[PATCH v2] rsi: Fix failure to load firmware after memory leak fix and fix the leak

2015-07-27 Thread Mike Looijmans
Fixes commit eae79b4f3e82 (rsi: fix memory leak in rsi_load_ta_instructions()) which stopped the driver from functioning. Firmware data has been allocated using vmalloc(), resulting in memory that cannot be used for DMA. Hence the firmware was first copied to a buffer allocated with kmalloc() in

Re: [net:master 41/49] drivers/net/ethernet/cadence/macb.c:164:1: error: macro writel passed 3 arguments, but takes just 2

2015-07-27 Thread Andy Shevchenko
On Mon, 2015-07-27 at 17:03 +0800, kbuild test robot wrote: tree: git://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git master head: 8fff755e9f8d0f70a595e79f248695ce6aef5cc3 commit: f2ce8a9e48385f444389e75cfe293637c3eb5410 [41/49] net/macb: improve big endian CPU support config:

[PATCH V3 net-next 3/3] ARM: net: add support for BPF_ANC | SKF_AD_HATYPE in ARM JIT.

2015-07-27 Thread Nicolas Schichan
Signed-off-by: Nicolas Schichan nschic...@freebox.fr --- arch/arm/net/bpf_jit_32.c | 22 -- arch/arm/net/bpf_jit_32.h | 3 +++ 2 files changed, 23 insertions(+), 2 deletions(-) diff --git a/arch/arm/net/bpf_jit_32.c b/arch/arm/net/bpf_jit_32.c index 3c73caf..876060b 100644

[PATCH V3 net-next 0/3] ARM BPF JIT features

2015-07-27 Thread Nicolas Schichan
Hello, This series adds support for more instructions to the ARM BPF JIT namely skb netdevice type retrieval, skb payload offset retrieval, and skb packet type retrieval. This allows 35 tests to use the JIT instead of 29 before. This series depends on the BPF JIT fixes for ARM serie sent

Re: [PATCH] MIPS: Remove most of the custom gpio.h

2015-07-27 Thread Linus Walleij
On Thu, Jul 23, 2015 at 8:25 PM, Lars-Peter Clausen l...@metafoo.de wrote: On 07/22/2015 07:33 PM, Alban Bedel wrote: diff --git a/arch/mips/jz4740/gpio.c b/arch/mips/jz4740/gpio.c index 54c80d4..3dc500c 100644 --- a/arch/mips/jz4740/gpio.c +++ b/arch/mips/jz4740/gpio.c @@ -262,18 +262,6 @@

Re: [RFC PATCH net] sctp: ASCONF-ACK with Unresolvable Address should be sent

2015-07-27 Thread Marcelo Ricardo Leitner
On Sat, Jul 25, 2015 at 01:08:08PM +0800, Xin Long wrote: RFC 5061: This is an opaque integer assigned by the sender to identify each request parameter. The receiver of the ASCONF Chunk will copy this 32-bit value into the ASCONF Response Correlation ID field of the

Re: Several races in usbnet module (kernel 4.1.x)

2015-07-27 Thread Oliver Neukum
On Fri, 2015-07-24 at 20:38 +0300, Eugene Shatokhin wrote: 21.07.2015 15:04, Oliver Neukum пишет: your analysis is correct and it looks like in addition to your proposed fix locking needs to be simplified and a common lock to be taken. Suggestions? Just an idea, I haven't tested it.

[PATCH V3 net-next 1/3] ARM: net: add support for BPF_ANC | SKF_AD_PKTTYPE in ARM JIT.

2015-07-27 Thread Nicolas Schichan
Signed-off-by: Nicolas Schichan nschic...@freebox.fr --- arch/arm/net/bpf_jit_32.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/arch/arm/net/bpf_jit_32.c b/arch/arm/net/bpf_jit_32.c index c011e22..6ff248c 100644 --- a/arch/arm/net/bpf_jit_32.c +++ b/arch/arm/net/bpf_jit_32.c

[PATCH V3 net-next 2/3] ARM: net: add support for BPF_ANC | SKF_AD_PAY_OFFSET in ARM JIT.

2015-07-27 Thread Nicolas Schichan
Signed-off-by: Nicolas Schichan nschic...@freebox.fr --- arch/arm/net/bpf_jit_32.c | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm/net/bpf_jit_32.c b/arch/arm/net/bpf_jit_32.c index 6ff248c..3c73caf 100644 --- a/arch/arm/net/bpf_jit_32.c +++ b/arch/arm/net/bpf_jit_32.c @@

Re: Several races in usbnet module (kernel 4.1.x)

2015-07-27 Thread Eugene Shatokhin
27.07.2015 15:29, Oliver Neukum пишет: On Fri, 2015-07-24 at 20:38 +0300, Eugene Shatokhin wrote: 21.07.2015 15:04, Oliver Neukum пишет: your analysis is correct and it looks like in addition to your proposed fix locking needs to be simplified and a common lock to be taken. Suggestions?

Re: [PATCH v2] ravb: minimize TX data copying

2015-07-27 Thread Sergei Shtylyov
On 7/27/2015 11:47 AM, David Laight wrote: Renesas Ethernet AVB controller requires that all data are aligned on 4-byte boundary. While it's easily achievable for the RX data with the help of skb_reserve() (we even align on 128-byte boundary as recommended by the manual), we can't do the

[net-next PATCH 2/2] drivers: net: cpsw: add separate napi for tx packet handling for performance improvment

2015-07-27 Thread Mugunthan V N
Instead of processing tx events in ISR itself, moving the tx event processing to a separate napi improves tx performance by 180 Mbps with omap2plus_defconfig. Also cleaning up rx napis by renaming to napi_rx for better understanding the code. Signed-off-by: Mugunthan V N mugunthan...@ti.com ---

[net-next PATCH 1/2] drivers: net: cpsw: remove disable_irq/enable_irq as irq can be masked from cpsw itself

2015-07-27 Thread Mugunthan V N
CPSW interrupts can be disabled by masking CPSW interrupts and clearing interrupt by writing appropriate EOI. So removing all disable_irq/enable_irq as discussed in [1] [1] http://patchwork.ozlabs.org/patch/492741/ Signed-off-by: Mugunthan V N mugunthan...@ti.com ---

[net-next PATCH 0/2] CPSW interrupt handling cleanup and performance improvement

2015-07-27 Thread Mugunthan V N
This patch series removes the irq controller disable interrupt and adding a napi for tx event handling which improves the performance by 180Mbps on dra7-evm [ 5] local 192.168.10.116 port 5001 connected with 192.168.10.125 port 44174 [ 5] 0.0-60.0 sec 1.46 GBytes 209 Mbits/sec [ 4] local

[PATCH net-next 4/4] net/mlx4_en: Add support for hardware accelerated 802.1ad vlan

2015-07-27 Thread Amir Vadai
From: Hadar Hen Zion had...@mellanox.com To enable device support in accelerated 802.1ad vlan, the port capability packet has vlan enable (phv_en) should be set. Firmware won't work properly, in case phv_en is not set. The user can enable phv_en port capability with the new ethtool private flag

[PATCH net-next 2/4] net/mlx4_en: Prepare ethtool private flags to support more flags

2015-07-27 Thread Amir Vadai
From: Hadar Hen Zion had...@mellanox.com Currently we support only one ethtool private flag. Prepare mlx4_en_set_priv_flags function to support more than one private flag. Will be used in the next patch to support hardware accelerated 802.1ad vlan. Signed-off-by: Hadar Hen Zion

[PATCH net-next 0/4] net/mlx4_en: Hardware accelerated 802.1ad

2015-07-27 Thread Amir Vadai
Hi, This patchset by Hadar introduces support in Hardware accelerated 802.1ad, for ConnectX-3pro NIC's. In order to support existing deployment, and due to some hardware limitations, the feature is disabled by default, and needed to be enabled using a private flag in ethtool. Ofcourse user can

[PATCH net-next 3/4] net/mlx4: Prepare VLAN macros for 802.1ad Hardware accelerated support

2015-07-27 Thread Amir Vadai
From: Hadar Hen Zion had...@mellanox.com To add Hardware accelerated support in 802.1ad vlan, replace Current VLAN macros to CVLAN. Replace: MLX4_WQE_CTRL_INS_VLAN MLX4_CQE_VLAN_PRESENT_MASK With: MLX4_WQE_CTRL_INS_CVLAN MLX4_CQE_CVLAN_PRESENT_MASK Signed-off-by: Hadar Hen Zion

[PATCH net-next 1/4] net/mlx4_core: Preparations for 802.1ad VLAN support

2015-07-27 Thread Amir Vadai
From: Hadar Hen Zion had...@mellanox.com mlx4_core preparation to support hardware accelerated 802.1ad VLAN device. To allow 802.1ad accelerated device, packet has vlan (phv) Firmware capability should be available. Firmware without the phv capability won't behave properly and can't support

[PATCH iproute2 net-next] bridge: mdb: add support for router add/del notifications monitoring

2015-07-27 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov niko...@cumulusnetworks.com This patch adds support for ADDMDB/DELMDB notifications about router ports which have been added or deleted/expired respectively. Example output: $ bridge -s monitor mdb Deleted router port dev eth3 master br0 router port dev eth3 master br0

Fwd: Need help about AR8327 Ethernet Driver

2015-07-27 Thread s prasad
Hi All, I am trying to sniff Ethernet data using AR8327 chip-set from other Ethernet device KSZ8895, which gives multiplexed TX and RX data of monitoring data of another device. If I am using devices like DUB-E100(D-Link), am able capture data from KSZ8895(Multiplexed TX and Rx Ethernet data).

Re: Several races in usbnet module (kernel 4.1.x)

2015-07-27 Thread Eugene Shatokhin
27.07.2015 13:00, Oliver Neukum пишет: On Fri, 2015-07-24 at 17:41 +0300, Eugene Shatokhin wrote: 23.07.2015 12:15, Oliver Neukum пишет: From what I see now in Documentation/atomic_ops.txt, stores to the properly aligned memory locations are in fact atomic. They are, but again only with

Need help about AR8327 Ethernet Driver

2015-07-27 Thread s prasad
Hi All, I am trying to sniff Ethernet data using AR8327 chip-set from other Ethernet device KSZ8895, which gives multiplexed TX and RX data of monitoring data of another device. If I am using devices like DUB-E100(D-Link), am able capture data from KSZ8895(Multiplexed TX and Rx Ethernet data).

Buggy cable detection on i.MX51, fec driver and LAN8700 PHY

2015-07-27 Thread Igor Plyatov
Dear all, very often we observe issue with Ethernet cable detection during cable unplugging and plugging. We use Voipac i.MX51 SOMs (System On Modules). They are based on Freescale i.MX51 CPU with LAN7800 PHY in MII mode. The schematic of PHY connection is very similar to the Freescale

netns refcnt leak for kernel accept sock

2015-07-27 Thread Sowmini Varadhan
I'm running into a netns refcnt issue, and I suspect that eeb1bd5c has something to do with it (perhaps we need an additional change in sk_clone_lock() after eeb1bd5c). Here's the problem: When we create an syn_recv sock based on a kernel listen sock, we take a get_net() ref with a stack

Re: linux-next: Tree for Jul 27 (net/mpls/af_mpls.c)

2015-07-27 Thread Randy Dunlap
On 07/26/15 23:02, Stephen Rothwell wrote: Hi all, Changes since 20150724: on i386 or x86_64: when CONFIG_IPV6 is not enabled: net/built-in.o: In function `find_outdev': af_mpls.c:(.text+0x1e8ddd): undefined reference to `ip6_route_output' af_mpls.c:(.text+0x1e8e90): undefined reference

RE: [PATCH net-next 1/1] Microchip's LAN7800 family USB 2/3 to 10/100/1000 Ethernet device driver

2015-07-27 Thread Woojung.Huh
Thanks for your review. I'll repost updated patch again. -Original Message- From: David Miller [mailto:da...@davemloft.net] Sent: Sunday, July 26, 2015 7:42 PM To: Woojung Huh - C21699 Cc: netdev@vger.kernel.org Subject: Re: [PATCH net-next 1/1] Microchip's LAN7800 family USB 2/3 to

Re: netns refcnt leak for kernel accept sock

2015-07-27 Thread Sowmini Varadhan
On (07/27/15 12:40), ebied...@xmission.com wrote: sock_create_kern and friends are specialied interfaces for special purposes. At a quick read through I don't think we have a single in tree user doing with them what you are trying to do. That doesnt change the fact that the architecture is

increase in time to delete an interface with 4.x kernels

2015-07-27 Thread David Ahern
Hi Alex: I believe you did the recent overhaul to the fib implementation. I am seeing dramatically higher times to delete an interface with an ipv4 address in 4.2-rc3. perf-top points to update_suffix: PerfTop: 15834 irqs/sec kernel:97.3% exact: 0.0% [4000Hz cpu-clock], (all, 4

Re: netns refcnt leak for kernel accept sock

2015-07-27 Thread Eric W. Biederman
sock_create_kern and friends are specialied interfaces for special purposes. At a quick read through I don't think we have a single in tree user doing with them what you are trying to do. Without seeing code using the interfaces in the way are trying to use them I do not have enough information

Re: netns refcnt leak for kernel accept sock

2015-07-27 Thread Sowmini Varadhan
On (07/27/15 11:13), Cong Wang wrote: That refcnt should be released in sock destructor too, when the tcp connection is terminated. yes, but in my case, the listen socket is opened as part of the -init indirection in pernet_operations (thus it is a kernel socket) and the expectation is that

Re: increase in time to delete an interface with 4.x kernels

2015-07-27 Thread Alexander Duyck
On 07/27/2015 09:49 AM, David Ahern wrote: Hi Alex: I believe you did the recent overhaul to the fib implementation. I am seeing dramatically higher times to delete an interface with an ipv4 address in 4.2-rc3. perf-top points to update_suffix: PerfTop: 15834 irqs/sec kernel:97.3%

Re: netns refcnt leak for kernel accept sock

2015-07-27 Thread Cong Wang
On Mon, Jul 27, 2015 at 7:21 AM, Sowmini Varadhan sowmini.varad...@oracle.com wrote: I'm running into a netns refcnt issue, and I suspect that eeb1bd5c has something to do with it (perhaps we need an additional change in sk_clone_lock() after eeb1bd5c). Here's the problem: When we create an

[PATCH net-next 06/16] net: Tx via VRF device

2015-07-27 Thread David Ahern
If out device is enslaved to a VRF device we want packets to go through the VRF master device first. This allows for example iptables rules and tc rules to be configured on the VRF as a whole as well as the option for rules on specific netdevices. This is accomplished by updating the dev in the

[PATCH net-next 14/16] net: Add sk_bind_dev_if to task_struct

2015-07-27 Thread David Ahern
Allow tasks to have a default device index for binding sockets. If set the value is passed to all AF_INET/AF_INET6 sockets when they are created. The task setting is passed parent to child on fork, but can be set or changed after task creation using prctl (if task has CAP_NET_ADMIN permissions).

[PATCH net-next 13/16] net: Introduce VRF device driver - v2

2015-07-27 Thread David Ahern
This driver borrows heavily from IPvlan and teaming drivers. Routing domains (VRF-lite) are created by instantiating a VRF master device with an associated table and enslaving all routed interfaces that participate in the domain. As part of the enslavement, all connected routes for the enslaved

[PATCH] iproute2: Add support for VRF device

2015-07-27 Thread David Ahern
Allow user to create a vrf device and specify its table binding. Based on the iplink_vlan implementation. Signed-off-by: Shrijeet Mukherjee s...@cumulusnetworks.com Signed-off-by: David Ahern d...@cumulusnetworks.com --- include/linux/if_link.h | 8 + ip/Makefile | 2 +-

[PATCH net-next 11/16] net: Use VRF device index for socket lookups

2015-07-27 Thread David Ahern
The intent of the VRF device is to leverage the existing SO_BINDTODEVICE as a means of creating L3 domains. Since sockets are expected to be bound to the VRF device the index of the master device needs to be used for socket lookups. Signed-off-by: Shrijeet Mukherjee s...@cumulusnetworks.com

[PATCH net-next 07/16] net: Add inet_addr lookup by table

2015-07-27 Thread David Ahern
Currently inet_addr_type and inet_dev_addr_type expect local addresses to be in the local table. With the VRF device local routes for devices associated with a VRF will be in the table associated with the VRF. Provide an alternate inet_addr lookup to use a specific table rather than defaulting to

[PATCH net-next 12/16] net: Add ipv4 route helper to set next hop

2015-07-27 Thread David Ahern
Signed-off-by: David Ahern d...@cumulusnetworks.com --- include/net/route.h | 3 +++ net/ipv4/route.c| 10 ++ 2 files changed, 13 insertions(+) diff --git a/include/net/route.h b/include/net/route.h index b14cbec93fbd..900d50fbcfc7 100644 --- a/include/net/route.h +++

[PATCH net-next 09/16] net: Add routes to the table associated with the device

2015-07-27 Thread David Ahern
When a device associated with a VRF is brought up or down routes should be added to/removed from the table associated with the VRF. fib_magic defaults to using the main or local tables. Have it use the table with the device if there is one. A part of this is directing prefsrc validations to the

[PATCH net-next 05/16] net: Use VRF device index for lookups on TX

2015-07-27 Thread David Ahern
As with ingress use the index of VRF master device for route lookups on egress. However, the oif should only be used to direct the lookups to a specific table. Routes in the table are not based on the VRF device but rather interfaces that are part of the VRF so do not consider the oif for lookups

Re: [PATCH net-next v2] route: allow to route in a peer netns via lwt framework

2015-07-27 Thread Nicolas Dichtel
Le 24/07/2015 17:39, Eric Dumazet a écrit : On Fri, 2015-07-24 at 16:16 +0200, Nicolas Dichtel wrote: This patch takes advantage of the newly added lwtunnel framework to allow the user to set routes that point to a peer netns. Packets are injected to the peer netns via the loopback device. It

Re: [PATCH net-next] route: allow to route in a peer netns via lwt framework

2015-07-27 Thread Nicolas Dichtel
Le 24/07/2015 17:19, David Ahern a écrit : In this case you are knowingly dropping packets. Would be nice to have a counter showing that. Ok. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: netns refcnt leak for kernel accept sock

2015-07-27 Thread Cong Wang
On Mon, Jul 27, 2015 at 11:19 AM, Sowmini Varadhan sowmini.varad...@oracle.com wrote: On (07/27/15 11:13), Cong Wang wrote: That refcnt should be released in sock destructor too, when the tcp connection is terminated. yes, but in my case, the listen socket is opened as part of the -init

Re: [RFC PATCH v4 net-next 1/4] tcp: replace cnt rtt with struct in pkts_acked()

2015-07-27 Thread Stephen Hemminger
On Fri, 24 Jul 2015 19:47:03 -0700 Lawrence Brakmo bra...@fb.com wrote: Replace 2 arguments (cnt and rtt) in the congestion control modules' pkts_acked() function with a struct. This will allow adding more information without having to modify existing congestion control modules (tcp_nv in

[net-next 0/16] Proposal for VRF-lite - v3

2015-07-27 Thread David Ahern
In the context of internet scale routing a requirement that always comes up is the need to partition the available routing tables into disjoint routing planes. A specific use case is the multi-tenancy problem where each tenant has their own unique routing tables and in the very least need

[PATCH net-next 08/16] net: Fix up inet_addr_type checks

2015-07-27 Thread David Ahern
Currently inet_addr_type and inet_dev_addr_type expect local addresses to be in the local table. With the VRF device local routes for devices associated with a VRF will be in the table associated with the VRF. Provide an alternate inet_addr lookup to use a specific table rather than defaulting to

[PATCH net-next 04/16] net: Use VRF device index for lookups on RX

2015-07-27 Thread David Ahern
On ingress use index of VRF master device for route lookups if real device is enslaved. Rules are expected to be installed for the VRF device to direct lookups to a specific table. Signed-off-by: Shrijeet Mukherjee s...@cumulusnetworks.com Signed-off-by: David Ahern d...@cumulusnetworks.com ---

[PATCH net-next 10/16] net: Use passed in table for nexthop lookups

2015-07-27 Thread David Ahern
If a user passes in a table for new routes use that table for nexthop lookups. Specifically, this solves the case where a connected route does not exist in the main table, but only another table and then a subsequent route is added with a next hop using the connected route. ie., $ ip route ls

[PATCH net-next 01/16] net: Refactor rtable allocation and initialization

2015-07-27 Thread David Ahern
All callers to rt_dst_alloc have nearly the same initialization following a successful allocation. Consolidate it into ip_route_new_rtable. Signed-off-by: David Ahern d...@cumulusnetworks.com --- include/net/route.h | 3 ++ net/ipv4/route.c| 111

Re: netns refcnt leak for kernel accept sock

2015-07-27 Thread Sowmini Varadhan
On (07/27/15 11:37), Cong Wang wrote: dlm uses a kernel TCP socket too, but it allocates a new socket and calls -accept() by itself. ;) sure, and rds does this in rds_tcp_accept_one() too. But the newsk being created in sk_clone_lock is the one on an incoming syn, i.e., the one that is

Re: [PATCH net-next 3/3] openvswitch: 802.1AD: Flow handling, actions, vlan parsing and netlink attributes

2015-07-27 Thread Pravin Shelar
On Sun, Jul 26, 2015 at 7:52 AM, Thomas F Herbert thomasfherb...@gmail.com wrote: Add support for 802.1ad including the ability to push and pop double tagged vlans. Add support for 802.1ad to netlink parsing and flow conversion. Uses double nested encap attributes to represent double tagged

Re: [RFC PATCH v4 net-next 1/4] tcp: replace cnt rtt with struct in pkts_acked()

2015-07-27 Thread Lawrence Brakmo
On 7/27/15, 11:46 AM, Stephen Hemminger step...@networkplumber.org wrote: On Fri, 24 Jul 2015 19:47:03 -0700 Lawrence Brakmo bra...@fb.com wrote: Replace 2 arguments (cnt and rtt) in the congestion control modules' pkts_acked() function with a struct. This will allow adding more information

Re: [PATCH net-next 13/16] net: Introduce VRF device driver - v2

2015-07-27 Thread Nikolay Aleksandrov
On 07/27/2015 08:31 PM, David Ahern wrote: This driver borrows heavily from IPvlan and teaming drivers. Routing domains (VRF-lite) are created by instantiating a VRF master device with an associated table and enslaving all routed interfaces that participate in the domain. As part of the

[net PATCH] fib_trie: Drop unnecessary calls to leaf_pull_suffix

2015-07-27 Thread Alexander Duyck
It was reported that update_suffix was taking a long time on systems where a large number of leaves were attached to a single node. As it turns out fib_table_flush was calling update_suffix for each leaf that didn't have all of the aliases stripped from it. As a result, on this large node

Re: [PATCH 8/8] can: replace timestamp as unique skb attribute

2015-07-27 Thread Oliver Hartkopp
Hello Greg, On 12.07.2015 21:18, Marc Kleine-Budde wrote: From: Oliver Hartkopp socket...@hartkopp.net Commit 514ac99c64b can: fix multiple delivery of a single CAN frame for overlapping CAN filters requires the skb-tstamp to be set to check for identical CAN skbs. Without timestamping to be

Re: [PATCH 02/10] dpaa_eth: add support for DPAA Ethernet

2015-07-27 Thread Scott Wood
On Fri, 2015-07-24 at 10:45 -0500, Bucur Madalin-Cristian-B32716 wrote: -Original Message- From: Joe Perches [mailto:j...@perches.com] On Wed, 2015-07-22 at 19:16 +0300, Madalin Bucur wrote: +static int __init dpa_load(void) +{ [] + err =

Re: kernel warning in tcp_fragment

2015-07-27 Thread Jovi Zhangwei
ping... On Wed, Jul 22, 2015 at 11:55 AM, Jovi Zhangwei j...@cloudflare.com wrote: Hi Neal and Martin, Sorry for disturbing, our production system(3.14 and 3.18 stable kernel) have many tcp_fragment warnings, the trace is same as below one which you discussed before.

[PATCH net-next 1/1] Microchip's LAN7800 family USB 2/3 to 10/100/1000 Ethernet device driver

2015-07-27 Thread Woojung.Huh
This patch adds a driver for LAN7800 family of USB 2.0 USB 3.0 to Gigabit Ethernet. - remove module param which can be configurable by standard mechanism. - remove other module parms except msg_level per review comment. Signed-off-by: Woojung Huh woojung@microchip.com ---

[PATCH net-next 02/16] net: export a few FIB functions

2015-07-27 Thread David Ahern
Required by the VRF driver. Signed-off-by: Shrijeet Mukherjee s...@cumulusnetworks.com Signed-off-by: David Ahern d...@cumulusnetworks.com --- net/ipv4/fib_frontend.c | 2 ++ net/ipv4/fib_trie.c | 1 + 2 files changed, 3 insertions(+) diff --git a/net/ipv4/fib_frontend.c

[PATCH net-next 03/16] net: Introduce VRF related flags and helpers

2015-07-27 Thread David Ahern
Add a VRF_MASTER flag for interfaces and helper functions for determining if a device is a VRF_MASTER. Add link attribute for passing VRF_TABLE id. Add vrf_ptr to netdevice. Add various macros for determining if a device is a VRF device, the index of the master VRF device and table associated

[PATCH net-next 15/16] net: Add chvrf command

2015-07-27 Thread David Ahern
Example of how to use the default bind to interface option for tasks and correlate with VRF devices. Signed-off-by: David Ahern d...@cumulusnetworks.com --- tools/net/Makefile | 6 +- tools/net/chvrf.c | 225 + 2 files changed, 229

Re: [RFC PATCH 0/4] Shared vhost design

2015-07-27 Thread Bandan Das
Eyal Moscovici eya...@il.ibm.com writes: Hi, The test showed the same relative numbers as we got in our internal testing. I was wondering about the configuration in regards to NUMA. From Thanks for confirming. our testing we saw that if the VMs are spread across 2 NUMA nodes then having

Re: [PATCH iproute2] ip: replace white-spaces with tabs

2015-07-27 Thread Stephen Hemminger
On Sat, 25 Jul 2015 08:54:53 -0400 Zhang Shengju zhangshen...@cmss.chinamobile.com wrote: Replace white-spaces with tabs Signed-off-by: Zhang Shengju zhangshen...@cmss.chinamobile.com --- ip/ip.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) There were more places that

Re: [PATCH 1/2] iproute2: Add support for IPv6 VTI tunnels to ip6tunnel

2015-07-27 Thread Stephen Hemminger
On Thu, 2 Oct 2014 11:11:40 +0200 Jiri Pirko j...@resnulli.us wrote: Thu, Oct 02, 2014 at 10:48:20AM CEST, steffen.klass...@secunet.com wrote: On Thu, Oct 02, 2014 at 10:41:09AM +0200, Jiri Pirko wrote: Fri, Sep 26, 2014 at 09:10:56AM CEST, steffen.klass...@secunet.com wrote: @@ -459,11

Re: [patch net-next 0/4] Introduce Mellanox Technologies Switch ASICs switchdev drivers

2015-07-27 Thread Scott Feldman
On Thu, Jul 23, 2015 at 8:43 AM, Jiri Pirko j...@resnulli.us wrote: This patchset introduces Mellanox Technologies Switch driver infrastructure and support for SwitchX-2 ASIC. You guys did a great job on the driver; looking forward to seeing L2/L3 hooked up. Very nice, aesthetically pleasing

Re: [patch net-next 0/4] Introduce Mellanox Technologies Switch ASICs switchdev drivers

2015-07-27 Thread Jiri Pirko
Mon, Jul 27, 2015 at 10:21:54PM CEST, sfel...@gmail.com wrote: On Thu, Jul 23, 2015 at 8:43 AM, Jiri Pirko j...@resnulli.us wrote: This patchset introduces Mellanox Technologies Switch driver infrastructure and support for SwitchX-2 ASIC. You guys did a great job on the driver; looking forward

Re: [net:master 41/49] drivers/net/ethernet/cadence/macb.c:164:1: error: macro writel passed 3 arguments, but takes just 2

2015-07-27 Thread David Miller
From: Andy Shevchenko andriy.shevche...@linux.intel.com Date: Mon, 27 Jul 2015 14:07:53 +0300 I do use compiler from Debian for AVR32, didn't check this on other architectures. Possible something like following will fix it: That isn't going to fix it. You misunderstand the nature of the

Re: [patch net-next 0/4] Introduce Mellanox Technologies Switch ASICs switchdev drivers

2015-07-27 Thread Florian Fainelli
On 27/07/15 13:27, Jiri Pirko wrote: Mon, Jul 27, 2015 at 10:21:54PM CEST, sfel...@gmail.com wrote: On Thu, Jul 23, 2015 at 8:43 AM, Jiri Pirko j...@resnulli.us wrote: This patchset introduces Mellanox Technologies Switch driver infrastructure and support for SwitchX-2 ASIC. You guys did a

Re: [PATCH iproute2] tc: fix bpf compilation with old glibc

2015-07-27 Thread Stephen Hemminger
On Wed, 22 Jul 2015 14:29:30 +0200 Nicolas Dichtel nicolas.dich...@6wind.com wrote: Error was: f_bpf.o: In function `bpf_parse_opt': f_bpf.c:(.text+0x88f): undefined reference to `secure_getenv' m_bpf.o: In function `parse_bpf': m_bpf.c:(.text+0x587): undefined reference to `secure_getenv'

Re: [net-next 0/16] Proposal for VRF-lite - v3

2015-07-27 Thread Eric W. Biederman
David Ahern d...@cumulusnetworks.com writes: In the context of internet scale routing a requirement that always comes up is the need to partition the available routing tables into disjoint routing planes. A specific use case is the multi-tenancy problem where each tenant has their own unique

Re: [PATCH net-next 14/16] net: Add sk_bind_dev_if to task_struct

2015-07-27 Thread Eric W. Biederman
David Ahern d...@cumulusnetworks.com writes: Allow tasks to have a default device index for binding sockets. If set the value is passed to all AF_INET/AF_INET6 sockets when they are created. The task setting is passed parent to child on fork, but can be set or changed after task creation

Re: [PATCH iproute2 net-next] bridge: mdb: add support for router add/del notifications monitoring

2015-07-27 Thread Stephen Hemminger
On Mon, 27 Jul 2015 13:44:05 +0200 Nikolay Aleksandrov ra...@blackwall.org wrote: From: Nikolay Aleksandrov niko...@cumulusnetworks.com This patch adds support for ADDMDB/DELMDB notifications about router ports which have been added or deleted/expired respectively. Example output: $

Re: [PATCH net-next]r8169: Correct values on dma_alloc_coherent

2015-07-27 Thread Francois Romieu
Corcodel Marian corcodel.mar...@gmail.com : [...] diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c index 3df51fa..fd249a6 100644 --- a/drivers/net/ethernet/realtek/r8169.c +++ b/drivers/net/ethernet/realtek/r8169.c @@ -6724,8 +6724,8 @@ static int

Re: [net-next PATCH 2/2] drivers: net: cpsw: add separate napi for tx packet handling for performance improvment

2015-07-27 Thread Francois Romieu
Mugunthan V N mugunthan...@ti.com : [...] diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c index d68d759..4f98537 100644 --- a/drivers/net/ethernet/ti/cpsw.c +++ b/drivers/net/ethernet/ti/cpsw.c @@ -752,13 +753,22 @@ static irqreturn_t cpsw_tx_interrupt(int irq,

Re: Fw: [Bug 102051] New: Unexpected TCP behavior

2015-07-27 Thread Eric Dumazet
On Mon, 2015-07-27 at 14:02 -0700, Stephen Hemminger wrote: Begin forwarded message: Date: Mon, 27 Jul 2015 20:06:07 + From: bugzilla-dae...@bugzilla.kernel.org bugzilla-dae...@bugzilla.kernel.org To: shemmin...@linux-foundation.org shemmin...@linux-foundation.org Subject: [Bug

Re: [PATCH iproute2 net-next] bridge: mdb: add support for router add/del notifications monitoring

2015-07-27 Thread Nikolay Aleksandrov
On 27 Jul 2015, at 23:40, Stephen Hemminger step...@networkplumber.org wrote: On Mon, 27 Jul 2015 13:44:05 +0200 Nikolay Aleksandrov ra...@blackwall.org wrote: From: Nikolay Aleksandrov niko...@cumulusnetworks.com This patch adds support for ADDMDB/DELMDB notifications about router

Re: [net PATCH] fib_trie: Drop unnecessary calls to leaf_pull_suffix

2015-07-27 Thread David Miller
From: Alexander Duyck alexander.h.du...@redhat.com Date: Mon, 27 Jul 2015 13:08:06 -0700 It was reported that update_suffix was taking a long time on systems where a large number of leaves were attached to a single node. As it turns out fib_table_flush was calling update_suffix for each leaf

Re: [net PATCH] fib_trie: Drop unnecessary calls to leaf_pull_suffix

2015-07-27 Thread David Ahern
On 7/27/15 2:08 PM, Alexander Duyck wrote: It was reported that update_suffix was taking a long time on systems where a large number of leaves were attached to a single node. As it turns out fib_table_flush was calling update_suffix for each leaf that didn't have all of the aliases stripped

Re: [RFC PATCH 0/4] Shared vhost design

2015-07-27 Thread Michael S. Tsirkin
On Mon, Jul 13, 2015 at 12:07:31AM -0400, Bandan Das wrote: Hello, There have been discussions on improving the current vhost design. The first attempt, to my knowledge was Shirley Ma's patch to create a dedicated vhost worker per cgroup.

Fw: [Bug 102051] New: Unexpected TCP behavior

2015-07-27 Thread Stephen Hemminger
Begin forwarded message: Date: Mon, 27 Jul 2015 20:06:07 + From: bugzilla-dae...@bugzilla.kernel.org bugzilla-dae...@bugzilla.kernel.org To: shemmin...@linux-foundation.org shemmin...@linux-foundation.org Subject: [Bug 102051] New: Unexpected TCP behavior

Re: [RFC PATCH 0/4] Shared vhost design

2015-07-27 Thread Michael S. Tsirkin
On Mon, Jul 27, 2015 at 03:48:19PM -0400, Bandan Das wrote: Eyal Moscovici eya...@il.ibm.com writes: Hi, The test showed the same relative numbers as we got in our internal testing. I was wondering about the configuration in regards to NUMA. From Thanks for confirming. our

Re: [RFC PATCH 4/4] vhost: Add cgroup-aware creation of worker threads

2015-07-27 Thread Michael S. Tsirkin
On Mon, Jul 13, 2015 at 12:07:35AM -0400, Bandan Das wrote: With the help of the cgroup function to compare groups introduced in the previous patch, this changes worker creation policy. If the new device belongs to different cgroups than any of the devices we are currently serving, we end up

Re: [PATCH iproute2] xfrm: remove duplicated include

2015-07-27 Thread Stephen Hemminger
On Sat, 25 Jul 2015 04:44:24 -0400 Zhang Shengju zhangshen...@cmss.chinamobile.com wrote: Remove dupldated include for linux/xfrm.h, since it's already included by 'xfrm.h'. Signed-off-by: Zhang Shengju zhangshen...@cmss.chinamobile.com Applied, thanks -- To unsubscribe from this list:

Re: [PATCH] phylib: add driver for aquantia phy

2015-07-27 Thread Florian Fainelli
On 27/07/15 01:30, Shaohui Xie wrote: -Original Message- From: Florian Fainelli [mailto:f.faine...@gmail.com] Sent: Friday, July 24, 2015 12:39 PM To: shh@gmail.com; netdev@vger.kernel.org; da...@davemloft.net Cc: Xie Shaohui-B21989 Subject: Re: [PATCH] phylib: add driver for

ip6t_SYNPROXY crashes kernel

2015-07-27 Thread Phil Sutter
Hi, When synproxy_send_server_ack() calls synproxy_send_tcp(), it passes NULL as third parameter (struct nf_conntrack *nfct). And the first thing synproxy_send_tcp() does, is dereference it: | struct net *net = nf_ct_net((struct nf_conn *)nfct); I could not find a commit leading to this

Re: [PATCH V3 net-next 0/3] ARM BPF JIT features

2015-07-27 Thread David Miller
From: Nicolas Schichan nschic...@freebox.fr Date: Mon, 27 Jul 2015 15:06:48 +0200 This series adds support for more instructions to the ARM BPF JIT namely skb netdevice type retrieval, skb payload offset retrieval, and skb packet type retrieval. This allows 35 tests to use the JIT instead

Re: [PATCH net-next 0/4] net/mlx4_en: Hardware accelerated 802.1ad

2015-07-27 Thread David Miller
From: Amir Vadai am...@mellanox.com Date: Mon, 27 Jul 2015 14:46:30 +0300 This patchset by Hadar introduces support in Hardware accelerated 802.1ad, for ConnectX-3pro NIC's. In order to support existing deployment, and due to some hardware limitations, the feature is disabled by default, and

[PATCH 2/2] ixgbe: Teardown SR-IOV before unregister_netdev()

2015-07-27 Thread Alex Williamson
When the .remove() callback for a PF is called, SR-IOV support for the device is disabled, which requires unbinding and removing the VFs. The VFs may be in-use either by the host kernel or userspace, such as assigned to a VM through vfio-pci. In this latter case, the VFs may be removed either by

RE: [Intel-wired-lan] [PATCH 2/2] ixgbe: Teardown SR-IOV before unregister_netdev()

2015-07-27 Thread Williams, Mitch A
ACK -Original Message- From: Intel-wired-lan [mailto:intel-wired-lan-boun...@lists.osuosl.org] On Behalf Of Alex Williamson Sent: Monday, July 27, 2015 4:19 PM To: intel-wired-...@lists.osuosl.org; Kirsher, Jeffrey T Cc: netdev@vger.kernel.org; linux-ker...@vger.kernel.org Subject:

RE: [Intel-wired-lan] [PATCH 1/2] igb: Teardown SR-IOV before unregister_netdev()

2015-07-27 Thread Williams, Mitch A
ACK -Original Message- From: Intel-wired-lan [mailto:intel-wired-lan-boun...@lists.osuosl.org] On Behalf Of Alex Williamson Sent: Monday, July 27, 2015 4:19 PM To: intel-wired-...@lists.osuosl.org; Kirsher, Jeffrey T Cc: netdev@vger.kernel.org; linux-ker...@vger.kernel.org Subject:

Re: [PATCH] packet: Allow packets with only a header (but no payload)

2015-07-27 Thread Martin Blumenstingl
Hi Johann, On Tue, Jul 21, 2015 at 6:51 PM, Willem de Bruijn will...@google.com wrote: I don't see a simple way of verifying the safety of allowing packets without data short of a code audit, which would be huge, especially when taking device driver logic into account. Perhaps someone

[patch -master] netfilter: xt_CT: checking for IS_ERR() instead of NULL

2015-07-27 Thread Dan Carpenter
We recently changed this from nf_conntrack_alloc() to nf_ct_tmpl_alloc() so the error handling needs to changed to check for NULL instead of IS_ERR(). Fixes: 0838aa7fcfcd ('netfilter: fix netns dependencies with conntrack templates') Signed-off-by: Dan Carpenter dan.carpen...@oracle.com diff

Re: kernel warning in tcp_fragment

2015-07-27 Thread Martin KaFai Lau
On Wed, Jul 22, 2015 at 11:55:35AM -0700, Jovi Zhangwei wrote: Sorry for disturbing, our production system(3.14 and 3.18 stable kernel) have many tcp_fragment warnings, the trace is same as below one which you discussed before.

[patch] packet: missing dev_put() in packet_do_bind()

2015-07-27 Thread Dan Carpenter
From: Lars Westerhoff lars.westerh...@newtec.eu When binding a PF_PACKET socket, the use count of the bound interface is always increased with dev_hold in dev_get_by_{index,name}. However, when rebound with the same protocol and device as in the previous bind the use count of the interface was

[PATCH] netfilter: ipt_SYNPROXY: fix sending window update to client

2015-07-27 Thread Phil Sutter
Upon receipt of SYNACK from the server, ipt_SYNPROXY first sends back an ACK to finish the server handshake, then calls nf_ct_seqadj_init() to initiate sequence number adjustment of forwarded packets to the client and finally sends a window update to the client to unblock it's TX queue. Since

Re: [PATCH net v3] macvtap: fix network header pointer for VLAN tagged pkts

2015-07-27 Thread David Miller
From: Ivan Vecera ivec...@redhat.com Date: Thu, 23 Jul 2015 16:37:43 +0200 Network header is set with offset ETH_HLEN but it is not true for VLAN (multiple-)tagged and results in checksum issues in lower devices. v2: leave skb-protocol untouched (thx Vlad), comment added v3: moved after

[PATCH 0/2] igb/ixgbe: Fix ordering of SR-IOV teardown

2015-07-27 Thread Alex Williamson
When running a Windows 2012 R2 guest with a pair of VFs assigned through vfio-pci, we run into a problem trying to hot-unplug those VFs after the PF has unregistered the netdev. This is a common scenario if the PF is unbound from the driver while VFs are active. In the case of igb, the resulting

Re: [PATCH net-next v2 1/2] ipv6: Re-arrange code in rt6_probe()

2015-07-27 Thread YOSHIFUJI Hideaki/吉藤英明
Martin KaFai Lau wrote: It is a prep work for the next patch to remove write_lock from rt6_probe(). 1. Reduce the number of if(neigh) check. From 4 to 1. 2. Bring the write_(un)lock() closer to the operations that the lock is protecting. Hopefully, the above make rt6_probe() more

  1   2   >