Re: [PATCH for-next V7 00/10] Move RoCE GID management to IB/Core

2015-07-31 Thread Doug Ledford
On 07/31/2015 04:18 PM, Jason Gunthorpe wrote: On Fri, Jul 31, 2015 at 01:41:39PM -0400, Doug Ledford wrote: Please be more specific here. What are you objecting to? Are you objecting to a flush_workqueue from a release() context? Because I don't see anything in the kref documentation or

[Patch net] fq_codel: explicitly reset flows in -reset()

2015-07-31 Thread Cong Wang
From: Eric Dumazet eric.duma...@gmail.com Alex reported the following crash when using fq_codel with htb: crash bt PID: 630839 TASK: 8823c990d280 CPU: 14 COMMAND: tc [... snip ...] #8 [8820ceec17a0] page_fault at 8160a8c2 [exception RIP: htb_qlen_notify+24]

Re: [PATCH] ip: Preserve original portocol family in batch mode

2015-07-31 Thread Stephen Hemminger
On Fri, 31 Jul 2015 13:55:31 +0300 Antti Paila antti.pa...@gmail.com wrote: From: Antti Paila antti.pa...@gmail.com Reset the 'preferred_family' global variable to its initially set value before each batch file command is processed. Signed-off-by: Antti Paila antti.pa...@gmail.com

Re: [PATCH iproute2 v2] bridge fdb: add 'use' option to set NTF_USE flag in fdb add requests

2015-07-31 Thread Stephen Hemminger
On Thu, 30 Jul 2015 14:37:02 -0700 Roopa Prabhu ro...@cumulusnetworks.com wrote: From: Roopa Prabhu ro...@cumulusnetworks.com This is similar to command options corresponding to other NTF_* flags already exposed to the user space (examples self/master). Also updates bridge man page (The

Re: [PATCH v2 net-next 0/5] ipv6: Turn on auto IPv6 flow labels by default

2015-07-31 Thread David Miller
From: Tom Herbert t...@herbertland.com Date: Fri, 31 Jul 2015 16:52:09 -0700 BSD (MacOS) has already turned on flow labels by default and this does not seem to be causing any problems in the Internet. Let's go ahead and turn them on by default. We'll continue to monitor for any devices start

Re: [PATCH] net: switchdev: restrict vid range abstraction

2015-07-31 Thread Vivien Didelot
Hi Scott, On Jul 29, 2015, at 5:17 PM, Scott Feldman sfel...@gmail.com wrote: On Wed, Jul 29, 2015 at 12:14 PM, Vivien Didelot vivien.dide...@savoirfairelinux.com wrote: Hi Scott, David, On Jul 29, 2015, at 2:28 PM, David da...@davemloft.net wrote: From: Scott Feldman sfel...@gmail.com

Re: [PATCH iproute2 net-next] bridge: mdb: add deleted when monitoring delmdb event

2015-07-31 Thread Stephen Hemminger
On Thu, 30 Jul 2015 11:30:32 +0200 Nikolay Aleksandrov ra...@blackwall.org wrote: From: Nikolay Aleksandrov niko...@cumulusnetworks.com Before this patch both addmdb and delmdb events were printed the same, now we'll get a Deleted string in front when delmdb is received. Before: $ bridge

Re: [PATCH net-next 5/9] openvswitch: Add conntrack action

2015-07-31 Thread Pravin Shelar
On Thu, Jul 30, 2015 at 11:12 AM, Joe Stringer joestrin...@nicira.com wrote: Expose the kernel connection tracker via OVS. Userspace components can make use of the ct() action, followed by recirculate, to populate the conntracking state in the OVS flow key, and subsequently match on that

Re: Null pointer dereference in UDP4 core on AVR32 ATNGW100

2015-07-31 Thread Eric Dumazet
ethernet cards supported by macb driver. Bring it mostly back to work with recent kernel from linux-next. Now, when I start networking on it, I got in few seconds kernel panic. Seems the hack fixes this (still playing with network connected). # uname -a Linux buildroot 4.2.0-rc4-next-20150731+ #164

Re: [REGRESSION] stmmac_platform: Unknown symbol devm_kmalloc (err 0)

2015-07-31 Thread Joachim Eastwood
Hi Igor, On 31 July 2015 at 01:07, Igor Gnatenko i.gnatenko.br...@gmail.com wrote: Hi all, stmmac driver doesn't work on cubietruck (and some more devices like PcDuino3 Nano[0]). This error comes from converting dwmac-sunxi to platform driver. stmmac_platform: module license 'unspecified'

Re: [PATCH net-next 1/9] openvswitch: Scrub packet in ovs_vport_receive()

2015-07-31 Thread Hannes Frederic Sowa
On Thu, 2015-07-30 at 11:12 -0700, Joe Stringer wrote: Signed-off-by: Joe Stringer joestrin...@nicira.com --- net/openvswitch/vport.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/openvswitch/vport.c b/net/openvswitch/vport.c index d14f594..baa018f 100644 ---

pull-request: wireless-drivers-next 2015-07-31

2015-07-31 Thread Kalle Valo
Hi Dave, here's a pull request for 4.3. In this pull request there's I have one revert in commit 360d9bb5ee2d (Revert ath9k: export HW random number generator), the data doesn't seem to be random enough. Please let me know if you have any problems. Kalle The following changes since commit

Re: [PATCH net-next 8/9] openvswitch: Allow matching on conntrack label

2015-07-31 Thread Florian Westphal
Joe Stringer joestrin...@nicira.com wrote: Allow matching and setting the conntrack label field. As with ct_mark, this is populated by executing the ct() action, and is a writable field. The set_field() action may be used to modify the label, which will take effect on the most recent conntrack

[PATCH net-next] bonding: add tlb_dynamic_lb netlink support

2015-07-31 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov niko...@cumulusnetworks.com tlb_dynamic_lb could be set only via sysfs, this patch allows it to be set via netlink. Signed-off-by: Nikolay Aleksandrov niko...@cumulusnetworks.com --- As usual if accepted I'll post the corresponding iproute2 patch that adds support for

Re: [PATCH net-next 5/9] openvswitch: Add conntrack action

2015-07-31 Thread Hannes Frederic Sowa
Hi, On Thu, 2015-07-30 at 11:12 -0700, Joe Stringer wrote: diff --git a/net/openvswitch/actions.c b/net/openvswitch/actions.c index e50678d..4a62ed4 100644 --- a/net/openvswitch/actions.c +++ b/net/openvswitch/actions.c @@ -22,6 +22,7 @@ #include linux/in.h #include linux/ip.h #include

RE: [ovs-dev] [PATCH net-next 3/3] openvswitch: 802.1AD: Flow handling, actions, vlan parsing and netlink attributes

2015-07-31 Thread ravulakollu.kumar
Hi Thomas, I have applied your below mentioned 1ad patch to ovs-master code. Compiled successfully. I am running ovs in a centos machine. I have created bridge and configured ports using below commands. ovs-vsctl --no-wait add-br br0 ovs-vsctl --no-wait add-port br0 eth0 tag=100

Re: [PATCH v2] net/phy: micrel: Reenable interrupts during resume

2015-07-31 Thread Nathan Sullivan
On Fri, Jul 31, 2015 at 12:22:04AM -0700, David Miller wrote: From: Nathan Sullivan nathan.sulli...@ni.com Date: Thu, 30 Jul 2015 18:09:05 -0500 On Thu, Jul 30, 2015 at 10:00:34AM -0700, David Miller wrote: From: Nathan Sullivan nathan.sulli...@ni.com Date: Thu, 30 Jul 2015 10:15:48

am335x: cpsw at high broadcast load

2015-07-31 Thread Yegor Yefremov
We experience massive problems, when putting am335x based devices into high broadcast load environment (customer reports). To reproduce the issue we've written following Python script #!/usr/bin/python # Send UDP broadcast packets myport = 5 import sys, time from socket import * if

Re: [PATCH for-next V7 00/10] Move RoCE GID management to IB/Core

2015-07-31 Thread Doug Ledford
On 07/31/2015 05:40 AM, Or Gerlitz wrote: On Thu, Jul 30, 2015 at 6:33 PM, Matan Barak mat...@mellanox.com wrote: [...] Changes from V6: (1) Addressed Jason's comments: (a) Cache is no longer a client but part of IB infrastructure (b) No need for READ_ONCE and

Null pointer dereference in UDP4 core on AVR32 ATNGW100

2015-07-31 Thread Andy Shevchenko
Hi! Got few weeks ago an old AVR32 board (ATNGW100). It has ethernet cards supported by macb driver. Bring it mostly back to work with recent kernel from linux-next. Now, when I start networking on it, I got in few seconds kernel panic. Unable to handle kernel NULL pointer dereference at

Re: Null pointer dereference in UDP4 core on AVR32 ATNGW100

2015-07-31 Thread Andy Shevchenko
in few seconds kernel panic. Seems the hack fixes this (still playing with network connected). # uname -a Linux buildroot 4.2.0-rc4-next-20150731+ #164 Fri Jul 31 16:37:20 EEST 2015 avr32 GNU/Linux --- a/net/ipv4/udp.c +++ b/net/ipv4/udp.c @@ -1665,6 +1665,10 @@ static int

Re: [PATCH 08/15] drivers: net: Drop unlikely before IS_ERR(_OR_NULL)

2015-07-31 Thread Viresh Kumar
On 31-07-15, 11:04, Murali Karicheri wrote: On 07/31/2015 04:38 AM, Viresh Kumar wrote: IS_ERR(_OR_NULL) already contain an 'unlikely' compiler flag and there is no need to do that again from its callers. Drop it. IS_ERR_OR_NULL() is defined as static inline bool __must_check

Re: [ovs-dev] [PATCH net-next 3/3] openvswitch: 802.1AD: Flow handling, actions, vlan parsing and netlink attributes

2015-07-31 Thread Thomas F Herbert
On 7/31/15 5:34 AM, ravulakollu.ku...@wipro.com wrote: Hi Thomas, I have applied your below mentioned 1ad patch to ovs-master code. Compiled successfully. I am running ovs in a centos machine. I have created bridge and configured ports using below commands. ovs-vsctl --no-wait add-br br0

[PATCH net 1/3] gianfar: Fix warning when CONFIG_PM off

2015-07-31 Thread Claudiu Manoil
CC drivers/net/ethernet/freescale/gianfar.o drivers/net/ethernet/freescale/gianfar.c:568:13: warning: 'lock_tx_qs' defined but not used [-Wunused-function] static void lock_tx_qs(struct gfar_private *priv) ^ drivers/net/ethernet/freescale/gianfar.c:576:13: warning:

[PATCH net 2/3] gianfar: Fix suspend/resume for wol magic packet

2015-07-31 Thread Claudiu Manoil
If we disable NAPI in the first place we can mask the device's interrupts (and halt it) without fearing that imask may be concurrently accessed from interrupt context, so there's no need to do local_irq_save() around gfar_halt_nodisable(). lock_rx_qs()/unlock_tx_qs() are just obsoleted and

[PATCH net 3/3] gianfar: Enable device wakeup when appropriate

2015-07-31 Thread Claudiu Manoil
The wol_en flag is 0 by default anyway, and we have the following inconsistency: a MAGIC packet wol capable eth interface is registered as a wake-up source but unable to wake-up the system as wol_en is 0 (wake-on flag set to 'd'). Calling set_wakeup_enable() at netdev open is just redundant

[PATCH net 0/3] gianfar: wol magic packet fixes

2015-07-31 Thread Claudiu Manoil
These changes were already validated as part of FSL SDK. Patch 2 fixes occasional wake-on magic packet failures during traffic, probably due to incorrect traffic stop/ device halt sequence and incorrect usage of txlock. Claudiu Manoil (3): gianfar: Fix warning when CONFIG_PM off gianfar: Fix

[PATCH net-next] virtio_net: add gro capability

2015-07-31 Thread Eric Dumazet
From: Eric Dumazet eduma...@google.com Straightforward patch to add GRO processing to virtio_net. napi_complete_done() usage allows more aggressive aggregation, opted-in by setting /sys/class/net/xxx/gro_flush_timeout Tested: Setting /sys/class/net/xxx/gro_flush_timeout to 1000 nsec, Rick

Re: [PATCH v5 1/4] bpf: Make the bpf_prog_array_map more generic

2015-07-31 Thread Alexei Starovoitov
On 7/31/15 4:59 AM, Kaixu Xia wrote: According to the comments from Daniel, rewrite part of the bpf_prog_array map code and make it more generic. So the new perf_event_array map type can reuse most of code with bpf_prog_array map and add fewer lines of special code. Tested the

Re: [PATCH for-next V7 00/10] Move RoCE GID management to IB/Core

2015-07-31 Thread Jason Gunthorpe
On Fri, Jul 31, 2015 at 08:50:24AM -0400, Doug Ledford wrote: So... are we ready to go with V7 upstream? Yes. I've already pulled it in. You are taking the netdev stuff without an ack from netdev?? I've been too busy too look at v7, but a quick check of the 'move the cache into core code

Re: [PATCH v5 0/4] bpf: Introduce the new ability of eBPF programs to access hardware PMU counter

2015-07-31 Thread Alexei Starovoitov
On 7/31/15 4:59 AM, Kaixu Xia wrote: changes in V5: - move struct fd_array_map_ops* fd_ops to bpf_map; - move array perf event decrement refcnt function to map_free; - fix the NULL ptr of perf_event_get(); - move bpf_perf_event_read() to kernel/bpf/bpf_trace.c; - get rid of the

Re: [REGRESSION] stmmac_platform: Unknown symbol devm_kmalloc (err 0)

2015-07-31 Thread Igor Gnatenko
On Fri, Jul 31, 2015 at 5:02 PM, Joachim Eastwood manab...@gmail.com wrote: Hi Igor, Hi, On 31 July 2015 at 01:07, Igor Gnatenko i.gnatenko.br...@gmail.com wrote: Hi all, stmmac driver doesn't work on cubietruck (and some more devices like PcDuino3 Nano[0]). This error comes from

Re: [PATCH net-next] bpf: add helpers to access tunnel metadata

2015-07-31 Thread Alexei Starovoitov
On 7/31/15 1:14 AM, Thomas Graf wrote: On 07/30/15 at 03:36pm, Alexei Starovoitov wrote: + to-tunnel_id = be64_to_cpu(info-key.tun_id); + to-remote_ipv4 = be32_to_cpu(info-key.ipv4_src); BTW: I have a patch ready to avoid this as you suggested which I'll post as soon as GRE and

RE: [PATCH 08/15] drivers: net: Drop unlikely before IS_ERR(_OR_NULL)

2015-07-31 Thread David Laight
From: Murali Karicheri Sent: 31 July 2015 16:04 On 07/31/2015 04:38 AM, Viresh Kumar wrote: IS_ERR(_OR_NULL) already contain an 'unlikely' compiler flag and there is no need to do that again from its callers. Drop it. IS_ERR_OR_NULL() is defined as static inline bool __must_check

Re: [PATCH net-next 5/9] openvswitch: Add conntrack action

2015-07-31 Thread Hannes Frederic Sowa
On Thu, 2015-07-30 at 11:12 -0700, Joe Stringer wrote: +static void do_output(struct datapath *dp, struct sk_buff *skb, int out_port, + struct sw_flow_key *key) { struct vport *vport = ovs_vport_rcu(dp, out_port); - if (likely(vport)) -

Re: [PATCH v5 3/4] bpf: Implement function bpf_perf_event_read() that get the selected hardware PMU conuter

2015-07-31 Thread Alexei Starovoitov
On 7/31/15 4:59 AM, Kaixu Xia wrote: +static int check_func_limit(struct bpf_map **mapp, int func_id) +{ + struct bpf_map *map = *mapp; + + if (map map-map_type == BPF_MAP_TYPE_PROG_ARRAY + func_id != BPF_FUNC_tail_call) + /* prog_array map type needs extra

Re: [PATCH 08/15] drivers: net: Drop unlikely before IS_ERR(_OR_NULL)

2015-07-31 Thread Murali Karicheri
On 07/31/2015 04:38 AM, Viresh Kumar wrote: IS_ERR(_OR_NULL) already contain an 'unlikely' compiler flag and there is no need to do that again from its callers. Drop it. IS_ERR_OR_NULL() is defined as static inline bool __must_check IS_ERR_OR_NULL(__force const void *ptr) { return

Re: [PATCH net-next] vxlan: expose COLLECT_METADATA flag to user space

2015-07-31 Thread Alexei Starovoitov
On 7/31/15 1:00 AM, Thomas Graf wrote: On 07/30/15 at 08:10pm, Alexei Starovoitov wrote: Two vxlan driver flags FLOWBASED and COLLECT_METADATA need to be set to make use of its new flow mode. The former already exposed. Expose the latter. Signed-off-by: Alexei Starovoitov a...@plumgrid.com

Re: [PATCH v5 2/4] bpf: Add new bpf map type to store the pointer to struct perf_event

2015-07-31 Thread Alexei Starovoitov
On 7/31/15 4:59 AM, Kaixu Xia wrote: + /* +* prevent some crazy events so we can make our life easier +*/ + if (event-attr.type != PERF_TYPE_RAW + event-attr.type != PERF_TYPE_HARDWARE) { + perf_event_release_kernel(event); +

Re: Null pointer dereference in UDP4 core on AVR32 ATNGW100

2015-07-31 Thread Andy Shevchenko
with network connected). # uname -a Linux buildroot 4.2.0-rc4-next-20150731+ #164 Fri Jul 31 16:37:20 EEST 2015 avr32 GNU/Linux --- a/net/ipv4/udp.c +++ b/net/ipv4/udp.c @@ -1665,6 +1665,10 @@ static int __udp4_lib_mcast_deliver(struct net *net, struct sk_buff *skb, unsigned int hash2

Re: [PATCH net-next 0/3] net: Switch tag HW extraction/insertion

2015-07-31 Thread Florian Fainelli
On 30/07/15 23:08, Eric Dumazet wrote: On Thu, 2015-07-30 at 18:51 -0700, Florian Fainelli wrote: On 30/07/15 15:51, David Miller wrote: From: David Miller da...@davemloft.net Date: Thu, 30 Jul 2015 14:19:35 -0700 (PDT) This looks fine, series applied, thanks. I think your control block is

Re: [PATCH for-next V7 00/10] Move RoCE GID management to IB/Core

2015-07-31 Thread Doug Ledford
On 07/31/2015 12:32 PM, Jason Gunthorpe wrote: On Fri, Jul 31, 2015 at 08:50:24AM -0400, Doug Ledford wrote: So... are we ready to go with V7 upstream? Yes. I've already pulled it in. You are taking the netdev stuff without an ack from netdev?? I've pulled it in, yes. Dave

Re: [PATCH net-next 5/9] openvswitch: Add conntrack action

2015-07-31 Thread Joe Stringer
Thanks for review, On 31 July 2015 at 07:52, Hannes Frederic Sowa han...@redhat.com wrote: On Thu, 2015-07-30 at 11:12 -0700, Joe Stringer wrote: +static void prepare_frag(struct vport *vport, struct sw_flow_key *key, + struct sk_buff *skb) +{ + unsigned int hlen =

[PATCH RFC net-next] net: Assert napi_gro_cb size against skb-cb[]

2015-07-31 Thread Florian Fainelli
On 64-bits hosts, napi_gro_cb is 48 bytes, which is exactly the size of skb-cb[], while on 32-bits hosts it is 36 bytes, but if it were to grow, we would not be catching a size inflation as we should. Make sure that we have enough room for a napi_gro_cb to be hosted in skb-cb[], and put this

[PATCH net] stmmac: fix missing MODULE_LICENSE in stmmac_platform

2015-07-31 Thread Joachim Eastwood
Commit 50649ab14982 (stmmac: drop driver from stmmac platform code) was a bit overzealous in removing code and dropped the MODULE_* macro's that are still needed since stmmac_platform can be a module. Fix this by putting the macro's remvoed in 50649ab14982 back. This fixes the following errors

[PATCH net-next v2 3/4] net: dsa: Refactor transmit path to eliminate duplication

2015-07-31 Thread Florian Fainelli
All tagging protocols do the same thing: increment device statistics, make room for the tag to be inserted, create the tag, invoke the parent network device transmit function. In order to prepare for adding netpoll support, which requires the tag creation, but not using the parent network device

Re: [patch net-next v2 0/4] Introduce Mellanox Technologies Switch ASICs switchdev drivers

2015-07-31 Thread roopa
On 7/29/15, 2:33 PM, Jiri Pirko wrote: From: Jiri Pirko j...@mellanox.com This patchset introduces Mellanox Technologies Switch driver infrastructure and support for SwitchX-2 ASIC. The driver is divided into 3 logical parts: 1) Bus - implements switch bus interface. Currently only PCI bus is

Re: [PATCH net-next 1/9] openvswitch: Scrub packet in ovs_vport_receive()

2015-07-31 Thread Joe Stringer
On 31 July 2015 at 07:34, Hannes Frederic Sowa han...@redhat.com wrote: On Thu, 2015-07-30 at 11:12 -0700, Joe Stringer wrote: Signed-off-by: Joe Stringer joestrin...@nicira.com --- net/openvswitch/vport.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/openvswitch/vport.c

Re: kernel warning in tcp_fragment

2015-07-31 Thread Jovi Zhangwei
Hi Eric, Would you like share your thought on this bug? great thanks. On Mon, Jul 27, 2015 at 4:19 PM, Martin KaFai Lau ka...@fb.com wrote: On Wed, Jul 22, 2015 at 11:55:35AM -0700, Jovi Zhangwei wrote: Sorry for disturbing, our production system(3.14 and 3.18 stable kernel) have many

[PATCH net-next v2 0/4] net: GENET, SYSTEMPORT and DSA netconsole

2015-07-31 Thread Florian Fainelli
Hi all, This patch series adds support for netconsole in the GENET, SYSTEMPORT and DSA drivers. A small refactoring to the DSA transmit path is required to avoid duplicating the dsa_netpoll_send_skb() into each and every tagging protocol supported. Testing on e.g: mv643xx_eth and/or e1000e

[PATCH net-next v2 2/4] net: systemport: Add netconsole support

2015-07-31 Thread Florian Fainelli
Implement a poll controller for netconsole which invokes the RX interrupt handler to poll for incoming packets, and cleans up all TX queues by invoking the TX interrupt handler. Signed-off-by: Florian Fainelli f.faine...@gmail.com --- Changes in v2: - properly pair the interrupt handler calls

[PATCH net-next v2 1/4] net: bcmgenet: Add netconsole support

2015-07-31 Thread Florian Fainelli
Implement a poll controller for netconsole which invokes both of our interrupt handlers for the different RX/TX queues. Signed-off-by: Florian Fainelli f.faine...@gmail.com --- Changes in v2: - properly pair the interrupt handler with disable/enable_irq pairs - remove the call to

[PATCH net-next v2 4/4] net: dsa: Add netconsole support

2015-07-31 Thread Florian Fainelli
Add support for using DSA slave network devices with netconsole, which requires us to allocate and free custom netpoll instances and invoke the parent network device poll controller callback. In order for netconsole to work, we need to construct the DSA tag, but not queue the skb for transmission

Re: [PATCH net-next 5/9] openvswitch: Add conntrack action

2015-07-31 Thread Joe Stringer
On 31 July 2015 at 08:26, Hannes Frederic Sowa han...@redhat.com wrote: On Thu, 2015-07-30 at 11:12 -0700, Joe Stringer wrote: +static void do_output(struct datapath *dp, struct sk_buff *skb, int out_port, + struct sw_flow_key *key) { struct vport *vport =

Re: [PATCH V3 net-next 0/5] net: implement SMC-R solution

2015-07-31 Thread Ursula Braun
On Sun, 2015-07-26 at 16:15 -0700, David Miller wrote: I'm really sorry but this is the same rabbit hole and set of claims that have been bullhorned my way for RDMA over the years and I still don't buy it. None of the RDMA'ish proponents ever talk about what you _don't_ get when this stuff

Re: [PATCH v2] net/phy: micrel: Reenable interrupts during resume

2015-07-31 Thread David Miller
From: Nathan Sullivan nathan.sulli...@ni.com Date: Fri, 31 Jul 2015 09:27:06 -0500 I believe I found the issue, we are using this PHY with cadence macb as the MAC. The driver currently turns off the management port in macb_reset_hw, which we have stopped with a local change since our hardware

Re: [PATCH RFC net-next] net: Assert napi_gro_cb size against skb-cb[]

2015-07-31 Thread David Miller
From: Florian Westphal f...@strlen.de Date: Fri, 31 Jul 2015 22:24:03 +0200 Florian Fainelli f.faine...@gmail.com wrote: On 64-bits hosts, napi_gro_cb is 48 bytes, which is exactly the size of skb-cb[], while on 32-bits hosts it is 36 bytes, but if it were to grow, we would not be catching a

Re: [PATCH RFC net-next] net: Assert napi_gro_cb size against skb-cb[]

2015-07-31 Thread Tom Herbert
On Fri, Jul 31, 2015 at 11:51 AM, Florian Fainelli f.faine...@gmail.com wrote: On 64-bits hosts, napi_gro_cb is 48 bytes, which is exactly the size of skb-cb[], while on 32-bits hosts it is 36 bytes, but if it were to grow, we would not be catching a size inflation as we should. Make sure

Re: [PATCH RFC net-next] net: Assert napi_gro_cb size against skb-cb[]

2015-07-31 Thread Florian Westphal
Florian Fainelli f.faine...@gmail.com wrote: On 64-bits hosts, napi_gro_cb is 48 bytes, which is exactly the size of skb-cb[], while on 32-bits hosts it is 36 bytes, but if it were to grow, we would not be catching a size inflation as we should. --- net/core/dev.c | 2 ++ 1 file changed, 2

Re: [PATCH for-next V7 00/10] Move RoCE GID management to IB/Core

2015-07-31 Thread Jason Gunthorpe
On Fri, Jul 31, 2015 at 01:41:39PM -0400, Doug Ledford wrote: Please be more specific here. What are you objecting to? Are you objecting to a flush_workqueue from a release() context? Because I don't see anything in the kref documentation or the kref implementation that prevents or

Re: [RFC PATCH 0/2] net: macb: Add mdio driver for accessing multiple phy devices

2015-07-31 Thread Nathan Sullivan
On Tue, Jul 28, 2015 at 03:34:51AM +, Punnaiah Choudary Kalluri wrote: Ok. I will send you updated patch for mdio support soon and we will finalize next Course of actions if it doesn't break the existing flow. Thanks, Punnaiah When you submit this patch and mdio is seperate from

Re: [PATCH net-next v6 0/2] af_mpls: fix undefined reference to ip6_route_output with CONFIG_IPV6=n

2015-07-31 Thread David Miller
From: Roopa Prabhu ro...@cumulusnetworks.com Date: Thu, 30 Jul 2015 13:34:52 -0700 This patch series uses ipv6_stub_impl.ipv6_dst_lookup instead of ip6_route_output. Follows the vxlan drivers usage of ipv6_stub_impl.ipv6_dst_lookup. There is no sk in the af_mpls context from where

Re: [Patch net] act_mirred: avoid calling tcf_hash_release() when binding

2015-07-31 Thread Cong Wang
On Fri, Jul 31, 2015 at 3:06 AM, Daniel Borkmann dan...@iogearbox.net wrote: Did you test all variants on this? I.e. what happens when you replace an existing one, I think the refcnt should also be dropped here. It looks like we only drop it, in case we tried to add an action to an already

Re: [PATCH net-next] vxlan: expose COLLECT_METADATA flag to user space

2015-07-31 Thread David Miller
From: Alexei Starovoitov a...@plumgrid.com Date: Thu, 30 Jul 2015 20:10:22 -0700 Two vxlan driver flags FLOWBASED and COLLECT_METADATA need to be set to make use of its new flow mode. The former already exposed. Expose the latter. Signed-off-by: Alexei Starovoitov a...@plumgrid.com Applied.

Re: [PATCH net-next] r8152: disable the capability of zero length

2015-07-31 Thread David Miller
From: Hayes Wang hayesw...@realtek.com Date: Fri, 31 Jul 2015 11:23:39 +0800 The UEFI driver would enable zero length, and the Linux driver doesn't need it. Zero length let the hw complete the transfer with length 0, when there is no received packet. It would add the load of USB host

Re: [PATCH] br2684: Remove unnecessary formatting macros b1 and bs

2015-07-31 Thread David Miller
From: Joe Perches j...@perches.com Date: Thu, 30 Jul 2015 23:54:28 -0700 Use vsprintf extension %pI4 instead. Signed-off-by: Joe Perches j...@perches.com Applied. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More

RE: [PATCH net-next 1/1] Microchip's LAN7800 family USB 2/3 to 10/100/1000 Ethernet device driver

2015-07-31 Thread Woojung.Huh
Thanks for all reviews comments. - Woojung -Original Message- From: David Miller [mailto:da...@davemloft.net] Sent: Friday, July 31, 2015 6:19 PM To: Woojung Huh - C21699 Cc: netdev@vger.kernel.org Subject: Re: [PATCH net-next 1/1] Microchip's LAN7800 family USB 2/3 to

[PATCH RESEND net] stmmac: fix missing MODULE_LICENSE in stmmac_platform

2015-07-31 Thread Joachim Eastwood
Commit 50649ab14982 (stmmac: drop driver from stmmac platform code) was a bit overzealous in removing code and dropped the MODULE_* macro's that are still needed since stmmac_platform can be a module. Fix this by putting the macro's remvoed in 50649ab14982 back. This fixes the following errors

Re: [RFC PATCH 0/2] net: macb: Add mdio driver for accessing multiple phy devices

2015-07-31 Thread Nathan Sullivan
On Tue, Jul 28, 2015 at 03:34:51AM +, Punnaiah Choudary Kalluri wrote: Ok. I will send you updated patch for mdio support soon and we will finalize next Course of actions if it doesn't break the existing flow. Thanks, Punnaiah Just a heads up, when mdio no longer turns off when macb

Re: [PATCH for-next V7 00/10] Move RoCE GID management to IB/Core

2015-07-31 Thread Jason Gunthorpe
On Sat, Aug 01, 2015 at 12:24:23AM +0300, Or Gerlitz wrote: addressed in incremental patch, as Doug suggested. Jason, it's wrong to send developers again and again to fix things which were perfect in Vn-1 but also not being covered by reviewers on Vn-1, at some point the reviewer can't load

Re: [PATCH][v3] net: phy: add driver for aquantia phy

2015-07-31 Thread David Miller
From: shh@gmail.com Date: Fri, 31 Jul 2015 16:58:42 +0800 From: Shaohui Xie shaohui@freescale.com This patch added driver to support Aquantia PHYs AQ1202, AQ2104, AQR105, AQR405, which accessed through clause 45. Signed-off-by: Shaohui Xie shaohui@freescale.com --- changes

Re: [PATCH for-next V7 00/10] Move RoCE GID management to IB/Core

2015-07-31 Thread Or Gerlitz
On Fri, Jul 31, 2015 at 8:41 PM, Doug Ledford dledf...@redhat.com wrote: On 07/31/2015 12:32 PM, Jason Gunthorpe wrote: On Fri, Jul 31, 2015 at 08:50:24AM -0400, Doug Ledford wrote: So... are we ready to go with V7 upstream? Yes. I've already pulled it in. You are taking the netdev stuff

Re: [PATCH net-next] bpf_jit_disasm: also support reading jit dump from file

2015-07-31 Thread David Miller
From: Daniel Borkmann dan...@iogearbox.net Date: Thu, 30 Jul 2015 16:04:22 +0200 This patch adds support to read the dmesg BPF JIT dump also from a file instead of the klog buffer. I found this quite useful when going through some 'before/after patch' logs. It also fixes a regex leak found by

Re: [PATCH net-next 1/1] Microchip's LAN7800 family USB 2/3 to 10/100/1000 Ethernet device driver

2015-07-31 Thread David Miller
From: woojung@microchip.com Date: Thu, 30 Jul 2015 19:45:21 + Repost patch of driver for LAN7800 family of USB 2.0 USB 3.0 to Gigabit E= thernet. - remove module param which can be configurable by standard mechanism. - remove other module parms except msg_level per review comment. -

Re: [PATCH net-next] bpf: add helpers to access tunnel metadata

2015-07-31 Thread David Miller
From: Alexei Starovoitov a...@plumgrid.com Date: Thu, 30 Jul 2015 15:36:57 -0700 Introduce helpers to let eBPF programs attached to TC manipulate tunnel metadata: bpf_skb_[gs]et_tunnel_key(skb, key, size, flags) skb: pointer to skb key: pointer to 'struct bpf_tunnel_key' size: size of

Re: [PATCH net-next 1/1] sfc: MC allocations must be restored following an entity reset

2015-07-31 Thread David Miller
From: Shradha Shah ss...@solarflare.com Date: Fri, 31 Jul 2015 11:15:22 +0100 From: Daniel Pieczko dpiec...@solarflare.com Signed-off-by: Shradha Shah ss...@solarflare.com Applied. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to

Re: [PATCH net-next] bonding: add tlb_dynamic_lb netlink support

2015-07-31 Thread David Miller
From: Nikolay Aleksandrov ra...@blackwall.org Date: Fri, 31 Jul 2015 16:49:43 +0200 From: Nikolay Aleksandrov niko...@cumulusnetworks.com tlb_dynamic_lb could be set only via sysfs, this patch allows it to be set via netlink. Signed-off-by: Nikolay Aleksandrov niko...@cumulusnetworks.com

Re: [PATCH net] stmmac: fix missing MODULE_LICENSE in stmmac_platform

2015-07-31 Thread David Miller
From: Joachim Eastwood manab...@gmail.com Date: Fri, 31 Jul 2015 19:02:32 +0200 Commit 50649ab14982 (stmmac: drop driver from stmmac platform code) was a bit overzealous in removing code and dropped the MODULE_* macro's that are still needed since stmmac_platform can be a module. Fix this by

Re: [PATCH RESEND net] stmmac: fix missing MODULE_LICENSE in stmmac_platform

2015-07-31 Thread David Miller
From: Joachim Eastwood manab...@gmail.com Date: Fri, 31 Jul 2015 19:13:22 +0200 Sorry for the resend, I managed to screwed up Igor's email address in the previous one. Ok I made sure to use this version. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a

Re: [PATCH net-next v2 0/4] net: GENET, SYSTEMPORT and DSA netconsole

2015-07-31 Thread David Miller
From: Florian Fainelli f.faine...@gmail.com Date: Fri, 31 Jul 2015 11:42:53 -0700 This patch series adds support for netconsole in the GENET, SYSTEMPORT and DSA drivers. A small refactoring to the DSA transmit path is required to avoid duplicating the dsa_netpoll_send_skb() into each and

[PATCH net-next] ebpf: add skb-hash to offset map for usage in {cls,act}_bpf or filters

2015-07-31 Thread Daniel Borkmann
Add skb-hash to the __sk_buff offset map, so it can be accessed from an eBPF program. We currently already do this for classic BPF filters, but not yet on eBPF, it might be useful as a demuxer in combination with helpers like bpf_clone_redirect(), toy example: __section(cls-lb) int

Re: [PATCH net-next 0/3] net: Switch tag HW extraction/insertion

2015-07-31 Thread Eric Dumazet
On Thu, 2015-07-30 at 18:51 -0700, Florian Fainelli wrote: On 30/07/15 15:51, David Miller wrote: From: David Miller da...@davemloft.net Date: Thu, 30 Jul 2015 14:19:35 -0700 (PDT) This looks fine, series applied, thanks. I think your control block is too large, you'll need to

Re: [v2] rsi: Fix failure to load firmware after memory leak fix and fixthe leak

2015-07-31 Thread Kalle Valo
Fixes commit eae79b4f3e82 (rsi: fix memory leak in rsi_load_ta_instructions()) which stopped the driver from functioning. Firmware data has been allocated using vmalloc(), resulting in memory that cannot be used for DMA. Hence the firmware was first copied to a buffer allocated with

Re: [PATCH] MIPS: Remove all the uses of custom gpio.h

2015-07-31 Thread Manuel Lauss
On Thu, Jul 30, 2015 at 7:28 PM, Alban Bedel al...@free.fr wrote: Currently CONFIG_ARCH_HAVE_CUSTOM_GPIO_H is defined for all MIPS machines, and each machine type provides its own gpio.h. However only a handful really implement the GPIO API, most just forward everythings to gpiolib. The

[PATCH net-next 4/4] tuntap: Don't segment multiple tagged packets on tap device

2015-07-31 Thread Toshiaki Makita
Tap devices don't need to segment multiple tagged packets. Signed-off-by: Toshiaki Makita makita.toshi...@lab.ntt.co.jp --- drivers/net/tun.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/tun.c b/drivers/net/tun.c index 06a0394..976aa97 100644 --- a/drivers/net/tun.c +++

[PATCH net-next 3/4] bridge: Don't segment multiple tagged packets on bridge device

2015-07-31 Thread Toshiaki Makita
Bridge devices don't need to segment multiple tagged packets since thier ports can segment them. Signed-off-by: Toshiaki Makita makita.toshi...@lab.ntt.co.jp --- net/bridge/br_device.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/bridge/br_device.c b/net/bridge/br_device.c index

Problem with fragmented packets on tun/tap interface

2015-07-31 Thread Prashant Upadhyaya
Hi, I am having a linux user space application which gets data from an interface (eg. eth0) using a packet socket. The application has a fast path and a slow path. In the fast path the packets are processed by the application and sent out via the packet socket. Certain packets need processing by

Re: [PATCH net-next 1/9] openvswitch: Scrub packet in ovs_vport_receive()

2015-07-31 Thread Thomas Graf
On 07/30/15 at 04:16pm, Joe Stringer wrote: On 30 July 2015 at 11:40, Thomas Graf tg...@suug.ch wrote: On 07/30/15 at 11:12am, Joe Stringer wrote: Signed-off-by: Joe Stringer joestrin...@nicira.com Can you write a few lines on why this is needed? I have flows which use the mark to

[PATCH net-next 1/4] macvlan: Don't segment multiple tagged packets on macvlan device

2015-07-31 Thread Toshiaki Makita
Macvlan/macvtap devices don't need to segment multiple tagged packets since the lower devices can segment them. Signed-off-by: Toshiaki Makita makita.toshi...@lab.ntt.co.jp --- drivers/net/macvlan.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c

[PATCH net-next 2/4] veth: Don't segment multiple tagged packets on veth device

2015-07-31 Thread Toshiaki Makita
Veth devices don't need to segment multiple tagged packets. Signed-off-by: Toshiaki Makita makita.toshi...@lab.ntt.co.jp --- drivers/net/veth.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/veth.c b/drivers/net/veth.c index c8186ff..343592c 100644 --- a/drivers/net/veth.c +++

[PATCH net-next 0/4] Stacked vlan TSO for virtual devices

2015-07-31 Thread Toshiaki Makita
Basically virtual devices do not need to segment double tagged packets. This patch set adds TSO feature for double tagged packets to several virtual devices, which can be realized by simply setting .ndo_features_check to passthru_features_check. Toshiaki Makita (4): macvlan: Don't segment

Re: [PATCH v2] net/phy: micrel: Reenable interrupts during resume

2015-07-31 Thread David Miller
From: Nathan Sullivan nathan.sulli...@ni.com Date: Thu, 30 Jul 2015 18:09:05 -0500 On Thu, Jul 30, 2015 at 10:00:34AM -0700, David Miller wrote: From: Nathan Sullivan nathan.sulli...@ni.com Date: Thu, 30 Jul 2015 10:15:48 -0500 Changes for V2: Actually make sure it compiles this time.

Re: [PATCH iproute2 v2] bridge fdb: add 'use' option to set NTF_USE flag in fdb add requests

2015-07-31 Thread Nikolay Aleksandrov
On 07/30/2015 11:37 PM, Roopa Prabhu wrote: From: Roopa Prabhu ro...@cumulusnetworks.com This is similar to command options corresponding to other NTF_* flags already exposed to the user space (examples self/master). Also updates bridge man page (The man page patch also includes a fix to

Re: [V4.2] rtlwifi: Fix NULL dereference when PCI driver used as an AP

2015-07-31 Thread Kalle Valo
From: Luis Felipe Dominguez Vega lfdoming...@nauta.cu In commit 33511b157bbcebaef853cc1811992b664a2e5862 (rtlwifi: add support to send beacon frame), the mechanism for sending beacons was established. That patch works correctly for rtl8192cu, but there is a possibility of getting the

[PATCH] br2684: Remove unnecessary formatting macros b1 and bs

2015-07-31 Thread Joe Perches
Use vsprintf extension %pI4 instead. Signed-off-by: Joe Perches j...@perches.com --- net/atm/br2684.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/net/atm/br2684.c b/net/atm/br2684.c index cc78538..aa0047c 100644 --- a/net/atm/br2684.c +++ b/net/atm/br2684.c @@

Re: Problem with fragmented packets on tun/tap interface

2015-07-31 Thread Eric Dumazet
On Fri, 2015-07-31 at 12:30 +0530, Prashant Upadhyaya wrote: The delays work for me but is clearly not good for the performance of the slow path. And more importantly, I was looking for a fundamental reason regarding why it works with delays and why not without it. The issue is reproducible

Re: [PATCH net-next] vxlan: expose COLLECT_METADATA flag to user space

2015-07-31 Thread Thomas Graf
On 07/30/15 at 08:10pm, Alexei Starovoitov wrote: Two vxlan driver flags FLOWBASED and COLLECT_METADATA need to be set to make use of its new flow mode. The former already exposed. Expose the latter. Signed-off-by: Alexei Starovoitov a...@plumgrid.com Since you are analyzing the program when

[PATCH v5 0/4] bpf: Introduce the new ability of eBPF programs to access hardware PMU counter

2015-07-31 Thread Kaixu Xia
Previous patch v4 url: https://lkml.org/lkml/2015/7/28/432 changes in V5: - move struct fd_array_map_ops* fd_ops to bpf_map; - move array perf event decrement refcnt function to map_free; - fix the NULL ptr of perf_event_get(); - move bpf_perf_event_read() to kernel/bpf/bpf_trace.c; -

[PATCH v5 2/4] bpf: Add new bpf map type to store the pointer to struct perf_event

2015-07-31 Thread Kaixu Xia
Introduce a new bpf map type 'BPF_MAP_TYPE_PERF_EVENT_ARRAY'. This map only stores the pointer to struct perf_event. The user space event FDs from perf_event_open() syscall are converted to the pointer to struct perf_event and stored in map. Signed-off-by: Kaixu Xia xiaka...@huawei.com ---

[PATCH v5 4/4] samples/bpf: example of get selected PMU counter value

2015-07-31 Thread Kaixu Xia
This is a simple example and shows how to use the new ability to get the selected Hardware PMU counter value. Signed-off-by: Kaixu Xia xiaka...@huawei.com --- samples/bpf/Makefile | 4 +++ samples/bpf/bpf_helpers.h | 2 ++ samples/bpf/tracex6_kern.c | 26 ++

  1   2   >