Re: [V9fs-developer] [PATCH] 9p: trans_fd, initialize recv fcall properly if not set

2015-09-05 Thread Dominique Martinet
Eric Van Hensbergen wrote on Sat, Sep 05, 2015: > On Thu, Sep 3, 2015 at 4:38 AM, Dominique Martinet > wrote: > > To be honest, I think it might be better to just bail out if we get in > > this switch (m->req->rc == NULL after p9_tag_lookup) and not try to > > allocate more, because if we get ther

Re: [PATCH] net: bridge: remove unnecessary switchdev include

2015-09-05 Thread Jiri Pirko
Sun, Sep 06, 2015 at 03:49:41AM CEST, vivien.dide...@savoirfairelinux.com wrote: >Remove the unnecessary switchdev.h include from br_netlink.c. > >Signed-off-by: Vivien Didelot Acked-by: Jiri Pirko -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to m

Re: [PATCH net] net: bridge: check __vlan_vid_del for error

2015-09-05 Thread Jiri Pirko
Sun, Sep 06, 2015 at 03:27:57AM CEST, vivien.dide...@savoirfairelinux.com wrote: >Since __vlan_del can return an error code, change its inner function >__vlan_vid_del to return an eventual error from switchdev_port_obj_del. > >Signed-off-by: Vivien Didelot Acked-by: Jiri Pirko -- To unsubscribe

Re: [PATCH net-next] RDS: rds_conn_lookup() should factor in the struct net for a match

2015-09-05 Thread David Miller
From: Sowmini Varadhan Date: Thu, 3 Sep 2015 16:24:52 -0400 > > Only return a conn if the rds_conn_net(conn) matches the struct > net passed to rds_conn_lookup(). > > Fixes: 467fa15356ac ("RDS-TCP: Support multiple RDS-TCP listen endpoints, >one per netns.") > > Signed-off-by: Sowmini

Re: [PATCH] net: fec: normalize return value of pm_runtime_get_sync() in MDIO write

2015-09-05 Thread David Miller
From: "Maciej S. Szmigiero" Date: Thu, 03 Sep 2015 21:38:30 +0200 > If fec MDIO write method succeeds its return value comes from > call to pm_runtime_get_sync(). > But pm_runtime_get_sync() can also return 1. > > In case of Micrel KSZ9031 PHY this value will then > be returned along the call ch

Re: [patch net] switchdev: fix return value of switchdev_port_fdb_dump in case of error

2015-09-05 Thread David Miller
From: Jiri Pirko Date: Thu, 3 Sep 2015 14:04:17 +0200 > From: Jiri Pirko > > switchdev_port_fdb_dump is used as .ndo_fdb_dump. Its return value is > idx, so we cannot return errval. > > Fixes: 45d4122ca7cd ("switchdev: add support for fdb add/del/dump via > switchdev_port_obj ops.") > Signed

Re: [PATCH] be2net: Revert "make the RX_FILTER command asynchronous" commit

2015-09-05 Thread David Miller
From: Sathya Perla Date: Thu, 3 Sep 2015 07:41:53 -0400 > The be_cmd_rx_filter() routine sends a non-embedded cmd to the FW and used > a pre-allocated dma memory to hold the cmd payload. This worked fine when > this cmd was synchronous. This cmd was changed to asynchronous mode by the > commit 8

Re: [net-next PATCH] net: kill default_pref field of struct fib_rules_ops

2015-09-05 Thread David Miller
From: Phil Sutter Date: Thu, 3 Sep 2015 13:10:22 +0200 > Since now all users of that field have been converted to use the generic > function fib_default_rule_pref() when assigning to it, fib_nl_newrule() > may just use it directly instead. > > Signed-off-by: Phil Sutter I did not instruct you

Re: [PATCH 0/6] Netfilter fixes for net

2015-09-05 Thread David Miller
From: Pablo Neira Ayuso Date: Thu, 3 Sep 2015 11:50:55 +0200 > The following patchset contains Netfilter fixes for net, they are: > > 1) Oneliner to restore maps in nf_tables since we support addressing registers >at 32 bits level. > > 2) Restore previous default behaviour in bridge netfil

Re: [PATCH] 9p: trans_fd, initialize recv fcall properly if not set

2015-09-05 Thread Eric Van Hensbergen
On Thu, Sep 3, 2015 at 4:38 AM, Dominique Martinet wrote: > That code really should never be called (rc is allocated in > tag_alloc), but if it had been it couldn't have worked... > > Signed-off-by: Dominique Martinet > --- > net/9p/trans_fd.c | 3 +++ > 1 file changed, 3 insertions(+) > > To be

[PATCH] net: bridge: remove unnecessary switchdev include

2015-09-05 Thread Vivien Didelot
Remove the unnecessary switchdev.h include from br_netlink.c. Signed-off-by: Vivien Didelot --- net/bridge/br_netlink.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/bridge/br_netlink.c b/net/bridge/br_netlink.c index af5e187..ea748c9 100644 --- a/net/bridge/br_netlink.c +++ b/net/bridg

[PATCH net] net: bridge: check __vlan_vid_del for error

2015-09-05 Thread Vivien Didelot
Since __vlan_del can return an error code, change its inner function __vlan_vid_del to return an eventual error from switchdev_port_obj_del. Signed-off-by: Vivien Didelot --- net/bridge/br_vlan.c | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/net/bridge/br

Re: [PATCH] net: wan: sbni: fix device usage count

2015-09-05 Thread David Miller
From: Sudip Mukherjee Date: Thu, 3 Sep 2015 11:30:30 +0530 > dev_get_by_name() will increment the usage count if the matching device > is found. But we were not decrementing the count if we have got the > device and the device is non-active. > > Signed-off-by: Sudip Mukherjee Applied, thanks.

Re: [PATCH 1/1] net/ipv6: Correct PIM6 mrt_lock handling

2015-09-05 Thread David Miller
From: Richard Laing Date: Thu, 3 Sep 2015 13:52:31 +1200 > In the IPv6 multicast routing code the mrt_lock was not being released > correctly in the MFC iterator, as a result adding or deleting a MIF would > cause a hang because the mrt_lock could not be acquired. > > This fix is a copy of the

Re: [PATCH] net: phy: Handle postive return codes in phy_connect

2015-09-05 Thread Andrew Lunn
> > It might not be an ERRNO. E.g. https://lkml.org/lkml/2015/9/3/534 > > fixed a bug where a positive value is returned which is not an > > indication of an error. > > It appears that I have stumbled upon the exact same issue as is fixed in > the patch above. Ah, sorry. I put that bug there :-(

Re: [PATCH] net: phy: Handle postive return codes in phy_connect

2015-09-05 Thread Michael Welling
On Sat, Sep 05, 2015 at 01:11:51PM -0700, Florian Fainelli wrote: > Le 09/05/15 12:47, Andrew Lunn a écrit : > > On Sat, Sep 05, 2015 at 02:44:01PM -0500, Michael Welling wrote: > >> On Sat, Sep 05, 2015 at 09:18:40PM +0200, Andrew Lunn wrote: > >>> On Sat, Sep 05, 2015 at 01:01:29PM -0500, Michael

Re: [PATCH] net: phy: Handle postive return codes in phy_connect

2015-09-05 Thread Michael Welling
On Sat, Sep 05, 2015 at 09:47:55PM +0200, Andrew Lunn wrote: > On Sat, Sep 05, 2015 at 02:44:01PM -0500, Michael Welling wrote: > > On Sat, Sep 05, 2015 at 09:18:40PM +0200, Andrew Lunn wrote: > > > On Sat, Sep 05, 2015 at 01:01:29PM -0500, Michael Welling wrote: > > > > The function phy_connect_di

Re: [PATCH] net: phy: Handle postive return codes in phy_connect

2015-09-05 Thread Florian Fainelli
Le 09/05/15 12:47, Andrew Lunn a écrit : > On Sat, Sep 05, 2015 at 02:44:01PM -0500, Michael Welling wrote: >> On Sat, Sep 05, 2015 at 09:18:40PM +0200, Andrew Lunn wrote: >>> On Sat, Sep 05, 2015 at 01:01:29PM -0500, Michael Welling wrote: The function phy_connect_direct can possibly return a

[PATCH net] net: dsa: bcm_sf2: Fix ageing conditions and operation

2015-09-05 Thread Florian Fainelli
The comparison check between cur_hw_state and hw_state is currently invalid because cur_hw_state is right shifted by G_MISTP_SHIFT, while hw_state is not, so we end-up comparing bits 2:0 with bits 7:5, which is going to cause an additional aging to occur. Fix this by not shifting cur_hw_state while

_DSD standardization note (WAS: Re: [PATCH 2/2] net, thunder, bgx: Add support for ACPI binding.)

2015-09-05 Thread Jon Masters
Following up on this thread after finally seeing it...figured I would send something just for the archive mainly (we discussed this in person recently at a few different events and I think are aligned already). On 08/07/2015 08:28 PM, Rafael J. Wysocki wrote: > Hi David, > > On Sat, Aug 8, 2015 a

Re: [PATCH] net: phy: Handle postive return codes in phy_connect

2015-09-05 Thread Andrew Lunn
On Sat, Sep 05, 2015 at 02:44:01PM -0500, Michael Welling wrote: > On Sat, Sep 05, 2015 at 09:18:40PM +0200, Andrew Lunn wrote: > > On Sat, Sep 05, 2015 at 01:01:29PM -0500, Michael Welling wrote: > > > The function phy_connect_direct can possibly return a positive > > > return code. Using ERR_PTR

Re: [PATCH] net: phy: Handle postive return codes in phy_connect

2015-09-05 Thread Michael Welling
On Sat, Sep 05, 2015 at 09:18:40PM +0200, Andrew Lunn wrote: > On Sat, Sep 05, 2015 at 01:01:29PM -0500, Michael Welling wrote: > > The function phy_connect_direct can possibly return a positive > > return code. Using ERR_PTR with a positive value can lead to > > deferencing of an invalid pointer.

[no subject]

2015-09-05 Thread
We offer both personal and business loan to any interested individual or company who will be able to pay back the loan when due for repayment. should Fill and return the application details below to my e-mail at ( montageglobalpvt...@gmail.com ). APPLICATION DETAILS 1) FULL NAMES: 2) CONTA

Re: [PATCH] net: phy: Handle postive return codes in phy_connect

2015-09-05 Thread Andrew Lunn
On Sat, Sep 05, 2015 at 01:01:29PM -0500, Michael Welling wrote: > The function phy_connect_direct can possibly return a positive > return code. Using ERR_PTR with a positive value can lead to > deferencing of an invalid pointer. Is this the correct fix? Would it not be better to find where the po

Re: [PATCH] ethtool: Dump eeprom info for soldered on modules

2015-09-05 Thread Ben Hutchings
On Sun, 2015-08-16 at 04:05 +0200, Andrew Lunn wrote: > Modules which are soldered onto the motherboard may also use the > sff8079 > EEPROM format. Dump these in the same way as SFP modules. > > Signed-off-by: Andrew Lunn [...] Applied, thanks. Ben. -- Ben Hutchings friends: People who know

[PATCH] net: phy: Handle postive return codes in phy_connect

2015-09-05 Thread Michael Welling
The function phy_connect_direct can possibly return a positive return code. Using ERR_PTR with a positive value can lead to deferencing of an invalid pointer. Signed-off-by: Michael Welling --- drivers/net/phy/phy_device.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/phy/ph

Re: [GIT] Networking

2015-09-05 Thread Lorenzo Bianconi
Hi all, > On Wed, Sep 2, 2015 at 10:35 PM, David Miller wrote: >> >> Another merge window, another set of networking changes. I've heard >> rumblings that the lightweight tunnels infrastructure has been voted >> networking change of the year. > > .. and others say that the most notable feature i

FROM MR. MARTIN IBANEZ

2015-09-05 Thread MR. MARTIN IBANEZ
Please view the attached file MR. MARTIN IBANEZ.pdf Description: Adobe PDF document

[PATCH net 2/3] r8169: move rtl_reset_counters_cond before the hardware counters helpers.

2015-09-05 Thread romieu
From: Francois Romieu Signed-off-by: Francois Romieu Cc: Corinna Vinschen Cc: pomidorabelis...@gmail.com --- drivers/net/ethernet/realtek/r8169.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/real

[PATCH net 1/3] r8169: decouple the counters data and the device private area.

2015-09-05 Thread romieu
From: Francois Romieu Signed-off-by: Francois Romieu Cc: Corinna Vinschen Cc: pomidorabelis...@gmail.com --- drivers/net/ethernet/realtek/r8169.c | 70 +--- 1 file changed, 42 insertions(+), 28 deletions(-) diff --git a/drivers/net/ethernet/realtek/r8169.c b/d

[PATCH net 0/3] r8169: fix sleepable allocation during netdevice stats retrieval.

2015-09-05 Thread romieu
From: Francois Romieu This series applies against davem's net as of 724a7636ad026a3a68f3fc626ccd04111f65cfd9 ("Merge branch 'sctp-fixes'). It's untested though reviewable. I should be able to try it this evening. Francois Romieu (3): r8169: decouple the counters data and the device private ar

[PATCH net 3/3] r8169: increase the lifespan of the hardware counters dump area.

2015-09-05 Thread romieu
From: Francois Romieu net/core/net-sysfs.c::netstat_show retrieves stats with spinlock held. This change avoids sleepable allocation and performs some housekeeping: - receive ring, transmit ring and counters dump area allocation failures are all considered fatal during open() - netif_warn is n

Re: [RFC PATCH 0/3] Network stack, first user of SLAB/kmem_cache bulk free API.

2015-09-05 Thread Jesper Dangaard Brouer
On Fri, 4 Sep 2015 18:45:13 -0500 (CDT) Christoph Lameter wrote: > On Fri, 4 Sep 2015, Alexander Duyck wrote: > > Right, but one of the reasons for Jesper to implement the bulk alloc/free is > > to avoid the cmpxchg that is being used to get stuff into or off of the per > > cpu lists. > > There

Re: [PATCH ethtool V3 1/2] ethtool: Add copybreak support

2015-09-05 Thread Ben Hutchings
On Thu, 2015-06-11 at 15:15 +0300, Hadar Hen Zion wrote: > From: Govindarajulu Varadarajan <_gov...@gmx.com> > > Add support for setting/getting driver's tx/rx_copybreak value. > > Copybreak is handled through a new ethtool tunable interface. > > The kernel support was added in 3.18, commit f0db

Re: [PATCH ethtool V3 1/2] ethtool: Add copybreak support

2015-09-05 Thread Ben Hutchings
On Thu, 2015-06-11 at 15:15 +0300, Hadar Hen Zion wrote: > From: Govindarajulu Varadarajan <_gov...@gmx.com> > > Add support for setting/getting driver's tx/rx_copybreak value. > > Copybreak is handled through a new ethtool tunable interface. > > The kernel support was added in 3.18, commit f0db

Re: parsing the output of ethtool programmatically

2015-09-05 Thread Ben Hutchings
On Thu, 2015-06-25 at 03:28 +0200, Robert Urban wrote: > Hello, > > there doesn't seem to be any flag to request ethtool to present its output in > a > script-friendly form. Things like: > > Link partner advertised link modes: 10baseT/Half 10baseT/Full > >

Re: [PATCH v2 1/2] ethtool: changes of emac_regs structure accordingly within driver emac_regs structure.

2015-09-05 Thread Ben Hutchings
On Wed, 2015-08-05 at 15:01 +0400, Ivan Mikhaylov wrote: > * do the redefinition of emac_regs struct from driver structure perspective > and passing size from actual struct size, not from memory area variable > which set in dts file. > > * passing variable from dts option may cause a problem w

Re: [PATCH v3 1/4] Add correlated clocksource deriving system time from an auxiliary clocksource

2015-09-05 Thread Ingo Molnar
* Thomas Gleixner wrote: > On Fri, 4 Sep 2015, Hall, Christopher S wrote: > > > Right, but we still do not know how that is going to be used. And > > > that's the key question. As long as that is not answered all can do is > > > wild guessing. > > > > It's not wild guessing. We do have it work

RE: [PATCH v3 1/4] Add correlated clocksource deriving system time from an auxiliary clocksource

2015-09-05 Thread Thomas Gleixner
On Fri, 4 Sep 2015, Hall, Christopher S wrote: > > Right, but we still do not know how that is going to be used. And > > that's the key question. As long as that is not answered all can do is > > wild guessing. > > It's not wild guessing. We do have it working on other OSs and have > a pretty goo

[PATCH] iproute: print more verbose error on route cache flush

2015-09-05 Thread Denis Kirjanov
Before: kda@vfirst ~/devel/iproute2 $ ./ip/ip route flush cache Cannot open "/proc/sys/net/ipv4/route/flush" After: kda@vfirst ~/devel/iproute2/ip $ ./ip route flush cache Cannot open "/proc/sys/net/ipv4/route/flush": Permission denied Signed-off-by: Denis Kirjanov --- ip/iproute.c | 3 ++- 1 f

Re: [PATCH 5/6] seccomp: add a way to attach a filter via eBPF fd

2015-09-05 Thread Michael Kerrisk (man-pages)
On 09/04/2015 10:41 PM, Kees Cook wrote: > On Fri, Sep 4, 2015 at 9:04 AM, Tycho Andersen > wrote: >> This is the final bit needed to support seccomp filters created via the bpf >> syscall. Hmm. Thanks Kees, for CCinf linux-api@. That really should have been done at the outset. Tycho, where's th