Re: unregister_netdevice warnings when deleting netns

2015-09-28 Thread Eric W. Biederman
Anand Gurram writes: >>If the message just spits out a few times and then goes away it simply >>means that something is taking a while to cleanup and drop it's >>reference. > > The message just spits out few times and then goes away, I am trying > to debug why cleanup is taking long, > and where

Re: [PATCH net-next 0/6] make non-modular code explicitly non-modular

2015-09-28 Thread Finn Thain
Hi Paul, On Mon, 28 Sep 2015, Paul Gortmaker wrote: > On 28/09/2015 (Mon 23:09) Geert Uytterhoeven wrote: > > > Hi Paul, ... > > > > Why did you choose this approach? > > What about changing the "bool"s to "tristate"s in Kconfig instead? > > Long answer is here: > > https://lkml.org/lkml/201

Re: unregister_netdevice warnings when deleting netns

2015-09-28 Thread Anand Gurram
>If the message just spits out a few times and then goes away it simply >means that something is taking a while to cleanup and drop it's >reference. The message just spits out few times and then goes away, I am trying to debug why cleanup is taking long, and where it is still referenced. Any point

Re: unregister_netdevice warnings when deleting netns

2015-09-28 Thread Anand Gurram
Thanks Julian, I will check if these two commits work for me. >I think, they will appear in other stable versions too... Yes, I saw them in other versions, the fix which is suggested in those branches didn't work for me. Hope the above two commits help. Regards, Anand On Tue, Sep 29, 2015 at 12

Re: unregister_netdevice warnings when deleting netns

2015-09-28 Thread Julian Anastasov
Hello, On Mon, 28 Sep 2015, Eric W. Biederman wrote: > Julian Anastasov writes: > > > On Mon, 28 Sep 2015, Anand Gurram wrote: > > > >> I am currently using kernel version 3.16.7 on a linux switch. > >> While creating and destroying network namespaces I am observing below logs > >> on

Re: [PATCH v2] net: sctp: Don't use 64 kilobyte lookup table for four elements

2015-09-28 Thread David Miller
From: Denys Vlasenko Date: Mon, 28 Sep 2015 14:34:04 +0200 > Seemingly innocuous sctp_trans_state_to_prio_map[] array > is way bigger than it looks, since > "[SCTP_UNKNOWN] = 2" expands into "[0x] = 2" ! > > This patch replaces it with switch() statement. > > Signed-off-by: Denys Vlasenko

Re: [net-next PATCH] net: help compiler generate better code in eth_get_headlen

2015-09-28 Thread David Miller
From: Jesper Dangaard Brouer Date: Mon, 28 Sep 2015 12:47:14 +0200 > Noticed that the compiler (gcc version 4.8.5 20150623 (Red Hat 4.8.5-4) (GCC)) > generated suboptimal assembler code in eth_get_headlen(). > > This early return coding style is usually not an issue, on super scalar CPUs, > but

Re: [PATCH] l2tp: protect tunnel->del_work by ref_count

2015-09-28 Thread David Miller
From: Alexander Couzens Date: Mon, 28 Sep 2015 11:32:42 +0200 > There is a small chance that tunnel_free() is called before tunnel->del_work > scheduled > resulting in a zero pointer dereference. > > Signed-off-by: Alexander Couzens Applied and queued up for -stable, thanks. -- To unsubscribe

Re: [PATCH v2 net-next] tcp: Fix CWV being too strict on thin streams

2015-09-28 Thread David Miller
From: Eric Dumazet Date: Sun, 27 Sep 2015 09:33:00 -0700 > David, any idea of what happened to Bendik patch ? > > https://patchwork.ozlabs.org/patch/521765 > > Do we need to re-submit or something ? Sorry, applied and build testing, I don't know how this disappeared like that :-) -- To unsubsc

Re: [PATCH net-next v4] net: Fix Hisilicon Network Subsystem Support Compilation

2015-09-28 Thread David Miller
From: huangdaode Date: Sun, 27 Sep 2015 15:22:44 +0800 > This patch fixes the compilation error with arm allmodconfig, this error > generated due to unavailability of readq() on 32-bit platform which was > found during net-next daily compilation. In the same time, fix all the > hns drivers compil

Re: [PATCH net-next] cxgb4: Add HW timesptamp support for RX

2015-09-28 Thread David Miller
From: Hariprasad Shenai Date: Mon, 28 Sep 2015 10:26:53 +0530 > Adds support for ethtool get time stamp ioctl, which is used by > tcpdump to get the supported time stamp types > > eg: tcpdump -i eth5 -J > Time stamp types for eth5 (use option -j to set): > host (Host) > adapter_unsynced (Ada

Re: [PATCH v3 2/3] net: irda: pxaficp_ir: convert to readl and writel

2015-09-28 Thread David Miller
From: Robert Jarzmik Date: Sat, 26 Sep 2015 20:49:19 +0200 > Convert the pxa IRDA driver to readl and writel primitives, and remove > another set of direct registers access. This leaves only the DMA > registers access, which will be dealt with dmaengine conversion. > > Signed-off-by: Robert Jarz

Re: [PATCH v3 3/3] net: irda: pxaficp_ir: dmaengine conversion

2015-09-28 Thread David Miller
From: Robert Jarzmik Date: Sat, 26 Sep 2015 20:49:20 +0200 > Convert pxaficp_ir to dmaengine. As pxa architecture is shifting from > raw DMA registers access to pxa_dma dmaengine driver, convert this > driver to dmaengine. > > Signed-off-by: Robert Jarzmik > Tested-by: Petr Cvek > --- > Since

Re: [PATCH v3 1/3] net: irda: pxaficp_ir: use sched_clock() for time management

2015-09-28 Thread David Miller
From: Robert Jarzmik Date: Sat, 26 Sep 2015 20:49:18 +0200 > Instead of using directly the OS timer through direct register access, > use the standard sched_clock(), which will end up in OSCR reading > anyway. > > This is a first step for direct access register removal and machine > specific cod

Re: [PATCH net v2] skbuff: Fix skb checksum flag on skb pull

2015-09-28 Thread David Miller
From: Pravin Shelar Date: Fri, 25 Sep 2015 19:48:57 -0700 > On Thu, Sep 24, 2015 at 2:09 PM, David Miller wrote: >> From: Pravin B Shelar >> Date: Tue, 22 Sep 2015 12:57:53 -0700 >> >>> VXLAN device can receive skb with checksum partial. But the checksum >>> offset could be in outer header whic

Re: [PATCH] net: fec: Remove unneeded FEATURES_NEED_QUIESCE definition

2015-09-28 Thread David Miller
From: Fabio Estevam Date: Fri, 25 Sep 2015 18:31:32 -0300 > From: Fabio Estevam > > There is no need to have FEATURES_NEED_QUIESCE defined as we > can simply use NETIF_F_RXCSUM instead as done in other parts > of the driver. > > Signed-off-by: Fabio Estevam Applied to net-next, thanks. -- To

Re: [PATCH net-next] net: Remove redundant oif checks in rt6_device_match

2015-09-28 Thread David Miller
From: David Ahern Date: Fri, 25 Sep 2015 15:22:54 -0600 > The oif has already been checked that it is non-zero; the 2 additional > checks on oif within that if (oif) {...} block are redundant. > > CC: YOSHIFUJI Hideaki > Signed-off-by: David Ahern Looks good, applied, thanks. -- To unsubscrib

Re: [PATCH net-next] lan78xx: Return 0 when lan78xx_suspend() has no error.

2015-09-28 Thread David Miller
From: Date: Fri, 25 Sep 2015 21:13:48 + > lan78xx_suspend() may return non-zero from lan78xx_write_reg() in some > scenario. > Fix to return 0 when lan78xx_suspend() has no error. > > Signed-off-by: Woojung Huh Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH] net/mlx4: Handle return codes in mlx4_qp_attach_common

2015-09-28 Thread David Miller
From: Robb Manes Date: Fri, 25 Sep 2015 10:39:21 -0400 > @@ -1184,10 +1184,11 @@ out: > if (prot == MLX4_PROT_ETH) { > /* manage the steering entry for promisc mode */ > if (new_entry) > -new_steering_entry(dev, port, steer, index, qp->qpn); > +err =

Re: [PATCH] net ipv4 ipconfig: use preferred log methods

2015-09-28 Thread David Miller
From: Bastian Stender Date: Fri, 25 Sep 2015 11:58:30 +0200 > @@ -69,7 +69,7 @@ > #undef IPCONFIG_DEBUG > > #ifdef IPCONFIG_DEBUG > -#define DBG(x) printk x > +#define DBG(x) pr_debug(x) > #else > #define DBG(x) do { } while(0) > #endif I agree with Stephen, just get rid of this and use p

Re: [PATCH v2] net/ibm/emac: bump version numbers for correct work with ethtool

2015-09-28 Thread David Miller
From: Ivan Mikhaylov Date: Fri, 25 Sep 2015 11:52:27 +0400 > The size of the MAC register dump used to be the size specified by the > reg property in the device tree. Userland has no good way of finding > out that size, and it was not specified consistently for each MAC type, > so ethtool would

Re: [PATCH net-next 0/4] switchdev: push bridge attributes down

2015-09-28 Thread Florian Fainelli
2015-09-24 21:26 GMT-07:00 Scott Feldman : > On Thu, Sep 24, 2015 at 6:23 PM, Florian Fainelli > wrote: >> On 24/09/15 13:59, sfel...@gmail.com wrote: >>> From: Scott Feldman >>> >>> Push bridge-level attributes down to switchdev drivers. This patchset >>> adds the infrastructure and then pushe

Re: [PATCH net-next 0/8] Mellanox mlx5 driver update

2015-09-28 Thread David Miller
From: Or Gerlitz Date: Fri, 25 Sep 2015 10:49:08 +0300 > Bunch of changes from the team, while warming engines for the > upcoming SRIOV support. Series applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org Mor

Re: [PATCH v2 17/19] tools: bpf_jit_disasm: make get_last_jit_image return unsigned

2015-09-28 Thread David Miller
From: Andrzej Hajda Date: Fri, 25 Sep 2015 08:45:43 +0200 > The function returns always non-negative values. > > The problem has been detected using proposed semantic patch > scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1]. > > [1]: http://permalink.gmane.org/gmane.linux.kernel/204

Re: [PATCH net-next] tcp: avoid reorders for TFO passive connections

2015-09-28 Thread David Miller
From: Eric Dumazet Date: Thu, 24 Sep 2015 17:16:05 -0700 > From: Eric Dumazet > > We found that a TCP Fast Open passive connection was vulnerable > to reorders, as the exchange might look like > > [1] C -> S S > [2] S -> C S. ack request > [3] S -> C . > > packets [2] and [3] can be gener

Re: [PATCH net-next 0/4] switchdev: push bridge attributes down

2015-09-28 Thread David Miller
From: sfel...@gmail.com Date: Thu, 24 Sep 2015 13:59:26 -0700 > From: Scott Feldman > > Push bridge-level attributes down to switchdev drivers. This patchset > adds the infrastructure and then pushes, as an example, ageing_time attribute > down from bridge to switchdev (rocker) driver. Add som

Re: [PATCH net 0/2] sctp: Fix SCTP deadlock

2015-09-28 Thread David Miller
From: Karl Heiss Date: Thu, 24 Sep 2015 12:15:05 -0400 > These patches fix a deadlock during accept() of an SCTP connection. > > The first patch fixes whitespace issues. > > The second patch actually fixes the deadlock race. Seems reasonable, series applied, thanks. -- To unsubscribe from this

Re: [net-next v2 0/6][pull request] Intel Wired LAN Driver Updates 2015-09-28

2015-09-28 Thread David Miller
From: Jeff Kirsher Date: Mon, 28 Sep 2015 17:55:28 -0700 > This series contains updates to i40e, i40evf and igb to resolve issues > seen and reported by Red Hat. Pulled, thanks Jeff. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.k

Re: [net] i40e/i40evf: check for stopped admin queue

2015-09-28 Thread David Miller
From: Jeff Kirsher Date: Mon, 28 Sep 2015 17:31:26 -0700 > From: Mitch Williams > > It's possible that while we are waiting for the spinlock, another > entity (that owns the spinlock) has shut down the admin queue. > If we then attempt to use the queue, we will panic. > > Add a check for this

Re: [net] i40e: fix VLAN inside VXLAN

2015-09-28 Thread David Miller
From: Jeff Kirsher Date: Mon, 28 Sep 2015 11:21:48 -0700 > From: Jesse Brandeburg > > Previously to this patch, the hardware was removing > VLAN tags from the inner header of VXLAN packets. The > hardware configuration can be changed to leave the > packet alone since that is what the linux sta

[PATCH net-next v2 RESEND] BNX2: fix a Null Pointer for stats_blk

2015-09-28 Thread Weidong Wang
we have two processes to do: P1#: ifconfig eth0 down; which will call bnx2_close, then will , and set Null to stats_blk P2#: ifconfig eth0; which will call bnx2_get_stats64, it will use stats_blk. In one case: --P1#-- --P2#-- stats_blk(no null)

Re: [PATCH net-next v2] BNX2: fix a Null Pointer for stats_blk

2015-09-28 Thread Weidong Wang
On 2015/9/28 15:01, Weidong Wang wrote: > we have two processes to do: > P1#: ifconfig eth0 down; which will call bnx2_close, then will > , and set Null to stats_blk > P2#: ifconfig eth0; which will call bnx2_get_stats64, it will > use stats_blk. > In one case: > --P1#-- --P2#

Re: [PATCH net] skbuff: Fix skb checksum partial check.

2015-09-28 Thread Pravin Shelar
On Mon, Sep 28, 2015 at 5:46 PM, Tom Herbert wrote: > On Mon, Sep 28, 2015 at 5:24 PM, Pravin B Shelar wrote: >> Earlier patch 6ae459bda tried to detect void ckecksum partial >> skb by comparing pull length to checksum offset. But it does >> not work for all cases since checksum-offset depends on

Re: [RFC PATCH] Fix false positives in can_checksum_protocol()

2015-09-28 Thread Tom Herbert
On Mon, Sep 28, 2015 at 6:38 PM, Jesse Brandeburg wrote: > On Mon, Sep 28, 2015 at 12:37 PM, Tom Herbert wrote: >> On Mon, Sep 28, 2015 at 12:26 PM, David Woodhouse >> wrote: >>> On Mon, 2015-09-28 at 12:13 -0700, Tom Herbert wrote: > Perhaps a better solution would be a bit in the sk

Re: [PATCH v4 net-next 0/2] ipv4: Hash-based multipath routing

2015-09-28 Thread David Miller
From: David Miller Date: Mon, 28 Sep 2015 19:33:55 -0700 (PDT) > From: Peter Nørlund > Date: Wed, 23 Sep 2015 21:49:35 +0200 > >> When the routing cache was removed in 3.6, the IPv4 multipath algorithm >> changed >> from more or less being destination-based into being quasi-random per-packet >

Re: [PATCH v4 net-next 0/2] ipv4: Hash-based multipath routing

2015-09-28 Thread David Miller
From: Peter Nørlund Date: Wed, 23 Sep 2015 21:49:35 +0200 > When the routing cache was removed in 3.6, the IPv4 multipath algorithm > changed > from more or less being destination-based into being quasi-random per-packet > scheduling. This increases the risk of out-of-order packets and makes it

Re: [RFC PATCH] Fix false positives in can_checksum_protocol()

2015-09-28 Thread Jesse Brandeburg
On Mon, Sep 28, 2015 at 12:37 PM, Tom Herbert wrote: > On Mon, Sep 28, 2015 at 12:26 PM, David Woodhouse wrote: >> On Mon, 2015-09-28 at 12:13 -0700, Tom Herbert wrote: >>> >>> > Perhaps a better solution would be a bit in the skbuff which indicates >>> > that it *is* a TCP or UDP checksum. That

[net-next v2 3/6] i40e: add GRE tunnel type to csum encoding

2015-09-28 Thread Jeff Kirsher
From: Shannon Nelson Make sure the Tx checksum encoder knows about GRE protocol and sets the descriptor flag appropriately. Signed-off-by: Shannon Nelson Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_txrx.c | 3 +++ 1 file changed, 3 insertions

[net-next v2 2/6] i40e/i40evf: refactor tx timeout logic

2015-09-28 Thread Jeff Kirsher
From: Kiran Patil This patch modifies the driver timeout logic by issuing a writeback request via a software interrupt to the hardware the first time the driver detects a hang. The driver was too aggressive in resetting a hung queue, so back that off by removing logic to down the netdevice after

Re: [PATCH] ipvs: Don't protect ip_vs_addr_is_unicast with CONFIG_SYSCTL

2015-09-28 Thread Simon Horman
On Mon, Sep 28, 2015 at 09:45:28PM +0300, Julian Anastasov wrote: > > Hello, > > On Mon, 28 Sep 2015, Eric W. Biederman wrote: > > > I arranged the code so that the compiler can remove the unecessary bits > > in ip_vs_leave when CONFIG_SYSCTL is unset, and removed an explicit > > CONFIG_SY

[net-next v2 5/6] i40e: Fix for recursive RTNL lock during PROMISC change

2015-09-28 Thread Jeff Kirsher
From: Anjali Singhai The sync_vsi_filters function can be called directly under RTNL or through the timer subtask without one. This was causing a deadlock. If sync_vsi_filters is called from a thread which held the lock, and in another thread the PROMISC setting got changed we would be executing

[net-next v2 0/6][pull request] Intel Wired LAN Driver Updates 2015-09-28

2015-09-28 Thread Jeff Kirsher
This series contains updates to i40e, i40evf and igb to resolve issues seen and reported by Red Hat. Kiran moves i40e_get_head() in preparation for the refactor of the Tx timeout logic, so that it can be used in other areas of the driver. Refactored the driver timeout logic by issuing a writeback

[net-next v2 4/6] i40e: Fix RS bit update in Tx path and disable force WB workaround

2015-09-28 Thread Jeff Kirsher
From: Anjali Singhai This patch fixes the issue of forcing WB too often causing us to not benefit from NAPI. Without this patch we were forcing WB/arming interrupt too often taking away the benefits of NAPI and causing a performance impact. With this patch we disable force WB in the clean routi

[net-next v2 6/6] igb: assume MSI-X interrupts during initialization

2015-09-28 Thread Jeff Kirsher
From: Stefan Assmann In igb_sw_init() the sequence of calls was changed from igb_init_queue_configuration() igb_init_interrupt_scheme() igb_probe_vfs() to igb_probe_vfs() igb_init_queue_configuration() igb_init_interrupt_scheme() This results in adapter->flags not having the IGB_FLAG_HAS_MSIX bi

[net-next v2 1/6] i40e: Move i40e_get_head into header file

2015-09-28 Thread Jeff Kirsher
From: Kiran Patil i40e_get_head needs to be called in multiple files in a further patch, prepare by moving the function into a header file. Signed-off-by: Kiran Patil Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_txrx.c | 13 - driv

Re: [PATCH net] skbuff: Fix skb checksum partial check.

2015-09-28 Thread Tom Herbert
On Mon, Sep 28, 2015 at 5:24 PM, Pravin B Shelar wrote: > Earlier patch 6ae459bda tried to detect void ckecksum partial > skb by comparing pull length to checksum offset. But it does > not work for all cases since checksum-offset depends on > updates to skb->data. > > Following patch fixes it by v

Re: 4.3-rc3 Regression: NFS access stall by commit 6ae459bdaaee

2015-09-28 Thread Pravin Shelar
On Mon, Sep 28, 2015 at 6:12 AM, Takashi Iwai wrote: > [I resent this since the previous mail didn't go out properly, as it > seems; apologies if you already read it, please disregard] > > Hi, > > I noticed that NFS access from my workstation slowed down drastically, > almost stalls, with the fre

Re: [net-next 0/5][pull request] Intel Wired LAN Driver Updates 2015-09-28

2015-09-28 Thread Jeff Kirsher
On Mon, 2015-09-28 at 12:33 -0700, Jeff Kirsher wrote: > This series contains updates to i40e, i40evf and igb to resolve > issues > seen and reported by Red Hat. > > Kiran moves i40e_get_head() in preparation for the refactor of the Tx > timeout logic, so that it can be used in other areas of the

[net] i40e/i40evf: check for stopped admin queue

2015-09-28 Thread Jeff Kirsher
From: Mitch Williams It's possible that while we are waiting for the spinlock, another entity (that owns the spinlock) has shut down the admin queue. If we then attempt to use the queue, we will panic. Add a check for this condition on the receive side. This matches an existing check on the send

Re: [net] skbuff: Fix skb checksum flag on skb pull

2015-09-28 Thread Pravin Shelar
On Mon, Sep 28, 2015 at 2:46 AM, Andrew Vagin wrote: > Hi, > > With this patch, I can't connect two local tcp ipv6 sockets. > > [root@fc22-vm criu]# strace -e network python ipv6.py > socket(PF_INET6, SOCK_STREAM, IPPROTO_IP) = 3 > bind(3, {sa_family=AF_INET6, sin6_port=htons(8976), inet_pton(AF_I

[PATCH net] skbuff: Fix skb checksum partial check.

2015-09-28 Thread Pravin B Shelar
Earlier patch 6ae459bda tried to detect void ckecksum partial skb by comparing pull length to checksum offset. But it does not work for all cases since checksum-offset depends on updates to skb->data. Following patch fixes it by validating checksum start offset after skb-data pointer is updated. N

[PATCH net-next] dsa: mv88e6xxx: Fix unsigned/signed issue

2015-09-28 Thread Andrew Lunn
commit dea870242a9c ("dsa: mv88e6xxx: Allow speed/duplex of port to be configured") leads to the following static checker warning: drivers/net/dsa/mv88e6xxx.c:585 mv88e6xxx_adjust_link() warn: unsigned 'ret' is never less than zero. drivers/net/dsa/mv88e6xxx.c 573 void mv88e6x

[PATCH] dsa: mv88e6xxx: Enable forwarding for unknown to the CPU port

2015-09-28 Thread Andrew Lunn
Frames destined to an unknown address must be forwarded to the CPU port. Otherwise incoming ARP, dhcp leases, etc, do not work. Signed-off-by: Andrew Lunn --- drivers/net/dsa/mv88e6xxx.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/dsa/mv88e6xxx.c b/drivers/net/dsa/mv88e6xxx

Re: [net] skbuff: Fix skb checksum flag on skb pull

2015-09-28 Thread Pravin Shelar
On Mon, Sep 28, 2015 at 2:46 AM, Andrew Vagin wrote: > Hi, > > With this patch, I can't connect two local tcp ipv6 sockets. > > [root@fc22-vm criu]# strace -e network python ipv6.py > socket(PF_INET6, SOCK_STREAM, IPPROTO_IP) = 3 > bind(3, {sa_family=AF_INET6, sin6_port=htons(8976), inet_pton(AF_I

Re: [PATCH net] netlink: make sure -EBUSY won't escape from netlink_insert

2015-09-28 Thread David Miller
From: Christoph Paasch Date: Wed, 16 Sep 2015 22:41:14 -0700 > Hello, > > On 10/08/15 - 11:00:15, David Miller wrote: >> From: Daniel Borkmann >> Date: Fri, 7 Aug 2015 00:26:41 +0200 >> > Linus reports the following deadlock on rtnl_mutex; triggered only >> > once so far (extract): >> ... >>

Re: request for stable inclusion

2015-09-28 Thread David Miller
From: Or Gerlitz Date: Wed, 16 Sep 2015 09:41:40 +0300 > Hi Dave, > > Commit 9293267 "net/mlx4_core: Capping number of requested MSIXs to > MAX_MSIX" fixes a bug under which the driver doesn't really starts > over a machine with > 32 cores. > > The bug was introduced in 4.2-rc1 but the fix miss

Re: [PATCH net-next 0/4] ila: Use NF_INET_PRE_ROUTING nfhook

2015-09-28 Thread Florian Westphal
Tom Herbert wrote: > RFC6296 doesn't work because it allows an invalid checksum to be sent > on wire relative to the addresses used on the wire. That means we > would lose CHECKSUM_UNNECESSARY for ILA which is way too big of a > performance hit. Not following. I did not say you should use NPT in

Re: [PATCH net-next 0/4] ila: Use NF_INET_PRE_ROUTING nfhook

2015-09-28 Thread Tom Herbert
On Sun, Sep 27, 2015 at 1:10 AM, Florian Westphal wrote: > David Miller wrote: >> > This patch set addresses the issue for ILA by adding a fast locator >> > lookup that occurs before early demux. This is done by using a hook >> > at NF_INET_PRE_ROUTING. For the backend we implement an rhashtable

Re: [PATCH net-next 0/8] Mellanox mlx5 driver update

2015-09-28 Thread Or Gerlitz
On Fri, Sep 25, 2015 at 10:49 AM, Or Gerlitz wrote: > Hi Dave, > > Bunch of changes from the team, while warming engines for the > upcoming SRIOV support. Hi Dave, FWIW - I will be OOO for the rest of this week, so in case you'll have some comments/questions on the series will see them only next

e1000_hw.c_Elementary checkpatch warnings and checks removed

2015-09-28 Thread Janusz Wolak
>From 83ef6e8f4eeaf13dfa100e6e08c12d94931e1f20 Mon Sep 17 00:00:00 2001 From: Janusz Wolak Date: Mon, 28 Sep 2015 23:40:19 +0200 Subject: [PATCH 2/2] Elementary checkpatch warnings and checks removed. Signed-off-by: Janusz Wolak --- drivers/net/ethernet/intel/e1000/e1000_hw.c | 18

Re: BUG: Mellanox crash with iommu=soft and swiotlb=force

2015-09-28 Thread Or Gerlitz
On Tue, Sep 29, 2015 at 12:04 AM, Christoffer Dall wrote: > Hi, > > In doing some performance experiments I found that using a 10G Mellanox > MX354A Dual port FDR CX3 device on a server running Apache and running > ab against that server causes the system to crash with 'iommu=soft > swiotlb=force'

Re: unregister_netdevice warnings when deleting netns

2015-09-28 Thread Eric W. Biederman
Julian Anastasov writes: > Hello, > > On Mon, 28 Sep 2015, Anand Gurram wrote: > >> I am currently using kernel version 3.16.7 on a linux switch. >> While creating and destroying network namespaces I am observing below logs >> on the console >> "unregister_netdevice: waiting for lo to becom

Re: [PATCH net-next 0/6] make non-modular code explicitly non-modular

2015-09-28 Thread Paul Gortmaker
[Re: [PATCH net-next 0/6] make non-modular code explicitly non-modular] On 28/09/2015 (Mon 23:09) Geert Uytterhoeven wrote: > Hi Paul, > > On Mon, Sep 28, 2015 at 9:51 PM, Paul Gortmaker > wrote: > > In a previous merge window, we made changes to allow better > > delineation between modular and

Re: [PATCH net-next 0/6] make non-modular code explicitly non-modular

2015-09-28 Thread Geert Uytterhoeven
Hi Paul, On Mon, Sep 28, 2015 at 9:51 PM, Paul Gortmaker wrote: > In a previous merge window, we made changes to allow better > delineation between modular and non-modular code in commit > 0fd972a7d91d6e15393c449492a04d94c0b89351 ("module: relocate module_init > from init.h to module.h"). This a

BUG: Mellanox crash with iommu=soft and swiotlb=force

2015-09-28 Thread Christoffer Dall
Hi, In doing some performance experiments I found that using a 10G Mellanox MX354A Dual port FDR CX3 device on a server running Apache and running ab against that server causes the system to crash with 'iommu=soft swiotlb=force'. The same behavior is seen without these options on Dom0 running und

[PATCH 5/5] net: sfc: avoid using timespec

2015-09-28 Thread Arnd Bergmann
The sfc driver internally uses a time format based on 32-bit (unsigned) seconds and 32-bit nanoseconds. This means it will overflow in 2106, but the value we pass into it is a signed 32-bit tv_sec that already overflows in 2038 to a negative value. This patch changes the logic to use the lower 32

[PATCH 2/5] ntp/pps: replace getnstime_raw_and_real with 64-bit version

2015-09-28 Thread Arnd Bergmann
There is exactly one caller of getnstime_raw_and_real in the kernel, which is the pps_get_ts function. This changes the caller and the implementation to work on timespec64 types rather than timespec, to avoid the time_t overflow on 32-bit architectures. For consistency with the other new functions

[PATCH 1/5] ntp/pps: use timespec64 for hardpps()

2015-09-28 Thread Arnd Bergmann
There is only one user of the hardpps function in the kernel, so it makes sense to atomically change it over to using 64-bit timestamps for y2038 safety. In the hardpps implementation, we also need to change the pps_normtime structure, which is similar to struct timespec and also requires a 64-bit

[PATCH 4/5] ntp/pps: use y2038 safe types in pps_event_time

2015-09-28 Thread Arnd Bergmann
The pps_event_time uses two 'timespec' structures internally, which suffer from the y2038 problem. The uses of this structure are fairly self-contained in the pps code, so this replaces them all at once. Unfortunately, this includes the sfc ethernet driver aside from the pps subsystem, so we chang

[PATCH 0/5] y2038 conversion for ntp/pps and sfc driver

2015-09-28 Thread Arnd Bergmann
When trying to build a kernel with time_t commented out, I found that the ntp subsystem still relies on timespec for its pps handling. This series addresses this and converts all the code to use timespec64 instead, step by step. There is one device driver that interacts with this code directly (ra

[PATCH 3/5] ntp: use timespec64 in sync_cmos_clock

2015-09-28 Thread Arnd Bergmann
The sync_cmos_clock has one use of struct timespec, which we want to eventually replace with timespec64 or similar in the kernel. There is no way this one can overflow, but the conversion to timespec64 is trivial and has no other dependencies. Signed-off-by: Arnd Bergmann --- kernel/time/ntp.c |

Re

2015-09-28 Thread David Thomas
I have a proposal for you Kindly E-mail me at mrshus...@gmail.com yours Faithfully Mrs Huian Shao [http://www.cranbrook.nsw.edu.au/images/email_sig.gif] David Thomas | Hone Housemaster / History Teacher 5 Victoria Road, Bellevue Hill NSW 2023 Australia Office

[PATCH 1/6] net/core: make sock_diag.c explicitly non-modular

2015-09-28 Thread Paul Gortmaker
The Makefile currently controlling compilation of this code lists it under "obj-y" ...meaning that it currently is not being built as a module by anyone. Lets remove the modular code that is essentially orphaned, so that when reading the driver there is no doubt it is builtin-only. Since module_i

[PATCH net-next 0/6] make non-modular code explicitly non-modular

2015-09-28 Thread Paul Gortmaker
In a previous merge window, we made changes to allow better delineation between modular and non-modular code in commit 0fd972a7d91d6e15393c449492a04d94c0b89351 ("module: relocate module_init from init.h to module.h"). This allows us to now ensure module code looks modular and non-modular code does

[PATCH 3/6] net/sched: make sch_blackhole.c explicitly non-modular

2015-09-28 Thread Paul Gortmaker
The Kconfig currently controlling compilation of this code is: net/sched/Kconfig:menuconfig NET_SCHED net/sched/Kconfig: bool "QoS and/or fair queueing" ...meaning that it currently is not being built as a module by anyone. Lets remove the modular code that is essentially orphaned, so that

[PATCH 2/6] net/dcb: make dcbnl.c explicitly non-modular

2015-09-28 Thread Paul Gortmaker
The Kconfig currently controlling compilation of this code is: net/dcb/Kconfig:config DCB net/dcb/Kconfig:bool "Data Center Bridging support" ...meaning that it currently is not being built as a module by anyone. Lets remove the modular code that is essentially orphaned, so that when rea

[PATCH 6/6] net/ethernet: make apple/macmace.c driver explicitly non-modular

2015-09-28 Thread Paul Gortmaker
The Kconfig for this option is currently: config MACMACE bool "Macintosh (AV) onboard MACE ethernet" ...meaning that it currently is not being built as a module by anyone. Lets remove the modular code that is essentially orphaned, so when reading the driver there should be no doubt it is

[PATCH 5/6] net/ethernet: make 8390/mac8390.c driver explicitly non-modular

2015-09-28 Thread Paul Gortmaker
The Kconfig for this option is currently: config MAC8390 bool "Macintosh NS 8390 based ethernet cards" ...meaning that it currently is not being built as a module by anyone. Lets remove the modular code that is essentially orphaned -- it was never even updated to use module_init/module_exit.

[PATCH 4/6] net/ethernet: make amd/hplance.c driver explicitly non-modular

2015-09-28 Thread Paul Gortmaker
The Kconfig for this driver is currently: config HPLANCE bool "HP on-board LANCE support" ...meaning that it currently is not being built as a module by anyone. Lets remove the modular and unused code here, so that when reading the driver there is no doubt it is builtin-only. Since modu

Re: [RFC PATCH] Fix false positives in can_checksum_protocol()

2015-09-28 Thread Tom Herbert
On Mon, Sep 28, 2015 at 12:26 PM, David Woodhouse wrote: > On Mon, 2015-09-28 at 12:13 -0700, Tom Herbert wrote: >> >> > Perhaps a better solution would be a bit in the skbuff which indicates >> > that it *is* a TCP or UDP checksum. That would be set by our UDP and >> > TCP sockets, cleared by enc

[net-next 4/5] i40e: Fix RS bit update in Tx path and disable force WB workaround

2015-09-28 Thread Jeff Kirsher
From: Anjali Singhai This patch fixes the issue of forcing WB too often causing us to not benefit from NAPI. Without this patch we were forcing WB/arming interrupt too often taking away the benefits of NAPI and causing a performance impact. With this patch we disable force WB in the clean routi

[net-next 2/5] i40e/i40evf: refactor tx timeout logic

2015-09-28 Thread Jeff Kirsher
From: Kiran Patil This patch modifies the driver timeout logic by issuing a writeback request via a software interrupt to the hardware the first time the driver detects a hang. The driver was too aggressive in resetting a hung queue, so back that off by removing logic to down the netdevice after

[net-next 1/5] i40e: Move i40e_get_head into header file

2015-09-28 Thread Jeff Kirsher
From: Kiran Patil i40e_get_head needs to be called in multiple files in a further patch, prepare by moving the function into a header file. Signed-off-by: Kiran Patil Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_txrx.c | 13 - driv

[net-next 5/5] igb: assume MSI-X interrupts during initialization

2015-09-28 Thread Jeff Kirsher
From: Stefan Assmann In igb_sw_init() the sequence of calls was changed from igb_init_queue_configuration() igb_init_interrupt_scheme() igb_probe_vfs() to igb_probe_vfs() igb_init_queue_configuration() igb_init_interrupt_scheme() This results in adapter->flags not having the IGB_FLAG_HAS_MSIX bi

[net-next 0/5][pull request] Intel Wired LAN Driver Updates 2015-09-28

2015-09-28 Thread Jeff Kirsher
This series contains updates to i40e, i40evf and igb to resolve issues seen and reported by Red Hat. Kiran moves i40e_get_head() in preparation for the refactor of the Tx timeout logic, so that it can be used in other areas of the driver. Refactored the driver timeout logic by issuing a writeback

[net-next 3/5] i40e: add GRE tunnel type to csum encoding

2015-09-28 Thread Jeff Kirsher
From: Shannon Nelson Make sure the Tx checksum encoder knows about GRE protocol and sets the descriptor flag appropriately. Signed-off-by: Shannon Nelson Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_txrx.c | 3 +++ 1 file changed, 3 insertions

Re: [RFT] geneve: implement support for IPv6-based tunnels

2015-09-28 Thread John W. Linville
On Fri, Sep 25, 2015 at 02:08:44PM +0200, Jiri Benc wrote: > On Thu, 24 Sep 2015 14:34:42 -0400, John W. Linville wrote: > > +#if IS_ENABLED(CONFIG_IPV6) > > +static netdev_tx_t geneve6_xmit_skb(struct sk_buff *skb, struct net_device > > *dev) > > +{ > > + struct geneve_dev *geneve = netdev_priv

Re: [RFC PATCH] Fix false positives in can_checksum_protocol()

2015-09-28 Thread David Woodhouse
On Mon, 2015-09-28 at 12:13 -0700, Tom Herbert wrote: > > > Perhaps a better solution would be a bit in the skbuff which indicates > > that it *is* a TCP or UDP checksum. That would be set by our UDP and > > TCP sockets, cleared by encapsulation, also set if appropriate by > > skb_partial_csum_set

Re: [RFC PATCH] Fix false positives in can_checksum_protocol()

2015-09-28 Thread Tom Herbert
>> Also, this doesn't help those drivers that that can offload TCP and >> UDP for IPv6 but only if there are no extension headers, in those >> case the driver needs to look at the packet to see if it is a >> "simple" UDP/TCP packet. > > Hm, are such devices even permitted to set NETIF_F_IPV6_CSUM?

Re: unregister_netdevice warnings when deleting netns

2015-09-28 Thread Julian Anastasov
Hello, On Mon, 28 Sep 2015, Anand Gurram wrote: > I am currently using kernel version 3.16.7 on a linux switch. > While creating and destroying network namespaces I am observing below logs > on the console > "unregister_netdevice: waiting for lo to become free. Usage count = 1" > > Can

Re: [PATCH] ipvs: Don't protect ip_vs_addr_is_unicast with CONFIG_SYSCTL

2015-09-28 Thread Julian Anastasov
Hello, On Mon, 28 Sep 2015, Eric W. Biederman wrote: > I arranged the code so that the compiler can remove the unecessary bits > in ip_vs_leave when CONFIG_SYSCTL is unset, and removed an explicit > CONFIG_SYSCTL. > > Unfortunately when rebasing my work on top of that of Alex Gartrell I

Re: [RFC PATCH] Fix false positives in can_checksum_protocol()

2015-09-28 Thread David Woodhouse
On Mon, 2015-09-28 at 10:03 -0700, Tom Herbert wrote: > > + if features & NETIF_F_V4_CSUM) && protocol == htons(ETH_P_IP)) > > || > > +((features & NETIF_F_V6_CSUM) && protocol == > > htons(ETH_P_IPV6))) && > > + (sk_protocol == IPPROTO_TCP || sk_protocol == IPPRO

[net] i40e: fix VLAN inside VXLAN

2015-09-28 Thread Jeff Kirsher
From: Jesse Brandeburg Previously to this patch, the hardware was removing VLAN tags from the inner header of VXLAN packets. The hardware configuration can be changed to leave the packet alone since that is what the linux stack expects for this type of VLAN in VXLAN packet. Signed-off-by: Jesse

[net-next PATCH 2/3] net: Swap ordering of tests in ip_route_input_mc

2015-09-28 Thread Alexander Duyck
This patch just swaps the ordering of one of the conditional tests in ip_route_input_mc. Specifically it swaps the testing for the source address to see if it is loopback, and the test to see if we allow a loopback source address. The reason for swapping these two tests is because it is much fast

[net-next PATCH 1/3] net/ipv4: Pass proto as u8 instead of u16 in ip_check_mc_rcu

2015-09-28 Thread Alexander Duyck
This patch updates ip_check_mc_rcu so that protocol is passed as a u8 instead of a u16. The motivation is just to avoid any unneeded type transitions since some systems will require an instruction to zero extend a u8 field to a u16. Also it makes it a bit more readable as to the fact that protocol

[net-next PATCH 3/3] net: Remove martian_source_keep_err goto label

2015-09-28 Thread Alexander Duyck
From: David Ahern err is initialized to -EINVAL when it is declared. It is not reset until fib_lookup which is well after the 3 users of the martian_source jump. So resetting err to -EINVAL at martian_source label is not needed. Removing that line obviates the need for the martian_source_keep_er

[net-next PATCH 0/3] Minor IPv4 routing cleanups

2015-09-28 Thread Alexander Duyck
These patches just contain some minor cleanups to address a few minor issues. The first and the third mostly just improve readability. The second patch should improve the performance for multicast destination addresses that do not have a localhost source IP address by avoiding some unnecessary de

Re: [PATCH v2] net: sctp: Don't use 64 kilobyte lookup table for four elements

2015-09-28 Thread Denys Vlasenko
On 09/28/2015 05:32 PM, David Laight wrote: > From: Eric Dumazet >> Sent: 28 September 2015 15:27 >> On Mon, 2015-09-28 at 14:12 +, David Laight wrote: >>> From: Neil Horman Sent: 28 September 2015 14:51 On Mon, Sep 28, 2015 at 02:34:04PM +0200, Denys Vlasenko wrote: > Seemingly i

Re: 4.3-rc3 Regression: NFS access stall by commit 6ae459bdaaee

2015-09-28 Thread Pravin Shelar
On Mon, Sep 28, 2015 at 6:12 AM, Takashi Iwai wrote: > [I resent this since the previous mail didn't go out properly, as it > seems; apologies if you already read it, please disregard] > > Hi, > > I noticed that NFS access from my workstation slowed down drastically, > almost stalls, with the fre

[PATCH net-next 11/11] net: Add netif_is_l3_slave

2015-09-28 Thread David Ahern
IPv6 addrconf keys off of IFF_SLAVE so can not use it for L3 slave. Add a new private flag and add netif_is_l3_slave function for checking it. Signed-off-by: David Ahern --- drivers/net/vrf.c | 8 +++- include/linux/netdevice.h | 7 +++ net/l3mdev/l3mdev.c | 8 3 f

  1   2   >