Re: [PATCH 3/3] 802.1AD: Flow handling, actions, vlan parsing and netlink attributes

2015-09-29 Thread Thomas F Herbert
On 9/29/15 6:56 PM, Pravin Shelar wrote: On Fri, Sep 25, 2015 at 3:35 PM, Thomas F Herbert wrote: Pravin, Another comment and question. Please seen inline below. Thanks, --Tom On 9/24/15 7:42 PM, Pravin Shelar wrote: On Thu, Sep 24, 2015 at 10:58 AM, Thomas F

[PATCH net-next] netfilter: remove dead code

2015-09-29 Thread Flavio Leitner
Remove __nf_conntrack_find() from headers. Fixes: dcd93ed4cd1 ("netfilter: nf_conntrack: remove dead code" Signed-off-by: Flavio Leitner --- include/net/netfilter/nf_conntrack.h | 4 1 file changed, 4 deletions(-) diff --git a/include/net/netfilter/nf_conntrack.h

Re: question about potential integer truncation in mwifiex_set_wapi_ie and mwifiex_set_wps_ie

2015-09-29 Thread James Cameron
On Tue, Sep 29, 2015 at 05:21:28PM +0200, PaX Team wrote: > hi all, > > in drivers/net/wireless/mwifiex/sta_ioctl.c the following functions > > mwifiex_set_wpa_ie_helper > mwifiex_set_wapi_ie > mwifiex_set_wps_ie > > can truncate the incoming ie_len argument from u16 to u8

Re: [net-next PATCH 0/3] Minor IPv4 routing cleanups

2015-09-29 Thread David Miller
From: Alexander Duyck Date: Mon, 28 Sep 2015 11:10:25 -0700 > These patches just contain some minor cleanups to address a few minor > issues. The first and the third mostly just improve readability. The > second patch should improve the performance for multicast

Re: [net-next PATCH v2] netpoll: Drop budget parameter from NAPI polling call hierarchy

2015-09-29 Thread David Miller
From: Alexander Duyck Date: Mon, 28 Sep 2015 09:16:17 -0700 > For some reason we were carrying the budget value around between the > various calls to napi->poll. If for example one of the drivers called had > a bug in which it returned a non-zero value for work this could

[PATCH net 6/7] openvswitch: Extend ct_state match field to 32 bits

2015-09-29 Thread Joe Stringer
The ct_state field was initially added as an 8-bit field, however six of the bits are already being used and use cases are already starting to appear that may push the limits of this field. This patch extends the field to 32 bits while retaining the internal representation of 8 bits. This should

[PATCH net 7/7] openvswitch: Change CT_ATTR_FLAGS to CT_ATTR_COMMIT

2015-09-29 Thread Joe Stringer
Previously, the CT_ATTR_FLAGS attribute, when nested under the OVS_ACTION_ATTR_CT, encoded a 32-bit bitmask of flags that modify the semantics of the ct action. It's more extensible to just represent each flag as a nested attribute, and this requires no additional error checking to reject flags

[PATCH net 2/7] openvswitch: Fix typos in CT headers

2015-09-29 Thread Joe Stringer
These comments hadn't caught up to their implementations, fix them. Fixes: 7f8a436 "openvswitch: Add conntrack action" Signed-off-by: Joe Stringer --- include/uapi/linux/openvswitch.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH net 5/7] openvswitch: Reject ct_state unsupported bits

2015-09-29 Thread Joe Stringer
Previously, if userspace specified ct_state bits in the flow key which are currently undefined (and therefore unsupported), then they would be ignored. This could cause unexpected behaviour in future if userspace is extended to support additional bits but attempts to communicate with the current

[PATCH net 1/7] openvswitch: Make LABELS name more consistent

2015-09-29 Thread Joe Stringer
Conntrack LABELS (plural) are exposed by conntrack; rename the OVS name for these to be consistent with conntrack. Fixes: c2ac667 "openvswitch: Allow matching on conntrack label" Signed-off-by: Joe Stringer --- include/uapi/linux/openvswitch.h | 4 ++--

[PATCH net 4/7] openvswitch: Ensure flow is valid before executing ct

2015-09-29 Thread Joe Stringer
The ct action uses parts of the flow key, so we need to ensure that it is valid before executing that action. Fixes: 7f8a436 "openvswitch: Add conntrack action" Signed-off-by: Joe Stringer --- net/openvswitch/actions.c | 6 ++ 1 file changed, 6 insertions(+) diff

[PATCH net 0/7] OVS conntrack fixes for net

2015-09-29 Thread Joe Stringer
The userspace side of the Open vSwitch conntrack changes is currently undergoing review, which has highlighted some minor bugs in the existing conntrack implementation in the kernel, as well as pointing out some future-proofing that can be done on the interface to reduce the need for additional

[PATCH net 3/7] openvswitch: Fix skb leak in ovs_fragment()

2015-09-29 Thread Joe Stringer
If ovs_fragment() was unable to fragment the skb due to an L2 header that exceeds the supported length, skbs would be leaked. Fix the bug. Fixes: 7f8a436 "openvswitch: Add conntrack action" Signed-off-by: Joe Stringer --- net/openvswitch/actions.c | 13 + 1

Re: [RFC PATCH] Fix false positives in can_checksum_protocol()

2015-09-29 Thread Tom Herbert
On Tue, Sep 29, 2015 at 12:12 AM, David Woodhouse wrote: > On Mon, 2015-09-28 at 20:04 -0700, Tom Herbert wrote: >> >> > I've been pondering a bit of a redesign in this space. I think the >> > skb struct should be explicit in its instructions to hardware for >> > which

Re: [PATCH net-next 4/6] xfrm: Add xfrm6 address translation function

2015-09-29 Thread David Ahern
Hi Tom: On 9/29/15 4:17 PM, Tom Herbert wrote: This patch adds xfrm6_xlat_addr which is called in the data path to perform address translation (primarily for the receive path). Modules may register their own callback to perform a translation-- this registration is managed by xfrm6_xlat_addr_add

Re: [PATCH net-next 1/2] openvswitch: add tunnel protocol to sw_flow_key

2015-09-29 Thread Pravin Shelar
On Tue, Sep 29, 2015 at 10:52 AM, Jiri Benc wrote: > Store tunnel protocol (AF_INET or AF_INET6) in sw_flow_key. This field now > also acts as an indicator whether the flow contains tunnel data (this was > previously indicated by tun_key.u.ipv4.dst being set but with IPv6

[PATCH net-next 1/6] ila: Create net/ipv6/ila directory

2015-09-29 Thread Tom Herbert
Create ila directory in preparation for supporting other hooks in the kernel than LWT for doing ILA. This includes: - Moving ila.c to ila/ila_lwt.c - Splitting out some common functions into ila_common.c Signed-off-by: Tom Herbert --- net/ipv6/Makefile | 2 +-

[PATCH net-next 4/6] xfrm: Add xfrm6 address translation function

2015-09-29 Thread Tom Herbert
This patch adds xfrm6_xlat_addr which is called in the data path to perform address translation (primarily for the receive path). Modules may register their own callback to perform a translation-- this registration is managed by xfrm6_xlat_addr_add and xfrm6_xlat_addr_del. xfrm6_xlat_addr allows

Re: [PATCH net-next 6/6] ila: Add support for xfrm6_xlat_addr

2015-09-29 Thread kbuild test robot
Hi Tom, [auto build test results on next-20150929 -- if it's inappropriate base, please ignore] config: xtensa-allyesconfig (attached as .config) reproduce: wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin

Re: [PATCH net-next 6/6] ila: Add support for xfrm6_xlat_addr

2015-09-29 Thread kbuild test robot
Hi Tom, [auto build test results on next-20150929 -- if it's inappropriate base, please ignore] reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings: (new ones prefixed by >>) >> net/ipv6/ila/ila_xlat.c:21

Re: Poor IPv6 TCP performance in 4.3-rc3

2015-09-29 Thread Fabio Estevam
Hi Russell, On Tue, Sep 29, 2015 at 8:32 PM, Russell King - ARM Linux wrote: > Hi, > > I'm seeing really poor IPv6 performance compared to IPv4. I've > checked using two different ARM platforms - an iMX6 platform using > the FEC driver, and an Armada 38x using mvneta.

Re: [PATCH] bna: fix error handling

2015-09-29 Thread David Miller
From: Andrzej Hajda Date: Mon, 28 Sep 2015 10:49:48 +0200 > Several functions can return negative value in case of error, > so their return type should be fixed as well as type of variables > to which this value is assigned. > > The problem has been detected using proposed

Re: [PATCH RFC 3/7] netfilter: add NF_INET_LOCAL_SOCKET_IN chain type

2015-09-29 Thread Florian Westphal
Daniel Mack wrote: > Add a new chain type NF_INET_LOCAL_SOCKET_IN which is ran after the > input demux is complete and the final destination socket (if any) > has been determined. > > This helps filtering packets based on information stored in the > destination socket, such as

Re: [PATCH net 3/7] openvswitch: Fix skb leak in ovs_fragment()

2015-09-29 Thread Rustad, Mark D
> On Sep 29, 2015, at 3:39 PM, Joe Stringer wrote: > > @@ -728,8 +727,14 @@ static void ovs_fragment(struct vport *vport, struct > sk_buff *skb, u16 mru, > WARN_ONCE(1, "Failed fragment ->%s: eth=%04x, MRU=%d, MTU=%d.", >

Re: [PATCH net-next 6/6] ila: Add support for xfrm6_xlat_addr

2015-09-29 Thread kbuild test robot
Hi Tom, [auto build test results on next-20150929 -- if it's inappropriate base, please ignore] config: m68k-sun3_defconfig (attached as .config) reproduce: wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin

[PATCH net-next v2 3/3] sched, bpf: make skb->priority writable

2015-09-29 Thread Daniel Borkmann
{cls,act}_bpf can now set the skb->priority from an eBPF program based on various critera, so that for example classful qdiscs like multiq can update the skb's priority during enqueue time and further push it down into subsequent qdiscs. Signed-off-by: Daniel Borkmann

[PATCH net-next v2 1/3] ebpf: migrate bpf_prog's flags to bitfield

2015-09-29 Thread Daniel Borkmann
As we need to add further flags to the bpf_prog structure, lets migrate both bools to a bitfield representation. The size of the base structure (excluding insns) remains unchanged at 40 bytes. Add also tags for the kmemchecker, so that it doesn't throw false positives. Even in case gcc would

[PATCH net-next v2 2/3] sched, bpf: add helper for retrieving routing realms

2015-09-29 Thread Daniel Borkmann
Using routing realms as part of the classifier is quite useful, it can be viewed as a tag for one or multiple routing entries (think of an analogy to net_cls cgroup for processes), set by user space routing daemons or via iproute2 as an indicator for traffic classifiers and later on processed in

[PATCH net-next v2 0/3] BPF updates

2015-09-29 Thread Daniel Borkmann
Some minor updates to {cls,act}_bpf to retrieve routing realms and to make skb->priority writable. Thanks! v1 -> v2: - Dropped preclassify patch for now from the series as the rest is pretty much independent of it - Rest unchanged, only rebased and already posted Acked-by's kept Daniel

[PATCH v2] Documentation: improve line discipline method descriptions

2015-09-29 Thread Tilman Schmidt
Mention that the ldisc open method must set tty->receive_room, and that many methods are optional. Add description of receive_buf2 method. Signed-off-by: Tilman Schmidt --- Documentation/serial/tty.txt | 60 1 file changed, 39

Re: [PATCH v4 0/2] [net] af_unix: return data from multiple SKBs on recv() with MSG_PEEK flag

2015-09-29 Thread David Miller
From: Aaron Conole Date: Sat, 26 Sep 2015 18:50:41 -0400 > This patch set implements a bugfix for kernel.org bugzilla #12323, allowing > MSG_PEEK to return all queued data on the unix domain socket, not just the > data contained in a single SKB. > > This is the v3 version

Re: [PATCH] netpoll: Drop budget parameter from NAPI polling call hierarchy

2015-09-29 Thread David Miller
From: Alexander Duyck Date: Sun, 27 Sep 2015 15:58:56 -0700 > On 09/26/2015 10:36 PM, David Miller wrote: >> From: Alexander Duyck >> Date: Tue, 22 Sep 2015 14:56:08 -0700 >> >>> Rather than carry around a value of budget that is 0 or less we can

[PATCH net-next 3/6] netlink: add a start callback for starting a netlink dump

2015-09-29 Thread Tom Herbert
The start callback allows the caller to set up a context for the dump callbacks. Presumably, the context can then be destroyed in the done callback. Signed-off-by: Tom Herbert --- include/linux/netlink.h | 2 ++ include/net/genetlink.h | 2 ++ net/netlink/af_netlink.c

[PATCH net-next 6/6] ila: Add support for xfrm6_xlat_addr

2015-09-29 Thread Tom Herbert
This patch set up a hook for xfrm6_xlat_addr. This provides a way to perform ILA translation before early demux which can be a significant performance advantage over LWT which would occur later. The implementation entails a rhashtable which is used to do the locator lookup. The rhash table is

[PATCH 1/3] ixgbe/ixgbevf: use napi_schedule_irqoff()

2015-09-29 Thread Alexander Duyck
The ixgbe_intr and ixgbe/ixgbevf_msix_clean_rings functions run from hard interrupt context or with interrupts already disabled in netpoll. They can use napi_schedule_irqoff() instead of napi_schedule() Signed-off-by: Alexander Duyck ---

[PATCH net-next 5/6] ipv6: Call xfrm6_xlat_addr from ipv6_rcv

2015-09-29 Thread Tom Herbert
Call before performing NF_HOOK and routing in order to perform address translation in the receive path. Signed-off-by: Tom Herbert --- net/ipv6/ip6_input.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/ipv6/ip6_input.c b/net/ipv6/ip6_input.c index

Re: [PATCH net 3/7] openvswitch: Fix skb leak in ovs_fragment()

2015-09-29 Thread Joe Stringer
On 29 September 2015 at 15:48, Rustad, Mark D wrote: >> On Sep 29, 2015, at 3:39 PM, Joe Stringer wrote: >> >> @@ -728,8 +727,14 @@ static void ovs_fragment(struct vport *vport, struct >> sk_buff *skb, u16 mru, >> WARN_ONCE(1,

Re: [PATCH net-next v2 00/11] net: L3 master device

2015-09-29 Thread David Miller
From: David Ahern Date: Mon, 28 Sep 2015 10:16:50 -0700 > v2 > - rebased to top of net-next > > - addressed Niks comments (checking master, removing extra lines, and > flipping the order of patches 1 and 2) This still needs some work: ERROR:

Re: [PATCH net-next 5/6] ipv6: Call xfrm6_xlat_addr from ipv6_rcv

2015-09-29 Thread Florian Westphal
Tom Herbert wrote: > Call before performing NF_HOOK and routing in order to perform address > translation in the receive path. > > Signed-off-by: Tom Herbert > --- > net/ipv6/ip6_input.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git

Re: List corruption on epoll_ctl(EPOLL_CTL_DEL) an AF_UNIX socket

2015-09-29 Thread Mathias Krause
On 29 September 2015 at 21:09, Jason Baron wrote: > However, if we call connect on socket 's', to connect to a new socket 'o2', we > drop the reference on the original socket 'o'. Thus, we can now close socket > 'o' without unregistering from epoll. Then, when we either close

Loan Offer

2015-09-29 Thread Loan
Contact us as we offer our finance service at a low and affordable interest rate for long and short cash term. Interested applicant should contact us for further acquisition procedures. Thanks as we remain obliged to render service to you; worldtrading1...@gmail.com -- To unsubscribe from this

Re: [PATCH net-next] netfilter: remove dead code

2015-09-29 Thread Florian Westphal
Flavio Leitner wrote: > Remove __nf_conntrack_find() from headers. > Fixes: dcd93ed4cd1 ("netfilter: nf_conntrack: remove dead code" For the record: netfilter patches should go to netfilter-de...@vger.kernel.org . That being said, in this case I doubt Pablo minds if David takes

[PATCH] net: Initialize flow flags in input path

2015-09-29 Thread David Ahern
The fib_table_lookup tracepoint found 2 places where the flowi4_flags is not initialized. Signed-off-by: David Ahern --- net/ipv4/fib_frontend.c | 1 + net/ipv4/route.c| 1 + 2 files changed, 2 insertions(+) diff --git a/net/ipv4/fib_frontend.c

Re: [PATCH] dsa: mv88e6xxx: Enable forwarding for unknown to the CPU port

2015-09-29 Thread David Miller
From: Andrew Lunn Date: Tue, 29 Sep 2015 01:50:56 +0200 > Frames destined to an unknown address must be forwarded to the CPU > port. Otherwise incoming ARP, dhcp leases, etc, do not work. > > Signed-off-by: Andrew Lunn Applied. -- To unsubscribe from this list:

Re: [PATCH 0/5] y2038 conversion for ntp/pps and sfc driver

2015-09-29 Thread David Miller
From: Arnd Bergmann Date: Mon, 28 Sep 2015 22:21:27 +0200 > When trying to build a kernel with time_t commented out, I found that > the ntp subsystem still relies on timespec for its pps handling. > > This series addresses this and converts all the code to use timespec64 >

Re: [PATCH net] net: dsa: fix preparation of a port STP update

2015-09-29 Thread David Miller
From: Vivien Didelot Date: Tue, 29 Sep 2015 14:17:54 -0400 > Because of the default 0 value of ret in dsa_slave_port_attr_set, a > driver may return -EOPNOTSUPP from the commit phase of a STP state, > which triggers a WARN() from switchdev. > > This happened

Re: [ovs-dev] [PATCH net-next 1/2] openvswitch: add tunnel protocol to sw_flow_key

2015-09-29 Thread Jesse Gross
On Tue, Sep 29, 2015 at 10:52 AM, Jiri Benc wrote: > diff --git a/net/openvswitch/flow_netlink.c b/net/openvswitch/flow_netlink.c > index 5c030a4d7338..03ba070c3256 100644 > --- a/net/openvswitch/flow_netlink.c > +++ b/net/openvswitch/flow_netlink.c > @@ -643,6 +643,7 @@ static

[PATCH net-next 02/11] net: Introduce L3 Master device abstraction

2015-09-29 Thread David Ahern
L3 master devices allow users of the abstraction to influence FIB lookups for enslaved devices. Current API provides a means for the master device to return a specific FIB table for an enslaved device, to return an rtable/custom dst and influence the OIF used for fib lookups. Signed-off-by: David

[PATCH net-next 01/11] net: Rename IFF_VRF_MASTER to IFF_L3MDEV_MASTER

2015-09-29 Thread David Ahern
Rename IFF_VRF_MASTER to IFF_L3MDEV_MASTER and update the name of the netif_is_vrf and netif_index_is_vrf macros. Signed-off-by: David Ahern --- drivers/net/vrf.c | 6 +++--- include/linux/netdevice.h | 14 +++--- include/net/route.h | 2 +-

[PATCH net-next 07/11] net: Remove the now unused vrf_ptr

2015-09-29 Thread David Ahern
Signed-off-by: David Ahern --- drivers/net/vrf.c | 32 ++-- include/linux/netdevice.h | 2 -- include/net/vrf.h | 6 -- 3 files changed, 2 insertions(+), 38 deletions(-) diff --git a/drivers/net/vrf.c

[PATCH net-next 04/11] net: Replace vrf_master_ifindex{,_rcu} with l3mdev equivalents

2015-09-29 Thread David Ahern
Replace calls to vrf_master_ifindex_rcu and vrf_master_ifindex with either l3mdev_master_ifindex_rcu or l3mdev_master_ifindex. The pattern: oif = vrf_master_ifindex(dev) ? : dev->ifindex; is replaced with oif = l3mdev_fib_oif(dev); And remove the now unused vrf macros. Signed-off-by:

[PATCH net-next 05/11] net: Replace vrf_dev_table and friends

2015-09-29 Thread David Ahern
Replace calls to vrf_dev_table and friends with l3mdev_fib_table and kin. Signed-off-by: David Ahern --- include/net/vrf.h | 80 - net/ipv4/af_inet.c | 4 +-- net/ipv4/fib_frontend.c | 7 ++--- 3 files

[PATCH net-next 08/11] net: Remove vrf header file

2015-09-29 Thread David Ahern
Move remaining structs to VRF driver and delete the vrf header file. Signed-off-by: David Ahern --- MAINTAINERS | 1 - drivers/net/vrf.c | 16 +++- include/net/vrf.h | 29 - 3 files changed, 15 insertions(+), 31

[PATCH net-next 03/11] net: Add support for l3mdev ops to VRF driver

2015-09-29 Thread David Ahern
Signed-off-by: David Ahern --- drivers/net/Kconfig | 1 + drivers/net/vrf.c | 29 + 2 files changed, 30 insertions(+) diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig index d18eb607bee6..b9ebd0d18a52 100644 --- a/drivers/net/Kconfig

[PATCH v3 net-next 00/11] net: L3 master device

2015-09-29 Thread David Ahern
The VRF device is essentially a Layer 3 master device used to associate netdevices with a specific routing table and to influence FIB lookups via 'ip rules' and controlling the oif/iif used for the lookup. This series generalizes the VRF into L3 master device, l3mdev. Similar to switchdev it has

Re: [PATCH 00/90] Netfilter/IPVS updates for net-next

2015-09-29 Thread David Miller
From: Pablo Neira Ayuso Date: Tue, 29 Sep 2015 21:25:21 +0200 > Hi David, > > The following pull request contains Netfilter/IPVS updates for net-next > containing 90 patches from Eric Biederman. > > The main goal of this batch is to avoid recurrent lookups for the netns >

[PATCH] net: macb: fix two typos

2015-09-29 Thread Geliang Tang
Just fix two typos in code comments. Signed-off-by: Geliang Tang --- drivers/net/ethernet/cadence/macb.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/cadence/macb.h b/drivers/net/ethernet/cadence/macb.h index 6e1faea..866b128

Re: [PATCH net-next 2/2] openvswitch: netlink attributes for IPv6 tunneling

2015-09-29 Thread Jesse Gross
On Tue, Sep 29, 2015 at 10:52 AM, Jiri Benc wrote: > When compat code for tunnel configuration is used, IPv6 tun_info will be > rejected by ovs_tunnel_get_egress_info. As the consequence, only the new way > of tunnel config supports IPv6. This appears to me to be a bug in the

Re: [net-next:master 414/428] net/ipv6/tcp_ipv6.c:930: warning: passing argument 1 of 'tcp_v6_md5_do_lookup' discards qualifiers from pointer target type

2015-09-29 Thread Eric Dumazet
On Wed, 2015-09-30 at 12:01 +0800, kbuild test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git > master > head: e6934f3ec00b04234acb24a1a2c28af59763d3b5 > commit: a00e74442bac5ad19a929d097370da7e07540ea6 [414/428] tcp/dccp: constify > send_synack and

Re: [PATCH net-next v2 RESEND] BNX2: fix a Null Pointer for stats_blk

2015-09-29 Thread David Miller
From: Weidong Wang Date: Tue, 29 Sep 2015 11:18:18 +0800 > @@ -839,11 +828,12 @@ bnx2_free_mem(struct bnx2 *bp) > } > > static int > -bnx2_alloc_mem(struct bnx2 *bp) > +bnx2_alloc_stats_blk(struct net_device *dev) > { > - int i, status_blk_size, err; > + int

[PATCH net] net: add pfmemalloc check in sk_add_backlog()

2015-09-29 Thread Eric Dumazet
From: Eric Dumazet Greg reported crashes hitting the following check in __sk_backlog_rcv() BUG_ON(!sock_flag(sk, SOCK_MEMALLOC)); The pfmemalloc bit is currently checked in sk_filter(). This works correctly for TCP, because sk_filter() is ran in tcp_v[46]_rcv()

[PATCH net-next 09/11] net: Move netif_index_is_l3_master to l3mdev.h

2015-09-29 Thread David Ahern
Change CONFIG dependency to CONFIG_NET_L3_MASTER_DEV as well. Signed-off-by: David Ahern --- include/linux/netdevice.h | 21 - include/net/l3mdev.h | 24 include/net/route.h | 1 + 3 files changed, 25

[PATCH net-next 06/11] net: Replace calls to vrf_dev_get_rth

2015-09-29 Thread David Ahern
Replace calls to vrf_dev_get_rth with l3mdev_get_rtable. The check on the flow flags is handled in the l3mdev operation. Signed-off-by: David Ahern --- include/net/vrf.h | 22 -- net/ipv4/route.c | 8 +++- 2 files changed, 3 insertions(+), 27

Re: [PATCH] net: Initialize flow flags in input path

2015-09-29 Thread David Miller
From: David Ahern Date: Tue, 29 Sep 2015 19:07:07 -0700 > The fib_table_lookup tracepoint found 2 places where the flowi4_flags is > not initialized. > > Signed-off-by: David Ahern Applied, thanks David. -- To unsubscribe from this list:

Re: [PATCH v3 net-next 00/11] net: L3 master device

2015-09-29 Thread David Miller
From: David Ahern Date: Tue, 29 Sep 2015 20:07:09 -0700 > v3 > - added license header to l3mdev.c > > - export symbols in l3mdev.c for use with GPL modules > > - removed netdevice header from l3mdev.h (not needed) and fixed > typo in comment Series applied, thanks

Re: [PATCH] testptp: Silence compiler warnings on ppc64

2015-09-29 Thread David Miller
From: Thomas Huth Date: Tue, 29 Sep 2015 17:45:28 +0200 > When compiling Documentation/ptp/testptp.c the following compiler > warnings are printed out: ... > This happens because __s64 is by default defined as "long" on ppc64, > not as "long long". However, to fix these

Re: [PATCH v2] net/mlx4: Handle return codes in mlx4_qp_attach_common

2015-09-29 Thread David Miller
From: Robb Manes Date: Tue, 29 Sep 2015 11:03:37 -0400 > Both new_steering_entry() and existing_steering_entry() return values > based on their success or failure, but currently they fall through > silently. This can make troubleshooting difficult, as we were unable > to tell

Re: [PATCH net-next v2] net: Add support for filtering neigh dump by master device

2015-09-29 Thread roopa
On 9/29/15, 9:32 AM, David Ahern wrote: Add support for filtering neighbor dumps by master device by adding the NDA_MASTER attribute to the dump request. A new netlink flag, NLM_F_DUMP_FILTERED, is added to indicate the kernel supports the request and output is filtered as requested.

Re: [PATCH net-next] net: dsa: fix preparation of a port STP update

2015-09-29 Thread David Miller
From: Vivien Didelot Date: Tue, 29 Sep 2015 12:38:36 -0400 > Because of the default 0 value of ret in dsa_slave_port_attr_set, a > driver may return -EOPNOTSUPP from the commit phase of a STP state, > which triggers a WARN() from switchdev. > > This happened

Re: [PATCH] net: macb: fix two typos

2015-09-29 Thread David Miller
From: Geliang Tang Date: Tue, 29 Sep 2015 19:31:32 -0700 > Just fix two typos in code comments. > > Signed-off-by: Geliang Tang Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to

Re: [PATCH net-next] netfilter: remove dead code

2015-09-29 Thread David Miller
From: Florian Westphal Date: Wed, 30 Sep 2015 02:45:07 +0200 > Flavio Leitner wrote: >> Remove __nf_conntrack_find() from headers. >> Fixes: dcd93ed4cd1 ("netfilter: nf_conntrack: remove dead code" > > For the record: netfilter patches should go to >

[net-next:master 414/428] net/ipv6/tcp_ipv6.c:930: warning: passing argument 1 of 'tcp_v6_md5_do_lookup' discards qualifiers from pointer target type

2015-09-29 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: e6934f3ec00b04234acb24a1a2c28af59763d3b5 commit: a00e74442bac5ad19a929d097370da7e07540ea6 [414/428] tcp/dccp: constify send_synack and send_reset socket argument config: avr32-atngw100_defconfig (attached

Re: [net-next:master 414/428] net/ipv6/tcp_ipv6.c:930: warning: passing argument 1 of 'tcp_v6_md5_do_lookup' discards qualifiers from pointer target type

2015-09-29 Thread David Miller
From: Eric Dumazet Date: Tue, 29 Sep 2015 21:10:28 -0700 > Thanks, probably a matter of applying this patch. Looks obvious enough, please submit this formally, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to

Re: [PATCH net-next] dsa: mv88e6xxx: Fix unsigned/signed issue

2015-09-29 Thread David Miller
From: Andrew Lunn Date: Tue, 29 Sep 2015 01:53:48 +0200 > commit dea870242a9c ("dsa: mv88e6xxx: Allow speed/duplex of port to be > configured") leads to the following static checker warning: > > drivers/net/dsa/mv88e6xxx.c:585 mv88e6xxx_adjust_link() > warn:

Re: [PATCH 0/5] net: m68k: Allow modular build

2015-09-29 Thread David Miller
From: Geert Uytterhoeven Date: Tue, 29 Sep 2015 10:24:01 +0200 > This patch series makes the remaining m68k Ethernet drivers modular. > It's an alternative to the last 3 patches of Paul Gortmaker's series > "[PATCH net-next 0/6] make non-modular code explicitly

Re: [net-next:master 414/428] net/ipv6/tcp_ipv6.c:930: warning: passing argument 1 of 'tcp_v6_md5_do_lookup' discards qualifiers from pointer target type

2015-09-29 Thread Eric Dumazet
On Tue, 2015-09-29 at 21:12 -0700, David Miller wrote: > From: Eric Dumazet > Date: Tue, 29 Sep 2015 21:10:28 -0700 > > > Thanks, probably a matter of applying this patch. > > Looks obvious enough, please submit this formally, thanks. Sure ! I am compiling ;) -- To

Re: [PATCH bluetooth-next 1/4] netlink: add nla_get for le32 and le64

2015-09-29 Thread David Miller
From: Marcel Holtmann Date: Tue, 29 Sep 2015 18:08:32 +0200 > do you have any objections to me taking this change through the > bluetooth-next tree? No objections. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to

[PATCH net-next] tcp: fix tcp_v6_md5_do_lookup prototype

2015-09-29 Thread Eric Dumazet
From: Eric Dumazet tcp_v6_md5_do_lookup() now takes a const socket, even if CONFIG_TCP_MD5SIG is not set. Fixes: b83e3deb974c ("tcp: md5: constify tcp_md5_do_lookup() socket argument") From: Eric Dumazet Reported-by: kbuild test robot

Re: [PATCH v2 net-next 0/6] net: switchdev: use specific switchdev_obj_*

2015-09-29 Thread David Miller
From: Vivien Didelot Date: Tue, 29 Sep 2015 12:07:12 -0400 > This patchset changes switchdev add, del, dump operations from this: ... > to something similar to the notifier_call callback of a notifier_block: ... > This allows the caller to pass and expect

Re: [PATCH net-next] tcp: fix tcp_v6_md5_do_lookup prototype

2015-09-29 Thread Eric Dumazet
On Tue, 2015-09-29 at 21:24 -0700, Eric Dumazet wrote: > From: Eric Dumazet > > tcp_v6_md5_do_lookup() now takes a const socket, even if > CONFIG_TCP_MD5SIG is not set. > > Fixes: b83e3deb974c ("tcp: md5: constify tcp_md5_do_lookup() socket argument") > From: Eric Dumazet

Re: [PATCH net-next] tcp: fix tcp_v6_md5_do_lookup prototype

2015-09-29 Thread David Miller
From: Eric Dumazet Date: Tue, 29 Sep 2015 21:24:05 -0700 > From: Eric Dumazet > > tcp_v6_md5_do_lookup() now takes a const socket, even if > CONFIG_TCP_MD5SIG is not set. > > Fixes: b83e3deb974c ("tcp: md5: constify tcp_md5_do_lookup() socket

Re: [PATCH net-next v2] net: Add support for filtering neigh dump by master device

2015-09-29 Thread David Miller
From: David Ahern Date: Tue, 29 Sep 2015 09:32:03 -0700 > Add support for filtering neighbor dumps by master device by adding > the NDA_MASTER attribute to the dump request. A new netlink flag, > NLM_F_DUMP_FILTERED, is added to indicate the kernel supports the >

Re: [PATCH net] net: add pfmemalloc check in sk_add_backlog()

2015-09-29 Thread David Miller
From: Eric Dumazet Date: Tue, 29 Sep 2015 18:52:25 -0700 > From: Eric Dumazet > > Greg reported crashes hitting the following check in __sk_backlog_rcv() > > BUG_ON(!sock_flag(sk, SOCK_MEMALLOC)); > > The pfmemalloc bit is currently checked

Re: [PATCH RFC 1/7] netfilter: add socket to struct nft_pktinfo

2015-09-29 Thread Eric W. Biederman
Daniel Mack writes: > The high-level netfilter hook API already enables users to pass a socket, > but that information is lost when the chains are walked. > > In order to let internal eval callbacks use the passed filter rather than > skb->sk, add a pointer of type 'struct

Re: 4.3-rc3 Regression: NFS access stall by commit 6ae459bdaaee

2015-09-29 Thread Pravin Shelar
On Tue, Sep 29, 2015 at 3:33 AM, Takashi Iwai wrote: > On Tue, 29 Sep 2015 02:35:04 +0200, > Pravin Shelar wrote: >> >> On Mon, Sep 28, 2015 at 6:12 AM, Takashi Iwai wrote: >> > [I resent this since the previous mail didn't go out properly, as it >> > seems;

Re: [MM PATCH V4 5/6] slub: support for bulk free with SLUB freelists

2015-09-29 Thread Alexander Duyck
On 09/29/2015 10:00 AM, Jesper Dangaard Brouer wrote: On Tue, 29 Sep 2015 09:38:30 -0700 Alexander Duyck wrote: On 09/29/2015 08:48 AM, Jesper Dangaard Brouer wrote: +#if defined(CONFIG_KMEMCHECK) || \ + defined(CONFIG_LOCKDEP) || \

Re: [PATCH] testptp: Silence compiler warnings on ppc64

2015-09-29 Thread Richard Cochran
On Tue, Sep 29, 2015 at 05:45:28PM +0200, Thomas Huth wrote: > This happens because __s64 is by default defined as "long" on ppc64, > not as "long long". However, to fix these warnings, it's possible to > define the __SANE_USERSPACE_TYPES__ so that __s64 gets defined to > "long long" on ppc64,

[PATCH net-next 1/2] openvswitch: add tunnel protocol to sw_flow_key

2015-09-29 Thread Jiri Benc
Store tunnel protocol (AF_INET or AF_INET6) in sw_flow_key. This field now also acts as an indicator whether the flow contains tunnel data (this was previously indicated by tun_key.u.ipv4.dst being set but with IPv6 addresses in an union with IPv4 ones this won't work anymore). The new field was

[PATCH net-next 0/2] openvswitch: add IPv6 tunneling support

2015-09-29 Thread Jiri Benc
This builds on the previous work that added IPv6 support to lwtunnels and adds IPv6 tunneling support to ovs; it is now pretty straightforward. To use IPv6 tunneling, there needs to be a metadata based tunnel net_device created and added to the ovs bridge. Currently, only vxlan is supported by

Re: List corruption on epoll_ctl(EPOLL_CTL_DEL) an AF_UNIX socket

2015-09-29 Thread Mathias Krause
On 14 September 2015 at 04:39, Eric Wong wrote: > +cc Jason Baron since he might be able to provide more insight into > epoll. > > Mathias Krause wrote: >> Hi, >> >> this is an attempt to resurrect the thread initially started here: >> >>

Re: [PATCH net-next 0/4] ila: Use NF_INET_PRE_ROUTING nfhook

2015-09-29 Thread Tom Herbert
On Mon, Sep 28, 2015 at 4:00 PM, Florian Westphal wrote: > Tom Herbert wrote: >> RFC6296 doesn't work because it allows an invalid checksum to be sent >> on wire relative to the addresses used on the wire. That means we >> would lose CHECKSUM_UNNECESSARY for

[PATCH net-next 2/2] openvswitch: netlink attributes for IPv6 tunneling

2015-09-29 Thread Jiri Benc
Add netlink attributes for IPv6 tunnel addresses. This enables IPv6 support for tunnels. When compat code for tunnel configuration is used, IPv6 tun_info will be rejected by ovs_tunnel_get_egress_info. As the consequence, only the new way of tunnel config supports IPv6. Signed-off-by: Jiri Benc

Re: [MM PATCH V4 5/6] slub: support for bulk free with SLUB freelists

2015-09-29 Thread Jesper Dangaard Brouer
On Tue, 29 Sep 2015 10:20:20 -0700 Alexander Duyck wrote: > On 09/29/2015 10:00 AM, Jesper Dangaard Brouer wrote: > > On Tue, 29 Sep 2015 09:38:30 -0700 > > Alexander Duyck wrote: > > > >> On 09/29/2015 08:48 AM, Jesper Dangaard Brouer

Re: [PATCH nf-next] bridge: Pass net into br_validate_ipv4 and br_validate_ipv6

2015-09-29 Thread Pablo Neira Ayuso
On Fri, Sep 25, 2015 at 04:52:51PM -0500, Eric W. Biederman wrote: > > The network namespace is easiliy available in state->net so use it. Also applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More

Re: [PATCH next 0/5] netfilter: Pass net into ip_route_me_harder

2015-09-29 Thread Pablo Neira Ayuso
On Fri, Sep 25, 2015 at 03:01:42PM -0500, Eric W. Biederman wrote: > > This is the next installment of my work to pass struct net through the > output path so the code does not need to guess how to figure out which > network namespace it is in, and ultimately routes can have output > devices in

Re: List corruption on epoll_ctl(EPOLL_CTL_DEL) an AF_UNIX socket

2015-09-29 Thread Jason Baron
On 09/29/2015 02:09 PM, Mathias Krause wrote: > On 14 September 2015 at 04:39, Eric Wong wrote: >> +cc Jason Baron since he might be able to provide more insight into >> epoll. >> >> Mathias Krause wrote: >>> Hi, >>> >>> this is an attempt to

[PATCH 00/90] Netfilter/IPVS updates for net-next

2015-09-29 Thread Pablo Neira Ayuso
Hi David, The following pull request contains Netfilter/IPVS updates for net-next containing 90 patches from Eric Biederman. The main goal of this batch is to avoid recurrent lookups for the netns pointer, that happens over and over again in our Netfilter/IPVS code. The idea consists of passing

[PATCH net-next] net/mlx4_core: Test interrupts fail if not all comp vectors called request_irq

2015-09-29 Thread clsoto
From: Carol L Soto Test interrupts fails if not all completion vectors called request_irq. This case can happen if only mlx4_en loads and we have more completion vectors than rx rings. Signed-off-by: Carol L Soto ---

Re: [PATCH v2 0/7] net: mvneta: Switch to per-CPU irq and make rxq_def useful

2015-09-29 Thread David Miller
From: Gregory CLEMENT Date: Fri, 25 Sep 2015 18:09:31 +0200 > As stated in the first version: "this patchset reworks the Marvell > neta driver in order to really support its per-CPU interrupts, instead > of faking them as SPI, and allow the use of any RX queue

Re: [PATCH net-next] net: dsa: fix preparation of a port STP update

2015-09-29 Thread Vivien Didelot
On Sep. Tuesday 29 (40) 06:42 PM, Andrew Lunn wrote: > On Tue, Sep 29, 2015 at 12:38:36PM -0400, Vivien Didelot wrote: > > Because of the default 0 value of ret in dsa_slave_port_attr_set, a > > driver may return -EOPNOTSUPP from the commit phase of a STP state, > > which triggers a WARN() from

<    1   2   3   >