On 10/12/2015 03:15 PM, Jiri Pirko wrote:
> From: Jiri Pirko
>
> Similar to the attr usecase, the caller knows if he is holding RTNL and is
> in atomic section. So let the called to decide the correct call variant.
>
> This allows drivers to sleep inside their ops and wait for hw to get the
> op
pling/20151012-170616
config: m68k-allyesconfig (attached as .config)
reproduce:
wget
https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross
-O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build
Hello.
On 10/11/2015 2:40 AM, Thomas F Herbert wrote:
Signed-off-by: Thomas F Herbert
---
include/linux/if_vlan.h | 17 +
1 file changed, 17 insertions(+)
diff --git a/include/linux/if_vlan.h b/include/linux/if_vlan.h
index 67ce5bd..88d1be4 100644
--- a/include/linux/if_vla
Christoph Hellwig writes:
> On Fri, Oct 09, 2015 at 04:05:17PM -0500, Felipe Balbi wrote:
>> Pratyush Anand writes:
>>
>> > On Sat, Oct 3, 2015 at 7:02 PM, Christoph Hellwig wrote:
>> >> Signed-off-by: Christoph Hellwig
>> >
>> > Acked-by: Pratyush Anand
>>
>> I don't seem to have the actua
On Mon, 2015-10-12 at 13:54 +0100, Rainer Weikusat wrote:
> David Miller writes:
> > From: Jason Baron
> > Date: Fri, 9 Oct 2015 00:15:59 -0400
> >
> >> These patches are against mainline, I can re-base to net-next, please
> >> let me know.
> >>
> >> They have been tested against: https://lkml.
From: Jiri Pirko
This is going to be used for deferred operations.
Signed-off-by: Jiri Pirko
---
include/net/switchdev.h | 5 +
net/switchdev/switchdev.c | 19 +++
2 files changed, 24 insertions(+)
diff --git a/include/net/switchdev.h b/include/net/switchdev.h
index 1ce
From: Jiri Pirko
netdev_for_each_lower_dev has to be called with rtnl mutex held. So
better enforce it in switchdev functions.
Signed-off-by: Jiri Pirko
---
net/switchdev/switchdev.c | 15 +++
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/net/switchdev/switchdev.c
From: Jiri Pirko
Similar to the attr usecase, the caller knows if he is holding RTNL and is
in atomic section. So let the called to decide the correct call variant.
This allows drivers to sleep inside their ops and wait for hw to get the
operation status. Then the status is propagated into switc
From: Jiri Pirko
Caller should know if he can call attr_set directly (when holding RTNL)
or if he has to defer the att_set processing for later.
This also allows drivers to sleep inside attr_set and report operation
status back to switchdev core. Switchdev core then warns if status is
not ok, in
From: Jiri Pirko
Since spinlock is held here, defer the switchdev operation.
Signed-off-by: Jiri Pirko
---
net/bridge/br_fdb.c | 5 -
net/bridge/br_if.c | 3 +++
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/net/bridge/br_fdb.c b/net/bridge/br_fdb.c
index f5e7da0..c88bd8e
From: Jiri Pirko
No need to avoid sleeping in switchdev callbacks now, as the switchdev
core allows it.
Signed-off-by: Jiri Pirko
---
drivers/net/ethernet/rocker/rocker.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/rocker/rocker.c
b/drivers/
From: Jiri Pirko
When object is used in deferred work, we cannot use pointers in
switchdev object structures because the memory they point at may be already
used by someone else. So rather do local copy of the value.
Signed-off-by: Jiri Pirko
---
drivers/net/ethernet/rocker/rocker.c | 6 +++--
From: Jiri Pirko
This is something which I'm currently struggling with.
Callers of attr_set and obj_add/del often hold not only RTNL, but also
spinlock (bridge). So in that case, the driver implementing the op cannot sleep.
The way rocker is dealing with this now is just to invoke driver operati
David Miller writes:
> From: Jason Baron
> Date: Fri, 9 Oct 2015 00:15:59 -0400
>
>> These patches are against mainline, I can re-base to net-next, please
>> let me know.
>>
>> They have been tested against: https://lkml.org/lkml/2015/9/13/195,
>> which causes the use-after-free quite quickly a
From: Nikolay Aleksandrov
VLANs 0 and 4095 are reserved and shouldn't be used, add checks to
switchdev similar to the bridge. Also make sure ids above 4095 cannot
be passed either.
Fixes: 47f8328bb1a4 ("switchdev: add new switchdev bridge setlink")
Signed-off-by: Nikolay Aleksandrov
---
net/sw
> On Oct 12, 2015, at 3:01 PM, Nikolay Aleksandrov wrote:
>
> From: Nikolay Aleksandrov
>
> We shouldn't allow BRIDGE_VLAN_INFO_PVID flag in VLAN ranges.
>
> Signed-off-by: Nikolay Aleksandrov
> ---
> net/switchdev/switchdev.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/net/s
On Mon, 2015-10-12 at 11:34 +0200, Dmitry Vyukov wrote:
> Hello,
>
> The following program causes episodic crashes:
>
> // autogenerated by syzkaller (http://github.com/google/syzkaller)
> #include
> #define CLONE_NEWNET 0x4000
> int main(void)
> {
> unshare(CLONE_NEWNET);
> }
>
> O
From: Geliang Tang
Date: Fri, 9 Oct 2015 03:45:39 -0700
> pcnet32 can't work on my machine recently. It says "architecture
> does not support 32bit PCI busmaster DMA". There is a logic error
> in it: pci_set_dma_mask() return 0 means return successfully.
>
> Signed-off-by: Geliang Tang
This d
From: Shradha Shah
Date: Fri, 9 Oct 2015 10:40:35 +0100
> From: Daniel Pieczko
>
> On EF10, MC_CMD_VPORT_RECONFIGURE can cause a CODE_MC_REBOOT event
> to be sent to a function without incrementing the (adapter-wide)
> warm_boot_count. In this case, the reboot is not detected by the
> loop on
On Mon, Oct 12, 2015 at 2:14 PM, Eric Dumazet wrote:
> On Mon, 2015-10-12 at 14:02 +0200, Michal Kubecek wrote:
>
>> Probably the issue discussed in
>>
>> http://thread.gmane.org/gmane.linux.kernel/2057497/
>>
>> and previous related threads.
>>
>
> Same issue, but Dmitry apparently did not trus
Mon, Oct 12, 2015 at 02:01:39PM CEST, ra...@blackwall.org wrote:
>From: Nikolay Aleksandrov
>
>We shouldn't allow BRIDGE_VLAN_INFO_PVID flag in VLAN ranges.
>
>Signed-off-by: Nikolay Aleksandrov
Acked-by: Jiri Pirko
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the bod
From: Shradha Shah
Date: Fri, 9 Oct 2015 10:18:56 +0100
> static void efx_remove_port(struct efx_nic *efx);
> -static void efx_init_napi_channel(struct efx_channel *channel);
> +static int efx_init_napi_channel(struct efx_channel *channel);
The changes to modify the call chain to return a statu
On Mon, 2015-10-12 at 14:02 +0200, Michal Kubecek wrote:
> Probably the issue discussed in
>
> http://thread.gmane.org/gmane.linux.kernel/2057497/
>
> and previous related threads.
>
Same issue, but Dmitry apparently did not trust me.
--
To unsubscribe from this list: send the line "unsubs
On Mon, Oct 12, 2015 at 08:05:20PM +0800, Wangnan (F) wrote:
>
>
> On 2015/10/12 20:02, Peter Zijlstra wrote:
> >On Mon, Oct 12, 2015 at 09:02:42AM +, Kaixu Xia wrote:
> >>--- a/include/linux/perf_event.h
> >>+++ b/include/linux/perf_event.h
> >>@@ -483,6 +483,8 @@ struct perf_event {
> >>
On 2015/10/12 20:02, Peter Zijlstra wrote:
On Mon, Oct 12, 2015 at 09:02:42AM +, Kaixu Xia wrote:
--- a/include/linux/perf_event.h
+++ b/include/linux/perf_event.h
@@ -483,6 +483,8 @@ struct perf_event {
perf_overflow_handler_t overflow_handler;
void
From: sfel...@gmail.com
Date: Thu, 8 Oct 2015 19:23:16 -0700
> From: Scott Feldman
>
> Push bridge-level attributes down to switchdev drivers. This patchset
> adds the infrastructure and then pushes, as an example, ageing_time attribute
> down from bridge to switchdev (rocker) driver. Add som
On Mon, Oct 12, 2015 at 09:02:42AM +, Kaixu Xia wrote:
> --- a/include/linux/perf_event.h
> +++ b/include/linux/perf_event.h
> @@ -483,6 +483,8 @@ struct perf_event {
> perf_overflow_handler_t overflow_handler;
> void*overflow_handler_context;
>
On Mon, Oct 12, 2015 at 01:07:55PM +0200, Dmitry Vyukov wrote:
> Hello,
>
> The following program causes use-after-in kernel:
>
...
> long r0 = syscall(SYS_mmap, 0x20001000ul, 0x1000ul, 0x3ul,
> 0x32ul, 0xul, 0x0ul);
> long r1 = syscall(SYS_mmap, 0x2000ul, 0x10
From: Nikolay Aleksandrov
We shouldn't allow BRIDGE_VLAN_INFO_PVID flag in VLAN ranges.
Signed-off-by: Nikolay Aleksandrov
---
net/switchdev/switchdev.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/net/switchdev/switchdev.c b/net/switchdev/switchdev.c
index 6e4a4f9ad927..256c596de896
On Monday 12 October 2015 11:23:44 huangdaode wrote:
> + s += sprintf(s,
> + "\t\ttx_ring on
> %p:%u,%u,%u,%u,%u,%llu,%llu\n",
> + h->qs[i]->tx_ring.io_base,
> + h->qs[i]->tx
From: Richard Sailer
Date: Fri, 9 Oct 2015 02:41:37 +0200
> The alive parameter of tcp_orphan_retries, indicates
> whether the connection is assumed alive or not.
> In the function and all places calling it is used as a boolean value.
>
> Therefore this changes the type of alive to bool in the
From: Roopa Prabhu
Date: Thu, 8 Oct 2015 10:38:52 -0700
> From: Roopa Prabhu
>
> This patch enables adding of fdb entries pointing to the bridge device.
> This can be used to propagate mac address of vlan interfaces
> configured on top of the vlan filtering bridge.
>
> Before:
> $bridge fdb a
On Monday 12 October 2015 11:38:24 huangdaode wrote:
> On 2015/10/12 11:24, Joe Perches wrote:
> > Hello Huang.
> >
> > On Mon, 2015-10-12 at 11:23 +0800, huangdaode wrote:
> >> This patch changes the code style to make the code more simple.
> >> also removes the once used HNADEL_TX_MSG macro, acco
From: Nikolay Aleksandrov
As Ido Schimmel pointed out the vlan_vid_del() loop in nbp_vlan_flush is
unnecessary (and is actually a remnant of the old vlan code) so we can
remove it and combine both br/nbp vlan_flush functions into one.
Signed-off-by: Nikolay Aleksandrov
---
net/bridge/br_if.c
From: Nikolay Aleksandrov
br_fill_ifinfo is called by br_ifinfo_notify which can be called from
many contexts with different locks held, sometimes it relies upon
bridge's spinlock only which is a problem for the vlan code, so use
explicitly rcu for that to avoid problems.
Signed-off-by: Nikolay
From: Nikolay Aleksandrov
Hi,
Patch 01 converts the vlgrp member to use rcu as it was already used in a
similar way so better to make it official and use all the available RCU
instrumentation. Patch 02 fixes a bug where the vlan_list can be traversed
without rtnl or rcu held which could lead to u
From: Nikolay Aleksandrov
Ido Schimmel reported a problem with switchdev devices because of the
order change of del_nbp operations, more specifically the move of
nbp_vlan_flush() which deletes all vlans and frees vlgrp after the
rx_handler has been unregistered. So in order to fix this break
vlan
From: Nikolay Aleksandrov
The bridge and port's vlgrp member is already used in RCU way, currently
we rely on the fact that it cannot disappear while the port exists but
that is error-prone and we might miss places with improper locking
(either RCU or RTNL must be held to walk the vlan_list). So
Hello,
The following program causes use-after-in kernel:
// autogenerated by syzkaller (http://github.com/google/syzkaller)
#include
#include
#include
int main()
{
long r0 = syscall(SYS_mmap, 0x20001000ul, 0x1000ul, 0x3ul,
0x32ul, 0xul, 0x0ul);
long r1 = syscal
J. Bruce Fields wrote:
> On Fri, Oct 09, 2015 at 06:29:44AM +, Kosuke Tatsukawa wrote:
>> Neil Brown wrote:
>> > Kosuke Tatsukawa writes:
>> >
>> >> There are several places in net/sunrpc/svcsock.c which calls
>> >> waitqueue_active() without calling a memory barrier. Add a memory
>> >> barr
On 10/12/2015 07:14 AM, Scott Feldman wrote:
> On Sun, Oct 11, 2015 at 5:13 PM, Nikolay Aleksandrov
> wrote:
>> On 10/12/2015 12:41 AM, Vivien Didelot wrote:
>>> On Oct. Sunday 11 (41) 09:12 AM, Jiri Pirko wrote:
Sat, Oct 10, 2015 at 12:36:26PM CEST, niko...@cumulusnetworks.com wrote:
> O
Sun, Oct 11, 2015 at 05:21:04PM CEST, j...@resnulli.us wrote:
>From: Jiri Pirko
>
>This is something which I'm currently struggling with.
>Callers of attr_set and obj_add/del often hold not only RTNL, but also
>spinlock (bridge). So in that case, the driver implementing the op cannot
>sleep.
>
>T
Hi,
I tried on linux-4.1:
linux:~# cat /proc/sys/net/ipv4/tcp_mem
8388608 1258291216777216
linux:~# echo 1234 >/proc/sys/net/ipv4/tcp_mem
-bash: echo: write error: Invalid argument
linux:~# cat /proc/sys/net/ipv4/tcp_mem
12341258291216777216
Hello,
The following program causes episodic crashes:
// autogenerated by syzkaller (http://github.com/google/syzkaller)
#include
#define CLONE_NEWNET 0x4000
int main(void)
{
unshare(CLONE_NEWNET);
}
On commit dd36d7393d6310b0c1adefb22fba79c3cf8a577c
(git://git.kernel.org/pub/scm/li
Hello,
The following program causes infinite loop in ip6_fragment function:
// autogenerated by syzkaller (http://github.com/google/syzkaller)
#include
#include
#include
int main()
{
long r0 = syscall(SYS_socket, 0xaul, 0x3ul, 0x53cul);
long r1 = syscall(SYS_mmap, 0x2000ul
In some scenarios we don't want to output trace data when perf sampling
in order to reduce overhead. For example, perf can be run as daemon to
dump trace data when necessary, such as the system performance goes down.
This patchset adds the helpers bpf_perf_event_sample_enable/disable() to
implemen
The functions bpf_perf_event_sample_enable/disable() can set the
flag sample_disable to enable/disable output trace data on samples.
Signed-off-by: Kaixu Xia
---
include/linux/bpf.h | 2 ++
include/uapi/linux/bpf.h | 2 ++
kernel/bpf/verifier.c| 4 +++-
kernel/trace/bpf_trace.c | 34
In some scenarios we don't want to output trace data when sampling
to reduce overhead. This patch adds the flag sample_disable to
implement this function. By setting this flag and integrating with
ebpf, we can control the data output process and get the samples we
are most interested in.
Signed-of
On 10/09/2015 04:25 PM, Yaowei Bai wrote:
>> Yaowei, feel free to send the CAN patch as part of your series directly
>> to David.
>
> OK, i'll do that and sorry for disturbing you. :)
Putting me on Cc was 100% correct, but IMHO no need to split up the
series when David can apply it in one go.
re
On Friday 09 October 2015 03:36 PM, Mugunthan V N wrote:
> cpdma is capable of placing the dma descriptors in ddr using
> dma_alloc_coherent() when the internal bd ram size is not enough.
> To utilize this feature pass the DT parameter "no_bd_ram" and
> increase bd_ram_size and number of rx descrip
Use kstrdup instead of strlen-kmalloc-strcpy. Remove unneeded NULL
test, it will be tested inside kstrdup. Remove 0 length string test,
it has been tested in the caller of dsp_pipeline_build.
Signed-off-by: Geliang Tang
---
Changes in v2:
- Remove unneeded NULL test.
---
drivers/isdn/mISDN/dsp
On Fri, 9 Oct 2015, Grygorii Strashko wrote:
> I can constantly see below error report with 4.1 RT-kernel on TI ARM dra7-evm
> if I'm trying to unplug cpu1:
>
> [ 57.737589] CPU1: shutdown
> [ 57.767537] BUG: spinlock bad magic on CPU#0, sh/137
> [ 57.767546] lock: 0xee994730, .magic:
From: Kalesh AP
The commit 435452aa8847 ("Prevent VFs from enabling VLAN promiscuous mode")
fixed the PF driver to not include the VLAN promisc capability while
provisioning the interface for a VF. But the fix did not remove this
capability from the profile descriptor of the VF. This causes the V
From: Suresh Reddy
On BE3 chips in SRIOV configs, the TX path stalls when a packet less
than 32B is received from the host. A workaround to pad such packets
already exists for the Skyhawk and Lancer chips. Use the same workaround
for BE3 chips too.
Signed-off-by: Suresh Reddy
Signed-off-by: Sat
From: Kalesh AP
In the BE3 FW image, unlike Skyhawk's, the "asic_type_rev" field doesn't
track the asic_rev of chip it is compatible with. When asic_type_rev
is 0 the image is compatible only with pre-BE3-R chips (asic_rev < 0x10).
Fix the current compatibility check to take care of this.
We hit
From: Somnath Kotur
The FW requires the pf_num field in the cmd hdr to be set for it to return
the specific function's descriptors in the GET_PROFILE_CONFIG cmd. If not
set, the FW returns the descriptors of all the functions on the device.
If the first descriptor is not what is being queried for
Patch 1 fixes a FW image compatibility check in the driver that
prevents certain FW images from being flashed on BE3 (not BE3-R)
adapters.
Patch 2 fixes a spin_lock not being released in a failure case in
be_cmd_notify_wait().
Patch 3 includes a workaround to pad packets that are only 32b long or
From: Suresh Reddy
The mcc/mbox lock is not being released when be_cmd_copy() returns
an error.
Signed-off-by: Suresh Reddy
Signed-off-by: Sathya Perla
---
drivers/net/ethernet/emulex/benet/be_cmds.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethern
2015-10-11 23:03 GMT+02:00 Roopa Prabhu :
> From: Wilson Kok
>
> This patch adds support to batch bridge commands.
> Follows ip batch code.
>
> Signed-off-by: Wilson Kok
> Signed-off-by: Roopa Prabhu
> Acked-by: Christophe Gouault
> ---
> v2 - change tab to space in usage as pointed out by Chri
Le 09/10/2015 20:42, Eric W. Biederman a écrit :
This is the next installment of my work to pass struct net through the
output path so the code does not need to guess how to figure out which
network namespace it is in, and ultimately routes can have output
devices in another network namespace.
commit afae5ad78b342f401c28b0bb1adb3cd494cb125a
"net/fsl_pq_mdio: streamline probing of MDIO nodes"
added support for different types of MDIO devices:
1) Gianfar MDIO nodes that only map the MII registers
2) Gianfar MDIO nodes that map the full MDIO register set
3) eTSEC2 MDIO nodes (which map t
When configuring the MDIO subsystem it is also necessary to configure
the TBI register. Make sure the TBI is contained within the mapped
register range in order to:
a) make sure the address is computed correctly
b) make users aware that we're actually accessing that register
In case of error, prin
Hi Jason,
Your analysis is correct.
The issue was initially reported by Valdis Kletnieks (valdis.kletni...@vt.edu)
http://lists.osuosl.org/pipermail/intel-wired-lan/Week-of-Mon-20150615/000992.html
Commit 37b12910dd11d9ab969f2c310dc9160b7f3e3405 fixes the lockup issue, and
according to my last c
201 - 263 of 263 matches
Mail list logo
