Re: [PATCH 1/1] commit c6825c0976fa7893692e0e43b09740b419b23c09 upstream.

2015-10-28 Thread Neal P. Murphy
On Mon, 26 Oct 2015 21:06:33 +0100 Pablo Neira Ayuso wrote: > Hi, > > On Mon, Oct 26, 2015 at 11:55:39AM -0700, Ani Sinha wrote: > > netfilter: nf_conntrack: fix RCU race in nf_conntrack_find_get > > Please, no need to Cc everyone here. Please, submit your Netfilter > patches to netfilter-de...

Re: [PATCH v2 1/3] virtio_net: Stop doing DMA from the stack

2015-10-28 Thread Michael S. Tsirkin
On Tue, Oct 27, 2015 at 10:30:19PM -0700, Andy Lutomirski wrote: > From: Andy Lutomirski > > Once virtio starts using the DMA API, we won't be able to safely DMA > from the stack. virtio-net does a couple of config DMA requests > from small stack buffers -- switch to using dynamically-allocated

Re: [PATCH v1 1/3] virtio-net: Using single MSIX IRQ for TX/RX Q pair

2015-10-28 Thread Michael S. Tsirkin
On Wed, Oct 28, 2015 at 11:13:39AM +0800, Jason Wang wrote: > > > On 10/27/2015 04:38 PM, Michael S. Tsirkin wrote: > > On Mon, Oct 26, 2015 at 10:52:47AM -0700, Ravi Kerur wrote: > >> Ported earlier patch from Jason Wang (dated 12/26/2014). > >> > >> This patch tries to reduce the number of MSIX

Re: [PATCH v2 net-next 0/4] Automatic adjustment of max frame size

2015-10-28 Thread Toshiaki Makita
On 15/10/28 (水) 13:58, Stephen Hemminger wrote: On Mon, 26 Oct 2015 12:40:55 +0900 Toshiaki Makita wrote: ... Thank you for taking a look at the patch set. I'm not sure if I fully understand you, so please correct me if I misread you. The problem is that you require changing network device

Re: [PATCH v1 1/3] virtio-net: Using single MSIX IRQ for TX/RX Q pair

2015-10-28 Thread Jason Wang
On 10/28/2015 03:21 PM, Michael S. Tsirkin wrote: > On Wed, Oct 28, 2015 at 11:13:39AM +0800, Jason Wang wrote: >> >> On 10/27/2015 04:38 PM, Michael S. Tsirkin wrote: >>> On Mon, Oct 26, 2015 at 10:52:47AM -0700, Ravi Kerur wrote: Ported earlier patch from Jason Wang (dated 12/26/2014). >>>

Re: [PATCH v7 02/10] ss: created formatters for json and hr

2015-10-28 Thread Matthias Tafelmeier
> > Well, then we should wait for another voice aimed at the complexity of > the patchset before amending and resending me the patchset. > > Well, I perceive that after Sutter has taken over the maintenance responsibilitiy and answered accordingly that the outstanding resentments as resolved. Tho

Re: [PATCH v7 10/10] ss: activate json_writer excluded logic

2015-10-28 Thread Phil Sutter
On Wed, Oct 28, 2015 at 11:39:41AM +0900, Stephen Hemminger wrote: > On Tue, 27 Oct 2015 14:21:03 +0100 > Phil Sutter wrote: > > > On Thu, Sep 10, 2015 at 09:35:08PM +0200, Matthias Tafelmeier wrote: > > > This small patch extends the lib json_writer module for formerly > > > deactivated function

Re: [PATCH 0/8] mm: memcontrol: account socket memory in unified hierarchy

2015-10-28 Thread Vladimir Davydov
On Tue, Oct 27, 2015 at 09:01:08AM -0700, Johannes Weiner wrote: ... > > > But regardless of tcp window control, we need to account socket memory > > > in the main memory accounting pool where pressure is shared (to the > > > best of our abilities) between all accounted memory consumers. > > > > >

Re: [PATCH v7 02/10] ss: created formatters for json and hr

2015-10-28 Thread Phil Sutter
On Wed, Oct 28, 2015 at 09:07:47AM +0100, Matthias Tafelmeier wrote: > > > > > Well, then we should wait for another voice aimed at the complexity of > > the patchset before amending and resending me the patchset. > > > > > > Well, I perceive that after Sutter has taken over the maintenance > res

Re: [PATCH 1/7] 8139cp: Improve accuracy of cp_interrupt() return, to survive IRQ storms

2015-10-28 Thread David Woodhouse
On Wed, 2015-09-23 at 10:58 -0700, David Miller wrote: > From: David Woodhouse > Date: Wed, 23 Sep 2015 09:14:09 +0100 > > > But sure, for now I'll drop this from the series and I can try to > > convince you separately. > > Yes, let's discuss this independantly to the nice bug fixing > that's ha

[patch net-next 02/12] switchdev: Make flood to CPU optional

2015-10-28 Thread Jiri Pirko
From: Ido Schimmel In certain use cases it is not always desirable for the switch device to flood traffic to CPU port. Instead, only certain packet types (e.g. STP, LACP) should be trapped to it. Signed-off-by: Ido Schimmel Signed-off-by: Jiri Pirko --- Documentation/networking/switchdev.txt

[patch net-next 01/12] switchdev: Add support for flood control

2015-10-28 Thread Jiri Pirko
From: Ido Schimmel Allow devices supporting this feature to control the flooding of unknown unicast traffic, by making switchdev infrastructure propagate this setting to the switch driver. Signed-off-by: Ido Schimmel Signed-off-by: Jiri Pirko --- Documentation/networking/switchdev.txt | 3 +++

[patch net-next 10/12] mlxsw: Put constant on the right side of comparisons

2015-10-28 Thread Jiri Pirko
From: Or Gerlitz Fixes those places where checkpatch complains that comparisons should place the constant on the right side of the test. Signed-off-by: Or Gerlitz Signed-off-by: Jiri Pirko Signed-off-by: Ido Schimmel --- drivers/net/ethernet/mellanox/mlxsw/core.c | 4 ++-- drivers/net/et

[patch net-next 07/12] mlxsw: reg: Fix desription typos of couple of SFN items

2015-10-28 Thread Jiri Pirko
From: Jiri Pirko Fix copy-paste errors. Signed-off-by: Jiri Pirko Signed-off-by: Ido Schimmel --- drivers/net/ethernet/mellanox/mlxsw/reg.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlxsw/reg.h b/drivers/net/ethernet/mellanox/mlxs

[patch net-next 08/12] mlxsw: reg: Avoid unnecessary line wrap for mlxsw_reg_sfd_uc_unpack

2015-10-28 Thread Jiri Pirko
From: Jiri Pirko Signed-off-by: Jiri Pirko Signed-off-by: Ido Schimmel --- drivers/net/ethernet/mellanox/mlxsw/reg.h | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlxsw/reg.h b/drivers/net/ethernet/mellanox/mlxsw/reg.h index 2bf230c..

[patch net-next 03/12] mlxsw: spectrum: move "bridged" bool to u8 flags

2015-10-28 Thread Jiri Pirko
From: Jiri Pirko It is a flag anyway, so move it to existing u8 flag and don't waste mem. Fix the flags to be in single u8 on the way. Signed-off-by: Jiri Pirko Signed-off-by: Ido Schimmel --- drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 4 ++-- drivers/net/ethernet/mellanox/mlxsw/spectru

[patch net-next 12/12] mlxsw: spectrum: Make mlxsw_sp_port_switchdev_ops static

2015-10-28 Thread Jiri Pirko
From: Jiri Pirko Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c index

[patch net-next 09/12] mlxsw: spectrum: Fix ageing time value

2015-10-28 Thread Jiri Pirko
From: Jiri Pirko The value passed through switchdev attr set is not in jiffies, but in clock_t, so fix the convert. Reported-by: Sagi Rotem Fixes: 56ade8fe3f ("mlxsw: spectrum: Add initial support for Spectrum ASIC") Signed-off-by: Jiri Pirko Signed-off-by: Ido Schimmel --- drivers/net/ether

[patch net-next 05/12] mlxsw: spectrum: Add support for flood control

2015-10-28 Thread Jiri Pirko
From: Ido Schimmel Add or remove a bridged port from the flooding domain of unknown unicast packets according to user configuration. Signed-off-by: Ido Schimmel Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 1 + drivers/net/ethernet/mellanox/mlxsw/spectr

[patch net-next 04/12] mlxsw: spectrum: Add support for VLAN ranges in flooding configuration

2015-10-28 Thread Jiri Pirko
From: Ido Schimmel When enabling a range of VLANs on a bridged port we can configure flooding for these VLANs by one register access instead of calling the same register for each VLAN. This is accomplished by using the 'range' field of the Switch Flooding Table Register (SFTR). Signed-off-by: Id

Re: [PATCH 02/25] IB/mthca, net/mlx4: remove counting semaphores

2015-10-28 Thread Sagi Grimberg
Hi Arnd, Since we want to make counting semaphores go away, Why do we want to make counting semaphores go away? completely? or just for binary use cases? I have a use case in iser target code where a counting semaphore is the best suited synchronizing mechanism. I have a single thread handli

[patch net-next 06/12] mlxsw: reg: Fix description for reg_sfd_uc_sub_port

2015-10-28 Thread Jiri Pirko
From: Jiri Pirko The original description was for LAG, so fix it. Signed-off-by: Jiri Pirko Signed-off-by: Ido Schimmel --- drivers/net/ethernet/mellanox/mlxsw/reg.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlxsw/reg.h b/drivers/n

[patch net-next 00/12] mlxsw: driver update

2015-10-28 Thread Jiri Pirko
From: Jiri Pirko This driver update mainly brings support for user to be able to setup flooding on specified port, via bridge flag. Also, there is a fix in ageing time conversion. The rest is just cosmetics. Ido Schimmel (4): switchdev: Add support for flood control switchdev: Make flood to

[patch net-next 11/12] mlxsw: Put braces on all arms of branch statement

2015-10-28 Thread Jiri Pirko
From: Or Gerlitz Fix a place where checkpatch complains that braces should be used on all arms of this statement. Signed-off-by: Or Gerlitz Signed-off-by: Jiri Pirko Signed-off-by: Ido Schimmel --- drivers/net/ethernet/mellanox/mlxsw/pci.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion

Re: [PATCH net-next v3 0/4] net: clean up interactions of CHECKSUM_PARTIAL and fragmentation

2015-10-28 Thread Hannes Frederic Sowa
Hi David, Hannes Frederic Sowa writes: > This series fixes wrong checksums on the wire for IPv4 and IPv6. Large > send buffers and especially NFS lead to wrong checksums in both IPv4 > and IPv6. > > CHECKSUM_PARTIAL skbs should not receive the respective fragmentations > functions, so we add WAR

Re: [GIT] Networking

2015-10-28 Thread Linus Torvalds
On Wed, Oct 28, 2015 at 3:32 PM, David Miller wrote: > > This may look a bit scary this late in the release cycle, but as is typically > the case it's predominantly small driver fixes all over the place. Christ people. This is just sh*t. The conflict I get is due to stupid new gcc header file cr

BUG: fsl FEC ethernet tx checksum offloading doesn't work with RMII interface

2015-10-28 Thread David Jander
Hi all, I was unable to figure out who's maintaining drivers/net/ethernet/freescale/fec_main.c, so I hope someone can help out on this list... We have a board with a RMII phy connected to an i.MX6S. The hardware seems to be ok, since I can receive and transmit ethernet frames without drops or er

[RFC PATCH net-next 1/4] perf tools: Enable pre-event inherit setting by config terms

2015-10-28 Thread Wang Nan
This patch allows perf record setting event's attr.inherit bit by config terms like: # perf record -e cycles/no-inherit/ ... # perf record -e cycles/inherit/ ... So user can control inherit bit for each event separately. In following example, a.out fork()s in main then do some complex CPU inte

[RFC PATCH net-next 0/4] perf tools: Support receiving output through BPF programs

2015-10-28 Thread Wang Nan
Alexei provided a patchset to allow BPF programs output data to ring buffer using helper bpf_perf_event_output() [1]. and have been merged into net-next as commit a43eec304259a6c637f4014a6d4767159b6a3aa3 (bpf: introduce bpf_perf_event_output() helper). This patchset introduces perf side code to u

[RFC PATCH net-next 4/4] perf data: Support converting data from bpf_perf_event_output()

2015-10-28 Thread Wang Nan
bpf_perf_event_output() outputs data through sample->raw_data. This patch adds support to convert those data into CTF. A python script then can be used to process output data from BPF programs. Example: BPF program # struct bpf_map_def SEC("maps") map_channel = {

[RFC PATCH net-next 3/4] perf data: Add u32_hex data type

2015-10-28 Thread Wang Nan
Add hexdamical u32 to base data type, which is useful for raw output because raw data are u32 aligned. Signed-off-by: Wang Nan Cc: Alexei Starovoitov Cc: Arnaldo Carvalho de Melo Cc: Brendan Gregg Cc: Jiri Olsa --- tools/perf/util/data-convert-bt.c | 2 ++ 1 file changed, 2 insertions(+) di

[RFC PATCH net-next 2/4] perf tools: Introduce bpf-output event

2015-10-28 Thread Wang Nan
Commit a43eec304259a6c637f4014a6d4767159b6a3aa3 (bpf: introduce bpf_perf_event_output() helper) add a helper to enable BPF program output data to perf ring buffer through a new type of perf event PERF_COUNT_SW_BPF_OUTPUT. This patch enable perf to create perf event of that type. Now perf user can u

Re: [GIT] Networking

2015-10-28 Thread Hannes Frederic Sowa
Hi Linus, On Wed, Oct 28, 2015, at 10:39, Linus Torvalds wrote: > On Wed, Oct 28, 2015 at 3:32 PM, David Miller > wrote: > > > > This may look a bit scary this late in the release cycle, but as is > > typically > > the case it's predominantly small driver fixes all over the place. > > Christ pe

Re: [RFC PATCH net-next 0/4] perf tools: Support receiving output through BPF programs

2015-10-28 Thread Wangnan (F)
On 2015/10/28 18:55, Wang Nan wrote: Alexei provided a patchset to allow BPF programs output data to ring buffer using helper bpf_perf_event_output() [1]. and have been merged into net-next as commit a43eec304259a6c637f4014a6d4767159b6a3aa3 (bpf: introduce bpf_perf_event_output() helper). Thi

Re: [PATCH 3/9] powerpc32: checksum_wrappers_64 becomes checksum_wrappers

2015-10-28 Thread Anton Blanchard
Hi Scott, > I wonder why it was 64-bit specific in the first place. I think it was part of a series where I added my 64bit assembly checksum routines, and I didn't step back and think that the wrapper code would be useful on 32 bit. Anton -- To unsubscribe from this list: send the line "unsubscr

Re: BUG: fsl FEC ethernet tx checksum offloading doesn't work with RMII interface

2015-10-28 Thread Russell King - ARM Linux
On Wed, Oct 28, 2015 at 10:48:54AM +0100, David Jander wrote: > > Hi all, > > I was unable to figure out who's maintaining > drivers/net/ethernet/freescale/fec_main.c, so I hope someone can help out on > this list... > > We have a board with a RMII phy connected to an i.MX6S. The hardware seems

Re: BUG: fsl FEC ethernet tx checksum offloading doesn't work with RMII interface

2015-10-28 Thread David Jander
On Wed, 28 Oct 2015 11:14:14 + Russell King - ARM Linux wrote: > On Wed, Oct 28, 2015 at 10:48:54AM +0100, David Jander wrote: > > > > Hi all, > > > > I was unable to figure out who's maintaining > > drivers/net/ethernet/freescale/fec_main.c, so I hope someone can help out > > on this list.

Re: [PATCH v7 02/10] ss: created formatters for json and hr

2015-10-28 Thread Matthias Tafelmeier
-BEGIN PGP SIGNED MESSAGE- Hash: SHA384 > I did not take over maintenance responsibility (whatever that means > to you precisely). I merely reviewed the patches, focussing on the > technical aspects of both implementation and patch management. Ah, I meant the maintenance of iproute2 as a

[PATCH] fec: Use gpio_set_value_cansleep()

2015-10-28 Thread Fabio Estevam
From: Fabio Estevam We are in a context where we can sleep, and the FEC PHY reset gpio may be on an I2C expander. Use the cansleep() variant when setting the GPIO value. Based on a patch from Russell King for pci-mvebu.c. Signed-off-by: Fabio Estevam --- drivers/net/ethernet/freescale/fec_mai

[PATCH net 2/2] ipv6: protect mtu calculation of wrap-around and infinite loop by rounding issues

2015-10-28 Thread Hannes Frederic Sowa
Raw sockets with hdrincl enabled can insert ipv6 extension headers right into the data stream. In case we need to fragment those packets, we reparse the options header to find the place where we can insert the fragment header. If the extension headers exceed the link's MTU we actually cannot make p

[PATCH net 1/2] Revert "Merge branch 'ipv6-overflow-arith'"

2015-10-28 Thread Hannes Frederic Sowa
Linus dislikes these changes. To not hold up the net-merge let's revert it for now and fix the bug like Linus suggested. This reverts commit ec3661b42257d9a06cf0d318175623ac7a660113, reversing changes made to c80dbe04612986fd6104b4a1be21681b113b5ac9. Cc: Linus Torvalds Signed-off-by: Hannes Fred

Re: BUG: fsl FEC ethernet tx checksum offloading doesn't work with RMII interface

2015-10-28 Thread Fabio Estevam
On Wed, Oct 28, 2015 at 9:19 AM, David Jander wrote: > Sorry, I somehow assumed it was obvious I'd report against latest mainline... > I'm on 4.3-rc7. Are you able to find out a previous kernel version that does not exhibit this failure? -- To unsubscribe from this list: send the line "unsubscri

Re: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

2015-10-28 Thread Al Viro
[Linus and Dave added, Solaris and NetBSD folks dropped from Cc] On Tue, Oct 27, 2015 at 05:13:56PM -0700, Eric Dumazet wrote: > On Tue, 2015-10-27 at 23:17 +, Al Viro wrote: > > > * [Linux-specific aside] our __alloc_fd() can degrade quite badly > > with some use patterns. The cacheline

Re: BUG: fsl FEC ethernet tx checksum offloading doesn't work with RMII interface

2015-10-28 Thread David Jander
On Wed, 28 Oct 2015 10:31:17 -0200 Fabio Estevam wrote: > On Wed, Oct 28, 2015 at 9:19 AM, David Jander wrote: > > > Sorry, I somehow assumed it was obvious I'd report against latest > > mainline... I'm on 4.3-rc7. > > Are you able to find out a previous kernel version that does not > exhibit

[v6, 4/6] fsl/fman: Add FMan SP support

2015-10-28 Thread igal.liberman
From: Igal Liberman The Storage Profiles contain parameters that are used by the FMan for frame reception and transmission. Signed-off-by: Igal Liberman --- drivers/net/ethernet/freescale/fman/Makefile |2 +- drivers/net/ethernet/freescale/fman/fman_sp.c | 167 +

[v6, 2/6] fsl/fman: Add FMan support

2015-10-28 Thread igal.liberman
From: Igal Liberman Add the Data Path Acceleration Architecture Frame Manger Driver. The FMan embeds a series of hardware blocks that implement a group of Ethernet interfaces. This patch adds The FMan configuration, initialization and runtime control routines. The FMan driver supports several ha

[v6, 1/6] fsl/fman: Add FMan MURAM support

2015-10-28 Thread igal.liberman
From: Igal Liberman Add Frame Manager Multi-User RAM support. This internal FMan memory block is used by the FMan hardware modules, the management being made through the generic allocator. The FMan Internal memory, for example, is used for allocating transmit and receive FIFOs. Signed-off-by: I

[v6, 3/6] fsl/fman: Add FMan MAC support

2015-10-28 Thread igal.liberman
From: Igal Liberman Add the Data Path Acceleration Architecture Frame Manger MAC support. This patch adds The FMan MAC configuration, initialization and runtime control routines. This patch contains support for these types of MACs: - dTSEC: Three speed Ethernet controller (10/100/1000 Mbp

[v6, 6/6] fsl/fman: Add FMan MAC driver

2015-10-28 Thread igal.liberman
From: Igal Liberman This patch adds the Ethernet MAC driver supporting the three different types of MACs: dTSEC, tGEC and mEMAC. Signed-off-by: Igal Liberman --- drivers/net/ethernet/freescale/fman/Makefile |3 +- drivers/net/ethernet/freescale/fman/mac.c| 980

[v6, 0/6] Freescale DPAA FMan

2015-10-28 Thread igal.liberman
From: Igal Liberman The Freescale Data Path Acceleration Architecture (DPAA) is a set of hardware components on specific QorIQ multicore processors. This architecture provides the infrastructure to support simplified sharing of networking interfaces and accelerators by multiple CPU cores and the

[v6, 5/6] fsl/fman: Add FMan Port Support

2015-10-28 Thread igal.liberman
From: Igal Liberman Add the Data Path Acceleration Architecture Frame Manger Port Driver. The FMan driver uses a module called "Port" to represent the physical TX and RX ports. Each FMan version has different number of physical ports. This patch adds The FMan Port configuration, initialization an

Re: [GIT] Networking

2015-10-28 Thread David Miller
From: Linus Torvalds Date: Wed, 28 Oct 2015 18:39:56 +0900 > Get rid of it. And I don't *ever* want to see that shit again. No problem, I'll revert it all. I asked Hannes to repost his patches to linux-kernel hoping someone would review and say it stunk or not, give him some feedback, or whatev

Re: [RFC PATCH net-next 2/4] perf tools: Introduce bpf-output event

2015-10-28 Thread Sergei Shtylyov
Hello. On 10/28/2015 1:55 PM, Wang Nan wrote: Commit a43eec304259a6c637f4014a6d4767159b6a3aa3 (bpf: introduce bpf_perf_event_output() helper) add a helper to enable BPF program You haven't run the patch thru scripts/checkpath.pl, I guess? It now enforces the certain style of citing a comm

Re: [RFC PATCH net-next 1/4] perf tools: Enable pre-event inherit setting by config terms

2015-10-28 Thread Jiri Olsa
On Wed, Oct 28, 2015 at 10:55:02AM +, Wang Nan wrote: SNIP > diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c > index f820906..397fb4e 100644 > --- a/tools/perf/util/evsel.c > +++ b/tools/perf/util/evsel.c > @@ -653,6 +653,15 @@ static void apply_config_terms(struct perf_evsel *

Re: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

2015-10-28 Thread Eric Dumazet
On Wed, 2015-10-28 at 12:35 +, Al Viro wrote: > [Linus and Dave added, Solaris and NetBSD folks dropped from Cc] > > On Tue, Oct 27, 2015 at 05:13:56PM -0700, Eric Dumazet wrote: > > On Tue, 2015-10-27 at 23:17 +, Al Viro wrote: > > > > > * [Linux-specific aside] our __alloc_fd() can de

Re: [PATCH] xfrm: dst_entries_init() per-net dst_ops

2015-10-28 Thread Dan Streetman
On Tue, Oct 27, 2015 at 12:15 PM, wrote: > From: Dan Streetman > > The ipv4 and ipv6 xfrms each create a template dst_ops object, and > perform dst_entries_init() on the template objects. Then each net > namespace has its net.xfrm.xfrm[46]_dst_ops field set to the template > values. The proble

Re: [RESEND PATCH 07/10] net: wireless: iwlegacy: Remove unneeded variable ret

2015-10-28 Thread Sergei Shtylyov
Hello. On 10/27/2015 10:02 PM, Punit Vara wrote: This patch is to the 3945-mac.c file that fixes up following warning by coccicheck: drivers/net/wireless/iwlegacy/3945-mac.c:247:5-8: Unneeded variable: "ret". Return "- EOPNOTSUPP" on line 249 Return -EOPNOTSUPP directly instead of return usin

Re: [RESEND PATCH 07/10] net: wireless: iwlegacy: Remove unneeded variable ret

2015-10-28 Thread Sergei Shtylyov
On 10/28/2015 4:35 PM, Sergei Shtylyov wrote: This patch is to the 3945-mac.c file that fixes up following warning by coccicheck: drivers/net/wireless/iwlegacy/3945-mac.c:247:5-8: Unneeded variable: "ret". Return "- EOPNOTSUPP" on line 249 Return -EOPNOTSUPP directly instead of return using re

Re: [RFC PATCH net-next 1/4] perf tools: Enable pre-event inherit setting by config terms

2015-10-28 Thread Arnaldo Carvalho de Melo
Em Wed, Oct 28, 2015 at 02:21:26PM +0100, Jiri Olsa escreveu: > On Wed, Oct 28, 2015 at 10:55:02AM +, Wang Nan wrote: > > @@ -55,6 +56,7 @@ struct perf_evsel_config_term { > > booltime; > > char*callgraph; > > u64 stack_user; > > + u64

Re: [PATCH] xfrm: dst_entries_init() per-net dst_ops

2015-10-28 Thread Hannes Frederic Sowa
Hello, On Wed, Oct 28, 2015, at 14:32, Dan Streetman wrote: > On Tue, Oct 27, 2015 at 12:15 PM, wrote: > > From: Dan Streetman > > > > The ipv4 and ipv6 xfrms each create a template dst_ops object, and > > perform dst_entries_init() on the template objects. Then each net > > namespace has its

Re: [RFC PATCH net-next 1/4] perf tools: Enable pre-event inherit setting by config terms

2015-10-28 Thread Arnaldo Carvalho de Melo
Em Wed, Oct 28, 2015 at 10:42:13AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Wed, Oct 28, 2015 at 02:21:26PM +0100, Jiri Olsa escreveu: > > On Wed, Oct 28, 2015 at 10:55:02AM +, Wang Nan wrote: > > > @@ -55,6 +56,7 @@ struct perf_evsel_config_term { > > > booltime; > > >

Re: [PATCH net] amd-xgbe: Fix race between access of desc and desc index

2015-10-28 Thread Tom Lendacky
On 10/27/2015 09:50 PM, David Miller wrote: From: Tom Lendacky Date: Mon, 26 Oct 2015 17:13:54 -0500 During Tx cleanup it's still possible for the descriptor data to be read ahead of the descriptor index. A memory barrier is required between the read of the descriptor index and the start of th

Re: [PATCH] xfrm: dst_entries_init() per-net dst_ops

2015-10-28 Thread David Miller
From: Dan Streetman Date: Wed, 28 Oct 2015 09:32:47 -0400 > Well I'm not sure why my test kernel booted, while the test robot > found the bug of GFP_KERNEL percpu counter alloc during atomic > context. Thanks test robot! It's because of the kernel config options you (don't) have enabled. -- To

Re: [PATCH 2/6] net: dsa: allow switch drivers to cleanup their resources

2015-10-28 Thread Neil Armstrong
On 10/27/2015 05:59 PM, Vivien Didelot wrote: > On Oct. Tuesday 27 (44) 04:43 PM, Neil Armstrong wrote: >> >> Yes, I didn't know how to handle this since it was part of a larger patch. >> >> I forgot to add this into the cover-letter but I wanted to send an RFC serie >> with >> your bcm remove pat

Re: [PATCH 6/6] net: phy: Stop 'phy-state-machine' and 'phy_change' work on remove

2015-10-28 Thread Neil Armstrong
> > void phy_disconnect(struct phy_device *phydev) > > { > > if (phydev->irq > 0) > > phy_stop_interrupts(phydev); > > > > phy_stop_machine(phydev); > > > > phydev->adjust_link = NULL; > > > > phy_detach(phydev)

[RFC PATCH v2 4/4] net: dsa: make usage of mv88e6xxx common remove function

2015-10-28 Thread Neil Armstrong
Make usage of previously introduced mv88e6xxx common remove function in all mv88e6xxx drivers. Signed-off-by: Neil Armstrong --- drivers/net/dsa/mv88e6123_61_65.c | 1 + drivers/net/dsa/mv88e6131.c | 8 drivers/net/dsa/mv88e6171.c | 1 + drivers/net/dsa/mv88e6352.c | 1

[RFC PATCH v2 2/4] net: dsa: bcm_sf2: cleanup resources in remove callback

2015-10-28 Thread Neil Armstrong
Implement a remove callback allowing the switch driver to cleanup resources it used: interrupts and remapped register ranges. Signed-off-by: Florian Fainelli Signed-off-by: Neil Armstrong --- drivers/net/dsa/bcm_sf2.c | 20 1 file changed, 20 insertions(+) diff --git a/dri

[RFC PATCH v2 3/4] net: dsa: mv88e6xxx: add common and ppu remove function

2015-10-28 Thread Neil Armstrong
With the previously introduced remove callback, add a mv88e6xxx common remove function to cleanup all resources. Signed-off-by: Neil Armstrong --- drivers/net/dsa/mv88e6xxx.c | 18 ++ drivers/net/dsa/mv88e6xxx.h | 2 ++ 2 files changed, 20 insertions(+) diff --git a/drivers/net

[RFC PATCH v2 1/4] net: dsa: allow switch drivers to cleanup their resources

2015-10-28 Thread Neil Armstrong
Some switch drivers might request interrupts, remap register ranges, allow such drivers to implement a "remove" callback doing just that. Signed-off-by: Florian Fainelli Signed-off-by: Neil Armstrong --- include/net/dsa.h | 1 + net/dsa/dsa.c | 4 2 files changed, 5 insertions(+) diff

Re: [RFC PATCH net-next 1/4] perf tools: Enable pre-event inherit setting by config terms

2015-10-28 Thread Jiri Olsa
On Wed, Oct 28, 2015 at 10:42:13AM -0300, Arnaldo Carvalho de Melo wrote: > Em Wed, Oct 28, 2015 at 02:21:26PM +0100, Jiri Olsa escreveu: > > On Wed, Oct 28, 2015 at 10:55:02AM +, Wang Nan wrote: > > > @@ -55,6 +56,7 @@ struct perf_evsel_config_term { > > > booltime; > > >

[RFC PATCH v2 0/4] net: dsa: cleanup dsa driver

2015-10-28 Thread Neil Armstrong
Introduce a new remove callback to allow DSA drivers to cleanup their ressources. Then add a remove implementation for bcm_sf2 and mv88e6xxx. This patch was not tested due of a lack of hardware. v2: add remove callback patch to the serie Neil Armstrong (4): net: dsa: allow switch drivers to cl

Re: [RFC PATCH v2 1/4] net: dsa: allow switch drivers to cleanup their resources

2015-10-28 Thread Andrew Lunn
On Wed, Oct 28, 2015 at 03:12:57PM +0100, Neil Armstrong wrote: > Some switch drivers might request interrupts, remap register ranges, > allow such drivers to implement a "remove" callback doing just that. > > Signed-off-by: Florian Fainelli > Signed-off-by: Neil Armstrong > --- > include/net/d

Re: [GIT] Networking

2015-10-28 Thread Rasmus Villemoes
On Wed, Oct 28 2015, Hannes Frederic Sowa wrote: > Hi Linus, > > On Wed, Oct 28, 2015, at 10:39, Linus Torvalds wrote: >> Get rid of it. And I don't *ever* want to see that shit again. > > I don't want to give up on that this easily: > > In future I would like to see an interface like this. It is

Re: [RFC PATCH v2 3/4] net: dsa: mv88e6xxx: add common and ppu remove function

2015-10-28 Thread Andrew Lunn
On Wed, Oct 28, 2015 at 03:13:16PM +0100, Neil Armstrong wrote: > With the previously introduced remove callback, add a > mv88e6xxx common remove function to cleanup all resources. > > Signed-off-by: Neil Armstrong > --- > drivers/net/dsa/mv88e6xxx.c | 18 ++ > drivers/net/dsa/mv

Re: [RFC PATCH v2 3/4] net: dsa: mv88e6xxx: add common and ppu remove function

2015-10-28 Thread Andrew Lunn
On Wed, Oct 28, 2015 at 03:37:02PM +0100, Neil Armstrong wrote: > Hi Andrew, > > On 10/28/2015 03:35 PM, Andrew Lunn wrote: > > On Wed, Oct 28, 2015 at 03:13:16PM +0100, Neil Armstrong wrote: > >> diff --git a/drivers/net/dsa/mv88e6xxx.c b/drivers/net/dsa/mv88e6xxx.c > >> index b1b14f5..6287096 10

Re: [RFC PATCH v2 3/4] net: dsa: mv88e6xxx: add common and ppu remove function

2015-10-28 Thread Neil Armstrong
Hi Andrew, On 10/28/2015 03:35 PM, Andrew Lunn wrote: > On Wed, Oct 28, 2015 at 03:13:16PM +0100, Neil Armstrong wrote: >> diff --git a/drivers/net/dsa/mv88e6xxx.c b/drivers/net/dsa/mv88e6xxx.c >> index b1b14f5..6287096 100644 >> --- a/drivers/net/dsa/mv88e6xxx.c >> +++ b/drivers/net/dsa/mv88e6xxx

Re: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

2015-10-28 Thread Eric Dumazet
On Wed, 2015-10-28 at 06:24 -0700, Eric Dumazet wrote: > Before I take a deep look at your suggestion, are you sure plain use of > include/linux/percpu-refcount.h infra is not possible for struct cred ? BTW, I am not convinced we need to spend so much energy and per-cpu memory for struct cred ref

[PATCH net-next 0/4] sfc: NUMA support

2015-10-28 Thread Shradha Shah
This patch series adds support for - allocating rx pages local to the interrupt - setting affinity hint to influence IRQs to be allocated on the same NUMA node as the one where the card resides. Alexandra Kossovsky (1): sfc: use __GFP_NOWARN when allocating RX pages from atomic context. Bert K

[PATCH net-next 3/4] sfc: Use cpu_to_mem() to support memoryless nodes

2015-10-28 Thread Shradha Shah
From: Bert Kenward With CONFIG_HAVE_MEMORYLESS_NODES cpu_to_node() may return nodes without memory, which is not a good choice when later using that to allocate memory. cpu_to_mem() instead provides the most appropriate NUMA node to allocate from. Signed-off-by: Shradha Shah --- drivers/net/et

[PATCH net-next 2/4] sfc: allocate rx pages on the same node as the interrupt

2015-10-28 Thread Shradha Shah
From: Daniel Pieczko When the interrupt servicing a channel is on a NUMA node that is not local to the device, performance is improved by allocating rx pages on the node local to the interrupt (remote to the device) The performance-optimal case, where interrupts and applications are pinned to CP

[PATCH net-next 4/4] sfc: set and clear interrupt affinity hints

2015-10-28 Thread Shradha Shah
From: Bert Kenward Use cpumask_local_spread to provide interrupt affinity hints for each queue. This will spread interrupts across NUMA local CPUs first, extending to remote nodes if needed. Signed-off-by: Shradha Shah --- drivers/net/ethernet/sfc/efx.c | 35 +++

Re: [PATCH v7 02/10] ss: created formatters for json and hr

2015-10-28 Thread Phil Sutter
On Wed, Oct 28, 2015 at 12:57:28PM +0100, Matthias Tafelmeier wrote: > >> Those resentments were related to the patchsets complexity and > >> size. > > > > I didn't see any problem with that in the first place. It is indeed > > a big change, achieving something like that without a big patch set >

[PATCH net-next 1/4] sfc: use __GFP_NOWARN when allocating RX pages from atomic context.

2015-10-28 Thread Shradha Shah
From: Alexandra Kossovsky If we fail to allocate a page when in atomic context this is handled by scheduling a fill in non-atomic context. As such, a warning is not needed. Signed-off-by: Shradha Shah --- drivers/net/ethernet/sfc/rx.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(

Re: [PATCH] xfrm: dst_entries_init() per-net dst_ops

2015-10-28 Thread Dan Streetman
On Wed, Oct 28, 2015 at 9:42 AM, Hannes Frederic Sowa wrote: > Hello, > > On Wed, Oct 28, 2015, at 14:32, Dan Streetman wrote: >> On Tue, Oct 27, 2015 at 12:15 PM, wrote: >> > From: Dan Streetman >> > >> > The ipv4 and ipv6 xfrms each create a template dst_ops object, and >> > perform dst_entri

Re: [PATCH v7 02/10] ss: created formatters for json and hr

2015-10-28 Thread Matthias Tafelmeier
> Yeah, sorry for not having looked into this earlier. Also, I neither > have nor claim any power of veto. No big issue. Maybe Stephen can clarifiy things. I mean acknowledge no further objections. > Apart from that, I'm not against this > patch series in general, just trying to help raise it's

Re: [PATCH net-next 2/4] sfc: allocate rx pages on the same node as the interrupt

2015-10-28 Thread Eric Dumazet
On Wed, 2015-10-28 at 15:01 +, Shradha Shah wrote: > From: Daniel Pieczko > > When the interrupt servicing a channel is on a NUMA node that is > not local to the device, performance is improved by allocating > rx pages on the node local to the interrupt (remote to the device) > > The perform

[PATCH net-next] net: bridge: use vzalloc() instead of vmalloc() as counterstmp is not cleared before it is used in get_counters(). counterstmp might be leaked partially when it is sent to userland la

2015-10-28 Thread Loganaden Velvindron
--- net/bridge/netfilter/ebtables.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/bridge/netfilter/ebtables.c b/net/bridge/netfilter/ebtables.c index f46ca41..26922e9 100644 --- a/net/bridge/netfilter/ebtables.c +++ b/net/bridge/netfilter/ebtables.c @@ -989,7 +989,7 @

[PATCH net-next] use vzalloc() instead of vmalloc() as counterstmp is not cleared before it is used in get_counters(). counterstmp might be leaked partially when it is sent to userland later on.

2015-10-28 Thread Loganaden Velvindron
--- net/bridge/netfilter/ebtables.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/bridge/netfilter/ebtables.c b/net/bridge/netfilter/ebtables.c index f46ca41..26922e9 100644 --- a/net/bridge/netfilter/ebtables.c +++ b/net/bridge/netfilter/ebtables.c @@ -989,7 +989,7 @

Re: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

2015-10-28 Thread Alan Burlison
On 27/10/2015 23:17, Al Viro wrote: Frankly, as far as I'm concerned, the bottom line is * there are two variants of semantics in that area and there's not much that could be done about that. Yes, that seems to be the case. * POSIX is vague enough for both variants to comply

[RFC] unix: fix use-after-free in unix_dgram_poll()

2015-10-28 Thread Rainer Weikusat
Rainer Weikusat writes: > Jason Baron writes: [...] >> 2) >> >> For the case of epoll() in edge triggered mode we need to ensure that >> when we return -EAGAIN from unix_dgram_sendmsg() when unix_recvq_full() >> is true, we need to add a unix_peer_wake_connect() call to guarantee a >> wakeup. O

[PATCH net 1/1] tipc: linearize arriving NAME_DISTR and LINK_PROTO buffers

2015-10-28 Thread Jon Maloy
Testing of the new UDP bearer has revealed that reception of NAME_DISTRIBUTOR, LINK_PROTOCOL/RESET and LINK_PROTOCOL/ACTIVATE message buffers is not prepared for the case that those may be non-linear. We now linearize all such buffers before they are delivered up to the generic reception layer. I

[PATCH net-next] ipv4: use l4 hash for locally generated multipath flows

2015-10-28 Thread Paolo Abeni
This patch changes how the multipath hash is computed for locally generated UDP or TCP flows: now the hash comprises also l4 information (source and destination port). This allows better utilization of the available paths when the existing flows have the same source IP and the same destination IP:

Re: [RFC] unix: fix use-after-free in unix_dgram_poll()

2015-10-28 Thread Jason Baron
On 10/28/2015 12:46 PM, Rainer Weikusat wrote: > Rainer Weikusat writes: >> Jason Baron writes: > > [...] > >>> 2) >>> >>> For the case of epoll() in edge triggered mode we need to ensure that >>> when we return -EAGAIN from unix_dgram_sendmsg() when unix_recvq_full() >>> is true, we need to ad

RE: [PATCH net-next] hyperv: Add handler for RNDIS_STATUS_NETWORK_CHANGE event

2015-10-28 Thread Haiyang Zhang
> -Original Message- > From: Richard Weinberger [mailto:richard.weinber...@gmail.com] > Sent: Tuesday, October 27, 2015 6:36 PM > To: David Miller > Cc: Haiyang Zhang ; o...@aepfle.de; Greg Kroah- > Hartman ; netdev@vger.kernel.org; > jasow...@redhat.com; driverdev-de...@linuxdriverproje

Re: [PATCH net-next] net: bridge: use vzalloc() instead of vmalloc() as counterstmp is not cleared before it is used in get_counters(). counterstmp might be leaked partially when it is sent to userlan

2015-10-28 Thread Sergei Shtylyov
Hello. Your subject is too long, it should have been placed in the changelog partially. You you didn't sign off on the patch, so it can't applied. MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More maj

Re: [PATCH net-next 4/4] sfc: set and clear interrupt affinity hints

2015-10-28 Thread Sergei Shtylyov
Hello. On 10/28/2015 06:02 PM, Shradha Shah wrote: From: Bert Kenward Use cpumask_local_spread to provide interrupt affinity hints for each queue. This will spread interrupts across NUMA local CPUs first, extending to remote nodes if needed. Signed-off-by: Shradha Shah --- drivers/net/eth

[PATCH 1/1 net-next] net: bridge: use vzalloc() instead of vmalloc() for counterstmp

2015-10-28 Thread Loganaden Velvindron
counterstmp is not cleared before it is used in get_counters(). it might be leaked partially when it is sent to userland later on. Signed-off-by: Loganaden Velvindron --- net/bridge/netfilter/ebtables.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/bridge/netfilter

Re: [PATCH net-next] net: bridge: use vzalloc() instead of vmalloc() as counterstmp is not cleared before it is used in get_counters(). counterstmp might be leaked partially when it is sent to userlan

2015-10-28 Thread Loganaden Velvindron
On Wed, Oct 28, 2015 at 09:10:20PM +0300, Sergei Shtylyov wrote: > Hello. > >Your subject is too long, it should have been placed in the changelog > partially. You you didn't sign off on the patch, so it can't applied. > > MBR, Sergei Thank you. Please reject this patch. I re-sent a proper o

Re: [PATCH net-next] net: bridge: use vzalloc() instead of vmalloc() as counterstmp is not cleared before it is used in get_counters(). counterstmp might be leaked partially when it is sent to userlan

2015-10-28 Thread Loganaden Velvindron
Please reject this patch. I sent a proper one with the sign-on later on. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/8] mm: memcontrol: account socket memory in unified hierarchy

2015-10-28 Thread Johannes Weiner
On Wed, Oct 28, 2015 at 11:20:03AM +0300, Vladimir Davydov wrote: > Then you'd better not touch existing tcp limits at all, because they > just work, and the logic behind them is very close to that of global tcp > limits. I don't think one can simplify it somehow. Uhm, no, there is a crapload of b

  1   2   >