[PATCH v2] r8169: Don't claim WoL works if LanWake flag is not set

[v2 adds missing text to the patch comment] The __rtl8169_get_wol function returns the state of the various WoL method bits (MagicPaket, Unicast, etc.). While the PMEnable bit is tested at entry, the function doesn't check the LanWake flag. Even if any one of the WoL bits is set, WoL is

[PATCH (net-next.git) 06/18] stmmac: add last_segment field to dma data

last_segment field is read twice from dma descriptors in stmmac_clean(). Add last_segment to dma data so that this flag is from priv structure in cache instead of memory. It avoids reading twice from memory for each loop in stmmac_clean(). Signed-off-by: Fabrice Gasnier

RE: [v9, 6/6] fsl/fman: Add FMan MAC driver

> -Original Message- > From: David Miller [mailto:da...@davemloft.net] > > From: Scott Wood > Date: Tue, 8 Dec 2015 16:44:38 -0600 > > > On Tue, 2015-12-08 at 14:18 -0600, Andy Fleming wrote: > >> On Thu, Dec 3, 2015 at 1:19 AM,

Re: [RFC PATCH V2 0/3] IXGBE/VFIO: Add live migration support for SRIOV NIC

On Sat, Dec 05, 2015 at 12:32:00AM +0800, Lan, Tianyu wrote: > Hi Michael & Alexander: > Thanks a lot for your comments and suggestions. It's nice that it's appreciated, but you then go on and ignore all that I have written here: https://www.mail-archive.com/kvm@vger.kernel.org/msg123826.html >

Re: [RFC PATCH V2 0/3] IXGBE/VFIO: Add live migration support for SRIOV NIC

On 12/8/2015 1:12 AM, Alexander Duyck wrote: On Mon, Dec 7, 2015 at 7:40 AM, Lan, Tianyu wrote: On 12/5/2015 1:07 AM, Alexander Duyck wrote: We still need to support Windows guest for migration and this is why our patches keep all changes in the driver since it's

RE: [PATCH net-next] bnx2x: avoid soft lockup in bnx2x_poll()

> > > Under heavy TX load, bnx2x_poll() can loop forever and trigger soft lockup > bugs. > > > > > > A napi poll handler must yield after one TX completion round, risk > > > of livelock is too high otherwise. > > > > > > Bug is very easy to trigger using a debug build, and udp flood, > > > because

Re: arRe: [PATCH net-next 2/2] net: hns: enet specisies a reference to dsaf (config and documents)

On 2015/12/9 18:00, Arnd Bergmann wrote: > On Wednesday 09 December 2015 17:25:13 Yankejian wrote: >> thanks a lot for pointing it out. >> >> It is great regret that this change breaks compatibility with old dtbs. >> this is a new driver which is run on developing boards, and all the >>

[PATCH (net-next.git) 00/18] stmmac: enhance driver performances and update the version.

This is a subset of patches to rework the driver in order to improve its performances and make it more robust under stress conditions. All patches have been ported on STi mainstream kernel branch and tested on ARM STiH4xx platforms and newer ones. This series also updates the driver version and

[PATCH (net-next.git) 03/18] stmmac: change descriptor layout

This patch completely changes the descriptor layout to improve the whole performances due to the single read usage of the descriptors in critical paths. Signed-off-by: Giuseppe Cavallaro --- drivers/net/ethernet/stmicro/stmmac/descs.h | 330 ++-

[PATCH (net-next.git) 04/18] stmmac: remove modulo in stmmac_xmit()

The indexes into the ring buffer are always incremented, and the entry is accessed via doing a modulo to find the "real" index. I have changed this for 3 reasons: * It is inefficient, modulo is an expensive operation. * It is also broken when the counter wraps. * It makes my head hurt trying to

[PATCH (net-next.git) 02/18] stmmac: rework DMA bus setting and introduce new platform AXI structure

This patch restructures the DMA bus settings and this is done by introducing a new platform structure used for programming the AXI Bus Mode Register inside the DMA module. This structure can be populated from device-tree as documented in the binding txt file. After initializing the DMA, the AXI

[PATCH (net-next.git) 05/18] stmmac: add length field to dma data

Currently, the code pulls out the length field when unmapping a buffer directly from the descriptor. This will result in an uncached read to a dma_alloc_coherent() region. There is no need to do this, so this patch simply puts the value directly into a data structure which will hit the cache.

Re: arRe: [PATCH net-next 2/2] net: hns: enet specisies a reference to dsaf (config and documents)

On Wednesday 09 December 2015 17:25:13 Yankejian wrote: > thanks a lot for pointing it out. > > It is great regret that this change breaks compatibility with old dtbs. > this is a new driver which is run on developing boards, and all the > clients' boards are developing boards. So we provide

[PATCH (net-next.git) 15/18] stmmac: fix phy init when attached to a phy

From: Fabrice Gasnier phy_bus_name can be NULL when "fixed-link" property isn't used. Then, since "stmmac: do not poll phy handler when attach a switch", phy_bus_name ptr needs to be checked before strcmp is called. Signed-off-by: Fabrice Gasnier

[PATCH (net-next.git) 09/18] stmmac: optimize tx desc management

This patch is to optimize the way to manage the TDES inside the xmit function. When prepare the frame, some settings (e.g. OWN bit) can be merged. This has been reworked to improve the tx performances. Signed-off-by: Fabrice Gasnier Signed-off-by: Giuseppe Cavallaro

[PATCH (net-next.git) 12/18] stmmac: first frame prep at the end of xmit routine

This patch is to fill the first descriptor just before granting the DMA engine so at the end of the xmit. The patch takes care about the algorithm adopted to mitigate the interrupts, then it fixes the last segment in case of no fragments. Moreover, this new implementation does not pass any "ter"

[PATCH (net-next.git) 17/18] stmmac: tune rx copy via threshold.

There is a threshold now used to also limit the skb allocation when use zero-copy. This is to avoid that there are incoherence in the ring due to a failure on skb allocation under very aggressive testing and under low memory conditions. Signed-off-by: Giuseppe Cavallaro

[PATCH (net-next.git) 10/18] stmmac: optimize tx clean function

From: Fabrice Gasnier This patch "inline" get_tx_owner and get_ls routines. It Results in a unique read to tdes0, instead of three, to check TX_OWN and LS bits, and other status bits. It helps improve driver TX path by removing two uncached read/writes inside TX clean

[PATCH (net-next.git) 14/18] stmmac: do not poll phy handler when attach a switch

This patch avoids to call the stmmac_adjust_link when the driver is connected to a switch by using the FIXED_PHY support. Prior this patch the phydev->irq was set as PHY_POLL so periodically the phy handler was invoked spending useless time because the link cannot actually change. Note that the

[PATCH (net-next.git) 18/18] stmmac: update version to Oct_2015

This patch just updates the driver to the version fully tested on STi platforms. This version is Oct_2015. Signed-off-by: Giuseppe Cavallaro --- drivers/net/ethernet/stmicro/stmmac/stmmac.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

[PATCH (net-next.git) 11/18] stmmac: set dirty index out of the loop

The dirty index can be updated out of the loop where all the tx resources are claimed. This will help on performances too. Also a useless debug printk has been removed from the main loop. Signed-off-by: Giuseppe Cavallaro ---

[PATCH (net-next.git) 01/18] stmmac: share reset function between dwmac100 and dwmac1000

This patch is to share the same reset procedure between dwmac100 and dwmac1000 chips. This will also help on enhancing the driver and support new chips. Signed-off-by: Giuseppe Cavallaro --- drivers/net/ethernet/stmicro/stmmac/common.h |3 +-

[PATCH (net-next.git) 08/18] stmmac: merge get_rx_owner into rx_status routine.

From: Fabrice Gasnier The RDES0 register can be read several times while doing RX of a packet. This patch slightly improves RX path performance by reading rdes0 once for two operation: check rx owner, get rx status bits. Signed-off-by: Fabrice Gasnier

[PATCH (net-next.git) 13/18] stmmac: perf, remove modulo in stmmac_rx()

The indexes into the ring buffer are always incremented, and the entry is accessed via doing a modulo to find the "real" index. Modulo is an expensive operation. This patch replaces the modulo with a simple if clamp. It helps improve stmmac RX path as it's being called inside RX loop.

[PATCH (net-next.git) 16/18] stmmac: do not perform zero-copy for rx frames

This patch is to allow this driver to copy tiny frames during the reception process. This is giving more stability while stressing the driver on STi embedded systems. Signed-off-by: Giuseppe Cavallaro --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 67

[PATCH (net-next.git) 07/18] stmmac: add is_jumbo field to dma data

Optimize tx_clean by avoiding a des3 read in stmmac_clean_desc3(). In ring mode, TX, des3 seems only used when xmit a jumbo frame. In case of normal descriptors, it may also be used for time stamping. Clean it in the above two case, without reading it. Signed-off-by: Fabrice Gasnier

Re: [PATCH v4 1/4] stmmac: create of compatible mdio bus for stmacc driver

On Wednesday 09 December 2015 10:47:29 Phil Reid wrote: > On 9/12/2015 10:15 AM, kbuild test robot wrote: > > > > > url: > > https://github.com/0day-ci/linux/commits/Phil-Reid/stmmac-create-of-compatible-mdio-bus-for-stmacc-driver/20151209-094242 > > config:

[PATCH 3.16.y-ckt 047/126] can: Use correct type in sizeof() in nla_put()

3.16.7-ckt21 -stable review patch. If anyone has any objections, please let me know. -- From: Marek Vasut commit 562b103a21974c2f9cd67514d110f918bb3e1796 upstream. The sizeof() is invoked on an incorrect variable, likely due to some copy-paste error, and this

[patch -next] VSOCK: signedness bug in virtio_transport_dgram_enqueue()

"written" has to be signed for the error handling to work. trans->ops->send_pkt() returns an int so that's fine. Fixes: 80a19e338d45 ('VSOCK: Introduce virtio-vsock-common.ko') Signed-off-by: Dan Carpenter diff --git a/net/vmw_vsock/virtio_transport_common.c

[PATCH] r8169: Don't claim WoL works if LanWake flag is not set

The __rtl8169_get_wol function returns the state of the various WoL method bits (MagicPaket, Unicast, etc.). While the PMEnable bit is tested at entry, the function doesn't check the LanWake flag. Even if any one of the WoL bits is set, WoL is deactivated as a whole if LanWake isn't set. The

[patch -next] mlxsw: spectrum: fix some error handling

The "err = " assignment is missing here. Fixes: 0d65fc13042f ('mlxsw: spectrum: Implement LAG port join/leave') Signed-off-by: Dan Carpenter diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum.c index

Re: [PATCH net-next 1/2] net: hns: enet specisies a reference to dsaf

On 2015/12/9 2:10, Florian Fainelli wrote: > Subject: s/specisies/specifies/? Thanks for pointing it out. i will change it in next patchset. Best Regards, yankejian > On 04/12/15 23:59, yankejian wrote: >> enet is associating with dasf. before this patch, the association is >> the same

[patch -next] mlxsw: core: remove an unneeded condition

We already know "err" is zero so there is no need to check. Signed-off-by: Dan Carpenter diff --git a/drivers/net/ethernet/mellanox/mlxsw/core_hwmon.c b/drivers/net/ethernet/mellanox/mlxsw/core_hwmon.c index 4dad146..913106d 100644 ---

Re: arRe: [PATCH net-next 2/2] net: hns: enet specisies a reference to dsaf (config and documents)

On 2015/12/7 17:40, Arnd Bergmann wrote: > On Monday 07 December 2015 15:14:13 Yankejian wrote: >> On 2015/12/6 6:19, Arnd Bergmann wrote: >>> On Saturday 05 December 2015 14:10:56 yankejian wrote: diff --git a/Documentation/devicetree/bindings/net/hisilicon-hns-dsaf.txt

[PATCH] net : To avoid execution of extra instructions in NET RX path when rps_map is not set but rps_needed is true.

From: Ashutosh Kaushik The patch fixes the issues with check of global flag "rps_needed" in RX Path (which process packets in TCP/IP stack like netif_rx and netif_receive_skb functions) These functions have flag CONFIG RPS which is enabled default in kernel and to

Re: [PATCH 1/3] ser_gigaset: fix up NULL checks

Am 08.12.2015 um 23:16 schrieb One Thousand Gnomes: > The right fix as far as I can see is to remove the tests although > WARN_ON() combined with your tty->ops change might be safer. Feel free to submit a patch. >> It's pretty obvious that this should have been part of commit >> f34d7a5b7010

[PATCH net-next] cxgb4: Handle clip return values

Add a warn message when clip table overflows. If clip table isn't allocated, return from cxgb4_clip_release() to avoid panic. Disable offload if clip isn't enabled in the hardware. Signed-off-by: Hariprasad Shenai --- drivers/net/ethernet/chelsio/cxgb4/clip_tbl.c | 11

RE: [PATCH 2/2] net: thunderx: Enable CQE count threshold interrupt

Hello! > -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On > Behalf Of Sunil > Goutham > Sent: Wednesday, December 09, 2015 2:38 PM > To: netdev@vger.kernel.org > Cc: linux-ker...@vger.kernel.org; linux-arm-ker...@lists.infradead.org; >

Re: [PATCH v2 next 1/2] dts: hisi: fixes no syscon error when init mdio

On 2015/12/8 23:25, Rob Herring wrote: > On Mon, Dec 07, 2015 at 04:25:06PM +0800, yankejian wrote: >> Signed-nux start up, we get the log below: >> "Hi-HNS_MDIO 803c.mdio: no syscon hisilicon,peri-c-subctrl >> mdio_bus mdio@803c: mdio sys ctl reg has not maped " >> >> the source

Re: [RFC PATCH V2 0/3] IXGBE/VFIO: Add live migration support for SRIOV NIC

On 12/9/2015 6:37 PM, Michael S. Tsirkin wrote: On Sat, Dec 05, 2015 at 12:32:00AM +0800, Lan, Tianyu wrote: Hi Michael & Alexander: Thanks a lot for your comments and suggestions. It's nice that it's appreciated, but you then go on and ignore all that I have written here:

Re: [PATCH net-next 0/2] mlx5 minor SRIOV fixes

On Wed, Dec 9, 2015 at 4:41 AM, David Miller wrote: > > Don't do this, submitting two disconnected patch series for the same > driver (mlx5), for the same tree (net-next). > for next time ? or you want me to re-submit those two patch sets ? > Just submit them all in one

Re: Checksum offload queries

On 08/12/15 17:06, David Miller wrote: > All of the headers get touched anyways as each layer of the stack > demuxes > the packet. Therefore there is _ZERO_ cost to use 1's > complement to > validate checksums in input. It's always superior. Ah, I understand now, it's touching the memory that's

Re: [PATCH 1/2] net: thunderx: HW TSO support for pass-2 hardware

>> + booltns_mode:1; >> + boolsqs_mode:1; >These little refactors are creeping in your code without even being mentioned in the commit message, this is not good practice. Okay, will include these in the commit message. >IMHO. Additionally, may be

Re: [PATCH v1 1/6] net: Generalize udp based tunnel offload

On 12/08/15 at 09:45pm, Alexei Starovoitov wrote: > definetely not 1, not 2 and hardly 3. > bpf verifier in 2k lines does full code analysis with all branches, > memory accesses and so on, so it's not hard to understand _intent_ > of the program by any HW backend. > I agree with John that it's not

Re: [PATCH net-next] ipv6: allow routes to be configured with expire values

On Wed, Dec 9, 2015 at 11:56 AM, David Miller wrote: > From: Xin Long > Date: Tue, 8 Dec 2015 22:37:44 +0800 > >> Add the support for adding expire value to routes, requested by >> Tom Gundersen for systemd-networkd, and NetworkManager

Re: [PATCH] NFC: nci: fix memory leak

On Mon, Nov 16, 2015 at 06:27:15PM +0530, Sudip Mukherjee wrote: > In case of invalid number_destination_params we were returning error but > we missed releasing cmd. Lets check for the number of parameter before > allocating memory so that we don't have a memory leak. > > Signed-off-by: Sudip

RE: [PATCH 1/2] net: thunderx: HW TSO support for pass-2 hardware

Hello! > -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On > Behalf Of Sunil > Goutham > Sent: Wednesday, December 09, 2015 2:38 PM > To: netdev@vger.kernel.org > Cc: linux-ker...@vger.kernel.org; linux-arm-ker...@lists.infradead.org; >

Re: [PATCH] net : To avoid execution of extra instructions in NET RX path when rps_map is not set but rps_needed is true.

Wed, Dec 09, 2015 at 11:35:21AM CET, rahul.j...@samsung.com wrote: >From: Ashutosh Kaushik > >The patch fixes the issues with check of global flag "rps_needed" in RX Path >(which process packets in TCP/IP stack like netif_rx and netif_receive_skb >functions) First of

Re: [net-next,1/2] net: Set sk_txhash from a random number

08.12.2015 19:33, Tom Herbert wrote: On Tue, Dec 8, 2015 at 5:15 AM, Eric Dumazet wrote: There never has been such guarantee. Even rx hashes for a single TCP flow can differ, if packets are received on two different NIC with different RSSS keys. +1, it is a salient

Re: [PATCH 2/2] chacha20poly1305: Skip encryption/decryption for 0-len

On Sun, Dec 06, 2015 at 02:51:38AM +0100, Jason A. Donenfeld wrote: > If the length of the plaintext is zero, there's no need to waste cycles > on encryption and decryption. Using the chacha20poly1305 construction > for zero-length plaintexts is a common way of using a shared encryption > key for

Re: [PATCH 2/3] ser_gigaset: fix deallocation of platform device structure

Am 09.12.2015 um 00:12 schrieb Paul Bolle: >> --- a/drivers/isdn/gigaset/ser-gigaset.c >> +++ b/drivers/isdn/gigaset/ser-gigaset.c >> @@ -370,19 +370,23 @@ static void gigaset_freecshw(struct cardstate >> *cs) >> tasklet_kill(>write_tasklet); >> if (!cs->hw.ser) >> return;

[PATCH 0/2] net: thunderx: Support for pass-2 hw features

From: Sunil Goutham This patch set adds support for new features added in pass-2 revision of hardware like TSO and count based interrupt coalescing. Sunil Goutham (2): net: thunderx: HW TSO support for pass-2 hardware net: thunderx: Enable CQE count threshold interrupt

Re: [RFC PATCH V2 0/3] IXGBE/VFIO: Add live migration support for SRIOV NIC

On 12/9/2015 7:28 PM, Michael S. Tsirkin wrote: I remember reading that it's possible to implement a bus driver on windows if required. But basically I don't see how windows can be relevant to discussing guest driver patches. That discussion probably belongs on the qemu maling list, not on

Re: [PATCH 2/2] net: thunderx: Enable CQE count threshold interrupt

Will take care of above suggestions and resubmit. Thanks, Sunil. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH net-next v2] net: Add fib rules at vrf device create

On 12/08/15 at 08:08pm, David Ahern wrote: > On 12/8/15 7:44 PM, David Miller wrote: > >Unfortunately it's too late for this, you should have considered this > >issue fully when VRF first went into an upstream release. > > > >If I add your change, the user experience is _worse_. > > > >Users on

Re: [PATCH] net : To avoid execution of extra instructions in NET RX path when rps_map is not set but rps_needed is true.

On Wed, 2015-12-09 at 16:05 +0530, Rahul Jain wrote: > From: Ashutosh Kaushik > > The patch fixes the issues with check of global flag "rps_needed" Hi Rahul I have no issue here. What is the issue exactly ? You provide no perf numbers, so it is hard to guess what

[PATCH 2/2] net: thunderx: Enable CQE count threshold interrupt

From: Sunil Goutham This feature is introduced in pass-2 chip and with this CQ interrupt coalescing will work based on both timer and count. Signed-off-by: Sunil Goutham --- drivers/net/ethernet/cavium/thunder/nic.h |2 ++

[PATCH 1/2] net: thunderx: HW TSO support for pass-2 hardware

From: Sunil Goutham This adds support for offloading TCP segmentation to HW in pass-2 revision of hardware. Both driver level SW TSO for pass1.x chips and HW TSO for pass-2 chip will co-exist. Signed-off-by: Sunil Goutham ---

Re: [PATCH 1/3] ser_gigaset: fix up NULL checks

On Wed, 9 Dec 2015 11:45:57 +0100 Tilman Schmidt wrote: > Am 08.12.2015 um 23:16 schrieb One Thousand Gnomes: > > The right fix as far as I can see is to remove the tests although > > WARN_ON() combined with your tty->ops change might be safer. > > Feel free to submit a patch.

Re: [patch -next] mlxsw: spectrum: fix some error handling

Wed, Dec 09, 2015 at 11:33:51AM CET, dan.carpen...@oracle.com wrote: >The "err = " assignment is missing here. > >Fixes: 0d65fc13042f ('mlxsw: spectrum: Implement LAG port join/leave') >Signed-off-by: Dan Carpenter Acked-by: Jiri Pirko Thanks. -- To

Re: [patch -next] mlxsw: core: remove an unneeded condition

Wed, Dec 09, 2015 at 11:41:29AM CET, dan.carpen...@oracle.com wrote: >We already know "err" is zero so there is no need to check. > >Signed-off-by: Dan Carpenter Acked-by: Jiri Pirko Thanks. -- To unsubscribe from this list: send the line

Re: [RFC PATCH V2 0/3] IXGBE/VFIO: Add live migration support for SRIOV NIC

On Wed, Dec 09, 2015 at 07:19:15PM +0800, Lan, Tianyu wrote: > On 12/9/2015 6:37 PM, Michael S. Tsirkin wrote: > >On Sat, Dec 05, 2015 at 12:32:00AM +0800, Lan, Tianyu wrote: > >>Hi Michael & Alexander: > >>Thanks a lot for your comments and suggestions. > > > >It's nice that it's appreciated, but

Re: [PATCH 1/2] blkcipher: Copy iv from desc even for 0-len walks

On Sun, Dec 06, 2015 at 02:51:37AM +0100, Jason A. Donenfeld wrote: > Some ciphers actually support encrypting zero length plaintexts. For > example, many AEAD modes support this. The resulting ciphertext for > those winds up being only the authentication tag, which is a result of > the key, the

Re: forwarding of ipv4 link local addresses

On 12/03/15 at 02:35pm, David Miller wrote: > From: David Ahern > Date: Tue, 1 Dec 2015 13:35:58 -0800 > > > RFC 3927 states that packets from/to IPv4 link-local addresses > > (169.254/16) should not be forwarded, yet the Linux networking stack > > happily forwards

use-after-free in inet6_destroy_sock

Hello, The following program causes use-after-free in inet6_destroy_sock: // autogenerated by syzkaller (http://github.com/google/syzkaller) #include #include #include #include #include #include #include #include int cfd = -1; void *thr(void *arg) { cfd = syscall(SYS_socket,

Re: [PATCH net-next] mpls_iptunnel: add static qualifier to mpls_output

On 09/12/15 14:56, Roopa Prabhu wrote: From: Roopa Prabhu This gets rid of the following compile warn: net/mpls/mpls_iptunnel.c:40:5: warning: no previous prototype for mpls_output [-Wmissing-prototypes] Acked-by: Robert Shearman

Re: [PATCH net-next v4 4/8] openvswitch: Update the CT state key only after nf_conntrack_in().

Hello. On 12/9/2015 4:01 AM, Jarno Rajahalme wrote: Only a successful nf_conntrack_in() call can effect a connection state change, so if suffices to update the key only after the nf_conntrack_in() returns. This change is needed for the later NAT patches. Signed-off-by: Jarno Rajahalme

Re: [PATCH net] net:sysctl fix the confusing corner of tcp_mem

Hello. On 12/9/2015 5:01 AM, Wang Yufen wrote: From: Yufen Wang I tried on linux-4.1: linux:~# cat /proc/sys/net/ipv4/tcp_mem 83886081258291216777216 linux:~# echo 1234 >/proc/sys/net/ipv4/tcp_mem -bash: echo: write error: Invalid

Re: [netfilter-core] [PATCH] netfilter: nfnetlink_queue: Unregister pernet subsys in case of init failure

On Mon, Dec 07, 2015 at 02:17:46PM +0100, Pablo Neira Ayuso wrote: > On Mon, Dec 07, 2015 at 02:58:44PM +0200, Nikolay Borisov wrote: > > > > > > On 12/07/2015 02:29 PM, Sergei Shtylyov wrote: > > > Hello. > > > > > > On 12/07/2015 01:13 PM, Nikolay Borisov wrote: > > > > > >> Commit

Re: use-after-free in sctp_do_sm

On Tue, Dec 8, 2015 at 8:22 PM, Dmitry Vyukov wrote: > On Tue, Dec 8, 2015 at 6:40 PM, Marcelo Ricardo Leitner > wrote: >> On Tue, Dec 08, 2015 at 06:30:51PM +0100, Dmitry Vyukov wrote: >>> On Mon, Dec 7, 2015 at 9:52 PM, Marcelo Ricardo Leitner >>>

[PATCH net-next] mpls_iptunnel: add static qualifier to mpls_output

From: Roopa Prabhu This gets rid of the following compile warn: net/mpls/mpls_iptunnel.c:40:5: warning: no previous prototype for mpls_output [-Wmissing-prototypes] Signed-off-by: Roopa Prabhu --- net/mpls/mpls_iptunnel.c | 2 +- 1 file

Re: use-after-free in inet6_destroy_sock

On Wed, Dec 9, 2015 at 6:59 AM, Marcelo Ricardo Leitner wrote: > On Wed, Dec 09, 2015 at 06:43:28AM -0800, Eric Dumazet wrote: > >> I can certainly send a patch, but maybe someone already cooked it and >> is testing it ? > > Speaking for me, I don't have it yet, at

Re: use-after-free in sctp_do_sm

On Wed, Dec 09, 2015 at 03:41:29PM +0100, Dmitry Vyukov wrote: > On Tue, Dec 8, 2015 at 8:22 PM, Dmitry Vyukov wrote: > > On Tue, Dec 8, 2015 at 6:40 PM, Marcelo Ricardo Leitner > > wrote: ... > >> The patches were combined already, but this last

Re: [PATCH] netfilter: Initialize local variables to NULL, to prevent using them when uninitialized.

We already have this: http://git.kernel.org/cgit/linux/kernel/git/pablo/nf.git/commit/?id=8e662164abb4a8fde701a46e1431980f9e325742 We'll be sending this today to David to avoid this annoyance. Thanks for you patch anyway. -- To unsubscribe from this list: send the line "unsubscribe netdev" in

Re: [PATCH net] nftables: use list_for_each_entry_safe_reverse to traversal commit_list in nf_tables_abort

On Mon, Dec 07, 2015 at 06:48:07PM +0800, Xin Long wrote: > when we use 'nft -f' to sumbit rules, it will build multiple rules into > one netlink skb to send to kernel, kernel will process them one by one. > meanwhile, it add the trans into commit_list to record every commit. > if one of them's

Re: use-after-free in inet6_destroy_sock

On Wed, Dec 9, 2015 at 6:15 AM, Dmitry Vyukov wrote: > Hello, > > The following program causes use-after-free in inet6_destroy_sock: > > // autogenerated by syzkaller (http://github.com/google/syzkaller) > #include > #include > #include > #include > #include > #include >

Re: forwarding of ipv4 link local addresses

On 12/09/15 at 02:44pm, Thomas Graf wrote: > This feature is being used by a popular PaaS which leverages the > 127/8 address space locally without polluting an entire routeable > address space. Kubernetes also wants to rely on this eventually, so please let's not break it ;-) -- To unsubscribe

Re: [PATCH net-next] ravb: ptp: fix misplaced ravb_ptp_stop() calling in ravb_probe()

Hello. On 12/8/2015 9:39 PM, Yoshihiro Kaneko wrote: 'commit ("ravb: ptp: Add CONFIG mode support")' added a calling of ravb_ptp_stop() in a wrong place in ravb_probe(). Signed-off-by: Yoshihiro Kaneko Well, this patch is good to apply anyway: Acked-by: Sergei

Re: [PATCH] sbc8641: drop bogus PHY IRQ entries from DTS file

[Re: [PATCH] sbc8641: drop bogus PHY IRQ entries from DTS file] On 09/12/2015 (Wed 04:07) Andrew Lunn wrote: > On Tue, Dec 08, 2015 at 05:44:02PM -0500, Paul Gortmaker wrote: > > This file was originally cloned off of the MPC8641D-HPCN reference > > platform, which actually had a PHY IRQ line

Re: use-after-free in inet6_destroy_sock

On Wed, Dec 09, 2015 at 06:43:28AM -0800, Eric Dumazet wrote: > On Wed, Dec 9, 2015 at 6:15 AM, Dmitry Vyukov wrote: > > Hello, > > > > The following program causes use-after-free in inet6_destroy_sock: > > > > // autogenerated by syzkaller (http://github.com/google/syzkaller)

Re: [PATCH -mm] net: drop tcp_memcontrol.c

On Wed, Dec 09, 2015 at 03:50:00PM +0300, Vladimir Davydov wrote: > tcp_memcontrol.c only contains legacy memory.tcp.kmem.* file definitions > and mem_cgroup->tcp_mem init/destroy stuff. This doesn't belong to > network subsys. Let's move it to memcontrol.c. This also allows us to > reuse generic

Re: Checksum offload queries

On Wed, Dec 9, 2015 at 4:14 AM, Edward Cree wrote: > On 08/12/15 17:06, David Miller wrote: >> All of the headers get touched anyways as each layer of the stack > demuxes >> the packet. Therefore there is _ZERO_ cost to use 1's > complement to >> validate checksums in

Re: [PATCH net] nftables: use list_for_each_entry_safe_reverse to traversal commit_list in nf_tables_abort

ok, the reproducer: 1. #nft delete table foo #nft add table foo #nft list tables #nft list table foo #nft add chain foo bar #nft add chain foo baz #nft add chain foo bok #nft list table foo 2. #nft -f panic.rules --panic.rules--- add rule foo bar ip saddr 127.0.0.1 accept add rule foo bar

[PATCH net] ipv6: sctp: clone options to avoid use after free

From: Eric Dumazet SCTP is lacking proper np->opt cloning at accept() time. TCP and DCCP use ipv6_dup_options() helper, do the same in SCTP. We might later factorize this code in a common helper to avoid future mistakes. Reported-by: Dmitry Vyukov

Re: [PATCH] sbc8641: drop bogus PHY IRQ entries from DTS file

> > Originally the interrupt is used for detecting the link has gone > > down. That would of also been bogus before. Have you tried this? If > > Haven't tried it, but chances are you are right. > > > that is also broken, maybe you need to add a fixes: tag so that it > > gets back ported? > >

Re: [PATCH net] ipv6: sctp: clone options to avoid use after free

On 12/09/2015 10:25 AM, Eric Dumazet wrote: > From: Eric Dumazet > > SCTP is lacking proper np->opt cloning at accept() time. > > TCP and DCCP use ipv6_dup_options() helper, do the same > in SCTP. > > We might later factorize this code in a common helper to avoid > future

[PATCH v3 4/4] VSOCK: Add Makefile and Kconfig

From: Asias He Enable virtio-vsock and vhost-vsock. Signed-off-by: Asias He Signed-off-by: Stefan Hajnoczi --- v3: * Don't put vhost vsock driver into staging * Add missing Kconfig dependencies (Arnd Bergmann ) ---

[PATCH v3 3/4] VSOCK: Introduce vhost-vsock.ko

From: Asias He VM sockets vhost transport implementation. This module runs in host kernel. Signed-off-by: Asias He Signed-off-by: Stefan Hajnoczi --- v3: * Remove unneeded variable used to store return value (Fengguang Wu

[PATCH v3 1/4] VSOCK: Introduce virtio-vsock-common.ko

From: Asias He This module contains the common code and header files for the following virtio-vsock and virtio-vhost kernel modules. Signed-off-by: Asias He Signed-off-by: Stefan Hajnoczi --- v3: * Remove unnecessary 3-way handshake,

[PATCH v3 0/4] Add virtio transport for AF_VSOCK

Note: the virtio-vsock device specification is currently under review but not yet finalized. Please review this code but don't merge until I send an update when the spec is finalized. Thanks! v3: * Remove unnecessary 3-way handshake, just do REQUEST/RESPONSE instead of REQUEST/RESPONSE/ACK

Re: [PATCH net] nftables: use list_for_each_entry_safe_reverse to traversal commit_list in nf_tables_abort

On Wed, Dec 9, 2015 at 10:03 PM, Pablo Neira Ayuso wrote: > On Mon, Dec 07, 2015 at 06:48:07PM +0800, Xin Long wrote: >> when we use 'nft -f' to sumbit rules, it will build multiple rules into >> one netlink skb to send to kernel, kernel will process them one by one. >>

[PATCHv2 net-next] ipv6: allow routes to be configured with expire values

Add the support for adding expire value to routes, requested by Tom Gundersen for systemd-networkd, and NetworkManager wants it too. add it by using the field rta_expires of rta_cacheinfo Signed-off-by: Xin Long Signed-off-by: Hannes Frederic Sowa

Re: [PATCH 00/14] mm: memcontrol: account socket memory in unified hierarchy v4-RESEND

On Tuesday 08 December 2015 10:30:10 Johannes Weiner wrote: > Hi Andrew, > > there was some build breakage in CONFIG_ combinations I hadn't tested > in the last revision, so here is a fixed-up resend with minimal CC > list. The only difference to the previous version is a section in >

Re: [RFC PATCH V2 0/3] IXGBE/VFIO: Add live migration support for SRIOV NIC

On Wed, Dec 9, 2015 at 1:28 AM, Lan, Tianyu wrote: > > > On 12/8/2015 1:12 AM, Alexander Duyck wrote: >> >> On Mon, Dec 7, 2015 at 7:40 AM, Lan, Tianyu wrote: >>> >>> On 12/5/2015 1:07 AM, Alexander Duyck wrote: > > > > We still need to

[PATCH] iwlegacy: mark il_adjust_beacon_interval as noinline

With the new optimized do_div() code, some versions of gcc produce obviously incorrect code that leads to a link error in iwlegacy/common.o: drivers/built-in.o: In function `il_send_rxon_timing': :(.text+0xa6b4d4): undefined reference to `ilog2_NaN' :(.text+0xa6b4f0): undefined reference to

RE: [PATCH net] ipv6: sctp: clone options to avoid use after free

> SCTP is lacking proper np->opt cloning at accept() time. > > TCP and DCCP use ipv6_dup_options() helper, do the same in SCTP. > > We might later factorize this code in a common helper to avoid > future mistakes. I'm wondering what the real impact of this and the other recent SCTP bugs/patches

Re: [PATCH] net : To avoid execution of extra instructions in NET RX path when rps_map is not set but rps_needed is true.

Hi Ashutosh, [auto build test ERROR on net-next/master] [also build test ERROR on v4.4-rc4 next-20151209] url: https://github.com/0day-ci/linux/commits/Rahul-Jain/net-To-avoid-execution-of-extra-instructions-in-NET-RX-path-when-rps_map-is-not-set-but-rps_needed-is-true/20151209-183932 config

[PATCH v3 2/4] VSOCK: Introduce virtio-vsock.ko

From: Asias He VM sockets virtio transport implementation. This module runs in guest kernel. Signed-off-by: Asias He Signed-off-by: Stefan Hajnoczi --- v2: * Fix total_tx_buf accounting * Add virtio_transport global mutex to prevent

[PATCH] mm: memcontrol: MEMCG no longer works with SLOB

The change to move the kmem accounting into the normal memcg code means we can no longer use memcg with slob, which lacks the memcg_params member in its struct kmem_cache: ../mm/slab.h: In function 'is_root_cache': ../mm/slab.h:187:10: error: 'struct kmem_cache' has no member named

[PATCH] mm: memcontrol: only manage socket pressure for CONFIG_INET

When IPV4 support is disabled, the memcg->socket_pressure field is not defined and we get a build error from the vmpressure code: mm/vmpressure.c: In function 'vmpressure': mm/vmpressure.c:287:9: error: 'struct mem_cgroup' has no member named 'socket_pressure' memcg->socket_pressure =

  1   2   3   >