[PATCH 1/1] net/ipv6: add sysctl option accept_ra_min_hop_limit

2016-01-04 Thread Yuki Machida
Please apply the following patch to v4.1.x. By ommit 6fd99094de2b ("ipv6: Don't reduce hop limit for an interface") that have been added in the 4.0-rc7, it no longer comply with RFC4861. This problem has been fixed in the commit 8013d1d7eafb ("net/ipv6: add sysctl option accept_ra_min_hop_limit")

[PATCH v3 net-next] net: ethernet: cadence-macb: Add disabled usrio caps

2016-01-04 Thread Neil Armstrong
On some platforms, the macb integration does not use the USRIO register to configure the (R)MII port and clocks. When the register is not implemented and the MACB error signal is connected to the bus error, reading or writing to the USRIO register can trigger some Imprecise External Aborts on ARM p

Re: [PATCH] net: Fix potential NULL pointer dereference in __skb_try_recv_datagram

2016-01-04 Thread Jacob Siverskog
On Wed, Dec 30, 2015 at 11:30 PM, Cong Wang wrote: > On Wed, Dec 30, 2015 at 6:30 AM, Jacob Siverskog > wrote: >> On Wed, Dec 30, 2015 at 2:26 PM, Eric Dumazet wrote: >>> How often can you trigger this bug ? >> >> Ok. I don't have a good repro to trigger it unfortunately, I've seen it just >> a

Re: [PATCH v3 net-next] net: ethernet: cadence-macb: Add disabled usrio caps

2016-01-04 Thread Nicolas Ferre
Le 04/01/2016 10:01, Neil Armstrong a écrit : > On some platforms, the macb integration does not use the USRIO > register to configure the (R)MII port and clocks. > When the register is not implemented and the MACB error signal > is connected to the bus error, reading or writing to the USRIO > regi

Re: [PATCH 1/3] rsi: Delete unnecessary variable initialisations in rsi_send_mgmt_pkt()

2016-01-04 Thread Dan Carpenter
These patches are labour intensive to review because you can't just do it in the email client. Also you were not able to review it properly yourself and introduced a bug. I am often remove initializers but it's normally because I am changing something else which makes it worthwhile. This patch i

Re: [PATCH 1/3] net-iwlegacy: Refactoring for il_eeprom_init()

2016-01-04 Thread Stanislaw Gruszka
On Fri, Jan 01, 2016 at 09:30:10PM +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Fri, 1 Jan 2016 20:54:25 +0100 > > Return directly if a memory allocation failed at the beginning. > > Signed-off-by: Markus Elfring Acked-by: Stanislaw Gruszka -- To unsubscribe from this list:

Re: [PATCH] iwlegacy: 4965-mac: constify il_sensitivity_ranges structure

2016-01-04 Thread Stanislaw Gruszka
On Wed, Dec 30, 2015 at 12:20:49PM +0100, Julia Lawall wrote: > The il_sensitivity_ranges is never modified, so declare it as const. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall Acked-by: Stanislaw Gruszka -- To unsubscribe from this list: send the line "unsubscribe n

Re: [PATCH 1/3] rsi: Delete unnecessary variable initialisations in rsi_send_mgmt_pkt()

2016-01-04 Thread Dan Carpenter
Btw, GCC misses a lot of uninitialized variable bugs. I have a Smatch check which sometimes catches the bugs that GCC misses but you should not rely on the tools here. These patches need to be reviewed manually. And the "goto err" before the initialization makes everything more complicated (that

Re: [PATCH 0/5] xen-netback: Fine-tuning for three function implementations

2016-01-04 Thread Dan Carpenter
The original code is fine. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[patch net-next 0/4] mlxsw: couple of fixes

2016-01-04 Thread Jiri Pirko
From: Jiri Pirko Couple of fixes from Ido. Ido Schimmel (4): mlxsw: spectrum: Initialize PVID only once mlxsw: spectrum: Return NOTIFY_BAD on bridge failure mlxsw: spectrum: Set bridge status in appropriate functions mlxsw: spectrum: Change bridge port attributes only when bridged driv

[patch net-next 2/4] mlxsw: spectrum: Return NOTIFY_BAD on bridge failure

2016-01-04 Thread Jiri Pirko
From: Ido Schimmel It is possible for us to fail when joining or leaving a bridge, so let the user know about that by returning NOTIFY_BAD, as already done for LAG join/leave and 802.1D bridges. Signed-off-by: Ido Schimmel Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/spec

[patch net-next 3/4] mlxsw: spectrum: Set bridge status in appropriate functions

2016-01-04 Thread Jiri Pirko
From: Ido Schimmel Set the bridge status of physical ports in the appropriate functions, to be consistent with LAG join/leave and vPorts joining/leaving bridge. Also, remove the error messages in these two functions, as we already emit errors in both the single functions they call. Signed-off-b

[patch net-next 1/4] mlxsw: spectrum: Initialize PVID only once

2016-01-04 Thread Jiri Pirko
From: Ido Schimmel We set PVID to 1 in mlxsw_sp_port_vlan_init(), so we can remove this statement. Signed-off-by: Ido Schimmel Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlxsw/sp

[PATCH v4 net-next 0/3] Add new capability and macb DT variant

2016-01-04 Thread Neil Armstrong
The first patch introduces a new capability bit to disable usage of the USRIO register on platform not implementing it thus avoiding some external imprecise aborts on ARM based platforms. The two last patchs adds a new macb variant compatible name using the capability, the NPx name is temporary and

[patch net-next 4/4] mlxsw: spectrum: Change bridge port attributes only when bridged

2016-01-04 Thread Jiri Pirko
From: Ido Schimmel Bridge port attributes are offloaded to hardware when invoked with SELF flag set, but it really makes no sense to reflect them when port is not bridged. Allow a user to change these attribute only when port is bridged and initialize them correctly when joining or leaving a bri

[PATCH v4 net-next 2/3] net: macb: Add NPx macb config using USRIO_DISABLED cap

2016-01-04 Thread Neil Armstrong
Declare a new SoC variant for NPx SoCs having USRIO_DISABLED as capability bit. Signed-off-by: Neil Armstrong --- drivers/net/ethernet/cadence/macb.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c index fa53bc3

[PATCH v4 net-next 1/3] net: ethernet: cadence-macb: Add disabled usrio caps

2016-01-04 Thread Neil Armstrong
On some platforms, the macb integration does not use the USRIO register to configure the (R)MII port and clocks. When the register is not implemented and the MACB error signal is connected to the bus error, reading or writing to the USRIO register can trigger some Imprecise External Aborts on ARM p

[PATCH v4 net-next 3/3] dt-bindings: net: macb: Add NPx macb variant

2016-01-04 Thread Neil Armstrong
Add NPx macb variant for NPx SoCs. Signed-off-by: Neil Armstrong --- Documentation/devicetree/bindings/net/macb.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/net/macb.txt b/Documentation/devicetree/bindings/net/macb.txt index 38c8e84..638cdde 100644 -

[PATCH iproute2 4/4] man: iplink: document new addrgenmodes

2016-01-04 Thread Bjørn Mork
Cc: Hannes Frederic Sowa Signed-off-by: Bjørn Mork --- man/man8/ip-link.8.in | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/man/man8/ip-link.8.in b/man/man8/ip-link.8.in index ac6f4813a329..189a8f15fa03 100644 --- a/man/man8/ip-link.8.in +++ b/man/man8/ip

[PATCH iproute2 2/4] iplink: support setting addrgenmode stable_secret

2016-01-04 Thread Bjørn Mork
It is possible to switch to another addrgenmode after setting a valid secret. Allow switching back without reconfiguring the secret for completeness. Cc: Hannes Frederic Sowa Signed-off-by: Bjørn Mork --- ip/iplink.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ip/ipl

[PATCH iproute2 0/4] addrgenmode updates for net-next

2016-01-04 Thread Bjørn Mork
This adds support for the new "random" addrgenmode in net-next and improves the support for the "stable_secret" mode. Bjørn Mork (4): include: update kernel headers iplink: support setting addrgenmode stable_secret iplink: support show and set of "addrgenmode random" man: iplink: document

[PATCH iproute2 3/4] iplink: support show and set of "addrgenmode random"

2016-01-04 Thread Bjørn Mork
"random" is a new IPv6 addrgenmode, enabling "stable_secret" type addresses with an auto-generated secret. $ ip link set eth0 addrgenmode random $ ip -d link show dev eth0 2: eth0: mtu 1500 qdisc pfifo_fast state DOWN mode DEFAULT group default qlen 1000 link/ether 00:21:86:a3:25:7d brd ff:

[PATCH iproute2 1/4] include: update kernel headers

2016-01-04 Thread Bjørn Mork
Import current if_link.h from net-next Signed-off-by: Bjørn Mork --- include/linux/if_link.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/if_link.h b/include/linux/if_link.h index c9ad487d04f0..d91f2c97d946 100644 --- a/include/linux/if_link.h +++ b/include/linux/if_link.h @

Re: net-libertas: Better exception handling in if_spi_host_to_card_worker()

2016-01-04 Thread Arend van Spriel
On 03-01-16 16:18, Rafał Miłecki wrote: > On 3 January 2016 at 10:36, Arend van Spriel wrote: >> On 02-01-16 12:21, SF Markus Elfring wrote: Did you look at the resulting assembly code for different target architectures? >>> >>> Not yet. - Which execution system variants would you rec

Re: [PATCH v4 net-next 2/3] net: macb: Add NPx macb config using USRIO_DISABLED cap

2016-01-04 Thread Nicolas Ferre
Le 04/01/2016 10:42, Neil Armstrong a écrit : > Declare a new SoC variant for NPx SoCs having USRIO_DISABLED as > capability bit. > > Signed-off-by: Neil Armstrong > --- > drivers/net/ethernet/cadence/macb.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/net/ethernet/cad

Re: [PATCH 1/3] rsi: Delete unnecessary variable initialisations in rsi_send_mgmt_pkt()

2016-01-04 Thread SF Markus Elfring
> These patches are labour intensive to review because you can't just do > it in the email client. Thanks for your general interest. > Also you were not able to review it properly yourself and introduced > a bug. I admit that it can happen during my software development that I overlook implemen

Re: [PATCH 0/5] xen-netback: Fine-tuning for three function implementations

2016-01-04 Thread Wei Liu
I think the original code is fine. Wei. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: net-libertas: Better exception handling in if_spi_host_to_card_worker()

2016-01-04 Thread Rafał Miłecki
On 4 January 2016 at 11:05, Arend van Spriel wrote: > On 03-01-16 16:18, Rafał Miłecki wrote: >> On 3 January 2016 at 10:36, Arend van Spriel wrote: >>> On 02-01-16 12:21, SF Markus Elfring wrote: > Did you look at the resulting assembly code for different target > architectures? >>

Re: [PATCH 1/3] rsi: Delete unnecessary variable initialisations in rsi_send_mgmt_pkt()

2016-01-04 Thread Dan Carpenter
On Mon, Jan 04, 2016 at 11:44:15AM +0100, SF Markus Elfring wrote: > > Please stop sending cleanup patches, Markus. Just send fixes. > > How often will source code clean-up fix something? > > > May I resend a consistent patch series for the source file > "drivers/net/wireless/rsi/rsi_91x_pkt.c"

Re: [RFC PATCH net-next 3/3] macsec: introduce IEEE 802.1AE driver

2016-01-04 Thread Florian Westphal
Sabrina Dubroca wrote: [ Sorry for long delay ] > 2015-12-29, 02:14:06 +0100, Florian Westphal wrote: > > > + tx_sa->next_pn++; > > > + if (tx_sa->next_pn == 0) { > > > + pr_notice("PN wrapped, transitionning to !oper\n"); > > > > Is that _notice intentional? > > I'm only asking because

Re: rsi: Delete unnecessary variable initialisations in rsi_send_mgmt_pkt()

2016-01-04 Thread SF Markus Elfring
>> May I resend a consistent patch series for the source file >> "drivers/net/wireless/rsi/rsi_91x_pkt.c" in the near future? > > If you were sending checkpatch.pl fixes that would be easier to deal with Does this feedback mean that you would accept any more suggestions around source code updates

[PATCH (net-next.git) 08/18] stmmac: merge get_rx_owner into rx_status routine.

2016-01-04 Thread Giuseppe Cavallaro
From: Fabrice Gasnier The RDES0 register can be read several times while doing RX of a packet. This patch slightly improves RX path performance by reading rdes0 once for two operation: check rx owner, get rx status bits. Signed-off-by: Fabrice Gasnier Acked-by: Giuseppe Cavallaro --- drivers/

[PATCHv2 (net-next.git) 00/18] stmmac: enhance driver performances and update the version

2016-01-04 Thread Giuseppe Cavallaro
This is a subset of patches to rework the driver in order to improve its performances and make it more robust under stress conditions. All patches have been ported on STi mainstream kernel branch and tested on ARM STiH4xx platforms and newer ones. This series also updates the driver version and p

[PATCH (net-next.git) 01/18] stmmac: share reset function between dwmac100 and dwmac1000

2016-01-04 Thread Giuseppe Cavallaro
This patch is to share the same reset procedure between dwmac100 and dwmac1000 chips. This will also help on enhancing the driver and support new chips. Signed-off-by: Giuseppe Cavallaro --- drivers/net/ethernet/stmicro/stmmac/common.h |3 +- drivers/net/ethernet/stmicro/stmmac/dwmac10

[PATCH (net-next.git) 02/18] stmmac: rework DMA bus setting and introduce new platform AXI structure

2016-01-04 Thread Giuseppe Cavallaro
This patch restructures the DMA bus settings and this is done by introducing a new platform structure used for programming the AXI Bus Mode Register inside the DMA module. This structure can be populated from device-tree as documented in the binding txt file. After initializing the DMA, the AXI re

[PATCH (net-next.git) 18/18] stmmac: update version to Oct_2015

2016-01-04 Thread Giuseppe Cavallaro
This patch just updates the driver to the version fully tested on STi platforms. This version is Oct_2015. Signed-off-by: Giuseppe Cavallaro --- drivers/net/ethernet/stmicro/stmmac/stmmac.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stm

[PATCH (net-next.git) 17/18] stmmac: tune rx copy via threshold.

2016-01-04 Thread Giuseppe Cavallaro
There is a threshold now used to also limit the skb allocation when use zero-copy. This is to avoid that there are incoherence in the ring due to a failure on skb allocation under very aggressive testing and under low memory conditions. Signed-off-by: Giuseppe Cavallaro --- drivers/net/ethernet/

[PATCH (net-next.git) 15/18] stmmac: fix phy init when attached to a phy

2016-01-04 Thread Giuseppe Cavallaro
From: Fabrice Gasnier phy_bus_name can be NULL when "fixed-link" property isn't used. Then, since "stmmac: do not poll phy handler when attach a switch", phy_bus_name ptr needs to be checked before strcmp is called. Signed-off-by: Fabrice Gasnier Signed-off-by: Giuseppe Cavallaro --- drivers/

[PATCH (net-next.git) 05/18] stmmac: add length field to dma data

2016-01-04 Thread Giuseppe Cavallaro
Currently, the code pulls out the length field when unmapping a buffer directly from the descriptor. This will result in an uncached read to a dma_alloc_coherent() region. There is no need to do this, so this patch simply puts the value directly into a data structure which will hit the cache. Sign

[PATCH (net-next.git) 10/18] stmmac: optimize tx clean function

2016-01-04 Thread Giuseppe Cavallaro
From: Fabrice Gasnier This patch "inline" get_tx_owner and get_ls routines. It Results in a unique read to tdes0, instead of three, to check TX_OWN and LS bits, and other status bits. It helps improve driver TX path by removing two uncached read/writes inside TX clean loop for enhanced descripto

Re: [Linux-v4.4-LTS] ppp: Backport of rtnetlink device handling

2016-01-04 Thread Guillaume Nault
On Mon, Jan 04, 2016 at 08:47:30AM +0100, Sedat Dilek wrote: > Hi Guillaume, > > which patches do I need to backport "ppp: rtnetlink device handling" > to Linux v4.4 which will be a LongTerm-Supported (LTS) Linux-kernel > [0]? > Quite frankly, backporting this series doesn't look like a good idea

[PATCH (net-next.git) 07/18] stmmac: add is_jumbo field to dma data

2016-01-04 Thread Giuseppe Cavallaro
Optimize tx_clean by avoiding a des3 read in stmmac_clean_desc3(). In ring mode, TX, des3 seems only used when xmit a jumbo frame. In case of normal descriptors, it may also be used for time stamping. Clean it in the above two case, without reading it. Signed-off-by: Fabrice Gasnier Signed-off-b

[PATCH (net-next.git) 12/18] stmmac: first frame prep at the end of xmit routine

2016-01-04 Thread Giuseppe Cavallaro
This patch is to fill the first descriptor just before granting the DMA engine so at the end of the xmit. The patch takes care about the algorithm adopted to mitigate the interrupts, then it fixes the last segment in case of no fragments. Moreover, this new implementation does not pass any "ter" fi

[PATCH (net-next.git) 09/18] stmmac: optimize tx desc management

2016-01-04 Thread Giuseppe Cavallaro
This patch is to optimize the way to manage the TDES inside the xmit function. When prepare the frame, some settings (e.g. OWN bit) can be merged. This has been reworked to improve the tx performances. Signed-off-by: Fabrice Gasnier Signed-off-by: Giuseppe Cavallaro --- drivers/net/ethernet/stm

[PATCHv2 (net-next.git) 16/18] stmmac: do not perform zero-copy for rx frames

2016-01-04 Thread Giuseppe Cavallaro
This patch is to allow this driver to copy tiny frames during the reception process. This is giving more stability while stressing the driver on STi embedded systems. Signed-off-by: Giuseppe Cavallaro --- V2: rx_copybreak tunable by using ethtool drivers/net/ethernet/stmicro/stmmac/stmmac.h

[PATCH (net-next.git) 14/18] stmmac: do not poll phy handler when attach a switch

2016-01-04 Thread Giuseppe Cavallaro
This patch avoids to call the stmmac_adjust_link when the driver is connected to a switch by using the FIXED_PHY support. Prior this patch the phydev->irq was set as PHY_POLL so periodically the phy handler was invoked spending useless time because the link cannot actually change. Note that the stm

[PATCH (net-next.git) 11/18] stmmac: set dirty index out of the loop

2016-01-04 Thread Giuseppe Cavallaro
The dirty index can be updated out of the loop where all the tx resources are claimed. This will help on performances too. Also a useless debug printk has been removed from the main loop. Signed-off-by: Giuseppe Cavallaro --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c |5 + 1 file

[PATCH (net-next.git) 03/18] stmmac: change descriptor layout

2016-01-04 Thread Giuseppe Cavallaro
This patch completely changes the descriptor layout to improve the whole performances due to the single read usage of the descriptors in critical paths. Signed-off-by: Giuseppe Cavallaro --- drivers/net/ethernet/stmicro/stmmac/descs.h | 330 ++- drivers/net/ethernet/stmi

[PATCH (net-next.git) 13/18] stmmac: perf, remove modulo in stmmac_rx()

2016-01-04 Thread Giuseppe Cavallaro
The indexes into the ring buffer are always incremented, and the entry is accessed via doing a modulo to find the "real" index. Modulo is an expensive operation. This patch replaces the modulo with a simple if clamp. It helps improve stmmac RX path as it's being called inside RX loop. Signed-off-

[PATCH (net-next.git) 04/18] stmmac: remove modulo in stmmac_xmit()

2016-01-04 Thread Giuseppe Cavallaro
The indexes into the ring buffer are always incremented, and the entry is accessed via doing a modulo to find the "real" index. I have changed this for 3 reasons: * It is inefficient, modulo is an expensive operation. * It is also broken when the counter wraps. * It makes my head hurt trying to c

[PATCH (net-next.git) 06/18] stmmac: add last_segment field to dma data

2016-01-04 Thread Giuseppe Cavallaro
last_segment field is read twice from dma descriptors in stmmac_clean(). Add last_segment to dma data so that this flag is from priv structure in cache instead of memory. It avoids reading twice from memory for each loop in stmmac_clean(). Signed-off-by: Fabrice Gasnier Signed-off-by: Giuseppe Ca

Re: [PATCH 1/3] rsi: Delete unnecessary variable initialisations in rsi_send_mgmt_pkt()

2016-01-04 Thread Bjørn Mork
Dan Carpenter writes: > Please stop sending cleanup patches, Markus. Just send fixes. Thanks for your continued but unwarranted belief in AI. Do you mind if I remind you of https://lkml.org/lkml/2014/11/3/162 ? I am sure there are lots and lots of other examples. There is no reason to believe

Re: [patch v2] qlcnic: fix a timeout loop

2016-01-04 Thread Yann Dupont - Veille Techno
Le 15/12/2015 14:56, Dan Carpenter a écrit : The problem here is that at the end of the loop we test for if idc->vnic_wait_limit is zero, but since idc->vnic_wait_limit-- is a post-op, it actually ends up set to (u8)-1. I have fixed this by moving the decrement inside the loop. Fixes: 486a5bc77

Re: [PATCH 1/3] rsi: Delete unnecessary variable initialisations in rsi_send_mgmt_pkt()

2016-01-04 Thread Dan Carpenter
On Mon, Jan 04, 2016 at 02:17:40PM +0100, Bjørn Mork wrote: > Dan Carpenter writes: > > > Please stop sending cleanup patches, Markus. Just send fixes. > > Thanks for your continued but unwarranted belief in AI. > I always tell people that I am very mechanical and you can rely on me to send p

Re: [PATCH] mac802154: constify ieee802154_llsec_ops structure

2016-01-04 Thread Alexander Aring
Hi, On Wed, Dec 23, 2015 at 10:36:32PM +0100, Julia Lawall wrote: > The ieee802154_llsec_ops structure is never modified, so declare it as > const. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall > Acked-by: Alexander Aring Marcel, can you please apply this on bluetoot

Re: [PATCH] net: Fix potential NULL pointer dereference in __skb_try_recv_datagram

2016-01-04 Thread Eric Dumazet
On Mon, 2016-01-04 at 10:10 +0100, Jacob Siverskog wrote: > On Wed, Dec 30, 2015 at 11:30 PM, Cong Wang wrote: > > On Wed, Dec 30, 2015 at 6:30 AM, Jacob Siverskog > > wrote: > >> On Wed, Dec 30, 2015 at 2:26 PM, Eric Dumazet wrote: > >>> How often can you trigger this bug ? > >> > >> Ok. I don'

Re: [RFC PATCH 02/12] net: sched: free per cpu bstats

2016-01-04 Thread Daniel Borkmann
On 12/30/2015 06:51 PM, John Fastabend wrote: When a qdisc is using per cpu stats only the bstats are being freed. This also free's the qstats. Signed-off-by: John Fastabend Seems like a bug fix, current code seems to free this only in error path in qdisc_create(). Should this go to -net as a

Re: commit e34d65696d2e broke stmmac ethernet on socfpga

2016-01-04 Thread Dinh Nguyen
On 01/01/2016 02:49 AM, Romain Perier wrote: > Hi all, > > Same here on rockchip. > See "[PATCH] stmmac: Don't exit mdio registration when mdio subnode is > not found in the DTS" > > Regards, > Romain > > 2015-12-18 18:45 GMT+01:00 Dinh Nguyen : >> Hi, >> >> It appears that commit e34d65696d2e '

[PATCH net-next 1/3] nfp: free buffers before changing MTU

2016-01-04 Thread Jakub Kicinski
For freeing DMA buffers we depend on nfp_net.fl_bufsz having the same value as during allocation therefore in .ndo_change_mtu we must first free the buffers and then change the setting. Signed-off-by: Jakub Kicinski Reviewed-by: Rolf Neugebauer --- drivers/net/ethernet/netronome/nfp/nfp_net_com

[PATCH net-next 0/3] nfp: MTU changes and other fixes

2016-01-04 Thread Jakub Kicinski
Hi! Three small fixes around RX buffer sizing. First one corrects the length used for unmapping DMA buffers when MTU is changed, second makes sure buffers are big enough to meet FW's expectations. Third change corrects packet length validation on RX. Jakub Kicinski (3): nfp: free buffers befo

[PATCH net-next 3/3] nfp: fix RX buffer length validation

2016-01-04 Thread Jakub Kicinski
Meaning of data_len and meta_len RX WB descriptor fields depend slightly on whether rx_offset is dynamic or not. For dynamic offsets data_len includes mata_len. This makes the code harder to follow, in fact our RX buffer length check is incorrect - we are comparing allocation length to data_len w

[PATCH net-next 2/3] nfp: correct RX buffer length calculation

2016-01-04 Thread Jakub Kicinski
When calculating the RX buffer length we need to account for up to 2 VLAN tags and up to 8 MPLS labels. Rounding up to 1k is an relic of a distant past and can be removed. While at it also remove trivial print statement. Signed-off-by: Jakub Kicinski Reviewed-by: Rolf Neugebauer --- drivers/n

Re: [PATCH] net: Fix potential NULL pointer dereference in __skb_try_recv_datagram

2016-01-04 Thread Rainer Weikusat
Eric Dumazet writes: > On Mon, 2016-01-04 at 10:10 +0100, Jacob Siverskog wrote: [...] >> I believe the crash occurred between these two actions. I just saw >> that there are some interesting events in the log prior to the crash: >> kernel: Bluetooth: Unable to push skb to HCI core(-6) >> kernel

Re: [PATCH v2 net-next 3/4] soreuseport: setsockopt SO_ATTACH_REUSEPORT_[CE]BPF

2016-01-04 Thread Craig Gallek
On Tue, Dec 29, 2015 at 6:50 PM, Alexei Starovoitov wrote: > On Tue, Dec 29, 2015 at 12:29:09PM -0500, Craig Gallek wrote: >> From: Craig Gallek >> +static struct sock *run_bpf(struct sock_reuseport *reuse, u16 socks, >> + struct bpf_prog *prog, struct sk_buff *skb, >> +

Re: [PATCH v2 net-next 3/4] soreuseport: setsockopt SO_ATTACH_REUSEPORT_[CE]BPF

2016-01-04 Thread Craig Gallek
On Sat, Jan 2, 2016 at 4:28 PM, Daniel Borkmann wrote: > On 12/29/2015 06:29 PM, Craig Gallek wrote: >> >> From: Craig Gallek >> >> Expose socket options for setting a classic or extended BPF program >> for use when selecting sockets in an SO_REUSEPORT group. These options >> can be used on the

[PATCH v3 net-next 0/4] Faster SO_REUSEPORT

2016-01-04 Thread Craig Gallek
From: Craig Gallek This series contains two optimizations for the SO_REUSEPORT feature: Faster lookup when selecting a socket for an incoming packet and the ability to select the socket from the group using a BPF program. This series only includes the UDP path. I plan to submit a follow-up incl

[PATCH v3 net-next 1/4] soreuseport: define reuseport groups

2016-01-04 Thread Craig Gallek
From: Craig Gallek struct sock_reuseport is an optional shared structure referenced by each socket belonging to a reuseport group. When a socket is bound to an address/port not yet in use and the reuseport flag has been set, the structure will be allocated and attached to the newly bound socket.

[PATCH v3 net-next 3/4] soreuseport: setsockopt SO_ATTACH_REUSEPORT_[CE]BPF

2016-01-04 Thread Craig Gallek
From: Craig Gallek Expose socket options for setting a classic or extended BPF program for use when selecting sockets in an SO_REUSEPORT group. These options can be used on the first socket to belong to a group before bind or on any socket in the group after bind. This change includes refactori

[PATCH v3 net-next 4/4] soreuseport: BPF selection functional test

2016-01-04 Thread Craig Gallek
From: Craig Gallek This program will build classic and extended BPF programs and validate the socket selection logic when used with SO_ATTACH_REUSEPORT_CBPF and SO_ATTACH_REUSEPORT_EBPF. It also validates the re-programing flow and several edge cases. Signed-off-by: Craig Gallek --- tools/tes

[PATCH v3 net-next 2/4] soreuseport: fast reuseport UDP socket selection

2016-01-04 Thread Craig Gallek
From: Craig Gallek Include a struct sock_reuseport instance when a UDP socket binds to a specific address for the first time with the reuseport flag set. When selecting a socket for an incoming UDP packet, use the information available in sock_reuseport if present. This required adding an additi

[RFC PATCH net-next] net: Add l3mdev cgroup

2016-01-04 Thread David Ahern
Add cgroup to assoicate tasks with L3 networking domains. AF_INET{6} sockets opened by tasks associated with an l3mdev cgroup are bound to the associated master device when the socket is created. This allows a user to run a command (and its children) within an L3 networking context. The master-dev

Re: [PATCH] net: Fix potential NULL pointer dereference in __skb_try_recv_datagram

2016-01-04 Thread Eric Dumazet
On Mon, 2016-01-04 at 16:14 +, Rainer Weikusat wrote: > Eric Dumazet writes: > > On Mon, 2016-01-04 at 10:10 +0100, Jacob Siverskog wrote: > > [...] > > >> I believe the crash occurred between these two actions. I just saw > >> that there are some interesting events in the log prior to the c

Re: [PATCH] rt2x00pci: Disable memory-write-invalidate when the driver exits

2016-01-04 Thread Helmut Schaa
On Mon, Jan 4, 2016 at 8:55 AM, Jia-Ju Bai wrote: > The driver calls pci_set_mwi to enable memory-write-invalidate when it > is initialized, but does not call pci_clear_mwi when it is removed. Many > other drivers calls pci_clear_mwi when pci_set_mwi is called, such as > r8169, 8139cp and e1000. >

Re: next-20160104 build: 3 failures 15 warnings (next-20160104)

2016-01-04 Thread Mark Brown
On Mon, Jan 04, 2016 at 12:12:20PM +, Build bot for Mark Brown wrote: Today's linux-next fails to build an arm allmodconfig (and probably also at least arm64 though other errors prevent that getting to linking currently) due to: | drivers/built-in.o: In function `dtsec_restart_autoneg': | :(.

[PATCH net] net: Propagate lookup failure in l3mdev_get_saddr to caller

2016-01-04 Thread David Ahern
Commands run in a vrf context are not failing as expected on a route lookup: root@kenny:~# ip ro ls table vrf-red unreachable default root@kenny:~# ping -I vrf-red -c1 -w1 10.100.1.254 ping: Warning: source address might be selected on device other than vrf-red. PING 10.100.1.

Re: [PATCH 1/3] rsi: Delete unnecessary variable initialisations in rsi_send_mgmt_pkt()

2016-01-04 Thread David Miller
From: Dan Carpenter Date: Mon, 4 Jan 2016 12:28:57 +0300 > Please stop sending cleanup patches, Markus. Just send fixes. +1 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/m

Re: Q: bad routing table cache entries

2016-01-04 Thread Stas Sergeev
04.01.2016 04:05, Sowmini Varadhan пишет: On (12/30/15 15:42), Stas Sergeev wrote: 29.12.2015 18:22, Sowmini Varadhan пишет: Do you have admin control over the ubuntu router? If yes, you might want to check the shared_media [#] setting on that router for the interfaces with overlapping subnets.

[ANNOUNCE] NetDev 1.1 is approaching...

2016-01-04 Thread Pablo Neira Ayuso
Hi! For those that still didn't hear about us, Netdev 1.1 is the community-driven Linux networking conference. This event will be again held back-to-back with NetConf in Sevilla, Spain, February 10-12, 2016. After the holidays break (happy new year everyone!), we would like to make a quick summar

Re: [RFC PATCH 02/12] net: sched: free per cpu bstats

2016-01-04 Thread Eric Dumazet
On Mon, 2016-01-04 at 16:21 +0100, Daniel Borkmann wrote: > On 12/30/2015 06:51 PM, John Fastabend wrote: > > When a qdisc is using per cpu stats only the bstats are being > > freed. This also free's the qstats. > > > > Signed-off-by: John Fastabend > > Seems like a bug fix, current code seems to

[RFC PATCH net-next 06/24] net: dnet: Use phy_find_first() helper

2016-01-04 Thread Andrew Lunn
Replace the open coded search for the first phy with a call to the existing helper function. Signed-off-by: Andrew Lunn --- drivers/net/ethernet/dnet.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/net/ethernet/dnet.c b/drivers/net/ethernet/dnet.c index 136b6

[RFC PATCH net-next 10/24] mdio: Move allocation of interrupts into core

2016-01-04 Thread Andrew Lunn
Have mdio_alloc() create the array of interrupt numbers, and initialize it to POLLING. This is what most MDIO drivers want, so allowing code to be removed from the drivers. Signed-off-by: Andrew Lunn --- arch/powerpc/platforms/82xx/ep8248e.c| 10 +- arch/powerpc/platforms

[RFC PATCH net-next 01/24] phy: Consistently use addr for address on an MII bus

2016-01-04 Thread Andrew Lunn
Within phy.h, an address on an MII bus has been called both addr and phy_id. phy_id is particularly confusion, since it also means the ID found in register 3, if the device on the bus is a phy. Consistently use addr. Signed-off-by: Andrew Lunn --- include/linux/phy.h | 4 ++-- 1 file changed, 2

[RFC PATCH net-next 24/24] Add linux,mdio-nop support for testing

2016-01-04 Thread Andrew Lunn
--- arch/arm/boot/dts/vf610-zii-dev-rev-b.dts | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm/boot/dts/vf610-zii-dev-rev-b.dts b/arch/arm/boot/dts/vf610-zii-dev-rev-b.dts index 6e657a9312ce..044e213f5809 100644 --- a/arch/arm/boot/dts/vf610-zii-dev-rev-b.dts +++ b/arch/arm/boot/

[RFC PATCH net-next 12/24] of: phy: Only register a phy device for phys

2016-01-04 Thread Andrew Lunn
We will soon support devices other than phys on the mdio bus. Look at a child's compatibility string to determine if it is a phy, before registering a phy device. Signed-off-by: Andrew Lunn --- drivers/of/of_mdio.c | 37 ++--- 1 file changed, 30 insertions(+), 7 d

[RFC PATCH net-next 09/24] phy: mdio-octeon: Use devm_mdiobus_alloc_size()

2016-01-04 Thread Andrew Lunn
Rather than use devm_kzalloc(), use the mdio helper function. Signed-off-by: Andrew Lunn --- drivers/net/phy/mdio-octeon.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/net/phy/mdio-octeon.c b/drivers/net/phy/mdio-octeon.c index fcf4e4df7cc8..0d5da1312d

[RFC PATCH net-next 02/24] mdio: Move mdiobus_read/write operatings into mdio.h

2016-01-04 Thread Andrew Lunn
These are logically MDIO operations, not phy operations, so move them into the mdio header. Signed-off-by: Andrew Lunn --- include/linux/mdio.h | 6 ++ include/linux/phy.h | 6 +- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/include/linux/mdio.h b/include/linux/mdio.h

[RFC PATCH net-next 11/24] phy: Add an mdio_device structure

2016-01-04 Thread Andrew Lunn
Not all devices attached to an MDIO bus are phys. So add an mdio_device structure to represent the generic parts of an mdio device, and place this structure into the phy_device. Signed-off-by: Andrew Lunn --- drivers/net/ethernet/agere/et131x.c | 30 ++-- drivers/net/etherne

[RFC PATCH net-next 08/24] phy: Centralise print about attached phy

2016-01-04 Thread Andrew Lunn
Many Ethernet drivers contain the same netdev_info() print statement about the attached phy. Move it into the phy device code. Signed-off-by: Andrew Lunn --- drivers/net/ethernet/adi/bfin_mac.c | 5 - drivers/net/ethernet/agere/et131x.c | 4 drivers/net/ethernet/amd/

[RFC PATCH net-next 05/24] phy: add phydev_name() macro

2016-01-04 Thread Andrew Lunn
Add a phydev_name() macro, to help with moving some structure members from phy_device. Signed-off-by: Andrew Lunn --- drivers/net/ethernet/8390/ax88796.c | 2 +- drivers/net/ethernet/adi/bfin_mac.c | 4 ++-- drivers/net/ethernet/agere/et131x.c | 4 ++--

[RFC PATCH net-next 07/24] phy: phy_{read|write}_mmd_indirect: get addr from phydev

2016-01-04 Thread Andrew Lunn
The address of the device can be determined from the phydev structure, rather than passing it as a parameter. Signed-off-by: Andrew Lunn --- drivers/net/phy/bcm-phy-lib.c | 8 drivers/net/phy/dp83867.c | 6 +++--- drivers/net/phy/microchip.c | 5 ++--- drivers/net/phy/phy.c

[RFC PATCH net-next 20/24] mdio_bus: Add comment to mdiobus_scan() and __mdiobus_register()

2016-01-04 Thread Andrew Lunn
Make it clear that mdiobus_scan () will only find devices which have a vendor/product ID in registers 2 and 3. These are typically PHY devices. Other sort of MDIO devices, such as switches, are not expected to be found during the scan. Similarly, __mdiobus_register(), which calls mdiobus_scan() wi

[RFC PATCH net-next 04/24] phy: Add phydev_err() and phydev_dbg() macros

2016-01-04 Thread Andrew Lunn
In preparation for moving some of the phy_device structure members, add macros for printing errors and debug information. Signed-off-by: Andrew Lunn --- drivers/net/phy/at803x.c | 4 ++-- drivers/net/phy/bcm87xx.c | 5 +++-- drivers/net/phy/micrel.c | 16 +--- drivers/net/phy/phy

[RFC PATCH net-next 00/24] Support MDIO devices

2016-01-04 Thread Andrew Lunn
The discussions about changing the way DSA probes switches resulted in the wish to have switches attached to an MDIO bus to be represented as an MDIO device. However the current code only supports PHYs on MDIO busses. This patchset remedies this problem. It consists of a number of cleanups, abstrac

[RFC PATCH net-next 03/24] phy: Use phy_read() instead of mdiobus_read()

2016-01-04 Thread Andrew Lunn
Since we have a phydev, make use of it and the phy_read() function. This will help with later refactoring. Signed-off-by: Andrew Lunn --- drivers/net/ethernet/hisilicon/hns/hns_ethtool.c | 104 --- drivers/net/phy/phy.c| 6 +- 2 files changed, 38

[RFC PATCH net-next 13/24] phy: Add API for {un{registering an mdio device to a bus.

2016-01-04 Thread Andrew Lunn
Rather than have drivers directly manipulate the mii_bus structure, provide and API for registering and unregistering devices on an MDIO bus, and performing lookups. Signed-off-by: Andrew Lunn --- drivers/net/ethernet/broadcom/b44.c | 2 +- drivers/net/ethernet/broadcom/genet/bcmm

[RFC PATCH net-next 14/24] phy_device: Move phy attributes into phy_device

2016-01-04 Thread Andrew Lunn
The mdio_bus exports three attributes. However these are all phy attributes, not generic mdio attributes. So move the attributes into the phy device code. Signed-off-by: Andrew Lunn --- drivers/net/phy/mdio_bus.c | 42 -- drivers/net/phy/phy_device.c | 4

[RFC PATCH net-next 15/24] dsa: Register netdev before phy

2016-01-04 Thread Andrew Lunn
When the phy is connected, an info message is printed. If the netdev it is attached to has not been registered yet, the name 'uninitialised' in the output. By registering the netdev first, then connecting they phy, we can avoid this. Signed-off-by: Andrew Lunn --- net/dsa/slave.c | 14 +++---

[RFC PATCH net-next 18/24] phy: Move phy specific bus match into phy_device

2016-01-04 Thread Andrew Lunn
Matching a driver to a device has both generic parts, and parts which are specific to PHY devices. Move the PHY specific parts into phy_device. Signed-off-by: Andrew Lunn --- drivers/net/phy/mdio_bus.c | 38 -- drivers/net/phy/phy_device.c | 28 +

[RFC PATCH net-next 19/24] mdio_bus: Generalise of_mdiobus_link_phydev()

2016-01-04 Thread Andrew Lunn
This function should work with any sort of MDIO device which can be probed on the bus, not just PHY devices. So generalise it. Signed-off-by: Andrew Lunn --- drivers/net/phy/mdio_bus.c | 29 +++-- 1 file changed, 15 insertions(+), 14 deletions(-) diff --git a/drivers/net

[RFC PATCH net-next 23/24] mdio: mdio-nop: Dummy driver to testing

2016-01-04 Thread Andrew Lunn
Add a dummy driver which does nothing, but is useful for testing the mdio device framework. --- drivers/net/phy/Kconfig| 8 drivers/net/phy/Makefile | 1 + drivers/net/phy/mdio-nop.c | 37 + 3 files changed, 46 insertions(+) create mode 100644

  1   2   3   >