[PATCH net-next 1/2] Support outside netns for tunnels.

2016-01-04 Thread Saurabh Mohan
This patch enchances a tunnel interface, like gre, to have the tunnel encap/decap be in the context of a network namespace that is different from the namespace of the tunnel interface. >From userspace this feature may be configured using the new 'onetns' keyword: ip netns exec custa ip link add

[RFC v5 1/6] Timekeeping cross timestamp interface for device drivers

2016-01-04 Thread Christopher S. Hall
ACKNOWLEDGMENT: The original correlated clock source and cross timestamp code was developed by Thomas Gleixner . It has changed considerably and any mistakes are mine. The precision with which events on multiple networked systems can be synchronized using, as an example, PTP

[RFC v5 6/6] Adds hardware supported cross timestamp

2016-01-04 Thread Christopher S. Hall
Modern Intel systems supports cross timestamping of the network device clock and Always Running Timer (ART) in hardware. This allows the device time and system time to be precisely correlated. The timestamp pair is returned through e1000e_phc_get_sync_devicetime() used by

[RFC v5 2/6] Always Running Timer (ART) correlated clocksource

2016-01-04 Thread Christopher S. Hall
On modern Intel systems TSC is derived from the new Always Running Timer (ART). ART can be captured simultaneous to the capture of audio and network device clocks, allowing a correlation between timebases to be constructed. Upon capture, the driver converts the captured ART value to the

Re: [PATCH] mac802154: constify ieee802154_llsec_ops structure

2016-01-04 Thread Marcel Holtmann
Hi Julia, > The ieee802154_llsec_ops structure is never modified, so declare it as > const. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall > > --- > include/net/ieee802154_netdev.h |2 +- > net/mac802154/mac_cmd.c |2 +- > 2 files

Re: [RFC PATCH net-next] net: Add l3mdev cgroup

2016-01-04 Thread David Ahern
On 1/4/16 12:23 PM, Tejun Heo wrote: I don't have an answer for that but cgroup isn't a place to put such stray configurations either. Please figure out where the configuration belongs first. What you're proposing really isn't a resource controller. There's no resource being distributed

Re: [RFC PATCH net-next 08/24] phy: Centralise print about attached phy

2016-01-04 Thread Florian Fainelli
On 04/01/16 09:36, Andrew Lunn wrote: > Many Ethernet drivers contain the same netdev_info() print statement > about the attached phy. Move it into the phy device code. > > Signed-off-by: Andrew Lunn > --- [snip] > diff --git a/drivers/net/ethernet/adi/bfin_mac.c >

Re: [PATCH v3 net-next 3/4] soreuseport: setsockopt SO_ATTACH_REUSEPORT_[CE]BPF

2016-01-04 Thread Alexei Starovoitov
On Mon, Jan 04, 2016 at 11:26:37AM -0500, Craig Gallek wrote: > From: Craig Gallek > > Expose socket options for setting a classic or extended BPF program > for use when selecting sockets in an SO_REUSEPORT group. These options > can be used on the first socket to belong to a

Re: [PATCH 6/6] tilepro: use to_delayed_work

2016-01-04 Thread David Miller
From: Geliang Tang Date: Fri, 1 Jan 2016 23:48:57 +0800 > Use to_delayed_work() instead of open-coding it. > > Signed-off-by: Geliang Tang Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message

Re: [RFC PATCH net-next 08/24] phy: Centralise print about attached phy

2016-01-04 Thread Andrew Lunn
On Mon, Jan 04, 2016 at 12:15:50PM -0800, Florian Fainelli wrote: > On 04/01/16 09:36, Andrew Lunn wrote: > > Many Ethernet drivers contain the same netdev_info() print statement > > about the attached phy. Move it into the phy device code. > > > > Signed-off-by: Andrew Lunn > >

Re: [RFC PATCH net-next] net: Add l3mdev cgroup

2016-01-04 Thread Tejun Heo
Hello, David. On Mon, Jan 04, 2016 at 11:53:55AM -0700, David Ahern wrote: > On 1/4/16 10:58 AM, Tejun Heo wrote: > >Please don't create any new controller whose sole purpose is > >identifying group membership. Please take a look at how libxt_cgroup > >handles identification w/o creating a new

Re: [PATCH 2/4] net: phy: at803x: Allow specifying the RGMII RX clock delay via phy mode

2016-01-04 Thread Martin Blumenstingl
On Sun, Dec 27, 2015 at 9:22 PM, Mason wrote: > On 27/12/2015 04:28, Florian Fainelli wrote: > >> Le 25/12/2015 16:27, Martin Blumenstingl wrote: >> >>> diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c >>> index f566b6e..0b262a2 100644 >>> ---

[PATCH iproute2] Support outside netns for tunnels.

2016-01-04 Thread Saurabh Mohan
This patch enchances a tunnel interface, like gre, to have the tunnel encap/decap be in the context of a network namespace that is different from the namespace of the tunnel interface. >From userspace this feature may be configured using the new 'onetns' keyword: ip netns exec custa ip link add

Re: [PATCH 0/2] sh_eth: remove unused BE descriptor support

2016-01-04 Thread David Miller
From: Sergei Shtylyov Date: Mon, 28 Dec 2015 02:05:24 +0300 >Here's a set of 2 patches against DaveM's 'net-next.git' repo plus the > recently merged to 'net.git' repo fix for the 16-bit descriptor endianness. > We get rid of ~30 LoCs and ~300 bytes of

Re: [RFC PATCH net-next 12/24] of: phy: Only register a phy device for phys

2016-01-04 Thread Florian Fainelli
On 04/01/16 09:36, Andrew Lunn wrote: > We will soon support devices other than phys on the mdio bus. Look at > a child's compatibility string to determine if it is a phy, before > registering a phy device. > > Signed-off-by: Andrew Lunn > --- [snip] > + if

Re: [RFC PATCH net-next 09/24] phy: mdio-octeon: Use devm_mdiobus_alloc_size()

2016-01-04 Thread Florian Fainelli
On 04/01/16 09:36, Andrew Lunn wrote: > Rather than use devm_kzalloc(), use the mdio helper function. > > Signed-off-by: Andrew Lunn Reviewed-by: Florian Fainelli -- Florian -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body

Re: [RFC PATCH net-next 10/24] mdio: Move allocation of interrupts into core

2016-01-04 Thread Florian Fainelli
On 04/01/16 09:36, Andrew Lunn wrote: > Have mdio_alloc() create the array of interrupt numbers, and > initialize it to POLLING. This is what most MDIO drivers want, so > allowing code to be removed from the drivers. Yeah, this should have been done a long time ago, thanks! Reviewed-by: Florian

Re: [RFC PATCH net-next] net: Add l3mdev cgroup

2016-01-04 Thread David Ahern
On 1/4/16 11:59 AM, Tejun Heo wrote: Hello, David. On Mon, Jan 04, 2016 at 11:53:55AM -0700, David Ahern wrote: On 1/4/16 10:58 AM, Tejun Heo wrote: Please don't create any new controller whose sole purpose is identifying group membership. Please take a look at how libxt_cgroup handles

Re: [PATCH net-next 1/2] Support outside netns for tunnels.

2016-01-04 Thread Joe Perches
On Mon, 2016-01-04 at 11:47 -0800, Tom Herbert wrote: > On Mon, Jan 4, 2016 at 10:45 AM, Saurabh Mohan > wrote: > > > > This patch enchances a tunnel interface, like gre, to have the tunnel > > encap/decap be in the context of a network namespace that is different

[RFC v5 4/6] Remove duplicate code from ktime_get_raw_and_real code

2016-01-04 Thread Christopher S. Hall
The code in ktime_get_snapshot() is a superset of the code in ktime_get_raw_and_real() code. Changes the latter to call the former. A side effect of this is that ktime_get_raw_and_real() returns two clock times corresponding to the *exact* same clock tick. Previously, this code read the underlying

Re: [RFC PATCH net-next 02/24] mdio: Move mdiobus_read/write operatings into mdio.h

2016-01-04 Thread Florian Fainelli
On 04/01/16 09:36, Andrew Lunn wrote: > These are logically MDIO operations, not phy operations, so move them > into the mdio header. > > Signed-off-by: Andrew Lunn Reviewed-by: Florian Fainelli -- Florian -- To unsubscribe from this list: send the line

Re: [RFC PATCH net-next 01/24] phy: Consistently use addr for address on an MII bus

2016-01-04 Thread Florian Fainelli
On 04/01/16 09:36, Andrew Lunn wrote: > Within phy.h, an address on an MII bus has been called both addr and > phy_id. phy_id is particularly confusion, since it also means the ID > found in register 3, if the device on the bus is a phy. Consistently > use addr. > > Signed-off-by: Andrew Lunn

Re: [RFC PATCH net-next] net: Add l3mdev cgroup

2016-01-04 Thread Tejun Heo
Hello, On Mon, Jan 04, 2016 at 12:59:15PM -0700, David Ahern wrote: > cgroups have very nice properties that I want to leverage such as > parent-child inheritance and easy tracking which subsystem instance a task > belongs. This provides a great kernel foundation for building easy to use >

Re: [PATCH net-next 0/7] bnxt_en: Support combined and rx/tx channels.

2016-01-04 Thread David Miller
From: Michael Chan Date: Sat, 2 Jan 2016 23:44:57 -0500 > The bnxt hardware uses a completion ring for rx and tx events. The driver > has to process the completion ring entries sequentially for the events. > The current code only supports an rx/tx ring pair for each

Re: [RFC PATCH net-next] net: Add l3mdev cgroup

2016-01-04 Thread Tejun Heo
Hello, David. On Mon, Jan 04, 2016 at 12:17:08PM -0700, David Ahern wrote: > None of the existing subsystems are relevant for configuring an L3 > networking domain, and it does not make sense to tie net_cls and net_prio to > an L3 domain. I don't have an answer for that but cgroup isn't a place

[RFC v5 3/6] Add history to cross timestamp interface supporting slower devices

2016-01-04 Thread Christopher S. Hall
Another representative use case of time sync and the correlated clocksource (in addition to PTP noted above) is PTP synchronized audio. In a streaming application, as an example, samples will be sent and/or received by multiple devices with a presentation time that is in terms of the PTP master

[RFC v5 0/6] Patchset enabling hardware based cross-timestamps for next gen Intel platforms

2016-01-04 Thread Christopher S. Hall
Modern Intel hardware adds an Always Running Timer (ART) that allows the network and audio device clocks to precisely cross timestamp the device clock with the system clock. This allows a precise correlation of the device time and system time. This patchset adds interfaces to the timekeeping code

[RFC v5 5/6] Add PTP_SYS_OFFSET_PRECISE for driver crosstimestamping

2016-01-04 Thread Christopher S. Hall
Currently, network /system cross-timestamping is performed in the PTP_SYS_OFFSET ioctl. The PTP clock driver reads gettimeofday() and the gettime64() callback provided by the driver. The cross-timestamp is best effort where the latency between the capture of system time (getnstimeofday()) and the

Re: [RFC PATCH net-next 03/24] phy: Use phy_read() instead of mdiobus_read()

2016-01-04 Thread Florian Fainelli
On 04/01/16 09:36, Andrew Lunn wrote: > Since we have a phydev, make use of it and the phy_read() function. > This will help with later refactoring. > > Signed-off-by: Andrew Lunn > --- [snip] > diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c > index

Re: [RFC PATCH net-next 06/24] net: dnet: Use phy_find_first() helper

2016-01-04 Thread Florian Fainelli
On 04/01/16 09:36, Andrew Lunn wrote: > Replace the open coded search for the first phy with a call to the > existing helper function. > > Signed-off-by: Andrew Lunn Reviewed-by: Florian Fainelli -- Florian -- To unsubscribe from this list: send the line

Re: [RFC PATCH net-next 04/24] phy: Add phydev_err() and phydev_dbg() macros

2016-01-04 Thread Florian Fainelli
On 04/01/16 09:36, Andrew Lunn wrote: > In preparation for moving some of the phy_device structure members, > add macros for printing errors and debug information. > > Signed-off-by: Andrew Lunn Reviewed-by: Florian Fainelli -- Florian -- To unsubscribe

[PATCH V2 3/5] net/ethtool: support set coalesce per queue

2016-01-04 Thread kan . liang
From: Kan Liang This patch implements sub command ETHTOOL_SCOALESCE for ioctl ETHTOOL_PERQUEUE. It introduces an interface set_per_queue_coalesce to set coalesce of each masked queue to device driver. The wanted coalesce information are stored in "data" for each masked

[PATCH net-next 2/2] Support outside netns for gre & vti tunnels

2016-01-04 Thread Saurabh Mohan
This patch enchances a tunnel interface, like gre, to have the tunnel encap/decap be in the context of a network namespace that is different from the namespace of the tunnel interface. >From userspace this feature may be configured using the new 'onetns' keyword: ip netns exec custa ip link add

Re: [RFC PATCH net-next 07/24] phy: phy_{read|write}_mmd_indirect: get addr from phydev

2016-01-04 Thread Florian Fainelli
On 04/01/16 09:36, Andrew Lunn wrote: > The address of the device can be determined from the phydev structure, > rather than passing it as a parameter. > > Signed-off-by: Andrew Lunn Reviewed-by: Florian Fainelli -- Florian -- To unsubscribe from this

[PATCH V2 5/5] i40e/ethtool: support coalesce setting by queue

2016-01-04 Thread kan . liang
From: Kan Liang This patch implements set_per_queue_coalesce for i40e driver. For i40e driver, only rx and tx usecs have per queue value. Usually, the queues number is the same as vectors number. Queue has its own vector. Changing these two parameters by setting specific

Re: [RFC PATCH net-next] net: Add l3mdev cgroup

2016-01-04 Thread David Ahern
Hi Tejun: On 1/4/16 10:58 AM, Tejun Heo wrote: Please don't create any new controller whose sole purpose is identifying group membership. Please take a look at how libxt_cgroup handles identification w/o creating a new controller.

Re: [PATCH net-next 1/2] Support outside netns for tunnels.

2016-01-04 Thread Tom Herbert
On Mon, Jan 4, 2016 at 10:45 AM, Saurabh Mohan wrote: > > This patch enchances a tunnel interface, like gre, to have the tunnel > encap/decap be in the context of a network namespace that is different from > the namespace of the tunnel interface. > > From userspace

[PATCH V2 2/5] net/ethtool: support get coalesce per queue

2016-01-04 Thread kan . liang
From: Kan Liang This patch implements sub command ETHTOOL_GCOALESCE for ioctl ETHTOOL_PERQUEUE. It introduces an interface get_per_queue_coalesce to get coalesce of each masked queue from device driver. Then the interrupt coalescing parameters will be copied back to user

[PATCH V2 4/5] i40e/ethtool: support coalesce getting by queue

2016-01-04 Thread kan . liang
From: Kan Liang This patch implements get_per_queue_coalesce for i40e driver. For i40e driver, only rx and tx usecs has per queue value. So only these two parameters are read from specific vectors. Usually, the queues number is the same as vectors number. Queue has its own

[PATCH V2 1/5] net/ethtool: introduce a new ioctl for per queue setting

2016-01-04 Thread kan . liang
From: Kan Liang Introduce a new ioctl ETHTOOL_PERQUEUE for per queue parameters setting. The following patches will enable some SUB_COMMANDs for per queue setting. Signed-off-by: Kan Liang --- Changes since V1: - Checking the sub-command number to

Re: [RFC PATCH net-next 12/24] of: phy: Only register a phy device for phys

2016-01-04 Thread Andrew Lunn
On Mon, Jan 04, 2016 at 12:01:04PM -0800, Florian Fainelli wrote: > On 04/01/16 09:36, Andrew Lunn wrote: > > We will soon support devices other than phys on the mdio bus. Look at > > a child's compatibility string to determine if it is a phy, before > > registering a phy device. > > > >

Re: [PATCH 1/3] rsi: Delete unnecessary variable initialisations in rsi_send_mgmt_pkt()

2016-01-04 Thread Dan Carpenter
These patches are labour intensive to review because you can't just do it in the email client. Also you were not able to review it properly yourself and introduced a bug. I am often remove initializers but it's normally because I am changing something else which makes it worthwhile. This patch

Re: [PATCH 0/5] xen-netback: Fine-tuning for three function implementations

2016-01-04 Thread Dan Carpenter
The original code is fine. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH iproute2 4/4] man: iplink: document new addrgenmodes

2016-01-04 Thread Bjørn Mork
Cc: Hannes Frederic Sowa Signed-off-by: Bjørn Mork --- man/man8/ip-link.8.in | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/man/man8/ip-link.8.in b/man/man8/ip-link.8.in index ac6f4813a329..189a8f15fa03 100644

[PATCH iproute2 2/4] iplink: support setting addrgenmode stable_secret

2016-01-04 Thread Bjørn Mork
It is possible to switch to another addrgenmode after setting a valid secret. Allow switching back without reconfiguring the secret for completeness. Cc: Hannes Frederic Sowa Signed-off-by: Bjørn Mork --- ip/iplink.c | 4 +++- 1 file changed, 3

[PATCH iproute2 0/4] addrgenmode updates for net-next

2016-01-04 Thread Bjørn Mork
This adds support for the new "random" addrgenmode in net-next and improves the support for the "stable_secret" mode. Bjørn Mork (4): include: update kernel headers iplink: support setting addrgenmode stable_secret iplink: support show and set of "addrgenmode random" man: iplink: document

[PATCH iproute2 3/4] iplink: support show and set of "addrgenmode random"

2016-01-04 Thread Bjørn Mork
"random" is a new IPv6 addrgenmode, enabling "stable_secret" type addresses with an auto-generated secret. $ ip link set eth0 addrgenmode random $ ip -d link show dev eth0 2: eth0: mtu 1500 qdisc pfifo_fast state DOWN mode DEFAULT group default qlen 1000

Re: [PATCH v4 net-next 2/3] net: macb: Add NPx macb config using USRIO_DISABLED cap

2016-01-04 Thread Nicolas Ferre
Le 04/01/2016 10:42, Neil Armstrong a écrit : > Declare a new SoC variant for NPx SoCs having USRIO_DISABLED as > capability bit. > > Signed-off-by: Neil Armstrong > --- > drivers/net/ethernet/cadence/macb.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git

Re: [PATCH 1/3] rsi: Delete unnecessary variable initialisations in rsi_send_mgmt_pkt()

2016-01-04 Thread Dan Carpenter
On Mon, Jan 04, 2016 at 11:44:15AM +0100, SF Markus Elfring wrote: > > Please stop sending cleanup patches, Markus. Just send fixes. > > How often will source code clean-up fix something? > > > May I resend a consistent patch series for the source file >

[PATCH iproute2 1/4] include: update kernel headers

2016-01-04 Thread Bjørn Mork
Import current if_link.h from net-next Signed-off-by: Bjørn Mork --- include/linux/if_link.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/if_link.h b/include/linux/if_link.h index c9ad487d04f0..d91f2c97d946 100644 --- a/include/linux/if_link.h +++

Re: [PATCH 1/3] rsi: Delete unnecessary variable initialisations in rsi_send_mgmt_pkt()

2016-01-04 Thread SF Markus Elfring
> These patches are labour intensive to review because you can't just do > it in the email client. Thanks for your general interest. > Also you were not able to review it properly yourself and introduced > a bug. I admit that it can happen during my software development that I overlook

Re: [PATCH 0/5] xen-netback: Fine-tuning for three function implementations

2016-01-04 Thread Wei Liu
I think the original code is fine. Wei. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: net-libertas: Better exception handling in if_spi_host_to_card_worker()

2016-01-04 Thread Rafał Miłecki
On 4 January 2016 at 11:05, Arend van Spriel wrote: > On 03-01-16 16:18, Rafał Miłecki wrote: >> On 3 January 2016 at 10:36, Arend van Spriel wrote: >>> On 02-01-16 12:21, SF Markus Elfring wrote: > Did you look at the resulting assembly code for

Re: net-libertas: Better exception handling in if_spi_host_to_card_worker()

2016-01-04 Thread Arend van Spriel
On 03-01-16 16:18, Rafał Miłecki wrote: > On 3 January 2016 at 10:36, Arend van Spriel wrote: >> On 02-01-16 12:21, SF Markus Elfring wrote: Did you look at the resulting assembly code for different target architectures? >>> >>> Not yet. - Which execution system

[PATCH 1/1] net/ipv6: add sysctl option accept_ra_min_hop_limit

2016-01-04 Thread Yuki Machida
Please apply the following patch to v4.1.x. By ommit 6fd99094de2b ("ipv6: Don't reduce hop limit for an interface") that have been added in the 4.0-rc7, it no longer comply with RFC4861. This problem has been fixed in the commit 8013d1d7eafb ("net/ipv6: add sysctl option

[PATCH v3 net-next] net: ethernet: cadence-macb: Add disabled usrio caps

2016-01-04 Thread Neil Armstrong
On some platforms, the macb integration does not use the USRIO register to configure the (R)MII port and clocks. When the register is not implemented and the MACB error signal is connected to the bus error, reading or writing to the USRIO register can trigger some Imprecise External Aborts on ARM

Re: [PATCH] net: Fix potential NULL pointer dereference in __skb_try_recv_datagram

2016-01-04 Thread Jacob Siverskog
On Wed, Dec 30, 2015 at 11:30 PM, Cong Wang wrote: > On Wed, Dec 30, 2015 at 6:30 AM, Jacob Siverskog > wrote: >> On Wed, Dec 30, 2015 at 2:26 PM, Eric Dumazet wrote: >>> How often can you trigger this bug ? >> >> Ok. I

[PATCH v4 net-next 0/3] Add new capability and macb DT variant

2016-01-04 Thread Neil Armstrong
The first patch introduces a new capability bit to disable usage of the USRIO register on platform not implementing it thus avoiding some external imprecise aborts on ARM based platforms. The two last patchs adds a new macb variant compatible name using the capability, the NPx name is temporary

[PATCH v4 net-next 1/3] net: ethernet: cadence-macb: Add disabled usrio caps

2016-01-04 Thread Neil Armstrong
On some platforms, the macb integration does not use the USRIO register to configure the (R)MII port and clocks. When the register is not implemented and the MACB error signal is connected to the bus error, reading or writing to the USRIO register can trigger some Imprecise External Aborts on ARM

[patch net-next 4/4] mlxsw: spectrum: Change bridge port attributes only when bridged

2016-01-04 Thread Jiri Pirko
From: Ido Schimmel Bridge port attributes are offloaded to hardware when invoked with SELF flag set, but it really makes no sense to reflect them when port is not bridged. Allow a user to change these attribute only when port is bridged and initialize them correctly when

[PATCH v4 net-next 2/3] net: macb: Add NPx macb config using USRIO_DISABLED cap

2016-01-04 Thread Neil Armstrong
Declare a new SoC variant for NPx SoCs having USRIO_DISABLED as capability bit. Signed-off-by: Neil Armstrong --- drivers/net/ethernet/cadence/macb.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/ethernet/cadence/macb.c

[patch net-next 2/4] mlxsw: spectrum: Return NOTIFY_BAD on bridge failure

2016-01-04 Thread Jiri Pirko
From: Ido Schimmel It is possible for us to fail when joining or leaving a bridge, so let the user know about that by returning NOTIFY_BAD, as already done for LAG join/leave and 802.1D bridges. Signed-off-by: Ido Schimmel Signed-off-by: Jiri Pirko

[patch net-next 3/4] mlxsw: spectrum: Set bridge status in appropriate functions

2016-01-04 Thread Jiri Pirko
From: Ido Schimmel Set the bridge status of physical ports in the appropriate functions, to be consistent with LAG join/leave and vPorts joining/leaving bridge. Also, remove the error messages in these two functions, as we already emit errors in both the single functions

[patch net-next 1/4] mlxsw: spectrum: Initialize PVID only once

2016-01-04 Thread Jiri Pirko
From: Ido Schimmel We set PVID to 1 in mlxsw_sp_port_vlan_init(), so we can remove this statement. Signed-off-by: Ido Schimmel Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 1 - 1 file changed, 1

Re: [PATCH v3 net-next] net: ethernet: cadence-macb: Add disabled usrio caps

2016-01-04 Thread Nicolas Ferre
Le 04/01/2016 10:01, Neil Armstrong a écrit : > On some platforms, the macb integration does not use the USRIO > register to configure the (R)MII port and clocks. > When the register is not implemented and the MACB error signal > is connected to the bus error, reading or writing to the USRIO >

[patch net-next 0/4] mlxsw: couple of fixes

2016-01-04 Thread Jiri Pirko
From: Jiri Pirko Couple of fixes from Ido. Ido Schimmel (4): mlxsw: spectrum: Initialize PVID only once mlxsw: spectrum: Return NOTIFY_BAD on bridge failure mlxsw: spectrum: Set bridge status in appropriate functions mlxsw: spectrum: Change bridge port attributes only

Re: [PATCH 1/3] net-iwlegacy: Refactoring for il_eeprom_init()

2016-01-04 Thread Stanislaw Gruszka
On Fri, Jan 01, 2016 at 09:30:10PM +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Fri, 1 Jan 2016 20:54:25 +0100 > > Return directly if a memory allocation failed at the beginning. > > Signed-off-by: Markus Elfring

Re: [PATCH 1/3] rsi: Delete unnecessary variable initialisations in rsi_send_mgmt_pkt()

2016-01-04 Thread Dan Carpenter
Btw, GCC misses a lot of uninitialized variable bugs. I have a Smatch check which sometimes catches the bugs that GCC misses but you should not rely on the tools here. These patches need to be reviewed manually. And the "goto err" before the initialization makes everything more complicated

Re: [PATCH] iwlegacy: 4965-mac: constify il_sensitivity_ranges structure

2016-01-04 Thread Stanislaw Gruszka
On Wed, Dec 30, 2015 at 12:20:49PM +0100, Julia Lawall wrote: > The il_sensitivity_ranges is never modified, so declare it as const. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall Acked-by: Stanislaw Gruszka -- To unsubscribe

[PATCH v4 net-next 3/3] dt-bindings: net: macb: Add NPx macb variant

2016-01-04 Thread Neil Armstrong
Add NPx macb variant for NPx SoCs. Signed-off-by: Neil Armstrong --- Documentation/devicetree/bindings/net/macb.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/net/macb.txt b/Documentation/devicetree/bindings/net/macb.txt index

Re: [PATCH v4 net-next 4/4] soreuseport: BPF selection functional test

2016-01-04 Thread Alexei Starovoitov
On Mon, Jan 04, 2016 at 05:41:48PM -0500, Craig Gallek wrote: > From: Craig Gallek > > This program will build classic and extended BPF programs and > validate the socket selection logic when used with > SO_ATTACH_REUSEPORT_CBPF and SO_ATTACH_REUSEPORT_EBPF. > > It also

Re: [PATCH net-next V3 0/4] Introduce mlx5 ethernet timestamping

2016-01-04 Thread Saeed Mahameed
Hi Dave, Any chance you are giving this a shot ? On Tue, Dec 29, 2015 at 2:58 PM, Saeed Mahameed wrote: > Hi Dave, > > This patch series introduces the support for ConnectX-4 timestamping > and the PTP kernel interface. > > Changes from V2: > net/mlx5_core: Introduce access

Re: [PATCH net-next 0/5] sctp: use transport hashtable to replace association's with rhashtable

2016-01-04 Thread David Miller
From: Xin Long Date: Wed, 30 Dec 2015 23:50:45 +0800 > for telecom center, the usual case is that a server is connected by thousands > of clients. but if the server with only one enpoint(udp style) use the same > sport and dport to communicate with every clients, and every

Re: next-20160104 build: 3 failures 15 warnings (next-20160104)

2016-01-04 Thread Mark Brown
On Mon, Jan 04, 2016 at 11:07:41PM +0100, Arnd Bergmann wrote: > On Monday 04 January 2016 16:50:25 Mark Brown wrote: > > On Mon, Jan 04, 2016 at 12:12:20PM +, Build bot for Mark Brown wrote: > > and various other linker errors caused by the fact that the new fman > > driver uses PHYLIB but

Re: rsi: Delete unnecessary variable initialisations in rsi_send_mgmt_pkt()

2016-01-04 Thread Julian Calaby
Hi Markus, On Mon, Jan 4, 2016 at 11:33 PM, SF Markus Elfring wrote: >>> May I resend a consistent patch series for the source file >>> "drivers/net/wireless/rsi/rsi_91x_pkt.c" in the near future? >> >> If you were sending checkpatch.pl fixes that would be easier

Re: [PATCH net-next 0/3] Fix some typos in setting hardware parameter

2016-01-04 Thread David Miller
From: Chunhao Lin Date: Tue, 29 Dec 2015 22:13:36 +0800 > The typos are in setting RTL8168DP, RTL8168EP and RTL8168H hardware > parameters. > This series of patch fix these typos. Series applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in

Re: [PATCH net-next V3 0/4] Introduce mlx5 ethernet timestamping

2016-01-04 Thread Saeed Mahameed
Sorry my mistake, please ignore my last email, just got your response on the matter, On Mon, Jan 4, 2016 at 11:57 PM, Saeed Mahameed wrote: > Hi Dave, > > Any chance you are giving this a shot ? > > On Tue, Dec 29, 2015 at 2:58 PM, Saeed Mahameed

Re: [PATCH 2/4] net: phy: at803x: Allow specifying the RGMII RX clock delay via phy mode

2016-01-04 Thread Florian Fainelli
On 04/01/16 13:17, Martin Blumenstingl wrote: > On Sun, Dec 27, 2015 at 9:22 PM, Mason wrote: >> On 27/12/2015 04:28, Florian Fainelli wrote: >> >>> Le 25/12/2015 16:27, Martin Blumenstingl wrote: >>> diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c

Re: [PATCH] mISDN: correctly handling failed allocation in fsm

2016-01-04 Thread David Miller
From: Insu Yun Date: Tue, 29 Dec 2015 16:41:33 -0500 > Since kzalloc can be failed in memory pressure, > NULL dereference can be happened. > > Signed-off-by: Insu Yun Similarly to your other mISDN patch you must propagate and handle errors properly. -- To

Re: [PATCH v3 net-next 3/4] soreuseport: setsockopt SO_ATTACH_REUSEPORT_[CE]BPF

2016-01-04 Thread Craig Gallek
On Mon, Jan 4, 2016 at 3:11 PM, Alexei Starovoitov wrote: > On Mon, Jan 04, 2016 at 11:26:37AM -0500, Craig Gallek wrote: >> From: Craig Gallek >> >> Expose socket options for setting a classic or extended BPF program >> for use when selecting

Re: [PATCH v4 net-next 3/4] soreuseport: setsockopt SO_ATTACH_REUSEPORT_[CE]BPF

2016-01-04 Thread Alexei Starovoitov
On Mon, Jan 04, 2016 at 05:41:47PM -0500, Craig Gallek wrote: > From: Craig Gallek > > Expose socket options for setting a classic or extended BPF program > for use when selecting sockets in an SO_REUSEPORT group. These options > can be used on the first socket to belong to a

Re: [PATCH net-next] net: Implement fast csum_partial for x86_64

2016-01-04 Thread Tom Herbert
On Mon, Jan 4, 2016 at 3:52 PM, Eric Dumazet wrote: > On Mon, 2016-01-04 at 15:34 -0800, Tom Herbert wrote: >> On Mon, Jan 4, 2016 at 2:36 PM, Eric Dumazet wrote: >> > On Sun, 2016-01-03 at 15:22 -0800, Tom Herbert wrote: >> > \... >> >> +402: /*

[PATCH v4 net-next 3/4] soreuseport: setsockopt SO_ATTACH_REUSEPORT_[CE]BPF

2016-01-04 Thread Craig Gallek
From: Craig Gallek Expose socket options for setting a classic or extended BPF program for use when selecting sockets in an SO_REUSEPORT group. These options can be used on the first socket to belong to a group before bind or on any socket in the group after bind. This change

[PATCH v4 net-next 0/4] Faster SO_REUSEPORT

2016-01-04 Thread Craig Gallek
From: Craig Gallek This series contains two optimizations for the SO_REUSEPORT feature: Faster lookup when selecting a socket for an incoming packet and the ability to select the socket from the group using a BPF program. This series only includes the UDP path. I plan to

[PATCH v4 net-next 2/4] soreuseport: fast reuseport UDP socket selection

2016-01-04 Thread Craig Gallek
From: Craig Gallek Include a struct sock_reuseport instance when a UDP socket binds to a specific address for the first time with the reuseport flag set. When selecting a socket for an incoming UDP packet, use the information available in sock_reuseport if present. This

[PATCH v4 net-next 1/4] soreuseport: define reuseport groups

2016-01-04 Thread Craig Gallek
From: Craig Gallek struct sock_reuseport is an optional shared structure referenced by each socket belonging to a reuseport group. When a socket is bound to an address/port not yet in use and the reuseport flag has been set, the structure will be allocated and attached to the

[PATCH v4 net-next 4/4] soreuseport: BPF selection functional test

2016-01-04 Thread Craig Gallek
From: Craig Gallek This program will build classic and extended BPF programs and validate the socket selection logic when used with SO_ATTACH_REUSEPORT_CBPF and SO_ATTACH_REUSEPORT_EBPF. It also validates the re-programing flow and several edge cases. Signed-off-by: Craig

Re: [PATCH net-next] net: Implement fast csum_partial for x86_64

2016-01-04 Thread Tom Herbert
On Mon, Jan 4, 2016 at 2:36 PM, Eric Dumazet wrote: > On Sun, 2016-01-03 at 15:22 -0800, Tom Herbert wrote: > \... >> +402: /* Length 2, align is 1, 3, or 5 */ >> + movb(%rdi), %al >> + movb1(%rdi), %ah > > Looks like a movw (%rdi),%ax > Wouldn't that be an

Re: [PATCH net-next] l2tp: rely on ppp layer for skb scrubbing

2016-01-04 Thread David Miller
From: Guillaume Nault Date: Tue, 29 Dec 2015 13:06:59 +0100 > Since 79c441ae505c ("ppp: implement x-netns support"), the PPP layer > calls skb_scrub_packet() whenever the skb is received on the PPP > device. Manually resetting packet meta-data in the L2TP layer is thus >

Re: [PATCH net-next] net: Implement fast csum_partial for x86_64

2016-01-04 Thread Eric Dumazet
On Sun, 2016-01-03 at 15:22 -0800, Tom Herbert wrote: \... > +402: /* Length 2, align is 1, 3, or 5 */ > + movb(%rdi), %al > + movb1(%rdi), %ah Looks like a movw (%rdi),%ax Also you probably should send this patch to x86 maintainers. -- To unsubscribe from this list: send the

Re: [PATCH v4 net-next 1/4] soreuseport: define reuseport groups

2016-01-04 Thread Eric Dumazet
On Mon, 2016-01-04 at 17:41 -0500, Craig Gallek wrote: > From: Craig Gallek > Acked-by: Eric Dumazet -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH 1/1] include/uapi/linux/sockios.h: mark SIOCRTMSG unused

2016-01-04 Thread David Miller
From: Heinrich Schuchardt Date: Tue, 29 Dec 2015 23:22:02 +0100 > IOCTL SIOCRTMSG does nothing but return EINVAL. > > So comment it as unused. > > Signed-off-by: Heinrich Schuchardt Please enhance your commit log message to include the analysis you

Re: [PATCH] af_unix: Fix splice-bind deadlock

2016-01-04 Thread Hannes Frederic Sowa
Hello, On Sun, Jan 3, 2016, at 19:03, Rainer Weikusat wrote: > Rainer Weikusat writes: > > > Hannes Frederic Sowa writes: > >> On 27.12.2015 21:13, Rainer Weikusat wrote: > >>> -static int unix_mknod(const char *sun_path,

Re: [PATCH net-next] net: Implement fast csum_partial for x86_64

2016-01-04 Thread Hannes Frederic Sowa
On 05.01.2016 00:34, Tom Herbert wrote: On Mon, Jan 4, 2016 at 2:36 PM, Eric Dumazet wrote: On Sun, 2016-01-03 at 15:22 -0800, Tom Herbert wrote: \... +402: /* Length 2, align is 1, 3, or 5 */ + movb(%rdi), %al + movb1(%rdi), %ah Looks like a movw

Re: [PATCH net-next] net: Implement fast csum_partial for x86_64

2016-01-04 Thread Eric Dumazet
On Mon, 2016-01-04 at 15:34 -0800, Tom Herbert wrote: > On Mon, Jan 4, 2016 at 2:36 PM, Eric Dumazet wrote: > > On Sun, 2016-01-03 at 15:22 -0800, Tom Herbert wrote: > > \... > >> +402: /* Length 2, align is 1, 3, or 5 */ > >> + movb(%rdi), %al > >> + movb

Re: [PATCH net-next V3 0/4] Introduce mlx5 ethernet timestamping

2016-01-04 Thread David Miller
From: Saeed Mahameed Date: Tue, 29 Dec 2015 14:58:28 +0200 > This patch series introduces the support for ConnectX-4 timestamping > and the PTP kernel interface. Richard, please review this series. Thanks. -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH] qlcnic: correctly handle qlcnic_alloc_mbx_args

2016-01-04 Thread David Miller
From: Insu Yun Date: Tue, 29 Dec 2015 15:02:18 -0500 > Since qlcnic_alloc_mbx_args can be failed, > return value should be checked. > > Signed-off-by: Insu Yun Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the

Re: [PATCH] cxgb4: correctly handling failed allocation

2016-01-04 Thread David Miller
From: Insu Yun Date: Tue, 29 Dec 2015 17:20:11 -0500 > Since t4_alloc_mem can be failed in memory pressure, > if not properly handled, NULL dereference could be happened. > > Signed-off-by: Insu Yun Applied. -- To unsubscribe from this list: send the line

Re: [PATCH net-next] net: Implement fast csum_partial for x86_64

2016-01-04 Thread Hannes Frederic Sowa
On 04.01.2016 00:22, Tom Herbert wrote: Implement assembly routine for csum_partial for 64 bit x86. This primarily speeds up checksum calculation for smaller lengths such as those that are present when doing skb_postpull_rcsum when getting CHECKSUM_COMPLETE from device or after

Re: [PATCH net-next] udp: properly support MSG_PEEK with truncated buffers

2016-01-04 Thread David Miller
From: Eric Dumazet Date: Wed, 30 Dec 2015 08:51:12 -0500 > From: Eric Dumazet > > Backport of this upstream commit into stable kernels : > 89c22d8c3b27 ("net: Fix skb csum races when peeking") > exposed a bug in udp stack vs MSG_PEEK support, when

  1   2   3   >