Re: Keystone 2 boards boot failure

2016-02-04 Thread Grygorii Strashko
On 02/03/2016 06:20 PM, Arnd Bergmann wrote: > On Wednesday 03 February 2016 16:21:05 Grygorii Strashko wrote: >> On 02/03/2016 04:11 PM, Franklin S Cooper Jr. wrote: >>> On 02/02/2016 07:19 PM, Franklin S Cooper Jr. wrote: > So only making this change on the latest master with no oth

RE: [PATCH 1/2] rtlwifi: Fix improve function 'rtl_addr_delay()' in core.c

2016-02-04 Thread David Laight
From: Larry Finger > Sent: 04 February 2016 15:44 > On 02/04/2016 03:48 AM, David Laight wrote: > > From: Larry Finger > >> Sent: 03 February 2016 19:45 > > ... > >> The performance will depend on where you satisfy the condition. All switch > >> cases > >> have the same execution time, but in the

RE: bonding reports interface up with 0 Mbps

2016-02-04 Thread Tantilov, Emil S
>-Original Message- >From: Jay Vosburgh [mailto:jay.vosbu...@canonical.com] >Sent: Wednesday, February 03, 2016 9:57 PM >To: Tantilov, Emil S >Cc: netdev@vger.kernel.org; go...@cumulusnetworks.com; zhuyj; >j...@mellanox.com >Subject: Re: bonding reports interface up with 0 Mbps > >Tantilov,

Re: [PATCH 1/2] rtlwifi: Fix improve function 'rtl_addr_delay()' in core.c

2016-02-04 Thread Larry Finger
On 02/04/2016 03:48 AM, David Laight wrote: From: Larry Finger Sent: 03 February 2016 19:45 ... The performance will depend on where you satisfy the condition. All switch cases have the same execution time, but in the if .. else if .. else form, the earlier tests execute more quickly. I'm not

[PATCH net-next 0/7] Faster SO_REUSEPORT for TCP

2016-02-04 Thread Craig Gallek
From: Craig Gallek This patch series complements an earlier series (6a5ef90c58da) which added faster SO_REUSEPORT lookup for UDP sockets by extending the feature to TCP sockets. It uses the same array-based data structure which allows for socket selection after finding the first listening socket

[PATCH net-next 3/7] tcp: __tcp_hdrlen() helper

2016-02-04 Thread Craig Gallek
From: Craig Gallek tcp_hdrlen is wasteful if you already have a pointer to struct tcphdr. This splits the size calculation into a helper function that can be used if a struct tcphdr is already available. Signed-off-by: Craig Gallek --- include/linux/tcp.h | 7 ++- 1 file changed, 6 inserti

[PATCH net-next 7/7] soreuseport: BPF selection functional test for TCP

2016-02-04 Thread Craig Gallek
From: Craig Gallek Unfortunately the existing test relied on packet payload in order to map incoming packets to sockets. In order to get this to work with TCP, TCP_FASTOPEN needed to be used. Since the fast open path is slightly different than the standard TCP path, I created a second test whic

[PATCH net-next 6/7] soreuseport: fast reuseport TCP socket selection

2016-02-04 Thread Craig Gallek
From: Craig Gallek This change extends the fast SO_REUSEPORT socket lookup implemented for UDP to TCP. Listener sockets with SO_REUSEPORT and the same receive address are additionally added to an array for faster random access. This means that only a single socket from the group must be found i

[PATCH net-next 5/7] soreuseport: Prep for fast reuseport TCP socket selection

2016-02-04 Thread Craig Gallek
From: Craig Gallek Both of the lines in this patch probably should have been included in the initial implementation of this code for generic socket support, but weren't technically necessary since only UDP sockets were supported. First, the sk_reuseport_cb points to a structure which assumes eac

[PATCH net-next 4/7] inet: refactor inet[6]_lookup functions to take skb

2016-02-04 Thread Craig Gallek
From: Craig Gallek This is a preliminary step to allow fast socket lookup of SO_REUSEPORT groups. Doing so with a BPF filter will require access to the skb in question. This change plumbs the skb (and offset to payload data) through the call stack to the listening socket lookup implementations

[PATCH net-next 2/7] inet: create IPv6-equivalent inet_hash function

2016-02-04 Thread Craig Gallek
From: Craig Gallek In order to support fast lookups for TCP sockets with SO_REUSEPORT, the function that adds sockets to the listening hash set needs to be able to check receive address equality. Since this equality check is different for IPv4 and IPv6, we will need two different socket hashing

[PATCH net-next 1/7] sock: struct proto hash function may error

2016-02-04 Thread Craig Gallek
From: Craig Gallek In order to support fast reuseport lookups in TCP, the hash function defined in struct proto must be capable of returning an error code. This patch changes the function signature of all related hash functions to return an integer and handles or propagates this return value at a

[PATCH net-next 2/7] inet: create IPv6-equivalent inet_hash function

2016-02-04 Thread Craig Gallek
From: Craig Gallek In order to support fast lookups for TCP sockets with SO_REUSEPORT, the function that adds sockets to the listening hash set needs to be able to check receive address equality. Since this equality check is different for IPv4 and IPv6, we will need two different socket hashing

[PATCH net-next 0/7] Faster SO_REUSEPORT for TCP

2016-02-04 Thread Craig Gallek
From: Craig Gallek This patch series complements an earlier series (6a5ef90c58da) which added faster SO_REUSEPORT lookup for UDP sockets by extending the feature to TCP sockets. It uses the same array-based data structure which allows for socket selection after finding the first listening socket

[PATCH net-next 1/7] sock: struct proto hash function may error

2016-02-04 Thread Craig Gallek
From: Craig Gallek In order to support fast reuseport lookups in TCP, the hash function defined in struct proto must be capable of returning an error code. This patch changes the function signature of all related hash functions to return an integer and handles or propagates this return value at a

Re: gigaset: memory leak in gigaset_initcshw

2016-02-04 Thread Paul Bolle
On do, 2016-02-04 at 15:54 +0100, Dmitry Vyukov wrote: > One TIOCSETD is enough to trigger the leak. > I've tested with different line disciplines and only N_GIGASET_M101 > triggers the leak. So things appear to be just on my plate now. I'll see what I can come up with. Feel free to prod me if I s

Re: gigaset: memory leak in gigaset_initcshw

2016-02-04 Thread Dmitry Vyukov
On Thu, Feb 4, 2016 at 2:46 PM, Paul Bolle wrote: > Hi Dmitry, > > On do, 2016-02-04 at 14:15 +0100, Dmitry Vyukov wrote: >> On Thu, Feb 4, 2016 at 2:09 PM, Paul Bolle wrote: >> > What are you seeing here? >> >> I see that active_objs is slowly, constantly growing. >> >> I've attached my config f

[PATCH net] ipv4: fix memory leaks in ip_cmsg_send() callers

2016-02-04 Thread Eric Dumazet
From: Eric Dumazet Dmitry reported memory leaks of IP options allocated in ip_cmsg_send() when/if this function returns an error. Callers are responsible for the freeing. Many thanks to Dmitry for the report and diagnostic. Reported-by: Dmitry Vyukov Signed-off-by: Eric Dumazet --- net/ipv4

Re: net: memory leak in ip_cmsg_send

2016-02-04 Thread Eric Dumazet
On Thu, 2016-02-04 at 10:47 +0100, Dmitry Vyukov wrote: > Hello, > > I've hit the following memory leak while running syzkaller fuzzer: > > unreferenced object 0x88002ea39708 (size 64): > comm "syz-executor", pid 19887, jiffies 4295848369 (age 8.676s) > hex dump (first 32 bytes): > 00

[PATCH 1/3] net: cavium: liquidio: Return correct error code

2016-02-04 Thread Amitoj Kaur Chawla
The return value of vmalloc on failure of allocation of memory should be -ENOMEM and not -1. Found using Coccinelle. A simplified version of the semantic patch used is: // @@ expression *e; identifier l1; position p,q; @@ e@q = vmalloc(...); if@p (e == NULL) { ... goto l1; } l1: ... return -1 +

[PATCH 2/3] ibmveth: Return correct error codes

2016-02-04 Thread Amitoj Kaur Chawla
The return value of kmalloc and kcalloc on failure of allocation of memory should be -ENOMEM and not -1. Found using Coccinelle. A simplified version of the semantic patch used is: // @@ expression *e; position p,q; @@ e@q = \(kmalloc\|kcalloc\)(...); if@p (e == NULL) { ... return - -1 + -ENOMEM

[PATCH 3/3] net: mvpp2: Return correct error codes

2016-02-04 Thread Amitoj Kaur Chawla
The return value of kzalloc on failure of allocation of memory should be -ENOMEM and not -1. Found using Coccinelle. A simplified version of the semantic patch used is: // @@ expression *e; position p,q; @@ e@q = kzalloc(...); if@p (e == NULL) { ... return - -1 + -ENOMEM ; } // This function ma

Re: gigaset: memory leak in gigaset_initcshw

2016-02-04 Thread Paul Bolle
Hi Dmitry, On do, 2016-02-04 at 14:15 +0100, Dmitry Vyukov wrote: > On Thu, Feb 4, 2016 at 2:09 PM, Paul Bolle wrote: > > What are you seeing here? > > I see that active_objs is slowly, constantly growing. > > I've attached my config file, please try with it. You mentioned that > "16 is N_GIGAS

Re: [patch net-next RFC 0/6] Introduce devlink interface and first drivers to use it

2016-02-04 Thread Jiri Pirko
Thu, Feb 04, 2016 at 02:22:17PM CET, han...@stressinduktion.org wrote: >On 03.02.2016 16:17, Daniel Borkmann wrote: >>On 02/03/2016 02:33 PM, Jiri Pirko wrote: >>>Wed, Feb 03, 2016 at 02:31:33PM CET, bro...@redhat.com wrote: On Wed, 3 Feb 2016 11:47:56 +0100 Jiri Pirko wrote: >From: J

Re: [patch net-next RFC 0/6] Introduce devlink interface and first drivers to use it

2016-02-04 Thread Hannes Frederic Sowa
On 03.02.2016 16:17, Daniel Borkmann wrote: On 02/03/2016 02:33 PM, Jiri Pirko wrote: Wed, Feb 03, 2016 at 02:31:33PM CET, bro...@redhat.com wrote: On Wed, 3 Feb 2016 11:47:56 +0100 Jiri Pirko wrote: From: Jiri Pirko [...] It is available here: https://github.com/jpirko/devlink IHMO thi

Re: [net-next PATCH 3/7] net: sched: add cls_u32 offload hooks for netdevs

2016-02-04 Thread Amir Vadai"
On Wed, Feb 03, 2016 at 01:28:37AM -0800, John Fastabend wrote: > This patch allows netdev drivers to consume cls_u32 offloads via > the ndo_setup_tc ndo op. > > This works aligns with how network drivers have been doing qdisc > offloads for mqprio. > > Signed-off-by: John Fastabend > --- > inc

Re: [net-next PATCH 0/7] tc offload for cls_u32 on ixgbe

2016-02-04 Thread Jamal Hadi Salim
On 16-02-03 01:48 PM, Fastabend, John R wrote: BTW: For the record John, I empathize with you that we need to move. Please have patience - we are close; lets just get this resolved in Seville. I like your patches a lot and would love to just have your patches pushed in, but the challenges with c

Re: gigaset: memory leak in gigaset_initcshw

2016-02-04 Thread Paul Bolle
On do, 2016-02-04 at 11:40 +0100, Dmitry Vyukov wrote: > Forgot to mention that you need to run it in a parallel loop, sorry. I see. > This one should do: > > // autogenerated by syzkaller (http://github.com/google/syzkaller) > #include > #include > #include > #include > #include > #include

Re: Keystone 2 boards boot failure

2016-02-04 Thread Arnd Bergmann
On Thursday 04 February 2016 14:19:54 Grygorii Strashko wrote: > On 02/03/2016 10:40 PM, Arnd Bergmann wrote: > > On Wednesday 03 February 2016 18:31:00 Grygorii Strashko wrote: > >> On 02/03/2016 06:20 PM, Arnd Bergmann wrote: > >>> On Wednesday 03 February 2016 16:21:05 Grygorii Strashko wrote: >

Re: Fw: [Bug 111771] New: deadlock in ppp/l2tp

2016-02-04 Thread Guillaume Nault
On Thu, Feb 04, 2016 at 02:32:48AM +0100, Sorin Manolache wrote: > On 2016-02-03 18:14, Guillaume Nault wrote: > > > >Sorin, it seems like one of your L2TP tunnels is routed to one of its upper > >PPP > >devices. Most likely, the peer address of the PPP device is also the address > >of > >the re

Re: [PATCH net-next v5 1/2] ethtool: add speed/duplex validation functions

2016-02-04 Thread Michael S. Tsirkin
On Wed, Feb 03, 2016 at 03:49:04PM -0800, Rick Jones wrote: > On 02/03/2016 03:32 PM, Stephen Hemminger wrote: > > >But why check for valid value at all. At some point in the > >future, there will be yet another speed adopted by some standard body > >and the switch statement would need another val

[PATCH v3 1/4] ipv4: add option to drop unicast encapsulated in L2 multicast

2016-02-04 Thread Johannes Berg
From: Johannes Berg In order to solve a problem with 802.11, the so-called hole-196 attack, add an option (sysctl) called "drop_unicast_in_l2_multicast" which, if enabled, causes the stack to drop IPv4 unicast packets encapsulated in link-layer multi- or broadcast frames. Such frames can (as an a

[PATCH v3 4/4] ipv6: add option to drop unsolicited neighbor advertisements

2016-02-04 Thread Johannes Berg
From: Johannes Berg In certain 802.11 wireless deployments, there will be NA proxies that use knowledge of the network to correctly answer requests. To prevent unsolicitd advertisements on the shared medium from being a problem, on such deployments wireless needs to drop them. Enable this by pro

[PATCH v3 3/4] ipv6: add option to drop unicast encapsulated in L2 multicast

2016-02-04 Thread Johannes Berg
From: Johannes Berg In order to solve a problem with 802.11, the so-called hole-196 attack, add an option (sysctl) called "drop_unicast_in_l2_multicast" which, if enabled, causes the stack to drop IPv6 unicast packets encapsulated in link-layer multi- or broadcast frames. Such frames can (as an a

[PATCH v3 2/4] ipv4: add option to drop gratuitous ARP packets

2016-02-04 Thread Johannes Berg
From: Johannes Berg In certain 802.11 wireless deployments, there will be ARP proxies that use knowledge of the network to correctly answer requests. To prevent gratuitous ARP frames on the shared medium from being a problem, on such deployments wireless needs to drop them. Enable this by provid

Re: [PATCH net-next v5 2/2] virtio_net: add ethtool support for set and get of settings

2016-02-04 Thread Nikolay Aleksandrov
On 02/04/2016 01:21 PM, Michael S. Tsirkin wrote: > On Wed, Feb 03, 2016 at 04:04:37AM +0100, Nikolay Aleksandrov wrote: >> From: Nikolay Aleksandrov [snip] >> struct padded_vnet_hdr { >> @@ -1376,6 +1380,58 @@ static void virtnet_get_channels(struct net_device >> *dev, >> channels->other_c

Re: [PATCH net-next v5 2/2] virtio_net: add ethtool support for set and get of settings

2016-02-04 Thread Michael S. Tsirkin
On Wed, Feb 03, 2016 at 10:19:04AM +0100, Nikolay Aleksandrov wrote: > On 02/03/2016 04:04 AM, Nikolay Aleksandrov wrote: > > From: Nikolay Aleksandrov > > > > This patch allows the user to set and retrieve speed and duplex of the > > virtio_net device via ethtool. Having this functionality is ve

Re: [PATCH net-next v5 2/2] virtio_net: add ethtool support for set and get of settings

2016-02-04 Thread Michael S. Tsirkin
On Wed, Feb 03, 2016 at 04:04:37AM +0100, Nikolay Aleksandrov wrote: > From: Nikolay Aleksandrov > > This patch allows the user to set and retrieve speed and duplex of the > virtio_net device via ethtool. Having this functionality is very helpful > for simulating different environments and also e

Re: Keystone 2 boards boot failure

2016-02-04 Thread Grygorii Strashko
Hi Arnd, On 02/03/2016 10:40 PM, Arnd Bergmann wrote: > On Wednesday 03 February 2016 18:31:00 Grygorii Strashko wrote: >> On 02/03/2016 06:20 PM, Arnd Bergmann wrote: >>> On Wednesday 03 February 2016 16:21:05 Grygorii Strashko wrote: On 02/03/2016 04:11 PM, Franklin S Cooper Jr. wrote:

Re: [PATCH net-next v5 1/2] ethtool: add speed/duplex validation functions

2016-02-04 Thread Michael S. Tsirkin
On Thu, Feb 04, 2016 at 10:32:26AM +1100, Stephen Hemminger wrote: > On Wed, 3 Feb 2016 04:04:36 +0100 > Nikolay Aleksandrov wrote: > > > > > +static inline int ethtool_validate_speed(__u32 speed) > > +{ > > > No need for inline. > > But why check for valid value at all. At some point in th

Re: [net-next PATCH 7/7] net: ixgbe: add support for tc_u32 offload

2016-02-04 Thread Amir Vadai"
On Thu, Feb 04, 2016 at 12:23:02AM -0800, Fastabend, John R wrote: > On 2/3/2016 11:30 PM, Amir Vadai" wrote: > > On Wed, Feb 03, 2016 at 01:29:59AM -0800, John Fastabend wrote: > >> This adds initial support for offloading the u32 tc classifier. This > >> initial implementation only implements a f

[net-next 13/20] i40evf: add new write-back mode

2016-02-04 Thread Jeff Kirsher
From: Anjali Singhai Jain Add write-back on interrupt throttle rate timer expiration support for the i40evf driver, when running on X722 devices. Signed-off-by: Anjali Singhai Jain Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c |

[net-next 10/20] i40e: add new device IDs for X722

2016-02-04 Thread Jeff Kirsher
From: Anjali Singhai Jain Add the KX and QSFP device IDs for X722. Signed-off-by: Anjali Singhai Jain Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_common.c | 2 ++ drivers/net/ethernet/intel/i40e/i40e_devids.h | 2 ++ drivers/net/ethernet/inte

[net-next 15/20] i40e: add new proxy-wol bit for X722

2016-02-04 Thread Jeff Kirsher
From: Shannon Nelson Add the new proxy-wake-on-lan capability bit available with the new X722 device. Signed-off-by: Shannon Nelson Acked-by: Jesse Brandeburg Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_adminq_cmd.h | 1 + drivers/net/ethe

[net-next 09/20] i40e: bump version to 1.4.10

2016-02-04 Thread Jeff Kirsher
From: Catherine Sullivan Bump. Change-ID: Ic9a495feb9ab0606f953c3848b0acf67169d3930 Signed-off-by: Catherine Sullivan Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drive

[net-next 00/20][pull request] 40GbE Intel Wired LAN Driver Updates 2016-02-03

2016-02-04 Thread Jeff Kirsher
This series contains updates to i40e and i40evf only. Kiran adds the MAC filter element to the end of the list instead of HEAD just in case there are ever any ordering issues in the future. Anjali fixes several RSS issues, first fixes the hash PCTYPE enable for X722 since it supports a broader se

[net-next 03/20] i40e: Replace X722 mac check in ethtool get_settings

2016-02-04 Thread Jeff Kirsher
From: Catherine Sullivan 100M SGMII is only supported on X722. Replace the mac check with a feature flag check that is only set for the X722 device. Change-ID: I53452d9af6af8cd9dca8500215fbc6ce93418f52 Signed-off-by: Catherine Sullivan Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher ---

[net-next 04/20] i40evf: allow channel bonding of VFs

2016-02-04 Thread Jeff Kirsher
From: Mitch Williams In some modes, bonding would not enslave VF interfaces. This is due to bonding calling change_mtu and the immediately calling open. Because of the asynchronous nature of the admin queue mechanism, the VF returns -EBUSY to the open call, because it knows the previous operation

[net-next 02/20] i40e/i40evf: Fix RSS rx-flow-hash configuration through ethtool

2016-02-04 Thread Jeff Kirsher
From: Anjali Singhai Jain This patch fixes the Hash PCTYPE enable for X722 since it supports a broader selection of PCTYPES for TCP and UDP. This patch also fixes a bug in XL710, X710, X722 support for RSS, as of now we cannot reduce the (4)tuple for RSS for TCP/IPv4/IPV6 or UDP/IPv4/IPv6 packet

[net-next 14/20] i40e/i40evf: Use private workqueue

2016-02-04 Thread Jeff Kirsher
From: Jesse Brandeburg As done per ixgbe, use a private workqueue to avoid blocking the system workqueue. This avoids some strange side effects when some other entity is depending on the system work queue. Change-ID: Ic8ba08f5b03696cf638b21afd25fbae7738d55ee Signed-off-by: Jesse Brandeburg Tes

[net-next 19/20] i40e: AQ Add external power class to get link status

2016-02-04 Thread Jeff Kirsher
From: Shannon Nelson Add the new External Device Power Ability field to the get_link_status data structure, using space from the reserved field at the end of the struct. Signed-off-by: Shannon Nelson Acked-by: Kevin Scott Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/

[net-next 16/20] i40e: Limit DCB FW version checks to X710/XL710 devices

2016-02-04 Thread Jeff Kirsher
From: Greg Bowers X710/XL710 devices require FW version checks to properly handle DCB configurations from the FW. Newer devices do not, so limit these checks to X710/XL710. Signed-off-by: Greg Bowers Acked-by: Shannon Nelson Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/

[net-next 18/20] i40e: AQ Geneve cloud tunnel type

2016-02-04 Thread Jeff Kirsher
From: Shannon Nelson Fix the name of the new cloud tunnel type from the place-holder NGE name to the official Geneve. Also fix the spelling of the VXLAN type. Signed-off-by: Shannon Nelson Acked-by: Kevin Scott Signed-off-by: Jeff Kirsher Tested-by: Andrew Bowers --- drivers/net/ethernet/i

[net-next 05/20] i40e: define function capabilities in only one place

2016-02-04 Thread Jeff Kirsher
From: Shannon Nelson The device capabilities were defined in two places, and neither had all the definitions. It really belongs with the AQ API definition, so this patch removes the other set of definitions and fills out the missing item. Change-ID: I273ba7d79a476cd11d2e0ca5825fec1716740de2 Sig

[net-next 08/20] i40e: update features with right offload

2016-02-04 Thread Jeff Kirsher
From: Jesse Brandeburg Synchronize code bases and add SCTP offload support. Change-ID: I9f99071f7176225479026930c387bf681a47494e Signed-off-by: Jesse Brandeburg Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_main.c | 10 +- 1 file change

[net-next 17/20] i40e: AQ Add Run PHY Activity struct

2016-02-04 Thread Jeff Kirsher
From: Shannon Nelson Add the AQ opcode and struct definitions for the Run PHY Activity command Signed-off-by: Shannon Nelson Acked-by: Kevin Scott Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_adminq_cmd.h | 13 + drivers/net/eth

[net-next 12/20] i40e/i40evf: Fix for UDP/TCP RSS for X722

2016-02-04 Thread Jeff Kirsher
From: Anjali Singhai Jain The PCTYPES for the X710 and X722 families are different. This patch makes adjustments for that. Signed-off-by: Anjali Singhai Jain Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 18 ++ drive

[net-next 06/20] i40evf: null out ring pointers on free

2016-02-04 Thread Jeff Kirsher
From: Mitch Williams Since we check these ring pointers to make sure we don't double-allocate or double-free the rings, we had better null them out after we free them. In very rare cases this can cause a panic if the driver is removed during reset recovery. Change-ID: Ib06eb4910a3058275c8f7ec5ef

[net-next 20/20] i40e: add 100Mb ethtool reporting

2016-02-04 Thread Jeff Kirsher
From: Catherine Sullivan Add some missing reporting/advertisement of 100Mb capability for adapters that support it. Change-ID: I8b8523fbdc99517bec29d90c71b3744db11542ac Signed-off-by: Catherine Sullivan Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/

[net-next 11/20] i40e: Extend ethtool RSS hooks for X722

2016-02-04 Thread Jeff Kirsher
From: Anjali Singhai Jain This patch adds another way to access the RSS keys and lut using the AQ for X722 devices. Signed-off-by: Anjali Singhai Jain Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_main.c | 53 - 1 fi

[net-next 07/20] i40e: Cleanup the code with respect to restarting autoneg

2016-02-04 Thread Jeff Kirsher
From: Anjali Singhai Jain The restart-autoneg work around does not apply to X722. Added a flag to set it only for the right MAC and right FW version where the work around should be applied. Signed-off-by: Anjali Singhai Jain Change-ID: I942c3ff40cccd1e56f424b1da776b020fe3c9d2a Tested-by: Andrew

[net-next 01/20] i40e: Add mac_filter_element at the end of the list instead of HEAD

2016-02-04 Thread Jeff Kirsher
From: Kiran Patil Add MAC filter element to the end of the list in the given order, just to be tidy, and just in case there are ever any ordering issues in the future. Change-ID: Idc15276147593ea9393ac72c861f9c7905a791b4 Signed-off-by: Kiran Patil Tested-by: Andrew Bowers Signed-off-by: Jeff K

RE: [PATCH v3 net-next] net: Implement fast csum_partial for x86_64

2016-02-04 Thread David Laight
From: Tom Herbert > Sent: 03 February 2016 19:19 ... > + /* Main loop */ > +50: adcq0*8(%rdi),%rax > + adcq1*8(%rdi),%rax > + adcq2*8(%rdi),%rax > + adcq3*8(%rdi),%rax > + adcq4*8(%rdi),%rax > + adcq5*8(%rdi),%rax > + adcq6*8(%rdi),%rax > +

Re: [PATCH net v4] r8169: Disabling multiple invocation on rtl_try_msi function.

2016-02-04 Thread Corcodel Marian
On Thu, 2016-02-04 at 11:35 +0200, Corcodel Marian wrote: > This patch set MSI on probe stage without this patch MSI is set when > rtl_open occur. > Do not need to run rtl_try_msi on multiple times. > > Signed-off-by: Corcodel Marian > --- > drivers/net/ethernet/realtek/r8169.c | 4 +++- > 1 fi

Re: [PATCH net-next v5 1/2] ethtool: add speed/duplex validation functions

2016-02-04 Thread Nikolay Aleksandrov
On 02/04/2016 12:32 AM, Stephen Hemminger wrote: > On Wed, 3 Feb 2016 04:04:36 +0100 > Nikolay Aleksandrov wrote: > >> >> +static inline int ethtool_validate_speed(__u32 speed) >> +{ > > > No need for inline. > This is defined in a header, if it's not inline you start getting "defined but n

Re: [PATCH v3 net-next] net: Implement fast csum_partial for x86_64

2016-02-04 Thread Ingo Molnar
* Ingo Molnar wrote: > s/!CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS > > > + > > + /* Check length */ > > +10:cmpl$8, %esi > > + jg 30f > > + jl 20f > > + > > + /* Exactly 8 bytes length */ > > + addl(%rdi), %eax > > + adcl4(%rdi), %eax > > + RETURN > > +

Re: gigaset: memory leak in gigaset_initcshw

2016-02-04 Thread Dmitry Vyukov
On Wed, Feb 3, 2016 at 8:11 PM, Paul Bolle wrote: > Hi Dmitry, > > On wo, 2016-02-03 at 17:16 +0100, Paul Bolle wrote: >> The above should provide me with enough information to figure out >> what's going on here. > > I've instrumented ser_gigaset with some printk's. Basically I added the > stuff p

Re: net/tipc: memory leak in tipc_release

2016-02-04 Thread Dmitry Vyukov
On Thu, Dec 31, 2015 at 11:35 AM, Dmitry Vyukov wrote: > Hello, > > The following program, if run a parallel loop, leads to a leak of 2 > objects allocated in tipc_release: > > // autogenerated by syzkaller (http://github.com/google/syzkaller) > #include > #include > #include > #include > #inc

RE: [PATCH 1/2] rtlwifi: Fix improve function 'rtl_addr_delay()' in core.c

2016-02-04 Thread David Laight
From: Larry Finger > Sent: 03 February 2016 19:45 ... > The performance will depend on where you satisfy the condition. All switch > cases > have the same execution time, but in the if .. else if .. else form, the > earlier > tests execute more quickly. I'm not sure that one can make any blanket

[PATCH net-next] MAINTAINERS: Update tg3 maintainer

2016-02-04 Thread skallam
From: Siva Reddy Kallam Signed-off-by: Siva Reddy Kallam Signed-off-by: Michael Chan Acked-by: Prashant Sreedharan --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index f678c37..5edcb8a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2424,6 +2424,7

net: memory leak in ip_cmsg_send

2016-02-04 Thread Dmitry Vyukov
Hello, I've hit the following memory leak while running syzkaller fuzzer: unreferenced object 0x88002ea39708 (size 64): comm "syz-executor", pid 19887, jiffies 4295848369 (age 8.676s) hex dump (first 32 bytes): 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0

Re: [PATCH net] sctp: do sanity checks before migrating the asoc

2016-02-04 Thread Marcelo Ricardo Leitner
On Wed, Feb 03, 2016 at 05:13:25PM +0100, Dmitry Vyukov wrote: > On Tue, Jan 19, 2016 at 9:08 PM, Marcelo Ricardo Leitner > wrote: > > Em 19-01-2016 17:55, Vlad Yasevich escreveu: > >> > >> On 01/19/2016 02:31 PM, Marcelo Ricardo Leitner wrote: > >>> > >>> Em 19-01-2016 16:37, Vlad Yasevich escrev

[PATCH] bpf_dbg: do not initialise statics to 0

2016-02-04 Thread Wei Tang
This patch fixes the checkpatch.pl error to bpf_dbg.c: ERROR: do not initialise statics to 0 Signed-off-by: Wei Tang --- tools/net/bpf_dbg.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tools/net/bpf_dbg.c b/tools/net/bpf_dbg.c index 9a287be..4f254bc 100644 ---

Re: [PATCH net] sctp: translate network order to host order when users get a hmacid

2016-02-04 Thread Marcelo Ricardo Leitner
On Wed, Feb 03, 2016 at 11:33:30PM +0800, Xin Long wrote: > Commit ed5a377d87dc ("sctp: translate host order to network order when > setting a hmacid") corrected the hmacid byte-order when setting a hmacid. > but the same issue also exists on getting a hmacid. > > We fix it by changing hmacids to

[PATCH 1/1] igb: adjust indent and remove unnecessary parentheses

2016-02-04 Thread zyjzyj2000
From: Zhu Yanjun Adjust indent and remove unnecessary parentheses in igb driver. Signed-off-by: Zhu Yanjun --- drivers/net/ethernet/intel/igb/igb_main.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/dri

[PATCH net v4] r8169: Disabling multiple invocation on rtl_try_msi function.

2016-02-04 Thread Corcodel Marian
This patch set MSI on probe stage without this patch MSI is set when rtl_open occur. Do not need to run rtl_try_msi on multiple times. Signed-off-by: Corcodel Marian --- drivers/net/ethernet/realtek/r8169.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethe

Re: [PATCH v3 net-next] net: Implement fast csum_partial for x86_64

2016-02-04 Thread Ingo Molnar
* Tom Herbert wrote: > Implement assembly routine for csum_partial for 64 bit x86. This > primarily speeds up checksum calculation for smaller lengths such as > those that are present when doing skb_postpull_rcsum when getting > CHECKSUM_COMPLETE from device or after CHECKSUM_UNNECESSARY > conve

Re: [net-next PATCH 0/7] tc offload for cls_u32 on ixgbe

2016-02-04 Thread Jiri Pirko
Wed, Feb 03, 2016 at 10:27:32AM CET, john.fastab...@gmail.com wrote: >This extends the setup_tc framework so it can support more than just >the mqprio offload and push other classifiers and qdiscs into the >hardware. The series here targets the u32 classifier and ixgbe >driver. I worked out the u32

net/irda: BUG: looking up invalid subclass: 4294967295

2016-02-04 Thread Dmitry Vyukov
Hello, I am hitting the following BUGs while running syzkaller fuzzer: BUG: looking up invalid subclass: 4294967295 turning off the locking correctness validator. CPU: 1 PID: 12344 Comm: syz-executor Not tainted 4.5.0-rc2+ #309 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS Bochs 01/

Re: [net-next PATCH 7/7] net: ixgbe: add support for tc_u32 offload

2016-02-04 Thread Fastabend, John R
On 2/3/2016 11:30 PM, Amir Vadai" wrote: > On Wed, Feb 03, 2016 at 01:29:59AM -0800, John Fastabend wrote: >> This adds initial support for offloading the u32 tc classifier. This >> initial implementation only implements a few base matches and actions >> to illustrate the use of the infrastructure

<    1   2