Re: linux-next: build warning after merge of the net-next tree

2016-02-15 Thread Nikolay Borisov
On 02/15/2016 04:09 AM, Stephen Rothwell wrote: > Hi all, > > After merging the net-next tree, today's linux-next build (arm > multi_v7_defconfig) produced this warning: > > net/ipv4/igmp.c: In function 'igmp_group_added': > net/ipv4/igmp.c:1227:14: warning: unused variable 'net' [-Wunused-vari

[PATCH net-next] store complete hash type information in socket buffer...

2016-02-15 Thread Paul Durrant
...rather than a boolean merely indicating a canonical L4 hash. skb_set_hash() takes a hash type (from enum pkt_hash_types) as an argument but information is lost since only a single bit in the skb stores whether that hash type is PKT_HASH_TYPE_L4 or not. By using two bits it's possible to store t

[PATCH] net: bcmgenet: Add MDIO_INTR in GENETv2

2016-02-15 Thread Jaedon Shin
The GENETv2 chipsets has MDIO interrupt like the GENETv3+ chipsets. The previous commit d5c3d84657db ("net: phy: Avoid polling PHY with PHY_IGNORE_INTERRUPTS") and commit 49f7a471e4d1 ("net: bcmgenet: Properly configure PHY to ignore interrupt") cause link-down PHY always in some 40nm generation c

RE: [PATCH net-next v1 0/8] xen-netback: support toeplitz hashing

2016-02-15 Thread Paul Durrant
> -Original Message- > From: Tom Herbert [mailto:t...@herbertland.com] > Sent: 14 February 2016 22:02 > To: Paul Durrant > Cc: David Miller; netdev@vger.kernel.org; xen-de...@lists.xenproject.org > Subject: Re: [PATCH net-next v1 0/8] xen-netback: support toeplitz hashing > > On Fri, Feb 1

RE: [PATCH net-next v1 1/8] skbuff: store hash type in socket buffer...

2016-02-15 Thread Paul Durrant
> -Original Message- > From: Tom Herbert [mailto:t...@herbertland.com] > Sent: 14 February 2016 22:25 > To: Paul Durrant > Cc: Linux Kernel Network Developers; xen-de...@lists.xenproject.org; David > S. Miller; Jay Vosburgh; Veaceslav Falico; Andy Gospodarek > Subject: Re: [PATCH net-next v

Re: [PATCH 2/2] net: dsa: remove phy_disconnect from error path

2016-02-15 Thread Neil Armstrong
On 02/11/2016 04:39 PM, Vivien Didelot wrote: > Hi Sascha, > > Sascha Hauer writes: > >> The phy has not been initialized, disconnecting it in the error >> path results in a NULL pointer exception. Drop the phy_disconnect >> from the error path. >> >> Signed-off-by: Sascha Hauer >> --- >> net/

[PATCH] Bluetooth: hci_core: cancel power off delayed work properly

2016-02-15 Thread Wei-Ning Huang
From: Wei-Ning Huang When the HCI_AUTO_OFF flag is cleared, the power_off delayed work need to be cancel or HCI will be powered off even if it's managed. Signed-off-by: Wei-Ning Huang --- net/bluetooth/hci_core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/bluetooth/hci_core.c b/ne

Re: Configure ICMP error source address

2016-02-15 Thread Robert Sander
On 08.01.2016 10:31, Robert Sander wrote: > We have the situation that our routers use RFC1918 addresses on their > transfer networks (which should be quite common nowadays to save on > public IPv4 addresses). ICMP errors are generated with RFC1918 source > addresses and therefor never reach the o

Re: Same data to several sockets with just one syscall ?

2016-02-15 Thread Claudio Scordino
Hi Eric, 2016-02-12 11:35 GMT+01:00 Eric Dumazet : > On Fri, 2016-02-12 at 09:53 +0100, Claudio Scordino wrote: > >> This makes the application waste time in entering/exiting the kernel >> level several times. > > syscall overhead is usually small. Real cost is actually getting to the > socket obj

[PATCH 0/6] Namespacify various ip sysctl knobs

2016-02-15 Thread Nikolay Borisov
[Resending since I forgot to cc linux-netdev] Hello, This series continues namespacifying more net related knobs. The focus here is on ip options. Patches 1,3,4,5 namespacify the respective sysctl knobs. Patch 2 moves some igmp code to the correct file (and function) and also adds some #ifdef g

[PATCH 4/6] ipv4: namespacify ip_early_demux sysctl knob

2016-02-15 Thread Nikolay Borisov
Signed-off-by: Nikolay Borisov --- include/net/ip.h | 3 --- include/net/netns/ipv4.h | 1 + net/ipv4/ip_input.c| 5 + net/ipv4/sysctl_net_ipv4.c | 15 --- net/ipv6/ip6_input.c | 2 +- 5 files changed, 11 insertions(+), 15 deletions(-) diff --git a/i

[PATCH 6/6] net: Export ip fragment sysctl to unprivileged users

2016-02-15 Thread Nikolay Borisov
Now that all the ip fragmentation related sysctls are namespaceified there is no reason to hide them anymore from "root" users inside containers. Signed-off-by: Nikolay Borisov --- net/ipv4/ip_fragment.c | 4 1 file changed, 4 deletions(-) diff --git a/net/ipv4/ip_fragment.c b/net/ipv4/ip_

[PATCH 2/6] igmp: net: Move igmp namespace init to correct file

2016-02-15 Thread Nikolay Borisov
When igmp related sysctl were namespacified their initializatin was erroneously put into the tcp socket namespace constructor. This patch moves the relevant code into the igmp namespace constructor to keep things consistent. Also sprinkle some #ifdefs to silence warnings Signed-off-by: Nikolay Bo

[PATCH 1/6] ipv4: Namespaceify ip_default_ttl sysctl knob

2016-02-15 Thread Nikolay Borisov
Signed-off-by: Nikolay Borisov --- include/net/netns/ipv4.h | 1 + include/net/route.h | 5 ++--- net/bridge/netfilter/nft_reject_bridge.c | 8 +--- net/ipv4/ip_output.c | 3 --- net/ipv4/ip_sockglue.c | 5 -

[PATCH 5/6] ipv4: namespacify ip fragment max dist sysctl knob

2016-02-15 Thread Nikolay Borisov
Signed-off-by: Nikolay Borisov --- include/net/inet_frag.h | 1 + net/ipv4/ip_fragment.c | 25 + 2 files changed, 14 insertions(+), 12 deletions(-) diff --git a/include/net/inet_frag.h b/include/net/inet_frag.h index 12aac0fd6ee7..909972aa3acd 100644 --- a/include/net/i

[PATCH 3/6] ipv4: Namespacify ip_dynaddr sysctl knob

2016-02-15 Thread Nikolay Borisov
Signed-off-by: Nikolay Borisov --- include/net/ip.h | 3 --- include/net/netns/ipv4.h | 2 ++ net/ipv4/af_inet.c | 10 ++ net/ipv4/sysctl_net_ipv4.c | 15 --- 4 files changed, 12 insertions(+), 18 deletions(-) diff --git a/include/net/ip.h b/include/net/

Re: [PATCH net] bridge: fix regression in ageing time

2016-02-15 Thread Jiri Pirko
Fri, Feb 12, 2016 at 10:31:09PM CET, step...@networkplumber.org wrote: >This fixes a regression in the bridge ageing time caused by: > >commit c62987bbd8a1 ("bridge: push bridge setting ageing_time down to >switchdev") > >There are users of Linux bridge which use the feature that if ageing time >i

IPv4/IPv6 sysctl defaults in new namespace

2016-02-15 Thread Konstantin Khlebnikov
IPv6 initialized with default. That's ok. IPv4 makes a copy from init_net. Looks like a bug, here v2.6.24-2577-g752d14dc6aa9 root@zurg:~# sysctl net.ipv4.conf.all.forwarding=0 net.ipv6.conf.all.forwarding=0 net.ipv4.conf.all.forwarding = 0 net.ipv6.conf.all.forwarding = 0 root@zurg:~# unshare -n s

[patch net 1/2] mlxsw: Treat local port 64 as valid

2016-02-15 Thread Jiri Pirko
From: Ido Schimmel MLXSW_PORT_MAX_PORTS represents the maximum number of local ports, which is 65 for both ASICs (SwitchX-2 and Spectrum) supported by this driver. Fixes: 93c1edb27f9e ("mlxsw: Introduce Mellanox switch driver core") Signed-off-by: Ido Schimmel Signed-off-by: Jiri Pirko --- dr

[patch net 2/2] mlxsw: spectrum: Set STP state when leaving 802.1D bridge

2016-02-15 Thread Jiri Pirko
From: Ido Schimmel When a VLAN device leaves a bridge its STP state is set to DISABLED, which causes the hardware to discard any packets coming through the port with this VLAN. Fix that by setting STP state to FORWARDING when the device leaves its bridge and allow traffic to be directed to CPU.

[patch net 0/2] mlxsw fixes

2016-02-15 Thread Jiri Pirko
From: Jiri Pirko Just a couple of fixes from Ido. Ido Schimmel (2): mlxsw: Treat local port 64 as valid mlxsw: spectrum: Set STP state when leaving 802.1D bridge drivers/net/ethernet/mellanox/mlxsw/port.h | 2 +- drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 8 2 files chan

I have registered your CHECK WORTH of $3.5 MILLION USD

2016-02-15 Thread Ben Taylor
I have registered your CHECK WORTH of $3.5 MILLION USD(THREE MILLION,FIVE HUNDRED THOUSAND DOLLARS) with delivery agency. Please Contact them with your delivery information such as, Your Name---, Your Address---, ID CARD COPY---, and Your Telephone Number: Contact Person: Mr. Mike Uwaa: E-mail: (de

[PATCH] ravb: Update DT binding example for final CPG/MSSR bindings

2016-02-15 Thread Geert Uytterhoeven
The example in the DT binding documentation uses the preliminary DT bindings for the r8a7795 MSTP clocks, which never went upstream. Update the example to use the DT bindings for the upstream Clock Pulse Generator / Module Standby and Software Reset hardware block. Signed-off-by: Geert Uytterhoeve

[PATCH 0/7] fix IS_ERR_VALUE usage

2016-02-15 Thread Andrzej Hajda
Hi, This small set of independent patches tries to fix incorrect IS_ERR_VALUE macro usage. It fixes most usages leading to errors as described in [1]. It also follows conclusion from the discussion [1][2] - IS_ERR_VALUE should be used only with unsigned long type, signed types should use compariso

[PATCH ethtool 0/3] IPv6 RXNFC

2016-02-15 Thread Edward Cree
This series adds support for steering of IPv6 receive flows. Edward Cree (3): ethtool-copy.h: sync with net-next Add IPv6 support to NFC Documentation for IPv6 NFC ethtool-copy.h | 149 +-- ethtool.8.in | 34 ++-- ethtool.c | 25 +- rxclass.c

[PATCH ethtool 1/3] ethtool-copy.h: sync with net-next

2016-02-15 Thread Edward Cree
This covers kernel changes up to: commit 72bb68721f80a1441e871b6afc9ab0b3793d5031 Author: Edward Cree Date: Fri Feb 5 11:16:21 2016 + ethtool: add IPv6 to the NFC API Signed-off-by: Edward Cree --- ethtool-copy.h | 149 ++--- 1 fil

[PATCH ethtool 2/3] Add IPv6 support to NFC

2016-02-15 Thread Edward Cree
Signed-off-by: Edward Cree --- ethtool.c | 21 + rxclass.c | 272 ++ 2 files changed, 279 insertions(+), 14 deletions(-) diff --git a/ethtool.c b/ethtool.c index 92c40b8..f18ad73 100644 --- a/ethtool.c +++ b/ethtool.c @@ -32,6 +32,

[PATCH ethtool 3/3] Documentation for IPv6 NFC

2016-02-15 Thread Edward Cree
Leaves 'src-ip' and 'dst-ip' documented as taking x.x.x.x, because there's more low-level nroff here than I can parse, let alone emit. Signed-off-by: Edward Cree --- ethtool.8.in | 34 +- ethtool.c| 4 +++- 2 files changed, 28 insertions(+), 10 deletions(-)

sctp: bad hash index calculation

2016-02-15 Thread Dmitry Vyukov
Hello, While looking into some memory leaks of sctp ports I've noticed that sctp_init initializes port hash table as follows: /* Allocate and initialize the SCTP port hash table. */ do { sctp_port_hashsize = (1UL << order) * PAGE_SIZE / sizeof(struct sctp_bind

[PATCH net-next 3/3] ila: autoload module

2016-02-15 Thread Robert Shearman
Avoid users having to manually load the module by adding a module alias allowing it to be autoloaded by the lwt infra. Signed-off-by: Robert Shearman --- net/ipv6/ila/ila_common.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/ipv6/ila/ila_common.c b/net/ipv6/ila/ila_common.c index 32dc

[PATCH net-next 0/3] lwtunnel: autoload of lwt modules

2016-02-15 Thread Robert Shearman
The lwt implementations using net devices can autoload using the existing mechanism using IFLA_INFO_KIND. However, there's no mechanism that lwt modules not using net devices can use. Therefore, add the ability to autoload modules registering lwt operations for lwt implementations not using a net

[PATCH net-next 1/3] lwtunnel: autoload of lwt modules

2016-02-15 Thread Robert Shearman
The lwt implementations using net devices can autoload using the existing mechanism using IFLA_INFO_KIND. However, there's no mechanism that lwt modules not using net devices can use. Therefore, add the ability to autoload modules registering lwt operations for lwt implementations not using a net

[PATCH net-next 2/3] mpls: autoload lwt module

2016-02-15 Thread Robert Shearman
Avoid users having to manually load the module by adding a module alias allowing it to be autoloaded by the lwt infra. Signed-off-by: Robert Shearman --- net/mpls/mpls_iptunnel.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/mpls/mpls_iptunnel.c b/net/mpls/mpls_iptunnel.c index fb31aa8

Re: sctp: bad hash index calculation

2016-02-15 Thread Neil Horman
On Mon, Feb 15, 2016 at 04:11:22PM +0100, Dmitry Vyukov wrote: > Hello, > > While looking into some memory leaks of sctp ports I've noticed that > sctp_init initializes port hash table as follows: > > /* Allocate and initialize the SCTP port hash table. */ > do { > sctp_port_hash

Re: sctp: bad hash index calculation

2016-02-15 Thread Dmitry Vyukov
On Mon, Feb 15, 2016 at 4:50 PM, Neil Horman wrote: > On Mon, Feb 15, 2016 at 04:11:22PM +0100, Dmitry Vyukov wrote: >> Hello, >> >> While looking into some memory leaks of sctp ports I've noticed that >> sctp_init initializes port hash table as follows: >> >> /* Allocate and initialize the SC

Re: sctp: bad hash index calculation

2016-02-15 Thread Neil Horman
On Mon, Feb 15, 2016 at 04:56:01PM +0100, Dmitry Vyukov wrote: > On Mon, Feb 15, 2016 at 4:50 PM, Neil Horman wrote: > > On Mon, Feb 15, 2016 at 04:11:22PM +0100, Dmitry Vyukov wrote: > >> Hello, > >> > >> While looking into some memory leaks of sctp ports I've noticed that > >> sctp_init initiali

[PATCH net] pppoe: fix reference counting in PPPoE proxy

2016-02-15 Thread Guillaume Nault
Drop reference on the relay_po socket when __pppoe_xmit() succeeds. This is already handled correctly in the error path. Signed-off-by: Guillaume Nault --- No 'Fixes' tag, since this issue seems to predate git's history. drivers/net/ppp/pppoe.c | 2 ++ 1 file changed, 2 insertions(+) diff --gi

Re: [PATCH net-next 1/3] lwtunnel: autoload of lwt modules

2016-02-15 Thread Jiri Benc
On Mon, 15 Feb 2016 15:42:01 +, Robert Shearman wrote: > +static const char *lwtunnel_encap_str(enum lwtunnel_encap_types encap_type) > +{ > + switch (encap_type) { > + case LWTUNNEL_ENCAP_MPLS: > + return "LWTUNNEL_ENCAP_MPLS"; > + case LWTUNNEL_ENCAP_IP: > +

Re: [PATCH net-next 1/3] lwtunnel: autoload of lwt modules

2016-02-15 Thread Robert Shearman
On 15/02/16 16:02, Jiri Benc wrote: On Mon, 15 Feb 2016 15:42:01 +, Robert Shearman wrote: +static const char *lwtunnel_encap_str(enum lwtunnel_encap_types encap_type) +{ + switch (encap_type) { + case LWTUNNEL_ENCAP_MPLS: + return "LWTUNNEL_ENCAP_MPLS"; + cas

Re: [PATCH net-next 1/3] lwtunnel: autoload of lwt modules

2016-02-15 Thread Jiri Benc
On Mon, 15 Feb 2016 16:22:08 +, Robert Shearman wrote: > Yeah, it's the C preprocessor. MODULE_ALIAS_RTNL_LWT includes the string > for the encap type in the module alias, and since the LWT encap types > are defined as enums this is symbolic name. I can't see any way of > getting the preproc

Re: [PATCH 00/33] Compile-time stack metadata validation

2016-02-15 Thread Josh Poimboeuf
On Fri, Feb 12, 2016 at 09:10:11PM +0100, Peter Zijlstra wrote: > On Fri, Feb 12, 2016 at 12:32:06PM -0600, Josh Poimboeuf wrote: > > What I actually see in the listing is: > > > > decl__percpu_prefix:__preempt_count > > je 1f: > > > > 1: > > call___preempt_sched

Re: [PATCH net-next v2 2/2] vxlan: support GPE/NSH

2016-02-15 Thread Jiri Benc
On Thu, 11 Feb 2016 19:57:06 +, Brian Russell wrote: > +skip_l2: > skb_reset_network_header(skb); > + > /* In flow-based mode, GBP is carried in dst_metadata */ > - if (!(vs->flags & VXLAN_F_COLLECT_METADATA)) > + if (!(vs->flags & VXLAN_F_COLLECT_METADATA) && > + !(

Re: [PATCH 00/33] Compile-time stack metadata validation

2016-02-15 Thread Peter Zijlstra
On Mon, Feb 15, 2016 at 10:31:34AM -0600, Josh Poimboeuf wrote: > On Fri, Feb 12, 2016 at 09:10:11PM +0100, Peter Zijlstra wrote: > > On Fri, Feb 12, 2016 at 12:32:06PM -0600, Josh Poimboeuf wrote: > > > What I actually see in the listing is: > > > > > > decl__percpu_prefix:__preempt_count >

Re: [PATCH net-next v2 1/2] nsh: encapsulation module

2016-02-15 Thread Jiri Benc
On Thu, 11 Feb 2016 19:57:05 +, Brian Russell wrote: > --- /dev/null > +++ b/net/ipv4/nsh.c > @@ -0,0 +1,365 @@ > +/* > + * Network Service Header (NSH) inserted onto encapsulated packets > + * or frames to realize service function paths. > + * NSH also provides a mechanism for metadata exchang

[PATCH] phy: marvell: Fix and unify reg-init behavior

2016-02-15 Thread Clemens Gruber
For the Marvell 88E1510, marvell_of_reg_init was called too late (in m88e1510_config_aneg), which lead to the phy state machine being stuck at waiting for interrupts, which are off by default on the 88E1510. This further lead to the ethernet link not coming up at boot. For some Marvell PHYs, marvel

Re: [PATCH net-next 1/3] lwtunnel: autoload of lwt modules

2016-02-15 Thread Robert Shearman
On 15/02/16 16:32, Jiri Benc wrote: On Mon, 15 Feb 2016 16:22:08 +, Robert Shearman wrote: Yeah, it's the C preprocessor. MODULE_ALIAS_RTNL_LWT includes the string for the encap type in the module alias, and since the LWT encap types are defined as enums this is symbolic name. I can't see an

Re: [PATCH] netfilter: tee: select NF_DUP_IPV6 unconditionally

2016-02-15 Thread Pablo Neira Ayuso
On Fri, Feb 05, 2016 at 10:20:21AM +0100, Arnd Bergmann wrote: > The NETFILTER_XT_TARGET_TEE option selects NF_DUP_IPV6 whenever > IP6_NF_IPTABLES is enabled, and it ensures that it cannot be > builtin itself if NF_CONNTRACK is a loadable module, as that > is a dependency for NF_DUP_IPV6. > > Howe

Re: Same data to several sockets with just one syscall ?

2016-02-15 Thread Eric Dumazet
On Mon, 2016-02-15 at 11:03 +0100, Claudio Scordino wrote: > Hi Eric, > > 2016-02-12 11:35 GMT+01:00 Eric Dumazet : > > On Fri, 2016-02-12 at 09:53 +0100, Claudio Scordino wrote: > > > >> This makes the application waste time in entering/exiting the kernel > >> level several times. > > > > syscall

Re: [PATCH] net: bcmgenet: Add MDIO_INTR in GENETv2

2016-02-15 Thread Florian Fainelli
Hi Jaedon, On 15/02/2016 00:42, Jaedon Shin wrote: > The GENETv2 chipsets has MDIO interrupt like the GENETv3+ chipsets. > > The previous commit d5c3d84657db ("net: phy: Avoid polling PHY with > PHY_IGNORE_INTERRUPTS") and commit 49f7a471e4d1 ("net: bcmgenet: Properly > configure PHY to ignore in

Re: [PATCH] phy: marvell: Fix and unify reg-init behavior

2016-02-15 Thread Florian Fainelli
On 15/02/2016 09:52, Clemens Gruber wrote: > For the Marvell 88E1510, marvell_of_reg_init was called too late (in > m88e1510_config_aneg), which lead to the phy state machine being stuck > at waiting for interrupts, which are off by default on the 88E1510. > This further lead to the ethernet link n

Re: [PATCH] phy: marvell: Fix and unify reg-init behavior

2016-02-15 Thread Florian Fainelli
On 15/02/2016 10:19, Florian Fainelli wrote: > On 15/02/2016 09:52, Clemens Gruber wrote: >> For the Marvell 88E1510, marvell_of_reg_init was called too late (in >> m88e1510_config_aneg), which lead to the phy state machine being stuck >> at waiting for interrupts, which are off by default on the

Re: [PATCH] netfilter: nft_counter: fix erroneous return values

2016-02-15 Thread Pablo Neira Ayuso
On Sat, Feb 06, 2016 at 11:31:19PM -0500, Anton Protopopov wrote: > The nft_counter_init() and nft_counter_clone() functions should return > negative error value -ENOMEM instead of positive ENOMEM. Applied, thanks.

Re: [PATCH net-next] core: remove unneded headers for net cgroup controllers.

2016-02-15 Thread Tejun Heo
On Mon, Feb 15, 2016 at 02:39:43AM +0200, Rami Rosen wrote: > commit 3ed80a6 (cgroup: drop module support) made including > module.h redundant in the net cgroup controllers, > netclassid_cgroup.c and netprio_cgroup.c. This patch > removes them. > > Signed-off-by: Rami Rosen Acked-by: Tejun He

[PATCH] af_llc: fix types on llc_ui_wait_for_conn

2016-02-15 Thread Alan
The timeout is a long, we return it truncated if it is huge. Basically harmless as the only caller does a boolean check, but tidy it up anyway. Signed-off-by: Alan Cox --- net/llc/af_llc.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/llc/af_llc.c b/net/llc/af_llc.c

Re: [PATCH] af_llc: fix types on llc_ui_wait_for_conn

2016-02-15 Thread kbuild test robot
Hi Alan, [auto build test ERROR on net-next/master] [also build test ERROR on v4.5-rc4 next-20160215] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/Alan/af_llc-fix-types-on

Re: [PATCH nf] netfilter: nfnetlink: correctly validate length of batch messages

2016-02-15 Thread Pablo Neira Ayuso
On Tue, Feb 02, 2016 at 01:36:45PM -0500, phil.turnb...@oracle.com wrote: > From: Phil Turnbull > > If nlh->nlmsg_len is zero then an infinite loop is triggered because > 'skb_pull(skb, msglen);' pulls zero bytes. > > The calculation in nlmsg_len() underflows if 'nlh->nlmsg_len < > NLMSG_HDRLEN'

[PATCHv2] af_llc: fix types on llc_ui_wait_for_conn

2016-02-15 Thread Alan
The timeout is a long, we return it truncated if it is huge. Basically harmless as the only caller does a boolean check, but tidy it up anyway. (64bit build tested this time. Thank you 0day) Signed-off-by: Alan Cox --- net/llc/af_llc.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-

[net-next PATCH 1/1] net_sched fix: reclassification needs to consider ether protocol changes

2016-02-15 Thread Jamal Hadi Salim
From: Jamal Hadi Salim actions could change the etherproto in particular with ethernet tunnelled data. Typically such actions, after peeling the outer header, will ask for the packet to be reclassified. We then need to restart the classification with the new proto header. Example setup used to

Re: [PATCH V6] netfilter: h323: avoid potential attack

2016-02-15 Thread Pablo Neira Ayuso
On Tue, Feb 02, 2016 at 09:40:04PM +0800, Zhouyi Zhou wrote: > diff --git a/net/netfilter/nf_conntrack_h323_main.c > b/net/netfilter/nf_conntrack_h323_main.c > index 9511af0..8d24c4b 100644 > --- a/net/netfilter/nf_conntrack_h323_main.c > +++ b/net/netfilter/nf_conntrack_h323_main.c > @@ -110,6 +1

[PATCH v2] phy: marvell: Fix and unify reg-init behavior

2016-02-15 Thread Clemens Gruber
For the Marvell 88E1510, marvell_of_reg_init was called too late, in the config_aneg function. Since commit 113c74d83eef ("net: phy: turn carrier off on phy attach"), this lead to the link not coming up at boot anymore, due to the phy state machine being stuck at waiting for interrupts (off by defa

Re: [PATCH 00/33] Compile-time stack metadata validation

2016-02-15 Thread Andi Kleen
> > There are two ways to fix the warnings: > > > > 1. get rid of the thunks and call the C functions directly; or > > No. Not until gcc learns about per-function callibg conventions (so that it > can > be marked as not clobbering registers). It does already for static functions in 5.x (with -fi

Re: [PATCH 00/33] Compile-time stack metadata validation

2016-02-15 Thread Josh Poimboeuf
On Mon, Feb 15, 2016 at 08:56:21AM -0800, Linus Torvalds wrote: > On Feb 15, 2016 8:31 AM, "Josh Poimboeuf" wrote: > > > > So is the goal to optimize for size? If I replace the calls to > > __preempt_schedule[_notrace]() with real C calls and remove the thunks, > > it only adds about 2k to vmlinu

Re: [net-next PATCH 1/1] net_sched fix: reclassification needs to consider ether protocol changes

2016-02-15 Thread kbuild test robot
Hi Jamal, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Jamal-Hadi-Salim/net_sched-fix-reclassification-needs-to-consider-ether-protocol-changes/20160216-035147 config: i386-randconfig-x008-201607 (attached as .config) reproduce: # save the a

Re: [PATCH net] ipv4: fix memory leaks in ip_cmsg_send() callers

2016-02-15 Thread Cong Wang
On Thu, Feb 4, 2016 at 6:23 AM, Eric Dumazet wrote: > From: Eric Dumazet > > Dmitry reported memory leaks of IP options allocated in > ip_cmsg_send() when/if this function returns an error. > > Callers are responsible for the freeing. Right, because there is a loop in ip_cmsg_send(), so the call

Re: [PATCH] phy: marvell: Fix and unify reg-init behavior

2016-02-15 Thread Clemens Gruber
Hi Florian, On Mon, Feb 15, 2016 at 10:22:14AM -0800, Florian Fainelli wrote: > > > On 15/02/2016 10:19, Florian Fainelli wrote: > > On 15/02/2016 09:52, Clemens Gruber wrote: > >> For the Marvell 88E1510, marvell_of_reg_init was called too late (in > >> m88e1510_config_aneg), which lead to the

Re: [PATCH v2] phy: marvell: Fix and unify reg-init behavior

2016-02-15 Thread Fabio Estevam
On Mon, Feb 15, 2016 at 6:01 PM, Clemens Gruber wrote: > +static int marvell_config_init(struct phy_device *phydev) > +{ > + int err; > + > + /* Set registers from marvell,reg-init DT property */ > + err = marvell_of_reg_init(phydev); > + if (err < 0) > + ret

Re: [net-next PATCH 1/1] net_sched fix: reclassification needs to consider ether protocol changes

2016-02-15 Thread Daniel Borkmann
On 02/15/2016 08:49 PM, Jamal Hadi Salim wrote: From: Jamal Hadi Salim actions could change the etherproto in particular with ethernet tunnelled data. Typically such actions, after peeling the outer header, will ask for the packet to be reclassified. We then need to restart the classification

[PATCH net-next 0/3] Remove the inet_lro library

2016-02-15 Thread Ben Hutchings
The old inet_lro library has been deprecated ever since GRO was introduced, but there are still a few drivers using it. Convert them to GRO and remove it. Ben. Ben Hutchings (3): pasemi_mac: Replace LRO with GRO RDMA/nes: Replace LRO with GRO ipv4: Remove inet_lro library drivers/infinib

[PATCH net-next 1/3] pasemi_mac: Replace LRO with GRO

2016-02-15 Thread Ben Hutchings
GRO is simpler to use than the old inet_lro library, and is compatible with forwarding and bridging configurations. Compile-tested only. Signed-off-by: Ben Hutchings --- drivers/net/ethernet/pasemi/Kconfig | 5 +-- drivers/net/ethernet/pasemi/pasemi_mac.c | 50 +---

[PATCH net-next 2/3] RDMA/nes: Replace LRO with GRO

2016-02-15 Thread Ben Hutchings
GRO is simpler to use than the old inet_lro library, and is compatible with forwarding and bridging configurations. Compile-tested only. Signed-off-by: Ben Hutchings --- drivers/infiniband/hw/nes/Kconfig | 1 - drivers/infiniband/hw/nes/nes_hw.c | 44 + d

[PATCH net-next 3/3] ipv4: Remove inet_lro library

2016-02-15 Thread Ben Hutchings
There are no longer any in-tree drivers that use it. Signed-off-by: Ben Hutchings --- include/linux/inet_lro.h | 142 -- net/ipv4/Kconfig | 8 - net/ipv4/Makefile| 1 - net/ipv4/inet_lro.c | 374 --- 4 files cha

Re: IPv4/IPv6 sysctl defaults in new namespace

2016-02-15 Thread Eric W. Biederman
Konstantin Khlebnikov writes: > IPv6 initialized with default. That's ok. > IPv4 makes a copy from init_net. Looks like a bug, here > v2.6.24-2577-g752d14dc6aa9 > > root@zurg:~# sysctl net.ipv4.conf.all.forwarding=0 > net.ipv6.conf.all.forwarding=0 > net.ipv4.conf.all.forwarding = 0 > net.ipv6.co

Re: [PATCH net-next 1/3] lwtunnel: autoload of lwt modules

2016-02-15 Thread Eric W. Biederman
Robert Shearman writes: > The lwt implementations using net devices can autoload using the > existing mechanism using IFLA_INFO_KIND. However, there's no mechanism > that lwt modules not using net devices can use. > > Therefore, add the ability to autoload modules registering lwt > operations for

Re: [PATCH v2] phy: marvell: Fix and unify reg-init behavior

2016-02-15 Thread Clemens Gruber
Hi Fabio, On Mon, Feb 15, 2016 at 06:54:29PM -0200, Fabio Estevam wrote: > On Mon, Feb 15, 2016 at 6:01 PM, Clemens Gruber > wrote: > > > +static int marvell_config_init(struct phy_device *phydev) > > +{ > > + int err; > > + > > + /* Set registers from marvell,reg-init DT property */

[PATCH v3] phy: marvell: Fix and unify reg-init behavior

2016-02-15 Thread Clemens Gruber
For the Marvell 88E1510, marvell_of_reg_init was called too late, in the config_aneg function. Since commit 113c74d83eef ("net: phy: turn carrier off on phy attach"), this lead to the link not coming up at boot anymore, due to the phy state machine being stuck at waiting for interrupts (off by defa

[PATCH] net-sysfs: remove unused fmt_long_hex

2016-02-15 Thread Colin King
From: Colin Ian King Ever since commit 04ed3e741d0f133e02bed7fa5c98edba128f90e7 ("net: change netdev->features to u32") the format string fmt_long_hex has not been used, so we may as well remove it. Signed-off-by: Colin Ian King --- net/core/net-sysfs.c | 1 - 1 file changed, 1 deletion(-) di

Re: [PATCH 1/2] ravb: kill useless *switch* defaults

2016-02-15 Thread Simon Horman
On Sun, Feb 14, 2016 at 10:56:03PM +0300, Sergei Shtylyov wrote: > The driver has the *default* case doing nothing in the *switch* statement > with an integer expression -- remove it. > > Signed-off-by: Sergei Shtylyov Reviewed-by: Simon Horman

Re: [PATCH 2/2] sh_eth: kill useless *switch* defaults

2016-02-15 Thread Simon Horman
On Sun, Feb 14, 2016 at 10:56:33PM +0300, Sergei Shtylyov wrote: > The driver often has the *default* cases doing nothing in the *switch* > statements with the integer expressions -- remove them. > > Signed-off-by: Sergei Shtylyov Reviewed-by: Simon Horman

Re: [PATCH] ravb: Update DT binding example for final CPG/MSSR bindings

2016-02-15 Thread Simon Horman
On Mon, Feb 15, 2016 at 01:41:31PM +0100, Geert Uytterhoeven wrote: > The example in the DT binding documentation uses the preliminary DT > bindings for the r8a7795 MSTP clocks, which never went upstream. > Update the example to use the DT bindings for the upstream Clock Pulse > Generator / Module

Re: [net-next PATCH 06/11] RFC: mlx5: RX bulking or bundling of packets before calling network stack

2016-02-15 Thread Saeed Mahameed
On Wed, Feb 10, 2016 at 10:26 PM, Jesper Dangaard Brouer wrote: > On Tue, 9 Feb 2016 13:57:41 +0200 > Saeed Mahameed wrote: > >> On Tue, Feb 2, 2016 at 11:13 PM, Jesper Dangaard Brouer >> wrote: >> > There are several techniques/concepts combined in this optimization. >> > It is both a data-cach

[PATCH net-next] net: macb: make magic-packet property generic

2016-02-15 Thread Sergio Prado
Signed-off-by: Sergio Prado --- As requested by Rob Herring on patch https://patchwork.ozlabs.org/patch/580862/ --- Documentation/devicetree/bindings/net/macb.txt | 2 +- drivers/net/ethernet/cadence/macb.c| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Document

[PATCH v2] gre: Avoid kernel panic by clearing IPCB before dst_link_failure called

2016-02-15 Thread Bernie Harris
skb->cb may contain data from previous layers (in the observed case the qdisc layer). In the observed scenario, the data was misinterpreted as ip header options, which later caused the ihl to be set to an invalid value (<5). This resulted in an infinite loop in the mips implementation of ip_fast_cs

[PATCH] et131x: check return value of dma_alloc_coherent

2016-02-15 Thread Insu Yun
For error handling, dma_alloc_coherent's return value needs to be checked, not argument. Signed-off-by: Insu Yun --- drivers/net/ethernet/agere/et131x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/agere/et131x.c b/drivers/net/ethernet/agere/et131x.c

[PATCH] tcp: correctly crypto_alloc_hash return check

2016-02-15 Thread Insu Yun
crypto_alloc_hash never returns NULL Signed-off-by: Insu Yun --- net/ipv4/tcp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c index fd17eec..a95aac1 100644 --- a/net/ipv4/tcp.c +++ b/net/ipv4/tcp.c @@ -2946,7 +2946,7 @@ static void __tcp_allo

Re: [PATCHv2] af_llc: fix types on llc_ui_wait_for_conn

2016-02-15 Thread Simon Horman
On Mon, Feb 15, 2016 at 07:41:51PM +, Alan wrote: > The timeout is a long, we return it truncated if it is huge. Basically > harmless as the only caller does a boolean check, but tidy it up anyway. If the only caller performs a boolean check then perhaps it would be best if the function's retu

Re: [PATCH] net: bcmgenet: Add MDIO_INTR in GENETv2

2016-02-15 Thread Jaedon Shin
Hi Florian, > On Feb 16, 2016, at 3:18 AM, Florian Fainelli wrote: > > Hi Jaedon, > > On 15/02/2016 00:42, Jaedon Shin wrote: >> The GENETv2 chipsets has MDIO interrupt like the GENETv3+ chipsets. >> >> The previous commit d5c3d84657db ("net: phy: Avoid polling PHY with >> PHY_IGNORE_INTERRUPT

[net-next 01/14] igb: Remove unnecessary flag setting in igb_set_flag_queue_pairs()

2016-02-15 Thread Jeff Kirsher
From: Shota Suzuki If VFs are enabled (max_vfs >= 1), both max_rss_queues and adapter->rss_queues are set to 2 in the case of e1000_82576. In this case, IGB_FLAG_QUEUE_PAIRS is always set in the default block as a result of fall-through, thus setting it in the e1000_82576 block is not necessary.

[net-next 02/14] igb: Unpair the queues when changing the number of queues

2016-02-15 Thread Jeff Kirsher
From: Shota Suzuki By the commit 72ddef0506da ("igb: Fix oops caused by missing queue pairing"), the IGB_FLAG_QUEUE_PAIRS flag can now be set when changing the number of queues by "ethtool -L", but it is never cleared unless the igb driver is reloaded. This patch clears it if queue pairing become

[net-next 12/14] igb: Drop unnecessary checks in transmit path

2016-02-15 Thread Jeff Kirsher
From: Alexander Duyck This patch drops several checks that we dropped from ixgbe some ago. It should not be possible for us to be called with either of the conditional statements returning true so we can just drop them from the hot-path. Signed-off-by: Alexander Duyck Tested-by: Aaron Brown S

[net-next 07/14] igb: Do not factor VLANs into RLPML calculation

2016-02-15 Thread Jeff Kirsher
From: Alexander Duyck The RLPML registers already take the size of VLAN headers into account when determining the maximum packet length. This is called out in EAS documents for several parts including the 82576 and the i350. As such we can drop the addition of size to the value programmed into

[net-next 14/14] igb: Add workaround for VLAN tag stripping on 82576

2016-02-15 Thread Jeff Kirsher
From: Alexander Duyck There was a workaround partially implemented for the 82576 that is needed in order for VLAN tag stripping to function correctly. The original code had side effects that would make it so the workaround was active on all MACs. I have updated the code so that the workaround i

[net-next 11/14] igb: Add support for VLAN promiscuous with SR-IOV and NTUPLE

2016-02-15 Thread Jeff Kirsher
From: Alexander Duyck This change fixes things so that we can fully support SR-IOV or the recently added NTUPLE filtering while allowing support for VLAN promiscuous mode. By making this change we are able to support possible scenarios such as SR-IOV with the PF connected to a Linux bridge hosti

[net-next 08/14] igb: Always enable VLAN 0 even if 8021q is not loaded

2016-02-15 Thread Jeff Kirsher
From: Alexander Duyck This patch makes it so that we always add VLAN 0. This is important as we need to guarantee the PF can receive untagged frames in the case of SR-IOV being enabled but VLAN filtering not being enabled in the kernel. Signed-off-by: Alexander Duyck Tested-by: Aaron Brown Si

[net-next 04/14] igb: clean up code for setting MAC address

2016-02-15 Thread Jeff Kirsher
From: Alexander Duyck Drop a bunch of hand written byte swapping code in favor of just doing the byte swapping ourselves. The registers are little endian registers storing a big endian value so if we read the MAC address array as little endian then we will get the CPU registers into the proper l

[net-next 00/14][pull request] 1GbE Intel Wired LAN Driver Updates 2016-02-15

2016-02-15 Thread Jeff Kirsher
This series contains updates to igb only. Shota Suzuki cleans up unnecessary flag setting for 82576 in igb_set_flag_queue_pairs() since the default block already sets IGB_FLAG_QUEUE_PAIRS to the correct value anyways, so the e1000_82576 code block is not necessary and we can simply fall through.

[net-next 09/14] igb: Merge VLVF configuration into igb_vfta_set

2016-02-15 Thread Jeff Kirsher
From: Alexander Duyck This change makes it so that we can merge the configuration of the VLVF registers into the setting of the VFTA register. By doing this we simplify the logic and make use of similar functionality that we have already added for ixgbe making it easier to maintain both drivers.

[net-next 13/14] igb: Enable use of "bridge fdb add" to set unicast table entries

2016-02-15 Thread Jeff Kirsher
From: Alexander Duyck This change makes it so that we can use the bridge utility to add a FDB entry for the PF to an igb port. By doing this we can enable the VFs to talk to virtual ports residing on top of the PF. In addition this should also address issues with MACVLANs trying to reside on to

[net-next 03/14] igb/igbvf: don't give up

2016-02-15 Thread Jeff Kirsher
From: Mitch Williams The driver shouldn't just give up if it fails to get the hardware mailbox lock. This can happen in a situation where the PF-VF communication channel is heavily loaded and causes complete communications failure between the PF and VF drivers. Add a counter and a delay. The dri

[net-next 05/14] igb: Refactor VFTA configuration

2016-02-15 Thread Jeff Kirsher
From: Alexander Duyck This patch starts the clean-up process on the VFTA configuration. Specifically in this patch I attempt to address and simplify several items while also updating the code to bring it more inline with what is already in ixgbe. Signed-off-by: Alexander Duyck Tested-by: Aaron

[net-next 06/14] igb: Allow asymmetric configuration of MTU versus Rx frame size

2016-02-15 Thread Jeff Kirsher
From: Alexander Duyck Since the igb driver is using page based receive there is no point in limiting the Rx capabilities of the device. The driver can receive 9K jumbo frames at all times. The only changes needed due to MTU changes are updates for the FIFO sizes and flow-control watermarks. Up

  1   2   >