Re: [RFC/RFT] mac80211: implement fq_codel for software queuing

2016-03-01 Thread Michal Kazior
On 1 March 2016 at 15:02, Johannes Berg wrote: > On Fri, 2016-02-26 at 14:09 +0100, Michal Kazior wrote: >> >> +typedef u64 codel_time_t; > > Do we really need this? And if yes, does it have to be in the public > header file? Why a typedef anyway? Hmm.. I don't think

Re: [PATCH 2/2] net: ethernet: renesas: sh_eth: don't open code of_device_get_match_data()

2016-03-01 Thread Wolfram Sang
On Wed, Mar 02, 2016 at 10:21:34AM +0900, Simon Horman wrote: > On Tue, Mar 01, 2016 at 05:37:59PM +0100, Wolfram Sang wrote: > > From: Wolfram Sang > > > > This change will also make Coverity happy by avoiding a theoretical NULL > > pointer dereference; yet

Re: [PATCH RFC] net: Fix race condition when removing qdisc

2016-03-01 Thread Cong Wang
On Tue, Mar 1, 2016 at 3:16 PM, Tom Herbert wrote: > We are seeing a number of softlockups occurring with HTB upon removing > the qdisc. We are still attempting to repro the exact circumstances, > however looking at the code I'm very suspicious of this block in >

Re: [PATCH 2/4] net: can: ifi: Fix TX DLC configuration

2016-03-01 Thread Oliver Hartkopp
On 03/01/2016 10:27 PM, Marek Vasut wrote: > On 03/01/2016 07:11 PM, Oliver Hartkopp wrote: > > Hi! > >> On 02/29/2016 08:59 PM, Marek Vasut wrote: >>> The TX DLC, the transmission length information, was not written >>> into the transmit configuration register. When using the CAN core >>>

Re: [PATCH 3/4] net: can: ifi: Fix RX and TX ID mask

2016-03-01 Thread Oliver Hartkopp
Hi Marek, On 03/01/2016 10:23 PM, Marek Vasut wrote: > On 03/01/2016 06:49 PM, Oliver Hartkopp wrote: >>> -#define IFI_CANFD_RXFIFO_ID_ID_STD_MASK0x3ff >>> +#define IFI_CANFD_RXFIFO_ID_ID_STD_MASK0x7ff >>> #define IFI_CANFD_RXFIFO_ID_ID_XTD_MASK0x1fff >>

Re: [PATCH v3] net: jme: fix suspend/resume on JMC260

2016-03-01 Thread Guo-Fu Tseng
On Wed, 24 Feb 2016 23:58:56 -0500 (EST), David Miller wrote > From: Diego Viola > Date: Tue, 23 Feb 2016 12:04:04 -0300 > > > The JMC260 network card fails to suspend/resume because the call to > > jme_start_irq() was too early, moving the call to jme_start_irq() after >

Re: Computer fails to resume from suspend unless I rmmod jme before initiating the suspend

2016-03-01 Thread Guo-Fu Tseng
Dear Diego and who concerns about this driver: Thanks for reporting it. I can still provide some help, but it's just I'm quite busy. So that you have not seem me sending patch for a long time. I wrote this driver when I wan an intern in JMicron during one of my summer vacation while I'm still

net_sched: dsmark: use qdisc_dequeue_peeked()

2016-03-01 Thread Kyeong Yoo
This fix is for dsmark similar to 3557619f0f6f7496ed453d4825e24958ab1884e0, and makes use of qdisc_dequeue_peeked() instead of direct dequeue() call. First time, wrr peeks dsmark, which will then peek into sfq. sfq dequeues an skb and it's stored in sch->gso_skb. Next time, wrr tries to dequeue

Re: [Intel-wired-lan] [next] igb: allow setting MAC address on i211 using a device tree blob V5

2016-03-01 Thread John Holland
> On 02.03.2016, at 00:55, Jeff Kirsher wrote: > >> On Tue, 2016-03-01 at 07:56 +0100, John Holland wrote: >> On Mar 1, 2016, at 03:52, Brown, Aaron F >> wrote: >> >>> This throws a few checkpatch warnings, but I won't withhold my >>

RE: [Intel-wired-lan] [net-next PATCH] net: relax setup_tc ndo op handle restriction

2016-03-01 Thread Allan, Bruce W
> -Original Message- > From: Intel-wired-lan [mailto:intel-wired-lan-boun...@lists.osuosl.org] On > Behalf Of John Fastabend > Sent: Monday, February 29, 2016 11:26 AM > To: intel-wired-...@lists.osuosl.org; john.fastab...@gmail.com; Kirsher, > Jeffrey T > Cc: netdev@vger.kernel.org >

Re: [PATCH v2] ethtool: check size of user memory before copying strings and stats

2016-03-01 Thread Keller, Jacob E
On Tue, 2016-03-01 at 15:05 -0800, Alexander Duyck wrote: > On Tue, Mar 1, 2016 at 2:58 PM, Keller, Jacob E > wrote: > > > > On Tue, 2016-03-01 at 14:31 -0800, Alexander Duyck wrote: > > > > > > This still has the potential to provide garbage data.  What you > > >

Re: [PATCH net-next] net: ipv6/l3mdev: Move host route on saved address if necessary

2016-03-01 Thread David Ahern
On 3/1/16 2:23 PM, David Miller wrote: From: David Ahern Date: Sat, 27 Feb 2016 09:59:17 -0800 Commit f1705ec197e70 allows IPv6 addresses to be retained on a link down. The address can have a cached host route which can point to the wrong FIB table if the L3

CISCO AND AVAYA IP Phones

2016-03-01 Thread Laison Computech Inc
Hi, Clean tested working pulls CPUs and QTYs in stock. 115 X X5650 65 X E5410 75 X X5660 145 X E5530 100 X E5645 40 X X5680 75 X X5690 Brand new sealed IP phones and QTYs in stock. 55 x CP-7937G 77 x CP-7942G 54 x CP-7945G 75 x CP-7962G .. 45 x Avaya 9630 65 x Avaya 9641 55 x Avaya 9640

[PATCH net] vxlan: fix missing options_len update on RX with collect metadata

2016-03-01 Thread Daniel Borkmann
When signalling to metadata consumers that the metadata_dst entry carries additional GBP extension data for vxlan (TUNNEL_VXLAN_OPT), the dst's vxlan_metadata information is populated, but options_len is left to zero. F.e. in ovs, ovs_flow_key_extract() checks for options_len before extracting the

[PATCH net-next] sh_eth, ravb: Use ARCH_RENESAS

2016-03-01 Thread Simon Horman
Make use of ARCH_RENESAS in place of ARCH_SHMOBILE. This is part of an ongoing process to migrate from ARCH_SHMOBILE to ARCH_RENESAS the motivation for which being that RENESAS seems to be a more appropriate name than SHMOBILE for the majority of Renesas ARM based SoCs. Signed-off-by: Simon

Re: [PATCH 2/2] net: ethernet: renesas: sh_eth: don't open code of_device_get_match_data()

2016-03-01 Thread Simon Horman
On Tue, Mar 01, 2016 at 05:37:59PM +0100, Wolfram Sang wrote: > From: Wolfram Sang > > This change will also make Coverity happy by avoiding a theoretical NULL > pointer dereference; yet another reason is to use the above helper function > to tighten the code

Re: [Intel-wired-lan] [next] igb: allow setting MAC address on i211 using a device tree blob V5

2016-03-01 Thread Jeff Kirsher
On Tue, 2016-03-01 at 07:56 +0100, John Holland wrote: > On Mar 1, 2016, at 03:52, Brown, Aaron F > wrote: > > > This throws a few checkpatch warnings, but I won't withhold my > tested by for these: > >  > > total: 0 errors, 2 warnings, 0 checks, 21 lines checked > >  >

Re: [PATCH 1/2] net: ethernet: renesas: ravb_main: don't open code of_device_get_match_data()

2016-03-01 Thread Simon Horman
On Tue, Mar 01, 2016 at 05:37:58PM +0100, Wolfram Sang wrote: > From: Wolfram Sang > > This change will also make Coverity happy by avoiding a theoretical NULL > pointer dereference; yet another reason is to use the above helper function > to tighten the code

Re: [PATCH v2] ethtool: check size of user memory before copying strings and stats

2016-03-01 Thread Keller, Jacob E
On Wed, 2016-03-02 at 00:12 +, Ben Hutchings wrote: > NAK, ethtool is not the only consumer of the ethtool API.  How many > times do I have to repeat myself? > > Ben. > Ok, so essentially forcing drivers to require static sets for the various stats/strings/etc? :( Will have patches to

Re: [PATCH RFC] net: Fix race condition when removing qdisc

2016-03-01 Thread Eric Dumazet
On mar., 2016-03-01 at 15:16 -0800, Tom Herbert wrote: > We are seeing a number of softlockups occurring with HTB upon removing > the qdisc. We are still attempting to repro the exact circumstances, > however looking at the code I'm very suspicious of this block in > net_tx_action and its

Re: [PATCH 2/2] arm64: dts: r8a7795: Add CAN support

2016-03-01 Thread Simon Horman
On Mon, Feb 29, 2016 at 09:21:01AM +, Ramesh Shanmugasundaram wrote: > Adds CAN controller nodes for r8a7795. > > Note: CAN channel register base address mentioned in R-Car Gen3 Hardware > User Manual v0.5E is incorrect. The corrected base addresses are: > > CAN Channel 0 - 0xe6c3 > CAN

Re: [PATCH v2] ethtool: check size of user memory before copying strings and stats

2016-03-01 Thread Ben Hutchings
On Tue, 2016-03-01 at 14:25 -0800, Jacob Keller wrote: > Since at least 2005, (oldest commit in ethtool.git), the userspace > ethtool implementation has given the size of the memory it has allocated > as the actual size in the ethtool data structures. We previously blindly > ignore this and

Re: Sending short raw packets using sendmsg() broke

2016-03-01 Thread Alan Cox
> More thorough validation of the header contents is not necessarily > hard. The following validates the address, including optional > repeaters. > > static bool ax25_validate_hard_header(const char *ll_header, >unsigned short len) > { >

Re: Sending short raw packets using sendmsg() broke

2016-03-01 Thread Alan Cox
On Fri, 2016-02-26 at 12:33 -0500, Willem de Bruijn wrote: > On Fri, Feb 26, 2016 at 9:44 AM, Alan Cox > wrote: > > On Thu, 2016-02-25 at 15:26 -0500, David Miller wrote: > > > From: Heikki Hannikainen > > > Date: Thu, 25 Feb 2016 21:36:07 +0200 (EET) > >

[net-next][PATCH v3 05/13] RDS: IB: Re-organise ibmr code

2016-03-01 Thread Santosh Shilimkar
No functional changes. This is in preperation towards adding fastreg memory resgitration support. Signed-off-by: Santosh Shilimkar Signed-off-by: Santosh Shilimkar --- net/rds/Makefile | 2 +- net/rds/ib.c | 37 +++--- net/rds/ib.h

[net-next][PATCH v3 12/13] RDS: IB: allocate extra space on queues for FRMR support

2016-03-01 Thread Santosh Shilimkar
Fastreg MR(FRMR) memory registration and invalidation makes use of work request and completion queues for its operation. Patch allocates extra queue space towards these operation(s). Signed-off-by: Santosh Shilimkar Signed-off-by: Santosh Shilimkar

[net-next][PATCH v3 01/13] RDS: Drop stale iWARP RDMA transport

2016-03-01 Thread Santosh Shilimkar
RDS iWarp support code has become stale and non testable. As indicated earlier, am dropping the support for it. If new iWarp user(s) shows up in future, we can adapat the RDS IB transprt for the special RDMA READ sink case. iWarp needs an MR for the RDMA READ sink. Signed-off-by: Santosh

[net-next][PATCH v3 04/13] RDS: IB: Remove the RDS_IB_SEND_OP dependency

2016-03-01 Thread Santosh Shilimkar
This helps to combine asynchronous fastreg MR completion handler with send completion handler. No functional change. Signed-off-by: Santosh Shilimkar Signed-off-by: Santosh Shilimkar --- net/rds/ib.h | 1 - net/rds/ib_cm.c | 42

[net-next][PATCH v3 07/13] RDS: IB: move FMR code to its own file

2016-03-01 Thread Santosh Shilimkar
No functional change. Signed-off-by: Santosh Shilimkar Signed-off-by: Santosh Shilimkar --- net/rds/ib_fmr.c | 126 +- net/rds/ib_mr.h | 6 +++ net/rds/ib_rdma.c | 108

[net-next][PATCH v3 10/13] RDS: IB: add mr reused stats

2016-03-01 Thread Santosh Shilimkar
Add MR reuse statistics to RDS IB transport. Signed-off-by: Santosh Shilimkar Signed-off-by: Santosh Shilimkar --- net/rds/ib.h | 2 ++ net/rds/ib_rdma.c | 7 ++- net/rds/ib_stats.c | 2 ++ 3 files changed, 10 insertions(+), 1

[net-next][PATCH v3 06/13] RDS: IB: create struct rds_ib_fmr

2016-03-01 Thread Santosh Shilimkar
Keep fmr related filed in its own struct. Fastreg MR structure will be added to the union. Signed-off-by: Santosh Shilimkar Signed-off-by: Santosh Shilimkar --- net/rds/ib_fmr.c | 17 ++--- net/rds/ib_mr.h | 11 +--

[net-next][PATCH v3 09/13] RDS: IB: handle the RDMA CM time wait event

2016-03-01 Thread Santosh Shilimkar
Drop the RDS connection on RDMA_CM_EVENT_TIMEWAIT_EXIT so that it can reconnect and resume. While testing fastreg, this error happened in couple of tests but was getting un-noticed. Signed-off-by: Santosh Shilimkar Signed-off-by: Santosh Shilimkar

RE: [Intel-wired-lan] [next] igb: allow setting MAC address on i211 using a device tree blob V5

2016-03-01 Thread Brown, Aaron F
> From: John Holland [mailto:jotih...@gmail.com] > Sent: Monday, February 29, 2016 10:56 PM > To: Brown, Aaron F > Cc: intel-wired-...@lists.osuosl.org; netdev@vger.kernel.org > Subject: Re: [Intel-wired-lan] [next] igb: allow setting MAC address on i211 > using a device

[net-next][PATCH v3 13/13] RDS: IB: Support Fastreg MR (FRMR) memory registration mode

2016-03-01 Thread Santosh Shilimkar
From: Avinash Repaka Fastreg MR(FRMR) is another method with which one can register memory to HCA. Some of the newer HCAs supports only fastreg mr mode, so we need to add support for it to have RDS functional on them. Signed-off-by: Santosh Shilimkar

[net-next][PATCH v3 03/13] MAINTAINERS: update RDS entry

2016-03-01 Thread Santosh Shilimkar
Acked-by: Chien Yen Signed-off-by: Santosh Shilimkar Signed-off-by: Santosh Shilimkar --- MAINTAINERS | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index

RDS: Major clean-up with couple of new features for 4.6

2016-03-01 Thread Santosh Shilimkar
v3: Re-generated the same series by omitting "-D" option from git format-patch command. Since first patch has file removals, git apply/am can't deal with it when formated with '-D' option. v2: Dropped module parameter from [PATCH 11/13] as suggested by David Miller Series is generated against

[net-next][PATCH v3 02/13] RDS: Add support for SO_TIMESTAMP for incoming messages

2016-03-01 Thread Santosh Shilimkar
The SO_TIMESTAMP generates time stamp for each incoming RDS messages User app can enable it by using SO_TIMESTAMP setsocketopt() at SOL_SOCKET level. CMSG data of cmsg type SO_TIMESTAMP contains the time stamp in struct timeval format. Reviewed-by: Sowmini Varadhan

[net-next][PATCH v3 08/13] RDS: IB: add connection info to ibmr

2016-03-01 Thread Santosh Shilimkar
Preperatory patch for FRMR support. From connection info, we can retrieve cm_id which contains qp handled needed for work request posting. We also need to drop the RDS connection on QP error states where connection handle becomes useful. Signed-off-by: Santosh Shilimkar

[net-next][PATCH v3 11/13] RDS: IB: add Fastreg MR (FRMR) detection support

2016-03-01 Thread Santosh Shilimkar
Discovere Fast Memmory Registration support using IB device IB_DEVICE_MEM_MGT_EXTENSIONS. Certain HCA might support just FRMR or FMR or both FMR and FRWR. In case both mr type are supported, default FMR is used. Default MR is still kept as FMR against what everyone else is following. Default will

[PATCH RFC] net: Fix race condition when removing qdisc

2016-03-01 Thread Tom Herbert
We are seeing a number of softlockups occurring with HTB upon removing the qdisc. We are still attempting to repro the exact circumstances, however looking at the code I'm very suspicious of this block in net_tx_action and its interaction with dev_deactivate (called through tc_modify_qdisc):

Re: pull-request: mac80211-next 2016-02-26

2016-03-01 Thread Johannes Berg
On Tue, 2016-03-01 at 17:11 -0500, David Miller wrote: >  > There was a minor merge conflict with net/mac80211/debugfs.c, take > a look and send me any fixups necessary. > Ah yes, I'd wondered when that change was coming in, but missed that you had it in net-next now. Looks good, thanks!

Re: [net-next][PATCH v2 00/13] RDS: Major clean-up with couple of new features for 4.6

2016-03-01 Thread santosh shilimkar
On 3/1/2016 2:33 PM, David Miller wrote: When I try to apply this series, it (strangely) fails on the first patch with: Strange indeed since patches and the tree is against net-next. Applying: RDS: Drop stale iWARP RDMA transport error: removal patch leaves file contents This patch has

Re: [PATCH v2] ethtool: check size of user memory before copying strings and stats

2016-03-01 Thread Alexander Duyck
On Tue, Mar 1, 2016 at 2:58 PM, Keller, Jacob E wrote: > On Tue, 2016-03-01 at 14:31 -0800, Alexander Duyck wrote: >> This still has the potential to provide garbage data. What you >> should >> probably do at each stage is make sure the length matches with the >> exact

Re: [PATCH v2] ethtool: check size of user memory before copying strings and stats

2016-03-01 Thread Keller, Jacob E
On Tue, 2016-03-01 at 14:31 -0800, Alexander Duyck wrote: > This still has the potential to provide garbage data.  What you > should > probably do at each stage is make sure the length matches with the > exact value that you would expect. > Sure, an exact check could be done instead, however...

Re: pull request [net-next]: batman-adv 20160229

2016-03-01 Thread David Miller
From: Antonio Quartulli Date: Mon, 29 Feb 2016 19:05:53 +0800 > this is our (hopefully) latest batch of patches intended for net-next. > > With this patchset we finally introduce B.A.T.M.A.N. V: the latest > version of our routing protocol. > Technical documentation describing

Re: [net-next] net: pktgen: use reset to set mac header

2016-03-01 Thread David Miller
From: Zhang Shengju Date: Mon, 29 Feb 2016 08:21:30 + > Since offset is zero, it's not necessary to use set function. > > Signed-off-by: Zhang Shengju Applied, thanks.

Re: [PATCH net-next V2 03/16] net: fec: pass txq to fec_enet_tx_queue instead of queue_id

2016-03-01 Thread Troy Kisky
On 3/1/2016 3:26 PM, Zhi Li wrote: > On Tue, Mar 1, 2016 at 3:51 PM, Troy Kisky > wrote: >> True, but fec_txq/fec_rxq is called in a loop. > > netdev_priv(ndev) is that pointer move. > dev + ALIGN(sizeof(struct net_device), NETDEV_ALIGN) > > Modem compiler can

Re: [PATCH] of_mdio: fix kernel-doc for of_phy_connect()

2016-03-01 Thread David Miller
From: Sergei Shtylyov Date: Sun, 28 Feb 2016 22:50:59 +0300 > The 'flags' parameter of the of_phy_connect() function wasn't described > in the kernel-doc comment... > > Signed-off-by: Sergei Shtylyov > > --- > The patch

Re: [PATCH] of_mdio: kill useless variable in of_mdiobus_register()

2016-03-01 Thread David Miller
From: Sergei Shtylyov Date: Sun, 28 Feb 2016 21:56:34 +0300 > of_mdiobus_register() declares the 'paddr' variable to hold the result of > the of_get_property() but only uses it once after that while the function > can be called directly from the *if*

Re: [PATCH net-next 0/4] qed: Attention support patch series

2016-03-01 Thread David Miller
From: Yuval Mintz Date: Sun, 28 Feb 2016 12:26:51 +0200 > Until now we've only enabled attention generation for the sake of > management firmware indications [required for link notifications]. > > This series enables [almost] all the attention sources of the HW, >

Re: [Patch net-next] net: remove skb_sender_cpu_clear()

2016-03-01 Thread David Miller
From: Cong Wang Date: Sat, 27 Feb 2016 20:19:54 -0800 > After commit 52bd2d62ce67 ("net: better skb->sender_cpu and skb->napi_id > cohabitation") > skb_sender_cpu_clear() becomes empty and can be removed. > > Cc: Eric Dumazet > Signed-off-by:

Re: [PATCH net] sctp: sctp_remaddr_seq_show use the wrong variable to dump transport info

2016-03-01 Thread David Miller
From: Xin Long Date: Sun, 28 Feb 2016 10:33:11 +0800 > Now in sctp_remaddr_seq_show(), we use variable *tsp to get the param *v. > but *tsp is also used to traversal transport_addr_list, which will cover > the previous value, and make sctp_transport_put work on the wrong

Re: [net-next][PATCH v2 00/13] RDS: Major clean-up with couple of new features for 4.6

2016-03-01 Thread David Miller
When I try to apply this series, it (strangely) fails on the first patch with: Applying: RDS: Drop stale iWARP RDMA transport error: removal patch leaves file contents error: net/rds/iw.c: patch does not apply error: removal patch leaves file contents error: net/rds/iw.h: patch does not apply

Re: [PATCH v2] ethtool: check size of user memory before copying strings and stats

2016-03-01 Thread Alexander Duyck
On Tue, Mar 1, 2016 at 2:25 PM, Jacob Keller wrote: > Since at least 2005, (oldest commit in ethtool.git), the userspace > ethtool implementation has given the size of the memory it has allocated > as the actual size in the ethtool data structures. We previously blindly

Re: [PATCH net] sctp: lack the check for ports in sctp_v6_cmp_addr

2016-03-01 Thread David Miller
From: Xin Long Date: Sun, 28 Feb 2016 10:03:51 +0800 > As the member .cmp_addr of sctp_af_inet6, sctp_v6_cmp_addr should also check > the port of addresses, just like sctp_v4_cmp_addr, cause it's invoked by > sctp_cmp_addr_exact(). > > Now sctp_v6_cmp_addr just check the

Re: [PATCH net-next V2 03/16] net: fec: pass txq to fec_enet_tx_queue instead of queue_id

2016-03-01 Thread Zhi Li
On Tue, Mar 1, 2016 at 3:51 PM, Troy Kisky wrote: > True, but fec_txq/fec_rxq is called in a loop. netdev_priv(ndev) is that pointer move. dev + ALIGN(sizeof(struct net_device), NETDEV_ALIGN) Modem compiler can handle it greatly. You can't get any valuable

[PATCH v2] ethtool: check size of user memory before copying strings and stats

2016-03-01 Thread Jacob Keller
Since at least 2005, (oldest commit in ethtool.git), the userspace ethtool implementation has given the size of the memory it has allocated as the actual size in the ethtool data structures. We previously blindly ignore this and overwrite the requested size with the current size returned by

Re: [net-next PATCH] IPv6: Use a 16 bit length field when computing a IPv6 UDP checksum

2016-03-01 Thread Alexander Duyck
On Tue, Mar 1, 2016 at 1:35 PM, David Miller wrote: > From: Alexander Duyck > Date: Tue, 1 Mar 2016 13:19:28 -0800 > >> I was wondering what your thoughts would be about widening the size of >> the length field that we pass into csum_tcpudp_magic

[PATCH net-next V3 0/9] mlx5 driver updates

2016-03-01 Thread Saeed Mahameed
Hi Dave, This series includes some bug fixes and updates for the mlx5 core and ethernet driver. >From Gal, two fixes that protects the update CQ moderation flows when it is not allowed. >From Moshe, two fixes for the core and ethernet driver in non-cached(NC) and write combining(WC) buffers

[PATCH net-next V3 6/9] net/mlx5e: Don't try to modify CQ moderation if it is not supported

2016-03-01 Thread Saeed Mahameed
From: Gal Pressman If CQ moderation is not supported by the device, print a warning on netdevice load, and return error when trying to modify/query cq moderation via ethtool. Fixes: f62b8bb8f2d3 ('net/mlx5: Extend mlx5_core to support ConnectX-4 Ethernet functionality')

[PATCH net-next V3 9/9] net/mlx5: Fix global UAR mapping

2016-03-01 Thread Saeed Mahameed
From: Moshe Lazer Avoid double mapping of io mapped memory, Device page may be mapped to non-cached(NC) or to write-combining(WC). The code before this fix tries to map it both to WC and NC contrary to what stated in Intel's software developer manual. Here we remove the

[PATCH net-next V3 1/9] net/mlx5e: Replace async events spinlock with synchronize_irq()

2016-03-01 Thread Saeed Mahameed
From: Tariq Toukan We only need to flush the irq handler to make sure it does not queue a work into the global work queue after we start to flush it. So using synchronize_irq() is more appropriate than a spin lock. Signed-off-by: Tariq Toukan

Re: [PATCH] wan: lmc: Switch to using managed resources

2016-03-01 Thread David Miller
From: Amitoj Kaur Chawla Date: Sat, 27 Feb 2016 22:34:16 +0530 > @@ -835,23 +835,20 @@ static int lmc_init_one(struct pci_dev *pdev, const > struct pci_device_id *ent) > err = pci_request_regions(pdev, "lmc"); > if (err) { > printk(KERN_ERR "lmc:

Re: [PATCH net-next] net: ipv6/l3mdev: Move host route on saved address if necessary

2016-03-01 Thread David Miller
From: David Ahern Date: Sat, 27 Feb 2016 09:59:17 -0800 > Commit f1705ec197e70 allows IPv6 addresses to be retained on a link down. > The address can have a cached host route which can point to the wrong > FIB table if the L3 enslavement is changed (e.g., route can

[PATCH net-next V3 7/9] net/mlx5e: Don't modify CQ before it was created

2016-03-01 Thread Saeed Mahameed
From: Gal Pressman Calling mlx5e_set_coalesce while the interface is down will result in modifying CQs that don't exist. Fixes: f62b8bb8f2d3 ('net/mlx5: Extend mlx5_core to support ConnectX-4 Ethernet functionality') Signed-off-by: Gal Pressman

[PATCH net-next V3 5/9] net/mlx5e: Set drop RQ's necessary parameters only

2016-03-01 Thread Saeed Mahameed
From: Tariq Toukan By its role, there is no need to set all the other parameters for the drop RQ. Signed-off-by: Tariq Toukan Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 12 ++--

[PATCH net-next V3 3/9] net/mlx5e: Changed naming convention of tx queues in ethtool stats

2016-03-01 Thread Saeed Mahameed
From: Tariq Toukan Instead of the pair (channel, tc), we now use a single number that goes over all tx queues of a TC, for all TCs. Signed-off-by: Tariq Toukan Signed-off-by: Saeed Mahameed ---

[PATCH net-next V3 2/9] net/mlx5e: Placement changed for carrier state updates

2016-03-01 Thread Saeed Mahameed
From: Tariq Toukan More proper to declare carrier state UP only after the channels are ready for traffic. Signed-off-by: Tariq Toukan Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_main.c |4 ++--

[PATCH net-next V3 8/9] net/mlx5: Make command timeout way shorter

2016-03-01 Thread Saeed Mahameed
From: Or Gerlitz The command timeout is terribly long, whole two hours. Make it 60s so if things do go wrong, the user gets feedback in relatively short time, so they can take corrective actions and/or investigate using tools and such. Fixes: e126ba97dba9 ('mlx5: Add

[PATCH net-next V3 4/9] net/mlx5e: Move common case counters within sq_stats struct

2016-03-01 Thread Saeed Mahameed
From: Tariq Toukan For data cache locality considerations, we moved the nop and csum_offload_inner within sq_stats struct as they are more commonly accessed in xmit path. Signed-off-by: Tariq Toukan Signed-off-by: Saeed Mahameed

Re: [net-next-2.6 v4 0/3] net_sched: Add support for IFE action

2016-03-01 Thread David Miller
From: Jamal Hadi Salim Date: Sat, 27 Feb 2016 08:08:53 -0500 > As agreed at netconf in Seville, here's the patch finally (1 year > was just too long to wait for an ethertype. Now we are just going > have the user configure one). > Described in netdev01 paper: >

Re: [PATCH v2 0/3] Convert network timestamps to be y2038 safe

2016-03-01 Thread David Miller
From: Deepa Dinamani Date: Sat, 27 Feb 2016 00:32:14 -0800 > Introduction: > > The series is aimed at transitioning network timestamps to being > y2038 safe. > All patches can be reviewed and merged independently. > > Socket timestamps and ioctl calls will be handled

Re: [PATCH 2/4] net: can: ifi: Fix TX DLC configuration

2016-03-01 Thread Marek Vasut
On 03/01/2016 07:11 PM, Oliver Hartkopp wrote: Hi! > On 02/29/2016 08:59 PM, Marek Vasut wrote: >> The TX DLC, the transmission length information, was not written >> into the transmit configuration register. When using the CAN core >> with different CAN controller, the receiving CAN controller

Re: [PATCH 3/4] net: can: ifi: Fix RX and TX ID mask

2016-03-01 Thread Marek Vasut
On 03/01/2016 06:49 PM, Oliver Hartkopp wrote: > Hi Marek, Hi Oliver, > On 02/29/2016 08:59 PM, Marek Vasut wrote: >> The RX and TX ID mask for CAN2.0 is 11 bits wide. This patch fixes >> the incorrect mask, which caused the CAN IDs to miss the MSBit both >> on receive and transmit. >> >>

Re: pull-request: mac80211-next 2016-02-26

2016-03-01 Thread David Miller
From: Johannes Berg Date: Fri, 26 Feb 2016 21:37:46 +0100 > Let's try this again. I backed out some of the rfkill changes > that are buggy and fixed some of that too. I also left out the > one that generated the big discussion, but I still think it's > the saner thing

Re: [RFC][PATCH] tags: Fix DEFINE_PER_CPU expansions

2016-03-01 Thread Paul E. McKenney
On Tue, Mar 01, 2016 at 10:34:44PM +0100, Peter Zijlstra wrote: > On Tue, Mar 01, 2016 at 08:56:50AM -0800, Paul E. McKenney wrote: > > +++ b/kernel/rcu/rcutorture.c > > @@ -131,9 +131,9 @@ static unsigned long rcu_torture_current_version; > > static struct rcu_torture rcu_tortures[10 *

Re: [PATCH net-next v2 0/4] bridge: mcast: add support for temp router port

2016-03-01 Thread David Miller
From: Nikolay Aleksandrov Date: Fri, 26 Feb 2016 21:20:00 +0100 > This set adds support for temporary router port which doesn't depend only > on the incoming queries. It can be refreshed by setting multicast_router to > the same value (3). The first two patches are

Re: [PATCH 0/2] phy: micrel: fix issues with interrupt on atmel boards

2016-03-01 Thread David Miller
From: Alexandre Belloni Date: Fri, 26 Feb 2016 19:18:21 +0100 > Since the phy is not polled anymore, there were issues getting a link on the > sama5d* xplained boards. ... Series applied, thanks.

Re: [PATCH net-next V2 03/16] net: fec: pass txq to fec_enet_tx_queue instead of queue_id

2016-03-01 Thread Troy Kisky
On 3/1/2016 2:06 PM, Zhi Li wrote: > On Wed, Feb 24, 2016 at 6:36 PM, Troy Kisky > wrote: >> queue_id is the qid member of struct bufdesc_prop. >> >> Signed-off-by: Troy Kisky >> --- >> drivers/net/ethernet/freescale/fec_main.c |

[PATCH v3] treewide: Remove newlines inside DEFINE_PER_CPU() macros

2016-03-01 Thread Michal Marek
Both Emacs etags and Exuberant ctags allow to specify regexp replacements to help the tools understand some constructs used in the source code. We use these replacements extensively in make tags, however, the rules have some limitations, one of them being that they only match single lines.

Re: [RFC][PATCH] tags: Fix DEFINE_PER_CPU expansions

2016-03-01 Thread Rafael J. Wysocki
On Tue, Mar 1, 2016 at 11:26 AM, Peter Zijlstra wrote: > > $ make tags > GEN tags > ctags: Warning: drivers/acpi/processor_idle.c:64: null expansion of name > pattern "\1" > ctags: Warning: drivers/xen/events/events_2l.c:41: null expansion of name > pattern "\1" >

Re: [net-next PATCH] IPv6: Use a 16 bit length field when computing a IPv6 UDP checksum

2016-03-01 Thread David Miller
From: Alexander Duyck Date: Tue, 1 Mar 2016 13:19:28 -0800 > I was wondering what your thoughts would be about widening the size of > the length field that we pass into csum_tcpudp_magic from a 16 bit to > a 24 or 32 bit value? The general idea would be to shift

Re: [RFC][PATCH] tags: Fix DEFINE_PER_CPU expansions

2016-03-01 Thread Peter Zijlstra
On Tue, Mar 01, 2016 at 08:56:50AM -0800, Paul E. McKenney wrote: > +++ b/kernel/rcu/rcutorture.c > @@ -131,9 +131,9 @@ static unsigned long rcu_torture_current_version; > static struct rcu_torture rcu_tortures[10 * RCU_TORTURE_PIPE_LEN]; > static DEFINE_SPINLOCK(rcu_torture_lock); > static

[PATCH] ethtool: check size of user memory before copying strings and stats

2016-03-01 Thread Jacob Keller
Since at least 2005, (oldest commit in ethtool.git), the userspace ethtool implementation has given the size of the memory it has allocated as the actual size in the ethtool data structures. We previously blindly ignore this and overwrite the requested size with the current size returned by

Re: [PATCH net-next 0/9] net: dsa: mv88e6xxx: implement VLAN filtering

2016-03-01 Thread David Miller
From: Vivien Didelot Date: Fri, 26 Feb 2016 13:15:59 -0500 > This patchset fixes hardware bridging for non 802.1Q aware systems. Series applied, thanks Vivien.

Re: [net-next PATCH] IPv6: Use a 16 bit length field when computing a IPv6 UDP checksum

2016-03-01 Thread Alexander Duyck
On Tue, Mar 1, 2016 at 12:09 PM, David Miller wrote: > From: Alexander Duyck > Date: Thu, 25 Feb 2016 19:10:59 -0800 > >> This change makes it so that we only use a 16 bit length field instead of a >> 32 bit length field when computing a UDP checksum for

Re: [PATCH net] ppp: lock ppp->flags in ppp_read() and ppp_poll()

2016-03-01 Thread David Miller
From: Guillaume Nault Date: Fri, 26 Feb 2016 18:45:34 +0100 > @@ -443,9 +443,14 @@ static ssize_t ppp_read(struct file *file, char __user > *buf, >* network traffic (demand mode). >*/ > struct ppp *ppp =

Re: [PATCH for-next 01/10] net/core: Add support for configuring VF GUIDs

2016-03-01 Thread Or Gerlitz
On Tue, Mar 1, 2016 at 8:25 PM, Jason Gunthorpe wrote: > On Tue, Mar 01, 2016 at 07:49:51PM +0200, Eli Cohen wrote: >> On Tue, Mar 01, 2016 at 10:37:51AM -0700, Jason Gunthorpe wrote: >> > > + return handle_infiniband_guid(dev, , IFLA_VF_IB_PORT_GUID); >> > >> >

Re: [patch net-next v3 0/9] Introduce devlink interface and first drivers to use it

2016-03-01 Thread David Miller
From: Jiri Pirko Date: Fri, 26 Feb 2016 17:32:22 +0100 > There a is need for some userspace API that would allow to expose things > that are not directly related to any device class like net_device of > ib_device, but rather chip-wide/switch-ASIC-wide stuff. > > Use cases: >

Re: [PATCH] can: rcar_canfd: Add Renesas R-Car CAN FD driver

2016-03-01 Thread Oliver Hartkopp
On 03/01/2016 10:34 AM, Ramesh Shanmugasundaram wrote: > This patch adds support for the CAN FD controller found in Renesas R-Car > SoCs. The controller operates in CAN FD mode by default. Two test modes > are available and can be enabled by the "rcar_canfd.testmode" module > parameter. Refer to

Re: [PATCH net-next V2 03/16] net: fec: pass txq to fec_enet_tx_queue instead of queue_id

2016-03-01 Thread Zhi Li
On Wed, Feb 24, 2016 at 6:36 PM, Troy Kisky wrote: > queue_id is the qid member of struct bufdesc_prop. > > Signed-off-by: Troy Kisky > --- > drivers/net/ethernet/freescale/fec_main.c | 17 ++--- > 1 file changed, 6

Re: [net-next PATCH v3 0/3] tc software only

2016-03-01 Thread David Miller
From: John Fastabend Date: Fri, 26 Feb 2016 07:53:26 -0800 > This adds a software only flag to tc but incorporates a bunch of comments > from the original attempt at this. > > First instead of having the offload decision logic be embedded in cls_u32 > I lifted into

Re: [PATCH net-next V2 02/16] net: fec: pass rxq to fec_enet_rx_queue instead of queue_id

2016-03-01 Thread Zhi Li
On Wed, Feb 24, 2016 at 6:36 PM, Troy Kisky wrote: > The queue_id is the qid member of struct bufdesc_prop. > > Signed-off-by: Troy Kisky > --- > drivers/net/ethernet/freescale/fec_main.c | 13 + > 1 file changed, 5

Re: [PATCH net-next v3 0/5] bridge/ovs: avoid skb head copy on frame forwarding

2016-03-01 Thread David Miller
From: pravin shelar Date: Mon, 29 Feb 2016 11:05:18 -0800 > On Fri, Feb 26, 2016 at 1:45 AM, Paolo Abeni wrote: >> Currently, while when an OVS or Linux bridge is used to forward frames >> towards >> some tunnel device, a skb_head_copy() may occur if the

Re: [PATCH net v3.16]r8169: Keep minimum barrier on coherent allocation

2016-03-01 Thread Francois Romieu
Corcodel Marian : > This patch add 256 Bytes barrier on rx/tx coherent allocations. It does not make much sense unless you want to use a non power of two value for NUM_.._DESC or a value < 16 with some strange kernel where dma_alloc_coherent does not provide page

Re: [PATCH net-next V2 0/9] mlx5 driver updates

2016-03-01 Thread Or Gerlitz
On Tue, Mar 1, 2016 at 9:51 PM, David Miller wrote: [...] > I'm not going to allow two sets of parallel sets of changes to > one driver you guys maintain to be submitted at once. [...] > Get one of these accepted first, then you can submit the other one. > I'm tossing all of

Re: [PATCH net-next v2 00/10] bnxt_en: updates for net-next.

2016-03-01 Thread David Miller
From: Michael Chan Date: Fri, 26 Feb 2016 03:59:58 -0500 > Miscellaneous updates covering SRIOV, IRQ coalescing, firmware logging and > package version for net-next. Thanks. > > v2: Updated description and added more comments for patch 1. Fixed > function

Re: [PATCH] can: rcar_canfd: Add Renesas R-Car CAN FD driver

2016-03-01 Thread Marc Kleine-Budde
On 03/01/2016 10:34 AM, Ramesh Shanmugasundaram wrote: > This patch adds support for the CAN FD controller found in Renesas R-Car > SoCs. The controller operates in CAN FD mode by default. Two test modes > are available and can be enabled by the "rcar_canfd.testmode" module > parameter. Refer to

Re: [Patch] rose_route_frame() NULL pointer dereference kernel panic

2016-03-01 Thread f6bvp
Hi David, Ralf, David is absolutely right about my unappropriate patch. Although I had searched functions calling rose_route_frame(), I did not notice rose_xmit() was involved. Shame on me ! Then, David precisely located the source of the issue we are facing. When rose_xmit() calls

hi beautiful

2016-03-01 Thread Jack
hi, I am seriously looking for some love and affection, I'm an adventurous, hardworking, seriously committed and kind person. My current priority is my daughter, my work, my health and fitness. I'm a devoted father on the weekends, but missing someone special to share my life. I would like to

  1   2   3   >