Re: Poorer networking performance in later kernels?

On 04/18/2016 04:27 AM, Butler, Peter wrote: Hi Rick Thanks for the reply. Here is some hardware information, as requested (the two systems are identical, and are communicating with one another over a 10GB full-duplex Ethernet backplane): - processor type: Intel(R) Xeon(R) CPU C5528 @

Re: [PATCH] netfilter: ctnetlink: add more #ifdef around unused code

On Sat, Apr 16, 2016 at 10:17:43PM +0200, Arnd Bergmann wrote: > A recent patch removed many 'inline' annotations for static > functions in this file, which has caused warnings for functions > that are not used in a given configuration, in particular when > CONFIG_NF_CONNTRACK_EVENTS is disabled:

Re: Poorer networking performance in later kernels?

On Mon, 2016-04-18 at 16:27 +, Butler, Peter wrote: > Hi Eric > > Thanks for your response. My apologies for being late in getting back > to you - I wasn't able to have access to the lab hardware on the > weekend. > > I performed your test as suggested - I've provided a side-by-side diff >

Greetings!!!

Hi, how are you? My name is J Eric Denials, External Financial Auditor at Lloyds Banking Group plc., London. It is a pleasure to contact you at this time through this medium. I have a cool and legitimate deal to do with you as you're a foreigner, it will be mutually beneficial to both. If

[PATCH net-next 1/3] qede: Fix various memory allocation error flows for fastpath

This patch handles memory allocation failures for fastpath gracefully in the driver. Signed-off-by: Manish Chopra Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qede/qede_main.c | 140 --- 1 file changed, 85

[PATCH net-next 3/3] qede: Fix single MTU sized packet from firmware GRO flow

In firmware assisted GRO flow there could be a single MTU sized segment arriving due to firmware aggregation timeout/last segment in an aggregation flow, which is not expected to be an actual gro packet. So If a skb has zero frags from the GRO flow then simply push it in the stack as non gso skb.

[PATCH net-next 0/3] qede: Bug fixes

Hi David, This series fixes - * various memory allocation failure flows for fastpath * issues with respect to driver GRO packets handling Please note that I have intentionally targeted this for "net-next" to avoid merge conflicts when net-next changes gets merged to net Please consider

[PATCH net-next 2/3] qede: Fix setting Skb network header

Skb's network header needs to be set before extracting IPv4/IPv6 headers from it. Signed-off-by: Manish Chopra Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qede/qede_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [PATCH V2] net: ethernet: mellanox: correct page conversion

On 4/18/2016 11:40 AM, Christoph Hellwig wrote: > On Mon, Apr 18, 2016 at 11:21:12AM -0400, Sinan Kaya wrote: >> I was looking at the code. I don't see how removing virt_to_page + vmap >> would solve the issue. >> >> The code is trying to access the buffer space with direct.buf member >> from the

Re: switchdev fib offload issues

From: Jiri Pirko Date: Mon, 18 Apr 2016 17:47:57 +0200 > However, if for any reason the switchdev add operation fails, there is an > abort function called (switchdev_fib_ipv4_abort). This function does two > things which are both unfortunate in many usecases: > 1) evicts all

Re: [patch -next] udp: fix if statement in SIOCINQ ioctl

From: Dan Carpenter Date: Mon, 18 Apr 2016 11:44:49 +0300 > We deleted a line of code and accidentally made the "return put_user()" > part of the if statement when it's supposed to be unconditional. > > Fixes: 9f9a45beaa96 ('udp: do not expect udp headers on ioctl

Re: [PATCH net-next] rtnetlink: rtnl_fill_stats: avoid an unnecssary stats copy

From: Roopa Prabhu Date: Fri, 15 Apr 2016 20:36:25 -0700 > From: Roopa Prabhu > > This patch passes netlink attr data ptr directly to dev_get_stats > thus elimiating a stats copy. > > Suggested-by: David Miller >

Re: switchdev fib offload issues

Hi Jiri, On 18.04.2016 17:47, Jiri Pirko wrote: Proposed solutions (ideas): 1) per-netns. Add a procfs file: /proc/sys/net/ipv4/route/fib_offload_error_policy with values: "evict" - default, current behaviour "fail" - propagate offload error to user

Re: switchdev fib offload issues

On 4/18/16 10:38 AM, Ilan Tayari wrote: Hi Jiri, Thoughts? One general thought comes to mind, regardless of your proposed solutions: You'll need to take care to propagate the error properly in case of routes created by the kernel, such as local routes. Local routes are created when an IP

Re: [PATCH v2] carl9170: Clarify kconfig text

On Monday, April 18, 2016 06:47:44 PM Xose Vazquez Perez wrote: > Christian Lamparter wrote: > > > Sure, but this could be a different patch then. I think Intel devices > > (iwlwifi, iwlegacy and ipw2x00) have a similar text about "download > > firmware from this device from our homepage here"

Re: [PATCH v2] carl9170: Clarify kconfig text

On Monday, April 18, 2016 07:42:05 PM Kalle Valo wrote: > Christian Lamparter writes: > > > On Monday, April 18, 2016 06:45:09 PM Kalle Valo wrote: > >> Lauri Kasanen writes: > >> > >> > --- a/drivers/net/wireless/ath/carl9170/Kconfig > >> > +++

Re: [Intel-wired-lan] [PATCH net-next V2 2/2] intel: ixgbevf: Support Windows hosts (Hyper-V)

On Mon, 2016-04-18 at 16:52 +, KY Srinivasan wrote: [] > > > +bool ixgbevf_on_hyperv(struct ixgbe_hw *hw) > > > +{ > > > +   if (hw->mbx.ops.check_for_msg == NULL) > > > +   return true; > > > +   else > > > +   return false; > > > +} trivia: bool func(...) {

Re: switchdev fib offload issues

On 4/18/16 9:47 AM, Jiri Pirko wrote: Proposed solutions (ideas): 1) per-netns. Add a procfs file: /proc/sys/net/ipv4/route/fib_offload_error_policy with values: "evict" - default, current behaviour "fail" - propagate offload error to user The

RE: switchdev fib offload issues

Hi Jiri, > Thoughts? One general thought comes to mind, regardless of your proposed solutions: You'll need to take care to propagate the error properly in case of routes created by the kernel, such as local routes. Local routes are created when an IP address is added to an interface, so in

RE: [Intel-wired-lan] [PATCH net-next V2 2/2] intel: ixgbevf: Support Windows hosts (Hyper-V)

> -Original Message- > From: Alexander Duyck [mailto:alexander.du...@gmail.com] > Sent: Monday, April 18, 2016 9:18 AM > To: KY Srinivasan > Cc: David Miller ; Netdev > ; linux-ker...@vger.kernel.org; >

Re: [PATCH v2] carl9170: Clarify kconfig text

Christian Lamparter wrote: > Sure, but this could be a different patch then. I think Intel devices > (iwlwifi, iwlegacy and ipw2x00) have a similar text about "download > firmware from this device from our homepage here" too. So if we want, > we can remove them altogether? linux-firmware.git

RE: Poorer networking performance in later kernels?

P.S. Cancel my comment about some fields existing in one kernel but not the other- that was probably just an artefact of the fact that for one kernel the value was zero but not in the other kernel (and that I did not run nstat with the -z option to output zero counts). So the data I provided

Re: [PATCH] macsec: fix crypto Kconfig dependency

From: Herbert Xu Date: Mon, 18 Apr 2016 18:43:36 +0800 > Right, the problem is that nothing within crypto ever selects > CRYPTO since it's also used as a way of hiding the crypto menu > options. As far as I understand it, this won't help. Because selects do not

Re: [PATCH v2] carl9170: Clarify kconfig text

Christian Lamparter writes: > On Monday, April 18, 2016 06:45:09 PM Kalle Valo wrote: >> Lauri Kasanen writes: >> >> > --- a/drivers/net/wireless/ath/carl9170/Kconfig >> > +++ b/drivers/net/wireless/ath/carl9170/Kconfig >> > @@ -5,12 +5,10 @@ config

Re: [PATCH net-next v4] rtnetlink: add new RTM_GETSTATS message to dump link stats

From: Roopa Prabhu Date: Sun, 17 Apr 2016 22:35:35 -0700 > This patch adds a new RTM_GETSTATS message to query link stats via netlink > from the kernel. RTM_NEWLINK also dumps stats today, but RTM_NEWLINK > returns a lot more than just stats and is expensive in some

RE: Poorer networking performance in later kernels?

Hi Eric Thanks for your response. My apologies for being late in getting back to you - I wasn't able to have access to the lab hardware on the weekend. I performed your test as suggested - I've provided a side-by-side diff of the nstat output below for the SCTP test only (not the TCP test).

Re: [PATCH v3] carl9170: Clarify kconfig text

On Monday, April 18, 2016 07:07:39 PM Lauri Kasanen wrote: > The previous text was confusing, leading readers to think this > driver was a duplicate, and so didn't need to be enabled. > > After the removal of the older staging driver, this is the only > driver in mainline for these devices. > >

Re: [PATCH net-next 0/8] allow bpf attach to tracepoints

On Mon, 4 Apr 2016 21:52:46 -0700 Alexei Starovoitov wrote: > Hi Steven, Peter, > > last time we discussed bpf+tracepoints it was a year ago [1] and the reason > we didn't proceed with that approach was that bpf would make arguments > arg1, arg2 to trace_xx(arg1, arg2) call to be

Re: [PATCH v2] carl9170: Clarify kconfig text

On Monday, April 18, 2016 06:45:09 PM Kalle Valo wrote: > Lauri Kasanen writes: > > > The previous text was confusing, leading readers to think this > > driver was a duplicate, and so didn't need to be enabled. > > > > After the removal of the older staging driver, this is the only

Re: [Intel-wired-lan] [PATCH net-next V2 2/2] intel: ixgbevf: Support Windows hosts (Hyper-V)

On Sun, Apr 17, 2016 at 10:22 PM, K. Y. Srinivasan wrote: > On Hyper-V, the VF/PF communication is a via software mediated path > as opposed to the hardware mailbox. Make the necessary > adjustments to support Hyper-V. > > Signed-off-by: K. Y. Srinivasan >

[PATCH v3] carl9170: Clarify kconfig text

The previous text was confusing, leading readers to think this driver was a duplicate, and so didn't need to be enabled. After the removal of the older staging driver, this is the only driver in mainline for these devices. Signed-off-by: Lauri Kasanen --- v3: Remove all firmware

Re: [PATCH V2] net: ethernet: mellanox: correct page conversion

On 4/18/2016 11:59 AM, David Miller wrote: > From: ok...@codeaurora.org > Date: Mon, 18 Apr 2016 01:06:27 -0400 > >> On 2016-04-18 00:00, David Miller wrote: >>> From: Sinan Kaya >>> Date: Sat, 16 Apr 2016 18:23:32 -0400 >>> Current code is assuming that the address

Re: [PATCH] macsec: fix crypto Kconfig dependency

From: Herbert Xu Date: Mon, 18 Apr 2016 16:02:02 +0800 > In fact this strikes me as a kbuild bug because CRYPTO_GCM already > selects (indirectly) CRYPTO_ALGAPI so why is this happening at all? Selects don't trigger selects.

Re: [PATCH V2] net: ethernet: mellanox: correct page conversion

From: ok...@codeaurora.org Date: Mon, 18 Apr 2016 01:06:27 -0400 > On 2016-04-18 00:00, David Miller wrote: >> From: Sinan Kaya >> Date: Sat, 16 Apr 2016 18:23:32 -0400 >> >>> Current code is assuming that the address returned by >>> dma_alloc_coherent >>> is a logical

switchdev fib offload issues

Hi all. The current situation of fib offloading is not good, I believe we need to make some changes, therefore I'm writing this email. Please read, think and comment. Currently what we have is that for every fib entry inserted into a table, there is a call to switchdev:

Re: [PATCH v2] carl9170: Clarify kconfig text

Lauri Kasanen writes: > The previous text was confusing, leading readers to think this > driver was a duplicate, and so didn't need to be enabled. > > After the removal of the older staging driver, this is the only > driver in mainline for these devices. > > Signed-off-by: Lauri

Re: [PATCH V2] net: ethernet: mellanox: correct page conversion

On Mon, Apr 18, 2016 at 11:21:12AM -0400, Sinan Kaya wrote: > I was looking at the code. I don't see how removing virt_to_page + vmap > would solve the issue. > > The code is trying to access the buffer space with direct.buf member > from the CPU side. This member would become NULL, when this

[PATCH] net: ipv6: Do not fix up linklocal and loopback addresses

f1705ec197e7 ("net: ipv6: Make address flushing on ifdown optional") added the option to retain user configured addresses on an admin down. A comment to one of the later revisions suggested using the IFA_F_PERMANENT flag rather than adding a user_managed boolean to the ifaddr struct. A side effect

[PATCH net-next] macvlan: fix failure during registration

Resending, did not include netdev the first time ... If a macvlan/macvtap creation fails in register_netdevice in call_netdevice_notifiers(NETDEV_REGISTER) then while cleaning things up in rollback_registered_many it invokes macvlan_uninit. This results in port->count being decremented twice (in

Re: [PATCH V2] net: ethernet: mellanox: correct page conversion

On 4/18/2016 11:15 AM, Timur Tabi wrote: > Sinan Kaya wrote: >> >> VMAP allows you to make several pages look contiguous to the CPU. >> It can only be used against logical addresses returned from kmalloc >> or alloc_page. >> >> You cannot take several virtually mapped addresses returned by >>

Re: [PATCH V2] net: ethernet: mellanox: correct page conversion

On 4/18/2016 11:17 AM, Christoph Hellwig wrote: > On Mon, Apr 18, 2016 at 02:39:36PM +, Eli Cohen wrote: >> Right, I did not suggest this as a patch but just wanted to pinpoint the >> problematic issue which is that virt_to_page does not give you the correct >> pointer to the page. > >

Re: [PATCH] net: ipv6: Do not fix up linklocal and loopback addresses

Hello. On 4/18/2016 5:23 PM, Mike Manning wrote: f1705ec197e7 "Make address flushing on ifdown optional" added the option Looking further, this doesn't seem like a complete commit summary. And you need to enclose it in parens too. to retain user configured addresses on an admin down.

Re: [PATCH V2] net: ethernet: mellanox: correct page conversion

On Mon, Apr 18, 2016 at 02:39:36PM +, Eli Cohen wrote: > Right, I did not suggest this as a patch but just wanted to pinpoint the > problematic issue which is that virt_to_page does not give you the correct > pointer to the page. Removing both the virt_to_page + vmap calls would solve the

Re: [PATCH V2] net: ethernet: mellanox: correct page conversion

Sinan Kaya wrote: VMAP allows you to make several pages look contiguous to the CPU. It can only be used against logical addresses returned from kmalloc or alloc_page. You cannot take several virtually mapped addresses returned by dma_alloc_coherent and try to make them virtually contiguous

Re: [PATCH] net: ipv6: Do not fix up linklocal and loopback addresses

On 04/18/2016 03:39 PM, David Ahern wrote: > On 4/18/16 8:23 AM, Mike Manning wrote: >> f1705ec197e7 "Make address flushing on ifdown optional" added the option >> to retain user configured addresses on an admin down. A comment to one of >> the later revisions suggested using the IFA_F_PERMANENT

[PATCH 2/5] arcnet: com90xx: add __init attribute

Add __init attribute on a function that is only called from other __init functions and that is not inlined, at least with gcc version 4.8.4 on an x86 machine with allyesconfig. Currently, the function is put in the .text.unlikely segment. Declaring it as __init will cause it to be put in the

[PATCH 0/5] add __init attribute

Add __init attribute on a function that is only called from other __init functions and that is not inlined. The complete semantic patch used to detect the need for this change is below (http://coccinelle.lip6.fr/). This semantic patch checks for local static non-init functions that are called

Re: [PATCH bluetooth-next 09/10] 6lowpan: introduce 6lowpan-nd

Hi Alexander, [auto build test ERROR on bluetooth-next/master] url: https://github.com/0day-ci/linux/commits/Alexander-Aring/6lowpan-introduce-basic-6lowpan-nd/20160418-191825 base: https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git master config: i386

Re: [PATCHv2] wlcore: spi: add wl18xx support

On Monday 18 April 2016 05:55:51 Reizer, Eyal wrote: > > > > > > - all wilink family needs special init command for entering wspi mode. > > > extra clock cycles should be sent after the spi init command while the > > > cs pin is high. > > > - switch to controling the cs pin from the spi driver

RE: [PATCH V2] net: ethernet: mellanox: correct page conversion

Right, I did not suggest this as a patch but just wanted to pinpoint the problematic issue which is that virt_to_page does not give you the correct pointer to the page. -Original Message- From: Christoph Hellwig [mailto:h...@infradead.org] Sent: Monday, April 18, 2016 9:33 AM To: Eli

Re: [PATCH net-next 2/5] qede: Add support for ethtool private flags

>> + flags |= (!!(edev->dev_info.common.num_hwfns > 1)) << >> + QEDE_PRI_FLAG_CMT; > Why not just '='? >> + >> + return flags; > ... or direct return of the value above? Probably wanted to lay the basis for future flags. But you're right in that there's no need for it.

Re: [PATCH] net: ipv6: Do not fix up linklocal and loopback addresses

On 4/18/16 8:23 AM, Mike Manning wrote: f1705ec197e7 "Make address flushing on ifdown optional" added the option to retain user configured addresses on an admin down. A comment to one of the later revisions suggested using the IFA_F_PERMANENT flag rather than adding a user_managed boolean to the

Re: [PATCH v5 2/4] Documentation: Bindings: Add STM32 DWMAC glue

On 3/22/2016 5:11 PM, Alexandre Torgue wrote: Hi guys, I will fix typo issues (s/vesrion/version and ethernet @). Concerning compatible string. For sure "snps,dwmac-3.50a" string is not used inside glue driver. I perfere to keep it for information but if you really want that I remove it I will

Re: [PATCH V2] net: ethernet: mellanox: correct page conversion

On Mon, Apr 18, 2016 at 09:54:47AM +0300, Eli Cohen wrote: > Sinan, > > if we get rid of the part this code: > > if (BITS_PER_LONG == 64) { > struct page **pages; > pages = kmalloc(sizeof *pages * buf->nbufs, gfp); >

Re: [PATCH V2] net: ethernet: mellanox: correct page conversion

Sure, this is not the complete patch. As far as I know the problem you're facing with arm is that virt_to_page() does not provide the correct page descriptor so my suggestion will eliminate the need for it. On Mon, Apr 18, 2016 at 09:53:30AM -0400, Sinan Kaya wrote: > On 4/18/2016 2:54 AM, Eli

[PATCH] net: ipv6: Do not fix up linklocal and loopback addresses

f1705ec197e7 "Make address flushing on ifdown optional" added the option to retain user configured addresses on an admin down. A comment to one of the later revisions suggested using the IFA_F_PERMANENT flag rather than adding a user_managed boolean to the ifaddr struct. A side effect of this

Re: [PATCH bluetooth-next 07/10] ipv6: introduce neighbour discovery ops

Hi Alexander, [auto build test WARNING on bluetooth-next/master] url: https://github.com/0day-ci/linux/commits/Alexander-Aring/6lowpan-introduce-basic-6lowpan-nd/20160418-191825 base: https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git master config: x86_64

Re: [PATCH net-next V2 05/11] net/mlx5e: Support RX multi-packet WQE (Striding RQ)

On Mon, 2016-04-18 at 16:05 +0300, Saeed Mahameed wrote: > On Mon, Apr 18, 2016 at 3:48 PM, Eric Dumazet wrote: > > On Sun, 2016-04-17 at 17:29 -0700, Eric Dumazet wrote: > > > >> > >> If really you need to allocate physically contiguous memory, have you > >> considered

Re: [PATCH net-next 2/5] qede: Add support for ethtool private flags

Hello. On 4/17/2016 10:26 PM, Yuval Mintz wrote: Adds a getter for the interfaces private flags. The only parameter currently supported is whether the interface is a coupled function [required for supporting 100g]. Signed-off-by: Yuval Mintz ---

[PATCH v2 1/1] drivers: net: cpsw: Prevent NUll pointer dereference with two PHYs

Adding a 2nd PHY to cpsw results in a NULL pointer dereference as below. Fix by maintaining a reference to each PHY node in slave struct instead of a single reference in the priv struct which was overwritten by the 2nd PHY. [ 17.870933] Unable to handle kernel NULL pointer dereference at

[PATCH v2 0/1] drivers: net: cpsw: Fix NULL pointer dereference with two slave PHYs

This is a fix for a NULL pointer dereference from cpsw which is triggered by having two slave PHYs attached to a cpsw network device. The problem is due to only maintaining a single reference to a PHY node in the prive data which gets overwritten by the second PHY probe. So move the PHY node

Re: [PATCH V2] net: ethernet: mellanox: correct page conversion

On Mon, Apr 18, 2016 at 09:49:10AM -0400, Sinan Kaya wrote: > Here is a good description of logical address vs. virtual address. > > https://www.quora.com/What-is-the-Kernel-logical-and-virtual-addresses-What-is-the-difference-between-them-What-is-the-type-of-addresses-listed-in-the-System-map

Re: [PATCH V2] net: ethernet: mellanox: correct page conversion

On 4/18/2016 9:10 AM, Christoph Hellwig wrote: > On Mon, Apr 18, 2016 at 09:06:18AM -0400, ok...@codeaurora.org wrote: >> On 2016-04-18 08:12, Christoph Hellwig wrote: >>> On Sat, Apr 16, 2016 at 06:23:32PM -0400, Sinan Kaya wrote: Current code is assuming that the address returned by

Re: [PATCH V2] net: ethernet: mellanox: correct page conversion

On 4/18/2016 2:54 AM, Eli Cohen wrote: > Sinan, > > if we get rid of the part this code: > > if (BITS_PER_LONG == 64) { > struct page **pages; > pages = kmalloc(sizeof *pages * buf->nbufs, gfp); > if (!pages)

Re: [patch -next] udp: fix if statement in SIOCINQ ioctl

On Mon, Apr 18, 2016 at 8:19 AM, Eric Dumazet wrote: > On Mon, 2016-04-18 at 11:44 +0300, Dan Carpenter wrote: >> We deleted a line of code and accidentally made the "return put_user()" >> part of the if statement when it's supposed to be unconditional. >> >> Fixes:

Re: [PATCH bluetooth-next 07/10] ipv6: introduce neighbour discovery ops

Hi, Am 04/18/2016 um 12:58 PM schrieb Alexander Aring: > This patch introduces neighbour discovery ops callback structure. The > structure contains at first receive and transmit handling for NS/NA and > userspace option field functionality. > > These callback offers 6lowpan different handling,

Re: [PATCH RFC net-next 0/2] pskb_extract() helper function.

On Mon, Apr 18, 2016 at 06:21:07AM -0700, Sowmini Varadhan wrote: > This patchset follows up on the discussion in > https://www.mail-archive.com/netdev@vger.kernel.org/msg105090.html > > For RDS-TCP, we have to deal with the full gamut of > nonlinear sk_buffs, including all the frag_list

[PATCH RFC net-next 1/2] skbuff: Add pskb_extract() helper function

A pattern of skb usage seen in modules such as RDS-TCP is to extract `to_copy' bytes from the received TCP segment, starting at some offset `off' into a new skb `clone'. This is done in the ->data_ready callback, where the clone skb is queued up for rx on the PF_RDS socket, while the parent TCP

[PATCH RFC net-next 2/2] RDS: TCP: Call pskb_extract() helper function

rds-stress experiments with request size 256 bytes, 8K acks, using 16 threads show a 40% improvment when pskb_extract() replaces the {skb_clone(..); pskb_pull(..); pskb_trim(..);} pattern in the Rx path, so we leverage the perf gain with this commit. Signed-off-by: Sowmini Varadhan

[PATCH RFC net-next 0/2] pskb_extract() helper function.

This patchset follows up on the discussion in https://www.mail-archive.com/netdev@vger.kernel.org/msg105090.html For RDS-TCP, we have to deal with the full gamut of nonlinear sk_buffs, including all the frag_list variants. Also, the parent skb has to remain unchanged, while the clone is queued

Re: [PATCH V2] net: ethernet: mellanox: correct page conversion

On Mon, Apr 18, 2016 at 09:06:18AM -0400, ok...@codeaurora.org wrote: > On 2016-04-18 08:12, Christoph Hellwig wrote: > >On Sat, Apr 16, 2016 at 06:23:32PM -0400, Sinan Kaya wrote: > >>Current code is assuming that the address returned by dma_alloc_coherent > >>is a logical address. This is not

Re: [PATCH V2] net: ethernet: mellanox: correct page conversion

On 2016-04-18 08:12, Christoph Hellwig wrote: On Sat, Apr 16, 2016 at 06:23:32PM -0400, Sinan Kaya wrote: Current code is assuming that the address returned by dma_alloc_coherent is a logical address. This is not true on ARM/ARM64 systems. Can you explain what you mean with a 'logical

Re: [PATCH net-next V2 05/11] net/mlx5e: Support RX multi-packet WQE (Striding RQ)

On Mon, Apr 18, 2016 at 3:48 PM, Eric Dumazet wrote: > On Sun, 2016-04-17 at 17:29 -0700, Eric Dumazet wrote: > >> >> If really you need to allocate physically contiguous memory, have you >> considered converting the order-5 pages into 32 order-0 ones ? > > Search for

Re: [PATCH bluetooth-next 09/10] 6lowpan: introduce 6lowpan-nd

Hi Alexander, [auto build test ERROR on bluetooth-next/master] url: https://github.com/0day-ci/linux/commits/Alexander-Aring/6lowpan-introduce-basic-6lowpan-nd/20160418-191825 base: https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git master config: x86_64

Re: [PATCH bluetooth-next 07/10] ipv6: introduce neighbour discovery ops

Hi Alexander, [auto build test ERROR on bluetooth-next/master] url: https://github.com/0day-ci/linux/commits/Alexander-Aring/6lowpan-introduce-basic-6lowpan-nd/20160418-191825 base: https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git master config: x86_64

Re: [PATCH net-next V2 05/11] net/mlx5e: Support RX multi-packet WQE (Striding RQ)

On Sun, 2016-04-17 at 17:29 -0700, Eric Dumazet wrote: > > If really you need to allocate physically contiguous memory, have you > considered converting the order-5 pages into 32 order-0 ones ? Search for split_page() call sites for examples.

IMPORTANT MAIL TO YOU

I am Capt. Lawrence Tyman, an officer in US Army,and also a West Point Graduate, serving in the Military with the 82nd Air Borne Division Peace keeping force deployed from Afganistan to Syria. We were moved to Syria from Iraq as the last batch just left,and i really need your help in assisting

Re: [patch -next] udp: fix if statement in SIOCINQ ioctl

On Mon, 2016-04-18 at 11:44 +0300, Dan Carpenter wrote: > We deleted a line of code and accidentally made the "return put_user()" > part of the if statement when it's supposed to be unconditional. > > Fixes: 9f9a45beaa96 ('udp: do not expect udp headers on ioctl SIOCINQ') > Signed-off-by: Dan

Re: Poorer networking performance in later kernels?

On Fri, 2016-04-15 at 15:33 -0700, Eric Dumazet wrote: > On Fri, 2016-04-15 at 21:02 +, Butler, Peter wrote: > > (Please keep me CC'd to all comments/responses) > > > > I've tried a kernel upgrade from 3.4.2 to 4.4.0 and see a marked drop in > > networking performance. Nothing was changed

RE: Poorer networking performance in later kernels?

Just a minor clarification to my last paragraph ("When I perform the tests in this setup the 3.4.2 and 4.4.0 kernels perform identically - just as you would expect."). By this I don't mean that the 3.4.2 and 4.4.0 kernels on the VMs perform identically to the 3.4.2 and 4.4.0 kernels on the

Re: [PATCH] cls_cgroup: get sk_classid only from full sockets

On Mon, 2016-04-18 at 14:37 +0300, Konstantin Khlebnikov wrote: > skb->sk could point to timewait or request socket which has no sk_classid. > Detected as "BUG: KASAN: slab-out-of-bounds in cls_cgroup_classify". > > Signed-off-by: Konstantin Khlebnikov > --- Acked-by:

Re: [PATCH V2] net: ethernet: mellanox: correct page conversion

On Sat, Apr 16, 2016 at 06:23:32PM -0400, Sinan Kaya wrote: > Current code is assuming that the address returned by dma_alloc_coherent > is a logical address. This is not true on ARM/ARM64 systems. Can you explain what you mean with a 'logical address' and what actual issue you're trying to

Re: [PATCH] net/mlx4_en: allocate non 0-order pages for RX ring with __GFP_NOMEMALLOC

On Mon, 2016-04-18 at 14:33 +0300, Konstantin Khlebnikov wrote: > High order pages are optional here since commit 51151a16a60f ("mlx4: allow > order-0 memory allocations in RX path"), so here is no reason for depleting > reserves. Generic __netdev_alloc_frag() implements the same logic. > >

[PATCH] cls_cgroup: get sk_classid only from full sockets

skb->sk could point to timewait or request socket which has no sk_classid. Detected as "BUG: KASAN: slab-out-of-bounds in cls_cgroup_classify". Signed-off-by: Konstantin Khlebnikov --- include/net/cls_cgroup.h |7 +-- 1 file changed, 5 insertions(+), 2

RE: Poorer networking performance in later kernels?

Hi Rick Thanks for the reply. Here is some hardware information, as requested (the two systems are identical, and are communicating with one another over a 10GB full-duplex Ethernet backplane): - processor type: Intel(R) Xeon(R) CPU C5528 @ 2.13GHz - NIC: Intel 82599EB 10GB XAUI/BX4 - NIC

[PATCH 1/2] net/ipv6/addrconf: simplify sysctl registration

Struct ctl_table_header holds pointer to sysctl table which could be used for freeing it after unregistration. IPv4 sysctls already use that. Remove redundant NULL assignment: ndev allocated using kzalloc. This also saves some bytes: sysctl table could be shorter than DEVCONF_MAX+1 if some

[PATCH] net/mlx4_en: allocate non 0-order pages for RX ring with __GFP_NOMEMALLOC

High order pages are optional here since commit 51151a16a60f ("mlx4: allow order-0 memory allocations in RX path"), so here is no reason for depleting reserves. Generic __netdev_alloc_frag() implements the same logic. Signed-off-by: Konstantin Khlebnikov ---

[PATCH] net/mlx4_en: do batched put_page using atomic_sub

This patch fixes couple error paths after allocation failures. Atomic set of page reference counter is safe only if it is zero, otherwise set can race with any speculative get_page_unless_zero. Signed-off-by: Konstantin Khlebnikov ---

[PATCH 2/2] net/ipv6/addrconf: fix sysctl table indentation

Separated from previous patch for readability. Signed-off-by: Konstantin Khlebnikov --- net/ipv6/addrconf.c | 616 +-- 1 file changed, 307 insertions(+), 309 deletions(-) diff --git a/net/ipv6/addrconf.c

[PATCH v2 2/4] io-mapping: Specify mapping size for io_mapping_map_wc()

The ioremap() hidden behind the io_mapping_map_wc() convenience helper can be used for remapping multiple pages. Extend the helper so that future callers can use it for larger ranges. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin Cc: Daniel

Re: [PATCH] macsec: fix crypto Kconfig dependency

On Monday 18 April 2016 18:43:36 Herbert Xu wrote: > > It's kind of silly really now that IPv4 selects CRYPTO which > means that you can't really avoid seeing all those options which > most users won't care about. I had not noticed that IPv4 does it, but that is a good point. We have had a

[PATCH bluetooth-next 01/10] 6lowpan: add private neighbour data

This patch will introduce a 6lowpan neighbour private data. Like the interface private data we handle private data for generic 6lowpan and for link-layer specific 6lowpan. The current first use case if to save the short address for a 802.15.4 6lowpan neighbour. Cc: David S. Miller

[PATCH bluetooth-next 07/10] ipv6: introduce neighbour discovery ops

This patch introduces neighbour discovery ops callback structure. The structure contains at first receive and transmit handling for NS/NA and userspace option field functionality. These callback offers 6lowpan different handling, such as 802.15.4 short address handling or RFC6775 (Neighbor

[PATCH bluetooth-next 08/10] ipv6: export ndisc functions

This patch exports some neighbour discovery functions which can be used by 6lowpan neighbour discovery ops functionality then. Cc: David S. Miller Cc: Alexey Kuznetsov Cc: James Morris Cc: Hideaki YOSHIFUJI

[PATCH bluetooth-next 09/10] 6lowpan: introduce 6lowpan-nd

This patch introduce different 6lowpan handling for receive and transmit NS/NA messages for the ipv6 neighbour discovery. The first use-case is for supporting 802.15.4 short addresses inside the option fields and handling for RFC6775 6CO option field as userspace option. Future handling: Also add

[PATCH bluetooth-next 05/10] ndisc: add addr_len parameter to ndisc_opt_addr_data

This patch makes the address length as argument for the ndisc_opt_addr_data function. This is necessary to handle addresses which don't use dev->addr_len as address length. Cc: David S. Miller Cc: Alexey Kuznetsov Cc: James Morris

[PATCH bluetooth-next 10/10] 6lowpan: add support for 802.15.4 short addr handling

This patch adds necessary handling for use the short address for 802.15.4 6lowpan. It contains support for IPHC address compression and new matching algorithmn to decide which link layer address will be used for 802.15.4 frame. Signed-off-by: Alexander Aring ---

[PATCH bluetooth-next 02/10] 6lowpan: add 802.15.4 short addr slaac

This patch adds the autoconfiguration if a valid 802.15.4 short address is available for 802.15.4 6LoWPAN interfaces. Cc: David S. Miller Cc: Alexey Kuznetsov Cc: James Morris Cc: Hideaki YOSHIFUJI Cc:

[PATCH bluetooth-next 06/10] ndisc: add addr_len parameter to ndisc_fill_addr_option

This patch makes the address length as argument for the ndisc_fill_addr_option function. This is necessary to handle addresses which don't use dev->addr_len as address length. Cc: David S. Miller Cc: Alexey Kuznetsov Cc: James Morris

[PATCH bluetooth-next 03/10] 6lowpan: remove ipv6 module request

Since we use exported function from ipv6 kernel module we don't need to request the module anymore to have ipv6 functionality. Signed-off-by: Alexander Aring --- net/6lowpan/core.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/net/6lowpan/core.c b/net/6lowpan/core.c

<    1   2   3   >