Re: [PATCH 2/2] net: ethernet: et131x: use phy_ethtool_{get|set}_link_ksettings

From: Philippe Reynes Date: Fri, 17 Jun 2016 23:32:15 +0200 > There are two generics functions phy_ethtool_{get|set}_link_ksettings, > so we can use them instead of defining the same code in the driver. > > Signed-off-by: Philippe Reynes Applied.

Re: [PATCH 1/2] net: ethernet: et131x: use phydev from struct net_device

From: Philippe Reynes Date: Fri, 17 Jun 2016 23:32:14 +0200 > The private structure contain a pointer to phydev, but the structure > net_device already contain such pointer. So we can remove the pointer > phydev in the private structure, and update the driver to use the > one

Re: [PATCH net] RDS: TCP: rds_tcp_accept_one() should transition socket from RESETTING to UP

From: Sowmini Varadhan Date: Fri, 17 Jun 2016 16:12:12 -0400 > The state of the rds_connection after rds_tcp_reset_callbacks() would > be RDS_CONN_RESETTING and this is the value that should be passed > by rds_tcp_accept_one() to rds_connect_path_complete() to

Re: [PATCH -next] RDS: TCP: Fix non static symbol warnings

From: weiyj...@163.com Date: Fri, 17 Jun 2016 18:12:46 + > From: Wei Yongjun > > Fixes the following sparse warnings: > > net/rds/tcp.c:59:5: warning: > symbol 'rds_tcp_min_sndbuf' was not declared. Should it be static? > net/rds/tcp.c:60:5: warning: >

Re: [PATCH] gtp: remove unused including

From: weiyj...@163.com Date: Fri, 17 Jun 2016 17:33:30 + > From: Wei Yongjun > > Remove including that don't need it. > > Signed-off-by: Wei Yongjun Applied.

Re: [PATCH] net:liquidio: remove unused including

From: weiyj...@163.com Date: Fri, 17 Jun 2016 17:49:33 + > From: Wei Yongjun > > Remove including that don't need it. > > Signed-off-by: Wei Yongjun Applied.

Re: [PATCH] net: tilegx: use correct timespec64 type

From: Arnd Bergmann Date: Fri, 17 Jun 2016 18:15:30 +0200 > The conversion to the 64-bit time based ptp methods left two instances > of 'struct timespec' in place. This is harmless because 64-bit > architectures define timespec64 as timespec, and this driver is > not used on

Re: [very-RFC 0/8] TSN driver for the kernel

Hi, Sorry to be late. In this weekday, I have little time for this thread because working for alsa-lib[1]. Besides, I'm not full-time developer for this kind of work. In short, I use my limited private time for this discussion. On Jun 15 2016 17:06, Richard Cochran wrote: > On Wed, Jun 15, 2016

Re: pull-request: can-next 2016-06-17,pull-request: can-next 2016-06-17

From: Marc Kleine-Budde Date: Fri, 17 Jun 2016 16:31:46 +0200 > this is a pull request of 14 patches for net-next/master. > > Geert Uytterhoeven contributes a patch that adds a file patterns for > CAN device tree bindings to MAINTAINERS. A patch by Alexander Aring > fixes

esp: Fix ESN generation under UDP encapsulation

On Fri, Jun 17, 2016 at 12:24:29PM +0200, Steffen Klassert wrote: > On Wed, Jun 15, 2016 at 12:44:54AM +, Blair Steven wrote: > > The restoration is happening - but being actioned on the wrong location. > > > > The destination IP address is being saved and restored, and the SPI > > being

Re: [patch net 0/2] mlxsw: couple of fixes

From: Jiri Pirko Date: Fri, 17 Jun 2016 15:09:04 +0200 > Couple of slowpath tx stats fixes for Spectrum and SwitchX-2. Series applied, thanks Jiri.

Re: [PATCH 0/6] eBPF JIT for PPC64

On 2016-06-13 15:40, Naveen N. Rao wrote: On 2016/06/10 10:47PM, David Miller wrote: From: "Naveen N. Rao" Date: Tue, 7 Jun 2016 19:02:17 +0530 > Please note that patch [2] is a pre-requisite for this patchset, and is > not yet upstream. ... > [1]

Re: [PATCH net 1/1] tipc: fix socket timer deadlock

From: Jon Maloy Date: Fri, 17 Jun 2016 06:35:57 -0400 > We sometimes observe a 'deadly embrace' type deadlock occurring > between mutually connected sockets on the same node. This happens > when the one-hour peer supervision timers happen to expire > simultaneously in

Re: [PATCH v2 net-next 0/3] net sched action timestamp improvements

From: Jamal Hadi Salim Date: Fri, 17 Jun 2016 07:15:27 -0400 > Ok, mystery solved. Dave, this patch series is missing from current > net-next. Then what is: commit 53eb440f4ada034ea43b295891feec3df0fa7a29 Author: Jamal Hadi Salim Date: Mon Jun 6

Re: [PATCH v3 0/2] net: ethernet: ti: cpsw: delete rx_descs property

From: Ivan Khoronzhuk Date: Fri, 17 Jun 2016 13:25:38 +0300 > There is no reason in rx_descs property because davinici_cpdma > driver splits pool of descriptors equally between tx and rx channels. > So, this patch series makes driver to use available number of >

Re: [patch -next] tipc: potential shift wrapping bug in map_set()

From: Dan Carpenter Date: Fri, 17 Jun 2016 12:22:26 +0300 > "up_map" is a u64 type but we're not using the high 32 bits. > > Fixes: 35c55c9877f8 ('tipc: add neighbor monitoring framework') > Signed-off-by: Dan Carpenter Applied.

Re: [PATCH net-next 0/3] net: vrf: Fix ipv6 source address selection

From: David Ahern Date: Thu, 16 Jun 2016 16:24:23 -0700 > IPv6 address selection is currently messed up for several use cases such > as unnumbered deployments with global addresses on the VRF device and none > on the enslaved devices. > > Update the source address

Re: [PATCH] net: lantiq_etop: remove unused variable

From: Sudip Mukherjee Date: Thu, 16 Jun 2016 22:19:31 +0100 > The variable i was declared but was never used and we were getting a > build warning for that. > > Signed-off-by: Sudip Mukherjee Applied, thanks.

Re: [PATCH net-next 0/8] tou: Transports over UDP - part I

> We also now have to debug against every single userland TCP > implementation someone can come up with, the barrier to entry is > insanely low with TOU. Maybe this sounds great to you, but to me > it is quite terrifying > No, it doesn't sound great, but the major problem we have is that Android

Re: [net-next PATCH v3 00/17] Future-proof tunnel offload handlers

From: Alexander Duyck Date: Thu, 16 Jun 2016 12:20:35 -0700 > s patch is meant to address two things. First we are currently using > the ndo_add/del_vxlan_port calls with VXLAN-GPE tunnels and we cannot > really support that as it is likely to cause more harm than good

Re: [PATCH net-next 0/8] tou: Transports over UDP - part I

From: Tom Herbert Date: Thu, 16 Jun 2016 10:51:54 -0700 > The goal of this work is twofold: > > 1) Allow applications to run their own transport layer stack (i.e.from >userspace). This eliminates dependencies on the OS (e.g. solves a >major dependency issue for

[PATCH] ibmvnic: fix to use list_for_each_safe() when delete items

From: Wei Yongjun Since we will remove items off the list using list_del() we need to use a safe version of the list_for_each() macro aptly named list_for_each_safe(). Signed-off-by: Wei Yongjun ---

Re: [PATCH 0/7] Netfilter fixes for net

From: Pablo Neira Ayuso Date: Fri, 17 Jun 2016 20:25:12 +0200 > The following patchset contains Netfilter fixes for your net tree, > they are rather small patches but fixing several outstanding bugs in > nf_conntrack and nf_tables, as well as minor problems with missing >

[PATCH iproute2 -master] ss: Add tcp_info fields data_segs_in/out

tcp_info fields, data_segs_in and data_segs_out, have been added to the kernel in commit a44d6eacdaf5 ("tcp: Add RFC4898 tcpEStatsPerfDataSegsOut/In") since kernel 4.6. This patch supports those fileds in ss: ESTAB 801736 360face:face:face:face::1:22

Re: [iproute PATCH 1/3] Use C99 style initializers everywhere

On Sat, 18 Jun 2016 02:02:21 +0200 Phil Sutter wrote: > On Fri, Jun 17, 2016 at 11:57:53AM -0700, Stephen Hemminger wrote: > > It makes sense that if you can build a kernel with old toolchain, that > > iproute2 needs to be buildable as well. > > > > The current kernels are

Re: [for-next 0/1] [pull request] Mellanox ConnectX-4 Shared Code

On 6/16/2016 12:37 AM, David Miller wrote: > From: Leon Romanovsky > Date: Tue, 14 Jun 2016 13:29:11 +0300 > >> are available in the git repository at: >> >> g...@gitolite.kernel.org:pub/scm/linux/kernel/git/leon/linux-rdma >> tags/shared > > You need to learn how to

[PATCH v3 net-next v3 10/14] net: dsa: mv88e6xxx: add SMI init helper

Add an helper function to isolate SMI specific assignations and checks. This function will later help choosing the different SMI accesses based of the compatible info. Since the chip structure is already allocated in the legacy probe, use the mv88e6xxx_reg_read access routine instead of

[PATCH v3 net-next v3 01/14] net: dsa: mv88e6xxx: fix style issues

This patch fixes 5 style problems reported by checkpatch: WARNING: suspect code indent for conditional statements (8, 24) #492: FILE: drivers/net/dsa/mv88e6xxx.c:492: + if (phydev->link) + reg |= PORT_PCS_CTRL_LINK_UP; CHECK: Logical continuations should

[PATCH v3 net-next v3 02/14] net: dsa: mv88e6xxx: remove redundant assignments

The chip->ds and ds->slave_mii_bus assignments are common to both legacy and new MDIO probing and are already done in the later setup code. Remove the duplicated assignments from the MDIO probing code. Signed-off-by: Vivien Didelot Reviewed-by: Andrew Lunn

[PATCH v3 net-next v3 03/14] net: dsa: mv88e6xxx: use already declared variables

In the MDIO probing function, dev is already assigned to >dev and np is already assigned to mdiodev->dev.of_node, so use them. Signed-off-by: Vivien Didelot Reviewed-by: Andrew Lunn --- drivers/net/dsa/mv88e6xxx.c | 6 +++--- 1 file changed,

[PATCH v3 net-next v3 08/14] net: dsa: mv88e6xxx: rename smi_mutex to reg_lock

The chip smi_mutex mutex is used to protect the access to the internal switch registers, not only the Multi-chip Addressing Mode, as commented. Other registers access (like management frames) may use this mutex. Since we will isolate SMI-specific pieces of code, avoid the confusion now by

[PATCH v3 net-next v3 06/14] net: dsa: mv88e6xxx: use gpio get optional variant

Use the optional variant to get the reset GPIO line, instead of checking for the -ENOENT error. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6xxx.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git

[PATCH v3 net-next v3 05/14] net: dsa: mv88e6xxx: add switch register helpers

The mixed assignments, allocations and registrations in the probe code make it hard to follow the logic and figure out what is DSA or chip specific. Extract the struct dsa_switch related code in a simple mv88e6xxx_register_switch helper function. For symmetry in the code, add a

[PATCH v3 net-next v3 04/14] net: dsa: mv88e6xxx: do not increment bus refcount

The MDIO device probe and remove functions are respectively incrementing and decrementing the bus refcount themselves. Since these bus level actions are out of the device scope, remove them. Signed-off-by: Vivien Didelot Acked-by: Andrew Lunn

[PATCH v3 net-next v3 09/14] net: dsa: mv88e6xxx: add chip allocation helper

Add an helper function to allocate the chip structure at the beginning of the probe functions. It will be used to initialize the SMI access. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6xxx.c | 39 +++ 1 file

[PATCH v3 net-next v3 07/14] net: dsa: mv88e6xxx: remove table args in info lookup

The mv88e6xxx_table array and the mv88e6xxx_lookup_info function are static, so remove the table and size arguments from the lookup function. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6xxx.c | 16 ++-- 1 file changed, 6

[PATCH v3 net-next v3 13/14] net: dsa: mv88e6xxx: add addressing mode to info

When the SMI address of the switch chip is zero, the chip assumes to be the only one on the SMI master bus and thus responds to all its known SMI devices addresses (port registers, Global2, etc.) When its SMI address is not zero, some chips (e.g. 88E6352) use an indirect access through two SMI

[PATCH v3 net-next v3 14/14] net: dsa: mv88e6xxx: add port base address to info

The switch ID is located at address 0x3 of every Port Registers bank. But not all Marvell switches have their Port Registers SMI Addresses starting at 0x10. 88E6060 starts at 0x8 and 88E6390 starts at 0x0. Add this data in the info structure and use it in the detection code. Signed-off-by:

[PATCH v3 net-next v3 11/14] net: dsa: mv88e6xxx: add detection helper

Extract the common detection code which assigns the info structure to the chip given the read switch ID. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6xxx.c | 64 + 1 file changed, 30 insertions(+), 34

[PATCH v3 net-next v3 12/14] net: dsa: mv88e6xxx: pass compatible info

After allocating the chip structure, pass it a compatible info pointer. The compatible info structure will be used later to describe how to access the switch registers and where to read the switch ID. For the standard MDIO probe, get it from the device node data. For the legacy DSA driver

[PATCH v3 net-next v3 00/14] net: dsa: mv88e6xxx: probe compatible

This patchset factorizes the legacy DSA probing and the new MDIO probing functions with a few helpers. This will allow us to use a compatible chip info to describe how to access the SMI device and its switch ID register at probe time. For the legacy probe, we fix the compatible info to 88E6085.

Re: [iproute PATCH 1/3] Use C99 style initializers everywhere

Hi, [Replying to multiple mails at once due to laziness.] On Fri, Jun 17, 2016 at 06:09:20PM +0200, Daniel Borkmann wrote: > Hmm, seems like a lot of stuff ... It is. At some point I thought about maybe hack something in cocci instead, but that would probably have taken longer given the code

Re: [PATCH net-next 12/18] IB/mlx5: Add kernel offload flow-tag

On Fri, Jun 17, 2016 at 3:31 PM, Saeed Mahameed wrote: > On Fri, Jun 17, 2016 at 7:00 PM, Alexei Starovoitov > wrote: >> On Fri, Jun 17, 2016 at 05:43:53PM +0300, Saeed Mahameed wrote: >>> From: Maor Gottlieb >>> >>>

Re: [PATCH net-next 13/18] net: Add offload kernel net stack packet type

On Fri, Jun 17, 2016 at 6:15 PM, Daniel Borkmann wrote: > On 06/17/2016 04:43 PM, Saeed Mahameed wrote: >> >> From: Maor Gottlieb >> >> Add new packet type to skip kernel specific protocol handlers. >> >> This is needed so device drivers can pass packets

Re: [PATCH net-next 1/8] net: Change SKB_GSO_DODGY to be a tx_flag

On Thu, Jun 16, 2016 at 11:58 AM, Alexander Duyck wrote: > On Thu, Jun 16, 2016 at 10:51 AM, Tom Herbert wrote: >> This replaces gso_type SKB_GSO_DODGY with a new tx_flag named >> SKBTX_UNTRUSTED_SOURCE. This more generically desrcibes the skb >>

Re: [PATCH net-next 12/18] IB/mlx5: Add kernel offload flow-tag

On Fri, Jun 17, 2016 at 7:00 PM, Alexei Starovoitov wrote: > On Fri, Jun 17, 2016 at 05:43:53PM +0300, Saeed Mahameed wrote: >> From: Maor Gottlieb >> >> Add kernel offload flow tag for packets that will bypass the kernel >> stack, e.g

Re: act_mirred: remove spinlock in fast path

On Fri, Jun 17, 2016 at 2:59 PM, Cong Wang wrote: > Generally speaking I worry about we change multiple fields in a struct > meanwhile we could still read them any time in the middle, we may > get them correct for some easy case, but it is hard to insure the >

Re: act_mirred: remove spinlock in fast path

On Fri, Jun 17, 2016 at 2:40 PM, Eric Dumazet wrote: > On Fri, Jun 17, 2016 at 2:35 PM, Cong Wang wrote: >> On Fri, Jun 17, 2016 at 2:24 PM, Eric Dumazet wrote: >>> Well, I added a READ_ONCE() to read tcf_action once. >>> >>>

Re: [PATCH net-next v6] tcp: Add RFC4898 tcpEStatsPerfDataSegsOut/In

On Thu, Jun 16, 2016 at 09:30:28PM -0700, Eric Dumazet wrote: > On Mon, 2016-03-14 at 10:52 -0700, Martin KaFai Lau wrote: > > Per RFC4898, they count segments sent/received > > containing a positive length data segment (that includes > > retransmission segments carrying data). Unlike > >

Re: act_mirred: remove spinlock in fast path

On Fri, Jun 17, 2016 at 2:35 PM, Cong Wang wrote: > On Fri, Jun 17, 2016 at 2:24 PM, Eric Dumazet wrote: >> Well, I added a READ_ONCE() to read tcf_action once. >> >> Adding rcu here would mean adding a pointer and extra cache line, to >> deref the

Re: act_mirred: remove spinlock in fast path

On Fri, Jun 17, 2016 at 2:24 PM, Eric Dumazet wrote: > Well, I added a READ_ONCE() to read tcf_action once. > > Adding rcu here would mean adding a pointer and extra cache line, to > deref the values. > > IMHO the race here has no effect . You either read the old or new

[PATCH 1/2] net: ethernet: et131x: use phydev from struct net_device

The private structure contain a pointer to phydev, but the structure net_device already contain such pointer. So we can remove the pointer phydev in the private structure, and update the driver to use the one contained in struct net_device. Signed-off-by: Philippe Reynes ---

[PATCH 2/2] net: ethernet: et131x: use phy_ethtool_{get|set}_link_ksettings

There are two generics functions phy_ethtool_{get|set}_link_ksettings, so we can use them instead of defining the same code in the driver. Signed-off-by: Philippe Reynes --- drivers/net/ethernet/agere/et131x.c | 16 ++-- 1 files changed, 2 insertions(+), 14

Re: act_mirred: remove spinlock in fast path

On Fri, Jun 17, 2016 at 2:03 PM, Cong Wang wrote: > Hi, Eric > > During code review, I notice we might have some problem after we go > lockless for the fast path in act_mirred. > > That is, what prevents us from the following possible race condition? > > change a

Re: [PATCH net-next] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)

Netanel Belgazal : [...] More stuff below. > diff --git a/drivers/net/ethernet/amazon/ena/ena_com.c > b/drivers/net/ethernet/amazon/ena/ena_com.c > new file mode 100644 > index 000..357e10f > --- /dev/null > +++ b/drivers/net/ethernet/amazon/ena/ena_com.c [...] >

act_mirred: remove spinlock in fast path

Hi, Eric During code review, I notice we might have some problem after we go lockless for the fast path in act_mirred. That is, what prevents us from the following possible race condition? change a standalone action with tcf_mirred_init(): // search for an existing action in hash // found

Re: [PATCH net] RDS: TCP: rds_tcp_accept_one() should transition socket from RESETTING to UP

On 6/17/2016 1:12 PM, Sowmini Varadhan wrote: The state of the rds_connection after rds_tcp_reset_callbacks() would be RDS_CONN_RESETTING and this is the value that should be passed by rds_tcp_accept_one() to rds_connect_path_complete() to transition the socket to RDS_CONN_UP. Fixes:

Re: [iproute PATCH 1/3] Use C99 style initializers everywhere

On 6/17/16 2:36 PM, Daniel Borkmann wrote: Once again, you have to ask Nicolas or Julien for their RHEL version, not me ... please have a look at 8f80d450c3cb. ;) I did, just ran right over the Author ;-) I just pointed to the fact that this would basically undo their changes that they've

Re: [PATCH RFC] brcmfmac: support deleting MBSS AP interfaces

On 17 June 2016 at 21:00, Arend van Spriel wrote: > On 17-06-16 14:30, Rafał Miłecki wrote: >> On 1 June 2016 at 21:00, Arend van Spriel >> wrote: >>> On 01-06-16 16:36, Rafał Miłecki wrote: We already support adding extra (AP)

Re: [iproute PATCH 1/3] Use C99 style initializers everywhere

On 06/17/2016 10:15 PM, David Ahern wrote: On 6/17/16 12:57 PM, Stephen Hemminger wrote: On Fri, 17 Jun 2016 16:58:14 + Nicolas Dichtel wrote: Le 17/06/2016 18:46, Daniel Borkmann a écrit : On 06/17/2016 06:34 PM, Stephen Hemminger wrote: On Fri, 17 Jun 2016

[PATCH net] RDS: TCP: rds_tcp_accept_one() should transition socket from RESETTING to UP

The state of the rds_connection after rds_tcp_reset_callbacks() would be RDS_CONN_RESETTING and this is the value that should be passed by rds_tcp_accept_one() to rds_connect_path_complete() to transition the socket to RDS_CONN_UP. Fixes: b5c21c0947c1 ("RDS: TCP: fix race windows in send-path

Re: [iproute PATCH 1/3] Use C99 style initializers everywhere

On 6/17/16 12:57 PM, Stephen Hemminger wrote: On Fri, 17 Jun 2016 16:58:14 + Nicolas Dichtel wrote: Le 17/06/2016 18:46, Daniel Borkmann a écrit : On 06/17/2016 06:34 PM, Stephen Hemminger wrote: On Fri, 17 Jun 2016 16:09:20 + Daniel Borkmann

[net-next,v3] openvswitch: Add packet len info to upcall.

The commit f2a4d086ed4c ("openvswitch: Add packet truncation support.") introduces packet truncation before sending to userspace upcall receiver. This patch passes up the skb->len before truncation so that the upcall receiver knows the original packet size. Potentially this will be used by sFlow,

Re: [PATCH] net: tilegx: use correct timespec64 type

On Fri, Jun 17, 2016 at 06:15:30PM +0200, Arnd Bergmann wrote: > The conversion to the 64-bit time based ptp methods left two instances > of 'struct timespec' in place. This is harmless because 64-bit > architectures define timespec64 as timespec, and this driver is > not used on 32-bit machines.

Re: [PATCH iproute2 net-next 3/5] bridge: add json support for bridge fdb show

On Fri, Jun 17, 2016 at 12:04 PM, Stephen Hemminger wrote: > On Fri, 17 Jun 2016 11:04:54 -0700 > Anuradha Karuppiah wrote: > >> On Tue, May 31, 2016 at 12:22 PM, Anuradha Karuppiah >> wrote: >> > On Tue,

Re: [PATCH iproute2 net-next 3/5] bridge: add json support for bridge fdb show

On Fri, 17 Jun 2016 11:04:54 -0700 Anuradha Karuppiah wrote: > On Tue, May 31, 2016 at 12:22 PM, Anuradha Karuppiah > wrote: > > On Tue, May 31, 2016 at 11:59 AM, Stephen Hemminger > > wrote: > >> On Fri,

Re: [PATCH RFC] brcmfmac: support deleting MBSS AP interfaces

On 17-06-16 14:30, Rafał Miłecki wrote: > On 1 June 2016 at 21:00, Arend van Spriel > wrote: >> On 01-06-16 16:36, Rafał Miłecki wrote: >>> We already support adding extra (AP) interfaces so it also makes an >>> obvious sense to allow deleting them. >>> >>> Adding a

Re: [iproute PATCH 1/3] Use C99 style initializers everywhere

On Fri, 17 Jun 2016 16:58:14 + Nicolas Dichtel wrote: > Le 17/06/2016 18:46, Daniel Borkmann a écrit : > > On 06/17/2016 06:34 PM, Stephen Hemminger wrote: > >> On Fri, 17 Jun 2016 16:09:20 + > >> Daniel Borkmann wrote: > >> > >>> Please

Re: [RFC PATCH 1/1] net/ipv4: Enable flow-based ECMP

Richard Laing alliedtelesis.co.nz> writes: > >>> Fair enough, I will look at making it a sysctl option. I guess the > >>> default can be the current behaviour. > Cheers > Richard > Hi Richard, Could you please share if this new patch for per-flow IPv4 ECMP has landed? If so, which version

Re: [PATCH net-next v3] tcp: use RFC6298 compliant TCP RTO calculation

On Fri, Jun 17, 2016 at 11:32 AM, David Miller wrote: > > From: Daniel Metz > Date: Wed, 15 Jun 2016 20:00:03 +0200 > > > This patch adjusts Linux RTO calculation to be RFC6298 Standard > > compliant. MinRTO is no longer added to the computed RTO, RTO damping

Re: Per-flow IPv4 ECMP

Peter Nørlund ordbogen.com> writes: > > This is being worked on currently by Peter Nørlund > > https://lwn.net/Articles/657431/ > Hi Peter, Following up on this thread, has the new patch for supporting per-flow IPv4 ECMP landed? Which version should I be able to use that has this feature?

Re: [PATCH -next] RDS: TCP: Fix non static symbol warnings

On 6/17/2016 11:12 AM, weiyj...@163.com wrote: From: Wei Yongjun Fixes the following sparse warnings: net/rds/tcp.c:59:5: warning: symbol 'rds_tcp_min_sndbuf' was not declared. Should it be static? net/rds/tcp.c:60:5: warning: symbol 'rds_tcp_min_rcvbuf' was

Re: PATCH 1/1] AX.25: Close socket connection on session completion

From: Basil Gunn Date: Thu, 16 Jun 2016 09:42:30 -0700 > A socket connection made in ax.25 is not closed when session is > completed. The heartbeat timer is stopped prematurely and this is > where the socket gets closed. Allow heatbeat timer to run to close > socket.

Re: [PATCH net-next v3] tcp: use RFC6298 compliant TCP RTO calculation

From: Daniel Metz Date: Wed, 15 Jun 2016 20:00:03 +0200 > This patch adjusts Linux RTO calculation to be RFC6298 Standard > compliant. MinRTO is no longer added to the computed RTO, RTO damping > and overestimation are decreased. ... Yuchung, I assume I am waiting for you to do

Re: [PATCH -next] RDS: TCP: Fix non static symbol warnings

On (06/17/16 18:12), weiyj...@163.com wrote: > From: Wei Yongjun > > Fixes the following sparse warnings: > > net/rds/tcp.c:59:5: warning: > symbol 'rds_tcp_min_sndbuf' was not declared. Should it be static? > net/rds/tcp.c:60:5: warning: > symbol

[PATCH 5/7] netfilter: nf_tables: fix a wrong check to skip the inactive rules

From: Liping Zhang nft_genmask_cur has already done left-shift operator on the gencursor, so there's no need to do left-shift operator on it again. Fixes: ea4bd995b0f2 ("netfilter: nf_tables: add transaction helper functions") Cc: Patrick McHardy

[PATCH 4/7] netfilter: nf_tables: fix wrong destroy anonymous sets if binding fails

From: Liping Zhang When we add a nft rule like follows: # nft add rule filter test tcp dport vmap {1: jump test} -ELOOP error will be returned, and the anonymous set will be destroyed. But after that, nf_tables_abort will also try to remove the element and destroy

[PATCH 6/7] netfilter: xt_SYNPROXY: add missing header to Kbuild

Matt Whitlock says: Without this line, the file xt_SYNPROXY.h does not get installed in /usr/include/linux/netfilter/, and thus user-space programs cannot make use of it. Reported-by: Matt Whitlock Signed-off-by: Pablo Neira Ayuso ---

[PATCH 2/7] netfilter: nf_tables: fix wrong check of NFT_SET_MAP in nf_tables_bind_set

From: Liping Zhang We should check "i" is used as a dictionary or not, "binding" is already checked before. Signed-off-by: Liping Zhang Signed-off-by: Pablo Neira Ayuso --- net/netfilter/nf_tables_api.c | 2 +- 1

[PATCH 3/7] netfilter: nf_tables: reject loops from set element jump to chain

Liping Zhang says: "Users may add such a wrong nft rules successfully, which will cause an endless jump loop: # nft add rule filter test tcp dport vmap {1: jump test} This is because before we commit, the element in the current anonymous set is inactive, so osp->walk will skip this element

[PATCH 0/7] Netfilter fixes for net

Hi David, The following patchset contains Netfilter fixes for your net tree, they are rather small patches but fixing several outstanding bugs in nf_conntrack and nf_tables, as well as minor problems with missing SYNPROXY header uapi installation: 1) Oneliner not to leak conntrack kmemcache on

[PATCH 1/7] netfilter: conntrack: destroy kmemcache on module removal

From: Florian Westphal I forgot to move the kmem_cache_destroy into the exit path. Fixes: 0c5366b3a8c7 ("netfilter: conntrack: use single slab cache) Signed-off-by: Florian Westphal Signed-off-by: Pablo Neira Ayuso ---

[PATCH 7/7] netfilter: xt_SYNPROXY: include missing

./usr/include/linux/netfilter/xt_SYNPROXY.h:11: found __[us]{8,16,32,64} type without #include Reported-by: kbuild test robot Signed-off-by: Pablo Neira Ayuso --- include/uapi/linux/netfilter/xt_SYNPROXY.h | 2 ++ 1 file changed, 2 insertions(+) diff

[PATCH -next] RDS: TCP: Fix non static symbol warnings

From: Wei Yongjun Fixes the following sparse warnings: net/rds/tcp.c:59:5: warning: symbol 'rds_tcp_min_sndbuf' was not declared. Should it be static? net/rds/tcp.c:60:5: warning: symbol 'rds_tcp_min_rcvbuf' was not declared. Should it be static? Signed-off-by:

Re: [PATCH iproute2 net-next 3/5] bridge: add json support for bridge fdb show

On Tue, May 31, 2016 at 12:22 PM, Anuradha Karuppiah wrote: > On Tue, May 31, 2016 at 11:59 AM, Stephen Hemminger > wrote: >> On Fri, 27 May 2016 21:37:14 -0700 >> Roopa Prabhu wrote: >> >>> Sample output: >>>

[PATCH] net:liquidio: remove unused including

From: Wei Yongjun Remove including that don't need it. Signed-off-by: Wei Yongjun --- drivers/net/ethernet/cavium/liquidio/octeon_device.c | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH] gtp: remove unused including

From: Wei Yongjun Remove including that don't need it. Signed-off-by: Wei Yongjun --- drivers/net/gtp.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c index 4e976a0..97e0cbc 100644 ---

Re: [BUG] act_ife: sleeping functions called in atomic context

On Fri, Jun 17, 2016 at 4:07 AM, Jamal Hadi Salim wrote: > On 16-06-17 01:38 AM, Cong Wang wrote: >> >> On Thu, Jun 16, 2016 at 7:14 PM, Cong Wang >> wrote: >>> >>> >>> I think we can just remove that tcf_lock, I am testing a patch now. >> >> >>

Re: [BUG] act_ife: sleeping functions called in atomic context

On Fri, Jun 17, 2016 at 4:05 AM, Alexey Khoroshilov wrote: > On 17.06.2016 08:38, Cong Wang wrote: >> On Thu, Jun 16, 2016 at 7:14 PM, Cong Wang wrote: >>> >>> I think we can just remove that tcf_lock, I am testing a patch now. >> >> Please try

Re: [patch net-next v4 0/4] return offloaded stats as default and expose original sw stats

On 06/17/2016 08:42 AM, Jiri Pirko wrote: > Fri, Jun 17, 2016 at 05:35:53PM CEST, d...@cumulusnetworks.com wrote: >> On 6/17/16 8:54 AM, Jamal Hadi Salim wrote: >>> On 16-06-17 10:05 AM, Jiri Pirko wrote: Fri, Jun 17, 2016 at 03:48:35PM CEST, d...@cumulusnetworks.com wrote: > On 6/17/16

Re: [iproute PATCH 1/3] Use C99 style initializers everywhere

Le 17/06/2016 18:46, Daniel Borkmann a écrit : > On 06/17/2016 06:34 PM, Stephen Hemminger wrote: >> On Fri, 17 Jun 2016 16:09:20 + >> Daniel Borkmann wrote: >> >>> Please have a look at commit 8f80d450c3cb ("tc: fix compilation with old gcc >>> (< 4.6)") ... >>> >>>

Re: [PATCH net-next 0/8] tou: Transports over UDP - part I

On Thu, Jun 16, 2016 at 4:15 PM, Hannes Frederic Sowa wrote: > On 16.06.2016 19:51, Tom Herbert wrote: >> Transports over UDP is intended to encapsulate TCP and other transport >> protocols directly and securely in UDP. >> >> The goal of this work is twofold: >> >> 1)

Re: [PATCH net-next 12/18] IB/mlx5: Add kernel offload flow-tag

On 16-06-17 09:00 AM, Alexei Starovoitov wrote: > On Fri, Jun 17, 2016 at 05:43:53PM +0300, Saeed Mahameed wrote: >> From: Maor Gottlieb >> >> Add kernel offload flow tag for packets that will bypass the kernel >> stack, e.g (RoCE/RDMA/RAW ETH (DPDK), etc ..). > > so the

Re: [iproute PATCH 1/3] Use C99 style initializers everywhere

On 06/17/2016 06:34 PM, Stephen Hemminger wrote: On Fri, 17 Jun 2016 16:09:20 + Daniel Borkmann wrote: Please have a look at commit 8f80d450c3cb ("tc: fix compilation with old gcc (< 4.6)") ... Your changes effectively revert them again. Here, and some other parts

Re: [iproute PATCH 1/3] Use C99 style initializers everywhere

On Fri, 17 Jun 2016 16:09:20 + Daniel Borkmann wrote: > Please have a look at commit 8f80d450c3cb ("tc: fix compilation with old gcc > (< 4.6)") ... > > Your changes effectively revert them again. Here, and some other parts of the > bpf frontend > code bits. GCC

[PATCH] net: tilegx: use correct timespec64 type

The conversion to the 64-bit time based ptp methods left two instances of 'struct timespec' in place. This is harmless because 64-bit architectures define timespec64 as timespec, and this driver is not used on 32-bit machines. However, using 'struct timespec64' directly is obviously the right

Re: [PATCH 1/2] mlx5: only register devlink when ethernet is available

On Fri, Jun 17, 2016 at 05:02:33PM +0200, Arnd Bergmann wrote: > On Friday, June 17, 2016 5:50:14 PM CEST Saeed Mahameed wrote: > > On Wed, Jun 15, 2016 at 11:50 PM, Arnd Bergmann wrote: > > > On Wednesday, June 15, 2016 7:04:54 PM CEST Saeed Mahameed wrote: > > > Ok, I see. It

Re: [iproute PATCH 1/3] Use C99 style initializers everywhere

On 06/17/2016 05:56 PM, Phil Sutter wrote: This big patch was compiled by vimgrepping for memset calls and changing to C99 initializer if applicable. Calls to memset for struct rtattr pointer fields for parse_rtattr*() were just dropped since they are not needed. The changes here allowed the

Re: [PATCH resend] net: sock: Add option for memory optimized hints.

On Fri, 2016-06-17 at 16:39 +0200, peter enderborg wrote: > It is mainly for af_unix sockets, and the effect is > quite significant when you hit a compaction, or with > this patch avoid get in to compaction, but it > can also be used for reducing the pressure on memory > for tcp. BTW, TCP always

Re: [PATCH resend] net: sock: Add option for memory optimized hints.

On Fri, 2016-06-17 at 16:39 +0200, peter enderborg wrote: > On 06/17/2016 04:14 PM, Eric Dumazet wrote: > > On Fri, 2016-06-17 at 15:58 +0200, peter enderborg wrote: > >> From: Peter Enderborg > >> > >> When sending data the socket allocates memory for > >> payload

  1   2   >