[PATCH v3] mac80211: mesh: set tx_info->hw_queue to the correct queue upon packet forwarding

2016-08-08 Thread Yaniv Machani
From: Meirav Kama MP received data frames from another MP. Frames are forwarded from Rx to Tx to be transmitted to a third MP. Upon cloning the skb, the tx_info was zeroed, and the hw_queue wasn't set correctly, causing frames to be inserted to queue 0 (VOICE). If re-queue occurred for some reaso

[RFC PATCH v4 2/2] net: phy: Add gmiitorgmii converter support

2016-08-08 Thread Kedareswara rao Appana
This patch adds support for gmiitorgmii converter. The GMII to RGMII IP core provides the Reduced Gigabit Media Independent Interface (RGMII) between Ethernet physical media Devices and the Gigabit Ethernet controller. This core can Switch dynamically between the three different speed modes of Ope

[RFC PATCH v4 1/2] Documentation: DT: net: Add Xilinx gmiitorgmii converter device tree binding documentation

2016-08-08 Thread Kedareswara rao Appana
Device-tree binding documentation for xilinx gmiitorgmii converter. Signed-off-by: Kedareswara rao Appana --- Changes for v4: --> Modified compatible as suggested by Rob. --> Removed underscores from the converter node name as suggested by Rob. Changes for v3: --> None. Changes for v2: --> New pa

Re: [patch iproute2 1/2] devlink: write usage help messages to stderr

2016-08-08 Thread Jiri Pirko
Sat, Jul 23, 2016 at 06:46:59PM CEST, step...@networkplumber.org wrote: >On Fri, 22 Jul 2016 18:34:29 +0200 >Jiri Pirko wrote: > >> From: Jiri Pirko >> >> In order to not confuse reader, write help messages into stderr. >> >> Signed-off-by: Jiri Pirko > >This does make devlink consistent with

Re: [PATCH RESEND] net: can: Introduce MEN 16Z192-00 CAN controller driver

2016-08-08 Thread Andreas Werner
On Sun, Aug 07, 2016 at 08:58:14PM -0700, Benjamin Poirier wrote: > On 2016/07/26 11:16, Andreas Werner wrote: > [...] > > + > > + /* Lock for CTL_BTR register access. > > +* This register combines bittiming bits > > +* and the operation mode bits. > > +* It is also used for bit r/m/w

[PATCH 2/2] mwifiex: simplify length computation for some memset

2016-08-08 Thread Christophe JAILLET
This patch should be a no-op. It just simplifies code by using the name of a variable instead of its type when calling 'sizeof'. Signed-off-by: Christophe JAILLET --- drivers/net/wireless/marvell/mwifiex/sta_ioctl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/

[PATCH 1/2] mwifiex: fix the length parameter of a memset

2016-08-08 Thread Christophe JAILLET
In 'mwifiex_get_ver_ext', we have: struct mwifiex_ver_ext ver_ext; memset(&ver_ext, 0, sizeof(struct host_cmd_ds_version_ext)); This is likely that memset'ing sizeof(struct mwifiex_ver_ext) was expected. Remove the ambiguity by using the variable name directly instead of its type. Signed-o

[PATCH net] net: ipv6: Fix ping to link-local addresses.

2016-08-08 Thread Lorenzo Colitti
ping_v6_sendmsg never sets flowi6_oif, so it is not possible to ping an IPv6 address on a different interface. Instead, it sets flowi6_iif, which is incorrect but harmless. Also, it returns an error if a passed-in scope ID doesn't match sk_bound_dev_if. Get rid of the error, stop setting flowi6_ii

Re: order-0 vs order-N driver allocation. Was: [PATCH v10 07/12] net/mlx4_en: add page recycle to prepare rx ring for tx support

2016-08-08 Thread Jesper Dangaard Brouer
On Sun, 7 Aug 2016 19:15:27 -0700 Alexei Starovoitov wrote: > On Fri, Aug 05, 2016 at 09:15:33AM +0200, Eric Dumazet wrote: > > On Thu, 2016-08-04 at 18:19 +0200, Jesper Dangaard Brouer wrote: > > > > > I actually agree, that we should switch to order-0 allocations. > > > > > > *BUT* this w

A potential race in drivers/atm/eni.ko

2016-08-08 Thread Pavel Andrianov
Hi! There is a potential race in drivers/atm/eni.ko. In the interrupt handler eni_int the field eni_dev->events is masked (line 1519) with a spinlock protection. In eni_start eni_dev->events is initialized (line 1844), but it is done after interrupts are requested (line 1813). Thus, the inter

Re: [PATCH v4 1/1] rps: Inspect PPTP encapsulated by GRE to get flow hash

2016-08-08 Thread Feng Gao
Hi Philip, Do you mean like the following? struct gre_full_hdr { struct { __be16 flags; __be16 protocol; } fixed_header; __be16 csum; __be16 reserved1; __be32 key; __be32 seq; } __packed; But we need struct gre_base_

[PATCH] sunrpc: Remove unnecessary variable

2016-08-08 Thread Amitoj Kaur Chawla
The variable `err` is not used anywhere and just returns the predefined value `0` at the end of the function. Hence, remove the variable and return 0 explicitly. Signed-off-by: Amitoj Kaur Chawla --- net/sunrpc/clnt.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/sunr

Re: [net-next 0/2] BPF, kprobes: Add current_in_cgroup helper

2016-08-08 Thread Daniel Borkmann
On 08/08/2016 05:52 AM, Alexei Starovoitov wrote: On Sun, Aug 07, 2016 at 08:08:19PM -0700, Sargun Dhillon wrote: Thanks for your feedback Alexei, I really appreciate it. On Sun, Aug 07, 2016 at 05:52:36PM -0700, Alexei Starovoitov wrote: On Sat, Aug 06, 2016 at 09:56:06PM -0700, Sargun Dhillo

Re;跨境电商物流供应商

2016-08-08 Thread Paul Tsang
Dear Sir/Miss This is the e-mail from Paul of HAOCHING INT'L LOGISTICS LTD in China. Our company is a well-staffed freight forwarding and logistics service company located in Shenzhen/Dongguan/Guangzhou/HuiZhou/Zhongshan GuangDong Province china,and provide safety, convenient and speedy logistic

Re: [PATCH RESEND] net: can: Introduce MEN 16Z192-00 CAN controller driver

2016-08-08 Thread Wolfgang Grandegger
Hello Andreas, a first quick review Am 26.07.2016 um 11:16 schrieb Andreas Werner: This CAN Controller is found on MEN Chameleon FPGAs. The driver/device supports the CAN2.0 specification. There are 255 RX and 255 Tx buffer within the IP. The pointer for the buffer are handled by HW to mak

[PATCH] [net] rxrpc: fix uninitialized pointer dereference in debug code

2016-08-08 Thread Arnd Bergmann
A newly added bugfix caused an uninitialized variable to be used for printing debug output. This is harmless as long as the debug setting is disabled, but otherwise leads to an immediate crash. gcc warns about this when -Wmaybe-uninitialized is enabled: net/rxrpc/call_object.c: In function 'rxrpc

[RFC PATCH 1/3] net: Remove unnecessary memset in __snmp6_fill_stats64

2016-08-08 Thread Jia He
buff[] will be assigned later, so memset is not necessary. Signed-off-by: Jia He Cc: "David S. Miller" Cc: Alexey Kuznetsov Cc: James Morris Cc: Hideaki YOSHIFUJI Cc: Patrick McHardy --- net/ipv6/addrconf.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/ipv6/addrconf.c b/net/ipv6/ad

[RFC PATCH 0/3] net: Improve snmp6_fill_stats

2016-08-08 Thread Jia He
This is the follow up work of commit a3a773726c9f ("net: Optimize snmp stat aggregation by walking all the percpu data at once") Jia He (3): net: Remove unnecessary memset in __snmp6_fill_stats64 net: Replace for_each_possible_cpu with for_each_online_cpu net: Remove the useless parameter

[RFC PATCH 3/3] net: Remove the useless parameter of __snmp6_fill_statsdev

2016-08-08 Thread Jia He
In commit a3a773726c9f ("net: Optimize snmp stat aggregation by walking all the percpu data at once"), __snmp6_fill_stats64 had been optimized by removing parameter items, so do the same for __snmp6_fill_statsdev. Signed-off-by: Jia He Cc: "David S. Miller" Cc: Alexey Kuznetsov Cc: James Morr

[RFC PATCH 2/3] net: Replace for_each_possible_cpu with for_each_online_cpu

2016-08-08 Thread Jia He
In PowerPC server with large number cpus, the loop index in smt=1 could be reduced to 1/8 compared with smt=8. Thus cache misses can be reduced. Signed-off-by: Jia He Cc: "David S. Miller" Cc: Alexey Kuznetsov Cc: James Morris Cc: Hideaki YOSHIFUJI Cc: Patrick McHardy --- net/ipv6/addrconf

Re: [RFC PATCH v4 1/2] Documentation: DT: net: Add Xilinx gmiitorgmii converter device tree binding documentation

2016-08-08 Thread Michal Simek
On 8.8.2016 09:15, Kedareswara rao Appana wrote: > Device-tree binding documentation for xilinx gmiitorgmii converter. > > Signed-off-by: Kedareswara rao Appana > --- > Changes for v4: > --> Modified compatible as suggested by Rob. > --> Removed underscores from the converter node name as suggest

Re: gpf in p9_client_read

2016-08-08 Thread Vlastimil Babka
With merge window gone, ping? On 07/27/2016 11:21 AM, Vlastimil Babka wrote: > Hi, > > I was fuzzing with trinity in qemu via the virtme script, i.e. using > these opts: > > virtme-run --kdir /home/vbabka/wrk/linus.git --rwdir > /home/vbabka/tmp/trinity/ --dry-run --show-command --qemu-opts --

Re: [PATCH v2] netfilter: nf_conntrack_sip: CSeq 0 is a valid CSeq

2016-08-08 Thread Pablo Neira Ayuso
On Wed, Aug 03, 2016 at 12:41:40PM +0200, Christophe Leroy wrote: > Do not drop packet when CSeq is 0 as 0 is also a valid value for CSeq. > > simple_strtoul() will return 0 either when all digits are 0 > or if there are no digits at all. Therefore when simple_strtoul() > returns 0 we check if fir

Re: [RFC PATCH 1/3] net: Remove unnecessary memset in __snmp6_fill_stats64

2016-08-08 Thread Florian Westphal
Jia He wrote: > buff[] will be assigned later, so memset is not necessary. > > Signed-off-by: Jia He > Cc: "David S. Miller" > Cc: Alexey Kuznetsov > Cc: James Morris > Cc: Hideaki YOSHIFUJI > Cc: Patrick McHardy > --- > net/ipv6/addrconf.c | 1 - > 1 file changed, 1 deletion(-) > > diff

Re: 4.6.3, pppoe + shaper workload, skb_panic / skb_push / ppp_start_xmit

2016-08-08 Thread Denys Fedoryshchenko
On 2016-08-01 23:59, Guillaume Nault wrote: Do you still have the vmlinux file with debug symbols that generated this panic? Sorry for delay, i didn't had same image on all servers and probably i found cause of panic, but still testing on several servers. If i remove SFQ qdisc from ppp shapers,

Re: [PATCH RESEND] net: can: Introduce MEN 16Z192-00 CAN controller driver

2016-08-08 Thread Andreas Werner
On Mon, Aug 08, 2016 at 11:27:25AM +0200, Wolfgang Grandegger wrote: > Hello Andreas, > > a first quick review > > Am 26.07.2016 um 11:16 schrieb Andreas Werner: > >This CAN Controller is found on MEN Chameleon FPGAs. > > > >The driver/device supports the CAN2.0 specification. > >There are 25

Re: [PATCH net] sctp: use event->chunk when it's valid

2016-08-08 Thread Marcelo Ricardo Leitner
On Sun, Aug 07, 2016 at 02:15:13PM +0800, Xin Long wrote: > Commit 52253db924d1 ("sctp: also point GSO head_skb to the sk when > it's available") used event->chunk->head_skb to get the head_skb in > sctp_ulpevent_set_owner(). > > But at that moment, the event->chunk was NULL, as it cloned the skb

Re: [PATCH RESEND] net: can: Introduce MEN 16Z192-00 CAN controller driver

2016-08-08 Thread Wolfgang Grandegger
Hello, Am 08.08.2016 um 13:39 schrieb Andreas Werner: On Mon, Aug 08, 2016 at 11:27:25AM +0200, Wolfgang Grandegger wrote: Hello Andreas, a first quick review Am 26.07.2016 um 11:16 schrieb Andreas Werner: This CAN Controller is found on MEN Chameleon FPGAs. The driver/device supports t

Re: [PATCH net-next] cdc_ether: Improve ZTE MF823/831/910 handling

2016-08-08 Thread Bjørn Mork
Oliver Neukum writes: > On Mon, 2016-07-18 at 16:10 +0200, Kristian Evensen wrote: >> On Mon, Jul 18, 2016 at 3:50 PM, Oliver Neukum wrote: >> > No, you misunderstand me. I don't want quirks if we can avoid it. >> > But if you need to do this for rndis_host and cdc_ether and maybe other >> > driv

Re: [PATCH] [net] rxrpc: fix uninitialized pointer dereference in debug code

2016-08-08 Thread David Howells
Arnd Bergmann wrote: > A newly added bugfix caused an uninitialized variable to be > used for printing debug output. This is harmless as long > as the debug setting is disabled, but otherwise leads to an > immediate crash. > > gcc warns about this when -Wmaybe-uninitialized is enabled: > > net/

Re: [RFC PATCH 1/3] net: Remove unnecessary memset in __snmp6_fill_stats64

2016-08-08 Thread hejianet
Yes, sorry about it,I am too hasty B.R. Jia He On 8/8/16 7:12 PM, Florian Westphal wrote: Jia He wrote: buff[] will be assigned later, so memset is not necessary. Signed-off-by: Jia He Cc: "David S. Miller" Cc: Alexey Kuznetsov Cc: James Morris Cc: Hideaki YOSHIFUJI Cc: Patrick McHardy

RE: [RFC PATCH v4 1/2] Documentation: DT: net: Add Xilinx gmiitorgmii converter device tree binding documentation

2016-08-08 Thread Appana Durga Kedareswara Rao
Hi Michal, > On 8.8.2016 09:15, Kedareswara rao Appana wrote: > > Device-tree binding documentation for xilinx gmiitorgmii converter. > > > > Signed-off-by: Kedareswara rao Appana > > --- > > Changes for v4: > > --> Modified compatible as suggested by Rob. > > --> Removed underscores from the con

Re: [PATCH RESEND] net: can: Introduce MEN 16Z192-00 CAN controller driver

2016-08-08 Thread Kurt Van Dijck
--- Original message --- > Date: Mon, 8 Aug 2016 14:28:39 +0200 > From: Wolfgang Grandegger > [...] > >>>+ > >>>+ if (!(cf->can_id & CAN_RTR_FLAG)) { > >>>+ writel(data[0], &cf_buf->data[0]); > >>>+ writel(data[1], &cf_buf->data[1]); > >> > >>Why do you not check cf->can_dlc h

Re: [PATCH net] sctp: use event->chunk when it's valid

2016-08-08 Thread Neil Horman
On Sun, Aug 07, 2016 at 02:15:13PM +0800, Xin Long wrote: > Commit 52253db924d1 ("sctp: also point GSO head_skb to the sk when > it's available") used event->chunk->head_skb to get the head_skb in > sctp_ulpevent_set_owner(). > > But at that moment, the event->chunk was NULL, as it cloned the skb

Re: [PATCH] sunrpc: Remove unnecessary variable

2016-08-08 Thread Anna Schumaker
On 08/08/2016 05:13 AM, Amitoj Kaur Chawla wrote: > The variable `err` is not used anywhere and just returns the > predefined value `0` at the end of the function. Hence, remove the > variable and return 0 explicitly. Makes sense to me. Thanks! Anna > > Signed-off-by: Amitoj Kaur Chawla > ---

[PATCH v1 1/1] net: phy: Add edge-rate, mac-if, read, write func to Microsemi PHYs.

2016-08-08 Thread Nagaraju Lakkaraju
crosemi PHYsBcc: Subject: [PATCH v1 1/1] net: phy: Add edge-rate, mac-if, read, write func to Reply-To: Nagaraju Lakkaraju Hello, As part of 2nd patch, Add Edge rate control, MAC Interface, Read and write driver functions add for Microsemi PHYs. Please review and send your comments. Thanks

Re: [PATCH net-next] cdc_ether: Improve ZTE MF823/831/910 handling

2016-08-08 Thread Oliver Neukum
On Mon, 2016-08-08 at 14:44 +0200, Bjørn Mork wrote: > Oliver Neukum writes: > > I don't see how it would be specific for a subsystem. If the patch > > is correct, it belongs into the networking core. > > The bug is in the firmware implementation of the "read unique vendor > assigned mac address

Re: [PATCH RESEND] net: can: Introduce MEN 16Z192-00 CAN controller driver

2016-08-08 Thread Andreas Werner
On Mon, Aug 08, 2016 at 02:28:39PM +0200, Wolfgang Grandegger wrote: > Hello, > > Am 08.08.2016 um 13:39 schrieb Andreas Werner: > >On Mon, Aug 08, 2016 at 11:27:25AM +0200, Wolfgang Grandegger wrote: > >>Hello Andreas, > >> > >>a first quick review > >> > >>Am 26.07.2016 um 11:16 schrieb Andr

Re: [PATCH RESEND] net: can: Introduce MEN 16Z192-00 CAN controller driver

2016-08-08 Thread Andreas Werner
On Mon, Aug 08, 2016 at 03:06:33PM +0200, Kurt Van Dijck wrote: > > --- Original message --- > > Date: Mon, 8 Aug 2016 14:28:39 +0200 > > From: Wolfgang Grandegger > > > [...] > > >>>+ > > >>>+if (!(cf->can_id & CAN_RTR_FLAG)) { > > >>>+writel(data[0], &cf_buf->data

[5.3] ucc_geth: Fix to avoid IS_ERR_VALUE abuses and dead code on 64bit systems.

2016-08-08 Thread Arvind Yadav
IS_ERR_VALUE() assumes that parameter is an unsigned long. It can not be used to check if 'unsigned int' is passed insted. Which tends to reflect an error. In 64bit architectures sizeof (int) == 4 && sizeof (long) == 8. IS_ERR_VALUE(x) is ((x) >= (unsigned long)-4095). IS_ERR_VALUE() of 'unsigned i

Re: [PATCH net] net: ipv6: Fix ping to link-local addresses.

2016-08-08 Thread Hannes Frederic Sowa
On 08.08.2016 09:42, Lorenzo Colitti wrote: > ping_v6_sendmsg never sets flowi6_oif, so it is not possible to > ping an IPv6 address on a different interface. Instead, it sets > flowi6_iif, which is incorrect but harmless. Also, it returns an > error if a passed-in scope ID doesn't match sk_bound_d

Re: [PATCH RESEND] net: can: Introduce MEN 16Z192-00 CAN controller driver

2016-08-08 Thread Wolfgang Grandegger
Am 08.08.2016 um 16:05 schrieb Andreas Werner: On Mon, Aug 08, 2016 at 02:28:39PM +0200, Wolfgang Grandegger wrote: Hello, Am 08.08.2016 um 13:39 schrieb Andreas Werner: On Mon, Aug 08, 2016 at 11:27:25AM +0200, Wolfgang Grandegger wrote: Hello Andreas, a first quick review Am 26.07.201

Re: [PATCH net] net: ipv6: Fix ping to link-local addresses.

2016-08-08 Thread Lorenzo Colitti
On Mon, Aug 8, 2016 at 11:26 PM, Hannes Frederic Sowa wrote: >> - if (sk->sk_bound_dev_if && >> - sk->sk_bound_dev_if != u->sin6_scope_id) { >> - return -EINVAL; >> - } > > Hmm, sk->sk_bound_dev_if always has highest prio for the selectio

RE: [5.3] ucc_geth: Fix to avoid IS_ERR_VALUE abuses and dead code on 64bit systems.

2016-08-08 Thread David Laight
From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On Behalf Of Arvind Yadav > IS_ERR_VALUE() assumes that parameter is an unsigned long. > It can not be used to check if 'unsigned int' is passed insted. > Which tends to reflect an error. > In 64bit architectures sizeof (int)

Re: [5.3] ucc_geth: Fix to avoid IS_ERR_VALUE abuses and dead code on 64bit systems.

2016-08-08 Thread Arnd Bergmann
On Monday, August 8, 2016 2:49:11 PM CEST David Laight wrote: > > > If qe_muram_alloc will return any error, Then IS_ERR_VALUE will always > > return 0. it'll not call ucc_fast_free for any failure. Inside 'if code' > > will be a dead code on 64bit. Even qe_muram_addr will return wrong > > virtual

Re: [PATCH v4 1/1] rps: Inspect PPTP encapsulated by GRE to get flow hash

2016-08-08 Thread Philp Prindeville
No, I was referring to anonymous structures, which is a feature of C11. Please see the link I sent. On 08/08/2016 03:13 AM, Feng Gao wrote: Hi Philip, Do you mean like the following? struct gre_full_hdr { struct { __be16 flags; __be16 protocol;

Re: [ovs-dev] [PATCH net-next v11 5/6] openvswitch: add layer 3 flow/port support

2016-08-08 Thread Simon Horman
On Wed, Jul 20, 2016 at 11:06:37AM -0700, pravin shelar wrote: > On Tue, Jul 19, 2016 at 5:02 PM, Simon Horman > wrote: > > On Mon, Jul 18, 2016 at 03:34:52PM -0700, pravin shelar wrote: > >> On Sun, Jul 17, 2016 at 9:50 PM, Simon Horman > >> wrote: > >> > [CC Jiri Benc for portion regarding GRE]

Re: problem with MPLS and TSO/GSO

2016-08-08 Thread Simon Horman
On Sun, Jul 31, 2016 at 12:07:10AM -0700, Roopa Prabhu wrote: > On 7/27/16, 12:02 AM, zhuyj wrote: > > On ubuntu16.04 server 64 bit > > The attached script is run, the following will appear. > > > > Error: either "to" is duplicate, or "encap" is a garbage. > > This maybe just because the iproute2

Re: Buggy rhashtable walking

2016-08-08 Thread Herbert Xu
On Fri, Aug 05, 2016 at 04:46:43AM -0700, Ben Greear wrote: > > It would not be fun to have to revert to the old way of hashing > stations in mac80211... > > I'll be happy to test the patches when you have them ready. Thanks for the offer. Unfortunately it'll be a few days before I'm ready becau

Re: [PATCH net] net: ipv6: Fix ping to link-local addresses.

2016-08-08 Thread David Ahern
On 8/8/16 1:42 AM, Lorenzo Colitti wrote: > ping_v6_sendmsg never sets flowi6_oif, so it is not possible to > ping an IPv6 address on a different interface. Instead, it sets > flowi6_iif, which is incorrect but harmless. Also, it returns an > error if a passed-in scope ID doesn't match sk_bound_dev

Re: [ovs-dev] [PATCH net-next v11 5/6] openvswitch: add layer 3 flow/port support

2016-08-08 Thread Jiri Benc
On Mon, 8 Aug 2016 17:17:17 +0200, Simon Horman wrote: > +bool skb_mac_header_present(struct sk_buff *skb) > +{ > + return skb->dev->type == ARPHRD_ETHER || > + (skb->dev->type == ARPHRD_NONE && > + skb->protocol == htons(ETH_P_TEB)); > +} > +EXPORT_SYMBOL(skb_mac_heade

[v5.1] ucc_fast: Fix to avoid IS_ERR_VALUE abuses and dead code on 64bit systems.

2016-08-08 Thread Arvind Yadav
IS_ERR_VALUE() assumes that parameter is an unsigned long. It can not be used to check if 'unsigned int' is passed insted. Which tends to reflect an error. In 64bit architectures sizeof (int) == 4 && sizeof (long) == 8. IS_ERR_VALUE(x) is ((x) >= (unsigned long)-4095). IS_ERR_VALUE() of 'unsigned i

Re: [PATCH iproute2] bridge: vlan json: skip ports with empty vlans

2016-08-08 Thread Stephen Hemminger
On Sun, 7 Aug 2016 12:37:03 -0700 Roopa Prabhu wrote: > From: Roopa Prabhu > > The non-json output prints 'None' for such vlans. > And this can garble json output. > > Fixes: d82a49ce85f0 ("bridge: add json support for bridge vlan show") > Signed-off-by: Roopa Prabhu Applied

RE: [5.3] ucc_geth: Fix to avoid IS_ERR_VALUE abuses and dead code on 64bit systems.

2016-08-08 Thread David Laight
From: Arnd Bergmann > Sent: 08 August 2016 16:13 > > On Monday, August 8, 2016 2:49:11 PM CEST David Laight wrote: > > > > > If qe_muram_alloc will return any error, Then IS_ERR_VALUE will always > > > return 0. it'll not call ucc_fast_free for any failure. Inside 'if code' > > > will be a dead co

Re: [PATCH] tc/m_gact: Fix action_a2n() return code check

2016-08-08 Thread Stephen Hemminger
On Sun, 7 Aug 2016 13:19:01 +0200 Phil Sutter wrote: > The function returns zero on success. > > Reported-by: Mark Bloch > Fixes: 69f5aff63c770b ("tc: use action_a2n() everywhere") > Signed-off-by: Phil Sutter Applied

Re: [patch iproute2 1/2] devlink: write usage help messages to stderr

2016-08-08 Thread Stephen Hemminger
On Mon, 8 Aug 2016 09:19:21 +0200 Jiri Pirko wrote: > Sat, Jul 23, 2016 at 06:46:59PM CEST, step...@networkplumber.org wrote: > >On Fri, 22 Jul 2016 18:34:29 +0200 > >Jiri Pirko wrote: > > > >> From: Jiri Pirko > >> > >> In order to not confuse reader, write help messages into stderr. > >>

Re: [PATCH net 1/2] net: vxlan: lwt: Use source ip address during route lookup.

2016-08-08 Thread Jiri Benc
On Fri, 5 Aug 2016 17:45:36 -0700, Pravin B Shelar wrote: > LWT user can specify destination as well as source ip address > for given tunnel endpoint. But vxlan is ignoring given source > ip address. Following patch uses both ip address to route the > tunnel packet. This consistent with other LWT

Re: [PATCH net 2/2] net: vxlan: lwt: Fix vxlan local traffic.

2016-08-08 Thread Jiri Benc
On Fri, 5 Aug 2016 17:45:37 -0700, Pravin B Shelar wrote: > vxlan driver has bypass for local vxlan traffic, but that > depends on information about all VNIs on local system in > vxlan driver. This is not available in case of LWT. > Therefore following patch disable encap bypass for LWT > vxlan tr

[PATCH 2/3] vsockmon: Add vsockmon device.

2016-08-08 Thread ggarcia
From: Gerard Garcia Add vsockmon virtual network device that receives packets from the vsock transports and exposes them to user space. Based on the nlmon device. Signed-off-by: Gerard Garcia --- drivers/net/Kconfig | 8 ++ drivers/net/Makefile | 1 + drivers/net/vsockm

[PATCH 1/3] vsockmon: Add tap functions.

2016-08-08 Thread ggarcia
From: Gerard Garcia Add tap functions that can be used by the vsock transports to deliver packets to vsockmon virtual network devices. Signed-off-by: Gerard Garcia --- include/net/af_vsock.h | 13 + include/uapi/linux/if_arp.h | 1 + net/vmw_vsock/Makefile | 2 +- net/vmw

[PATCH 0/3] vsockmon: virtual device to monitor AF_VSOCK sockets.

2016-08-08 Thread ggarcia
From: Gerard Garcia This patch applies over the mst vhost git repository: http://git.kernel.org/cgit/linux/kernel/git/mst/vhost.git This was already been sent as a RFC where several issues where fixed. This is the summary of changes from the first RFC: v2: * Do not clone skb, instead take owne

[PATCH 3/3] vsockmon: Add virtio vsock hooks

2016-08-08 Thread ggarcia
From: Gerard Garcia Add hooks to the virtio transport host driver to deliver a copy of the received and sent messages to all vsockmon virtual network devices. Signed-off-by: Gerard Garcia --- drivers/vhost/vsock.c | 72 +++ 1 file changed, 72 ins

Re: [patch iproute2 1/2] devlink: write usage help messages to stderr

2016-08-08 Thread Jiri Pirko
Mon, Aug 08, 2016 at 05:56:54PM CEST, step...@networkplumber.org wrote: >On Mon, 8 Aug 2016 09:19:21 +0200 >Jiri Pirko wrote: > >> Sat, Jul 23, 2016 at 06:46:59PM CEST, step...@networkplumber.org wrote: >> >On Fri, 22 Jul 2016 18:34:29 +0200 >> >Jiri Pirko wrote: >> > >> >> From: Jiri Pirko >>

Re: [PATCH net] net: ipv6: Fix ping to link-local addresses.

2016-08-08 Thread 吉藤英明
Hi, 2016-08-08 23:45 GMT+09:00 Lorenzo Colitti : > On Mon, Aug 8, 2016 at 11:26 PM, Hannes Frederic Sowa > wrote: >>> - if (sk->sk_bound_dev_if && >>> - sk->sk_bound_dev_if != u->sin6_scope_id) { >>> - return -EINVAL; >>> - } >> >> Hmm,

Re: [PATCH net] net: ipv6: Fix ping to link-local addresses.

2016-08-08 Thread Lorenzo Colitti
On Tue, Aug 9, 2016 at 12:27 AM, David Ahern wrote: > > - if (!fl6.flowi6_oif && ipv6_addr_is_multicast(&fl6.daddr)) > > - fl6.flowi6_oif = np->mcast_oif; > > - else if (!fl6.flowi6_oif) > > - fl6.flowi6_oif = np->ucast_oif; > > - > > That code removal is contrary t

Re: [PATCH net] net: ipv6: Fix ping to link-local addresses.

2016-08-08 Thread David Ahern
On 8/8/16 10:24 AM, Lorenzo Colitti wrote: > On Tue, Aug 9, 2016 at 12:27 AM, David Ahern wrote: >>> - if (!fl6.flowi6_oif && ipv6_addr_is_multicast(&fl6.daddr)) >>> - fl6.flowi6_oif = np->mcast_oif; >>> - else if (!fl6.flowi6_oif) >>> - fl6.flowi6_oif = np->ucast_o

Re: [PATCH net 1/3] mlxsw: spectrum: Do not assume PAUSE frames are disabled

2016-08-08 Thread Jiri Pirko
Thu, Aug 04, 2016 at 04:36:20PM CEST, ido...@mellanox.com wrote: >When ieee_setpfc() gets called, PAUSE frames are not necessarily >disabled on the port. > >Check if PAUSE frames are disabled or enabled and configure the port's >headroom buffer accordingly. > >Fixes: d81a6bdb87ce ("mlxsw: spectrum:

[ANNOUNCE] iproute2 4.7.0

2016-08-08 Thread Stephen Hemminger
Update to iproute2 utility to support new features in Linux 4.7. New features are support of JSON output for bridge command, and configuring macsec. Plus the usual array of documentation, support of kernel flags and minor fixes. Source: http://www.kernel.org/pub/linux/utils/net/iproute2/iproute

Re: [PATCH net 2/3] mlxsw: spectrum: Do not override PAUSE settings

2016-08-08 Thread Jiri Pirko
Thu, Aug 04, 2016 at 04:36:21PM CEST, ido...@mellanox.com wrote: >The PFCC register is used to configure both PAUSE and PFC frames. >Therefore, when PFC frames are disabled we must make sure we don't >mistakenly also disable PAUSE frames (which might be enabled). > >Fix this by packing the PFCC reg

Re: [PATCH net 3/3] mlxsw: spectrum: Add missing DCB rollback in error path

2016-08-08 Thread Jiri Pirko
Thu, Aug 04, 2016 at 04:36:22PM CEST, ido...@mellanox.com wrote: >We correctly execute mlxsw_sp_port_dcb_fini() when port is removed, but >I missed its rollback in the error path of port creation, so add it. > >Fixes: f00817df2b42 ("mlxsw: spectrum: Introduce support for Data Center >Bridging (DCB

Re: [Patch net-next] net_sched: remove an unnecessary list_del()

2016-08-08 Thread Cong Wang
On Tue, Aug 2, 2016 at 10:30 AM, Cong Wang wrote: > This list_del() for tc action is not needed actually, > because we only use this list to chain bulk operations, > therefore should not be carried for latter operations. > > Cc: Jamal Hadi Salim > Signed-off-by: Cong Wang David, please drop thi

Re: problem with MPLS and TSO/GSO

2016-08-08 Thread David Ahern
On 7/25/16 10:39 AM, Lennert Buytenhek wrote: > Hi! > > I am seeing pretty horrible TCP transmit performance (anywhere between > 1 and 10 Mb/s, on a 10 Gb/s interface) when traffic is sent out over a > route that involves MPLS labeling, and this seems to be due to an > interaction between MPLS and

Re: [RFC PATCH 2/3] net: Replace for_each_possible_cpu with for_each_online_cpu

2016-08-08 Thread David Miller
From: Jia He Date: Mon, 8 Aug 2016 18:22:21 +0800 > In PowerPC server with large number cpus, the loop index in smt=1 could be > reduced to 1/8 compared with smt=8. > Thus cache misses can be reduced. You can't do this, if cpus go down we still want to report the statistics they collected whil

Re: [net-next 0/2] BPF, kprobes: Add current_in_cgroup helper

2016-08-08 Thread Sargun Dhillon
On Mon, Aug 08, 2016 at 11:27:32AM +0200, Daniel Borkmann wrote: > On 08/08/2016 05:52 AM, Alexei Starovoitov wrote: > >On Sun, Aug 07, 2016 at 08:08:19PM -0700, Sargun Dhillon wrote: > >>Thanks for your feedback Alexei, > >>I really appreciate it. > >> > >>On Sun, Aug 07, 2016 at 05:52:36PM -0700,

Re: [PATCH net-next] cdc_ether: Improve ZTE MF823/831/910 handling

2016-08-08 Thread Bjørn Mork
Oliver Neukum writes: > But why fix similar issues at two different places? And what about > PCI or other cards that show the same problem? I guess some sort of common helper would be nice to avoid open coding this fix everywhere. But you would still have to modify every driver where it is appl

Re: order-0 vs order-N driver allocation. Was: [PATCH v10 07/12] net/mlx4_en: add page recycle to prepare rx ring for tx support

2016-08-08 Thread Alexei Starovoitov
On Mon, Aug 08, 2016 at 10:01:15AM +0200, Jesper Dangaard Brouer wrote: > > On Sun, 7 Aug 2016 19:15:27 -0700 Alexei Starovoitov > wrote: > > > On Fri, Aug 05, 2016 at 09:15:33AM +0200, Eric Dumazet wrote: > > > On Thu, 2016-08-04 at 18:19 +0200, Jesper Dangaard Brouer wrote: > > > > > > > I

Re: [PATCH -net] net/ethernet: tundra: fix dump_eth_one warning in tsi108_eth

2016-08-08 Thread David Miller
From: Paul Gortmaker Date: Thu, 4 Aug 2016 16:07:58 -0400 > The call site for this function appears as: > > #ifdef DEBUG > data->msg_enable = DEBUG; > dump_eth_one(dev); > #endif > > ...leading to the following warning for !DEBUG builds: > > drivers/net/ethernet/tundra/tsi1

Re: [PATCH net v2 0/3] Few BPF helper related checksum fixes

2016-08-08 Thread David Miller
From: Daniel Borkmann Date: Fri, 5 Aug 2016 00:11:10 +0200 > The set contains three fixes with regards to CHECKSUM_COMPLETE > and BPF helper functions. For details please see individual > patches. > > Thanks! > > v1 -> v2: > - Fixed make htmldocs issue reported by kbuild bot. > - Rest as i

[PATCH net] bnx2x: don't reset chip on cleanup if PCI function is offline

2016-08-08 Thread Guilherme G. Piccoli
When PCI error is detected, in some architectures (like PowerPC) a slot reset is performed - the driver's error handlers are in charge of "disable" device before the reset, and re-enable it after a successful slot reset. There are two cases though that another path is taken on the code: if the slo

Re: [PATCH 1/3] net: stmmac: dwmac-rk: add rk3366 & rk3399-specific data

2016-08-08 Thread Heiko Stübner
Hi Roger, Am Mittwoch, 6. Juli 2016, 18:51:29 schrieb Roger Chen: > Add constants and callback functions for the dwmac on rk3368 socs. > As can be seen, the base structure is the same, only registers and > the bits in them moved slightly. > > Signed-off-by: Roger Chen > --- > .../devicetree/bin

[Patch net 0/5] net_sched: tc action fixes and updates

2016-08-08 Thread Cong Wang
This patchset fixes several regressions caused by the previous code refactor. Thanks to Jamal for catching them! Note, patch 3/5 and 4/5 are not strictly necessary, I just want to carry them together. Cong Wang (5): net_sched: remove the leftover cleanup_a() net_sched: remove an unnecessary l

[Patch net 1/5] net_sched: remove the leftover cleanup_a()

2016-08-08 Thread Cong Wang
After refactoring tc_action into tcf_common, we no longer need to cleanup temporary "actions" in list, they are permanently stored in the hashtable. Fixes: a85a970af265 ("net_sched: move tc_action into tcf_common") Reported-by: Jamal Hadi Salim Cc: Jamal Hadi Salim Signed-off-by: Cong Wang ---

[Patch net 2/5] net_sched: remove an unnecessary list_del()

2016-08-08 Thread Cong Wang
This list_del() for tc action is not needed actually, because we only use this list to chain bulk operations, therefore should not be carried for latter operations. Fixes: ec0595cc4495 ("net_sched: get rid of struct tcf_common") Cc: Jamal Hadi Salim Signed-off-by: Cong Wang --- net/sched/act_ap

[Patch net 5/5] net_sched: convert tcf_exts from list to flex_array

2016-08-08 Thread Cong Wang
As pointed out by Jamal, an action could be shared by multiple filters, so we can't use list to chain them any more after we get rid of the original tc_action. Instead, we could just save pointers to these actions in tcf_exts, since they are refcount'ed, so convert the list to a flex array. The ug

[Patch net 4/5] net_sched: move tc offload macros to pkt_cls.h

2016-08-08 Thread Cong Wang
struct tcf_exts belongs to filters, should not be visible to plain tc actions. Cc: Ido Schimmel Signed-off-by: Cong Wang --- include/net/act_api.h | 16 include/net/pkt_cls.h | 20 2 files changed, 20 insertions(+), 16 deletions(-) diff --git a/include/net

[Patch net 3/5] net_sched: fix a typo in tc_for_each_action()

2016-08-08 Thread Cong Wang
It is harmless because all users pass 'a' to this macro. Fixes: 00175aec941e ("net/sched: Macro instead of CONFIG_NET_CLS_ACT ifdef") Cc: Amir Vadai Signed-off-by: Cong Wang --- include/net/act_api.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/net/act_api.h b/inc

Re: [5.3] ucc_geth: Fix to avoid IS_ERR_VALUE abuses and dead code on 64bit systems.

2016-08-08 Thread Arnd Bergmann
On Monday, August 8, 2016 3:49:22 PM CEST David Laight wrote: > From: Arnd Bergmann > > Sent: 08 August 2016 16:13 > > > > On Monday, August 8, 2016 2:49:11 PM CEST David Laight wrote: > > > > > > > If qe_muram_alloc will return any error, Then IS_ERR_VALUE will always > > > > return 0. it'll not

Re: 4.6.3, pppoe + shaper workload, skb_panic / skb_push / ppp_start_xmit

2016-08-08 Thread Guillaume Nault
On Mon, Aug 08, 2016 at 02:25:00PM +0300, Denys Fedoryshchenko wrote: > On 2016-08-01 23:59, Guillaume Nault wrote: > > Do you still have the vmlinux file with debug symbols that generated > > this panic? > Sorry for delay, i didn't had same image on all servers and probably i found > cause of pani

Re: [PATCH net 2/2] net: vxlan: lwt: Fix vxlan local traffic.

2016-08-08 Thread David Miller
From: Pravin B Shelar Date: Fri, 5 Aug 2016 17:45:37 -0700 > vxlan driver has bypass for local vxlan traffic, but that > depends on information about all VNIs on local system in > vxlan driver. This is not available in case of LWT. > Therefore following patch disable encap bypass for LWT > vxlan

Re: [PATCH net 1/2] net: vxlan: lwt: Use source ip address during route lookup.

2016-08-08 Thread David Miller
From: Pravin B Shelar Date: Fri, 5 Aug 2016 17:45:36 -0700 > LWT user can specify destination as well as source ip address > for given tunnel endpoint. But vxlan is ignoring given source > ip address. Following patch uses both ip address to route the > tunnel packet. This consistent with other L

Re: [Regression] Bonding no longer support tun-interfaces

2016-08-08 Thread Jörn Engel
Redirected by Davem. Is there a mailing list or a maintainer for regressions? There used to be, but I've been out of the loop for a while. On Mon, Aug 08, 2016 at 02:15:30PM -0700, Jörn Engel wrote: > This has been reported (and ignored) before: > http://lkml.iu.edu/hypermail/linux/kernel/1407.2

Re: [PATCH] net: make net namespace sysctls belong to container's owner

2016-08-08 Thread Eric W. Biederman
Dmitry Torokhov writes: > If net namespace is attached to a user namespace let's make container's > root owner of sysctls affecting said network namespace instead of global > root. > > This also allows us to clean up net_ctl_permissions() because we do not > need to fudge permissions anymore for

Re: [PATCH v2 00/10] userns: sysctl limits for namespaces

2016-08-08 Thread Eric W. Biederman
I won't have any more time for this until I return from vacation at the end of the month but after a little bit of thought I think I have fixed all of the bugs (except arguably the return value). I have further tweaked these and made the limits per user. Because it occured to me that if the limi

Re: [PATCH net] sctp: use event->chunk when it's valid

2016-08-08 Thread David Miller
From: Xin Long Date: Sun, 7 Aug 2016 14:15:13 +0800 > Commit 52253db924d1 ("sctp: also point GSO head_skb to the sk when > it's available") used event->chunk->head_skb to get the head_skb in > sctp_ulpevent_set_owner(). > > But at that moment, the event->chunk was NULL, as it cloned the skb > i

Re: [PATCH net] net: ipv6: Fix ping to link-local addresses.

2016-08-08 Thread David Miller
From: Lorenzo Colitti Date: Mon, 8 Aug 2016 16:42:07 +0900 > ping_v6_sendmsg never sets flowi6_oif, so it is not possible to > ping an IPv6 address on a different interface. Instead, it sets > flowi6_iif, which is incorrect but harmless. Also, it returns an > error if a passed-in scope ID doesn'

[PATCH] bonding: Allow tun-interfaces as slaves

2016-08-08 Thread Jörn Engel
Up until 00503b6f702e (part of 3.14-rc1), the bonding driver could be used to enslave tun-interfaces. 00503b6f702e broke that behaviour, afaics as an unintended side-effect. For the purpose of bond-over-tun in balance-rr mode, simply ignoring the error from dev_set_mac_address() is good enough.

Re: [PATCH] net: make net namespace sysctls belong to container's owner

2016-08-08 Thread Dmitry Torokhov
On Mon, Aug 8, 2016 at 2:08 PM, Eric W. Biederman wrote: > Dmitry Torokhov writes: > >> If net namespace is attached to a user namespace let's make container's >> root owner of sysctls affecting said network namespace instead of global >> root. >> >> This also allows us to clean up net_ctl_permis

Re: [PATCH] proc: make proc entries inherit ownership from parent

2016-08-08 Thread Dmitry Torokhov
On Thu, Aug 4, 2016 at 8:22 PM, Dmitry Torokhov wrote: > There are certain parameters that belong to net namespace and that are > exported in /proc. They should be controllable by the container's owner, > but are currently owned by global root and thus not available. > > Let's change proc code to

Re: [PATCH] net: make net namespace sysctls belong to container's owner

2016-08-08 Thread Eric W. Biederman
Dmitry Torokhov writes: > On Mon, Aug 8, 2016 at 2:08 PM, Eric W. Biederman > wrote: >> Dmitry Torokhov writes: >> >>> If net namespace is attached to a user namespace let's make container's >>> root owner of sysctls affecting said network namespace instead of global >>> root. >>> >>> This als

[PATCH net] vti: flush x-netns xfrm cache when vti interface is removed

2016-08-08 Thread Lance Richardson
When executing the script included below, the netns delete operation hangs with the following message (repeated at 10 second intervals): kernel:unregister_netdevice: waiting for lo to become free. Usage count = 1 This occurs because a reference to the lo interface in the "secure" netns is still

  1   2   >