Re: [net-next 00/14][pull request] 100GbE Intel Wired LAN Driver Updates 2016-08-29

2016-08-29 Thread David Miller
From: Jeff Kirsher Date: Mon, 29 Aug 2016 02:13:32 -0700 > This series contains updates to fm10k only. Pulled, thanks Jeff.

did you receive my previous email ?

2016-08-29 Thread Friedrich Mayrhofer
Hello, This is the second time i am sending you this mail. I, Friedrich Mayrhofer and my wife has Donate $ 1,000,000.00 USD to You, Email Me personally for more details. Regards. Friedrich Mayrhofer

Re: [net-next RFC v2 4/9] bpf, security: Add Checmate security LSM and BPF program type

2016-08-29 Thread Sargun Dhillon
On Mon, Aug 29, 2016 at 02:49:17PM -0700, Alexei Starovoitov wrote: > On 8/29/16 12:24 PM, Tejun Heo wrote: > >Hello, Sargun. > > > >On Mon, Aug 29, 2016 at 11:49:07AM -0700, Sargun Dhillon wrote: > >>It would be a separate hook per LSM hook. Why wouldn't we want a separate > >>bpf > >>hook per

[PATCH net v3 3/9] net: ethernet: mediatek: fix API usage with skb_free_frag

2016-08-29 Thread sean.wang
From: Sean Wang use skb_free_frag() instead of legacy put_page() Signed-off-by: Sean Wang Acked-by: John Crispin --- drivers/net/ethernet/mediatek/mtk_eth_soc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH net v3 6/9] net: ethernet: mediatek: fix issue of driver removal with interface is up

2016-08-29 Thread sean.wang
From: Sean Wang mtk_stop() must be called to stop for freeing DMA resources acquired and restoring state changed by mtk_open() firstly when module removal. Signed-off-by: Sean Wang --- drivers/net/ethernet/mediatek/mtk_eth_soc.c | 8 1

[PATCH net v3 9/9] net: ethernet: mediatek: fix error handling inside mtk_mdio_init

2016-08-29 Thread sean.wang
From: Sean Wang Return -ENODEV if the MDIO bus is disabled in the device tree. Signed-off-by: Sean Wang Acked-by: John Crispin Reviewed-by: Andrew Lunn --- drivers/net/ethernet/mediatek/mtk_eth_soc.c | 2 +- 1

[PATCH net v3 4/9] net: ethernet: mediatek: remove redundant free_irq for devm_request_irq allocated irq

2016-08-29 Thread sean.wang
From: Sean Wang these irqs are not used for shared irq and disabled during ethernet stops. irq requested by devm_request_irq is safe to be freed automatically on driver detach. Signed-off-by: Sean Wang Acked-by: John Crispin

[PATCH net v3 7/9] net: ethernet: mediatek: fix the missing of_node_put() after node is used done inside mtk_mdio_init

2016-08-29 Thread sean.wang
From: Sean Wang This patch adds the missing of_node_put() after finishing the usage of of_get_child_by_name. Signed-off-by: Sean Wang Acked-by: John Crispin --- drivers/net/ethernet/mediatek/mtk_eth_soc.c | 1 + 1 file

[PATCH net v3 1/9] net: ethernet: mediatek: fix fails from TX housekeeping due to incorrect port setup

2016-08-29 Thread sean.wang
From: Sean Wang which net device the SKB is complete for depends on the forward port on txd4 on the corresponding TX descriptor, but the information isn't set up well in case of SKB fragments that would lead to watchdog timeout from the upper layer, so fix it up.

[PATCH net v3 0/9] net: ethernet: mediatek: a couple of fixes

2016-08-29 Thread sean.wang
From: Sean Wang a couple of fixes come out from integrating with linux-4.8 rc1 they all are verified and workable on linux-4.8 rc1 Changes since v1: - usage of loops to work out if all required clock are ready instead of tedious coding - remove redundant pinctrl setup

[PATCH net v3 2/9] net: ethernet: mediatek: fix incorrect return value of devm_clk_get with EPROBE_DEFER

2016-08-29 Thread sean.wang
From: Sean Wang 1) If the return value of devm_clk_get is EPROBE_DEFER, we should defer probing the driver. The change is verified and works based on 4.8-rc1 staying with the latest clk-next code for MT7623. 2) Changing with the usage of loops to work out if all clocks

[PATCH net v3 8/9] net: ethernet: mediatek: use devm_mdiobus_alloc instead of mdiobus_alloc inside mtk_mdio_init

2016-08-29 Thread sean.wang
From: Sean Wang a lot of parts in the driver uses devm_* APIs to gain benefits from the device resource management, so devm_mdiobus_alloc is also used instead of mdiobus_alloc to have more elegant code flow. Using common code provided by the devm_* helps to 1) have

[PATCH net v3 5/9] net: ethernet: mediatek: fix logic unbalance between probe and remove

2016-08-29 Thread sean.wang
From: Sean Wang original mdio_cleanup is not in the symmetric place against where mdio_init is, so relocate mdio_cleanup to the right one. Signed-off-by: Sean Wang Acked-by: John Crispin ---

Re: [PATCH net 1/2] ipv6: add missing netconf notif when 'all' is updated

2016-08-29 Thread YOSHIFUJI Hideaki
Nicolas Dichtel wrote: > The 'default' value was not advertised. > > Fixes: f3a1bfb11ccb ("rtnl/ipv6: use netconf msg to advertise forwarding > status") > Signed-off-by: Nicolas Dichtel > --- > net/ipv6/addrconf.c | 7 +++ > 1 file changed, 7 insertions(+) > >

Re: [PATCH] net/mlx4_en: protect ring->xdp_prog with rcu_read_lock

2016-08-29 Thread Tariq Toukan
Hi Brenden, The solution direction should be XDP specific that does not hurt the regular flow. On 26/08/2016 11:38 PM, Brenden Blanco wrote: Depending on the preempt mode, the bpf_prog stored in xdp_prog may be freed despite the use of call_rcu inside bpf_prog_put. The situation is possible

Re: [PATCH net-next 0/6] perf, bpf: add support for bpf in sw/hw perf_events

2016-08-29 Thread Brendan Gregg
On Mon, Aug 29, 2016 at 5:19 AM, Peter Zijlstra wrote: > > On Fri, Aug 26, 2016 at 07:31:18PM -0700, Alexei Starovoitov wrote: > > Hi Peter, Dave, > > > > this patch set is a follow up to the discussion: > > https://lkml.org/lkml/2016/8/4/304 > > It turned out to be simpler

Re: [PATCH] bonding: Allow tun-interfaces as slaves

2016-08-29 Thread Ding Tianhong
On 2016/8/12 2:24, Jörn Engel wrote: > On Wed, Aug 10, 2016 at 05:58:38PM -0700, Jay Vosburgh wrote: >> Jörn Engel wrote: >>> On Wed, Aug 10, 2016 at 02:26:49PM -0700, Jörn Engel wrote: Having to set one more parameter is a bit annoying. It would have to be

[net] i40e: Fix kernel panic on enable/disable LLDP

2016-08-29 Thread Jeff Kirsher
From: Dave Ertman If DCB is configured on the link partner switch with an unsupported traffic class configuration (e.g. non-contiguous TCs), the driver is flagging DCB as disabled. But, for future DCB LLDPDUs, the driver was checking if the interface was DCB capable

Re: [PATCH net-next 3/6] bpf: perf_event progs should only use preallocated maps

2016-08-29 Thread Daniel Borkmann
On 08/27/2016 04:31 AM, Alexei Starovoitov wrote: Make sure that BPF_PROG_TYPE_PERF_EVENT programs only use preallocated hash maps, since doing memory allocation in overflow_handler can crash depending on where nmi got triggered. Signed-off-by: Alexei Starovoitov Acked-by:

Re: [PATCH net-next 2/6] bpf: introduce BPF_PROG_TYPE_PERF_EVENT program type

2016-08-29 Thread Daniel Borkmann
On 08/27/2016 04:31 AM, Alexei Starovoitov wrote: Introduce BPF_PROG_TYPE_PERF_EVENT programs that can be attached to HW and SW perf events (PERF_TYPE_HARDWARE and PERF_TYPE_SOFTWARE correspondingly in uapi/linux/perf_event.h) The program visible context meta structure is struct

Re: [PATCH net-next 1/6] bpf: support 8-byte metafield access

2016-08-29 Thread Daniel Borkmann
On 08/27/2016 04:31 AM, Alexei Starovoitov wrote: The verifier supported only 4-byte metafields in struct __sk_buff and struct xdp_md. The metafields in upcoming struct bpf_perf_event are 8-byte to match register width in struct pt_regs. Teach verifier to recognize 8-byte metafield access. The

[NetDev] [ANNOUNCE] Netdev 1.2 weekly updates (30th August, 2016)

2016-08-29 Thread Hajime Tazaki
Hello folks, I hope you're doing well. Here is an weekly update of Netdev 1.2 Tokyo. The early bird registration is still available. Please don't miss the discount ticket - and your early registration will be definitely helpful to prepare the conference.

Re: [net-next RFC v2 4/9] bpf, security: Add Checmate security LSM and BPF program type

2016-08-29 Thread Andy Lutomirski
On Aug 29, 2016 3:19 PM, "Mickaël Salaün" wrote: > > > On 29/08/2016 23:49, Alexei Starovoitov wrote: > > On 8/29/16 12:24 PM, Tejun Heo wrote: > >> Hello, Sargun. > >> > >> On Mon, Aug 29, 2016 at 11:49:07AM -0700, Sargun Dhillon wrote: > >>> It would be a separate hook per LSM

Re: [PATCH v3 4/6] net: filter: run cgroup eBPF ingress programs

2016-08-29 Thread Daniel Borkmann
On 08/26/2016 09:58 PM, Daniel Mack wrote: If the cgroup associated with the receiving socket has an eBPF programs installed, run them from sk_filter_trim_cap(). eBPF programs used in this context are expected to either return 1 to let the packet pass, or != 1 to drop them. The programs have

Re: [PATCH v3 2/6] cgroup: add support for eBPF programs

2016-08-29 Thread Sargun Dhillon
On Fri, Aug 26, 2016 at 09:58:48PM +0200, Daniel Mack wrote: > This patch adds two sets of eBPF program pointers to struct cgroup. > One for such that are directly pinned to a cgroup, and one for such > that are effective for it. > > To illustrate the logic behind that, assume the following

Re: [PATCH net-next 0/6] perf, bpf: add support for bpf in sw/hw perf_events

2016-08-29 Thread Alexei Starovoitov
On Mon, Aug 29, 2016 at 12:58:00PM +0200, Peter Zijlstra wrote: > On Fri, Aug 26, 2016 at 07:31:18PM -0700, Alexei Starovoitov wrote: > > Hi Peter, Dave, > > > > this patch set is a follow up to the discussion: > > https://lkml.org/lkml/2016/8/4/304 > > Please don't use lkml.org links, that site

Re: [PATCH v3 3/6] bpf: add BPF_PROG_ATTACH and BPF_PROG_DETACH commands

2016-08-29 Thread Daniel Borkmann
On 08/26/2016 09:58 PM, Daniel Mack wrote: Extend the bpf(2) syscall by two new commands, BPF_PROG_ATTACH and BPF_PROG_DETACH which allow attaching and detaching eBPF programs to a target. On the API level, the target could be anything that has an fd in userspace, hence the name of the field in

Re: [PATCH] bonding: Allow tun-interfaces as slaves

2016-08-29 Thread Jörn Engel
Ping. Not sure if we reached some conclusion yet. If we did, I must have missed it. Jörn -- If you managed to confuse the compiler, you lost your human readers a long time ago. -- hummassa

Re: [PATCH v3 2/6] cgroup: add support for eBPF programs

2016-08-29 Thread Daniel Borkmann
On 08/26/2016 09:58 PM, Daniel Mack wrote: This patch adds two sets of eBPF program pointers to struct cgroup. One for such that are directly pinned to a cgroup, and one for such that are effective for it. To illustrate the logic behind that, assume the following example cgroup hierarchy. A

[PATCH RFC 0/2] net: Iterate over cpu_present_mask during calculation of percpu statistics

2016-08-29 Thread Kirill Tkhai
Many variables of statistics type are made percpu in kernel. This allows to do not make them atomic or to do not use synchronization. The result value is calculated as sum of values on every possible cpu. The problem is this scales bad. The calculations may took a lot of time. For example, some

Re: kernel BUG at net/unix/garbage.c:149!"

2016-08-29 Thread Miklos Szeredi
On Sat, Aug 27, 2016 at 11:55 AM, Miklos Szeredi wrote: > > On Wed, Aug 24, 2016 at 11:40 PM, Hannes Frederic Sowa > wrote: > > On 24.08.2016 16:24, Nikolay Borisov wrote: > >> Hello, > >> > >> I hit the following BUG: > >> > >> [1851513.239831]

[PATCH RFC 2/2] net: Iterate over present cpus only during ipstats calculation

2016-08-29 Thread Kirill Tkhai
Use net_stats callback to iterate only present cpus mask. This gives a signify performance growth on configurations with large number of possible cpus. Signed-off-by: Kirill Tkhai --- net/ipv6/addrconf.c |4 +++- net/ipv6/af_inet6.c | 56

Re: [net-next RFC v2 8/9] samples/bpf: Add limit_connections, remap_bind checmate examples / tests

2016-08-29 Thread Alexei Starovoitov
On Mon, Aug 29, 2016 at 04:47:46AM -0700, Sargun Dhillon wrote: > 1) limit_connections > This program performs connection limiting using a probablistic > datastructure. It ensures that for a given 2-tuple, there will never be > more than 10 connections. The parameters themselves are adjustable >

Re: [PATCH v3 5/6] net: core: run cgroup eBPF egress programs

2016-08-29 Thread Sargun Dhillon
On Tue, Aug 30, 2016 at 12:03:23AM +0200, Daniel Borkmann wrote: > On 08/26/2016 09:58 PM, Daniel Mack wrote: > >If the cgroup associated with the receiving socket has an eBPF > >programs installed, run them from __dev_queue_xmit(). > > > >eBPF programs used in this context are expected to either

Re: [net-next RFC v2 4/9] bpf, security: Add Checmate security LSM and BPF program type

2016-08-29 Thread Mickaël Salaün
On 29/08/2016 23:49, Alexei Starovoitov wrote: > On 8/29/16 12:24 PM, Tejun Heo wrote: >> Hello, Sargun. >> >> On Mon, Aug 29, 2016 at 11:49:07AM -0700, Sargun Dhillon wrote: >>> It would be a separate hook per LSM hook. Why wouldn't we want a >>> separate bpf >>> hook per lsm hook? I think if

Re: [PATCH v3 1/6] bpf: add new prog type for cgroup socket filtering

2016-08-29 Thread Daniel Borkmann
On 08/26/2016 09:58 PM, Daniel Mack wrote: For now, this program type is equivalent to BPF_PROG_TYPE_SOCKET_FILTER in terms of checks during the verification process. It may access the skb as well. Programs of this type will be attached to cgroups for network filtering and accounting.

Re: [PATCH v3 5/6] net: core: run cgroup eBPF egress programs

2016-08-29 Thread Daniel Borkmann
On 08/26/2016 09:58 PM, Daniel Mack wrote: If the cgroup associated with the receiving socket has an eBPF programs installed, run them from __dev_queue_xmit(). eBPF programs used in this context are expected to either return 1 to let the packet pass, or != 1 to drop them. The programs have

Re: [net-next RFC v2 4/9] bpf, security: Add Checmate security LSM and BPF program type

2016-08-29 Thread Alexei Starovoitov
On 8/29/16 12:24 PM, Tejun Heo wrote: Hello, Sargun. On Mon, Aug 29, 2016 at 11:49:07AM -0700, Sargun Dhillon wrote: It would be a separate hook per LSM hook. Why wouldn't we want a separate bpf hook per lsm hook? I think if one program has to handle them all, the first program would be

[PATCH RFC 1/2] net: Implement net_stats callbacks

2016-08-29 Thread Kirill Tkhai
net_stats callbacks are functions, which are called during a cpu is going down. They operate on percpu statistics and should move it from dying cpu to an alive one. The callbacks are called on CPU_DYING stage, when machine is stopped, and they are executed on dying cpu. This allows to minimize

Re: [PATCH] net: ethernet: renesas: sh_eth: do not access POST registers if not exist

2016-08-29 Thread Sergei Shtylyov
Hello. On 08/29/2016 05:41 PM, Chris Brandt wrote: The RZ/A1 has a TSU, but since it only has one Ethernet port, it does not have POST registers. I'm not sure the reason is having one port... do you have the old SH manuals somewhere? :-) Yes, I used to support the SH7757. Good to

Re: [RFCv2 16/16] nfp: bpf: add offload of TC direct action mode

2016-08-29 Thread Daniel Borkmann
On 08/26/2016 08:06 PM, Jakub Kicinski wrote: Add offload of TC in direct action mode. We just need to provide appropriate checks in the verifier and a new outro block to translate the exit codes to what data path expects Signed-off-by: Jakub Kicinski [...]

[PATCH net-next] MAINTAINERS: update to working email address

2016-08-29 Thread Andy Gospodarek
Signed-off-by: Andy Gospodarek --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 99f9527..ccf186d 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2484,7 +2484,7 @@ F:include/net/bluetooth/ BONDING

Re: [RFCv2 11/16] net: cls_bpf: allow offloaded filters to update stats

2016-08-29 Thread Daniel Borkmann
On 08/26/2016 08:06 PM, Jakub Kicinski wrote: Call into offloaded filters to update stats. Signed-off-by: Jakub Kicinski Acked-by: Daniel Borkmann

[PATCH net-next 0/3] net: dsa: add MDB support

2016-08-29 Thread Vivien Didelot
This patchset adds the switchdev MDB object support to the DSA layer. The MDB support for the mv88e6xxx driver is very similar to the FDB support. The FDB operations care about unicast addresses while the MDB operations care about multicast addresses. Both operation set load/purge/dump the

[PATCH net-next 3/3] net: dsa: mv88e6xxx: add MDB support

2016-08-29 Thread Vivien Didelot
Add support for the MDB operations. This consists of loading/purging/dumping multicast addresses for a given port in the ATU. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6xxx/chip.c | 65 1 file changed, 65

[PATCH net-next 2/3] net: dsa: mv88e6xxx: make switchdev DB ops generic

2016-08-29 Thread Vivien Didelot
The MDB support for the mv88e6xxx driver will be very similar to the FDB support, since it consists of loading/purging/dumping address to/from the Address Translation Unit (ATU). Prepare the support for MDB by making the FDB code accessing the ATU generic. The FDB operations now provide access to

[PATCH net-next 1/3] net: dsa: add MDB support

2016-08-29 Thread Vivien Didelot
Add SWITCHDEV_OBJ_ID_PORT_MDB support to the DSA layer. Signed-off-by: Vivien Didelot --- Documentation/networking/dsa/dsa.txt | 23 +++ include/net/dsa.h| 16 +++ net/dsa/slave.c | 55

Re: [RFCv2 07/16] bpf: enable non-core use of the verfier

2016-08-29 Thread Daniel Borkmann
On 08/29/2016 10:13 PM, Daniel Borkmann wrote: On 08/27/2016 07:32 PM, Alexei Starovoitov wrote: On Sat, Aug 27, 2016 at 12:40:04PM +0100, Jakub Kicinski wrote: On Fri, 26 Aug 2016 16:29:05 -0700, Alexei Starovoitov wrote: On Fri, Aug 26, 2016 at 07:06:06PM +0100, Jakub Kicinski wrote:

Re: [RFCv2 07/16] bpf: enable non-core use of the verfier

2016-08-29 Thread Daniel Borkmann
On 08/27/2016 07:32 PM, Alexei Starovoitov wrote: On Sat, Aug 27, 2016 at 12:40:04PM +0100, Jakub Kicinski wrote: On Fri, 26 Aug 2016 16:29:05 -0700, Alexei Starovoitov wrote: On Fri, Aug 26, 2016 at 07:06:06PM +0100, Jakub Kicinski wrote: Advanced JIT compilers and translators may want to

Re: [PATCH net-next] tcp: add tcp_add_backlog()

2016-08-29 Thread Marcelo Ricardo Leitner
On Mon, Aug 29, 2016 at 12:22:37PM -0700, Eric Dumazet wrote: > On Mon, 2016-08-29 at 15:51 -0300, Marcelo Ricardo Leitner wrote: > > skb->truesize = SKB_TRUESIZE(skb_end_offset(skb)); > > > > Shouldn't __pskb_pull_tail() already fix this? As it seems the expected > > behavior and it would

Re: [net-next RFC v2 4/9] bpf, security: Add Checmate security LSM and BPF program type

2016-08-29 Thread Tejun Heo
Hello, Sargun. On Mon, Aug 29, 2016 at 11:49:07AM -0700, Sargun Dhillon wrote: > It would be a separate hook per LSM hook. Why wouldn't we want a separate bpf > hook per lsm hook? I think if one program has to handle them all, the first > program would be looking up the hook program in a bpf

Re: [PATCH net-next] tcp: add tcp_add_backlog()

2016-08-29 Thread Eric Dumazet
On Mon, 2016-08-29 at 15:51 -0300, Marcelo Ricardo Leitner wrote: > skb->truesize = SKB_TRUESIZE(skb_end_offset(skb)); > > Shouldn't __pskb_pull_tail() already fix this? As it seems the expected > behavior and it would have a more global effect then. For drivers not > using copybreak,

pull-request: wireless-drivers 2016-08-29

2016-08-29 Thread Kalle Valo
Hi Dave, I'm quite backlogged after coming back from my vacation but luckily it has been pretty quiet. Here is the first batch of patches for 4.8, quite simple actually and not really anything special to mention. More to come later, most probably next week. Please let me know if there are any

[patch iproute2 v2 0/2] Add matchall support to tc

2016-08-29 Thread Jiri Pirko
From: Jiri Pirko Yotam says: Add the matchall classifier support to tc and added the specific man pages. --- v1->v2: -fixed couple of checkpatch issues Yotam Gigi (2): tc: Add support for the matchall traffic classifier. tc: man: Add man entry for the matchall

[patch iproute2 v2 2/2] tc: man: Add man entry for the matchall classifier.

2016-08-29 Thread Jiri Pirko
From: Yotam Gigi In addition to providing information about the mathcall filter and its configurations, the man entry contains examples for creating port mirorring entries. Signed-off-by: Yotam Gigi Signed-off-by: Jiri Pirko ---

[patch iproute2 v2 1/2] tc: Add support for the matchall traffic classifier.

2016-08-29 Thread Jiri Pirko
From: Yotam Gigi The matchall classifier matches every packet and allows the user to apply actions on it. In addition, it supports the skip_sw and skip_hw (as can be found on u32 and flower filter) that direct the kernel to skip the software/hardware processing of the

Re: [PATCH net-next] tcp: add tcp_add_backlog()

2016-08-29 Thread Marcelo Ricardo Leitner
On Sat, Aug 27, 2016 at 07:37:54AM -0700, Eric Dumazet wrote: > From: Eric Dumazet > > When TCP operates in lossy environments (between 1 and 10 % packet > losses), many SACK blocks can be exchanged, and I noticed we could > drop them on busy senders, if these SACK blocks

Re: [net-next RFC v2 4/9] bpf, security: Add Checmate security LSM and BPF program type

2016-08-29 Thread Sargun Dhillon
On Mon, Aug 29, 2016 at 01:01:18PM -0400, Tejun Heo wrote: > Hello, > > On Mon, Aug 29, 2016 at 04:47:07AM -0700, Sargun Dhillon wrote: > > This patch adds a minor LSM, Checmate. Checmate is a flexible programmable, > > extensible minor LSM that's coupled with cgroups and BPF. It is designed to >

Re: [patch iproute2 1/2] tc: Add support for the matchall traffic classifier.

2016-08-29 Thread Jiri Pirko
Mon, Aug 29, 2016 at 08:03:21PM CEST, step...@networkplumber.org wrote: >On Mon, 22 Aug 2016 13:56:25 +0200 >Jiri Pirko wrote: > >> From: Yotam Gigi >> >> The matchall classifier matches every packet and allows the user to apply >> actions on it. In

Re: [PATCH net-next] sky2: use napi_complete_done

2016-08-29 Thread Eric Dumazet
On Mon, 2016-08-29 at 10:16 -0700, Stephen Hemminger wrote: > Update the sky2 driver to pass number of packets done to NAPI. > The driver was never updated when napi_complete_done was added. > > Signed-off-by: Stephen Hemminger > --- Acked-by: Eric Dumazet

Re: [PATCH v3 net-next 1/1] net_sched: Introduce skbmod action

2016-08-29 Thread Eric Dumazet
On Mon, 2016-08-29 at 07:35 -0400, Jamal Hadi Salim wrote: >flags = READ_ONCE(d->flags); > rcu_read_lock(); > if (flags & SKBMOD_F_DMAC) > ether_addr_copy(eth_hdr(skb)->h_dest, d->eth_dst); > if (flags & SKBMOD_F_SMAC) >

Re: [PATCH net iproute2] devlink: Add e-switch support

2016-08-29 Thread Stephen Hemminger
On Sun, 28 Aug 2016 16:35:21 +0300 Or Gerlitz wrote: > Implement kernel devlink e-switch interface. Currently we allow > to get and set the device e-switch mode. > > Signed-off-by: Or Gerlitz > Signed-off-by: Roi Dayan Applied

Re: [PATCH iproute2 1/2] tc: flower: Introduce vlan support

2016-08-29 Thread Stephen Hemminger
On Mon, 22 Aug 2016 13:24:53 +0300 Hadar Hen Zion wrote: > iff --git a/include/linux/tc_act/tc_vlan.h b/include/linux/tc_act/tc_vlan.h > index 31151ff..26ae695 100644 > --- a/include/linux/tc_act/tc_vlan.h > +++ b/include/linux/tc_act/tc_vlan.h > @@ -16,6 +16,9 @@ > >

Re: [patch iproute2 1/2] tc: Add support for the matchall traffic classifier.

2016-08-29 Thread Stephen Hemminger
On Mon, 22 Aug 2016 13:56:25 +0200 Jiri Pirko wrote: > From: Yotam Gigi > > The matchall classifier matches every packet and allows the user to apply > actions on it. In addition, it supports the skip_sw and skip_hw (as can > be found on u32 and flower

Re: [PATCH iproute2 net-next v3] bridge: vlan: add support to display per-vlan statistics

2016-08-29 Thread Stephen Hemminger
On Thu, 25 Aug 2016 14:28:55 +0200 Nikolay Aleksandrov wrote: > This patch adds support for the stats argument to the bridge > vlan command which will display the per-vlan statistics and the device > each vlan belongs to with its flags. The supported command

Re: [PATCH] iproute: disallow ip rule del without parameters

2016-08-29 Thread Stephen Hemminger
On Wed, 24 Aug 2016 23:43:00 +0300 "Andrey Jr. Melnikov" wrote: > Disallow run `ip rule del` without any parameter to avoid delete any first > rule from table. > > Signed-off-by: Andrey Jr. Melnikov > --- > > diff --git a/ip/iprule.c b/ip/iprule.c >

Re: [PATCH] net/mlx4_en: protect ring->xdp_prog with rcu_read_lock

2016-08-29 Thread Tom Herbert
On Mon, Aug 29, 2016 at 8:55 AM, Brenden Blanco wrote: > On Mon, Aug 29, 2016 at 05:59:26PM +0300, Tariq Toukan wrote: >> Hi Brenden, >> >> The solution direction should be XDP specific that does not hurt the >> regular flow. > An rcu_read_lock is _already_ taken for _every_

Re: [iproute PATCH] ip-route: Prevent some double spaces in output

2016-08-29 Thread Stephen Hemminger
On Tue, 23 Aug 2016 11:52:45 +0200 Phil Sutter wrote: > The code is a bit messy, as it starts with space after text and at some > point switches to space before text. But either way, printing space > before *and* after text almost certainly leads to printing more > whitespace than

Re: [PATCH v2 net-next] documentation: Document issues with VMs and XPS and drivers enabling it on their own

2016-08-29 Thread Tom Herbert
On Mon, Aug 29, 2016 at 9:26 AM, Rick Jones wrote: > On 08/27/2016 12:41 PM, Tom Herbert wrote: >> >> On Fri, Aug 26, 2016 at 9:35 PM, David Miller wrote: >>> >>> From: Tom Herbert >>> Date: Thu, 25 Aug 2016 16:43:35 -0700 >>>

Re: [PATCH iproute2] tipc: add peer remove functionality

2016-08-29 Thread Stephen Hemminger
On Mon, 22 Aug 2016 10:18:29 +0200 Richard Alpe wrote: > This enables a user to remove an offline peer from the kernel data > structures. This could for example be useful when deliberately scaling > in peer nodes in a cloud environment. > > This functionality was

Re: [PATCH net-next] amd-xgbe: Reset running devices after resume from hibernate

2016-08-29 Thread Tom Lendacky
On 08/26/2016 03:21 AM, James Morse wrote: > After resume from hibernate on arm64, any amd-xgbe devices that were > running when we hibernated are reported as down, even when it is not. > > Re-plugging the cables does not cause the interface to come back, the > link must be marked as down then up

[PATCH net-next] sky2: use napi_complete_done

2016-08-29 Thread Stephen Hemminger
Update the sky2 driver to pass number of packets done to NAPI. The driver was never updated when napi_complete_done was added. Signed-off-by: Stephen Hemminger --- drivers/net/ethernet/marvell/sky2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [net-next RFC v2 9/9] doc: Add LSM / BPF Checmate docs

2016-08-29 Thread Randy Dunlap
On 08/29/16 04:47, Sargun Dhillon wrote: > This adds documentation on how to operate, and develop against the > Checmate LSM and Cgroup controller. > > Signed-off-by: Sargun Dhillon > --- > Documentation/security/Checmate.txt | 54 > + > 1

[PATCH] ath10k: Spelling and miscellaneous neatening

2016-08-29 Thread Joe Perches
Correct some trivial comment typos. Remove unnecessary parentheses in a long line. Convert a return; before the end of a void function definition to just ; Signed-off-by: Joe Perches --- drivers/net/wireless/ath/ath10k/ce.c| 2 +-

Re: [net-next RFC v2 4/9] bpf, security: Add Checmate security LSM and BPF program type

2016-08-29 Thread Tejun Heo
Hello, On Mon, Aug 29, 2016 at 04:47:07AM -0700, Sargun Dhillon wrote: > This patch adds a minor LSM, Checmate. Checmate is a flexible programmable, > extensible minor LSM that's coupled with cgroups and BPF. It is designed to > enforce container-specific policies. It is also a cgroupv2

Re: [PATCH net-next] tcp: add tcp_add_backlog()

2016-08-29 Thread Yuchung Cheng
On Sat, Aug 27, 2016 at 9:25 AM, Eric Dumazet wrote: > > On Sat, 2016-08-27 at 09:13 -0700, Yuchung Cheng wrote: > > On Sat, Aug 27, 2016 at 7:37 AM, Eric Dumazet > > wrote: > > > > > > > + /* Only socket owner can try to collapse/prune rx

Re: [PATCH net 1/2] ipv6: add missing netconf notif when 'all' is updated

2016-08-29 Thread Sergei Shtylyov
On 08/29/2016 05:13 PM, 吉藤英明 wrote: The 'default' value was not advertised. Fixes: f3a1bfb11ccb ("rtnl/ipv6: use netconf msg to advertise forwarding status") Signed-off-by: Nicolas Dichtel --- net/ipv6/addrconf.c | 7 +++ 1 file changed, 7 insertions(+) diff

Fwd: ixgbe: Can't get link / carrier on embedded NIC of a D-1518 CPU

2016-08-29 Thread Sylvain Munaut
Hi, I'm having trouble getting a link up on a ixgbe card. The hardware is a SuperMicro SYS-5018D-FN8T ( https://www.supermicro.nl/products/system/1U/5018/SYS-5018D-FN8T.cfm ) It includes a Intel® Xeon® processor D-1518 with embedded 10G Intel NICs and cs4227 phys to SFP+ ports. The optics in

Re: [RFC PATCH 1/6] proc: Reduce cache miss in {snmp,netstat}_seq_show

2016-08-29 Thread Eric Dumazet
On Tue, 2016-08-30 at 00:03 +0800, Jia He wrote: > This patch exchanges the two loop for collecting the percpu statistics > data. This can aggregate the data by going through all the items of each > cpu sequentially. In snmp_seq_show, just use one buff copy to dislay the > Udp and UdpLite data

Re: [PATCH v4] brcmfmac: add missing header dependencies

2016-08-29 Thread Rafał Miłecki
On 29 August 2016 at 17:42, Baoyou Xie wrote: > On 29 August 2016 at 23:31, Rafał Miłecki wrote: >> >> On 29 August 2016 at 14:39, Baoyou Xie wrote: >> > We get 1 warning when build kernel with W=1: >> >

Re: [PATCH net v2 9/9] net: ethernet: mediatek: fix error handling inside mtk_mdio_init

2016-08-29 Thread Andrew Lunn
On Mon, Aug 29, 2016 at 01:03:23PM +0800, sean.w...@mediatek.com wrote: > From: Sean Wang > > return -ENODEV if no child is found in MDIO bus. The "no child" is wrong here, and got me confused. What the code is actually doing is of_device_is_available() which is looking

Re: [PATCH v2 net-next] documentation: Document issues with VMs and XPS and drivers enabling it on their own

2016-08-29 Thread Rick Jones
On 08/27/2016 12:41 PM, Tom Herbert wrote: On Fri, Aug 26, 2016 at 9:35 PM, David Miller wrote: From: Tom Herbert Date: Thu, 25 Aug 2016 16:43:35 -0700 This seems like it will only confuse users even more. You've clearly identified an issue, let's

[RESEND PATCH v6 1/3] net: ethernet: dwmac: add Ethernet glue logic for stm32 chip

2016-08-29 Thread Alexandre TORGUE
From: Alexandre TORGUE stm324xx family chips support Synopsys MAC 3.510 IP. This patch adds settings for logical glue logic: -clocks -mode selection MII or RMII. Reviewed-by: Joachim Eastwood Acked-by: Giuseppe Cavallaro

[RESEND PATCH v6 3/3] net: ethernet: stmmac: add support of Synopsys 3.50a MAC IP

2016-08-29 Thread Alexandre TORGUE
From: Alexandre TORGUE Adds support of Synopsys 3.50a MAC IP in stmmac driver. Acked-by: Giuseppe Cavallaro Tested-by: Maxime Coquelin Signed-off-by: Alexandre TORGUE diff --git

[RESEND PATCH v6 0/3] Add Ethernet support on STM32F429

2016-08-29 Thread Alexandre TORGUE
STM32F429 Chip embeds a Synopsys 3.50a MAC IP. This series enhance current stmmac driver to control it (code already available) and adds basic glue for STM32F429 chip. Changes since v5: -Fix typo in bindings documentation patch. -Change clocks names in stm32-dwmac glue driver / Documentation.

[RESEND PATCH v6 2/3] Documentation: Bindings: Add STM32 DWMAC glue

2016-08-29 Thread Alexandre TORGUE
From: Alexandre TORGUE Acked-by: Rob Herring Signed-off-by: Alexandre TORGUE diff --git a/Documentation/devicetree/bindings/net/stm32-dwmac.txt b/Documentation/devicetree/bindings/net/stm32-dwmac.txt new file mode

Re: [PATCH net v2 9/9] net: ethernet: mediatek: fix error handling inside mtk_mdio_init

2016-08-29 Thread Sean Wang
Date: Mon, 29 Aug 2016 15:15:58 +0200,Andrew Lunn wrote: >On Mon, Aug 29, 2016 at 01:03:23PM +0800, sean.w...@mediatek.com wrote: >> From: Sean Wang >> >> return -ENODEV if no child is found in MDIO bus. > >Hi Sean > >Why is it an error not to have any children on the

[RFC PATCH 5/6] ipv6: Remove useless parameter in __snmp6_fill_statsdev

2016-08-29 Thread Jia He
The parameter items(always ICMP6_MIB_MAX) is useless for __snmp6_fill_statsdev. Signed-off-by: Jia He --- net/ipv6/addrconf.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index df8425f..0fa5aa1

[RFC PATCH 2/6] proc: Reduce cache miss in snmp6_seq_show

2016-08-29 Thread Jia He
This patch exchanges the two loop for collecting the percpu statistics data. This can reduce cache misses by going through all the items of each cpu sequentially. Signed-off-by: Jia He --- net/ipv6/proc.c | 47 --- 1 file changed,

[RFC PATCH 1/6] proc: Reduce cache miss in {snmp,netstat}_seq_show

2016-08-29 Thread Jia He
This patch exchanges the two loop for collecting the percpu statistics data. This can aggregate the data by going through all the items of each cpu sequentially. In snmp_seq_show, just use one buff copy to dislay the Udp and UdpLite data because they are the same. Signed-off-by: Jia He

[RFC PATCH 3/6] proc: Reduce cache miss in sctp_snmp_seq_show

2016-08-29 Thread Jia He
This patch exchanges the two loop for collecting the percpu statistics data. This can reduce cache misses by going through all the items of each cpu sequentially. Signed-off-by: Jia He --- net/sctp/proc.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-)

[RFC PATCH 0/6] Reduce cache miss for snmp_fold_field

2016-08-29 Thread Jia He
In a PowerPc server with large cpu number(160), besides commit a3a773726c9f ("net: Optimize snmp stat aggregation by walking all the percpu data at once"), I watched several other snmp_fold_field callsites which will cause high cache miss rate. #My simple test case, which read from the procfs

[RFC PATCH 4/6] proc: Reduce cache miss in xfrm_statistics_seq_show

2016-08-29 Thread Jia He
This patch exchanges the two loop for collecting the percpu statistics data. This can reduce cache misses by going through all the items of each cpu sequentially. Signed-off-by: Jia He --- net/xfrm/xfrm_proc.c | 17 + 1 file changed, 13 insertions(+), 4

[RFC PATCH 6/6] net: Suppress the "Comparison to NULL

2016-08-29 Thread Jia He
This is to suppress the checkpatch.pl warning "Comparison to NULL could be written". No functional changes here. Signed-off-by: Jia He --- net/ipv4/proc.c | 42 +- net/sctp/proc.c | 4 ++-- net/xfrm/xfrm_proc.c | 4 ++-- 3

Re: [PATCH] net/mlx4_en: protect ring->xdp_prog with rcu_read_lock

2016-08-29 Thread Brenden Blanco
On Mon, Aug 29, 2016 at 05:59:26PM +0300, Tariq Toukan wrote: > Hi Brenden, > > The solution direction should be XDP specific that does not hurt the > regular flow. An rcu_read_lock is _already_ taken for _every_ packet. This is 1/64th of that. > > On 26/08/2016 11:38 PM, Brenden Blanco wrote: >

Re: [net-next PATCH] e1000: add initial XDP support

2016-08-29 Thread Jesper Dangaard Brouer
Hi Jamal, I'm adding: drop a specific UDP port option to my script... But I does not match/drop the packets, command below does apply, but it does not work in practice $ ./tc_ingress_drop.sh --verbose --dev mlx5p2 --port 9 tc qdisc del dev mlx5p2 ingress tc qdisc add dev mlx5p2 ingress tc

Re: [PATCH net-next 0/3] strp: Generalize stream parser to work with other socket types

2016-08-29 Thread Tom Herbert
On Sun, Aug 28, 2016 at 8:34 PM, David Miller wrote: > From: Tom Herbert > Date: Sun, 28 Aug 2016 14:43:16 -0700 > >> Add a read_sock protocol operation function that allows something like >> tcp_read_sock to be called for other protocol types. >> >>

Re: [RFCv2 01/16] add basic register-field manipulation macros

2016-08-29 Thread Daniel Borkmann
On 08/29/2016 05:07 PM, Jakub Kicinski wrote: On Mon, 29 Aug 2016 16:34:25 +0200, Daniel Borkmann wrote: On 08/26/2016 08:06 PM, Jakub Kicinski wrote: Common approach to accessing register fields is to define structures or sets of macros containing mask and shift pair. Operations on the

Re: [PATCH v4] brcmfmac: add missing header dependencies

2016-08-29 Thread Rafał Miłecki
On 29 August 2016 at 14:39, Baoyou Xie wrote: > We get 1 warning when build kernel with W=1: > drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c:23:6: warning: > no previous prototype for '__brcmf_err' [-Wmissing-prototypes] building? I'm not native English,

Re: [RFC 2/9] ipv6: sr: add code base for control plane support of SR-IPv6

2016-08-29 Thread Roopa Prabhu
On 8/26/16, 8:52 AM, David Lebrun wrote: > This patch adds the necessary hooks and structures to provide support > for SR-IPv6 control plane, essentially the Generic Netlink commands > that will be used for userspace control over the Segment Routing > kernel structures. > > The genetlink commands

  1   2   3   >