When system enters into kdump kernel because of kernel panic, it won't
shutdown devices. On-flight DMA will continue transferring data until
device driver initializes. All devices are supposed to reset during
driver initialization. And this property is used to fix the kdump
failure in system with i
Hi Dave,
This series from Mohamad improves the driver load/unload flows
to seamlessly handle pci errors and device internal errors recovery
reset flows.
Current pci and internal error handling is too heavy and is done
with a full restart of the driver by unregistering mlx5 interfaces
(mlx5e neted
From: Mohamad Haj Yahia
Simplify the code and makes it look modular and symmetric.
Split sriov enable/disable to two levels: device level and pci level.
When user enable/disable sriov (via sriov_configure driver callback) we
will enable/disable both device and pci sriov.
When driver load/unload w
From: Mohamad Haj Yahia
When detaching the mlx5e interface clear all the vlans rules from the
vlan flow table.
When attaching it back restore all the active vlans rules to the HW.
Signed-off-by: Mohamad Haj Yahia
Signed-off-by: Saeed Mahameed
---
drivers/net/ethernet/mellanox/mlx5/core/en_fs.
From: Mohamad Haj Yahia
In case of device in internal error state there is no need to wait for
vf pages since they will be reclaimed manually later in the unload flow.
Signed-off-by: Mohamad Haj Yahia
Signed-off-by: Saeed Mahameed
---
drivers/net/ethernet/mellanox/mlx5/core/pagealloc.c | 13 +
From: Mohamad Haj Yahia
Save the user configuration in the vport sturct.
Restore saved old configuration upon vport enable.
Signed-off-by: Mohamad Haj Yahia
Signed-off-by: Saeed Mahameed
---
drivers/net/ethernet/mellanox/mlx5/core/eswitch.c | 249 ++
drivers/net/ethernet/m
From: Mohamad Haj Yahia
Gather all software context creating/destroying in one function and call
it once in the first load and in the last unload.
load/unload functions will now receive indication if we need to
create/destroy the software contexts.
In internal/pci error do the unload/load flows w
From: Mohamad Haj Yahia
Hide the exposed (external) mlx5_dev_list and mlx5_intf_mutex and expose
an organized modular API to manage and manipulate mlx5 devices list.
Signed-off-by: Mohamad Haj Yahia
Signed-off-by: Saeed Mahameed
---
drivers/net/ethernet/mellanox/mlx5/core/Makefile | 2 +-
From: Mohamad Haj Yahia
Needed to support seamless and lightweight PCI/Internal error recovery.
Implement the attach/detach interface callbacks.
In attach callback we only allocate HW resources.
In detach callback we only deallocate HW resources.
All SW/kernel objects initialzing/destroying is ke
From: Mohamad Haj Yahia
Needed for lightweight and modular internal/pci error handling.
Implement sriov attach function which enables pre-saved number of vfs on
the device side.
Implement sriov detach function which disable the current vfs on the
device side.
Init/cleanup function only handles sr
From: Mohamad Haj Yahia
Add attach/detach callbacks to interface API.
This is crucial for implementing seamless reset flow which releases the
hardware and it's resources upon detach while keeping software
structures and state (e.g netdev) then reset and reallocate the hardware
needed resources up
From: Mohamad Haj Yahia
Init/cleanup sriov/eswitch in the core software context init/cleanup
flows.
Attach/detach sriov/eswitch in the core load/unload flows.
Signed-off-by: Mohamad Haj Yahia
Signed-off-by: Saeed Mahameed
---
drivers/net/ethernet/mellanox/mlx5/core/eswitch.c | 2 --
drivers/
From: Mohamad Haj Yahia
Needed for lightweight and modular internal/pci error handling.
Implement eswitch attach function which allocates/starts hw related
resources.
Implement eswitch detach function which releases/stops hw related
resources.
Init/cleanup function only handle eswitch software co
On Fri, Sep 09, 2016 at 03:11:57PM +0800, Xin Long wrote:
> >>
> > Its not enough to just look at the paths where outq_tail is called, because
> > the outq_tail function is checking a state variable that can update
> > asynchronously in the side effect processing queue. Look at any one of the
> >
Hi Corentin
> +static int sun8i_emac_mdio_register(struct net_device *ndev)
> +{
> + struct sun8i_emac_priv *priv = netdev_priv(ndev);
> + struct mii_bus *bus;
> + int ret;
> +
> + bus = mdiobus_alloc();
You can use devm_mdiobus_alloc() which will simplify your error
handling and
> +Optional properties:
> +- allwinner,tx-delay: TX clock delay chain value. Range value is 0-0x07.
> Default is 0)
> +- allwinner,rx-delay: RX clock delay chain value. Range value is 0-0x1F.
> Default is 0)
What are the units? pS? nS?
Andrew
On Fri, Sep 09, 2016 at 04:02:22PM +0200, Davide Caratti wrote:
> the maximum possible ICV length in a MACsec frame is 16 octects, not 32:
> fix get_icvlen() accordingly, so that a proper error message is displayed
> in case input 'icvlen' is greater than 16.
>
> Signed-off-by: Davide Caratti
Ac
Hi Richard,
I will take your indications into account in next version of the patch.
Regards,
Andrei
On 06.09.2016 18:37, Richard Cochran wrote:
On Fri, Sep 02, 2016 at 02:53:37PM +0200, Andrei Pistirica wrote:
Hardware time stamp on the PTP Ethernet packets are received using the
SO_TIMESTAMP
> +The device node referenced by "phy" or "phy-handle" should be a child node
> +of this node. See phy.txt for the generic PHY bindings.
I've not looked at the code yet, but is this really true? Generally
there is not this limitation. You can point to any Ethernet phy
anyway, so long as it is on a
the maximum possible ICV length in a MACsec frame is 16 octects, not 32:
fix get_icvlen() accordingly, so that a proper error message is displayed
in case input 'icvlen' is greater than 16.
Signed-off-by: Davide Caratti
---
ip/ipmacsec.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
On 06.09.2016 17:48, Richard Cochran wrote:
I have some issues with this patch...
On Fri, Sep 02, 2016 at 02:53:36PM +0200, Andrei Pistirica wrote:
- Frequency adjustment is not directly supported by this IP.
addend is the initial value ns increment and similarly addendesub.
The ppb (pa
> On Sep 8, 2016, at 9:19 AM, Jiri Pirko wrote:
>
> From: Nogah Frankel
>
> Add a nested attribute of offload stats to if_stats_msg
> named IFLA_STATS_LINK_OFFLOAD_XSTATS.
> Under it, add SW stats, meaning stats only per packets that went via
> slowpath to the cpu, named IFLA_OFFLOAD_XSTATS_CP
On 22/08/16 16:42, Vitaly Kuznetsov wrote:
> Small packet loss is reported on complex multi host network configurations
> including tunnels, NAT, ... My investigation led me to the following check
> in netback which drops packets:
>
> if (unlikely(txreq.size < ETH_HLEN)) {
>
Vitaly Kuznetsov writes:
> Vitaly Kuznetsov writes:
>
>> David Vrabel writes:
>>
>>> On 22/08/16 16:42, Vitaly Kuznetsov wrote:
I see two ways to fix the issue:
- Change the 'wire' protocol between netfront and netback to start keeping
the original SKB structure. We'll ha
> On Sep 9, 2016, at 4:36 PM, Nikolay Aleksandrov
> wrote:
>
>>
>> On Sep 8, 2016, at 9:19 AM, Jiri Pirko wrote:
>>
>> From: Nogah Frankel
>>
>> Add a nested attribute of offload stats to if_stats_msg
>> named IFLA_STATS_LINK_OFFLOAD_XSTATS.
>> Under it, add SW stats, meaning stats only pe
> On Sep 8, 2016, at 9:19 AM, Jiri Pirko wrote:
>
> From: Nogah Frankel
>
> Add a nested attribute of offload stats to if_stats_msg
> named IFLA_STATS_LINK_OFFLOAD_XSTATS.
> Under it, add SW stats, meaning stats only per packets that went via
> slowpath to the cpu, named IFLA_OFFLOAD_XSTATS_CP
On Thu, 2016-09-08 at 22:30 -0700, Cong Wang wrote:
> On Thu, Sep 8, 2016 at 9:15 AM, John Fastabend
> wrote:
> >
> > This should be rtnl_derefence(t->params) and drop the read_lock/unlock
> > pair. This is always called with RTNL lock unless you have a path I'm
> > not seeing.
>
> You missed th
> > > +static int vsc85xx_edge_rate_cntl_set(struct phy_device *phydev,
> > > + u8 edge_rate)
> >
> > No spaces place.
> >
> I ran the checkpatch. I did not find any error. I created another workspace
> and
> applied the same patch. It shows the correct alig
Hi Stephen,
Stephen Hemminger writes:
> On Thu, 8 Sep 2016 12:50:43 -0400
> Vivien Didelot wrote:
>
>> If /sbin/bridge-stp is available on the system, bridge tries to execute
>> it instead of the kernel implementation when starting/stopping STP.
>>
>> If anything goes wrong with /sbin/bridge-
This patch add pm_runtime support to sun8i-emac.
For the moment, only basic support is added, (the device is marked as
used when net/open)
Signed-off-by: Corentin Labbe
---
drivers/net/ethernet/allwinner/sun8i-emac.c | 62 -
1 file changed, 60 insertions(+), 2 deletio
This patch add myself as maintainer of the sun8i-emac driver.
Signed-off-by: Corentin Labbe
---
MAINTAINERS | 6 ++
1 file changed, 6 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 6781a3f..43f5be3 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -582,6 +582,12 @@ S: Maintained
F:
This patch add support for sun8i-emac ethernet MAC hardware.
It could be found in Allwinner H3/A83T/A64 SoCs.
It supports 10/100/1000 Mbit/s speed with half/full duplex.
It can use an internal PHY (MII 10/100) or an external PHY
via RGMII/RMII.
Signed-off-by: Corentin Labbe
---
drivers/net/ethe
Enable the sun8i-emac driver in the sunxi default configuration
Signed-off-by: Corentin Labbe
---
arch/arm/configs/sunxi_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/configs/sunxi_defconfig b/arch/arm/configs/sunxi_defconfig
index 714da33..153707a 100644
--- a/arch/arm/
The IS_ENABLED() macro checks if a Kconfig symbol has been enabled either
built-in or as a module, use that macro instead of open coding the same.
Using the macro makes the code more readable by helping abstract away some
of the Kconfig built-in and module enable details.
Signed-off-by: Javier Ma
Hello
This patch series add the driver for sun8i-emac which handle the Ethernet MAC
present on Allwinner H3/A83T/A64 SoCs.
It supports 10/100/1000 Mbit/s speed with half/full duplex.
It can use an internal PHY (MII 10/100) or an external PHY
via RGMII/RMII.
This patch series enable the driver on
The IS_ENABLED() macro checks if a Kconfig symbol has been enabled either
built-in or as a module, use that macro instead of open coding the same.
Using the macro makes the code more readable by helping abstract away some
of the Kconfig built-in and module enable details.
Signed-off-by: Javier Ma
This patch adds documentation for Device-Tree bindings for the
Allwinner sun8i-emac driver.
Signed-off-by: Corentin Labbe
---
.../bindings/net/allwinner,sun8i-emac.txt | 64 ++
1 file changed, 64 insertions(+)
create mode 100644
Documentation/devicetree/bindings/ne
The sun8i-emac hardware is present on the Orange PI PC.
It uses the internal PHY.
This patch create the needed emac and phy nodes.
Signed-off-by: Corentin Labbe
---
arch/arm/boot/dts/sun8i-h3-orangepi-pc.dts | 10 ++
1 file changed, 10 insertions(+)
diff --git a/arch/arm/boot/dts/sun8i
The IS_ENABLED() macro checks if a Kconfig symbol has been enabled either
built-in or as a module, use that macro instead of open coding the same.
Using the macro makes the code more readable by helping abstract away some
of the Kconfig built-in and module enable details.
Signed-off-by: Javier Ma
The sun8i-emac is an ethernet MAC hardware that support 10/100/1000
speed.
This patch enable the sun8i-emac on the Allwinner H3 SoC Device-tree.
The SoC H3 have an internal PHY, so optionals syscon and ephy are set.
Signed-off-by: Corentin Labbe
---
arch/arm/boot/dts/sun8i-h3.dtsi | 19
Hello David,
This trivial series replace the open coding to check for a Kconfig symbol
being built-in or module, with IS_ENABLED() macro that does exactly that.
Using the macro makes the code more readable by helping abstract away some
of the Kconfig built-in and module enable details.
Best rega
On 09/08/2016 07:00 PM, Sebastian Andrzej Siewior wrote:
> On 2016-08-19 17:29:16 [+0300], Grygorii Strashko wrote:
>> I've collected trace before first occurrence of "NOHZ:
>> local_softirq_pending 80"
>>
>
>> irq/354-4848400-85[000]90.642393: softirq_exit: vec=3
>> [action=N
This patch add the dt node for the syscon register present on the
Allwinner H3.
Only two register are present in this syscon and the only one useful is
the one dedicated to EMAC clock.
Signed-off-by: Corentin Labbe
---
arch/arm/boot/dts/sun8i-h3.dtsi | 5 +
1 file changed, 5 insertions(+)
From: Hans de Goede
The sun8i-emac hardware is present on the Orange PI One.
It uses the internal PHY.
This patch create the needed emac and phy nodes.
Signed-off-by: Hans de Goede
Signed-off-by: Corentin Labbe
---
arch/arm/boot/dts/sun8i-h3-orangepi-one.dts | 10 ++
1 file changed,
The IS_ENABLED() macro checks if a Kconfig symbol has been enabled either
built-in or as a module, use that macro instead of open coding the same.
Using the macro makes the code more readable by helping abstract away some
of the Kconfig built-in and module enable details.
Signed-off-by: Javier Ma
The IS_ENABLED() macro checks if a Kconfig symbol has been enabled either
built-in or as a module, use that macro instead of open coding the same.
Using the macro makes the code more readable by helping abstract away some
of the Kconfig built-in and module enable details.
Signed-off-by: Javier Ma
The IS_ENABLED() macro checks if a Kconfig symbol has been enabled either
built-in or as a module, use that macro instead of open coding the same.
Using the macro makes the code more readable by helping abstract away some
of the Kconfig built-in and module enable details.
Signed-off-by: Javier Ma
The IS_ENABLED() macro checks if a Kconfig symbol has been enabled either
built-in or as a module, use that macro instead of open coding the same.
Using the macro makes the code more readable by helping abstract away some
of the Kconfig built-in and module enable details.
Signed-off-by: Javier Ma
The IS_ENABLED() macro checks if a Kconfig symbol has been enabled either
built-in or as a module, use that macro instead of open coding the same.
Using the macro makes the code more readable by helping abstract away some
of the Kconfig built-in and module enable details.
Signed-off-by: Javier Ma
On 16-09-08 12:11 PM, Eric Dumazet wrote:
On Thu, 2016-09-08 at 09:02 -0700, Eric Dumazet wrote:
On Thu, 2016-09-08 at 06:38 -0400, Jamal Hadi Salim wrote:
On 16-09-06 10:25 AM, Eric Dumazet wrote:
This simply works for me.
But maybe you read the stats at the wrong place ?
Pleas give us mo
When the length of the packet is below the defined copybreak limit,
the received packet is copied into a newly allocated skb in order
to reuse the skb. This is only interesting if it allow us to avoid
a new DMA mapping. We shall therefore not DMA unmap and remap the
skb->data. Instead, we invalidat
Measurement shows that on a MPC8xx running at 132MHz, the optimal
limit is 112:
* 114 bytes packets are processed in 147 TB ticks with higher copybreak
* 114 bytes packets are processed in 148 TB ticks with lower copybreak
* 128 bytes packets are processed in 154 TB ticks with higher copybreak
* 12
Initially, a NAPI TX routine has been implemented separately from
NAPI RX, as done on the freescale/gianfar driver.
By merging NAPI RX and NAPI TX, we reduce the amount of TX completion
interrupts.
Handling of the budget in association with TX interrupts is based on
indications provided at https:
This set optimises the freescale fs_enet ethernet driver:
1/ Merge of RX and TX NAPI functions in order to limit the amount of
interrupts
2/ Do not unmap DMA when packets len is below copybreak, otherwise there
is no benefit in copying the skb instead of allocating a new one
3/ Make copybreak value
On Thu, 2016-09-08 at 22:59 -0700, Cong Wang wrote:
> On Thu, Sep 8, 2016 at 10:48 PM, Alexei Starovoitov
> wrote:
> >
> > imo the deliberate small race in Eric's initial lock removal in mirred
> > was a good design choice. I think he did this patch only to
> > silence the complains with the code
On Thu, 2016-09-08 at 22:24 -0700, Cong Wang wrote:
> On Thu, Sep 8, 2016 at 8:35 AM, Eric Dumazet wrote:
> > From: Eric Dumazet
> >
> > As reported by Cong Wang, I was lazy when I did initial RCU conversion
> > of tc_mirred, as I thought I could avoid allocation/freeing of a
> > parameter block.
On Thu, 2016-09-08 at 22:26 -0700, Cong Wang wrote:
> On Thu, Sep 8, 2016 at 8:51 AM, Eric Dumazet wrote:
> > On Thu, 2016-09-08 at 08:47 -0700, John Fastabend wrote:
> >
> >> Works for me. FWIW I find this plenty straightforward and don't really
> >> see the need to make the hash table itself rcu
Daniel Wagner wrote:
> From: Daniel Wagner
>
> carl9170_usb_stop() is used from several places to flush and cleanup any
> pending work. The normal pattern is to send a request and wait for the
> irq handler to call complete(). The completion is not reinitialized
> during normal operation and as
On Fri, Sep 09, 2016 at 11:23:52AM +0530, Raju Lakkaraju wrote:
> Hi Andrew,
>
> Thank you for review the code and valuable comments.
>
> On Thu, Sep 08, 2016 at 03:27:27PM +0200, Andrew Lunn wrote:
> > EXTERNAL EMAIL
> >
> >
> > On Thu, Sep 08, 2016 at 02:47:22PM +0530, Raju Lakkaraju wrote:
>
This patchset adds msi-x support to the alx driver. It is a preparatory
series for multi queue support, which I am currently working on. As there
is no advantage over msi interrupts without multi queue support, msi-x
interrupts are disabled by default. In order to test for regressions, a
new module
Introduce a new flag field for the advanced interrupt capatibilities and add
new functions to enable and disable msi interrupts. These functions will be
extended later to cover msi-x interrupts.
We enable msi interrupts earlier in alx_init_intr because with msi-x and multi
queue support the number
Add msi-x support to the alx driver. This is in preparation for multi queue
support.
msi-x interrupts are disabled by default because without multi queue support
there is no advantage over msi interrupts. The performance numbers observed
with iperf stay the same.
Based on information of the downs
Factor out the handling of misc interrupts into a new function.
This function can be reused later for msi-x interrupts.
Signed-off-by: Tobias Regnery
---
drivers/net/ethernet/atheros/alx/main.c | 34 +++--
1 file changed, 20 insertions(+), 14 deletions(-)
diff --git
msi-x support is default disabled in the alx driver. In order to test msi-x
interrupts for regressions add a module parameter to the driver.
Signed-off-by: Tobias Regnery
---
drivers/net/ethernet/atheros/alx/main.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/n
On 09/09/16 at 04:11pm, Baoquan He wrote:
> When system enters into kdump kernel because of kernel panic, it won't
> shutdown devices. On-flight DMA will continue transferring data until
> device driver initializes. All devices are supposed to reset during
> driver initialization. And this property
Hi Joerg,
On 09/09/16 at 10:41am, Joerg Roedel wrote:
>
> Hi Baoquan,
>
> On Fri, Sep 09, 2016 at 04:22:25PM +0800, Baoquan He wrote:
> > Recently I tried to fix the kdump failure in amd iommu system again, and
> > now the latest code works, IO_PAGE_FAULT can't be seen any more. But on
> > sever
Christophe Jaillet wrote:
> This patch:
>- improves code layout
>- removes a useless memset(0) for some memory allocated with kzalloc
>- removes a useless if. We know that 'if (chan_band_tlv)' will succeed
> because it has been tested a few lines above
>
> Signed-off-by: Christop
--
Attention,
This is to officially inform you that your payment that was Suppose to
be made payable to you from Africa has been handed over to the below
security company in Dubai, U.A.E. by the Africa government due to
Africa countries irregularities and inability to carry out the
transaction of
> On Thu, 8 Sep 2016 11:30:08 -0700
> Florian Fainelli wrote:
>
>> On 09/08/2016 10:19 AM, D. Herrendoerfer wrote:
>>>
>>> On 08 Sep 2016, at 17:39, Stephen Hemminger
>>> wrote:
>>>
On Thu, 8 Sep 2016 15:06:16 +0200
"D. Herrendoerfer" wrote:
> Hello,
>
> I'd li
On 09/09/16 at 10:41am, Joerg Roedel wrote:
>
> Hi Baoquan,
>
> On Fri, Sep 09, 2016 at 04:22:25PM +0800, Baoquan He wrote:
> > Recently I tried to fix the kdump failure in amd iommu system again, and
> > now the latest code works, IO_PAGE_FAULT can't be seen any more. But on
> > several amd iomm
Hi Baoquan,
On Fri, Sep 09, 2016 at 04:22:25PM +0800, Baoquan He wrote:
> Recently I tried to fix the kdump failure in amd iommu system again, and
> now the latest code works, IO_PAGE_FAULT can't be seen any more. But on
> several amd iommu system with bnx2 NIC, always IO_PAGE_FAULT will be
> pri
On Wed, Sep 07, 2016 at 08:40:38PM +0200, thomas.zeitlhofer+l...@ze-it.at wrote:
> In case of inter address family tunneling (IPv6 over vti4 or IPv4 over
> vti6), the inbound policy checks in vti_rcv_cb() and vti6_rcv_cb() are
> using the wrong address family. As a result, all inbound inter address
On Thu, Sep 08, 2016 at 06:09:57PM +0200, Mathias Krause wrote:
> When we fail to attach the security context in xfrm_state_construct()
> we'll return 0 as error value which, in turn, will wrongly claim success
> to userland when, in fact, we won't be adding / updating the XFRM state.
>
> This is
On Thu, Sep 08, 2016 at 02:42:23PM -0400, Richard Guy Briggs wrote:
> On 16/09/08, Richard Guy Briggs wrote:
> > Reported-by: Paul Wouters
>
> Oops, this above should read "nohats.ca".
I've fixed this up.
>
> > Signed-off-by: Richard Guy Briggs
Applied to ipsec-next, thanks Richard!
Hi Joreg,
Sorry, forget ccing to you.
Recently I tried to fix the kdump failure in amd iommu system again, and
now the latest code works, IO_PAGE_FAULT can't be seen any more. But on
several amd iommu system with bnx2 NIC, always IO_PAGE_FAULT will be
printed out. After investegating I found out
When system enters into kdump kernel because of kernel panic, it won't
shutdown devices. On-flight DMA will continue transferring data until
device driver initializes. All devices are supposed to reset during
driver initialization. And this property is used to fix the kdump
failure in system with i
The recently-added socket mark matching in inet_diag_bc_run is
inconsistent with the fwmark matching in fib_rule_match:
inet_diag_bc_run:
if ((entry->mark & cond->mask) != cond->mark)
yes = 0;
fib_rule_match:
if ((rule->mark ^ fl->flowi_mark) & rule->mark_mask)
Since commit 8a29111c7 ("net: gro: allow to build full sized skb")
gro may build buffers with a frag_list. This can hurt forwarding
because most NICs can't offload such packets, they need to be
segmented in software. This patch splits buffers with a frag_list
at the frag_list pointer into buffers t
>>
> What path does this occur in? __sctp_lookup_association takes a hold on the
> asoc, and that function is protected by the rcu_read_lock, so I'm not sure how
> you get into a situation in which the asoc can be deleted while the lookup is
> occuring.
>
yes that function is protected by the rcu
>>
> Its not enough to just look at the paths where outq_tail is called, because
> the outq_tail function is checking a state variable that can update
> asynchronously in the side effect processing queue. Look at any one of the
> timer functions. Those all fire asynchronous to the outq list, but
101 - 180 of 180 matches
Mail list logo
