Hi Scott,
Thanks for your review :)
See my comment inline.
> -Original Message-
> From: Scott Wood [mailto:o...@buserror.net]
> Sent: Friday, September 09, 2016 11:47 AM
> To: Y.B. Lu; linux-...@vger.kernel.org; ulf.hans...@linaro.org; Arnd
> Bergmann
> Cc: linuxppc-...@lists.ozlabs.org;
On Fri, Sep 9, 2016 at 8:52 AM, John Fastabend wrote:
> On 16-09-08 10:26 PM, Cong Wang wrote:
>> On Thu, Sep 8, 2016 at 8:51 AM, Eric Dumazet wrote:
>>> On Thu, 2016-09-08 at 08:47 -0700, John Fastabend wrote:
>>>
Works for me. FWIW I find this plenty straightforward and don't really
s
If 'inet_diag_lock_handler()' returns an error, we should not call
'inet_diag_unlock_handler()' on it.
'handler' is not a valid mutexc in this case.
This has been spotted with the folowing coccinelle script:
@@
expression x;
identifier f;
@@
* if (IS_ERR(x))
{
On Fri, Sep 9, 2016 at 5:23 AM, Eric Dumazet wrote:
> On Thu, 2016-09-08 at 22:24 -0700, Cong Wang wrote:
>> On Thu, Sep 8, 2016 at 8:35 AM, Eric Dumazet wrote:
>> > From: Eric Dumazet
>> >
>> > As reported by Cong Wang, I was lazy when I did initial RCU conversion
>> > of tc_mirred, as I though
On Sun, Sep 11, 2016 at 03:05:49PM +0200, Julia Lawall wrote:
> For structure types defined in the same file or local header files, find
> top-level static structure declarations that have the following
> properties:
> 1. Never reassigned.
> 2. Address never taken
> 3. Not passed to a top-level mac
This patch implements the remaining Verbs functions registered with the
core RDMA stack.
Reviewed-by: Jorgen Hansen
Reviewed-by: George Zhang
Reviewed-by: Aditya Sarwade
Reviewed-by: Bryan Tan
Signed-off-by: Adit Ranadive
---
Changes v3->v4:
- Renamed priviledged -> privileged.
- Added erro
We share some common structures with the user-level driver. This patch
adds those structures and shared functions to traverse the QP/CQ rings.
Reviewed-by: Yuval Shaia
Reviewed-by: Jorgen Hansen
Reviewed-by: George Zhang
Reviewed-by: Aditya Sarwade
Reviewed-by: Bryan Tan
Signed-off-by: Adit R
This patch adds the support to register a RDMA device with the kernel RDMA
stack as well as a kernel module. This also initializes the underlying
virtual PCI device.
Reviewed-by: Yuval Shaia
Reviewed-by: Jorgen Hansen
Reviewed-by: George Zhang
Reviewed-by: Aditya Sarwade
Reviewed-by: Bryan Tan
This patch adds the main device-level structures and functions to be used
to provide RDMA functionality. Also, we define conversion functions from
the IB core stack structures to the device-specific ones.
Reviewed-by: Jorgen Hansen
Reviewed-by: George Zhang
Reviewed-by: Aditya Sarwade
Reviewed-
This patch adds support for creating and destroying memory regions. The
PVRDMA device supports User MRs, DMA MRs (no Remote Read/Write support),
Fast Register MRs.
Reviewed-by: Jorgen Hansen
Reviewed-by: George Zhang
Reviewed-by: Aditya Sarwade
Reviewed-by: Bryan Tan
Signed-off-by: Adit Ranadi
This patch adds the ability to create, modify, query and destroy QPs. The
PVRDMA device supports RC, UD and GSI QPs.
Reviewed-by: Jorgen Hansen
Reviewed-by: George Zhang
Reviewed-by: Aditya Sarwade
Reviewed-by: Bryan Tan
Signed-off-by: Adit Ranadive
---
Changes v3->v4:
- Removed an unnecessa
This patch describes the main specification of the underlying virtual RDMA
device. The pvrdma_dev_api header file defines the Verbs commands and
their parameters that can be issued to the device backend.
Reviewed-by: Yuval Shaia
Reviewed-by: Jorgen Hansen
Reviewed-by: George Zhang
Reviewed-by:
This patch updates the InfiniBand subsystem to build the PVRDMA driver.
Reviewed-by: Jorgen Hansen
Reviewed-by: George Zhang
Reviewed-by: Aditya Sarwade
Reviewed-by: Bryan Tan
Signed-off-by: Adit Ranadive
---
drivers/infiniband/Kconfig | 1 +
drivers/infiniband/hw/Makefile | 1 +
2 files
Add maintainer info for the PVRDMA driver.
Reviewed-by: Jorgen Hansen
Reviewed-by: George Zhang
Reviewed-by: Aditya Sarwade
Reviewed-by: Bryan Tan
Signed-off-by: Adit Ranadive
---
MAINTAINERS | 7 +++
1 file changed, 7 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 87e23cd..
This patch adds the various Verbs structures that we support in the
virtual RDMA device. We have re-mapped the ones from the RDMA core stack
to make sure we can maintain compatibility with our backend.
Reviewed-by: Jorgen Hansen
Reviewed-by: George Zhang
Reviewed-by: Aditya Sarwade
Reviewed-by:
This patch adds the UAR support for the paravirtual RDMA device. The UAR
pages are MMIO pages from the virtual PCI space. We define offsets within
this page to provide the fast data-path operations.
Reviewed-by: Yuval Shaia
Reviewed-by: Jorgen Hansen
Reviewed-by: George Zhang
Reviewed-by: Adity
This patch enables posting Verb requests and receiving responses to/from
the backend PVRDMA emulation layer.
Reviewed-by: Yuval Shaia
Reviewed-by: Jorgen Hansen
Reviewed-by: George Zhang
Reviewed-by: Aditya Sarwade
Reviewed-by: Bryan Tan
Signed-off-by: Adit Ranadive
---
Changes v3->v4:
- Re
This patch adds a Kconfig and Makefile for the PVRDMA driver.
Reviewed-by: Jorgen Hansen
Reviewed-by: George Zhang
Reviewed-by: Aditya Sarwade
Reviewed-by: Bryan Tan
Signed-off-by: Adit Ranadive
---
Changes v3->v4:
- Enforced dependency on VMXNet3
---
drivers/infiniband/hw/pvrdma/Kconfig |
This patch adds the support for creating and destroying completion queues
on the paravirtual RDMA device.
Reviewed-by: Jorgen Hansen
Reviewed-by: George Zhang
Reviewed-by: Aditya Sarwade
Reviewed-by: Bryan Tan
Signed-off-by: Adit Ranadive
---
Changes v3->v4:
- Added a pvrdma_destroy_cq in th
This patch adds helper functions to store guest page addresses in a page
directory structure. The page directory pointer is passed down to the
backend which then maps the entire memory for the RDMA object by
traversing the directory. We add some more helper functions for converting
to/from RDMA sta
The VMXNet3 PCI Id will be shared with our paravirtual RDMA driver.
Moved it to the shared location in pci_ids.h.
Suggested-by: Leon Romanovsky
Signed-off-by: Adit Ranadive
---
---
drivers/net/vmxnet3/vmxnet3_int.h | 3 +--
include/linux/pci_ids.h | 1 +
2 files changed, 2 insertions(
Hi Doug, others,
This patch series adds a driver for a paravirtual RDMA device. The device
is developed for VMware's Virtual Machines and allows existing RDMA
applications to continue to use existing Verbs API when deployed in VMs on
ESXi. We recently did a presentation in the OFA Workshop [1] reg
On Sun, Sep 11, 2016 at 08:15:28PM -0700, John Fastabend wrote:
>
> >>> But what is the action for XDP_TX if the queue is stopped? There is no
> >>> qdisc to back pressure in the XDP path. Would we just start dropping
> >>> packets then?
> >>
> >> Yep that is what the p
On 16-09-09 09:13 PM, Tom Herbert wrote:
> On Fri, Sep 9, 2016 at 8:26 PM, John Fastabend
> wrote:
>> On 16-09-09 08:12 PM, Tom Herbert wrote:
>>> On Fri, Sep 9, 2016 at 6:40 PM, Alexei Starovoitov
>>> wrote:
On Fri, Sep 09, 2016 at 06:19:56PM -0700, Tom Herbert wrote:
> On Fri, Sep 9,
Mostly small sets of driver fixes scattered all over the place.
1) Mediatek driver fixes from Sean Wang. Forward port not written
correctly during TX map, missed handling of EPROBE_DEFER, and
mistaken use of put_page() instead of skb_free_frag().
2) Fix socket double-free in KCM code, fro
On 16-09-10 08:36 AM, Tom Herbert wrote:
> On Fri, Sep 9, 2016 at 2:29 PM, John Fastabend
> wrote:
>> e1000 supports a single TX queue so it is being shared with the stack
>> when XDP runs XDP_TX action. This requires taking the xmit lock to
>> ensure we don't corrupt the tx ring. To avoid taking
Jarod Wilson wrote:
> On Tue, Sep 06, 2016 at 04:55:29PM -0700, David Miller wrote:
>> From: Jarod Wilson
>> Date: Fri, 2 Sep 2016 13:07:42 -0400
>>
>>> In any case, the number of "mtu < 68" and "#define FOO_MIN_MTU 68", or
>>> variations thereof, under drivers/net/ is kind of crazy.
>>
>> Agree
Julia, I went over the networking driver patches in this series and
I have to say that I'd rather see these changes be more durable
and self-checking.
By this I mean that I want you to also make the driver private pointer
that holds these structures be const too.
Then if there are really any ass
> Actually breaking this up into easily digestable/mergeable chunks is going
> to be kind of entertaining... Suggestions welcomed on that. First up is
> obviously the core change, which touches just net/ethernet/eth.c,
> net/core/dev.c, include/linux/netdevice.h and
> include/uapi/linux/if_ether.h,
From: Tariq Toukan
Date: Sun, 11 Sep 2016 10:56:16 +0300
> This patchset contains several bug fixes from the team to the
> mlx4 Eth driver.
>
> Series generated against net commit:
> c2f57fb97da5 "drivers: net: phy: mdio-xgene: Add hardware dependency"
...
> v2:
> * excluded some cleanup patche
From: Florian Fainelli
Date: Sat, 10 Sep 2016 12:39:03 -0700
> While migrating the bcm_sf2 driver to use b53_common, we left a small
> piece untouched where we kept our local copy of the per-port
> port_vlan_ctl bitmask value. This value is now maintained by b53_device
> so we need to use it inst
The function ip_rcv_finish() calls l3mdev_ip_rcv(). On any VRF except
the global VRF, this replaces skb->dev with the VRF master interface.
When calling ip_route_input_noref() from here, the checks for forwarding
look at this master device instead of the initial ingress interface.
This will allow p
Hi all,
Today's linux-next merge of the net-next tree got a conflict in:
drivers/net/phy/Kconfig
between commit:
c2f57fb97da5 ("drivers: net: phy: mdio-xgene: Add hardware dependency")
from the net tree and commit:
d75b4a22b255 ("net: phy: Sort Makefile and Kconfig")
from the net-next
Hello,
I have a device with a Meson GXBB SoC with an stmmac IP block.
Gbit ethernet on my device is provided by a Realtek RTL8211F RGMII PHY.
Similar issues were reported in #linux-amlogic by a user with an
Odroid C2 board (= similar hardware).
The symptoms are:
Receiving data is plenty fast (I c
If 'IS_ERR(pdata->clk)' is true, then 'clk_disable_unprepare(pdata->clk)'
will do nothing.
It is likely that 'if (!IS_ERR(pdata->clk))' was expected here.
In fact, the test can even be removed because 'clk_disable_unprepare'
already handles such cases.
Signed-off-by: Christophe JAILLET
---
driv
On Sat, Sep 10, 2016 at 04:28:40PM -0600, David Ahern wrote:
> On 9/10/16 4:05 PM, Cyrill Gorcunov wrote:
> > On Sat, Sep 10, 2016 at 10:31:35AM -0600, David Ahern wrote:
> >>
> >> Would you mind adding the destroy capability as well? The udp version
> >> should be close to what is needed for raw s
On Sun, 11 Sep 2016, Joe Perches wrote:
> On Sun, 2016-09-11 at 15:05 +0200, Julia Lawall wrote:
> > Constify local structures.
>
> Thanks Julia.
>
> A few suggestions & questions:
>
> Perhaps the script should go into scripts/coccinelle/
> so that future cases could be caught by the robot
> and
On Sun, Sep 11, 2016 at 9:30 AM, Jamal Hadi Salim wrote:
>
> What do you want the commit message to say? It shows an example because
> the functionality broke.
I expect it to explain why we need to increase that refcnt for GET
and how we missed it. Also need to find a right commit to blame. ;)
T
On 09/11/2016 04:06 PM, Julia Lawall wrote:
For structure types defined in the same file or local header files, find
top-level static structure declarations that have the following
properties:
1. Never reassigned.
Really?
2. Address never taken
Really?
3. Not passed to a top-level mac
On Sun, 2016-09-11 at 15:05 +0200, Julia Lawall wrote:
> Constify local structures.
Thanks Julia.
A few suggestions & questions:
Perhaps the script should go into scripts/coccinelle/
so that future cases could be caught by the robot
and commit message referenced by the patch instances.
Can you
On Sun, Sep 11, 2016 at 03:05:42PM +0200, Julia Lawall wrote:
> Constify local structures.
>
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
Just my two cents but:
1. You *can* use a static analysis too to find bugs or other issues.
2. However, you shoul
On 16-09-08 01:12 PM, Cong Wang wrote:
+}
+
static int
tca_action_gd(struct net *net, struct nlattr *nla, struct nlmsghdr *n,
u32 portid, int event)
@@ -883,6 +894,7 @@ tca_action_gd(struct net *net, struct nlattr *nla, struct
nlmsghdr *n,
goto err;
The ethtool api {get|set}_settings is deprecated.
We move this driver to new api {get|set}_link_ksettings.
Signed-off-by: Philippe Reynes
---
.../net/ethernet/apm/xgene/xgene_enet_ethtool.c| 61
1 files changed, 37 insertions(+), 24 deletions(-)
diff --git a/drivers/n
The private structure contain a pointer to phydev, but the structure
net_device already contain such pointer. So we can remove the pointer
phy_dev in the private structure, and update the driver to use the
one contained in struct net_device.
Signed-off-by: Philippe Reynes
---
.../net/ethernet/ap
For structure types defined in the same file or local header files, find
top-level static structure declarations that have the following
properties:
1. Never reassigned.
2. Address never taken
3. Not passed to a top-level macro call
4. No pointer or array-typed field passed to a function or stored
For structure types defined in the same file or local header files, find
top-level static structure declarations that have the following
properties:
1. Never reassigned.
2. Address never taken
3. Not passed to a top-level macro call
4. No pointer or array-typed field passed to a function or stored
For structure types defined in the same file or local header files, find
top-level static structure declarations that have the following
properties:
1. Never reassigned.
2. Address never taken
3. Not passed to a top-level macro call
4. No pointer or array-typed field passed to a function or stored
For structure types defined in the same file or local header files, find
top-level static structure declarations that have the following
properties:
1. Never reassigned.
2. Address never taken
3. Not passed to a top-level macro call
4. No pointer or array-typed field passed to a function or stored
For structure types defined in the same file or local header files, find
top-level static structure declarations that have the following
properties:
1. Never reassigned.
2. Address never taken
3. Not passed to a top-level macro call
4. No pointer or array-typed field passed to a function or stored
For structure types defined in the same file or local header files, find
top-level static structure declarations that have the following
properties:
1. Never reassigned.
2. Address never taken
3. Not passed to a top-level macro call
4. No pointer or array-typed field passed to a function or stored
For structure types defined in the same file or local header files, find
top-level static structure declarations that have the following
properties:
1. Never reassigned.
2. Address never taken
3. Not passed to a top-level macro call
4. No pointer or array-typed field passed to a function or stored
Constify local structures.
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
//
// The first rule ignores some cases that posed problems
@r disable optional_qualifier@
identifier s != {peri_clk_data,threshold_attr,tracer_flags,tracer};
identifier i != {s5k5baf
For structure types defined in the same file or local header files, find
top-level static structure declarations that have the following
properties:
1. Never reassigned.
2. Address never taken
3. Not passed to a top-level macro call
4. No pointer or array-typed field passed to a function or stored
For structure types defined in the same file or local header files, find
top-level static structure declarations that have the following
properties:
1. Never reassigned.
2. Address never taken
3. Not passed to a top-level macro call
4. No pointer or array-typed field passed to a function or stored
On Sun, Sep 11 2016, 03:02 AM, Andreas Noever wrote:
> On Mon, Aug 1, 2016 at 2:23 PM, Amir Levy wrote:
> > Adding more Thunderbolt(TM) register definitions and some helper
> > macros.
>
> Thinking about this again I would prefer it if you would put your definitions
> into a separate file under i
> - dev_dbg(&oct->pci_dev->dev, "%s[%llx] : 0x%llx\n",
> - "CN23XX_WIN_WR_MASK_REG",
> + pr_devel("%s[%llx] : 0x%llx\n",
> + "CN23XX_WIN_WR_MASK_REG",
It looks like at least half of this patch [and I think it's also true for other
patches in this series] merely
From: Kamal Heib
mlx4_en_dcbnl_set_state() returns u8, the return value from
mlx4_en_setup_tc() could be negative in case of failure, so fix that.
Fixes: af7d51852631 ("net/mlx4_en: Add DCB PFC support through CEE netlink
commands")
Signed-off-by: Kamal Heib
Signed-off-by: Tariq Toukan
---
d
From: Moshe Shemesh
When port is down, tx drop counter update is not needed.
Updating the counter in this case can cause a kernel
panic as when the port is down, ring can be NULL.
Fixes: 63a664b7e92b ("net/mlx4_en: fix tx_dropped bug")
Signed-off-by: Moshe Shemesh
Signed-off-by: Tariq Toukan
-
This patch adds a capability check before enabling DCBX.
In addition, it re-organizes the relevant data structures,
and fixes a typo in a define.
Fixes: af7d51852631 ("net/mlx4_en: Add DCB PFC support through CEE netlink
commands")
Signed-off-by: Tariq Toukan
---
drivers/net/ethernet/mellanox/m
Hi Dave,
This patchset contains several bug fixes from the team to the
mlx4 Eth driver.
Series generated against net commit:
c2f57fb97da5 "drivers: net: phy: mdio-xgene: Add hardware dependency"
Thanks,
Tariq.
v2:
* excluded some cleanup patches.
Kamal Heib (2):
net/mlx4_en: Fix the return v
From: Kamal Heib
mlx4_en_dcbnl_set_all() returns u8, so return value can't be negative in
case of failure.
Fixes: af7d51852631 ("net/mlx4_en: Add DCB PFC support through CEE netlink
commands")
Signed-off-by: Kamal Heib
Signed-off-by: Rana Shahout
Reported-by: Dan Carpenter
Signed-off-by: Tar
Hi,
I have a question as a relatively new user to IPv6. I am wondering if it
is currently possible to enable/disable the usage of temporary addresses
on a per-prefix basis. My current understanding is that the feature is
enabled by the the 'use_tempaddr' sysctl attribute, which is
per-interfa
Hi Dave,
On 08/09/2016 11:36 PM, David Miller wrote:
From: Tariq Toukan
Date: Thu, 8 Sep 2016 11:51:58 +0300
From: Leon Romanovsky
Radix tree lookup can be performed without locking.
Fixes: 225c7b1feef1 ("IB/mlx4: Add a driver Mellanox ConnectX InfiniBand
adapters")
Suggested-by: Sagi Gr
63 matches
Mail list logo