[PATCH] ipv6 addrconf: implement RFC7559 router solicitation backoff

2016-09-27 Thread Maciej Żenczykowski
From: Maciej Żenczykowski This implements: https://tools.ietf.org/html/rfc7559 Backoff is performed according to RFC3315 section 14: https://tools.ietf.org/html/rfc3315#section-14 We allow setting /proc/sys/net/ipv6/conf/*/router_solicitations to a negative value meaning an unlimited number

[PATCH v5 6/7] ipv6: Remove useless parameter in __snmp6_fill_statsdev

2016-09-27 Thread Jia He
The parameter items(always ICMP6_MIB_MAX) is useless for __snmp6_fill_statsdev. Signed-off-by: Jia He --- net/ipv6/addrconf.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index 2f1f5d4..35d4baa 100644 --- a/net/ipv6/ad

[PATCH v5 5/7] proc: Reduce cache miss in xfrm_statistics_seq_show

2016-09-27 Thread Jia He
This is to use the generic interfaces snmp_get_cpu_field{,64}_batch to aggregate the data by going through all the items of each cpu sequentially. Signed-off-by: Jia He --- net/xfrm/xfrm_proc.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/net/xfrm/xfrm_proc.c

[PATCH v5 1/7] net:snmp: Introduce generic interfaces for snmp_get_cpu_field{,64}

2016-09-27 Thread Jia He
This is to introduce the generic interfaces for snmp_get_cpu_field{,64}. It exchanges the two for-loops for collecting the percpu statistics data. This can aggregate the data by going through all the items of each cpu sequentially. Signed-off-by: Jia He Suggested-by: Marcelo Ricardo Leitner ---

[PATCH v5 3/7] proc: Reduce cache miss in snmp6_seq_show

2016-09-27 Thread Jia He
This is to use the generic interfaces snmp_get_cpu_field{,64}_batch to aggregate the data by going through all the items of each cpu sequentially. Signed-off-by: Jia He --- net/ipv6/proc.c | 32 +++- 1 file changed, 23 insertions(+), 9 deletions(-) diff --git a/net/i

[PATCH v5 7/7] net: Suppress the "Comparison to NULL could be written" warnings

2016-09-27 Thread Jia He
This is to suppress the checkpatch.pl warning "Comparison to NULL could be written". No functional changes here. Signed-off-by: Jia He --- net/ipv4/proc.c | 32 net/sctp/proc.c | 2 +- 2 files changed, 17 insertions(+), 17 deletions(-) diff --git a/net/ipv4/pro

[PATCH v5 4/7] proc: Reduce cache miss in sctp_snmp_seq_show

2016-09-27 Thread Jia He
This is to use the generic interfaces snmp_get_cpu_field{,64}_batch to aggregate the data by going through all the items of each cpu sequentially. Signed-off-by: Jia He --- net/sctp/proc.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/net/sctp/proc.c b/net/sctp/p

[PATCH v5 0/7] Reduce cache miss for snmp_fold_field

2016-09-27 Thread Jia He
In a PowerPc server with large cpu number(160), besides commit a3a773726c9f ("net: Optimize snmp stat aggregation by walking all the percpu data at once"), I watched several other snmp_fold_field callsites which would cause high cache miss rate. test source code: My simple test ca

[PATCH v5 2/7] proc: Reduce cache miss in snmp_seq_show

2016-09-27 Thread Jia He
This is to use the generic interfaces snmp_get_cpu_field{,64}_batch to aggregate the data by going through all the items of each cpu sequentially. Then snmp_seq_show is split into 2 parts to avoid build warning "the frame size" larger than 1024. Signed-off-by: Jia He --- net/ipv4/proc.c | 68 +++

Re: [PATCH RFC 1/3] net: Add dev_set_env_hdr_len to accept envelope frames

2016-09-27 Thread Toshiaki Makita
On 2016/09/27 23:23, Mintz, Yuval wrote: >> +/* return envelope header length */ >> +static inline int netif_get_env_hdr_len(struct net_device *dev) { >> +if (dev->netdev_ops->ndo_set_env_hdr_len) >> +return dev->env_hdr_len; >> + >> +if (netif_reduces_vlan_mtu(dev)) >> +

Re: [PATCH v3 net-next] tcp: Change txhash on every SYN and RTO retransmit

2016-09-27 Thread Lawrence Brakmo
Neal and Yuchung, thank you for the feedback. I¹ve submitted v4 with your recommended changes. Thanks, Larry On 9/27/16, 6:28 PM, "Neal Cardwell" wrote: >On Tue, Sep 27, 2016 at 8:18 PM, Yuchung Cheng wrote: >> On Tue, Sep 27, 2016 at 4:31 PM, Lawrence Brakmo wrote: >>> @@ -213,6 +215,8 @@ st

Re: [net-next v2 0/4][pull request] 1GbE Intel Wired LAN Driver Updates 2016-09-27

2016-09-27 Thread David Miller
From: Jeff Kirsher Date: Tue, 27 Sep 2016 19:04:57 -0700 > This series contains updates to igb and igbvf. Pulled, thanks Jeff.

Re: [PATCH nf-next v2 1/2] netfilter: Fix potential null pointer dereference

2016-09-27 Thread Liping Zhang
2016-09-28 11:08 GMT+08:00 Liping Zhang : > Hi Feng, > > 2016-09-28 9:23 GMT+08:00 Feng Gao : >> Hi Aaraon, >> >> On Tue, Sep 27, 2016 at 9:38 PM, Aaron Conole wrote: >>> It's possible for nf_hook_entry_head to return NULL if two >>> nf_unregister_net_hook calls happen simultaneously with a single

Re: [PATCH nf-next v2 1/2] netfilter: Fix potential null pointer dereference

2016-09-27 Thread Liping Zhang
Hi Feng, 2016-09-28 9:23 GMT+08:00 Feng Gao : > Hi Aaraon, > > On Tue, Sep 27, 2016 at 9:38 PM, Aaron Conole wrote: >> It's possible for nf_hook_entry_head to return NULL if two >> nf_unregister_net_hook calls happen simultaneously with a single hook > > The critical region of nf_unregister_net_h

Re: [PATCH RFC net-next] bnx2x: avoid printing unnecessary messages during register dump

2016-09-27 Thread David Miller
From: "Guilherme G. Piccoli" Date: Tue, 27 Sep 2016 15:33:54 -0300 > The bnx2x driver prints multiple error messages during register dump, > with "ethtool -d" for example. The driver even warn that many messages > might be seen during the register dump, but they are harmless. A typical > kernel l

Re: [PATCH v2] netfilter: xt_hashlimit: Fix link error in 32bit arch because of 64bit division

2016-09-27 Thread Maciej Żenczykowski
I don't think you actually need the backslashes since this ain't in a MACRO definition context.

Re: [PATCH V2 net-next 15/15] smc: proc-fs interface for smc connections

2016-09-27 Thread David Miller
From: Ursula Braun Date: Tue, 27 Sep 2016 18:41:56 +0200 > Maintain a list of SMC sockets and display important SMC socket > information in /proc/net/smc. > > Signed-off-by: Ursula Braun Dumping internal tables and information via /procfs is strongly deprecated. Please use a more modern mecha

Re: [RFC 0/3] ipsec: flow cache removal

2016-09-27 Thread David Miller
From: Florian Westphal Date: Tue, 27 Sep 2016 18:05:20 +0200 > Please do not apply these patches. To be honest, I really want to :-) > These are part of tests I made for the ipsec workshop at upcoming > netdev 1.2 and I wanted to post these before the conference. > > Short version is that ther

Re: Explaining RX-stages for XDP

2016-09-27 Thread Alexei Starovoitov
On Tue, Sep 27, 2016 at 11:32:37AM +0200, Jesper Dangaard Brouer wrote: > > Let me try in a calm way (not like [1]) to explain how I imagine that > the XDP processing RX-stage should be implemented. As I've pointed out > before[2], I'm proposing splitting up the driver into RX-stages. This > is a

Re: [PATCH v3] Net Driver: Add Cypress GX3 VID=04b4 PID=3610.

2016-09-27 Thread David Miller
From: Date: Tue, 27 Sep 2016 09:57:50 -0600 > From: Chris Roth > > From Allan Chou > From: Chris Roth Three From lines, it's actually quite amazing how you were able to achieve this. Please take some time, and carefully craft your patch emails but don't send them to the list. Instead, emai

Re: [PATCH trival -resend 2/2] lib: clean up put_cpu_var usage

2016-09-27 Thread David Miller
From: Shaohua Li Date: Tue, 27 Sep 2016 08:42:42 -0700 > put_cpu_var takes the percpu data, not the data returned from > get_cpu_var. > > This doesn't change the behavior. > > Cc: Tejun Heo > Signed-off-by: Shaohua Li Applied.

Re: [PATCH trival -resend 1/2] bpf: clean up put_cpu_var usage

2016-09-27 Thread David Miller
From: Shaohua Li Date: Tue, 27 Sep 2016 08:42:41 -0700 > put_cpu_var takes the percpu data, not the data returned from > get_cpu_var. > > This doesn't change the behavior. > > Cc: Tejun Heo > Cc: Alexei Starovoitov > Signed-off-by: Shaohua Li Applied.

Re: kernel BUG at net/unix/garbage.c:149!"

2016-09-27 Thread David Miller
From: Nikolay Borisov Date: Tue, 27 Sep 2016 17:16:27 +0300 > What's the status of https://patchwork.ozlabs.org/patch/664062/ , is > this going to be picked up ? Why would I apply a patch that's an RFC, doesn't have a proper commit message, lacks a proper signoff, and also lacks ACK's and feedba

[net-next v2 2/4] igbvf: bump version to igbvf-2.4.0

2016-09-27 Thread Jeff Kirsher
From: Todd Fujinaka Bump version to match other igbvf drivers. Signed-off-by: Todd Fujinaka Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/igbvf/netdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/igbvf/ne

[net-next v2 0/4][pull request] 1GbE Intel Wired LAN Driver Updates 2016-09-27

2016-09-27 Thread Jeff Kirsher
This series contains updates to igb and igbvf. Wei Yongjun makes a function static to shut up sparse. Todd bumps the igb and igbvf version, which is long overdue. Jake fixes an issue where the PPS SYS_WRAP interrupt was not re-enabled after a reset, which resulted in disabling of the PPS signali

[net-next v2 4/4] igb: restore PPS signal on igb_ptp_reset

2016-09-27 Thread Jeff Kirsher
From: Jacob Keller When a reset occurs, the PPS SYS_WRAP interrupt was not re-enabled which resulted in disabling of the PPS signaling. Fix this by recording when the interrupt is on and ensuring that we re-enable it every time we reset. Signed-off-by: Jacob Keller Tested-by: Aaron Brown Signe

[net-next v2 1/4] igb: fix non static symbol warning

2016-09-27 Thread Jeff Kirsher
From: Wei Yongjun Fixes the following sparse warning: drivers/net/ethernet/intel/igb/igb_ethtool.c:2707:5: warning: symbol 'igb_rxnfc_write_vlan_prio_filter' was not declared. Should it be static? Signed-off-by: Wei Yongjun Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher --- drivers/ne

[net-next v2 3/4] igb: bump version to igb-5.4.0

2016-09-27 Thread Jeff Kirsher
From: Todd Fujinaka Bump igb version to match other igb drivers. Signed-off-by: Todd Fujinaka Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/igb/igb_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/igb/ig

[PATCH v4 net-next] tcp: Change txhash on every SYN and RTO retransmit

2016-09-27 Thread Lawrence Brakmo
The current code changes txhash (flowlables) on every retransmitted SYN/ACK, but only after the 2nd retransmitted SYN and only after tcp_retries1 RTO retransmits. With this patch: 1) txhash is changed with every SYN retransmits 2) txhash is changed with every RTO. The result is that we can start

Re: [net-next 0/5][pull request] 1GbE Intel Wired LAN Driver Updates 2016-09-22

2016-09-27 Thread Jeff Kirsher
On Thu, 2016-09-22 at 23:38 -0700, Jeff Kirsher wrote: > This series contains updates to igb, igbvf and PCI quirks. > > Wei Yongjun makes a function static to shut up sparse. > > Todd bumps the igb and igbvf version, which is long overdue. > > Jake fixes an issue where the PPS SYS_WRAP interrupt

[PATCH] mwifiex: report wakeup for wowlan

2016-09-27 Thread Rajat Jain
Enable notifying wakeup source to the PM core. This allow darkresume to correctly track wakeup source and mark mwifiex_plt as 'automatic' wakeup source. Signed-off-by: Wei-Ning Huang Signed-off-by: Rajat Jain Tested-by: Wei-Ning Huang Reviewed-by: Eric Caruso --- drivers/net/wireless/marvell/

[PATCH v2] mwifiex: report wakeup for wowlan

2016-09-27 Thread Rajat Jain
Enable notifying wakeup source to the PM core in case of a wake on wireless LAN event. Signed-off-by: Wei-Ning Huang Signed-off-by: Rajat Jain Tested-by: Wei-Ning Huang Reviewed-by: Eric Caruso --- v2: Fix the commit log drivers/net/wireless/marvell/mwifiex/sdio.c | 8 drivers/net/w

Re: [PATCH v3 net-next] tcp: Change txhash on every SYN and RTO retransmit

2016-09-27 Thread Neal Cardwell
On Tue, Sep 27, 2016 at 8:18 PM, Yuchung Cheng wrote: > On Tue, Sep 27, 2016 at 4:31 PM, Lawrence Brakmo wrote: >> @@ -213,6 +215,8 @@ static int tcp_write_timeout(struct sock *sk) >> tcp_mtu_probing(icsk, sk); >> >> dst_negative_advice(sk); >> +

Re: [PATCH nf-next v2 1/2] netfilter: Fix potential null pointer dereference

2016-09-27 Thread Feng Gao
Hi Aaraon, On Tue, Sep 27, 2016 at 9:38 PM, Aaron Conole wrote: > It's possible for nf_hook_entry_head to return NULL if two > nf_unregister_net_hook calls happen simultaneously with a single hook The critical region of nf_unregister_net_hook is protected by &nf_hook_mutex. When it would be call

Re: [net-next 5/5] PCI: disable FLR for 82579 device

2016-09-27 Thread Alexander Duyck
Since I worked with Sasha on this I will provide a bit of information from what I understand of this bug as well. On Tue, Sep 27, 2016 at 12:13 PM, Alex Williamson wrote: > On Tue, 27 Sep 2016 13:17:02 -0500 > Bjorn Helgaas wrote: > >> On Sun, Sep 25, 2016 at 10:02:43AM +0300, Neftin, Sasha wrot

Re: [PATCH v3 net-next] tcp: Change txhash on every SYN and RTO retransmit

2016-09-27 Thread Yuchung Cheng
On Tue, Sep 27, 2016 at 4:31 PM, Lawrence Brakmo wrote: > > The current code changes txhash (flowlables) on every retransmitted > SYN/ACK, but only after the 2nd retransmitted SYN and only after > tcp_retries1 RTO retransmits. > > With this patch: > 1) txhash is changed with every SYN retransmits

[PATCH v3 net-next] tcp: Change txhash on every SYN and RTO retransmit

2016-09-27 Thread Lawrence Brakmo
The current code changes txhash (flowlables) on every retransmitted SYN/ACK, but only after the 2nd retransmitted SYN and only after tcp_retries1 RTO retransmits. With this patch: 1) txhash is changed with every SYN retransmits 2) adds the option for the txhash to be changed before tcp_retries1

Re: [PATCH trival -resend 2/2] lib: clean up put_cpu_var usage

2016-09-27 Thread Tejun Heo
On Tue, Sep 27, 2016 at 08:42:42AM -0700, Shaohua Li wrote: > put_cpu_var takes the percpu data, not the data returned from > get_cpu_var. > > This doesn't change the behavior. > > Cc: Tejun Heo > Signed-off-by: Shaohua Li Acked-by: Tejun Heo Thanks. -- tejun

Re: [PATCH trival -resend 1/2] bpf: clean up put_cpu_var usage

2016-09-27 Thread Tejun Heo
On Tue, Sep 27, 2016 at 08:42:41AM -0700, Shaohua Li wrote: > put_cpu_var takes the percpu data, not the data returned from > get_cpu_var. > > This doesn't change the behavior. > > Cc: Tejun Heo > Cc: Alexei Starovoitov > Signed-off-by: Shaohua Li Acked-by: Tejun Heo Thanks. -- tejun

Re: [Intel-wired-lan] [PATCH net] i40e: avoid NULL pointer dereference and recursive errors on early PCI error

2016-09-27 Thread Guilherme G. Piccoli
On 09/27/2016 07:41 PM, Keller, Jacob E wrote: > On Tue, 2016-09-27 at 18:14 -0300, Guilherme G. Piccoli wrote: >> Although rare, it's possible to hit PCI error early on device >> probe, meaning possibly some structs are not entirely initialized, >> and some might even be completely uninitialized,

Re: [PATCH net-next] tcp: Change txhash on every SYN and RTO retransmit

2016-09-27 Thread Lawrence Brakmo
Eric, thank you for comments. V2 should be out shortly. Thanks! On 9/27/16, 9:29 AM, "netdev-ow...@vger.kernel.org on behalf of Eric Dumazet" wrote: >On Tue, 2016-09-27 at 09:06 -0700, Lawrence Brakmo wrote: >> The current code changes txhash (flowlables) on every retransmitted >> SYN/ACK, but

Re: [PATCH trival -resend 1/2] bpf: clean up put_cpu_var usage

2016-09-27 Thread Alexei Starovoitov
On Tue, Sep 27, 2016 at 08:42:41AM -0700, Shaohua Li wrote: > put_cpu_var takes the percpu data, not the data returned from > get_cpu_var. > > This doesn't change the behavior. > > Cc: Tejun Heo > Cc: Alexei Starovoitov > Signed-off-by: Shaohua Li Acked-by: Alexei Starovoitov

Re: [Intel-wired-lan] [PATCH net] i40e: avoid NULL pointer dereference and recursive errors on early PCI error

2016-09-27 Thread Keller, Jacob E
On Tue, 2016-09-27 at 18:14 -0300, Guilherme G. Piccoli wrote: > Although rare, it's possible to hit PCI error early on device > probe, meaning possibly some structs are not entirely initialized, > and some might even be completely uninitialized, leading to NULL > pointer dereference. > > The i40e

Re: [PATCH v2 net-next 4/4] net/sched: act_mirred: Implement ingress actions

2016-09-27 Thread Eric Dumazet
On Wed, 2016-09-28 at 00:42 +0300, Shmulik Ladkani wrote: > Thanks Eric. > > I assume adding a READ_ONCE(m->tcfm_eaction) at beggining of section, > and using the read value, will solve this specific inconsistency? Sure, adding a READ_ONCE() might work, if done properly ;)

[PATCH v2] mlx5: Add ndo_poll_controller() implementation

2016-09-27 Thread Calvin Owens
This implements ndo_poll_controller in net_device_ops callback for mlx5, which is necessary to use netconsole with this driver. Cc: Saeed Mahameed Signed-off-by: Calvin Owens --- Changes in v2: * Only iterate channels to avoid redundant napi_schedule() calls drivers/net/ethernet/mellano

RE: [PATCH 0/2] cxgb4 FR_NSMR_TPTE_WR support

2016-09-27 Thread Steve Wise
> > > > >> > >> From: Steve Wise > >> Date: Fri, 16 Sep 2016 07:54:55 -0700 > >> > >> > This series enables a new work request to optimize small REG_MR > >> > operations. This is intended for 4.9. If everyone agrees, I suggest > >> > Doug take both the cxgb4 and iw_cxgb4 patches through his tre

[RFC v2 1/4] skge: Change LED_OFF to LED_REG_OFF in marvel skge driver to avoid conflicts with leds namespace

2016-09-27 Thread Zach Brown
Adding led support for phy causes namespace conflicts for some phy drivers. The marvel skge driver declared an enum for representing the states of Link LED Register. The enum contained constant LED_OFF which conflicted with declartation found in linux/leds.h. LED_OFF changed to LED_REG_OFF Signed

[RFC v2 2/4] staging: rtl8712: Change _LED_STATE enum in rtl871x driver to avoid conflicts with LED namespace

2016-09-27 Thread Zach Brown
Adding led support for phy causes namespace conflicts for some phy drivers. The rtl871 driver declared an enum for representing LED states. The enum contains constant LED_OFF which conflicted with declaration found in linux/leds.h. LED_OFF changed to LED_STATE_OFF In order to avoid a possible futu

[RFC v2 4/4] phy,leds: add support for led triggers on phy link state change

2016-09-27 Thread Zach Brown
From: Josh Cartwright Create an option CONFIG_LED_TRIGGER_PHY (default n), which will create a set of led triggers for each instantiated PHY device. There is one LED trigger per link-speed, per-phy. This allows for a user to configure their system to allow a set of LEDs to represent link state

[RFC v2 0/4] Add support for led triggers on phy link state change

2016-09-27 Thread Zach Brown
Fix two net drivers that declared enum constants that conflict with enum constants in linux/leds.h Create function that encapsulates actions taken during the adjust phy link step of phy state changes. Add support for led triggers on phy link state changes by adding a config option. When set the c

[RFC v2 3/4] phy: Encapsulate actions performed during link state changes into function phy_adjust_link

2016-09-27 Thread Zach Brown
During phy state machine state transitions some set of actions should occur whenever the link state changes. These actions should be encapsulated into a single function. This patch adds the phy_adjust_link function, which is called whenever phydev->adjust_link would have been called before. Action

Re: [PATCH net] tg3: Avoid NULL pointer dereference in tg3_io_error_detected()

2016-09-27 Thread Michael Chan
On Tue, Sep 27, 2016 at 2:27 PM, Guilherme G. Piccoli wrote: > On 09/27/2016 05:58 PM, Michael Chan wrote: >> >> On Tue, Sep 27, 2016 at 1:05 PM, Guilherme G. Piccoli >> wrote: >>> >>> From: Milton Miller >>> >>> While the driver is probing the adapter, an error may occur before the >>> netdev s

Re: [PATCH v2 net-next 4/4] net/sched: act_mirred: Implement ingress actions

2016-09-27 Thread Shmulik Ladkani
Hi, On Tue, 27 Sep 2016 14:27:13 -0700 Eric Dumazet wrote: > On Tue, 2016-09-27 at 23:59 +0300, Shmulik Ladkani wrote: > > Up until now, 'action mirred' supported only egress actions (either > > TCA_EGRESS_REDIR or TCA_EGRESS_MIRROR). > > > > This patch implements the corresponding ingress actio

Re: [PATCH net] tg3: Avoid NULL pointer dereference in tg3_io_error_detected()

2016-09-27 Thread Guilherme G. Piccoli
On 09/27/2016 05:58 PM, Michael Chan wrote: On Tue, Sep 27, 2016 at 1:05 PM, Guilherme G. Piccoli wrote: From: Milton Miller While the driver is probing the adapter, an error may occur before the netdev structure is allocated and attached to pci_dev. In this case, not only netdev isn't availa

Re: [PATCH v2 net-next 4/4] net/sched: act_mirred: Implement ingress actions

2016-09-27 Thread Eric Dumazet
On Tue, 2016-09-27 at 23:59 +0300, Shmulik Ladkani wrote: > Up until now, 'action mirred' supported only egress actions (either > TCA_EGRESS_REDIR or TCA_EGRESS_MIRROR). > > This patch implements the corresponding ingress actions > TCA_INGRESS_REDIR and TCA_INGRESS_MIRROR. > - if (m-

[PATCH v2 net-next] tcp: Change txhash on every SYN and RTO retransmit

2016-09-27 Thread Lawrence Brakmo
The current code changes txhash (flowlables) on every retransmitted SYN/ACK, but only after the 2nd retransmitted SYN and only after tcp_retries1 RTO retransmits. With this patch: 1) txhash is changed with every SYN retransmits 2) adds the option for the txhash to be changed before tcp_retries1

[PATCH net] i40e: avoid NULL pointer dereference and recursive errors on early PCI error

2016-09-27 Thread Guilherme G. Piccoli
Although rare, it's possible to hit PCI error early on device probe, meaning possibly some structs are not entirely initialized, and some might even be completely uninitialized, leading to NULL pointer dereference. The i40e driver currently presents a "bad" behavior if device hits such early PCI e

Re: [v3,net-next] net: phy: Add Edge-rate driver for Microsemi PHYs.

2016-09-27 Thread Andrew Lunn
I just realised the possibly correct binding was starring me in the face. --| | 3.3V 2.5V1.8V1.5V | |-| |-2%-3%

[PATCH v2 net-next 1/4] net/sched: act_mirred: Rename tcfm_ok_push to tcfm_mac_header_xmit and make it a bool

2016-09-27 Thread Shmulik Ladkani
'tcfm_ok_push' specifies whether a mac_len sized push is needed upon egress to the target device (if action is performed at ingress). Rename it to 'tcfm_mac_header_xmit' as this is actually an attribute of the target device (and use a bool instead of int). This allows to decouple the attribute fr

[PATCH v2 net-next 4/4] net/sched: act_mirred: Implement ingress actions

2016-09-27 Thread Shmulik Ladkani
Up until now, 'action mirred' supported only egress actions (either TCA_EGRESS_REDIR or TCA_EGRESS_MIRROR). This patch implements the corresponding ingress actions TCA_INGRESS_REDIR and TCA_INGRESS_MIRROR. This allows attaching filters whose target is to hand matching skbs into the rx processing

[PATCH v2 net-next 3/4] net/sched: tc_mirred: Rename public predicates 'is_tcf_mirred_redirect' and 'is_tcf_mirred_mirror'

2016-09-27 Thread Shmulik Ladkani
These accessors are used in various drivers that support tc offloading, to detect properties of a given 'tc_action'. 'is_tcf_mirred_redirect' tests that the action is TCA_EGRESS_REDIR. 'is_tcf_mirred_mirror' tests that the action is TCA_EGRESS_MIRROR. As a prep towards supporting INGRESS redir/mi

[PATCH v2 net-next 2/4] net/sched: act_mirred: Refactor detection whether dev needs xmit at mac header

2016-09-27 Thread Shmulik Ladkani
Move detection logic that tests whether device expects skb data to point at mac_header upon xmit into a function. Signed-off-by: Shmulik Ladkani --- net/sched/act_mirred.c | 28 +++- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/net/sched/act_mirred.c b/

[PATCH v2 net-next 0/4] act_mirred: Ingress actions support

2016-09-27 Thread Shmulik Ladkani
This patch series implements action mirred 'ingress' actions TCA_INGRESS_REDIR and TCA_INGRESS_MIRROR. This allows attaching filters whose target is to hand matching skbs into the rx processing of a specified device. v2: in 1/4, declare tcfm_mac_header_xmit as bool instead of int Shmulik Ladka

Re: [PATCH net] tg3: Avoid NULL pointer dereference in tg3_io_error_detected()

2016-09-27 Thread Michael Chan
On Tue, Sep 27, 2016 at 1:05 PM, Guilherme G. Piccoli wrote: > From: Milton Miller > > While the driver is probing the adapter, an error may occur before the > netdev structure is allocated and attached to pci_dev. In this case, > not only netdev isn't available, but the tg3 private structure is

[PATCH net] tg3: Avoid NULL pointer dereference in tg3_io_error_detected()

2016-09-27 Thread Guilherme G. Piccoli
From: Milton Miller While the driver is probing the adapter, an error may occur before the netdev structure is allocated and attached to pci_dev. In this case, not only netdev isn't available, but the tg3 private structure is also not available as it is just math from the NULL pointer, so derefer

Re: [PATCH net] net: skbuff: Fix incorrect skb->mac_len adjustment in skb_vlan_push()

2016-09-27 Thread pravin shelar
On Tue, Sep 27, 2016 at 10:31 AM, Shmulik Ladkani wrote: > In case 'skb_vlan_push' is called on an skb with a hw-accel vlan tag > already present, the existing hw-accel tag is inserted into payload, and > the new given tag is placed as new hw-accel tag. > > After the insertion: > - 'mac_header' i

Re: [PATCH net v2] L2TP:Adjust intf MTU,factor underlay L3,overlay L2

2016-09-27 Thread R. Parameswaran
Hi David, Thanks for the reply, please see inline: On Tue, 27 Sep 2016, David Miller wrote: > From: "R. Parameswaran" > Date: Thu, 22 Sep 2016 13:52:43 -0700 (PDT) > > > From ed585bdd6d3d2b3dec58d414f514cd764d89159d Mon Sep 17 00:00:00 2001 > > From: "R. Parameswaran" > > Date: Thu, 22 Sep 2

Re: [net-next 5/5] PCI: disable FLR for 82579 device

2016-09-27 Thread Alex Williamson
On Tue, 27 Sep 2016 13:17:02 -0500 Bjorn Helgaas wrote: > On Sun, Sep 25, 2016 at 10:02:43AM +0300, Neftin, Sasha wrote: > > On 9/24/2016 12:05 AM, Jeff Kirsher wrote: > > >On Fri, 2016-09-23 at 09:01 -0500, Bjorn Helgaas wrote: > > >>On Thu, Sep 22, 2016 at 11:39:01PM -0700, Jeff Kirsher wro

Re: [PATCH v5 13/16] IB/pvrdma: Add the main driver module for PVRDMA

2016-09-27 Thread Adit Ranadive
On Tue, Sep 27, 2016 at 09:21:27AM +, David Laight wrote: > From: Adit Ranadive > > Sent: 26 September 2016 19:15 > > On Mon, Sep 26, 2016 at 00:27:40AM -0700, Yuval Shaia wrote: > > > On Sat, Sep 24, 2016 at 04:21:37PM -0700, Adit Ranadive wrote: > > > > + > > > > + /* Currently, the dri

Re: [PATCH net-next v2 3/3] udp: use it's own memory accounting schema

2016-09-27 Thread Eric Dumazet
On Tue, 2016-09-27 at 18:58 +0200, Paolo Abeni wrote: > > Since the new memory accounting model does not require socket > locking, remove the lock on enqueue and free and avoid using the > backlog on enqueue. ... > __UDP_INC_STATS(sock_net(sk), UDP_MIB_CSUMERRORS, is_udplite); > @@ -234

[PATCH RFC net-next] bnx2x: avoid printing unnecessary messages during register dump

2016-09-27 Thread Guilherme G. Piccoli
The bnx2x driver prints multiple error messages during register dump, with "ethtool -d" for example. The driver even warn that many messages might be seen during the register dump, but they are harmless. A typical kernel log after register dump looks like this: [9.375] bnx2x: [bnx2x_get_regs:987

Re: [PATCH net-next 1/4] net/sched: act_mirred: Rename tcfm_ok_push to tcfm_mac_header_xmit

2016-09-27 Thread Shmulik Ladkani
Hi, On Tue, 27 Sep 2016 12:30:20 +0200 Daniel Borkmann wrote: > On 09/22/2016 03:21 PM, Shmulik Ladkani wrote: > > From: Shmulik Ladkani > > > > 'tcfm_ok_push' specifies whether a mac_len sized push is needed upon > > egress to the target device (if action is performed at ingress). > > > > Renam

Re: [net-next 5/5] PCI: disable FLR for 82579 device

2016-09-27 Thread Bjorn Helgaas
On Sun, Sep 25, 2016 at 10:02:43AM +0300, Neftin, Sasha wrote: > On 9/24/2016 12:05 AM, Jeff Kirsher wrote: > >On Fri, 2016-09-23 at 09:01 -0500, Bjorn Helgaas wrote: > >>On Thu, Sep 22, 2016 at 11:39:01PM -0700, Jeff Kirsher wrote: > >>>From: Sasha Neftin > >>> > >>>82579 has a problem reattachin

Re: [PATCH resend] sh_eth: add R8A7743/5 support

2016-09-27 Thread Sergei Shtylyov
On 09/27/2016 10:35 AM, Geert Uytterhoeven wrote: Add support for the first two members of the Renesas RZ/G family, RZ/G1M/E (also known as R8A7743/5). The Ether core is the same as in the R-Car gen2 SoCs, so will share the code/data with them... Signed-off-by: Sergei Shtylyov --- net-next

Re: [RFC PATCH net-next 2/2] sfc: report 4-tuple UDP hashing to ethtool, if it's enabled

2016-09-27 Thread Mintz, Yuval
> info->data = 0; > switch (info->flow_type) { > +   case UDP_V4_FLOW: > +   if (efx->rx_hash_udp_4tuple) > +   /* fall through */ > +   /* else fall further! */ > case

[PATCH net] net: skbuff: Fix incorrect skb->mac_len adjustment in skb_vlan_push()

2016-09-27 Thread Shmulik Ladkani
In case 'skb_vlan_push' is called on an skb with a hw-accel vlan tag already present, the existing hw-accel tag is inserted into payload, and the new given tag is placed as new hw-accel tag. After the insertion: - 'mac_header' is adjusted to point to the new start of the vlan_ethhdr - 'data' is

RE: [PATCH net-next 0/2] net: ethernet: mediatek: some bug fixes for PDAM and HW LRO

2016-09-27 Thread Nelson Chang
Got it. I'll notice that for later patches. Thanks David. -Original Message- From: David Miller [mailto:da...@davemloft.net] Sent: Tuesday, September 27, 2016 9:42 PM To: Nelson Chang (張家祥) Cc: j...@phrozen.org; n...@openwrt.org; netdev@vger.kernel.org; linux-media...@lists.infradead.org;

[PATCH net-next v2 2/3] udp: implement memory accounting helpers

2016-09-27 Thread Paolo Abeni
Avoid usage of common memory accounting functions, since the logic is pretty much different. To account for forward allocation, a couple of new atomic_t members are added to udp_sock: 'mem_alloced' and 'can_reclaim'. The current forward allocation is estimated as 'mem_alloced' minus 'sk_rmem_allo

Re:

2016-09-27 Thread Rajat Jain
Please ignore, not sure why this landed without a subject. On Tue, Sep 27, 2016 at 9:50 AM, Rajat Jain wrote: > From: Wei-Ning Huang > > Date: Thu, 17 Mar 2016 11:43:16 +0800 > Subject: [PATCH] mwifiex: report wakeup for wowlan > > Enable notifying wakeup source to the PM core. This allow darkre

[PATCH net-next v2 3/3] udp: use it's own memory accounting schema

2016-09-27 Thread Paolo Abeni
Completely avoid default sock memory accounting and replace it with udp-specific accounting. The udp code now tracks the memory pressure status, to optimize memory reclaiming. Since the new memory accounting model does not require socket locking, remove the lock on enqueue and free and avoid usin

[PATCH net-next v2 1/3] net/socket: factor out helpers for memory and queue manipulation

2016-09-27 Thread Paolo Abeni
Basic sock operations that udp code can use with its own memory accounting schema. No functional change is introduced in the existing APIs. v1 -> v2: - avoid export sock_rmem_free Signed-off-by: Paolo Abeni --- include/net/sock.h | 5 +++ net/core/datagram.c | 36 net/c

[PATCH net-next v2 0/3] udp: refactor memory accounting

2016-09-27 Thread Paolo Abeni
This patch series refactor the udp memory accounting, replacing the generic implementation with a custom one, in order to remove the needs for locking the socket on the enqueue and dequeue operations. The socket backlog usage is dropped, as well. The first patch factor out core pieces of some queu

[no subject]

2016-09-27 Thread Rajat Jain
From: Wei-Ning Huang Date: Thu, 17 Mar 2016 11:43:16 +0800 Subject: [PATCH] mwifiex: report wakeup for wowlan Enable notifying wakeup source to the PM core. This allow darkresume to correctly track wakeup source and mark mwifiex_plt as 'automatic' wakeup source. Signed-off-by: Wei-Ning Huang S

[PATCH] mwifiex: report wakeup for wowlan

2016-09-27 Thread Rajat Jain
Enable notifying wakeup source to the PM core. This allow darkresume to correctly track wakeup source and mark mwifiex_plt as 'automatic' wakeup source. Signed-off-by: Wei-Ning Huang Signed-off-by: Rajat Jain Tested-by: Wei-Ning Huang Reviewed-by: Eric Caruso --- drivers/net/wireless/marvell/

Re: [PATCH v2] net: hns: mark symbols static where possible

2016-09-27 Thread Mark Brown
On Tue, Sep 27, 2016 at 07:50:14AM -0400, David Miller wrote: > This still doesn't apply to the net-next tree. > If you aren't actually building your patch against the net-next > tree, don't bother submitting these patches any more. Baoyou, Dave is referring to his git tree at: git://git.ker

[PATCH V2 net-next 15/15] smc: proc-fs interface for smc connections

2016-09-27 Thread Ursula Braun
Maintain a list of SMC sockets and display important SMC socket information in /proc/net/smc. Signed-off-by: Ursula Braun --- net/smc/Makefile | 2 +- net/smc/af_smc.c | 14 +++ net/smc/smc.h | 1 + net/smc/smc_proc.c | 247 + net

[PATCH V2 net-next 10/15] smc: link layer control (LLC)

2016-09-27 Thread Ursula Braun
send and receive LLC messages CONFIRM_LINK (via IB message send and CQE) Signed-off-by: Ursula Braun --- net/smc/Makefile | 2 +- net/smc/af_smc.c | 94 ++- net/smc/smc_clc.h | 2 + net/smc/smc_core.c | 8 +++ net/smc/smc_core.h | 4 ++ net/smc/smc_llc.c

Re: [PATCH net-next 2/3] net: mpls: Fixups for GSO

2016-09-27 Thread Jiri Benc
On Tue, 27 Sep 2016 10:38:41 -0600, David Ahern wrote: > On 9/27/16 1:45 AM, Jiri Benc wrote: > > On Mon, 26 Sep 2016 20:04:06 -0600, David Ahern wrote: > >> you know this code better than me, but key_extract pulls the eth > >> header and then sets network header. If MPLS labels are present then >

[PATCH V2 net-next 09/15] smc: initialize IB transport incl. PD, MR, QP, CQ, event, WR

2016-09-27 Thread Ursula Braun
Prepare the link for RDMA transport: Create a queue pair (QP) and move it into the state Ready-To-Receive (RTR). Signed-off-by: Ursula Braun --- net/smc/af_smc.c | 34 ++-- net/smc/smc.h | 1 + net/smc/smc_clc.c | 10 ++- net/smc/smc_core.c | 80 ++ net/smc/smc_c

[PATCH V2 net-next 14/15] smc: socket closing and linkgroup cleanup

2016-09-27 Thread Ursula Braun
smc_shutdown() and smc_release() handling delayed linkgroup cleanup for linkgroups without connections Signed-off-by: Ursula Braun --- net/smc/Makefile| 2 +- net/smc/af_smc.c| 105 +++-- net/smc/smc.h | 20 ++- net/smc/smc_cdc.c | 33 ++-- net/smc/smc_cdc.h | 1 +

[PATCH V2 net-next 12/15] smc: send data (through RDMA)

2016-09-27 Thread Ursula Braun
copy data to kernel send buffer, and trigger RDMA write Signed-off-by: Ursula Braun --- net/smc/Makefile | 2 +- net/smc/af_smc.c | 13 +- net/smc/smc.h | 1 + net/smc/smc_cdc.c | 7 +- net/smc/smc_tx.c | 437 ++ net/smc/smc_tx.h

[PATCH V2 net-next 13/15] smc: receive data from RMBE

2016-09-27 Thread Ursula Braun
move RMBE data into user space buffer and update managing cursors Signed-off-by: Ursula Braun --- net/smc/Makefile | 2 +- net/smc/af_smc.c | 7 +- net/smc/smc.h | 4 + net/smc/smc_cdc.c | 6 +- net/smc/smc_core.c | 10 +++ net/smc/smc_rx.c | 216

[PATCH V2 net-next 08/15] smc: work request (WR) base for use by LLC and CDC

2016-09-27 Thread Ursula Braun
The base containers for RDMA transport are work requests and completion queue entries processed through Infiniband verbs: * allocate and initialize these areas * map these areas to DMA * implement the basic communication consisting of work request posting and receival of completion queue events

[PATCH V2 net-next 06/15] smc: connection and link group creation

2016-09-27 Thread Ursula Braun
* create smc_connection for SMC-sockets * determine suitable link group for a connection * create a new link group if necessary Signed-off-by: Ursula Braun --- net/smc/Makefile | 2 +- net/smc/af_smc.c | 103 +-- net/smc/smc.h | 35 ++ net/smc/smc_clc.c | 31 -

[PATCH V2 net-next 07/15] smc: remote memory buffers (RMBs)

2016-09-27 Thread Ursula Braun
* allocate data RMB memory for sending and receiving * size depends on the maximum socket send and receive buffers * allocated RMBs are kept during life time of the owning link group * map the allocated RMBs to DMA Signed-off-by: Ursula Braun --- net/smc/af_smc.c | 29 ++- net/smc/smc.h

[PATCH V2 net-next 01/15] net: introduce keepalive function in struct proto

2016-09-27 Thread Ursula Braun
Direct call of tcp_set_keepalive() function from protocol-agnostic sock_setsockopt() function in net/core/sock.c violates network layering. And newly introduced protocol (SMC-R) will need its own keepalive function. Therefore, add "keepalive" function pointer to "struct proto", and call it from soc

[PATCH V2 net-next 05/15] smc: CLC handshake (incl. preparation steps)

2016-09-27 Thread Ursula Braun
* CLC (Connection Layer Control) handshake Signed-off-by: Ursula Braun --- net/smc/Makefile | 2 +- net/smc/af_smc.c | 467 ++ net/smc/smc.h | 24 ++- net/smc/smc_clc.c | 251 + net/smc/smc_clc.h | 111 +

[PATCH V2 net-next 11/15] smc: connection data control (CDC)

2016-09-27 Thread Ursula Braun
send and receive CDC messages (via IB message send and CQE) Signed-off-by: Ursula Braun --- net/smc/Makefile | 1 + net/smc/af_smc.c | 8 ++ net/smc/smc.h | 97 ++ net/smc/smc_cdc.c | 288 + net/smc/smc_cdc.h | 2

[PATCH V2 net-next 00/15] net/smc: Shared Memory Communications - RDMA

2016-09-27 Thread Ursula Braun
Dave, here is now V2 of the SMC-R patches having processed your August feedback plus reported coccinelle findings. The most important change is the removal of xchg() calls, I had wrongly used for atomic updates of 64-bit values. I still see a need for atomic reads and updates of 64-bit SMC-cursor

[PATCH V2 net-next 02/15] smc: establish new socket family

2016-09-27 Thread Ursula Braun
* enable smc module loading and unloading * register new socket family * basic smc socket creation and deletion * use backing TCP socket to run CLC (Connection Layer Control) handshake of SMC protocol * Setup for infiniband traffic is implemented in follow-on patches. For now fallback to

  1   2   3   >