Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7)

2016-10-12 Thread Andy Lutomirski
On Wed, Oct 12, 2016 at 7:22 AM, Johannes Berg wrote: > >> > Can you elaborate on how exactly it kills your system? >> >> the last time I saw it it was a NULL deref at >> ieee80211_aes_ccm_decrypt. > > Hm. I was expecting something within the crypto code would cause the

Re: [PATCH 1/1] vxlan: insert ipv6 macro

2016-10-12 Thread zhuyj
Soon I will analyze the previous patch. I will let you know. Thanks a lot. On Thu, Oct 13, 2016 at 1:28 PM, zhuyj wrote: > Hi, Jiri > > The dumped source code is in the attachment. Please check it. I think > this file can explain all. > > If anything, please just let me

[PATCH 06/10] mm: replace get_user_pages() write/force parameters with gup_flags

2016-10-12 Thread Lorenzo Stoakes
This patch removes the write and force parameters from get_user_pages() and replaces them with a gup_flags parameter to make the use of FOLL_FORCE explicit in callers as use of this flag can result in surprising behaviour (and hence bugs) within the mm subsystem. Signed-off-by: Lorenzo Stoakes

[PATCH 10/10] mm: replace access_process_vm() write parameter with gup_flags

2016-10-12 Thread Lorenzo Stoakes
This patch removes the write parameter from access_process_vm() and replaces it with a gup_flags parameter as use of this function previously _implied_ FOLL_FORCE, whereas after this patch callers explicitly pass this flag. We make this explicit as use of FOLL_FORCE can result in surprising

[PATCH 05/10] mm: replace get_vaddr_frames() write/force parameters with gup_flags

2016-10-12 Thread Lorenzo Stoakes
This patch removes the write and force parameters from get_vaddr_frames() and replaces them with a gup_flags parameter to make the use of FOLL_FORCE explicit in callers as use of this flag can result in surprising behaviour (and hence bugs) within the mm subsystem. Signed-off-by: Lorenzo Stoakes

[PATCH 08/10] mm: replace __access_remote_vm() write parameter with gup_flags

2016-10-12 Thread Lorenzo Stoakes
This patch removes the write parameter from __access_remote_vm() and replaces it with a gup_flags parameter as use of this function previously _implied_ FOLL_FORCE, whereas after this patch callers explicitly pass this flag. We make this explicit as use of FOLL_FORCE can result in surprising

[PATCH 09/10] mm: replace access_remote_vm() write parameter with gup_flags

2016-10-12 Thread Lorenzo Stoakes
This patch removes the write parameter from access_remote_vm() and replaces it with a gup_flags parameter as use of this function previously _implied_ FOLL_FORCE, whereas after this patch callers explicitly pass this flag. We make this explicit as use of FOLL_FORCE can result in surprising

[PATCH 07/10] mm: replace get_user_pages_remote() write/force parameters with gup_flags

2016-10-12 Thread Lorenzo Stoakes
This patch removes the write and force parameters from get_user_pages_remote() and replaces them with a gup_flags parameter to make the use of FOLL_FORCE explicit in callers as use of this flag can result in surprising behaviour (and hence bugs) within the mm subsystem. Signed-off-by: Lorenzo

Re: [PATCH V2 net-next] net/mlx5: Add MLX5_ARRAY_SET64 to fix BUILD_BUG_ON

2016-10-12 Thread David Miller
I've been travelling and will get to this patch when I get to it.

Re: [PATCH v6] net: ip, diag -- Add diag interface for raw sockets

2016-10-12 Thread David Miller
From: Cyrill Gorcunov Date: Wed, 12 Oct 2016 09:53:29 +0300 > I can't rename the field, neither a can use union. Remind me again what is wrong with using an anonymous union?

RE: [PATCH] xen-netback: fix type mismatch warning

2016-10-12 Thread Paul Durrant
> -Original Message- > From: Arnd Bergmann [mailto:a...@arndb.de] > Sent: 12 October 2016 10:54 > To: Wei Liu ; Paul Durrant > Cc: Arnd Bergmann ; David S. Miller > ; David Vrabel ;

[PATCH 00/10] mm: adjust get_user_pages* functions to explicitly pass FOLL_* flags

2016-10-12 Thread Lorenzo Stoakes
This patch series adjusts functions in the get_user_pages* family such that desired FOLL_* flags are passed as an argument rather than implied by flags. The purpose of this change is to make the use of FOLL_FORCE explicit so it is easier to grep for and clearer to callers that this flag is being

[PATCH 01/10] mm: remove write/force parameters from __get_user_pages_locked()

2016-10-12 Thread Lorenzo Stoakes
This patch removes the write and force parameters from __get_user_pages_locked() to make the use of FOLL_FORCE explicit in callers as use of this flag can result in surprising behaviour (and hence bugs) within the mm subsystem. Signed-off-by: Lorenzo Stoakes --- mm/gup.c |

[PATCH 03/10] mm: replace get_user_pages_unlocked() write/force parameters with gup_flags

2016-10-12 Thread Lorenzo Stoakes
This patch removes the write and force parameters from get_user_pages_unlocked() and replaces them with a gup_flags parameter to make the use of FOLL_FORCE explicit in callers as use of this flag can result in surprising behaviour (and hence bugs) within the mm subsystem. Signed-off-by: Lorenzo

[PATCH 02/10] mm: remove write/force parameters from __get_user_pages_unlocked()

2016-10-12 Thread Lorenzo Stoakes
This patch removes the write and force parameters from __get_user_pages_unlocked() to make the use of FOLL_FORCE explicit in callers as use of this flag can result in surprising behaviour (and hence bugs) within the mm subsystem. Signed-off-by: Lorenzo Stoakes ---

[PATCH net-next 4/5] udp: UDP tunnel flow dissection infrastructure

2016-10-12 Thread Tom Herbert
Add infrastructure to allow UDP tunnels to setup flow dissection. Signed-off-by: Tom Herbert --- include/net/udp_tunnel.h | 5 + net/ipv4/udp_tunnel.c| 5 + 2 files changed, 10 insertions(+) diff --git a/include/net/udp_tunnel.h b/include/net/udp_tunnel.h

[PATCH net-next 3/5] udp: Add UDP flow dissection functions to IPv4 and IPv6

2016-10-12 Thread Tom Herbert
Add per protocol offload callbacks for flow_dissect to UDP for IPv4 and IPv6. The callback functions extract the port number information and with the packet addresses (given in an argument with type flow_dissector_key_addrs) it performs a lookup on the UDP socket. If a socket is found and

[PATCH net-next 0/5] udp: Flow dissection for tunnels

2016-10-12 Thread Tom Herbert
Now that we have a means to perform a UDP socket lookup without taking a reference, it is feasible to have flow dissector crack open UDP encapsulated packets. Generally, we would expect that the UDP source port or the flow label in IPv6 would contain enough entropy about the encapsulated flow.

[PATCH net-next 1/5] udp: Add socket lookup functions with noref

2016-10-12 Thread Tom Herbert
Create udp4_lib_lookup_noref and udp6_lib_lookup_noref. These perfrom a socket lookup on addresses and ports without taking a reference. Signed-off-by: Tom Herbert --- include/net/udp.h | 8 net/ipv4/udp.c| 8 net/ipv6/udp.c| 10 ++ 3

[PATCH net-next 5/5] fou: Support flow dissection

2016-10-12 Thread Tom Herbert
This patch performs flow dissection for GUE and FOU. This is an optional feature on the receiver and is set by FOU_ATTR_DEEP_HASH netlink configuration. When enable the UDP socket flow_dissect function is set to fou_flow_dissect or gue_flow_dissect as appropriate. These functions return

[PATCH net-next 2/5] udp: UDP flow dissector

2016-10-12 Thread Tom Herbert
Add infrastructure for performing per protocol flow dissection and support flow dissection in UDP payloads (e.g. flow dissection on a UDP encapsulated tunnel. The per protocol flow dissector is called by flow_dissect function in the offload_callbacks of a protocol. The arguments of this function

Re: [PATCH v3] iproute2: macvlan: add "source" mode

2016-10-12 Thread Stephen Hemminger
On Sun, 25 Sep 2016 21:08:55 +0200 Michael Braun wrote: > Adjusting iproute2 utility to support new macvlan link type mode called > "source". > > Example of commands that can be applied: > ip link add link eth0 name macvlan0 type macvlan mode source > ip link set

Re: [PATCH iproute2 1/1] tc filters: add support to get individual filters by handle

2016-10-12 Thread Stephen Hemminger
On Mon, 10 Oct 2016 12:45:14 -0400 Jamal Hadi Salim wrote: > From: Jamal Hadi Salim > > sudo $TC filter add dev $ETH parent : prio 2 protocol ip \ > u32 match u32 0 0 flowid 1:1 \ > action ok > sudo $TC filter add dev $ETH parent : prio 1 protocol

Re: [PATCH v2 iproute2 0/9] Cleanup backlog

2016-10-12 Thread Stephen Hemminger
On Tue, 11 Oct 2016 07:00:39 -0400 Jamal Hadi Salim wrote: > From: Jamal Hadi Salim > > > Variety of cleanup and new functionality I had sitting around on my > private tree > > Craig Dillabaugh (1): > action gact: list pipe as a valid action > > Jamal

Re: [PATCH net-next] net: phy: Trigger state machine on state change and not polling.

2016-10-12 Thread Kyle Roeschley
On Wed, Oct 12, 2016 at 10:14:53PM +0200, Andrew Lunn wrote: > The phy_start() is used to indicate the PHY is now ready to do its > work. The state is changed, normally to PHY_UP which means that both > the MAC and the PHY are ready. > > If the phy driver is using polling, when the next poll

[PATCH net-next 06/11] ixgbe: Flip to the new dev walk API

2016-10-12 Thread David Ahern
Convert ixgbe users of the old macros to new dev walk API. This is just a move to the new API; no functional change is intended. Signed-off-by: David Ahern --- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 132 -- 1 file changed, 82

[PATCH net-next 11/11] net: dev: Improve debug statements for adjacency tracking

2016-10-12 Thread David Ahern
Adjacency code only has debugs for the insert case. Add debugs for the remove path and make both consistently worded to make it easier to follow the insert and removal with reference counts. In addition, change the BUG to a WARN_ON. A missing adjacency at removal time is not cause for a panic.

[PATCH net-next 09/11] net: Remove all_adj_list and its references

2016-10-12 Thread David Ahern
Only direct adjacencies are maintained. All upper or lower devices can be learned via the new walk API which recursively walks the adj_list for upper devices or lower devices. Signed-off-by: David Ahern --- include/linux/netdevice.h | 25 - net/core/dev.c

[PATCH net-next 07/11] mlxsw: Flip to the new dev walk API

2016-10-12 Thread David Ahern
Convert mlxsw users to new dev walk API. This is just a move to the new API; no functional change is intended. Signed-off-by: David Ahern --- drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 37 -- 1 file changed, 23 insertions(+), 14

Re: [RFC] net: phy: smsc: Disable auto-negotiation on startup

2016-10-12 Thread Andrew Lunn
On Wed, Oct 12, 2016 at 10:05:33AM -0500, Kyle Roeschley wrote: > On Wed, Oct 12, 2016 at 02:13:06AM -0700, Florian Fainelli wrote: > > On 10/10/2016 10:41 AM, Kyle Roeschley wrote: > > > Because the SMSC PHY completes auto-negotiation before the driver is > > > ready to handle interrupts, the PHY

[PATCH net-next 08/11] rocker: Flip to the new dev walk API

2016-10-12 Thread David Ahern
Convert rocker to the new dev walk API. This is just a code conversion; no functional change is intended. Signed-off-by: David Ahern --- drivers/net/ethernet/rocker/rocker_main.c | 31 --- 1 file changed, 24 insertions(+), 7 deletions(-)

[PATCH net-next 10/11] net: Add warning if any lower device is still in adjacency list

2016-10-12 Thread David Ahern
Lower list should be empty just like upper. Signed-off-by: David Ahern --- net/core/dev.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/net/core/dev.c b/net/core/dev.c index 0f9b0985a84c..52e70a3d61a4 100644 --- a/net/core/dev.c +++

[PATCH net-next 05/11] IB/ipoib: Flip to new dev walk API

2016-10-12 Thread David Ahern
Convert ipoib_get_net_dev_match_addr to the new upper device walk API. This is just a move to the new API; no functional change is intended. Signed-off-by: David Ahern --- drivers/infiniband/ulp/ipoib/ipoib_main.c | 37 +-- 1 file changed,

[PATCH net-next 04/11] IB/core: Flip to the new dev walk API

2016-10-12 Thread David Ahern
Convert rdma_is_upper_dev_rcu, handle_netdev_upper and ipoib_get_net_dev_match_addr to the new upper device walk API. This is just a move to the new API; no functional change is intended. Signed-off-by: David Ahern --- drivers/infiniband/core/core_priv.h | 9

[PATCH net-next 01/11] net: Remove refnr arg when inserting link adjacencies

2016-10-12 Thread David Ahern
Commit 93409033ae65 ("net: Add netdev all_adj_list refcnt propagation to fix panic") propagated the refnr to insert and remove functions tracking the netdev adjacency graph. However, for the insert path the refnr can only be 1. Accordingly, remove the refnr argument to make that clear. ie., the

[PATCH net-next 00/11] net: Fix netdev adjacency tracking

2016-10-12 Thread David Ahern
The netdev adjacency tracking is failing to create proper dependencies for some topologies. For example this topology ++ | myvrf | ++ || | +-+ | | macvlan | | +-+ ||

[PATCH net-next 02/11] net: Introduce new api for walking upper and lower devices

2016-10-12 Thread David Ahern
This patch introduces netdev_walk_all_upper_dev_rcu, netdev_walk_all_lower_dev and netdev_walk_all_lower_dev_rcu. These functions recursively walk the adj_list of devices to determine all upper and lower devices. The functions take a callback function that is invoked for each device in the list.

[PATCH net-next 03/11] net: bonding: Flip to the new dev walk API

2016-10-12 Thread David Ahern
Convert alb_send_learning_packets and bond_has_this_ip to use the new netdev_walk_all_upper_dev_rcu API. In both cases this is just a move to the new API; no functional change is intended. Signed-off-by: David Ahern --- drivers/net/bonding/bond_alb.c | 82

[PATCH] net: ipv4: Do not drop to make_route if oif is l3mdev

2016-10-12 Thread David Ahern
Commit e0d56fdd7342 was a bit aggressive removing l3mdev calls in the IPv4 stack. If the fib_lookup fails we do not want to drop to make_route if the oif is an l3mdev device. Also reverts 19664c6a0009 ("net: l3mdev: Remove netif_index_is_l3_master") which removed netif_index_is_l3_master. Fixes:

[PATCH net-next] net: phy: Trigger state machine on state change and not polling.

2016-10-12 Thread Andrew Lunn
The phy_start() is used to indicate the PHY is now ready to do its work. The state is changed, normally to PHY_UP which means that both the MAC and the PHY are ready. If the phy driver is using polling, when the next poll happens, the state machine notices the PHY is now in PHY_UP, and kicks off

[PATCH] net: wan: slic_ds26522: Allow driver to built if COMPILE_TEST is enabled

2016-10-12 Thread Javier Martinez Canillas
The driver only has runtime but no build time dependency with FSL_SOC || ARCH_MXC || ARCH_LAYERSCAPE. So it can be built for testing purposes if the COMPILE_TEST option is enabled. This is useful to have more build coverage and make sure that the driver is not affected by changes that could

[PATCH 1/2] net: wan: slic_ds26522: add SPI device ID table to fix module autoload

2016-10-12 Thread Javier Martinez Canillas
If the driver is built as a module, module alias information isn't filled so the module won't be autoloaded. Add a SPI device ID table and use the MODULE_DEVICE_TABLE() macro so the information is exported in the module. Before this patch: $ modinfo drivers/net/wan/slic_ds26522.ko | grep alias $

[PATCH 2/2] net: wan: slic_ds26522: Export OF module alias information

2016-10-12 Thread Javier Martinez Canillas
When the device is registered via OF, the OF table is used to match the driver instead of the SPI device ID table, but the entries in the later are used as aliasses to load the module if the driver was not built-in. This is because the SPI core always reports an SPI module alias instead of an OF

Re: igb driver can cause cache invalidation of non-owned memory?

2016-10-12 Thread Alexander Duyck
On Wed, Oct 12, 2016 at 11:12 AM, Nikita Yushchenko wrote: >> It would make more sense to update the DMA API for >> __dma_page_cpu_to_dev on ARM so that you don't invalidate the cache if >> the direction is DMA_FROM_DEVICE. > > No, in generic case it's unsafe. > >

Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning

2016-10-12 Thread Chris Rorvick
On Wed, Oct 12, 2016 at 1:05 PM, Paul Bolle wrote: > On Wed, 2016-10-12 at 12:50 -0500, Chris Rorvick wrote: >> This may already be apparent, but Dell sells two versions of the 9350: >> one with the Broadcom adapter and one with the AC 8260. > > Off topic, for most readers: my

Re: [PATCH] IB/ipoib: move back the IB LL address into the hard header

2016-10-12 Thread Doug Ledford
On 10/11/2016 2:50 PM, Doug Ledford wrote: > On 10/11/2016 2:30 PM, Jason Gunthorpe wrote: >> On Tue, Oct 11, 2016 at 02:17:51PM -0400, Doug Ledford wrote: >> >>> Well, not exactly. Even if we put 65520 into the scripts, the kernel >>> will silently drop it down to 65504. It actually won't

Re: igb driver can cause cache invalidation of non-owned memory?

2016-10-12 Thread Nikita Yushchenko
> It would make more sense to update the DMA API for > __dma_page_cpu_to_dev on ARM so that you don't invalidate the cache if > the direction is DMA_FROM_DEVICE. No, in generic case it's unsafe. If CPU issued a write to a location, and sometime later that location is used as DMA buffer, there is

Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning

2016-10-12 Thread Paul Bolle
On Wed, 2016-10-12 at 12:50 -0500, Chris Rorvick wrote: > This may already be apparent, but Dell sells two versions of the 9350: > one with the Broadcom adapter and one with the AC 8260. Off topic, for most readers: my version (with the AC 8260) came with Ubuntu preinstalled. Perhaps Chris'

Re: igb driver can cause cache invalidation of non-owned memory?

2016-10-12 Thread Alexander Duyck
On Wed, Oct 12, 2016 at 9:11 AM, Nikita Yushchenko wrote: To get some throughput improvement, I propose removal of that sync_for_device() before reusing buffer. Will you accept such a patch ;) >>> >>> Not one that gets rid of sync_for_device() in the

Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning

2016-10-12 Thread Chris Rorvick
Hi Luca, FYI, It seems that Google does not like your email as I'm not receiving any of your messages in gmail. Some responses below: On Wed, 2016-10-12 at 15:24 +0300, Luca Coelho wrote: > Hi Chris, > On Tue, 2016-10-11 at 09:09 -0500, Chris Rorvick wrote: > > On Tue, Oct 11, 2016 at 5:11 AM,

Re: [RFC] net: phy: smsc: Disable auto-negotiation on startup

2016-10-12 Thread Kyle Roeschley
On Tue, Oct 11, 2016 at 09:32:30AM -0500, Jeremy Linton wrote: > On 10/10/2016 12:41 PM, Kyle Roeschley wrote: > > Because the SMSC PHY completes auto-negotiation before the driver is > > ready to handle interrupts, the PHY state machine never realizes that we > > have a link. Clear the ANENABLE

Re: [RFC v3 3/3] phy,leds: add support for led triggers on phy link state change

2016-10-12 Thread Zach Brown
On Mon, Oct 10, 2016 at 02:03:32AM -0700, Florian Fainelli wrote: > > + > > +#ifdef CONFIG_LED_TRIGGER_PHY > > + > > +#include > > +#include > > + > > +#define PHY_LINK_LED_MAX_TRIGGERS 5 > > +#define PHY_LED_TRIGGER_SPEED_SUFFIX_SIZE 7 > > +#define PHY_MII_BUS_ID_SIZE(20 - 3) > >

[PATCH] net: limit a number of namespaces which can be cleaned up concurrently

2016-10-12 Thread Andrei Vagin
From: Andrey Vagin The operation of destroying netns is heavy and it is executed under net_mutex. If many namespaces are destroyed concurrently, net_mutex can be locked for a long time. It is impossible to create a new netns during this period of time. In our days when userns

[PATCH net] ipv6: tcp: restore IP6CB for pktoptions skbs

2016-10-12 Thread Eric Dumazet
From: Eric Dumazet Baozeng Ding reported following KASAN splat : BUG: KASAN: use-after-free in ip6_datagram_recv_specific_ctl+0x13f1/0x15c0 at addr 880029c84ec8 Read of size 1 by task poc/25548 Call Trace: [] dump_stack+0x12e/0x185 /lib/dump_stack.c:15 [< inline

Re: igb driver can cause cache invalidation of non-owned memory?

2016-10-12 Thread Nikita Yushchenko
>>> To get some throughput improvement, I propose removal of that >>> sync_for_device() before reusing buffer. Will you accept such a patch ;) >> >> Not one that gets rid of sync_for_device() in the driver. From what I >> can tell there are some DMA APIs that use that to perform the >>

Re: [PATCH iproute2 1/1] tc filters: add support to get individual filters by handle

2016-10-12 Thread Cong Wang
On Mon, Oct 10, 2016 at 9:45 AM, Jamal Hadi Salim wrote: > tc/tc_filter.c | 185 > + > 1 file changed, 175 insertions(+), 10 deletions(-) Please update man/man8/tc.8 too, but can be a separated patch. ;)

[PATCH net v2] netvsc: fix checksum on UDP IPV6

2016-10-12 Thread Stephen Hemminger
From: Stephen Hemminger The software calculation of UDP checksum in Netvsc driver was only handling IPv4 case. Instead, use common code to recompute checksum as needed for all protocols. Signed-off-by: Stephen Hemminger --- v2 remove accidental

Re: [RFC] net: phy: smsc: Disable auto-negotiation on startup

2016-10-12 Thread Kyle Roeschley
On Wed, Oct 12, 2016 at 02:13:06AM -0700, Florian Fainelli wrote: > On 10/10/2016 10:41 AM, Kyle Roeschley wrote: > > Because the SMSC PHY completes auto-negotiation before the driver is > > ready to handle interrupts, the PHY state machine never realizes that we > > have a link. Clear the

Re: [PATCH net] net_sched: do not broadcast RTM_GETTFILTER result

2016-10-12 Thread Cong Wang
On Sun, Oct 9, 2016 at 8:25 PM, Eric Dumazet wrote: > + if (unicast) > + return netlink_unicast(net->rtnl, skb, portid, MSG_DONTWAIT); Nit: rtnl_unicast() is simpler.

[PATCH net-next v11 0/1] net: phy: Rebase Edge-Rate clean up

2016-10-12 Thread Allan W. Nielsen
Hi, I can see that the "Add Wake-on-LAN driver for Microsemi PHYs" (0a55c12f97) patch has been applied to net-next, and that it is causing the Edge-Rate patch to conflict. I have therefore rebased v10 of the patch to fit on top of net-next. /Allan -- 2.7.3

RE: igb driver can cause cache invalidation of non-owned memory?

2016-10-12 Thread David Laight
From: Alexander Duyck > Sent: 12 October 2016 16:33 ... > > To get some throughput improvement, I propose removal of that > > sync_for_device() before reusing buffer. Will you accept such a patch ;) > > Not one that gets rid of sync_for_device() in the driver. From what I > can tell there are

Re: [PATCH iproute2] tc: cls_bpf: handle skip_sw and skip_hw flags

2016-10-12 Thread Daniel Borkmann
On 10/12/2016 05:46 PM, Jakub Kicinski wrote: Add support for controling hardware offload using (now standard) skip_sw and skip_hw flags in cls_bpf. Signed-off-by: Jakub Kicinski Acked-by: Daniel Borkmann

[PATCH iproute2] tc: cls_bpf: handle skip_sw and skip_hw flags

2016-10-12 Thread Jakub Kicinski
Add support for controling hardware offload using (now standard) skip_sw and skip_hw flags in cls_bpf. Signed-off-by: Jakub Kicinski --- Hi Stephen! This requires header rebase to get TCA_BPF_FLAGS_GEN in pkt_cls.h. The patch is for 4.9 release so it is targeted at

Re: igb driver can cause cache invalidation of non-owned memory?

2016-10-12 Thread Alexander Duyck
On Tue, Oct 11, 2016 at 11:55 PM, Nikita Yushchenko wrote: The main reason why this isn't a concern for the igb driver is because we currently pass the page up as read-only. We don't allow the stack to write into the page by keeping the page count

Re: [PATCH net-next] tcp: Change txhash on some non-RTO retransmits

2016-10-12 Thread Eric Dumazet
On Tue, 2016-10-11 at 20:56 -0700, Yuchung Cheng wrote: > I thought more about this patch on my way home and have more > questions: why do we exclude RTO retransmission specifically? also > when we rehash, we'll introduce reordering either in recovery or after > recovery, as some TCP CC like bbr

Re: BUG: net/ipv6: kernel memory leak in ip6_datagram_recv_specific_ctl

2016-10-12 Thread Eric Dumazet
On Wed, 2016-10-12 at 19:09 +0800, Baozeng Ding wrote: > Hi all, > The following program triggers use-after-free in > ip6_datagram_recv_specific_ctl, which may leak kernel memory. The > kernel version is 4.8.0+ (on Oct 7 commit > d1f5323370fceaed43a7ee38f4c7bfc7e70f28d0). >

[PATCH] xen-netback: fix type mismatch warning

2016-10-12 Thread Arnd Bergmann
Wiht the latest rework of the xen-netback driver, we get a warning on ARM about the types passed into min(): drivers/net/xen-netback/rx.c: In function 'xenvif_rx_next_chunk': include/linux/kernel.h:739:16: error: comparison of distinct pointer types lacks a cast [-Werror] The reason is that

[PATCH v2] IB/ipoib: move back IB LL address into the hard header

2016-10-12 Thread Paolo Abeni
After the commit 9207f9d45b0a ("net: preserve IP control block during GSO segmentation"), the GSO CB and the IPoIB CB conflict. That destroy the IPoIB address information cached there, causing a severe performance regression, as better described here:

Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7)

2016-10-12 Thread Johannes Berg
> > Can you elaborate on how exactly it kills your system? > > the last time I saw it it was a NULL deref at > ieee80211_aes_ccm_decrypt. Hm. I was expecting something within the crypto code would cause the crash, this seems strange. Anyway, I'm surely out of my depth wrt. the actual cause.

[PATCH net-next v11 1/1] net: phy: Cleanup the Edge-Rate feature in Microsemi PHYs.

2016-10-12 Thread Allan W. Nielsen
Edge-Rate cleanup include the following: - Updated device tree bindings documentation for edge-rate - The edge-rate is now specified as a "slowdown", meaning that it is now being specified as positive values instead of negative (both documentation and implementation wise). - Only explicitly

Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7)

2016-10-12 Thread Sergey Senozhatsky
Hello, On (10/12/16 11:05), Johannes Berg wrote: > Sorry - I meant to look into this yesterday but forgot. > > > Andy, can this be related to CONFIG_VMAP_STACK? > > I think it is. yeah, the system works fine with !CONFIG_VMAP_STACK. > > > current -git kills my system. > > Can you elaborate

Re: [PATCH V2 net-next 15/15] smc: proc-fs interface for smc connections

2016-10-12 Thread Ursula Braun
Hi Dave, thank you for your feedback. Following your guidance I studied the inet_diag/tcp_diag kernel code for AF_INET sockets. It could make sense to create an smc_diag module with an smc_diag_handler to provide SMC-socket data to userspace. Userspace tools could exploit this by receiving the

[PATCH (net.git) 2/2] stmmac: fix error check when init ptp

2016-10-12 Thread Giuseppe Cavallaro
This patch fixes a problem when propagated the failure of ptp_clock_register to open function. Signed-off-by: Giuseppe Cavallaro Cc: Alexandre TORGUE Cc: Rayagond Kokatanur ---

[PATCH (net.git) 1/2] stmmac: fix ptp init for gmac4

2016-10-12 Thread Giuseppe Cavallaro
The gmac 4.x version has not extended descriptors (that are available on 3.x instead of). While initializing the PTP module, the advanced PTP was enabled in case of extended descriptors. This cannot be applied for 4.x version where only the hardware capability register has to show if the feature

ATENCIÓN;

2016-10-12 Thread Sistemas administrador
ATENCIÓN; Su buzón ha superado el límite de almacenamiento, que es de 5 GB definidos por el administrador, quien actualmente está ejecutando en 10.9GB, no puede ser capaz de enviar o recibir correo nuevo hasta que vuelva a validar su buzón de correo electrónico. Para revalidar su buzón de

Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning

2016-10-12 Thread Luca Coelho
On Wed, 2016-10-12 at 14:36 +0200, Paul Bolle wrote: > On Wed, 2016-10-12 at 15:24 +0300, Luca Coelho wrote: > > Okay... Actually this is a structure in the BIOS and the actual method > > we call is SPLC.  The SPLC method may return one item from this table, > > or something entirely different,

Re: [Patch net] net_sched: reorder pernet ops and act ops registrations

2016-10-12 Thread Jamal Hadi Salim
On 16-10-11 01:56 PM, Cong Wang wrote: Krister reported a kernel NULL pointer dereference after tcf_action_init_1() invokes a_o->init(), it is a race condition where one thread calling tcf_register_action() to initialize the netns data after putting act ops in the global list and the other

Re: [PATCH 1/1] vxlan: insert ipv6 macro

2016-10-12 Thread Jiri Benc
On Wed, 12 Oct 2016 21:01:54 +0800, zhuyj wrote: > How to explain the following source code? As you mentioned, are the > #ifdefs in the following source pointless? They are not, the code would not compile without them. Look how struct vxlan_dev is defined. Those are really basic questions you

Re: [PATCH 1/1] vxlan: insert ipv6 macro

2016-10-12 Thread zhuyj
Hi, Jiri How to explain the following source code? As you mentioned, are the #ifdefs in the following source pointless? As to the previous patch, I will compile and analyze it. But now I am busy with something else. After I draw a conclusion, I will let you know. Thanks for your reply. static

[PATCH iproute2 net-next] bridge: vlan: remove wrong stats help

2016-10-12 Thread Nikolay Aleksandrov
When I did the per-vlan stats iproute2 support, I left out a hunk from a previous version of the patch that was using a special subcommand "stats". Since the latest version uses the -s switch remove the help for the stats subcommand. Fixes: 7abf5de677e32 ("bridge: vlan: add support to display

[patch net-next RFC 5/6] mlxsw: reg: add the Monitoring Packet Sampling Configuration Register

2016-10-12 Thread Jiri Pirko
From: Yotam Gigi The MPSC register allows to configure ingress packet sampling on specific port of the mlxsw device. The sampled packets are then trapped via PKT_SAMPLE trap. Signed-off-by: Yotam Gigi Signed-off-by: Jiri Pirko ---

[patch net-next RFC 6/6] mlxsw: packet sample: Add packet sample offloading support

2016-10-12 Thread Jiri Pirko
From: Yotam Gigi Using the MPSC regiter, add the functions that configure port packets sampling in hardware and the necessary datatypes in the mlxsw_sp_port struct. In addition, add the necessary trap for sampled packets and integrate with matchall offloading to allow

[patch net-next RFC 2/6] act_ife: Change to use ife module

2016-10-12 Thread Jiri Pirko
From: Yotam Gigi Use the encode/decode functionality from the ife module instead of using implementation inside the act_ife. Signed-off-by: Yotam Gigi Signed-off-by: Jiri Pirko --- include/net/tc_act/tc_ife.h| 3 -

[patch net-next RFC 3/6] ife: Introduce new metadata tlv types

2016-10-12 Thread Jiri Pirko
From: Yotam Gigi - IFE_META_IFINDEX: Allow to pass ifindex value as part of the ife metadata - IFE_META_ORIG_SIZE: Allow to pass the original packet size as part of the ife metadata. Can be used in case that the packet is truncated - IFE_META_SIZE: Allow to pass the

[patch net-next RFC 0/6] Add support for offloading packet-sampling

2016-10-12 Thread Jiri Pirko
From: Jiri Pirko Add the sample tc action, which allows to sample packet matching a classifier. The sample action peeks randomly packets, duplicates them, truncates them and adds informative metadata on the packet, for example, the input interface and the original packet

Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning

2016-10-12 Thread Paul Bolle
On Wed, 2016-10-12 at 15:24 +0300, Luca Coelho wrote: > Okay... Actually this is a structure in the BIOS and the actual method > we call is SPLC.  The SPLC method may return one item from this table, > or something entirely different, possible one of the three values > depending on a configuration

[patch net-next RFC 4/6] Introduce sample tc action

2016-10-12 Thread Jiri Pirko
From: Yotam Gigi This action allow the user to sample traffic matched by tc classifier. The sampling consists of choosing packets randomly, truncating them, adding some informative metadata regarding the interface and the original packet size and mark them with specific mark,

[patch net-next RFC 1/6] Introduce ife encapsulation module

2016-10-12 Thread Jiri Pirko
From: Yotam Gigi This module is responsible for the ife encapsulation protocol encode/decode logics. That module can: - ife_encode: encode skb and reserve space for the ife meta header - ife_decode: decode skb and extract the meta header size - ife_tlv_meta_encode -

Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning

2016-10-12 Thread Luca Coelho
On Tue, 2016-10-11 at 23:32 -0500, Chris Rorvick wrote: > On Tue, Oct 11, 2016 at 5:11 AM, Paul Bolle wrote: > > For what it's worth, on my machine I have twenty (!) SPLX entries, all > > reading: > > Name (SPLX, Package (0x04) > > { > > Zero, > >

Re: [PATCH v6 2/4] mac80211: filter multicast data packets on AP / AP_VLAN

2016-10-12 Thread Johannes Berg
On Mon, 2016-10-10 at 19:12 +0200, Michael Braun wrote: > This patch adds filtering for multicast data packets on AP_VLAN > interfaces >  [...] Applied patches 1 and 2 for now, I'll look at the others again later. johannes

BUG: net/ipv6: kernel memory leak in ip6_datagram_recv_specific_ctl

2016-10-12 Thread Baozeng Ding
Hi all, The following program triggers use-after-free in ip6_datagram_recv_specific_ctl, which may leak kernel memory. The kernel version is 4.8.0+ (on Oct 7 commit d1f5323370fceaed43a7ee38f4c7bfc7e70f28d0). == BUG: KASAN: use-after-free in

[PATCH net 3/3] s390/lcs: remove trailing space at end of dev_err message

2016-10-12 Thread Ursula Braun
From: Colin Ian King There is a trailing white space at the end of a dev_err message that does nothing useful - remove it. Signed-off-by: Colin Ian King Signed-off-by: Ursula Braun --- drivers/s390/net/lcs.c | 2

[PATCH net 1/3] s390/netiucv: get rid of one memcpy in netiucv_printuser

2016-10-12 Thread Ursula Braun
Save a memcpy in netiucv_printuser(). Signed-off-by: Ursula Braun Reported-by: David Binderman --- drivers/s390/net/netiucv.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/s390/net/netiucv.c

[PATCH net 2/3] s390/netiucv: improve checking of sysfs attribute buffer

2016-10-12 Thread Ursula Braun
High values are always wrong for netiucv's sysfs attribute "buffer". But the current code does not detect values between 2**31 and 2**32 as invalid. Choosing type "unsigned int" for variable "bs1" and making use of "kstrtouint()" improves the syntax checking for "buffer". Signed-off-by: Ursula

[PATCH net 0/3] s390 network driver patches

2016-10-12 Thread Ursula Braun
Hi Dave, here are 3 small patches for the s390 network drivers netiucv and lcs. They are built for the net-tree. Thanks, Ursula Ursula Braun (2): s390/netiucv: get rid of one memcpy in netiucv_printuser s390/netiucv: improve checking of sysfs attribute buffer Colin Ian King (1):

[PATCH] qede: fix CONFIG_INFINIBAND_QEDR=m build error

2016-10-12 Thread Arnd Bergmann
The newly introduced INFINIBAND_QEDR option is 'tristate' but fails to build when set to 'm': drivers/net/built-in.o: In function `qed_hw_init': (.text+0x1c0e17): undefined reference to `qed_rdma_dpm_bar' drivers/net/built-in.o: In function `qed_eq_completion': (.text+0x1d185b): undefined

Re: [PATCH net-next v10 1/1] net: phy: Cleanup the Edge-Rate feature in Microsemi PHYs.

2016-10-12 Thread Florian Fainelli
On 10/10/2016 07:13 AM, Allan W. Nielsen wrote: > Edge-Rate cleanup include the following: > - Updated device tree bindings documentation for edge-rate > - The edge-rate is now specified as a "slowdown", meaning that it is now > being specified as positive values instead of negative (both >

Re: [PATCH v3] Add support for ethtool operations and statistics to RDC-R6040.

2016-10-12 Thread Florian Fainelli
On 10/11/2016 11:36 PM, VENKAT PRASHANTH B U wrote: > This is a patch to add support for ethtool operations and keeping > up to date statistics for RDC R6040 fast ethernet MAC driver. > > Signed-off-by: Venkat Prashanth B U > --- > changelog v3: > -Made the commit

[patch v2] netfilter: nf_tables: underflow in nft_parse_u32_check()

2016-10-12 Thread Dan Carpenter
We don't want to allow negatives here. Fixes: 36b701fae12a ('netfilter: nf_tables: validate maximum value of u32 netlink attributes') Signed-off-by: Dan Carpenter --- v2: cosmetic change diff --git a/net/netfilter/nf_tables_api.c b/net/netfilter/nf_tables_api.c index

Re: [RFC] net: phy: smsc: Disable auto-negotiation on startup

2016-10-12 Thread Florian Fainelli
On 10/10/2016 10:41 AM, Kyle Roeschley wrote: > Because the SMSC PHY completes auto-negotiation before the driver is > ready to handle interrupts, the PHY state machine never realizes that we > have a link. Clear the ANENABLE bit on initialization, which lets > genphy_config_aneg do its thing when

  1   2   >