Re: [RFC] make kmemleak scan __ro_after_init section (was: Re: [PATCH 0/5] genetlink improvements)

2016-11-02 Thread Cong Wang
On Wed, Nov 2, 2016 at 4:47 PM, Jakub Kicinski wrote: > > Thanks for looking into this! Bisect led me to the following commit: > > commit 56989f6d8568c21257dcec0f5e644d5570ba3281 > Author: Johannes Berg > Date: Mon Oct 24 14:40:05 2016 +0200 > >

Re: net/netlink: global-out-of-bounds in genl_family_rcv_msg/validate_nla

2016-11-02 Thread Cong Wang
On Wed, Nov 2, 2016 at 10:25 PM, Cong Wang wrote: > On Wed, Nov 2, 2016 at 5:25 PM, Andrey Konovalov > wrote: >> Hi, >> >> I've got the following error report while running the syzkaller fuzzer: >> >>

Re: net/netlink: global-out-of-bounds in genl_family_rcv_msg/validate_nla

2016-11-02 Thread Cong Wang
On Wed, Nov 2, 2016 at 5:25 PM, Andrey Konovalov wrote: > Hi, > > I've got the following error report while running the syzkaller fuzzer: > > == > BUG: KASAN: global-out-of-bounds in validate_nla+0x49b/0x4e0 at

bpf: kernel BUG in htab_elem_free

2016-11-02 Thread Dmitry Vyukov
Here we go. The following program triggers kernel BUG in htab_elem_free. On commit 0c183d92b20b5c84ca655b45ef57b3318b83eb9e (Oct 31). Run as "while true; do ./a.out; done". [ cut here ] kernel BUG at mm/slub.c:3866! invalid opcode: [#1] SMP KASAN Modules linked in:

Re: [PATCH net-next RFC WIP] Patch for XDP support for virtio_net

2016-11-02 Thread Michael S. Tsirkin
On Wed, Nov 02, 2016 at 06:28:34PM -0700, Shrijeet Mukherjee wrote: > > -Original Message- > > From: Jesper Dangaard Brouer [mailto:bro...@redhat.com] > > Sent: Wednesday, November 2, 2016 7:27 AM > > To: Thomas Graf > > Cc: Shrijeet Mukherjee ;

[PATCH net] ipv6: dccp: fix out of bound access in dccp_v6_err()

2016-11-02 Thread Eric Dumazet
From: Eric Dumazet dccp_v6_err() does not use pskb_may_pull() and might access garbage. We only need 4 bytes at the beginning of the DCCP header, like TCP, so the 8 bytes pulled in icmpv6_notify() are more than enough. Signed-off-by: Eric Dumazet ---

[PATCH net] netlink: netlink_diag_dump() runs without locks

2016-11-02 Thread Eric Dumazet
From: Eric Dumazet A recent commit removed locking from netlink_diag_dump() but forgot one error case. = [ BUG: bad unlock balance detected! ] 4.9.0-rc3+ #336 Not tainted - syz-executor/4018 is trying

Re: net/netlink: null-ptr-deref in netlink_dump/lock_acquire

2016-11-02 Thread Andrey Konovalov
Hi Eric, This fixes the second report, the first one is still there. Apparently these are two separate issues. For the second one: Tested-by: Andrey Konovalov Thanks for the fix! On Thu, Nov 3, 2016 at 3:58 AM, Eric Dumazet wrote: > On Thu,

Re: [PATCH 2/2] rtl8xxxu: Fix for bogus data used to determine macpower

2016-11-02 Thread David Miller
From: Larry Finger Date: Wed, 2 Nov 2016 20:00:03 -0500 > On 10/30/2016 05:21 AM, John Heenan wrote: >> Code tests show data returned by rtl8xxxu_read8(priv, REG_CR), used to >> set >> macpower, is never 0xea. It is only ever 0x01 (first time after >> modprobe) >>

Re: net/netlink: null-ptr-deref in netlink_dump/lock_acquire

2016-11-02 Thread Eric Dumazet
On Thu, 2016-11-03 at 03:36 +0100, Andrey Konovalov wrote: > On Thu, Nov 3, 2016 at 1:15 AM, Andrey Konovalov > wrote: > > On Wed, Oct 19, 2016 at 4:13 PM, Andrey Konovalov > > wrote: > >> Hi, > >> > >> I've got the following error report while

Re: net/netlink: null-ptr-deref in netlink_dump/lock_acquire

2016-11-02 Thread Andrey Konovalov
On Thu, Nov 3, 2016 at 1:15 AM, Andrey Konovalov wrote: > On Wed, Oct 19, 2016 at 4:13 PM, Andrey Konovalov > wrote: >> Hi, >> >> I've got the following error report while running the syzkaller fuzzer: >> >> kasan: CONFIG_KASAN_INLINE enabled >>

[PATCH net] dccp: fix out of bound access in dccp_v4_err()

2016-11-02 Thread Eric Dumazet
From: Eric Dumazet dccp_v4_err() does not use pskb_may_pull() and might access garbage. We only need 4 bytes at the beginning of the DCCP header, like TCP, so the 8 bytes pulled in icmp_socket_deliver() are more than enough. This patch might allow to process more ICMP

RE: [PATCH net-next RFC WIP] Patch for XDP support for virtio_net

2016-11-02 Thread Shrijeet Mukherjee
> -Original Message- > From: Jesper Dangaard Brouer [mailto:bro...@redhat.com] > Sent: Wednesday, November 2, 2016 7:27 AM > To: Thomas Graf > Cc: Shrijeet Mukherjee ; Alexei Starovoitov > ; Jakub Kicinski

Re: [PATCH net 1/1] driver: veth: Return the actual value instead return NETDEV_TX_OK always

2016-11-02 Thread Gao Feng
Hi Florian, On Thu, Nov 3, 2016 at 8:58 AM, Florian Fainelli wrote: > On 11/02/2016 05:52 PM, Gao Feng wrote: >> Hi Cong, >> >> On Thu, Nov 3, 2016 at 4:22 AM, Cong Wang wrote: >>> On Wed, Nov 2, 2016 at 2:59 AM, wrote:

[PATCH net] dccp: do not send reset to already closed sockets

2016-11-02 Thread Eric Dumazet
From: Eric Dumazet Andrey reported following warning while fuzzing with syzkaller WARNING: CPU: 1 PID: 21072 at net/dccp/proto.c:83 dccp_set_state+0x229/0x290 Kernel panic - not syncing: panic_on_warn set ... CPU: 1 PID: 21072 Comm: syz-executor Not tainted 4.9.0-rc1+ #293

Re: [PATCH 2/2] rtl8xxxu: Fix for bogus data used to determine macpower

2016-11-02 Thread Larry Finger
On 10/30/2016 05:21 AM, John Heenan wrote: Code tests show data returned by rtl8xxxu_read8(priv, REG_CR), used to set macpower, is never 0xea. It is only ever 0x01 (first time after modprobe) using wpa_supplicant and 0x00 thereafter using wpa_supplicant. These results occurs with 'Fix for

Re: [PATCH 1/2] rtl8xxxu: Fix for authentication failure

2016-11-02 Thread Larry Finger
On 10/30/2016 05:20 AM, John Heenan wrote: This fix enables the same sequence of init behaviour as the alternative working driver for the wireless rtl8723bu IC at https://github.com/lwfinger/rtl8723bu For exampe rtl8xxxu_init_device is now called each time userspace wpa_supplicant is executed

Re: [PATCH net 1/1] driver: veth: Return the actual value instead return NETDEV_TX_OK always

2016-11-02 Thread Florian Fainelli
On 11/02/2016 05:52 PM, Gao Feng wrote: > Hi Cong, > > On Thu, Nov 3, 2016 at 4:22 AM, Cong Wang wrote: >> On Wed, Nov 2, 2016 at 2:59 AM, wrote: >>> From: Gao Feng >>> >>> Current veth_xmit always returns NETDEV_TX_OK whatever if it

Re: [PATCH net 1/1] driver: veth: Return the actual value instead return NETDEV_TX_OK always

2016-11-02 Thread Gao Feng
Hi Cong, On Thu, Nov 3, 2016 at 4:22 AM, Cong Wang wrote: > On Wed, Nov 2, 2016 at 2:59 AM, wrote: >> From: Gao Feng >> >> Current veth_xmit always returns NETDEV_TX_OK whatever if it is really >> sent successfully. Now return the

Fwd: net/netlink: global-out-of-bounds in genl_family_rcv_msg/validate_nla

2016-11-02 Thread Andrey Konovalov
Hi, I've got the following error report while running the syzkaller fuzzer: == BUG: KASAN: global-out-of-bounds in validate_nla+0x49b/0x4e0 at addr 8407e3ac Read of size 2 by task a.out/3877 Address belongs to variable[<

net/netlink: global-out-of-bounds in genl_family_rcv_msg/validate_nla

2016-11-02 Thread Andrey Konovalov
Hi, I've got the following error report while running the syzkaller fuzzer: == BUG: KASAN: global-out-of-bounds in validate_nla+0x49b/0x4e0 at addr 8407e3ac Read of size 2 by task a.out/3877 Address belongs to variable[<

Re: net/netlink: null-ptr-deref in netlink_dump/lock_acquire

2016-11-02 Thread Andrey Konovalov
On Wed, Oct 19, 2016 at 4:13 PM, Andrey Konovalov wrote: > Hi, > > I've got the following error report while running the syzkaller fuzzer: > > kasan: CONFIG_KASAN_INLINE enabled > kasan: GPF could be caused by NULL-ptr deref or user memory access > general protection fault:

[PATCH net] dccp: do not release listeners too soon

2016-11-02 Thread Eric Dumazet
From: Eric Dumazet Andrey Konovalov reported following error while fuzzing with syzkaller : IPv4: Attempt to release alive inet socket 880068e98940 kasan: CONFIG_KASAN_INLINE enabled kasan: GPF could be caused by NULL-ptr deref or user memory access general protection

Grant Benefit

2016-11-02 Thread Mrs Julie Leach
You are a recipient to Mrs Julie Leach Donation of $2 million USD. Contact (julieleach...@gmail.com) for claims

[RFC] make kmemleak scan __ro_after_init section (was: Re: [PATCH 0/5] genetlink improvements)

2016-11-02 Thread Jakub Kicinski
On Wed, 2 Nov 2016 13:30:34 -0700, Cong Wang wrote: > On Tue, Nov 1, 2016 at 11:56 AM, Jakub Kicinski wrote: > > On Tue, 1 Nov 2016 11:32:52 -0700, Cong Wang wrote: > >> On Tue, Nov 1, 2016 at 10:28 AM, Jakub Kicinski wrote: > >> > unreferenced object

Re: mlx5: ifup failure due to huge allocation

2016-11-02 Thread Saeed Mahameed
On Wed, Nov 2, 2016 at 3:37 PM, Sebastian Ott wrote: > Hi, > > Ifup on an interface provided by CX4 (MLX5 driver) on s390 fails with: > > [ 22.318553] [ cut here ] > [ 22.318564] WARNING: CPU: 1 PID: 399 at mm/page_alloc.c:3421 >

Re: [PATCH net-next v2 0/5] bpf: BPF for lightweight tunnel encapsulation

2016-11-02 Thread Tom Herbert
On Wed, Nov 2, 2016 at 3:57 PM, Thomas Graf wrote: > On 1 November 2016 at 17:07, Tom Herbert wrote: >> On the other hand, I'm not really sure how to implement for this level >> of performance this in LWT+BPF either. It seems like one way to do >> that would

Re: [PATCH net-next 07/11] net: dsa: mv88e6xxx: add port link setter

2016-11-02 Thread Andrew Lunn
> Do you expect to return an error if adjust_link is called with > phydev->duplex == DUPLEX_UNKNOWN, or, do you expect to fallback to > unforced duplex when setting such value? ethtool(1) itself does not allow you to specify "unknown". It only allows "full" or "half". So passing DUPLEX_UNKNOWN

Re: [PATCH net-next v2 3/5] bpf: BPF for lightweight tunnel encapsulation

2016-11-02 Thread Thomas Graf
On 2 November 2016 at 07:39, Roopa Prabhu wrote: >> diff --git a/net/core/Makefile b/net/core/Makefile >> index d6508c2..a675fd3 100644 >> --- a/net/core/Makefile >> +++ b/net/core/Makefile >> @@ -23,7 +23,7 @@ obj-$(CONFIG_NETWORK_PHY_TIMESTAMPING) += timestamping.o >>

Re: [PATCH net-next v2 0/5] bpf: BPF for lightweight tunnel encapsulation

2016-11-02 Thread Thomas Graf
On 1 November 2016 at 17:07, Tom Herbert wrote: > On the other hand, I'm not really sure how to implement for this level > of performance this in LWT+BPF either. It seems like one way to do > that would be to create a program each destination and set it each > host. As you

Re: [PATCH net-next v2 0/5] bpf: BPF for lightweight tunnel encapsulation

2016-11-02 Thread Thomas Graf
On 1 November 2016 at 16:12, Hannes Frederic Sowa wrote: > On 01.11.2016 21:59, Thomas Graf wrote: >>> Dumping and verifying which routes get used might actually already be >>> quite complex on its own. Thus my fear. >> >> We even have an API to query which route is

Re: [PATCH net-next] net: remove unused argument in checksum unnecessary conversion

2016-11-02 Thread Tom Herbert
On Wed, Nov 2, 2016 at 1:14 PM, Willem de Bruijn wrote: > From: Willem de Bruijn > > The check argument is never used. This code has not changed since > the original introduction in d96535a17dbb ("net: Infrastructure for > checksum unnecessary

Re: net/sctp: use-after-free in __sctp_connect

2016-11-02 Thread Andrey Konovalov
On Wed, Oct 19, 2016 at 6:57 PM, Marcelo Ricardo Leitner wrote: > On Wed, Oct 19, 2016 at 02:25:24PM +0200, Andrey Konovalov wrote: >> Hi, >> >> I've got the following error report while running the syzkaller fuzzer: >> >>

Re: [PATCH net-next 07/11] net: dsa: mv88e6xxx: add port link setter

2016-11-02 Thread Vivien Didelot
Hi Andrew, Andrew Lunn writes: > On Wed, Nov 02, 2016 at 02:07:09AM +0100, Vivien Didelot wrote: >> Hi Andrew, >> >> Andrew Lunn writes: >> >> >> +#define LINK_UNKNOWN -1 >> >> + >> >> + /* Port's MAC link state >> >> + * LINK_UNKNOWN for normal link

Re: [PATCH net] tcp: fix return value for partial writes

2016-11-02 Thread Soheil Hassas Yeganeh
On Wed, Nov 2, 2016 at 5:41 PM, Eric Dumazet wrote: > From: Eric Dumazet > > After my commit, tcp_sendmsg() might restart its loop after > processing socket backlog. > > If sk_err is set, we blindly return an error, even though we > copied data to

Re: [PATCH] e1000e: free IRQ when the link is up or down

2016-11-02 Thread Alexander Duyck
On Wed, Nov 2, 2016 at 2:08 PM, Tyler Baicar wrote: > Move IRQ free code so that it will happen regardless of the > link state. Currently the e1000e driver only releases its IRQ > if the link is up. This is not sufficient because it is > possible for a link to go down

[PATCH net] tcp: fix return value for partial writes

2016-11-02 Thread Eric Dumazet
From: Eric Dumazet After my commit, tcp_sendmsg() might restart its loop after processing socket backlog. If sk_err is set, we blindly return an error, even though we copied data to user space before. We should instead return number of bytes that could be copied, otherwise

Re: [PATCH net-next] ibmveth: v1 calculate correct gso_size and set gso_type

2016-11-02 Thread Brian King
On 10/27/2016 10:26 AM, Eric Dumazet wrote: > On Wed, 2016-10-26 at 11:09 +1100, Jon Maxwell wrote: >> We recently encountered a bug where a few customers using ibmveth on the >> same LPAR hit an issue where a TCP session hung when large receive was >> enabled. Closer analysis revealed that the

Re: [PATCH net-next iproute2 PATCH 2/2 v2] ss: Add inet raw sockets information gathering via netlink diag interface

2016-11-02 Thread David Ahern
On 11/2/16 7:14 AM, Cyrill Gorcunov wrote: > unix, tcp, udp[lite], packet, netlink sockets already support diag > interface for their collection and killing. Implement support > for raw sockets. > > Signed-off-by: Cyrill Gorcunov > --- > include/linux/inet_diag.h | 15

net/ipv6: null-ptr-deref in inet6_bind

2016-11-02 Thread Andrey Konovalov
Hi, I've got the following error report while running the syzkaller fuzzer: BUG: unable to handle kernel NULL pointer dereference at (null) IP: [< (null)>] (null) PGD 66b6f067 [ 102.549865] PUD 66c6e067 PMD 0 [ 102.549865] Oops: 0010 [#1] SMP KASAN Modules linked

Re: [PATCH] net: tcp: check skb is non-NULL for exact match on lookups

2016-11-02 Thread David Ahern
On 11/2/16 2:13 PM, Andrey Konovalov wrote: > I can confirm that this fixes the null-ptr-deref I've been getting. > Thanks, Andrey.

[PATCH] e1000e: free IRQ when the link is up or down

2016-11-02 Thread Tyler Baicar
Move IRQ free code so that it will happen regardless of the link state. Currently the e1000e driver only releases its IRQ if the link is up. This is not sufficient because it is possible for a link to go down without releasing the IRQ. A secondary bus reset can cause this case to happen.

net/dccp: null-ptr-deref in dccp_parse_options

2016-11-02 Thread Andrey Konovalov
Hi, I've got the following error report while running the syzkaller fuzzer: kasan: CONFIG_KASAN_INLINE enabled kasan: GPF could be caused by NULL-ptr deref or user memory access general protection fault: [#1] SMP KASAN Modules linked in: CPU: 0 PID: 4677 Comm: syz-executor Not tainted

[PATCH net v3] ipv4: allow local fragmentation in ip_finish_output_gso()

2016-11-02 Thread Lance Richardson
Some configurations (e.g. geneve interface with default MTU of 1500 over an ethernet interface with 1500 MTU) result in the transmission of packets that exceed the configured MTU. While this should be considered to be a "bad" configuration, it is still allowed and should not result in the sending

[PATCH net-next v6 02/10] dpaa_eth: add support for DPAA Ethernet

2016-11-02 Thread Madalin Bucur
This introduces the Freescale Data Path Acceleration Architecture (DPAA) Ethernet driver (dpaa_eth) that builds upon the DPAA QMan, BMan, PAMU and FMan drivers to deliver Ethernet connectivity on the Freescale DPAA QorIQ platforms. Signed-off-by: Madalin Bucur ---

[PATCH net-next v6 09/10] arch/powerpc: Enable FSL_FMAN

2016-11-02 Thread Madalin Bucur
Signed-off-by: Madalin Bucur --- arch/powerpc/configs/dpaa.config | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/configs/dpaa.config b/arch/powerpc/configs/dpaa.config index f124ee1..9ad9bc0 100644 --- a/arch/powerpc/configs/dpaa.config +++

[PATCH net-next v6 00/10] dpaa_eth: Add the QorIQ DPAA Ethernet driver

2016-11-02 Thread Madalin Bucur
This patch series adds the Ethernet driver for the Freescale QorIQ Data Path Acceleration Architecture (DPAA). This version includes changes following the feedback received on previous versions from Eric Dumazet, Bob Cochran, Joe Perches, Paul Bolle, Joakim Tjernlund, Scott Wood, David Miller -

[PATCH net-next v6 03/10] dpaa_eth: add option to use one buffer pool set

2016-11-02 Thread Madalin Bucur
Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/dpaa/Kconfig| 6 ++ drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 23 +++ 2 files changed, 29 insertions(+) diff --git a/drivers/net/ethernet/freescale/dpaa/Kconfig

[PATCH net-next v6 01/10] devres: add devm_alloc_percpu()

2016-11-02 Thread Madalin Bucur
Introduce managed counterparts for alloc_percpu() and free_percpu(). Add devm_alloc_percpu() and devm_free_percpu() into the managed interfaces list. Signed-off-by: Madalin Bucur --- Documentation/driver-model/devres.txt | 4 +++ drivers/base/devres.c |

Re: new kmemleak reports (was: Re: [PATCH 0/5] genetlink improvements)

2016-11-02 Thread Cong Wang
On Tue, Nov 1, 2016 at 11:56 AM, Jakub Kicinski wrote: > On Tue, 1 Nov 2016 11:32:52 -0700, Cong Wang wrote: >> On Tue, Nov 1, 2016 at 10:28 AM, Jakub Kicinski wrote: >> > unreferenced object 0x8807389cba28 (size 128): >> > comm "swapper/0", pid 1, jiffies

Re: net/dccp: null-ptr-deref in dccp_v4_rcv/selinux_socket_sock_rcv_skb

2016-11-02 Thread Andrey Konovalov
Hi Eric, Your patch fixes the issue. Tested-by: Andrey Konovalov Thanks! On Wed, Nov 2, 2016 at 9:16 PM, Eric Dumazet wrote: > On Wed, 2016-11-02 at 19:44 +0100, Andrey Konovalov wrote: >> Hi, >> >> I've got the following error report while

Re: [PATCH net 1/1] driver: veth: Return the actual value instead return NETDEV_TX_OK always

2016-11-02 Thread Cong Wang
On Wed, Nov 2, 2016 at 2:59 AM, wrote: > From: Gao Feng > > Current veth_xmit always returns NETDEV_TX_OK whatever if it is really > sent successfully. Now return the actual value instead of NETDEV_TX_OK > always. > > Signed-off-by: Gao Feng >

[PATCH net-next v6 08/10] arch/powerpc: Enable FSL_PAMU

2016-11-02 Thread Madalin Bucur
Signed-off-by: Madalin Bucur --- arch/powerpc/configs/dpaa.config | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/configs/dpaa.config b/arch/powerpc/configs/dpaa.config index efa99c0..f124ee1 100644 --- a/arch/powerpc/configs/dpaa.config +++

[PATCH net-next v6 10/10] arch/powerpc: Enable dpaa_eth

2016-11-02 Thread Madalin Bucur
Signed-off-by: Madalin Bucur --- arch/powerpc/configs/dpaa.config | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/configs/dpaa.config b/arch/powerpc/configs/dpaa.config index 9ad9bc0..2fe76f5 100644 --- a/arch/powerpc/configs/dpaa.config +++

[PATCH net-next v6 05/10] dpaa_eth: add ethtool statistics

2016-11-02 Thread Madalin Bucur
Add a series of counters to be exported through ethtool: - add detailed counters for reception errors; - add detailed counters for QMan enqueue reject events; - count the number of fragmented skbs received from the stack; - count all frames received on the Tx confirmation path; - add congestion

[PATCH net-next v6 04/10] dpaa_eth: add ethtool functionality

2016-11-02 Thread Madalin Bucur
Add support for basic ethtool operations. Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/dpaa/Makefile | 2 +- drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 2 + drivers/net/ethernet/freescale/dpaa/dpaa_eth.h | 3 +

[PATCH net-next v6 07/10] dpaa_eth: add trace points

2016-11-02 Thread Madalin Bucur
Add trace points on the hot processing path. Signed-off-by: Ruxandra Ioana Radulescu --- drivers/net/ethernet/freescale/dpaa/Makefile | 1 + drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 15 +++ drivers/net/ethernet/freescale/dpaa/dpaa_eth.h | 1

Re: [PATCH net v2] ipv4: allow local fragmentation in ip_finish_output_gso()

2016-11-02 Thread kbuild test robot
Hi Lance, [auto build test WARNING on net/master] url: https://github.com/0day-ci/linux/commits/Lance-Richardson/ipv4-allow-local-fragmentation-in-ip_finish_output_gso/20161103-040904 config: x86_64-randconfig-x014-201644 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901

[PATCH net-next v6 06/10] dpaa_eth: add sysfs exports

2016-11-02 Thread Madalin Bucur
Export Frame Queue and Buffer Pool IDs through sysfs. Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/dpaa/Makefile | 2 +- drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 4 + drivers/net/ethernet/freescale/dpaa/dpaa_eth.h | 4 +

Re: net/dccp: null-ptr-deref in dccp_v4_rcv/selinux_socket_sock_rcv_skb

2016-11-02 Thread Eric Dumazet
On Wed, 2016-11-02 at 19:44 +0100, Andrey Konovalov wrote: > Hi, > > I've got the following error report while running the syzkaller fuzzer: > > IPv4: Attempt to release alive inet socket 880068e98940 > kasan: CONFIG_KASAN_INLINE enabled > kasan: GPF could be caused by NULL-ptr deref or user

[PATCH net-next] net: remove unused argument in checksum unnecessary conversion

2016-11-02 Thread Willem de Bruijn
From: Willem de Bruijn The check argument is never used. This code has not changed since the original introduction in d96535a17dbb ("net: Infrastructure for checksum unnecessary conversions"). Remove the unused argument and update all callers. Signed-off-by: Willem de Bruijn

Re: [PATCH] net: tcp: check skb is non-NULL for exact match on lookups

2016-11-02 Thread Andrey Konovalov
I can confirm that this fixes the null-ptr-deref I've been getting. Tested-by: Andrey Konovalov On Wed, Nov 2, 2016 at 8:08 PM, David Ahern wrote: > Andrey reported the following error report while running the syzkaller > fuzzer: > > general

Re: [PATCH net] ipv4: allow local fragmentation in ip_finish_output_gso()

2016-11-02 Thread Lance Richardson
- Original Message - > From: "Florian Westphal" > To: "Lance Richardson" > Cc: netdev@vger.kernel.org, f...@strlen.de, jtl...@redhat.com > Sent: Wednesday, November 2, 2016 1:20:36 PM > Subject: Re: [PATCH net] ipv4: allow local fragmentation in >

[PATCH net v2] ipv4: allow local fragmentation in ip_finish_output_gso()

2016-11-02 Thread Lance Richardson
Some configurations (e.g. geneve interface with default MTU of 1500 over an ethernet interface with 1500 MTU) result in the transmission of packets that exceed the configured MTU. While this should be considered to be a "bad" configuration, it is still allowed and should not result in the sending

Re: [Patch net] inet: fix sleeping inside inet_wait_for_connect()

2016-11-02 Thread Cong Wang
On Tue, Nov 1, 2016 at 6:54 PM, Eric Dumazet wrote: > On Tue, 2016-11-01 at 16:04 -0700, Cong Wang wrote: >> Andrey reported this kernel warning: > >> Unlike commit 26cabd31259ba43f68026ce3f62b78094124333f >> ("sched, net: Clean up sk_wait_event() vs. might_sleep()"), the

Re: [PATCH v5 4/7] Documentation: devicetree: net: add NS2 bindings to amac

2016-11-02 Thread Sergei Shtylyov
On 11/02/2016 08:24 PM, Jon Mason wrote: Clean-up the documentation to the bgmac-amac driver, per suggestion by Rob Herring, and add details for NS2 support. Signed-off-by: Jon Mason --- Documentation/devicetree/bindings/net/brcm,amac.txt | 16 +++- 1 file

Re: [PATCH net-next v2] mlxsw: Remove unused including

2016-11-02 Thread David Miller
From: Wei Yongjun Date: Wed, 2 Nov 2016 12:49:57 + > From: Wei Yongjun > > Remove including that don't need it. > > Signed-off-by: Wei Yongjun Applied.

Re: [PATCH 1/1] xen-netfront: cast grant table reference first to type int

2016-11-02 Thread David Miller
From: Dongli Zhang Date: Wed, 2 Nov 2016 09:04:33 +0800 > IS_ERR_VALUE() in commit 87557efc27f6a50140fb20df06a917f368ce3c66 > ("xen-netfront: do not cast grant table reference to signed short") would > not return true for error code unless we cast ref first to type int.

Re: [PATCH net-next] enic: set skb->hash type properly

2016-11-02 Thread David Miller
From: Govindarajulu Varadarajan Date: Tue, 1 Nov 2016 17:58:50 -0700 > From: Govindarajulu Varadarajan <_gov...@gmx.com> > > Driver sets the skb l4/l3 hash based on NIC_CFG_RSS_HASH_TYPE_*, > which is bit mask. This is wrong. Hw actually provides us enum. > Use

RE: [PATCH v4 net-next] lan78xx: Use irq_domain for phy interrupt from USB Int. EP

2016-11-02 Thread Woojung.Huh
> -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Wednesday, November 02, 2016 3:25 PM > To: Woojung Huh - C21699 > Cc: netdev@vger.kernel.org; f.faine...@gmail.com; and...@lunn.ch; > UNGLinuxDriver > Subject: Re: [PATCH v4 net-next] lan78xx: Use irq_domain for

Re: [PATCH] net: 3com: typhoon: use new api ethtool_{get|set}_link_ksettings

2016-11-02 Thread David Miller
From: Philippe Reynes Date: Wed, 2 Nov 2016 00:11:51 +0100 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > Signed-off-by: Philippe Reynes Applied.

Re: [PATCH net-next] ila: Fix crash caused by rhashtable changes

2016-11-02 Thread David Miller
From: Tom Herbert Date: Tue, 1 Nov 2016 14:55:25 -0700 > commit ca26893f05e86 ("rhashtable: Add rhlist interface") > added a field to rhashtable_iter so that length became 56 bytes > and would exceed the size of args in netlink_callback (which is > 48 bytes). The netlink

Re: [PATCH] net: ip, diag -- Adjust raw_abort to use unlocked __udp_disconnect

2016-11-02 Thread David Miller
From: Cyrill Gorcunov Date: Tue, 1 Nov 2016 23:05:00 +0300 > While being preparing patches for killing raw sockets via > diag netlink interface I noticed that my runs are stuck: > > | [root@pcs7 ~]# cat /proc/`pidof ss`/stack > | [] __lock_sock+0x80/0xc4 > | []

Re: [PATCH v4 net-next] lan78xx: Use irq_domain for phy interrupt from USB Int. EP

2016-11-02 Thread David Miller
From: Date: Tue, 1 Nov 2016 20:02:00 + > From: Woojung Huh > > To utilize phylib with interrupt fully than handling some of phy stuff in the > MAC driver, > create irq_domain for USB interrupt EP of phy interrupt and > pass the irq

Re: [PATCH net v3 2/2] ip6_udp_tunnel: remove unused IPCB related codes

2016-11-02 Thread David Miller
From: Eli Cooper Date: Tue, 1 Nov 2016 23:45:13 +0800 > Some IPCB fields are currently set in udp_tunnel6_xmit_skb(), which are > never used before it reaches ip6tunnel_xmit(), and past that point the > control buffer is no longer interpreted as IPCB. > > This clears these

Re: [PATCH net v3 1/2] ip6_tunnel: Clear IP6CB in ip6tunnel_xmit()

2016-11-02 Thread David Miller
From: Eli Cooper Date: Tue, 1 Nov 2016 23:45:12 +0800 > skb->cb may contain data from previous layers. In the observed scenario, > the garbage data were misinterpreted as IP6CB(skb)->frag_max_size, so > that small packets sent through the tunnel are mistakenly fragmented. >

Re: [PATCH 1/3] net: mii: add generic function to support ksetting support

2016-11-02 Thread David Miller
From: Philippe Reynes Date: Tue, 1 Nov 2016 16:32:25 +0100 > The old ethtool api (get_setting and set_setting) has generic mii > functions mii_ethtool_sset and mii_ethtool_gset. > > To support the new ethtool api ({get|set}_link_ksettings), we add > two generics mii function

Re: [PATCH 2/3] net: 3c59x: use new api ethtool_{get|set}_link_ksettings

2016-11-02 Thread David Miller
From: Philippe Reynes Date: Tue, 1 Nov 2016 16:32:26 +0100 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > Signed-off-by: Philippe Reynes Applied.

Re: [PATCH 3/3] net: 3c509: use new api ethtool_{get|set}_link_ksettings

2016-11-02 Thread David Miller
From: Philippe Reynes Date: Tue, 1 Nov 2016 16:32:27 +0100 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > Signed-off-by: Philippe Reynes Applied.

Re: [PATCH net-next 0/3] tools lib bpf: Synchronize implementations

2016-11-02 Thread Arnaldo Carvalho de Melo
Em Wed, Nov 02, 2016 at 03:04:05PM -0400, David Miller escreveu: > From: Alexei Starovoitov > Date: Tue, 1 Nov 2016 16:04:35 -0600 > > > I think these patches has to go through Arnaldo's perf tree, since > > otherwise they will conflict with Wang's changes. > > Ok.

Re: [PATCH] MAINTAINERS: Update MELLANOX MLX5 core VPI driver maintainers

2016-11-02 Thread David Miller
From: Saeed Mahameed Date: Tue, 1 Nov 2016 15:09:58 +0200 > Add myself as a maintainer for mlx5 core driver as well. > > Signed-off-by: Saeed Mahameed Applied.

[PATCH] net: tcp: check skb is non-NULL for exact match on lookups

2016-11-02 Thread David Ahern
Andrey reported the following error report while running the syzkaller fuzzer: general protection fault: [#1] SMP KASAN Dumping ftrace buffer: (ftrace buffer empty) Modules linked in: CPU: 0 PID: 648 Comm: syz-executor Not tainted 4.9.0-rc3+ #333 Hardware name: QEMU Standard PC (i440FX +

Re: [PATCH net-next V3 0/3] mlx4 XDP TX refactor

2016-11-02 Thread David Miller
From: Tariq Toukan Date: Wed, 2 Nov 2016 17:12:22 +0200 > This patchset refactors the XDP forwarding case, so that > its dedicated transmit queues are managed in a complete > separation from the other regular ones. > > It also adds ethtool counters for XDP cases. > >

Re: [PATCH net-next] sctp: clean up sctp_packet_transmit

2016-11-02 Thread David Miller
From: Xin Long Date: Tue, 1 Nov 2016 00:49:41 +0800 > After adding sctp gso, sctp_packet_transmit is a quite big function now. > > This patch is to extract the codes for packing packet to sctp_packet_pack > from sctp_packet_transmit, and add some comments, simplify the

Re: [PATCH net-next 0/3] tools lib bpf: Synchronize implementations

2016-11-02 Thread David Miller
From: Alexei Starovoitov Date: Tue, 1 Nov 2016 16:04:35 -0600 > I think these patches has to go through Arnaldo's perf tree, since > otherwise they will conflict with Wang's changes. Ok.

Re: [PATCH net-next 0/2] misc TC/flower changes

2016-11-02 Thread David Miller
From: Roi Dayan Date: Tue, 1 Nov 2016 16:08:27 +0200 > This series includes two small changes to the TC flower classifier. Series applied, thanks!

Re: [PATCH 00/12] Netfilter updates for net-next

2016-11-02 Thread David Miller
From: Pablo Neira Ayuso Date: Tue, 1 Nov 2016 22:26:21 +0100 > The following patchset contains Netfilter updates for your net-next > tree. This includes better integration with the routing subsystem for > nf_tables, explicit notrack support and smaller updates. More >

Re: [PATCH net] r8152: Fix broken RX checksums.

2016-11-02 Thread Mark Lord
On 16-10-31 04:14 AM, Hayes Wang wrote: The r8152 driver has been broken since (approx) 3.16.xx when support was added for hardware RX checksums on newer chip versions. Symptoms include random segfaults and silent data corruption over NFS. The hardware checksum logig does not work on the

net/dccp: null-ptr-deref in dccp_v4_rcv/selinux_socket_sock_rcv_skb

2016-11-02 Thread Andrey Konovalov
Hi, I've got the following error report while running the syzkaller fuzzer: IPv4: Attempt to release alive inet socket 880068e98940 kasan: CONFIG_KASAN_INLINE enabled kasan: GPF could be caused by NULL-ptr deref or user memory access general protection fault: [#1] SMP KASAN Modules

Re: [PATCH v5 3/7] net: phy: broadcom: Add BCM54810 PHY entry

2016-11-02 Thread Andrew Lunn
On Wed, Nov 02, 2016 at 01:08:04PM -0400, Jon Mason wrote: > The BCM54810 PHY requires some semi-unique configuration, which results > in some additional configuration in addition to the standard config. > Also, some users of the BCM54810 require the PHY lanes to be swapped. > Since there is no

Re: net/tcp: null-ptr-deref in __inet_lookup_listener/inet_exact_dif_match

2016-11-02 Thread Andrey Konovalov
Hi David, I'm able to reproduce it, so I'd be happy to test your fix. Thanks! On Wed, Nov 2, 2016 at 7:31 PM, David Ahern wrote: > On 11/2/16 11:21 AM, Eric Dumazet wrote: >> Thanks for your report. >> >> David, please take a look. >> >> TCP MD5 can call

Re: [PATCH v5 2/7] Documentation: devicetree: add PHY lane swap binding

2016-11-02 Thread Andrew Lunn
On Wed, Nov 02, 2016 at 01:08:03PM -0400, Jon Mason wrote: > Add the documentation for PHY lane swapping. This is a boolean entry to > notify the phy device drivers that the TX/RX lanes need to be swapped. > > Signed-off-by: Jon Mason Reviewed-by: Andrew Lunn

Re: [PATCH v5 4/7] Documentation: devicetree: net: add NS2 bindings to amac

2016-11-02 Thread Florian Fainelli
On 11/02/2016 10:08 AM, Jon Mason wrote: > Clean-up the documentation to the bgmac-amac driver, per suggestion by > Rob Herring, and add details for NS2 support. > > Signed-off-by: Jon Mason Reviewed-by: Florian Fainelli -- Florian

[mm PATCH v2 22/26] arch/xtensa: Add option to skip DMA sync as a part of mapping

2016-11-02 Thread Alexander Duyck
This change allows us to pass DMA_ATTR_SKIP_CPU_SYNC which allows us to avoid invoking cache line invalidation if the driver will just handle it via a sync_for_cpu or sync_for_device call. Cc: Max Filippov Signed-off-by: Alexander Duyck ---

Re: [PATCH v5 4/7] Documentation: devicetree: net: add NS2 bindings to amac

2016-11-02 Thread Jon Mason
On Wed, Nov 02, 2016 at 08:18:51PM +0300, Sergei Shtylyov wrote: > Hello. > > On 11/02/2016 08:08 PM, Jon Mason wrote: > > >Clean-up the documentation to the bgmac-amac driver, per suggestion by > >Rob Herring, and add details for NS2 support. > > > >Signed-off-by: Jon Mason

[mm PATCH v2 21/26] arch/tile: Add option to skip DMA sync as a part of map and unmap

2016-11-02 Thread Alexander Duyck
This change allows us to pass DMA_ATTR_SKIP_CPU_SYNC which allows us to avoid invoking cache line invalidation if the driver will just handle it via a sync_for_cpu or sync_for_device call. Cc: Chris Metcalf Signed-off-by: Alexander Duyck ---

[mm PATCH v2 11/26] arch/m68k: Add option to skip DMA sync as a part of mapping

2016-11-02 Thread Alexander Duyck
This change allows us to pass DMA_ATTR_SKIP_CPU_SYNC which allows us to avoid invoking cache line invalidation if the driver will just handle it later via a sync_for_cpu or sync_for_device call. Cc: Geert Uytterhoeven Cc: linux-m...@lists.linux-m68k.org Signed-off-by:

Re: net/tcp: null-ptr-deref in __inet_lookup_listener/inet_exact_dif_match

2016-11-02 Thread Eric Dumazet
On Wed, 2016-11-02 at 18:01 +0100, Andrey Konovalov wrote: > Hi, > > I've got the following error report while running the syzkaller fuzzer: > > general protection fault: [#1] SMP KASAN > Dumping ftrace buffer: >(ftrace buffer empty) > Modules linked in: > CPU: 0 PID: 648 Comm:

[mm PATCH v2 10/26] arch/hexagon: Add option to skip DMA sync as a part of mapping

2016-11-02 Thread Alexander Duyck
This change allows us to pass DMA_ATTR_SKIP_CPU_SYNC which allows us to avoid invoking cache line invalidation if the driver will just handle it later via a sync_for_cpu or sync_for_device call. Cc: Richard Kuo Cc: linux-hexa...@vger.kernel.org Signed-off-by: Alexander Duyck

Re: [PATCH net] ipv4: allow local fragmentation in ip_finish_output_gso()

2016-11-02 Thread Florian Westphal
Lance Richardson wrote: > Some configurations (e.g. geneve interface with default > MTU of 1500 over an ethernet interface with 1500 MTU) result > in the transmission of packets that exceed the configured MTU. > While this should be considered to be a "bad" configuration, >

  1   2   3   >