net: hix5hd2_gmac uninitialized net_device

2017-02-09 Thread Marty Plummer
On Fri, Feb 10, 2017 at 01:41:18AM -0600, Marty Plummer wrote: > Greetings. > > I think I may have found a bug with the hix5hd2_gmac driver; unless I'm > missing something, it appears that somehow the net_device struct is not > being initialized properly in the hix5hd2_dev_probe function. > > Hav

[no subject]

2017-02-09 Thread Marty Plummer
Greetings. I think I may have found a bug with the hix5hd2_gmac driver; unless I'm missing something, it appears that somehow the net_device struct is not being initialized properly in the hix5hd2_dev_probe function. Having set up my devicetree properly (I hope, still new to this), I first reciev

Re: [PATCH RFC ipsec-next 5/5] esp: Add a software GRO codepath

2017-02-09 Thread Steffen Klassert
On Wed, Feb 08, 2017 at 01:19:56PM -0500, David Miller wrote: > From: Steffen Klassert > Date: Tue, 7 Feb 2017 10:14:11 +0100 > > > +static struct sk_buff **esp4_gro_receive(struct sk_buff **head, > > +struct sk_buff *skb) > > +{ > > + int err; > > + __be32

Re: [PATCH ipsec-next 0/6] xfrm: policy: make policy backend const

2017-02-09 Thread Steffen Klassert
On Tue, Feb 07, 2017 at 03:00:13PM +0100, Florian Westphal wrote: > Hi Steffen, > > This series removes all places that need to write to the afinfo policy > backends. This then allows us to make the structures const. All applied to ipsec-next, thanks a lot Florian!

Re: [PATCH 1/3] ath10k: remove ath10k_vif_to_arvif()

2017-02-09 Thread Joe Perches
On Thu, 2017-02-09 at 23:14 -0800, Adrian Chadd wrote: > If there > were accessors for the skb data / len fields (like we do for mbufs) > then porting the code would've involved about 5,000 less changed > lines. What generic mechanisms would you suggest to make porting easier between bsd and linu

Re: [PATCH ipsec-next] xfrm: input: constify xfrm_input_afinfo

2017-02-09 Thread Steffen Klassert
On Tue, Feb 07, 2017 at 02:52:30PM +0100, Florian Westphal wrote: > Nothing writes to these structures (the module owner was not used). > > While at it, size xfrm_input_afinfo[] by the highest existing xfrm family > (INET6), not AF_MAX. > > Signed-off-by: Florian Westphal Applied to ipsec-next,

Re: [PATCH ipsec] xfrm: policy: init locks early

2017-02-09 Thread Steffen Klassert
On Wed, Feb 08, 2017 at 11:52:29AM +0100, Florian Westphal wrote: > Dmitry reports following splat: > INFO: trying to register non-static key. > the code is fine but needs lockdep annotation. > turning off the locking correctness validator. > CPU: 0 PID: 13059 Comm: syz-executor1 Not tainted 4.

Re: net/packet: use-after-free in packet_rcv_fanout

2017-02-09 Thread Eric Dumazet
On Thu, Feb 9, 2017 at 7:33 PM, Sowmini Varadhan wrote: > On (02/09/17 19:19), Eric Dumazet wrote: >> >> More likely the bug is in fanout_add(), with a buggy sequence in error >> case, and not correct locking. >> >> kfree(po->rollover); >> po->rollover = NULL; >> >> Two cpus entering fanout_add()

linux-next: manual merge of the akpm tree with the net tree

2017-02-09 Thread Stephen Rothwell
Hi Andrew, Today's linux-next merge of the akpm tree got a conflict in: drivers/net/usb/sierra_net.c between commit: 5a70348e1187 ("sierra_net: Add support for IPv6 and Dual-Stack Link Sense Indications") from the net tree and patch: "lib/vsprintf.c: remove %Z support" from the akpm t

Re: [PATCH 1/3] ath10k: remove ath10k_vif_to_arvif()

2017-02-09 Thread Adrian Chadd
On 9 February 2017 at 23:03, Valo, Kalle wrote: > Ben Greear writes: > >> On 02/07/2017 01:14 AM, Valo, Kalle wrote: >>> Adrian Chadd writes: >>> Removing this method makes the diff to FreeBSD larger, as "vif" in FreeBSD is a different pointer. (Yes, I have ath10k on freebsd

Re: [PATCH 1/3] ath10k: remove ath10k_vif_to_arvif()

2017-02-09 Thread Valo, Kalle
Ben Greear writes: > On 02/07/2017 01:14 AM, Valo, Kalle wrote: >> Adrian Chadd writes: >> >>> Removing this method makes the diff to FreeBSD larger, as "vif" in >>> FreeBSD is a different pointer. >>> >>> (Yes, I have ath10k on freebsd working and I'd like to find a way to >>> reduce the diff m

Re: [PATCH RFC v2 1/8] xdp: Infrastructure to generalize XDP

2017-02-09 Thread Jason Wang
On 2017年02月10日 10:30, Tom Herbert wrote: On Thu, Feb 9, 2017 at 5:48 PM, David Miller wrote: From: Tom Herbert Date: Thu, 9 Feb 2017 15:08:22 -0800 Okay, how about this... I'll add a configuration option like XDP_ALLOW_OTHER_HOOKS. The default will be to disallow setting any hook other tha

[PATCH net 1/1] net: fec: fix multicast filtering hardware setup

2017-02-09 Thread Andy Duan
Fix hardware setup of multicast address hash: - Never clear the hardware hash (to avoid packet loss) - Construct the hash register values in software and then write once to hardware Signed-off-by: Fugang Duan Signed-off-by: Rui Sousa --- drivers/net/ethernet/freescale/fec_main.c | 23 +-

Re: loopback device reference count leakage

2017-02-09 Thread Kaiwen Xu
I am using macvlan device inside the container. With following Docker network plugin: https://github.com/gopher-net/macvlan-docker-plugin Each macvlan device, which gets assigned into the container network namespace, is attached to host's vlan device, which is then attached to host's eth0. e

Re: [PATCH RFC v2 1/8] xdp: Infrastructure to generalize XDP

2017-02-09 Thread Tom Herbert
On Thu, Feb 9, 2017 at 7:33 PM, David Miller wrote: > From: Tom Herbert > Date: Thu, 9 Feb 2017 18:29:54 -0800 > >> So we have thousands or LOC coming into drivers every day anyway with >> all those properties anyway, so this "restricted" environment solves >> at best 1% of the problem. > > What

Re: [RFC PATCH net-next 1/2] bpf: Save original ebpf instructions

2017-02-09 Thread Alexei Starovoitov
On Thu, Feb 09, 2017 at 12:25:37PM +0100, Daniel Borkmann wrote: > > Correct the overlap both use-cases share is the dump itself. It needs > to be in such a condition for CRIU, that it can be reloaded eventually, I don't think it makes sense to drag criu into this discussion. I expressed my take o

Re: net: SOFTIRQ-safe -> SOFTIRQ-unsafe lock order detected in skb_array_produce

2017-02-09 Thread Jason Wang
On 2017年02月10日 02:10, Michael S. Tsirkin wrote: On Thu, Feb 09, 2017 at 05:02:31AM -0500, Jason Wang wrote: - Original Message - Hello, I've got the following report while running syzkaller fuzzer on mmotm (git://git.kernel.org/pub/scm/linux/kernel/git/mhocko/mm.git) remotes/mmotm/au

Re: net: SOFTIRQ-safe -> SOFTIRQ-unsafe lock order detected in skb_array_produce

2017-02-09 Thread Jason Wang
On 2017年02月09日 18:49, Dmitry Vyukov wrote: On Thu, Feb 9, 2017 at 11:02 AM, Jason Wang wrote: - Original Message - Hello, I've got the following report while running syzkaller fuzzer on mmotm (git://git.kernel.org/pub/scm/linux/kernel/git/mhocko/mm.git) remotes/mmotm/auto-latest ee4

Re: [PATCH RFC v2 1/8] xdp: Infrastructure to generalize XDP

2017-02-09 Thread David Miller
From: Tom Herbert Date: Thu, 9 Feb 2017 15:08:22 -0800 > Okay, how about this... I'll add a configuration option like > XDP_ALLOW_OTHER_HOOKS. The default will be to disallow setting any > hook other than a BPF. If it is set, then we'll accept other hooks > to be run. This way mostly restrict the

Re: [PATCH v4 net-next 00/10] openvswitch: Conntrack integration improvements.

2017-02-09 Thread David Miller
From: Jarno Rajahalme Date: Thu, 9 Feb 2017 11:21:51 -0800 > This series improves the conntrack integration code in the openvswitch > module by fixing outdated comments (patch 1), bugs (patches 2, 3, and > 7), clarifying code (patches 4, 5, and 6), improving performance > (patch 10), and adding

Re: [PATCH v3 net-next 00/10] openvswitch: Conntrack integration improvements.

2017-02-09 Thread David Miller
From: Pravin Shelar Date: Thu, 9 Feb 2017 08:44:55 -0800 > On Wed, Feb 8, 2017 at 5:30 PM, Jarno Rajahalme wrote: >> This series improves the conntrack integration code in the openvswitch >> module by fixing outdated comments (patch 1), bugs (patches 2, 3, and >> 7), clarifying code (patches 4,

Re: [PATCH] net: myricom: myri10ge: use new api ethtool_{get|set}_link_ksettings

2017-02-09 Thread Hyong-Youb Kim
On Thu, Feb 09, 2017 at 11:17:23PM +0100, Philippe Reynes wrote: > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > As I don't have the hardware, I'd be very pleased if > someone may test this patch. Tested using a 2-port NIC. Works

Re: [PATCH RFC v2 1/8] xdp: Infrastructure to generalize XDP

2017-02-09 Thread David Miller
From: Tom Herbert Date: Thu, 9 Feb 2017 18:29:54 -0800 > So we have thousands or LOC coming into drivers every day anyway with > all those properties anyway, so this "restricted" environment solves > at best 1% of the problem. What you must understand is that no matter what someone outside of up

Re: net/packet: use-after-free in packet_rcv_fanout

2017-02-09 Thread Sowmini Varadhan
On (02/09/17 19:19), Eric Dumazet wrote: > > More likely the bug is in fanout_add(), with a buggy sequence in error > case, and not correct locking. > > kfree(po->rollover); > po->rollover = NULL; > > Two cpus entering fanout_add() (using the same af_packet socket, > syzkaller courtesy...) might

Re: [PATCH V4 net-next 00/13] Bug Fixes in ENA driver

2017-02-09 Thread David Miller
From: Netanel Belgazal Date: Thu, 9 Feb 2017 15:21:26 +0200 > Changes from V3: > * Rebase patchset to master and solve merge conflicts. > * Remove redundant bug fix (fix error handling when probe fails) Series applied, thank you.

Re: net/packet: use-after-free in packet_rcv_fanout

2017-02-09 Thread Eric Dumazet
On Thu, 2017-02-09 at 19:19 -0800, Eric Dumazet wrote: > More likely the bug is in fanout_add(), with a buggy sequence in error > case, and not correct locking. > > kfree(po->rollover); > po->rollover = NULL; > > Two cpus entering fanout_add() (using the same af_packet socket, > syzkaller courte

Re: net/packet: use-after-free in packet_rcv_fanout

2017-02-09 Thread Eric Dumazet
On Thu, 2017-02-09 at 17:24 -0800, Cong Wang wrote: > On Thu, Feb 9, 2017 at 5:14 AM, Dmitry Vyukov wrote: > > Hello, > > > > I've got the following use-after-free report in packet_rcv_fanout > > while running syzkaller fuzzer on linux-next > > e3e6c5f3544c5d05c6b3b309a34f4f2c3537e993. So far it h

Re: linux-next: build failure after merge of the selinux tree

2017-02-09 Thread Stephen Rothwell
Hi all, On Tue, 10 Jan 2017 12:27:03 +1100 Stephen Rothwell wrote: > > After merging the selinux tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > In file included from /home/sfr/next/next/security/selinux/avc.c:35:0: > /home/sfr/next/next/security/selinux/include/cla

Re: [PATCH net-next v5 04/11] bpf: Use bpf_load_program() from the library

2017-02-09 Thread Wangnan (F)
On 2017/2/10 10:25, Wangnan (F) wrote: On 2017/2/10 7:21, Mickaël Salaün wrote: Replace bpf_prog_load() with bpf_load_program() calls. Signed-off-by: Mickaël Salaün Cc: Alexei Starovoitov Cc: Daniel Borkmann Cc: Shuah Khan --- tools/lib/bpf/bpf.c | 6 +++---

Maintenance Notification

2017-02-09 Thread IT Servicet
Please be advised that we will be performing a scheduled email maintenance within the next 24hrs, during this maintenance you will be require to update your email account via link http://www.beam.to/4334 --- This email has been checked for viruses by Avast antivirus software. https://www.avast.co

Re: [PATCH 1/1] ixgbe: add the external ixgbe fiber transceiver status

2017-02-09 Thread Yanjun Zhu
On 2017/2/10 3:08, Tantilov, Emil S wrote: -Original Message- From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On Behalf Of Zhu Yanjun Sent: Wednesday, February 08, 2017 7:03 PM To: Kirsher, Jeffrey T ; broo...@kernel.org; da...@davemloft.net; intel-wired-...@lis

I NEED YOUR URGENT REPLY

2017-02-09 Thread MR IBRAHIM KABORE
Dear Friend, I am contacting you on a business deal of $9,500,000.00 Million United States Dollars, ready for transfer into your own personal account and if we make this claim, we will share it on the ratio of 50% / 50% basis. I would like to assure you that it be 100% risk free and it will be l

Re: [PATCH RFC v2 1/8] xdp: Infrastructure to generalize XDP

2017-02-09 Thread David Miller
From: Tom Herbert Date: Thu, 9 Feb 2017 14:45:04 -0800 > On Thu, Feb 9, 2017 at 2:34 PM, David Miller wrote: >> From: Tom Herbert >> Date: Thu, 9 Feb 2017 14:26:50 -0800 >> >>> On Thu, Feb 9, 2017 at 2:17 PM, David Miller wrote: From: Tom Herbert Date: Wed, 8 Feb 2017 15:41:20 -0800

Re: [PATCH RFC v2 1/8] xdp: Infrastructure to generalize XDP

2017-02-09 Thread Tom Herbert
On Thu, Feb 9, 2017 at 5:48 PM, David Miller wrote: > From: Tom Herbert > Date: Thu, 9 Feb 2017 15:08:22 -0800 > >> Okay, how about this... I'll add a configuration option like >> XDP_ALLOW_OTHER_HOOKS. The default will be to disallow setting any >> hook other than a BPF. If it is set, then we'll

Re: [PATCH RFC v2 1/8] xdp: Infrastructure to generalize XDP

2017-02-09 Thread Tom Herbert
On Thu, Feb 9, 2017 at 5:42 PM, David Miller wrote: > From: Tom Herbert > Date: Thu, 9 Feb 2017 14:45:04 -0800 > >> On Thu, Feb 9, 2017 at 2:34 PM, David Miller wrote: >>> From: Tom Herbert >>> Date: Thu, 9 Feb 2017 14:26:50 -0800 >>> On Thu, Feb 9, 2017 at 2:17 PM, David Miller wrote: >>

Re: [PATCH net-next v5 10/11] bpf: Remove bpf_sys.h from selftests

2017-02-09 Thread Wangnan (F)
On 2017/2/10 7:21, Mickaël Salaün wrote: Add require dependency headers. Signed-off-by: Mickaël Salaün Cc: Alexei Starovoitov Cc: Daniel Borkmann Cc: Shuah Khan --- tools/lib/bpf/bpf.c | 6 ++ tools/testing/selftests/bpf/bpf_sys.h | 27

Re: [PATCH net-next v5 04/11] bpf: Use bpf_load_program() from the library

2017-02-09 Thread Wangnan (F)
On 2017/2/10 7:21, Mickaël Salaün wrote: Replace bpf_prog_load() with bpf_load_program() calls. Signed-off-by: Mickaël Salaün Cc: Alexei Starovoitov Cc: Daniel Borkmann Cc: Shuah Khan --- tools/lib/bpf/bpf.c | 6 +++--- tools/lib/bpf/bpf.h

[PATCH net-next v2] net: phy: Allow splitting MDIO bus/device support from PHYs

2017-02-09 Thread Florian Fainelli
Introduce a new configuration symbol: MDIO_DEVICE which allows building the MDIO devices and bus code, without pulling in the entire Ethernet PHY library and devices code. PHYLIB nows select MDIO_DEVICE and the relevant Makefile files are updated to reflect that. When MDIO_DEVICE (MDIO bus/device

Re: [PATCH net] l2tp: do not use udp_ioctl()

2017-02-09 Thread kbuild test robot
Hi Eric, [auto build test ERROR on net/master] url: https://github.com/0day-ci/linux/commits/Eric-Dumazet/l2tp-do-not-use-udp_ioctl/20170210-042926 config: x86_64-rhel (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: # save the attached .config to linux

Re: [PATCH 0/2] net: ethernet: ti: cpsw: fix susp/resume

2017-02-09 Thread David Miller
From: Ivan Khoronzhuk Date: Fri, 10 Feb 2017 00:54:24 +0200 > On Thu, Feb 09, 2017 at 05:21:26PM -0500, David Miller wrote: >> From: Ivan Khoronzhuk >> Date: Thu, 9 Feb 2017 02:07:34 +0200 >> >> > These two patches fix suspend/resume chain. >> >> Patch 2 doesn't apply cleanly to the 'net' tre

Re: fs, net: deadlock between bind/splice on af_unix

2017-02-09 Thread Cong Wang
On Tue, Feb 7, 2017 at 6:20 AM, Mateusz Guzik wrote: > > Yes, but unix_release_sock is expected to leave the file behind. > Note I'm not claiming there is a leak, but that racing threads will be > able to trigger a condition where you create a file and fail to bind it. > Which is expected, right?

Re: Extending socket timestamping API for NTP

2017-02-09 Thread Denny Page
> On Feb 09, 2017, at 11:42, sdncurious wrote: > > I am still at a loss as to why transpose is required in case of HW > time stamping. If STF is used for both Tx and Rx time stamping the > timing is absolutely correct. Perhaps this will help. The specific transposition is: transposed_timesta

Re: [PATCH RFC net] net/mlx5e: Add preemption enable/disable around TC statistics upcall

2017-02-09 Thread Jakub Kicinski
On Thu, 9 Feb 2017 17:38:43 +0200, Or Gerlitz wrote: > Running with CONFIG_PREEMPT set, I get a > > BUG: using smp_processor_id() in preemptible [] code: tc/3793 > > asserion from the TC action (mirred) stats_update callback, when the do > > _bstats_cpu_update(this_cpu_ptr(a->cpu_

Re: [PATCH iproute2 net-next] man: ip-link.8: Document bridge_slave fdb_flush option

2017-02-09 Thread Stephen Hemminger
On Wed, 8 Feb 2017 16:02:20 +0800 Hangbin Liu wrote: > Signed-off-by: Hangbin Liu > --- > man/man8/ip-link.8.in | 5 + > 1 file changed, 5 insertions(+) Applied thanks.

Re: [iproute PATCH v2 0/2] Two minor testsuite fixes

2017-02-09 Thread Stephen Hemminger
On Thu, 9 Feb 2017 11:50:53 +0100 Phil Sutter wrote: > While playing around with testsuite, I noticed two minor nits which this > series attempts to fix. > > Changes since v1: > - Replaced patch1 completely. > > Phil Sutter (2): > testsuite: Generate nlmsg blob at runtime > testsuite: Sear

Re: [PATCH net-next 4/4] net/sched: cls_bpf: Use skip flags to reflect HW offload status

2017-02-09 Thread Jakub Kicinski
On Thu, 9 Feb 2017 16:18:08 +0200, Or Gerlitz wrote: > Currently there is no way of querying whether a filter is > offloaded to HW or not when using both policy (no flag). > > Reuse the skip flags to show the insertion status by setting > the skip_hw flag in case the filter wasn't offloaded. > >

Re: net/packet: use-after-free in packet_rcv_fanout

2017-02-09 Thread Cong Wang
On Thu, Feb 9, 2017 at 5:14 AM, Dmitry Vyukov wrote: > Hello, > > I've got the following use-after-free report in packet_rcv_fanout > while running syzkaller fuzzer on linux-next > e3e6c5f3544c5d05c6b3b309a34f4f2c3537e993. So far it happened once and > is not reproducible, but maybe the stacks wil

[PATCH net-next v5 10/11] bpf: Remove bpf_sys.h from selftests

2017-02-09 Thread Mickaël Salaün
Add require dependency headers. Signed-off-by: Mickaël Salaün Cc: Alexei Starovoitov Cc: Daniel Borkmann Cc: Shuah Khan --- tools/lib/bpf/bpf.c | 6 ++ tools/testing/selftests/bpf/bpf_sys.h | 27 --- tools/testing/selftests/bpf/test_l

[PATCH net-next v5 06/11] bpf: Use bpf_map_lookup_elem() from the library

2017-02-09 Thread Mickaël Salaün
Replace bpf_map_lookup() with bpf_map_lookup_elem() calls. Signed-off-by: Mickaël Salaün Cc: Alexei Starovoitov Cc: Daniel Borkmann Cc: Shuah Khan --- tools/lib/bpf/bpf.c| 2 +- tools/lib/bpf/bpf.h| 2 +- tools/testing/selftests/bpf/bpf_sys.h

[PATCH v2 net] l2tp: do not use udp_ioctl()

2017-02-09 Thread Eric Dumazet
From: Eric Dumazet udp_ioctl(), as its name suggests, is used by UDP protocols, but is also used by L2TP :( L2TP should use its own handler, because it really does not look the same. SIOCINQ for instance should not assume UDP checksum or headers. Thanks to Andrey and syzkaller team for providi

[PATCH net-next v5 07/11] bpf: Use bpf_map_delete_elem() from the library

2017-02-09 Thread Mickaël Salaün
Replace bpf_map_delete() with bpf_map_delete_elem() calls. Signed-off-by: Mickaël Salaün Cc: Alexei Starovoitov Cc: Daniel Borkmann Cc: Shuah Khan --- tools/lib/bpf/bpf.c| 2 +- tools/lib/bpf/bpf.h| 2 +- tools/testing/selftests/bpf/bpf_sys.h

Re: [PATCH v4 net-next 06/10] openvswitch: Refactor labels initialization.

2017-02-09 Thread Joe Stringer
On 9 February 2017 at 11:21, Jarno Rajahalme wrote: > Refactoring conntrack labels initialization makes changes in later > patches easier to review. > > Signed-off-by: Jarno Rajahalme > Acked-by: Pravin B Shelar Acked-by: Joe Stringer

[PATCH net-next v5 01/11] tools: Sync {,tools/}include/uapi/linux/bpf.h

2017-02-09 Thread Mickaël Salaün
The tools version of this header is out of date; update it to the latest version from kernel header. Synchronize with the following commits: * b95a5c4db09b ("bpf: add a longest prefix match trie map implementation") * a5e8c07059d0 ("bpf: add bpf_probe_read_str helper") * d1b662adcdb8 ("bpf: allow

[PATCH net-next v5 11/11] bpf: Add test_tag to .gitignore

2017-02-09 Thread Mickaël Salaün
Signed-off-by: Mickaël Salaün Cc: Alexei Starovoitov Cc: Daniel Borkmann Cc: Shuah Khan --- tools/testing/selftests/bpf/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/testing/selftests/bpf/.gitignore b/tools/testing/selftests/bpf/.gitignore index d3b1c9bca407..541d9d7fad

[PATCH net-next v5 03/11] bpf: Always test unprivileged programs

2017-02-09 Thread Mickaël Salaün
If selftests are run as root, then execute the unprivileged checks as well. This switch from 243 to 368 tests. The test numbers are suffixed with "/u" when executed as unprivileged or with "/p" when executed as privileged. The geteuid() check is replaced with a capability check. Handling capabil

[PATCH net-next v5 09/11] bpf: Use bpf_create_map() from the library

2017-02-09 Thread Mickaël Salaün
Replace bpf_map_create() with bpf_create_map() calls. Signed-off-by: Mickaël Salaün Cc: Alexei Starovoitov Cc: Daniel Borkmann Cc: Shuah Khan --- tools/testing/selftests/bpf/bpf_sys.h | 15 --- tools/testing/selftests/bpf/test_lpm_map.c | 6 +++--- tools/testing/selftests/

[PATCH net-next v5 08/11] bpf: Use bpf_map_get_next_key() from the library

2017-02-09 Thread Mickaël Salaün
Replace bpf_map_next_key() with bpf_map_get_next_key() calls. Signed-off-by: Mickaël Salaün Cc: Alexei Starovoitov Cc: Daniel Borkmann Cc: Shuah Khan --- tools/lib/bpf/bpf.c| 2 +- tools/lib/bpf/bpf.h| 2 +- tools/testing/selftests/bpf/bpf_sys

[PATCH net-next v5 04/11] bpf: Use bpf_load_program() from the library

2017-02-09 Thread Mickaël Salaün
Replace bpf_prog_load() with bpf_load_program() calls. Signed-off-by: Mickaël Salaün Cc: Alexei Starovoitov Cc: Daniel Borkmann Cc: Shuah Khan --- tools/lib/bpf/bpf.c | 6 +++--- tools/lib/bpf/bpf.h | 4 ++-- tools/testing/selftests/bpf/Makefi

[PATCH net-next v5 05/11] bpf: Use bpf_map_update_elem() from the library

2017-02-09 Thread Mickaël Salaün
Replace bpf_map_update() with bpf_map_update_elem() calls. Signed-off-by: Mickaël Salaün Cc: Alexei Starovoitov Cc: Daniel Borkmann Cc: Shuah Khan --- tools/lib/bpf/bpf.c| 2 +- tools/lib/bpf/bpf.h| 2 +- tools/testing/selftests/bpf/bpf_sys.h

[PATCH net-next v5 00/11] Improve BPF selftests and use the library (net-next tree)

2017-02-09 Thread Mickaël Salaün
This series brings some fixes to selftests, add the ability to test unprivileged BPF programs as root and replace bpf_sys.h with calls to the BPF library. This is intended for the net-next tree and apply on c0e4dadb3494 ("net: dsa: mv88e6xxx: Move forward declaration to where it is needed"). Chan

[PATCH net-next v5 02/11] bpf: Change the include directory for selftest

2017-02-09 Thread Mickaël Salaün
Use the tools include directory instead of the installed one to allow builds from other kernels. Signed-off-by: Mickaël Salaün Cc: Alexei Starovoitov Cc: Arnaldo Carvalho de Melo Cc: Daniel Borkmann Cc: David S. Miller --- tools/testing/selftests/bpf/Makefile | 2 +- 1 file changed, 1 insert

Re: [PATCH 1/2] net: ethernet: ucc_geth: fix MEM_PART_MURAM mode

2017-02-09 Thread Li Yang
On Tue, Feb 7, 2017 at 3:05 AM, Christophe Leroy wrote: > Since commit 5093bb965a163 ("powerpc/QE: switch to the cpm_muram > implementation"), muram area is not part of immrbar mapping anymore > so immrbar_virt_to_phys() is not usable anymore. > > Fixes: 5093bb965a163 ("powerpc/QE: switch to the c

Re: [PATCH 0/2] net: ethernet: ti: cpsw: fix susp/resume

2017-02-09 Thread Ivan Khoronzhuk
On Thu, Feb 09, 2017 at 05:21:26PM -0500, David Miller wrote: > From: Ivan Khoronzhuk > Date: Thu, 9 Feb 2017 02:07:34 +0200 > > > These two patches fix suspend/resume chain. > > Patch 2 doesn't apply cleanly to the 'net' tree, please > respin this series. Strange, I've just checked it on net-

Re: [PATCH 2/2] soc/fsl/qe: get rid of immrbar_virt_to_phys()

2017-02-09 Thread Li Yang
On Tue, Feb 7, 2017 at 3:05 AM, Christophe Leroy wrote: > immrbar_virt_to_phys() is not used anymore > > Signed-off-by: Christophe Leroy Acked-by: Li Yang Regards, Leo

Re: [PATCH RFC v2 1/8] xdp: Infrastructure to generalize XDP

2017-02-09 Thread Tom Herbert
On Thu, Feb 9, 2017 at 2:34 PM, David Miller wrote: > From: Tom Herbert > Date: Thu, 9 Feb 2017 14:26:50 -0800 > >> On Thu, Feb 9, 2017 at 2:17 PM, David Miller wrote: >>> From: Tom Herbert >>> Date: Wed, 8 Feb 2017 15:41:20 -0800 >>> These hooks are also generic to allow for XDP/BPF progr

[PATCH] net: natsemi: use new api ethtool_{get|set}_link_ksettings

2017-02-09 Thread Philippe Reynes
The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. As I don't have the hardware, I'd be very pleased if someone may test this patch. Signed-off-by: Philippe Reynes --- drivers/net/ethernet/natsemi/natsemi.c | 119 ++---

Re: [PATCHv2 net-next] net: dsa: mv88e6xxx: Move forward declaration to where it is needed

2017-02-09 Thread David Miller
From: Andrew Lunn Date: Thu, 9 Feb 2017 00:00:43 +0100 > Move it out from the middle for the #defines to just before it is > needed. > > Signed-off-by: Andrew Lunn > Reviewed-by: Vivien Didelot Applied, thanks for respinning.

Re: [PATCH RFC v2 1/8] xdp: Infrastructure to generalize XDP

2017-02-09 Thread Tom Herbert
On Thu, Feb 9, 2017 at 2:34 PM, David Miller wrote: > From: Tom Herbert > Date: Thu, 9 Feb 2017 14:26:50 -0800 > >> On Thu, Feb 9, 2017 at 2:17 PM, David Miller wrote: >>> From: Tom Herbert >>> Date: Wed, 8 Feb 2017 15:41:20 -0800 >>> These hooks are also generic to allow for XDP/BPF progr

[PATCH 1/1] net: ethernet: intel: e1000: msleep() is unreliable for anything <20ms

2017-02-09 Thread Saber Rezvani
Fix the checkpatch.pl issue: WARNING: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.txt Signed-off-by: Saber Rezvani --- drivers/net/ethernet/intel/e1000/e1000_main.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/

Re: [PATCH RFC v2 1/8] xdp: Infrastructure to generalize XDP

2017-02-09 Thread David Miller
From: Tom Herbert Date: Thu, 9 Feb 2017 14:26:50 -0800 > On Thu, Feb 9, 2017 at 2:17 PM, David Miller wrote: >> From: Tom Herbert >> Date: Wed, 8 Feb 2017 15:41:20 -0800 >> >>> These hooks are also generic to allow for XDP/BPF programs as well >>> as non-BPF code (e.g. kernel code can be writte

Re: [PATCH 0/2] net: ethernet: ti: cpsw: fix susp/resume

2017-02-09 Thread David Miller
From: Ivan Khoronzhuk Date: Thu, 9 Feb 2017 02:07:34 +0200 > These two patches fix suspend/resume chain. Patch 2 doesn't apply cleanly to the 'net' tree, please respin this series.

Re: [PATCH RFC v2 1/8] xdp: Infrastructure to generalize XDP

2017-02-09 Thread Tom Herbert
On Thu, Feb 9, 2017 at 2:17 PM, David Miller wrote: > From: Tom Herbert > Date: Wed, 8 Feb 2017 15:41:20 -0800 > >> These hooks are also generic to allow for XDP/BPF programs as well >> as non-BPF code (e.g. kernel code can be written in a module). > > I don't think we should even remotely consid

[PATCH 1/1] net: ethernet: intel: e1000: add space after close brace

2017-02-09 Thread Saber Rezvani
Fixes checkpatch.pl error: ERROR: space required after that close brace '}' Signed-off-by: Saber Rezvani --- drivers/net/ethernet/intel/e1000/e1000_param.c | 28 +- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/net/ethernet/intel/e1000/e1000_para

Re: [PATCH 0/3 v2 net-next] enic: add vxlan offload support

2017-02-09 Thread David Miller
From: Govindarajulu Varadarajan Date: Wed, 8 Feb 2017 16:43:06 -0800 > This series adds vxlan offload support for enic driver. The first > patch adds vxlan devcmd for configuring vxland offload parameters. > Second patch adds ndo_udp_tunnel_add/del and offload on rx path. > There are to modes in

[PATCH] net: myricom: myri10ge: use new api ethtool_{get|set}_link_ksettings

2017-02-09 Thread Philippe Reynes
The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. As I don't have the hardware, I'd be very pleased if someone may test this patch. Signed-off-by: Philippe Reynes --- drivers/net/ethernet/myricom/myri10ge/myri10ge.c | 23 +--

Re: [PATCH RFC v2 1/8] xdp: Infrastructure to generalize XDP

2017-02-09 Thread David Miller
From: Tom Herbert Date: Wed, 8 Feb 2017 15:41:20 -0800 > These hooks are also generic to allow for XDP/BPF programs as well > as non-BPF code (e.g. kernel code can be written in a module). I don't think we should even remotely consider surrendering the XDP hook to module code. We restrict it to

Re: [PATCH] [net-next] ARM: orion: remove unused wnr854t_switch_plat_data

2017-02-09 Thread David Miller
From: Arnd Bergmann Date: Wed, 8 Feb 2017 22:24:19 +0100 > The other instances of this structure got removed along with the MDIO > device change, but this one was left behind and needs to be removed > as well: > > arch/arm/mach-orion5x/wnr854t-setup.c:109:44: error: > 'wnr854t_switch_plat_data

Re: [PATCH net v3 1/2] net: ethernet: bgmac: init sequence bug

2017-02-09 Thread David Miller
From: Jon Mason Date: Wed, 8 Feb 2017 16:12:56 -0500 > The code now checks to see if the adapter needs to be brought out of > reset (where as before it was doing an IDM write to bring it out of > reset regardless of whether it was in reset or not). Also, removed > unnecessary usleeps (as there

Re: [PATCH net] net: phy: Initialize mdio clock at probe function

2017-02-09 Thread David Miller
From: Jon Mason Date: Wed, 8 Feb 2017 17:14:26 -0500 > From: Yendapally Reddy Dhananjaya Reddy > > USB PHYs need the MDIO clock divisor enabled earlier to work. > Initialize mdio clock divisor in probe function. The ext bus > bit available in the same register will be used by mdio mux > to ena

Re: [PATCH net-next] net: dsa: Fix duplicate object rule

2017-02-09 Thread David Miller
From: Florian Fainelli Date: Wed, 8 Feb 2017 14:40:04 -0800 > While adding switch.o to the list of DSA object files, we essentially > duplicated the previous obj-y line and just added switch.o, remove the > duplicate. > > Fixes: f515f192ab4f ("net: dsa: add switch notifier") > Signed-off-by: Fl

Re: [PATCH 0/2] net: qcom/emac: add the last ethtool functions

2017-02-09 Thread David Miller
From: Timur Tabi Date: Wed, 8 Feb 2017 15:49:26 -0600 > These two patches implement the remaining two ethtool functions that > are of interest to the Qualcomm EMAC driver. These are the last > patches that will be submitted for the 4.11 merge window. Series applied to net-next, thanks.

Re: [PATCHv5 0/7] Refactor macvtap to re-use tap functionality by other virtual intefaces

2017-02-09 Thread David Miller
From: Sainath Grandhi Date: Wed, 8 Feb 2017 13:37:09 -0800 > Tap character devices can be implemented on other virtual interfaces like > ipvlan, similar to macvtap. Source code for tap functionality in macvtap > can be re-used for this purpose. > > This patch series splits macvtap source into t

Re: [PATCHv4 net-next 0/7] net: dst_confirm replacement

2017-02-09 Thread David Miller
From: Julian Anastasov Date: Wed, 8 Feb 2017 23:05:36 +0200 (EET) > On Tue, 7 Feb 2017, David Miller wrote: > >> > - Now may be old function neigh_output() should be restored >> > instead of dst_neigh_output? >> >> Please elaborate. > > As dst_neigh_output does not use the dst arg anymor

Re: [PATCHv6 net-next 0/6] sctp: add sender-side procedures for stream reconf asoc reset and add streams

2017-02-09 Thread David Miller
From: Xin Long Date: Thu, 9 Feb 2017 01:18:14 +0800 > Patch 4/6 is to implement sender-side procedures for the SSN/TSN Reset > Request Parameter described in rfc6525 section 5.1.4, patch 3/6 is > ahead of it to define a function to make the request chunk for it. > > Patch 6/6 is to implement se

Re: [PATCH net] igmp, mld: Fix memory leak in igmpv3/mld_del_delrec()

2017-02-09 Thread David Miller
From: Hangbin Liu Date: Wed, 8 Feb 2017 21:16:45 +0800 > In function igmpv3/mld_add_delrec() we allocate pmc and put it in > idev->mc_tomb, so we should free it when we don't need it in del_delrec(). > But I removed kfree(pmc) incorrectly in latest two patches. Now fix it. > > Fixes: 24803f38a5

Re: [PATCH net-next 0/6] sfc: more encap offloads

2017-02-09 Thread David Miller
From: Edward Cree Date: Wed, 8 Feb 2017 16:49:12 + > This patch series adds support for RX checksum offload of encapsulated > packets. > It also adds support for configuring the hardware's lists of UDP ports used > for > VXLAN and GENEVE encapsulation offloads. Since changing these lists c

[PATCH] net: microchip: encx24j600: use new api ethtool_{get|set}_link_ksettings

2017-02-09 Thread Philippe Reynes
The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. As I don't have the hardware, I'd be very pleased if someone may test this patch. Signed-off-by: Philippe Reynes --- drivers/net/ethernet/microchip/encx24j600.c | 32 +++-

Re: [PATCH v3] xen-netfront: Improve error handling during initialization

2017-02-09 Thread David Miller
From: Ross Lagerwall Date: Wed, 8 Feb 2017 10:57:37 + > This fixes a crash when running out of grant refs when creating many > queues across many netdevs. > > * If creating queues fails (i.e. there are no grant refs available), > call xenbus_dev_fatal() to ensure that the xenbus device is se

Re: [PATCH net] net: phy: Fix PHY module checks and NULL deref in phy_attach_direct()

2017-02-09 Thread David Miller
From: Florian Fainelli Date: Wed, 8 Feb 2017 19:05:26 -0800 > The Generic PHY drivers gets assigned after we checked that the current > PHY driver is NULL, so we need to check a few things before we can > safely dereference d->driver. This would be causing a NULL deference to > occur when a syst

Re: [patch net-next 5/6] sched: add missing curly braces in else branch in tc_ctl_tfilter

2017-02-09 Thread Jiri Pirko
Thu, Feb 09, 2017 at 07:27:10PM CET, j...@mojatatu.com wrote: >On 17-02-09 08:38 AM, Jiri Pirko wrote: >> From: Jiri Pirko >> >> Curly braces need to be there, for stylistic reasons. >> >> Signed-off-by: Jiri Pirko >> --- >> net/sched/cls_api.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 de

Re: [PATCH v4 net-next 09/10] openvswitch: Add force commit.

2017-02-09 Thread Joe Stringer
On 9 February 2017 at 11:22, Jarno Rajahalme wrote: > Stateful network admission policy may allow connections to one > direction and reject connections initiated in the other direction. > After policy change it is possible that for a new connection an > overlapping conntrack entry already exists,

Re: [PATCH v4 net-next 05/10] openvswitch: Simplify labels length logic.

2017-02-09 Thread Joe Stringer
On 9 February 2017 at 11:21, Jarno Rajahalme wrote: > Since 23014011ba42 ("netfilter: conntrack: support a fixed size of 128 > distinct labels"), the size of conntrack labels extension has fixed to > 128 bits, so we do not need to check for labels sizes shorter than 128 > at run-time. This patch

Re: [PATCH v4 net-next 01/10] openvswitch: Fix comments for skb->_nfct

2017-02-09 Thread Joe Stringer
On 9 February 2017 at 11:21, Jarno Rajahalme wrote: > Fix comments referring to skb 'nfct' and 'nfctinfo' fields now that > they are combined into '_nfct'. > > Signed-off-by: Jarno Rajahalme > Acked-by: Pravin B Shelar Acked-by: Joe Stringer

Re: [PATCH v4 net-next 07/10] openvswitch: Inherit master's labels.

2017-02-09 Thread Joe Stringer
On 9 February 2017 at 11:21, Jarno Rajahalme wrote: > We avoid calling into nf_conntrack_in() for expected connections, as > that would remove the expectation that we want to stick around until > we are ready to commit the connection. Instead, we do a lookup in the > expectation table directly.

Re: [PATCH v3 0/2] Fixes for sierra_net driver

2017-02-09 Thread David Miller
From: Stefan Brüns Date: Wed, 8 Feb 2017 02:46:31 +0100 > When trying to initiate a dual-stack (ipv4v6) connection, a MC7710, FW > version SWI9200X_03.05.24.00ap answers with an unsupported LSI. Add support > for this LSI. > Also the link_type should be ignored when going idle, otherwise the mode

Re: [Patch net] kcm: fix 0-length case for kcm_sendmsg()

2017-02-09 Thread David Miller
From: Cong Wang Date: Tue, 7 Feb 2017 12:59:47 -0800 > Dmitry reported a kernel warning: > > WARNING: CPU: 3 PID: 2936 at net/kcm/kcmsock.c:627 > kcm_write_msgs+0x12e3/0x1b90 net/kcm/kcmsock.c:627 > CPU: 3 PID: 2936 Comm: a.out Not tainted 4.10.0-rc6+ #209 > Hardware name: QEMU Standard PC

Re: [PATCH] xen-netfront: Rework the fix for Rx stall during OOM and network stress

2017-02-09 Thread David Miller
From: Vineeth Remanan Pillai Date: Tue, 7 Feb 2017 18:59:01 + > The commit 90c311b0eeea ("xen-netfront: Fix Rx stall during network > stress and OOM") caused the refill timer to be triggerred almost on > all invocations of xennet_alloc_rx_buffers for certain workloads. > This reworks the fix

Re: [PATCH] netlink: move nla_put_{u8,u16,u32} out of line

2017-02-09 Thread David Miller
From: Arnd Bergmann Date: Wed, 8 Feb 2017 22:18:26 +0100 > When CONFIG_KASAN is enabled, the "--param asan-stack=1" causes rather large > stack frames in some functions. This goes unnoticed normally because > CONFIG_FRAME_WARN is disabled with CONFIG_KASAN by default as of commit > 3f181b4d8652

Re: [PATCH net-next v4 04/11] bpf: Use bpf_load_program() from the library

2017-02-09 Thread Daniel Borkmann
On 02/08/2017 09:49 PM, Mickaël Salaün wrote: Replace bpf_prog_load() with bpf_load_program() calls. Signed-off-by: Mickaël Salaün Cc: Alexei Starovoitov Cc: Daniel Borkmann Cc: Shuah Khan [...] diff --git a/tools/testing/selftests/bpf/test_tag.c b/tools/testing/selftests/bpf/test_tag.c i

Re: Extending socket timestamping API for NTP

2017-02-09 Thread Denny Page
> On Feb 08, 2017, at 16:45, Denny Page wrote: > > [Resend as plain text] > > >> On Feb 07, 2017, at 06:01, Miroslav Lichvar wrote: >> >> 5) new SO_TIMESTAMPING options to get transposed RX timestamps >> >> PTP uses preamble RX timestamps, but NTP works with trailer RX >> timestamps. This

  1   2   3   4   >