Re: [Patch net-next v2] net_sched: move the empty tp check from ->destroy() to ->delete()

2017-04-13 Thread kbuild test robot
Hi Cong, [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Cong-Wang/net_sched-move-the-empty-tp-check-from-destroy-to-delete/20170413-145318 config: x86_64-randconfig-x004-201715 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901

Re: [PATCHv4] net: dsa: add SMSC/Microchip LAN9303 three port ethernet switch driver

2017-04-13 Thread Juergen Borleis
Hi David, On Wednesday 12 April 2017 19:15:20 David Miller wrote: > [...] > >> Please note: the "MDIO managed mode" driver part isn't tested yet. I > >> have used and tested the "I2C managed mode" only. > > > > Series applied, thank you. > > Actually, this doesn't even build. Please fix this and

[PATCH v5 1/4] net: dsa: add support for the SMSC-LAN9303 tagging format

2017-04-13 Thread Juergen Borleis
To define the outgoing port and to discover the incoming port a regular VLAN tag is used by the LAN9303. But its VID meaning is 'special'. This tag handler/filter depends on some hardware features which must be enabled in the device to provide and make use of this special VLAN tag to control the d

[PATCH v5 4/4] net: dsa: LAN9303: add MDIO managed mode support

2017-04-13 Thread Juergen Borleis
When the LAN9303 device is in MDIO manged mode, all register accesses must be done via MDIO. Please note: this code is compile time tested only due to the absence of such configured hardware. It is based on a patch from Stefan Roese from 2014. Signed-off-by: Juergen Borleis Reviewed-by: Andrew L

[PATCH v5 2/4] net: dsa: add new DSA switch driver for the SMSC-LAN9303

2017-04-13 Thread Juergen Borleis
The SMSC/Microchip LAN9303 is an ethernet switch device with one CPU port and two external ethernet ports with built-in phys. This driver uses the DSA framework, but is currently only capable of separating the two external ports. There is no offload support yet. Signed-off-by: Juergen Borleis Re

[PATCHv5] net: dsa: add SMSC/Microchip LAN9303 three port ethernet switch driver

2017-04-13 Thread Juergen Borleis
The LAN9303 is a three port 10/100 ethernet switch with integrated phys for the two external ethernet ports. The third port is an RMII/MII interface to a host master network interface (e.g. fixed link). While the LAN9303 device itself supports offload packet processing, this driver does not make u

[PATCH v5 3/4] net: dsa: LAN9303: add I2C managed mode support

2017-04-13 Thread Juergen Borleis
In this mode the switch device and the internal phys will be managed via I2C interface. The MDIO interface is still supported, but for the (emulated) CPU port only. Signed-off-by: Juergen Borleis Reviewed-by: Andrew Lunn CC: devicet...@vger.kernel.org CC: robh...@kernel.org CC: mark.rutl...@arm.

[PATCH v2 net-next 0/8] net/ncsi: Add debugging functionality

2017-04-13 Thread Gavin Shan
This series supports NCSI debugging infrastructure by adding several debugfs files. It was inspired by the reported issues: No available package and channel are probed successfully. Obviously, we don't have a debugging infrastructure for NCSI stack yet. The first 3 patches, fixing some issues, are

[PATCH v2 net-next 3/8] net/ncsi: Enforce failover on link monitor timeout

2017-04-13 Thread Gavin Shan
The NCSI channel has been configured to provide service if its link monitor timer is enabled, regardless of its state (inactive or active). So the timeout event on the link monitor indicates the out-of-service on that channel, for which a failover is needed. This sets NCSI_DEV_RESHUFFLE flag to en

[PATCH v2 net-next 6/8] net/ncsi: Support NCSI packet generation

2017-04-13 Thread Gavin Shan
This introduces /sys/kernel/debug/ncsi/eth0/pkt. The debugfs entry can accept parameters to produce NCSI command packet. The received NCSI response packet is dumped on read. Below is an example to send CIS command and dump its response. # echo CIS,0,0 > /sys/kernel/debug/ncsi/eth0/pkt # cat

[PATCH v2 net-next 4/8] net/ncsi: Add debugging infrastructurre

2017-04-13 Thread Gavin Shan
This creates debugfs directories as NCSI debugging infrastructure. With the patch applied, We will see below debugfs directories. Every NCSI package and channel has one corresponding directory. Other than presenting the NCSI topology, No real function has been achieved through these debugfs directo

[PATCH v2 net-next 8/8] net/ncsi: Fix length of GVI response packet

2017-04-13 Thread Gavin Shan
The length of GVI (GetVersionInfo) response packet should be 40 instead of 36. This issue was found from /sys/kernel/debug/ncsi/eth0/stats. # cat /sys/kernel/debug/ncsi/eth0/stats : RSP OK TIMEOUT ERROR === GVI 002

[PATCH v2 net-next 2/8] net/ncsi: Properly track channel monitor timer state

2017-04-13 Thread Gavin Shan
The field @monitor.enabled in the NCSI channel descriptor is used to track the state of channel monitor timer. It indicates the timer's state (pending or not). We could not start the timer again in its handler. In that case, We missed to update @monitor.enabled to false. It leads to below warning p

[PATCH v2 net-next 5/8] net/ncsi: Dump NCSI packet statistics

2017-04-13 Thread Gavin Shan
This creates /sys/kernel/debug/ncsi//stats to dump the NCSI packets sent and received over all packages and channels. It's useful to diagnose NCSI problems, especially when NCSI packages and channels aren't probed properly. The statistics can be gained from debugfs file as below: # cat /sys/kerne

[PATCH v2 net-next 1/8] net/ncsi: Disable HWA mode when no channels are found

2017-04-13 Thread Gavin Shan
When there are no NCSI channels probed, HWA (Hardware Arbitration) mode is enabled. It's not correct because HWA depends on the fact: NCSI channels exist and all of them support HWA mode. This disables HWA when no channels are probed. Signed-off-by: Gavin Shan --- net/ncsi/ncsi-manage.c | 12 +++

[PATCH v2 net-next 7/8] net/ncsi: No error report on DP response to non-existing package

2017-04-13 Thread Gavin Shan
The issue was found from /sys/kernel/debug/ncsi/eth0/stats. The first step in NCSI package/channel enumeration is deselect all packages by sending DP (Deselect Package) commands. The remote NIC replies with response while the corresponding package isn't populated yet and it is treated as an error w

Re: [PATCH net-next 0/8] net/ncsi: Add debugging functionality

2017-04-13 Thread Gavin Shan
On Thu, Apr 13, 2017 at 12:46:32PM +1000, Gavin Shan wrote: >This series supports NCSI debugging infrastructure by adding several >procfs files. It was inspired by the reported issues: No available >package and channel are probed successfully. Obviously, we don't >have a debugging infrastructure fo

Re: [PATCH linux 2/2] net sched actions: fix refcount decrement on error

2017-04-13 Thread Wolfgang Bumiller
On Wed, Apr 12, 2017 at 09:27:31PM -0700, Cong Wang wrote: > On Wed, Apr 12, 2017 at 7:21 AM, Wolfgang Bumiller > wrote: > > If memory allocation for nla_memdup_cookie() fails > > module_put has to be guarded by the same condition as it was > > before the TCA_ACT_COOKIE has been added as stated in

[PATCH v4] smsc95xx: Add comments to the registers definition

2017-04-13 Thread Martin Wetterwald
This chip is used by a lot of embedded devices and also by the Raspberry Pi 1, 2 & 3 which were created to promote the study of computer sciences. Students wanting to learn kernel / network device driver programming through those devices can only rely on the Linux kernel driver source to make their

Re: [PATCH v3] smsc95xx: Add comments to the registers definition

2017-04-13 Thread martin
On 12/04/17 22:10, woojung@microchip.com wrote: > Sorry forgetting that you are referring RPi which uses LAN9514. > Because these LEDs' GPIO can vary per chip (LAN9500, 9514..), it would be > better > not putting GPIO number. LAN9500 are GPIO 10/9/8 as described. > > > While we are here, coul

Re: [PATCH 20/24] bpf: Restrict kernel image access functions when the kernel is locked down

2017-04-13 Thread David Howells
Alexei Starovoitov wrote: > this will obviously break the program. Yeah. But if it allows one to twiddle the kernel image or gain access to crypto material... > How about disabling loading tracing programs during the lockdown completely? Interesting thought. I'm not sure how much would actua

RE: [RFC PATCH 2/7] net: ethernet: update drivers to handle HWTSTAMP_FILTER_NTP_ALL

2017-04-13 Thread Keller, Jacob E
> -Original Message- > From: Miroslav Lichvar [mailto:mlich...@redhat.com] > Sent: Wednesday, April 12, 2017 7:18 AM > To: netdev@vger.kernel.org > Cc: Richard Cochran ; Willem de Bruijn > ; Soheil Hassas Yeganeh ; Keller, > Jacob E ; Denny Page ; Jiri > Benc > Subject: [RFC PATCH 2/7] n

RE: [RFC PATCH 4/7] net: ethernet: update drivers to provide timestamping packet info

2017-04-13 Thread Keller, Jacob E
> -Original Message- > From: Miroslav Lichvar [mailto:mlich...@redhat.com] > Sent: Wednesday, April 12, 2017 7:18 AM > To: netdev@vger.kernel.org > Cc: Richard Cochran ; Willem de Bruijn > ; Soheil Hassas Yeganeh ; Keller, > Jacob E ; Denny Page ; Jiri > Benc > Subject: [RFC PATCH 4/7] net

RE: [RFC PATCH 0/7] Extend socket timestamping API

2017-04-13 Thread Keller, Jacob E
> -Original Message- > From: Miroslav Lichvar [mailto:mlich...@redhat.com] > Sent: Wednesday, April 12, 2017 7:18 AM > To: netdev@vger.kernel.org > Cc: Richard Cochran ; Willem de Bruijn > ; Soheil Hassas Yeganeh ; Keller, > Jacob E ; Denny Page ; Jiri > Benc > Subject: [RFC PATCH 0/7] Ext

RE: Re: [PATCH net-next 1/4] ixgbe: sparc: rename the ARCH_WANT_RELAX_ORDER to IXGBE_ALLOW_RELAXED_ORDER

2017-04-13 Thread Gabriele Paoloni
Hi David > -Original Message- > Subject: Re: [PATCH net-next 1/4] ixgbe: sparc: rename the > ARCH_WANT_RELAX_ORDER to IXGBE_ALLOW_RELAXED_ORDER > Date: Sat, 1 Apr 2017 11:26:03 -0700 > From: David Miller > To: dingtianh...@huawei.com > CC: catalin.mari...@arm.com, will.dea...@arm.com, mar

Re: [patch iproute2/net-next repost] devlink: Add support for pipeline debug (dpipe)

2017-04-13 Thread Jiri Pirko
Thu, Apr 13, 2017 at 01:45:25AM CEST, step...@networkplumber.org wrote: >On Tue, 28 Mar 2017 17:26:54 +0200 >Jiri Pirko wrote: > >> >> #define pr_err(args...) fprintf(stderr, ##args) >> -#define pr_out(args...) fprintf(stdout, ##args) >> +#define pr_out(args...)

Re: [RFC PATCH 0/7] Extend socket timestamping API

2017-04-13 Thread Miroslav Lichvar
On Thu, Apr 13, 2017 at 09:08:08AM +, Keller, Jacob E wrote: > > -Original Message- > > This patchset adds new options to the timestamping API that will be > > useful for NTP implementations and possibly other applications. > I think this looks pretty good, straight forward and useful.

Re: [PATCH resend 1/4] uapi glibc compat: add libc compat code when not build for kernel

2017-04-13 Thread Sergei Shtylyov
Hello! On 4/12/2017 11:31 PM, Hauke Mehrtens wrote: Instead of checking if this header file is used in the glibc, check if iti is not used in kernel context, this way it will also work with s/iti/it/. other libc implementations like musl. Acked-by: Mikko Rapeli Signed-off-by: Hauke Meh

Re: [PATCH RFC net-next v3 4/7] net: use skb->csum_algo to identify packets needing crc32c

2017-04-13 Thread Davide Caratti
thank you, On Fri, 2017-04-07 at 08:43 -0700, Tom Herbert wrote: > Maybe just call it csum_not_ip then. Then just do "if > (unlikely(skb->csum_not_ip)) ..." OK, I will rename the bit, avoid the enum and use the 'unlikely'. Up to now, this series uses the bit for SCTP only and leaves unmodified be

Re: [PATCH v2 net-next 4/8] net/ncsi: Add debugging infrastructurre

2017-04-13 Thread Joe Perches
On Thu, 2017-04-13 at 17:48 +1000, Gavin Shan wrote: > This creates debugfs directories as NCSI debugging infrastructure. > With the patch applied, We will see below debugfs directories. Every > NCSI package and channel has one corresponding directory. Other than > presenting the NCSI topology, No

RE: [RFC PATCH 0/7] Extend socket timestamping API

2017-04-13 Thread Keller, Jacob E
> -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] > On Behalf Of Miroslav Lichvar > Sent: Thursday, April 13, 2017 2:54 AM > To: Keller, Jacob E > Cc: netdev@vger.kernel.org; Richard Cochran ; > Willem de Bruijn ; Soheil Hassas Yeganeh > ; Denn

Re: [PATCH v2 net-next 5/8] net/ncsi: Dump NCSI packet statistics

2017-04-13 Thread Joe Perches
On Thu, 2017-04-13 at 17:48 +1000, Gavin Shan wrote: > This creates /sys/kernel/debug/ncsi//stats to dump the NCSI > packets sent and received over all packages and channels. It's useful > to diagnose NCSI problems, especially when NCSI packages and channels > aren't probed properly. trivia: > di

Re: ney/key: slab-out-of-bounds in parse_ipsecrequests

2017-04-13 Thread Herbert Xu
On Wed, Apr 12, 2017 at 05:39:22PM -0700, Cong Wang wrote: > On Wed, Apr 12, 2017 at 8:02 AM, Andrey Konovalov > wrote: > > Hi, > > > > I've got the following error report while fuzzing the kernel with syzkaller. > > > > On commit 39da7c509acff13fc8cb12ec1bb20337c988ed36 (4.11-rc6). > > > > A rep

Re: [PATCH net-next] net: ipv6: send unsolicited NA on admin up

2017-04-13 Thread Hannes Frederic Sowa
On Wed, Apr 12, 2017, at 20:49, David Ahern wrote: > ndisc_notify is the ipv6 equivalent to arp_notify. When arp_notify is > set to 1, gratuitous arp requests are sent when the device is brought up. > The same is expected when ndisc_notify is set to 1 (per ndisc_notify in > Documentation/networki

[PATCH net-next 1/2] qed: aRFS infrastructure support

2017-04-13 Thread Manish Chopra
This patch adds necessary APIs to interface with qede aRFS support in successive patch. It also reserves separate PTT entry for aRFS, [as being in fastpath flow] for hardware access instead of trying to acquire it at run time from the ptt pool. Signed-off-by: Manish Chopra Signed-off-by: Yuval M

[PATCH net-next 0/2] qed/qede: aRFS support

2017-04-13 Thread Manish Chopra
Hi David, This series adds support for Accelerated Flow Steering in qede driver for TCP/UDP over IPv4/IPv6 protocols. Please consider applying this series to "net-next" Thanks, Manish Manish Chopra (2): qed: aRFS infrastructure support qede: Add aRFS support drivers/net/ethernet/qlogic/qe

[PATCH net-next 2/2] qede: Add aRFS support

2017-04-13 Thread Manish Chopra
This patch adds support for aRFS for TCP and UDP protocols with IPv4/IPv6. Signed-off-by: Manish Chopra Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qede/qede.h| 22 +- drivers/net/ethernet/qlogic/qede/qede_filter.c | 441 + drivers/net/ethernet/ql

Re: net/ipv4: deadlock in ip_ra_control

2017-04-13 Thread Andrey Konovalov
On Wed, Apr 12, 2017 at 9:41 PM, Cong Wang wrote: > On Wed, Apr 12, 2017 at 5:05 AM, Andrey Konovalov > wrote: >> Hi Cong, >> >> I now have a reproducer for this bug (attached) and your patch fixes it. >> >> Could you send it? >> > > Done. I verified it with your reproducer too. > > Thanks! Gre

Re: ath6kl: Add __printf verification to ath6kl_dbg

2017-04-13 Thread Kalle Valo
Joe Perches wrote: > Fix fallout too. > > Signed-off-by: Joe Perches > Reviewed-by: Steve deRosier Patch applied to ath-next branch of ath.git, thanks. 169345d40d0f ath6kl: add __printf verification to ath6kl_dbg -- https://patchwork.kernel.org/patch/9655275/ https://wireless.wiki.kernel.o

Re: [PATCH net-next 0/3] l3mdev: Improve use with main table

2017-04-13 Thread Robert Shearman
On 12/04/17 17:51, David Ahern wrote: On 4/10/17 8:21 AM, Robert Shearman wrote: Attempting to create a TCP socket not bound to a VRF device when a TCP socket bound to a VRF device with the same port exists (and vice versa) fails with EADDRINUSE. This limits the ability to use programs in select

Greetings.

2017-04-13 Thread Sarah JOHNSON
Good Day Dearest. My name is Sarah JOHNSON I am 18 years old, the only daughter of late Mr. Raymond JOHNSON from Burkina Faso, I am contacting you to help me relocate to your country to continue my university education in your country, before my father died he gave me a deposit slip document o

Re: [PATCH] mwifiex: MAC randomization should not be persistent

2017-04-13 Thread Kalle Valo
Brian Norris writes: > On Thu, Apr 06, 2017 at 07:02:15AM +0300, Kalle Valo wrote: >> Brian Norris writes: >> >> > nl80211 provides the NL80211_SCAN_FLAG_RANDOM_ADDR for every scan >> > request that should be randomized; the absence of such a flag means we >> > should not randomize. However, mw

Re: [PATCH 1/5] netlink: extended ACK reporting

2017-04-13 Thread Nicolas Dichtel
Le 10/04/2017 à 08:18, Johannes Berg a écrit : > >> perhaps I misunderstand something, but nla_parse suggests attribute >> type can not be 0: > [...] > > Yes, some - very few - families still insist on using attribute 0, > perhaps parsing by hand or so. Like you say though, the entire > infrastru

Re: [PATCH 1/5] netlink: extended ACK reporting

2017-04-13 Thread Johannes Berg
On Thu, 2017-04-13 at 15:27 +0200, Nicolas Dichtel wrote: > > > Yes, some - very few - families still insist on using attribute 0, > > perhaps parsing by hand or so. Like you say though, the entire > > infrastructure makes that hard and undesirable, so I don't really > > see > > why we need to inv

[PATCH 2/4] net: macb: Add tsu_clk to device tree

2017-04-13 Thread Rafal Ozieblo
Signed-off-by: Rafal Ozieblo --- Documentation/devicetree/bindings/net/macb.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/net/macb.txt b/Documentation/devicetree/bindings/net/macb.txt index 1506e94..27966ae 100644 --- a/Documentation/devicetree/binding

Re: [PATCH linux 2/2] net sched actions: fix refcount decrement on error

2017-04-13 Thread Roman Mashak
Wolfgang Bumiller writes: > If memory allocation for nla_memdup_cookie() fails > module_put has to be guarded by the same condition as it was > before the TCA_ACT_COOKIE has been added as stated in the > comment afterwards: > What if a new entry has been created, and a_o->init returns ACT_P_CREA

[PATCH 3/4] net: macb: Add hardware PTP support

2017-04-13 Thread Rafal Ozieblo
This patch is based on original Harini's patch and Andrei's patch, implemented in a separate file to ease the review/maintanance and integration with other platforms. This driver does support GEM-GXL: - Register ptp clock framework - Initialize PTP related registers - HW time stamp on the PTP Ethe

Re: [PATCH 6/8] ftgmac100: Allow configuration of phy interface via device-tree

2017-04-13 Thread Andrew Lunn
On Thu, Apr 13, 2017 at 08:44:41AM +1000, Benjamin Herrenschmidt wrote: > This uses the standard phy-mode property > > Signed-off-by: Benjamin Herrenschmidt Reviewed-by: Andrew Lunn Andrew

Re: [PATCH 7/8] ftgmac100: Display the discovered PHY device info

2017-04-13 Thread Andrew Lunn
On Thu, Apr 13, 2017 at 08:44:42AM +1000, Benjamin Herrenschmidt wrote: > Signed-off-by: Benjamin Herrenschmidt Reviewed-by: Andrew Lunn Andrew

[PATCH 4/4] net: macb: Add macb_ptp to compilation chain

2017-04-13 Thread Rafal Ozieblo
Add macb_ptp.c to Makefile. In case that macb is compiled as a module, it has been renamed to cadence-macb.ko to avoid naming confusion in Makefile. Signed-off-by: Rafal Ozieblo --- drivers/net/ethernet/cadence/Makefile | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/dr

Re: [PATCH 8/8] ftgmac100: Document device-tree binding

2017-04-13 Thread Andrew Lunn
> +- phy-mode: See ethernet.txt file in the same directory. If the property is > + absent, "rgmii" is assumed. Supported values are "rgmii" and "rmii" You might want to say rgmii*, or similar, it indicate the delayed versions are accepted as well. Andrew

Re: [PATCH 8/8] ftgmac100: Document device-tree binding

2017-04-13 Thread Benjamin Herrenschmidt
On Thu, 2017-04-13 at 15:42 +0200, Andrew Lunn wrote: > > +- phy-mode: See ethernet.txt file in the same directory. If the > > property is > > +  absent, "rgmii" is assumed. Supported values are "rgmii" and > > "rmii" > > You might want to say rgmii*, or similar, it indicate the delayed > versions

Re: [PATCH 1/5] netlink: extended ACK reporting

2017-04-13 Thread Nicolas Dichtel
Le 13/04/2017 à 15:29, Johannes Berg a écrit : > On Thu, 2017-04-13 at 15:27 +0200, Nicolas Dichtel wrote: >> >>> Yes, some - very few - families still insist on using attribute 0, >>> perhaps parsing by hand or so. Like you say though, the entire >>> infrastructure makes that hard and undesirable,

[PATCH 1/4] net: macb: Add support for PTP timestamps in DMA descriptors

2017-04-13 Thread Rafal Ozieblo
This patch adds support for PTP timestamps in DMA buffer descriptors. It checks capability at runtime and uses appropriate buffer descriptor. Signed-off-by: Rafal Ozieblo --- drivers/net/ethernet/cadence/Kconfig | 10 ++- drivers/net/ethernet/cadence/macb.c | 133 +++---

[PATCH] net: thunderx: Fix set_max_bgx_per_node for 81xx rgx

2017-04-13 Thread George Cherian
Add the PCI_SUBSYS_DEVID_81XX_RGX and use the same to set the max bgx per node count. This fixes the issue intoduced by following commit 78aacb6f6 net: thunderx: Fix invalid mac addresses for node1 interfaces With this commit the max_bgx_per_node for 81xx is set as 2 instead of 3 because of which

Re: [RFC PATCH 6/7] net: allow simultaneous SW and HW transmit timestamping

2017-04-13 Thread Willem de Bruijn
On Wed, Apr 12, 2017 at 10:17 AM, Miroslav Lichvar wrote: > Add SOF_TIMESTAMPING_OPT_MULTIMSG option to allow looping the outgoing > packet to the socket's error queue with a software timestamp even when > a hardware transmit timestamp is expected to be provided by the driver. > > Applications usi

Re: [PATCH net-next 0/3] l3mdev: Improve use with main table

2017-04-13 Thread David Ahern
On 4/13/17 6:48 AM, Robert Shearman wrote: >> the patches look ok to me, but in testing them I see I refcnt problem. >> simple reproducer: >> >> ip li add red type vrf table 254 >> ip link set dev eth1 vrf red >> ip addr add 127.0.0.1/8 dev red >> ip link set dev eth1 up >> ip li set red up >> ping

Re: [RFC PATCH 3/7] net: add option to get information about timestamped packets

2017-04-13 Thread Willem de Bruijn
On Wed, Apr 12, 2017 at 10:17 AM, Miroslav Lichvar wrote: > Extend the skb_shared_hwtstamps structure with the index of the > real interface which received or transmitted the packet and the length > of the packet at layer 2. The original packet is received along with the timestamp. Why is this L2

Re: [PATCHv5] net: dsa: add SMSC/Microchip LAN9303 three port ethernet switch driver

2017-04-13 Thread David Miller
From: Juergen Borleis Date: Thu, 13 Apr 2017 09:33:39 +0200 > Changes in v5: > > - missing include file to 'net/dsa/tag_lan9303.c' added This still doesn't build cleanly. drivers/net/dsa/lan9303_mdio.o: In function `mdio_module_init': lan9303_mdio.c:(.init.text+0x0): multiple definition of `in

Re: [PATCH net-next 1/4] ixgbe: sparc: rename the ARCH_WANT_RELAX_ORDER to IXGBE_ALLOW_RELAXED_ORDER

2017-04-13 Thread David Miller
From: Gabriele Paoloni Date: Thu, 13 Apr 2017 09:10:32 + > Wouldn't it be more correct to have this as a driver specific symbol > now and move it to a generic one later once we have other drivers > requiring it? No, it would not.

[PATCH 6/7] crypto: qat: use pcie_flr instead of duplicating it

2017-04-13 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig --- drivers/crypto/qat/qat_common/adf_aer.c | 15 +-- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/drivers/crypto/qat/qat_common/adf_aer.c b/drivers/crypto/qat/qat_common/adf_aer.c index 2839fccdd84b..d3e25c37dc33 100644 --- a/drivers

[PATCH 4/7] ixgbe: use pcie_flr instead of duplicating it

2017-04-13 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig --- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 16 ++-- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c index a7a430a7be2c..543ddde5f8e2

[PATCH 3/7] PCI: call pcie_flr from reset_chelsio_generic_dev

2017-04-13 Thread Christoph Hellwig
Instead of copy & pasting and old version of the code. Signed-off-by: Christoph Hellwig --- drivers/pci/quirks.c | 15 +-- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c index b1775354cc69..b54c0d986f2a 100644 --- a/drivers/p

[PATCH 5/7] IB/hfi1: use pcie_flr instead of duplicating it

2017-04-13 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig --- drivers/infiniband/hw/hfi1/chip.c | 4 ++-- drivers/infiniband/hw/hfi1/hfi.h | 1 - drivers/infiniband/hw/hfi1/pcie.c | 30 -- 3 files changed, 2 insertions(+), 33 deletions(-) diff --git a/drivers/infiniband/hw/hfi1/chip.c b/d

[PATCH 7/7] liquidio: use pcie_flr instead of duplicating it

2017-04-13 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig --- drivers/net/ethernet/cavium/liquidio/lio_vf_main.c | 15 +-- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/drivers/net/ethernet/cavium/liquidio/lio_vf_main.c b/drivers/net/ethernet/cavium/liquidio/lio_vf_main.c index 7b83be4ce1fe..

[PATCH 2/7] PCI: call pcie_flr from reset_intel_82599_sfp_virtfn

2017-04-13 Thread Christoph Hellwig
The 82599 quirk contained an outdated copy of the FLR code. Signed-off-by: Christoph Hellwig --- drivers/pci/quirks.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c index 673683660b5c..b1775354cc69 100644 --- a/dr

[PATCH 1/7] PCI: export pcie_flr

2017-04-13 Thread Christoph Hellwig
Currently we opencode the FLR sequence in lots of place, export a core helper instead. We split out the probing for FLR support as all the non-core callers already know their hardware. Signed-off-by: Christoph Hellwig --- drivers/pci/pci.c | 34 +- include/linu

export pcie_flr and remove copies of it in drivers

2017-04-13 Thread Christoph Hellwig
Hi all, this exports the PCI layer pcie_flr helper, and removes various opencoded copies of it.

Re: [PATCH 0/6] mvmdio updates

2017-04-13 Thread David Miller
From: Russell King - ARM Linux Date: Mon, 10 Apr 2017 16:27:28 +0100 > This series of patches update mvmdio for Armada 8k CP110. A number of > issues were found: ... Series applied to net-next, thanks.

Re: [RFC PATCH 6/7] net: allow simultaneous SW and HW transmit timestamping

2017-04-13 Thread Miroslav Lichvar
On Thu, Apr 13, 2017 at 10:30:32AM -0400, Willem de Bruijn wrote: > On Wed, Apr 12, 2017 at 10:17 AM, Miroslav Lichvar > wrote: > > +SOF_TIMESTAMPING_OPT_MULTIMSG: > > + > > + Allow outgoing packets to be looped multiple times to the socket's > > + error queue in order to receive both software

Re: [PATCH v3 1/3] VSOCK: Add vsockmon tap functions

2017-04-13 Thread Stefan Hajnoczi
On Wed, Apr 12, 2017 at 07:37:36PM +0300, Michael S. Tsirkin wrote: > On Wed, Apr 12, 2017 at 05:08:23PM +0100, Stefan Hajnoczi wrote: > > +int __vsock_remove_tap(struct vsock_tap *vt) { > > + bool found = false; > > + struct vsock_tap *tmp; > > + > > + spin_lock(&vsock_tap_lock); > > + > > +

Re: [PATCH v3 2/3] VSOCK: Add vsockmon device

2017-04-13 Thread Stefan Hajnoczi
On Wed, Apr 12, 2017 at 01:05:10PM -0400, David Miller wrote: > From: "Michael S. Tsirkin" > Date: Wed, 12 Apr 2017 19:43:20 +0300 > > > On Wed, Apr 12, 2017 at 05:08:24PM +0100, Stefan Hajnoczi wrote: > >> +struct af_vsockmon_hdr { > >> + __le64 src_cid; > >> + __le64 dst_cid; > >> + __le32 s

[PATCH v3 0/4] TI Bluetooth serdev support

2017-04-13 Thread Rob Herring
This series adds serdev support to the HCI LL protocol used on TI BT modules and enables support on HiKey board with with the WL1835 module. With this the custom TI UIM daemon and btattach are no longer needed. The series is available on this git branch[1]. This version is rebased on bluetooth-ne

[PATCH v3 4/4] arm64: dts: hikey: add WL1835 Bluetooth device node

2017-04-13 Thread Rob Herring
This adds the serial slave device for the WL1835 Bluetooth interface. Signed-off-by: Rob Herring Cc: Wei Xu Cc: Mark Rutland --- v3: - rebase on bluetooth-next arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm64/boot/dts/hisilicon

[PATCH v3 3/4] bluetooth: hci_uart: add LL protocol serdev driver support

2017-04-13 Thread Rob Herring
Turns out that the LL protocol and the TI-ST are the same thing AFAICT. The TI-ST adds firmware loading, GPIO control, and shared access for NFC, FM radio, etc. For now, we're only implementing what is needed for BT. This mirrors other drivers like BCM and Intel, but uses the new serdev bus. The f

[PATCH v3 1/4] dt-bindings: net: Add TI WiLink shared transport binding

2017-04-13 Thread Rob Herring
Add serial slave device binding for the TI WiLink series of Bluetooth/FM/GPS devices. Signed-off-by: Rob Herring Cc: Mark Rutland Cc: netdev@vger.kernel.org Cc: devicet...@vger.kernel.org --- v3: - rebase on bluetooth-next .../devicetree/bindings/net/ti,wilink-st.txt | 35 +++

[PATCH v3 2/4] bluetooth: hci_uart: remove unused hci_uart_init_tty

2017-04-13 Thread Rob Herring
There are no users of hci_uart_init_tty, so remove it. Signed-off-by: Rob Herring Cc: Marcel Holtmann Cc: Gustavo Padovan Cc: Johan Hedberg Cc: linux-blueto...@vger.kernel.org --- v3: - rebase on bluetooth-next drivers/bluetooth/hci_ldisc.c | 19 --- drivers/bluetooth/hci_uar

Re: [RFC PATCH 3/7] net: add option to get information about timestamped packets

2017-04-13 Thread Miroslav Lichvar
On Thu, Apr 13, 2017 at 10:37:07AM -0400, Willem de Bruijn wrote: > On Wed, Apr 12, 2017 at 10:17 AM, Miroslav Lichvar > wrote: > > Extend the skb_shared_hwtstamps structure with the index of the > > real interface which received or transmitted the packet and the length > > of the packet at layer

RE: [RFC PATCH 6/7] net: allow simultaneous SW and HW transmit timestamping

2017-04-13 Thread Keller, Jacob E
> -Original Message- > From: Miroslav Lichvar [mailto:mlich...@redhat.com] > Sent: Thursday, April 13, 2017 8:00 AM > > Oh, I see. I was struggling to find a good name for this option. > > > The name for this option is therefore not very descriptive. Perhaps > > SOF_TIMESTAMPING_OPT_BOTH

Re: [PATCH v3 net-next RFC] Generic XDP

2017-04-13 Thread David Miller
From: Alexei Starovoitov Date: Wed, 12 Apr 2017 21:20:38 -0700 > On Wed, Apr 12, 2017 at 02:54:15PM -0400, David Miller wrote: >> One thing I have not tried to address here is the issue of >> XDP_PACKET_HEADROOM, thanks to Daniel for spotting that. It seems >> incredibly expensive to do a skb_co

Re: [PATCH v3 net-next RFC] Generic XDP

2017-04-13 Thread David Miller
From: Johannes Berg Date: Thu, 13 Apr 2017 08:10:56 +0200 > On Wed, 2017-04-12 at 21:20 -0700, Alexei Starovoitov wrote: > >> > + if (skb_linearize(skb)) >> > + goto do_drop; >> >> when we discussed supporting jumbo frames in XDP, the idea >> was that the program would need to look at

Re: [PATCH v3 net-next RFC] Generic XDP

2017-04-13 Thread David Miller
From: Michael Chan Date: Wed, 12 Apr 2017 23:48:22 -0700 > On Wed, Apr 12, 2017 at 11:54 AM, David Miller wrote: >> >> +static struct static_key generic_xdp_needed __read_mostly; >> + >> +static int generic_xdp_install(struct net_device *dev, struct netdev_xdp >> *xdp) >> +{ >> + struct b

[PATCH net-next v2] Subject: net: allow configuring default qdisc

2017-04-13 Thread Stephen Hemminger
Since 3.12 it has been possible to configure the default queuing discipline via sysctl. This patch adds ability to configure the default queue discipline in kernel configuration. This is useful for environments where configuring the value from userspace is difficult to manage. The default is still

[PATCH 2/2] net: phy: simplify phy_supported_speeds()

2017-04-13 Thread Russell King
Simplify the loop in phy_supported_speeds(). Signed-off-by: Russell King --- drivers/net/phy/phy.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c index 00280d4eeb56..6afbd973a779 100644 --- a/drivers/net/phy/phy.c

[PATCH 1/2] net: phy: improve phylib correctness for non-autoneg settings

2017-04-13 Thread Russell King
phylib has some undesirable behaviour when forcing a link mode through ethtool. phylib uses this code: idx = phy_find_valid(phy_find_setting(phydev->speed, phydev->duplex), features); to find an index in the settings table. phy_find_setting() starts at index 0, a

Re: [PATCH v3 net-next RFC] Generic XDP

2017-04-13 Thread Daniel Borkmann
On 04/12/2017 08:54 PM, David Miller wrote: [...] +static u32 netif_receive_generic_xdp(struct sk_buff *skb, +struct bpf_prog *xdp_prog) +{ + struct xdp_buff xdp; + u32 act = XDP_DROP; + void *orig_data; + int hlen, off; + + if (sk

Re: [PATCH v3 net-next RFC] Generic XDP

2017-04-13 Thread David Miller
From: Daniel Borkmann Date: Thu, 13 Apr 2017 17:57:06 +0200 > On 04/12/2017 08:54 PM, David Miller wrote: > [...] >> +static u32 netif_receive_generic_xdp(struct sk_buff *skb, >> + struct bpf_prog *xdp_prog) >> +{ >> +struct xdp_buff xdp; >> +u32 act = XDP_

[PATCH v4 net-next RFC] net: Generic XDP

2017-04-13 Thread David Miller
This provides a generic SKB based non-optimized XDP path which is used if either the driver lacks a specific XDP implementation, or the user requests it via a new IFLA_XDP_FLAGS value named XDP_FLAGS_SKB_MODE. It is arguable that perhaps I should have required something like this as part of the i

Re: [Patch net-next v2] net_sched: move the empty tp check from ->destroy() to ->delete()

2017-04-13 Thread Cong Wang
On Thu, Apr 13, 2017 at 12:28 AM, kbuild test robot wrote: > Hi Cong, > > [auto build test WARNING on net-next/master] > > url: > https://github.com/0day-ci/linux/commits/Cong-Wang/net_sched-move-the-empty-tp-check-from-destroy-to-delete/20170413-145318 > config: x86_64-r

[patch net-next] MAINTAINERS: rename TC entry and add couple of header files

2017-04-13 Thread Jiri Pirko
From: Jiri Pirko The section is not specific only to "TC classifiers", but applies to the whole TC subsystem. Also, add couple of forgotten headers. Signed-off-by: Jiri Pirko --- MAINTAINERS | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS ind

Re: [RFC PATCH 3/7] net: add option to get information about timestamped packets

2017-04-13 Thread Willem de Bruijn
On Thu, Apr 13, 2017 at 11:18 AM, Miroslav Lichvar wrote: > On Thu, Apr 13, 2017 at 10:37:07AM -0400, Willem de Bruijn wrote: >> On Wed, Apr 12, 2017 at 10:17 AM, Miroslav Lichvar >> wrote: >> > Extend the skb_shared_hwtstamps structure with the index of the >> > real interface which received or

[PATCH v4 0/3] VSOCK: vsockmon virtual device to monitor AF_VSOCK sockets.

2017-04-13 Thread Stefan Hajnoczi
v4: * Add explicit reserved padding field to struct af_vsockmon_hdr and drop __attribute__((packed)) [Michael, DaveM] * Call synchronize_net() before module_put() [Michael] v3: * Hook virtio_transport.c (guest driver), not just drivers/vhost/vsock.c (host driver) * Fix DEFAULT_MTU macro

[PATCH v4 1/3] VSOCK: Add vsockmon tap functions

2017-04-13 Thread Stefan Hajnoczi
From: Gerard Garcia Add tap functions that can be used by the vsock transports to deliver packets to vsockmon virtual network devices. Signed-off-by: Gerard Garcia Signed-off-by: Stefan Hajnoczi --- v4: * Call synchronize_net() before module_put() [Michael] v3: * Include missing header in a

Re: [RFC PATCH 6/7] net: allow simultaneous SW and HW transmit timestamping

2017-04-13 Thread Willem de Bruijn
On Thu, Apr 13, 2017 at 11:24 AM, Keller, Jacob E wrote: > > >> -Original Message- >> From: Miroslav Lichvar [mailto:mlich...@redhat.com] >> Sent: Thursday, April 13, 2017 8:00 AM >> >> Oh, I see. I was struggling to find a good name for this option. >> >> > The name for this option is the

[PATCH v4 3/3] VSOCK: Add virtio vsock vsockmon hooks

2017-04-13 Thread Stefan Hajnoczi
From: Gerard Garcia The virtio drivers deal with struct virtio_vsock_pkt. Add virtio_transport_deliver_tap_pkt(pkt) for handing packets to the vsockmon device. We call virtio_transport_deliver_tap_pkt(pkt) from net/vmw_vsock/virtio_transport.c and drivers/vhost/vsock.c instead of common code.

[PATCH v4 2/3] VSOCK: Add vsockmon device

2017-04-13 Thread Stefan Hajnoczi
From: Gerard Garcia Add vsockmon virtual network device that receives packets from the vsock transports and exposes them to user space. Based on the nlmon device. Signed-off-by: Gerard Garcia Signed-off-by: Stefan Hajnoczi --- v4: * Add explicit reserved padding field to struct af_vsockmon_h

Re: IGMP on IPv6

2017-04-13 Thread Murali Karicheri
On 03/22/2017 11:04 AM, Murali Karicheri wrote: > Hi Liu, > > I saw that you have sent patches to the list for IGMP and have a question on > IGMP on IPv6. > Hope you can clarify. I have posted the question already to the list and is > reproduced > below. Let me know if you have an answer. > > =

Re: [PATCH 1/1] drivers: net: usb: qmi_wwan: add QMI_QUIRK_SET_DTR for Telit PID 0x1201

2017-04-13 Thread David Miller
From: Daniele Palmas Date: Mon, 10 Apr 2017 17:34:23 +0200 > Telit LE920A4 uses the same pid 0x1201 of LE920, but modem > implementation is different, since it requires DTR to be set for > answering to qmi messages. > > This patch replaces QMI_FIXED_INTF with QMI_QUIRK_SET_DTR: tests on > LE920

Re: [PATCH net-next] cxgb4: save tid while creating server filter

2017-04-13 Thread David Miller
From: Ganesh Goudar Date: Mon, 10 Apr 2017 21:26:18 +0530 > Save the filter tid while creating the server filter, which is used > later to retrieve the corresponding filter instance while handling > the filter reply. > > Signed-off-by: Ganesh Goudar Applied.

Re: [PATCH net-next] net: stmmac: set total length of the packet to be transmitted in TDES3

2017-04-13 Thread David Miller
From: Niklas Cassel Date: Mon, 10 Apr 2017 20:33:29 +0200 > From: Niklas Cassel > > Field FL/TPL in register TDES3 is not correctly set on GMAC4. > TX appears to be functional on GMAC 4.10a even if this field is not set, > however, to avoid relying on undefined behavior, set the length in TDES3

  1   2   >