Re: [patch net-next v2 0/8] mlxsw: Support firmware flash

2017-05-24 Thread Jiri Pirko
Wed, May 24, 2017 at 10:33:28PM CEST, da...@davemloft.net wrote: >From: Jiri Pirko >Date: Tue, 23 May 2017 21:56:22 +0200 > >> From: Jiri Pirko >> >> Add support for device firmware flash on mlxsw spectrum. The firmware files >> are expected to be in the Mellanox Firmware Archive version 2 (MFA2

[PATCH] net: llc: add lock_sock in llc_ui_bind to avoid a race condition

2017-05-24 Thread Lin Zhang
There is a race condition in llc_ui_bind if two or more processes/threads try to bind a same socket. If more processes/threads bind a same socket success that will lead to two problems, one is this action is not what we expected, another is will lead to kernel in unstable status or oops(in my s

Re: [PATCH] bonding: Don't update slave->link until ready to commit

2017-05-24 Thread महेश बंडेवार
On Wed, May 24, 2017 at 7:45 PM, Nithin Nayak Sujir wrote: > In the loadbalance arp monitoring scheme, when a slave link change is > detected, the slave->link is immediately updated and slave_state_changed > is set. Later down the function, the rtnl_lock is acquired and the > changes are committed

RE: [for-next 4/6] net/mlx5: FPGA, Add basic support for Innova

2017-05-24 Thread Ilan Tayari
> -Original Message- > From: Alexei Starovoitov [mailto:alexei.starovoi...@gmail.com] > > On Tue, May 23, 2017 at 02:44:02PM +0300, Saeed Mahameed wrote: > > From: Ilan Tayari > > > > Mellanox Innova is a NIC with ConnectX and an FPGA on the same > > board. The FPGA is a bump-on-the-wire

Re: [PATCH net-next] ibmvnic: Enable TSO support

2017-05-24 Thread kbuild test robot
Hi Thomas, [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Thomas-Falcon/ibmvnic-Enable-TSO-support/20170525-111039 config: powerpc-allmodconfig (attached as .config) compiler: powerpc64-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705 reproduce:

[PATCH net-next 5/6] net: mpls: Add extack messages for route add and delete failures

2017-05-24 Thread David Ahern
Add error messages for failures in adding and deleting mpls routes. This covers most of the annoying EINVAL errors. Signed-off-by: David Ahern --- net/mpls/af_mpls.c | 136 +--- net/mpls/internal.h | 2 +- 2 files changed, 98 insertions(+), 40 d

[PATCH net-next 3/6] net: plumb extack arg down to lwtunnel build state

2017-05-24 Thread David Ahern
Pass extack arg down to lwtunnel_build_state and the build_state callbacks. Add messages for failures in lwtunnel_build_state, and add the extarg to nla_parse where possible in the build_state callbacks. Signed-off-by: David Ahern --- include/linux/netlink.h | 10 ++ include/net/lwtunn

[PATCH net-next 4/6] net: Fill in extack for mpls lwt encap

2017-05-24 Thread David Ahern
Fill in extack for errors in build_state for mpls lwt encap including passing extack to nla_get_labels and adding error messages for failures in it. Signed-off-by: David Ahern --- net/mpls/af_mpls.c | 49 ++-- net/mpls/internal.h | 2 +- ne

[PATCH net-next 0/6] net: another round of extack handling for routing

2017-05-24 Thread David Ahern
This set focuses on passing extack through lwtunnel and MPLS with additional catches for IPv4 route add and minor cleanups in MPLS encountered passing the extack arg around. David Ahern (6): net: ipv4: Add extack message for invalid prefix or length net: lwtunnel: Add extack to encap attr vali

[PATCH net-next 2/6] net: lwtunnel: Add extack to encap attr validation

2017-05-24 Thread David Ahern
Pass extack down to lwtunnel_valid_encap_type and lwtunnel_valid_encap_type_attr. Add messages for unknown or unsupported encap types. Signed-off-by: David Ahern --- include/net/lwtunnel.h | 13 + net/core/lwtunnel.c | 18 +- net/ipv4/fib_frontend.c | 6 --

[PATCH net-next 1/6] net: ipv4: Add extack message for invalid prefix or length

2017-05-24 Thread David Ahern
Add extack error message for invalid prefix length and invalid prefix. Example of the latter is a route spec containing 172.16.100.1/24, where the /24 mask means the lower 8-bits should be 0. Amazing how easy that one is to overlook when an EINVAL is returned. Signed-off-by: David Ahern --- incl

[PATCH net-next 6/6] net: mpls: minor cleanups

2017-05-24 Thread David Ahern
Noticed these doing the extack support: - nla_get_via is only used in af_mpls.c so remove from internal.h - err is initialized to EINVAL in mpls_nh_build_from_cfg but then set again before it is checked. Remove the EINVAL setting Signed-off-by: David Ahern --- net/mpls/af_mpls.c | 5 +++-- n

Re: [PATCH net-next 1/8] net: ipv4: refactor __ip_route_output_key_hash

2017-05-24 Thread Roopa Prabhu
On Wed, May 24, 2017 at 6:10 PM, David Ahern wrote: > On 5/24/17 1:33 PM, Rosen, Rami wrote: >> Hi, Rupa /David Ahern, >> >> First, thanks for this patch set! >> >> Second, it seems to me that something might be incorrect here. >> >> You have these additions in this patch (1/8): >> ... >> +struct

[PATCH] bonding: Don't update slave->link until ready to commit

2017-05-24 Thread Nithin Nayak Sujir
In the loadbalance arp monitoring scheme, when a slave link change is detected, the slave->link is immediately updated and slave_state_changed is set. Later down the function, the rtnl_lock is acquired and the changes are committed, updating the bond link state. However, the acquisition of the rtn

Re: [PATCH net-next 1/8] net: ipv4: refactor __ip_route_output_key_hash

2017-05-24 Thread kbuild test robot
Hi David, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Roopa-Prabhu/net-extend-RTM_GETROUTE-to-return-fib-result/20170525-053253 config: openrisc-or1ksim_defconfig (attached as .config) compiler: or1k-linux-gcc (GCC) 5.4.0 reproduce: wget h

Re: [PATCH net-next 8/8] net: ipv6: RTM_GETROUTE: return matched fib result when requested

2017-05-24 Thread David Ahern
Since you have to do a v2 ... On 5/24/17 12:19 PM, Roopa Prabhu wrote: > @@ -3622,6 +3623,7 @@ static int inet6_rtm_getroute(struct sk_buff *in_skb, > struct nlmsghdr *nlh, > memset(&fl6, 0, sizeof(fl6)); > rtm = nlmsg_data(nlh); > fl6.flowlabel = ip6_make_flowinfo(rtm->rtm_tos,

[PATCH net-next 0/2] be2net: patch-set

2017-05-24 Thread Suresh Reddy
Hi Dave, Please consider applying these two patches to net-next Suresh Reddy (2): be2net: Fix UE detection logic for BE3 be2net: Update the driver version to 11.4.0.0 drivers/net/ethernet/emulex/benet/be.h | 2 +- drivers/net/ethernet/emulex/benet/be_hw.h | 3 +++ drivers/net/ethern

[PATCH net-next 1/2] be2net: Fix UE detection logic for BE3

2017-05-24 Thread Suresh Reddy
On certain platforms BE3 chips may indicate spurious UEs (unrecoverable error). Because of the UE detection logic was disabled in the driver for BE3 chips. Because of this, even in cases of a real UE, a failover will not occur. This patch re-enables UE detection on BE3 and if a UE is detected, read

[PATCH net-next 2/2] be2net: Update the driver version to 11.4.0.0

2017-05-24 Thread Suresh Reddy
Signed-off-by: Suresh Reddy --- drivers/net/ethernet/emulex/benet/be.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/emulex/benet/be.h b/drivers/net/ethernet/emulex/benet/be.h index 5056624..674cf9d 100644 --- a/drivers/net/ethernet/emulex/benet/be.h ++

[PATCH net-next] ibmvnic: Enable TSO support

2017-05-24 Thread Thomas Falcon
Enable TSO in the ibmvnic driver. Scatter-gather is also enabled, though there currently is no support for scatter-gather in vNIC-compatible hardware, resulting in forced linearization of all fragmented SKB's. Though not ideal, given the throughput improvement gained by enabling TSO, it has been de

Re: [PATCH net-next 7/8] net: ipv4: RTM_GETROUTE: return matched fib result when requested

2017-05-24 Thread David Ahern
On 5/24/17 12:19 PM, Roopa Prabhu wrote: > @@ -2746,8 +2748,15 @@ static int inet_rtm_getroute(struct sk_buff *in_skb, > struct nlmsghdr *nlh, > if (rtm->rtm_flags & RTM_F_LOOKUP_TABLE) > table_id = rt->rt_table_id; > > - err = rt_fill_info(net, dst, src, table_id, &fl4,

Re: [PATCH net-next 1/8] net: ipv4: refactor __ip_route_output_key_hash

2017-05-24 Thread kbuild test robot
Hi David, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Roopa-Prabhu/net-extend-RTM_GETROUTE-to-return-fib-result/20170525-053253 config: cris-etrax-100lx_v2_defconfig (attached as .config) compiler: cris-linux-gcc (GCC) 6.2.0 reproduce: wget

Re: Deleting a dynamic mac entry..

2017-05-24 Thread Toshiaki Makita
On 2017/05/25 3:05, Manohar Kumar wrote: > Thanks, Toshiaki. > > What is the right way to set the default_pvid using the bridge command > ? I tried this, which fails.. > > root@net-3:~# ip link set dev vxlan0 name untagged type vlan id 0 > RTNETLINK answers: Operation not supported > root@net-3:~

Re: [PATCH net-next 1/8] net: ipv4: refactor __ip_route_output_key_hash

2017-05-24 Thread David Ahern
On 5/24/17 1:33 PM, Rosen, Rami wrote: > Hi, Rupa /David Ahern, > > First, thanks for this patch set! > > Second, it seems to me that something might be incorrect here. > > You have these additions in this patch (1/8): > ... > +struct rtable *ip_route_output_key_hash_rcu(struct net *net, struct

Re: [PATCH net-next 3/3] net: sysfs: Document PHY device sysfs attributes

2017-05-24 Thread Florian Fainelli
On 05/24/2017 04:07 PM, Florian Fainelli wrote: > Hi Andrew, > > On 05/24/2017 01:10 PM, Andrew Lunn wrote: >>> +What: /sys/class/mdio_bus///phy_interface >>> +Date: February 2014 >>> +KernelVersion: 3.15 >>> +Contact: netdev@vger.kernel.org >>> +Description: >>> +

Re: [PATCH 0/2] Replace driver's usage of hard-coded device IDs to #defines

2017-05-24 Thread David Miller
From: Myron Stowe Date: Wed, 24 May 2017 16:47:34 -0600 > Noa Osherovich introduced a series of new Mellanox device ID definitions to > help differentiate specific controllers that needed INTx masking quirks [1]. > > Bjorn Helgaas followed on, using the device ID definitions Noa provided to > re

Re: [PATCH] test_bpf: Add a couple of tests for BPF_JSGE.

2017-05-24 Thread Daniel Borkmann
On 05/25/2017 01:35 AM, David Daney wrote: Some JITs can optimize comparisons with zero. Add a couple of BPF_JSGE tests against immediate zero. Signed-off-by: David Daney Thanks for the tests! Acked-by: Daniel Borkmann

[PATCH] test_bpf: Add a couple of tests for BPF_JSGE.

2017-05-24 Thread David Daney
Some JITs can optimize comparisons with zero. Add a couple of BPF_JSGE tests against immediate zero. Signed-off-by: David Daney --- lib/test_bpf.c | 38 ++ 1 file changed, 38 insertions(+) diff --git a/lib/test_bpf.c b/lib/test_bpf.c index 889bc31..be88cba 1

linux-next: manual merge of the net-next tree with the net tree

2017-05-24 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: drivers/net/phy/marvell.c between commit: f2899788353c ("net: phy: marvell: Limit errata to 88m1101") from the net tree and commit: 0c3439bc7773 ("net: phy: Marvell: checkpatch - Comments") from the net-next tree.

Re: [PATCH net-next 3/3] net: sysfs: Document PHY device sysfs attributes

2017-05-24 Thread Florian Fainelli
Hi Andrew, On 05/24/2017 01:10 PM, Andrew Lunn wrote: >> +What: /sys/class/mdio_bus///phy_interface >> +Date: February 2014 >> +KernelVersion: 3.15 >> +Contact:netdev@vger.kernel.org >> +Description: >> +String value indicating the PHY interface, po

[PATCH net v2 2/5] bpf: properly reset caller saved regs after helper call and ld_abs/ind

2017-05-24 Thread Daniel Borkmann
Currently, after performing helper calls, we clear all caller saved registers, that is r0 - r5 and fill r0 depending on struct bpf_func_proto specification. The way we reset these regs can affect pruning decisions in later paths, since we only reset register's imm to 0 and type to NOT_INIT. However

[PATCH net v2 4/5] bpf: fix wrong exposure of map_flags into fdinfo for lpm

2017-05-24 Thread Daniel Borkmann
trie_alloc() always needs to have BPF_F_NO_PREALLOC passed in via attr->map_flags, since it does not support preallocation yet. We check the flag, but we never copy the flag into trie->map.map_flags, which is later on exposed into fdinfo and used by loaders such as iproute2. Latter uses this in bpf

[PATCH net v2 3/5] bpf: add bpf_clone_redirect to bpf_helper_changes_pkt_data

2017-05-24 Thread Daniel Borkmann
The bpf_clone_redirect() still needs to be listed in bpf_helper_changes_pkt_data() since we call into bpf_try_make_head_writable() from there, thus we need to invalidate prior pkt regs as well. Fixes: 36bbef52c7eb ("bpf: direct packet write and access for helpers for clsact progs") Signed-off-by:

[PATCH net v2 5/5] bpf: add various verifier test cases

2017-05-24 Thread Daniel Borkmann
This patch adds various verifier test cases: 1) A test case for the pruning issue when tracking alignment is used. 2) Various PTR_TO_MAP_VALUE_OR_NULL tests to make sure pointer arithmetic turns such register into UNKNOWN_VALUE type. 3) Test cases for the special treatment of LD_ABS/LD_IND t

[PATCH net v2 1/5] bpf: fix incorrect pruning decision when alignment must be tracked

2017-05-24 Thread Daniel Borkmann
Currently, when we enforce alignment tracking on direct packet access, the verifier lets the following program pass despite doing a packet write with unaligned access: 0: (61) r2 = *(u32 *)(r1 +76) 1: (61) r3 = *(u32 *)(r1 +80) 2: (61) r7 = *(u32 *)(r1 +8) 3: (bf) r0 = r2 4: (07) r0 += 1

[PATCH net v2 0/5] Various BPF fixes

2017-05-24 Thread Daniel Borkmann
Follow-up to fix incorrect pruning when alignment tracking is in use and to properly clear regs after call to not leave stale data behind, also a fix that adds bpf_clone_redirect to the bpf_helper_changes_pkt_data helper and exposes correct map_flags for lpm map into fdinfo. For details, please see

[PATCH 2/2] net/mlx5e: Use device ID defines

2017-05-24 Thread Myron Stowe
Use Mellanox device ID definitions in the mlx5 ID table so tools such as 'grep' and 'cscope' can be used to help find related aspects. No functional change intended. Signed-off-by: Myron Stowe --- drivers/net/ethernet/mellanox/mlx5/core/main.c | 12 ++-- 1 file changed, 6 insertions(+

[PATCH 1/2] PCI: Add Mellanox device IDs

2017-05-24 Thread Myron Stowe
Add Mellanox device IDs for controllers covered by the mlx5 driver. Signed-off-by: Myron Stowe --- include/linux/pci_ids.h |3 +++ 1 file changed, 3 insertions(+) diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h index 5f6b71d..5626d5a 100644 --- a/include/linux/pci_ids.h +++ b

[PATCH 0/2] Replace driver's usage of hard-coded device IDs to #defines

2017-05-24 Thread Myron Stowe
Noa Osherovich introduced a series of new Mellanox device ID definitions to help differentiate specific controllers that needed INTx masking quirks [1]. Bjorn Helgaas followed on, using the device ID definitions Noa provided to replace hard-coded values within the mxl4 ID table [2]. This patc

[PATCH net] sky2: Do not deadlock on sky2_hw_down

2017-05-24 Thread Joshua Emele
From: Joshua Emele The sky2_hw_down uses sky2_tx_complete to free pending frames stuck in the HW queue. Because sky2_hw_down can be called from a process context, the call to u64_stats_update_begin can result in deadlock. Because the statistics do not require update as part of the sky2_hw_down s

[PATCH] arp: fixed -Wuninitialized compiler warning

2017-05-24 Thread Ihar Hrachyshka
Commit 7d472a59c0e5ec117220a05de6b370447fb6cb66 ("arp: always override existing neigh entries with gratuitous ARP") introduced a compiler warning: net/ipv4/arp.c:880:35: warning: 'addr_type' may be used uninitialized in this function [-Wmaybe-uninitialized] While the code logic seems to be correc

Re: [Intel-wired-lan] [PATCH 3/4] [next-queue]net: i40e: Enable mqprio full offload mode in the i40e driver for configuring TCs and queue mapping

2017-05-24 Thread Alexander Duyck
On Fri, May 19, 2017 at 5:58 PM, Amritha Nambiar wrote: > The i40e driver is modified to enable the new mqprio hardware > offload mode and factor the TCs and queue configuration by > creating channel VSIs. In this mode, the priority to traffic > class mapping and the user specified queue ranges ar

Re: [PATCH 2/2] at803x: double check SGMII side autoneg

2017-05-24 Thread Timur Tabi
On 05/24/2017 04:36 PM, Florian Fainelli wrote: OK, and there is no way you can run into the following race condition: CPU HW MDIO read intent polling starts disable HW autopoll polling continues Disabl

Re: [Intel-wired-lan] [PATCH 1/4] [next-queue]net: mqprio: Introduce new hardware offload mode in mqprio for offloading full TC configurations

2017-05-24 Thread Alexander Duyck
On Fri, May 19, 2017 at 5:58 PM, Amritha Nambiar wrote: > This patch introduces a new hardware offload mode in mqprio > which makes full use of the mqprio options, the TCs, the > queue configurations and the bandwidth rates for the TCs. > This is achieved by setting the value 2 for the "hw" option

Re: [PATCH v2 0/4] arp: always override existing neigh entries with gratuitous ARP

2017-05-24 Thread Arnd Bergmann
On Wed, May 24, 2017 at 11:32 PM, Ihar Hrachyshka wrote: > On 05/23/2017 01:56 PM, Arnd Bergmann wrote: >> >> This seems to have caused a build warning: >> >> net/ipv4/arp.c:880:35: warning: 'addr_type' may be used uninitialized >> in this function [-Wmaybe-uninitialized] >> > Not sure. How do you

Re: [Intel-wired-lan] [PATCH 2/4] [next-queue]net: i40e: Add infrastructure for queue channel support with the TCs and queue configurations offloaded via mqprio scheduler

2017-05-24 Thread Alexander Duyck
On Fri, May 19, 2017 at 5:58 PM, Amritha Nambiar wrote: > This patch sets up the infrastructure for offloading TCs and > queue configurations to the hardware by creating HW channels(VSI). > A new channel is created for each of the traffic class > configuration offloaded via mqprio framework except

Re: [PATCH v2 2/4] arp: decompose is_garp logic into a separate function

2017-05-24 Thread Ihar Hrachyshka
On 05/18/2017 01:49 PM, Julian Anastasov wrote: All 4 patches look ok to me with only a small problem which comes from patch already included in kernel. I see that GARP replies can not work for 1394, is_garp will be cleared. May be 'tha' check should be moved in if expression, for exampl

Re: [PATCH 2/2] at803x: double check SGMII side autoneg

2017-05-24 Thread Florian Fainelli
On 05/24/2017 02:32 PM, Timur Tabi wrote: > On 05/24/2017 04:28 PM, Florian Fainelli wrote: > >> Yes phydev->lock which is used to serialize the state machine state >> changes. >> >> Most PHYs have many more registers than the 15 standard exposed >> directly, and so you need indirect reads/writes

Re: [PATCH v2 0/4] arp: always override existing neigh entries with gratuitous ARP

2017-05-24 Thread Ihar Hrachyshka
On 05/23/2017 01:56 PM, Arnd Bergmann wrote: This seems to have caused a build warning: net/ipv4/arp.c:880:35: warning: 'addr_type' may be used uninitialized in this function [-Wmaybe-uninitialized] Not sure. How do you reproduce it? I just did 'make net' in the latest tree that includes the p

Re: [PATCH 2/2] at803x: double check SGMII side autoneg

2017-05-24 Thread Timur Tabi
On 05/24/2017 04:28 PM, Florian Fainelli wrote: Yes phydev->lock which is used to serialize the state machine state changes. Most PHYs have many more registers than the 15 standard exposed directly, and so you need indirect reads/writes to access these registers, which typically involve switchi

Re: [PATCH 2/2] at803x: double check SGMII side autoneg

2017-05-24 Thread Florian Fainelli
On 05/24/2017 02:20 PM, Timur Tabi wrote: > On 05/24/2017 04:15 PM, Andrew Lunn wrote: >>> My NIC has a feature called autopolling where it takes over the MDIO >>> bus and regularly polls the link state. When it detects that the >>> link state has changed, it generates a MAC interrupt. This is wh

Re: [PATCH 2/2] at803x: double check SGMII side autoneg

2017-05-24 Thread Timur Tabi
On 05/24/2017 04:15 PM, Andrew Lunn wrote: My NIC has a feature called autopolling where it takes over the MDIO bus and regularly polls the link state. When it detects that the link state has changed, it generates a MAC interrupt. This is when I call phy_mac_interrupt() normally. Unfortunate

Re: [PATCH 2/2] at803x: double check SGMII side autoneg

2017-05-24 Thread Florian Fainelli
On 05/24/2017 01:57 PM, Timur Tabi wrote: > On 05/24/2017 02:34 PM, Andrew Lunn wrote: >>> Ok, I'm going to debug this some more. It turns out that the MAC >>> side of >>> the SGMII link can send an interrupt when it thinks that >>> auto-negotiation is >>> done. I might be able to use this. >> >>

Re: [PATCH 2/2] at803x: double check SGMII side autoneg

2017-05-24 Thread Andrew Lunn
On Wed, May 24, 2017 at 03:57:06PM -0500, Timur Tabi wrote: > On 05/24/2017 02:34 PM, Andrew Lunn wrote: > >>Ok, I'm going to debug this some more. It turns out that the MAC side of > >>the SGMII link can send an interrupt when it thinks that auto-negotiation is > >>done. I might be able to use t

Re: [PATCH 2/2] at803x: double check SGMII side autoneg

2017-05-24 Thread Timur Tabi
On 05/24/2017 02:34 PM, Andrew Lunn wrote: Ok, I'm going to debug this some more. It turns out that the MAC side of the SGMII link can send an interrupt when it thinks that auto-negotiation is done. I might be able to use this. You can use this for your board. But it still leaves the phy driv

Re: [PATCH net-next v9 5/5] virtio_net: check return value of skb_to_sgvec always

2017-05-24 Thread Sergei Shtylyov
On 05/24/2017 11:39 PM, Jason A. Donenfeld wrote: I've only looked on the last 2 patches. You can add my: Reviewed-by: Sergei Shtylyov if you want. :-) Will do. For the series, or just for 5/5? 5/5 only. :-) MBR, Sergei

Re: [PATCH v6 net-next 01/17] net: qualcomm: remove unnecessary includes

2017-05-24 Thread David Miller
From: Stefan Wahren Date: Wed, 24 May 2017 22:05:26 +0200 (CEST) > AFAIK these ones above aren't necessary (no init, no kernel module, > no kernel parameter, no kernel version) for this C file. So i will > double check it. You need the endianness translators like cpu_to_be32() or whatever, so yo

Re: [PATCH net-next v9 5/5] virtio_net: check return value of skb_to_sgvec always

2017-05-24 Thread Jason A. Donenfeld
On Wed, May 24, 2017 at 6:41 PM, Sergei Shtylyov >I've only looked on the last 2 patches. You can add my: > > Reviewed-by: Sergei Shtylyov > > if you want. :-) Will do. For the series, or just for 5/5?

Re: [patch net-next v2 0/8] mlxsw: Support firmware flash

2017-05-24 Thread David Miller
From: Jiri Pirko Date: Tue, 23 May 2017 21:56:22 +0200 > From: Jiri Pirko > > Add support for device firmware flash on mlxsw spectrum. The firmware files > are expected to be in the Mellanox Firmware Archive version 2 (MFA2) > format. > > The firmware flash is triggered on driver initializatio

Re: [PATCH net-next] tcp: fix TCP_SYNCNT flakes

2017-05-24 Thread David Miller
From: Eric Dumazet Date: Tue, 23 May 2017 12:38:35 -0700 > From: Eric Dumazet > > After the mentioned commit, some of our packetdrill tests became flaky. > > TCP_SYNCNT socket option can limit the number of SYN retransmits. > > retransmits_timed_out() has to compare times computations based o

Re: [PATCH net-next] net: dsa: support cross-chip ageing time

2017-05-24 Thread David Miller
From: Vivien Didelot Date: Tue, 23 May 2017 15:20:59 -0400 > Now that the switchdev bridge ageing time attribute is propagated to all > switch chips of the fabric, each switch can check if the requested value > is valid and program itself, so that the whole fabric shares a common > ageing time se

Re: [PATCH V3 net 0/3] Fix checksum issues with Q-in-Q vlans

2017-05-24 Thread David Miller
From: Vladislav Yasevich Date: Tue, 23 May 2017 13:38:40 -0400 > TCP checksum appear broken on a lot of devices that > advertise NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM. This problem > becomes very visible/reproducable since the series > commit afb0bc972b526 ("Merge branch 'stacked_vlan_tso'"). > >

Re: [patch net-next v2 0/5] add tcp flags match support to flower and offload it

2017-05-24 Thread David Miller
From: Jiri Pirko Date: Tue, 23 May 2017 18:40:43 +0200 > From: Jiri Pirko > > This patch adds support to dissect tcp flags, match on them using > flower classifier and offload such rules to mlxsw Spectrum devices. > > --- > v1->v2: > - removed no longer relevant comment from patch 1 as suggest

Re: [Patch net-next] net_sched: only create filter chains for new filters/actions

2017-05-24 Thread Jiri Pirko
Wed, May 24, 2017 at 05:53:42PM CEST, xiyou.wangc...@gmail.com wrote: >On Tue, May 23, 2017 at 11:37 PM, Jiri Pirko wrote: >> Tue, May 23, 2017 at 06:42:37PM CEST, xiyou.wangc...@gmail.com wrote: >>>tcf_chain_get() always creates a new filter chain if not found >>>in existing ones. This is totally

Re: [PATCH net 1/3] bpf: fix incorrect pruning decision when alignment must be tracked

2017-05-24 Thread Daniel Borkmann
On 05/24/2017 10:07 PM, David Miller wrote: From: Daniel Borkmann Date: Tue, 23 May 2017 18:30:41 +0200 + if (!env->strict_alignment && old->off <= cur->off && You can't just test env->strict_alignment by itself, that's just an override and doesn't determine the actual "strict" value w

Re: [PATCH net-next 3/3] net: sysfs: Document PHY device sysfs attributes

2017-05-24 Thread Andrew Lunn
> +What:/sys/class/mdio_bus///phy_interface > +Date:February 2014 > +KernelVersion: 3.15 > +Contact: netdev@vger.kernel.org > +Description: > + String value indicating the PHY interface, possible > + values are in include/linux/phy.h

Re: [PATCH net 1/3] bpf: fix incorrect pruning decision when alignment must be tracked

2017-05-24 Thread David Miller
From: Daniel Borkmann Date: Tue, 23 May 2017 18:30:41 +0200 > + if (!env->strict_alignment && old->off <= cur->off && You can't just test env->strict_alignment by itself, that's just an override and doesn't determine the actual "strict" value we use which is a combination of env->strict_alig

Re: [PATCH v6 net-next 01/17] net: qualcomm: remove unnecessary includes

2017-05-24 Thread Stefan Wahren
> David Miller hat am 24. Mai 2017 um 21:41 geschrieben: > > > From: Stefan Wahren > Date: Tue, 23 May 2017 15:12:37 +0200 > > > Most of the includes in qca_7k.c are unnecessary so we better remove them. > > > > Signed-off-by: Stefan Wahren > > --- > > drivers/net/ethernet/qualcomm/qca_7k.

Re: [PATCH net-next] geneve: fix fill_info when using collect_metadata

2017-05-24 Thread Eric Garver
On Wed, May 24, 2017 at 12:20:36PM -0700, Pravin Shelar wrote: > On Tue, May 23, 2017 at 3:37 PM, Eric Garver wrote: > > Since 9b4437a5b870 ("geneve: Unify LWT and netdev handling.") fill_info > > does not return UDP_ZERO_CSUM6_RX when using COLLECT_METADATA. This is > > because it uses ip_tunnel_

Re: [PATCH v3 net] net: phy: marvell: Limit errata to 88m1101

2017-05-24 Thread David Miller
From: Andrew Lunn Date: Tue, 23 May 2017 17:49:13 +0200 > The 88m1101 has an errata when configuring autoneg. However, it was > being applied to many other Marvell PHYs as well. Limit its scope to > just the 88m1101. > > Fixes: 76884679c644 ("phylib: Add support for Marvell 88eS and 88e1145"

Re: [PATCH] net/phy: fix mdio-octeon dependency and build

2017-05-24 Thread David Miller
From: Randy Dunlap Date: Tue, 23 May 2017 08:19:49 -0700 > From: Randy Dunlap > > Fix build errors by making this driver depend on OF_MDIO, like > several other similar drivers do. > > drivers/built-in.o: In function `octeon_mdiobus_remove': > mdio-octeon.c:(.text+0x196ee0): undefined referenc

Re: [pull request][net 0/8] Mellanox, mlx5 fixes 2017-05-23

2017-05-24 Thread David Miller
From: Saeed Mahameed Date: Tue, 23 May 2017 17:16:02 +0300 > This series contains some fixes for the mlx5 driver and one small patch that > adds csum actions accessors in include/net/tc_act/tc_csum.h needed by some of > mlx5 fixes patches. > > Details are below. > > Please pull and let me know

Re: [PATCH v6 net-next 01/17] net: qualcomm: remove unnecessary includes

2017-05-24 Thread David Miller
From: Stefan Wahren Date: Tue, 23 May 2017 15:12:37 +0200 > Most of the includes in qca_7k.c are unnecessary so we better remove them. > > Signed-off-by: Stefan Wahren > --- > drivers/net/ethernet/qualcomm/qca_7k.c | 4 > 1 file changed, 4 deletions(-) > > diff --git a/drivers/net/ethern

Re: [PATCH net] net/mlx4: Fix the check in attaching steering rules

2017-05-24 Thread David Miller
From: Tariq Toukan Date: Tue, 23 May 2017 15:50:07 +0300 > diff --git a/drivers/net/ethernet/mellanox/mlx4/en_ethtool.c > b/drivers/net/ethernet/mellanox/mlx4/en_ethtool.c > index ae5fdc2df654..00a7cd3dcc2e 100644 > --- a/drivers/net/ethernet/mellanox/mlx4/en_ethtool.c > +++ b/drivers/net/ethern

Re: [PATCH 2/2] at803x: double check SGMII side autoneg

2017-05-24 Thread Andrew Lunn
On Wed, May 24, 2017 at 01:58:09PM -0500, Timur Tabi wrote: > On 05/24/2017 09:09 AM, Andrew Lunn wrote: > > It could be, the copper side is up, but the SGMII side is down, at the > > point at803x_aneg_done() is called. So it is correctly returning > > 0. Sometime later the SGMII side goes up, but

[PATCH net-next 1/3] net: phy: Create sysfs reciprocal links for attached_dev/phydev

2017-05-24 Thread Florian Fainelli
There is currently no way for a program scanning /sys to know whether a network device is attached to a particular PHY device, just like the PHY device is not pointed back to its attached network device. Create a symbolic link in the network device's namespace named "phydev" which points to the PH

[PATCH net-next 3/3] net: sysfs: Document PHY device sysfs attributes

2017-05-24 Thread Florian Fainelli
Document the different sysfs attributes that exist for PHY devices: attached_dev, phy_has_fixups, phy_id and phy_interface. Signed-off-by: Florian Fainelli --- Documentation/ABI/testing/sysfs-class-net-phydev | 32 1 file changed, 32 insertions(+) create mode 100644 Doc

[PATCH net-next 2/3] net: sysfs: Document "phydev" symbolic link

2017-05-24 Thread Florian Fainelli
Now that we link the network device to its PHY device, document this sysfs symbolic link. Signed-off-by: Florian Fainelli --- Documentation/ABI/testing/sysfs-class-net | 8 1 file changed, 8 insertions(+) diff --git a/Documentation/ABI/testing/sysfs-class-net b/Documentation/ABI/testi

[PATCH net-next 0/3] net: phy: Create sysfs reciprocal links for attached_dev/phydev

2017-05-24 Thread Florian Fainelli
Hi David, Andrew, This patch series addresses a device topology shortcoming where a program scanning /sys would not be able to establish a mapping between the network device and the PHY device. In the process it turned out that no PHY device documentation existed for sysfs attributes. Thanks! F

RE: [PATCH net-next 1/8] net: ipv4: refactor __ip_route_output_key_hash

2017-05-24 Thread Rosen, Rami
Hi, Rupa /David Ahern, First, thanks for this patch set! Second, it seems to me that something might be incorrect here. You have these additions in this patch (1/8): ... +struct rtable *ip_route_output_key_hash_rcu(struct net *net, struct flowi4 *flp, +

Re: [PATCH] net: rtnetlink: bail out from rtnl_fdb_dump() on parse error

2017-05-24 Thread David Miller
From: Alexander Potapenko Date: Tue, 23 May 2017 13:20:28 +0200 > rtnl_fdb_dump() failed to check the result of nlmsg_parse(), which led > to contents of |ifm| being uninitialized because nlh->nlmsglen was too > small to accommodate |ifm|. The uninitialized data may affect some > branches and res

Re: pull-request: mac80211 2017-05-23

2017-05-24 Thread David Miller
From: Johannes Berg Date: Tue, 23 May 2017 14:42:55 +0200 > I have just two fixes here, one of the scheduled scan issue that > Sander Eikelenboom found, and the other properly makes mesh more > strictly check its extension headers. > > Please pull and let me know if there's any problem. Pulled,

Re: [PATCH] net: rtnetlink: bail out from rtnl_fdb_dump() on parse error

2017-05-24 Thread Greg Rose
On Tue, 2017-05-23 at 13:20 +0200, Alexander Potapenko wrote: > rtnl_fdb_dump() failed to check the result of nlmsg_parse(), which led > to contents of |ifm| being uninitialized because nlh->nlmsglen was too > small to accommodate |ifm|. The uninitialized data may affect some > branches and result

Re: [PATCH v2] net: fec: add post PHY reset delay DT property

2017-05-24 Thread David Miller
From: Quentin Schulz Date: Tue, 23 May 2017 11:48:08 +0200 > Some PHY require to wait for a bit after the reset GPIO has been > toggled. This adds support for the DT property `phy-reset-post-delay` > which gives the delay in milliseconds to wait after reset. > > If the DT property is not given,

Re: [PATCH net-next 2/4] nfp: register ports as devlink ports

2017-05-24 Thread Jakub Kicinski
On Wed, 24 May 2017 14:35:14 +0200, Jiri Pirko wrote: > >+void nfp_devlink_port_unregister(struct nfp_port *port) > >+{ > >+/* Due to unpleasant lock ordering we may see the port go away before > >+ * we have fully probed. > > Could you elaborate on this a bit more please? It's partiall

Re: [PATCH net 0/2] sctp: a bunch of fixes for processing dupcookie

2017-05-24 Thread David Miller
From: Xin Long Date: Tue, 23 May 2017 13:28:53 +0800 > After introducing transport hashtable and per stream info into sctp, > some regressions were caused when processing dupcookie, this patchset > is to fix them. Series applied, thanks.

Re: [PATCH net-next] geneve: fix fill_info when using collect_metadata

2017-05-24 Thread Pravin Shelar
On Tue, May 23, 2017 at 3:37 PM, Eric Garver wrote: > Since 9b4437a5b870 ("geneve: Unify LWT and netdev handling.") fill_info > does not return UDP_ZERO_CSUM6_RX when using COLLECT_METADATA. This is > because it uses ip_tunnel_info_af() with the device level info, which is > not valid for COLLECT_

Re: [PATCH v2 net-next 00/11] qed/qede: Mostly-cleanup series

2017-05-24 Thread David Miller
From: Yuval Mintz Date: Tue, 23 May 2017 09:41:17 +0300 > This series contains some cleanup of the qed and qede code: > - #1 contains mostly static/endian changes in order to allow qede to >pass sparse compilation cleanly. > - #2, #5 and #6 are either semantic or remove dead-code from drive

Re: [PATCH 2/2] at803x: double check SGMII side autoneg

2017-05-24 Thread Timur Tabi
On 05/24/2017 09:09 AM, Andrew Lunn wrote: > It could be, the copper side is up, but the SGMII side is down, at the > point at803x_aneg_done() is called. So it is correctly returning > 0. Sometime later the SGMII side goes up, but there is not a second > interrupt. Hence the phy core does not know

[PATCH net-next 1/8] net: ipv4: refactor __ip_route_output_key_hash

2017-05-24 Thread Roopa Prabhu
From: David Ahern A later patch wants access to the fib result on an output route lookup with the rcu lock held. Refactor __ip_route_output_key_hash, pushing the logic between rcu_read_lock ... rcu_read_unlock into a new helper that takes the fib_result as an input arg. To keep the name length u

[PATCH net-next 2/8] net: ipv4: refactor ip_route_input_noref

2017-05-24 Thread Roopa Prabhu
From: David Ahern A later patch wants access to the fib result on an input route lookup with the rcu lock held. Refactor ip_route_input_noref pushing the logic between rcu_read_lock ... rcu_read_unlock into a new helper that takes the fib_result as an input arg. Signed-off-by: David Ahern Signe

[PATCH net-next 8/8] net: ipv6: RTM_GETROUTE: return matched fib result when requested

2017-05-24 Thread Roopa Prabhu
From: Roopa Prabhu This patch adds support to return matched fib result when RTM_F_FIB_MATCH flag is specified in RTM_GETROUTE request. This is useful for user-space applications/controllers wanting to query a matching route. Signed-off-by: Roopa Prabhu --- net/ipv6/route.c | 36 ++

[PATCH net-next 0/8] net: extend RTM_GETROUTE to return fib result

2017-05-24 Thread Roopa Prabhu
From: Roopa Prabhu This series adds a new RTM_F_FIB_MATCH flag to return matched fib result with RTM_GETROUTE. This is useful for applications and protocols in userspace wanting to query the selected route. examples (with patched iproute2): ipv4: $ip route show default via 192.168.0.2 dev e

[PATCH net-next 5/8] net: ipv4: Save trie prefix to fib lookup result

2017-05-24 Thread Roopa Prabhu
From: David Ahern Prefix is needed for returning matching route spec on get route request. Signed-off-by: David Ahern Signed-off-by: Roopa Prabhu --- include/net/ip_fib.h | 1 + net/ipv4/fib_trie.c | 1 + 2 files changed, 2 insertions(+) diff --git a/include/net/ip_fib.h b/include/net/ip_fi

[PATCH net-next 3/8] net: ipv4: Remove event arg to rt_fill_info

2017-05-24 Thread Roopa Prabhu
From: David Ahern rt_fill_info has 1 caller with the event set to RTM_NEWROUTE. Given that remove the arg and use RTM_NEWROUTE directly in rt_fill_info. Signed-off-by: David Ahern Signed-off-by: Roopa Prabhu --- net/ipv4/route.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) di

[PATCH net-next 7/8] net: ipv4: RTM_GETROUTE: return matched fib result when requested

2017-05-24 Thread Roopa Prabhu
From: Roopa Prabhu This patch adds support to return matched fib result when RTM_F_FIB_MATCH flag is specified in RTM_GETROUTE request. This is useful for user-space applications/controllers wanting to query a matching route. Signed-off-by: Roopa Prabhu --- net/ipv4/route.c | 13 +++--

[PATCH net-next 6/8] net: ipv4: add new RTM_F_FIB_MATCH flag for use with RTM_GETROUTE

2017-05-24 Thread Roopa Prabhu
From: Roopa Prabhu This flag when specified will return matched fib result in response to a RTM_GETROUTE query. Signed-off-by: Roopa Prabhu --- include/uapi/linux/rtnetlink.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/uapi/linux/rtnetlink.h b/include/uapi/linux/rtnetlink.h ind

[PATCH net-next 4/8] net: ipv4: Convert inet_rtm_getroute to rcu versions of route lookup

2017-05-24 Thread Roopa Prabhu
From: David Ahern Convert inet_rtm_getroute to use ip_route_input_rcu and ip_route_output_key_hash_rcu passing the fib_result arg to both. The rcu lock is held through the creation of the response, so the rtable/dst does not need to be attached to the skb and is passed to rt_fill_info directly.

Re: [kernel-hardening] [PATCH v4 next 0/3] modules: automatic module loading restrictions

2017-05-24 Thread Djalal Harouni
On Tue, May 23, 2017 at 9:48 AM, Solar Designer wrote: >> >>> On Mon, May 22, 2017 at 2:08 PM, Solar Designer >> >>> wrote: >> >>> > On Mon, May 22, 2017 at 01:57:03PM +0200, Djalal Harouni wrote: >> >>> >> *) When modules_autoload_mode is set to (2), automatic module loading >> >>> >> is >> >>

Re: Deleting a dynamic mac entry..

2017-05-24 Thread Manohar Kumar
Thanks, Toshiaki. What is the right way to set the default_pvid using the bridge command ? I tried this, which fails.. root@net-3:~# ip link set dev vxlan0 name untagged type vlan id 0 RTNETLINK answers: Operation not supported root@net-3:~# All the interfaces in the bridge are untagged. thanks

  1   2   >