Re: [patch iproute2/net-next] tc: add support for TRAP action

2017-06-07 Thread Jiri Pirko
Mon, Jun 05, 2017 at 04:39:45PM CEST, j...@resnulli.us wrote: >From: Jiri Pirko > >Signed-off-by: Jiri Pirko Stephen, note that the kernel part was accepted in v2. Thanks. >--- > include/linux/pkt_cls.h | 5 + > tc/tc_util.c| 3 +++ > 2 files changed, 8 insertions(+) > >diff --gi

[patch net-next 3/3] mlxsw: spectrum: Pass port argument to module mapping functions

2017-06-07 Thread Jiri Pirko
From: Ido Schimmel Previous patch made it unnecessary to map ports to modules before we allocate their struct. We can now therefore pass the port struct to these functions, thereby making them consistent with other functions that operate on ports. Signed-off-by: Ido Schimmel Signed-off-by: Jiri

[patch net-next 0/3] mlxsw: Remove compatibility with old firmware

2017-06-07 Thread Jiri Pirko
From: Jiri Pirko Up until recently we couldn't enforce a minimal firmware version, which forced us to be compatible with old firmware versions. This patchset removes this code and simplifies the driver. Ido Schimmel (3): mlxsw: spectrum_router: Mark only first LPM tree as reserved mlxsw: spe

[patch net-next 2/3] mlxsw: spectrum: Simplify port split flow

2017-06-07 Thread Jiri Pirko
From: Ido Schimmel In commit be94535f9531 ("mlxsw: spectrum: Make split flow match firmware requirements") we had to modify the port split flow to overcome quirks in the device's firmware. This resulted in asymmetrical code with regards to port creation and removal. The problem in the firmware i

[patch net-next 1/3] mlxsw: spectrum_router: Mark only first LPM tree as reserved

2017-06-07 Thread Jiri Pirko
From: Ido Schimmel In new firmware versions (that we can now enforce via request_firmware()), only the first LPM tree is reserved and not the first two as in older versions. Signed-off-by: Ido Schimmel Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c | 2 +-

[patch net-next v2 02/19] net: bridge: Add support for offloading port attributes

2017-06-07 Thread Jiri Pirko
From: Arkadi Sharshevsky Currently the flood, learning and learning_sync port attributes are offloaded by setting the SELF flag. Add support for offloading the flood and learning attribute through the bridge code. In case of setting an unsupported flag on a offloded port the operation will fail.

[patch net-next v2 01/19] net: switchdev: Add support for querying supported bridge flags by hardware

2017-06-07 Thread Jiri Pirko
From: Arkadi Sharshevsky This is done as a preparation stage before setting the bridge port flags from the bridge code. Currently the device can be queried for the bridge flags state, but the querier cannot distinguish if the flag is disabled or if it is not supported at all. Thus, add new attr a

[patch net-next v2 03/19] net: bridge: Add support for calling FDB external learning under rcu

2017-06-07 Thread Jiri Pirko
From: Arkadi Sharshevsky This is done as a preparation to moving the switchdev notifier chain to be atomic. The FDB external learning should be called under rtnl or rcu. Signed-off-by: Arkadi Sharshevsky Reviewed-by: Ido Schimmel Reviewed-by: Nikolay Aleksandrov Signed-off-by: Jiri Pirko ---

[patch net-next v2 08/19] mlxsw: spectrum_switchdev: Add support for querying supported bridge flags

2017-06-07 Thread Jiri Pirko
From: Arkadi Sharshevsky Add support for querying supported bridge flags. Signed-off-by: Arkadi Sharshevsky Reviewed-by: Ido Schimmel Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethe

[patch net-next v2 06/19] net: bridge: Receive notification about successful FDB offload

2017-06-07 Thread Jiri Pirko
From: Arkadi Sharshevsky When a new static FDB is added to the bridge a notification is sent to the driver for offload. In case of successful offload the driver should notify the bridge back, which in turn should mark the FDB as offloaded. Currently, externally learned is equivalent for being of

[patch net-next v2 15/19] rocker: Add support for querying supported bridge flags

2017-06-07 Thread Jiri Pirko
From: Arkadi Sharshevsky Add support for querying supported bridge flags. Signed-off-by: Arkadi Sharshevsky Signed-off-by: Jiri Pirko --- drivers/net/ethernet/rocker/rocker.h | 4 drivers/net/ethernet/rocker/rocker_main.c | 18 ++ drivers/net/ethernet/rocker/rocke

[patch net-next v2 14/19] rocker: Remove support for bridge FDB learning sync

2017-06-07 Thread Jiri Pirko
From: Arkadi Sharshevsky Currently the rocker driver supports an option for disabling syncing the hardware learned FDBs with the software bridge. This behavior breaks the bridge offload model and thus it is removed. Signed-off-by: Arkadi Sharshevsky Signed-off-by: Jiri Pirko --- drivers/net/e

[patch net-next v2 13/19] net: Remove support for bridge bypass ndos from stacked devices

2017-06-07 Thread Jiri Pirko
From: Arkadi Sharshevsky Remove support for bridge bypass ndos from stacked devices. At this point no driver which supports stack device behavior offload supports operation with SELF flag. The case for upper device is already taken care of in both of the following cases: 1. FDB add/del - driver

[patch net-next v2 09/19] mlxsw: spectrum: Remove support for bypass bridge port attributes/vlan set

2017-06-07 Thread Jiri Pirko
From: Arkadi Sharshevsky The bridge port attributes/vlan for mlxsw devices should be set only from bridge code. The vlans are synced totally with the bridge so there is no need to special dump support. Signed-off-by: Arkadi Sharshevsky Reviewed-by: Ido Schimmel Signed-off-by: Jiri Pirko ---

[patch net-next v2 17/19] rocker: Add support for learning FDB through notification

2017-06-07 Thread Jiri Pirko
From: Arkadi Sharshevsky Add support for learning FDB through notification. The driver defers the hardware update via ordered work queue. Signed-off-by: Arkadi Sharshevsky Signed-off-by: Jiri Pirko --- drivers/net/ethernet/rocker/rocker_main.c | 140 -- 1 file chan

[patch net-next v2 19/19] rocker: Remove support bridge bypass FDB

2017-06-07 Thread Jiri Pirko
From: Arkadi Sharshevsky The FDB add/delete are now done through the notification chain. The FDBs are synced with the bridge and there is no need for extra dumping. Signed-off-by: Arkadi Sharshevsky Signed-off-by: Jiri Pirko --- drivers/net/ethernet/rocker/rocker.h | 3 -- drivers/net/

[patch net-next v2 16/19] rocker: Change world_ops API and implementation to be switchdev independant

2017-06-07 Thread Jiri Pirko
From: Arkadi Sharshevsky Currently the switchdev_trans struct is embedded in the world_ops API. In order to add support for adding FDB via a notfication chain the API should be switchdev independent. Signed-off-by: Arkadi Sharshevsky Signed-off-by: Jiri Pirko --- drivers/net/ethernet/rocker/r

[patch net-next v2 18/19] rocker: Remove support for bypass bridge port attributes/vlan set

2017-06-07 Thread Jiri Pirko
From: Arkadi Sharshevsky The bridge port attributes/vlan for mlxsw devices should be set only from bridge code. The vlans are synced totally with the bridge so there is no need to special dump support. Signed-off-by: Arkadi Sharshevsky Signed-off-by: Jiri Pirko --- drivers/net/ethernet/rocker

[patch net-next v2 12/19] mlxsw: spectrum: Remove support for bridge bypass FDB add/del

2017-06-07 Thread Jiri Pirko
From: Arkadi Sharshevsky The FDB add/del are now done through the notification chain. The FDBs are synced with the bridge and there is no need for extra dumping. Signed-off-by: Arkadi Sharshevsky Reviewed-by: Ido Schimmel Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/spec

[patch net-next v2 05/19] net: bridge: Add support for notifying devices about FDB add/del

2017-06-07 Thread Jiri Pirko
From: Arkadi Sharshevsky Currently the bridge doesn't notify the underlying devices about new FDBs learned. The FDB sync is placed on the switchdev notifier chain because devices may potentially learn FDB that are not directly related to their ports, for example: 1. Mixed SW/HW bridge - FDBs tha

[patch net-next v2 10/19] mlxsw: spectrum_switchdev: Change switchdev notifier API

2017-06-07 Thread Jiri Pirko
From: Arkadi Sharshevsky The current API for sending switchdev notifications implies only FDB add/del. In order to support notification about successful FDB offload the API is changed. Signed-off-by: Arkadi Sharshevsky Reviewed-by: Ido Schimmel Signed-off-by: Jiri Pirko --- .../net/ethernet/

[patch net-next v2 11/19] mlxsw: spectrum_switchdev: Add support for learning FDB through notification

2017-06-07 Thread Jiri Pirko
From: Arkadi Sharshevsky Add support for learning FDB through notification. The driver defers the hardware update via ordered work queue. Support for stacked devices is also provided. In case of a successful FDB add a notification is sent back to bridge. Signed-off-by: Arkadi Sharshevsky Review

[patch net-next v2 07/19] mlxsw: spectrum: Remove support for bridge FDB learning sync

2017-06-07 Thread Jiri Pirko
From: Arkadi Sharshevsky Currently the mlxsw driver supports an option for disabling syncing the hardware learned FDBs with the software bridge. This behavior breaks the bridge offload model and thus it is removed. Signed-off-by: Arkadi Sharshevsky Reviewed-by: Ido Schimmel Signed-off-by: Jiri

[patch net-next v2 04/19] net: switchdev: Change notifier chain to be atomic

2017-06-07 Thread Jiri Pirko
From: Arkadi Sharshevsky In order to use the switchdev notifier chain for FDB sync with the device it has to be changed to atomic. The is done because the bridge can learn new FDBs in atomic context. Signed-off-by: Arkadi Sharshevsky Reviewed-by: Ido Schimmel Reviewed-by: Ivan Vecera Signed-o

[patch net-next v2 00/19] Remove support from bridge bypass for mlxsw/rocker drivers

2017-06-07 Thread Jiri Pirko
From: Jiri Pirko Currently setting bridge port attributes and adding FDBs are done via setting the SELF flag which implies unconsistent offloading model. This patch-set fixes this behavior by making the bridge and drivers which are using it to be totally in sync. This implies several changes: -

Re: [PATCH net-next 00/16] nfp: ctrl vNIC

2017-06-07 Thread Jiri Pirko
Thu, Jun 08, 2017 at 08:33:11AM CEST, yuval.mi...@cavium.com wrote: >> >> >> >> >What were your plans with pre-netdev config? >> >> >> >> >> >> >> >> We need to pass come initial resource division. Generally the >> >> >> >> consensus is to have these options exposed through devlink, let >> >> >> >>

RE: [PATCH net-next 00/16] nfp: ctrl vNIC

2017-06-07 Thread Mintz, Yuval
> >> >> >> >What were your plans with pre-netdev config? > >> >> >> > >> >> >> We need to pass come initial resource division. Generally the > >> >> >> consensus is to have these options exposed through devlink, let > >> >> >> the user configure them all and then to have a trigger that > >> >> >> w

RE: [linuxwifi] [PATCH] net: wireless: intel: iwlwifi: dvm: fix tid mask

2017-06-07 Thread Grumbach, Emmanuel
Hi, > Subject: [linuxwifi] [PATCH] net: wireless: intel: iwlwifi: dvm: fix tid mask > > Currently the tid mask covers the first 4 bits of iwlagn_tx_resp::ra_tid, > which gives 16 possible values for tid. > This is problematic because IWL_MAX_TID_COUNT is 8, so indexing > iwl_priv::tid_data can go

[PATCH 2/2] drivers: net: emac: add const to mii_phy_ops structures

2017-06-07 Thread Bhumika Goyal
The object references of mii_phy_ops structures are only stored in the ops field of a mii_phy_def structure. This ops field is of type const. So, mii_phy_ops structures having similar properties can be declared as const. Signed-off-by: Bhumika Goyal --- drivers/net/ethernet/ibm/emac/phy.c | 12 +

[PATCH 1/2] drivers/net/sungem: add const to mii_phy_ops structures

2017-06-07 Thread Bhumika Goyal
The object references of mii_phy_ops structures are only stored in the ops field of a mii_phy_def structure. This ops field is of type const. So, mii_phy_ops structures having similar properties can be declared as const. Signed-off-by: Bhumika Goyal --- drivers/net/sungem_phy.c | 26

[PATCH 0/2] drivers: net: add const to mii_phy_ops structures

2017-06-07 Thread Bhumika Goyal
The object references of mii_phy_ops structures are only stored in the ops field of a mii_phy_def structure. This ops field is of type const. So, mii_phy_ops structures having similar properties can be declared as const. Bhumika Goyal (2): drivers/net/sungem: add const to mii_phy_ops structures

Re: [PATCH net-next 00/16] nfp: ctrl vNIC

2017-06-07 Thread Jiri Pirko
Wed, Jun 07, 2017 at 07:48:08PM CEST, yuval.mi...@cavium.com wrote: >> >> >> >What were your plans with pre-netdev config? >> >> >> >> >> >> We need to pass come initial resource division. Generally the >> >> >> consensus is to have these options exposed through devlink, let >> >> >> the user confi

[net-next 1/2] igb: make a few local functions static

2017-06-07 Thread Jeff Kirsher
From: Colin Ian King Clean up a few sparse warnings, these following functions can be made static: drivers/net/ethernet/intel/igb/igb_main.c: warning: symbol 'igb_add_mac_filter' was not declared. Should it be static? drivers/net/ethernet/intel/igb/igb_main.c: warning: symbol 'igb_del_mac_fi

[net-next 2/2] e1000e: Undo e1000e_pm_freeze if __e1000_shutdown fails

2017-06-07 Thread Jeff Kirsher
From: Chris Wilson An error during suspend (e100e_pm_suspend), [ 429.994338] ACPI : EC: event blocked [ 429.994633] e1000e: EEE TX LPI TIMER: 0011 [ 430.955451] pci_pm_suspend(): e1000e_pm_suspend+0x0/0x30 [e1000e] returns -2 [ 430.955454] dpm_run_callback(): pci_pm_suspend+0x0/0x140 ret

[net-next 0/2][pull request] 1GbE Intel Wired LAN Driver Updates 2017-06-07

2017-06-07 Thread Jeff Kirsher
This series contains a fix for e1000e and igb. Colin Ian King fixes sparse warnings in igb by making functions static. Chris Wilson provides a fix for a previous commit which is causing an issue during suspend "e1000e_pm_suspend()", where we need to run e1000e_pm_thaw() if __e1000_shutdown() is u

[PATCH net-next] cxgb4: fix to bring link down after adapter crash

2017-06-07 Thread Ganesh Goudar
From: Rahul Lakkireddy Use PORT_REG for T4 and T5_PORT_REG for > T4 to write to correct register to bring down link during shutdown after adapter crash. Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar --- drivers/net/ethernet/chelsio/cxgb4/t4_hw.c | 7 +++ 1 file changed, 3 i

Re: Netlink messages without NLM_F_REQUEST flag

2017-06-07 Thread Leon Romanovsky
On Wed, Jun 07, 2017 at 12:35:11PM -0600, Jason Gunthorpe wrote: > On Wed, Jun 07, 2017 at 09:18:10PM +0300, Leon Romanovsky wrote: > > > > AFAIK, that is different, that is acking and retriggering a single shot > > > notification, not completing a kernel initiated handshake. > > > > It is acking t

Re: [PATCH v3 2/2] ip6_tunnel: fix potential issue in __ip6_tnl_rcv

2017-06-07 Thread Alexei Starovoitov
On Thu, Jun 08, 2017 at 12:56:58PM +0800, 严海双 wrote: > > > On 8 Jun 2017, at 12:38 PM, Alexei Starovoitov > > wrote: > > > > On Thu, Jun 08, 2017 at 12:32:44PM +0800, Haishuang Yan wrote: > >> When __ip6_tnl_rcv fails, the tun_dst won't be freed, so call > >> dst_release to free it in error cod

Investment Interest & Offer

2017-06-07 Thread Seydou Thieba
We are a Fund management company located in the United Kingdom, we specialize in searching for potential investments opportunities for our high net-worth clients globally. Should this be of interest to you, please do not hesitate to email me for further information. Thanks Seydou Thieba --- T

Re: [PATCH v3 1/2] ip_tunnel: fix potential issue in ip_tunnel_rcv

2017-06-07 Thread Eric Dumazet
On Thu, 2017-06-08 at 12:32 +0800, Haishuang Yan wrote: > When ip_tunnel_rcv fails, the tun_dst won't be freed, so call > dst_release to free it in error code path. > > CC: Pravin B Shelar > Fixes: 2e15ea390e6f ("ip_gre: Add support to collect tunnel metadata.") > Signed-off-by: Haishuang Yan >

Re: [PATCH v3 2/2] ip6_tunnel: fix potential issue in __ip6_tnl_rcv

2017-06-07 Thread Eric Dumazet
On Wed, Jun 7, 2017 at 9:38 PM, Alexei Starovoitov wrote: > On Thu, Jun 08, 2017 at 12:32:44PM +0800, Haishuang Yan wrote: >> When __ip6_tnl_rcv fails, the tun_dst won't be freed, so call >> dst_release to free it in error code path. >> >> CC: Alexei Starovoitov >> Fixes: 8d79266bc48c ("ip6_tunne

Re: [PATCH v3 2/2] ip6_tunnel: fix potential issue in __ip6_tnl_rcv

2017-06-07 Thread Alexei Starovoitov
On Thu, Jun 08, 2017 at 12:32:44PM +0800, Haishuang Yan wrote: > When __ip6_tnl_rcv fails, the tun_dst won't be freed, so call > dst_release to free it in error code path. > > CC: Alexei Starovoitov > Fixes: 8d79266bc48c ("ip6_tunnel: add collect_md mode to IPv6 tunnels") > Signed-off-by: Haishua

[PATCH v3 2/2] ip6_tunnel: fix potential issue in __ip6_tnl_rcv

2017-06-07 Thread Haishuang Yan
When __ip6_tnl_rcv fails, the tun_dst won't be freed, so call dst_release to free it in error code path. CC: Alexei Starovoitov Fixes: 8d79266bc48c ("ip6_tunnel: add collect_md mode to IPv6 tunnels") Signed-off-by: Haishuang Yan --- Changes in v2: - Add the the missing Fixes information Chang

[PATCH v3 1/2] ip_tunnel: fix potential issue in ip_tunnel_rcv

2017-06-07 Thread Haishuang Yan
When ip_tunnel_rcv fails, the tun_dst won't be freed, so call dst_release to free it in error code path. CC: Pravin B Shelar Fixes: 2e15ea390e6f ("ip_gre: Add support to collect tunnel metadata.") Signed-off-by: Haishuang Yan --- Changes in v2: - Add the the missing Fixes information Changes

Re: [PATCH v2 1/2] ip_tunnel: fix potential issue in ip_tunnel_rcv

2017-06-07 Thread Pravin Shelar
On Wed, Jun 7, 2017 at 8:15 PM, Eric Dumazet wrote: > On Wed, 2017-06-07 at 19:13 -0700, Pravin Shelar wrote: >> On Wed, Jun 7, 2017 at 5:57 PM, Haishuang Yan >> wrote: >> > When ip_tunnel_rcv fails, the tun_dst won't be freed, so move >> > skb_dst_set to begin and tun_dst would be freed by kfree

[PATCH net-next 3/3] LiquidIO: lowmem: init allocated memory to 0

2017-06-07 Thread Felix Manlunas
From: Rick Farrington For defensive programming, zero the allocated block 'oct->droq[0]' in octeon_setup_output_queues() and 'oct->instr_queue[0]' in octeon_setup_instr_queues(). Signed-off-by: Rick Farrington Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas --- drivers/net/ethern

[PATCH net-next 2/3] LiquidIO: lowmem: do not dereference NULL ptr

2017-06-07 Thread Felix Manlunas
From: Rick Farrington Don't dereference a NULL ptr in octeon_droq_destroy_ring_buffers(). Signed-off-by: Rick Farrington Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/octeon_droq.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/dr

[PATCH net-next 1/3] LiquidIO: lowmem: init allocated memory to 0

2017-06-07 Thread Felix Manlunas
From: Rick Farrington Fix GPF in octeon_init_droq(); zero the allocated block 'recv_buf_list'. This prevents a GPF trying to access an invalid 'recv_buf_list[i]' entry in octeon_droq_destroy_ring_buffers() if init didn't alloc all entries. Signed-off-by: Rick Farrington Signed-off-by: Satanand

[PATCH net-next 0/3] LiquidIO: avoid VM low memory crashes

2017-06-07 Thread Felix Manlunas
From: Rick Farrington This patchset addresses issues brought about by low memory conditions in a VM. These conditions were only seen when VM's were intentionally created with small amounts of memory (for stress testing). 1. Fix GPF in octeon_init_droq(); zero the allocated block 'recv_buf_list'

Re: [PATCH v2 1/2] ip_tunnel: fix potential issue in ip_tunnel_rcv

2017-06-07 Thread Eric Dumazet
On Wed, 2017-06-07 at 19:13 -0700, Pravin Shelar wrote: > On Wed, Jun 7, 2017 at 5:57 PM, Haishuang Yan > wrote: > > When ip_tunnel_rcv fails, the tun_dst won't be freed, so move > > skb_dst_set to begin and tun_dst would be freed by kfree_skb. > > > > CC: Pravin B Shelar > > Fixes: 2e15ea390e6f

Re: [PATCH v2 1/2] ip_tunnel: fix potential issue in ip_tunnel_rcv

2017-06-07 Thread 严海双
> On 8 Jun 2017, at 10:13 AM, Pravin Shelar wrote: > > On Wed, Jun 7, 2017 at 5:57 PM, Haishuang Yan > wrote: >> When ip_tunnel_rcv fails, the tun_dst won't be freed, so move >> skb_dst_set to begin and tun_dst would be freed by kfree_skb. >> >> CC: Pravin B Shelar >> Fixes: 2e15ea390e6f ("i

Re: linux-next: build failure after merge of the wireless-drivers-next tree

2017-06-07 Thread Stephen Rothwell
Hi Igor, On Wed, 7 Jun 2017 19:43:18 -0700 Igor Mitsyanko wrote: > > thanks. As I understand, you've applied this patch during a merge and no > further actions are required, correct? Dave Miller will need to apply that patch (or something similar) when he merges the wireless-drivers-next tree

Re: [PATCH v2 2/2] ip6_tunnel: fix potential issue in __ip6_tnl_rcv

2017-06-07 Thread Alexei Starovoitov
On Thu, Jun 08, 2017 at 08:57:56AM +0800, Haishuang Yan wrote: > When __ip6_tnl_rcv fails, the tun_dst won't be freed, so move > skb_dst_set to begin and tun_dst would be freed by kfree_skb. > > CC: Alexei Starovoitov > Fixes: 8d79266bc48c ("ip6_tunnel: add collect_md mode to IPv6 tunnels") > Sig

Re: [RFC PATCH net-next 5/5] selftests/bpf: change test_verifier expectations

2017-06-07 Thread Alexei Starovoitov
On Wed, Jun 07, 2017 at 04:00:02PM +0100, Edward Cree wrote: > Some of the verifier's error messages have changed, and some constructs > that previously couldn't be verified are now accepted. > > Signed-off-by: Edward Cree > --- > tools/testing/selftests/bpf/test_verifier.c | 226 > +++

Re: linux-next: build failure after merge of the wireless-drivers-next tree

2017-06-07 Thread Igor Mitsyanko
On 06/07/2017 07:27 PM, Stephen Rothwell wrote: External Email Hi all, After merging the wireless-drivers-next tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/net/wireless/quantenna/qtnfmac/core.c: In function 'qtnf_core_net_attach': drivers/net/wireless/quant

Re: [RFC PATCH net-next 4/5] bpf/verifier: track signed and unsigned min/max values

2017-06-07 Thread Alexei Starovoitov
On Wed, Jun 07, 2017 at 03:59:25PM +0100, Edward Cree wrote: > Allows us to, sometimes, combine information from a signed check of one > bound and an unsigned check of the other. > We now track the full range of possible values, rather than restricting > ourselves to [0, 1<<30) and considering an

Re: [RFC PATCH net-next 3/5] bpf/verifier: feed pointer-to-unknown-scalar casts into scalar ALU path

2017-06-07 Thread Alexei Starovoitov
On Wed, Jun 07, 2017 at 03:58:50PM +0100, Edward Cree wrote: > If pointer leaks are allowed, and adjust_ptr_min_max_vals returns -EACCES, > treat the pointer as an unknown scalar and try again, because we might be > able to conclude something about the result (e.g. pointer & 0x40 is either > 0 o

Re: [RFC PATCH net-next 2/5] bpf/verifier: rework value tracking

2017-06-07 Thread Alexei Starovoitov
On Wed, Jun 07, 2017 at 03:58:31PM +0100, Edward Cree wrote: > Tracks value alignment by means of tracking known & unknown bits. > Tightens some min/max value checks and fixes a couple of bugs therein. > > Signed-off-by: Edward Cree > --- > include/linux/bpf.h | 34 +- > include/linux

linux-next: build failure after merge of the wireless-drivers-next tree

2017-06-07 Thread Stephen Rothwell
Hi all, After merging the wireless-drivers-next tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/net/wireless/quantenna/qtnfmac/core.c: In function 'qtnf_core_net_attach': drivers/net/wireless/quantenna/qtnfmac/core.c:319:5: error: 'struct net_device' has no member

Re: [PATCH v2 1/2] ip_tunnel: fix potential issue in ip_tunnel_rcv

2017-06-07 Thread Pravin Shelar
On Wed, Jun 7, 2017 at 5:57 PM, Haishuang Yan wrote: > When ip_tunnel_rcv fails, the tun_dst won't be freed, so move > skb_dst_set to begin and tun_dst would be freed by kfree_skb. > > CC: Pravin B Shelar > Fixes: 2e15ea390e6f ("ip_gre: Add support to collect tunnel metadata.") > Signed-off-by: H

Re: [PATCH v2 2/2] ip6_tunnel: fix potential issue in __ip6_tnl_rcv

2017-06-07 Thread Eric Dumazet
On Thu, 2017-06-08 at 08:57 +0800, Haishuang Yan wrote: > When __ip6_tnl_rcv fails, the tun_dst won't be freed, so move > skb_dst_set to begin and tun_dst would be freed by kfree_skb. > > CC: Alexei Starovoitov > Fixes: 8d79266bc48c ("ip6_tunnel: add collect_md mode to IPv6 tunnels") > Signed-off

Re: [PATCH v2 1/2] ip_tunnel: fix potential issue in ip_tunnel_rcv

2017-06-07 Thread Eric Dumazet
On Thu, 2017-06-08 at 08:57 +0800, Haishuang Yan wrote: > When ip_tunnel_rcv fails, the tun_dst won't be freed, so move > skb_dst_set to begin and tun_dst would be freed by kfree_skb. > > CC: Pravin B Shelar > Fixes: 2e15ea390e6f ("ip_gre: Add support to collect tunnel metadata.") > Signed-off-by

Re: [PATCH 2/2(net.git)] stmmac: fix for hw timestamp of GMAC3 unit

2017-06-07 Thread Andy Shevchenko
On Wed, Jun 7, 2017 at 11:45 AM, Mario Molitor wrote: > exit: > - return ret; > + if (likely(ret == 0)) > + return 1; > + else > + return 0; else is redundant. -- With Best Regards, Andy Shevchenko

Re: [PATCH net-next v2 5/5] net: dsa: Stop accessing ds->dst->cpu_dp in drivers

2017-06-07 Thread Vivien Didelot
Hi Florian, Florian Fainelli writes: >> Also I do not think that it is a good thing that a DSA driver play much >> in dsa_port structures (they are ideally DSA core only specific data). >> They only seem to need the master interface, so what I see is: >> >> static inline struct net_device *

[PATCH v2 2/2] ip6_tunnel: fix potential issue in __ip6_tnl_rcv

2017-06-07 Thread Haishuang Yan
When __ip6_tnl_rcv fails, the tun_dst won't be freed, so move skb_dst_set to begin and tun_dst would be freed by kfree_skb. CC: Alexei Starovoitov Fixes: 8d79266bc48c ("ip6_tunnel: add collect_md mode to IPv6 tunnels") Signed-off-by: Haishuang Yan --- net/ipv6/ip6_tunnel.c | 6 +++--- 1 file ch

[PATCH v2 1/2] ip_tunnel: fix potential issue in ip_tunnel_rcv

2017-06-07 Thread Haishuang Yan
When ip_tunnel_rcv fails, the tun_dst won't be freed, so move skb_dst_set to begin and tun_dst would be freed by kfree_skb. CC: Pravin B Shelar Fixes: 2e15ea390e6f ("ip_gre: Add support to collect tunnel metadata.") Signed-off-by: Haishuang Yan --- net/ipv4/ip_tunnel.c | 6 +++--- 1 file change

Re: [PATCH net-next v2 5/5] net: dsa: Stop accessing ds->dst->cpu_dp in drivers

2017-06-07 Thread Florian Fainelli
On 06/07/2017 04:24 PM, Vivien Didelot wrote: > Hi Florian, > > Sorry to bother you again, I don't want to be annoying but I might not > get things right still. > > Florian Fainelli writes: > > So as I said in v2, now that a driver is guaranteed that dp->cpu_dp is > correctly assigned a

Re: linux-next: build failure after merge of the net tree

2017-06-07 Thread David Miller
From: Stephen Rothwell Date: Thu, 8 Jun 2017 10:08:58 +1000 > I applied the following merge fix patch for today. > > From: Stephen Rothwell > Date: Thu, 8 Jun 2017 09:49:26 +1000 > Subject: [PATCH] net: fix up for "Fix inconsistent teardown and release of > private netdev state" > > Signed-of

Re: [PATCH 1/2] ip_tunnel: fix potential issue in ip_tunnel_rcv

2017-06-07 Thread 严海双
> On 7 Jun 2017, at 10:48 PM, Eric Dumazet wrote: > > On Wed, 2017-06-07 at 22:16 +0800, Haishuang Yan wrote: >> When ip_tunnel_rcv fails, the tun_dst won't be freed, so move >> skb_dst_set to begin and tun_dst would be freed by kfree_skb. >> >> Signed-off-by: Haishuang Yan >> --- > > Please

linux-next: build failure after merge of the net tree

2017-06-07 Thread Stephen Rothwell
Hi all, After merging the net tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c: In function 'rtw_cfg80211_add_monitor_if': drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:2670:10: error: 'struct net_device' has no member

[PATCH RFC net-next 1/4] net/mlx5e: Rearrange netdevice ops structures

2017-06-07 Thread Saeed Mahameed
Since we are going to allow compiling the driver without eswitch, it means we will have to compile out mlx5e_netdev_ops_sriov and will replace it with mlx5e_netdev_ops_basic. Move missing vxlan ndos into mlx5e_netdev_ops_basic. Rearrange some ndos in mlx5e_netdev_ops_sriov and put vf/eswitch rela

[PATCH RFC net-next 0/4] Mellanox, MLX5 E-Switch break down

2017-06-07 Thread Saeed Mahameed
Based on Jes Sorensen work to make eswitch_offloads optional at compilation time, here is an initial RFC series that provides similar behavior, but here we do more accurate zoom in into eswitch and we break it into two HW components (MPFS & ESWITCH) to not break any functionality, and provide more

[PATCH RFC net-next 3/4] net/mlx5: Separate between eswitch and MPFS l2 table logic

2017-06-07 Thread Saeed Mahameed
Multi-Physical Function Switch (MPFs) is required for when multi-PF configuration is enabled to allow passing user configured unicast MAC addresses to the requesting PF. Before this patch eswitch.c used to manage the HW MPFS l2 table, eswitch always enabled vport(0) (NIC PF) vport's contexts updat

[PATCH RFC net-next 4/4] net/mlx5: Add CONFIG_MLX5_ESWITCH Kconfig

2017-06-07 Thread Saeed Mahameed
This patch gives the option to chose whether to compile the driver with or without eswitch/eswitch_offloads(switchdev mode)/en_rep(VF representors) and en_tc offloads. It also removes most of the above modules headers declarations and stubs out the API functions which are used outside these module

[PATCH RFC net-next 2/4] net/mlx5e: NIC netdev init flow cleanup

2017-06-07 Thread Saeed Mahameed
Remove redundant mlx5_eswitch_unregister_vport_rep in mlx5e_add error flow. Hide mlx5e_rep_priv and eswitch internal structures from en_main.c in preparation for downstream patches which allows compiling the driver without en_rep and eswitch. Signed-off-by: Saeed Mahameed --- drivers/net/ethern

YOUR PAYMENT

2017-06-07 Thread Barrister Mike Obi
Hello Beneficiary. I will send you the payment information only if contact me and assure me that you are the rightful person to receive $6.5Million Dollars. If you do not contact me I will cancel the money transfer as I will then know that this is not the rightful person.contact Phone+229683

Re: [PATCH net-next v2 5/5] net: dsa: Stop accessing ds->dst->cpu_dp in drivers

2017-06-07 Thread Vivien Didelot
Hi Florian, Sorry to bother you again, I don't want to be annoying but I might not get things right still. Florian Fainelli writes: So as I said in v2, now that a driver is guaranteed that dp->cpu_dp is correctly assigned at setup time, isn't better (especially for future multi-C

Re: [PATCH v3 3/3] net/cxgb4: Use new PCI_DEV_FLAGS_NO_RELAXED_ORDERING flag

2017-06-07 Thread Alexander Duyck
On Wed, Jun 7, 2017 at 2:16 AM, Ding Tianhong wrote: > From: Casey Leedom > > cxgb4 Ethernet driver now queries Root Complex Port to determine if it can > send TLPs to it with the Relaxed Ordering Attribute set. > > Signed-off-by: Casey Leedom > Signed-off-by: Ding Tianhong So I am pretty sure

Re: [PATCH net] net: Zero ifla_vf_info in rtnl_fill_vfinfo()

2017-06-07 Thread Greg Rose
On 06/07/2017 11:00 AM, Yuval Mintz wrote: Some of the structure's fields are not initialized by the rtnetlink. If driver doesn't set those in ndo_get_vf_config(), they'd leak memory to user. Signed-off-by: Yuval Mintz CC: Michal Schmidt --- net/core/rtnetlink.c | 3 ++- 1 file changed, 2 i

Re: Question about tcp_filter() in tcp_v6_do_rcv()

2017-06-07 Thread Eric Dumazet
On Wed, 2017-06-07 at 15:35 -0700, Chenbo Feng wrote: > Hello everybody, > > I am testing eBPF programs on ipv6 and I just find out the tcp_filter() > function (previously named sk_filter()) is called both in tcp_v6_rcv() > and tcp_v6_do_rcv(). In contrast, it is only called by tcp_v4_rcv() in

[PATCH net v2 2/3] netvsc: fix net poll mode

2017-06-07 Thread Stephen Hemminger
The ndo_poll_controller function needs to schedule NAPI to pick up arriving packets and send completions. Otherwise no data will ever be received. For simple case of netconsole, it also will allow send completions to happen. Without this netpoll will eventually get stuck. Signed-off-by: Stephen H

[PATCH net v2 1/3] netvsc: fix rcu dereference warning from ethtool

2017-06-07 Thread Stephen Hemminger
The ethtool info command calls the netvsc get_sset_count with RTNL but not with RCU. Which causes warning: drivers/net/hyperv/netvsc_drv.c:1010 suspicious rcu_dereference_check() usage! Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/netvsc_drv.c | 2 +- 1 file changed, 1 insertion(+),

[PATCH net v2 0/3] netvsc: bug fixes

2017-06-07 Thread Stephen Hemminger
These are bugfixes for netvsc driver in 4.12. Stephen Hemminger (3): netvsc: fix rcu dereference warning from ethtool netvsc: fix net poll mode netvsc: move filter setting to rndis_device drivers/net/hyperv/hyperv_net.h | 5 ++-- drivers/net/hyperv/netvsc_drv.c | 54 +-

[PATCH net v2 3/3] netvsc: move filter setting to rndis_device

2017-06-07 Thread Stephen Hemminger
The work queue and handling of network filter parameters should be in rndis_device. This gets rid of warning from RCU checks, eliminates a race and cleans up code. Signed-off-by: Stephen Hemminger --- v2 - instead of adding locking to do_set_mulitcast, move the workqueue to rndis portion of

Re: [PATCH v3 5/6] dt-bindings: display: amlogic: DT fix s/resets-names/reset-names/

2017-06-07 Thread Rob Herring
On Fri, Jun 02, 2017 at 02:38:48PM +0200, Geert Uytterhoeven wrote: > Fixes: 8cceda5349377e30 ("dt-bindings: Add bindings for the Amlogic Meson > dw-hdmi extension") > Signed-off-by: Geert Uytterhoeven > --- > v3: > - New. > --- > Documentation/devicetree/bindings/display/amlogic,meson-dw-hdmi

Re: [PATCH v3 6/6] dt-bindings: net: btusb: DT fix s/interrupt-name/interrupt-names/

2017-06-07 Thread Rob Herring
On Fri, Jun 02, 2017 at 02:38:49PM +0200, Geert Uytterhoeven wrote: > Fixes: fd913ef7ce619467 ("Bluetooth: btusb: Add out-of-band wakeup support") > Signed-off-by: Geert Uytterhoeven > --- > v3: > - New. > --- > Documentation/devicetree/bindings/net/btusb.txt | 2 +- > 1 file changed, 1 inserti

Re: ath9k_htc - Division by zero in kernel (as well as firmware panic)

2017-06-07 Thread Tobias Diedrich
Oleksij Rempel wrote: > Am 07.06.2017 um 02:12 schrieb Tobias Diedrich: > > Oleksij Rempel wrote: > >> Yes, this is "normal" problem. The firmware has no error handler for PCI > >> bus related exceptions. So if we filed to read PCI bus first time, we > >> have choice to Ooops and stall or Ooops and

Question about tcp_filter() in tcp_v6_do_rcv()

2017-06-07 Thread Chenbo Feng
Hello everybody, I am testing eBPF programs on ipv6 and I just find out the tcp_filter() function (previously named sk_filter()) is called both in tcp_v6_rcv() and tcp_v6_do_rcv(). In contrast, it is only called by tcp_v4_rcv() in ipv4 layer. I guess this implementation is used to capture some

[PATCH] net: wireless: intel: iwlwifi: dvm: fix tid mask

2017-06-07 Thread Seraphime Kirkovski
Currently the tid mask covers the first 4 bits of iwlagn_tx_resp::ra_tid, which gives 16 possible values for tid. This is problematic because IWL_MAX_TID_COUNT is 8, so indexing iwl_priv::tid_data can go very wrong. With UBSAN I can it happening while establishing the first connection after module

[PATCH net-next v2 0/5] net: dsa: add cross-chip VLAN support

2017-06-07 Thread Vivien Didelot
The current code in DSA does not support cross-chip VLAN. This means that in a multi-chip environment such as this one (similar to ZII Rev B) [CPU] (mdio) (eth0) | : : : _|_______ [__sw0__]--[__sw1__]--[__sw2_

[PATCH net-next v2 4/5] net: dsa: mv88e6xxx: exclude all ports in new VLAN

2017-06-07 Thread Vivien Didelot
Now that the DSA core adds the CPU and DSA ports itself to the new VLAN entry, there is no need to include them as members of this VLAN when initializing a new VTU entry. As of now, initialize a new VTU entry with all ports excluded. Reviewed-by: Florian Fainelli Signed-off-by: Vivien Didelot -

[PATCH net-next v2 3/5] net: dsa: add CPU and DSA ports as VLAN members

2017-06-07 Thread Vivien Didelot
In a multi-chip switch fabric, it is currently the responsibility of the driver to add the CPU or DSA (interconnecting chips together) ports as members of a new VLAN entry. This makes the drivers more complicated. We want the DSA drivers to be stupid and the DSA core being the one responsible for

[PATCH net-next v2 2/5] net: dsa: check VLAN capability of every switch

2017-06-07 Thread Vivien Didelot
Now that the VLAN object is propagated to every switch chip of the switch fabric, we can easily ensure that they all support the required VLAN operations before modifying an entry on a single switch. To achieve that, remove the condition skipping other target switches, and add a bitmap of VLAN mem

[PATCH net-next v2 5/5] net: dsa: mv88e6xxx: do not skip ports on VLAN del

2017-06-07 Thread Vivien Didelot
The mv88e6xxx driver currently tries to be smart and remove by itself a VLAN entry from the VTU when the driven switch sees no user ports as members of the VLAN. This is bad in a multi-chip switch fabric, since a chip in between others may have no bridge port members, but still needs to be aware o

[PATCH net-next v2 1/5] net: dsa: mv88e6xxx: define membership on VLAN add

2017-06-07 Thread Vivien Didelot
Define the target port membership of the VLAN entry in mv88e6xxx_port_vlan_add where ds is scoped. Allow the DSA core to call later the port_vlan_add operation for CPU or DSA ports, by using the Unmodified membership for these ports, as in the current behavior. Reviewed-by: Florian Fainelli Sign

Re: [PATCH V2 1/3] Documentation: devicetree: add multiple cpu port DSA binding

2017-06-07 Thread Andrew Lunn
On Wed, Jun 07, 2017 at 04:10:02PM -0500, Rob Herring wrote: > On Tue, May 30, 2017 at 02:32:29PM -0700, Florian Fainelli wrote: > > On 05/30/2017 03:44 AM, John Crispin wrote: > > > Extend the DSA binding documentation, adding the new property required > > > when there is more than one CPU port at

Re: [PATCH V2 1/3] Documentation: devicetree: add multiple cpu port DSA binding

2017-06-07 Thread Florian Fainelli
On 06/07/2017 02:10 PM, Rob Herring wrote: > On Tue, May 30, 2017 at 02:32:29PM -0700, Florian Fainelli wrote: >> On 05/30/2017 03:44 AM, John Crispin wrote: >>> Extend the DSA binding documentation, adding the new property required >>> when there is more than one CPU port attached to the switch. >

[PATCH net-next 0/3] rxrpc: Tx length parameter

2017-06-07 Thread David Howells
Julia Lawall for reporting this. The patches can be found here also: http://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/log/?h=rxrpc-rewrite Tagged thusly: git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git rxrpc-rewrite-20170607-v2 David

[PATCH net-next 3/3] rxrpc: Provide a cmsg to specify the amount of Tx data for a call

2017-06-07 Thread David Howells
Provide a control message that can be specified on the first sendmsg() of a client call or the first sendmsg() of a service response to indicate the total length of the data to be transmitted for that call. Currently, because the length of the payload of an encrypted DATA packet is encrypted in fr

[PATCH net-next 1/3] rxrpc: Provide a getsockopt call to query what cmsgs types are supported

2017-06-07 Thread David Howells
Provide a getsockopt() call that can query what cmsg types are supported by AF_RXRPC. --- Documentation/networking/rxrpc.txt |9 + include/linux/rxrpc.h | 24 ++-- net/rxrpc/af_rxrpc.c | 30 +- 3 files chan

  1   2   3   >