Re: [PATCH net-next 1/3] bluetooth: 6lowpan dev_close never returns error

2017-07-21 Thread Marcel Holtmann
Hi Stephen, > [auto build test WARNING on net-next/master] > > url: > https://github.com/0day-ci/linux/commits/Stephen-Hemminger/net-make-dev_close-void/20170720-090123 > config: x86_64-randconfig-a0-07211734 (attached as .config) > compiler: gcc-4.4 (Debian 4.4.7-8) 4.4.7 > reproduce: >

Re: [PATCH 1/2] net: ethernet: ti: cpts: convert to use kthread_worker

2017-07-21 Thread Richard Cochran
On Fri, Jul 21, 2017 at 06:49:42PM -0500, Grygorii Strashko wrote: > There could be significant delay in CPTS work schedule under high system > load and on -RT which could cause CPTS misbehavior due to internal counter > overflow. Usage of own kthread_worker allows to avoid such kind of issues > an

Re: [PATCH v7 2/3] PCI: Enable PCIe Relaxed Ordering if supported

2017-07-21 Thread Ding Tianhong
Hi Sinan, Bjorn: On 2017/7/14 21:54, Sinan Kaya wrote: > On 7/13/2017 9:26 PM, Ding Tianhong wrote: >> There is no code to enable the PCIe Relaxed Ordering bit in the >> configuration space, >> it is only be enable by default according to the PCIe Standard >> Specification, what we >> do is to d

Re: 4.12.0: igb: transmit queue 7 timed out

2017-07-21 Thread Cong Wang
(Cc netdev and Intel) On Tue, Jul 18, 2017 at 1:57 PM, Justin Piszcz wrote: > Hello, > > Kernel: 4.12.0 > Arch: x86_64 > > What causes this issue? It is likely a igb driver issue. > > [199141.434449] NETDEV WATCHDOG: eth1 (igb): transmit queue 7 timed out > [199141.434501] [ cut h

[PATCH 1/2] net: ethernet: ti: cpts: convert to use kthread_worker

2017-07-21 Thread Grygorii Strashko
There could be significant delay in CPTS work schedule under high system load and on -RT which could cause CPTS misbehavior due to internal counter overflow. Usage of own kthread_worker allows to avoid such kind of issues and makes it possible to tune priority of CPTS kthread_worker thread on -RT (

[PATCH 0/2] net: ethernet: ti: cpts: fix tx timestamping timeout

2017-07-21 Thread Grygorii Strashko
With the low Ethernet connection speed cpdma notification about packet processing can be received before CPTS TX timestamp event, which is set when packet actually left CPSW while cpdma notification is sent when packet pushed in CPSW fifo. As result, when connection is slow and CPU is fast enough T

[PATCH 2/2] net: ethernet: ti: cpts: fix tx timestamping timeout

2017-07-21 Thread Grygorii Strashko
With the low speed Ethernet connection CPDMA notification about packet processing can be received before CPTS TX timestamp event, which is set when packet actually left CPSW while cpdma notification is sent when packet pushed in CPSW fifo. As result, when connection is slow and CPU is fast enough

Re: [PATCH iproute2 master 1/2] bpf: improve error reporting around tail calls

2017-07-21 Thread Stephen Hemminger
On Fri, 21 Jul 2017 21:13:06 +0200 Daniel Borkmann wrote: > Currently, it's still quite hard to figure out if a prog passed the > verifier, but later gets rejected due to different tail call ownership. > Figure out whether that is the case and provide appropriate error > messages to the user. >

SELinux/IP_PASSSEC regression in 4.13-rcX

2017-07-21 Thread Paul Moore
Hello, I've been seeing a SELinux regression with IP_PASSSEC on the v4.13-rcX kernels and finally tracked the problem down to the skb_release_head_state() call in __udp_queue_rcv_skb(). Looking at the code and the git log it would appear that the likely culprit is 0a463c78d25b ("udp: avoid a cach

Re: [PATCH net] ipv6: no need to return rt->dst.error if it is not null entry.

2017-07-21 Thread Roopa Prabhu
On Fri, Jul 21, 2017 at 11:42 AM, Cong Wang wrote: > On Thu, Jul 20, 2017 at 8:23 AM, Hangbin Liu wrote: >> 2017-07-20 23:06 GMT+08:00 Hangbin Liu : +++ b/net/ipv6/route.c @@ -3637,12 +3637,6 @@ static int inet6_rtm_getroute(struct sk_buff *in_skb, struct nlmsghdr *nlh,

[PATCH] net: stmmac: Adjust dump offset of DMA registers for ethtool

2017-07-21 Thread thor . thayer
From: Thor Thayer The commit fbf68229ffe7 ("net: stmmac: unify registers dumps methods") in the Linux kernel modified the register dump to store the DMA registers at the DMA register offset (0x1000) but ethtool (stmmac.c) looks for the DMA registers after the MAC registers which is offset 55. Th

Re: A buggy behavior for Linux TCP Reno and HTCP

2017-07-21 Thread Yuchung Cheng
On Fri, Jul 21, 2017 at 1:46 PM, Neal Cardwell wrote: > On Fri, Jul 21, 2017 at 4:27 PM, Lisong Xu wrote: >> >> Hi Yuchung, >> >> This test scenario is only one example to trigger this bug. In general, as >> long as cwnd <4, the undo function has this bug. > > > Yes, personally I agree that this

Re: A buggy behavior for Linux TCP Reno and HTCP

2017-07-21 Thread Neal Cardwell
On Fri, Jul 21, 2017 at 4:27 PM, Lisong Xu wrote: > > Hi Yuchung, > > This test scenario is only one example to trigger this bug. In general, as > long as cwnd <4, the undo function has this bug. Yes, personally I agree that this seems like an issue that is general enough to be worth fixing. In

Re: [RFC 1/2] net-next: add a dma_desc element to struct skb_shared_info

2017-07-21 Thread Florian Westphal
John Crispin wrote: > When the flow offloading engine forwards a packet to the DMA it will send > additional info to the sw path. this includes > * physical switch port > * internal flow hash - this is required to populate the correct flow table > entry > * ppe state - this indicates what state th

Re: A buggy behavior for Linux TCP Reno and HTCP

2017-07-21 Thread Lisong Xu
Hi Yuchung, This test scenario is only one example to trigger this bug. In generally, as long as cwnd <4, the undo function has this bug. This would not be a problem for a normal network. But might be an issue, if the network is highly congested (e.g., many many TCP flows with small cwnd <4)

Re: A buggy behavior for Linux TCP Reno and HTCP

2017-07-21 Thread Lisong Xu
Hi Yuchung, This test scenario is only one example to trigger this bug. In general, as long as cwnd <4, the undo function has this bug. This would not be a problem for a normal network. But might be an issue, if the network is highly congested (e.g., many many TCP flows with small cwnd <4).

Re: [RFC 1/2] net-next: add a dma_desc element to struct skb_shared_info

2017-07-21 Thread David Miller
From: John Crispin Date: Fri, 21 Jul 2017 19:01:57 +0200 > When the flow offloading engine forwards a packet to the DMA it will > send additional info to the sw path. this includes > * physical switch port > * internal flow hash - this is required to populate the correct flow > * table entry > *

[PATCH iproute2 master 1/2] bpf: improve error reporting around tail calls

2017-07-21 Thread Daniel Borkmann
Currently, it's still quite hard to figure out if a prog passed the verifier, but later gets rejected due to different tail call ownership. Figure out whether that is the case and provide appropriate error messages to the user. Signed-off-by: Daniel Borkmann --- lib/bpf.c | 226 +

[PATCH iproute2 master 0/2] Minor BPF updates

2017-07-21 Thread Daniel Borkmann
Two minor updates to the BPF code, first one makes use of the recently exposed owner_jited in fdinfo to report whether a load issue related to tail calls occured, and second one fixes up custom mount of bpf fs when passed via env. Thanks! Daniel Borkmann (2): bpf: improve error reporting around

[PATCH iproute2 master 2/2] bpf: fix mnt path when from env

2017-07-21 Thread Daniel Borkmann
When bpf fs mount path is from env, behavior is currently broken as we continue to search in default paths, thus fix this up. Signed-off-by: Daniel Borkmann --- lib/bpf.c | 55 +-- 1 file changed, 45 insertions(+), 10 deletions(-) diff --git a

Re: [PATCH V2 1/4] net-next: dsa: move struct dsa_device_ops to the global header file

2017-07-21 Thread David Miller
A proper patch series submission must always have a proper "[PATCH 0/N] ..." header posting that explains at a high level what the patch series does, how it is doing it, and why it is doing it that way. Thank you.

Re: [PATCH net-next 1/2] rxrpc: Expose UAPI definitions to userspace

2017-07-21 Thread Joe Perches
On Fri, 2017-07-21 at 19:29 +0100, David Howells wrote: > Move UAPI definitions from the internal header and place them in a UAPI > header file so that userspace can make use of them. Please use git format-patch -M to make the rename clearer.

Re: commit 16ecba59 breaks 82574L under heavy load.

2017-07-21 Thread Lennart Sorensen
On Thu, Jul 20, 2017 at 04:44:55PM -0700, Benjamin Poirier wrote: > Could you please test the following patch and let me know if it: > 1) reduces the interrupt rate of the Other msi-x vector > 2) avoids the link flaps > or > 3) logs some dmesg warnings of the form "Other interrupt with unhandled [.

[PATCH] netvsc: fix ptr_ret.cocci warnings

2017-07-21 Thread kbuild test robot
drivers/net/hyperv/netvsc_drv.c:737:8-14: WARNING: PTR_ERR_OR_ZERO can be used Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR Generated by: scripts/coccinelle/api/ptr_ret.cocci Fixes: 9749fed5d43d ("netvsc: use ERR_PTR to avoid dereference issues") CC: stephen hemminger Signed-off-

Re: [Patch net] net: check mac address length for dev_set_mac_address()

2017-07-21 Thread Cong Wang
On Thu, Jul 20, 2017 at 11:27 AM, Cong Wang wrote: > diff --git a/net/core/dev_ioctl.c b/net/core/dev_ioctl.c > index 82fd4c9c4a1b..3f41601d7b7c 100644 > --- a/net/core/dev_ioctl.c > +++ b/net/core/dev_ioctl.c > @@ -262,6 +262,8 @@ static int dev_ifsioc(struct net *net, struct ifreq *ifr, > unsig

Re: [PATCH 4/5] e1000e: Separate signaling for link check/link up

2017-07-21 Thread Lennart Sorensen
On Fri, Jul 21, 2017 at 11:36:26AM -0700, Benjamin Poirier wrote: > Lennart reported the following race condition: > > \ e1000_watchdog_task > \ e1000e_has_link > \ hw->mac.ops.check_for_link() === e1000e_check_for_copper_link > /* link is up */ > mac->get_link_

Re: [PATCH 5/5] e1000e: Avoid receiver overrun interrupt bursts

2017-07-21 Thread Lennart Sorensen
On Fri, Jul 21, 2017 at 11:36:27AM -0700, Benjamin Poirier wrote: > When e1000e_poll() is not fast enough to keep up with incoming traffic, the > adapter (when operating in msix mode) raises the Other interrupt to signal > Receiver Overrun. > > This is a double problem because 1) at the moment e10

Re: [PATCH net] ipv6: no need to return rt->dst.error if it is not null entry.

2017-07-21 Thread Cong Wang
On Thu, Jul 20, 2017 at 8:23 AM, Hangbin Liu wrote: > 2017-07-20 23:06 GMT+08:00 Hangbin Liu : >>> +++ b/net/ipv6/route.c >>> @@ -3637,12 +3637,6 @@ static int inet6_rtm_getroute(struct sk_buff >>> *in_skb, struct nlmsghdr *nlh, >>> dst = ip6_route_lookup(net, &fl6, 0); >>> >>>

[PATCH 1/5] e1000e: Fix error path in link detection

2017-07-21 Thread Benjamin Poirier
In case of error from e1e_rphy(), the loop will exit early and "success" will be set to true erroneously. Signed-off-by: Benjamin Poirier --- drivers/net/ethernet/intel/e1000e/phy.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/intel/e1000e/phy.c

[PATCH 3/5] e1000e: Fix return value test

2017-07-21 Thread Benjamin Poirier
All the helpers return -E1000_ERR_PHY. Signed-off-by: Benjamin Poirier --- drivers/net/ethernet/intel/e1000e/netdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c index 58a87134d2e5..f

[PATCH 5/5] e1000e: Avoid receiver overrun interrupt bursts

2017-07-21 Thread Benjamin Poirier
When e1000e_poll() is not fast enough to keep up with incoming traffic, the adapter (when operating in msix mode) raises the Other interrupt to signal Receiver Overrun. This is a double problem because 1) at the moment e1000_msix_other() assumes that it is only called in case of Link Status Change

[PATCH 2/5] e1000e: Fix wrong comment related to link detection

2017-07-21 Thread Benjamin Poirier
Reading e1000e_check_for_copper_link() shows that get_link_status is set to false after link has been detected. Therefore, it stays TRUE until then. Signed-off-by: Benjamin Poirier --- drivers/net/ethernet/intel/e1000e/netdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --gi

[PATCH 4/5] e1000e: Separate signaling for link check/link up

2017-07-21 Thread Benjamin Poirier
Lennart reported the following race condition: \ e1000_watchdog_task \ e1000e_has_link \ hw->mac.ops.check_for_link() === e1000e_check_for_copper_link /* link is up */ mac->get_link_status = false; /* interrupt */

[patch net-next] mlxsw: spectrum_router: Don't batch neighbour deletion

2017-07-21 Thread Jiri Pirko
From: Ido Schimmel Current firmware supported by the driver doesn't support batch deletion of IPv6 neighbours on a given router interface (RIF). Until a new version that supports this functionality is made available, delete neighbours one by one. Signed-off-by: Ido Schimmel Signed-off-by: Jiri

[PATCH net-next 0/2] rxrpc: Rearrange headers

2017-07-21 Thread David Howells
rxrpc-rewrite-20170721 David --- David Howells (2): rxrpc: Expose UAPI definitions to userspace rxrpc: Move the packet.h include file into net/rxrpc/ fs/afs/misc.c |1 fs/afs/rxrpc.c |1 include/linux/rxrpc.h | 79 --- inc

[PATCH net-next 1/2] rxrpc: Expose UAPI definitions to userspace

2017-07-21 Thread David Howells
Move UAPI definitions from the internal header and place them in a UAPI header file so that userspace can make use of them. Signed-off-by: David Howells --- include/linux/rxrpc.h | 79 --- include/uapi/linux/rxrpc.h | 80 +

[PATCH net-next 2/2] rxrpc: Move the packet.h include file into net/rxrpc/

2017-07-21 Thread David Howells
Move the protocol description header file into net/rxrpc/ and rename it to protocol.h. It's no longer necessary to expose it as packets are no longer exposed to kernel services (such as AFS) that use the facility. The abort codes are transferred to the UAPI header instead as we pass these back to

Re: [PATCH v2 3/4] net: ethernet: nb8800: Fix RGMII TX clock delay setup

2017-07-21 Thread Florian Fainelli
On 07/21/2017 07:24 AM, Måns Rullgård wrote: > Marc Gonzalez writes: > >> On 21/07/2017 15:47, Måns Rullgård wrote: >> >>> Marc Gonzalez wrote: >>> On 21/07/2017 15:04, Måns Rullgård wrote: > Marc Gonzalez wrote: > >> According to commit e5f3a4a56ce2a707b2fb8ce37e4414dcac89c

Re: [PATCH v2 2/4] net: ethernet: nb8800: Set RGMII_MODE for all RGMII modes

2017-07-21 Thread Florian Fainelli
On 07/21/2017 04:25 AM, Marc Gonzalez wrote: > There are 4 RGMII phy-modes to handle. ... so make sure that the MAC is configured to set the RGMII_MODE accordingly for all 4 RGMII mode. > > Signed-off-by: Marc Gonzalez Fixes: 52dfc8301248 ("net: ethernet: add driver for Aurora VLSI NB8800 Ethe

Re: A buggy behavior for Linux TCP Reno and HTCP

2017-07-21 Thread Yuchung Cheng
On Thu, Jul 20, 2017 at 2:28 PM, Wei Sun wrote: > Hi Yuchung, > > Sorry for the confusion. The test case was adapted from an old DSACK > test case (i.e., forget to remove something). > > Attached is a new and simple one. Thanks Note that the test scenario is fairly rare IMO: the connection first

Re: [RFC 1/2] net-next: add a dma_desc element to struct skb_shared_info

2017-07-21 Thread John Crispin
On 21/07/17 17:56, Paolo Abeni wrote: Hi, On Fri, 2017-07-21 at 17:20 +0200, John Crispin wrote: In order to make HW flow offloading work in latest MediaTek silicon we need to propagate part of the RX DMS descriptor to the upper layers populating the flow offload engines HW tables. This patch

Re: [patch net-next] mlxsw: spectrum_router: Don't ignore IPv6 notifications

2017-07-21 Thread Ido Schimmel
On Fri, Jul 21, 2017 at 06:05:23PM +0200, Jiri Pirko wrote: > From: Ido Schimmel > > We now have all the necessary IPv6 infrastructure in place, so stop > ignoring these notifications. > > Signed-off-by: Ido Schimmel > Signed-off-by: Jiri Pirko Dave, we sent the wrong patch. Please ignore. T

[PATCH net] net/socket: fix type in assignment and trim long line

2017-07-21 Thread Paolo Abeni
The commit ffb07550c76f ("copy_msghdr_from_user(): get rid of field-by-field copyin") introduce a new sparse warning: net/socket.c:1919:27: warning: incorrect type in assignment (different address spaces) net/socket.c:1919:27:expected void *msg_control net/socket.c:1919:27:got void [noder

Re: [PATCHv2 net] ipv6: should not return rt->dst.error if it is prohibit or blk hole entry.

2017-07-21 Thread kbuild test robot
Hi Hangbin, [auto build test WARNING on net/master] url: https://github.com/0day-ci/linux/commits/Hangbin-Liu/ipv6-should-not-return-rt-dst-error-if-it-is-prohibit-or-blk-hole-entry/20170721-204554 config: x86_64-randconfig-x003-07211556 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3

pull-request: wireless-drivers 2017-07-21

2017-07-21 Thread Kalle Valo
Hi Dave, important fixes for net which had accumulated while I was away. I only applied the brcmfmac and rtlwifi patches only eight hours ago and I haven't seen the kbuild report yet so they might have some build breakage in theory. But the patches are so small so the chances that they would break

Re: commit 16ecba59 breaks 82574L under heavy load.

2017-07-21 Thread Lennart Sorensen
On Fri, Jul 21, 2017 at 11:27:09AM -0400, wrote: > On Thu, Jul 20, 2017 at 04:44:55PM -0700, Benjamin Poirier wrote: > > Could you please test the following patch and let me know if it: > > 1) reduces the interrupt rate of the Other msi-x vector > > 2) avoids the link flaps > > or > > 3) logs some

[patch net] mlxsw: spectrum_router: Don't offload routes next in list

2017-07-21 Thread Jiri Pirko
From: Ido Schimmel Each FIB node holds a linked list of routes sharing the same prefix and length. In the case of IPv4 it's ordered according to table ID, metric and TOS and only the first route in the list is actually programmed to the device. In case a gatewayed route is added somewhere in the

[patch net-next] mlxsw: spectrum_router: Don't ignore IPv6 notifications

2017-07-21 Thread Jiri Pirko
From: Ido Schimmel We now have all the necessary IPv6 infrastructure in place, so stop ignoring these notifications. Signed-off-by: Ido Schimmel Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --gi

Re: [PATCH net] ipv6: no need to return rt->dst.error if it is not null entry.

2017-07-21 Thread David Ahern
On 7/20/17 9:23 AM, Hangbin Liu wrote: > diff --git a/net/ipv6/route.c b/net/ipv6/route.c > index 4d30c96..c290aa4 100644 > --- a/net/ipv6/route.c > +++ b/net/ipv6/route.c > @@ -3637,13 +3637,8 @@ static int inet6_rtm_getroute(struct sk_buff > *in_skb, struct nlmsghdr *nlh, > dst =

Re: [iovisor-dev] [PATCH net 0/2] bpf: fix verifier min/max handling in BPF_SUB

2017-07-21 Thread Nadav Amit
Edward Cree via iovisor-dev wrote: > I managed to come up with a test for the swapped bounds in BPF_SUB, so here > it is along with a patch that fixes it, separated out from my 'rewrite > everything' series so it can go to -stable. > > Edward Cree (2): > selftests/bpf: subtraction bounds test >

Re: [RFC 1/2] net-next: add a dma_desc element to struct skb_shared_info

2017-07-21 Thread Paolo Abeni
Hi, On Fri, 2017-07-21 at 17:20 +0200, John Crispin wrote: > In order to make HW flow offloading work in latest MediaTek silicon we need > to propagate part of the RX DMS descriptor to the upper layers populating > the flow offload engines HW tables. This patch adds an extra element to > struct sk

Re: [PATCH] net: ethernet: ti: cpsw: Push the request_irq function to the end of probe

2017-07-21 Thread Grygorii Strashko
On 07/20/2017 11:45 PM, Keerthy wrote: On Friday 21 July 2017 04:14 AM, Grygorii Strashko wrote: On 07/20/2017 05:28 PM, David Miller wrote: From: Grygorii Strashko Date: Thu, 20 Jul 2017 11:08:09 -0500 In general patch looks good to me, but it's really unexpected to receive IRQs while

Re: [PATCHv2 net] ipv6: should not return rt->dst.error if it is prohibit or blk hole entry.

2017-07-21 Thread kbuild test robot
Hi Hangbin, [auto build test ERROR on net/master] url: https://github.com/0day-ci/linux/commits/Hangbin-Liu/ipv6-should-not-return-rt-dst-error-if-it-is-prohibit-or-blk-hole-entry/20170721-204554 config: m68k-sun3_defconfig (attached as .config) compiler: m68k-linux-gcc (GCC) 4.9.0 reproduce

Re: commit 16ecba59 breaks 82574L under heavy load.

2017-07-21 Thread Lennart Sorensen
On Thu, Jul 20, 2017 at 04:44:55PM -0700, Benjamin Poirier wrote: > Could you please test the following patch and let me know if it: > 1) reduces the interrupt rate of the Other msi-x vector > 2) avoids the link flaps > or > 3) logs some dmesg warnings of the form "Other interrupt with unhandled [.

[RFC 1/2] net-next: add a dma_desc element to struct skb_shared_info

2017-07-21 Thread John Crispin
In order to make HW flow offloading work in latest MediaTek silicon we need to propagate part of the RX DMS descriptor to the upper layers populating the flow offload engines HW tables. This patch adds an extra element to struct skb_shared_info allowing the ethernet drivers RX napi code to store th

[RFC 2/2] net-next: mediatek: populate the shared

2017-07-21 Thread John Crispin
When enabling HW flow offloading, the traffic coming in on either of the GMACs is first sent to the PPE for processing. Any traffic not offloaded at this point will then be forwarded to the normal RX DMA ring for SW path processing. In this case the PPE will send additional data inside RXD4 that is

[RFC 0/2] net-next: hw flow offloading

2017-07-21 Thread John Crispin
Hi, I managed to bring up the flow offloading on latest MedieTek silicon. When enabling HW flow offloading, the traffic coming in on either of the GMACs is first sent to the PPE for processing. Any traffic not offloaded at this point will then be forwarded to the normal RX DMA ring for SW path pr

[PATCH] lib: test_rhashtable: fix for large entry counts

2017-07-21 Thread Phil Sutter
During concurrent access testing, threadfunc() concatenated thread ID and object index to create a unique key like so: | tdata->objs[i].value = (tdata->id << 16) | i; This breaks if a user passes an entries parameter of 64k or higher, since 'i' might use more than 16 bits then. Effectively, this

[PATCH] iwlwifi: Demote messages about fw flags size to info

2017-07-21 Thread João Paulo Rechi Vita
These messages are not reporting a real error, just the fact that the firmware knows about more flags then the driver. Currently these messages are presented to the user during boot if there is no bootsplash covering the console, sometimes even if the boot splash is enabled but has not started yet

Re: [PATCH v2 1/4] net: phy: at803x: Document RGMII RX and TX clock delay issues

2017-07-21 Thread Marc Gonzalez
On 21/07/2017 16:06, Timur Tabi wrote: > On 7/21/17 8:29 AM, Marc Gonzalez wrote: > >> I don't understand what you're saying. >> >> It is a correct observation that the code enabling >> RGMII RX clock delay is a NOP, since that bit will >> always be set at that point. >> >> The spec for the 8035 (

Re: [PATCH net 2/2] bpf/verifier: fix min/max handling in BPF_SUB

2017-07-21 Thread Daniel Borkmann
On 07/21/2017 03:37 PM, Edward Cree wrote: We have to subtract the src max from the dst min, and vice-versa, since (e.g.) the smallest result comes from the largest subtrahend. Fixes: 484611357c19 ("bpf: allow access into map value arrays") Signed-off-by: Edward Cree LGTM, thanks for the fi

Re: [PATCH net 1/2] selftests/bpf: subtraction bounds test

2017-07-21 Thread Daniel Borkmann
On 07/21/2017 03:36 PM, Edward Cree wrote: There is a bug in the verifier's handling of BPF_SUB: [a,b] - [c,d] yields was [a-c, b-d] rather than the correct [a-d, b-c]. So here is a test which, with the bogus handling, will produce ranges of [0,0] and thus allowed accesses; whereas the cor

Re: [PATCH v2 3/4] net: ethernet: nb8800: Fix RGMII TX clock delay setup

2017-07-21 Thread Måns Rullgård
Marc Gonzalez writes: > On 21/07/2017 15:47, Måns Rullgård wrote: > >> Marc Gonzalez wrote: >> >>> On 21/07/2017 15:04, Måns Rullgård wrote: >>> Marc Gonzalez wrote: > According to commit e5f3a4a56ce2a707b2fb8ce37e4414dcac89c672 > ("Documentation: devicetree: clarify usage of t

Re: [PATCH v2 3/4] net: ethernet: nb8800: Fix RGMII TX clock delay setup

2017-07-21 Thread Marc Gonzalez
On 21/07/2017 15:47, Måns Rullgård wrote: > Marc Gonzalez wrote: > >> On 21/07/2017 15:04, Måns Rullgård wrote: >> >>> Marc Gonzalez wrote: >>> According to commit e5f3a4a56ce2a707b2fb8ce37e4414dcac89c672 ("Documentation: devicetree: clarify usage of the RGMII phy-modes") there are

Re: [PATCH v2 1/4] net: phy: at803x: Document RGMII RX and TX clock delay issues

2017-07-21 Thread Timur Tabi
On 7/21/17 8:29 AM, Marc Gonzalez wrote: I don't understand what you're saying. It is a correct observation that the code enabling RGMII RX clock delay is a NOP, since that bit will always be set at that point. The spec for the 8035 (I haven't checked for 8030 and 8031, is that what you meant b

[RFC PATCH] IP: do not modify ingress packet IP option in ip_options_echo()

2017-07-21 Thread Paolo Abeni
While computing the response option set for LRSS, ip_options_echo() also changes the ingress packet LRSS addresses list, setting the last one to the dst specific address for the ingress packet - via memset(start[ ... The only visible effect of such change - beyond possibly damaging shared/cloned sk

Re: [PATCH v2 3/4] net: ethernet: nb8800: Fix RGMII TX clock delay setup

2017-07-21 Thread Måns Rullgård
Marc Gonzalez writes: > On 21/07/2017 15:04, Måns Rullgård wrote: > >> Marc Gonzalez wrote: >> >>> According to commit e5f3a4a56ce2a707b2fb8ce37e4414dcac89c672 >>> ("Documentation: devicetree: clarify usage of the RGMII phy-modes") >>> there are 4 RGMII modes to handle: >>> >>> "rgmii" (RX and T

Re: [PATCH v2 3/4] net: ethernet: nb8800: Fix RGMII TX clock delay setup

2017-07-21 Thread Marc Gonzalez
On 21/07/2017 15:04, Måns Rullgård wrote: > Marc Gonzalez wrote: > >> According to commit e5f3a4a56ce2a707b2fb8ce37e4414dcac89c672 >> ("Documentation: devicetree: clarify usage of the RGMII phy-modes") >> there are 4 RGMII modes to handle: >> >> "rgmii" (RX and TX delays are added by the MAC when

[PATCH net 2/2] bpf/verifier: fix min/max handling in BPF_SUB

2017-07-21 Thread Edward Cree
We have to subtract the src max from the dst min, and vice-versa, since (e.g.) the smallest result comes from the largest subtrahend. Fixes: 484611357c19 ("bpf: allow access into map value arrays") Signed-off-by: Edward Cree --- kernel/bpf/verifier.c | 21 +++-- 1 file changed,

[PATCH net 1/2] selftests/bpf: subtraction bounds test

2017-07-21 Thread Edward Cree
There is a bug in the verifier's handling of BPF_SUB: [a,b] - [c,d] yields was [a-c, b-d] rather than the correct [a-d, b-c]. So here is a test which, with the bogus handling, will produce ranges of [0,0] and thus allowed accesses; whereas the correct handling will give a range of [-255, 255]

[PATCH net 0/2] bpf: fix verifier min/max handling in BPF_SUB

2017-07-21 Thread Edward Cree
I managed to come up with a test for the swapped bounds in BPF_SUB, so here it is along with a patch that fixes it, separated out from my 'rewrite everything' series so it can go to -stable. Edward Cree (2): selftests/bpf: subtraction bounds test bpf/verifier: fix min/max handling in BPF_SUB

Re: [PATCH v2 1/4] net: phy: at803x: Document RGMII RX and TX clock delay issues

2017-07-21 Thread Marc Gonzalez
On 21/07/2017 15:20, Timur Tabi wrote: > On 7/21/17 6:25 AM, Marc Gonzalez wrote: > >> + * NB: This code assumes that RGMII RX clock delay is disabled >> + * at reset, but actually, RX clock delay is enabled at reset. > > Could we change this to say, "RX clock delay is enabled at reset on

Re: [PATCH v2 1/4] net: phy: at803x: Document RGMII RX and TX clock delay issues

2017-07-21 Thread Timur Tabi
On 7/21/17 6:25 AM, Marc Gonzalez wrote: +* NB: This code assumes that RGMII RX clock delay is disabled +* at reset, but actually, RX clock delay is enabled at reset. Could we change this to say, "RX clock delay is enabled at reset on some systems."? Otherwise, it implies that

Re: [Patch net] team: use a larger struct for mac address

2017-07-21 Thread kbuild test robot
Hi Cong, [auto build test WARNING on net/master] url: https://github.com/0day-ci/linux/commits/Cong-Wang/team-use-a-larger-struct-for-mac-address/20170721-203849 config: xtensa-allyesconfig (attached as .config) compiler: xtensa-linux-gcc (GCC) 4.9.0 reproduce: wget https

Re: [PATCH v2 0/4] RGMII RX and TX clock delays using Atheros 8035

2017-07-21 Thread Marc Gonzalez
On 21/07/2017 14:47, Marc Gonzalez wrote: > fping caps at 1000 packets per second, which limits > its usefulness as a benchmarking tool. "Normal" ping is slightly faster (5000 packets per second). time ping -f -c 6 -s 1450 -q 172.27.64.1 --- 172.27.64.1 ping statistics --- 6 packets tra

Re: [Patch net] team: use a larger struct for mac address

2017-07-21 Thread kbuild test robot
Hi Cong, [auto build test ERROR on net/master] url: https://github.com/0day-ci/linux/commits/Cong-Wang/team-use-a-larger-struct-for-mac-address/20170721-203849 config: i386-randconfig-x019-07211017 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce

Re: [PATCH v2 3/4] net: ethernet: nb8800: Fix RGMII TX clock delay setup

2017-07-21 Thread Måns Rullgård
Marc Gonzalez writes: > According to commit e5f3a4a56ce2a707b2fb8ce37e4414dcac89c672 > ("Documentation: devicetree: clarify usage of the RGMII phy-modes") > there are 4 RGMII modes to handle: > > "rgmii" (RX and TX delays are added by the MAC when required) > "rgmii-id" (RGMII with internal RX an

Re: [PATCH v2 2/4] net: ethernet: nb8800: Set RGMII_MODE for all RGMII modes

2017-07-21 Thread Måns Rullgård
Marc Gonzalez writes: > There are 4 RGMII phy-modes to handle. > > Signed-off-by: Marc Gonzalez Acked-by: Mans Rullgard > --- > drivers/net/ethernet/aurora/nb8800.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/aurora/nb8800.c > b/drivers/net/

Re: [PATCH v2 0/4] RGMII RX and TX clock delays using Atheros 8035

2017-07-21 Thread Marc Gonzalez
On 21/07/2017 13:22, Marc Gonzalez wrote: > Changes from v1 > - Drop support for disabling RX and TX clock delays > (it breaks some boards). Document the issues instead. > - Split the MAC patch in two unrelated parts > - Fix the vantage 1172 DTS > > Marc Gonzalez (4): > net: phy: at803x: Docume

Backwards route when adding IPv6 peer?

2017-07-21 Thread Fabian Pietsch
Hi, this looks backwards to me: | root@blackbox:~# ip -6 addr add fd12:3456:789a::1 peer fd99::::1/48 dev sit0 | root@blackbox:~# ip -6 route show dev sit0 | fd12:3456:789a::/48 proto kernel metric 256 pref medium | fd99::::1 proto kernel metric 256 pref medium | root@blackbox

[PATCH v2 3/4] net: ethernet: nb8800: Fix RGMII TX clock delay setup

2017-07-21 Thread Marc Gonzalez
According to commit e5f3a4a56ce2a707b2fb8ce37e4414dcac89c672 ("Documentation: devicetree: clarify usage of the RGMII phy-modes") there are 4 RGMII modes to handle: "rgmii" (RX and TX delays are added by the MAC when required) "rgmii-id" (RGMII with internal RX and TX delays provided by the PHY,

[PATCH v2 1/4] net: phy: at803x: Document RGMII RX and TX clock delay issues

2017-07-21 Thread Marc Gonzalez
The current code supports enabling RGMII RX and TX clock delays. The unstated assumption is that these settings are disabled by default at reset, which is not the case. RX clock delay is enabled at reset. And TX clock delay "survives" across SW resets. Thus, if the bootloader enables TX clock dela

[PATCH v2 2/4] net: ethernet: nb8800: Set RGMII_MODE for all RGMII modes

2017-07-21 Thread Marc Gonzalez
There are 4 RGMII phy-modes to handle. Signed-off-by: Marc Gonzalez --- drivers/net/ethernet/aurora/nb8800.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/aurora/nb8800.c b/drivers/net/ethernet/aurora/nb8800.c index 041cfb7952f8..ded041dbafe7 100644 --

[PATCH v2 0/4] RGMII RX and TX clock delays using Atheros 8035

2017-07-21 Thread Marc Gonzalez
Changes from v1 - Drop support for disabling RX and TX clock delays (it breaks some boards). Document the issues instead. - Split the MAC patch in two unrelated parts - Fix the vantage 1172 DTS Marc Gonzalez (4): net: phy: at803x: Document RGMII RX and TX clock delay issues net: ethernet: nb88

[PATCH v2 4/4] ARM: dts: tango4: Add RGMII RX and TX clock delays

2017-07-21 Thread Marc Gonzalez
RX and TX clock delays are required. Signed-off-by: Marc Gonzalez --- arch/arm/boot/dts/tango4-vantage-1172.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/tango4-vantage-1172.dts b/arch/arm/boot/dts/tango4-vantage-1172.dts index 86d8df98802f..13bcc460b

Re: [PATCH] bluetooth: document config options

2017-07-21 Thread Marcel Holtmann
Hi Pavel, >>> Kernel config options should include useful help text; I had to look >>> up the terms on wikipedia. >>> >>> Signed-off-by: Pavel Machek >>> >>> diff --git a/net/bluetooth/Kconfig b/net/bluetooth/Kconfig >>> index 68f951b..133c8a6 100644 >>> --- a/net/bluetooth/Kconfig >>> +++ b/ne

Re: [PATCH net v2] udp: preserve skb->dst if required for IP options processing

2017-07-21 Thread Artem Savkov
On Tue, Jul 18, 2017 at 11:57:55AM +0200, Paolo Abeni wrote: > Eric noticed that in udp_recvmsg() we still need to access > skb->dst while processing the IP options. > Since commit 0a463c78d25b ("udp: avoid a cache miss on dequeue") > skb->dst is no more available at recvmsg() time and bad things >

[PATCH net-next v2 0/6] Allow to switch off UDP-based tunnel offloads per netdevice

2017-07-21 Thread Sabrina Dubroca
This patchset adds a new netdevice feature to toggle RX offloads of UDP-based tunnel via ethtool. This is useful if the offload is causing issues, for example if the hardware is buggy. The feature is added to all devices providing the ->ndo_udp_tunnel_add op, and enabled by default to preserve cur

[PATCH net-next v2 1/6] net: add new netdevice feature for offload of RX port for UDP tunnels

2017-07-21 Thread Sabrina Dubroca
This adds a new netdevice feature, so that the offloading of RX port for UDP tunnels can be disabled by the administrator on some netdevices, using the "rx-udp_tunnel-port-offload" feature in ethtool. This feature is set for all devices that provide ndo_udp_tunnel_add. Signed-off-by: Sabrina Dubr

[PATCH net-next v2 5/6] geneve/vxlan: add support for NETDEV_UDP_TUNNEL_DROP_INFO

2017-07-21 Thread Sabrina Dubroca
Signed-off-by: Sabrina Dubroca --- drivers/net/geneve.c | 19 +-- drivers/net/vxlan.c | 25 + 2 files changed, 30 insertions(+), 14 deletions(-) diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c index de8156c6b292..ee52233750f7 100644 --- a/drivers

[PATCH net-next v2 4/6] net: call udp_tunnel_get_rx_info when NETIF_F_RX_UDP_TUNNEL_PORT is toggled

2017-07-21 Thread Sabrina Dubroca
NETIF_F_RX_UDP_TUNNEL_PORT is special, in that we need to do more than just flip the bit in dev->features. When disabling we must also clear currently offloaded ports from the device, and when enabling we must tell the device to offload the ports it can. Because vxlan stores its sockets in a hasht

[PATCH net-next v2 6/6] geneve/vxlan: offload ports on register/unregister events

2017-07-21 Thread Sabrina Dubroca
This improves consistency of handling when moving a netdev to another netns. Most drivers currently do a full reset when the device goes up, so that will flush the offload state anyway. Signed-off-by: Sabrina Dubroca --- drivers/net/geneve.c | 7 ++- drivers/net/vxlan.c | 10 +++--- 2

[PATCH net-next v2 3/6] net: add infrastructure to un-offload UDP tunnel port

2017-07-21 Thread Sabrina Dubroca
This adds a new NETDEV_UDP_TUNNEL_DROP_INFO event, similar to NETDEV_UDP_TUNNEL_PUSH_INFO, to signal to un-offload ports. This also adds udp_tunnel_drop_rx_port(), which calls ndo_udp_tunnel_del. Signed-off-by: Sabrina Dubroca --- include/linux/netdevice.h | 1 + include/net/udp_tunnel.h | 8

[PATCH net-next v2 2/6] net: check UDP tunnel RX port offload feature before calling tunnel ndo ndo

2017-07-21 Thread Sabrina Dubroca
If NETIF_F_RX_UDP_TUNNEL_PORT was disabled on a given netdevice, skip the tunnel offload ndo call during tunnel port creation and deletion. Signed-off-by: Sabrina Dubroca --- net/ipv4/udp_tunnel.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/net/ipv4/udp_tunnel.c b/n

Re: [PATCH] bluetooth: document config options

2017-07-21 Thread Pavel Machek
Hi! > > Kernel config options should include useful help text; I had to look > > up the terms on wikipedia. > > > > Signed-off-by: Pavel Machek > > > > diff --git a/net/bluetooth/Kconfig b/net/bluetooth/Kconfig > > index 68f951b..133c8a6 100644 > > --- a/net/bluetooth/Kconfig > > +++ b/net/blue

Re: [PATCH net-next 1/3] bluetooth: 6lowpan dev_close never returns error

2017-07-21 Thread kbuild test robot
Hi Stephen, [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Stephen-Hemminger/net-make-dev_close-void/20170720-090123 config: x86_64-randconfig-a0-07211734 (attached as .config) compiler: gcc-4.4 (Debian 4.4.7-8) 4.4.7 reproduce: # save the a

Re: [PATCH] bluetooth: document config options

2017-07-21 Thread Marcel Holtmann
Hi Pavel, > Kernel config options should include useful help text; I had to look > up the terms on wikipedia. > > Signed-off-by: Pavel Machek > > diff --git a/net/bluetooth/Kconfig b/net/bluetooth/Kconfig > index 68f951b..133c8a6 100644 > --- a/net/bluetooth/Kconfig > +++ b/net/bluetooth/Kconfi

Re: [PATCH net-next 2/8] netvsc: add some rtnl_dereference annotations

2017-07-21 Thread kbuild test robot
Hi Stephen, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Stephen-Hemminger/netvsc-lockdep-and-related-fixes/20170720-191938 config: x86_64-rhel (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: # save the attac

Re: [PATCH 0/4] Configuring traffic classes via new hardware offload mechanism in tc/mqprio

2017-07-21 Thread Richard Cochran
On Mon, May 22, 2017 at 12:31:12PM -0700, Jeff Kirsher wrote: > On Fri, 2017-05-19 at 17:58 -0700, Amritha Nambiar wrote: > > The following series introduces a new harware offload mode in tc/mqprio > > where the TCs, the queue configurations and bandwidth rate limits are > > offloaded to the hardwa

[PATCH] ceph: kernel client startsync can be removed

2017-07-21 Thread Yanhu Cao
kernel client is still sending write,startsync. that startsync is a no-op (has been for years) and can probably be removed Link: http://tracker.ceph.com/issues/20604 Signed-off-by: Yanhu Cao --- fs/ceph/addr.c | 9 ++--- fs/ceph/file.c | 5 + include/linux/ceph/r

  1   2   >