[PATCH net-next] cxgb4: Clear On FLASH config file after a FW upgrade

2017-08-07 Thread Ganesh Goudar
From: Arjun Vynipadath Because Firmware and the Firmware Configuration File need to be in sync; clear out any On-FLASH Firmware Configuration File when new Firmware is loaded. This will avoid difficult to diagnose and fix problems with a mis-matched Firmware Configuration

Re: [PATCHv2 net] net: sched: set xt_tgchk_param par.net properly in ipt_init_target

2017-08-07 Thread Jiri Pirko
Tue, Aug 08, 2017 at 04:13:27AM CEST, lucien@gmail.com wrote: >Now xt_tgchk_param par in ipt_init_target is a local varibale, >par.net is not initialized there. Later when xt_check_target >calls target's checkentry in which it may access par.net, it >would cause kernel panic. > >Jaroslav found

Re: [Patch net-next] net_sched: get rid of some forward declarations

2017-08-07 Thread Jiri Pirko
Tue, Aug 08, 2017 at 12:26:50AM CEST, xiyou.wangc...@gmail.com wrote: >If we move up tcf_fill_node() we can get rid of these >forward declarations. > >Also, move down tfilter_notify_chain() to group them together. > >Reported-by: Jamal Hadi Salim >Cc: Jamal Hadi Salim

Re: [PATCH] net: Reduce skb_warn_bad_offload() noise.

2017-08-07 Thread Tonghao Zhang
Hi Willem In a case, there is also warn info. The test topo is shown as below. VM01: veth1 and eth0 in the VM01 are inserted to ovs br0. veth0(IP: 172.16.34.100/24) —— veth1--br0--eth0 iperf3 -c 172.168.100.13 -i 1 -P 10 -t 10 -u -b 1000M -l 10K VM02 eth0(IP: 172.16.34.200/24) iperf3 -s

[PATCH net-next] openvswitch: add NSH support

2017-08-07 Thread Yi Yang
OVS master and 2.8 branch has merged NSH userspace patch series, this patch is to enable NSH support in kernel data path in order that OVS can support NSH in 2.8 release in compat mode by porting this. Signed-off-by: Yi Yang --- drivers/net/vxlan.c | 7 ++

Re: [PATCH 0/6] In-kernel QMI handling

2017-08-07 Thread Bjorn Andersson
On Mon 07 Aug 12:19 PDT 2017, Marcel Holtmann wrote: > Hi Bjorn, > > >>> This series starts by moving the common definitions of the QMUX > >>> protocol to the > >>> uapi header, as they are shared with clients - both in kernel and > >>> userspace. > >>> > >>> This series then introduces

Re: [PATCH net-next 03/14] sctp: remove the typedef sctp_scope_policy_t

2017-08-07 Thread Xin Long
On Mon, Aug 7, 2017 at 9:28 PM, David Laight wrote: > From: Xin Long >> Sent: 05 August 2017 13:00 >> This patch is to remove the typedef sctp_scope_policy_t and keep >> it's members as an anonymous enum. >> >> It is also to define SCTP_SCOPE_POLICY_MAX to replace the num

Re: [PATCH net] sctp: use __GFP_NOWARN for sctpw.fifo allocation

2017-08-07 Thread Xin Long
On Mon, Aug 7, 2017 at 11:39 AM, Marcelo Ricardo Leitner wrote: > On Sun, Aug 06, 2017 at 06:14:39PM +1200, Xin Long wrote: >> On Sun, Aug 6, 2017 at 5:08 AM, Marcelo Ricardo Leitner >> wrote: >> > On Sat, Aug 05, 2017 at 08:31:09PM +0800,

Re: [PATCH net] net: sched: fix NULL pointer dereference when action calls some targets

2017-08-07 Thread Xin Long
On Tue, Aug 8, 2017 at 9:15 AM, Cong Wang wrote: > (Cc'ing netfilter and Jamal) > > On Sat, Aug 5, 2017 at 4:35 AM, Xin Long wrote: >> As we know in some target's checkentry it may dereference par.entryinfo >> to check entry stuff inside. But when

Re: [PATCH net] net: sched: set xt_tgchk_param par.nft_compat with false in ipt_init_target

2017-08-07 Thread Xin Long
On Tue, Aug 8, 2017 at 9:03 AM, Cong Wang wrote: > On Sat, Aug 5, 2017 at 4:32 AM, Xin Long wrote: >> Commit 55917a21d0cc ("netfilter: x_tables: add context to know if >> extension runs from nft_compat") introduced a member nft_compat to >>

[PATCHv2 net] net: sched: set xt_tgchk_param par.net properly in ipt_init_target

2017-08-07 Thread Xin Long
Now xt_tgchk_param par in ipt_init_target is a local varibale, par.net is not initialized there. Later when xt_check_target calls target's checkentry in which it may access par.net, it would cause kernel panic. Jaroslav found this panic when running: # ip link add TestIface type dummy # tc

Re: [PATCH v9 0/4] Add new PCI_DEV_FLAGS_NO_RELAXED_ORDERING flag

2017-08-07 Thread Bjorn Helgaas
On Mon, Aug 07, 2017 at 02:14:48PM -0700, David Miller wrote: > From: Ding Tianhong > Date: Mon, 7 Aug 2017 12:13:17 +0800 > > > Hi David: > > > > I think networking tree merge it is a better choice, as it mainly used to > > tell the NIC > > drivers how to use the

Re: [PATCH RFC v2 3/5] samples/bpf: Fix inline asm issues building samples on arm64

2017-08-07 Thread Joel Fernandes
Hi Dave, On Mon, Aug 7, 2017 at 11:28 AM, David Miller wrote: > > Please, no. Sorry you dislike it, I had intentionally marked it as RFC as its an idea I was just toying with the idea and posted it early to get feedback. > > The amount of hellish hacks we are adding to

Re:Re:Re: Re: [PATCH net] ppp: Fix a scheduling-while-atomic bug in del_chan

2017-08-07 Thread Gao Feng
At 2017-08-08 01:17:02, "Cong Wang" wrote: >On Sun, Aug 6, 2017 at 6:32 PM, Gao Feng wrote: >> I think the RCU should be supposed to avoid the race between del_chan and >> lookup_chan. > >More precisely, it is callid_sock which is protected by

Re: [PATCH net] net: sched: set xt_tgchk_param par.net properly in ipt_init_target

2017-08-07 Thread Xin Long
On Tue, Aug 8, 2017 at 9:00 AM, Cong Wang wrote: > On Sat, Aug 5, 2017 at 1:48 AM, Xin Long wrote: >> -static int __tcf_ipt_init(struct tc_action_net *tn, struct nlattr *nla, >> +static int __tcf_ipt_init(struct net *net, struct nlattr *nla, >>

Re: [PATCH v5 net-next 00/12] bpf: rewrite value tracking in verifier

2017-08-07 Thread Daniel Borkmann
On 08/07/2017 04:21 PM, Edward Cree wrote: This series simplifies alignment tracking, generalises bounds tracking and fixes some bounds-tracking bugs in the BPF verifier. Pointer arithmetic on packet pointers, stack pointers, map value pointers and context pointers has been unified, and

[PATCH] Allow passing tid or pid in SCM_CREDENTIALS without CAP_SYS_ADMIN

2017-08-07 Thread Prakash Sangappa
Currently passing tid(gettid(2)) of a thread in struct ucred in SCM_CREDENTIALS message requires CAP_SYS_ADMIN capability otherwise it fails with EPERM error. Some applications deal with thread id of a thread(tid) and so it would help to allow tid in SCM_CREDENTIALS message. Basically, either

Re: [PATCH] net: Reduce skb_warn_bad_offload() noise.

2017-08-07 Thread Tonghao Zhang
That is fine to me. I have tested it. Thanks. On Mon, Aug 7, 2017 at 12:42 PM, Willem de Bruijn wrote: >> The openvswitch kernel module calls the __skb_gso_segment()(and sets >> tx_path = false) when passing packets to userspace. The UFO will set >> the ip_summed

Re: Qdisc->u32_node - licence to kill

2017-08-07 Thread Cong Wang
On Mon, Aug 7, 2017 at 12:54 PM, John Fastabend wrote: > On 08/07/2017 12:06 PM, Jiri Pirko wrote: >> Mon, Aug 07, 2017 at 07:47:14PM CEST, john.fastab...@gmail.com wrote: >>> On 08/07/2017 09:41 AM, Jiri Pirko wrote: Hi Jamal/Cong/David/all. Digging in

Re: [PATCH net-next] net: dsa: lan9303: Only allocate 3 ports

2017-08-07 Thread Vivien Didelot
Egil Hjelmeland writes: > Save 2628 bytes on arm eabi by allocate only the required 3 ports. > > Now that ds->num_ports is correct: In net/dsa/tag_lan9303.c > eliminate duplicate LAN9303_MAX_PORTS, use ds->num_ports. > (Matching the pattern of other net/dsa/tag_xxx.c

Re: [PATCH net-next] selftests: bpf: add a test for XDP redirect

2017-08-07 Thread John Fastabend
On 08/07/2017 01:14 PM, William Tu wrote: > Add test for xdp_redirect by creating two namespaces with two > veth peers, then forward packets in-between. > > Signed-off-by: William Tu > Cc: Daniel Borkmann > Cc: John Fastabend

Re: [PATCH] ip/link_vti*.c: Fix output for ikey/okey

2017-08-07 Thread Stephen Hemminger
On Mon, 7 Aug 2017 11:59:28 +0200 Christian Langrock wrote: > ikey and okey are normal u32 values. There's no reason to print them as > IPv4/IPv6 addresses. > > Signed-off-by: Christian Langrock Changing output format breaks

Re: [PATCH net-next] net: dsa: lan9303: Only allocate 3 ports

2017-08-07 Thread Florian Fainelli
On 08/07/2017 03:22 PM, Egil Hjelmeland wrote: > Save 2628 bytes on arm eabi by allocate only the required 3 ports. > > Now that ds->num_ports is correct: In net/dsa/tag_lan9303.c > eliminate duplicate LAN9303_MAX_PORTS, use ds->num_ports. > (Matching the pattern of other net/dsa/tag_xxx.c

[Patch net-next] net_sched: get rid of some forward declarations

2017-08-07 Thread Cong Wang
If we move up tcf_fill_node() we can get rid of these forward declarations. Also, move down tfilter_notify_chain() to group them together. Reported-by: Jamal Hadi Salim Cc: Jamal Hadi Salim Signed-off-by: Cong Wang ---

multi-queue over IFF_NO_QUEUE "virtual" devices

2017-08-07 Thread Florian Fainelli
Hi, Most DSA supported Broadcom switches have multiple queues per ports (usually 8) and each of these queues can be configured with different pause, drop, hysteresis thresholds and so on in order to make use of the switch's internal buffering scheme and have some queues achieve some kind of

[RFC PATCH 1/2] bpf: Fix bpf_trace_printk on 32-bit architectures

2017-08-07 Thread James Hogan
bpf_trace_printk() uses conditional operators to attempt to pass different types to __trace_printk() depending on the format operators. This doesn't work as intended on 32-bit architectures where u32 & long are passed differently to u64, since the result of C conditional operators follows the

[RFC PATCH 0/2] bpf_trace_printk() fixes

2017-08-07 Thread James Hogan
A couple of RFC fixes for bpf_trace_printk(). The first affects 32-bit architectures in particular, the second is a theoretical uninitialised variable fix. Cc: Alexei Starovoitov Cc: Daniel Borkmann Cc: Steven Rostedt Cc: Ingo Molnar

[RFC PATCH 2/2] bpf: Initialise mod[] in bpf_trace_printk

2017-08-07 Thread James Hogan
In bpf_trace_printk(), the elements in mod[] are left uninitialised, but they are then incremented to track the width of the formats. Zero initialise the array just in case the memory contains non-zero values on entry. Fixes: 9c959c863f82 ("tracing: Allow BPF programs to call bpf_trace_printk()")

[RFC PATCH] net: don't set __LINK_STATE_START until after dev->open() call

2017-08-07 Thread Jacob Keller
Fix an issue with relying on netif_running() which could be true during when dev->open() handler is being called, even if it would exit with a failure. This ensures the state does not get set and removed with a narrow race for other callers to read it as open when infact it never finished opening.

[PATCH net-next] net: dsa: lan9303: Only allocate 3 ports

2017-08-07 Thread Egil Hjelmeland
Save 2628 bytes on arm eabi by allocate only the required 3 ports. Now that ds->num_ports is correct: In net/dsa/tag_lan9303.c eliminate duplicate LAN9303_MAX_PORTS, use ds->num_ports. (Matching the pattern of other net/dsa/tag_xxx.c files.) Signed-off-by: Egil Hjelmeland

Re: [PATCH net-next] net: vrf: Add extack messages for newlink failures

2017-08-07 Thread David Miller
From: David Ahern Date: Mon, 7 Aug 2017 10:08:10 -0700 > Add extack error messages for failure paths creating vrf devices. Once > extack support is added to iproute2, we go from the unhelpful: > $ ip li add foobar type vrf > RTNETLINK answers: Invalid argument > >

[PATCH RFC 1/2] bpf: Add a BPF return code to disconnect a connection

2017-08-07 Thread Tom Herbert
When using BPF program against a flow a possible verdict is that the packet should not only be dropped, but that the flow the packet was received on should be terminated. Signed-off-by: Tom Herbert --- include/uapi/linux/bpf.h | 1 + 1 file changed, 1 insertion(+) diff

[PATCH RFC 2/2] stap: Socket tap

2017-08-07 Thread Tom Herbert
The socket tap uses ULP mechanism to insert funtionality between the socket system calls and the connection itself. Basically, this is a means to tap into a socket. To implement the tap the data operations (sendmsg, recvmsg, sendpage, and read_sock) are intercepted using the ULP infrastructure. In

[PATCH RFC 0/2] stap: Socket tap

2017-08-07 Thread Tom Herbert
This patch set introduces generic socket tap support. This allows a means to run BPF programs or implement other functionality in both the send and receive path of a socket. The socket tap uses the ULP mechanism recently introduced for kTLS. The data operations (sendmsg, recvmsg, sendpage, and

Re: [PATCH] wan: dscc4: add checks for dma mapping errors

2017-08-07 Thread Francois Romieu
Alexey Khoroshilov : > The driver does not check if mapping dma memory succeed. > The patch adds the checks and failure handling. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Alexey Khoroshilov Please amend

Re: [PATCH net-next v3 00/13] Update DSA's FDB API and perform switchdev cleanup

2017-08-07 Thread David Miller
From: Arkadi Sharshevsky Date: Sun, 6 Aug 2017 16:15:38 +0300 > The patchset adds support for configuring static FDB entries via the > switchdev notification chain. The current method for FDB configuration > uses the switchdev's bridge bypass implementation. In order to

Re: [PATCH 0/3] ARM: dts: keystone-k2g: Add DCAN instances to 66AK2G

2017-08-07 Thread Franklin S Cooper Jr
Hi Santosh, On 08/04/2017 12:07 PM, Santosh Shilimkar wrote: > Hi Franklin, > > On 8/2/2017 1:18 PM, Franklin S Cooper Jr wrote: >> Add D CAN nodes to 66AK2G based SoC dtsi. >> >> Franklin S Cooper Jr (2): >>dt-bindings: net: c_can: Update binding for clock and power-domains >> property

Re: [PATCH net-next] selftests: bpf: add a test for XDP redirect

2017-08-07 Thread Daniel Borkmann
On 08/07/2017 10:14 PM, William Tu wrote: Add test for xdp_redirect by creating two namespaces with two veth peers, then forward packets in-between. Signed-off-by: William Tu Cc: Daniel Borkmann Cc: John Fastabend

Re: [PATCH] hamradio: baycom: make hdlcdrv_ops const

2017-08-07 Thread David Miller
From: Bhumika Goyal Date: Sun, 6 Aug 2017 14:21:45 +0530 > Make hdlcdrv_ops structures const as they are only passed to > hdlcdrv_register function. The corresponding argument is of type const, > so make the structures const. > > Signed-off-by: Bhumika Goyal

Re: [PATCH ipsec-next] xfrm: check that cached bundle is still valid

2017-08-07 Thread David Miller
From: Florian Westphal Date: Sun, 6 Aug 2017 10:19:07 +0200 > Quoting Ilan Tayari: > 1. Set up a host-to-host IPSec tunnel (or transport, doesn't matter) > 2. Ping over IPSec, or do something to populate the pcpu cache > 3. Join a MC group, then leave MC group > 4. Try

Re: [PATCH net-next v2 0/3] net: dsa: remove useless arguments

2017-08-07 Thread David Miller
From: Vivien Didelot Date: Sat, 5 Aug 2017 16:20:16 -0400 > Several DSA core setup functions take many arguments, mostly because of > the legacy code. This patch series removes the useless args of these > functions, where either the dsa_switch or dsa_port

Re: [PATCH][net-next] net: hns3: fix spelling mistake: "capabilty" -> "capability"

2017-08-07 Thread David Miller
From: Colin King Date: Sat, 5 Aug 2017 14:46:35 +0100 > From: Colin Ian King > > Trivial fix to spelling mistake in dev_err error message and also > split overly long line to avoid a checkpatch warning. > > Signed-off-by: Colin Ian King

Re: [RFC] iproute: Add support for extended ack to rtnl_talk

2017-08-07 Thread Stephen Hemminger
On Mon, 07 Aug 2017 13:26:03 -0700 (PDT) David Miller wrote: > From: Stephen Hemminger > Date: Mon, 7 Aug 2017 12:12:35 -0700 > > > Dave, I asked for test cases, and received none. > > You don't need a test case to type make and make sure the

Re: [PATCH v4 net-next 0/5] Refactor lan9303_xxx_packet_processing

2017-08-07 Thread David Miller
From: Egil Hjelmeland Date: Sat, 5 Aug 2017 13:05:45 +0200 > This series is purely non functional. > > It changes the lan9303_enable_packet_processing, > lan9303_disable_packet_processing() to pass port number (0,1,2) as > parameter instead of port offset. This

Re: [PATCH net-next v2 0/5] ipv6: sr: add support for advanced local segment processing

2017-08-07 Thread David Miller
From: David Lebrun Date: Sat, 5 Aug 2017 12:38:23 +0200 > v2: use EXPORT_SYMBOL_GPL > > The current implementation of IPv6 SR supports SRH insertion/encapsulation > and basic segment endpoint behavior (i.e., processing of an SRH contained in > a packet whose active

Re: [PATCH net] net: sched: fix NULL pointer dereference when action calls some targets

2017-08-07 Thread Cong Wang
(Cc'ing netfilter and Jamal) On Sat, Aug 5, 2017 at 4:35 AM, Xin Long wrote: > As we know in some target's checkentry it may dereference par.entryinfo > to check entry stuff inside. But when sched action calls xt_check_target, > par.entryinfo is set with NULL. It would

Re: unregister_netdevice: waiting for eth0 to become free. Usage count = 1

2017-08-07 Thread John Stultz
On Mon, Aug 7, 2017 at 2:05 PM, John Stultz wrote: > So, with recent testing with my HiKey board, I've been noticing some > quirky behavior with my USB eth adapter. > > Basically, pluging the usb eth adapter in and then removing it, when > plugging it back in I often find

Re: [PATCH v9 0/4] Add new PCI_DEV_FLAGS_NO_RELAXED_ORDERING flag

2017-08-07 Thread David Miller
From: Ding Tianhong Date: Mon, 7 Aug 2017 12:13:17 +0800 > Hi David: > > I think networking tree merge it is a better choice, as it mainly used to > tell the NIC > drivers how to use the Relaxed Ordering Attribute, and later we need send > patch to enable > RO for

Re: [net-next PATCH v2] bpf: devmap fix mutex in rcu critical section

2017-08-07 Thread David Miller
From: John Fastabend Date: Fri, 04 Aug 2017 22:02:19 -0700 > Originally we used a mutex to protect concurrent devmap update > and delete operations from racing with netdev unregister notifier > callbacks. > > The notifier hook is needed because we increment the netdev

Re: [Patch net-next 0/2] net_sched: clean up filter handle

2017-08-07 Thread David Miller
From: Cong Wang Date: Fri, 4 Aug 2017 21:31:41 -0700 > This patchset sits in my local branch for a long time, it is time to > send it out. It cleans up the ambiguous use of 'unsigned long fh', > please see each of them for details. Series applied, thanks Cong.

Re: [PATCH net-next v2] lwtunnel: replace EXPORT_SYMBOL with EXPORT_SYMBOL_GPL

2017-08-07 Thread David Miller
From: Roopa Prabhu Date: Fri, 4 Aug 2017 18:19:18 -0700 > From: Roopa Prabhu > > Signed-off-by: Roopa Prabhu > --- > v2 - fixed a incorrect replace Applied, thanks.

Re: [PATCH net-next v4 0/2] bpf: add support for sys_{enter|exit}_* tracepoints

2017-08-07 Thread David Miller
From: Yonghong Song Date: Fri, 4 Aug 2017 16:00:08 -0700 > Currently, bpf programs cannot be attached to sys_enter_* and sys_exit_* > style tracepoints. The main reason is that syscalls/sys_enter_* and > syscalls/sys_exit_* > tracepoints are treated differently from other

Re: [PATCH] of_mdio: use of_property_read_u32_array()

2017-08-07 Thread David Miller
From: Sergei Shtylyov Date: Sat, 05 Aug 2017 00:43:43 +0300 > The "fixed-link" prop support predated of_property_read_u32_array(), so > basically had to open-code it. Using the modern API saves 24 bytes of the > object code (ARM gcc 4.8.5); the only behavior

Re: [PATCH] wan: dscc4: add checks for dma mapping errors

2017-08-07 Thread David Miller
From: Alexey Khoroshilov Date: Fri, 4 Aug 2017 23:23:24 +0300 > The driver does not check if mapping dma memory succeed. > The patch adds the checks and failure handling. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Alexey

unregister_netdevice: waiting for eth0 to become free. Usage count = 1

2017-08-07 Thread John Stultz
So, with recent testing with my HiKey board, I've been noticing some quirky behavior with my USB eth adapter. Basically, pluging the usb eth adapter in and then removing it, when plugging it back in I often find that its not detected, and the system slowly spits out the following message over and

Re: [PATCH net] net: sched: set xt_tgchk_param par.nft_compat with false in ipt_init_target

2017-08-07 Thread Cong Wang
On Sat, Aug 5, 2017 at 4:32 AM, Xin Long wrote: > Commit 55917a21d0cc ("netfilter: x_tables: add context to know if > extension runs from nft_compat") introduced a member nft_compat to > xt_tgchk_param structure. > > But it didn't set it's value for ipt_init_target. With

Re: [PATCH net v2] net/mlx4_en: don't set CHECKSUM_COMPLETE on SCTP packets

2017-08-07 Thread David Miller
From: Davide Caratti Date: Thu, 3 Aug 2017 22:54:48 +0200 > if the NIC fails to validate the checksum on TCP/UDP, and validation of IP > checksum is successful, the driver subtracts the pseudo-header checksum > from the value obtained by the hardware and sets

Re: [PATCH net-next] ibmvnic: Report rx buffer return codes as netdev_dbg

2017-08-07 Thread David Miller
From: John Allen Date: Mon, 7 Aug 2017 15:42:30 -0500 > Reporting any return code for a receive buffer as an "rx error" only > produces alarming noise and the only values that have been observed to be > used in this field are not error conditions. Change this to a

Re: [PATCH net] net: sched: set xt_tgchk_param par.net properly in ipt_init_target

2017-08-07 Thread Cong Wang
On Sat, Aug 5, 2017 at 1:48 AM, Xin Long wrote: > -static int __tcf_ipt_init(struct tc_action_net *tn, struct nlattr *nla, > +static int __tcf_ipt_init(struct net *net, struct nlattr *nla, > struct nlattr *est, struct tc_action **a, >

[PATCH net-next] ibmvnic: Report rx buffer return codes as netdev_dbg

2017-08-07 Thread John Allen
Reporting any return code for a receive buffer as an "rx error" only produces alarming noise and the only values that have been observed to be used in this field are not error conditions. Change this to a netdev_dbg with a more descriptive message. Signed-off-by: John Allen

Re: [RFC] iproute: Add support for extended ack to rtnl_talk

2017-08-07 Thread David Miller
From: Stephen Hemminger Date: Mon, 7 Aug 2017 12:12:35 -0700 > Dave, I asked for test cases, and received none. You don't need a test case to type make and make sure the build succeeds.

[PATCH net-next] selftests: bpf: add a test for XDP redirect

2017-08-07 Thread William Tu
Add test for xdp_redirect by creating two namespaces with two veth peers, then forward packets in-between. Signed-off-by: William Tu Cc: Daniel Borkmann Cc: John Fastabend --- tools/include/uapi/linux/bpf.h

Re: Qdisc->u32_node - licence to kill

2017-08-07 Thread John Fastabend
On 08/07/2017 12:06 PM, Jiri Pirko wrote: > Mon, Aug 07, 2017 at 07:47:14PM CEST, john.fastab...@gmail.com wrote: >> On 08/07/2017 09:41 AM, Jiri Pirko wrote: >>> Hi Jamal/Cong/David/all. >>> >>> Digging in the u32 code deeper now. I need to get rid of tp->q for shared >>> blocks, but I found out

Re: [PATCH iproute2] lib: Dump ext-ack string by default

2017-08-07 Thread David Ahern
On 8/7/17 1:28 PM, David Ahern wrote: > @@ -99,7 +95,12 @@ static int nl_dump_ext_err(const struct nlmsghdr *nlh, > nl_ext_ack_fn_t errfn) > err_nlh = >msg; > } > > - return errfn(errmsg, off, err_nlh); > + if (errfn) > + return errfn(errmsg, off,

Re: [pull request][for-next 0/8] Mellanox, mlx5 shared 2017-08-07

2017-08-07 Thread Saeed Mahameed
On Mon, Aug 7, 2017 at 9:20 PM, David Miller wrote: > From: Saeed Mahameed > Date: Mon, 7 Aug 2017 13:18:00 +0300 > >> Hi Dave & Doug, >> >> This series contains some low level updates for mlx5 core driver, >> to be shared as base code for net-next and

[PATCH iproute2] lib: Dump ext-ack string by default

2017-08-07 Thread David Ahern
In time, errfn can be implemented for link, route, etc commands to give a much more detailed response (e.g., point to the attribute that failed). Doing so is much more complicated to process the message and convert attribute ids to names. In any case the error string returned by the kernel should

[PATCH net-next] liquidio: fix misspelled firmware image filenames

2017-08-07 Thread Felix Manlunas
From: Derek Chickles Fix misspelled firmware image filenames advertised via MODULE_FIRMWARE(). Signed-off-by: Derek Chickles Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_main.c | 12

Re: [PATCH 0/6] In-kernel QMI handling

2017-08-07 Thread Marcel Holtmann
Hi Bjorn, >>> This series starts by moving the common definitions of the QMUX >>> protocol to the >>> uapi header, as they are shared with clients - both in kernel and >>> userspace. >>> >>> This series then introduces in-kernel helper functions for aiding the >>> handling >>> of QMI encoded

Re: [RFC] iproute: Add support for extended ack to rtnl_talk

2017-08-07 Thread Stephen Hemminger
On Mon, 07 Aug 2017 11:45:17 -0700 (PDT) David Miller wrote: > From: David Ahern > Date: Mon, 7 Aug 2017 12:09:31 -0600 > > > On 8/7/17 12:06 PM, Stephen Hemminger wrote: > >>> Does not work. Seems like you pushed the RFC commit which was known to >

Re: Qdisc->u32_node - licence to kill

2017-08-07 Thread Jiri Pirko
Mon, Aug 07, 2017 at 07:47:14PM CEST, john.fastab...@gmail.com wrote: >On 08/07/2017 09:41 AM, Jiri Pirko wrote: >> Hi Jamal/Cong/David/all. >> >> Digging in the u32 code deeper now. I need to get rid of tp->q for shared >> blocks, but I found out about this: >> >> struct Qdisc { >> ..

Re: [PATCH net-next v4 1/2] bpf: add support for sys_enter_* and sys_exit_* tracepoints

2017-08-07 Thread Alexei Starovoitov
On 8/4/17 1:00 PM, Yonghong Song wrote: Currently, bpf programs cannot be attached to sys_enter_* and sys_exit_* style tracepoints. The iovisor/bcc issue #748 (https://github.com/iovisor/bcc/issues/748) documents this issue. For example, if you try to attach a bpf program to tracepoints

Re: [PATCH net-next v3 00/13] Update DSA's FDB API and perform switchdev cleanup

2017-08-07 Thread Florian Fainelli
On 08/07/2017 07:59 AM, Vivien Didelot wrote: > Hi Arkadi, > > Arkadi Sharshevsky writes: > >> The patchset adds support for configuring static FDB entries via the >> switchdev notification chain. The current method for FDB configuration >> uses the switchdev's bridge

[PATCH net-next v2 2/2] bpf: Extend check_uarg_tail_zero() checks

2017-08-07 Thread Mickaël Salaün
The function check_uarg_tail_zero() was created from bpf(2) for BPF_OBJ_GET_INFO_BY_FD without taking the access_ok() nor the PAGE_SIZE checks. Make this checks more generally available while unlikely to be triggered, extend the memory range check and add an explanation including why the ToCToU

[PATCH net-next v2 1/2] bpf: Move check_uarg_tail_zero() upward

2017-08-07 Thread Mickaël Salaün
The function check_uarg_tail_zero() may be useful for other part of the code in the syscall.c file. Move this function at the beginning of the file. Signed-off-by: Mickaël Salaün Acked-by: Daniel Borkmann Cc: Alexei Starovoitov Cc: David

Re: [RFC] iproute: Add support for extended ack to rtnl_talk

2017-08-07 Thread David Miller
From: David Ahern Date: Mon, 7 Aug 2017 12:09:31 -0600 > On 8/7/17 12:06 PM, Stephen Hemminger wrote: >>> Does not work. Seems like you pushed the RFC commit which was known to >>> be incomplete. >> >> Patches welcome. > > What exists does not even compile. Patches will be

Re: [PATCH] of_mdio: use of_property_read_u32_array()

2017-08-07 Thread Rob Herring
On Mon, Aug 7, 2017 at 1:01 PM, Florian Fainelli wrote: > On 08/07/2017 09:18 AM, Sergei Shtylyov wrote: >> Hello! >> >> On 08/07/2017 05:18 PM, Rob Herring wrote: >> The "fixed-link" prop support predated of_property_read_u32_array(), so basically had to open-code

Re: [PATCH v3 net-next 0/7] net: l3mdev: Support for sockets bound to enslaved device

2017-08-07 Thread David Ahern
On 8/7/17 12:39 PM, David Miller wrote: > Series applied, let's see if it builds this time :-) I did an allyesconfig build before sending just to make sure, so our mileage better not vary.

Re: [PATCH v3 net-next 0/7] net: l3mdev: Support for sockets bound to enslaved device

2017-08-07 Thread David Miller
From: David Ahern Date: Mon, 7 Aug 2017 08:44:15 -0700 > A missing piece to the VRF puzzle is the ability to bind sockets to > devices enslaved to a VRF. This patch set adds the enslaved device > index, sdif, to IPv4 and IPv6 socket lookups. The end result for users > is the

Re: pull-request: wireless-drivers-next 2017-08-07

2017-08-07 Thread David Miller
From: Kalle Valo Date: Mon, 07 Aug 2017 17:55:40 +0300 > here's the first pull request to net-next for 4.14, more info in the > signed tag below. This time there's a simple conflict in iwlwifi but > you can fix it just like Stephen did: > >

Re: [PATCH net-next v1 2/2] bpf: Extend check_uarg_tail_zero() checks

2017-08-07 Thread Daniel Borkmann
On 08/07/2017 06:36 PM, Mickaël Salaün wrote: The function check_uarg_tail_zero() was created from bpf(2) for BPF_OBJ_GET_INFO_BY_FD without taking the access_ok() nor the PAGE_SIZE checks. Make this checks more generally available while unlikely to be triggered, extend the memory range check

[PATCH net-next 1/1] netvsc: make sure and unregister datapath

2017-08-07 Thread Stephen Hemminger
Go back to switching datapath directly in the notifier callback. Otherwise datapath might not get switched on unregister. No need for calling the NOTIFY_PEERS notifier since that is only for a gratitious ARP/ND packet; but that is not required with Hyper-V because both VF and synthetic NIC have

[PATCH net-next 0/1] netvsc: another VF datapath fix

2017-08-07 Thread Stephen Hemminger
Previous fix was incomplete. Stephen Hemminger (1): netvsc: make sure and unregister datapath drivers/net/hyperv/hyperv_net.h | 3 -- drivers/net/hyperv/netvsc.c | 2 -- drivers/net/hyperv/netvsc_drv.c | 71 - 3 files changed, 28 insertions(+), 48

Re: [PATCH RFC v2 3/5] samples/bpf: Fix inline asm issues building samples on arm64

2017-08-07 Thread David Miller
Please, no. The amount of hellish hacks we are adding to deal with this is getting way out of control. BPF programs MUST have their own set of asm headers, this is the only way to get around this issue in the long term. I am also strongly against adding -static to the build.

Re: [PATCH net 1/1] s390/qeth: fix L3 next-hop in xmit qeth hdr

2017-08-07 Thread David Miller
From: Ursula Braun Date: Mon, 7 Aug 2017 13:28:39 +0200 > From: Julian Wiedmann > > On L3, the qeth_hdr struct needs to be filled with the next-hop > IP address. > The current code accesses rtable->rt_gateway without checking that > rtable

Re: [PATCH v2] hysdn: fix to a race condition in put_log_buffer

2017-08-07 Thread David Miller
From: Anton Volkov Date: Mon, 7 Aug 2017 15:54:14 +0300 > The synchronization type that was used earlier to guard the loop that > deletes unused log buffers may lead to a situation that prevents any > thread from going through the loop. > > The patch deletes previously used

Re: [PATCH net-next v1 1/2] bpf: Move check_uarg_tail_zero() upward

2017-08-07 Thread Daniel Borkmann
On 08/07/2017 06:36 PM, Mickaël Salaün wrote: The function check_uarg_tail_zero() may be useful for other part of the code in the syscall.c file. Move this function at the beginning of the file. Signed-off-by: Mickaël Salaün Cc: Alexei Starovoitov Cc: Daniel

Re: [PATCH] hns3: fix unused function warning

2017-08-07 Thread David Miller
From: Arnd Bergmann Date: Mon, 7 Aug 2017 12:41:53 +0200 > Without CONFIG_PCI_IOV, we get a harmless warning about an > unused function: > > drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c:2273:13: error: > 'hclge_disable_sriov' defined but not used

Re: [pull request][for-next 0/8] Mellanox, mlx5 shared 2017-08-07

2017-08-07 Thread David Miller
From: Saeed Mahameed Date: Mon, 7 Aug 2017 13:18:00 +0300 > Hi Dave & Doug, > > This series contains some low level updates for mlx5 core driver, > to be shared as base code for net-next and rdma for-next mlx5 > 4.14 submissions. > > Please find more information in the

[PATCH v1 net] TCP_USER_TIMEOUT and tcp_keepalive should conform to RFC5482

2017-08-07 Thread Rao Shoaib
Change from version 0: Rationale behind the change: The man page for tcp(7) states when used with the TCP keepalive (SO_KEEPALIVE) option, TCP_USER_TIMEOUT will override keepalive to determine when to close a connection due to keepalive failure. This is ambigious at best. user expectation is

Re: [PATCH net-next v3 13/13] net: switchdev: Remove bridge bypass support from switchdev

2017-08-07 Thread Florian Fainelli
On 08/06/2017 06:15 AM, Arkadi Sharshevsky wrote: > Currently the bridge port flags, vlans, FDBs and MDBs can be offloaded > through the bridge code, making the switchdev's SELF bridge bypass > implementation to be redundant. This implies several changes: > - No need for dump infra in switchdev,

Re: [PATCH net-next v4 2/2] bpf: add a test case for syscalls/sys_{enter|exit}_* tracepoints

2017-08-07 Thread Daniel Borkmann
On 08/05/2017 01:00 AM, Yonghong Song wrote: Signed-off-by: Yonghong Song Acked-by: Daniel Borkmann

Re: [PATCH net-next v3 12/13] net: bridge: Remove FDB deletion through switchdev object

2017-08-07 Thread Florian Fainelli
On 08/06/2017 06:15 AM, Arkadi Sharshevsky wrote: > At this point no driver supports FDB add/del through switchdev object > but rather via notification chain, thus, it is removed. > > Signed-off-by: Arkadi Sharshevsky > Reviewed-by: Vivien Didelot

Re: [PATCH net-next v3 09/13] net: dsa: Remove support for MDB dump from DSA's drivers

2017-08-07 Thread Florian Fainelli
On 08/06/2017 06:15 AM, Arkadi Sharshevsky wrote: > This is done as a preparation before removing support for MDB dump from > DSA core. The MDBs are synced with the bridge and thus there is no > need for special dump operation support. > > Signed-off-by: Arkadi Sharshevsky

Re: [RFC] iproute: Add support for extended ack to rtnl_talk

2017-08-07 Thread David Ahern
On 8/7/17 12:06 PM, Stephen Hemminger wrote: >> Does not work. Seems like you pushed the RFC commit which was known to >> be incomplete. > > Patches welcome. What exists does not even compile. Patches will be sent once you fix that.

Re: [PATCH net-next v3 07/13] net: dsa: Remove support for vlan dump from DSA's drivers

2017-08-07 Thread Florian Fainelli
On 08/06/2017 06:15 AM, Arkadi Sharshevsky wrote: > This is done as a preparation before removing support for vlan dump from > DSA core. The vlans are synced with the bridge and thus there is no > need for special dump operation support. > > Signed-off-by: Arkadi Sharshevsky

Re: [PATCH net-next v3 08/13] net: dsa: Remove support for bypass bridge port attributes/vlan set

2017-08-07 Thread Florian Fainelli
On 08/06/2017 06:15 AM, Arkadi Sharshevsky wrote: > The bridge port attributes/vlan for DSA devices should be set only > from bridge code. Furthermore, The vlans are synced totally with the > bridge so there is no need for special dump support. > > Signed-off-by: Arkadi Sharshevsky

Re: [PATCH net-next v3 05/13] net: dsa: Move FDB add/del implementation inside DSA

2017-08-07 Thread Florian Fainelli
On 08/06/2017 06:15 AM, Arkadi Sharshevsky wrote: > Currently DSA uses switchdev's implementation of FDB add/del ndos. This > patch moves the implementation inside DSA in order to support the legacy > way for static FDB configuration. > > Signed-off-by: Arkadi Sharshevsky

Re: [PATCH net-next v3 04/13] net: dsa: Add support for learning FDB through notification

2017-08-07 Thread Florian Fainelli
On 08/06/2017 06:15 AM, Arkadi Sharshevsky wrote: > Add support for learning FDB through notification. The driver defers > the hardware update via ordered work queue. In case of a successful > FDB add a notification is sent back to bridge. > > In case of hw FDB del failure the static FDB will be

Re: [RFC] iproute: Add support for extended ack to rtnl_talk

2017-08-07 Thread Stephen Hemminger
On Mon, 7 Aug 2017 10:48:23 -0600 David Ahern wrote: > On 8/4/17 10:47 AM, Stephen Hemminger wrote: > > I will put in the libmnl version. If it doesn't work because no one sent > > me test cases, then fine. send a patch for that. > > This commit: > > commit

Re: [PATCH net-next v3 10/13] net: dsa: Remove redundant MDB dump support

2017-08-07 Thread Florian Fainelli
On 08/06/2017 06:15 AM, Arkadi Sharshevsky wrote: > Currently the MDB HW database is synced with the bridge's one, thus, > There is no need to support special dump functionality. > > Signed-off-by: Arkadi Sharshevsky Reviewed-by: Florian Fainelli --

  1   2   3   >