Re: [PATCH iproute2 net-next v2 0/2] Add support for seg6 l2encap mode

2017-08-30 Thread Stephen Hemminger
On Mon, 28 Aug 2017 20:26:38 +0100 David Lebrun wrote: > This patch series adds support for the new L2ENCAP mode for SRv6 > encapsulations. > > v2: use a name/value table for encap modes > > David Lebrun (2): > iproute: add support for seg6 l2encap mode > man: add documentation for seg6 l2e

Re: nflog performance ...

2017-08-30 Thread Stephen Hemminger
On Wed, 30 Aug 2017 13:27:57 +0530 Akshat Kakkar wrote: > Anybody? > > On Tue, Aug 29, 2017 at 4:11 PM, Akshat Kakkar wrote: > > I am using ulogd2 to log iptables activity. > > However, when using pgsql as output plugin ... performance is very > > very sluggish. (~130-150 entries per second) >

RE: [PATCH net-next v2] net: bcmgenet: Use correct I/O accessors

2017-08-30 Thread Florian Fainelli
On August 30, 2017 4:39:52 AM PDT, David Laight wrote: >From: Florian Fainelli >> Sent: 29 August 2017 20:26 >> The GENET driver currently uses __raw_{read,write}l which means >> native I/O endian. This works correctly for an ARM LE kernel >(default) >> but fails miserably on an ARM BE (BE8) kerne

Re: [PATCH] staging: r8822be: Fix typo for CONFIG_RTLWIFI_DEBUG

2017-08-30 Thread Larry Finger
On 08/30/2017 02:58 AM, Andreas Ziegler wrote: Indeed, sorry I missed that as well. So what should we make of that #ifdef? The code inside it doesn't compile (anymore? I didn't find any development history for that patch except the original mail), as there is no definition of struct submit_ctx i

[PATCH net] kcm: do not attach PF_KCM sockets to avoid deadlock

2017-08-30 Thread Eric Dumazet
From: Eric Dumazet syzkaller had no problem to trigger a deadlock, attaching a KCM socket to another one (or itself). (original syzkaller report was a very confusing lockdep splat during a sendmsg()) It seems KCM claims to only support TCP, but no enforcement is done, so we might need to add add

Re: [PATCH] rtlwifi: btcoex: 23b 1ant: fix duplicated code for different branches

2017-08-30 Thread Larry Finger
On 08/30/2017 08:42 AM, Gustavo A. R. Silva wrote: Refactor code in order to avoid identical code for different branches. This issue was detected with the help of Coccinelle. Addresses-Coverity-ID: 1226788 Signed-off-by: Gustavo A. R. Silva --- This issue was reported by Coverity and it was te

Re: [PATCH net] kcm: do not attach PF_KCM sockets to avoid deadlock

2017-08-30 Thread Tom Herbert
On Wed, Aug 30, 2017 at 9:29 AM, Eric Dumazet wrote: > From: Eric Dumazet > > syzkaller had no problem to trigger a deadlock, attaching a KCM socket > to another one (or itself). (original syzkaller report was a very > confusing lockdep splat during a sendmsg()) > > It seems KCM claims to only su

Re: rsi: remove memset before memcpy

2017-08-30 Thread Kalle Valo
Himanshu Jha wrote: > calling memcpy immediately after memset with the same region of memory > makes memset redundant. > > Signed-off-by: Himanshu Jha Patch applied to wireless-drivers-next.git, thanks. 66a3479e1217 rsi: remove memset before memcpy -- https://patchwork.kernel.org/patch/9927

linux-next: Signed-off-by missing for commit in the net-next tree

2017-08-30 Thread Stephen Rothwell
Hi all, Commit 1b70d792cf67 ("ipv6: Use rt6i_idev index for echo replies to a local address") is missing a Signed-off-by from its author. -- Cheers, Stephen Rothwell

Re: [PATCH] rtlwifi: btcoex: 23b 1ant: fix duplicated code for different branches

2017-08-30 Thread Gustavo A. R. Silva
Hi Larry, On 08/30/2017 11:37 AM, Larry Finger wrote: On 08/30/2017 08:42 AM, Gustavo A. R. Silva wrote: Refactor code in order to avoid identical code for different branches. This issue was detected with the help of Coccinelle. Addresses-Coverity-ID: 1226788 Signed-off-by: Gustavo A. R. Silv

Re: linux-next: Signed-off-by missing for commit in the net-next tree

2017-08-30 Thread David Ahern
On 8/30/17 10:51 AM, Stephen Rothwell wrote: > Hi all, > > Commit > > 1b70d792cf67 ("ipv6: Use rt6i_idev index for echo replies to a local > address") > > is missing a Signed-off-by from its author. > Eric pointed this out last night. The commit message copied output from a command that con

[PATCH] rtlwifi: rtl8723be: fix duplicated code for different branches

2017-08-30 Thread Gustavo A. R. Silva
Refactor code in order to avoid identical code for different branches. Addresses-Coverity-ID: 1248728 Signed-off-by: Gustavo A. R. Silva --- This issue was reported by Coverity and it was tested by compilation only. Please, verify if this is not a copy/paste error. Also, notice this code has been

[PATCH] rtlwifi: refactor code in halbtcoutsrc module

2017-08-30 Thread Gustavo A. R. Silva
Function halbtc_get_wifi_rssi always returns rtlpriv->dm.undec_sm_pwdb. So this function can be removed and the value of rtlpriv->dm.undec_sm_pwdb assigned to *s32_tmp directly. This issue was first reported by Coverity as "identical code for different branches" in function halbtc_get_wifi_rssi.

Re: [PATCH] net: ti: cpsw-common: dont print error if ti_cm_get_macid() fails

2017-08-30 Thread David Miller
From: Sekhar Nori Date: Wed, 30 Aug 2017 13:37:13 +0530 > It is quite common for ti_cm_get_macid() to fail on some of the > platforms it is invoked on. They include any platform where > mac address is not part of SoC register space. > > On these platforms, mac address is read and populated in >

Re: [PATCH][next][V2] bpf: test_maps: fix typo "conenct" -> "connect"

2017-08-30 Thread Colin Ian King
On 30/08/17 14:46, Daniel Borkmann wrote: > On 08/30/2017 01:47 PM, Colin King wrote: >> From: Colin Ian King >> >> Trivial fix to typo in printf error message >> >> Signed-off-by: Colin Ian King > > For net-next; looks like there is also one in "failed to listeen\n". > Want to fix this one as w

Re: [GIT] Networking

2017-08-30 Thread David Miller
From: Kalle Valo Date: Wed, 30 Aug 2017 17:45:31 +0300 > Pavel Machek writes: > >> Could we get this one in? >> >> wl1251 misses a spin_lock_init(). >> >> https://www.mail-archive.com/netdev@vger.kernel.org/msg177031.html >> >> It seems pretty trivial, yet getting the backtraces is not nice. >

Re: [PATCH v3 net-next] staging: irda: fix init level for irda core

2017-08-30 Thread David Miller
From: Greg KH Date: Wed, 30 Aug 2017 13:16:49 +0200 > When moving the IRDA code out of net/ into drivers/staging/irda/net, the > link order changes when IRDA is built into the kernel. That causes a > kernel crash at boot time as netfilter isn't initialized yet. > > To fix this, move the init ca

[PATCH][net-next][V3] bpf: test_maps: fix typos, "conenct" and "listeen"

2017-08-30 Thread Colin King
From: Colin Ian King Trivial fix to typos in printf error messages: "conenct" -> "connect" "listeen" -> "listen" thanks to Daniel Borkmann for spotting one of these mistakes Signed-off-by: Colin Ian King --- tools/testing/selftests/bpf/test_maps.c | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [net-next PATCHv6 2/2] net: socionext: Add NetSec driver

2017-08-30 Thread Andrew Lunn
> +static int netsec_mac_update_to_phy_state(struct netsec_priv *priv) > +{ > + struct phy_device *phydev = priv->ndev->phydev; > + u32 value = 0; > + > + value = phydev->duplex ? NETSEC_GMAC_MCR_REG_FULL_DUPLEX_COMMON : > +NETSEC_GMAC_MCR_REG_HALF_DU

[PATCH net-next 0/2] tcp: re-add header prediction

2017-08-30 Thread Florian Westphal
Eric reported a performance regression caused by header prediction removal. We now call tcp_ack() much more frequently, for some workloads this brings in enough cache line misses to become noticeable. We could possibly still kill HP provided we find a different way to suppress unneeded tcp_ack, b

[PATCH net-next 2/2] tcp: Revert "tcp: remove header prediction"

2017-08-30 Thread Florian Westphal
This reverts commit 45f119bf936b1f9f546a0b139c5b56f9bb2bdc78. Eric Dumazet says: We found at Google a significant regression caused by 45f119bf936b1f9f546a0b139c5b56f9bb2bdc78 tcp: remove header prediction In typical RPC (TCP_RR), when a TCP socket receives data, we now call tcp_ack() wh

[PATCH net-next 1/2] tcp: Revert "tcp: remove CA_ACK_SLOWPATH"

2017-08-30 Thread Florian Westphal
This change was a followup to the header prediction removal, so first revert this as a prerequisite to back out hp removal. Signed-off-by: Florian Westphal --- include/net/tcp.h | 5 +++-- net/ipv4/tcp_input.c| 35 +++ net/ipv4/tcp_westwood.c | 31 +

Re: [patch net-next 0/8] mlxsw: Add IPv6 host dpipe table

2017-08-30 Thread Andrew Lunn
On Wed, Aug 30, 2017 at 02:02:58PM +0200, Jiri Pirko wrote: > From: Jiri Pirko > > Arkadi says: > > This patchset adds IPv6 host dpipe table support. This will provide the > ability to observe the hardware offloaded IPv6 neighbors. Hi Jiri, Arkadi Could you give us an example of the output see

Re: [GIT] Networking

2017-08-30 Thread Kalle Valo
David Miller writes: > From: Kalle Valo > Date: Wed, 30 Aug 2017 17:45:31 +0300 > >> Pavel Machek writes: >> >>> Could we get this one in? >>> >>> wl1251 misses a spin_lock_init(). >>> >>> https://www.mail-archive.com/netdev@vger.kernel.org/msg177031.html >>> >>> It seems pretty trivial, yet g

Re: [PATCH][net-next][V3] bpf: test_maps: fix typos, "conenct" and "listeen"

2017-08-30 Thread John Fastabend
On 08/30/2017 10:15 AM, Colin King wrote: > From: Colin Ian King > > Trivial fix to typos in printf error messages: > "conenct" -> "connect" > "listeen" -> "listen" > > thanks to Daniel Borkmann for spotting one of these mistakes > > Signed-off-by: Colin Ian King > --- Thanks. Even though its

[PATCH net-next] xen-netfront: be more drop monitor friendly

2017-08-30 Thread Eric Dumazet
From: Eric Dumazet xennet_start_xmit() might copy skb with inappropriate layout into a fresh one. Old skb is freed, and at this point it is not a drop, but a consume. New skb will then be either consumed or dropped. Signed-off-by: Eric Dumazet --- drivers/net/xen-netfront.c |2 +- 1 file

Re: [patch net-next 0/8] mlxsw: Add IPv6 host dpipe table

2017-08-30 Thread David Ahern
On 8/30/17 11:26 AM, Andrew Lunn wrote: > On Wed, Aug 30, 2017 at 02:02:58PM +0200, Jiri Pirko wrote: >> From: Jiri Pirko >> >> Arkadi says: >> >> This patchset adds IPv6 host dpipe table support. This will provide the >> ability to observe the hardware offloaded IPv6 neighbors. > > Hi Jiri, Arka

Re: [patch net-next 3/8] mlxsw: spectrum_dpipe: Add IPv6 host table initial support

2017-08-30 Thread David Ahern
On 8/30/17 6:03 AM, Jiri Pirko wrote: > @@ -328,9 +329,21 @@ static int mlxsw_sp_dpipe_table_host_matches_dump(struct > sk_buff *skb, int type) > if (err) > return err; > > - match.type = DEVLINK_DPIPE_MATCH_TYPE_FIELD_EXACT; > - match.header = &devlink_dpipe_header_i

Re: [PATCH net 6/9] sch_fq_codel: avoid double free on init failure

2017-08-30 Thread Cong Wang
On Wed, Aug 30, 2017 at 2:49 AM, Nikolay Aleksandrov wrote: > It is very unlikely to happen but the backlogs memory allocation > could fail and will free q->flows, but then ->destroy() will free > q->flows too. For correctness remove the first free and let ->destroy > clean up. > > Fixes: 87b60cfa

Re: [PATCH net 9/9] sch_tbf: fix two null pointer dereferences on init failure

2017-08-30 Thread Cong Wang
On Wed, Aug 30, 2017 at 2:49 AM, Nikolay Aleksandrov wrote: > Reproduce: > $ sysctl net.core.default_qdisc=tbf > $ ip l set ethX up I once upon a time had a patch to disallow those qdisc's to be default. Probably I should resend it.

Re: linux-next: Signed-off-by missing for commit in the net-next tree

2017-08-30 Thread Stephen Rothwell
Hi David, On Wed, 30 Aug 2017 10:53:48 -0600 David Ahern wrote: > > On 8/30/17 10:51 AM, Stephen Rothwell wrote: > > Hi all, > > > > Commit > > > > 1b70d792cf67 ("ipv6: Use rt6i_idev index for echo replies to a local > > address") > > > > is missing a Signed-off-by from its author. > > Eri

Re: [RESEND PATCH] Allow passing tid or pid in SCM_CREDENTIALS without CAP_SYS_ADMIN

2017-08-30 Thread Eric W. Biederman
Prakash Sangappa writes: > On 8/29/17 5:10 PM, ebied...@xmission.com wrote: > > "prakash.sangappa" writes: > > On 08/29/2017 04:02 PM, David Miller wrote: > > From: Prakash Sangappa > Date: Mon, 28 Aug 2017 17:12:20 -0700 > > Currently passing tid(gettid(2)) of a thread in struct ucred in >

Re: [patch net-next 6/8] mlxsw: spectrum_dpipe: Add support for IPv6 host table dump

2017-08-30 Thread David Ahern
On 8/30/17 6:03 AM, Jiri Pirko wrote: > diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_dpipe.c > b/drivers/net/ethernet/mellanox/mlxsw/spectrum_dpipe.c > index 5924e97..75da2ef 100644 > --- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_dpipe.c > +++ b/drivers/net/ethernet/mellanox/mlxs

Re: [patch net-next 7/8] mlxsw: spectrum_router: Add support for setting counters on IPv6 neighbors

2017-08-30 Thread David Ahern
On 8/30/17 6:03 AM, Jiri Pirko wrote: > diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c > b/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c > index db57c0c..0cf6810 100644 > --- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c > +++ b/drivers/net/ethernet/mellanox/m

[PATCH 5/5] net: mdio-mux: fix unbalanced put_device

2017-08-30 Thread Corentin Labbe
mdio_mux_uninit() call put_device (unconditionally) because of of_mdio_find_bus() in mdio_mux_init. But of_mdio_find_bus is only called if mux_bus is empty. If mux_bus is set, mdio_mux_uninit will print a "refcount_t: underflow" trace. This patch add a get_device in the other branch of "if (mux_bu

[PATCH 4/5] net: mdio-mux-mmioreg: Can handle 8/16/32 bits registers

2017-08-30 Thread Corentin Labbe
This patch fix an old information that mdio-mux-mmioreg can only handle 8bit registers. This is not true anymore. Signed-off-by: Corentin Labbe --- drivers/net/phy/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig index

[PATCH 2/5] net: mdio-mux: Remove unnecessary 'out of memory' message

2017-08-30 Thread Corentin Labbe
This patch fix checkpatch warning about unnecessary 'out of memory' message. Signed-off-by: Corentin Labbe --- drivers/net/phy/mdio-mux.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/net/phy/mdio-mux.c b/drivers/net/phy/mdio-mux.c index b18ad7082b88..5e08e89465c5 100644 --- a

[PATCH 0/5] net: mdio-mux: Misc fix

2017-08-30 Thread Corentin Labbe
Hello This patch series fix minor problems found when working on the dwmac-sun8i syscon mdio-mux. Regards Corentin Labbe (5): net: mdio-mux: Fix NULL Comparison style net: mdio-mux: Remove unnecessary 'out of memory' message net: mdio-mux: printing driver version is useless net: mdio-mux

[PATCH 3/5] net: mdio-mux: printing driver version is useless

2017-08-30 Thread Corentin Labbe
Remove the driver version information because this information is not useful in an upstream kernel driver. Signed-off-by: Corentin Labbe --- drivers/net/phy/mdio-mux.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/phy/mdio-mux.c b/drivers/net/phy/mdio-mux.c index 5e08e89465c5..9

[PATCH 1/5] net: mdio-mux: Fix NULL Comparison style

2017-08-30 Thread Corentin Labbe
This patch fix checkpatch warning about NULL Comparison style. Signed-off-by: Corentin Labbe --- drivers/net/phy/mdio-mux.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/phy/mdio-mux.c b/drivers/net/phy/mdio-mux.c index 942ceaf3fd3f..b18ad7082b88 100644 ---

Re: linux-next: Signed-off-by missing for commit in the net-next tree

2017-08-30 Thread David Miller
From: David Ahern Date: Wed, 30 Aug 2017 10:53:48 -0600 > On 8/30/17 10:51 AM, Stephen Rothwell wrote: >> Hi all, >> >> Commit >> >> 1b70d792cf67 ("ipv6: Use rt6i_idev index for echo replies to a local >> address") >> >> is missing a Signed-off-by from its author. >> > > Eric pointed this

Re: [GIT] Networking

2017-08-30 Thread David Miller
From: Kalle Valo Date: Wed, 30 Aug 2017 20:31:31 +0300 > AFAICS the bug was introduced by 9df86e2e702c6 back in 2010. If the bug > has been there for 7 years so waiting for a few more weeks should not > hurt. As a maintainer you have a right to handle bug fixing in that way, but certainly that i

Re: [PATCH net-next 0/2] tcp: re-add header prediction

2017-08-30 Thread David Miller
From: Florian Westphal Date: Wed, 30 Aug 2017 19:24:56 +0200 > Eric reported a performance regression caused by header prediction > removal. > > We now call tcp_ack() much more frequently, for some workloads > this brings in enough cache line misses to become noticeable. > > We could possibly s

Re: [PATCH net-next 1/4] net: Add SRIOV VGT+ support

2017-08-30 Thread Saeed Mahameed
On Tue, Aug 29, 2017 at 7:43 PM, Sabrina Dubroca wrote: > 2017-08-29, 13:13:09 +0300, Saeed Mahameed wrote: >> On Mon, Aug 28, 2017 at 6:52 PM, Sabrina Dubroca >> wrote: >> > 2017-08-27, 14:06:15 +0300, Saeed Mahameed wrote: >> > [...] >> >> +#define VF_VLAN_BITMAP DIV_ROUND_UP(VF_VLAN_N_V

Re: [PATCH net-next 0/4] SRIOV VF VGT+ and violation counters support

2017-08-30 Thread Saeed Mahameed
On Sun, Aug 27, 2017 at 2:06 PM, Saeed Mahameed wrote: > Hi Dave > > This series provides two security SRIOV related features (VGT+ and VF > violation counters). > > VGT+ is a security feature that gives the administrator the ability of > controlling > the allowed VGT vlan IDs list that can be t

Re: [PATCH net-next 0/4] SRIOV VF VGT+ and violation counters support

2017-08-30 Thread David Miller
From: Saeed Mahameed Date: Wed, 30 Aug 2017 21:33:18 +0300 > On Sun, Aug 27, 2017 at 2:06 PM, Saeed Mahameed wrote: >> Hi Dave >> >> This series provides two security SRIOV related features (VGT+ and VF >> violation counters). >> >> VGT+ is a security feature that gives the administrator the ab

Re: [PATCH 3/5] net: mdio-mux: printing driver version is useless

2017-08-30 Thread Andrew Lunn
On Wed, Aug 30, 2017 at 07:46:49PM +0200, Corentin Labbe wrote: > Remove the driver version information because this information > is not useful in an upstream kernel driver. > > Signed-off-by: Corentin Labbe Hi Corentin You may as well remove DRV_VERSION from this file, not just here. And

Re: [PATCH 1/5] net: mdio-mux: Fix NULL Comparison style

2017-08-30 Thread Andrew Lunn
On Wed, Aug 30, 2017 at 07:46:47PM +0200, Corentin Labbe wrote: > This patch fix checkpatch warning about NULL Comparison style. > > Signed-off-by: Corentin Labbe Reviewed-by: Andrew Lunn Andrew

Re: [PATCH][net-next][V3] bpf: test_maps: fix typos, "conenct" and "listeen"

2017-08-30 Thread Daniel Borkmann
On 08/30/2017 07:15 PM, Colin King wrote: From: Colin Ian King Trivial fix to typos in printf error messages: "conenct" -> "connect" "listeen" -> "listen" thanks to Daniel Borkmann for spotting one of these mistakes Signed-off-by: Colin Ian King Acked-by: Daniel Borkmann

Re: [PATCH 2/5] net: mdio-mux: Remove unnecessary 'out of memory' message

2017-08-30 Thread Andrew Lunn
On Wed, Aug 30, 2017 at 07:46:48PM +0200, Corentin Labbe wrote: > This patch fix checkpatch warning about unnecessary 'out of memory' > message. > > Signed-off-by: Corentin Labbe Reviewed-by: Andrew Lunn Andrew

Re: [PATCH 4/5] net: mdio-mux-mmioreg: Can handle 8/16/32 bits registers

2017-08-30 Thread Andrew Lunn
On Wed, Aug 30, 2017 at 07:46:50PM +0200, Corentin Labbe wrote: > This patch fix an old information that mdio-mux-mmioreg can only handle > 8bit registers. > This is not true anymore. > > Signed-off-by: Corentin Labbe Reviewed-by: Andrew Lunn Andrew

Re: [PATCH 5/5] net: mdio-mux: fix unbalanced put_device

2017-08-30 Thread Andrew Lunn
> err_pb_kz: > /* balance the reference of_mdio_find_bus() took */ Hi Corentin This comment should probably be updated as well. > - if (!mux_bus) > - put_device(&parent_bus->dev); > + put_device(&parent_bus->dev); Thanks Andrew

Re: [PATCH 0/5] net: mdio-mux: Misc fix

2017-08-30 Thread Andrew Lunn
On Wed, Aug 30, 2017 at 07:46:46PM +0200, Corentin Labbe wrote: > Hello > > This patch series fix minor problems found when working on the > dwmac-sun8i syscon mdio-mux. Hi Corentin In general, a nice patchset. Looking at the code, there are a few calls to devm_kfree() which look redundant. Thi

RE: [ovs-dev] [PATCH net-next v6 3/3] openvswitch: enable NSH support

2017-08-30 Thread Mooney, Sean K
> -Original Message- > From: Hannes Frederic Sowa [mailto:han...@stressinduktion.org] > Sent: Wednesday, August 30, 2017 4:16 PM > To: Mooney, Sean K > Cc: Yang, Yi Y ; d...@openvswitch.org; > netdev@vger.kernel.org; jb...@redhat.com; e...@erig.me > Subject: Re: [ovs-dev] [PATCH net-next

Re: [PATCH 5/6] platform/x86: make device_attribute const

2017-08-30 Thread Andy Shevchenko
On Mon, Aug 21, 2017 at 2:43 PM, Bhumika Goyal wrote: > Make these const as they are only passed as an argument to the > function device_create_file and device_remove_file and the corresponding > arguments are of type const. > Done using Coccinelle > Split on per driver basis. > Signed-off-by: B

[PATCH 1/2] staging: r8822be: Remove some dead code

2017-08-30 Thread Larry Finger
The code found inside an #ifdef CONFIG_RTL_DEBUG ... #endif section is left over from debugging of the original driver, and should be deleted. Reported by: Andreas Ziegler Signed-off-by: Larry Finger Cc: Ping-Ke Shih Cc: Yan-Hsuan Chuang Cc: Birming Chiu Cc: Shaofu Cc: Steven Ting --- driv

[PATCH 2/2] staging: r8822be: Simplify deinit_priv()

2017-08-30 Thread Larry Finger
Now that the extraneous debugging code is removed, routine deinit_priv() clearly contains code that serves no useful purpose. A null test before a call to kfree() and a spurious cast are also removed. Signed-off-by: Larry Finger Cc: Ping-Ke Shih Cc: Yan-Hsuan Chuang Cc: Birming Chiu Cc: Shaof

[PATCH 0/2] staging: r8822be: Remove some left-over debug code

2017-08-30 Thread Larry Finger
Some useless debugging code from the initial writing of the driver was not removed before it was submitted. That oversight is now fixed and the remaining code in routine deinit_priv() is simplified. Larry Larry Finger (2): staging: r8822be: Remove some dead code staging: r8822be: Simplify dei

[PATCH net] net: dsa: bcm_sf2: Fix number of CFP entries for BCM7278

2017-08-30 Thread Florian Fainelli
BCM7278 has only 128 entries while BCM7445 has the full 256 entries set, fix that. Fixes: 7318166cacad ("net: dsa: bcm_sf2: Add support for ethtool::rxnfc") Signed-off-by: Florian Fainelli --- drivers/net/dsa/bcm_sf2.c | 4 drivers/net/dsa/bcm_sf2.h | 1 + drivers/net/dsa/bcm_sf2_cf

Re: [PATCH net] net: dsa: bcm_sf2: Fix number of CFP entries for BCM7278

2017-08-30 Thread Vivien Didelot
Florian Fainelli writes: > BCM7278 has only 128 entries while BCM7445 has the full 256 entries set, > fix that. > > Fixes: 7318166cacad ("net: dsa: bcm_sf2: Add support for ethtool::rxnfc") > Signed-off-by: Florian Fainelli Reviewed-by: Vivien Didelot

DSA mv88e6xxx RX frame errors and TCP/IP RX failure

2017-08-30 Thread Tim Harvey
Greetings, I'm seeing RX frame errors when using the mv88e6xxx DSA driver on 4.13-rc7. The board I'm using is a GW5904 [1] which has an IMX6 FEC MAC (eth0) connected via RGMII to a MV88E6176 with its downstream P0/P1/P2/P3 to front panel RJ45's (lan1-lan4). What I see is the following: - bring up

Re: [PATCH][net-next][V3] bpf: test_maps: fix typos, "conenct" and "listeen"

2017-08-30 Thread Shuah Khan
On 08/30/2017 12:47 PM, Daniel Borkmann wrote: > On 08/30/2017 07:15 PM, Colin King wrote: >> From: Colin Ian King >> >> Trivial fix to typos in printf error messages: >> "conenct" -> "connect" >> "listeen" -> "listen" >> >> thanks to Daniel Borkmann for spotting one of these mistakes >> >> Signed

Re: [PATCH][net-next][V3] bpf: test_maps: fix typos, "conenct" and "listeen"

2017-08-30 Thread Daniel Borkmann
On 08/30/2017 10:13 PM, Shuah Khan wrote: On 08/30/2017 12:47 PM, Daniel Borkmann wrote: On 08/30/2017 07:15 PM, Colin King wrote: From: Colin Ian King Trivial fix to typos in printf error messages: "conenct" -> "connect" "listeen" -> "listen" thanks to Daniel Borkmann for spotting one of th

[PATCH net-next] hv_netvsc: Fix typos in the document of UDP hashing

2017-08-30 Thread Haiyang Zhang
From: Haiyang Zhang There are two typos in the document, netvsc.txt, regarding UDP hashing level. This patch fixes them. Signed-off-by: Haiyang Zhang --- Documentation/networking/netvsc.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/networking/netvsc.

Re: [PATCH net-next 3/3 v11] drivers: net: ethernet: qualcomm: rmnet: Initial implementation

2017-08-30 Thread Subash Abhinov Kasiviswanathan
General comment; other drivers that do similar things (macvlan, ipvlan) use the term "port" to refer to what I think you're calling a "rmnet_real_dev_info". Maybe that's a shorter or less confusing term. Could be renamed later too, if you wanted to do so. Hi Dan I'll rename it to rmnet_port.

Re: [PATCH net-next 3/3 v11] drivers: net: ethernet: qualcomm: rmnet: Initial implementation

2017-08-30 Thread David Miller
From: Subash Abhinov Kasiviswanathan Date: Wed, 30 Aug 2017 15:19:19 -0600 > Sure, I'll implement this. Let me know if you have more comments. Subash, keep in mind that since I applied your v11 patches already you will need to send me relative fixes and changes at this point, rather than resubmi

[Patch net-next] net_sched: add reverse binding for tc class

2017-08-30 Thread Cong Wang
TC filters when used as classifiers are bound to TC classes. However, there is a hidden difference when adding them in different orders: 1. If we add tc classes before its filters, everything is fine. Logically, the classes exist before we specify their ID's in filters, it is easy to bind th

RE: [PATCH] DSA support for Micrel KSZ8895

2017-08-30 Thread Tristram.Ha
> On Mon 2017-08-28 16:09:27, Andrew Lunn wrote: > > > I may be confused here, but AFAICT: > > > > > > 1) Yes, it has standard layout when accessed over MDIO. > > > > > > Section 4.8 of the datasheet says: > > > > All the registers defined in this section can be also accessed > > via the SP

Re: [PATCH net 0/9] net/sched: init failure fixes

2017-08-30 Thread Nikolay Aleksandrov
On 30/08/17 15:15, Jamal Hadi Salim wrote: > On 17-08-30 05:48 AM, Nikolay Aleksandrov wrote: >> Hi all, >> I went over all qdiscs' init, destroy and reset callbacks and found the >> issues fixed in each patch. Mostly they are null pointer dereferences due >> to uninitialized timer (qdisc watchdog)

Re: [PATCH net 6/9] sch_fq_codel: avoid double free on init failure

2017-08-30 Thread Nikolay Aleksandrov
On 30/08/17 20:36, Cong Wang wrote: > On Wed, Aug 30, 2017 at 2:49 AM, Nikolay Aleksandrov > wrote: >> It is very unlikely to happen but the backlogs memory allocation >> could fail and will free q->flows, but then ->destroy() will free >> q->flows too. For correctness remove the first free and le

Re: [PATCH net 9/9] sch_tbf: fix two null pointer dereferences on init failure

2017-08-30 Thread Nikolay Aleksandrov
On 30/08/17 20:37, Cong Wang wrote: > On Wed, Aug 30, 2017 at 2:49 AM, Nikolay Aleksandrov > wrote: >> Reproduce: >> $ sysctl net.core.default_qdisc=tbf >> $ ip l set ethX up > > I once upon a time had a patch to disallow those qdisc's > to be default. Probably I should resend it. > That sounds

Re: [patch net-next v2 0/3] net/sched: Improve getting objects by indexes

2017-08-30 Thread David Miller
From: Chris Mi Date: Wed, 30 Aug 2017 02:31:56 -0400 > Using current TC code, it is very slow to insert a lot of rules. > > In order to improve the rules update rate in TC, > we introduced the following two changes: > 1) changed cls_flower to use IDR to manage the filters. > 2) c

Re: [PATCH net-next 3/3 v11] drivers: net: ethernet: qualcomm: rmnet: Initial implementation

2017-08-30 Thread Subash Abhinov Kasiviswanathan
Subash, keep in mind that since I applied your v11 patches already you will need to send me relative fixes and changes at this point, rather than resubmit the series. Thank you. Thanks for the heads up David. Will do. -- Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a

Re: [PATCH net-next] net: cpsw: Don't handle SIOC[GS]HWTSTAMP when CPTS is disabled

2017-08-30 Thread David Miller
From: Stefan Sørensen Date: Wed, 30 Aug 2017 08:50:55 +0200 > There is no reason to handle SIOC[GS]HWTSTAMP and return -EOPNOTSUPP when > CPTS is disabled, so just pass them on to the phy. This will allow PTP > timestamping on a capable phy by disabling CPTS. > > Signed-off-by: Stefan Sørensen

Re: [Patch net-next] net_sched: add reverse binding for tc class

2017-08-30 Thread Daniel Borkmann
On 08/30/2017 11:30 PM, Cong Wang wrote: [...] Note, we still can NOT totally get rid of those class lookup in ->enqueue() because cgroup and flow filters have no way to determine the classid at setup time, they still have to go through dynamic lookup. [...] --- include/net/sch_generic.h | 1

Re: [PATCH net-next] dp83640: don't hold spinlock while calling netif_rx_ni

2017-08-30 Thread David Miller
From: Stefan Sørensen Date: Wed, 30 Aug 2017 08:58:47 +0200 > We should not hold a spinlock while pushing the skb into the networking > stack, so move the call to netif_rx_ni out of the critical region to where > we have dropped the spinlock. > > Signed-off-by: Stefan Sørensen Looks good, appl

Re: [PATCH] DSA support for Micrel KSZ8895

2017-08-30 Thread Andrew Lunn
> The KSZ8795 driver will be submitted after Labor Day (9/4) if > testing reveals no problem. The KSZ8895 driver will be submitted > right after that. You should have no problem using the driver right > away. Hi Tristram Release early, release often. It stops people wasting time Also, we a

Re: [Patch net-next] net_sched: add reverse binding for tc class

2017-08-30 Thread Cong Wang
On Wed, Aug 30, 2017 at 2:48 PM, Daniel Borkmann wrote: > On 08/30/2017 11:30 PM, Cong Wang wrote: > [...] >> >> Note, we still can NOT totally get rid of those class lookup in >> ->enqueue() because cgroup and flow filters have no way to determine >> the classid at setup time, they still have to

Re: DSA mv88e6xxx RX frame errors and TCP/IP RX failure

2017-08-30 Thread Andrew Lunn
On Wed, Aug 30, 2017 at 12:53:56PM -0700, Tim Harvey wrote: > Greetings, > > I'm seeing RX frame errors when using the mv88e6xxx DSA driver on > 4.13-rc7. The board I'm using is a GW5904 [1] which has an IMX6 FEC > MAC (eth0) connected via RGMII to a MV88E6176 with its downstream > P0/P1/P2/P3 to

Re: [PATCH net-next v4 00/13] net: mvpp2: comphy configuration

2017-08-30 Thread David Miller
From: Antoine Tenart Date: Wed, 30 Aug 2017 10:29:11 +0200 > This series, following up the one one the GoP/MAC configuration, aims at > stopping to depend on the firmware/bootloader configuration when using > the PPv2 engine. With this series the PPv2 driver does not need to rely > on a previous

Re: [PATCH v2] ipv6: sr: fix get_srh() to comply with IPv6 standard "RFC 8200"

2017-08-30 Thread David Miller
From: Ahmed Abdelsalam Date: Wed, 30 Aug 2017 10:50:37 +0200 > IPv6 packet may carry more than one extension header, and IPv6 nodes must > accept and attempt to process extension headers in any order and occurring > any number of times in the same packet. Hence, there should be no > assumption th

Re: [PATCH] net: bcm63xx_enet: make bcm_enetsw_ethtool_ops const

2017-08-30 Thread David Miller
From: Bhumika Goyal Date: Wed, 30 Aug 2017 14:55:08 +0530 > Make this const as it is never modified. > > Signed-off-by: Bhumika Goyal Applied to net-next.

[net 01/11] net/mlx5e: Check for qos capability in dcbnl_initialize

2017-08-30 Thread Saeed Mahameed
From: Huy Nguyen qos capability is the master capability bit that determines if the DCBX is supported for the PCI function. If this bit is off, driver cannot run any dcbx code. Fixes: e207b7e99176 ("net/mlx5e: ConnectX-4 firmware support for DCBX") Signed-off-by: Huy Nguyen Reviewed-by: Parav P

[net 07/11] net/mlx5e: Don't override user RSS upon set channels

2017-08-30 Thread Saeed Mahameed
From: Inbar Karmy Currently, increasing the number of combined channels is changing the RSS spread to use the new created channels. Prevent the RSS spread change in case the user explicitly declare it, to avoid overriding user configuration. Tested: when RSS default: # ethtool -L ens8 combined

[net 04/11] net/mlx5: Skip mlx5_unload_one if mlx5_load_one fails

2017-08-30 Thread Saeed Mahameed
From: Huy Nguyen There is an issue where the firmware fails during mlx5_load_one, the health_care timer detects the issue and schedules a health_care call. Then the mlx5_load_one detects the issue, cleans up and quits. Then the health_care starts and calls mlx5_unload_one to clean up the resource

[net 05/11] net/mlx5: Remove the flag MLX5_INTERFACE_STATE_SHUTDOWN

2017-08-30 Thread Saeed Mahameed
From: Huy Nguyen MLX5_INTERFACE_STATE_SHUTDOWN is not used in the code. Fixes: 5fc7197d3a25 ("net/mlx5: Add pci shutdown callback") Signed-off-by: Huy Nguyen Reviewed-by: Daniel Jurgens Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/main.c | 2 -- include/linux/mlx

[net 10/11] net/mlx5e: Fix inline header size for small packets

2017-08-30 Thread Saeed Mahameed
From: Moshe Shemesh Fix inline header size, make sure it is not greater than skb len. This bug effects small packets, for example L2 packets with size < 18. Fixes: ae76715d153e ("net/mlx5e: Check the minimum inline header mode before xmit") Signed-off-by: Moshe Shemesh Signed-off-by: Saeed Mah

[net 11/11] net/mlx5e: Fix CQ moderation mode not set properly

2017-08-30 Thread Saeed Mahameed
From: Tal Gilboa cq_period_mode assignment was mistakenly removed so it was always set to "0", which is EQE based moderation, regardless of the device CAPs and requested value in ethtool. Fixes: 6a9764efb255 ("net/mlx5e: Isolate open_channels from priv->params") Signed-off-by: Tal Gilboa Signed

[net 08/11] net/mlx5e: Properly resolve TC offloaded ipv6 vxlan tunnel source address

2017-08-30 Thread Saeed Mahameed
From: Paul Blakey Currently if vxlan tunnel ipv6 src isn't supplied the driver fails to resolve it as part of the route lookup. The resulting encap header is left with a zeroed out ipv6 src address so the packets are sent with this src ip. Use an appropriate route lookup API that also resolves t

[net 06/11] net/mlx5e: Fix dangling page pointer on DMA mapping error

2017-08-30 Thread Saeed Mahameed
From: Eran Ben Elisha Function mlx5e_dealloc_rx_wqe is using page pointer value as an indication to valid DMA mapping. In case that the mapping failed, we released the page but kept the dangling pointer. Store the page pointer only after the DMA mapping passed to avoid invalid page DMA unmap. Fi

[pull request][net 00/11] Mellanox, mlx5 fixes 2017-08-30

2017-08-30 Thread Saeed Mahameed
Hi Dave, This series contains some misc fixes to the mlx5 driver. Please pull and let me know if there's any problem. For -stable: Kernels >= 4.12 net/mlx5e: Fix CQ moderation mode not set properly net/mlx5e: Don't override user RSS upon set channels Kernels >= 4.11

[net 09/11] net/mlx5: E-Switch, Unload the representors in the correct order

2017-08-30 Thread Saeed Mahameed
From: Shahar Klein When changing from switchdev to legacy mode, all the representor port devices (uplink nic and reps) are cleaned up. Part of this cleaning process is removing the neigh entries and the hash table containing them. However, a representor neigh entry might be linked to the uplink p

[net 03/11] net/mlx5: Fix arm SRQ command for ISSI version 0

2017-08-30 Thread Saeed Mahameed
From: Noa Osherovich Support for ISSI version 0 was recently broken as the arm_srq_cmd command, which is used only for ISSI version 0, was given the opcode for ISSI version 1 instead of ISSI version 0. Change arm_srq_cmd to use the correct command opcode for ISSI version 0. Fixes: af1ba291c5e4

Re: [Patch net-next] net_sched: add reverse binding for tc class

2017-08-30 Thread Daniel Borkmann
On 08/31/2017 12:01 AM, Cong Wang wrote: On Wed, Aug 30, 2017 at 2:48 PM, Daniel Borkmann wrote: On 08/30/2017 11:30 PM, Cong Wang wrote: [...] Note, we still can NOT totally get rid of those class lookup in ->enqueue() because cgroup and flow filters have no way to determine the classid at s

[net 02/11] net/mlx5e: Fix DCB_CAP_ATTR_DCBX capability for DCBNL getcap.

2017-08-30 Thread Saeed Mahameed
From: Huy Nguyen Current code doesn't report DCB_CAP_DCBX_HOST capability when query through getcap. User space lldptool expects capability to have HOST mode set when it wants to configure DCBX CEE mode. In absence of HOST mode capability, lldptool fails to switch to CEE mode. This fix returns D

Re: [PATCH net 0/9] net/sched: init failure fixes

2017-08-30 Thread David Miller
From: Jamal Hadi Salim Date: Wed, 30 Aug 2017 08:15:37 -0400 > On 17-08-30 05:48 AM, Nikolay Aleksandrov wrote: >> Hi all, >> I went over all qdiscs' init, destroy and reset callbacks and found >> the >> issues fixed in each patch. Mostly they are null pointer dereferences >> due >> to uninitiali

Re: [PATCH net-next] net: hns3: Fixes the wrong IS_ERR check on the returned phydev value

2017-08-30 Thread David Miller
From: Salil Mehta Date: Wed, 30 Aug 2017 12:06:03 +0100 > This patch removes the wrong check being done for the phy device being > returned by the mdiobus_get_phy() function. This function never returns > the error pointers. > > Fixes: 256727da7395 ("net: hns3: Add MDIO support to HNS3 Ethernet

Re: [PATCH][net-next][V3] bpf: test_maps: fix typos, "conenct" and "listeen"

2017-08-30 Thread David Miller
From: Colin King Date: Wed, 30 Aug 2017 18:15:25 +0100 > From: Colin Ian King > > Trivial fix to typos in printf error messages: > "conenct" -> "connect" > "listeen" -> "listen" > > thanks to Daniel Borkmann for spotting one of these mistakes > > Signed-off-by: Colin Ian King Applied.

Re: [PATCH][next] qed: fix spelling mistake: "calescing" -> "coalescing"

2017-08-30 Thread David Miller
From: Colin King Date: Wed, 30 Aug 2017 12:40:12 +0100 > From: Colin Ian King > > Trivial fix to spelling mistake in DP_NOTICE message > > Signed-off-by: Colin Ian King Applied.

Re: [Patch net-next] net_sched: add reverse binding for tc class

2017-08-30 Thread Daniel Borkmann
On 08/31/2017 12:22 AM, Daniel Borkmann wrote: On 08/31/2017 12:01 AM, Cong Wang wrote: On Wed, Aug 30, 2017 at 2:48 PM, Daniel Borkmann wrote: On 08/30/2017 11:30 PM, Cong Wang wrote: [...] Note, we still can NOT totally get rid of those class lookup in ->enqueue() because cgroup and flow f

<    1   2   3   >