Re: [PATCH] tcp: TCP_USER_TIMEOUT can not work in tcp_probe_timer()

2017-09-12 Thread liujian
在 2017/9/12 23:38, Eric Dumazet 写道: > On Tue, 2017-09-12 at 08:05 -0700, Eric Dumazet wrote: >> On Tue, 2017-09-12 at 14:08 +0800, liujian wrote: >>> Hi, >>> >>> In the scenario, tcp server side IP changed, and at that memont, >>> userspace application still send data continuously; >>> tcp_send_h

Re: [Patch net v3 1/3] net_sched: get rid of tcfa_rcu

2017-09-12 Thread Jiri Pirko
Tue, Sep 12, 2017 at 11:53:09PM CEST, xiyou.wangc...@gmail.com wrote: >On Tue, Sep 12, 2017 at 2:36 PM, Jiri Pirko wrote: >> Tue, Sep 12, 2017 at 11:10:22PM CEST, xiyou.wangc...@gmail.com wrote: >>>On Tue, Sep 12, 2017 at 3:40 AM, Jiri Pirko wrote: This patch helps: >>> >>>Looks good to me.

Re: [Patch net v3 0/3] net_sched: fix filter chain reference counting

2017-09-12 Thread Jiri Pirko
Wed, Sep 13, 2017 at 05:41:18AM CEST, da...@davemloft.net wrote: >From: Cong Wang >Date: Mon, 11 Sep 2017 16:33:29 -0700 > >> This patchset fixes tc filter chain reference counting and nasty race >> conditions with RCU callbacks. Please see each patch for details. > >Series applied, thanks Cong.

Dear Talented

2017-09-12 Thread Kim Sharma
Dear Talented, I am Talent Scout For BLUE SKY FILM STUDIO, Present Blue sky Studio a Film Corporation Located in the United State, is Soliciting for the Right to use Your Photo/Face and Personality as One of the Semi -Major Role/ Character in our Upcoming ANIMATED Stereoscope 3D Movie-The Story of

Re: [PATCH] w90p910_ether: include linux/interrupt.h

2017-09-12 Thread David Miller
From: Arnd Bergmann Date: Tue, 12 Sep 2017 14:31:48 +0200 > A randconfig build caused a compile failure: > > drivers/net/ethernet/nuvoton/w90p910_ether.c: In function > 'w90p910_ether_close': > drivers/net/ethernet/nuvoton/w90p910_ether.c:580:2: error: implicit > declaration of function 'free_

Re: [PATCH net] net: bonding: fix tlb_dynamic_lb default value

2017-09-12 Thread David Miller
From: Nikolay Aleksandrov Date: Tue, 12 Sep 2017 15:10:05 +0300 > Commit 8b426dc54cf4 ("bonding: remove hardcoded value") changed the > default value for tlb_dynamic_lb which lead to either broken ALB mode > (since tlb_dynamic_lb can be changed only in TLB) or setting TLB mode > with tlb_dynamic_

Re: [PATCH] ipv4: Namespaceify tcp_fastopen knob

2017-09-12 Thread David Miller
From: Haishuang Yan Date: Tue, 12 Sep 2017 18:30:57 +0800 > Different namespace application might require enable TCP Fast Open > feature independently of the host. > > Reported-by: Luca BRUNO > Signed-off-by: Haishuang Yan ... > diff --git a/samples/bpf/test_ipip.sh b/samples/bpf/test_ipip.sh

RE: [PATCH v3] iproute2: add support for GRE ignore-df knob

2017-09-12 Thread Michele Lucini
Guys, thanks heaps for this, much appreciated! Cheers. Mike -Original Message- From: Philip Prindeville [mailto:phil...@redfish-solutions.com] Sent: Friday, 21 July 2017 10:35 AM To: Stephen Hemminger Cc: netdev@vger.kernel.org; Michele Lucini Subject: Re: [PATCH v3] iproute2: add supp

Re: [PATCH v4 2/2] ip6_tunnel: fix ip6 tunnel lookup in collect_md mode

2017-09-12 Thread David Miller
From: Haishuang Yan Date: Tue, 12 Sep 2017 17:47:57 +0800 > In collect_md mode, if the tun dev is down, it still can call > __ip6_tnl_rcv to receive on packets, and the rx statistics increase > improperly. > > When the md tunnel is down, it's not neccessary to increase RX drops > for the tunnel

Re: [PATCH v4 1/2] ip_tunnel: fix ip tunnel lookup in collect_md mode

2017-09-12 Thread David Miller
From: Haishuang Yan Date: Tue, 12 Sep 2017 17:47:56 +0800 > In collect_md mode, if the tun dev is down, it still can call > ip_tunnel_rcv to receive on packets, and the rx statistics increase > improperly. > > When the md tunnel is down, it's not neccessary to increase RX drops > for the tunnel

Re: [patch net] mlxsw: spectrum: Prevent mirred-related crash on removal

2017-09-12 Thread David Miller
From: Jiri Pirko Date: Tue, 12 Sep 2017 08:50:53 +0200 > From: Yuval Mintz > > When removing the offloading of mirred actions under > matchall classifiers, mlxsw would find the destination port > associated with the offloaded action and utilize it for undoing > the configuration. > > Depending

Re: [Patch net v3 0/3] net_sched: fix filter chain reference counting

2017-09-12 Thread David Miller
From: Cong Wang Date: Mon, 11 Sep 2017 16:33:29 -0700 > This patchset fixes tc filter chain reference counting and nasty race > conditions with RCU callbacks. Please see each patch for details. Series applied, thanks Cong.

Re: [PATCH v2] openvswitch: Fix an error handling path in 'ovs_nla_init_match_and_action()'

2017-09-12 Thread David Miller
From: Christophe JAILLET Date: Mon, 11 Sep 2017 21:56:20 +0200 > All other error handling paths in this function go through the 'error' > label. This one should do the same. > > Fixes: 9cc9a5cb176c ("datapath: Avoid using stack larger than 1024.") > Signed-off-by: Christophe JAILLET Applied.

Re: [PATCH net] tcp/dccp: remove reqsk_put() from inet_child_forget()

2017-09-12 Thread David Miller
From: Eric Dumazet Date: Mon, 11 Sep 2017 15:58:38 -0700 > From: Eric Dumazet > > Back in linux-4.4, I inadvertently put a call to reqsk_put() in > inet_child_forget(), forgetting it could be called from two different > points. > > In the case it is called from inet_csk_reqsk_queue_add(), we w

Re: [PATCH v2 net] smsc95xx: Configure pause time to 0xffff when tx flow control enabled

2017-09-12 Thread David Miller
From: Date: Mon, 11 Sep 2017 17:43:11 + > From: Nisar Sayed > > Configure pause time to 0x when tx flow control enabled > > Set pause time to 0x in the pause frame to indicate the > partner to stop sending the packets. When RX buffer frees up, > the device sends pause frame with pa

Re: Regression in throughput between kvm guests over virtual bridge

2017-09-12 Thread Jason Wang
On 2017年09月13日 01:56, Matthew Rosato wrote: We are seeing a regression for a subset of workloads across KVM guests over a virtual bridge between host kernel 4.12 and 4.13. Bisecting points to c67df11f "vhost_net: try batch dequing from skb array" In the regressed environment, we are running 4

Re: [PATCH] datapath: Fix an error handling path in 'ovs_nla_init_match_and_action()'

2017-09-12 Thread Tonghao Zhang
On Tue, Sep 12, 2017 at 3:20 AM, Christophe JAILLET wrote: > All other error handling paths in this function go through the 'error' > label. This one should do the same. > > Fixes: 9cc9a5cb176c ("datapath: Avoid using stack larger than 1024.") > Signed-off-by: Christophe JAILLET > --- > I think t

Re: [PATCH v2] geneve: Fix setting ttl value in collect metadata mode

2017-09-12 Thread Pravin Shelar
On Tue, Sep 12, 2017 at 12:05 AM, Haishuang Yan wrote: > Similar to vxlan/ipip tunnel, if key->tos is zero in collect metadata > mode, tos should also fallback to ip{4,6}_dst_hoplimit. > > Signed-off-by: Haishuang Yan > > --- > Changes since v2: > * Make the commit message more clearer. > --- >

Re: [PATCH v4 1/2] ip_tunnel: fix ip tunnel lookup in collect_md mode

2017-09-12 Thread Pravin Shelar
On Tue, Sep 12, 2017 at 2:47 AM, Haishuang Yan wrote: > In collect_md mode, if the tun dev is down, it still can call > ip_tunnel_rcv to receive on packets, and the rx statistics increase > improperly. > > When the md tunnel is down, it's not neccessary to increase RX drops > for the tunnel device

Memory leaks in conntrack

2017-09-12 Thread Cong Wang
Hello, While testing my TC filter patches (so not related to conntrack), the following memory leaks are shown up: unreferenced object 0x9b19ba551228 (size 128): comm "chronyd", pid 338, jiffies 4294910829 (age 53.188s) hex dump (first 32 bytes): 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b

Re: 319554f284dd ("inet: don't use sk_v6_rcv_saddr directly") causes bind port regression

2017-09-12 Thread Josef Bacik
First I’m super sorry for the top post, I’m at plumbers and I forgot to upload my muttrc to my new cloud instance, so I’m screwed using outlook. I have a completely untested, uncompiled patch that I think will fix the problem, would you mind giving it a go? Thanks, Josef On 9/12/17, 3:36 PM,

Re: [RFC PATCH] net: Introduce a socket option to enable picking tx queue based on rx queue.

2017-09-12 Thread Tom Herbert
On Tue, Sep 12, 2017 at 3:31 PM, Samudrala, Sridhar wrote: > > > On 9/12/2017 8:47 AM, Eric Dumazet wrote: >> >> On Mon, 2017-09-11 at 23:27 -0700, Samudrala, Sridhar wrote: >>> >>> On 9/11/2017 8:53 PM, Eric Dumazet wrote: On Mon, 2017-09-11 at 20:12 -0700, Tom Herbert wrote: >

Re: [PATCH] datapath: Fix an error handling path in 'ovs_nla_init_match_and_action()'

2017-09-12 Thread Greg Rose
On 09/11/2017 12:20 PM, Christophe JAILLET wrote: All other error handling paths in this function go through the 'error' label. This one should do the same. Fixes: 9cc9a5cb176c ("datapath: Avoid using stack larger than 1024.") Signed-off-by: Christophe JAILLET --- I think that the comment above

319554f284dd ("inet: don't use sk_v6_rcv_saddr directly") causes bind port regression

2017-09-12 Thread Laura Abbott
Hi, Fedora got a bug report https://bugzilla.redhat.com/show_bug.cgi?id=1432684 of a regression with automatic spice port assignment. The libvirt team reduced this to the attached test case run as follows: In a separate terminal, qemu-kvm -vnc 127.0.0.1:0 to grab port 5900. Then do this: $

Re: [PATCH] ieee802154: fix gcc-4.9 warnings

2017-09-12 Thread Joe Perches
On Tue, 2017-09-12 at 12:16 +0200, Arnd Bergmann wrote: > All older compiler versions up to gcc-4.9 produce these > harmless warnings: > > drivers/net/ieee802154/ca8210.c: In function 'ca8210_skb_tx': > drivers/net/ieee802154/ca8210.c:1947:9: warning: missing braces around > initializer [-Wmissin

Re: [RFC PATCH] net: Introduce a socket option to enable picking tx queue based on rx queue.

2017-09-12 Thread Samudrala, Sridhar
On 9/12/2017 8:47 AM, Eric Dumazet wrote: On Mon, 2017-09-11 at 23:27 -0700, Samudrala, Sridhar wrote: On 9/11/2017 8:53 PM, Eric Dumazet wrote: On Mon, 2017-09-11 at 20:12 -0700, Tom Herbert wrote: Two ints in sock_common for this purpose is quite expensive and the use case for this is lim

[no subject]

2017-09-12 Thread marketing
<>

Re: [PATCH 2/2] net: qcom/emac: add software control for pause frame mode

2017-09-12 Thread Timur Tabi
On 08/01/2017 04:37 PM, Timur Tabi wrote: The EMAC has the option of sending only a single pause frame when flow control is enabled and the RX queue is full. Although sending only one pause frame has little value, this would allow admins to enable automatic flow control without having to worry a

Re: [Patch net v3 1/3] net_sched: get rid of tcfa_rcu

2017-09-12 Thread Cong Wang
On Tue, Sep 12, 2017 at 2:36 PM, Jiri Pirko wrote: > Tue, Sep 12, 2017 at 11:10:22PM CEST, xiyou.wangc...@gmail.com wrote: >>On Tue, Sep 12, 2017 at 3:40 AM, Jiri Pirko wrote: >>> This patch helps: >> >>Looks good to me. Please feel free to submit a formal patch. > > Okay, I will send the patch t

Re: [PATCH net] net: systemport: Fix 64-bit stats deadlock

2017-09-12 Thread Florian Fainelli
On 09/12/2017 02:38 PM, Eric Dumazet wrote: > On Tue, 2017-09-12 at 13:14 -0700, Florian Fainelli wrote: >> We can enter a deadlock situation because there is no sufficient protection >> when ndo_get_stats64() runs in process context to guard against RX or TX NAPI >> contexts running in softirq, th

Re: [PATCH net] net: systemport: Fix 64-bit stats deadlock

2017-09-12 Thread Eric Dumazet
On Tue, 2017-09-12 at 13:14 -0700, Florian Fainelli wrote: > We can enter a deadlock situation because there is no sufficient protection > when ndo_get_stats64() runs in process context to guard against RX or TX NAPI > contexts running in softirq, this can lead to the following lockdep splat and >

Re: [Patch net v3 1/3] net_sched: get rid of tcfa_rcu

2017-09-12 Thread Jiri Pirko
Tue, Sep 12, 2017 at 11:10:22PM CEST, xiyou.wangc...@gmail.com wrote: >On Tue, Sep 12, 2017 at 3:40 AM, Jiri Pirko wrote: >> Tue, Sep 12, 2017 at 11:42:15AM CEST, j...@resnulli.us wrote: >>>Tue, Sep 12, 2017 at 01:33:30AM CEST, xiyou.wangc...@gmail.com wrote: gen estimator has been rewritten i

Re: [Patch net v3 1/3] net_sched: get rid of tcfa_rcu

2017-09-12 Thread Cong Wang
On Tue, Sep 12, 2017 at 3:40 AM, Jiri Pirko wrote: > Tue, Sep 12, 2017 at 11:42:15AM CEST, j...@resnulli.us wrote: >>Tue, Sep 12, 2017 at 01:33:30AM CEST, xiyou.wangc...@gmail.com wrote: >>>gen estimator has been rewritten in commit 1c0d32fde5bd >>>("net_sched: gen_estimator: complete rewrite of r

Re: Can libpcap filter on vlan tags when vlans are hardware-accelerated?

2017-09-12 Thread Michal Kubecek
On Tue, Sep 12, 2017 at 11:54:43AM -0700, Ben Greear wrote: > It does not appear to work on Fedora-26, and I'm curious if someone > knows what needs doing to get this support working? It's rather complicated. The "vlan" and "vlan " filters didn't handle the case when vlan information is passed in

Re: [PATCH/RFC net-next 2/2] net/sched: allow flower to match tunnel options

2017-09-12 Thread Or Gerlitz
On Tue, Sep 12, 2017 at 5:20 PM, Simon Horman wrote: > Allow matching on options in tunnel headers. > This makes use of existing tunnel metadata support. Simon, This patch is about matching on tunnel options, right? but > Options are a bytestring of up to 256 bytes. > Tunnel implementations may

[PATCH net] net: systemport: Fix 64-bit stats deadlock

2017-09-12 Thread Florian Fainelli
We can enter a deadlock situation because there is no sufficient protection when ndo_get_stats64() runs in process context to guard against RX or TX NAPI contexts running in softirq, this can lead to the following lockdep splat and actual deadlock was experienced as well with an iperf session in th

[PATCH] net: vrf: avoid gcc-4.6 warning

2017-09-12 Thread Arnd Bergmann
When building an allmodconfig kernel with gcc-4.6, we get a rather odd warning: drivers/net/vrf.c: In function ‘vrf_ip6_input_dst’: drivers/net/vrf.c:964:3: error: initialized field with side-effects overwritten [-Werror] drivers/net/vrf.c:964:3: error: (near initialization for ‘fl6’) [-Werror]

[PATCH] ravb: document R8A77970 bindings

2017-09-12 Thread Sergei Shtylyov
R-Car V3M (R8A77970) SoC also has the R-Car gen3 compatible EtherAVB device, so document the SoC specific bindings. Signed-off-by: Sergei Shtylyov --- The patch is against DaveM's 'net-next.git' repo but I wouldn't mind if it's applied to 'net.git' instead. :-) Documentation/devicetree/bindin

Re: Can libpcap filter on vlan tags when vlans are hardware-accelerated?

2017-09-12 Thread Ben Greear
On 09/12/2017 11:54 AM, Ben Greear wrote: It does not appear to work on Fedora-26, and I'm curious if someone knows what needs doing to get this support working? Thanks, Ben Gah, I spoke too soon. system-test guy says it works on cmd-line, but not when we try to make it work in another way

Can libpcap filter on vlan tags when vlans are hardware-accelerated?

2017-09-12 Thread Ben Greear
It does not appear to work on Fedora-26, and I'm curious if someone knows what needs doing to get this support working? Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com

[no subject]

2017-09-12 Thread pooks005
<>

Regression in throughput between kvm guests over virtual bridge

2017-09-12 Thread Matthew Rosato
We are seeing a regression for a subset of workloads across KVM guests over a virtual bridge between host kernel 4.12 and 4.13. Bisecting points to c67df11f "vhost_net: try batch dequing from skb array" In the regressed environment, we are running 4 kvm guests, 2 running as uperf servers and 2 ru

Re: [PATCH net] net: bonding: fix tlb_dynamic_lb default value

2017-09-12 Thread महेश बंडेवार
On Tue, Sep 12, 2017 at 5:10 AM, Nikolay Aleksandrov wrote: > Commit 8b426dc54cf4 ("bonding: remove hardcoded value") changed the > default value for tlb_dynamic_lb which lead to either broken ALB mode > (since tlb_dynamic_lb can be changed only in TLB) or setting TLB mode > with tlb_dynamic_lb eq

[PATCH] VSOCK: fix uapi/linux/vm_sockets.h incomplete types

2017-09-12 Thread Stefan Hajnoczi
This patch fixes the following compiler errors when userspace applications use the vm_sockets.h header: include/uapi/linux/vm_sockets.h:148:32: error: invalid application of ‘sizeof’ to incomplete type ‘struct sockaddr’ unsigned char svm_zero[sizeof(struct sockaddr) -

Re: [RFC PATCH] net: Introduce a socket option to enable picking tx queue based on rx queue.

2017-09-12 Thread Eric Dumazet
On Mon, 2017-09-11 at 23:27 -0700, Samudrala, Sridhar wrote: > > On 9/11/2017 8:53 PM, Eric Dumazet wrote: > > On Mon, 2017-09-11 at 20:12 -0700, Tom Herbert wrote: > > > >> Two ints in sock_common for this purpose is quite expensive and the > >> use case for this is limited-- even if a RX->TX que

[PATCH net] ipv6: fix net.ipv6.conf.all interface DAD handlers

2017-09-12 Thread Matteo Croce
Currently, writing into net.ipv6.conf.all.{accept_dad,use_optimistic,optimistic_dad} has no effect. Fix handling of these flags by: - using the maximum of global and per-interface values for the accept_dad flag. That is, if at least one of the two values is non-zero, enable DAD on the interfac

Re: [PATCH] tcp: TCP_USER_TIMEOUT can not work in tcp_probe_timer()

2017-09-12 Thread Eric Dumazet
On Tue, 2017-09-12 at 08:05 -0700, Eric Dumazet wrote: > On Tue, 2017-09-12 at 14:08 +0800, liujian wrote: > > Hi, > > > > In the scenario, tcp server side IP changed, and at that memont, > > userspace application still send data continuously; > > tcp_send_head(sk)'s timestamp always be refreshed.

Re: [PATCH] tcp: TCP_USER_TIMEOUT can not work in tcp_probe_timer()

2017-09-12 Thread Eric Dumazet
On Tue, 2017-09-12 at 14:08 +0800, liujian wrote: > Hi, > > In the scenario, tcp server side IP changed, and at that memont, > userspace application still send data continuously; > tcp_send_head(sk)'s timestamp always be refreshed. > > Here is the packetdrill script: > >0 socket(..., SOCK_ST

[iproute PATCH] ipaddress: Fix segfault in 'addr showdump'

2017-09-12 Thread Phil Sutter
Obviously, 'addr showdump' feature wasn't adjusted to json output support. As a consequence, calls to print_string() in print_addrinfo() tried to dereference a NULL FILE pointer. Fixes: d0e720111aad2 ("ip: ipaddress.c: add support for json output") Signed-off-by: Phil Sutter --- ip/ipaddress.c |

Re: [PATCH] ieee802154: fix gcc-4.9 warnings

2017-09-12 Thread Marcel Holtmann
Hi Arnd, > All older compiler versions up to gcc-4.9 produce these > harmless warnings: > > drivers/net/ieee802154/ca8210.c: In function 'ca8210_skb_tx': > drivers/net/ieee802154/ca8210.c:1947:9: warning: missing braces around > initializer [-Wmissing-braces] > > This changes the syntax to some

[PATCH/RFC net-next 2/2] net/sched: allow flower to match tunnel options

2017-09-12 Thread Simon Horman
Allow matching on options in tunnel headers. This makes use of existing tunnel metadata support. Options are a bytestring of up to 256 bytes. Tunnel implementations may support less or more options, or no options at all. # ip link add name geneve0 type geneve dstport 0 external # tc qdisc add d

[PATCH/RFC net-next 1/2] net/sched: add tunnel option support to act_tunnel_key

2017-09-12 Thread Simon Horman
Allow setting tunnel options using the act_tunnel_key action. Options are a bitwise maskable bytestring of up to 256 bytes. Tunnel implementations may support less or more options, or no options at all. e.g. # ip link add name geneve0 type geneve dstport 0 external # tc qdisc del dev geneve0 in

[PATCH/RFC net-next 0/2] net/sched: support tunnel options in cls_flower and act_tunnel_key

2017-09-12 Thread Simon Horman
Allow the flower classifier to match on tunnel options and the tunnel key action to set them. Tunnel options are a bytestring of up to 256 bytes. The flower classifier matching with an optional bitwise mask. Tunnel implementations may support more or less options, or none at all. Simon Horman (2)

[PATCH iproute2/net-next] tc: flower: support for matching MPLS labels

2017-09-12 Thread Simon Horman
From: Benjamin LaHaise This patch adds support to the iproute2 tc filter command for matching MPLS labels in the flower classifier. The ability to match the Time To Live, Bottom Of Stack, Traffic Control and Label fields are added as options to the flower filter. e.g.: tc filter add dev eth0

Re: [patch net] mlxsw: spectrum: Prevent mirred-related crash on removal

2017-09-12 Thread Andrew Lunn
On Tue, Sep 12, 2017 at 03:15:50PM +0200, Jiri Pirko wrote: > Tue, Sep 12, 2017 at 03:05:06PM CEST, and...@lunn.ch wrote: > >On Tue, Sep 12, 2017 at 08:50:53AM +0200, Jiri Pirko wrote: > >> From: Yuval Mintz > > > >Hi Jiri, Yuval > > > >s/mirred/mirrored/g > > Actually, the name of the tc action

Re: [patch net] mlxsw: spectrum: Prevent mirred-related crash on removal

2017-09-12 Thread Jiri Pirko
Tue, Sep 12, 2017 at 03:05:06PM CEST, and...@lunn.ch wrote: >On Tue, Sep 12, 2017 at 08:50:53AM +0200, Jiri Pirko wrote: >> From: Yuval Mintz > >Hi Jiri, Yuval > >s/mirred/mirrored/g Actually, the name of the tc action is indeed "mirred". See net/sched/act_mirred.c

[PATCH/RFC net-next] ravb: RX checksum offload

2017-09-12 Thread Simon Horman
Add support for RX checksum offload. This is enabled by default and may be disabled and re-enabled using ethtool: # ethtool -K eth0 rx off # ethtool -K eth0 rx on The RAVB provides a simple checksumming scheme which appears to be completely compatible with CHECKSUM_COMPLETE: a 1's complement su

Re: [patch net] mlxsw: spectrum: Prevent mirred-related crash on removal

2017-09-12 Thread Andrew Lunn
On Tue, Sep 12, 2017 at 08:50:53AM +0200, Jiri Pirko wrote: > From: Yuval Mintz Hi Jiri, Yuval s/mirred/mirrored/g Andrew

RE: [PATCH v2 net 1/3] lan78xx: Fix for eeprom read/write when device auto suspend

2017-09-12 Thread Nisar.Sayed
> > From: Nisar Sayed > > > > Fix for eeprom read/write when device auto suspend > > > > Fixes: 55d7de9de6c3 ("Microchip's LAN7800 family USB 2/3 to > > 10/100/1000 Ethernet device driver") > > Signed-off-by: Nisar Sayed > > --- > > drivers/net/usb/lan78xx.c | 22 ++ > > 1 fi

Re: [PATCH net-next v2 1/2] net: phy: realtek: rename RTL8211F_PAGE_SELECT to RTL821x_PAGE_SELECT

2017-09-12 Thread Andrew Lunn
On Tue, Sep 12, 2017 at 06:54:35PM +0900, Kunihiko Hayashi wrote: > This renames the definition of page select register from > RTL8211F_PAGE_SELECT to RTL821x_PAGE_SELECT to use it across models. > > Signed-off-by: Kunihiko Hayashi Reviewed-by: Andrew Lunn Andrew

[PATCH] w90p910_ether: include linux/interrupt.h

2017-09-12 Thread Arnd Bergmann
A randconfig build caused a compile failure: drivers/net/ethernet/nuvoton/w90p910_ether.c: In function 'w90p910_ether_close': drivers/net/ethernet/nuvoton/w90p910_ether.c:580:2: error: implicit declaration of function 'free_irq'; did you mean 'free_uid'? [-Werror=implicit-function-declaration]

[PATCH net] net: bonding: fix tlb_dynamic_lb default value

2017-09-12 Thread Nikolay Aleksandrov
Commit 8b426dc54cf4 ("bonding: remove hardcoded value") changed the default value for tlb_dynamic_lb which lead to either broken ALB mode (since tlb_dynamic_lb can be changed only in TLB) or setting TLB mode with tlb_dynamic_lb equal to 0. The first issue was recently fixed by setting tlb_dynamic_l

Re: ipset losing entries on its own

2017-09-12 Thread Akshat Kakkar
can somebody throw more light on this? How it is possible (without a bug) that for exactly same set of IPs, at time IPSET HASHSIZE remains at 1024 and at times it increases to 2048? As a workaround I am running the show setting HASHSIZE as 16384 at times of IPSET creation itself, and till now (its

Re: Subject: [PATCH] vxlan: only reduce known arp boardcast request to support, virtual IP

2017-09-12 Thread Jiri Benc
On Tue, 12 Sep 2017 11:26:49 +0800, oc wrote: > The purpose of vxlan arp reduce feature is to reply the boardcast > arp request in vtep instead of sending it out to save traffic. > The current implemention drops arp packet, if the ip cannot be > found in neigh table. In the case of virtual IP addre

[PATCH] vti: fix NULL dereference in xfrm_input()

2017-09-12 Thread Alexey Kodanev
Can be reproduced with LTP tests: # icmp-uni-vti.sh -p ah -a sha256 -m tunnel -S fffe -k 1 -s 10 IPv4: RIP: 0010:xfrm_input+0x7f9/0x870 ... Call Trace: vti_input+0xaa/0x110 [ip_vti] ? skb_free_head+0x21/0x40 vti_rcv+0x33/0x40 [ip_vti] xfrm4_ah_rcv+0x33/0x60 ip_local_delive

[PATCH] qed: remove unnecessary call to memset

2017-09-12 Thread Himanshu Jha
call to memset to assign 0 value immediately after allocating memory with kzalloc is unnecesaary as kzalloc allocates the memory filled with 0 value. Semantic patch used to resolve this issue: @@ expression e,e2; constant c; statement S; @@ e = kzalloc(e2, c); if(e == NULL) S - memset(e, 0,

Re: broken vlan support on Realtek RTL8111/8168/8411 rev 9

2017-09-12 Thread Benoit Panizzon
Hi Francois > ethtool -K eth0 rxvlan off Thank you, that did the trick, vlan tags are not correctly passed on and not set to vlan 0 with rxvlan turned off. > For my reward, please send a complete dmesg where the messages from > the vanilla r8169 module appear for the rev 09 card (r81..f ?). I >

Re: [Patch net v3 3/3] net_sched: carefully handle tcf_block_put()

2017-09-12 Thread Jiri Pirko
Tue, Sep 12, 2017 at 01:33:32AM CEST, xiyou.wangc...@gmail.com wrote: >As pointed out by Jiri, there is still a race condition between >tcf_block_put() and tcf_chain_destroy() in a RCU callback. There >is no way to make it correct without proper locking or synchronization, >because both operate on

Re: [Patch net v3 2/3] net_sched: fix reference counting of tc filter chain

2017-09-12 Thread Jiri Pirko
Tue, Sep 12, 2017 at 01:33:31AM CEST, xiyou.wangc...@gmail.com wrote: >This patch fixes the following ugliness of tc filter chain refcnt: > >a) tp proto should hold a refcnt to the chain too. This significantly > simplifies the logic. > >b) Chain 0 is no longer special, it is created with refcnt=

Re: [Patch net v3 1/3] net_sched: get rid of tcfa_rcu

2017-09-12 Thread Jiri Pirko
Tue, Sep 12, 2017 at 11:42:15AM CEST, j...@resnulli.us wrote: >Tue, Sep 12, 2017 at 01:33:30AM CEST, xiyou.wangc...@gmail.com wrote: >>gen estimator has been rewritten in commit 1c0d32fde5bd >>("net_sched: gen_estimator: complete rewrite of rate estimators"), >>the caller is no longer needed to wai

[PATCH] ipv4: Namespaceify tcp_fastopen knob

2017-09-12 Thread Haishuang Yan
Different namespace application might require enable TCP Fast Open feature independently of the host. Reported-by: Luca BRUNO Signed-off-by: Haishuang Yan --- include/net/netns/ipv4.h | 2 ++ include/net/tcp.h | 1 - net/ipv4/af_inet.c | 7 --- net/ipv4/sysctl_net_ipv4

Re: [PATCH] ieee802154: fix gcc-4.9 warnings

2017-09-12 Thread Stefan Schmidt
Hello. On 09/12/2017 12:16 PM, Arnd Bergmann wrote: All older compiler versions up to gcc-4.9 produce these harmless warnings: drivers/net/ieee802154/ca8210.c: In function 'ca8210_skb_tx': drivers/net/ieee802154/ca8210.c:1947:9: warning: missing braces around initializer [-Wmissing-braces] Th

[PATCH] ieee802154: fix gcc-4.9 warnings

2017-09-12 Thread Arnd Bergmann
All older compiler versions up to gcc-4.9 produce these harmless warnings: drivers/net/ieee802154/ca8210.c: In function 'ca8210_skb_tx': drivers/net/ieee802154/ca8210.c:1947:9: warning: missing braces around initializer [-Wmissing-braces] This changes the syntax to something that works on all ve

[PATCH net-next v2 1/2] net: phy: realtek: rename RTL8211F_PAGE_SELECT to RTL821x_PAGE_SELECT

2017-09-12 Thread Kunihiko Hayashi
This renames the definition of page select register from RTL8211F_PAGE_SELECT to RTL821x_PAGE_SELECT to use it across models. Signed-off-by: Kunihiko Hayashi --- Changes since v1: - new patch in this series --- drivers/net/phy/realtek.c | 10 +- 1 file changed, 5 insertions(+), 5 deleti

[PATCH net-next v2 2/2] net: phy: realtek: add RTL8201F phy-id and functions

2017-09-12 Thread Kunihiko Hayashi
From: Jassi Brar Add RTL8201F phy-id and the related functions to the driver. The original patch is as follows: https://patchwork.kernel.org/patch/2538341/ Signed-off-by: Jongsung Kim Signed-off-by: Jassi Brar Signed-off-by: Kunihiko Hayashi Reviewed-by: Andrew Lunn Reviewed-by: Florian Fai

[PATCH v4 2/2] ip6_tunnel: fix ip6 tunnel lookup in collect_md mode

2017-09-12 Thread Haishuang Yan
In collect_md mode, if the tun dev is down, it still can call __ip6_tnl_rcv to receive on packets, and the rx statistics increase improperly. When the md tunnel is down, it's not neccessary to increase RX drops for the tunnel device, packets would be recieved on fallback tunnel, and the RX drops o

[PATCH v4 1/2] ip_tunnel: fix ip tunnel lookup in collect_md mode

2017-09-12 Thread Haishuang Yan
In collect_md mode, if the tun dev is down, it still can call ip_tunnel_rcv to receive on packets, and the rx statistics increase improperly. When the md tunnel is down, it's not neccessary to increase RX drops for the tunnel device, packets would be recieved on fallback tunnel, and the RX drops o

Re: [Patch net v3 1/3] net_sched: get rid of tcfa_rcu

2017-09-12 Thread Jiri Pirko
Tue, Sep 12, 2017 at 01:33:30AM CEST, xiyou.wangc...@gmail.com wrote: >gen estimator has been rewritten in commit 1c0d32fde5bd >("net_sched: gen_estimator: complete rewrite of rate estimators"), >the caller is no longer needed to wait for a grace period. >So this patch gets rid of it. > >This also

RE: [PATCH] tipc: Use bsearch library function

2017-09-12 Thread David Laight
From: David Miller > Sent: 11 September 2017 22:30 > From: Thomas Meyer > Date: Sat, 9 Sep 2017 05:18:19 +0200 > > > @@ -168,6 +169,18 @@ static struct name_seq *tipc_nameseq_create(u32 type, > > struct hlist_head > *seq_hea > > return nseq; > > } > > > > +static int nameseq_find_subseq_cm

Re: [PATCH net-next 2/3] net: ethernet: socionext: add AVE ethernet driver

2017-09-12 Thread Kunihiko Hayashi
Hi Andrew, On Mon, 11 Sep 2017 14:00:09 +0200 Andrew Lunn wrote: > > > > +static irqreturn_t ave_interrupt(int irq, void *netdev) > > > > +{ > > > > + struct net_device *ndev = (struct net_device *)netdev; > > > > + struct ave_private *priv = netdev_priv(ndev); > > > > + u32 gi

scheduling while atomic from vmci_transport_recv_stream_cb in 3.16 kernels

2017-09-12 Thread Michal Hocko
Hi, we are seeing the following splat with Debian 3.16 stable kernel BUG: scheduling while atomic: MATLAB/26771/0x0100 Modules linked in: veeamsnap(O) hmac cbc cts nfsv4 dns_resolver rpcsec_gss_krb5 nfsd auth_rpcgss oid_registry nfs_acl nfs lockd fscache sunrpc vmw_vso$ CPU: 0 PID: 26771 Comm

Re: [PATCH iproute2 1/2] lib/libnetlink: re malloc buff if size is not enough

2017-09-12 Thread Michal Kubecek
On Tue, Sep 12, 2017 at 10:47:48AM +0200, Michal Kubecek wrote: > On Mon, Sep 11, 2017 at 03:19:55PM +0800, Hangbin Liu wrote: > > On Fri, Sep 08, 2017 at 04:51:13PM +0200, Phil Sutter wrote: > > > Regarding Michal's concern about reentrancy, maybe we should go into a > > > different direction and

Re: [PATCH iproute2 1/2] lib/libnetlink: re malloc buff if size is not enough

2017-09-12 Thread Michal Kubecek
On Mon, Sep 11, 2017 at 03:19:55PM +0800, Hangbin Liu wrote: > On Fri, Sep 08, 2017 at 04:51:13PM +0200, Phil Sutter wrote: > > Regarding Michal's concern about reentrancy, maybe we should go into a > > different direction and make rtnl_recvmsg() return a newly allocated > > buffer which the caller

Re: [PATCH v5 10/10] net: stmmac: dwmac-sun8i: Handle integrated/external MDIOs

2017-09-12 Thread Corentin Labbe
On Mon, Sep 11, 2017 at 10:19:20PM +0200, Andrew Lunn wrote: > > Even with CLK_BUS_EPHY/RST_BUS_EPHY enabled, the MAC reset timeout. > > So no the CLK/RST are really for the PHY. > > Thanks for trying that. > > You said it was probably during scanning of the bus it times out. What > address is ca

[PATCH v2] geneve: Fix setting ttl value in collect metadata mode

2017-09-12 Thread Haishuang Yan
Similar to vxlan/ipip tunnel, if key->tos is zero in collect metadata mode, tos should also fallback to ip{4,6}_dst_hoplimit. Signed-off-by: Haishuang Yan --- Changes since v2: * Make the commit message more clearer. --- drivers/net/geneve.c | 6 ++ 1 file changed, 2 insertions(+), 4 dele