Re: [RFC net-next 0/5] TSN: Add qdisc-based config interfaces for traffic shapers

2017-09-19 Thread Richard Cochran
On Tue, Sep 19, 2017 at 05:19:18PM -0700, Vinicius Costa Gomes wrote: > (I think LaunchTime is something specific to the i210, right?) Levi just told us: Recent SoCs from NXP (the i.MX 6 SoloX, and all the i.MX 7 and 8 parts) support Qav shaping as well as scheduled launch

Re: [RFC net-next 0/5] TSN: Add qdisc-based config interfaces for traffic shapers

2017-09-19 Thread Richard Cochran
On Tue, Sep 19, 2017 at 07:59:11PM -0600, levipear...@gmail.com wrote: > If some endpoint device shows up with direct Qbv support, this interface would > probably work well there too, although a talker would need to be able to > schedule its transmits pretty precisely to achieve the lowest

Re: TSN Scorecard, was Re: [RFC net-next 0/5] TSN: Add qdisc-based config interfaces for traffic shapers

2017-09-19 Thread Richard Cochran
On Tue, Sep 19, 2017 at 11:17:54PM -0600, levipear...@gmail.com wrote: > In addition to OpenAvnu, Renesas has a number of github repositories with > what looks like a fairly > complete media streaming system: Is it a generic stack or a set of hacks for their HW? > Although your SO_TXTIME

Re: [PATCH net-next 3/4] qed: Fix maximum number of CQs for iWARP

2017-09-19 Thread Kalderon, Michal
From: Leon Romanovsky Sent: Tuesday, September 19, 2017 8:46 PM On Tue, Sep 19, 2017 at 08:26:18PM +0300, Michal Kalderon wrote: >> The maximum number of CQs supported is bound to the number >> of connections supported, which differs between RoCE and iWARP. >> >> This fixes a

Re: [RFC net-next 0/5] TSN: Add qdisc-based config interfaces for traffic shapers

2017-09-19 Thread Richard Cochran
On Tue, Sep 19, 2017 at 05:19:18PM -0700, Vinicius Costa Gomes wrote: > One of the problems with OpenAVNU is that it's too coupled with the i210 > NIC. One of the things we want is to decouple OpenAVNU from the > controller. Yes, I want that, too. > The way we thought best was to propose

TSN Scorecard, was Re: [RFC net-next 0/5] TSN: Add qdisc-based config interfaces for traffic shapers

2017-09-19 Thread levipearson
On Mon, Sep 18, 2017, Richard Cochran wrote: > Just for the record, here is my score card showing the current status > of TSN support in Linux. Comments and corrections are more welcome. > > Thanks, > Richard > > > | FEATURE| STANDARD| >

Re: [RFC PATCH] net: Introduce a socket option to enable picking tx queue based on rx queue.

2017-09-19 Thread Eric Dumazet
On Tue, 2017-09-19 at 21:59 -0700, Samudrala, Sridhar wrote: > On 9/19/2017 5:48 PM, Tom Herbert wrote: > > On Tue, Sep 19, 2017 at 5:34 PM, Samudrala, Sridhar > > wrote: > > > On 9/12/2017 3:53 PM, Tom Herbert wrote: > > > > On Tue, Sep 12, 2017 at 3:31 PM,

Re: [PATCH,net-next,0/2] Improve code coverage of syzkaller

2017-09-19 Thread Petar Penkov
On Tue, Sep 19, 2017 at 4:01 PM, David Miller wrote: > From: Petar Penkov > Date: Tue, 19 Sep 2017 00:34:00 -0700 > >> The following patches address this by providing the user(syzkaller) >> with the ability to send via napi_gro_receive() and

[PATCH net] net/ncsi: Don't assume last available channel exists

2017-09-19 Thread Samuel Mendoza-Jonas
When handling new VLAN tags in NCSI we check the maximum allowed number of filters on the last active ("hot") channel. However if the 'add' callback is called before NCSI has configured a channel, this causes a NULL dereference. Check that we actually have a hot channel, and warn if it is

Re: Latest net-next from GIT panic

2017-09-19 Thread Eric Dumazet
On Wed, 2017-09-20 at 02:06 +0200, Paweł Staszewski wrote: > Just checked kernel 4.13.2 and same problem > > Just after start all 6 bgp sessions - and kernel starts to learn routes > it panic. > > https://bugzilla.kernel.org/attachment.cgi?id=258509 > Unfortunately we have not enough

Re: [PATCH,net-next,2/2] tun: enable napi_gro_frags() for TUN/TAP driver

2017-09-19 Thread Eric Dumazet
On Tue, 2017-09-19 at 00:34 -0700, Petar Penkov wrote: > Add a TUN/TAP receive mode that exercises the napi_gro_frags() > interface. This mode is available only in TAP mode, as the interface > expects packets with Ethernet headers. > > Furthermore, packets follow the layout of the iovec_iter that

Re: [PATCH,net-next,1/2] tun: enable NAPI for TUN/TAP driver

2017-09-19 Thread Eric Dumazet
On Tue, 2017-09-19 at 00:34 -0700, Petar Penkov wrote: > Changes TUN driver to use napi_gro_receive() upon receiving packets > rather than netif_rx_ni(). Adds flag CONFIG_TUN_NAPI that enables > these changes and operation is not affected if the flag is disabled. > SKBs are constructed upon packet

Re: [PATCH v5 05/10] dt-bindings: net: dwmac-sun8i: update documentation about integrated PHY

2017-09-19 Thread Rob Herring
On Thu, Sep 14, 2017 at 2:19 PM, Andrew Lunn wrote: >> > Is the MDIO controller "allwinner,sun8i-h3-emac" or "snps,dwmac-mdio"? >> > If the latter, then I think the node is fine, but then the mux should be >> > a child node of it. IOW, the child of an MDIO controller should either

RE: [PATCH RFC v1 0/3] Support for tap user-space access with veth interfaces

2017-09-19 Thread Grandhi, Sainath
Just a reminder for feedback. > -Original Message- > From: Grandhi, Sainath > Sent: Wednesday, September 06, 2017 5:34 PM > To: netdev@vger.kernel.org > Cc: da...@davemloft.net; Grandhi, Sainath > Subject: [PATCH RFC v1 0/3] Support for tap user-space access

RE: [PATCH v4 2/3] net: fec: remove unused interrupt FEC_ENET_TS_TIMER

2017-09-19 Thread Andy Duan
From: Troy Kisky Sent: Wednesday, September 20, 2017 8:33 AM >FEC_ENET_TS_TIMER is not checked in the interrupt routine so there is no >need to enable it. > >Signed-off-by: Troy Kisky >Acked-by: Fugang Duan >

Re: [RFC net-next 0/5] TSN: Add qdisc-based config interfaces for traffic shapers

2017-09-19 Thread levipearson
On Thu, Aug 31, 2017 at 06:26:20PM -0700, Vinicius Costa Gomes wrote: > Hi, > > This patchset is an RFC on a proposal of how the Traffic Control subsystem can > be used to offload the configuration of traffic shapers into network devices > that provide support for them in HW. Our goal here is to

[PATCH] isdn/i4l: fetch the ppp_write buffer in one shot

2017-09-19 Thread Meng Xu
In isdn_ppp_write(), the header (i.e., protobuf) of the buffer is fetched twice from userspace. The first fetch is used to peek at the protocol of the message and reset the huptimer if necessary; while the second fetch copies in the whole buffer. However, given that buf resides in userspace

[PATCHv3 iproute2 2/2] lib/libnetlink: update rtnl_talk to support malloc buff at run time

2017-09-19 Thread Hangbin Liu
This is an update for 460c03f3f3cc ("iplink: double the buffer size also in iplink_get()"). After update, we will not need to double the buffer size every time when VFs number increased. With call like rtnl_talk(, , NULL, 0), we can simply remove the length parameter. With call like rtnl_talk(,

[PATCHv3 iproute2 0/2] libnetlink: malloc correct buff at run time

2017-09-19 Thread Hangbin Liu
With commit 72b365e8e0fd ("libnetlink: Double the dump buffer size") and 460c03f3f3cc ("iplink: double the buffer size also in iplink_get()"), we extend the buffer size to avoid truncated message with large numbers of VFs. But just as Michal said, this is not future-proof since the NIC number is

[PATCHv3 iproute2 1/2] lib/libnetlink: re malloc buff if size is not enough

2017-09-19 Thread Hangbin Liu
With commit 72b365e8e0fd ("libnetlink: Double the dump buffer size") we doubled the buffer size to support more VFs. But the VFs number is increasing all the time. Some customers even use more than 200 VFs now. We could not double it everytime when the buffer is not enough. Let's just not hard

[PATCH v4 3/3] net: fec: return IRQ_HANDLED if fec_ptp_check_pps_event handled it

2017-09-19 Thread Troy Kisky
fec_ptp_check_pps_event will return 1 if FEC_T_TF_MASK caused an interrupt. Don't return IRQ_NONE in this case. Signed-off-by: Troy Kisky Acked-by: Fugang Duan --- v3: New patch, came from feedback from another patch. v4: Added Acked-by

[PATCH v4 2/3] net: fec: remove unused interrupt FEC_ENET_TS_TIMER

2017-09-19 Thread Troy Kisky
FEC_ENET_TS_TIMER is not checked in the interrupt routine so there is no need to enable it. Signed-off-by: Troy Kisky Acked-by: Fugang Duan --- v4: Added Acked-by Signed-off-by: Troy Kisky ---

[PATCH v4 1/3] net: fec: only check queue 0 if RXF_0/TXF_0 interrupt is set

2017-09-19 Thread Troy Kisky
Before queue 0 was always checked if any queue caused an interrupt. It is better to just mark queue 0 if queue 0 has caused an interrupt. Signed-off-by: Troy Kisky Acked-by: Fugang Duan --- v3: add Acked-by v4: no change Signed-off-by: Troy

linux-next: manual merge of the net-next tree with the driver-core.current tree

2017-09-19 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: lib/kobject_uevent.c between commit: 6878e7de6af7 ("driver core: suppress sending MODALIAS in UNBIND uevents") from the driver-core.current tree and commit: 16dff336b33d ("kobject: add

[PATCH 0/2] blackfin: Drop non-functional DSA code

2017-09-19 Thread Florian Fainelli
Hi David, I sent those many months ago in the hope that the bfin-linux people would pick those patches but nobody seems to be responding, can you queue those via net-next since this affects DSA? Thanks! Florian Fainelli (2): blackfin: tcm-bf518: Remove dsa.h inclusion blackfin: ezbrd:

[PATCH 1/2] blackfin: tcm-bf518: Remove dsa.h inclusion

2017-09-19 Thread Florian Fainelli
Nothing in that file uses definitions from that header, so just get rid of it. Signed-off-by: Florian Fainelli --- arch/blackfin/mach-bf518/boards/tcm-bf518.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/blackfin/mach-bf518/boards/tcm-bf518.c

[PATCH 2/2] blackfin: ezbrd: Remove non-functional DSA/KSZ8893M code

2017-09-19 Thread Florian Fainelli
There is no in tree driver for the KSZ8893M switch driver, so just get rid of the code in that board file. Signed-off-by: Florian Fainelli --- arch/blackfin/mach-bf518/boards/ezbrd.c | 47 - 1 file changed, 47 deletions(-) diff --git

[PATCH net-next] net: dsa: Utilize dsa_slave_dev_check()

2017-09-19 Thread Florian Fainelli
Instead of open coding the check. Signed-off-by: Florian Fainelli --- net/dsa/slave.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/dsa/slave.c b/net/dsa/slave.c index d51b10450e1b..6fc9eb094267 100644 --- a/net/dsa/slave.c +++ b/net/dsa/slave.c

Re: [RFC PATCH] net: Introduce a socket option to enable picking tx queue based on rx queue.

2017-09-19 Thread Tom Herbert
On Tue, Sep 19, 2017 at 5:34 PM, Samudrala, Sridhar wrote: > On 9/12/2017 3:53 PM, Tom Herbert wrote: >> >> On Tue, Sep 12, 2017 at 3:31 PM, Samudrala, Sridhar >> wrote: >>> >>> >>> On 9/12/2017 8:47 AM, Eric Dumazet wrote: On

Re: [PATCH] ipv6_skip_exthdr: use ipv6_authlen for AH hdrlen

2017-09-19 Thread Tom Herbert
On Tue, Sep 19, 2017 at 5:59 AM, Xiang Gao wrote: > In ipv6_skip_exthdr, the lengh of AH header is computed manually > as (hp->hdrlen+2)<<2. However, in include/linux/ipv6.h, a macro > named ipv6_authlen is already defined for exactly the same job. This > commit replaces

Re: [RFC PATCH] net: Introduce a socket option to enable picking tx queue based on rx queue.

2017-09-19 Thread Samudrala, Sridhar
On 9/12/2017 3:53 PM, Tom Herbert wrote: On Tue, Sep 12, 2017 at 3:31 PM, Samudrala, Sridhar wrote: On 9/12/2017 8:47 AM, Eric Dumazet wrote: On Mon, 2017-09-11 at 23:27 -0700, Samudrala, Sridhar wrote: On 9/11/2017 8:53 PM, Eric Dumazet wrote: On Mon,

Re: Latest net-next from GIT panic

2017-09-19 Thread Paweł Staszewski
Latest working kernel with same configuration and kernel config 4.12.13 There is no panic after routes from all 6x bgp sessions are learned. ip r | wc -l 653112 W dniu 2017-09-20 o 02:06, Paweł Staszewski pisze: Just checked kernel 4.13.2 and same problem Just after start all 6 bgp

Re: [RFC net-next 0/5] TSN: Add qdisc-based config interfaces for traffic shapers

2017-09-19 Thread Vinicius Costa Gomes
Hi Richard, Richard Cochran writes: > On Mon, Sep 18, 2017 at 04:06:28PM -0700, Vinicius Costa Gomes wrote: >> That's the point, the application does not need to know that, and asking >> that would be stupid. > > On the contrary, this information is essential to the

Re: [PATCH net-next 07/14] gtp: Support encapsulation of IPv6 packets

2017-09-19 Thread Tom Herbert
On Tue, Sep 19, 2017 at 10:42 AM, David Miller wrote: > From: Harald Welte > Date: Tue, 19 Sep 2017 20:12:45 +0800 > >> Hi Dave, >> >> On Mon, Sep 18, 2017 at 09:19:08PM -0700, David Miller wrote: >> >>> > +static inline u32 ipv6_hashfn(const struct

Re: Latest net-next from GIT panic

2017-09-19 Thread Paweł Staszewski
Just checked kernel 4.13.2 and same problem Just after start all 6 bgp sessions - and kernel starts to learn routes it panic. https://bugzilla.kernel.org/attachment.cgi?id=258509 W dniu 2017-09-20 o 02:01, Paweł Staszewski pisze: Some information about enviroment: Server is acting as a ip

Re: Latest net-next from GIT panic

2017-09-19 Thread Paweł Staszewski
Some information about enviroment: Server is acting as a ip router with bgp There are 6x bgp sessions - each with full bgp table ~600k prefixes And it looks like panic is appearing after bgp sessions are connected - not by traffic - cause at time when panic occured there is almost no traffic.

Re: Latest net-next from GIT panic

2017-09-19 Thread Paweł Staszewski
Added few more screenshoots from kernels 4.14-rc1(net-next) and 4.14-rc1(linux-next) https://bugzilla.kernel.org/show_bug.cgi?id=197005 W dniu 2017-09-20 o 00:35, Paweł Staszewski pisze: Just tried latest net-next git and found kernel panic. Below link to bugzilla.

Re: [PATCH net-next 00/14] gtp: Additional feature support

2017-09-19 Thread Tom Herbert
On Tue, Sep 19, 2017 at 4:19 PM, Harald Welte wrote: > Hi Tom, > > On Tue, Sep 19, 2017 at 08:59:28AM -0700, Tom Herbert wrote: >> On Tue, Sep 19, 2017 at 5:43 AM, Harald Welte >> wrote: >> > On Mon, Sep 18, 2017 at 05:38:50PM -0700, Tom Herbert wrote:

Development Setup

2017-09-19 Thread sdnlabs Janakaraj
Dear all, I am new a newbie, I am curious to know what development tools with Ubuntu as Host OS, will best fit for people entering into linux kernel development focusing on Netlink, Netdev and Wireless MAC. I have read many blogs describing the basic setup and things like that. But I felt input

Re: [PATCH net] ipv6: fix net.ipv6.conf.all interface DAD handlers

2017-09-19 Thread David Miller
From: Matteo Croce Date: Tue, 12 Sep 2017 17:46:37 +0200 > Currently, writing into > net.ipv6.conf.all.{accept_dad,use_optimistic,optimistic_dad} has no effect. > Fix handling of these flags by: > > - using the maximum of global and per-interface values for the > accept_dad

Re: [PATCH] net: ipv6: fix regression of no RTM_DELADDR sent after DAD failure

2017-09-19 Thread David Miller
From: Mike Manning Date: Mon, 18 Sep 2017 14:06:40 +0100 > In the absence of a reply from Mahesh, I would be most grateful for > anyone familiar with the IPv6 code to review this 1-line fix. > > Or if not, then I request that the commit f784ad3d79e5 is backed out, > as its

Re: [PATCH net v2] bpf: fix ri->map_owner pointer on bpf_prog_realloc

2017-09-19 Thread David Miller
From: Daniel Borkmann Date: Wed, 20 Sep 2017 00:44:21 +0200 > Commit 109980b894e9 ("bpf: don't select potentially stale > ri->map from buggy xdp progs") passed the pointer to the prog > itself to be loaded into r4 prior on bpf_redirect_map() helper > call, so that we can

Re: [PATCH v2 net-next 0/7] net: speedup netns create/delete time

2017-09-19 Thread David Miller
From: Eric Dumazet Date: Tue, 19 Sep 2017 16:27:02 -0700 > When rate of netns creation/deletion is high enough, > we observe softlockups in cleanup_net() caused by huge list > of netns and way too many rcu_barrier() calls. > > This patch series does some optimizations in

Re: [PATCH net-next] net_sched: no need to free qdisc in RCU callback

2017-09-19 Thread David Miller
From: Cong Wang Date: Tue, 19 Sep 2017 13:15:42 -0700 > gen estimator has been rewritten in commit 1c0d32fde5bd > ("net_sched: gen_estimator: complete rewrite of rate estimators"), > the caller no longer needs to wait for a grace period. So this > patch gets rid of it.

Re: [PATCH] isdn/i4l: check the message proto does not change across fetches

2017-09-19 Thread David Miller
From: Meng Xu Date: Tue, 19 Sep 2017 14:52:58 -0400 > In isdn_ppp_write(), the header (i.e., protobuf) of the buffer is fetched > twice from userspace. The first fetch is used to peek at the protocol > of the message and reset the huptimer if necessary; while the second

[PATCH v2 net-next 1/7] kobject: add kobject_uevent_net_broadcast()

2017-09-19 Thread Eric Dumazet
This removes some #ifdef pollution and will ease follow up patches. Signed-off-by: Eric Dumazet --- lib/kobject_uevent.c | 96 +--- 1 file changed, 53 insertions(+), 43 deletions(-) diff --git a/lib/kobject_uevent.c

[PATCH v2 net-next 5/7] tcp: batch tcp_net_metrics_exit

2017-09-19 Thread Eric Dumazet
When dealing with a list of dismantling netns, we can scan tcp_metrics once, saving cpu cycles. Signed-off-by: Eric Dumazet --- net/ipv4/tcp_metrics.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/net/ipv4/tcp_metrics.c

[PATCH v2 net-next 6/7] ipv6: speedup ipv6 tunnels dismantle

2017-09-19 Thread Eric Dumazet
Implement exit_batch() method to dismantle more devices per round. (rtnl_lock() ... unregister_netdevice_many() ... rtnl_unlock()) Tested: $ cat add_del_unshare.sh for i in `seq 1 40` do (for j in `seq 1 100` ; do unshare -n /bin/true >/dev/null ; done) & done wait ; grep net_namespace

[PATCH v2 net-next 4/7] ipv6: addrlabel: per netns list

2017-09-19 Thread Eric Dumazet
Having a global list of labels do not scale to thousands of netns in the cloud era. This causes quadratic behavior on netns creation and deletion. This is time having a per netns list of ~10 labels. Tested: $ time perf record (for f in `seq 1 3000` ; do ip netns add tast$f; done) [ perf record:

[PATCH v2 net-next 3/7] kobject: factorize skb setup in kobject_uevent_net_broadcast()

2017-09-19 Thread Eric Dumazet
We can build one skb and let it be cloned in netlink. This is much faster, and use less memory (all clones will share the same skb->head) Tested: time perf record (for f in `seq 1 3000` ; do ip netns add tast$f; done) [ perf record: Woken up 1 times to write data ] [ perf record: Captured and

[PATCH v2 net-next 7/7] ipv4: speedup ipv6 tunnels dismantle

2017-09-19 Thread Eric Dumazet
Implement exit_batch() method to dismantle more devices per round. (rtnl_lock() ... unregister_netdevice_many() ... rtnl_unlock()) Tested: $ cat add_del_unshare.sh for i in `seq 1 40` do (for j in `seq 1 100` ; do unshare -n /bin/true >/dev/null ; done) & done wait ; grep net_namespace

[PATCH v2 net-next 2/7] kobject: copy env blob in one go

2017-09-19 Thread Eric Dumazet
No need to iterate over strings, just copy in one efficient memcpy() call. Tested: time perf record "(for f in `seq 1 3000` ; do ip netns add tast$f; done)" [ perf record: Woken up 10 times to write data ] [ perf record: Captured and wrote 8.224 MB perf.data (~359301 samples) ] real0m52.554s

[PATCH v2 net-next 0/7] net: speedup netns create/delete time

2017-09-19 Thread Eric Dumazet
When rate of netns creation/deletion is high enough, we observe softlockups in cleanup_net() caused by huge list of netns and way too many rcu_barrier() calls. This patch series does some optimizations in kobject, and add batching to tunnels so that netns dismantles are less costly. IPv6

Re: [PATCH net-next 00/14] gtp: Additional feature support

2017-09-19 Thread Harald Welte
Hi Tom, On Tue, Sep 19, 2017 at 08:59:28AM -0700, Tom Herbert wrote: > On Tue, Sep 19, 2017 at 5:43 AM, Harald Welte > wrote: > > On Mon, Sep 18, 2017 at 05:38:50PM -0700, Tom Herbert wrote: > >> - IPv6 support > > > > see my detailed comments in other mails. It's

Re: [PATCH] net: emac: Fix napi poll list corruption

2017-09-19 Thread David Miller
From: Christian Lamparter Date: Tue, 19 Sep 2017 19:35:18 +0200 > This patch is pretty much a carbon copy of > commit 3079c652141f ("caif: Fix napi poll list corruption") > with "caif" replaced by "emac". > > The commit d75b1ade567f ("net: less interrupt masking in

Re: [PATCH net-next 0/7] net: speedup netns create/delete time

2017-09-19 Thread Eric Dumazet
On Tue, 2017-09-19 at 16:02 -0700, David Miller wrote: > From: Eric Dumazet > Date: Mon, 18 Sep 2017 12:07:26 -0700 > > > When rate of netns creation/deletion is high enough, > > we observe softlockups in cleanup_net() caused by huge list > > of netns and way too many

Re: [patch net-next] team: fall back to hash if table entry is empty

2017-09-19 Thread David Miller
From: Jim Hanko Date: Tue, 19 Sep 2017 11:33:39 -0700 > If the hash to port mapping table does not have a valid port (i.e. when > a port goes down), fall back to the simple hashing mechanism to avoid > dropping packets. > > Signed-off-by: Jim Hanko >

Re: [PATCH net] tcp: fastopen: fix on syn-data transmit failure

2017-09-19 Thread David Miller
From: Eric Dumazet Date: Tue, 19 Sep 2017 10:05:57 -0700 > From: Eric Dumazet > > Our recent change exposed a bug in TCP Fastopen Client that syzkaller > found right away [1] > > When we prepare skb with SYN+DATA, we attempt to transmit it, > and

Re: [net-next v2 0/4] test_rhashtable: don't allocate huge static array

2017-09-19 Thread David Miller
From: Florian Westphal Date: Wed, 20 Sep 2017 01:12:10 +0200 > Add a test case for the rhlist interface. > While at it, cleanup current rhashtable test a bit and add a check > for max_size support. > > No changes since v1, except in last patch. > kbuild robot complained about

[net-next v2 3/4] test_rhashtable: add a check for max_size

2017-09-19 Thread Florian Westphal
add a test that tries to insert more than max_size elements. Signed-off-by: Florian Westphal --- lib/test_rhashtable.c | 41 + 1 file changed, 41 insertions(+) diff --git a/lib/test_rhashtable.c b/lib/test_rhashtable.c index

[net-next v2 4/4] test_rhashtable: add test case for rhl_table interface

2017-09-19 Thread Florian Westphal
also test rhltable. rhltable remove operations are slow as deletions require a list walk, thus test with 1/16th of the given entry count number to get a run duration similar to rhashtable one. Signed-off-by: Florian Westphal --- change since v1: place struct rhltable in

[net-next v2 1/4] test_rhashtable: don't allocate huge static array

2017-09-19 Thread Florian Westphal
Signed-off-by: Florian Westphal --- lib/test_rhashtable.c | 27 --- 1 file changed, 16 insertions(+), 11 deletions(-) diff --git a/lib/test_rhashtable.c b/lib/test_rhashtable.c index 0ffca990a833..c40d6e636f33 100644 --- a/lib/test_rhashtable.c +++

[net-next v2 2/4] test_rhashtable: don't use global entries variable

2017-09-19 Thread Florian Westphal
pass the entries to test as an argument instead. Followup patch will add an rhlist test case; rhlist delete opererations are slow so we need to use a smaller number to test it. Signed-off-by: Florian Westphal --- lib/test_rhashtable.c | 37 +++--

[net-next v2 0/4] test_rhashtable: don't allocate huge static array

2017-09-19 Thread Florian Westphal
Add a test case for the rhlist interface. While at it, cleanup current rhashtable test a bit and add a check for max_size support. No changes since v1, except in last patch. kbuild robot complained about large onstack allocation caused by struct rhltable when lockdep is enabled.

Re: [PATCH net-next v3 00/12] net: dsa: b53/bcm_sf2 cleanups

2017-09-19 Thread David Miller
From: Florian Fainelli Date: Tue, 19 Sep 2017 10:46:42 -0700 > This patch series is a first pass set of clean-ups to reduce the number of > LOCs > between b53 and bcm_sf2 and sharing as many functions as possible. > > There is a number of additional cleanups queued up

Re: [PATCH V2 net 0/7] Bug fixes for the HNS3 Ethernet Driver for Hip08 SoC

2017-09-19 Thread David Miller
From: Salil Mehta Date: Tue, 19 Sep 2017 17:17:09 +0100 > This patch set presents some bug fixes for the HNS3 Ethernet driver identified > during internal testing & stabilization efforts. > > Change Log: > Patch V2: Resolved comments from Leon Romanovsky > Patch V1:

Re: [PATCH net-next 0/4] net: dsa: move master ethtool code

2017-09-19 Thread David Miller
From: Florian Fainelli Date: Tue, 19 Sep 2017 13:04:56 -0700 > On 09/19/2017 08:56 AM, Vivien Didelot wrote: >> The DSA core overrides the master device's ethtool_ops structure so that >> it can inject statistics and such of its dedicated switch CPU port. >> >> This

Re: [PATCH net-next 0/7] net: speedup netns create/delete time

2017-09-19 Thread David Miller
From: Eric Dumazet Date: Mon, 18 Sep 2017 12:07:26 -0700 > When rate of netns creation/deletion is high enough, > we observe softlockups in cleanup_net() caused by huge list > of netns and way too many rcu_barrier() calls. > > This patch series does some optimizations in

Re: [PATCH,net-next,0/2] Improve code coverage of syzkaller

2017-09-19 Thread David Miller
From: Petar Penkov Date: Tue, 19 Sep 2017 00:34:00 -0700 > The following patches address this by providing the user(syzkaller) > with the ability to send via napi_gro_receive() and napi_gro_frags(). > Additionally, syzkaller can specify how many fragments there are and >

Re: [PATCH] net: ethernet: aquantia: default to no in config

2017-09-19 Thread David Miller
From: vcap...@pengaru.com Date: Tue, 19 Sep 2017 16:02:49 -0700 > Out of curiosity, what's the rationale for that decision? So that you don't need to know what special vendor knob needs to be switched in order to even be offered the config knob for the driver you are interested in.

Re: [PATCH] net: ethernet: aquantia: default to no in config

2017-09-19 Thread vcaputo
On Tue, Sep 19, 2017 at 03:52:31PM -0700, David Miller wrote: > From: Vito Caputo > Date: Tue, 19 Sep 2017 15:43:15 -0700 > > > NET_VENDOR_AQUANTIA was "default y" for some reason, which seems > > obviously inappropriate. > > It is appropriate. > > We make all vendor

Re: [PATCH] net: ethernet: aquantia: default to no in config

2017-09-19 Thread David Miller
From: Vito Caputo Date: Tue, 19 Sep 2017 15:43:15 -0700 > NET_VENDOR_AQUANTIA was "default y" for some reason, which seems > obviously inappropriate. It is appropriate. We make all vendor guards default to yes.

[PATCH] net: ethernet: aquantia: default to no in config

2017-09-19 Thread Vito Caputo
NET_VENDOR_AQUANTIA was "default y" for some reason, which seems obviously inappropriate. --- drivers/net/ethernet/aquantia/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/aquantia/Kconfig b/drivers/net/ethernet/aquantia/Kconfig index

[PATCH net v2] bpf: fix ri->map_owner pointer on bpf_prog_realloc

2017-09-19 Thread Daniel Borkmann
Commit 109980b894e9 ("bpf: don't select potentially stale ri->map from buggy xdp progs") passed the pointer to the prog itself to be loaded into r4 prior on bpf_redirect_map() helper call, so that we can store the owner into ri->map_owner out of the helper. Issue with that is that the actual

Re: [PATCH net] bpf: do not disable/enable BH in bpf_map_free_id()

2017-09-19 Thread David Miller
From: Eric Dumazet Date: Tue, 19 Sep 2017 09:15:59 -0700 > From: Eric Dumazet > > syzkaller reported following splat [1] > > Since hard irq are disabled by the caller, bpf_map_free_id() > should not try to enable/disable BH. > > Another solution

Latest net-next from GIT panic

2017-09-19 Thread Paweł Staszewski
Just tried latest net-next git and found kernel panic. Below link to bugzilla. https://bugzilla.kernel.org/attachment.cgi?id=258499

Re: [PATCH] ipv6_skip_exthdr: use ipv6_authlen for AH hdrlen

2017-09-19 Thread David Miller
From: Xiang Gao Date: Tue, 19 Sep 2017 08:59:50 -0400 > In ipv6_skip_exthdr, the lengh of AH header is computed manually > as (hp->hdrlen+2)<<2. However, in include/linux/ipv6.h, a macro > named ipv6_authlen is already defined for exactly the same job. This > commit

Re: [PATCH net-next] selftests: rtnetlink.sh: add test case for device ifalias

2017-09-19 Thread David Miller
From: Florian Westphal Date: Tue, 19 Sep 2017 14:42:17 +0200 > Signed-off-by: Florian Westphal Applied, thanks Florian.

Re: [PATCH net] tcp: fastopen: fix on syn-data transmit failure

2017-09-19 Thread Yuchung Cheng
On Tue, Sep 19, 2017 at 10:05 AM, Eric Dumazet wrote: > From: Eric Dumazet > > Our recent change exposed a bug in TCP Fastopen Client that syzkaller > found right away [1] > > When we prepare skb with SYN+DATA, we attempt to transmit it, > and we

Re: [PATCH v2 net-next] net: sk_buff rbnode reorg

2017-09-19 Thread David Miller
From: Eric Dumazet Date: Tue, 19 Sep 2017 05:14:24 -0700 > From: Eric Dumazet > > skb->rbnode shares space with skb->next, skb->prev and skb->tstamp > > Current uses (TCP receive ofo queue and netem) need to save/restore > tstamp, while skb->dev is

Re: [PATCH] rhashtable: Documentation tweak

2017-09-19 Thread David Miller
From: Andreas Gruenbacher Date: Tue, 19 Sep 2017 12:41:37 +0200 > Clarify that rhashtable_walk_{stop,start} will not reset the iterator to > the beginning of the hash table. Confusion between rhashtable_walk_enter > and rhashtable_walk_start has already lead to a bug. > >

Reporting transceiver with ethtool_link_ksettings

2017-09-19 Thread Florian Fainelli
Hi, After tracking down why all network interfaces using PHYLIB and using phy_ethtool_link_ksettings_get would report "Transceiver: internal" it became clear that's because ethtool_link_ksettings deprecated that field... We could have deprecated setting the transceiver which makes sense, but not

Re: [PATCH] tcp: avoid bogus warning in tcp_clean_rtx_queue

2017-09-19 Thread David Miller
From: Arnd Bergmann Date: Tue, 19 Sep 2017 23:32:33 +0200 > On Tue, Sep 19, 2017 at 11:02 PM, David Miller wrote: >> What cpu did you test the object code generation upon and does that >> cpu have branch prediction hints in the target you are building for? >

Reply

2017-09-19 Thread a
Are you free for discussion?

Re: [PATCH] tcp: avoid bogus warning in tcp_clean_rtx_queue

2017-09-19 Thread Arnd Bergmann
On Tue, Sep 19, 2017 at 11:02 PM, David Miller wrote: > From: Arnd Bergmann > Date: Mon, 18 Sep 2017 22:48:47 +0200 > >> gcc-4.9 warns that it cannot trace the state of the 'last_ackt' >> variable since the change to the TCP timestamping code, when >>

Re: [PATCH 3/3][v2] selftests: silence test output by default

2017-09-19 Thread Shuah Khan
On 09/19/2017 07:51 AM, jo...@toxicpanda.com wrote: > From: Josef Bacik > > Some of the networking tests are very noisy and make it impossible to > see if we actually passed the tests as they run. Default to suppressing > the output from any tests run in order to make it easier

Re: [PATCH net-next 0/3] Implement delete for BPF LPM trie

2017-09-19 Thread Daniel Mack
On 09/19/2017 11:29 PM, David Miller wrote: > From: Craig Gallek > Date: Tue, 19 Sep 2017 17:16:13 -0400 > >> On Tue, Sep 19, 2017 at 5:13 PM, Daniel Mack wrote: >>> On 09/19/2017 10:55 PM, David Miller wrote: From: Craig Gallek

Re: [PATCH 2/3][v2] selftests: actually run the various net selftests

2017-09-19 Thread Shuah Khan
On 09/19/2017 07:51 AM, jo...@toxicpanda.com wrote: > From: Josef Bacik > > These self tests are just self contained binaries, they are not run by > any of the scripts in the directory. This means they need to be marked > with TEST_GEN_PROGS to actually be run, not

Re: [PATCH 1/3][v2] selftest: add a reuseaddr test

2017-09-19 Thread Shuah Khan
On 09/19/2017 07:51 AM, jo...@toxicpanda.com wrote: > From: Josef Bacik > > This is to test for a regression introduced by > > b9470c27607b ("inet: kill smallest_size and smallest_port") > > which introduced a problem with reuseaddr and bind conflicts. > > Signed-off-by: Josef

Re: [PATCH net-next 0/3] Implement delete for BPF LPM trie

2017-09-19 Thread David Miller
From: Craig Gallek Date: Tue, 19 Sep 2017 17:16:13 -0400 > On Tue, Sep 19, 2017 at 5:13 PM, Daniel Mack wrote: >> On 09/19/2017 10:55 PM, David Miller wrote: >>> From: Craig Gallek >>> Date: Mon, 18 Sep 2017 15:30:54 -0400 >>>

Re: [PATCH net-next] net_sched: no need to free qdisc in RCU callback

2017-09-19 Thread Eric Dumazet
On Tue, 2017-09-19 at 13:15 -0700, Cong Wang wrote: > gen estimator has been rewritten in commit 1c0d32fde5bd > ("net_sched: gen_estimator: complete rewrite of rate estimators"), > the caller no longer needs to wait for a grace period. So this > patch gets rid of it. > > Cc: Jamal Hadi Salim

Re: [patch net-next 00/13] mlxsw: Prepare for multicast router offload

2017-09-19 Thread David Miller
From: Jiri Pirko Date: Tue, 19 Sep 2017 10:00:07 +0200 > From: Jiri Pirko > > Yotam says: > > This patch-set makes various preparations needed for the multicast router > offloading, which include: > - Add the needed registers. > - Add needed ACL actions.

Re: [PATCH net-next 0/3] Implement delete for BPF LPM trie

2017-09-19 Thread Craig Gallek
On Tue, Sep 19, 2017 at 5:13 PM, Daniel Mack wrote: > On 09/19/2017 10:55 PM, David Miller wrote: >> From: Craig Gallek >> Date: Mon, 18 Sep 2017 15:30:54 -0400 >> >>> This was previously left as a TODO. Add the implementation and >>> extend the test to

Re: [PATCH net-next 0/3] Implement delete for BPF LPM trie

2017-09-19 Thread Daniel Mack
On 09/19/2017 10:55 PM, David Miller wrote: > From: Craig Gallek > Date: Mon, 18 Sep 2017 15:30:54 -0400 > >> This was previously left as a TODO. Add the implementation and >> extend the test to cover it. > > Series applied, thanks. > Hmm, I think these patches need

[PATCH] mwifiex: make const array tos_to_ac static, reduces object code size

2017-09-19 Thread Colin King
From: Colin Ian King Don't populate the read-only const array tos_to_ac on the stack, instead make it static. Makes the object code smaller by 250 bytes: Before: textdata bss dec hex filename 261042720 128 289527118 wmm.o After:

Re: [PATCH net-next 0/4] test_rhashtable: add test case for rhl table

2017-09-19 Thread David Miller
From: Florian Westphal Date: Mon, 18 Sep 2017 23:07:07 +0200 > Add a test case for the rhlist interface. > > While at it, cleanup current rhashtable test a bit and add a check > for max_size support. The kbuild test robot complained about a very large on-stack allocation added

Re: [PATCH] tcp: avoid bogus warning in tcp_clean_rtx_queue

2017-09-19 Thread David Miller
From: Arnd Bergmann Date: Mon, 18 Sep 2017 22:48:47 +0200 > gcc-4.9 warns that it cannot trace the state of the 'last_ackt' > variable since the change to the TCP timestamping code, when > CONFIG_PROFILE_ANNOTATED_BRANCHES is set: > > net/ipv4/tcp_input.c: In function

Re: cross namespace interface notification for tun devices

2017-09-19 Thread Jason A. Donenfeld
On Tue, Sep 19, 2017 at 10:40 PM, Cong Wang wrote: > By "notification" I assume you mean netlink notification. Yes, netlink notification. > The question is why does the process in A still care about > the device sitting in B? > > Also, the process should be able to

Re: [PATCH net-next 0/3] Implement delete for BPF LPM trie

2017-09-19 Thread David Miller
From: Craig Gallek Date: Mon, 18 Sep 2017 15:30:54 -0400 > This was previously left as a TODO. Add the implementation and > extend the test to cover it. Series applied, thanks.

Re: [PATCH net] net: phy: Kconfig: Fix PHY infrastructure menu in menuconfig

2017-09-19 Thread David Miller
From: Jerome Brunet Date: Mon, 18 Sep 2017 14:59:20 +0200 > Since the integration of PHYLINK, the configuration option which > used to be under the PHY infrastructure menu in menuconfig ended > up one level up (the network device driver section) > > By placing PHYLINK

  1   2   3   >