Hi,
we use a QorIQ P1011 connected via SGMII to a switch (Marvell 88E6352).
Currently we still use a really old linux kernel (2.6.33) successfully.
For configuration of the MDIO Bus attached to the corresponding eTSEC/TBI
Phy we use the following settings in the device tree:
On 2017/10/04 14:12, Roopa Prabhu wrote:
> From: Roopa Prabhu
>
> This patch adds a new bridge port flag BR_NEIGH_SUPPRESS to
> suppress arp and nd flood on bridge ports. It implements
> rfc7432, section 10.
> https://tools.ietf.org/html/rfc7432#section-10
> for ethernet VPN deployments. It is si
On 2017/10/04 14:12, Roopa Prabhu wrote:
> From: Roopa Prabhu
>
> This patch avoids flooding and proxies arp packets
> for BR_NEIGH_SUPPRESS ports.
>
> Moves existing br_do_proxy_arp to br_do_proxy_suppress_arp
> to support both proxy arp and neigh suppress.
>
> Signed-off-by: Roopa Prabhu
> -
On 3 October 2017 at 08:27, James Chapman wrote:
> On 2 October 2017 at 19:35, SviMik wrote:
>> Hi, James!
>>
>> No, I'm suffering from kernel panics since I started using 4.x
>> kernels.
> It's interesting that you are seeing l2tp issues since switching to
> 4.x kernels. Are you able to try earl
Add support for RX checksum offload. This is enabled by default and
may be disabled and re-enabled using ethtool:
# ethtool -K eth0 rx off
# ethtool -K eth0 rx on
The RAVB provides a simple checksumming scheme which appears to be
completely compatible with CHECKSUM_COMPLETE: sum of all packet d
On Tue, Oct 03, 2017 at 11:17:46AM -0700, Tom Herbert wrote:
> On Tue, Oct 3, 2017 at 2:40 AM, Simon Horman
> wrote:
> > On Mon, Oct 02, 2017 at 01:37:55PM -0700, Tom Herbert wrote:
> >> On Mon, Oct 2, 2017 at 1:41 AM, Simon Horman
> >> wrote:
> >> > Move dissection of tunnel info from the flow
Wed, Oct 04, 2017 at 10:08:57AM CEST, simon.hor...@netronome.com wrote:
>On Tue, Oct 03, 2017 at 11:17:46AM -0700, Tom Herbert wrote:
>> On Tue, Oct 3, 2017 at 2:40 AM, Simon Horman
>> wrote:
>> > On Mon, Oct 02, 2017 at 01:37:55PM -0700, Tom Herbert wrote:
>> >> On Mon, Oct 2, 2017 at 1:41 AM, S
On 04/10/17 03:32, Stephen Hemminger wrote:
> The name ipv4v6_shared is longer than it needs to be maybe ip or ip_common
Well ip_common sounds nice.
But I don't fully understand what this means for the current situation.
I could do a v2, but would that make any sense since Dave and Eric
already sa
Icenowy Zheng writes:
> Allwinner XR819 is a SDIO Wi-Fi chip, which has the functionality to use
> an out-of-band interrupt pin instead of SDIO in-band interrupt.
>
> Add the device tree binding of this chip, in order to make it possible
> to add this interrupt pin to device trees.
>
> Signed-off
于 2017年10月4日 GMT+08:00 下午5:02:17, Kalle Valo 写到:
>Icenowy Zheng writes:
>
>> Allwinner XR819 is a SDIO Wi-Fi chip, which has the functionality to
>use
>> an out-of-band interrupt pin instead of SDIO in-band interrupt.
>>
>> Add the device tree binding of this chip, in order to make it
>possible
Colin Ian King wrote:
> Don't populate the read-only array reg_hole_list on the stack, instead make
> it static. Makes the object code smaller by over 200 bytes:
>
> Before:
>text data bss dec hex filename
> 57518 15248 0 72766 11c3e debug.o
>
> Aft
> -Original Message-
> From: David Miller [mailto:da...@davemloft.net]
> Sent: Wednesday, October 04, 2017 7:44 AM
> To: Madalin-cristian Bucur
> Cc: netdev@vger.kernel.org; and...@lunn.ch; f.faine...@gmail.com; linux-
> ker...@vger.kernel.org
> Subject: Re: [PATCH] fsl/fman: remove of_nod
> -Original Message-
> From: Andrew Lunn [mailto:and...@lunn.ch]
> Sent: Tuesday, October 03, 2017 4:01 PM
> To: Madalin-cristian Bucur
> Cc: David Miller ; netdev@vger.kernel.org;
> f.faine...@gmail.com; linux-ker...@vger.kernel.org
> Subject: Re: [PATCH] fsl/fman: remove of_node
>
> On
On 10/4/2017 11:03 AM, Icenowy Zheng wrote:
于 2017年10月4日 GMT+08:00 下午5:02:17, Kalle Valo 写到:
Icenowy Zheng writes:
Allwinner XR819 is a SDIO Wi-Fi chip, which has the functionality to
use
an out-of-band interrupt pin instead of SDIO in-band interrupt.
Add the device tree binding of this
On Wed, Oct 04, 2017 at 10:02:48AM +, Arend van Spriel wrote:
> On 10/4/2017 11:03 AM, Icenowy Zheng wrote:
> >
> >
> > 于 2017年10月4日 GMT+08:00 下午5:02:17, Kalle Valo 写到:
> > > Icenowy Zheng writes:
> > >
> > > > Allwinner XR819 is a SDIO Wi-Fi chip, which has the functionality to
> > > use
于 2017年10月4日 GMT+08:00 下午6:11:45, Maxime Ripard
写到:
>On Wed, Oct 04, 2017 at 10:02:48AM +, Arend van Spriel wrote:
>> On 10/4/2017 11:03 AM, Icenowy Zheng wrote:
>> >
>> >
>> > 于 2017年10月4日 GMT+08:00 下午5:02:17, Kalle Valo
>写到:
>> > > Icenowy Zheng writes:
>> > >
>> > > > Allwinner XR81
On Wed, Oct 04, 2017 at 08:49:51AM +0100, James Chapman wrote:
> On 3 October 2017 at 08:27, James Chapman wrote:
> > On 2 October 2017 at 19:35, SviMik wrote:
> >> Hi, James!
> >>
> >> No, I'm suffering from kernel panics since I started using 4.x
> >> kernels.
> > It's interesting that you are
Am Dienstag, den 03.10.2017, 16:01 +0200 schrieb Bjørn Mork:
> Adding anything else, e.g. based on the table at
> http://www.usb.org/developers/defined_class/#BaseClassEFh , is a bit
> more risky. We don't know if a driver will work with *any* such device
> until we've actually seen one.
>
> This
Hey Michael,
Thanks for your work on ptr_ring.h. I'm interested in using it, but in
a multi-producer, multi-consumer context. I realize it's been designed
for a single-producer, single-consumer context, and thus uses a
spinlock. I'm wondering if you'd be happy to receive patches that
implement thi
Em Tue, Oct 03, 2017 at 05:48:22PM -0700, Jakub Kicinski escreveu:
> On Tue, 3 Oct 2017 17:19:42 -0300, Arnaldo Carvalho de Melo wrote:
> > Why not call it just 'bpf'?
> bpftool was suggested as a better name, I don't really mind either way.
I just thought that 'bpf' isn't used as a command, sho
to make sure this is serialized correctly.
Signed-off-by: Florian Westphal
---
tools/testing/selftests/net/rtnetlink.sh | 8
1 file changed, 8 insertions(+)
diff --git a/tools/testing/selftests/net/rtnetlink.sh
b/tools/testing/selftests/net/rtnetlink.sh
index 62c87da92770..13c29beb576
net/core/dev.c:1306: warning: No description found for parameter 'name'
net/core/dev.c:1306: warning: Excess function parameter 'alias' description in
'dev_get_alias'
Fixes: 6c5570016b97 ("net: core: decouple ifalias get/set from rtnl lock")
Reported-by: kbuild test robot
Signed-off-by: Florian
Add type II erspan vport implementation. Since erspan protocol is
on top of the GRE header, the implementation is extended from the
existing gre implementation.
Signed-off-by: William Tu
Cc: Pravin B Shelar
---
include/net/gre.h| 2 ++
include/uapi/linux/openvswitch.h | 2 ++
This adds two tracepoint to the cpumap. One for the enqueue side
trace_xdp_cpumap_enqueue() and one for the kthread dequeue side
trace_xdp_cpumap_kthread().
To mitigate the tracepoint overhead, these are invoked during the
enqueue/dequeue bulking phases, thus amortizing the cost.
The obvious use
This sample program show how to use cpumap and the associated
tracepoints.
It provides command line stats, which shows how the XDP-RX process,
cpumap-enqueue and cpumap kthread dequeue is cooperating on a per CPU
basis. It also utilize the xdp_exception and xdp_redirect_err
transpoints to allow u
This patch connects cpumap to the xdp_do_redirect_map infrastructure.
Still no SKB allocation are done yet. The XDP frames are transferred
to the other CPU, but they are simply refcnt decremented on the remote
CPU. This served as a good benchmark for measuring the overhead of
remote refcnt decre
This patch makes cpumap functional, by adding SKB allocation and
invoking the network stack on the dequeuing CPU.
For constructing the SKB on the remote CPU, the xdp_buff in converted
into a struct xdp_pkt, and it mapped into the top headroom of the
packet, to avoid allocating separate mem. For n
The 'cpumap' is primary used as a backend map for XDP BPF helper
call bpf_redirect_map() and XDP_REDIRECT action, like 'devmap'.
This patch implement the main part of the map. It is not connected to
the XDP redirect system yet, and no SKB allocation are done yet.
The main concern in this patch i
Introducing a new way to redirect XDP frames. Notice how no driver
changes are necessary given the design of XDP_REDIRECT.
This redirect map type is called 'cpumap', as it allows redirection
XDP frames to remote CPUs. The remote CPU will do the SKB allocation
and start the network stack invocati
On Wed, Oct 04, 2017 at 01:52:20PM +0900, Toshiaki Makita wrote:
> On 2017/10/04 1:42, Ido Schimmel wrote:
> > The driver can make sure it's able to handle the configured
> > `vlan_filtering` state during port enslavement to the bridge and also
> > forbid it from being toggled once it's enslaved.
>
> Does DSA work for systems that do not use a device tree to boot, i.e. ACPI?
ACPI is not supported. So far, nobody has built a board using ACPI and
Ethernet switches supported by DSA.
Andrew
From: Colin Ian King
The functions t4vf_link_down_rc_str and t4vf_handle_get_port_info are
local to the source and do not need to be in global scope, so make
them static.
Cleans up sparse warnings:
symbol 't4vf_link_down_rc_str' was not declared. Should it be static?
symbol 't4vf_handle_get_port
On Tue, Oct 03, 2017 at 09:58:54PM -0700, David Ahern wrote:
> mlxsw fails device enslavement for a number of reasons. Use the extack
> facility to return an error message to the user stating why the enslave
> is failing.
>
> Messages are prefixed with "spectrum" so users know it is a constraint
>
On Wed, Oct 04, 2017 at 07:56:53AM +0200, Jörg Willmann wrote:
> Hi,
>
> we use a QorIQ P1011 connected via SGMII to a switch (Marvell 88E6352).
> Currently we still use a really old linux kernel (2.6.33) successfully.
>
> For configuration of the MDIO Bus attached to the corresponding eTSEC/TBI
The sysfs enabled value is a boolean, so kstrtobool() is a better fit
for parsing the input string since it does the range checking for us.
Signed-off-by: Andy Shevchenko
---
drivers/s390/net/qeth_l2_sys.c | 13 +
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/drivers/
no users in the tree.
Signed-off-by: Florian Westphal
---
include/net/rtnetlink.h | 3 ---
net/core/rtnetlink.c| 6 --
2 files changed, 9 deletions(-)
diff --git a/include/net/rtnetlink.h b/include/net/rtnetlink.h
index 21837ca68ecc..6520993ff449 100644
--- a/include/net/rtnetlink.h
+++
Wed, Oct 04, 2017 at 03:55:29PM CEST, f...@strlen.de wrote:
>no users in the tree.
>
>Signed-off-by: Florian Westphal
Acked-by: Jiri Pirko
On Tue, Oct 3, 2017 at 10:03 AM, Jesper Dangaard Brouer
wrote:
>
>
> First of all, thank you Craig for working on this. As Alexei says, we
> need to improve tools/lib/bpf/libbpf and move towards converting users
> of bpf_load.c to this lib instead.
>
> Comments inlined below.
>
>> +
switch the only caller to rtnl_af_unregister.
Signed-off-by: Florian Westphal
---
include/net/rtnetlink.h | 2 --
net/core/rtnetlink.c| 14 +-
net/ipv6/addrconf.c | 4 ++--
3 files changed, 3 insertions(+), 17 deletions(-)
diff --git a/include/net/rtnetlink.h b/include/net
On Tue, Oct 3, 2017 at 10:11 AM, Jesper Dangaard Brouer
wrote:
> On Mon, 2 Oct 2017 12:41:28 -0400
> Craig Gallek wrote:
>
>> diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c
>> index 4f402dcdf372..28b300868ad7 100644
>> --- a/tools/lib/bpf/libbpf.c
>> +++ b/tools/lib/bpf/libbpf.c
>>
On Tue, Oct 3, 2017 at 10:11 AM, Jesper Dangaard Brouer
wrote:
> On Mon, 2 Oct 2017 12:41:28 -0400
> Craig Gallek wrote:
>
>> diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c
>> index 4f402dcdf372..28b300868ad7 100644
>> --- a/tools/lib/bpf/libbpf.c
>> +++ b/tools/lib/bpf/libbpf.c
>>
On Tue, Oct 3, 2017 at 10:39 AM, Daniel Borkmann wrote:
> On 10/03/2017 01:07 AM, Alexei Starovoitov wrote:
>>
>> On 10/2/17 9:41 AM, Craig Gallek wrote:
>>>
>>> +/* Assume equally sized map definitions */
>>> +map_def_sz = data->d_size / nr_maps;
>>> +if (!data->d_size || (data->d_siz
From: Craig Gallek
> Sent: 04 October 2017 14:58
> >> + obj->maps[map_idx].def = *def;
> >
> > I'm not too happy/comfortable with this way of copying the memory of
> > "def" (the type-cased struct bpf_map_def). I guess it works, and is
> > part of the C-standard(?).
>
> I beli
On Wed, 2017-10-04 at 13:52 +0200, Florian Westphal wrote:
> to make sure this is serialized correctly.
>
> Signed-off-by: Florian Westphal
> ---
> tools/testing/selftests/net/rtnetlink.sh | 8
> 1 file changed, 8 insertions(+)
>
> diff --git a/tools/testing/selftests/net/rtnetlink.sh
On Wed, 4 Oct 2017, Andrew Lunn wrote:
On Wed, Oct 04, 2017 at 07:56:53AM +0200, Jörg Willmann wrote:
Hi,
we use a QorIQ P1011 connected via SGMII to a switch (Marvell 88E6352).
Currently we still use a really old linux kernel (2.6.33) successfully.
For configuration of the MDIO Bus attached
to make sure this is serialized correctly.
Signed-off-by: Florian Westphal
---
change since v1:
Eric points out 'wait' blocks for all current children, so no need
for another loop.
tools/testing/selftests/net/rtnetlink.sh | 6 ++
1 file changed, 6 insertions(+)
diff --git a/tools/testin
On Tue, Oct 03, 2017 at 11:26:53AM -0700, Stephen Hemminger wrote:
> On Tue, 3 Oct 2017 13:57:42 -0400
> Stefan Hajnoczi wrote:
>
> > Linux has more than 32 address families defined in . Use
> > a 64-bit type so all of them can be represented in the filter->families
> > bitmask.
> >
> > It's e
From: Stefan Hajnoczi
> Sent: 04 October 2017 16:01
...
> > > --- a/misc/ss.c
> > > +++ b/misc/ss.c
> > > @@ -170,55 +170,57 @@ enum {
> > > struct filter {
> > > int dbs;
> > > int states;
> > > - int families;
> > > + __u64 families;
> >
> > Since this isn't a value that is coming from kerne
On Tue, Oct 03, 2017 at 11:24:55AM -0700, Stephen Hemminger wrote:
> On Tue, 3 Oct 2017 13:57:43 -0400
> Stefan Hajnoczi wrote:
>
> > This new Linux header file defines the sock_diag interface used by
> > AF_VSOCK.
> >
> > Signed-off-by: Stefan Hajnoczi
> > ---
> > include/linux/vm_sockets_di
On Tue, Oct 03, 2017 at 09:46:52PM -0700, David Miller wrote:
> From: Stefan Hajnoczi
> Date: Tue, 3 Oct 2017 11:39:42 -0400
>
> > +static int sk_diag_fill(struct sock *sk, struct sk_buff *skb,
> > + u32 portid, u32 seq, u32 flags)
> > +{
> > + struct nlmsghdr *nlh;
> > + s
On Tue, Oct 03, 2017 at 09:48:05PM -0700, David Miller wrote:
> From: Stefan Hajnoczi
> Date: Tue, 3 Oct 2017 11:39:43 -0400
>
> > MAINTAINERS | 1 +
> > tools/vsock/Makefile | 9 +
> > tools/vsock/control.h | 13 +
> > tools/vsock/timeout.h | 14
On Tue, Oct 03, 2017 at 09:46:17PM -0700, David Miller wrote:
> From: Stefan Hajnoczi
> Date: Tue, 3 Oct 2017 11:39:40 -0400
>
> > @@ -250,15 +250,17 @@ static struct sock
> > *__vsock_find_connected_socket(struct sockaddr_vm *src,
> > return NULL;
> > }
> >
> > -static bool __vsock_in_b
First of all thank you for working on this.
On Tue, 3 Oct 2017 13:07:04 +0530 cjacob wrote:
> Usage: ./xdp3 [-S]
>
> -S to choose generic xdp implementation
> [Default is driver xdp implementation]
> ifindex - the index of the interface to which
> the xdp p
On Tue, 3 Oct 2017 21:58:53 -0700
David Ahern wrote:
> Pass extack arg to br_add_if. Add messages for a couple of failures
> and pass arg to netdev_master_upper_dev_link.
>
> Signed-off-by: David Ahern
This looks good. You might want to pass the netlink_ext_ack down as
an immutable pointer (c
On Wed, 4 Oct 2017 15:03:09 +
David Laight wrote:
> From: Stefan Hajnoczi
> > Sent: 04 October 2017 16:01
> ...
> > > > --- a/misc/ss.c
> > > > +++ b/misc/ss.c
> > > > @@ -170,55 +170,57 @@ enum {
> > > > struct filter {
> > > > int dbs;
> > > > int states;
> > > > -
On Wed, Oct 4, 2017 at 5:56 AM, Anders K. Pedersen | Cohaesio
wrote:
> Hello,
>
> After updating one of our Linux based routers to kernel 4.13 it began
> leaking memory quite fast (about 1 GB every half hour). To narrow we
> tried various kernel versions and found that 4.11.12 is okay, while
> 4.1
On Wed, Oct 04, 2017 at 04:19:23PM +0200, Jörg Willmann wrote:
> On Wed, 4 Oct 2017, Andrew Lunn wrote:
>
> >On Wed, Oct 04, 2017 at 07:56:53AM +0200, Jörg Willmann wrote:
> >>Hi,
> >>
> >>we use a QorIQ P1011 connected via SGMII to a switch (Marvell 88E6352).
> >>Currently we still use a really o
On 10/3/17 11:38 PM, Jiri Pirko wrote:
> Wed, Oct 04, 2017 at 06:58:52AM CEST, dsah...@gmail.com wrote:
>> A number of bond_enslave errors are logged using the netdev_err API.
>> Return those messages to userspace via the extack facility.
>>
>> Signed-off-by: David Ahern
>> ---
>> drivers/net/bond
We currently only have BPF tools in the tools/net directory.
We are about to add more BPF tools there, not necessarily
networking related, rename the directory and related Makefile
targets to bpf.
Suggested-by: Daniel Borkmann
Signed-off-by: Jakub Kicinski
Reviewed-by: Simon Horman
Acked-by: Da
Add a simple tool for querying and updating BPF objects on the system.
Signed-off-by: Jakub Kicinski
Reviewed-by: Simon Horman
Acked-by: Daniel Borkmann
Acked-by: Alexei Starovoitov
---
tools/bpf/Makefile | 18 +-
tools/bpf/bpftool/Makefile | 80 +
tools/bpf/bpftool/comm
Add documentation for bpftool. Separate files for each subcommand.
Use rst format. Documentation is compiled into man pages using
rst2man.
Signed-off-by: David Beckett
Signed-off-by: Jakub Kicinski
Acked-by: Alexei Starovoitov
Acked-by: Daniel Borkmann
---
tools/bpf/bpftool/Documentation/Ma
Hi!
This set adds bpftool to the tools/ directory. The first
patch renames tools/net to tools/bpf, the second one adds
the new code, while the third adds simple documentation.
I was holding off reposting in case the verifier instruction
printing/lock removal patches would turn out to be an eas
Florian
On 10/03/2017 01:31 PM, Florian Fainelli wrote:
> On 10/03/2017 11:03 AM, Dan Murphy wrote:
>> Florian
>>
>> Thanks for the review
>>
>> On 10/03/2017 12:15 PM, Florian Fainelli wrote:
+ } else {
+ value &= ~DP83822_WOL_SECURE_ON;
+ }
On 10/4/17 6:24 AM, Ido Schimmel wrote:
> On Tue, Oct 03, 2017 at 09:58:54PM -0700, David Ahern wrote:
>> mlxsw fails device enslavement for a number of reasons. Use the extack
>> facility to return an error message to the user stating why the enslave
>> is failing.
>>
>> Messages are prefixed with
From: Alexander Duyck
It looks like we weren't correctly placing the pages from buffers that had
been used to return a filter programming status back on the ring. As a
result they were being overwritten and tracking of the pages was lost.
This change works to correct that by incorporating part o
On Wed, Oct 4, 2017 at 1:15 AM, Jiri Pirko wrote:
> Wed, Oct 04, 2017 at 10:08:57AM CEST, simon.hor...@netronome.com wrote:
>>On Tue, Oct 03, 2017 at 11:17:46AM -0700, Tom Herbert wrote:
>>> On Tue, Oct 3, 2017 at 2:40 AM, Simon Horman
>>> wrote:
>>> > On Mon, Oct 02, 2017 at 01:37:55PM -0700, T
Macros should always be wrapped in braces, so fix this instance.
Signed-off-by: Christoph Böhmwalder
---
drivers/net/wireless/intel/iwlwifi/iwl-io.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-io.c
b/drivers/net/wireless/intel/iwlwi
Change a usage of int in a boolean context to use the bool type instead, as it
makes the intent of the function clearer and helps clarify its semantics.
Also eliminate the if/else and just return the boolean result directly,
making the code more readable.
Signed-off-by: Christoph Böhmwalder
---
This fixes a bug that can occur if an AER error is encountered while SRIOV
devices are present.
This issue was seen by doing the following. Inject an AER error to a device
that has SRIOV devices. After the device has recovered, remove the driver.
Reload the driver and enable SRIOV which causes th
Separate the function from the previous definition with a newline and
put the `static` keyword on the same line, as it just looks nicer.
Signed-off-by: Christoph Böhmwalder
---
drivers/net/wireless/intel/iwlwifi/iwl-phy-db.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a
Fix several code style issues, some of which were reported by checkpatch.pl.
The changes are:
* One instance of an `int` variable being used in a boolean context, chaned to
use the more appropriate `bool` type.
* One very minor fix, removing a newline between a function definition and its
asso
On Wed, Oct 4, 2017 at 12:21 AM, Toshiaki Makita
wrote:
> On 2017/10/04 14:12, Roopa Prabhu wrote:
>> From: Roopa Prabhu
>>
>> This patch adds a new bridge port flag BR_NEIGH_SUPPRESS to
>> suppress arp and nd flood on bridge ports. It implements
>> rfc7432, section 10.
>> https://tools.ietf.org/
Please don't send obviously broken patches.
johannes
On Wed, 2017-10-04 at 17:57 +0200, Christoph Böhmwalder wrote:
> Macros should always be wrapped in braces, so fix this instance.
>
> Signed-off-by: Christoph Böhmwalder
> ---
> drivers/net/wireless/intel/iwlwifi/iwl-io.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/
On Wed, 2017-10-04 at 17:56 +0200, Christoph Böhmwalder wrote:
> Separate the function from the previous definition with a newline and
> put the `static` keyword on the same line, as it just looks nicer.
>
> Signed-off-by: Christoph Böhmwalder
> ---
> drivers/net/wireless/intel/iwlwifi/iwl-phy-d
On Wed, 2017-10-04 at 17:56 +0200, Christoph Böhmwalder wrote:
> Change a usage of int in a boolean context to use the bool type
> instead, as it
> makes the intent of the function clearer and helps clarify its
> semantics.
>
> Also eliminate the if/else and just return the boolean result
> direct
On 10/4/17 8:13 AM, Stephen Hemminger wrote:
> On Tue, 3 Oct 2017 21:58:53 -0700
> David Ahern wrote:
>
>> Pass extack arg to br_add_if. Add messages for a couple of failures
>> and pass arg to netdev_master_upper_dev_link.
>>
>> Signed-off-by: David Ahern
>
> This looks good. You might want t
On Wed, 2017-10-04 at 17:56 +0200, Christoph Böhmwalder wrote:
> Fix several code style issues, some of which were reported by
> checkpatch.pl.
>
> The changes are:
> * One instance of an `int` variable being used in a boolean context,
> chaned to
> use the more appropriate `bool` type.
> * One
On Wed, Oct 04, 2017 at 01:18:24PM +0200, Jason A. Donenfeld wrote:
> Hey Michael,
>
> Thanks for your work on ptr_ring.h. I'm interested in using it, but in
> a multi-producer, multi-consumer context. I realize it's been designed
> for a single-producer, single-consumer context, and thus uses a
>
Florian
On 10/04/2017 11:18 AM, Florian Fainelli wrote:
> On 10/04/2017 08:41 AM, Dan Murphy wrote:
>> Florian
>>
>> On 10/03/2017 01:31 PM, Florian Fainelli wrote:
>>> On 10/03/2017 11:03 AM, Dan Murphy wrote:
Florian
Thanks for the review
On 10/03/2017 12:15 PM, Florian
On 10/04/2017 08:41 AM, Dan Murphy wrote:
> Florian
>
> On 10/03/2017 01:31 PM, Florian Fainelli wrote:
>> On 10/03/2017 11:03 AM, Dan Murphy wrote:
>>> Florian
>>>
>>> Thanks for the review
>>>
>>> On 10/03/2017 12:15 PM, Florian Fainelli wrote:
> + } else {
> + va
On Wed, 2017-10-04 at 17:56 +0200, Christoph Böhmwalder wrote:
> Change a usage of int in a boolean context to use the bool type instead, as it
> makes the intent of the function clearer and helps clarify its semantics.
>
> Also eliminate the if/else and just return the boolean result directly,
>
v2:
* Moved tests to tools/testing/vsock/. I was unable to put them in selftests/
because they require manual setup of a VMware/KVM guest.
* Moved to __vsock_in_bound/connected_table() to af_vsock.h
* Fixed local variable ordering in Patch 4
There is currently no way for userspace to query
The socket table symbols need to be exported from vsock.ko so that the
vsock_diag.ko module will be able to traverse sockets.
Signed-off-by: Stefan Hajnoczi
---
include/net/af_vsock.h | 5 +
net/vmw_vsock/af_vsock.c | 10 ++
2 files changed, 11 insertions(+), 4 deletions(-)
diff
This patch adds the sock_diag interface for querying sockets from
userspace. Tools like ss(8) and netstat(8) can use this interface to
list open sockets.
The userspace ABI is defined in and includes
netlink request and response structs. The request can query sockets
based on their sk_state (e.g
The vsock_diag.ko module will need to check socket table membership.
Signed-off-by: Stefan Hajnoczi
---
include/net/af_vsock.h | 12
net/vmw_vsock/af_vsock.c | 10 --
2 files changed, 12 insertions(+), 10 deletions(-)
diff --git a/include/net/af_vsock.h b/include/net/af_v
There are two state fields: socket->state and sock->sk_state. The
socket->state field uses SS_UNCONNECTED, SS_CONNECTED, etc while the
sock->sk_state typically uses values that match TCP state constants
(TCP_CLOSE, TCP_ESTABLISHED). AF_VSOCK does not follow this convention
and instead uses SS_* c
This patch adds tests for the vsock_diag.ko module.
These tests are not self-tests because they require manual set up of a
KVM or VMware guest. Please see tools/testing/vsock/README for
instructions.
The control.h and timeout.h infrastructure can be used for additional
AF_VSOCK tests in the futu
On Wed, 2017-10-04 at 09:26 -0700, Joe Perches wrote:
> On Wed, 2017-10-04 at 17:56 +0200, Christoph Böhmwalder wrote:
> > Change a usage of int in a boolean context to use the bool type
> > instead, as it
> > makes the intent of the function clearer and helps clarify its
> > semantics.
> >
> > Al
Am 04.10.2017 um 17:34 schrieb Andrew Lunn:
On Wed, Oct 04, 2017 at 04:19:23PM +0200, Jörg Willmann wrote:
On Wed, 4 Oct 2017, Andrew Lunn wrote:
On Wed, Oct 04, 2017 at 07:56:53AM +0200, Jörg Willmann wrote:
Hi,
we use a QorIQ P1011 connected via SGMII to a switch (Marvell 88E6352).
Current
On 09/29/2017 06:11 AM, Tom Herbert wrote:
> @@ -122,6 +125,30 @@ int gre_parse_header(struct sk_buff *skb, struct
tnl_ptk_info *tpi,
> }
> EXPORT_SYMBOL(gre_parse_header);
>
> +#if IS_ENABLED(CONFIG_MPLS)
> +int mpls_gre_rcv(struct sk_buff *skb, int gre_hdr_len)
> +{
> + if (unlikely(
From: Wei Wang
Currently in the TCP code, the initialization sequence for cached
metrics, congestion control, BPF, etc, after successful connection
is very inconsistent. This introduces inconsistent bevhavior and is
prone to bugs. The current call sequence is as follows:
(1) for active case (tcp
From: Wei Wang
This commit does a cleanup and moves tcp_rearm_rto() call in the TFO
server case into a previous spot in tcp_rcv_state_process() to make
it more compact.
This is only a cosmetic change.
Suggested-by: Yuchung Cheng
Signed-off-by: Wei Wang
Acked-by: Neal Cardwell
Acked-by: Yuchun
From: Simon Horman
Date: Wed, 4 Oct 2017 09:54:27 +0200
> Add support for RX checksum offload. This is enabled by default and
> may be disabled and re-enabled using ethtool:
>
> # ethtool -K eth0 rx off
> # ethtool -K eth0 rx on
>
> The RAVB provides a simple checksumming scheme which appear
From: Florian Westphal
Date: Wed, 4 Oct 2017 13:56:50 +0200
> net/core/dev.c:1306: warning: No description found for parameter 'name'
> net/core/dev.c:1306: warning: Excess function parameter 'alias' description
> in 'dev_get_alias'
>
> Fixes: 6c5570016b97 ("net: core: decouple ifalias get/set
From: Colin King
Date: Wed, 4 Oct 2017 14:20:37 +0100
> From: Colin Ian King
>
> The functions t4vf_link_down_rc_str and t4vf_handle_get_port_info are
> local to the source and do not need to be in global scope, so make
> them static.
>
> Cleans up sparse warnings:
> symbol 't4vf_link_down_rc
From: Florian Westphal
Date: Wed, 4 Oct 2017 15:55:29 +0200
> no users in the tree.
>
> Signed-off-by: Florian Westphal
Applied.
From: Florian Westphal
Date: Wed, 4 Oct 2017 15:58:49 +0200
> switch the only caller to rtnl_af_unregister.
>
> Signed-off-by: Florian Westphal
Applied.
From: Florian Westphal
Date: Wed, 4 Oct 2017 16:22:59 +0200
> to make sure this is serialized correctly.
>
> Signed-off-by: Florian Westphal
> ---
> change since v1:
> Eric points out 'wait' blocks for all current children, so no need
> for another loop.
Applied.
This patch introduces the MPLS over GRE encapsulation (RFC 4023).
Various applications of MPLS make use of label stacks with multiple
entries. In some cases, it is possible to replace the top label of
the stack with an IP-based encapsulation, thereby, it is possible for
two LSRs that are adjacent
1 - 100 of 267 matches
Mail list logo
