Re: iproute2 4.14.1 tc class add come to kernel-panic

2018-01-30 Thread Roland Franke
Hello, On Tue, Jan 30, 2018 at 9:46 AM, Roland Franke wrote: Hello, Well, not min_qdisc things, but it should be resolved by: commit efbf78973978b0d25af59bc26c8013a942af6e64 Author: Cong Wang Date: Mon Dec 4 10:48:18 2017 -0800

Re: [Intel-wired-lan] [RFC PATCH] e1000e: Remove Other from EIAC.

2018-01-30 Thread Benjamin Poirier
On 2018/01/30 11:46, Alexander Duyck wrote: > On Wed, Jan 17, 2018 at 10:50 PM, Benjamin Poirier wrote: > > It was reported that emulated e1000e devices in vmware esxi 6.5 Build > > 7526125 do not link up after commit 4aea7a5c5e94 ("e1000e: Avoid receiver > > overrun interrupt

Re: WARNING in refcount_inc (2)

2018-01-30 Thread Eric Biggers
On Tue, Dec 19, 2017 at 11:26:01AM -0800, syzbot wrote: > syzkaller has found reproducer for the following crash on > 6084b576dca2e898f5c101baef151f7bfdbb606d > git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw

[PATCH net] e1000e: Remove Other from EIAC.

2018-01-30 Thread Benjamin Poirier
It was reported that emulated e1000e devices in vmware esxi 6.5 Build 7526125 do not link up after commit 4aea7a5c5e94 ("e1000e: Avoid receiver overrun interrupt bursts", v4.15-rc1). Some tracing shows that after e1000e_trigger_lsc() is called, ICR reads out as 0x0 in e1000_msix_other() on

Re: BUG: unable to handle kernel NULL pointer dereference in sctp_stream_free

2018-01-30 Thread Marcelo Ricardo Leitner
On Tue, Jan 30, 2018 at 03:03:50PM -0800, Eric Biggers wrote: > On Fri, Dec 22, 2017 at 01:31:26PM +0800, Xin Long wrote: > > On Thu, Dec 21, 2017 at 9:13 PM, Marcelo Ricardo Leitner > > wrote: > > > On Wed, Dec 20, 2017 at 12:51:01PM -0800, syzbot wrote: > > > > > >

Re: [PATCH bpf] bpf: fix null pointer deref in bpf_prog_test_run_xdp

2018-01-30 Thread Jesper Dangaard Brouer
On Wed, 31 Jan 2018 01:31:11 +0100 Daniel Borkmann wrote: > syzkaller was able to generate the following XDP program ... > > (18) r0 = 0x0 > (61) r5 = *(u32 *)(r1 +12) > (04) (u32) r0 += (u32) 0 > (95) exit > > ... and trigger a NULL pointer dereference in

Re: sctp netns "unregister_netdevice: waiting for lo to become free. Usage count = 1"

2018-01-30 Thread Tommi Rantala
On 31.01.2018 00:52, Marcelo Ricardo Leitner wrote: On Mon, Jan 29, 2018 at 05:55:45PM +0200, Tommi Rantala wrote: Hi, When running sctp_test from lksctp-tools in netns in 4.4 and 4.9 with suitable arguments, the local loopback device in the netns is not getting destroyed after deleting the

Re: KASAN: use-after-free Read in map_lookup_elem

2018-01-30 Thread Eric Biggers
On Fri, Jan 12, 2018 at 02:58:02PM -0800, syzbot wrote: > Hello, > > syzkaller hit the following crash on > 4147d50978df60f34d444c647dde9e5b34a4315e > git://git.cmpxchg.org/linux-mmots.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console output is attached. > C

Re: iproute2 4.14.1 tc class add come to kernel-panic

2018-01-30 Thread Cong Wang
On Tue, Jan 30, 2018 at 9:46 AM, Roland Franke wrote: > Hello, > >> Well, not min_qdisc things, but it should be resolved by: > > >> commit efbf78973978b0d25af59bc26c8013a942af6e64 >> Author: Cong Wang >> Date: Mon Dec 4 10:48:18 2017 -0800 > >

Re: [PATCH] tls: Add support for encryption using async offload accelerator

2018-01-30 Thread Gilad Ben-Yossef
On Wed, Jan 31, 2018 at 8:10 AM, Gilad Ben-Yossef wrote: > Hi Vakul, > > On Wed, Jan 31, 2018 at 12:36 PM, Vakul Garg wrote: >> Async crypto accelerators (e.g. drivers/crypto/caam) support offloading >> GCM operation. If they are enabled,

Re: KASAN: use-after-free Read in refcount_inc_not_zero

2018-01-30 Thread Eric Biggers
On Thu, Dec 14, 2017 at 10:23:01AM -0800, syzbot wrote: > syzkaller has found reproducer for the following crash on > 82bcf1def3b5f1251177ad47c44f7e17af039b4b > git://git.cmpxchg.org/linux-mmots.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console output is attached.

Re: [PATCH] tls: Add support for encryption using async offload accelerator

2018-01-30 Thread Gilad Ben-Yossef
Hi Vakul, On Wed, Jan 31, 2018 at 12:36 PM, Vakul Garg wrote: > Async crypto accelerators (e.g. drivers/crypto/caam) support offloading > GCM operation. If they are enabled, crypto_aead_encrypt() return error > code -EINPROGRESS. In this case tls_do_encryption() needs to wait

[PATCH] libceph: use 64-bit arithmetic instead of 32-bit

2018-01-30 Thread Gustavo A. R. Silva
Cast objsetno to u64 in order to give the compiler complete information about the proper arithmetic to use. Notice that this variable is used in a context that expects an expression of type u64 (64 bits, unsigned). The expression objsetno * sc + stripepos is currently being evaluated using 32-bit

[PATCH] openvswitch: meter: Use 64-bit arithmetic instead of 32-bit

2018-01-30 Thread Gustavo A. R. Silva
Add suffix LL to constant 1000 in order to give the compiler complete information about the proper arithmetic to use. Notice that this constant is used in a context that expects an expression of type long long int (64 bits, signed). The expression (band->burst_size + band->rate) * 1000 is

[PATCH] tls: Add support for encryption using async offload accelerator

2018-01-30 Thread Vakul Garg
Async crypto accelerators (e.g. drivers/crypto/caam) support offloading GCM operation. If they are enabled, crypto_aead_encrypt() return error code -EINPROGRESS. In this case tls_do_encryption() needs to wait on a completion till the time the response for crypto offload request is received.

[PATCH] tcp_nv: fix potential integer overflow in tcpnv_acked

2018-01-30 Thread Gustavo A. R. Silva
Add suffix ULL to constant 8 in order to avoid a potential integer overflow and give the compiler complete information about the proper arithmetic to use. Notice that this constant is used in a context that expects an expression of type u64. The current cast to u64 effectively applies to the

Re: BUG: spinlock bad magic (2)

2018-01-30 Thread santosh.shilim...@oracle.com
On 1/30/18 2:28 PM, Eric Biggers wrote: On Mon, Dec 18, 2017 at 06:01:30PM +0100, 'Dmitry Vyukov' via syzkaller-bugs wrote: On Mon, Dec 18, 2017 at 5:46 PM, Santosh Shilimkar wrote: On 12/18/2017 4:36 AM, syzbot wrote: Hello, syzkaller hit the following

[PATCH v4 2/2] bnx2x: disable GSO where gso_size is too big for hardware

2018-01-30 Thread Daniel Axtens
If a bnx2x card is passed a GSO packet with a gso_size larger than ~9700 bytes, it will cause a firmware error that will bring the card down: bnx2x: [bnx2x_attn_int_deasserted3:4323(enP24p1s0f0)]MC assert! bnx2x: [bnx2x_mc_assert:720(enP24p1s0f0)]XSTORM_ASSERT_LIST_INDEX 0x2 bnx2x:

[PATCH v4 0/2] bnx2x: disable GSO on too-large packets

2018-01-30 Thread Daniel Axtens
We observed a case where a packet received on an ibmveth device had a GSO size of around 10kB. This was forwarded by Open vSwitch to a bnx2x device, where it caused a firmware assert. This is described in detail at [0]. Ultimately we want a fix in the core, but that is very tricky to backport. So

[PATCH v4 1/2] net: create skb_gso_validate_mac_len()

2018-01-30 Thread Daniel Axtens
If you take a GSO skb, and split it into packets, will the MAC length (L2 + L3 + L4 headers + payload) of those packets be small enough to fit within a given length? Move skb_gso_mac_seglen() to skbuff.h with other related functions like skb_gso_network_seglen() so we can use it, and then create

Re: KASAN: stack-out-of-bounds Read in rds_sendmsg

2018-01-30 Thread Santosh Shilimkar
On 1/30/2018 6:16 PM, Eric Biggers wrote: On Thu, Dec 21, 2017 at 08:44:32AM -0800, Santosh Shilimkar wrote: +Avinash On 12/21/2017 1:10 AM, syzbot wrote: syzkaller has found reproducer for the following crash on [..] audit: type=1400 audit(1513847224.110:7): avc:  denied  { map } for

Re: KASAN: stack-out-of-bounds Read in rds_sendmsg

2018-01-30 Thread Eric Biggers
On Thu, Dec 21, 2017 at 08:44:32AM -0800, Santosh Shilimkar wrote: > +Avinash > > On 12/21/2017 1:10 AM, syzbot wrote: > > syzkaller has found reproducer for the following crash on > > [..] > > > > > audit: type=1400 audit(1513847224.110:7): avc:  denied  { map } for > > pid=3157

Re: KASAN: use-after-free Read in sctp_association_free

2018-01-30 Thread Eric Biggers
On Thu, Nov 02, 2017 at 08:07:27PM +0800, Xin Long wrote: > On Thu, Nov 2, 2017 at 1:55 AM, syzbot > > wrote: > > Hello, > > > > syzkaller hit the following crash on > > 25a5d23b47994cdb451dcd2bc8ac310a1492f71b > >

Re: KASAN: use-after-free Read in __xfrm_state_lookup

2018-01-30 Thread Eric Biggers
On Wed, Nov 01, 2017 at 10:55:01AM -0700, syzbot wrote: > Hello, > > syzkaller hit the following crash on > 33ad61d0f799656e8987e9c80e6e15151bb857f3 > git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console

Re: KASAN: slab-out-of-bounds Read in xfrm_hash_rebuild

2018-01-30 Thread Eric Biggers
On Thu, Dec 21, 2017 at 05:48:01AM -0800, syzbot wrote: > syzkaller has found reproducer for the following crash on > 8f36e00065436412a02d1f50ad77375bdb506300 > git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw

Re: [PATCH ipsec] xfrm: skip policies marked as dead while rehashing

2018-01-30 Thread syzbot
On Sun, Dec 31, 2017 at 08:50:17AM +0100, Steffen Klassert wrote: On Wed, Dec 27, 2017 at 11:25:45PM +0100, Florian Westphal wrote: > syzkaller triggered following KASAN splat: > > BUG: KASAN: slab-out-of-bounds in xfrm_hash_rebuild+0xdbe/0xf00 net/xfrm/xfrm_policy.c:618 > read of size 2 at

Re: [PATCH ipsec] xfrm: skip policies marked as dead while rehashing

2018-01-30 Thread Eric Biggers
On Sun, Dec 31, 2017 at 08:50:17AM +0100, Steffen Klassert wrote: > On Wed, Dec 27, 2017 at 11:25:45PM +0100, Florian Westphal wrote: > > syzkaller triggered following KASAN splat: > > > > BUG: KASAN: slab-out-of-bounds in xfrm_hash_rebuild+0xdbe/0xf00 > > net/xfrm/xfrm_policy.c:618 > > read of

Re: KASAN: use-after-free Read in __bpf_prog_put

2018-01-30 Thread Eric Biggers
On Thu, Jan 11, 2018 at 11:48:28AM +0100, Daniel Borkmann wrote: > Hi Dmitry, > > On 01/11/2018 11:22 AM, Dmitry Vyukov wrote: > > On Thu, Jan 11, 2018 at 11:17 AM, syzbot > > wrote: > >> Hello, > >> > >> syzkaller hit the following crash on

Re: general protection fault in fib6_add (2)

2018-01-30 Thread Wei Wang
On Tue, Jan 30, 2018 at 5:16 PM, Eric Biggers wrote: > On Wed, Jan 03, 2018 at 10:53:02AM -0800, 'Wei Wang' via syzkaller-bugs wrote: >> On Wed, Jan 3, 2018 at 8:16 AM, David Ahern wrote: >> > [ +wei...@google.com ] >> > >> > On 1/2/18 3:58 PM, syzbot

Re: BUG: unable to handle kernel paging request in check_memory_region

2018-01-30 Thread Eric Biggers
On Sun, Jan 14, 2018 at 01:22:13AM +0100, Daniel Borkmann wrote: > On 01/13/2018 08:29 AM, Dmitry Vyukov wrote: > > On Fri, Jan 12, 2018 at 11:58 PM, syzbot > > wrote: > >> Hello, > >> > >> syzkaller hit the following crash on > >>

Re: general protection fault in fib6_add (2)

2018-01-30 Thread Eric Biggers
On Wed, Jan 03, 2018 at 10:53:02AM -0800, 'Wei Wang' via syzkaller-bugs wrote: > On Wed, Jan 3, 2018 at 8:16 AM, David Ahern wrote: > > [ +wei...@google.com ] > > > > On 1/2/18 3:58 PM, syzbot wrote: > >> Hello, > >> > >> syzkaller hit the following crash on > >>

Re: suspicious RCU usage at ./include/linux/inetdevice.h:LINE

2018-01-30 Thread Eric Biggers
On Thu, Nov 02, 2017 at 03:53:38AM -0700, syzbot wrote: > Hello, > > syzkaller hit the following crash on > ce43f4fd6f103681c7485c2b1967179647e73555 > git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console

Re: general protection fault in ___bpf_prog_run

2018-01-30 Thread Daniel Borkmann
On 01/30/2018 09:58 PM, syzbot wrote: > Hello, > > syzbot hit the following crash on bpf-next commit > 868c36dcc949c26bc74fa4661b670d9acc6489e4 (Mon Jan 29 03:00:16 2018 +) > Merge tag 'wireless-drivers-next-for-davem-2018-01-26' of >

[PATCH bpf] bpf: fix null pointer deref in bpf_prog_test_run_xdp

2018-01-30 Thread Daniel Borkmann
syzkaller was able to generate the following XDP program ... (18) r0 = 0x0 (61) r5 = *(u32 *)(r1 +12) (04) (u32) r0 += (u32) 0 (95) exit ... and trigger a NULL pointer dereference in ___bpf_prog_run() via bpf_prog_test_run_xdp() where this was attempted to run. Reason is that recent

Re: WARNING: bad unlock balance in ipmr_mfc_seq_stop

2018-01-30 Thread Eric Biggers
On Fri, Dec 15, 2017 at 11:52:01PM -0800, syzbot wrote: > Hello, > > syzkaller hit the following crash on > a638349bf6c29433b938141f99225b160551ff48 > git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console

Re: WARNING: bad unlock balance detected!

2018-01-30 Thread Eric Biggers
On Thu, Dec 14, 2017 at 11:37:00PM -0800, syzbot wrote: > Hello, > > syzkaller hit the following crash on > 50c4c4e268a2d7a3e58ebb698ac74da0de40ae36 > git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console

Re: WARNING in _copy_to_user

2018-01-30 Thread Eric Biggers
On Fri, Dec 01, 2017 at 03:30:01AM -0800, syzbot wrote: > Hello, > > syzkaller hit the following crash on > df8ba95c572a187ed2aa7403e97a7a7f58c01f00 > git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console

RE: macvlan devices and vlan interaction

2018-01-30 Thread Keller, Jacob E
> -Original Message- > From: Alexander Duyck [mailto:alexander.du...@gmail.com] > Sent: Tuesday, January 30, 2018 2:39 PM > To: Keller, Jacob E > Cc: Shannon Nelson ; netdev@vger.kernel.org; > Duyck, Alexander H

Re: BUG: unable to handle kernel NULL pointer dereference in sctp_stream_free

2018-01-30 Thread Eric Biggers
On Fri, Dec 22, 2017 at 01:31:26PM +0800, Xin Long wrote: > On Thu, Dec 21, 2017 at 9:13 PM, Marcelo Ricardo Leitner > wrote: > > On Wed, Dec 20, 2017 at 12:51:01PM -0800, syzbot wrote: > > > > from the log: > > [ 89.451366] FAULT_INJECTION: forcing a failure.^M > > [

Re: general protection fault in sctp_stream_free

2018-01-30 Thread Eric Biggers
On Sun, Nov 05, 2017 at 01:35:02AM -0700, syzbot wrote: > Hello, > > syzkaller hit the following crash on > 2a171788ba7bb61995e98e8163204fc7880f63b2 > git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console

Re: net: hang in unregister_netdevice: waiting for lo to become free

2018-01-30 Thread David Ahern
On 1/30/18 1:57 PM, David Ahern wrote: > On 1/30/18 1:08 PM, Daniel Borkmann wrote: >> On 01/30/2018 07:32 PM, Cong Wang wrote: >>> On Tue, Jan 30, 2018 at 4:09 AM, Dmitry Vyukov wrote: Hello, The following program creates a hang in unregister_netdevice.

Re: WARNING in inet_sock_destruct

2018-01-30 Thread Eric Biggers
On Sun, Nov 05, 2017 at 01:05:01AM -0800, syzbot wrote: > Hello, > > syzkaller hit the following crash on > 7f9ad2ace17a3521a80831208d431170ef71591f > git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console

Re: sctp netns "unregister_netdevice: waiting for lo to become free. Usage count = 1"

2018-01-30 Thread Marcelo Ricardo Leitner
On Mon, Jan 29, 2018 at 05:55:45PM +0200, Tommi Rantala wrote: > Hi, > > When running sctp_test from lksctp-tools in netns in 4.4 and 4.9 with > suitable arguments, the local loopback device in the netns is not getting > destroyed after deleting the netns. > ... > > Based on a quick test, 4.14

Re: BUG: unable to handle kernel NULL pointer dereference in sctp_cmp_addr_exact

2018-01-30 Thread Marcelo Ricardo Leitner
On Tue, Jan 30, 2018 at 01:57:44PM -0800, Eric Biggers wrote: > On Tue, Dec 19, 2017 at 11:49:03PM -0800, syzbot wrote: > > Hello, > > > > syzkaller hit the following crash on > > 6084b576dca2e898f5c101baef151f7bfdbb606d > > git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/master

Re: macvlan devices and vlan interaction

2018-01-30 Thread Alexander Duyck
On Tue, Jan 30, 2018 at 2:20 PM, Keller, Jacob E wrote: >> -Original Message- >> From: Alexander Duyck [mailto:alexander.du...@gmail.com] >> Sent: Tuesday, January 30, 2018 12:49 PM >> To: Shannon Nelson >> Cc: Keller, Jacob E

Re: [rds-devel] BUG: unable to handle kernel NULL pointer dereference in rds_send_xmit

2018-01-30 Thread Sowmini Varadhan
On (01/30/18 14:22), Eric Biggers wrote: > > I assume you weren't able to reproduce this? This crash hasn't been > seen again, : > I am invalidating the bug for syzbot so it will report the same crash > signature > again if it occurs, but if you think there is a real bug feel free to keep >

Re: BUG: spinlock bad magic (2)

2018-01-30 Thread Eric Biggers
On Mon, Dec 18, 2017 at 06:01:30PM +0100, 'Dmitry Vyukov' via syzkaller-bugs wrote: > On Mon, Dec 18, 2017 at 5:46 PM, Santosh Shilimkar > wrote: > > On 12/18/2017 4:36 AM, syzbot wrote: > >> > >> Hello, > >> > >> syzkaller hit the following crash on > >>

Re: [rds-devel] BUG: unable to handle kernel NULL pointer dereference in rds_send_xmit

2018-01-30 Thread Eric Biggers
On Mon, Dec 18, 2017 at 12:22:51PM -0500, Sowmini Varadhan wrote: > > From: Santosh Shilimkar > > Date: Mon, 18 Dec 2017 08:28:05 -0800 > : > > > Looks like another one tripping on empty transport. Mostly below > > > should > > > address it but we will test it if

RE: macvlan devices and vlan interaction

2018-01-30 Thread Keller, Jacob E
> -Original Message- > From: Yuan, Linyu (NSB - CN/Shanghai) [mailto:linyu.y...@nokia-sbell.com] > Sent: Monday, January 29, 2018 5:53 PM > To: Keller, Jacob E ; netdev@vger.kernel.org > Cc: Duyck, Alexander H > Subject: RE: macvlan

RE: macvlan devices and vlan interaction

2018-01-30 Thread Keller, Jacob E
> -Original Message- > From: Alexander Duyck [mailto:alexander.du...@gmail.com] > Sent: Tuesday, January 30, 2018 12:49 PM > To: Shannon Nelson > Cc: Keller, Jacob E ; netdev@vger.kernel.org; Duyck, > Alexander H

Re: BUG: unable to handle kernel NULL pointer dereference in inet6_fill_ifinfo

2018-01-30 Thread Eric Biggers
On Mon, Dec 18, 2017 at 11:54:00PM -0800, syzbot wrote: > Hello, > > syzkaller hit the following crash on > 6084b576dca2e898f5c101baef151f7bfdbb606d > git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console

Re: BUG: unable to handle kernel NULL pointer dereference in snmp6_unregister_dev

2018-01-30 Thread Eric Biggers
On Tue, Dec 19, 2017 at 12:35:02AM -0800, syzbot wrote: > Hello, > > syzkaller hit the following crash on > 6084b576dca2e898f5c101baef151f7bfdbb606d > git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console

Re: BUG: unable to handle kernel NULL pointer dereference in ip_mc_up

2018-01-30 Thread Eric Biggers
On Tue, Dec 19, 2017 at 12:40:01AM -0800, syzbot wrote: > Hello, > > syzkaller hit the following crash on > 6084b576dca2e898f5c101baef151f7bfdbb606d > git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console

RE: macvlan devices and vlan interaction

2018-01-30 Thread Keller, Jacob E
> -Original Message- > From: Shannon Nelson [mailto:shannon.nel...@oracle.com] > Sent: Tuesday, January 30, 2018 12:30 PM > To: Keller, Jacob E ; netdev@vger.kernel.org > Cc: Duyck, Alexander H > Subject: Re: macvlan devices and vlan

Re: BUG: unable to handle kernel NULL pointer dereference in tc_fill_qdisc

2018-01-30 Thread Eric Biggers
On Tue, Dec 19, 2017 at 04:49:02AM -0800, syzbot wrote: > Hello, > > syzkaller hit the following crash on > 6084b576dca2e898f5c101baef151f7bfdbb606d > git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console

Re: BUG: unable to handle kernel NULL pointer dereference in qdisc_match_from_root

2018-01-30 Thread Eric Biggers
On Tue, Dec 19, 2017 at 05:43:00AM -0800, syzbot wrote: > Hello, > > syzkaller hit the following crash on > 6084b576dca2e898f5c101baef151f7bfdbb606d > git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console

Re: BUG: unable to handle kernel NULL pointer dereference in ipv6_get_lladdr

2018-01-30 Thread Eric Biggers
On Tue, Dec 19, 2017 at 08:38:01AM -0800, syzbot wrote: > Hello, > > syzkaller hit the following crash on > 6084b576dca2e898f5c101baef151f7bfdbb606d > git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console

Re: BUG: unable to handle kernel NULL pointer dereference in neigh_fill_info

2018-01-30 Thread Eric Biggers
On Tue, Dec 19, 2017 at 10:41:00AM -0800, syzbot wrote: > Hello, > > syzkaller hit the following crash on > 6084b576dca2e898f5c101baef151f7bfdbb606d > git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console

Re: BUG: unable to handle kernel NULL pointer dereference in addrconf_notify

2018-01-30 Thread Eric Biggers
On Tue, Dec 19, 2017 at 11:48:01AM -0800, syzbot wrote: > Hello, > > syzkaller hit the following crash on > 6084b576dca2e898f5c101baef151f7bfdbb606d > git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console

Re: BUG: unable to handle kernel NULL pointer dereference in sctp_cmp_addr_exact

2018-01-30 Thread Eric Biggers
On Tue, Dec 19, 2017 at 11:49:03PM -0800, syzbot wrote: > Hello, > > syzkaller hit the following crash on > 6084b576dca2e898f5c101baef151f7bfdbb606d > git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console

Re: BUG: unable to handle kernel NULL pointer dereference in addrconf_ifdown

2018-01-30 Thread Eric Biggers
On Tue, Dec 19, 2017 at 11:50:01PM -0800, syzbot wrote: > Hello, > > syzkaller hit the following crash on > 6084b576dca2e898f5c101baef151f7bfdbb606d > git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console

[git pull] reducing kernel_recvmsg() use

2018-01-30 Thread Al Viro
kernel_recvmsg() is a set_fs()-using wrapper for sock_recvmsg(). In all but one case that is not needed - use of ITER_KVEC for ->msg_iter takes care of the data and does not care about set_fs(). The only exception is svc_udp_recvfrom() where we want cmsg to be store into kernel object;

Re: [PATCH] vsock.7: document VSOCK socket address family

2018-01-30 Thread Michael Kerrisk (man-pages)
Hi Stefan, Ping on the below please, since it either blocks the man-pages release I'd currently like to make, or I must remove the vsock.7 page for this release. Thanks, Michael On 26 January 2018 at 22:47, Michael Kerrisk (man-pages) wrote: > Stefan, > > I've just

Re: general protection fault in ___bpf_prog_run

2018-01-30 Thread Daniel Borkmann
On 01/30/2018 09:58 PM, syzbot wrote: > Hello, > > syzbot hit the following crash on bpf-next commit > 868c36dcc949c26bc74fa4661b670d9acc6489e4 (Mon Jan 29 03:00:16 2018 +) > Merge tag 'wireless-drivers-next-for-davem-2018-01-26' of >

Re: KASAN: stack-out-of-bounds Read in xfrm_state_find (3)

2018-01-30 Thread Eric Biggers
On Wed, Dec 13, 2017 at 06:18:05AM +0100, Steffen Klassert wrote: > On Tue, Dec 12, 2017 at 01:00:31PM -0800, Eric Biggers wrote: > > Hi Steffen, > > > > On Fri, Dec 01, 2017 at 08:27:43AM +0100, Steffen Klassert wrote: > > > On Wed, Nov 22, 2017 at 08:05:00AM -0800, syzbot wrote: > > > >

Re: WARNING in xfrm_state_fini

2018-01-30 Thread Eric Biggers
On Mon, Nov 27, 2017 at 09:37:07AM -0800, Cong Wang wrote: > On Mon, Nov 27, 2017 at 3:55 AM, Steffen Klassert > wrote: > > On Tue, Nov 21, 2017 at 06:44:04PM -0800, Cong Wang wrote: > >> User-space uses proto==0 as a wildcard, but xfrm_id_proto_match() > >> doesn't

Re: general protection fault in __rds_rdma_map

2018-01-30 Thread Eric Biggers
On Mon, Nov 27, 2017 at 10:30:01AM -0800, syzbot wrote: > Hello, > > syzkaller hit the following crash on > e1d1ea549b57790a3d8cf6300e6ef86118d692a3 > git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console

Re: sctp netns "unregister_netdevice: waiting for lo to become free. Usage count = 1"

2018-01-30 Thread Neil Horman
On Tue, Jan 30, 2018 at 09:24:17PM +0200, Tommi Rantala wrote: > On 30.01.2018 17:59, Neil Horman wrote: > > On Mon, Jan 29, 2018 at 05:55:45PM +0200, Tommi Rantala wrote: > > > > > > ip netns add TEST > > > ip netns exec TEST ip link set lo up > > > ip link add dummy0 type dummy > > > ip link

Re: net: hang in unregister_netdevice: waiting for lo to become free

2018-01-30 Thread David Ahern
On 1/30/18 1:08 PM, Daniel Borkmann wrote: > On 01/30/2018 07:32 PM, Cong Wang wrote: >> On Tue, Jan 30, 2018 at 4:09 AM, Dmitry Vyukov wrote: >>> Hello, >>> >>> The following program creates a hang in unregister_netdevice. >>> cleanup_net work hangs there forever periodically

[PATCH bpf-next v8 2/5] libbpf: add function to setup XDP

2018-01-30 Thread Eric Leblond
Most of the code is taken from set_link_xdp_fd() in bpf_load.c and slightly modified to be library compliant. Signed-off-by: Eric Leblond Acked-by: Alexei Starovoitov --- tools/lib/bpf/bpf.c| 122 +

[PATCH bpf-next v8 3/5] libbpf: add error reporting in XDP

2018-01-30 Thread Eric Leblond
Parse netlink ext attribute to get the error message returned by the card. Code is partially take from libnl. We add netlink.h to the uapi include of tools. And we need to avoid include of userspace netlink header to have a successful build of sample so nlattr.h has a define to avoid the

[PATCH bpf-next v8 4/5] libbpf: add missing SPDX-License-Identifier

2018-01-30 Thread Eric Leblond
Signed-off-by: Eric Leblond Acked-by: Alexei Starovoitov --- tools/lib/bpf/bpf.c| 2 ++ tools/lib/bpf/bpf.h| 2 ++ tools/lib/bpf/libbpf.c | 2 ++ tools/lib/bpf/libbpf.h | 2 ++ 4 files changed, 8 insertions(+) diff --git a/tools/lib/bpf/bpf.c

[PATCH bpf-next v8 1/5] tools: add netlink.h and if_link.h in tools uapi

2018-01-30 Thread Eric Leblond
The headers are necessary for libbpf compilation on system with older version of the headers. Signed-off-by: Eric Leblond --- tools/include/uapi/linux/if_link.h | 943 + tools/include/uapi/linux/netlink.h | 251 ++

[PATCH bpf-next v8 5/5] samples/bpf: use bpf_set_link_xdp_fd

2018-01-30 Thread Eric Leblond
Use bpf_set_link_xdp_fd instead of set_link_xdp_fd to remove some code duplication and benefit of netlink ext ack errors message. Signed-off-by: Eric Leblond --- samples/bpf/bpf_load.c | 102 samples/bpf/bpf_load.h |

[PATCH bpf-next v8 0/5] libbpf: add XDP binding support

2018-01-30 Thread Eric Leblond
Hello Daniel, No problem with the delay in the answer. I'm doing far worse. Here is an updated version: - add if_link.h in uapi and remove the definition - fix a commit message - remove uapi from a include Best Regards, -- Eric

Re: macvlan devices and vlan interaction

2018-01-30 Thread Alexander Duyck
On Tue, Jan 30, 2018 at 12:29 PM, Shannon Nelson wrote: > On 1/29/2018 3:01 PM, Keller, Jacob E wrote: >> >> Hi, >> >> I'm currently investigating how macvlan devices behave in regards to vlan >> support, and found some interesting behavior that I am not sure how best

Re: macvlan devices and vlan interaction

2018-01-30 Thread Shannon Nelson
On 1/29/2018 3:01 PM, Keller, Jacob E wrote: Hi, I'm currently investigating how macvlan devices behave in regards to vlan support, and found some interesting behavior that I am not sure how best to correct, or what the right path forward is. If I create a macvlan device: ip link add link

Re: net: hang in unregister_netdevice: waiting for lo to become free

2018-01-30 Thread Daniel Borkmann
On 01/30/2018 07:32 PM, Cong Wang wrote: > On Tue, Jan 30, 2018 at 4:09 AM, Dmitry Vyukov wrote: >> Hello, >> >> The following program creates a hang in unregister_netdevice. >> cleanup_net work hangs there forever periodically printing >> "unregister_netdevice: waiting for lo

Re: [patch 1/1] net/netfilter/x_tables.c: make allocation less aggressive

2018-01-30 Thread Eric Dumazet
On Tue, 2018-01-30 at 11:30 -0800, a...@linux-foundation.org wrote: > From: Michal Hocko > Subject: net/netfilter/x_tables.c: make allocation less aggressive > > syzbot has noticed that xt_alloc_table_info can allocate a lot of memory. > This is an admin only interface but an

Re: [Intel-wired-lan] [RFC PATCH] e1000e: Remove Other from EIAC.

2018-01-30 Thread Alexander Duyck
On Wed, Jan 17, 2018 at 10:50 PM, Benjamin Poirier wrote: > It was reported that emulated e1000e devices in vmware esxi 6.5 Build > 7526125 do not link up after commit 4aea7a5c5e94 ("e1000e: Avoid receiver > overrun interrupt bursts", v4.15-rc1). Some tracing shows that after >

Re: [RFC PATCH 2/2] hv_netvsc: Change GPADL teardown order according to Hyper-V version

2018-01-30 Thread Stephen Hemminger
On Tue, 23 Jan 2018 10:34:05 +0100 Mohammed Gamal wrote: > Commit 0cf737808ae7 ("hv_netvsc: netvsc_teardown_gpadl() split") > introduced a regression causing VMs not to shutdown on pre-Wind2016 > hosts after netvsc_remove_device() is called. This was caused as the > GPADL

[patch 1/1] net/netfilter/x_tables.c: make allocation less aggressive

2018-01-30 Thread akpm
From: Michal Hocko Subject: net/netfilter/x_tables.c: make allocation less aggressive syzbot has noticed that xt_alloc_table_info can allocate a lot of memory. This is an admin only interface but an admin in a namespace is sufficient as well. eacd86ca3b03

Re: [RFC PATCH 1/2] hv_netvsc: Split netvsc_revoke_buf() and netvsc_teardown_gpadl()

2018-01-30 Thread Stephen Hemminger
On Tue, 23 Jan 2018 10:34:04 +0100 Mohammed Gamal wrote: > Split each of the functions into two for each of send/recv buffers > > Signed-off-by: Mohammed Gamal Splitting these functions is not necessary

[PATCH][next] wil6210: fix spelling mistake: "preperation"-> "preparation"

2018-01-30 Thread Colin King
From: Colin Ian King Trivial fix to spelling mistake in debug error message text. Signed-off-by: Colin Ian King --- drivers/net/wireless/ath/wil6210/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [netfilter-core] kernel panic: Out of memory and no killable processes... (2)

2018-01-30 Thread Andrew Morton
On Tue, 30 Jan 2018 15:01:04 +0100 Michal Hocko wrote: > > Well, this is not about syzkaller, it merely pointed out a potential > > DoS... And that has to be addressed somehow. > > So how about this? > --- argh ;) > >From d48e950f1b04f234b57b9e34c363bdcfec10aeee Mon Sep 17

Re: sctp netns "unregister_netdevice: waiting for lo to become free. Usage count = 1"

2018-01-30 Thread Tommi Rantala
On 30.01.2018 17:59, Neil Horman wrote: On Mon, Jan 29, 2018 at 05:55:45PM +0200, Tommi Rantala wrote: ip netns add TEST ip netns exec TEST ip link set lo up ip link add dummy0 type dummy ip link add dummy1 type dummy ip link add dummy2 type dummy ip link set dev dummy0 netns TEST ip link set

[PATCH v2 01/10] net/sched: kconfig: Remove empty help texts

2018-01-30 Thread Ulf Magnusson
In preparation for adding a warning ("kconfig: Warn if help text is blank"): https://lkml.org/lkml/2018/1/30/516 Signed-off-by: Ulf Magnusson --- net/sched/Kconfig | 3 --- 1 file changed, 3 deletions(-) diff --git a/net/sched/Kconfig b/net/sched/Kconfig index

[PATCH 01/10] net/sched: kconfig: Remove empty help texts

2018-01-30 Thread Ulf Magnusson
In preparation for adding a warning ("kconfig: Warn if help text is blank"): https://lkml.org/lkml/2018/1/30/516 Signed-off-by: Ulf Magnusson --- net/sched/Kconfig | 3 --- 1 file changed, 3 deletions(-) diff --git a/net/sched/Kconfig b/net/sched/Kconfig index

Re: net: hang in unregister_netdevice: waiting for lo to become free

2018-01-30 Thread Cong Wang
On Tue, Jan 30, 2018 at 4:09 AM, Dmitry Vyukov wrote: > Hello, > > The following program creates a hang in unregister_netdevice. > cleanup_net work hangs there forever periodically printing > "unregister_netdevice: waiting for lo to become free. Usage count = 3" > and creation

[PATCH] samples/bpf: Add program for CPU state statistics

2018-01-30 Thread Leo Yan
CPU is active when have running tasks on it and CPUFreq governor can select different operating points (OPP) according to different workload; we use 'pstate' to present CPU state which have running tasks with one specific OPP. On the other hand, CPU is idle which only idle task on it, CPUIdle

[PATCH] wireless: zd1211rw: remove redundant assignment of pointer 'q'

2018-01-30 Thread Colin King
From: Colin Ian King Pointer q is initialized and then almost immediately afterwards being re-assigned the same value. Remove the second redundant assignment. Cleans up clang warning: drivers/net/wireless/zydas/zd1211rw/zd_mac.c:503:23: warning: Value stored to 'q'

Re: [PATCH iproute2-next 6/6] ipaddress: Get rid of print_linkinfo_brief()

2018-01-30 Thread Serhey Popovych
Stephen Hemminger wrote: > On Tue, 30 Jan 2018 18:52:48 +0200 > Serhey Popovych wrote: > >> +if (brief) { >> +print_name_and_link("%-16s ", COLOR_NONE, name, tb); >> + >> +if (tb[IFLA_OPERSTATE]) >> +print_operstate(fp,

[PATCH iproute2-next v2 6/6] ipaddress: Make print_linkinfo_brief() static

2018-01-30 Thread Serhey Popovych
It shares lot of code with print_linkinfo(): drop duplicated part, change parameters list, make it static and call from print_linkinfo() after common path. While there move SPRINT_BUF() to the function scope from blocks to avoid duplication and use "%s" to print "\n" to help compiler optimize

[PATCH iproute2-next v2 1/6] ipaddress: Improve print_linkinfo()

2018-01-30 Thread Serhey Popovych
There are few places to improve: 1) return -1 when entry is filtered instead of zero, which means accept entry: ipaddress_list_flush_or_save() the only user of this 2) use ll_index_to_name() as last resort to translate name to index: it will return name in the form "if%d" in case

[PATCH iproute2-next v2 3/6] lib: Correct object file dependencies

2018-01-30 Thread Serhey Popovych
Neither internal libnetlink nor libgenl depends on ll_map.o: prepare for upcoming changes that brings much more cleaner dependency between utils.o and ll_map.o. Signed-off-by: Serhey Popovych --- lib/Makefile |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[PATCH iproute2-next v2 0/6] ipaddress: Get rid of print_linkinfo_brief()

2018-01-30 Thread Serhey Popovych
With this series I propose to get rid of custom print_linkinfo_brief() in favor of print_linkinfo() to avoid code duplication. Changes presented with this series tested using following script: iproute2_dir="$1" iface='eth0.2' pushd "$iproute2_dir" &>/dev/null for i in new old; do

[PATCH iproute2-next v2 4/6] utils: Introduce and use get_ifname_rta()

2018-01-30 Thread Serhey Popovych
Be consistent in handling of IFLA_IFNAME attribute in all places: if there is no attribute report bug to stderr and use ll_index_to_name() as last measure to get name in "if%d" format instead of "". Use check_ifname() to validate network device name: this catches both unexpected return from

[PATCH iproute2-next v2 2/6] ipaddress: Simplify print_linkinfo_brief() and it's usage

2018-01-30 Thread Serhey Popovych
Improve print_linkinfo_brief() and it's callers: 1) Get rid of custom @struct filter pointer @pfilter: it is NULL in all callers anyway and global @filter is used. 2) Simplify calling code in ipaddr_list_flush_or_save() by introducing intermediate variable of @struct nlmsghdr, drop

[PATCH iproute2-next v2 5/6] utils: Introduce and use print_name_and_link() to print name@link

2018-01-30 Thread Serhey Popovych
There is at least three places implementing same things: two in ipaddress.c print_linkinfo() & print_linkinfo_brief() and one in bridge/link.c. These two implementations diverge from each other very little: bridge/link.c does not support JSON output at the moment and print_linkinfo_brief() does

[PATCH net] netfilter: on sockopt() acquire sock lock only in the required scope

2018-01-30 Thread Paolo Abeni
Syzbot reported several deadlocks in the netfilter area caused by rtnl lock and socket lock being acquired with a different order on different code paths, leading to backtraces like the following one: == WARNING: possible circular locking

  1   2   >