Re: Regression in 39461af74125 "bitmap: replace bitmap_{from,to}_u32array"

2018-02-04 Thread Yury Norov
On Mon, Feb 05, 2018 at 07:21:32AM +0100, Heiner Kallweit wrote: > Recently ethtool started to give incomplete values for supported and > advertised modes. There seems to be a regression in this commit: > The bit number parameter in the calls to bitmap_to_arr32() in > store_link_ksettings_for_user(

Regression in 39461af74125 "bitmap: replace bitmap_{from,to}_u32array"

2018-02-04 Thread Heiner Kallweit
Recently ethtool started to give incomplete values for supported and advertised modes. There seems to be a regression in this commit: The bit number parameter in the calls to bitmap_to_arr32() in store_link_ksettings_for_user() should be __ETHTOOL_LINK_MODE_MASK_NBITS instead of __ETHTOOL_LINK_MODE

Re: [PATCH] DT: net: renesas,ravb: document R8A77980 bindings

2018-02-04 Thread Rob Herring
On Thu, Feb 01, 2018 at 11:13:45PM +0300, Sergei Shtylyov wrote: > Renesas R-Car V3H (R8A77980) SoC has the R-Car gen3 compatible EtherAVB > device, so document the SoC specific bindings. > > Signed-off-by: Sergei Shtylyov > > --- > The patch is against DaveM's 'net-next.git' repo but I wouldn't

Re: r8169 take too long to complete driver initialization

2018-02-04 Thread Chris Chiu
On Fri, Feb 2, 2018 at 7:49 PM, Hau wrote: > >> -Original Message- >> From: Chris Chiu [mailto:c...@endlessm.com] >> Sent: Friday, February 2, 2018 10:03 AM >> To: Hau >> Cc: nic_swsd ; netdev@vger.kernel.org; Linux >> Kernel ; Linux Upstreaming Team >> >> Subject: Re: r8169 take too lon

[PATCH v2] net: sched: tbf: handle GSO_BY_FRAGS case in enqueue

2018-02-04 Thread Daniel Axtens
tbf_enqueue() checks the size of a packet before enqueuing it. However, the GSO size check does not consider the GSO_BY_FRAGS case, and so will drop GSO SCTP packets, causing a massive drop in throughput. Use skb_gso_validate_mac_len() instead, as it does consider that case. Signed-off-by: Daniel

[PATCH net] dwc-xlgmac: remove Jie Deng as co-maintainer

2018-02-04 Thread Jie Deng
Jose Abreu is working on this driver and I will leave Synopsys soon. Thus it does not seem appropriate for me to be a co-maintainer anymore. Signed-off-by: Jie Deng --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index b59a8cd..8903842 100644 --- a/MA

[PATCH] net: sched: tbf: handle GSO_BY_FRAGS case in enqueue

2018-02-04 Thread Daniel Axtens
tbf_enqueue() checks the size of a packet before enqueuing it. However, the GSO size check does not consider the GSO_BY_FRAGS case, and so will drop GSO SCTP packets, causing a massive drop in throughput. Use skb_gso_validate_mac_len() instead, as it does consider that case. --- skb_gso_validate

[PATCH v3] RDS: IB: Fix null pointer issue

2018-02-04 Thread Guanglei Li
Scenario: 1. Port down and do fail over 2. Ap do rds_bind syscall PID: 47039 TASK: 89887e2fe640 CPU: 47 COMMAND: "kworker/u:6" #0 [898e35f159f0] machine_kexec at 8103abf9 #1 [898e35f15a60] crash_kexec at 810b96e3 #2 [898e35f15b30] oops_end at 8150f518

[PATCH] doc: Change the min default value of tcp_wmem/tcp_rmem.

2018-02-04 Thread Tonghao Zhang
The SK_MEM_QUANTUM was changed from PAGE_SIZE to 4096. And the tcp_wmem/tcp_rmem min default values are 4096. Fixes: bd68a2a854ad ("net: set SK_MEM_QUANTUM to 4096") Cc: Eric Dumazet Signed-off-by: Tonghao Zhang --- Documentation/networking/ip-sysctl.txt | 4 ++-- 1 file changed, 2 insertions(+

[PATCH 18/20] iwlwifi: fix malformed CONFIG_IWLWIFI_PCIE_RTPM default

2018-02-04 Thread Ulf Magnusson
'default false' should be 'default n', though they happen to have the same effect here, due to undefined symbols ('false' in this case) evaluating to n in a tristate sense. Remove the default instead of changing it. bool and tristate symbols implicitly default to n. Discovered with the https://gi

Re: [PATCH net] sctp: fix dst reference leak in sctp_v4_get_dst

2018-02-04 Thread Marcelo Ricardo Leitner
Hi, On Sun, Feb 04, 2018 at 11:02:39AM +0200, Tommi Rantala wrote: > Fix dst reference leak in sctp_v4_get_dst() introduced in commit > 410f03831 ("sctp: add routing output fallback"): > > When walking the address_list, successive ip_route_output_key() calls > may return the same rt->dst with the

Re: [PATCH bpf] bpf: fix selftests/bpf test_kmod.sh failure when CONFIG_BPF_JIT_ALWAYS_ON=y

2018-02-04 Thread Daniel Borkmann
On 02/03/2018 07:37 AM, Yonghong Song wrote: > With CONFIG_BPF_JIT_ALWAYS_ON is defined in the config file, > tools/testing/selftests/bpf/test_kmod.sh failed like below: [...] > With this logic, Test #297 always gets return value -ENOTSUPP > when CONFIG_BPF_JIT_ALWAYS_ON is defined, causing the tes

Re: pull-request: bpf 2018-02-02

2018-02-04 Thread David Miller
From: Alexei Starovoitov Date: Fri, 2 Feb 2018 18:09:13 -0800 > The following pull-request contains BPF updates for your *net* tree. > > The main changes are: > > 1) support XDP attach in libbpf, from Eric. > > 2) minor fixes, from Daniel, Jakub, Yonghong, Alexei. > > Please consider pulling

Re: [Intel-wired-lan] [PATCH] e1000e: allocate ring descriptors with dma_zalloc_coherent

2018-02-04 Thread Alexander Duyck
On Sun, Feb 4, 2018 at 12:01 PM, Florian Fainelli wrote: > > > On 01/26/2018 02:24 AM, Pierre-Yves Kerbrat wrote: >> Descriptor rings were not initialized at zero when allocated >> When area contained garbage data, it caused skb_over_panic in >> e1000_clean_rx_irq (if data had E1000_RXD_STAT_DD bi

[PATCH v2 1/2] r8169: Dereference MMIO address immediately before use

2018-02-04 Thread Andy Shevchenko
There is no need to dereference struct rtl8169_private to get mmio_addr in almost every function in the driver. Replace it by using pointer to struct rtl8169_private directly. No functional change intended. Next step might be a conversion of RTL_Wxx() / RTL_Rxx() macros to inline functions for s

[PATCH v2 2/2] r8169: switch to device-managed functions in probe (part 2)

2018-02-04 Thread Andy Shevchenko
This is a follow up to the commit 4c45d24a759d ("r8169: switch to device-managed functions in probe") to move towards managed resources even more. Cc: Heiner Kallweit Signed-off-by: Andy Shevchenko --- drivers/net/ethernet/realtek/r8169.c | 16 1 file changed, 4 insertions(

Re: [RFC PATCH 05/10] net: dsa: mv88e6xxx: add support for GPIO configuration

2018-02-04 Thread Andrew Lunn
On Sun, Feb 04, 2018 at 11:53:58AM -0800, Florian Fainelli wrote: > On 02/03/2018 01:40 PM, Andrew Lunn wrote: > > From: Brandon Streiff > > > > MV88E6352 and later switches support GPIO control through the "Scratch > > & Misc" global2 register. (Older switches do too, though with a slightly > >

Re: PA Semi PWRficient Gigabit Ethernet doesn't work anymore since the first networking updates for the kernel 4.16

2018-02-04 Thread Florian Fainelli
On 02/04/2018 09:16 AM, Andrew Lunn wrote: > On Sun, Feb 04, 2018 at 05:47:03PM +0100, Christian Zigotzky wrote: >> Hello, >> >> The PA Semi PWRficient Gigabit Ethernet doesn't work anymore since the first >> networking updates [1] for the kernel 4.16. >> >> Error messages: >> >> [    0.634241] l

Re: [PATCH] e1000e: allocate ring descriptors with dma_zalloc_coherent

2018-02-04 Thread Florian Fainelli
On 01/26/2018 02:24 AM, Pierre-Yves Kerbrat wrote: > Descriptor rings were not initialized at zero when allocated > When area contained garbage data, it caused skb_over_panic in > e1000_clean_rx_irq (if data had E1000_RXD_STAT_DD bit set) > > This patch makes use of dma_zalloc_coherent to make s

Re: [RFC PATCH 05/10] net: dsa: mv88e6xxx: add support for GPIO configuration

2018-02-04 Thread Florian Fainelli
On 02/03/2018 01:40 PM, Andrew Lunn wrote: > From: Brandon Streiff > > MV88E6352 and later switches support GPIO control through the "Scratch > & Misc" global2 register. (Older switches do too, though with a slightly > different register interface. Only the 6352-style is implemented here.) > > A

Re: [PATCH v1] r8169: switch to device-managed functions in probe (part 2)

2018-02-04 Thread Andy Shevchenko
On Sun, 2018-02-04 at 21:29 +0200, Andy Shevchenko wrote: > This is a follow up to the commit > > 4c45d24a759d ("r8169: switch to device-managed functions in probe") > > to move towards managed resources even more. > Oops, sorry, it's not ready-yet version. > Cc: Heiner Kallweit > Signed-o

[PATCH v1] r8169: switch to device-managed functions in probe (part 2)

2018-02-04 Thread Andy Shevchenko
This is a follow up to the commit 4c45d24a759d ("r8169: switch to device-managed functions in probe") to move towards managed resources even more. Cc: Heiner Kallweit Signed-off-by: Andy Shevchenko --- drivers/net/ethernet/realtek/r8169.c | 16 1 file changed, 4 insertions(

Re: [PATCH net 1/1 v1] rtnetlink: require unique netns identifier

2018-02-04 Thread David Ahern
On 2/4/18 5:11 AM, Christian Brauner wrote: > On Sat, Feb 03, 2018 at 11:17:01AM -0800, Stephen Hemminger wrote: >> On Sat, 3 Feb 2018 14:29:04 +0100 >> Christian Brauner wrote: >> >>> +static int rtnl_ensure_unique_netns_attr(const struct sock *sk, >>> +struct

Re: PA Semi PWRficient Gigabit Ethernet doesn't work anymore since the first networking updates for the kernel 4.16

2018-02-04 Thread Andrew Lunn
On Sun, Feb 04, 2018 at 05:47:03PM +0100, Christian Zigotzky wrote: > Hello, > > The PA Semi PWRficient Gigabit Ethernet doesn't work anymore since the first > networking updates [1] for the kernel 4.16. > > Error messages: > > [    0.634241] libphy: pasemi gpio mdio bus: probed > [    0.634749]

[no subject]

2018-02-04 Thread Jones
This is in regards to an inheritance on your surname, reply back using your email address, stating your full name for more details. Reply to email for info. Email me here ( ger...@dr.com )

PA Semi PWRficient Gigabit Ethernet doesn't work anymore since the first networking updates for the kernel 4.16

2018-02-04 Thread Christian Zigotzky
Hello, The PA Semi PWRficient Gigabit Ethernet doesn't work anymore since the first networking updates [1] for the kernel 4.16. Error messages: [    0.634241] libphy: pasemi gpio mdio bus: probed [    0.634749] pasemi gpio mdio bus: Cannot register as MDIO bus, err -38 [    2.311496] pasemi_m

Re: xfrm, ip tunnel: non released device reference upon device unregistration

2018-02-04 Thread Eyal Birger
On Sun, 4 Feb 2018 13:21:18 +0200 Eyal Birger wrote: > Hi, > > We've encountered a non released device reference upon device > unregistration which seems to stem from xfrm policy code. > > The setup includes: > - an underlay device (e.g. eth0) using IPv4 > - an xfrm IPv6 over IPv4 tunnel routed

Re: after adding > 200vlans to mlx nic no traffic

2018-02-04 Thread Gal Pressman
On 01-Feb-18 10:25, Paweł Staszewski wrote: > > > W dniu 31.01.2018 o 13:19, Gal Pressman pisze: >> On 30-Jan-18 17:57, Paweł Staszewski wrote: >>> >>> W dniu 30.01.2018 o 15:57, Gal Pressman pisze: On 30-Jan-18 02:29, Paweł Staszewski wrote: > Weird thing with mellanox mlx5 (connectx-4)

Re: [bpf-next PATCH 0/5] tools/libbpf improvements and selftests

2018-02-04 Thread Daniel Borkmann
On 02/04/2018 10:19 AM, Jesper Dangaard Brouer wrote: > On Thu, 1 Feb 2018 18:56:14 +0100 > Daniel Borkmann wrote: > >> Don't get me wrong, I'm not at all against such tool or test, I think >> it's a great idea and needed. I just think that tools/lib/bpf/ is not >> the right place to put it into

Re: [PATCH net 1/1 v1] rtnetlink: require unique netns identifier

2018-02-04 Thread Christian Brauner
On Sat, Feb 03, 2018 at 07:09:55PM -0700, David Ahern wrote: > On 2/3/18 12:17 PM, Stephen Hemminger wrote: > > On Sat, 3 Feb 2018 14:29:04 +0100 > > Christian Brauner wrote: > > > >> +static int rtnl_ensure_unique_netns_attr(const struct sock *sk, > >> + struct

Re: [PATCH net 1/1 v1] rtnetlink: require unique netns identifier

2018-02-04 Thread Christian Brauner
On Sat, Feb 03, 2018 at 11:17:01AM -0800, Stephen Hemminger wrote: > On Sat, 3 Feb 2018 14:29:04 +0100 > Christian Brauner wrote: > > > +static int rtnl_ensure_unique_netns_attr(const struct sock *sk, > > +struct nlattr *tb[], > > +

xfrm, ip tunnel: non released device reference upon device unregistration

2018-02-04 Thread Eyal Birger
Hi, We've encountered a non released device reference upon device unregistration which seems to stem from xfrm policy code. The setup includes: - an underlay device (e.g. eth0) using IPv4 - an xfrm IPv6 over IPv4 tunnel routed via the underlay device - an ipip6 tunnel over the xfrm IPv6 tunnel W

Re: possible deadlock in rtnl_lock (2)

2018-02-04 Thread Dmitry Vyukov
On Sat, Feb 3, 2018 at 12:25 PM, Xin Long wrote: > On Thu, Feb 1, 2018 at 7:58 PM, syzbot > wrote: >> Hello, >> >> syzbot hit the following crash on upstream commit >> 255442c93843f52b6891b21d0b485bf2c97f93c3 (Thu Feb 1 03:25:25 2018 +) >> Merge tag 'docs-4.16' of git://git.lwn.net/linux >> >

Re: Help needed!

2018-02-04 Thread Sandra Younes
Good Day, Forgive my indignation if this message comes to you as a surprise and may offend your personality for contacting you without your prior consent and writing through this channel. I came across your name and contact on the course of my personal searching when i was searching for a fore

Re: [RFC PATCH 01/10] net: ptp: Add stub for ptp_classify_raw()

2018-02-04 Thread Sergei Shtylyov
Hello! On 2/4/2018 12:40 AM, Andrew Lunn wrote: When NET_PTP_CLASSIFY is disabled, a stub function is required in order that drivers compile. s/that/the/? Signed-off-by: Andrew Lunn Acked-by: Richard Cochran [...] MBR, Sergei

Re: [bpf-next PATCH 0/5] tools/libbpf improvements and selftests

2018-02-04 Thread Jesper Dangaard Brouer
On Thu, 1 Feb 2018 18:56:14 +0100 Daniel Borkmann wrote: > Don't get me wrong, I'm not at all against such tool or test, I think > it's a great idea and needed. I just think that tools/lib/bpf/ is not > the right place to put it into lib directory. Right now, as you say, > it's a mixture of examp

Re: sctp netns "unregister_netdevice: waiting for lo to become free. Usage count = 1"

2018-02-04 Thread Tommi Rantala
On 02.02.2018 14:34, Neil Horman wrote: Patch looks good, but if you could please submit it with the proper title in a separate thread so it gets davem's attention properly, I'd appreciate it. Additional points if you update it to include the ipv6 fixes :) Thanks, I'll send this patch properly.

[PATCH net] sctp: fix dst reference leak in sctp_v4_get_dst

2018-02-04 Thread Tommi Rantala
Fix dst reference leak in sctp_v4_get_dst() introduced in commit 410f03831 ("sctp: add routing output fallback"): When walking the address_list, successive ip_route_output_key() calls may return the same rt->dst with the reference incremented on each call. The code would not decrement the dst ref

Re: [Intel-wired-lan] [PATCH] e1000e: allocate ring descriptors with dma_zalloc_coherent

2018-02-04 Thread Neftin, Sasha
On 1/26/2018 12:24, Pierre-Yves Kerbrat wrote: Descriptor rings were not initialized at zero when allocated When area contained garbage data, it caused skb_over_panic in e1000_clean_rx_irq (if data had E1000_RXD_STAT_DD bit set) This patch makes use of dma_zalloc_coherent to make sure the ring i