Re: [PATCH v6 19/36] nds32: VDSO support

2018-01-18 18:28 GMT+08:00 Arnd Bergmann : > On Mon, Jan 15, 2018 at 6:53 AM, Greentime Hu wrote: >> From: Greentime Hu >> >> This patch adds VDSO support. The VDSO code is currently used for >> sys_rt_sigreturn() and optimised

Re: [PATCH iproute2-next 00/10] RDMA resource tracking

On Mon, Feb 05, 2018 at 05:25:53PM -0800, Stephen Hemminger wrote: > On Wed, 31 Jan 2018 10:11:46 +0200 > Leon Romanovsky wrote: > > > Changelog: > > v2 -> v3: > >* Rebased to commit: 1e24e773f144 ("Merge branch 'iproute2-master' into > > iproute2-next") > >* Refreshed

Re: [PATCH v6 20/36] nds32: Signal handling support

Thanks, I got it. After referring to arm64 and risc-v, we try to refine our code, such as removing unneeded checking and refining syscall restart flow. We hope these modifications can enhance the reliability and readability. However, the following 2 files which you had acked are included in this

Re: [PATCH net v3] sctp: fix dst refcnt leak in sctp_v4_get_dst

On Tue, Feb 6, 2018 at 7:20 AM, David Ahern wrote: > On 2/5/18 12:48 PM, Tommi Rantala wrote: >> Fix dst reference count leak in sctp_v4_get_dst() introduced in commit >> 410f03831 ("sctp: add routing output fallback"): >> >> When walking the address_list, successive

[PATCH v3] RDS: IB: Fix null pointer issue

Scenario: 1. Port down and do fail over 2. Ap do rds_bind syscall PID: 47039 TASK: 89887e2fe640 CPU: 47 COMMAND: "kworker/u:6" #0 [898e35f159f0] machine_kexec at 8103abf9 #1 [898e35f15a60] crash_kexec at 810b96e3 #2 [898e35f15b30] oops_end at 8150f518

Re: [PATCH, net] ibmvnic: fix empty firmware version and errors cleanup

From: Desnes Augusto Nunes do Rosario Date: Mon, 5 Feb 2018 14:33:55 -0200 > This patch makes sure that the firmware version is never NULL. Moreover, > it also performs some cleanup on the error messages. > > Fixes: a107311d7fdf ("ibmvnic: fix firmware version when

Re: [PATCH] sctp: fix dst refcnt leak in sctp_v6_get_dst()

From: Alexey Kodanev Date: Mon, 5 Feb 2018 15:10:35 +0300 > When going through the bind address list in sctp_v6_get_dst() and > the previously found address is better ('matchlen > bmatchlen'), > the code continues to the next iteration without releasing currently >

Re: [PATCH net v3] sctp: fix dst refcnt leak in sctp_v4_get_dst

From: Tommi Rantala Date: Mon, 5 Feb 2018 21:48:14 +0200 > Fix dst reference count leak in sctp_v4_get_dst() introduced in commit > 410f03831 ("sctp: add routing output fallback"): > > When walking the address_list, successive ip_route_output_key() calls > may return

Re: Please apply these tiny, 4-month-old patches.

On Tue, 6 Feb 2018 02:42:17 +0100, Andrew Lunn wrote: >>> Please learn how the community works, and how to interact with >>> developers and maintainers in that community appropriately. >> >> I already tried that. >> >> If you're unwilling to be an effective maintainer, then please hand >> off the

Re: Please apply these tiny, 4-month-old patches.

> > Please learn how the community works, and how to interact with > > developers and maintainers in that community appropriately. > > I already tried that. > > If you're unwilling to be an effective maintainer, then please hand > off the responsibiilty to someone else. Could i suggest you

Re: Please apply these tiny, 4-month-old patches.

On Mon, 05 Feb 2018 20:12:11 -0500 (EST), David Miller wrote: >> If this is considered "new" code (it isn't) and if this email is >> received outside of an appropriate merge window, then save this >> email for later consideration---this isn't a real-time conversation; >> this is email, so it

Re: [PATCH iproute2-next 00/10] RDMA resource tracking

On Wed, 31 Jan 2018 10:11:46 +0200 Leon Romanovsky wrote: > Changelog: > v2 -> v3: >* Rebased to commit: 1e24e773f144 ("Merge branch 'iproute2-master' into > iproute2-next") >* Refreshed include/uapi/rdma/rdma_netlink.h file >* Fixed bug, where cxgb4 was printed

Re: [PATCH net v3] sctp: fix dst refcnt leak in sctp_v4_get_dst

On Mon, Feb 05, 2018 at 09:48:14PM +0200, Tommi Rantala wrote: > Fix dst reference count leak in sctp_v4_get_dst() introduced in commit > 410f03831 ("sctp: add routing output fallback"): > > When walking the address_list, successive ip_route_output_key() calls > may return the same rt->dst with

Re: Please apply these tiny, 4-month-old patches.

From: Michael Witten Date: Tue, 06 Feb 2018 00:54:35 - > If this is considered "new" code (it isn't) and if this email is > received outside of an appropriate merge window, then save this > email for later consideration---this isn't a real-time conversation; > this is

Please apply these tiny, 4-month-old patches.

Strictly speaking, these patches streamline the code at both compile-time and run-time, and seem to face no technical objection of note. The strongest objection was a dubious *potential* refactoring of similar code, a refactoring which is clearly vaporware, and which I myself would have tried to

Re: [PATCH] ss: introduce switch to print exact value of data rates

On Fri, 2 Feb 2018 16:32:47 -0700 David Ahern wrote: > On 2/1/18 7:19 AM, Tomasz Torcz wrote: > > Introduce -X/--exact switch to disable human-friendly printing > > of datarates. With the switch, data is not presented as MBps/Kbps. > > > > Signed-off-by: Tomasz Torcz

[PATCH bpf] tools/bpf: fix batch-mode test failure of test_xdp_redirect.sh

The tests at tools/testing/selftests/bpf can run in patch mode, e.g., make -C tools/testing/selftests/bpf run_tests With the batch mode, I experimented intermittent test failure of test_xdp_redirect.sh. selftests: test_xdp_redirect [PASS] selftests: test_xdp_redirect.sh

[PATCH net] nfp: fix kdoc warnings on nested structures

Commit 84ce5b987783 ("scripts: kernel-doc: improve nested logic to handle multiple identifiers") improved the handling of nested structure definitions in scripts/kernel-doc, and changed the expected format of documentation. This causes new warnings to appear on W=1 builds. Only comment changes.

Re: [Patch net v2] xt_RATEEST: acquire xt_rateest_mutex for hash insert

On Mon, 2018-02-05 at 14:41 -0800, Cong Wang wrote: > rateest_hash is supposed to be protected by xt_rateest_mutex, > and, as suggested by Eric, lookup and insert should be atomic, > so we should acquire the xt_rateest_mutex once for both. > > So introduce a non-locking helper for internal use

Re: [PATCH net 1/1 v2] rtnetlink: require unique netns identifier

On Tue, Feb 06, 2018 at 12:47:46AM +0300, Kirill Tkhai wrote: > On 05.02.2018 18:55, Christian Brauner wrote: > > Since we've added support for IFLA_IF_NETNSID for RTM_{DEL,GET,SET,NEW}LINK > > it is possible for userspace to send us requests with three different > > properties to identify a

Re: [PATCH net v3] sctp: fix dst refcnt leak in sctp_v4_get_dst

On 2/5/18 12:48 PM, Tommi Rantala wrote: > Fix dst reference count leak in sctp_v4_get_dst() introduced in commit > 410f03831 ("sctp: add routing output fallback"): > > When walking the address_list, successive ip_route_output_key() calls > may return the same rt->dst with the reference

Re: [Patch net v2] xt_RATEEST: acquire xt_rateest_mutex for hash insert

Cong Wang wrote: > rateest_hash is supposed to be protected by xt_rateest_mutex, > and, as suggested by Eric, lookup and insert should be atomic, > so we should acquire the xt_rateest_mutex once for both. > > So introduce a non-locking helper for internal use and keep

Re: [NetDev-info] Distributed Switch Architecture for 88E6390

> Hi Andrew, > > > For port 0x6 reg 0x4, confirmed. It looks like the latest code is > > correctly setting bits 13:12. I'm porting from an older hash. Hi Dave 6390 support is quite new. So you really should be use the latest code. Otherwise you are going to have issues like this. Plus you are

Re: [PATCH net v3] sctp: fix dst refcnt leak in sctp_v4_get_dst

On Mon, Feb 05, 2018 at 09:48:14PM +0200, Tommi Rantala wrote: > Fix dst reference count leak in sctp_v4_get_dst() introduced in commit > 410f03831 ("sctp: add routing output fallback"): > > When walking the address_list, successive ip_route_output_key() calls > may return the same rt->dst with

[Patch net v2] xt_RATEEST: acquire xt_rateest_mutex for hash insert

rateest_hash is supposed to be protected by xt_rateest_mutex, and, as suggested by Eric, lookup and insert should be atomic, so we should acquire the xt_rateest_mutex once for both. So introduce a non-locking helper for internal use and keep the locking one for external. Reported-by:

Re: [PATCH 4/4] net: amd-xgbe: fix comparison to bitshift when dealing with a mask

On 2/5/2018 2:10 PM, Wolfram Sang wrote: > Due to a typo, the mask was destroyed by a comparison instead of a bit > shift. > > Signed-off-by: Wolfram Sang Excellent find. Acked-by: Tom Lendacky David, this should also be applied to

Re: Potential issue with f5e64032a799 "net: phy: fix resume handling"

Am 04.02.2018 um 03:48 schrieb Florian Fainelli: > > > On 02/03/2018 03:58 PM, Heiner Kallweit wrote: >> Am 03.02.2018 um 21:17 schrieb Andrew Lunn: >>> On Sat, Feb 03, 2018 at 05:41:54PM +0100, Heiner Kallweit wrote: This commit forces callers of phy_resume() and phy_suspend() to hold

Re: [PATCH net 1/1 v2] rtnetlink: require unique netns identifier

On 05.02.2018 18:55, Christian Brauner wrote: > Since we've added support for IFLA_IF_NETNSID for RTM_{DEL,GET,SET,NEW}LINK > it is possible for userspace to send us requests with three different > properties to identify a target network namespace. This affects at least > RTM_{NEW,SET}LINK. Each

Re: [NetDev-info] Distributed Switch Architecture for 88E6390

On Mon, Feb 05, 2018 at 03:52:20PM -0500, David Thompson wrote: > Hello all! I really appreciate any feedback with regards to my inquiry. Hi David No top posting please. Please make your signature confirm the netiquette. That general means 4 lines max, no legal gibberish, etc. Andrew

Re: [PATCH net v4] cls_u32: fix use after free in u32_destroy_key()

On Mon, Feb 5, 2018 at 1:23 PM, Paolo Abeni wrote: > The problem is that the htnode is freed before the linked knodes and the > latter will try to access the first at u32_destroy_key() time. > This change addresses the issue using the htnode refcnt to guarantee > the correct

Re: [NetDev-info] Distributed Switch Architecture for 88E6390

On Mon, Feb 05, 2018 at 02:59:48PM -0500, S.Y. Park wrote: > Dear Mr. Thompson, > > I'm forwarding to you to the technical discussion mailing list called > "netdev@vger.kernel.org". > > i...@netdevconf.org is for discussions regarding The NetDev Society's > NetDev Conference attendance &

[PATCH net 2/3] net: erspan: fix erspan config overwrite

When an erspan tunnel device receives an erpsan packet with different tunnel metadata (ex: version, index, hwid, direction), existing code overwrites the tunnel device's erspan configuration with the received packet's metadata. The patch fixes it. Fixes: 1a66a836da63 ("gre: add collect_md mode

[PATCH net 3/3] sample/bpf: fix erspan metadata

The commit c69de58ba84f ("net: erspan: use bitfield instead of mask and offset") changes the erspan header to use bitfield, and commit d350a823020e ("net: erspan: create erspan metadata uapi header") creates a uapi header file. The above two commit breaks the current erspan test. This patch

[PATCH net 1/3] net: erspan: fix metadata extraction

Commit d350a823020e ("net: erspan: create erspan metadata uapi header") moves the erspan 'version' in front of the 'struct erspan_md2' for later extensibility reason. This breaks the existing erspan metadata extraction code because the erspan_md2 then has a 4-byte offset to between the

[PATCH net 0/3] net: erspan fixes

The first patch fixes erspan metadata extraction issue from packet header due to commit d350a823020e ("net: erspan: create erspan metadata uapi header"). The commit moves the erspan 'version' in 'struct erspan_metadata' in front of 'struct erspan_md2' for later extensibility, but breaks the

[PATCH net v4] cls_u32: fix use after free in u32_destroy_key()

Li Shuang reported an Oops with cls_u32 due to an use-after-free in u32_destroy_key(). The use-after-free can be triggered with: dev=lo tc qdisc add dev $dev root handle 1: htb default 10 tc filter add dev $dev parent 1: prio 5 handle 1: protocol ip u32 divisor 256 tc filter add dev $dev protocol

Re: [NetDev-info] Distributed Switch Architecture for 88E6390

On 02/05/2018 11:59 AM, S.Y. Park wrote: > Dear Mr. Thompson, > > I'm forwarding to you to the technical discussion mailing list called > "netdev@vger.kernel.org". > > i...@netdevconf.org is for discussions regarding The NetDev Society's > NetDev Conference attendance & participation

[PATCH 4/4] net: amd-xgbe: fix comparison to bitshift when dealing with a mask

Due to a typo, the mask was destroyed by a comparison instead of a bit shift. Signed-off-by: Wolfram Sang --- Only build tested. To be applied individually per subsystem. drivers/net/ethernet/amd/xgbe/xgbe-drv.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 0/4] tree-wide: fix comparison to bitshift when dealing with a mask

In one Renesas driver, I found a typo which turned an intended bit shift ('<<') into a comparison ('<'). Because this is a subtle issue, I looked tree wide for similar patterns. This small patch series is the outcome. Buildbot and checkpatch are happy. Only compile-tested. To be applied

Re: [NetDev-info] Distributed Switch Architecture for 88E6390

Dear Mr. Thompson, I'm forwarding to you to the technical discussion mailing list called "netdev@vger.kernel.org". i...@netdevconf.org is for discussions regarding The NetDev Society's NetDev Conference attendance & participation questions & concerns, not technical discussion. Good luck w/

[PATCH iproute2-next 9/9] ipaddress: Make print_linkinfo_brief() static

It shares lot of code with print_linkinfo(): drop duplicated part, change parameters list, make it static and call from print_linkinfo() after common path. While there move SPRINT_BUF() to the function scope from blocks to avoid duplication and use "%s" to print "\n" to help compiler optimize

[PATCH iproute2-next 8/9] utils: Introduce and use print_name_and_link() to print name@link

There is at least three places implementing same things: two in ipaddress.c print_linkinfo() & print_linkinfo_brief() and one in bridge/link.c. They are diverge from each other very little: bridge/link.c does not support JSON output at the moment and print_linkinfo_brief() does not handle

[PATCH iproute2-next 7/9] utils: Introduce and use get_ifname_rta()

Be consistent in handling of IFLA_IFNAME attribute in all places: if there is no attribute report bug to stderr and use ll_idx_n2a() as last measure to get name in "if%u" format instead of "". Use check_ifname() to validate network device name: this catches both unexpected return from kernel and

[PATCH iproute2-next 1/9] ipaddress: Abstract IFA_LABEL matching code

There at least two places in ip/ipaddress.c where we match IFA_LABEL against filter.label if that is given. Get rid of "common" if () statement for inet_addr_match_rta() and ifa_label_match_rta(): it is not common because first will check for filter.pfx.family != AF_UNSPEC inside and second for

[PATCH iproute2-next 4/9] ipaddress: Improve print_linkinfo()

There are few places to improve: 1) return -1 when entry is filtered instead of zero, which means accept entry: ipaddress_list_flush_or_save() the only user of this 2) use ll_idx_n2a() as last resort to translate name to index for "should never happen" cases when cache shouldn't be

[PATCH iproute2-next 5/9] ipaddress: Simplify print_linkinfo_brief() and it's usage

Simplify calling code in ipaddr_list_flush_or_save() by introducing intermediate variable of @struct nlmsghdr, drop duplicated code: print_linkinfo_brief() never returns values other than <= 0 so we can move print_selected_addrinfo() outside of each block. Signed-off-by: Serhey Popovych

[PATCH iproute2-next 3/9] utils: Reimplement ll_idx_n2a() and introduce ll_idx_a2n()

Now all users of ll_idx_n2a() replaced with ll_index_to_name() we can move it's functionality to ll_index_to_name() and implement index to name conversion using snprintf() and "if%u". Use %u specifier in "if%..." template consistently: network device indexes are always greather than zero. Also

[PATCH iproute2-next 2/9] ipaddress: ll_map: Replace ll_idx_n2a() with ll_index_to_name()

There is no reentrancy as well as deferred result usage for all cases where ll_idx_n2a() being used: it is safe to use ll_index_to_name() that internally calls ll_idx_n2a() with static buffer to hold result. Signed-off-by: Serhey Popovych --- ip/ipaddress.c | 14

[PATCH iproute2-next 6/9] lib: Correct object file dependencies

Neither internal libnetlink nor libgenl depends on ll_map.o: prepare for upcoming changes that brings much more cleaner dependency between utils.o and ll_map.o. Signed-off-by: Serhey Popovych --- lib/Makefile |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[PATCH iproute2-next 0/9] ipaddress: Make print_linkinfo_brief() static

With this series I propose to make print_linkinfo_brief() static in favor of print_linkinfo() as single point for linkinfo printing. Changes presented with this series tested using following script: \#!/bin/bash iproute2_dir="$1" iface='eth0.2' pushd "$iproute2_dir" &>/dev/null for i in new

[PATCH net v3] sctp: fix dst refcnt leak in sctp_v4_get_dst

Fix dst reference count leak in sctp_v4_get_dst() introduced in commit 410f03831 ("sctp: add routing output fallback"): When walking the address_list, successive ip_route_output_key() calls may return the same rt->dst with the reference incremented on each call. The code would not decrement the

Re: [PATCH v2 1/1] tcp: Honor the eor bit in tcp_mtu_probe

On Mon, 2018-02-05 at 20:18 +0200, Ilya Lesokhin wrote: > Avoid SKB coalescing if eor bit is set in one of the relevant > SKBs. > > Fixes: c134ecb87817 ("tcp: Make use of MSG_EOR in tcp_sendmsg") > Signed-off-by: Ilya Lesokhin > --- > net/ipv4/tcp_output.c | 12

Re: [PATCH net v3] cls_u32: fix use after free in u32_destroy_key()

On Mon, Feb 5, 2018 at 1:20 AM, Paolo Abeni wrote: > @@ -625,6 +627,8 @@ static int u32_destroy_hnode(struct tcf_proto *tp, struct > tc_u_hnode *ht, > idr_destroy(>handle_idr); > idr_remove_ext(_c->handle_idr, ht->handle); >

[PATCH v2 1/1] tcp: Honor the eor bit in tcp_mtu_probe

Avoid SKB coalescing if eor bit is set in one of the relevant SKBs. Fixes: c134ecb87817 ("tcp: Make use of MSG_EOR in tcp_sendmsg") Signed-off-by: Ilya Lesokhin --- net/ipv4/tcp_output.c | 12 1 file changed, 12 insertions(+) diff --git a/net/ipv4/tcp_output.c

[bpf PATCH v4 3/3] bpf: sockmap, fix leaking maps with attached but not detached progs

When a program is attached to a map we increment the program refcnt to ensure that the program is not removed while it is potentially being referenced from sockmap side. However, if this same program also references the map (this is a reasonably common pattern in my programs) then the verifier

[bpf PATCH v4 2/3] bpf: sockmap, add sock close() hook to remove socks

The selftests test_maps program was leaving dangling BPF sockmap programs around because not all psock elements were removed from the map. The elements in turn hold a reference on the BPF program they are attached to causing BPF programs to stay open even after test_maps has completed. The

[bpf PATCH v4 1/3] net: add a UID to use for ULP socket assignment

Create a UID field and enum that can be used to assign ULPs to sockets. This saves a set of string comparisons if the ULP id is known. For sockmap, which is added in the next patches, a ULP is used to hook into TCP sockets close state. In this case the ULP being added is done at map insert time

[bpf PATCH v4 0/3] bpf: sockmap fixes

A set of fixes for sockmap to resolve programs referencing sockmaps and closing without deleting all entries in the map and/or not detaching BPF programs attached to the map. Both leaving entries in the map and not detaching programs may result in the map failing to be removed by BPF

[PATCH net] net: phy: Handle not having GPIO enabled in the kernel

If CONFIG_GPIOLIB is disabled, fwnode_get_named_gpiod() becomes a stub function, which return -ENOSYS. Handle this in the same way as -ENOENT, i.e. assume there is no GPIO used to reset the PHYs. Reported-by: Christian Zigotzky Tested-by: Christian Zigotzky

[PATCH 2/2] netfilter: nf_tables: fix flowtable resource leak

When cleaning up flowtable entries, associated dst and ct entries need to be released as well Signed-off-by: Felix Fietkau --- net/netfilter/nf_flow_table.c | 19 +-- 1 file changed, 5 insertions(+), 14 deletions(-) diff --git a/net/netfilter/nf_flow_table.c

[PATCH 1/2] netfilter: nf_tables: fix flowtable free

Every flow_offload entry is added into the table twice. Because of this, rhashtable_free_and_destroy can't be used, since it would call kfree for each flow_offload object twice. Signed-off-by: Felix Fietkau --- include/net/netfilter/nf_flow_table.h | 2 ++

Re: [PATCH v3] RDS: IB: Fix null pointer issue

On Mon, 2018-02-05 at 10:27 +0800, Guanglei Li wrote: > Scenario: > 1. Port down and do fail over > 2. Ap do rds_bind syscall > > PID: 47039 TASK: 89887e2fe640 CPU: 47 COMMAND: "kworker/u:6" > #0 [898e35f159f0] machine_kexec at 8103abf9 > #1 [898e35f15a60] crash_kexec at

Re: [PATCH v2] socket: Provide put_cmsg_whitelist() for constant size copies

On Tue, Feb 6, 2018 at 2:03 AM, David Miller wrote: > From: Kees Cook > Date: Fri, 2 Feb 2018 02:27:49 -0800 > >> @@ -343,6 +343,14 @@ struct ucred { >> >> extern int move_addr_to_kernel(void __user *uaddr, int ulen, struct >> sockaddr_storage

Re: [PATCH V2 net-next] rds: tcp: use rds_destroy_pending() to synchronize netns/module teardown and rds connection/workq management

On 2/3/2018 4:26 AM, Sowmini Varadhan wrote: An rds_connection can get added during netns deletion between lines 528 and 529 of 506 static void rds_tcp_kill_sock(struct net *net) : /* code to pull out all the rds_connections that should be destroyed */ : 528

Re: [PATCH 1/1] tcp: Honor the eor bit in tcp_mtu_probe

On Mon, 2018-02-05 at 07:52 -0800, Eric Dumazet wrote: > On Mon, 2018-02-05 at 17:11 +0200, Ilya Lesokhin wrote: > > Avoid SKB coalescing if eor bit is set in one of the relevant > > SKBs. > > > > Fixes: c134ecb87817 ("tcp: Make use of MSG_EOR in tcp_sendmsg") > > Signed-off-by: Ilya Lesokhin

[PATCH, net] ibmvnic: fix empty firmware version and errors cleanup

This patch makes sure that the firmware version is never NULL. Moreover, it also performs some cleanup on the error messages. Fixes: a107311d7fdf ("ibmvnic: fix firmware version when no firmware level has been provided by the VIOS server") Signed-off-by: Desnes A. Nunes do Rosario

Re: [PATCH net 1/1 v2] rtnetlink: require unique netns identifier

On 2/5/18 8:55 AM, Christian Brauner wrote: > Since we've added support for IFLA_IF_NETNSID for RTM_{DEL,GET,SET,NEW}LINK > it is possible for userspace to send us requests with three different > properties to identify a target network namespace. This affects at least > RTM_{NEW,SET}LINK. Each of

Re: [BUG iproute2] ip tuntap show

On 2/5/18 8:34 AM, Serhey Popovych wrote: > Sorry David, but I do no see problem with this function right now: > > 1. It allocates string using malloc() in asprintf() > 2. free() it *after* fopen() to prevent memory leak if fopen() fails > 3. or if fopen() succeeded and we fscanf() with %ms

Re: regression in igb driver from commit 182785335447

On Fri, Feb 02, 2018 at 12:54:27PM -0600, Aaron Sierra wrote: > > From: "Michal Kubecek" > > Sent: Thursday, February 1, 2018 6:47:32 AM > > [ 13.710535] igb: Intel(R) Gigabit Ethernet Network Driver - version > > 5.4.0-k > > [ 13.710538] igb: Copyright (c) 2007-2014 Intel

[PATCH net 1/1 v2] rtnetlink: require unique netns identifier

Since we've added support for IFLA_IF_NETNSID for RTM_{DEL,GET,SET,NEW}LINK it is possible for userspace to send us requests with three different properties to identify a target network namespace. This affects at least RTM_{NEW,SET}LINK. Each of them could potentially refer to a different network

[PATCH net 0/1 v2] rtnetlink: require unique netns identifier

Hey, Since we've added support for IFLA_IF_NETNSID for RTM_{DEL,GET,SET,NEW}LINK it is possible for userspace to send us requests with three different properties to identify a target network namespace. This affects at least RTM_{NEW,SET}LINK. Each of them could potentially refer to a different

Re: [PATCH] sctp: fix dst refcnt leak in sctp_v6_get_dst()

On Mon, Feb 05, 2018 at 03:10:35PM +0300, Alexey Kodanev wrote: > When going through the bind address list in sctp_v6_get_dst() and > the previously found address is better ('matchlen > bmatchlen'), > the code continues to the next iteration without releasing currently > held destination. > > Fix

Re: [PATCH 1/1] tcp: Honor the eor bit in tcp_mtu_probe

On Mon, 2018-02-05 at 17:11 +0200, Ilya Lesokhin wrote: > Avoid SKB coalescing if eor bit is set in one of the relevant > SKBs. > > Fixes: c134ecb87817 ("tcp: Make use of MSG_EOR in tcp_sendmsg") > Signed-off-by: Ilya Lesokhin > --- Reviewed-by: Eric Dumazet

Re: [PATCH net v2] sctp: fix dst refcnt leak in sctp_v4_get_dst

On Mon, Feb 05, 2018 at 03:33:11PM +0200, Tommi Rantala wrote: > Fix dst reference count leak in sctp_v4_get_dst() introduced in commit > 410f03831 ("sctp: add routing output fallback"): > Patch LGTM. Will wait the respin for Acking. Thanks.

Re: [PATCH bpf] bpf: prevent out-of-bounds speculation

Hi all, On Wed, Jan 10, 2018 at 07:47:33PM +, Will Deacon wrote: > On Tue, Jan 09, 2018 at 10:21:29AM +, Will Deacon wrote: > > On Mon, Jan 08, 2018 at 10:49:01AM -0800, Linus Torvalds wrote: > > > In this particular case, we should be very much aware of future CPU's > > > being more

Re: [BUG iproute2] ip tuntap show

David Ahern wrote: > On 1/31/18 10:21 AM, Serhey Popovych wrote: >> Eric Dumazet wrote: >>> ip tuntap enumerates devices using /sys/class/net which is unusual. >>> >>> Should we replace this enumeration using /proc/net/dev like "ip tunnel" ? >>> >>> After "unshare -n" maybe mounting /sys should

Re: PA Semi PWRficient Gigabit Ethernet doesn't work anymore since the first networking updates for the kernel 4.16

Yes, you can. Christian On 05 February 2018 at 3:29PM, Andrew Lunn wrote: On Mon, Feb 05, 2018 at 10:38:34AM +0100, Christian Zigotzky wrote: Hello Andrew, Many thanks for your patch. I compiled the latest git kernel today and the PA Semi PWRficient Gigabit Ethernet works with your patch.

Re: [PATCH] net: phy-micrel: remove redundant initialization of pointer of_node

On Mon, Feb 05, 2018 at 12:47:59PM +, Colin King wrote: > From: Colin Ian King > > Pointer of_node is initialized with a value that is never read, of_node > is later updated with a new value instead, hence the initialization is > redundant and can be removed. Also

[PATCH 1/1] tcp: Honor the eor bit in tcp_mtu_probe

Avoid SKB coalescing if eor bit is set in one of the relevant SKBs. Fixes: c134ecb87817 ("tcp: Make use of MSG_EOR in tcp_sendmsg") Signed-off-by: Ilya Lesokhin --- net/ipv4/tcp_output.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/net/ipv4/tcp_output.c

Re: [PATCH net] dwc-xlgmac: remove Jie Deng as co-maintainer

From: Jie Deng Date: Mon, 5 Feb 2018 11:31:27 +0800 > Jose Abreu is working on this driver and I will leave Synopsys soon. > Thus it does not seem appropriate for me to be a co-maintainer anymore. > > Signed-off-by: Jie Deng Applied.

Re: [PATCH] doc: Change the min default value of tcp_wmem/tcp_rmem.

From: Tonghao Zhang Date: Sun, 4 Feb 2018 18:07:10 -0800 > The SK_MEM_QUANTUM was changed from PAGE_SIZE to 4096. And the > tcp_wmem/tcp_rmem min default values are 4096. > > Fixes: bd68a2a854ad ("net: set SK_MEM_QUANTUM to 4096") > Cc: Eric Dumazet

Re: [RFC PATCH 00/24] Introducing AF_XDP support

2018-01-31 14:53 GMT+01:00 Björn Töpel : > From: Björn Töpel > > This RFC introduces a new address family called AF_XDP that is > optimized for high performance packet processing and zero-copy > semantics. Throughput improvements can be up to 20x

Re: [PATCH v2] socket: Provide put_cmsg_whitelist() for constant size copies

From: Kees Cook Date: Fri, 2 Feb 2018 02:27:49 -0800 > @@ -343,6 +343,14 @@ struct ucred { > > extern int move_addr_to_kernel(void __user *uaddr, int ulen, struct > sockaddr_storage *kaddr); > extern int put_cmsg(struct msghdr*, int level, int type, int len, void >

Re: [PATCH net v2] sctp: fix dst refcnt leak in sctp_v4_get_dst

From: Tommi Rantala Date: Mon, 5 Feb 2018 15:33:11 +0200 > Fixes: 410f03831 ("sctp: add routing output fallback") > Signed-off-by: Tommi Rantala I would add another Fixes tag mentioning commit:

Re: PA Semi PWRficient Gigabit Ethernet doesn't work anymore since the first networking updates for the kernel 4.16

On Mon, Feb 05, 2018 at 10:38:34AM +0100, Christian Zigotzky wrote: > Hello Andrew, > > Many thanks for your patch. I compiled the latest git kernel today and the > PA Semi PWRficient Gigabit Ethernet works with your patch. Great. Can i add a tested-by: Thanks Andrew

Re: possible deadlock in rtnl_lock (2)

syzbot wrote: #syz-fix: netfilter: on sockopt() acquire sock lock only in the required scope

Re: RFC(V3): Audit Kernel Container IDs

On Fri, 2018-02-02 at 18:24 -0500, Paul Moore wrote: > On Fri, Feb 2, 2018 at 5:19 PM, Simo Sorce wrote: > > On Fri, 2018-02-02 at 16:24 -0500, Paul Moore wrote: > > > On Wed, Jan 10, 2018 at 2:00 AM, Richard Guy Briggs > > > wrote: > > > > On 2018-01-09 11:18,

Re: [RFC PATCH 05/24] bpf: added bpf_xdpsk_redirect

On Wed, 31 Jan 2018 14:53:37 +0100 Björn Töpel wrote: > The bpf_xdpsk_redirect call redirects the XDP context to the XDP > socket bound to the receiving queue (if any). As I explained in-person at FOSDEM, my suggestion is to use the bpf-map infrastructure for AF_XDP

Re: [PATCH 1/3] net: stmmac: dwmac-sun8i: drop V3s compatible and add V3 one

Hi, On Sat, Feb 03, 2018 at 03:23:28PM +0800, Icenowy Zheng wrote: > 于 2018年2月3日 GMT+08:00 上午6:13:01, Maxime Ripard 写到: > >On Sat, Feb 03, 2018 at 02:04:54AM +0800, Icenowy Zheng wrote: > >> The V3s is just a differently packaged version of the V3 chip, which > >has >

[PATCH] qlcnic: remove redundant initializations to pointers vh and nf

From: Colin Ian King Pointer vh is initialized however the value is never read as it is re-assigned inside an if-statement. Move the declaration to inside the if-statement and remove the extraneous initialization. Similarly, pointer nf is being initialized and the

[PATCH net v2] sctp: fix dst refcnt leak in sctp_v4_get_dst

Fix dst reference count leak in sctp_v4_get_dst() introduced in commit 410f03831 ("sctp: add routing output fallback"): When walking the address_list, successive ip_route_output_key() calls may return the same rt->dst with the reference incremented on each call. The code would not decrement the

Re: [PATCH iproute2-next 08/10] rdma: Add QP resource tracking information

On Thu, Feb 01, 2018 at 02:05:08PM -0600, Steve Wise wrote: > Hey Leon, <...> > > > +static int res_qp_parse_cb(const struct nlmsghdr *nlh, void *data) > > +{ <...> > > + > > + mnl_attr_for_each_nested(nla_entry, nla_table) { > > + struct nlattr *nla_line[RDMA_NLDEV_ATTR_MAX] = {};

[PATCH] net: phy-micrel: remove redundant initialization of pointer of_node

From: Colin Ian King Pointer of_node is initialized with a value that is never read, of_node is later updated with a new value instead, hence the initialization is redundant and can be removed. Also remove unused pointer dev and remove an empty line. Cleans up clang

Re: [PATCH] sctp: fix dst refcnt leak in sctp_v6_get_dst()

On Mon, Feb 05, 2018 at 03:10:35PM +0300, Alexey Kodanev wrote: > When going through the bind address list in sctp_v6_get_dst() and > the previously found address is better ('matchlen > bmatchlen'), > the code continues to the next iteration without releasing currently > held destination. > > Fix

[PATCH] sctp: fix dst refcnt leak in sctp_v6_get_dst()

When going through the bind address list in sctp_v6_get_dst() and the previously found address is better ('matchlen > bmatchlen'), the code continues to the next iteration without releasing currently held destination. Fix it by releasing 'bdst' before continue to the next iteration, and instead

PA Semi PWRficient Gigabit Ethernet doesn't work anymore since the first networking updates for the kernel 4.16

Hello Andrew, Many thanks for your patch. I compiled the latest git kernel today and the PA Semi PWRficient Gigabit Ethernet works with your patch. Have a nice week! Thanks, Christian On 04 February 2018 at 6:16PM, Andrew Lunn wrote: > On Sun, Feb 04, 2018 at 05:47:03PM +0100, Christian

[PATCH net v3] cls_u32: fix use after free in u32_destroy_key()

Li Shuang reported an Oops with cls_u32 due to an use-after-free in u32_destroy_key(). The use-after-free can be triggered with: dev=lo tc qdisc add dev $dev root handle 1: htb default 10 tc filter add dev $dev parent 1: prio 5 handle 1: protocol ip u32 divisor 256 tc filter add dev $dev protocol

Re: [PATCH net] sctp: fix dst reference leak in sctp_v4_get_dst

On 05.02.2018 03:01, Marcelo Ricardo Leitner wrote: Hi, On Sun, Feb 04, 2018 at 11:02:39AM +0200, Tommi Rantala wrote: Fix dst reference leak in sctp_v4_get_dst() introduced in commit 410f03831 ("sctp: add routing output fallback"): When walking the address_list, successive