Re: [PATCH 0/4] tree-wide: fix comparison to bitshift when dealing with a mask

2018-02-06 Thread Geert Uytterhoeven
Hi Wolfram, On Mon, Feb 5, 2018 at 9:09 PM, Wolfram Sang wrote: > In one Renesas driver, I found a typo which turned an intended bit shift > ('<<') > into a comparison ('<'). Because this is a subtle issue, I looked tree wide > for > similar patterns. This small patch series is the outcome. > >

Re: [PATCH net v3] sctp: fix dst refcnt leak in sctp_v4_get_dst

2018-02-06 Thread Dmitry Vyukov
On Tue, Feb 6, 2018 at 6:06 AM, Xin Long wrote: > On Tue, Feb 6, 2018 at 7:20 AM, David Ahern wrote: >> On 2/5/18 12:48 PM, Tommi Rantala wrote: >>> Fix dst reference count leak in sctp_v4_get_dst() introduced in commit >>> 410f03831 ("sctp: add routing output fallback"): >>> >>> When walking the

Re: [PATCH 0/4] tree-wide: fix comparison to bitshift when dealing with a mask

2018-02-06 Thread Wolfram Sang
> I found two more using "git grep 'define.*0x[0-9a-f]* < '": I added '[0-9]\+' at the end of the regex to reduce the number of false positives... > drivers/net/can/m_can/m_can.c:#define RXFC_FWM_MASK (0x7f < > RXFC_FWM_SHIFT) > drivers/usb/gadget/udc/goku_udc.h:#define INT_EPnNAK(n) > (0x0

Re: [PATCH v6 19/36] nds32: VDSO support

2018-02-06 Thread Arnd Bergmann
On Tue, Feb 6, 2018 at 8:41 AM, Vincent Chen wrote: > 2018-01-18 18:28 GMT+08:00 Arnd Bergmann : >> On Mon, Jan 15, 2018 at 6:53 AM, Greentime Hu wrote: >>> From: Greentime Hu >>> >>> This patch adds VDSO support. The VDSO code is currently used for >>> sys_rt_sigreturn() and optimised gettimeof

[PATCH] can: m_can: change comparison to bitshift when dealing with a mask

2018-02-06 Thread Wolfram Sang
Due to a typo, the mask was destroyed by a comparison instead of a bit shift. Reported-by: Geert Uytterhoeven Signed-off-by: Wolfram Sang --- Only build tested. drivers/net/can/m_can/m_can.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/can/m_can/m_can.c b/dri

Re: xfrm, ip tunnel: non released device reference upon device unregistration

2018-02-06 Thread Steffen Klassert
Cc Wei Wang On Sun, Feb 04, 2018 at 01:21:18PM +0200, Eyal Birger wrote: > Hi, > > We've encountered a non released device reference upon device > unregistration which seems to stem from xfrm policy code. > > The setup includes: > - an underlay device (e.g. eth0) using IPv4 > - an xfrm IPv6 over

Potential display issue with 88997e4208ae "net/8021q: create device with all possible features in wanted_features"

2018-02-06 Thread Yunsheng Lin
Hi, all During testing, below cmd is used to add a vlan dev. vconfig add eth0 1000 Without the commit 88997e4208ae(I revert the patch in the latest net-next) ethtool -k eth0 | grep rx-checksumming rx-checksumming: on ethtool -k eth0.1000 | grep rx-checksumming rx-checksumming: on [fixed] ethto

Re: xfrm, ip tunnel: non released device reference upon device unregistration

2018-02-06 Thread Florian Westphal
Steffen Klassert wrote: > Cc Wei Wang > > On Sun, Feb 04, 2018 at 01:21:18PM +0200, Eyal Birger wrote: > > Hi, > > > > We've encountered a non released device reference upon device > > unregistration which seems to stem from xfrm policy code. > > > > The setup includes: > > - an underlay device

Re: [PATCH bpf] tools/bpf: fix batch-mode test failure of test_xdp_redirect.sh

2018-02-06 Thread Daniel Borkmann
On 02/06/2018 01:25 AM, Yonghong Song wrote: > The tests at tools/testing/selftests/bpf can run in patch mode, e.g., > make -C tools/testing/selftests/bpf run_tests > > With the batch mode, I experimented intermittent test failure of > test_xdp_redirect.sh. > > selftests: test_xdp

Re: xfrm, ip tunnel: non released device reference upon device unregistration

2018-02-06 Thread Eyal Birger
Hi Steffen, On Tue, 6 Feb 2018 09:53:38 +0100 Steffen Klassert wrote: > Cc Wei Wang > > On Sun, Feb 04, 2018 at 01:21:18PM +0200, Eyal Birger wrote: > > Hi, > > > > We've encountered a non released device reference upon device > > unregistration which seems to stem from xfrm policy code. > >

Re: [PATCH net 1/1 v2] rtnetlink: require unique netns identifier

2018-02-06 Thread Kirill Tkhai
Hi, Christian, On 06.02.2018 02:24, Christian Brauner wrote: > On Tue, Feb 06, 2018 at 12:47:46AM +0300, Kirill Tkhai wrote: >> On 05.02.2018 18:55, Christian Brauner wrote: >>> Since we've added support for IFLA_IF_NETNSID for RTM_{DEL,GET,SET,NEW}LINK >>> it is possible for userspace to send us

Re: Potential issue with f5e64032a799 "net: phy: fix resume handling"

2018-02-06 Thread Russell King - ARM Linux
On Mon, Feb 05, 2018 at 10:48:55PM +0100, Heiner Kallweit wrote: > Am 04.02.2018 um 03:48 schrieb Florian Fainelli: > > > > > > On 02/03/2018 03:58 PM, Heiner Kallweit wrote: > >> Am 03.02.2018 um 21:17 schrieb Andrew Lunn: > >>> On Sat, Feb 03, 2018 at 05:41:54PM +0100, Heiner Kallweit wrote: >

Re: [bpf PATCH v4 0/3] bpf: sockmap fixes

2018-02-06 Thread Daniel Borkmann
On 02/05/2018 07:17 PM, John Fastabend wrote: > A set of fixes for sockmap to resolve programs referencing sockmaps > and closing without deleting all entries in the map and/or not detaching > BPF programs attached to the map. Both leaving entries in the map and > not detaching programs may result

[PATCH 1/2] net, can, ifi: fix "write buffer full" error

2018-02-06 Thread Heiko Schocher
the driver reads in the ISR first the IRQpending register, and clears after that in a write *all* bits in it. It could happen that the isr register raise bits between this 2 register accesses, which leads in lost bits ... In case it clears "TX message sent successfully", the driver never sends an

[PATCH 2/2] net, can, ifi: loopback Tx message in IFI block

2018-02-06 Thread Heiko Schocher
Current ifi driver reads first Rx messages, than loopback the Tx message, if the IFI_CANFD_INTERRUPT_TXFIFO_REMOVE bit is set. This can lead into the case, that Rx messages overhelm Tx messages! Fixed this in the following way: Set in the IFI_CANFD_TXFIFO_DLC register the FN value to 1, so the IF

Re: [PATCH net 1/1 v2] rtnetlink: require unique netns identifier

2018-02-06 Thread Christian Brauner
On Tue, Feb 06, 2018 at 01:49:10PM +0300, Kirill Tkhai wrote: > Hi, Christian, > > On 06.02.2018 02:24, Christian Brauner wrote: > > On Tue, Feb 06, 2018 at 12:47:46AM +0300, Kirill Tkhai wrote: > >> On 05.02.2018 18:55, Christian Brauner wrote: > >>> Since we've added support for IFLA_IF_NETNSID

Re: [Patch net v2] xt_RATEEST: acquire xt_rateest_mutex for hash insert

2018-02-06 Thread Pablo Neira Ayuso
On Mon, Feb 05, 2018 at 02:41:45PM -0800, Cong Wang wrote: > rateest_hash is supposed to be protected by xt_rateest_mutex, > and, as suggested by Eric, lookup and insert should be atomic, > so we should acquire the xt_rateest_mutex once for both. > > So introduce a non-locking helper for internal

Re: [bpf PATCH v4 1/3] net: add a UID to use for ULP socket assignment

2018-02-06 Thread Daniel Borkmann
On 02/05/2018 07:17 PM, John Fastabend wrote: [...] > @@ -124,6 +145,34 @@ int tcp_set_ulp(struct sock *sk, const char *name) > if (!ulp_ops) > return -ENOENT; > > + if (!ulp_ops->user_visible) { > + module_put(ulp_ops->owner); > + return -ENOENT; >

Re: [PATCH 1/2] net, can, ifi: fix "write buffer full" error

2018-02-06 Thread Marek Vasut
On 02/06/2018 01:02 PM, Heiko Schocher wrote: > the driver reads in the ISR first the IRQpending register, > and clears after that in a write *all* bits in it. > > It could happen that the isr register raise bits between > this 2 register accesses, which leads in lost bits ... > > In case it clea

Re: [PATCH 2/2] net, can, ifi: loopback Tx message in IFI block

2018-02-06 Thread Marek Vasut
On 02/06/2018 01:02 PM, Heiko Schocher wrote: > Current ifi driver reads first Rx messages, than loopback > the Tx message, if the IFI_CANFD_INTERRUPT_TXFIFO_REMOVE > bit is set. This can lead into the case, that Rx messages > overhelm Tx messages! > > Fixed this in the following way: > > Set in

Re: Potential issue with f5e64032a799 "net: phy: fix resume handling"

2018-02-06 Thread Andrew Lunn
> Maybe a better solution now would be to restore phy_resume()'s lock- > taking behaviour, and provide a lockless __phy_resume() which can be > used internally within phylib. This means drivers using phy_resume() > would see no change. Maybe something like (untested): Hi Russell I was thinking

Re: xfrm, ip tunnel: non released device reference upon device unregistration

2018-02-06 Thread Florian Westphal
Eyal Birger wrote: > Hi, > > We've encountered a non released device reference upon device > unregistration which seems to stem from xfrm policy code. > > The setup includes: > - an underlay device (e.g. eth0) using IPv4 > - an xfrm IPv6 over IPv4 tunnel routed via the underlay device > - an ipi

Re: Please apply these tiny, 4-month-old patches.

2018-02-06 Thread Andrew Lunn
> However, I'm fully versed on the scripture. > > I'm glad to report that the patches apply cleanly to `net-next'; the > actual patches are, of course, still available in my previous emails. > Also, as already described, they can be easily fetched from GitHub. > > Sincerely, > Michael Witten Hi

[PATCH 3/3] arm64: dts: renesas: r8a77995: Remove non-existing STBE region

2018-02-06 Thread Geert Uytterhoeven
R-Car D3 does not have the Stream Buffer for EtherAVB-IF (STBE). Note that the RAVB driver does not use this region. Fixes: f9ba0c4cfe6169b7 ("arm64: dts: renesas: r8a77995: Add EthernetAVB device node") Signed-off-by: Geert Uytterhoeven --- arch/arm64/boot/dts/renesas/r8a77995.dtsi | 2 +- 1

[PATCH 2/3] arm64: dts: renesas: r8a77970: Remove non-existing STBE region

2018-02-06 Thread Geert Uytterhoeven
R-Car V3M does not have the Stream Buffer for EtherAVB-IF (STBE). Note that the RAVB driver does not use this region. Fixes: bea2ab136eaacec2 ("arm64: dts: renesas: r8a77970: add EtherAVB support") Signed-off-by: Geert Uytterhoeven --- arch/arm64/boot/dts/renesas/r8a77970.dtsi | 2 +- 1 file ch

[PATCH 0/3] arm64: dts: renesas: r8a77970/r8a77995: Remove non-existing STBE region

2018-02-06 Thread Geert Uytterhoeven
Hi all, The Stream Buffer for EtherAVB-IF (STBE) is an optional component, and is not present on all R-Car Gen3 SoCs. This patches series documents this in the DT bindings, and removes the non-existing regions from the affected DTS files. Note that this region is apparently not used by t

[PATCH 1/3] dt-bindings: net: renesas-ravb: Make stream buffer optional

2018-02-06 Thread Geert Uytterhoeven
The Stream Buffer for EtherAVB-IF (STBE) is an optional component, and is not present on all SoCs. Document this in the DT bindings, including a list of SoCs that do have it. Fixes: 785ec87483d1e24a ("ravb: document R8A77970 bindings") Fixes: f231c4178a655b09 ("dt-bindings: net: renesas-ravb: Add

Re: xfrm, ip tunnel: non released device reference upon device unregistration

2018-02-06 Thread Steffen Klassert
On Tue, Feb 06, 2018 at 01:56:24PM +0100, Florian Westphal wrote: > Eyal Birger wrote: > > Hi, > > > > We've encountered a non released device reference upon device > > unregistration which seems to stem from xfrm policy code. > > > > The setup includes: > > - an underlay device (e.g. eth0) usin

Re: [PATCH 0/4] tree-wide: fix comparison to bitshift when dealing with a mask

2018-02-06 Thread Dan Carpenter
On Mon, Feb 05, 2018 at 09:09:57PM +0100, Wolfram Sang wrote: > In one Renesas driver, I found a typo which turned an intended bit shift > ('<<') > into a comparison ('<'). Because this is a subtle issue, I looked tree wide > for > similar patterns. This small patch series is the outcome. > > Bu

Re: [PATCH 0/4] tree-wide: fix comparison to bitshift when dealing with a mask

2018-02-06 Thread Julia Lawall
On Tue, 6 Feb 2018, Dan Carpenter wrote: > On Mon, Feb 05, 2018 at 09:09:57PM +0100, Wolfram Sang wrote: > > In one Renesas driver, I found a typo which turned an intended bit shift > > ('<<') > > into a comparison ('<'). Because this is a subtle issue, I looked tree wide > > for > > similar p

Re: [PATCH 1/3] dt-bindings: net: renesas-ravb: Make stream buffer optional

2018-02-06 Thread Simon Horman
On Tue, Feb 06, 2018 at 02:05:52PM +0100, Geert Uytterhoeven wrote: > The Stream Buffer for EtherAVB-IF (STBE) is an optional component, and > is not present on all SoCs. > > Document this in the DT bindings, including a list of SoCs that do have > it. > > Fixes: 785ec87483d1e24a ("ravb: document

Re: xfrm, ip tunnel: non released device reference upon device unregistration

2018-02-06 Thread Florian Westphal
Steffen Klassert wrote: > I gave the patch a quick try, but still I get this: > > unregister_netdevice: waiting for dummy1 to become free. Usage count = 2 Was that with Eyals setup or the bridge one I posted? If it was Eyals setup, its possible the patch missed hookup to whatever tunnel infra i

[PATCH net 0/1 v3] rtnetlink: require unique netns identifier

2018-02-06 Thread Christian Brauner
Hey, Since we've added support for IFLA_IF_NETNSID for RTM_{DEL,GET,SET,NEW}LINK it is possible for userspace to send us requests with three different properties to identify a target network namespace. This affects at least RTM_{NEW,SET}LINK. Each of them could potentially refer to a different net

[PATCH net 1/1 v3] rtnetlink: require unique netns identifier

2018-02-06 Thread Christian Brauner
Since we've added support for IFLA_IF_NETNSID for RTM_{DEL,GET,SET,NEW}LINK it is possible for userspace to send us requests with three different properties to identify a target network namespace. This affects at least RTM_{NEW,SET}LINK. Each of them could potentially refer to a different network n

Re: xfrm, ip tunnel: non released device reference upon device unregistration

2018-02-06 Thread Steffen Klassert
On Tue, Feb 06, 2018 at 02:15:09PM +0100, Florian Westphal wrote: > Steffen Klassert wrote: > > I gave the patch a quick try, but still I get this: > > > > unregister_netdevice: waiting for dummy1 to become free. Usage count = 2 > > Was that with Eyals setup or the bridge one I posted? It was w

Re: [PATCH 0/4] tree-wide: fix comparison to bitshift when dealing with a mask

2018-02-06 Thread Dan Carpenter
On Tue, Feb 06, 2018 at 02:15:51PM +0100, Julia Lawall wrote: > > > On Tue, 6 Feb 2018, Dan Carpenter wrote: > > > On Mon, Feb 05, 2018 at 09:09:57PM +0100, Wolfram Sang wrote: > > > In one Renesas driver, I found a typo which turned an intended bit shift > > > ('<<') > > > into a comparison ('

Re: [PATCH 0/4] tree-wide: fix comparison to bitshift when dealing with a mask

2018-02-06 Thread Julia Lawall
On Tue, 6 Feb 2018, Dan Carpenter wrote: > On Tue, Feb 06, 2018 at 02:15:51PM +0100, Julia Lawall wrote: > > > > > > On Tue, 6 Feb 2018, Dan Carpenter wrote: > > > > > On Mon, Feb 05, 2018 at 09:09:57PM +0100, Wolfram Sang wrote: > > > > In one Renesas driver, I found a typo which turned an inte

[PATCH net] netlink: ensure to loop over all netns in genlmsg_multicast_allns()

2018-02-06 Thread Nicolas Dichtel
Nowadays, nlmsg_multicast() returns only 0 or -ESRCH but this was not the case when commit 134e63756d5f was pushed. However, there was no reason to stop the loop if a netns does not have listeners. Returns -ESRCH only if there was no listeners in all netns. To avoid having the same problem in the

Re: [PATCH net-next 0/7] tcp: implement rb-tree based retransmit queue

2018-02-06 Thread Tal Gilboa
On 1/24/2018 5:09 PM, Eric Dumazet wrote: On Wed, 2018-01-24 at 16:42 +0200, Tal Gilboa wrote: Hi Eric, My choice of words in my comment was misplaced, and I apologies. It completely missed the point. I understand, of course, the importance of optimizing real-life scenarios. We are currently ev

Re: [PATCH 0/4] tree-wide: fix comparison to bitshift when dealing with a mask

2018-02-06 Thread Wolfram Sang
Hi Julia, > and got the results below. I can make a version for the kernel shortly. It should probably take care of right-shifting, too? Thanks, Wolfram signature.asc Description: PGP signature

Re: [PATCH 0/4] tree-wide: fix comparison to bitshift when dealing with a mask

2018-02-06 Thread Julia Lawall
On Tue, 6 Feb 2018, Wolfram Sang wrote: > Hi Julia, > > > and got the results below. I can make a version for the kernel shortly. > > It should probably take care of right-shifting, too? I did that too but got no results. Perhaps right shifting constants is pretty uncommon. I can put that in

Re: [PATCH 0/4] tree-wide: fix comparison to bitshift when dealing with a mask

2018-02-06 Thread Wolfram Sang
> I did that too but got no results. Perhaps right shifting constants is > pretty uncommon. I can put that in the complete rule though. Please do. Even if rare, we would want this bug pointed out, right? :) signature.asc Description: PGP signature

Re: [PATCH 0/4] tree-wide: fix comparison to bitshift when dealing with a mask

2018-02-06 Thread Dan Carpenter
That found 4 that I think Wolfram's grep missed. arch/um/drivers/vector_user.h |2 -- drivers/gpu/drm/mxsfb/mxsfb_regs.h|2 -- drivers/video/fbdev/mxsfb.c |2 -- include/drm/drm_scdc_helper.h |3 --- But it didn't find the two bugs tha

[PATCH net 2/2] be2net: Handle transmit completion errors in Lancer

2018-02-06 Thread Suresh Reddy
If the driver receives a TX CQE with status as 0x1 or 0x9 or 0xb, the completion indexes should not be used. The driver must stop consuming CQEs from this TXQ/CQ. The TXQ from this point on-wards to be in a bad state. Driver should destroy and recreate the TXQ. 0x1: LANCER_TX_COMP_LSO_ERR 0x9 LANC

[PATCH net 0/2] be2net: patch-set

2018-02-06 Thread Suresh Reddy
Hi Dave, Please consider applying these two patches to net Suresh Reddy (2): be2net: Fix HW stall issue in Lancer be2net: Handle transmit completion errors in Lancer drivers/net/ethernet/emulex/benet/be.h | 7 +- drivers/net/ethernet/emulex/benet/be_ethtool.c | 1 + drivers/net/e

[PATCH net 1/2] be2net: Fix HW stall issue in Lancer

2018-02-06 Thread Suresh Reddy
Lancer HW cannot handle a TSO packet with a single segment. Disable TSO/GSO for such packets. Signed-off-by: Suresh Reddy --- drivers/net/ethernet/emulex/benet/be_main.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers

Re: [PATCH 0/4] tree-wide: fix comparison to bitshift when dealing with a mask

2018-02-06 Thread Julia Lawall
On Tue, 6 Feb 2018, Dan Carpenter wrote: > That found 4 that I think Wolfram's grep missed. > > arch/um/drivers/vector_user.h |2 -- > drivers/gpu/drm/mxsfb/mxsfb_regs.h|2 -- > drivers/video/fbdev/mxsfb.c |2 -- > include/drm/drm_scdc_helper.h

Re: [PATCH net-next 0/7] tcp: implement rb-tree based retransmit queue

2018-02-06 Thread Eric Dumazet
On Tue, Feb 6, 2018 at 5:51 AM, Tal Gilboa wrote: > On 1/24/2018 5:09 PM, Eric Dumazet wrote: >> >> On Wed, 2018-01-24 at 16:42 +0200, Tal Gilboa wrote: >>> >>> Hi Eric, >>> My choice of words in my comment was misplaced, and I apologies. It >>> completely missed the point. I understand, of course

[bpf-next V2 PATCH 1/5] bpf: Sync kernel ABI header with tooling header for bpf_common.h

2018-02-06 Thread Jesper Dangaard Brouer
I recently fixed up a lot of commits that forgot to keep the tooling headers in sync. And then I forgot to do the same thing in commit cb5f7334d479 ("bpf: add comments to BPF ld/ldx sizes"). Let correct that before people notice ;-). Lawrence did partly fix/sync this for bpf.h in commit d6d4f60c3

[bpf-next V2 PATCH 2/5] tools/libbpf: improve the pr_debug statements to contain section numbers

2018-02-06 Thread Jesper Dangaard Brouer
While debugging a bpf ELF loading issue, I needed to correlate the ELF section number with the failed relocation section reference. Thus, add section numbers/index to the pr_debug. In debug mode, also print section that were skipped. This helped me identify that a section (.eh_frame) was skipped,

[bpf-next V2 PATCH 0/5] tools/libbpf improvements and selftests

2018-02-06 Thread Jesper Dangaard Brouer
While playing with using libbpf for the Suricata project, we had issues LLVM >= 4.0.1 generating ELF files that could not be loaded with libbpf (tools/lib/bpf/). During the troubleshooting phase, I wrote a test program and improved the debugging output in libbpf. I turned this into a selftests pr

[bpf-next V2 PATCH 5/5] tools/libbpf: handle issues with bpf ELF objects containing .eh_frames

2018-02-06 Thread Jesper Dangaard Brouer
If clang >= 4.0.1 is missing the option '-target bpf', it will cause llc/llvm to create two ELF sections for "Exception Frames", with section names '.eh_frame' and '.rel.eh_frame'. The BPF ELF loader library libbpf fails when loading files with these sections. The other in-kernel BPF ELF loader i

[bpf-next V2 PATCH 4/5] selftests/bpf: add selftest that use test_libbpf_open

2018-02-06 Thread Jesper Dangaard Brouer
This script test_libbpf.sh will be part of the 'make run_tests' invocation, but can also be invoked manually in this directory, and a verbose mode can be enabled via setting the environment variable $VERBOSE like: $ VERBOSE=yes ./test_libbpf.sh The script contains some tests that are commented o

[bpf-next V2 PATCH 3/5] selftests/bpf: add test program for loading BPF ELF files

2018-02-06 Thread Jesper Dangaard Brouer
V2: Moved program into selftests/bpf from tools/libbpf This program can be used on its own for testing/debugging if a BPF ELF-object file can be loaded with libbpf (from tools/lib/bpf). If something is wrong with the ELF object, the program have a --debug mode that will display the ELF sections a

Re: [PATCH 1/3] dt-bindings: net: renesas-ravb: Make stream buffer optional

2018-02-06 Thread Sergei Shtylyov
On 02/06/2018 04:05 PM, Geert Uytterhoeven wrote: > The Stream Buffer for EtherAVB-IF (STBE) is an optional component, and > is not present on all SoCs. > > Document this in the DT bindings, including a list of SoCs that do have > it. > > Fixes: 785ec87483d1e24a ("ravb: document R8A77970 binding

Re: [regresssion 4.15] Userspace compilation broken by uapi/linux/if_ether.h update

2018-02-06 Thread Guillaume Nault
On Fri, Jan 26, 2018 at 11:51:38AM +0100, Guillaume Nault wrote: > On Thu, Jan 25, 2018 at 11:21:34PM +0100, Hauke Mehrtens wrote: > > On 01/25/2018 03:58 PM, Guillaume Nault wrote: > > > Hi, > > > > > > Commit 6926e041a892 ("uapi/if_ether.h: prevent redefinition of struct > > > ethhdr"), > > > c

Re: [PATCH 1/3] dt-bindings: net: renesas-ravb: Make stream buffer optional

2018-02-06 Thread Geert Uytterhoeven
Hi Sergei, On Tue, Feb 6, 2018 at 3:56 PM, Sergei Shtylyov wrote: > On 02/06/2018 04:05 PM, Geert Uytterhoeven wrote: >> The Stream Buffer for EtherAVB-IF (STBE) is an optional component, and >> is not present on all SoCs. >> >> Document this in the DT bindings, including a list of SoCs that do h

[PATCH iproute2] ip netns: allow negative nsid

2018-02-06 Thread Christian Brauner
If the kernel receives a negative nsid it will automatically assign the next available nsid. In this case alloc_netid() will set min and max to 0 for ird_alloc(). And when max == 0 idr_alloc() will interpret this as the maxium range, i.e. specific to nsids it will try to find an id in the range [0,

Re: [PATCH] Carrier detect ok, don't turn off negotiation

2018-02-06 Thread Denis Du
Hi, David: How  do you think my patch? As you see, Krzysztof  think my patch is ok to be accepted. But if you have a better idea to fix it,I am glad to see it. Anyway, this issue have to be fixed. Denis DU On Sunday, January 28, 2018, 9:34:15 AM EST, Krzysztof Halasa wrote: Den

RE: [PATCH net-next 0/7] tcp: implement rb-tree based retransmit queue

2018-02-06 Thread David Laight
From: Eric Dumazet > Sent: 06 February 2018 14:20 ... > Please give exact details. > Sending 64, 128, 256 or 512 bytes at a time on TCP_STREAM makes little sense. > We are not optimizing stack for pathological cases, sorry. There are plenty of workloads which are not bulk data and where multiple s

[PATCH v1 1/1] spi_ks8995: use regmap to access chip registers.

2018-02-06 Thread Sven Van Asbroeck
The register map layouts used in this driver are well suited to being accessed through a regmap. This makes the driver simpler and shorter, by eliminating some spi boilerplate code. Testing: - tested on a ksz8785. - not tested on the other supported chips (ks8995, ksz8864) because I don't have a

[PATCH v1 0/1] spi_ks8995: use regmap to access chip registers.

2018-02-06 Thread Sven Van Asbroeck
v1: starting point. is there a way to test-run this on supported devices that I don't have physical access to - (ks8995, ksz8864) ? Sven Van Asbroeck (1): spi_ks8995: use regmap to access chip registers. drivers/net/phy/spi_ks8995.c | 163 +--

Re: [PATCH] Carrier detect ok, don't turn off negotiation

2018-02-06 Thread David Miller
From: Denis Du Date: Tue, 6 Feb 2018 15:15:28 + (UTC) > How  do you think my patch? > > As you see, Krzysztof  think my patch is ok to be accepted. > But if you have a better idea to fix it,I am glad to see it. Anyway, this > issue have to be fixed. Please resubmit it and I'll think about

Re: [PATCH net-next 0/7] tcp: implement rb-tree based retransmit queue

2018-02-06 Thread Eric Dumazet
On Tue, 2018-02-06 at 15:22 +, David Laight wrote: > From: Eric Dumazet > > Sent: 06 February 2018 14:20 > > ... > > Please give exact details. > > Sending 64, 128, 256 or 512 bytes at a time on TCP_STREAM makes little > > sense. > > We are not optimizing stack for pathological cases, sorry.

Re: [bpf-next V2 PATCH 5/5] tools/libbpf: handle issues with bpf ELF objects containing .eh_frames

2018-02-06 Thread Alexei Starovoitov
On Tue, Feb 06, 2018 at 03:54:28PM +0100, Jesper Dangaard Brouer wrote: > If clang >= 4.0.1 is missing the option '-target bpf', it will cause > llc/llvm to create two ELF sections for "Exception Frames", with > section names '.eh_frame' and '.rel.eh_frame'. > > The BPF ELF loader library libbpf f

Re: [PATCH v2] net: sched: tbf: handle GSO_BY_FRAGS case in enqueue

2018-02-06 Thread David Miller
From: Daniel Axtens Date: Mon, 5 Feb 2018 15:02:06 +1100 > tbf_enqueue() checks the size of a packet before enqueuing it. > However, the GSO size check does not consider the GSO_BY_FRAGS > case, and so will drop GSO SCTP packets, causing a massive drop > in throughput. > > Use skb_gso_validate_

Re: [PATCH v1 0/1] spi_ks8995: use regmap to access chip registers.

2018-02-06 Thread Andrew Lunn
On Tue, Feb 06, 2018 at 10:13:55AM -0500, Sven Van Asbroeck wrote: > v1: > starting point. > is there a way to test-run this on supported devices that I don't > have physical access to - (ks8995, ksz8864) ? > > Sven Van Asbroeck (1): > spi_ks8995: use regmap to access c

Re: Regression in 39461af74125 "bitmap: replace bitmap_{from,to}_u32array"

2018-02-06 Thread David Miller
From: Heiner Kallweit Date: Mon, 5 Feb 2018 07:21:32 +0100 > Recently ethtool started to give incomplete values for supported and > advertised modes. There seems to be a regression in this commit: > The bit number parameter in the calls to bitmap_to_arr32() in > store_link_ksettings_for_user() sh

Re: [PATCH v2] socket: Provide put_cmsg_whitelist() for constant size copies

2018-02-06 Thread David Miller
From: Kees Cook Date: Tue, 6 Feb 2018 04:31:50 +1100 > On Tue, Feb 6, 2018 at 2:03 AM, David Miller wrote: >> From: Kees Cook >> Date: Fri, 2 Feb 2018 02:27:49 -0800 >> >>> @@ -343,6 +343,14 @@ struct ucred { >>> >>> extern int move_addr_to_kernel(void __user *uaddr, int ulen, struct >>> sock

Re: [PATCH net] net: phy: Handle not having GPIO enabled in the kernel

2018-02-06 Thread David Miller
From: Andrew Lunn Date: Mon, 5 Feb 2018 19:17:23 +0100 > If CONFIG_GPIOLIB is disabled, fwnode_get_named_gpiod() becomes a stub > function, which return -ENOSYS. Handle this in the same way as > -ENOENT, i.e. assume there is no GPIO used to reset the PHYs. > > Reported-by: Christian Zigotzky >

Re: [PATCH v2 1/1] tcp: Honor the eor bit in tcp_mtu_probe

2018-02-06 Thread David Miller
From: Ilya Lesokhin Date: Mon, 5 Feb 2018 20:18:32 +0200 > Avoid SKB coalescing if eor bit is set in one of the relevant > SKBs. > > Fixes: c134ecb87817 ("tcp: Make use of MSG_EOR in tcp_sendmsg") > Signed-off-by: Ilya Lesokhin This adds a build warning, please fix: CC net/ipv4/tcp_ou

Re: [PATCH 4/4] net: amd-xgbe: fix comparison to bitshift when dealing with a mask

2018-02-06 Thread David Miller
From: Wolfram Sang Date: Mon, 5 Feb 2018 21:10:01 +0100 > Due to a typo, the mask was destroyed by a comparison instead of a bit > shift. > > Signed-off-by: Wolfram Sang Applied and queued up for -stable, thanks.

Re: Regression in 39461af74125 "bitmap: replace bitmap_{from,to}_u32array"

2018-02-06 Thread Yury Norov
On Tue, Feb 06, 2018 at 11:17:36AM -0500, David Miller wrote: > From: Heiner Kallweit > Date: Mon, 5 Feb 2018 07:21:32 +0100 > > > Recently ethtool started to give incomplete values for supported and > > advertised modes. There seems to be a regression in this commit: > > The bit number parameter

Re: [PATCH net-next 0/7] tcp: implement rb-tree based retransmit queue

2018-02-06 Thread Tal Gilboa
On 2/6/2018 5:52 PM, Eric Dumazet wrote: On Tue, 2018-02-06 at 15:22 +, David Laight wrote: From: Eric Dumazet Sent: 06 February 2018 14:20 ... Please give exact details. Sending 64, 128, 256 or 512 bytes at a time on TCP_STREAM makes little sense. We are not optimizing stack for patholo

Re: [PATCH net v4] cls_u32: fix use after free in u32_destroy_key()

2018-02-06 Thread David Miller
From: Paolo Abeni Date: Mon, 5 Feb 2018 22:23:01 +0100 > Li Shuang reported an Oops with cls_u32 due to an use-after-free > in u32_destroy_key(). The use-after-free can be triggered with: > > dev=lo > tc qdisc add dev $dev root handle 1: htb default 10 > tc filter add dev $dev parent 1: prio 5

Re: [PATCH net 0/3] net: erspan fixes

2018-02-06 Thread David Miller
From: William Tu Date: Mon, 5 Feb 2018 13:35:33 -0800 > The first patch fixes erspan metadata extraction issue from packet > header due to commit d350a823020e ("net: erspan: create erspan metadata > uapi header"). The commit moves the erspan 'version' in > 'struct erspan_metadata' in front of '

Re: [NetDev-info] Distributed Switch Architecture for 88E6390

2018-02-06 Thread Andrew Lunn
> Let me know if you're interested in any testing. Unfortunately I'm going > to be limited to kernel 4.4.38 though as the tegra BSP would need to be > ported in its entirety (a code-base that I don't control). Hi Dave You might be interested in: https://lkml.org/lkml/2018/2/6/24 Andrew

Re: [PATCH v1 0/1] spi_ks8995: use regmap to access chip registers.

2018-02-06 Thread Sven Van Asbroeck
On Tue, Feb 6, 2018 at 11:14 AM, Andrew Lunn wrote: > Rather than invest time in this driver, it would be better to look > into writing a DSA driver. Thank you Andrew. I know little of DSA, but at first sight it appears to be a _very_ complicated beast for a switch PHY which only needs a few stat

Re: Regression in 39461af74125 "bitmap: replace bitmap_{from,to}_u32array"

2018-02-06 Thread David Miller
From: Yury Norov Date: Tue, 6 Feb 2018 19:26:23 +0300 > On Tue, Feb 06, 2018 at 11:17:36AM -0500, David Miller wrote: >> From: Heiner Kallweit >> Date: Mon, 5 Feb 2018 07:21:32 +0100 >> >> > Recently ethtool started to give incomplete values for supported and >> > advertised modes. There seems

Re: [PATCH net] nfp: fix kdoc warnings on nested structures

2018-02-06 Thread David Miller
From: Jakub Kicinski Date: Mon, 5 Feb 2018 15:29:27 -0800 > Commit 84ce5b987783 ("scripts: kernel-doc: improve nested logic to > handle multiple identifiers") improved the handling of nested structure > definitions in scripts/kernel-doc, and changed the expected format of > documentation. This

[PATCH net] rxrpc: Fix received abort handling

2018-02-06 Thread David Howells
AF_RXRPC is incorrectly sending back to the server any abort it receives for a client connection. This is due to the final-ACK offload to the connection event processor patch. The abort code is copied into the last-call information on the connection channel and then the event processor is set. I

Re: [PATCH v3] RDS: IB: Fix null pointer issue

2018-02-06 Thread David Miller
From: Guanglei Li Date: Tue, 6 Feb 2018 10:43:21 +0800 > Scenario: > 1. Port down and do fail over > 2. Ap do rds_bind syscall ... > PID: 45659 PID: 47039 > rds_ib_laddr_check > /* create id_priv with a null event_handler */ > rdma_create_id > rdma_bind_addr >

Re: [PATCH net 0/2] be2net: patch-set

2018-02-06 Thread David Miller
From: Suresh Reddy Date: Tue, 6 Feb 2018 08:52:40 -0500 > Hi Dave, Please consider applying these two patches to net Series applied, thank you.

Re: [PATCH v1 0/1] spi_ks8995: use regmap to access chip registers.

2018-02-06 Thread Sven Van Asbroeck
On Tue, Feb 6, 2018 at 11:50 AM, Andrew Lunn wrote: > And a DSA driver does not need to be complex. You can start simple, > and add more features later. I see. Would it be possible/practical to start with just phy_read/write, port_enable/disable in dsa_switch_ops ? And just add a sysfs bin file f

Re: Regression in 39461af74125 "bitmap: replace bitmap_{from,to}_u32array"

2018-02-06 Thread Yury Norov
On Tue, Feb 06, 2018 at 11:42:18AM -0500, David Miller wrote: > From: Yury Norov > Date: Tue, 6 Feb 2018 19:26:23 +0300 > > > On Tue, Feb 06, 2018 at 11:17:36AM -0500, David Miller wrote: > >> From: Heiner Kallweit > >> Date: Mon, 5 Feb 2018 07:21:32 +0100 > >> > >> > Recently ethtool started t

Re: [bpf-next V2 PATCH 5/5] tools/libbpf: handle issues with bpf ELF objects containing .eh_frames

2018-02-06 Thread Jesper Dangaard Brouer
On Tue, 6 Feb 2018 08:00:59 -0800 Alexei Starovoitov wrote: > On Tue, Feb 06, 2018 at 03:54:28PM +0100, Jesper Dangaard Brouer wrote: > > If clang >= 4.0.1 is missing the option '-target bpf', it will cause > > llc/llvm to create two ELF sections for "Exception Frames", with > > section names '

Re: [PATCH net-next 0/7] tcp: implement rb-tree based retransmit queue

2018-02-06 Thread Eric Dumazet
On Tue, Feb 6, 2018 at 8:27 AM, Tal Gilboa wrote: > On 2/6/2018 5:52 PM, Eric Dumazet wrote: >> >> On Tue, 2018-02-06 at 15:22 +, David Laight wrote: >>> >>> From: Eric Dumazet Sent: 06 February 2018 14:20 >>> >>> >>> ... Please give exact details. Sending 64, 128, 256

Re: [PATCH] Carrier detect ok, don't turn off negotiation

2018-02-06 Thread Denis Du
Ok, I submit it  again. In drivers/net/wan/hdlc_ppp.c, some noise on physical line can cause the carrier detect still ok, but the protocol will fail. So if carrier detect ok, don't turn off protocol negotiation This patch is against the kernel version Linux 4.15-rc8 On Tuesday, February

Re: [PATCH v1 0/1] spi_ks8995: use regmap to access chip registers.

2018-02-06 Thread Andrew Lunn
On Tue, Feb 06, 2018 at 11:41:14AM -0500, Sven Van Asbroeck wrote: > On Tue, Feb 6, 2018 at 11:14 AM, Andrew Lunn wrote: > > Rather than invest time in this driver, it would be better to look > > into writing a DSA driver. > > Thank you Andrew. I know little of DSA, but at first sight it appears

Re: [PATCH iproute2] ip netns: allow negative nsid

2018-02-06 Thread Stephen Hemminger
On Tue, 6 Feb 2018 16:16:15 +0100 Christian Brauner wrote: > If the kernel receives a negative nsid it will automatically assign the > next available nsid. In this case alloc_netid() will set min and max to > 0 for ird_alloc(). And when max == 0 idr_alloc() will interpret this as > the maxium ra

Re: [PATCH v1 0/1] spi_ks8995: use regmap to access chip registers.

2018-02-06 Thread Florian Fainelli
On 02/06/2018 09:05 AM, Andrew Lunn wrote: > On Tue, Feb 06, 2018 at 11:58:17AM -0500, Sven Van Asbroeck wrote: >> On Tue, Feb 6, 2018 at 11:50 AM, Andrew Lunn wrote: >>> And a DSA driver does not need to be complex. You can start simple, >>> and add more features later. >> >> I see. Would it be p

Re: Regression in 39461af74125 "bitmap: replace bitmap_{from,to}_u32array"

2018-02-06 Thread David Miller
From: Yury Norov Date: Tue, 6 Feb 2018 20:03:13 +0300 > On Tue, Feb 06, 2018 at 11:42:18AM -0500, David Miller wrote: >> From: Yury Norov >> Date: Tue, 6 Feb 2018 19:26:23 +0300 >> >> > On Tue, Feb 06, 2018 at 11:17:36AM -0500, David Miller wrote: >> >> From: Heiner Kallweit >> >> Date: Mon, 5

Re: possible deadlock in rtnl_lock (3)

2018-02-06 Thread Dmitry Vyukov
On Tue, Feb 6, 2018 at 6:58 PM, syzbot wrote: > Hello, > > syzbot hit the following crash on net-next commit > 617aebe6a97efa539cc4b8a52adccd89596e6be0 (Sun Feb 4 00:25:42 2018 +) > Merge tag 'usercopy-v4.16-rc1' of > git://git.kernel.org/pub/scm/linux/kernel/git/kees/linux > > So far this cra

Re: [PATCH v1 0/1] spi_ks8995: use regmap to access chip registers.

2018-02-06 Thread Sven Van Asbroeck
Andrew and Florian, thanks for your input. On Tue, Feb 6, 2018 at 12:05 PM, Andrew Lunn wrote: > I would NACK sysfs bin file. Do it right, or don't do it at all. On Tue, Feb 6, 2018 at 12:47 PM, Florian Fainelli wrote: > Sven, there is a standard ethtool register dump interface that can be > us

Re: [PATCH v2] socket: Provide put_cmsg_whitelist() for constant size copies

2018-02-06 Thread Kees Cook
On Wed, Feb 7, 2018 at 3:19 AM, David Miller wrote: > From: Kees Cook > Date: Tue, 6 Feb 2018 04:31:50 +1100 > >> On Tue, Feb 6, 2018 at 2:03 AM, David Miller wrote: >>> From: Kees Cook >>> Date: Fri, 2 Feb 2018 02:27:49 -0800 >>> @@ -343,6 +343,14 @@ struct ucred { extern int m

[PATCH iproute2 v1] ip netns: allow negative nsid

2018-02-06 Thread Christian Brauner
If the kernel receives a negative nsid it will automatically assign the next available nsid. In this case alloc_netid() will set min and max to 0 for ird_alloc(). And when max == 0 idr_alloc() will interpret this as the maxium range, i.e. specific to nsids it will try to find an id in the range [0,

Re: [PATCH v2] socket: Provide put_cmsg_whitelist() for constant size copies

2018-02-06 Thread David Miller
From: Kees Cook Date: Wed, 7 Feb 2018 05:36:02 +1100 > Making put_cmsg() inline would help quite a bit with tracking the > builtin_const-ness, and that could speed things up a little bit too. > Would you be opposed to inlining? Nope.

Re: [PATCH v1 0/1] spi_ks8995: use regmap to access chip registers.

2018-02-06 Thread Andrew Lunn
On Tue, Feb 06, 2018 at 11:58:17AM -0500, Sven Van Asbroeck wrote: > On Tue, Feb 6, 2018 at 11:50 AM, Andrew Lunn wrote: > > And a DSA driver does not need to be complex. You can start simple, > > and add more features later. > > I see. Would it be possible/practical to start with just phy_read/w

Re: [bpf-next V2 PATCH 5/5] tools/libbpf: handle issues with bpf ELF objects containing .eh_frames

2018-02-06 Thread Daniel Borkmann
On 02/06/2018 06:03 PM, Jesper Dangaard Brouer wrote: > On Tue, 6 Feb 2018 08:00:59 -0800 Alexei Starovoitov > wrote: >> On Tue, Feb 06, 2018 at 03:54:28PM +0100, Jesper Dangaard Brouer wrote: >>> If clang >= 4.0.1 is missing the option '-target bpf', it will cause >>> llc/llvm to create two ELF

Re: xfrm, ip tunnel: non released device reference upon device unregistration

2018-02-06 Thread Eyal Birger
On Tue, 6 Feb 2018 14:15:09 +0100 Florian Westphal wrote: > Steffen Klassert wrote: > > I gave the patch a quick try, but still I get this: > > > > unregister_netdevice: waiting for dummy1 to become free. Usage > > count = 2 > > Was that with Eyals setup or the bridge one I posted? > > If i

  1   2   >