Re: [QUESTION] Mainline support for B43_PHY_AC wifi cards

On 24/03/18 00:01, Rafał Miłecki wrote: > On 23 March 2018 at 15:09, Juri Lelli wrote: > > On 23/03/18 14:43, Rafał Miłecki wrote: > >> Hi, > >> > >> On 23 March 2018 at 10:47, Juri Lelli wrote: > >> > I've got a Dell XPS 13 9343/0TM99H (BIOS A15

[PATCHv2] net/usb/qmi_wwan.c: Add USB id for lt4120 modem

This is needed to support the modem found in HP EliteBook 820 G3. Signed-off-by: Torsten Hilbrich --- drivers/net/usb/qmi_wwan.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c index

Re: possible deadlock in handle_rx

On 2018年03月26日 08:01, syzbot wrote: Hello, syzbot hit the following crash on upstream commit cb6416592bc2a8b731dabcec0d63cda270764fc6 (Sun Mar 25 17:45:10 2018 +) Merge tag 'dmaengine-fix-4.16-rc7' of git://git.kernel.org/pub/scm/linux/kernel/git/vkoul/slave-dma syzbot dashboard link:

Re: [RFC PATCH V2 0/8] Packed ring for vhost

cc Jens, Tiwei and Wei Thanks On 2018年03月26日 11:38, Jason Wang wrote: Hi all: This RFC implement packed ring layout. The code were tested with pmd implement by Jens at http://dpdk.org/ml/archives/dev/2018-January/089417.html. Minor change was needed for pmd codes to kick virtqueue since it

[RFC PATCH V2 1/8] vhost: move get_rx_bufs to vhost.c

Move get_rx_bufs() to vhost.c and rename it to vhost_get_rx_bufs(). This helps to hide vring internal layout from specific device implementation. Packed ring implementation will benefit from this. Signed-off-by: Jason Wang --- drivers/vhost/net.c | 83

[RFC PATCH V2 0/8] Packed ring for vhost

Hi all: This RFC implement packed ring layout. The code were tested with pmd implement by Jens at http://dpdk.org/ml/archives/dev/2018-January/089417.html. Minor change was needed for pmd codes to kick virtqueue since it assumes a busy polling backend. Test were done between localhost and guest.

[RFC PATCH V2 3/8] vhost: do not use vring_used_elem

Instead of depending on the exported vring_used_elem, this patch switches to use a new internal structure vhost_used_elem which embed vring_used_elem in itself. This could be used to let vhost to record extra metadata for the incoming packed ring layout. Signed-off-by: Jason Wang

[RFC PATCH V2 4/8] vhost_net: do not explicitly manipulate vhost_used_elem

Two helpers of setting/getting used len were introduced to avoid explicitly manipulating vhost_used_elem in zerocopy code. This will be used to hide used_elem internals and simplify packed ring implementation. Signed-off-by: Jason Wang --- drivers/vhost/net.c | 11

[RFC PATCH V2 6/8] virtio: introduce packed ring defines

Signed-off-by: Jason Wang --- include/uapi/linux/virtio_config.h | 9 + include/uapi/linux/virtio_ring.h | 13 + 2 files changed, 22 insertions(+) diff --git a/include/uapi/linux/virtio_config.h b/include/uapi/linux/virtio_config.h index

[RFC PATCH V2 5/8] vhost: vhost_put_user() can accept metadata type

We assumes used ring update is the only user for vhost_put_user() in the past. This may not be the case for the incoming packed ring which may update the descriptor ring for used. So introduce a new type parameter. Signed-off-by: Jason Wang --- drivers/vhost/vhost.c | 14

[RFC PATCH V2 8/8] vhost: event suppression for packed ring

This patch introduces basic support for event suppression aka driver and device area. Compile tested only. Signed-off-by: Jason Wang --- drivers/vhost/vhost.c| 169 --- drivers/vhost/vhost.h| 10 ++-

[RFC PATCH V2 7/8] vhost: packed ring support

Signed-off-by: Jason Wang --- drivers/vhost/net.c | 5 +- drivers/vhost/vhost.c | 530 ++ drivers/vhost/vhost.h | 7 +- 3 files changed, 505 insertions(+), 37 deletions(-) diff --git a/drivers/vhost/net.c

[RFC PATCH V2 2/8] vhost: hide used ring layout from device

We used to return descriptor head by vhost_get_vq_desc() to device and pass it back to vhost_add_used() and its friends. This exposes the internal used ring layout to device which makes it hard to be extended for e.g packed ring layout. So this patch tries to hide the used ring layout by -

Re: pull-request: wireless-drivers-next 2018-03-24

From: Kalle Valo Date: Sat, 24 Mar 2018 14:30:01 +0200 > here's the first pull request to net-next for 4.17. What's special here > is the addition of a new bluetooth driver, but that's been acked by > Marcel. Also we add a new include file to include/net because of that. >

Re: pull-request: wireless-drivers 2018-03-24

From: Kalle Valo Date: Sat, 24 Mar 2018 13:03:13 +0200 > This is a pull request to the net tree for 4.16. I'm not planning to > send anything more in this cycle for 4.16, unless something really major > comes up. > > Please let me know if you have any problems. Pulled.

Re: [RFC PATCH net-next] tipc: tipc_disc_addr_trial_msg() can be static

From: kbuild test robot Date: Sat, 24 Mar 2018 03:47:42 +0800 > Fixes: 25b0b9c4e835 ("tipc: handle collisions of 32-bit node address hash > values") > Signed-off-by: Fengguang Wu Applied.

Re: [PATCH net v2] ipv6: the entire IPv6 header chain must fit the first fragment

From: Paolo Abeni Date: Fri, 23 Mar 2018 14:47:30 +0100 > While building ipv6 datagram we currently allow arbitrary large > extheaders, even beyond pmtu size. The syzbot has found a way > to exploit the above to trigger the following splat: ... > As stated by RFC 7112 section

Re: [PATCH] net/usb/qmi_wwan.c: Add USB id for lt4120 modem

From: Torsten Hilbrich Date: Fri, 23 Mar 2018 14:26:18 +0100 > This is needed to support the modem found in HP EliteBook 820 G3. > > Signed-off-by: Torsten Hilbrich This patch was corrupted by your email client, it transformed TAB

Re: [PATCH] netlink: make sure nladdr has correct size in netlink_connect()

From: Alexander Potapenko Date: Fri, 23 Mar 2018 13:49:02 +0100 > KMSAN reports use of uninitialized memory in the case when |alen| is > smaller than sizeof(struct sockaddr_nl), and therefore |nladdr| isn't > fully copied from the userspace. > > Signed-off-by: Alexander

Re: [PATCH net-next] ibmvnic: Potential NULL dereference in clean_one_tx_pool()

From: Dan Carpenter Date: Fri, 23 Mar 2018 14:36:15 +0300 > There is an && vs || typo here, which potentially leads to a NULL > dereference. > > Fixes: e9e1e97884b7 ("ibmvnic: Update TX pool cleaning routine") > Signed-off-by: Dan Carpenter

Re: [PATCH net-next] cxgb4: depend on firmware event for link status

From: Ganesh Goudar Date: Fri, 23 Mar 2018 17:03:10 +0530 > Depend on the firmware sending us link status changes, > rather than assuming that the link goes down upon L1 > configuration. > > Signed-off-by: Casey Leedom > Signed-off-by: Ganesh Goudar

Re: [PATCH net-next] cxgb4: support new ISSI flash parts

From: Ganesh Goudar Date: Fri, 23 Mar 2018 17:05:49 +0530 > Add support for new 32MB and 64MB ISSI (Integrated Silicon > Solution, Inc.) FLASH parts. > > Signed-off-by: Casey Leedom > Signed-off-by: Ganesh Goudar Applied.

Re: [PATCH net-next] cxgb4: copy vlan_id in ndo_get_vf_config

From: Ganesh Goudar Date: Fri, 23 Mar 2018 15:48:46 +0530 > From: Arjun Vynipadath > > Copy vlan_id to get it displayed in vf info. > > Signed-off-by: Arjun Vynipadath > Signed-off-by: Casey Leedom >

Re: [PATCH v1 net] lan78xx: Set ASD in MAC_CR when EEE is enabled.

From: Raghuram Chary J Date: Fri, 23 Mar 2018 15:48:08 +0530 > Description: > EEE does not work with lan7800 when AutoSpeed is not set. > (This can happen when EEPROM is not populated or configured incorrectly) > > Root-Cause: > When EEE is enabled, the

Re: [PATCH V2 net 1/1] net/ipv4: disable SMC TCP option with SYN Cookies

From: Ursula Braun Date: Fri, 23 Mar 2018 11:05:45 +0100 > From: Hans Wippel > > Currently, the SMC experimental TCP option in a SYN packet is lost on > the server side when SYN Cookies are active. However, the corresponding > SYNACK sent

Re: [PATCH net-next] cxgb4: Setup FW queues before registering netdev

From: Ganesh Goudar Date: Fri, 23 Mar 2018 15:25:10 +0530 > From: Arjun Vynipadath > > When NetworkManager is enabled, there are chances that interface up > is called even before probe completes. This means we have not yet > allocated the FW sge queues,

Re: [PATCH net-next 0/2] net: broadcom: Adaptive interrupt coalescing

From: Florian Fainelli Date: Thu, 22 Mar 2018 18:19:31 -0700 > This patch series adds adaptive interrupt coalescing for the Gigabit > Ethernet drivers SYSTEMPORT and GENET. > > This really helps lower the interrupt count and system load, as > measured by vmstat for a

Re: [PATCH v3 net-next 0/2] Fixes to allow mv88e6xxx module to be reloaded

From: Andrew Lunn Date: Sun, 25 Mar 2018 23:43:13 +0200 > As reported by Uwe Kleine-König, the interrupt trigger is first > configured by DT and then reconfigured to edge. This results in a > failure on EPROBE_DEFER, or if the module is unloaded and reloaded. > > A second crash

BUG: unable to handle kernel paging request in smc_ib_remember_port_attr

Hello, syzbot hit the following crash on upstream commit bcfc1f4554662d8f2429ac8bd96064a59c149754 (Sat Mar 24 16:50:12 2018 +) Merge tag 'pinctrl-v4.16-3' of git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl syzbot dashboard link:

general protection fault in tipc_sk_fill_sock_diag

Hello, syzbot hit the following crash on net-next commit 94cb5492409219ee3f9468616dd58af314029f76 (Fri Mar 23 18:31:30 2018 +) net/sched: act_vlan: declare push_vid with host byte order syzbot dashboard link: https://syzkaller.appspot.com/bug?extid=326e587eff1074657718 So far this crash

possible deadlock in handle_rx

Hello, syzbot hit the following crash on upstream commit cb6416592bc2a8b731dabcec0d63cda270764fc6 (Sun Mar 25 17:45:10 2018 +) Merge tag 'dmaengine-fix-4.16-rc7' of git://git.kernel.org/pub/scm/linux/kernel/git/vkoul/slave-dma syzbot dashboard link:

Re: [PATCH net] r8169: fix setting driver_data after register_netdev

On Mon, Mar 26, 2018 at 01:07:00AM +0200, Francois Romieu wrote: > Heiner Kallweit : > > pci_set_drvdata() is called only after registering the net_device, > > therefore we could run into a NPE if one of the functions using > > driver_data is called before it's set. > > > >

Re: [PATCH net] r8169: fix setting driver_data after register_netdev

Heiner Kallweit : > pci_set_drvdata() is called only after registering the net_device, > therefore we could run into a NPE if one of the functions using > driver_data is called before it's set. > > Fix this by calling pci_set_drvdata() before registering the > net_device. >

Re: [PATCH net-next RFC V1 5/5] net: mdio: Add a driver for InES time stamping IP core.

> > in the future some devices will be MDIO, or I2C, or SPI. Just call it > > ptpdev. This ptpdev needs to be control bus agnostic. You need a > > ptpdev core API exposing functions like ptpdev_hwtstamp, > > ptpdev_rxtstamp, ptpdev_txtstamp, ptpdev_link_change, which take a > > ptpdev. > > Well,

Re: [PATCH net-next RFC V1 5/5] net: mdio: Add a driver for InES time stamping IP core.

On 03/25/2018 03:10 PM, Richard Cochran wrote: > On Sun, Mar 25, 2018 at 05:59:37PM +0200, Andrew Lunn wrote: 3) How do you limit the MAC/PHY to what the PTP device can do. >>> >>> Hm, I don't think this is important. >> >> So you are happy that the PTP device will cause the MC/PHY link to

Re: [PATCH net-next RFC V1 5/5] net: mdio: Add a driver for InES time stamping IP core.

> > You can then clean up the code in timestamping.c. Code like: > > > > phydev = skb->dev->phydev; > > if (likely(phydev->drv->txtstamp)) { > > clone = skb_clone_sk(skb); > > if (!clone) > > return; > >

[PATCH net] r8169: fix setting driver_data after register_netdev

pci_set_drvdata() is called only after registering the net_device, therefore we could run into a NPE if one of the functions using driver_data is called before it's set. Fix this by calling pci_set_drvdata() before registering the net_device. This fix is a candidate for stable. As far as I can

linux-next: manual merge of the ipsec tree with the net tree

Hi Steffen, Today's linux-next merge of the ipsec tree got a conflict in: net/ipv4/ip_tunnel.c between commit: f6cc9c054e77 ("ip_tunnel: Emit events for post-register MTU changes") from the net tree and commit: 24fc79798b8d ("ip_tunnel: Clamp MTU to bounds on new link") from the ipsec

Re: [PATCH net-next RFC V1 5/5] net: mdio: Add a driver for InES time stamping IP core.

On Sun, Mar 25, 2018 at 05:59:37PM +0200, Andrew Lunn wrote: > To keep lifecycle issues simple, i would also keep it in phydev, not > netdev. Okay. Since we don't have any representation for MII anyhow, it seems equally fitting to attach this to the PHY's data structure as to the MAC's. Thanks,

Re: [PATCH net-next RFC V1 5/5] net: mdio: Add a driver for InES time stamping IP core.

On Sun, Mar 25, 2018 at 05:59:37PM +0200, Andrew Lunn wrote: > > > 3) How do you limit the MAC/PHY to what the PTP device can do. > > > > Hm, I don't think this is important. > > So you are happy that the PTP device will cause the MC/PHY link to > break down when it is asked to do something it

Re: [PATCH v3 net-next 1/2] net: dsa: mv88e6xxx: Use the DT IRQ trigger mode

Hi Andrew, On Mon, Mar 26, 2018 at 12:02:37AM +0200, Andrew Lunn wrote: > On Sun, Mar 25, 2018 at 11:54:24PM +0200, Uwe Kleine-König wrote: > > On Sun, Mar 25, 2018 at 11:43:14PM +0200, Andrew Lunn wrote: > > > By calling request_threaded_irq() with the flag IRQF_TRIGGER_FALLING > > > we override

Re: [PATCH v3 net-next 1/2] net: dsa: mv88e6xxx: Use the DT IRQ trigger mode

On Sun, Mar 25, 2018 at 11:54:24PM +0200, Uwe Kleine-König wrote: > On Sun, Mar 25, 2018 at 11:43:14PM +0200, Andrew Lunn wrote: > > By calling request_threaded_irq() with the flag IRQF_TRIGGER_FALLING > > we override the trigger mode provided in device tree. And the > > interrupt is actually

Re: [PATCH v3 net-next 1/2] net: dsa: mv88e6xxx: Use the DT IRQ trigger mode

On Sun, Mar 25, 2018 at 11:43:14PM +0200, Andrew Lunn wrote: > By calling request_threaded_irq() with the flag IRQF_TRIGGER_FALLING > we override the trigger mode provided in device tree. And the > interrupt is actually active low, which is what all the current device > tree descriptions use. > >

[PATCH v3 net-next 2/2] net: dsa: mv88e6xxx: Call the common IRQ free code

When free'ing the polled IRQs, call the common irq free code. Otherwise the interrupts are left registered, and when we come to load the driver a second time, we get an Opps. Signed-off-by: Andrew Lunn --- drivers/net/dsa/mv88e6xxx/chip.c | 2 ++ 1 file changed, 2 insertions(+)

[PATCH v3 net-next 1/2] net: dsa: mv88e6xxx: Use the DT IRQ trigger mode

By calling request_threaded_irq() with the flag IRQF_TRIGGER_FALLING we override the trigger mode provided in device tree. And the interrupt is actually active low, which is what all the current device tree descriptions use. Suggested-by: Uwe Kleine-König

[PATCH v3 net-next 0/2] Fixes to allow mv88e6xxx module to be reloaded

As reported by Uwe Kleine-König, the interrupt trigger is first configured by DT and then reconfigured to edge. This results in a failure on EPROBE_DEFER, or if the module is unloaded and reloaded. A second crash happens on module reload due to a missing call to the common IRQ free code when

Re: [PATCH v2 net-next 1/2] net: dsa: mv88e6xxx: Use the DT IRQ trigger mode

On Sun, Mar 25, 2018 at 06:09:11PM -0300, Fabio Estevam wrote: > Hi Andrew, > > On Sun, Mar 25, 2018 at 5:56 PM, Andrew Lunn wrote: > > By calling request_threaded_irq() with the flag IRQF_TRIGGER_FALLING > > we override the trigger mode provided in device tree. And the > >

Re: [PATCH net-next 5/6] r8169: change type of driver_data

Am 25.03.2018 um 22:43 schrieb David Miller: > From: Heiner Kallweit > Date: Sat, 24 Mar 2018 23:18:25 +0100 > >> Several functions accessing the device driver_data field don't need the >> net_device. All needed parameters can be accessed via struct >> rtl8169_private,

[RESEND PATCH net-next 1/1] tc-testing: updated police, mirred, skbedit and skbmod with more tests

Added extra test cases for control actions (reclassify, pipe etc.), cookies, max index value and police args sanity check. Signed-off-by: Roman Mashak --- .../tc-testing/tc-tests/actions/mirred.json| 192 +

Re: [PATCH v2 net-next 1/2] net: dsa: mv88e6xxx: Use the DT IRQ trigger mode

Hi Andrew, On Sun, Mar 25, 2018 at 5:56 PM, Andrew Lunn wrote: > By calling request_threaded_irq() with the flag IRQF_TRIGGER_FALLING > we override the trigger mode provided in device tree. And the > interrupt is actually active low, which is what all the current device > tree

Re: [PATCH net-next,0/2] hv_netvsc: Fix/improve RX path error handling

From: Haiyang Zhang Date: Thu, 22 Mar 2018 12:01:12 -0700 > Fix the status code returned to the host. Also add range > check for rx packet offset and length. Series applied, thank you.

Re: [RESEND PATCH net-next 1/1] tc-testing: updated police, mirred, skbedit and skbmod with more tests

From: Roman Mashak Date: Thu, 22 Mar 2018 15:29:36 -0400 > David Miller writes: > >> From: Roman Mashak >> Date: Thu, 22 Mar 2018 08:23:22 -0400 >> >>> diff --git >>> a/tools/testing/selftests/tc-testing/tc-tests/actions/skbmod.json

Re: [PATCH net-next 1/1] tc-testing: Correct compound statements for namespace execution

From: Lucas Bates Date: Thu, 22 Mar 2018 15:14:58 -0400 > On Thu, Mar 22, 2018 at 2:48 PM, David Miller wrote: >> From: Lucas Bates >> Date: Wed, 21 Mar 2018 11:49:40 -0400 >> >>> } >>> -] >>> \ No newline at end of file >>>

Re: [PATCH] of_net: Implement of_get_nvmem_mac_address helper

> I have no experience with Coccinelle though. Hi Mike I've very little either. But all the interactions i've had with Coccinelle people have been very friendly and helpful. It could be, if you can describe in words what you need help with, they can write the script to do it. Andrew

[PATCH v2 net-next 0/2] Fixes to allow mv88e6xxx module to be reloaded

As reported by Uwe Kleine-Künig, the interrupt trigger is first configured by DT and then reconfigured to edge. This results in a failure on EPROBE_DEFER, or if the module is unloaded and reloaded. A second crash happens on module reload due to a missing call to the common IRQ free code when

[PATCH v2 net-next 2/2] net: dsa: mv88e6xxx: Call the common IRQ free code

When free'ing the polled IRQs, call the common irq free code. Otherwise the interrupts are left registered, and when we come to load the driver a second time, we get an Opps. Signed-off-by: Andrew Lunn --- drivers/net/dsa/mv88e6xxx/chip.c | 2 ++ 1 file changed, 2 insertions(+)

[PATCH v2 net-next 1/2] net: dsa: mv88e6xxx: Use the DT IRQ trigger mode

By calling request_threaded_irq() with the flag IRQF_TRIGGER_FALLING we override the trigger mode provided in device tree. And the interrupt is actually active low, which is what all the current device tree descriptions use. Suggested-by: Uwe Kleine-Künig

Re: [v2] vhost: add vsock compat ioctl

From: Stefan Hajnoczi Date: Thu, 22 Mar 2018 09:25:35 + > On Fri, Mar 16, 2018 at 7:30 PM, David Miller wrote: >> Although the top level ioctls are probably size and layout compatible, >> I do not think that the deeper ioctls can be called by compat

Re: [PATCH net-next v6 0/2] net: permit skb_segment on head_frag frag_list skb

From: Yonghong Song Date: Wed, 21 Mar 2018 16:31:02 -0700 > One of our in-house projects, bpf-based NAT, hits a kernel BUG_ON at > function skb_segment(), line 3667. The bpf program attaches to > clsact ingress, calls bpf_skb_change_proto to change protocol > from ipv4 to ipv6 or

hallo Schönheit

Es ist mir eine Freude, Sie kennenzulernen. Mein Name ist Wesley, ich komme aus dem Vereinigten Staaten von Amerika. Ich bin ledig und nie verheiratet. Ich werde mich gerne mit Ihnen bekannt machen, ich entschuldige mich für Ihre Privatsphäre. Ich hoffe, Sie werden freundlich sein genug, um mir

Re: [PATCH net-next 5/6] r8169: change type of driver_data

From: Heiner Kallweit Date: Sat, 24 Mar 2018 23:18:25 +0100 > Several functions accessing the device driver_data field don't need the > net_device. All needed parameters can be accessed via struct > rtl8169_private, therefore change type of driver_data accordingly. > >

Re: [net-next 00/12][pull request] 10GbE Intel Wired LAN Driver Updates 2018-03-23

From: Jeff Kirsher Date: Fri, 23 Mar 2018 16:16:19 -0700 > This series contains updates to ixgbe and ixgbevf only. ... > Tony provides the much anticipated XDP support for ixgbevf. Currently, > pass, drop and XDP_TX actions are supported, as well as meta data and >

Re: [PATCH v7 6/7] bnxt_en: Eliminate duplicate barriers on weakly-ordered archs

On Sun, Mar 25, 2018 at 7:39 AM, Sinan Kaya wrote: > Code includes wmb() followed by writel(). writel() already has a barrier on > some architectures like arm64. > > This ends up CPU observing two barriers back to back before executing the > register write. > > Create a new

Re: [PATCH net-next 00/13] liquidio: Tx queue cleanup

From: Felix Manlunas Date: Fri, 23 Mar 2018 17:36:18 -0700 > From: Intiyaz Basha > > Moved some common function to octeon_network.h > Removed some unwanted functions and checks. Series applied, thanks.

Re: [PATCH RFC net-next 7/7] netdevsim: Add simple FIB resource controller via devlink

On Sun, 25 Mar 2018 08:27:42 -0600, David Ahern wrote: > On 3/25/18 12:35 AM, Jakub Kicinski wrote: > > On Sat, 24 Mar 2018 09:02:45 -0600, David Ahern wrote: > diff --git a/drivers/net/netdevsim/Makefile > b/drivers/net/netdevsim/Makefile > index 09388c06171d..449b2a1a1800

[PATCH net] team: move dev_mc_sync after master_upper_dev_link in team_port_add

The same fix as in 'bonding: move dev_mc_sync after master_upper_dev_link in bond_enslave' is needed for team driver. The panic can be reproduced easily: ip link add team1 type team ip link set team1 up ip link add link team1 vlan1 type vlan id 80 ip link set vlan1 master team1 Fixes:

[PATCH net 2/3] bonding: move dev_mc_sync after master_upper_dev_link in bond_enslave

Beniamino found a crash when adding vlan as slave of bond which is also the parent link: ip link add bond1 type bond ip link set bond1 up ip link add link bond1 vlan1 type vlan id 80 ip link set vlan1 master bond1 The call trace is as below: [] queued_spin_lock_slowpath+0xb/0xf []

[PATCH net 3/3] bonding: process the err returned by dev_set_allmulti properly in bond_enslave

When dev_set_promiscuity(1) succeeds but dev_set_allmulti(1) fails, dev_set_promiscuity(-1) should be done before going to the err path. Otherwise, dev->promiscuity will leak. Fixes: 7e1a1ac1fbaa ("bonding: Check return of dev_set_promiscuity/allmulti") Signed-off-by: Xin Long

[PATCH net 1/3] bonding: fix the err path for dev hwaddr sync in bond_enslave

vlan_vids_add_by_dev is called right after dev hwaddr sync, so on the err path it should unsync dev hwaddr. Otherwise, the slave dev's hwaddr will never be unsync when this err happens. Fixes: 1ff412ad7714 ("bonding: change the bond's vlan syncing functions with the standard ones")

[PATCH net 0/3] bonding: a bunch of fixes for dev hwaddr sync in bond_enslave

This patchset is mainly to fix a crash when adding vlan as slave of bond which is also the parent link in patch 2/3, and also fix some err process problems in bond_enslave in patch 1/3 and 3/3. Xin Long (3): bonding: fix the err path for dev hwaddr sync in bond_enslave bonding: move

Re: [net-next 03/15] net/mlx5e: PFC stall prevention support

> > Shouldn't you map a value of MLX5E_PFC_PREVEN_AUTO_TOUT_MSEC back to > > PFC_STORM_PREVENTION_AUTO? > > We discussed this point internally, mapping MLX5E_PFC_PREVEN_AUTO_TOUT_MSEC > (100) to > PFC_STORM_PREVENTION_AUTO might cause confusion when the user explicitly asks > for 100msec

Re: [PATCH net-next RFC V1 5/5] net: mdio: Add a driver for InES time stamping IP core.

On Sat, Mar 24, 2018 at 09:51:52PM -0700, Richard Cochran wrote: > On Sat, Mar 24, 2018 at 07:48:58PM +0100, Andrew Lunn wrote: > > As far as i can see, you have three basic problems: > > > > 1) How do you associate the PTP device to the netdev? > > 2) How do you get the information you need to

Hello Beautiful

Hi Dear, my name is Jack and i am seeking for a relationship in which i will feel loved after a series of failed relationships. I am hoping that you would be interested and we could possibly get to know each other more if you do not mind. I am open to answering questions from you as i think

Re: [PATCH RFC net-next 1/7] net: Fix fib notifer to return errno

On Sun, Mar 25, 2018 at 08:00:19AM -0600, David Ahern wrote: > On 3/25/18 2:16 AM, Ido Schimmel wrote: > > On Thu, Mar 22, 2018 at 03:57:51PM -0700, David Ahern wrote: > >> Notifier handlers use notifier_from_errno to convert any potential error > >> to an encoded format. As a consequence the

Re: [PATCH RFC v2 net-next 00/21] net/ipv6: Separate data structures for FIB and data path

On 3/24/18 9:59 AM, Ido Schimmel wrote: >> As you know, my preference is to move to nexthop objects (makes fib6_nh >> optional). I have IPv4 done; IPv6 requires this patch set. > > After going over your presentation [1] I was under the impression that > the fib6_info will be optional, not

Re: [PATCH RFC v2 net-next 19/21] net/ipv6: separate handling of FIB entries from dst based routes

On 3/24/18 10:02 AM, Ido Schimmel wrote: >> >> ok, I'll take a look. I thought I verified both paths (fib6_info and >> dst) were freeing the metrics. > > I get this from kmemleak (applied your patchset on top of fe2d55d295cf): > > unreferenced object 0x88004e2c16c8 (size 96): > comm

[PATCH v7 5/7] net: qlge: Eliminate duplicate barriers on weakly-ordered archs

Code includes wmb() followed by writel(). writel() already has a barrier on some architectures like arm64. This ends up CPU observing two barriers back to back before executing the register write. Create a new wrapper function with relaxed write operator. Use the new wrapper when a write is

[PATCH v7 6/7] bnxt_en: Eliminate duplicate barriers on weakly-ordered archs

Code includes wmb() followed by writel(). writel() already has a barrier on some architectures like arm64. This ends up CPU observing two barriers back to back before executing the register write. Create a new wrapper function with relaxed write operator. Use the new wrapper when a write is

[PATCH v7 1/7] net: qla3xxx: Eliminate duplicate barriers on weakly-ordered archs

Code includes wmb() followed by writel(). writel() already has a barrier on some architectures like arm64. This ends up CPU observing two barriers back to back before executing the register write. Since code already has an explicit barrier call, changing code to wmb() writel_relaxed() mmiowb()

[PATCH v7 2/7] qlcnic: Eliminate duplicate barriers on weakly-ordered archs

Code includes wmb() followed by writel(). writel() already has a barrier on some architectures like arm64. This ends up CPU observing two barriers back to back before executing the register write. Since code already has an explicit barrier call, changing writel() to writel_relaxed().

[PATCH v7 7/7] net: ena: Eliminate duplicate barriers on weakly-ordered archs

Code includes barrier() followed by writel(). writel() already has a barrier on some architectures like arm64. This ends up CPU observing two barriers back to back before executing the register write. Create a new wrapper function with relaxed write operator. Use the new wrapper when a write is

[PATCH v7 4/7] bnx2x: Eliminate duplicate barriers on weakly-ordered archs

Code includes wmb() followed by writel(). writel() already has a barrier on some architectures like arm64. This ends up CPU observing two barriers back to back before executing the register write. Since code already has an explicit barrier call, changing writel() to writel_relaxed().

[PATCH v7 3/7] bnx2x: Replace doorbell barrier() with wmb()

barrier() doesn't guarantee memory writes to be observed by the hardware on all architectures. barrier() only tells compiler not to move this code with respect to other read/writes. If memory write needs to be observed by the HW, wmb() is the right choice. Signed-off-by: Sinan Kaya

[PATCH v7 0/7] netdev: Eliminate duplicate barriers on weakly-ordered archs

Code includes wmb() followed by writel() in multiple places. writel() already has a barrier on some architectures like arm64. This ends up CPU observing two barriers back to back before executing the register write. Since code already has an explicit barrier call, changing writel() to

Re: [PATCH net] nfp: use full 40 bits of the NSP buffer address

On Fri, 23 Mar 2018 19:42:22 -0700, Jakub Kicinski wrote: > From: Dirk van der Merwe > > The NSP default buffer is a piece of NFP memory where additional > command data can be placed. Its format has been copied from > host buffer, but the PCIe selection bits do

Re: [PATCH RFC net-next 7/7] netdevsim: Add simple FIB resource controller via devlink

On 3/25/18 12:35 AM, Jakub Kicinski wrote: > On Sat, 24 Mar 2018 09:02:45 -0600, David Ahern wrote: diff --git a/drivers/net/netdevsim/Makefile b/drivers/net/netdevsim/Makefile index 09388c06171d..449b2a1a1800 100644 --- a/drivers/net/netdevsim/Makefile +++

Re: [PATCH RFC net-next 7/7] netdevsim: Add simple FIB resource controller via devlink

On 3/24/18 10:02 AM, Jiri Pirko wrote: >>> >>> Wait a second. What do you mean by "per-network namespace"? Devlink >>> instance is always associated with one physical device. Like an ASIC. >>> >>> has a net entry, the simplest design is to put it into the namespace of

Re: [PATCH RFC net-next 1/7] net: Fix fib notifer to return errno

On 3/25/18 2:16 AM, Ido Schimmel wrote: > On Thu, Mar 22, 2018 at 03:57:51PM -0700, David Ahern wrote: >> Notifier handlers use notifier_from_errno to convert any potential error >> to an encoded format. As a consequence the other side, call_fib_notifiers >> in this case, needs to use

RE: [PATCH iproute2-next] rdma: Move RDMA UAPI header file to be under RDMA responsibility

> Subject: [PATCH iproute2-next] rdma: Move RDMA UAPI header file to be > under RDMA responsibility > > From: Leon Romanovsky > > In iproute2 package, the updates of UAPIs files are performed > after the needed feature lands in kernel's net-next tree. > > Such development

Re: [PATCH v4 17/17] net: ena: Eliminate duplicate barriers on weakly-ordered archs

On 2018-03-25 08:06, Belgazal, Netanel wrote: I think you should either add a parameter to ena_com_write_sq_doorbell() or add ena_com_write_sq_doorbell_rel(). Right now, you have unused function. That is true. I got rid of ena_com_write_sq_doorbell_rel. On 3/20/18, 4:43 AM, "Sinan Kaya"

Re: [PATCH net-next v2 1/2] fs/crashdd: add API to collect hardware dump in second kernel

Hi Rahul, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Rahul-Lakkireddy/fs-crashdd-add-API-to-collect-hardware-dump-in-second-kernel/20180325-191308 config: i386-randconfig-s0-03251817

Re: [PATCH v4 17/17] net: ena: Eliminate duplicate barriers on weakly-ordered archs

I think you should either add a parameter to ena_com_write_sq_doorbell() or add ena_com_write_sq_doorbell_rel(). Right now, you have unused function. On 3/20/18, 4:43 AM, "Sinan Kaya" wrote: Code includes barrier() followed by writel(). writel() already has a

Re: [RFC v3 net-next 13/18] net/sched: Introduce the TBS Qdisc

On Fri, 23 Mar 2018, Jesus Sanchez-Palencia wrote: > On 03/22/2018 03:52 PM, Thomas Gleixner wrote: > > So what's the plan for this? Having TAS as a separate entity or TAS feeding > > into the proposed 'basic' time transmission thing? > > The second one, I guess. That's just wrong. It won't

Hello Beautiful

Hi Dear, my name is Jack and i am seeking for a relationship in which i will feel loved after a series of failed relationships. I am hoping that you would be interested and we could possibly get to know each other more if you do not mind. I am open to answering questions from you as i think

Re: [net-next 02/15] ethtool: Add support for configuring PFC stall prevention in ethtool

On 24-Mar-18 17:57, Andrew Lunn wrote: > On Fri, Mar 23, 2018 at 03:39:12PM -0700, Saeed Mahameed wrote: >> From: Inbar Karmy >> >> In the event where the device unexpectedly becomes unresponsive >> for a long period of time, flow control mechanism may propagate >> pause

Re: [net-next 03/15] net/mlx5e: PFC stall prevention support

On 24-Mar-18 18:07, Andrew Lunn wrote: > On Fri, Mar 23, 2018 at 03:39:13PM -0700, Saeed Mahameed wrote: >> From: Inbar Karmy >> >> Implement set/get functions to configure PFC stall prevention >> timeout by tunables api through ethtool. >> By default the stall prevention

Hello Beautiful

Cześć Drogi, nazywam się Jack i szukam związku, w którym będę czuć się kochany po serii nieudanych związków. Mam nadzieję, że byłbyś zainteresowany i moglibyśmy się lepiej poznać, jeśli nie masz nic przeciwko. Jestem otwarty na udzielanie odpowiedzi na pytania od ciebie, ponieważ uważam, że

KASAN: use-after-free Read in pppol2tp_connect (3)

Hello, syzbot hit the following crash on upstream commit bcfc1f4554662d8f2429ac8bd96064a59c149754 (Sat Mar 24 16:50:12 2018 +) Merge tag 'pinctrl-v4.16-3' of git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl syzbot dashboard link:

Re: [PATCH] of_net: Implement of_get_nvmem_mac_address helper

On 24-03-18 19:53, Andrew Lunn wrote: A quick survey for the of_get_mac_address users learns that most of them do a memcpy (or similar) right after it, so for these drivers the "of_get_nvmem_mac_address" style signature that performs the memcpy (or better, ether_addr_copy) is a better fit, e.g.:

Re: [PATCH RFC net-next 1/7] net: Fix fib notifer to return errno

On Thu, Mar 22, 2018 at 03:57:51PM -0700, David Ahern wrote: > Notifier handlers use notifier_from_errno to convert any potential error > to an encoded format. As a consequence the other side, call_fib_notifiers > in this case, needs to use notifier_to_errno to return the error from > the handler

  1   2   >