Re: RTL8723BE performance regression

On Wed, 2018-05-02 at 05:44 +, Pkshih wrote: > > > -Original Message- > > From: João Paulo Rechi Vita [mailto:jprv...@gmail.com] > > Sent: Wednesday, May 02, 2018 6:41 AM > > To: Larry Finger > > Cc: Steve deRosier; 莊彥宣; Pkshih; Birming Chiu; Shaofu; Steven Ting; > > Chaoming_Li;

Re: [PATCH RFC 6/9] veth: Add ndo_xdp_xmit

On Wed, 2 May 2018 12:33:47 +0900 Toshiaki Makita wrote: > On 18/05/01 (火) 17:14, Jesper Dangaard Brouer wrote: > > On Tue, 1 May 2018 10:02:01 +0900 Toshiaki Makita > > wrote: > > > >> On 2018/05/01 2:27, Jesper Dangaard Brouer

Re: linux-next: manual merge of the bpf-next tree with the bpf tree

Hi Song, On Wed, 2 May 2018 04:40:20 + Song Liu wrote: > > > - CHECK(build_id_matches < 1, "build id match", > > - "Didn't find expected build ID from the map\n"); > > + if (CHECK(build_id_matches < 1, "build id match", > > - "Didn't find

[PATCH net] sctp: fix the issue that the cookie-ack with auth can't get processed

When auth is enabled for cookie-ack chunk, in sctp_inq_pop, sctp processes auth chunk first, then continues to the next chunk in this packet if chunk_end + chunk_hdr size < skb_tail_pointer(). Otherwise, it will go to the next packet or discard this chunk. However, it missed the fact that

RE: RTL8723BE performance regression

> -Original Message- > From: João Paulo Rechi Vita [mailto:jprv...@gmail.com] > Sent: Wednesday, May 02, 2018 6:41 AM > To: Larry Finger > Cc: Steve deRosier; 莊彥宣; Pkshih; Birming Chiu; Shaofu; Steven Ting; > Chaoming_Li; Kalle Valo; > linux-wireless; Network Development; LKML; Daniel

[PATCH net] sctp: use the old asoc when making the cookie-ack chunk in dupcook_d

When processing a duplicate cookie-echo chunk, for case 'D', sctp will not process the param from this chunk. It means old asoc has nothing to be updated, and the new temp asoc doesn't have the complete info. So there's no reason to use the new asoc when creating the cookie-ack chunk. Otherwise,

[PATCH net] sctp: init active key for the new asoc in dupcook_a and dupcook_b

When processing a duplicate cookie-echo chunk, for case 'A' and 'B', after sctp_process_init for the new asoc, if auth is enabled for the cookie-ack chunk, the active key should also be initialized. Otherwise, the cookie-ack chunk made later can not be set with auth shkey properly, and a crash

Re: [Xen-devel] [PATCH 2/6] xen-netfront: copy response out of shared buffer before accessing it

On 05/01/2018 12:01 AM, Marek Marczykowski-Górecki wrote: Make local copy of the response, otherwise backend might modify it while frontend is already processing it - leading to time of check / time of use issue. This is complementary to XSA155. Cc: sta...@vger.kernel.org Signed-off-by: Marek

Re: [v2 PATCH 1/1] tg3: fix meaningless hw_stats reading after tg3_halt memset 0 hw_stats

On Tue, May 1, 2018 at 5:42 PM, Zumeng Chen wrote: > diff --git a/drivers/net/ethernet/broadcom/tg3.h > b/drivers/net/ethernet/broadcom/tg3.h > index 3b5e98e..c61d83c 100644 > --- a/drivers/net/ethernet/broadcom/tg3.h > +++ b/drivers/net/ethernet/broadcom/tg3.h > @@

Re: [PATCH bpf-next] bpf/verifier: enable ctx + const + 0.

On Tue, May 01, 2018 at 09:35:29PM -0700, William Tu wrote: > > > How did you test this patch? > > > Without the patch, the test case will fail. > With the patch, the test case passes. Please test it with real program and you'll see crashes and garbage returned.

Re: [PATCH iproute2-next] Add tc-BPF example for a TCP pure ack recognizer

On Tue, May 1, 2018 at 9:12 PM, David Ahern wrote: > On 5/1/18 12:32 PM, Dave Taht wrote: >> ack_recognize can shift pure tcp acks into another flowid. >> --- >> examples/bpf/ack_recognize.c | 98 >> >> 1 file changed, 98

Re: linux-next: manual merge of the bpf-next tree with the bpf tree

> On May 1, 2018, at 7:09 PM, Stephen Rothwell wrote: > > Hi all, > > Today's linux-next merge of the bpf-next tree got a conflict in: > > tools/testing/selftests/bpf/test_progs.c > > between commit: > > a4e21ff8d9a3 ("bpf: minor fix to selftest

Re: [PATCH bpf-next] bpf/verifier: enable ctx + const + 0.

On Tue, May 1, 2018 at 4:16 PM, Alexei Starovoitov wrote: > On Mon, Apr 30, 2018 at 10:15:05AM -0700, William Tu wrote: >> Existing verifier does not allow 'ctx + const + const'. However, due to >> compiler optimization, there is a case where BPF compilerit

Re: [PATCH iproute2-next] Add tc-BPF example for a TCP pure ack recognizer

On 5/1/18 12:32 PM, Dave Taht wrote: > ack_recognize can shift pure tcp acks into another flowid. > --- > examples/bpf/ack_recognize.c | 98 > > 1 file changed, 98 insertions(+) > create mode 100644 examples/bpf/ack_recognize.c > > diff --git

Re: [RFC v3 0/5] virtio: support packed ring

On 2018年04月25日 13:15, Tiwei Bie wrote: Hello everyone, This RFC implements packed ring support in virtio driver. Some simple functional tests have been done with Jason's packed ring implementation in vhost: https://lkml.org/lkml/2018/4/23/12 Both of ping and netperf worked as expected

Re: [PATCH RFC 4/9] veth: Use NAPI for XDP

On 18/05/01 (火) 17:43, Jesper Dangaard Brouer wrote: On Tue, 1 May 2018 17:02:34 +0900 Toshiaki Makita wrote: On 2018/05/01 16:50, Jesper Dangaard Brouer wrote: On Tue, 24 Apr 2018 23:39:18 +0900 Toshiaki Makita wrote: +static

Re: [PATCH bpf-next 1/2] bpf: enable stackmap with build_id in nmi context

Hi Song, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on bpf-next/master] url: https://github.com/0day-ci/linux/commits/Song-Liu/bpf-enable-stackmap-with-build_id-in-nmi-context/20180502-081727 base:

[RFC PATCH] bpf: __pcpu_scope_irq_work can be static

Fixes: 1bd02fb7c12e ("bpf: enable stackmap with build_id in nmi context") Signed-off-by: Fengguang Wu --- stackmap.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/bpf/stackmap.c b/kernel/bpf/stackmap.c index c33fec1..5d0a951 100644 ---

Re: [PATCH RFC 6/9] veth: Add ndo_xdp_xmit

On 18/05/01 (火) 17:14, Jesper Dangaard Brouer wrote: On Tue, 1 May 2018 10:02:01 +0900 Toshiaki Makita wrote: On 2018/05/01 2:27, Jesper Dangaard Brouer wrote: On Thu, 26 Apr 2018 19:52:40 +0900 Toshiaki Makita wrote: On

Re: [PATCH V2 net-next 5/6] macvlan/macvtap: Add support for SCTP checksum offload.

On Tue, May 01, 2018 at 10:07:38PM -0400, Vladislav Yasevich wrote: > Since we now have support for software CRC32c offload, turn it on > for macvlan and macvtap devices so that guests can take advantage > of offload SCTP checksums to the host or host hardware. > > Signed-off-by: Vladislav

Re: [PATCH V2 net-next 1/6] virtio: Add support for SCTP checksum offloading

On Tue, May 01, 2018 at 10:07:34PM -0400, Vladislav Yasevich wrote: > To support SCTP checksum offloading, we need to add a new feature > to virtio_net, so we can negotiate support between the hypervisor > and the guest. > The HOST feature bit signifies offloading support for transmit and >

Re: [RFC v3 4/5] virtio_ring: add event idx support in packed ring

On 2018年04月25日 13:15, Tiwei Bie wrote: This commit introduces the event idx support in packed ring. This feature is temporarily disabled, because the implementation in this patch may not work as expected, and some further discussions on the implementation are needed, e.g. do we have to check

Re: [PATCH iproute2 1/2] README: update libdb build dependency information

On Tue, 1 May 2018 15:43:07 +0300 Baruch Siach wrote: > Debian does not distribute libdb4.x-dev for quite some time now. Current > stable carries libdb5.3-dev. Update the wording accordingly. > > Signed-off-by: Baruch Siach Applied both patches, not sure

Re: [PATCH iproute2-master] iproute: Parse last nexthop in a multipath route

On Tue, 1 May 2018 16:16:35 +0300 Ido Schimmel wrote: > Continue parsing a multipath payload as long as another nexthop can fit > in the payload. > > # ip route add 192.0.2.0/24 nexthop dev dummy0 nexthop dev dummy1 > > Before: > # ip route show 192.0.2.0/24 >

Re: Suggestions on iterating eBPF maps

On Wed, May 02, 2018 at 11:05:19AM +0900, Lorenzo Colitti wrote: > On Sat, Apr 28, 2018 at 10:04 AM, Alexei Starovoitov > wrote: > > Another approach could be to use map-in-map and have almost atomic > > replace of the whole map with new potentially empty map. The

linux-next: manual merge of the bpf-next tree with the bpf tree

Hi all, Today's linux-next merge of the bpf-next tree got a conflict in: tools/testing/selftests/bpf/test_progs.c between commit: a4e21ff8d9a3 ("bpf: minor fix to selftest test_stacktrace_build_id()") from the bpf tree and commit: 79b453501310 ("tools/bpf: add a test for bpf_get_stack

[PATCH V2 net-next 5/6] macvlan/macvtap: Add support for SCTP checksum offload.

Since we now have support for software CRC32c offload, turn it on for macvlan and macvtap devices so that guests can take advantage of offload SCTP checksums to the host or host hardware. Signed-off-by: Vladislav Yasevich --- drivers/net/macvlan.c | 5 +++--

[PATCH V2 net-next 3/6] sctp: Build sctp offload support into the base kernel

With the SCTP checksum offload support added to virtio, it is now possible to get into a situation where SCTP not present in the kernel, but the feature is negotiated. Handle this just like we do IPv6 and other modular offloads. Move the sctp offload out of the sctp module and into the base

[PATCH V2 net-next 1/6] virtio: Add support for SCTP checksum offloading

To support SCTP checksum offloading, we need to add a new feature to virtio_net, so we can negotiate support between the hypervisor and the guest. The HOST feature bit signifies offloading support for transmit and enables device offload features. The GUEST feature bit signifies offloading support

[PATCH V2 net-next 4/6] tun: Add support for SCTP checksum offload

Adds a new tun offload flag to allow for SCTP checksum offload. The flag has to be set by the user and defaults to "no offload". Add SCTP checksum support to the supported tun features. Signed-off-by: Vladislav Yasevich --- drivers/net/tun.c | 7 ++-

[PATCH V2 net-next 0/6] virtio-net: Add SCTP checksum offload support

Now that we have SCTP offload capabilities in the kernel, we can add them to virtio as well. First step is SCTP checksum. We need a new freature in virtio to negotiate this support since SCTP is excluded with the stardard checksum and requires a little bit extra. This series proposes

[PATCH V2 net-next 2/6] sctp: Handle sctp packets with CHECKSUM_PARTIAL

With SCTP checksum offload available in virtio, it is now possible for virtio to receive a sctp packet with CHECKSUM_PARTIAL set (guest-to-guest traffic). SCTP doesn't really have a partial checksum like TCP does, because CRC32c can't do partial additive checksumming. It's all or nothing. So an

[PATCH V2 net-next 6/6] ipvlan: Add support for SCTP checksum offload

Since ipvlan is a software device, we can turn on SCTP checksum offload and let the checksum be computed at the lower layer. Signed-off-by: Vladislav Yasevich --- drivers/net/ipvlan/ipvlan_main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: Suggestions on iterating eBPF maps

On Sat, Apr 28, 2018 at 10:04 AM, Alexei Starovoitov wrote: > Another approach could be to use map-in-map and have almost atomic > replace of the whole map with new potentially empty map. The prog > can continue using the new map, while user space walks no longer >

[PATCH] net/xfrm: Fix lookups for states with spi == 0

It seems to be a valid use case to add xfrm state without Security Parameter Indexes (SPI) value associated: ip xfrm state add src $src dst $dst proto $proto mode $mode sel src $src dst $dst $algo The bad thing is that it's currently impossible to get/delete the state without SPI:

linux-next: manual merge of the net-next tree with the net tree

Hi all, Today's linux-next merge of the net-next tree got a conflict in: include/net/ip6_route.h between commit: edd7ceb78296 ("ipv6: Allow non-gateway ECMP for IPv6") from the net tree and commit: 93c2fb253d17 ("net/ipv6: Rename fib6_info struct elements") from the net-next tree. I

[PATCH net] tcp_bbr: fix to zero idle_restart only upon S/ACKed data

Previously the bbr->idle_restart tracking was zeroing out the bbr->idle_restart bit upon ACKs that did not SACK or ACK anything, e.g. receiving incoming data or receiver window updates. In such situations BBR would forget that this was a restart-from-idle situation, and if the min_rtt had expired

[v2 PATCH 1/1] tg3: fix meaningless hw_stats reading after tg3_halt memset 0 hw_stats

From: Zumeng Chen Reading hw_stats will get the actual data after a sucessfull tg3_reset_hw, which actually after tg3_timer_start, so TG3_FLAG_HALT is introduced to tell tg3_get_stats64 when hw_stats is ready to read. It will be set after having done

Re: [PATCH] kvmalloc: always use vmalloc if CONFIG_DEBUG_VM

On Tue, 24 Apr 2018 12:33:01 -0400 (EDT) Mikulas Patocka wrote: > > > On Tue, 24 Apr 2018, Michal Hocko wrote: > > > On Tue 24-04-18 11:30:40, Mikulas Patocka wrote: > > > > > > > > > On Tue, 24 Apr 2018, Michal Hocko wrote: > > > > > > > On Mon 23-04-18 20:25:15,

Re: [PATCH net-next v9 3/4] virtio_net: Extend virtio to use VF datapath when available

On 4/30/2018 12:20 AM, Jiri Pirko wrote: Now I try to change mac of the failover master: [root@test1 ~]# ip link set ens3 addr 52:54:00:b2:a7:f3 RTNETLINK answers: Operation not supported That I did expect to work. I would expect this would change the mac of the master and both standby and

[PATCH bpf-next 2/2] bpf: add selftest for stackmap with build_id in NMI context

This new test captures stackmap with build_id with hardware event PERF_COUNT_HW_CPU_CYCLES. Because we only support one ips-to-build_id lookup per cpu in NMI context, stack_amap will not be able to do the lookup in this test. Therefore, we didn't do compare_stack_ips(), as it will alwasy fail.

[PATCH bpf-next 1/2] bpf: enable stackmap with build_id in nmi context

Currently, we cannot parse build_id in nmi context because of up_read(>mm->mmap_sem), this makes stackmap with build_id less useful. This patch enables parsing build_id in nmi by putting the up_read() call in irq_work. To avoid memory allocation in nmi context, we use per cpu variable for the

Re: [PATCH net-next 0/2] sctp: unify sctp_make_op_error_fixed and sctp_make_op_error_space

On Tue, May 01, 2018 at 12:13:53PM -0400, David Miller wrote: > From: Marcelo Ricardo Leitner > Date: Sun, 29 Apr 2018 12:56:30 -0300 > > > These two variants are very close to each other and can be merged > > to avoid code duplication. That's what this patchset does. >

Re: [PATCH net-next v7 1/3] vmcore: add API to collect hardware dump in second kernel

On Tue, 1 May 2018 23:57:45 +0530 Rahul Lakkireddy wrote: > + > +int vmcore_add_device_dump(struct vmcoredd_data *data) > +{ > + return __vmcore_add_device_dump(data); > +} > +EXPORT_SYMBOL(vmcore_add_device_dump); > +#endif /* CONFIG_PROC_VMCORE_DEVICE_DUMP

Re: [PATCH bpf-next] bpf/verifier: enable ctx + const + 0.

On Mon, Apr 30, 2018 at 10:15:05AM -0700, William Tu wrote: > Existing verifier does not allow 'ctx + const + const'. However, due to > compiler optimization, there is a case where BPF compilerit generates > 'ctx + const + 0', as shown below: > > 599: (1d) if r2 == r4 goto pc+2 >

Re: [PATCH net] nfp: flower: set tunnel ttl value to net default

From: Jakub Kicinski Date: Tue, 1 May 2018 15:49:49 -0700 > From: John Hurley > > Firmware requires that the ttl value for an encapsulating ipv4 tunnel > header be included as an action field. Prior to the support of Geneve > tunnel

Re: [PATCH net] net/tls: Don't recursively call push_record during tls_write_space callbacks

From: Dave Watson Date: Tue, 1 May 2018 13:05:39 -0700 > It is reported that in some cases, write_space may be called in > do_tcp_sendpages, such that we recursively invoke do_tcp_sendpages again: > > [ 660.468802] ? do_tcp_sendpages+0x8d/0x580 > [ 660.468826] ?

Re: [PATCH V4 net-next 2/2] selftest: add test for TCP_INQ

From: Soheil Hassas Yeganeh Date: Tue, 1 May 2018 15:39:16 -0400 > From: Soheil Hassas Yeganeh > > Signed-off-by: Soheil Hassas Yeganeh > Signed-off-by: Yuchung Cheng > Signed-off-by: Willem de Bruijn

Re: [PATCH V4 net-next 1/2] tcp: send in-queue bytes in cmsg upon read

From: Soheil Hassas Yeganeh Date: Tue, 1 May 2018 15:39:15 -0400 > Add the TCP_INQ socket option to TCP. When this socket > option is set, recvmsg() relays the number of bytes available > on the socket for reading to the application via the > TCP_CM_INQ control message.

[PATCH net] nfp: flower: set tunnel ttl value to net default

From: John Hurley Firmware requires that the ttl value for an encapsulating ipv4 tunnel header be included as an action field. Prior to the support of Geneve tunnel encap (when ttl set was removed completely), ttl value was extracted from the tunnel key. However, tests

[RFC PATCH 2/3] Revert "rtlwifi: fill FW version and subversion"

This reverts commit 874e837d67d0db179c9771f38fd21df07c703e93. This drastically affects the upload performance and signal strenght on the HP 240 G4 laptop, as shown by the results bellow: Without this change: $ sudo iw dev wlp2s0 scan | grep -B3 JJ | grep signal signal: -42.00 dBm $

[RFC PATCH 3/3] rtlwifi: btcoex: Always use 2ant-functions for RTL8723BE

This partially reverts commit 7937f02d1953952a6eaf626b175ea9db5541e699, which not only hooked external functions for newer ICs, as described in its commit message, but also changed the behavior for RTL8723BE depending on the value of board_info.btdm_ant_num. When board_info.btdm_ant_num == 1,

[RFC PATCH 1/3] rtlwifi: btcoex: Don't init antenna position to main port

This partially reverts commit 40d9dd4f1c5dcd0d4a2a1f0efcd225c9c4b36d6f, which does not only remove global variables from btcoex, as described on its commit message, but also does a few other things -- in particular, setting the default antenna position to BTC_ANTENNA_AT_MAIN_PORT. This

Re: Silently dropped UDP packets on kernel 4.14

Hi, Thanks for your quick and detailed reply! On Wed, May 2, 2018 at 12:24 AM, Florian Westphal wrote: > I'm not sure what the best way to solve this is, we either need > to insert earlier in nfqueue case, or do conflict resolution in nfqueue > case (and perhaps also nat undo?

Re: RTL8723BE performance regression

On Tue, Apr 3, 2018 at 7:51 PM, Larry Finger wrote: > On 04/03/2018 09:37 PM, João Paulo Rechi Vita wrote: >> >> On Tue, Apr 3, 2018 at 7:28 PM, Larry Finger >> wrote: >> >> (...) >> >>> As the antenna selection code changes affected your

Re: [PATCH net-next v7 1/3] vmcore: add API to collect hardware dump in second kernel

Rahul Lakkireddy writes: > The sequence of actions done by device drivers to append their device > specific hardware/firmware logs to /proc/vmcore are as follows: Except for the missing include that the kbuild test robot caught I am not seeing a problems.

Re: [PATCH net-next 2/2] net: bridge: Notify about !added_by_user FDB entries

Nikolay Aleksandrov writes: > On 01/05/18 20:04, Petr Machata wrote: >> Do not automatically bail out on sending notifications about activity on >> non-user-added FDB entries. Instead, notify about this activity except >> for cases where the activity itself

Re: [PATCH net-next v6] Add Common Applications Kept Enhanced (cake) qdisc

On Tue, May 1, 2018 at 12:12 PM, Eric Dumazet wrote: > > I guess that nobody really wants to really review Cake if > it is a file with 2700 lines of code and hundreds of variables/tunables. > > Sure, we have big files in networking land, as a result of thousands of >

Re: [PATCH net-next 0/2] bridge: FDB: Notify about removal of non-user-added entries

Andrew Lunn writes: > On Tue, May 01, 2018 at 07:04:19PM +0200, Petr Machata wrote: >> Device drivers may generally need to keep in sync with bridge's FDB. In >> particular, for its offload of tc mirror action where the mirrored-to >> device is a gretap device, mlxsw needs to

Re: Silently dropped UDP packets on kernel 4.14

Kristian Evensen wrote: > On Tue, May 1, 2018 at 8:50 PM, Kristian Evensen > wrote: > > Does anyone have any idea of what could be wrong, where I should look > > or other things I can try? I tried to space the requests out a bit in > > time

Re: [PATCH bpf-next 0/3] bpf: cleanups on managing subprog information

On Mon, Apr 30, 2018 at 06:28:13PM -0400, Jiong Wang wrote: > > There is no functional change by this patch set. > No bpf selftest regression found after this patch set. I was about to apply them, but there is a regression: [ 27.773899]

Re: [PATCH bpf] bpf: minor fix to selftest test_stacktrace_build_id()

On 05/01/2018 07:20 PM, Song Liu wrote: > 1. remove useless parameter list to ./urandom_read > 2. add missing "\n" to the end of an error message > > Fixes: 81f77fd0deeb ("bpf: add selftest for stackmap with > BPF_F_STACK_BUILD_ID") > Cc: Alexei Starovoitov > Cc: Daniel

Re: [PATCH net-next v6] Add Common Applications Kept Enhanced (cake) qdisc

Eric Dumazet writes: > On 05/01/2018 12:31 PM, Toke Høiland-Jørgensen wrote: > >> Could you comment on specifically what you believe is broken in this, >> please, so I can fix it in the same iteration? >> > > Apart from the various pskb_may_pull() this helper should not

Re: [PATCH bpf-nex] tools: bpftool: change time format for program 'loaded at:' information

On Tue, May 01, 2018 at 09:18:38PM +0100, Quentin Monnet wrote: > To make eBPF program load time easier to parse from "bpftool prog" > output for machines, change the time format used by the program. The > format now differs for plain and JSON version: > > - Plain version uses a string formatted

[PATCH] net: stmmac: Avoid VLA usage

In the quest to remove all stack VLAs from the kernel[1], this switches the "status" stack buffer to use the existing small (8) upper bound on how many queues can be checked for DMA, and adds a sanity-check just to make sure it doesn't operate under pathological conditions. [1]

Re: [RFC net-next 4/5] net: phy: Add support for IEEE standard test modes

On 05/01/2018 01:07 PM, woojung@microchip.com wrote: > Hi Florian, > >> Not sure I completely understand your suggestion, do you mean that I >> should break down the body of that function above such that there are >> per-speed lower level functions? Something like the pseudo-code below: >> >>

Re: [PATCH net-next v7 1/3] vmcore: add API to collect hardware dump in second kernel

Hi Rahul, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Rahul-Lakkireddy/vmcore-add-API-to-collect-hardware-dump-in-second-kernel/20180502-023638 config: i386-tinyconfig (attached as .config)

Re: [RFC PATCH v3 bpf-next 2/5] bpf/verifier: rewrite subprog boundary detection

On 18/04/18 00:48, Alexei Starovoitov wrote: > as I was saying before this is no go. > subprogno is meaningless in the hierarchy of: prog -> func -> bb -> insn > Soon bpf will have libraries and this field would need to become > a pointer back to bb or func structure creating unnecessary circular

[PATCH bpf-nex] tools: bpftool: change time format for program 'loaded at:' information

To make eBPF program load time easier to parse from "bpftool prog" output for machines, change the time format used by the program. The format now differs for plain and JSON version: - Plain version uses a string formatted according to ISO 8601. - JSON uses the number of seconds since the Epoch,

RE: [RFC net-next 4/5] net: phy: Add support for IEEE standard test modes

Hi Florian, > Not sure I completely understand your suggestion, do you mean that I > should break down the body of that function above such that there are > per-speed lower level functions? Something like the pseudo-code below: > > genphy_set_test() { > switch (mode) { > case

[PATCH net] net/tls: Don't recursively call push_record during tls_write_space callbacks

It is reported that in some cases, write_space may be called in do_tcp_sendpages, such that we recursively invoke do_tcp_sendpages again: [ 660.468802] ? do_tcp_sendpages+0x8d/0x580 [ 660.468826] ? tls_push_sg+0x74/0x130 [tls] [ 660.468852] ? tls_push_record+0x24a/0x390 [tls] [ 660.468880]

Re: [RFC net-next 0/5] Support for PHY test modes

> # echo 4 > /sys/class/net/gphy/operstate > # ip link show gphy > 4: gphy@eth1: mtu 1500 > qdisc noqueue switchid state TESTING mode DEFAULT group default > qlen 1000 > link/ether 00:10:18:de:38:1f brd ff:ff:ff:ff:ff:ff This looks good.

Re: [PATCH net-next v6] Add Common Applications Kept Enhanced (cake) qdisc

On 05/01/2018 12:31 PM, Toke Høiland-Jørgensen wrote: > Could you comment on specifically what you believe is broken in this, > please, so I can fix it in the same iteration? > Apart from the various pskb_may_pull() this helper should not change skb layout. Ideally, the skb should be const

[PATCH V4 net-next 2/2] selftest: add test for TCP_INQ

From: Soheil Hassas Yeganeh Signed-off-by: Soheil Hassas Yeganeh Signed-off-by: Yuchung Cheng Signed-off-by: Willem de Bruijn Reviewed-by: Eric Dumazet Reviewed-by: Neal Cardwell

[PATCH V4 net-next 1/2] tcp: send in-queue bytes in cmsg upon read

From: Soheil Hassas Yeganeh Applications with many concurrent connections, high variance in receive queue length and tight memory bounds cannot allocate worst-case buffer size to drain sockets. Knowing the size of receive queue length, applications can optimize how they

Re: [PATCH net-next v6] Add Common Applications Kept Enhanced (cake) qdisc

Eric Dumazet writes: > On 05/01/2018 11:53 AM, Toke Høiland-Jørgensen wrote: > >> *sigh* - can do, I guess. Though I'm not sure what that is going to >> accomplish, exactly? > > > I guess that nobody really wants to really review Cake if > it is a file with 2700 lines of

Re: [PATCH V3 net-next 1/2] tcp: send in-queue bytes in cmsg upon read

On Tue, May 1, 2018 at 2:34 PM, David Miller wrote: > From: Soheil Hassas Yeganeh > Date: Tue, 1 May 2018 10:11:27 -0400 > >> +static inline int tcp_inq_hint(struct sock *sk) > > Please do not use 'inline' in foo.c files, let the compiler decide. > >

Re: [PATCH net-next v6] Add Common Applications Kept Enhanced (cake) qdisc

On Tue, May 1, 2018 at 11:53 AM, Toke Høiland-Jørgensen wrote: > Eric Dumazet writes: > >> On 04/30/2018 02:27 PM, Dave Taht wrote: >> >>> I actually have a tc - bpf based ack filter, during the development of >>> cake's ack-thinner, that I should submit one

Re: [PATCH net-next v6] Add Common Applications Kept Enhanced (cake) qdisc

From: Eric Dumazet Date: Tue, 1 May 2018 12:12:45 -0700 > It seems you guys spent years/months on work on this stuff, so what > is the big deal about presenting your work in the best possible way > ? +1

Re: [PATCH net-next v6] Add Common Applications Kept Enhanced (cake) qdisc

On 05/01/2018 11:53 AM, Toke Høiland-Jørgensen wrote: > *sigh* - can do, I guess. Though I'm not sure what that is going to > accomplish, exactly? I guess that nobody really wants to really review Cake if it is a file with 2700 lines of code and hundreds of variables/tunables. Sure, we have

Re: [PATCH net-next 0/9] Misc bug fixes for HNS3 Ethernet driver

From: Salil Mehta Date: Tue, 1 May 2018 19:55:56 +0100 > This patch-set presents some miscellaneous bug fixs and cleanups for > HNS3 Ethernet Driver. Series applied, thank you.

[PATCH net-next 1/9] net: hns3: Remove error log when getting pfc stats fails

From: Yunsheng Lin When mac supports DCB, but is in GE mode, it does not support querying pfc stats, firmware returns error when trying to query the pfc stats. this creates a lot of noise in the kernel log when it prints the error log. This patch fixes it by removing the

[PATCH net-next 0/9] Misc bug fixes for HNS3 Ethernet driver

This patch-set presents some miscellaneous bug fixs and cleanups for HNS3 Ethernet Driver. Fuyun Liang (1): net: hns3: Fix to support autoneg only for port attached with phy Huazhong Tan (5): net: hns3: fix to correctly fetch l4 protocol outer header net: hns3: Fixes the out of bounds

[PATCH net-next 3/9] net: hns3: Fixes the out of bounds access in hclge_map_tqp

From: Huazhong Tan This patch fixes the handling of the check when number of vports are detected to be more than available TPQs. Current handling causes an out of bounds access in hclge_map_tqp(). Fixes: 7df7dad633e2 ("net: hns3: Refactor the mapping of tqp to vport")

[PATCH net-next 2/9] net: hns3: fix to correctly fetch l4 protocol outer header

From: Huazhong Tan This patch fixes the function being used to fetch L4 protocol outer header. Mistakenly skb_inner_transport_header API was being used earlier. Fixes: 76ad4f0ee747 ("net: hns3: Add support of HNS3 Ethernet Driver for hip08 SoC") Signed-off-by: Huazhong

[PATCH net-next 7/9] net: hns3: fix a dead loop in hclge_cmd_csq_clean

From: Huazhong Tan If head has invlid value then a dead loop can be triggered in hclge_cmd_csq_clean. This patch adds sanity check for this case. Fixes: 68c0a5c70614 ("net: hns3: Add HNS3 IMP(Integrated Mgmt Proc) Cmd Interface Support") Signed-off-by: Huazhong Tan

[PATCH net-next 8/9] net: hns3: Fix for packet loss due wrong filter config in VLAN tbls

From: Yunsheng Lin There are two level of vlan tables in hardware, one is port vlan which is shared by all functions, the other one is function vlan table, each function has it's own function vlan table. Currently, PF sets the port vlan table, and vf sets the function

[PATCH net-next 4/9] net: hns3: Fixes the error legs in hclge_init_ae_dev function

From: Huazhong Tan This patch fixes some of the missed error legs in the initialization function of the ae device. This might cause leaks in case of failure. Fixes: 46a3df9f9718 ("net: hns3: Add HNS3 Acceleration Engine & Compatibility Layer Support") Signed-off-by:

[PATCH net-next 6/9] net: hns3: Fix to support autoneg only for port attached with phy

From: Fuyun Liang This patch adds a check to support autoneg(ethtool -A) only when PHY is attached with the port. Fixes: e2cb1dec9779 ("net: hns3: Add HNS3 VF HCL(Hardware Compatibility Layer) Support") Signed-off-by: Fuyun Liang Signed-off-by:

[PATCH net-next 5/9] net: hns3: fix for phy_addr error in hclge_mac_mdio_config

From: Huazhong Tan When phy exists, phy_addr must less than PHY_MAX_ADDR. If not, hclge_mac_mdio_config should return error. And for fiber(phy_addr=0xff), it does not need hclge_mac_mdio_config. Signed-off-by: Huazhong Tan Signed-off-by: Peng Li

[PATCH net-next 9/9] net: hns3: Remove packet statistics in the range of 8192~12287

From: Xi Wang Because the current statistics for size 8192~12287 are only valid for GE, the ranges of 8192~9216 and 9217~12287 are valid only for LGE/CGE, and are always 0 for GE interfaces. it is easy to cause confusion when viewing the packet statistics using the command

Re: Silently dropped UDP packets on kernel 4.14

On Tue, May 1, 2018 at 8:50 PM, Kristian Evensen wrote: > Does anyone have any idea of what could be wrong, where I should look > or other things I can try? I tried to space the requests out a bit in > time (I inserted a sleep 1 between them), and then the problem went

Re: [PATCH net-next v6] Add Common Applications Kept Enhanced (cake) qdisc

Eric Dumazet writes: > On 04/30/2018 02:27 PM, Dave Taht wrote: > >> I actually have a tc - bpf based ack filter, during the development of >> cake's ack-thinner, that I should submit one of these days. It >> proved to be of limited use. >> >> Probably the biggest

Silently dropped UDP packets on kernel 4.14

Hello, I am currently debugging an issue where it looks like UDP packets are silently dropped. My setup is a client with a tool that sends two UDP packets (DNS requests) "simultaneously" using the same socket, and then a router running latest OpenWRT (with kernel 4.14.37). What I am seeing is

Re: [RFC net-next 4/5] net: phy: Add support for IEEE standard test modes

On 05/01/2018 10:29 AM, woojung@microchip.com wrote: > Hi Florian, > >> diff --git a/drivers/net/phy/phy-tests.c b/drivers/net/phy/phy-tests.c > ... >> +/* genphy_set_test - Make a PHY enter one of the standard IEEE defined >> + * test modes >> + * @phydev: the PHY device instance >> + *

Re: [PATCH V3 net-next 1/2] tcp: send in-queue bytes in cmsg upon read

From: Soheil Hassas Yeganeh Date: Tue, 1 May 2018 10:11:27 -0400 > +static inline int tcp_inq_hint(struct sock *sk) Please do not use 'inline' in foo.c files, let the compiler decide. Otherwise looks great, thanks.

[PATCH iproute2-next] Add tc-BPF example for a TCP pure ack recognizer

ack_recognize can shift pure tcp acks into another flowid. --- examples/bpf/ack_recognize.c | 98 1 file changed, 98 insertions(+) create mode 100644 examples/bpf/ack_recognize.c diff --git a/examples/bpf/ack_recognize.c

Re: [Cake] [PATCH net-next v6] Add Common Applications Kept Enhanced (cake) qdisc

> On 1 May, 2018, at 7:06 pm, Eric Dumazet wrote: > > You have not provided any numbers to show how useful it is to maintain this > code (probably still broken btw, considering it is changing some skb > attributes). A simple calculation shows what the maximum tolerable

[PATCH net-next v7 0/3] kernel: add support to collect hardware logs in crash recovery kernel

On production servers running variety of workloads over time, kernel panic can happen sporadically after days or even months. It is important to collect as much debug logs as possible to root cause and fix the problem, that may not be easy to reproduce. Snapshot of underlying hardware/firmware

[PATCH net-next v7 2/3] vmcore: append device dumps to vmcore as elf notes

Update read and mmap logic to append device dumps as additional notes before the other elf notes. We add device dumps before other elf notes because the other elf notes may not fill the elf notes buffer completely and we will end up with zero-filled data between the elf notes and the device dumps.

  1   2   >