Re: [PATCH 8/8] rhashtable: don't hold lock on first table throughout insertion.

On Sun, May 06, 2018 at 08:00:49AM +1000, NeilBrown wrote: > > The insert function must (and does) take the lock on the bucket before > testing if there is a "next" table. > If one inserter finds that it has locked the "last" table (because there > is no next) and successfully inserts, then the

Re: [PATCH 4/8] rhashtable: fix race in nested_table_alloc()

On Sun, May 06, 2018 at 07:48:20AM +1000, NeilBrown wrote: > > The spinlock protects 2 or more buckets. The nested table contains at > least 512 buckets, maybe more. > It is quite possible for two insertions into 2 different buckets to both > get their spinlock and both try to instantiate the

[RFC PATCH] drivers core: device_root_tasks_done can be static

Fixes: 6d54ba128905 ("drivers core: multi-threading device shutdown") Signed-off-by: Fengguang Wu --- core.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/base/core.c b/drivers/base/core.c index 110d797..666c163 100644 ---

Re: [Intel-wired-lan] [PATCH v2 1/1] drivers core: multi-threading device shutdown

Hi Pavel, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on driver-core/driver-core-testing] [also build test WARNING on v4.17-rc3 next-20180504] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

[PATCH net-next 3/4] qed: Add support for multi function mode with 802.1ad tagging.

The patch adds support for new Multi function mode wherein the traffic classification is done based on the 802.1ad tagging and the outer vlan tag provided by the management firmware. Signed-off-by: Sudarsana Reddy Kalluru Signed-off-by: Ariel Elior

[PATCH net-next 2/4] qed: Remove unused data member 'is_mf_default'.

The data member 'is_mf_default' is not used by the qed/qede drivers, removing the same. Signed-off-by: Sudarsana Reddy Kalluru Signed-off-by: Ariel Elior --- drivers/net/ethernet/qlogic/qed/qed_main.c | 2 -- include/linux/qed/qed_if.h

[PATCH net-next 4/4] qed: Add support for Unified Fabric Port.

This patch adds driver changes for supporting the Unified Fabric Port (UFP). This is a new paritioning mode wherein MFW provides the set of parameters to be used by the device such as traffic class, outer-vlan tag value, priority type etc. Drivers receives this info via notifications from mfw and

[PATCH net-next 1/4] qed*: Refactor mf_mode to consist of bits.

`mf_mode' field indicates the multi-partitioning mode the device is configured to. This method doesn't scale very well, adding a new MF mode requires going over all the existing conditions, and deciding whether those are needed for the new mode or not. The patch defines a set of bit-fields for

[PATCH net-next 0/4] qed*: Add support for new multi partitioning modes.

From: Sudarsana Reddy Kalluru The patch series simplifies the multi function (MF) mode implementation of qed/qede drivers, and adds support for new MF modes. Please consider applying it to net-next branch. Sudarsana Reddy Kalluru (4): qed*: Refactor mf_mode to

Re: [PATCH net] net/tls: Don't recursively call push_record during tls_write_space callbacks

On 01. mai 2018 22:05, Dave Watson wrote: It is reported that in some cases, write_space may be called in do_tcp_sendpages, such that we recursively invoke do_tcp_sendpages again: [ 660.468802] ? do_tcp_sendpages+0x8d/0x580 [ 660.468826] ? tls_push_sg+0x74/0x130 [tls] [ 660.468852] ?

BUG: please report to d...@vger.kernel.org => prev = 0, last = 0 at net/dccp/ccids/lib/packet_history.c:LINE/tfrc_rx_his

Hello, syzbot found the following crash on: HEAD commit:c1c07416cdd4 Merge tag 'kbuild-fixes-v4.17' of git://git.k.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=13d5de4780 kernel config: https://syzkaller.appspot.com/x/.config?x=5a1dc06635c10d27

[PATCH bpf-next v5 1/4] bpf: sockmap, refactor sockmap routines to work with hashmap

This patch only refactors the existing sockmap code. This will allow much of the psock initialization code path and bpf helper codes to work for both sockmap bpf map types that are backed by an array, the currently supported type, and the new hash backed bpf map type sockhash. Most the fallout

[PATCH bpf-next v5 3/4] bpf: selftest additions for SOCKHASH

This runs existing SOCKMAP tests with SOCKHASH map type. To do this we push programs into include file and build two BPF programs. One for SOCKHASH and one for SOCKMAP. We then run the entire test suite with each type. Signed-off-by: John Fastabend Acked-by: David S.

[PATCH bpf-next v5 2/4] bpf: sockmap, add hash map support

Sockmap is currently backed by an array and enforces keys to be four bytes. This works well for many use cases and was originally modeled after devmap which also uses four bytes keys. However, this has become limiting in larger use cases where a hash would be more appropriate. For example users

[PATCH bpf-next v5 4/4] bpf: bpftool, support for sockhash

This adds the SOCKHASH map type to bpftools so that we get correct pretty printing. Signed-off-by: John Fastabend Acked-by: David S. Miller --- tools/bpf/bpftool/map.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/bpf/bpftool/map.c

[PATCH bpf-next v5 0/4] Hash support for sock

In the original sockmap implementation we got away with using an array similar to devmap. However, unlike devmap where an ifindex has a nice 1:1 function into the map we have found some use cases with sockets that need to be referenced using longer keys. This series adds support for a sockhash

Re: WARNING in kernfs_add_one

On Sat, May 05, 2018 at 10:43:45AM -0700, Eric Dumazet wrote: > > > On 05/05/2018 09:40 AM, Greg KH wrote: > > On Sat, May 05, 2018 at 08:47:02AM -0700, syzbot wrote: > >> Hello, > >> > >> syzbot found the following crash on: > >> > >> HEAD commit:8fb11a9a8d51 net/ipv6: rename rt6_next to

Re: [PATCH 8/8] rhashtable: don't hold lock on first table throughout insertion.

On Sat, May 05 2018, Herbert Xu wrote: > On Fri, May 04, 2018 at 01:54:14PM +1000, NeilBrown wrote: >> rhashtable_try_insert() currently hold a lock on the bucket in >> the first table, while also locking buckets in subsequent tables. >> This is unnecessary and looks like a hold-over from some

Re: [PATCH 6/8] rhashtable: further improve stability of rhashtable_walk

On Sat, May 05 2018, Herbert Xu wrote: > On Fri, May 04, 2018 at 01:54:14PM +1000, NeilBrown wrote: >> If the sequence: >>obj = rhashtable_walk_next(iter); >>rhashtable_walk_stop(iter); >>rhashtable_remove_fast(ht, >head, params); >>rhashtable_walk_start(iter); >> >> races with

Re: [PATCH 1/8] rhashtable: silence RCU warning in rhashtable_test.

On Sat, May 05 2018, Herbert Xu wrote: > On Fri, May 04, 2018 at 01:54:14PM +1000, NeilBrown wrote: >> print_ht in rhashtable_test calls rht_dereference() with neither >> RCU protection or the mutex. This triggers an RCU warning. >> So take the mutex to silence the warning. >> >> Signed-off-by:

Re: [PATCH 4/8] rhashtable: fix race in nested_table_alloc()

On Sat, May 05 2018, Herbert Xu wrote: > On Fri, May 04, 2018 at 01:54:14PM +1000, NeilBrown wrote: >> If two threads run nested_table_alloc() at the same time >> they could both allocate a new table. >> Best case is that one of them will never be freed, leaking memory. >> Worst case is hat entry

Re: [PATCH 3/8] rhashtable: use cmpxchg() to protect ->future_tbl.

On Sat, May 05 2018, Herbert Xu wrote: > On Fri, May 04, 2018 at 01:54:14PM +1000, NeilBrown wrote: >> Rather than borrowing one of the bucket locks to >> protect ->future_tbl updates, use cmpxchg(). >> This gives more freedom to change how bucket locking >> is implemented. >> >> Signed-off-by:

[RFC PATCH 2/3] arcnet: com20020: Fixup missing SLOWARB bit

From: Andrea Greco If com20020 clock is major of 40Mhz SLOWARB bit is requested. Signed-off-by: Andrea Greco --- drivers/net/arcnet/com20020.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/arcnet/com20020.c

Re: [PATCH 2/8] rhashtable: remove nulls_base and related code.

On Sat, May 05 2018, Herbert Xu wrote: > On Fri, May 04, 2018 at 01:54:14PM +1000, NeilBrown wrote: >> This "feature" is unused, undocumented, and untested and so >> doesn't really belong. If a use for the nulls marker >> is found, all this code would need to be reviewed to >> ensure it works as

[RFC PATCH 3/3] arcnet: com20020: Add ethtool support

From: Andrea Greco Setup ethtols for export com20020 diag register Signed-off-by: Andrea Greco --- drivers/net/arcnet/com20020-isa.c| 1 + drivers/net/arcnet/com20020-membus.c | 1 + drivers/net/arcnet/com20020.c| 29

[RFC PATCH 1/3] arcnet: com20020: Add memory map of com20020

From: Andrea Greco Add support for com20022I/com20020, memory mapped chip version. Support bus: Intel 80xx and Motorola 68xx. Bus size: Only 8 bit bus size is supported. Added related device tree bindings Signed-off-by: Andrea Greco ---

Re: [PATCH net-next v2 03/13] net: phy: sfp: warn the user when no tx_disable pin is available

On Sat, May 05, 2018 at 01:38:31PM -0700, Florian Fainelli wrote: > On May 4, 2018 10:14:25 AM PDT, Andrew Lunn wrote: > >On Fri, May 04, 2018 at 10:07:53AM -0700, Florian Fainelli wrote: > >> On 05/04/2018 06:56 AM, Antoine Tenart wrote: > >> > In case no Tx disable pin is

Re: [PATCH net-next v2 03/13] net: phy: sfp: warn the user when no tx_disable pin is available

On May 4, 2018 10:14:25 AM PDT, Andrew Lunn wrote: >On Fri, May 04, 2018 at 10:07:53AM -0700, Florian Fainelli wrote: >> On 05/04/2018 06:56 AM, Antoine Tenart wrote: >> > In case no Tx disable pin is available the SFP modules will always >be >> > emitting. This could be an issue

Re: [PATCH net-next] net: phy: sfp: handle cases where neither BR,min nor BR,max is given

On May 4, 2018 8:21:03 AM PDT, Antoine Tenart wrote: >When computing the bitrate using values read from an SFP module EEPROM, >we use the nominal BR plus BR,min and BR,max to determine the >boundaries. But in some cases BR,min and BR,max aren't provided, which >led

Re: [PATCH v5 0/6] firmware_loader: cleanups for v4.18

"Luis R. Rodriguez" writes: > So we can nuke CONFIG_WANXL_BUILD_FIRMWARE now? I'm uncertain I understand why do you want it, or maybe what are you trying to do at all. And what use would wanxlfw.S (the assembly source) have if the option is removed? >> It's more about

[PATCH] isdn: eicon: fix a missing-check bug

In divasmain.c, the function divas_write() firstly invokes the function diva_xdi_open_adapter() to open the adapter that matches with the adapter number provided by the user, and then invokes the function diva_xdi_write() to perform the write operation using the matched adapter. The two functions

[PATCH net-next 8/9] net: dsa: Plug in PHYLINK support

Add support for PHYLINK within the DSA subsystem in order to support more complex devices such as pluggable (SFP) and non-pluggable (SFF) modules, 10G PHYs, and traditional PHYs. Using PHYLINK allows us to drop some amount of complexity we had while probing fixed and non-fixed PHYs using Device

[PATCH net-next 2/9] net: phy: phylink: Release link GPIO

We are not releasing the link GPIO descriptor with gpiod_put() which results in subsequent probing to get -EBUSY when calling fwnode_get_named_gpiod(). Fix this by doing the release in phylink_destroy(). Fixes: 9525ae83959b ("phylink: add phylink infrastructure") Signed-off-by: Florian Fainelli

[PATCH net-next 5/9] net: dsa: bcm_sf2: Implement phylink_mac_ops

Make the bcm_sf2 driver implement phylink_mac_ops since it needs to support a wide variety of network interfaces: internal & external MDIO PHYs, fixed PHYs, MoCA with MMIO link status. A large amount of what needs to be done already exists under bcm_sf2_sw_adjust_link() so we are essentially

[PATCH net-next 6/9] net: dsa: Eliminate dsa_slave_get_link()

Since we use PHYLIB to manage the per-port link indication, this will also be reflected correctly in the network device's carrier state, so we can use ethtool_op_get_link() instead. Signed-off-by: Florian Fainelli --- net/dsa/slave.c | 12 +--- 1 file changed, 1

[PATCH net-next 7/9] net: dsa: mv88e6xxx: add PHYLINK support

From: Russell King Add rudimentary phylink support to mv88e6xxx. This allows the driver using user ports with fixed links to keep operating normally. User ports with normal PHYs are not affected since the switch automatically manages their link parameters. User facing

[PATCH net-next 9/9] net: dsa: bcm_sf2: Get rid of PHYLIB functions

Now that we have converted the bcm_sf2 driver to implement PHYLINK MAC operations, we can remove the PHYLIB callbacks: adjust_link() and fixed_link_update() which are no longer called by DSA. Signed-off-by: Florian Fainelli --- drivers/net/dsa/bcm_sf2.c | 149

[PATCH net-next 3/9] net: phy: phylink: Poll link GPIOs

From: Russell King When using a fixed link with a link GPIO, we need to poll that GPIO to determine link state changes. This is consistent with what fixed_phy.c does. Signed-off-by: Florian Fainelli --- drivers/net/phy/phylink.c | 16

[PATCH net-next 4/9] net: dsa: Add PHYLINK switch operations

In preparation for adding support for PHYLINK within DSA, define a number of operations that we will need and that switch drivers can start implementing. Proper integration with PHYLINK will follow in subsequent patches. We start selecting PHYLINK (which implies PHYLIB) in net/dsa/Kconfig such

[PATCH net-next 0/9] net: dsa: Plug in PHYLINK support

Hi all, This patch series adds PHYLINK support to DSA which is necessary to support more complex PHY and pluggable modules setups. Patch series can be found here: https://github.com/ffainelli/linux/commits/dsa-phylink This was tested on: - dsa-loop - bcm_sf2 - mv88e6xxx - b53 With a variety

[PATCH net-next 1/9] net: phy: phylink: Use gpiod_get_value_cansleep()

The GPIO provider for the link GPIO line might require the use of the _cansleep() API, utilize that. This is safe to do since we run in workqueue context. Fixes: 9525ae83959b ("phylink: add phylink infrastructure") Signed-off-by: Florian Fainelli ---

[PATCH net] net: dsa: mv88e6xxx: Fix PHY interrupts by parameterising PHY base address

Most of the mv88e6xxx switches have the PHYs at address 0, 1, 2, ... The 6341 however has the PHYs at 0x10, 0x11, 0x12. Add a parameter to the info structure for this base address. Testing of 6f88284f3bd7 ("net: dsa: mv88e6xxx: Add MDIO interrupts for internal PHYs") was performed on the 6341. So

Re: [PATCH] net: dsa: drop some VLAs in switch.c

> > You could make the bitmap part of the dsa_switch structure. This is > > allocated by dsa_switch_alloc() and is passed the number of ports. > > Doing the allocation there means you don't need to worry about it > > failing in dsa_switch_mdb_add() or dsa_switch_vlan_add(). > > Are

Re: [PATCH iproute2-next] bpf: don't offload perf array maps

On 5/4/18 6:37 PM, Jakub Kicinski wrote: > Perf arrays are handled specially by the kernel, don't request > offload even when used by an offloaded program. > > Signed-off-by: Jakub Kicinski > Reviewed-by: Quentin Monnet > --- >

Re: [PATCH] net: dsa: drop some VLAs in switch.c

On Sat, May 5, 2018 at 8:39 AM, Andrew Lunn wrote: > On Sat, May 05, 2018 at 12:36:36PM +0200, Salvatore Mesoraca wrote: >> 2018-03-13 21:06 GMT+01:00 Florian Fainelli : >> > On 03/13/2018 12:58 PM, Vivien Didelot wrote: >> >> Hi Salvatore, >> >> >> >>

possible deadlock in sk_diag_fill

Hello, syzbot found the following crash on: HEAD commit:c1c07416cdd4 Merge tag 'kbuild-fixes-v4.17' of git://git.k.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=12164c9780 kernel config: https://syzkaller.appspot.com/x/.config?x=5a1dc06635c10d27

Re: [PATCH net-next v2 02/13] net: phy: sfp: handle non-wired SFP connectors

On Sat, May 05, 2018 at 05:39:45PM +0200, Thomas Petazzoni wrote: > Hello, > > On Fri, 4 May 2018 19:23:37 +0200, Antoine Tenart wrote: > > > On Fri, May 04, 2018 at 10:04:48AM -0700, Florian Fainelli wrote: > > > On 05/04/2018 06:56 AM, Antoine Tenart wrote: > > > > SFP connectors can be

Re: WARNING in kernfs_add_one

On 05/05/2018 09:40 AM, Greg KH wrote: > On Sat, May 05, 2018 at 08:47:02AM -0700, syzbot wrote: >> Hello, >> >> syzbot found the following crash on: >> >> HEAD commit:8fb11a9a8d51 net/ipv6: rename rt6_next to fib6_next >> git tree: net-next >> console output:

Re: [net-next PATCH v2 4/8] udp: Do not pass checksum as a parameter to GSO segmentation

On Sat, May 5, 2018 at 3:01 AM, Willem de Bruijn wrote: > On Fri, May 4, 2018 at 8:30 PM, Alexander Duyck > wrote: >> From: Alexander Duyck >> >> This patch is meant to allow us to avoid having to recompute

Re: [net-next PATCH v2 5/8] udp: Partially unroll handling of first segment and last segment

On Sat, May 5, 2018 at 1:37 AM, Willem de Bruijn wrote: > On Fri, May 4, 2018 at 8:30 PM, Alexander Duyck > wrote: >> From: Alexander Duyck >> >> This patch allows us to take care of unrolling the first

Re: [net-next PATCH v2 2/8] udp: Verify that pulling UDP header in GSO segmentation doesn't fail

On Sat, May 5, 2018 at 1:12 AM, Willem de Bruijn wrote: > On Fri, May 4, 2018 at 8:29 PM, Alexander Duyck > wrote: >> From: Alexander Duyck >> >> We should verify that we can pull the UDP header before we

Re: [PATCH rdma-next] MAINTAINERS: Remove bouncing @mellanox.com addresses

On Fri, May 4, 2018 at 12:37 AM, Doug Ledford wrote: > On 5/3/2018 5:11 PM, Or Gerlitz wrote: >> On Thu, May 3, 2018 at 9:37 PM, LR wrote: >> >>> MELLANOX MLX5 core VPI driver >>> M: Saeed Mahameed >>> -M: Matan Barak >>

Re: WARNING in kernfs_add_one

On Sat, May 05, 2018 at 08:47:02AM -0700, syzbot wrote: > Hello, > > syzbot found the following crash on: > > HEAD commit:8fb11a9a8d51 net/ipv6: rename rt6_next to fib6_next > git tree: net-next > console output: https://syzkaller.appspot.com/x/log.txt?x=14b2723780 > kernel config:

Re: [PATCH v2 net-next 1/4] umh: introduce fork_usermode_blob() helper

On Sat, May 05, 2018 at 12:48:24AM -0400, Jann Horn wrote: > On Thu, May 3, 2018 at 12:36 AM, Alexei Starovoitov wrote: > > Introduce helper: > > int fork_usermode_blob(void *data, size_t len, struct umh_info *info); > > struct umh_info { > >struct file *pipe_to_umh; > >

[PATCH v2 0/1] multi-threading device shutdown

Changelog v1 - v2 - It turns out we cannot lock more than MAX_LOCK_DEPTH by a single thread. (By default this value is 48), and is used to detect deadlocks. So, I re-wrote the code to only lock one devices per thread instead of pre-locking all devices by the

Re: [PATCH 7/8] rhashtable: add rhashtable_walk_prev()

On Sat, May 5, 2018 at 2:43 AM, Herbert Xu wrote: > On Fri, May 04, 2018 at 01:54:14PM +1000, NeilBrown wrote: >> rhashtable_walk_prev() returns the object returned by >> the previous rhashtable_walk_next(), providing it is still in the >> table (or was during this

[PATCH v2 1/1] drivers core: multi-threading device shutdown

When system is rebooted, halted or kexeced device_shutdown() is called. This function shuts down every single device by calling either: dev->bus->shutdown(dev) dev->driver->shutdown(dev) Even on a machine with just a moderate amount of devices, device_shutdown() may take

Re: [PATCH net-next v2 02/13] net: phy: sfp: handle non-wired SFP connectors

Hello, On Fri, 4 May 2018 19:23:37 +0200, Antoine Tenart wrote: > On Fri, May 04, 2018 at 10:04:48AM -0700, Florian Fainelli wrote: > > On 05/04/2018 06:56 AM, Antoine Tenart wrote: > > > SFP connectors can be solder on a board without having any of their pins > > > (LOS, i2c...) wired. In

Re: [PATCH] net: dsa: drop some VLAs in switch.c

On Sat, May 05, 2018 at 12:36:36PM +0200, Salvatore Mesoraca wrote: > 2018-03-13 21:06 GMT+01:00 Florian Fainelli : > > On 03/13/2018 12:58 PM, Vivien Didelot wrote: > >> Hi Salvatore, > >> > >> Salvatore Mesoraca writes: > >> > >>> dsa_switch's

[PATCH net] tls: fix use after free in tls_sk_proto_close

syzbot reported a use-after-free in tls_sk_proto_close Add a boolean value to cleanup a bit this function. BUG: KASAN: use-after-free in tls_sk_proto_close+0x8ab/0x9c0 net/tls/tls_main.c:297 Read of size 1 at addr 8801ae40a858 by task syz-executor363/4503 CPU: 0 PID: 4503 Comm:

Re: [PATCH iproute2] rdma: fix header files

On 5/4/18 10:58 PM, Stephen Hemminger wrote: > On Fri, 4 May 2018 16:13:07 -0600 > David Ahern wrote: > >> On 5/4/18 3:56 PM, Stephen Hemminger wrote: >>> All user api headers in iproute2 should be in include/uapi >>> so that script can be used to put correct sanitized kernel

Re: [PATCH] net/mlx5: Fix mlx5_get_vector_affinity function

On Thu, Apr 12, 2018 at 09:49:11AM +, Israel Rukshin wrote: > Adding the vector offset when calling to mlx5_vector2eqn() is wrong. > This is because mlx5_vector2eqn() checks if EQ index is equal to vector number > and the fact that the internal completion vectors that mlx5 allocates > don't

Re: [PATCH] dt-bindings: can: rcar_can: Fix R8A7796 SoC name

On 05/03/2018 03:02 PM, Geert Uytterhoeven wrote: > R8A7796 is R-Car M3-W. > > Signed-off-by: Geert Uytterhoeven Applied to linux-can. thnx, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions| Phone:

Re: [PATCH 38/40] ide: remove ide_driver_proc_write

Christoph Hellwig writes: > The driver proc file hasn't been writeable for a long time, so this is > just dead code. It is possible to chmod this file to get at the write method. Not that I think anyone does. It looks like this code was merged in 2.3.99-pre1 with permissions

Re: [PATCH RFC net-next] net: ipvs: Adjust gso_size for IPPROTO_TCP

Hello, On Thu, 3 May 2018, Martin KaFai Lau wrote: > > - when exactly we start to use the new PMTU, eg. what happens > > in case socket caches the route, whether route is killed via > > dst->obsolete. Or may be while the PMTU expiration is handled > > per-packet, the PMTU change is

Re: [PATCH 34/40] atm: simplify procfs code

Christoph Hellwig writes: > Use remove_proc_subtree to remove the whole subtree on cleanup, and > unwind the registration loop into individual calls. Switch to use > proc_create_seq where applicable. Can you please explain why you are removing the error handling when you are

Re: [PATCH 11/40] ipv6/flowlabel: simplify pid namespace lookup

Christoph Hellwig writes: > The shole seq_file sequence already operates under a single RCU lock pair, > so move the pid namespace lookup into it, and stop grabbing a reference > and remove all kinds of boilerplate code. This is wrong. Move task_active_pid_ns(current) from open to

Re: [PATCH] net: dsa: drop some VLAs in switch.c

2018-03-13 21:06 GMT+01:00 Florian Fainelli : > On 03/13/2018 12:58 PM, Vivien Didelot wrote: >> Hi Salvatore, >> >> Salvatore Mesoraca writes: >> >>> dsa_switch's num_ports is currently fixed to DSA_MAX_PORTS. So we avoid >>> 2 VLAs[1] by using

Re: [net-next PATCH v2 0/8] UDP GSO Segmentation clean-ups

On Fri, May 4, 2018 at 8:28 PM, Alexander Duyck wrote: > This patch set addresses a number of issues I found while sorting out > enabling UDP GSO Segmentation support for ixgbe/ixgbevf. Specifically there > were a number of issues related to the checksum and such that

Re: [net-next PATCH v2 4/8] udp: Do not pass checksum as a parameter to GSO segmentation

On Fri, May 4, 2018 at 8:30 PM, Alexander Duyck wrote: > From: Alexander Duyck > > This patch is meant to allow us to avoid having to recompute the checksum > from scratch and have it passed as a parameter. > > Instead of taking that

Re: [PATCH 6/8] rhashtable: further improve stability of rhashtable_walk

On Fri, May 04, 2018 at 01:54:14PM +1000, NeilBrown wrote: > If the sequence: >obj = rhashtable_walk_next(iter); >rhashtable_walk_stop(iter); >rhashtable_remove_fast(ht, >head, params); >rhashtable_walk_start(iter); > > races with another thread inserting or removing > an object

Re: [PATCH 8/8] rhashtable: don't hold lock on first table throughout insertion.

On Fri, May 04, 2018 at 01:54:14PM +1000, NeilBrown wrote: > rhashtable_try_insert() currently hold a lock on the bucket in > the first table, while also locking buckets in subsequent tables. > This is unnecessary and looks like a hold-over from some earlier > version of the implementation. > >

Re: [PATCH 5/8] rhashtable: remove rhashtable_walk_peek()

On Fri, May 04, 2018 at 01:54:14PM +1000, NeilBrown wrote: > This function has a somewhat confused behavior that is not properly > described by the documentation. > Sometimes is returns the previous object, sometimes it returns the > next one. > Sometimes it changes the iterator, sometimes it

Re: [PATCH 4/8] rhashtable: fix race in nested_table_alloc()

On Fri, May 04, 2018 at 01:54:14PM +1000, NeilBrown wrote: > If two threads run nested_table_alloc() at the same time > they could both allocate a new table. > Best case is that one of them will never be freed, leaking memory. > Worst case is hat entry get stored there before it leaks, > and the

Re: [PATCH 3/8] rhashtable: use cmpxchg() to protect ->future_tbl.

On Fri, May 04, 2018 at 01:54:14PM +1000, NeilBrown wrote: > Rather than borrowing one of the bucket locks to > protect ->future_tbl updates, use cmpxchg(). > This gives more freedom to change how bucket locking > is implemented. > > Signed-off-by: NeilBrown This looks nice. >

Re: [PATCH 2/8] rhashtable: remove nulls_base and related code.

On Fri, May 04, 2018 at 01:54:14PM +1000, NeilBrown wrote: > This "feature" is unused, undocumented, and untested and so > doesn't really belong. If a use for the nulls marker > is found, all this code would need to be reviewed to > ensure it works as required. It would be just as easy to > just

Re: [PATCH 1/8] rhashtable: silence RCU warning in rhashtable_test.

On Fri, May 04, 2018 at 01:54:14PM +1000, NeilBrown wrote: > print_ht in rhashtable_test calls rht_dereference() with neither > RCU protection or the mutex. This triggers an RCU warning. > So take the mutex to silence the warning. > > Signed-off-by: NeilBrown I don't think the

BUG?: receiving on a packet socket with .sll_protocoll and bridging

Hello, my eventual goal is to implement MRP and for that I started to program a bit and stumbled over a problem I don't understand. For testing purposes I created a veth device pair (veth0 veth1), open a socket for each of the devices and send packets around between them. In tcpdump a typical

Re: [net-next PATCH v2 7/8] udp: Do not copy destructor if one is not present

On Fri, May 4, 2018 at 8:31 PM, Alexander Duyck wrote: > From: Alexander Duyck > > This patch makes it so that if a destructor is not present we avoid trying > to update the skb socket or any reference counting that would be associated >

Re: [net-next PATCH v2 5/8] udp: Partially unroll handling of first segment and last segment

On Fri, May 4, 2018 at 8:30 PM, Alexander Duyck wrote: > From: Alexander Duyck > > This patch allows us to take care of unrolling the first segment and the > last segment Only the last segment needs to be unrolled, right? > of the loop

Re: [net-next PATCH v2 1/8] udp: Record gso_segs when supporting UDP segmentation offload

On Fri, May 4, 2018 at 8:28 PM, Alexander Duyck wrote: > From: Alexander Duyck > > We need to record the number of segments that will be generated when this > frame is segmented. The expectation is that if gso_size is set then > gso_segs is

Re: [net-next PATCH v2 3/8] udp: Do not pass MSS as parameter to GSO segmentation

On Fri, May 4, 2018 at 10:08 PM, Eric Dumazet wrote: > > > On 05/04/2018 11:29 AM, Alexander Duyck wrote: >> From: Alexander Duyck >> >> There is no point in passing MSS as a parameter for for the GSO >> segmentation call as it is already

Re: [net-next PATCH v2 2/8] udp: Verify that pulling UDP header in GSO segmentation doesn't fail

On Fri, May 4, 2018 at 8:29 PM, Alexander Duyck wrote: > From: Alexander Duyck > > We should verify that we can pull the UDP header before we attempt to do > so. Otherwise if this fails we have no way of knowing and GSO will not work >

Re: [RFC PATCH 2/2] net: mac808211: mac802154: use lockdep_assert_in_softirq() instead own warning

* Sebastian Andrzej Siewior wrote: > On 2018-05-04 20:51:32 [+0200], Peter Zijlstra wrote: > > On Fri, May 04, 2018 at 08:45:39PM +0200, Sebastian Andrzej Siewior wrote: > > > On 2018-05-04 20:32:49 [+0200], Peter Zijlstra wrote: > > > > On Fri, May 04, 2018 at 07:51:44PM

Re: [PATCH net] sctp: delay the authentication for the duplicated cookie-echo chunk

On Sat, May 5, 2018 at 6:33 AM, Marcelo Ricardo Leitner wrote: > On Fri, May 04, 2018 at 05:05:10PM +0800, Xin Long wrote: >> Now sctp only delays the authentication for the normal cookie-echo >> chunk by setting chunk->auth_chunk in sctp_endpoint_bh_rcv(). But >> for

[PATCHv2 net] sctp: delay the authentication for the duplicated cookie-echo chunk

Now sctp only delays the authentication for the normal cookie-echo chunk by setting chunk->auth_chunk in sctp_endpoint_bh_rcv(). But for the duplicated one with auth, in sctp_assoc_bh_rcv(), it does authentication first based on the old asoc, which will definitely fail due to the different auth