Re: [pull request][net-next 00/10] Mellanox, mlx5 and devlink updates 2018-07-31

2018-08-01 Thread Jiri Pirko
Thu, Aug 02, 2018 at 01:13:20AM CEST, sae...@dev.mellanox.co.il wrote: [...] >> >> So after looking over the patch set the one thing I would ask for in >> this is some sort of documentation at a minimum. As a user I don't see >> how you can expect someone to be able to use this when the naming of

[PATCH] Revert "net/ipv6: fix metrics leak"

2018-08-01 Thread David Miller
This reverts commit df18b50448fab1dff093731dfd0e25e77e1afcd1. This change causes other problems and use-after-free situations as found by syzbot. Signed-off-by: David S. Miller --- net/ipv6/ip6_fib.c | 18 -- 1 file changed, 4 insertions(+), 14 deletions(-) diff --git a/net/i

[PATCH net-next] rxrpc: Remove set but not used variable 'nowj'

2018-08-01 Thread Wei Yongjun
Fixes gcc '-Wunused-but-set-variable' warning: net/rxrpc/proc.c: In function 'rxrpc_call_seq_show': net/rxrpc/proc.c:66:29: warning: variable 'nowj' set but not used [-Wunused-but-set-variable] unsigned long timeout = 0, nowj; ^ Signed-off-by: Wei Yongjun --- net

Re: [pull request][net-next 00/10] Mellanox, mlx5 and devlink updates 2018-07-31

2018-08-01 Thread David Miller
From: Jakub Kicinski Date: Wed, 1 Aug 2018 17:00:47 -0700 > On Wed, 1 Aug 2018 14:52:45 -0700, Saeed Mahameed wrote: >> - According to the discussion outcome, we are keeping the congestion control >> setting as mlx5 device specific for the current HW generation. > > I still see queuing and ma

Re: [Patch net-next] net: hns3: fix return value error while hclge_cmd_csq_clean failed

2018-08-01 Thread tanhuazhong
On 2018/8/2 1:03, David Miller wrote: From: Huazhong Tan Date: Wed, 1 Aug 2018 17:53:28 +0800 From: fredalu While cleaning the command queue, the value of the HEAD register is not in the range of next_to_clean and next_to_use, meaning that this value is invalid. This also means that there

Re: [pull request][net-next 00/10] Mellanox, mlx5 and devlink updates 2018-07-31

2018-08-01 Thread Alexander Duyck
On Wed, Aug 1, 2018 at 4:13 PM, Saeed Mahameed wrote: > On Wed, Aug 1, 2018 at 3:34 PM, Alexander Duyck > wrote: >> On Wed, Aug 1, 2018 at 2:52 PM, Saeed Mahameed wrote: >>> Hi Dave, >>> >>> This series provides devlink parameters updates to both devlink API and >>> mlx5 driver, it is a 2nd iter

Re: [pull request][net-next 00/10] Mellanox, mlx5 and devlink updates 2018-07-31

2018-08-01 Thread Jakub Kicinski
On Wed, 1 Aug 2018 14:52:45 -0700, Saeed Mahameed wrote: > - According to the discussion outcome, we are keeping the congestion control > setting as mlx5 device specific for the current HW generation. I still see queuing and marking based on queue level. You want to add a Qdisc that will mirr

re: hello

2018-08-01 Thread Erika@EuropeMillions
-- Congratulations, You Have won SIX HUNDRED AND FIFTY THOUSAND EURO in the monthly Euro/ Google draws on July 1, 2018. reply to fill your claim form. Erika Hermann Online Coordinator Desk038984EU

Re: [PATCH net-next] virtio_net: force_napi_tx module param.

2018-08-01 Thread Willem de Bruijn
On Wed, Aug 1, 2018 at 6:48 PM Michael S. Tsirkin wrote: > > On Wed, Aug 01, 2018 at 06:43:53PM -0400, Willem de Bruijn wrote: > > > > So e.g. we could set an affinity hint to a group of CPUs that > > > > > might transmit to this queue. > > > > > > > > We also want to set the xps mask for all cpu

Re: [pull request][net-next 00/10] Mellanox, mlx5 and devlink updates 2018-07-31

2018-08-01 Thread Saeed Mahameed
On Wed, Aug 1, 2018 at 3:34 PM, Alexander Duyck wrote: > On Wed, Aug 1, 2018 at 2:52 PM, Saeed Mahameed wrote: >> Hi Dave, >> >> This series provides devlink parameters updates to both devlink API and >> mlx5 driver, it is a 2nd iteration of the dropped patches sent in a previous >> mlx5 submissi

Re: [PATCH net-next] virtio_net: force_napi_tx module param.

2018-08-01 Thread Michael S. Tsirkin
On Wed, Aug 01, 2018 at 06:43:53PM -0400, Willem de Bruijn wrote: > > > So e.g. we could set an affinity hint to a group of CPUs that > > > > might transmit to this queue. > > > > > > We also want to set the xps mask for all cpus in the group to this queue. > > > > > > Is there a benefit over expl

Re: [PATCH net-next] virtio_net: force_napi_tx module param.

2018-08-01 Thread Willem de Bruijn
> > So e.g. we could set an affinity hint to a group of CPUs that > > > might transmit to this queue. > > > > We also want to set the xps mask for all cpus in the group to this queue. > > > > Is there a benefit over explicitly choosing one cpu from the set, btw? > > If only one CPU actually transm

Re: [pull request][net-next 00/10] Mellanox, mlx5 and devlink updates 2018-07-31

2018-08-01 Thread Alexander Duyck
On Wed, Aug 1, 2018 at 2:52 PM, Saeed Mahameed wrote: > Hi Dave, > > This series provides devlink parameters updates to both devlink API and > mlx5 driver, it is a 2nd iteration of the dropped patches sent in a previous > mlx5 submission "net/mlx5: Support PCIe buffer congestion handling via > Dev

Re: [net-next 01/10] devlink: Fix param set handling for string type

2018-08-01 Thread Jakub Kicinski
On Wed, 1 Aug 2018 14:52:46 -0700, Saeed Mahameed wrote: > From: Moshe Shemesh > > In case devlink param type is string, it needs to copy the string value > it got from the input to devlink_param_value. > > Fixes: e3b7ca18ad7b ("devlink: Add param set command") > Signed-off-by: Moshe Shemesh >

Re: [PATCH net-next] virtio_net: force_napi_tx module param.

2018-08-01 Thread Michael S. Tsirkin
On Mon, Jul 30, 2018 at 02:06:50PM +0800, Jason Wang wrote: > > > On 2018年07月25日 08:17, Jon Olson wrote: > > On Tue, Jul 24, 2018 at 3:46 PM Michael S. Tsirkin wrote: > > > On Tue, Jul 24, 2018 at 06:31:54PM -0400, Willem de Bruijn wrote: > > > > On Tue, Jul 24, 2018 at 6:23 PM Michael S. Tsirki

Re: [PATCH net-next] virtio_net: force_napi_tx module param.

2018-08-01 Thread Michael S. Tsirkin
On Wed, Aug 01, 2018 at 11:46:14AM -0400, Willem de Bruijn wrote: > On Tue, Jul 31, 2018 at 8:34 AM Michael S. Tsirkin wrote: > > > > On Sun, Jul 29, 2018 at 05:32:56PM -0400, Willem de Bruijn wrote: > > > On Sun, Jul 29, 2018 at 12:01 PM David Miller wrote: > > > > > > > > From: Caleb Raitto >

Re: [net-next 07/10] net/mlx5: Enable PCIe buffer congestion handling workaround via devlink

2018-08-01 Thread Alexander Duyck
On Wed, Aug 1, 2018 at 2:52 PM, Saeed Mahameed wrote: > From: Eran Ben Elisha > > Add support for two driver parameters via devlink params interface: > - Congestion action > HW mechanism in the PCIe buffer which monitors the amount of > consumed PCIe buffer per host. This mechanis

[net-next 09/10] net/mlx5: Add Crdump FW snapshot support

2018-08-01 Thread Saeed Mahameed
From: Alex Vesker Crdump allows the driver to create a snapshot of the FW PCI crspace. This is useful in case of catastrophic issues which require FW reset. The snapshot can be used for later debug. The snapshot is exposed using devlink, cr-space address regions are registered on init and snapsh

[net-next 10/10] net/mlx5: Use devlink region_snapshot parameter

2018-08-01 Thread Saeed Mahameed
From: Alex Vesker This parameter enables capturing region snapshot of the crspace during critical errors. The default value of this parameter is disabled, it can be enabled using devlink param commands. It is possible to configure during runtime and also driver init. Signed-off-by: Alex Vesker

[net-next 07/10] net/mlx5: Enable PCIe buffer congestion handling workaround via devlink

2018-08-01 Thread Saeed Mahameed
From: Eran Ben Elisha Add support for two driver parameters via devlink params interface: - Congestion action HW mechanism in the PCIe buffer which monitors the amount of consumed PCIe buffer per host. This mechanism supports the following actions in case of threshold over

[net-next 08/10] net/mlx5: Add Vendor Specific Capability access gateway

2018-08-01 Thread Saeed Mahameed
From: Alex Vesker The Vendor Specific Capability (VSC) is used to activate a gateway interfacing with the device. The gateway is used to read or write device configurations, which are organized in different domains (spaces). A configuration access may result in multiple actions, reads, writes. E

[net-next 06/10] net/mlx5: Add MPEGC register configuration functionality

2018-08-01 Thread Saeed Mahameed
From: Eran Ben Elisha MPEGC register is used to configure and access the PCIe general configuration. Expose set/get for TX lossy overflow and TX overflow sense which use the MPEGC register. These will be used in a downstream patch via devlink params. Signed-off-by: Eran Ben Elisha Reviewed-by:

[net-next 05/10] net/mlx5: Move all devlink related functions calls to devlink.c

2018-08-01 Thread Saeed Mahameed
From: Eran Ben Elisha Centralize all devlink related callbacks in one file. In the downstream patch, some more functionality will be added, this patch is preparing the driver infrastructure for it. Currently, move devlink un/register functions calls into this file. Signed-off-by: Eran Ben Elish

[net-next 03/10] devlink: Add helper function for safely copy string param

2018-08-01 Thread Saeed Mahameed
From: Moshe Shemesh Devlink string param buffer is allocated at the size of DEVLINK_PARAM_MAX_STRING_VALUE. Add helper function which makes sure this size is not exceeded. Renamed DEVLINK_PARAM_MAX_STRING_VALUE to __DEVLINK_PARAM_MAX_STRING_VALUE to emphasize that it should be used by devlink onl

[net-next 04/10] devlink: Add extack messages support to param set

2018-08-01 Thread Saeed Mahameed
From: Moshe Shemesh Add param extack messages support to param->set() function. This will enable providing clear reasoning to user on setting new value failure. Note that param->validate() already supports extack messages, but it is not enough as input validation can pass or even not needed and s

[net-next 01/10] devlink: Fix param set handling for string type

2018-08-01 Thread Saeed Mahameed
From: Moshe Shemesh In case devlink param type is string, it needs to copy the string value it got from the input to devlink_param_value. Fixes: e3b7ca18ad7b ("devlink: Add param set command") Signed-off-by: Moshe Shemesh Acked-by: Jiri Pirko Signed-off-by: Saeed Mahameed --- include/net/dev

[net-next 02/10] devlink: Fix param cmode driverinit for string type

2018-08-01 Thread Saeed Mahameed
From: Moshe Shemesh Driverinit configuration mode value is held by devlink to enable the driver fetch the value after reload command. In case the param type is string devlink should copy the value from driver string buffer to devlink string buffer on devlink_param_driverinit_value_set() and vice-

[pull request][net-next 00/10] Mellanox, mlx5 and devlink updates 2018-07-31

2018-08-01 Thread Saeed Mahameed
Hi Dave, This series provides devlink parameters updates to both devlink API and mlx5 driver, it is a 2nd iteration of the dropped patches sent in a previous mlx5 submission "net/mlx5: Support PCIe buffer congestion handling via Devlink" to address review comments [1]. Changes from the original s

Re: how PHY driver is notified that cable is unplugged? (possibly related to IFF_RUNNING flag)

2018-08-01 Thread Robert P. J. Day
On Wed, 1 Aug 2018, Florian Fainelli wrote: > On 08/01/2018 05:58 AM, rpj...@crashcourse.ca wrote: > > > >   (warning that i have a few questions that are probably trivial > > until i get up to speed with networking code.) > > > >   a colleague asked for advice about the following -- apparently a

[net-next:master 408/425] net/rds/connection.c:71:31: sparse: incorrect type in argument 1 (different base types)

2018-08-01 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: b69ab96ab13ddaa28a506a2433ae5b12669615e8 commit: e65d4d96334e3ff4fe0064612a93a51c63de08de [408/425] rds: Remove IPv6 dependency reproduce: # apt-get install sparse git checkout e65d4d96334e3f

Re: [PATCH net-next v1] net: don't declare IPv6 non-local bind helper if CONFIG_IPV6 undefined

2018-08-01 Thread David Miller
From: Vincent Bernat Date: Wed, 1 Aug 2018 22:05:10 +0200 > Fixes: 83ba4645152d ("net: add helpers checking if socket can be bound to > nonlocal address") > Signed-off-by: Vincent Bernat Applied, thanks Vincent.

Re: [net-next v5 3/3] net/tls: Remove redundant array allocation.

2018-08-01 Thread Dave Watson
On 08/01/18 01:49 PM, Vakul Garg wrote: > > I don't think this patch is safe as-is. sgin_arr is a stack array of size > > MAX_SKB_FRAGS (+ overhead), while my read of skb_cow_data is that it > > walks the whole chain of skbs from skb->next, and can return any number of > > segments. Therefore we

Re: Security enhancement proposal for kernel TLS

2018-08-01 Thread Dave Watson
On 07/31/18 10:45 AM, Vakul Garg wrote: > > > IIUC, with the upstream implementation of tls record layer in kernel, > > > the decryption of tls FINISHED message happens in kernel. Therefore > > > the keys are already being sent to kernel tls socket before handshake is > > completed. > > > > This i

Re: [PATCH bpf] xdp: add NULL pointer check in __xdp_return()

2018-08-01 Thread Daniel Borkmann
On 08/01/2018 04:43 PM, Björn Töpel wrote: > Den ons 1 aug. 2018 kl 16:14 skrev Jesper Dangaard Brouer : >> On Mon, 23 Jul 2018 11:41:02 +0200 >> Björn Töpel wrote: >> >> diff --git a/net/core/xdp.c b/net/core/xdp.c >> index 9d1f220..1c12bc7 100644 >> --- a/net/core/xdp.c >> +++ b/

[PATCH net-next v1] net: don't declare IPv6 non-local bind helper if CONFIG_IPV6 undefined

2018-08-01 Thread Vincent Bernat
Fixes: 83ba4645152d ("net: add helpers checking if socket can be bound to nonlocal address") Signed-off-by: Vincent Bernat --- include/net/ipv6.h | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/include/net/ipv6.h b/include/net/ipv6.h index 82deb684ba73..ff33f49

[net-next:master 415/424] include/net/ipv6.h:772:14: error: 'struct net' has no member named 'ipv6'; did you mean 'ipv4'?

2018-08-01 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: 90d4c5bb98bf6665266917edf0e16ccd35f9 commit: 83ba4645152d1177c161750e1064e3a8e7cee19b [415/424] net: add helpers checking if socket can be bound to nonlocal address config: i386-tinyconfig (attached as .

Re: [net-next 10/16] net/mlx5: Support PCIe buffer congestion handling via Devlink

2018-08-01 Thread Moshe Shemesh
On Tue, Jul 31, 2018 at 2:06 PM, Bjorn Helgaas wrote: > On Mon, Jul 30, 2018 at 08:19:50PM -0700, Alexander Duyck wrote: > > On Mon, Jul 30, 2018 at 7:33 PM, Bjorn Helgaas > wrote: > > > On Mon, Jul 30, 2018 at 08:02:48AM -0700, Alexander Duyck wrote: > > >> On Mon, Jul 30, 2018 at 7:07 AM, Bjor

Re: [Patch net-next] net: hns3: fix return value error while hclge_cmd_csq_clean failed

2018-08-01 Thread David Miller
From: Huazhong Tan Date: Wed, 1 Aug 2018 17:53:28 +0800 > From: fredalu > > While cleaning the command queue, the value of the HEAD register is not > in the range of next_to_clean and next_to_use, meaning that this value > is invalid. This also means that there is a hardware error and the > har

Re: [PATCH net-next] cxgb4: fix endian to test F_FW_PORT_CMD_DCBXDIS32

2018-08-01 Thread David Miller
From: Ganesh Goudar Date: Wed, 1 Aug 2018 18:15:32 +0530 > For FW_PORT_ACTION_GET_PORT_INFO32 messages, the > u.info32.lstatus32_to_cbllen32 is 32-bit Big Endian. > We need to translate that to CPU Endian in order to > test F_FW_PORT_CMD_DCBXDIS32. > > Signed-off-by: Casey Leedom > Signed-off-

Re: [PATCH net-next] strparser: remove redundant variable 'rd_desc'

2018-08-01 Thread David Miller
From: YueHaibing Date: Wed, 1 Aug 2018 15:10:37 +0800 > Variable 'rd_desc' is being assigned but never used, > so can be removed. > > fix this clang warning: > net/strparser/strparser.c:411:20: warning: variable ‘rd_desc’ set but not > used [-Wunused-but-set-variable] > > Signed-off-by: YueHai

Re: [patch net-next v2 0/3] net: sched: couple of adjustments/fixes

2018-08-01 Thread David Miller
From: Jiri Pirko Date: Wed, 1 Aug 2018 12:36:54 +0200 > From: Jiri Pirko > > Jiri Pirko (3): > net: sched: change name of zombie chain to "held_by_acts_only" > net: sched: fix notifications for action-held chains > net: sched: make tcf_chain_{get,put}() static Series applied, thanks Jir

Re: [PATCH net-next v1] net: add helpers checking if socket can be bound to nonlocal address

2018-08-01 Thread David Miller
From: Vincent Bernat Date: Tue, 31 Jul 2018 21:18:11 +0200 > The construction "net->ipv4.sysctl_ip_nonlocal_bind || inet->freebind > || inet->transparent" is present three times and its IPv6 counterpart > is also present three times. We introduce two small helpers to > characterize these tests un

Re: how PHY driver is notified that cable is unplugged? (possibly related to IFF_RUNNING flag)

2018-08-01 Thread Florian Fainelli
On 08/01/2018 05:58 AM, rpj...@crashcourse.ca wrote: > >   (warning that i have a few questions that are probably trivial until i > get up to speed > with networking code.) > >   a colleague asked for advice about the following -- apparently a new > PHY driver works > properly when being brought

Re: [PATCH v2 net-next 0/5] tcp: add 4 new stats

2018-08-01 Thread David Miller
From: Wei Wang Date: Tue, 31 Jul 2018 17:46:19 -0700 > From: Wei Wang > > This patch series adds 3 RFC4898 stats: > 1. tcpEStatsPerfHCDataOctetsOut > 2. tcpEStatsPerfOctetsRetrans > 3. tcpEStatsStackDSACKDups > and an addtional stat to record the number of data packet reordering > events seen:

Re: [PATCH net-next] tcp: remove set but not used variable 'skb_size'

2018-08-01 Thread David Miller
From: Wei Yongjun Date: Wed, 1 Aug 2018 01:59:56 + > Fixes gcc '-Wunused-but-set-variable' warning: > > net/ipv4/tcp_output.c: In function 'tcp_collapse_retrans': > net/ipv4/tcp_output.c:2700:6: warning: > variable 'skb_size' set but not used [-Wunused-but-set-variable] > int skb_size, ne

Re: [PATCH V2 net-next 0/2] be2net: patch-set

2018-08-01 Thread David Miller
From: Suresh Reddy Date: Tue, 31 Jul 2018 11:39:41 -0400 > v1->v2 : Modified the subject line and commit log. > > Please consider applying these two patches to net-next. Series applied, thanks.

Re: [PATCH net-next 1/2] rds: rds_ib_recv_alloc_cache() should call alloc_percpu_gfp() instead

2018-08-01 Thread David Miller
From: Ka-Cheong Poon Date: Mon, 30 Jul 2018 22:48:41 -0700 > Currently, rds_ib_conn_alloc() calls rds_ib_recv_alloc_caches() > without passing along the gfp_t flag. But rds_ib_recv_alloc_caches() > and rds_ib_recv_alloc_cache() should take a gfp_t parameter so that > rds_ib_recv_alloc_cache() ca

Re: [PATCH net] net: stmmac: Fix WoL for PCI-based setups

2018-08-01 Thread David Miller
From: Jose Abreu Date: Tue, 31 Jul 2018 15:08:20 +0100 > WoL won't work in PCI-based setups because we are not saving the PCI EP > state before entering suspend state and not allowing D3 wake. > > Fix this by using a wrapper around stmmac_{suspend/resume} which > correctly sets the PCI EP state.

Re: [PATCH v2 net] bonding: avoid lockdep confusion in bond_get_stats()

2018-08-01 Thread David Miller
From: Eric Dumazet Date: Tue, 31 Jul 2018 06:30:54 -0700 > syzbot found that the following sequence produces a LOCKDEP splat [1] ... > To fix this, we can use the already provided nest_level. > > This patch also provides correct nesting for dev->addr_list_lock ... > Signed-off-by: Eric Dumazet

Re: [PATCH ethtool] ethtool: Add support for WAKE_FILTER

2018-08-01 Thread David Miller
From: Florian Fainelli Date: Mon, 30 Jul 2018 15:26:24 -0700 > On 07/17/2018 08:36 AM, Florian Fainelli wrote: >> Allow re-purposing the wol->sopass storage area to specify a bitmask of >> filters >> (programmed previously via ethtool::rxnfc) to be used as wake-up patterns. > > John, David, can

Re: [PATCH net-next 2/2] rds: Remove IPv6 dependency

2018-08-01 Thread David Miller
From: Ka-Cheong Poon Date: Mon, 30 Jul 2018 22:48:42 -0700 > This patch removes the IPv6 dependency from RDS. > > Signed-off-by: Ka-Cheong Poon Applied.

Re: [PATCH net-next] virtio_net: force_napi_tx module param.

2018-08-01 Thread Willem de Bruijn
> > > > Just distribute across the available cpus evenly, and be done with it. > > > > > > Sounds good to me. > > > > So e.g. we could set an affinity hint to a group of CPUs that > > might transmit to this queue. > > We also want to set the xps mask for all cpus in the group to this queue. > > Is

Re: [PATCH net-next] virtio_net: force_napi_tx module param.

2018-08-01 Thread Willem de Bruijn
On Tue, Jul 31, 2018 at 8:34 AM Michael S. Tsirkin wrote: > > On Sun, Jul 29, 2018 at 05:32:56PM -0400, Willem de Bruijn wrote: > > On Sun, Jul 29, 2018 at 12:01 PM David Miller wrote: > > > > > > From: Caleb Raitto > > > Date: Mon, 23 Jul 2018 16:11:19 -0700 > > > > > > > From: Caleb Raitto >

Re: [PATCH net-next 7/9] net: stmmac: Integrate XGMAC into main driver flow

2018-08-01 Thread Andrew Lunn
> @@ -842,6 +863,12 @@ static void stmmac_adjust_link(struct net_device *dev) > new_state = true; > ctrl &= ~priv->hw->link.speed_mask; > switch (phydev->speed) { > + case SPEED_1: > +

Re: [PATCH bpf] selftests/bpf: update test_lwt_seg6local.sh according to iproute2

2018-08-01 Thread Y Song
On Wed, Aug 1, 2018 at 8:34 AM, Mathieu Xhonneux wrote: > The shell file for test_lwt_seg6local contains an early iproute2 syntax > for installing a seg6local End.BPF route. iproute2 support for this > feature has recently been upstreamed, but with an additional keyword > required. This patch upda

Re: [PATCH v6 bpf-next 4/9] veth: Handle xdp_frames in xdp napi ring

2018-08-01 Thread Jesper Dangaard Brouer
On Wed, 1 Aug 2018 14:41:08 +0900 Toshiaki Makita wrote: > On 2018/07/31 21:46, Jesper Dangaard Brouer wrote: > > On Tue, 31 Jul 2018 19:40:08 +0900 > > Toshiaki Makita wrote: > > > >> On 2018/07/31 19:26, Jesper Dangaard Brouer wrote: > >>> > >>> Context needed from: [PATCH v6 bpf-next 2/9

Re: [PATCH net-next 5/9] net: stmmac: Add MDIO related functions for XGMAC2

2018-08-01 Thread Andrew Lunn
Hi Jose > +static int stmmac_xgmac2_mdio_read(struct stmmac_priv *priv, int phyaddr, > +int phyreg) > +{ > + unsigned int mii_address = priv->hw->mii.addr; > + unsigned int mii_data = priv->hw->mii.data; > + u32 tmp, addr, value = MII_XGMAC_BUSY; > +

Re: [PATCH net-next 9/9] bindings: net: stmmac: Add the bindings documentation for XGMAC2.

2018-08-01 Thread Sergei Shtylyov
Hello! On 08/01/2018 03:10 PM, Jose Abreu wrote: > Adds the documentation for XGMAC2 DT bindings. > > Signed-off-by: Jose Abreu > Cc: David S. Miller > Cc: Joao Pinto > Cc: Giuseppe Cavallaro > Cc: Alexandre Torgue > --- > Documentation/devicetree/bindings/net/stmmac.txt | 3 ++- > 1 file

Re: [PATCH bpf] xdp: add NULL pointer check in __xdp_return()

2018-08-01 Thread Björn Töpel
Den ons 1 aug. 2018 kl 16:14 skrev Jesper Dangaard Brouer : > > On Mon, 23 Jul 2018 11:41:02 +0200 > Björn Töpel wrote: > > > > >> diff --git a/net/core/xdp.c b/net/core/xdp.c > > > >> index 9d1f220..1c12bc7 100644 > > > >> --- a/net/core/xdp.c > > > >> +++ b/net/core/xdp.c > > > >> @@ -345,7 +345

Re: [PATCH net-next v5 1/4] net/sched: user-space can't set unknown tcfa_action values

2018-08-01 Thread Jamal Hadi Salim
On 31/07/18 10:40 AM, Paolo Abeni wrote: If we choose to reject unknown opcodes, such user-space configuration will fail. I think that is a good thing. The kernel should not be accepting things it doesnt understand. This is a good opportunity to enforce that. What would happen before this p

Re: [PATCH mlx5-next] RDMA/mlx5: Don't use cached IRQ affinity mask

2018-08-01 Thread Max Gurtovoy
On 8/1/2018 8:12 AM, Sagi Grimberg wrote: Hi Max, Hi, Yes, since nvmf is the only user of this function. Still waiting for comments on the suggested patch :) Sorry for the late response (but I'm on vacation so I have an excuse ;)) NP :) currently the code works.. I'm thinking that

Re: [PATCH bpf] xdp: add NULL pointer check in __xdp_return()

2018-08-01 Thread Jesper Dangaard Brouer
On Mon, 23 Jul 2018 11:41:02 +0200 Björn Töpel wrote: > > >> diff --git a/net/core/xdp.c b/net/core/xdp.c > > >> index 9d1f220..1c12bc7 100644 > > >> --- a/net/core/xdp.c > > >> +++ b/net/core/xdp.c > > >> @@ -345,7 +345,8 @@ static void __xdp_return(void *data, struct > > >> xdp_mem_info *mem,

RE: [net-next v5 3/3] net/tls: Remove redundant array allocation.

2018-08-01 Thread Vakul Garg
> -Original Message- > From: Dave Watson [mailto:davejwat...@fb.com] > Sent: Monday, July 23, 2018 10:05 PM > To: David Miller > Cc: Vakul Garg ; netdev@vger.kernel.org; > bor...@mellanox.com; avia...@mellanox.com; Doron Roberts-Kedes > > Subject: Re: [net-next v5 3/3] net/tls: Remove

[PATCH bpf] selftests/bpf: update test_lwt_seg6local.sh according to iproute2

2018-08-01 Thread Mathieu Xhonneux
The shell file for test_lwt_seg6local contains an early iproute2 syntax for installing a seg6local End.BPF route. iproute2 support for this feature has recently been upstreamed, but with an additional keyword required. This patch updates test_lwt_seg6local.sh to the definitive iproute2 syntax Sign

how PHY driver is notified that cable is unplugged? (possibly related to IFF_RUNNING flag)

2018-08-01 Thread rpjday
(warning that i have a few questions that are probably trivial until i get up to speed with networking code.) a colleague asked for advice about the following -- apparently a new PHY driver works properly when being brought up with "ifconfig up", part of that process apparently set

Re: [RFC PATCH 0/2] net: macb: Disable TX checksum offloading on all Zynq

2018-08-01 Thread Harini Katakam
Hi Jennifer, On Tue, Jun 5, 2018 at 10:21 AM, Harini Katakam wrote: > Hi Jeniffer, > > On Mon, Jun 4, 2018 at 8:35 PM, Nicolas Ferre > wrote: >> Jennifer, >> >> On 25/05/2018 at 23:44, Jennifer Dahm wrote: >>> >>> During testing, I discovered that the Zynq GEM hardware overwrites all >>> outgoin

[PATCH net-next] cxgb4: fix endian to test F_FW_PORT_CMD_DCBXDIS32

2018-08-01 Thread Ganesh Goudar
For FW_PORT_ACTION_GET_PORT_INFO32 messages, the u.info32.lstatus32_to_cbllen32 is 32-bit Big Endian. We need to translate that to CPU Endian in order to test F_FW_PORT_CMD_DCBXDIS32. Signed-off-by: Casey Leedom Signed-off-by: Ganesh Goudar --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c |

[PATCH net-next 6/9] net: stmmac: Add PTP support for XGMAC2

2018-08-01 Thread Jose Abreu
XGMAC2 uses the same engine of timestamping as GMAC4. Let's use the same callbacks. Signed-off-by: Jose Abreu Cc: David S. Miller Cc: Joao Pinto Cc: Giuseppe Cavallaro Cc: Alexandre Torgue --- drivers/net/ethernet/stmicro/stmmac/hwif.c | 4 ++-- drivers/net/ethernet/stmicro/stmmac/stmm

[PATCH net-next 7/9] net: stmmac: Integrate XGMAC into main driver flow

2018-08-01 Thread Jose Abreu
Now that we have all the XGMAC related callbacks, lets start integrating this IP block into main driver. Signed-off-by: Jose Abreu Cc: David S. Miller Cc: Joao Pinto Cc: Giuseppe Cavallaro Cc: Alexandre Torgue --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 55 ++-

[PATCH net-next 9/9] bindings: net: stmmac: Add the bindings documentation for XGMAC2.

2018-08-01 Thread Jose Abreu
Adds the documentation for XGMAC2 DT bindings. Signed-off-by: Jose Abreu Cc: David S. Miller Cc: Joao Pinto Cc: Giuseppe Cavallaro Cc: Alexandre Torgue --- Documentation/devicetree/bindings/net/stmmac.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Documentation/dev

[PATCH net-next 8/9] net: stmmac: Add the bindings parsing for XGMAC2

2018-08-01 Thread Jose Abreu
Add the bindings parsing for XGMAC2 IP block. Signed-off-by: Jose Abreu Cc: David S. Miller Cc: Joao Pinto Cc: Giuseppe Cavallaro Cc: Alexandre Torgue --- drivers/net/ethernet/stmicro/stmmac/dwmac-generic.c | 2 ++ drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 6 ++ 2 files c

[PATCH net-next 3/9] net: stmmac: Add DMA related callbacks for XGMAC2

2018-08-01 Thread Jose Abreu
Add the DMA related callbacks for the new IP block XGMAC2. Signed-off-by: Jose Abreu Cc: David S. Miller Cc: Joao Pinto Cc: Giuseppe Cavallaro Cc: Alexandre Torgue --- drivers/net/ethernet/stmicro/stmmac/Makefile | 2 +- drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h | 56 +++ d

[PATCH net-next 5/9] net: stmmac: Add MDIO related functions for XGMAC2

2018-08-01 Thread Jose Abreu
Add the MDIO related funcionalities for the new IP block XGMAC2. Signed-off-by: Jose Abreu Cc: David S. Miller Cc: Joao Pinto Cc: Giuseppe Cavallaro Cc: Alexandre Torgue --- drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c | 88 +++ 1 file changed, 88 insertions(+) diff

[PATCH net-next 4/9] net: stmmac: Add descriptor related callbacks for XGMAC2

2018-08-01 Thread Jose Abreu
Add the descriptor related callbacks for the new IP block XGMAC2. Signed-off-by: Jose Abreu Cc: David S. Miller Cc: Joao Pinto Cc: Giuseppe Cavallaro Cc: Alexandre Torgue --- drivers/net/ethernet/stmicro/stmmac/Makefile | 3 +- drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h | 30

[PATCH net-next 2/9] net: stmmac: Add MAC related callbacks for XGMAC2

2018-08-01 Thread Jose Abreu
Add the MAC related callbacks for the new IP block XGMAC2. Signed-off-by: Jose Abreu Cc: David S. Miller Cc: Joao Pinto Cc: Giuseppe Cavallaro Cc: Alexandre Torgue --- drivers/net/ethernet/stmicro/stmmac/Makefile | 2 +- drivers/net/ethernet/stmicro/stmmac/common.h | 3 + dri

[PATCH net-next 0/9] Add 10GbE support in stmmac using XGMAC2

2018-08-01 Thread Jose Abreu
This series adds support for 10Gigabit IP in stmmac. The IP is called XGMAC2 and has many similarities with GMAC4. Due to this, its relatively easy to incorporate this new IP into stmmac driver by adding a new block and filling the necessary callbacks. The functionality added by this series is sti

[PATCH net-next 1/9] net: stmmac: Add XGMAC 2.10 HWIF entry

2018-08-01 Thread Jose Abreu
Add a new entry to HWIF table for XGMAC 2.10. For now we fill it with empty callbacks which will be added in posterior patches. Signed-off-by: Jose Abreu Cc: David S. Miller Cc: Joao Pinto Cc: Giuseppe Cavallaro Cc: Alexandre Torgue --- drivers/net/ethernet/stmicro/stmmac/common.h | 14 +

[patch net-next v2 3/3] net: sched: make tcf_chain_{get,put}() static

2018-08-01 Thread Jiri Pirko
From: Jiri Pirko These are no longer used outside of cls_api.c so make them static. Move tcf_chain_flush() to avoid fwd declaration of tcf_chain_put(). Signed-off-by: Jiri Pirko v1->v2: - new patch --- include/net/pkt_cls.h | 3 --- net/sched/cls_api.c | 34

[patch net-next v2 1/3] net: sched: change name of zombie chain to "held_by_acts_only"

2018-08-01 Thread Jiri Pirko
From: Jiri Pirko As mentioned by Cong and Jakub during the review process, it is a bit odd to sometimes (act flow) create a new chain which would be immediately a "zombie". So just rename it to "held_by_acts_only". Signed-off-by: Jiri Pirko Suggested-by: Cong Wang Suggested-by: Jakub Kicinski

[patch net-next v2 2/3] net: sched: fix notifications for action-held chains

2018-08-01 Thread Jiri Pirko
From: Jiri Pirko Chains that only have action references serve as placeholders. Until a non-action reference is created, user should not be aware of the chain. Also he should not receive any notifications about it. So send notifications for the new chain only in case the chain gets the first non-

[patch net-next v2 0/3] net: sched: couple of adjustments/fixes

2018-08-01 Thread Jiri Pirko
From: Jiri Pirko Jiri Pirko (3): net: sched: change name of zombie chain to "held_by_acts_only" net: sched: fix notifications for action-held chains net: sched: make tcf_chain_{get,put}() static include/net/pkt_cls.h | 3 -- net/sched/cls_api.c | 113 +++---

答复: [Patch net-next] net: hns3: fix return value error while hclge_cmd_csq_clean failed

2018-08-01 Thread tanhuazhong
Sorry, please ignore this patch. I will resend it. -邮件原件- 发件人: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] 代表 Huazhong Tan 发送时间: 2018年8月1日 17:53 收件人: da...@davemloft.net 抄送: netdev@vger.kernel.org; Linuxarm 主题: [Patch net-next] net: hns3: fix return value error whi

[Patch net-next V2] net: hns3: fix return value error while hclge_cmd_csq_clean failed

2018-08-01 Thread Huazhong Tan
While cleaning the command queue, the value of the HEAD register is not in the range of next_to_clean and next_to_use, meaning that this value is invalid. This also means that there is a hardware error and the hardware will trigger a reset soon. At this time we should return an error code instead o

[Patch net-next] net: hns3: fix return value error while hclge_cmd_csq_clean failed

2018-08-01 Thread Huazhong Tan
From: fredalu While cleaning the command queue, the value of the HEAD register is not in the range of next_to_clean and next_to_use, meaning that this value is invalid. This also means that there is a hardware error and the hardware will trigger a reset soon. At this time we should return an erro

Re: [patch net-next 2/2] net: sched: fix notifications for action-held chains

2018-08-01 Thread Jiri Pirko
Wed, Aug 01, 2018 at 06:27:28AM CEST, xiyou.wangc...@gmail.com wrote: >On Tue, Jul 31, 2018 at 5:10 AM Jiri Pirko wrote: >> >> From: Jiri Pirko >> >> Chains that only have action references serve as placeholders. >> Until a non-action reference is created, user should not be aware >> of the chain

Re: [net-next V2 12/12] net/mlx5e: Use PARTIAL_GSO for UDP segmentation

2018-08-01 Thread Boris Pismenny
On 7/24/2018 8:35 PM, Saeed Mahameed wrote: On Tue, Jul 24, 2018 at 7:53 AM, Alexander Duyck wrote: On Mon, Jul 23, 2018 at 3:11 PM, Saeed Mahameed wrote: From: Boris Pismenny This patch removes the splitting of UDP_GSO_L4 packets in the driver, and exposes UDP_GSO_L4 as a PARTIAL_GSO fe