On 27/09/18 17:32, Eric Dumazet wrote:
> As diagnosed by Song Liu, ndo_poll_controller() can
> be very dangerous on loaded hosts, since the cpu
> calling ndo_poll_controller() might steal all NAPI
> contexts (for all RX/TX queues of the NIC). This capture
> can last for unlimited amount of time, si
On 27/09/18 17:31, Eric Dumazet wrote:
> As diagnosed by Song Liu, ndo_poll_controller() can
> be very dangerous on loaded hosts, since the cpu
> calling ndo_poll_controller() might steal all NAPI
> contexts (for all RX/TX queues of the NIC). This capture
> can last for unlimited amount of time, si
On Fri, Sep 28, 2018 at 8:09 AM wrote:
>
> From: Sunil Goutham
>
> This patch adds basic template for Marvell OcteonTX2's
> CGX ethernet interface driver. Just the probe.
> RVU AF driver will use APIs exported by this driver
> for various things like PF to physical interface mapping,
> loopback m
On Fri, Sep 28, 2018 at 8:09 AM wrote:
>
> +/* scratchx(0) CSR used for ATF->non-secure SW communication.
> + * This acts as the status register
> + * Provides details on command ack/status, link status, error details
> + */
> +struct cgx_evt_sts {
> + uint64_t ack:1;
> + uint64_t evt_
On Fri, Sep 28, 2018 at 8:08 AM wrote:
>
> From: Sunil Goutham
>
> Resource virtualization unit (RVU) on Marvell's OcteonTX2 SOC maps HW
> resources from the network, crypto and other functional blocks into
> PCI-compatible physical and virtual functions. Each functional block
> again has multipl
Hello!
On 9/27/2018 7:21 PM, Jeff Kirsher wrote:
From: Jacob Keller
When shutting down the controlqs, we check if they are initialized
before we shut them down and destroy the lock. This is important, as it
prevents attempts to access the lock of an already shutdown queue.
Unfortunately, we
On 26.09.2018 19:39, David Miller wrote:
> From: Julian Wiedmann
> Date: Wed, 26 Sep 2018 18:07:08 +0200
>
>> please apply two qeth patches for -net. The first is a trivial cleanup
>> required for patch #2 by Jean, which fixes a potential endless loop.
>
> Series applied, thank you.
>
Odd, doe
On Thu, Sep 27, 2018 at 02:37:30PM -0700, Yonghong Song wrote:
> Currently, helper bpf_get_current_cgroup_id() is not permitted
> for CGROUP_DEVICE type of programs. If the helper is used
> in such cases, the verifier will log the following error:
>
> 0: (bf) r6 = r1
> 1: (69) r7 = *(u16 *)(r6
On Fri, Sep 28, 2018 at 1:45 PM Arnd Bergmann wrote:
>
> On Fri, Sep 28, 2018 at 8:09 AM wrote:
> >
> > From: Sunil Goutham
> >
> > This patch adds basic template for Marvell OcteonTX2's
> > CGX ethernet interface driver. Just the probe.
> > RVU AF driver will use APIs exported by this driver
>
On Fri, Sep 28, 2018 at 1:49 PM Arnd Bergmann wrote:
>
> On Fri, Sep 28, 2018 at 8:09 AM wrote:
> >
> > +/* scratchx(0) CSR used for ATF->non-secure SW communication.
> > + * This acts as the status register
> > + * Provides details on command ack/status, link status, error details
> > + */
> > +
On Fri, Sep 28, 2018 at 1:57 PM Arnd Bergmann wrote:
>
> On Fri, Sep 28, 2018 at 8:08 AM wrote:
> >
> > From: Sunil Goutham
> >
> > Resource virtualization unit (RVU) on Marvell's OcteonTX2 SOC maps HW
> > resources from the network, crypto and other functional blocks into
> > PCI-compatible phy
On Thu, Sep 27, 2018 at 04:26:51PM -0700, Joe Stringer wrote:
> Teach the verifier a little bit about a new type of pointer, a
> PTR_TO_SOCKET. This pointer type is accessed from BPF through the
> 'struct bpf_sock' structure.
>
> Signed-off-by: Joe Stringer
Acked-by: Alexei Starovoitov
On Thu, Sep 27, 2018 at 04:26:54PM -0700, Joe Stringer wrote:
> This patch adds new BPF helper functions, bpf_sk_lookup_tcp() and
> bpf_sk_lookup_udp() which allows BPF programs to find out if there is a
> socket listening on this host, and returns a socket pointer which the
> BPF program can then
On Thu, Sep 27, 2018 at 02:37:30PM -0700, Yonghong Song wrote:
> Currently, helper bpf_get_current_cgroup_id() is not permitted
> for CGROUP_DEVICE type of programs. If the helper is used
> in such cases, the verifier will log the following error:
>
> 0: (bf) r6 = r1
> 1: (69) r7 = *(u16 *)(r6
On Fri, Sep 28, 2018 at 11:31 AM Sunil Kovvuri wrote:
> On Fri, Sep 28, 2018 at 1:49 PM Arnd Bergmann wrote:
> > On Fri, Sep 28, 2018 at 8:09 AM wrote:
> This communication between firmware and kernel driver is done using couple of
> scratch registers. With limited space available we had to res
Hello Dave.
An update from ieee802154 for your *net* tree.
Some cleanup patches throughout the drivers from the Huawei tag team
Yue Haibing and Zhong Jiang.
Xue is replacing some magic numbers with defines in his mcr20a driver.
regards
Stefan Schmidt
The following changes since commit 10bc6a604
On Fri, Sep 28, 2018 at 09:08:26AM +0800, Hangbin Liu wrote:
> Phil pointed out that there is a mismatch between vxlan and geneve ttl
> inherit.
> We should define it as a flag and use nla_put_flag to export this opiton.
s/opiton/option/
Apart from that, LGTM!
Thanks, Phil
On Fri, Sep 28, 2018 at 09:09:58AM +0800, Hangbin Liu wrote:
> Phil pointed out that there is a mismatch between vxlan and geneve ttl
> inherit. We should define it as a flag and use nla_put_flag to export this
> opiton.
Same typo here. :)
Apart from that, LGTM!
Thanks, Phil
On Thu 27 Sep 2018 at 20:42, Cong Wang wrote:
> It is clearly a copy-n-paste.
>
> Signed-off-by: Cong Wang
> ---
> net/sched/cls_api.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c
> index 3de47e99b788..8dd7f8af6d54 100644
> --
On 09/28/2018 11:53 AM, Roman Gushchin wrote:
> On Thu, Sep 27, 2018 at 02:37:30PM -0700, Yonghong Song wrote:
>> Currently, helper bpf_get_current_cgroup_id() is not permitted
>> for CGROUP_DEVICE type of programs. If the helper is used
>> in such cases, the verifier will log the following error:
On Fri, Sep 28, 2018 at 12:37:00PM +0200, Phil Sutter wrote:
> On Fri, Sep 28, 2018 at 09:08:26AM +0800, Hangbin Liu wrote:
> > Phil pointed out that there is a mismatch between vxlan and geneve ttl
> > inherit.
> > We should define it as a flag and use nla_put_flag to export this opiton.
>
> s/o
Forwarding to corrected netdev address.
Forwarded Message
Subject: R8169: Network lockups in 4.18.{8,9,10} (and 4.19 dev)
Date: Fri, 28 Sep 2018 13:14:35 +0100
From: Chris Clayton
To: linux-net...@vger.kernel.org
CC: David Miller , a3at.m...@gmail.com, Greg Kroah-Hartman
,
hka
On 26/09/18 09:47, Ariel Almog wrote:
> I was won
Truncated sentence? ("... wondering"?)
> I find the ability to set off, auto and specific FEC mode in the same
> command confusing.
I didn't try to define semantics here since each driver currently does
something slightly different. Probably the
Hi Joe,
On 09/28/2018 01:26 AM, Joe Stringer wrote:
> Teach the verifier a little bit about a new type of pointer, a
> PTR_TO_SOCKET. This pointer type is accessed from BPF through the
> 'struct bpf_sock' structure.
>
> Signed-off-by: Joe Stringer
[...]
> }
> @@ -1726,6 +1755,14 @@ static
On 09/28/2018 01:26 AM, Joe Stringer wrote:
> Teach the verifier a little bit about a new type of pointer, a
> PTR_TO_SOCKET. This pointer type is accessed from BPF through the
> 'struct bpf_sock' structure.
>
> Signed-off-by: Joe Stringer
[...]
> diff --git a/net/core/filter.c b/net/core/filter.
On 26/09/18 23:16, Jiong Wang wrote:
> On 22/08/2018 20:00, Edward Cree wrote:
>> In the future this idea may be extended to form use-def chains.
>
> 1. instruction level use->def chain
>
> - new use->def chains for each instruction. one eBPF insn could have two
> uses at maximum.
I w
On 09/28/2018 01:26 AM, Joe Stringer wrote:
> Teach the verifier a little bit about a new type of pointer, a
> PTR_TO_SOCKET. This pointer type is accessed from BPF through the
> 'struct bpf_sock' structure.
>
> Signed-off-by: Joe Stringer
[...]
> +/* Return true if it's OK to have the same insn
On 09/28/2018 01:26 AM, Joe Stringer wrote:
> Add this iterator for spilled registers, it concentrates the details of
> how to get the current frame's spilled registers into a single macro
> while clarifying the intention of the code which is calling the macro.
>
> Signed-off-by: Joe Stringer
> A
From: Pieter Jansen van Vuuren
Allow matching on options in Geneve tunnel headers.
The options can be described in the form
CLASS:TYPE:DATA/CLASS_MASK:TYPE_MASK:DATA_MASK, where CLASS is
represented as a 16bit hexadecimal value, TYPE as an 8bit
hexadecimal value and DATA as a variable length hex
On Wed, Sep 19, 2018 at 04:37:29PM -0700, Cong Wang wrote:
> From: Vlad Buslov
>
> From: Vlad Buslov
>
> Action API was changed to work with actions and action_idr in concurrency
> safe manner, however tcf_del_walker() still uses actions without taking a
> reference or idrinfo->lock first, and
On Fri, Sep 28, 2018 at 05:59:00PM +0300, Ido Schimmel wrote:
> I'm getting a use-after-free when running tc_chains.sh selftest and I
> believe it's caused by this patch.
BTW, I can't reproduce the issue after reverting the patch.
> For us, those semantics make sense (our HW has a notion of 'supported'
> and 'requested' bits for each FEC type for each of local-device, cable
> and link-partner, and uses the strongest FEC mode that's supported by
> everyone and requested by anyone); but if something else is a better fit
>
From: David Ahern
Pass extack to dump callbacks by adding extack to netlink_dump_control
and transferring to netlink_callback. Update rtnetlink as the first
user.
Signed-off-by: David Ahern
---
include/linux/netlink.h | 2 ++
net/core/rtnetlink.c | 1 +
net/netlink/af_netlink.c | 1 +
3 f
From: David Ahern
There are many use cases where a user wants to influence what is
returned in a dump for some rtnetlink command: one is wanting data
for a different namespace than the one the request is received and
another is limiting the amount of data returned in the dump to a
specific set of
From: David Ahern
Update inet6_dump_addr to check for NLM_F_DUMP_PROPER_HDR in the netlink
message header. If the flag is set, the dump request is expected to have
an ifaddrmsg struct as the header potentially followed by one or more
attributes. Any data passed in the header or as an attribute is
From: David Ahern
Add a new flag, NLM_F_DUMP_PROPER_HDR, for userspace to indicate to the
kernel that it believes it is sending the right header struct for the
dump message type (ifinfomsg, ifaddrmsg, rtmsg, fib_rule_hdr, ...).
Setting the flag in the netlink message header indicates to the kern
From: David Ahern
Update inet_dump_ifaddr to check for NLM_F_DUMP_PROPER_HDR in the netlink
message header. If the flag is set, the dump request is expected to have
an ifaddrmsg struct as the header potentially followed by one or more
attributes. Any data passed in the header or as an attribute i
From: David Ahern
Pull the inet6_fill_args arg up to in6_dump_addrs and move netnsid
into it. Since IFA_TARGET_NETNSID is a kernel side filter add the
NLM_F_DUMP_FILTERED flag so userspace knows the request was honored.
Signed-off-by: David Ahern
---
net/ipv6/addrconf.c | 59 ++
Hi Samuel,
Please see my comment below.
Thanks,
Justin
> On Thu, 2018-09-27 at 21:08 +, justin.l...@dell.com wrote:
> > The new command (NCSI_CMD_SEND_CMD) is added to allow user space
> > application
> > to send NC-SI command to the network card.
> > Also, add a new attribute (NCSI_ATTR_
On 28/09/18 16:39, Andrew Lunn wrote:
> I wonder how true that will be in 5 years time, about reading the
> manual? SFP sockets are starting to appear in consumer devices. There
> are some Marvell SoC reference boards with SFP and SFP+. Broadcom also
> have some boards with SFP. With time, SFP will
Callers of bond_for_each_slave_rcu are expected to hold the rcu lock,
otherwise a trace like below is shown
WARNING: CPU: 2 PID: 179 at net/core/dev.c:6567
netdev_lower_get_next_private_rcu+0x34/0x40
CPU: 2 PID: 179 Comm: kworker/u16:15 Not tainted 4.19.0-rc5-backup+ #1
Workqueue: bond0 bond_mii_
On 2018-09-27 18:25, Eric Dumazet wrote:
On 09/27/2018 05:16 PM, stran...@codeaurora.org wrote:
Hi Yuchung,
Based on the dumps we were able to get, it appears that TFO was not
used in this case.
We also tried some local experiments where we dropped incoming SYN
packets after already
successf
> I see where you're coming from, but if people start needing to manually
> configure FEC on their consumer devices, possibly we have bigger
> problems.
Yes, i agree with that. For the consumer market, SFPs needs to grow up
and start doing full and reliable auto-neg, just like copper Ethernet.
On Fri, Sep 28, 2018 at 9:18 AM Dave Jones wrote:
>
> Callers of bond_for_each_slave_rcu are expected to hold the rcu lock,
> otherwise a trace like below is shown
So why not take rcu read lock in netpoll_send_skb_on_dev() where
RCU is also assumed?
As I said, I can't explain why you didn't trig
On 9/25/18 3:15 PM, Roopa Prabhu wrote:
> From: Roopa Prabhu
>
> Signed-off-by: Roopa Prabhu
> ---
> ip/ipneigh.c | 2 ++
> 1 file changed, 2 insertions(+)
>
applied to iproute2-next.
And then I noticed you did not update the help or the man page. Please
send a follow up.
On Fri, Sep 28, 2018 at 4:36 AM Vlad Buslov wrote:
>
> On Thu 27 Sep 2018 at 20:42, Cong Wang wrote:
> > It is clearly a copy-n-paste.
> >
> > Signed-off-by: Cong Wang
> > ---
> > net/sched/cls_api.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/net/sched/cls_ap
On Thu, Sep 27, 2018 at 1:42 PM Cong Wang wrote:
>
> It is clearly a copy-n-paste.
>
> Signed-off-by: Cong Wang
I regret again for wasting my time, so:
NAcked-by: Cong Wang
I really don't care, do you?
From: Vlad Dumitrescu
Taking a one-iovec example, with rtnl->seq at 42. iovlen == 1, seq
becomes 43 on line 604, and a message is sent with nlmsg_seq == 43. If
a response with nlmsg_seq of 42 is received, the condition being fixed
in this patch would incorrectly accept it.
Fixes: 72a2ff3916e5 ("
From: YueHaibing
Date: Thu, 27 Sep 2018 06:45:06 +
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/ethernet/qlogic/qed/qed_ooo.c: In function 'qed_ooo_delete_isles':
> drivers/net/ethernet/qlogic/qed/qed_ooo.c:354:30: warning:
> variable 'p_archipelago' set but not used [-W
(Changing $subject as the discussion is going to a completely different topic)
On Thu, Sep 27, 2018 at 3:19 PM Eric Dumazet wrote:
>
>
>
> On 09/27/2018 02:36 PM, Cong Wang wrote:
>
> > I don't understand what you mean by changing ip command, you must
> > mean tc command, but still, I have no ide
From: Johannes Berg
Date: Thu, 27 Sep 2018 10:22:42 +0200
> On Wed, 2018-09-26 at 10:21 -0700, David Miller wrote:
>> From: Johannes Berg
>> Date: Wed, 26 Sep 2018 11:15:29 +0200
>>
>> > This adds nested policy validation, which lets you specify the
>> > nested attribute type, e.g. NLA_NESTED w
On Fri, Sep 28, 2018 at 09:55:52AM -0700, Cong Wang wrote:
> On Fri, Sep 28, 2018 at 9:18 AM Dave Jones wrote:
> >
> > Callers of bond_for_each_slave_rcu are expected to hold the rcu lock,
> > otherwise a trace like below is shown
>
> So why not take rcu read lock in netpoll_send_skb_on_dev
From: Stephen Hemminger
Date: Thu, 27 Sep 2018 10:47:01 +0200
> I haven't been doing reviews only but not active development on bridge
> code for several years. Roopa and Nikolay have been doing most of
> the new features and have agreed to take over as new co-maintainers.
>
> Signed-off-by: Ste
In the recent TCP/EDT patch series, I switched TCP and sch_fq
clocks from MONOTONIC to TAI, in order to meet the choice done
earlier for sch_etf packet scheduler.
But sure enough, this broke some setups were the TAI clock
jumps forward (by almost 50 year...), as reported
by Leonard Crestez.
If we
On 28/09/18 17:45, Andrew Lunn wrote:
> Now is a good time to change the API, since we are moving to a netlink
> socket. Which is why these questions were asked in the first place...
OK, well, I've posted sfc's semantics and view-from-the-hardware*; now
patiently waiting for other NIC vendors to c
On Fri, Sep 28, 2018 at 10:25 AM Dave Jones wrote:
>
> On Fri, Sep 28, 2018 at 09:55:52AM -0700, Cong Wang wrote:
> > On Fri, Sep 28, 2018 at 9:18 AM Dave Jones wrote:
> > >
> > > Callers of bond_for_each_slave_rcu are expected to hold the rcu lock,
> > > otherwise a trace like below is shown
On Wed, Sep 26, 2018 at 11:40 AM Yifeng Sun wrote:
>
> This patch fixes the bug that all datapath and vport ops are returning
> wrong values (OVS_FLOW_CMD_NEW or OVS_DP_CMD_NEW) in their replies.
>
> Signed-off-by: Yifeng Sun
I am surprised this was not found earlier.
Acked-by: Pravin B Shelar
From: Sudarsana Reddy Kalluru
Date: Wed, 26 Sep 2018 21:57:03 -0700
> Signed-off-by: Sudarsana Reddy Kalluru
> Signed-off-by: Ameen Rahman
Applied, thank you.
On Wed, Sep 26, 2018 at 2:58 AM Stefano Brivio wrote:
>
> Hi Pravin,
>
> On Wed, 15 Aug 2018 00:19:39 -0700
> Pravin Shelar wrote:
>
> > I understand fairness has cost, but we need to find right balance
> > between performance and fairness. Current fairness scheme is a
> > lockless algorithm with
From: Sudarsana Reddy Kalluru
Date: Thu, 27 Sep 2018 04:12:10 -0700
> The structure shared between driver and the management FW (mfw) differ in
> sizes. This would lead to issues when driver try to access the structure
> members which are not-aligned with the mfw copy e.g., data_ptr usage in the
From: Nikolay Aleksandrov
Date: Thu, 27 Sep 2018 16:35:13 +0300
> This test adds an fdb entry with the sticky flag and sends traffic from
> a different port with the same mac as a source address expecting the entry
> to not change ports if the flag is operating correctly.
>
> Signed-off-by: Niko
On 9/27/18 5:00 PM, Maciej Żenczykowski wrote:
> From: Maciej Żenczykowski
>
> Signed-off-by: Maciej Żenczykowski
> ---
> net/ipv4/route.c | 6 +-
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/net/ipv4/route.c b/net/ipv4/route.c
> index 048919713f4e..17953a52fbd0 100644
On 9/27/18 5:00 PM, Maciej Żenczykowski wrote:
> From: Maciej Żenczykowski
>
> Signed-off-by: Maciej Żenczykowski
> ---
> net/ipv6/route.c | 6 +-
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/net/ipv6/route.c b/net/ipv6/route.c
> index d28f83e01593..9cb024451fc5 100644
On 9/27/18 7:35 AM, Nikolay Aleksandrov wrote:
> Add support for the new sticky flag that can be set on fdbs and update the
> man page.
>
> CC: David Ahern
> Signed-off-by: Nikolay Aleksandrov
> ---
> bridge/fdb.c | 9 +++--
> man/man8/bridge.8 | 6 +-
> 2 files changed, 12 inserti
On 9/28/18 6:38 AM, Hangbin Liu wrote:
> On Fri, Sep 28, 2018 at 12:37:00PM +0200, Phil Sutter wrote:
>> On Fri, Sep 28, 2018 at 09:08:26AM +0800, Hangbin Liu wrote:
>>> Phil pointed out that there is a mismatch between vxlan and geneve ttl
>>> inherit.
>>> We should define it as a flag and use nl
This reverts commit 90c7afc96cbbd77f44094b5b651261968e97de67.
When the commit was merged, the code used nf_ct_put() to free
the entry, but later on commit 76644232e612 ("openvswitch: Free
tmpl with tmpl_free.") replaced that with nf_ct_tmpl_free which
is a more appropriate. Now the original proble
On Fri, Sep 28, 2018 at 7:59 AM Ido Schimmel wrote:
>
> On Wed, Sep 19, 2018 at 04:37:29PM -0700, Cong Wang wrote:
> > From: Vlad Buslov
> >
> > From: Vlad Buslov
> >
> > Action API was changed to work with actions and action_idr in concurrency
> > safe manner, however tcf_del_walker() still use
On 9/27/18 7:08 PM, Hangbin Liu wrote:
> Phil pointed out that there is a mismatch between vxlan and geneve ttl
> inherit.
> We should define it as a flag and use nla_put_flag to export this opiton.
>
> Fixes: 8fd780698745b ("vxlan: fill ttl inherit info")
Wrong Fixes tag:
kenny:mgmt:iproute2-n
On 9/27/18 7:09 PM, Hangbin Liu wrote:
> Phil pointed out that there is a mismatch between vxlan and geneve ttl
> inherit. We should define it as a flag and use nla_put_flag to export this
> opiton.
>
> Fixes: 52d0d404d39dd ("geneve: add ttl inherit support")
same here .. getting an unknown commi
From: Wei Yongjun
Date: Thu, 27 Sep 2018 14:47:56 +
> Fixes the following sparse warning:
>
> net/sched/sch_generic.c:944:6: warning:
> symbol 'qdisc_free_cb' was not declared. Should it be static?
>
> Fixes: 3a7d0d07a386 ("net: sched: extend Qdisc with rcu")
> Signed-off-by: Wei Yongjun
From: Jeff Kirsher
Date: Thu, 27 Sep 2018 09:21:53 -0700
> This series contains fixes to the ice driver only.
...
> The following are changes since commit
> 1042caa79e9351b81ed19dc8d2d7fd6ff51a4422:
> net-ipv4: remove 2 always zero parameters from ipv4_redirect()
> and are available in the gi
On Fri, Sep 28, 2018 at 10:56:47AM -0700, Cong Wang wrote:
> On Fri, Sep 28, 2018 at 7:59 AM Ido Schimmel wrote:
> >
> > On Wed, Sep 19, 2018 at 04:37:29PM -0700, Cong Wang wrote:
> > > From: Vlad Buslov
> > >
> > > From: Vlad Buslov
> > >
> > > Action API was changed to work with actions and ac
From: Eric Dumazet
Date: Thu, 27 Sep 2018 09:31:50 -0700
> As diagnosed by Song Liu, ndo_poll_controller() can
> be very dangerous on loaded hosts, since the cpu
> calling ndo_poll_controller() might steal all NAPI
> contexts (for all RX/TX queues of the NIC).
>
> This capture, showing one ksoft
The new command (NCSI_CMD_SEND_CMD) is added to allow user space application
to send NC-SI command to the network card.
Also, add a new attribute (NCSI_ATTR_DATA) for transferring request and
response.
The work flow is as below.
Request:
User space application -> Netlink interface (msg)
On Fri, Sep 28, 2018 at 10:31:39AM -0700, Cong Wang wrote:
> On Fri, Sep 28, 2018 at 10:25 AM Dave Jones wrote:
> >
> > On Fri, Sep 28, 2018 at 09:55:52AM -0700, Cong Wang wrote:
> > > On Fri, Sep 28, 2018 at 9:18 AM Dave Jones
> > wrote:
> > > >
> > > > Callers of bond_for_each_slave_
Callers of bond_for_each_slave_rcu are expected to hold the rcu lock,
otherwise a trace like below is shown
WARNING: CPU: 2 PID: 179 at net/core/dev.c:6567
netdev_lower_get_next_private_rcu+0x34/0x40
CPU: 2 PID: 179 Comm: kworker/u16:15 Not tainted 4.19.0-rc5-backup+ #1
Workqueue: bond0 bond_mii_
On Fri, Sep 28, 2018 at 11:11 AM Ido Schimmel wrote:
> I don't think this will work given the reference count already dropped
> to 0, which is why the template deletion function was invoked. I didn't
> test the patch, but I don't see what would prevent the chain from being
> freed.
Good catch! So
On 09/28/2018 11:24 AM, Dave Jones wrote:
> Callers of bond_for_each_slave_rcu are expected to hold the rcu lock,
> otherwise a trace like below is shown
>
> WARNING: CPU: 2 PID: 179 at net/core/dev.c:6567
> netdev_lower_get_next_private_rcu+0x34/0x40
> CPU: 2 PID: 179 Comm: kworker/u16:15 Not
On Fri, Sep 28, 2018 at 08:45:01AM -0700, dsah...@kernel.org wrote:
> From: David Ahern
>
> Update inet_dump_ifaddr to check for NLM_F_DUMP_PROPER_HDR in the netlink
> message header. If the flag is set, the dump request is expected to have
> an ifaddrmsg struct as the header potentially followed
On Fri, Sep 28, 2018 at 08:45:02AM -0700, dsah...@kernel.org wrote:
> From: David Ahern
>
> Update inet6_dump_addr to check for NLM_F_DUMP_PROPER_HDR in the netlink
> message header. If the flag is set, the dump request is expected to have
> an ifaddrmsg struct as the header potentially followed
On 9/28/18 12:41 PM, Christian Brauner wrote:
>> @@ -1683,15 +1683,45 @@ static int inet_dump_ifaddr(struct sk_buff *skb,
>> struct netlink_callback *cb)
>> s_idx = idx = cb->args[1];
>> s_ip_idx = ip_idx = cb->args[2];
>>
>> -if (nlmsg_parse(cb->nlh, sizeof(struct ifaddrmsg), tb,
On Fri, Sep 28, 2018 at 08:44:58AM -0700, dsah...@kernel.org wrote:
> From: David Ahern
>
> Pass extack to dump callbacks by adding extack to netlink_dump_control
> and transferring to netlink_callback. Update rtnetlink as the first
> user.
>
> Signed-off-by: David Ahern
I like the idea of pas
On Fri, Sep 28, 2018 at 08:44:59AM -0700, dsah...@kernel.org wrote:
> From: David Ahern
>
> Pull the inet6_fill_args arg up to in6_dump_addrs and move netnsid
> into it. Since IFA_TARGET_NETNSID is a kernel side filter add the
> NLM_F_DUMP_FILTERED flag so userspace knows the request was honored.
On Fri, Sep 28, 2018 at 08:44:57AM -0700, dsah...@kernel.org wrote:
> From: David Ahern
>
> There are many use cases where a user wants to influence what is
> returned in a dump for some rtnetlink command: one is wanting data
> for a different namespace than the one the request is received and
>
On Fri, Sep 28, 2018 at 11:26 AM Dave Jones wrote:
> diff --git a/net/core/netpoll.c b/net/core/netpoll.c
> index 3219a2932463..4f9494381635 100644
> --- a/net/core/netpoll.c
> +++ b/net/core/netpoll.c
> @@ -330,6 +330,7 @@ void netpoll_send_skb_on_dev(struct netpoll *np, struct
> sk_buff *skb,
>
On Fri, Sep 28, 2018 at 12:02 PM Cong Wang wrote:
>
> On Fri, Sep 28, 2018 at 11:26 AM Dave Jones wrote:
> > diff --git a/net/core/netpoll.c b/net/core/netpoll.c
> > index 3219a2932463..4f9494381635 100644
> > --- a/net/core/netpoll.c
> > +++ b/net/core/netpoll.c
> > @@ -330,6 +330,7 @@ void netp
From: David Ahern
Link dumps can return results from a target namespace. If the namespace id
is invalid, then the dump request should fail if get_target_net fails
rather than continuing with a dump of the current namespace.
Fixes: 79e1ad148c844 ("rtnetlink: use netnsid to query interface")
Signe
Currently, rtnl_fdb_dump() assumes the family header is 'struct ifinfomsg',
which is not always true. For example, 'struct ndmsg' is used by iproute2
as well (in the 'ip neigh' command).
The problem is, the function bails out early if nlmsg_parse() fails, which
does occur for iproute2 usage of 's
On 27.09.2018 05:04, David Miller wrote:
> From: Heiner Kallweit
> Date: Mon, 24 Sep 2018 21:58:04 +0200
>
>> phy_suspend doesn't always recognize that WoL is enabled and therefore
>> suspends the PHY when it should not. First idea to address the issue
>> was to reuse checks used in mdio_bus_phy_
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git
master
head: 5362700c942b2cc4bab328361545a6d6fe649534
commit: 4dc13b9668d8ba7a5d1a26b88fa30baa8a214dcc [729/738] net: hns3: Add
serdes parallel inner loopback support
config: i386-allmodconfig (attached as .config)
compi
On Fri, Sep 28, 2018 at 12:03:22PM -0700, Cong Wang wrote:
> On Fri, Sep 28, 2018 at 12:02 PM Cong Wang wrote:
> >
> > On Fri, Sep 28, 2018 at 11:26 AM Dave Jones
> > wrote:
> > > diff --git a/net/core/netpoll.c b/net/core/netpoll.c
> > > index 3219a2932463..4f9494381635 100644
> > > ---
Previously TCP initial receive buffer is ~87KB by default and
the initial receive window is ~29KB (20 MSS). This patch changes
the two numbers to 128KB and ~64KB (rounding down to the multiples
of MSS) respectively. The patch also simplifies the calculations s.t.
the two numbers are directly contro
Some of the chip-specific hw_start functions set bit TXCFG_AUTO_FIFO
in register TxConfig. The original patch changed the order of some
calls resulting in these changes being overwritten by
rtl_set_tx_config_registers() in rtl_hw_start(). This eventually
resulted in network stalls especially under
The bonding driver lacks the rcu lock when it calls down into
netdev_lower_get_next_private_rcu from bond_poll_controller, which
results in a trace like:
WARNING: CPU: 2 PID: 179 at net/core/dev.c:6567
netdev_lower_get_next_private_rcu+0x34/0x40
CPU: 2 PID: 179 Comm: kworker/u16:15 Not tainted 4.
internal pacing timer to CLOCK_TAI")
> Signed-off-by: Eric Dumazet
> Reported-by: Leonard Crestez
Tested-by: Leonard Crestez
Fixes the problem reported earlier when applied on top of next-20180928
On 28.09.2018 22:19, Heiner Kallweit wrote:
> Some of the chip-specific hw_start functions set bit TXCFG_AUTO_FIFO
> in register TxConfig. The original patch changed the order of some
> calls resulting in these changes being overwritten by
> rtl_set_tx_config_registers() in rtl_hw_start(). This eve
Small changes addressing races discovered by syzbot.
First patch is a cleanup.
Second patch moves a mutex init sooner.
Third patch makes sure each tfile gets its own napi enable flags.
Eric Dumazet (3):
tun: remove unused parameters
tun: initialize napi_mutex unconditionally
tun: napi flags
This is the first part to fix following syzbot report :
console output: https://syzkaller.appspot.com/x/log.txt?x=145378e640
kernel config: https://syzkaller.appspot.com/x/.config?x=443816db871edd66
dashboard link: https://syzkaller.appspot.com/bug?extid=e662df0ac1d753b57e80
Following patch
Some of the chip-specific hw_start functions set bit TXCFG_AUTO_FIFO
in register TxConfig. The original patch changed the order of some
calls resulting in these changes being overwritten by
rtl_set_tx_config_registers() in rtl_hw_start(). This eventually
resulted in network stalls especially under
tun_napi_disable() and tun_napi_del() do not need
a pointer to the tun_struct
Signed-off-by: Eric Dumazet
---
drivers/net/tun.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/net/tun.c b/drivers/net/tun.c
index
e2648b5a3861e51dc6c40d19e1198a5f3f7ca7af..
1 - 100 of 124 matches
Mail list logo
