[PATCH net-next] net: phy: realtek: load driver for all PHYs with a Realtek OUI

2018-11-06 Thread Heiner Kallweit
Instead of listing every single PHYID, load the driver for every PHYID with a Realtek OUI, independent of model number and revision. This patch also improves two further aspects: - constify realtek_tbl[] - the mask should have been 0x instead of 0x001f so far, by masking out some

Re: [PATCH rdma] net/mlx5: Fix XRC SRQ umem valid bits

2018-11-06 Thread Leon Romanovsky
On Tue, Nov 06, 2018 at 03:11:53PM -0700, Jason Gunthorpe wrote: > On Tue, Nov 06, 2018 at 05:10:53PM -0500, Doug Ledford wrote: > > On Tue, 2018-11-06 at 22:02 +, Jason Gunthorpe wrote: > > > On Tue, Nov 06, 2018 at 04:31:08PM -0500, Doug Ledford wrote: > > > > On Wed, 2018-10-31 at 12:20

[PATCH net-next] net: phy: make phy_trigger_machine static

2018-11-06 Thread Heiner Kallweit
phy_trigger_machine() is used in phy.c only, so we can make it static. Signed-off-by: Heiner Kallweit --- drivers/net/phy/phy.c | 33 - include/linux/phy.h | 1 - 2 files changed, 12 insertions(+), 22 deletions(-) diff --git a/drivers/net/phy/phy.c

Re: [PATCH net-next 03/11] vxlan: Allow configuration of DF behaviour

2018-11-06 Thread Stephen Hemminger
On Tue, 6 Nov 2018 22:38:59 +0100 Stefano Brivio wrote: > df = htons(IP_DF); > } > > + if (!df) { > + if (vxlan->cfg.df == VXLAN_DF_SET) { > + df = htons(IP_DF); I am confused, this looks like

Join the Illuminati Brotherhood

2018-11-06 Thread Bright Terry
Greetings from the Illuminati order, Join the Illuminati Brotherhood for fame, knowledge, wealth and powers.

[PATCH] staging: rtl8723bs: Fix incorrect sense of ether_addr_equal

2018-11-06 Thread Larry Finger
In commit b37f9e1c3801 ("staging: rtl8723bs: Fix lines too long in update_recvframe_attrib()."), the refactoring involved replacing two memcmp() calls with ether_addr_equal() calls. What the author missed is that memcmp() returns false when the two strings are equal, whereas ether_addr_equal()

[PATCH bpf-next 3/3] selftests/bpf: Test narrow loads with off > 0 for bpf_sock_addr

2018-11-06 Thread Andrey Ignatov
Add more test cases for context bpf_sock_addr to test narrow loads with offset > 0 for ctx->user_ip4 field (__u32): * off=1, size=1; * off=2, size=1; * off=3, size=1; * off=2, size=2. Signed-off-by: Andrey Ignatov --- tools/testing/selftests/bpf/test_sock_addr.c | 28 +--- 1

[PATCH bpf-next 2/3] selftests/bpf: Test narrow loads with off > 0 in test_verifier

2018-11-06 Thread Andrey Ignatov
Test the following narrow loads in test_verifier for context __sk_buff: * off=1, size=1 - ok; * off=2, size=1 - ok; * off=3, size=1 - ok; * off=0, size=2 - ok; * off=1, size=2 - fail; * off=0, size=2 - ok; * off=3, size=2 - fail. Signed-off-by: Andrey Ignatov ---

[PATCH bpf-next 1/3] bpf: Allow narrow loads with offset > 0

2018-11-06 Thread Andrey Ignatov
Currently BPF verifier allows narrow loads for a context field only with offset zero. E.g. if there is a __u32 field then only the following loads are permitted: * off=0, size=1 (narrow); * off=0, size=2 (narrow); * off=0, size=4 (full). On the other hand LLVM can generate a load with

[PATCH bpf-next 0/3] bpf: Allow narrow loads with offset > 0

2018-11-06 Thread Andrey Ignatov
This patch set adds support for narrow loads with offset > 0 to BPF verifier. Patch 1 provides more details and is the main patch in the set. Patches 2 and 3 add new test cases to test_verifier and test_sock_addr selftests. Andrey Ignatov (3): bpf: Allow narrow loads with offset > 0

[PATCH net-next 5/7] nfp: flower: make nfp_fl_lag_changels_event() void

2018-11-06 Thread Jakub Kicinski
nfp_fl_lag_changels_event() never fails, and therefore we would never return NOTIFY_BAD for NETDEV_CHANGELOWERSTATE. Make this clearer by changing nfp_fl_lag_changels_event()'s return type to void. Signed-off-by: Jakub Kicinski Reviewed-by: John Hurley ---

[PATCH net-next 2/7] nfp: flower: add ipv6 set flow label and hop limit offload

2018-11-06 Thread Jakub Kicinski
From: Pieter Jansen van Vuuren Add ipv6 set flow label and hop limit action offload. Since pedit sets headers per 4 byte word, we need to ensure that setting either version, priority, payload_len or nexthdr does not get offloaded. Signed-off-by: Pieter Jansen van Vuuren Reviewed-by: Jakub

[PATCH net-next 6/7] nfp: register a notifier handler in a central location for the device

2018-11-06 Thread Jakub Kicinski
Code interested in networking events registers its own notifier handlers. Create one device-wide notifier instance. Signed-off-by: Jakub Kicinski Reviewed-by: John Hurley --- drivers/net/ethernet/netronome/nfp/nfp_app.c | 47 drivers/net/ethernet/netronome/nfp/nfp_app.h |

[PATCH net-next 0/7] nfp: more set actions and notifier refactor

2018-11-06 Thread Jakub Kicinski
Hi! This series brings updates to flower offload code. First Pieter adds support for setting TTL, ToS, Flow Label and Hop Limit fields in IPv4 and IPv6 headers. Remaining 5 patches deal with factoring out netdev notifiers from flower code. We already have two instances, and more is coming, so

[PATCH net-next 4/7] nfp: flower: don't try to nack device unregister events

2018-11-06 Thread Jakub Kicinski
Returning an error from a notifier means we want to veto the change. We shouldn't veto NETDEV_UNREGISTER just because we couldn't find the tracking info for given master. I can't seem to find a way to trigger this unless we have some other bug, so it's probably not fix-worthy. While at it move

[PATCH net-next 1/7] nfp: flower: add ipv4 set ttl and tos offload

2018-11-06 Thread Jakub Kicinski
From: Pieter Jansen van Vuuren Add ipv4 set ttl and tos action offload. Since pedit sets headers per 4 byte word, we need to ensure that setting either version, ihl, protocol, total length or checksum does not get offloaded. Signed-off-by: Pieter Jansen van Vuuren Reviewed-by: John Hurley

[PATCH net-next 7/7] nfp: flower: use the common netdev notifier

2018-11-06 Thread Jakub Kicinski
Use driver's common notifier for LAG and tunnel configuration. Signed-off-by: Jakub Kicinski Reviewed-by: John Hurley --- .../ethernet/netronome/nfp/flower/lag_conf.c | 14 ++- .../net/ethernet/netronome/nfp/flower/main.c | 23 +++ .../net/ethernet/netronome/nfp/flower/main.h |

[PATCH net-next 3/7] nfp: flower: remove unnecessary iteration over devices

2018-11-06 Thread Jakub Kicinski
For flower tunnel offloads FW has to be informed about MAC addresses of tunnel devices. We use a netdev notifier to keep track of these addresses. Remove unnecessary loop over netdevices after notifier is registered. The intention of the loop was to catch devices which already existed on the

Re: [PATCH bpf-next v2 02/13] bpf: btf: Add BTF_KIND_FUNC and BTF_KIND_FUNC_PROTO

2018-11-06 Thread Alexei Starovoitov
On Tue, Nov 06, 2018 at 10:58:42PM +, Edward Cree wrote: >  share its type record with 'foo'.  And partly just because the >  name of the function itself is no more part of its type than the >  name of an integer variable is part of the integer's type. correct. function name is not part of

Re: [PATCH RFC net-next 0/3] net: phy: sfp: Warn when using generic PHY driver

2018-11-06 Thread Andrew Lunn
> Another approach could be to maintain a list of modules that do not work > with the generic PHY driver and therefore require a specialized driver, > in that case we could even go as far as not letting sfp_sm_probe_phy() > return success. Not sure how well things would scale, probably not too >

[net-next:master 8/13] drivers/net/dsa/bcm_sf2_cfp.c:532:2-3: Unneeded semicolon

2018-11-06 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: 5882d526d887e42ead4014d79620e5a8aa741151 commit: ae7a5aff783c79d5ca87867df84b08c43447159b [8/13] net: dsa: bcm_sf2: Keep copy of inserted rules coccinelle warnings: (new ones prefixed by >>) >>

[PATCH] net: dsa: bcm_sf2: fix semicolon.cocci warnings

2018-11-06 Thread kbuild test robot
From: kbuild test robot drivers/net/dsa/bcm_sf2_cfp.c:1168:2-3: Unneeded semicolon drivers/net/dsa/bcm_sf2_cfp.c:532:2-3: Unneeded semicolon Remove unneeded semicolon. Generated by: scripts/coccinelle/misc/semicolon.cocci Fixes: ae7a5aff783c ("net: dsa: bcm_sf2: Keep copy of inserted

Re: [PATCH RFC net-next 0/3] net: phy: sfp: Warn when using generic PHY driver

2018-11-06 Thread Florian Fainelli
On 11/6/18 4:34 PM, Russell King - ARM Linux wrote: > On Tue, Nov 06, 2018 at 04:09:35PM -0800, Florian Fainelli wrote: >> On 11/6/18 4:03 PM, Russell King - ARM Linux wrote: >>> On Tue, Nov 06, 2018 at 03:38:44PM -0800, David Miller wrote: From: Florian Fainelli Date: Tue, 6 Nov 2018

Re: [PATCH v2 1/3] bpf: allow zero-initializing hash map seed

2018-11-06 Thread Song Liu
On Thu, Oct 25, 2018 at 8:12 AM Lorenz Bauer wrote: > > On Tue, 9 Oct 2018 at 01:08, Song Liu wrote: > > > > > --- a/include/uapi/linux/bpf.h > > > +++ b/include/uapi/linux/bpf.h > > > @@ -253,6 +253,8 @@ enum bpf_attach_type { > > > #define BPF_F_NO_COMMON_LRU(1U << 1) > > > /* Specify

[PATCH net-next] net: phy: bcm7xxx: Add entry for BCM7255

2018-11-06 Thread Florian Fainelli
From: Justin Chen Add support for BCM7255 EPHY. Signed-off-by: Justin Chen Signed-off-by: Florian Fainelli --- drivers/net/phy/bcm7xxx.c | 2 ++ include/linux/brcmphy.h | 1 + 2 files changed, 3 insertions(+) diff --git a/drivers/net/phy/bcm7xxx.c b/drivers/net/phy/bcm7xxx.c index

Re: [PATCH RFC net-next 0/3] net: phy: sfp: Warn when using generic PHY driver

2018-11-06 Thread Russell King - ARM Linux
On Tue, Nov 06, 2018 at 04:09:35PM -0800, Florian Fainelli wrote: > On 11/6/18 4:03 PM, Russell King - ARM Linux wrote: > > On Tue, Nov 06, 2018 at 03:38:44PM -0800, David Miller wrote: > >> From: Florian Fainelli > >> Date: Tue, 6 Nov 2018 15:29:10 -0800 > >> > >>> This patch series allows

Re: [PATCH bpf-next] bpf_load: add map name to load_maps error message

2018-11-06 Thread Song Liu
On Mon, Oct 29, 2018 at 3:12 PM John Fastabend wrote: > > On 10/29/2018 02:14 PM, Shannon Nelson wrote: > > To help when debugging bpf/xdp load issues, have the load_map() > > error message include the number and name of the map that > > failed. > > > > Signed-off-by: Shannon Nelson > > --- > >

Re: [PATCH RFC net-next 0/3] net: phy: sfp: Warn when using generic PHY driver

2018-11-06 Thread Florian Fainelli
On 11/6/18 4:03 PM, Russell King - ARM Linux wrote: > On Tue, Nov 06, 2018 at 03:38:44PM -0800, David Miller wrote: >> From: Florian Fainelli >> Date: Tue, 6 Nov 2018 15:29:10 -0800 >> >>> This patch series allows warning an user that the generic PHY driver(s) >>> are used when a SFP

Re: [PATCH RFC net-next 0/3] net: phy: sfp: Warn when using generic PHY driver

2018-11-06 Thread Russell King - ARM Linux
On Tue, Nov 06, 2018 at 03:38:44PM -0800, David Miller wrote: > From: Florian Fainelli > Date: Tue, 6 Nov 2018 15:29:10 -0800 > > > This patch series allows warning an user that the generic PHY driver(s) > > are used when a SFP incorporates a PHY (e.g: 1000BaseT SFP) which is > > likely not

Re: [PATCH RFC net-next 0/3] net: phy: sfp: Warn when using generic PHY driver

2018-11-06 Thread Florian Fainelli
On 11/6/18 3:38 PM, David Miller wrote: > From: Florian Fainelli > Date: Tue, 6 Nov 2018 15:29:10 -0800 > >> This patch series allows warning an user that the generic PHY driver(s) >> are used when a SFP incorporates a PHY (e.g: 1000BaseT SFP) which is >> likely not going to work at all. >> >>

Re: [PATCH net-next 0/3] net: systemport: Unmap queues upon DSA unregister event

2018-11-06 Thread David Miller
From: Florian Fainelli Date: Tue, 6 Nov 2018 15:15:15 -0800 > This patch series fixes the unbinding/binding of the bcm_sf2 switch > driver along with bcmsysport which monitors the switch port queues. > Because the driver was not processing the DSA_PORT_UNREGISTER event, we > would not be

Re: [PATCH RFC net-next 0/3] net: phy: sfp: Warn when using generic PHY driver

2018-11-06 Thread David Miller
From: Florian Fainelli Date: Tue, 6 Nov 2018 15:29:10 -0800 > This patch series allows warning an user that the generic PHY driver(s) > are used when a SFP incorporates a PHY (e.g: 1000BaseT SFP) which is > likely not going to work at all. > > Let me know if you would want to do that

[PATCH RFC net-next 2/3] net: phy: sfp: Issue warning when using Generic PHY driver(s)

2018-11-06 Thread Florian Fainelli
1000BaseT SFP modules typically include an Ethernet PHY device, and while the Generic PHY driver will be able to bind to it, it usually will not work at all without a specialized PHY driver. Issue a warning in that case to help toubleshoot things. Signed-off-by: Florian Fainelli ---

[PATCH RFC net-next 1/3] net: phy: Add helpers to determine if PHY driver is generic

2018-11-06 Thread Florian Fainelli
We are already checking in phy_detach() that the PHY driver is of generic kind (1G or 10G) and we are going to make use of that in the SFP layer as well for 1000BaseT SFP modules, so expose helper functions to return that information. Signed-off-by: Florian Fainelli ---

[PATCH RFC net-next 3/3] net: phy: Default MARVELL_PHY to the value of SFP

2018-11-06 Thread Florian Fainelli
Marvell PHYs are typically found in 1000BaseT SFP modules, so give a chance for users to get the correct PHY driver when using SFP modules. Signed-off-by: Florian Fainelli --- drivers/net/phy/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/phy/Kconfig

[PATCH RFC net-next 0/3] net: phy: sfp: Warn when using generic PHY driver

2018-11-06 Thread Florian Fainelli
Hi all, This patch series allows warning an user that the generic PHY driver(s) are used when a SFP incorporates a PHY (e.g: 1000BaseT SFP) which is likely not going to work at all. Let me know if you would want to do that differently. Florian Fainelli (3): net: phy: Add helpers to determine

Re: [PATCH net-next 09/11] udp: Support for error handlers of tunnels with arbitrary destination port

2018-11-06 Thread David Miller
From: Stefano Brivio Date: Tue, 6 Nov 2018 22:39:05 +0100 > diff --git a/include/net/ip6_tunnel.h b/include/net/ip6_tunnel.h > index 236e40ba06bf..7855966b4a19 100644 > --- a/include/net/ip6_tunnel.h > +++ b/include/net/ip6_tunnel.h > @@ -69,6 +69,8 @@ struct ip6_tnl_encap_ops { > size_t

Re: [PATCH net-next 01/11] udp: Handle ICMP errors for tunnels with same destination port on both endpoints

2018-11-06 Thread David Miller
From: Stefano Brivio Date: Tue, 6 Nov 2018 22:38:57 +0100 > + /* Network header needs to point to the outer IPv4 header inside ICMP */ > + skb_reset_network_header(skb); > + iph = ip_hdr(skb); > + /* Transport header needs to point to the UDP header */ > +

Re: [PATCH net-next 00/11] ICMP error handling for UDP tunnels

2018-11-06 Thread David Miller
From: Stefano Brivio Date: Tue, 6 Nov 2018 22:38:56 +0100 > This series introduces ICMP error handling for UDP tunnels and > encapsulations and related selftests. We need to handle ICMP errors to > support PMTU discovery and route redirection -- this support is entirely > missing right now: >

[PATCH net-next 2/3] net: systemport: Simplify queue mapping logic

2018-11-06 Thread Florian Fainelli
The use of a bitmap speeds up the finding of the first available queue to which we could start establishing the mapping for, but we still have to loop over all slave network devices to set them up. Simplify the logic to have a single loop, and use the fact that a correctly configured ring has

[PATCH net-next 3/3] net: systemport: Unmap queues upon DSA unregister event

2018-11-06 Thread Florian Fainelli
Binding and unbinding the switch driver which creates the DSA slave network devices for which we set-up inspection would lead to undesireable effects since we were not clearing the port/queue mapping to the SYSTEMPORT TX queue. Signed-off-by: Florian Fainelli ---

[PATCH net-next 1/3] net: dsa: bcm_sf2: Turn on PHY to allow successful registration

2018-11-06 Thread Florian Fainelli
We are binding to the PHY using the SF2 slave MDIO bus that we create, binding involves reading the PHY's MII_PHYSID1/2 which won't be possible if the PHY is turned off. Temporarily turn it on/off for the bus probing to succeeed. This fixes unbind/bind problems where the port connecting to that

[PATCH net-next 0/3] net: systemport: Unmap queues upon DSA unregister event

2018-11-06 Thread Florian Fainelli
Hi all, This patch series fixes the unbinding/binding of the bcm_sf2 switch driver along with bcmsysport which monitors the switch port queues. Because the driver was not processing the DSA_PORT_UNREGISTER event, we would not be unmapping switch port/queues, which could cause incorrect decisions

Re: [PATCH net-next 0/5] net: dsa: bcm_sf2: Store rules in lists

2018-11-06 Thread Florian Fainelli
On 11/6/18 3:06 PM, David Miller wrote: > From: Florian Fainelli > Date: Tue, 6 Nov 2018 12:58:36 -0800 > >> Hi all, >> >> This patch series changes the bcm-sf2 driver to keep a copy of the >> inserted rules as opposed to using the HW as a storage area for a number >> of reasons: >> >> - this

Re: [PATCH v4 1/3] net: emac: implement 802.1Q VLAN TX tagging support

2018-11-06 Thread David Miller
From: Christian Lamparter Date: Tue, 6 Nov 2018 23:27:49 +0100 > @@ -1435,6 +1436,22 @@ static inline netdev_tx_t emac_xmit_finish(struct > emac_instance *dev, int len) > return NETDEV_TX_OK; > } > > +static inline u16 emac_tx_vlan(struct emac_instance *dev, struct sk_buff > *skb) >

Re: [PATCH net-next 0/5] net: dsa: bcm_sf2: Store rules in lists

2018-11-06 Thread David Miller
From: Florian Fainelli Date: Tue, 6 Nov 2018 12:58:36 -0800 > Hi all, > > This patch series changes the bcm-sf2 driver to keep a copy of the > inserted rules as opposed to using the HW as a storage area for a number > of reasons: > > - this helps us with doing duplicate rule detection in a

Re: [PATCH net-next 0/3] net: More extack messages

2018-11-06 Thread David Miller
From: David Ahern Date: Tue, 6 Nov 2018 12:51:13 -0800 > From: David Ahern > > Add more extack messages for several link create errors (e.g., invalid > number of queues, unknown link kind) and invalid metrics argument. Series applied, thanks David.

Re: [PATCH bpf-next v2 02/13] bpf: btf: Add BTF_KIND_FUNC and BTF_KIND_FUNC_PROTO

2018-11-06 Thread Edward Cree
On 06/11/18 21:56, Alexei Starovoitov wrote: > that looks very weird to me. Why split func name from argument names? > The 'function name' as seen by the BTF may not be the symbol name > as seen in elf file. The symbol name will be in the symbol table, which is not the same  thing as the functions

Re: [PATCH net-next] ipv6: gro: do not use slow memcmp() in ipv6_gro_receive()

2018-11-06 Thread David Miller
From: Eric Dumazet Date: Tue, 6 Nov 2018 14:51:15 -0800 > On Tue, Nov 6, 2018 at 2:41 PM David Miller wrote: >> >> From: Eric Dumazet >> Date: Tue, 6 Nov 2018 14:25:52 -0800 >> >> > + if (unlikely(nlen > sizeof(struct ipv6hdr))) { >> > + if (memcmp(iph + 1,

Re: [PATCH net-next] ipv6: gro: do not use slow memcmp() in ipv6_gro_receive()

2018-11-06 Thread Eric Dumazet
On Tue, Nov 6, 2018 at 2:41 PM David Miller wrote: > > From: Eric Dumazet > Date: Tue, 6 Nov 2018 14:25:52 -0800 > > > + if (unlikely(nlen > sizeof(struct ipv6hdr))) { > > + if (memcmp(iph + 1, iph2 + 1, > > +nlen - sizeof(struct

Re: [PATCH net-next 1/3] devlink: Add fw_version_check generic parameter

2018-11-06 Thread Jakub Kicinski
On Tue, 6 Nov 2018 22:37:51 +0200, Ido Schimmel wrote: > On Tue, Nov 06, 2018 at 12:19:13PM -0800, Jakub Kicinski wrote: > > On Tue, 6 Nov 2018 20:05:00 +, Ido Schimmel wrote: > > > From: Shalom Toledo > > > > > > Many drivers checking the device's firmware version during the > > >

Re: [PATCH net-next] ipv6: gro: do not use slow memcmp() in ipv6_gro_receive()

2018-11-06 Thread David Miller
From: Eric Dumazet Date: Tue, 6 Nov 2018 14:25:52 -0800 > + if (unlikely(nlen > sizeof(struct ipv6hdr))) { > + if (memcmp(iph + 1, iph2 + 1, > +nlen - sizeof(struct ipv6hdr))) > + goto not_same_flow; > +

[PATCH v4 1/3] net: emac: implement 802.1Q VLAN TX tagging support

2018-11-06 Thread Christian Lamparter
As per' APM82181 Embedded Processor User Manual 26.1 EMAC Features: VLAN: - Support for VLAN tag ID in compliance with IEEE 802.3ac. - VLAN tag insertion or replacement for transmit packets This patch completes the missing code for the VLAN tx tagging support, as the the EMAC_MR1_VLE was

[PATCH v4 2/3] net: emac: implement TCP segmentation offload (TSO)

2018-11-06 Thread Christian Lamparter
This patch enables TSO(v4) hw feature for emac driver. As atleast the APM82181's TCP/IP acceleration hardware controller (TAH) provides TCP segmentation support in the transmit path. Signed-off-by: Christian Lamparter --- drivers/net/ethernet/ibm/emac/core.c | 112 ++-

[PATCH v4 3/3] net: emac: remove IBM_EMAC_RX_SKB_HEADROOM

2018-11-06 Thread Christian Lamparter
The EMAC driver had a custom IBM_EMAC_RX_SKB_HEADROOM Kconfig option that reserved additional skb headroom for RX. This patch removes the option and migrates the code to use napi_alloc_skb() and netdev_alloc_skb_ip_align() in its place. Signed-off-by: Christian Lamparter ---

[PATCH net-next] ipv6: gro: do not use slow memcmp() in ipv6_gro_receive()

2018-11-06 Thread Eric Dumazet
ipv6_gro_receive() compares 34 bytes using slow memcmp(), while handcoding with a couple of ipv6_addr_equal() is much faster. Before this patch, "perf top -e cycles:pp -C " would see memcmp() using ~10% of cpu cycles on a 40Gbit NIC receiving IPv6 TCP traffic. Signed-off-by: Eric Dumazet ---

Re: [PATCH rdma] net/mlx5: Fix XRC SRQ umem valid bits

2018-11-06 Thread Jason Gunthorpe
On Tue, Nov 06, 2018 at 05:10:53PM -0500, Doug Ledford wrote: > On Tue, 2018-11-06 at 22:02 +, Jason Gunthorpe wrote: > > On Tue, Nov 06, 2018 at 04:31:08PM -0500, Doug Ledford wrote: > > > On Wed, 2018-10-31 at 12:20 +0200, Leon Romanovsky wrote: > > > > From: Yishai Hadas > > > > > > > >

Re: [PATCH rdma] net/mlx5: Fix XRC SRQ umem valid bits

2018-11-06 Thread Doug Ledford
On Tue, 2018-11-06 at 22:02 +, Jason Gunthorpe wrote: > On Tue, Nov 06, 2018 at 04:31:08PM -0500, Doug Ledford wrote: > > On Wed, 2018-10-31 at 12:20 +0200, Leon Romanovsky wrote: > > > From: Yishai Hadas > > > > > > Adapt XRC SRQ to the latest HW specification with fixed definition > > >

Re: [PATCH rdma] net/mlx5: Fix XRC SRQ umem valid bits

2018-11-06 Thread Jason Gunthorpe
On Tue, Nov 06, 2018 at 04:31:08PM -0500, Doug Ledford wrote: > On Wed, 2018-10-31 at 12:20 +0200, Leon Romanovsky wrote: > > From: Yishai Hadas > > > > Adapt XRC SRQ to the latest HW specification with fixed definition > > around umem valid bits. The previous definition relied on a bit which >

Re: [PATCH bpf-next v2 02/13] bpf: btf: Add BTF_KIND_FUNC and BTF_KIND_FUNC_PROTO

2018-11-06 Thread Alexei Starovoitov
On Tue, Nov 06, 2018 at 06:52:11PM +, Edward Cree wrote: > On 06/11/18 06:29, Alexei Starovoitov wrote: > > BTF is not pure type information. BTF is everything that verifier needs > > to know to make safety decisions that bpf instruction set doesn't have. > Yes, I'm not disputing that and

[PATCH iproute2 net-next 0/2] Add DF configuration for VxLAN and GENEVE link types

2018-11-06 Thread Stefano Brivio
This series adds configuration of the DF bit in outgoing IPv4 packets for VxLAN and GENEVE link types. I also included uapi/linux/if_link.h changes for convenience, please let me know if I should repost without them. Stefano Brivio (2): iplink_vxlan: Add DF configuration iplink_geneve: Add

[PATCH iproute2 net-next 2/2] iplink_geneve: Add DF configuration

2018-11-06 Thread Stefano Brivio
Allow to set the DF bit behaviour for outgoing IPv4 packets: it can be always on, inherited from the inner header, or, by default, always off, which is the current behaviour. Signed-off-by: Stefano Brivio --- include/uapi/linux/if_link.h | 9 + ip/iplink_geneve.c | 29

[PATCH iproute2 net-next 1/2] iplink_vxlan: Add DF configuration

2018-11-06 Thread Stefano Brivio
Allow to set the DF bit behaviour for outgoing IPv4 packets: it can be always on, inherited from the inner header, or, by default, always off, which is the current behaviour. Signed-off-by: Stefano Brivio --- include/uapi/linux/if_link.h | 9 + ip/iplink_vxlan.c| 29

[PATCH net-next 03/11] vxlan: Allow configuration of DF behaviour

2018-11-06 Thread Stefano Brivio
Allow users to set the IPv4 DF bit in outgoing packets, or to inherit its value from the IPv4 inner header. If the encapsulated protocol is IPv6 and DF is configured to be inherited, always set it. For IPv4, inheriting DF from the inner header was probably intended from the very beginning judging

[PATCH net-next 01/11] udp: Handle ICMP errors for tunnels with same destination port on both endpoints

2018-11-06 Thread Stefano Brivio
For both IPv4 and IPv6, if we can't match errors to a socket, try tunnels before ignoring them. Look up a socket with the original source and destination ports as found in the UDP packet inside the ICMP payload, this will work for tunnels that force the same destination port for both endpoints,

[PATCH net-next 05/11] geneve: ICMP error lookup handler

2018-11-06 Thread Stefano Brivio
Export an encap_err_lookup() operation to match an ICMP error against a valid VNI. Reviewed-by: Sabrina Dubroca Signed-off-by: Stefano Brivio --- drivers/net/geneve.c | 52 1 file changed, 52 insertions(+) diff --git a/drivers/net/geneve.c

[PATCH net-next 09/11] udp: Support for error handlers of tunnels with arbitrary destination port

2018-11-06 Thread Stefano Brivio
ICMP error handling is currently not possible for UDP tunnels not employing a receiving socket with local destination port matching the remote one, because we have no way to look them up. Add an err_handler tunnel encapsulation operation that can be exported by tunnels in order to pass the error

[PATCH net-next 08/11] net: Convert protocol error handlers from void to int

2018-11-06 Thread Stefano Brivio
We'll need this to handle ICMP errors for tunnels without a sending socket (i.e. FoU and GUE). There, we might have to look up different types of IP tunnels, registered as network protocols, before we get a match, so we want this for the error handlers of IPPROTO_IPIP and IPPROTO_IPV6 in both

[PATCH net-next 11/11] selftests: pmtu: Introduce FoU and GUE PMTU exceptions tests

2018-11-06 Thread Stefano Brivio
Introduce eight tests, for FoU and GUE, with IPv4 and IPv6 payload, on IPv4 and IPv6 transport, that check that PMTU exceptions are created with the right value when exceeding the MTU on a link of the path. Reviewed-by: Sabrina Dubroca Signed-off-by: Stefano Brivio ---

[PATCH net-next 10/11] fou, fou6: ICMP error handlers for FoU and GUE

2018-11-06 Thread Stefano Brivio
As the destination port in FoU and GUE receiving sockets doesn't necessarily match the remote destination port, we can't associate errors to the encapsulating tunnels with a socket lookup -- we need to blindly try them instead. This means we don't even know if we are handling errors for FoU or GUE

[PATCH net-next 02/11] vxlan: ICMP error lookup handler

2018-11-06 Thread Stefano Brivio
Export an encap_err_lookup() operation to match an ICMP error against a valid VNI. Reviewed-by: Sabrina Dubroca Signed-off-by: Stefano Brivio --- drivers/net/vxlan.c | 29 + 1 file changed, 29 insertions(+) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c

[PATCH net-next 04/11] selftests: pmtu: Introduce tests for IPv4/IPv6 over VxLAN over IPv6

2018-11-06 Thread Stefano Brivio
Use a router between endpoints, implemented via namespaces, set a low MTU between router and destination endpoint, exceed it and check PMTU value in route exceptions. Reviewed-by: Sabrina Dubroca Signed-off-by: Stefano Brivio --- This only introduces tests over VxLAN over IPv6 right now. I'll

[PATCH net-next 06/11] geneve: Allow configuration of DF behaviour

2018-11-06 Thread Stefano Brivio
draft-ietf-nvo3-geneve-08 says: It is strongly RECOMMENDED that Path MTU Discovery ([RFC1191], [RFC1981]) be used by setting the DF bit in the IP header when Geneve packets are transmitted over IPv4 (this is the default with IPv6). Now that ICMP error handling is working for GENEVE, we

[PATCH net-next 00/11] ICMP error handling for UDP tunnels

2018-11-06 Thread Stefano Brivio
This series introduces ICMP error handling for UDP tunnels and encapsulations and related selftests. We need to handle ICMP errors to support PMTU discovery and route redirection -- this support is entirely missing right now: - patch 1/11 adds a socket lookup for UDP tunnels that use, by design,

[PATCH net-next 07/11] selftests: pmtu: Introduce tests for IPv4/IPv6 over GENEVE over IPv6

2018-11-06 Thread Stefano Brivio
Use a router between endpoints, implemented via namespaces, set a low MTU between router and destination endpoint, exceed it and check PMTU value in route exceptions. Reviewed-by: Sabrina Dubroca Signed-off-by: Stefano Brivio --- This only introduces tests over GENEVE over IPv6 right now. I'll

Re: [PATCH rdma] net/mlx5: Fix XRC SRQ umem valid bits

2018-11-06 Thread Doug Ledford
On Wed, 2018-10-31 at 12:20 +0200, Leon Romanovsky wrote: > From: Yishai Hadas > > Adapt XRC SRQ to the latest HW specification with fixed definition > around umem valid bits. The previous definition relied on a bit which > was taken for other purposes in legacy FW. > > Fixes: bd37197554eb

[PATCH net-next 4/5] net: dsa: bcm_sf2: Get rid of unmarshalling functions

2018-11-06 Thread Florian Fainelli
Now that we have migrated the CFP rule handling to a list with a software copy, the delete/get operation just returns what is on the list, no need to read from the hardware which is both slow and more error prone. Signed-off-by: Florian Fainelli --- drivers/net/dsa/bcm_sf2_cfp.c | 310

[PATCH net-next 5/5] net: systemport: Restore Broadcom tag match filters upon resume

2018-11-06 Thread Florian Fainelli
Some of the system suspend states that we support wipe out entirely the HW contents. If we had a Wake-on-LAN filter programmed prior to going into suspend, but we did not actually wake-up from Wake-on-LAN and instead used a deeper suspend state, make sure we restore the CID number that we need to

[PATCH net-next 2/5] net: dsa: bcm_sf2: Split rule handling from HW operation

2018-11-06 Thread Florian Fainelli
In preparation for restoring CFP rules during system wide system suspend/resume where the hardware loses its context, split the rule validation from its actual insertion as well as the rule removal from its actual hardware deletion operation. Signed-off-by: Florian Fainelli ---

[PATCH net-next 3/5] net: dsa: bcm_sf2: Restore CFP rules during system resume

2018-11-06 Thread Florian Fainelli
The hardware can lose its context during system suspend, and depending on the switch generation (7445 vs. 7278), while the rules are still there, they will have their valid bit cleared (because that's the fastest way for the HW to reset things). Just make sure we re-apply them coming back from

[PATCH net-next 0/5] net: dsa: bcm_sf2: Store rules in lists

2018-11-06 Thread Florian Fainelli
Hi all, This patch series changes the bcm-sf2 driver to keep a copy of the inserted rules as opposed to using the HW as a storage area for a number of reasons: - this helps us with doing duplicate rule detection in a faster way, it would have required a full rule read before - this helps with

[PATCH net-next 1/5] net: dsa: bcm_sf2: Keep copy of inserted rules

2018-11-06 Thread Florian Fainelli
We tried hard to use the hardware as a storage area, which made things needlessly complex in that we had to both marshall and unmarshall the ethtool_rx_flow_spec into what the CFP hardware understands but it did not require any driver level allocations, so that was nice. Keep a copy of the

[PATCH net-next 2/3] net: Add extack argument to ip_fib_metrics_init

2018-11-06 Thread David Ahern
From: David Ahern Add extack argument to ip_fib_metrics_init and add messages for invalid metrics. Signed-off-by: David Ahern --- include/net/ip.h | 3 ++- net/ipv4/fib_semantics.c | 2 +- net/ipv4/metrics.c | 26 +++--- net/ipv6/route.c | 5 +++--

[PATCH net-next 1/3] net: Add extack argument to rtnl_create_link

2018-11-06 Thread David Ahern
From: David Ahern Add extack arg to rtnl_create_link and add messages for invalid number of Tx or Rx queues. Signed-off-by: David Ahern --- drivers/net/can/vxcan.c | 2 +- drivers/net/geneve.c| 2 +- drivers/net/veth.c | 2 +- drivers/net/vxlan.c | 2 +-

[PATCH net-next 3/3] rtnetlink: Add more extack messages to rtnl_newlink

2018-11-06 Thread David Ahern
From: David Ahern Add extack arg to the nla_parse_nested calls in rtnl_newlink, and add messages for unknown device type and link network namespace id. In particular, it improves the failure message when the wrong link type is used. From $ ip li add bond1 type bonding RTNETLINK answers:

[PATCH net-next 0/3] net: More extack messages

2018-11-06 Thread David Ahern
From: David Ahern Add more extack messages for several link create errors (e.g., invalid number of queues, unknown link kind) and invalid metrics argument. David Ahern (3): net: Add extack argument to rtnl_create_link net: Add extack argument to ip_fib_metrics_init rtnetlink: Add more

Re: [PATCH net-next 1/3] devlink: Add fw_version_check generic parameter

2018-11-06 Thread Ido Schimmel
On Tue, Nov 06, 2018 at 12:19:13PM -0800, Jakub Kicinski wrote: > On Tue, 6 Nov 2018 20:05:00 +, Ido Schimmel wrote: > > From: Shalom Toledo > > > > Many drivers checking the device's firmware version during the > > initialization flow and flashing a compatible version if the current > >

[PATCH bpf-next 0/2] TCP-BPF event notification support

2018-11-06 Thread Sowmini Varadhan
This patchset uses eBPF perf-event based notification mechanism to solve the problem described in https://marc.info/?l=linux-netdev=154022219423571=2. Thanks to Daniel Borkmann for feedback/input. The problem statement is We would like to monitor some subset of TCP sockets in user-space,

[PATCH bpf-next 2/2] selftests/bpf: add a test case for sock_ops perf-event notification

2018-11-06 Thread Sowmini Varadhan
This patch provides a tcp_bpf based eBPF sample. The test - ncat(1) as the TCP client program to connect() to a port with the intention of triggerring SYN retransmissions: we first install an iptables DROP rule to make sure ncat SYNs are resent (instead of aborting instantly after a TCP RST)

[PATCH bpf-next 1/2] bpf: add perf-event notificaton support for sock_ops

2018-11-06 Thread Sowmini Varadhan
This patch allows eBPF programs that use sock_ops to send perf-based event notifications using bpf_perf_event_output() Signed-off-by: Sowmini Varadhan --- net/core/filter.c | 19 +++ 1 files changed, 19 insertions(+), 0 deletions(-) diff --git a/net/core/filter.c

Re: [PATCH net-next 1/3] devlink: Add fw_version_check generic parameter

2018-11-06 Thread Jakub Kicinski
On Tue, 6 Nov 2018 20:05:00 +, Ido Schimmel wrote: > From: Shalom Toledo > > Many drivers checking the device's firmware version during the > initialization flow and flashing a compatible version if the current > version is not. > > fw_version_check gives the ability to skip this check

bpf-next is OPEN

2018-11-06 Thread Daniel Borkmann
Merge window is over so bpf-next is open again! Thanks, Daniel

[PATCH net-next 0/3] mlxsw: Add fw_version_check devlink parameter

2018-11-06 Thread Ido Schimmel
Shalom says: Currently, drivers do not have the ability to skip the firmware version check during their initialization flow. Hence, drivers will always flash a compatible version. This prevents drivers from running the device with a different firmware version for testing and/or debugging

[PATCH net-next 3/3] mlxsw: spectrum: Skip firmware version check based on devlink parameter

2018-11-06 Thread Ido Schimmel
From: Shalom Toledo Based on fw_version_check devlink parameter, skip firmware version check in order to run the device with different firmware version than required by the driver for testing and/or debugging purposes. Signed-off-by: Shalom Toledo Reviewed-by: Jiri Pirko Signed-off-by: Ido

[PATCH net-next 1/3] devlink: Add fw_version_check generic parameter

2018-11-06 Thread Ido Schimmel
From: Shalom Toledo Many drivers checking the device's firmware version during the initialization flow and flashing a compatible version if the current version is not. fw_version_check gives the ability to skip this check which allows to run the device with a different firmware version than

[PATCH net-next 2/3] mlxsw: core: Reset firmware after flash during driver initialization

2018-11-06 Thread Ido Schimmel
From: Shalom Toledo After flashing new firmware during the driver initialization flow (reload or not), the driver should do a firmware reset when it gets -EAGAIN in order to load the new one. Signed-off-by: Shalom Toledo Reviewed-by: Jiri Pirko Signed-off-by: Ido Schimmel ---

net-next is OPEN...

2018-11-06 Thread David Miller
Do it, to it.

Re: [PATCH bpf-next v2 02/13] bpf: btf: Add BTF_KIND_FUNC and BTF_KIND_FUNC_PROTO

2018-11-06 Thread Edward Cree
On 06/11/18 06:29, Alexei Starovoitov wrote: > BTF is not pure type information. BTF is everything that verifier needs > to know to make safety decisions that bpf instruction set doesn't have. Yes, I'm not disputing that and never have. I'm just saying that it will be much cleaner and better if

Re: [PATCH v2 net 0/3] net: bql: better deal with GSO

2018-11-06 Thread David Miller
From: Edward Cree Date: Tue, 6 Nov 2018 18:23:42 + > I'm doing a patch to update sfc to use this new helper.  Is this 'net' >  material, or should I wait for 'net-next' to open back up? As the driver maintainer I guess I can lead that judgment up to you at least to a certain extent.

Re: [PATCH net-next v4 9/9] ipv6: do not drop vrf udp multicast packets

2018-11-06 Thread David Ahern
On 11/2/18 1:10 PM, Mike Manning wrote: > From: Dewi Morgan > > For bound udp sockets in a vrf, also check the sdif to get the index > for ingress devices enslaved to an l3mdev. > > Signed-off-by: Dewi Morgan > Signed-off-by: Mike Manning > --- > net/ipv6/udp.c | 8 +--- > 1 file

  1   2   >