Re: [PATCH net-next 0/4] net: phy: mscc-miim: reduce waiting time between MDIO transactions

2020-05-27 Thread Antoine Tenart
Hi Andrew, Quoting Andrew Lunn (2020-05-26 19:01:00) > On Tue, May 26, 2020 at 06:22:52PM +0200, Antoine Tenart wrote: > > > > This series aims at reducing the waiting time between MDIO transactions > > when using the MSCC MIIM MDIO controller. > > There are a couple of other things you can look

Re: [net-next v4 10/12] ASoC: SOF: Introduce descriptors for SOF client

2020-05-27 Thread Greg KH
On Tue, May 26, 2020 at 03:37:36PM +0200, Takashi Iwai wrote: > On Tue, 26 May 2020 15:15:26 +0200, > Pierre-Louis Bossart wrote: > > > > > > > > On 5/24/20 1:35 AM, Greg KH wrote: > > > On Sat, May 23, 2020 at 02:41:51PM -0500, Pierre-Louis Bossart wrote: > > >> > > >> > > >> On 5/23/20 1:23 AM

Re: [PATCH net] net/sched: fix infinite loop in sch_fq_pie

2020-05-27 Thread Ivan Vecera
On Wed, 27 May 2020 02:04:26 +0200 Davide Caratti wrote: > this command hangs forever: > > # tc qdisc add dev eth0 root fq_pie flows 65536 > > watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [tc:1028] > [...] > CPU: 1 PID: 1028 Comm: tc Not tainted 5.7.0-rc6+ #167 > RIP: 0010:fq_pie_init

Re: [PATCH v5 06/11] net: ethernet: mtk-star-emac: new driver

2020-05-27 Thread Nathan Chancellor
On Fri, May 22, 2020 at 02:06:55PM +0200, Bartosz Golaszewski wrote: > diff --git a/drivers/net/ethernet/mediatek/mtk_star_emac.c > b/drivers/net/ethernet/mediatek/mtk_star_emac.c > new file mode 100644 > index ..789c77af501f > --- /dev/null > +++ b/drivers/net/ethernet/mediatek/mtk

RE: [net-next 12/16] net/mlx5: Add basic suspend/resume support

2020-05-27 Thread Dexuan Cui
> From: Saeed Mahameed > Sent: Tuesday, May 26, 2020 6:49 PM > To: David S. Miller ; k...@kernel.org > Cc: netdev@vger.kernel.org; Mark Bloch ; Dexuan Cui > ; Moshe Shemesh ; Saeed > Mahameed > Subject: [net-next 12/16] net/mlx5: Add basic suspend/resume support > > From: Mark Bloch > > Add ca

Re: [PATCH net-next 00/14] mlxsw: Various trap changes - part 2

2020-05-27 Thread Ido Schimmel
On Tue, May 26, 2020 at 04:43:23PM -0700, Jakub Kicinski wrote: > On Wed, 27 May 2020 02:19:05 +0300 Ido Schimmel wrote: > > On Tue, May 26, 2020 at 03:14:37PM -0700, Jakub Kicinski wrote: > > > On Tue, 26 May 2020 02:05:42 +0300 Ido Schimmel wrote: > > > > From: Ido Schimmel > > > > > > > > Th

[PATCH net] nfp: flower: fix used time of merge flow statistics

2020-05-27 Thread Simon Horman
From: Heinrich Kuhn Prior to this change the correct value for the used counter is calculated but not stored nor, therefore, propagated to user-space. In use-cases such as OVS use-case at least this results in active flows being removed from the hardware datapath. Which results in both unnecessar

[PATCH] net/mlx5e: Don't use err uninitialized in mlx5e_attach_decap

2020-05-27 Thread Nathan Chancellor
Clang warns: drivers/net/ethernet/mellanox/mlx5/core/en_tc.c:3712:6: warning: variable 'err' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] if (IS_ERR(d->pkt_reformat)) { ^~~ drivers/net/ethernet/mellanox/mlx5/core/en_tc.c

Re: [PATCH] mac80211_hwsim: report the WIPHY_FLAG_SUPPORTS_5_10_MHZ capability

2020-05-27 Thread Johannes Berg
On Tue, 2020-05-26 at 08:36 -0300, Ramon Fontes wrote: > > Not sure this is enough? How about wmediumd, for example? > > It works with wmediumd too. At least I was able to enable 5 / 10MHz > via iw with 5.9GHz Yeah, but wmediumd won't know that it's not 20 MHz, I guess :-) > > And also, 5/10 MHz

[PATCH net] vsock: fix timeout in vsock_accept()

2020-05-27 Thread Stefano Garzarella
The accept(2) is an "input" socket interface, so we should use SO_RCVTIMEO instead of SO_SNDTIMEO to set the timeout. So this patch replace sock_sndtimeo() with sock_rcvtimeo() to use the right timeout in the vsock_accept(). Fixes: d021c344051a ("VSOCK: Introduce VM Sockets") Signed-off-by: Stefa

[PATCH net-next] nexthop: Fix type of event_type in call_nexthop_notifiers

2020-05-27 Thread Nathan Chancellor
Clang warns: net/ipv4/nexthop.c:841:30: warning: implicit conversion from enumeration type 'enum nexthop_event_type' to different enumeration type 'enum fib_event_type' [-Wenum-conversion] call_nexthop_notifiers(net, NEXTHOP_EVENT_DEL, nh); ~~ ^

[PATCH net] netfilter: conntrack: Pass value of ctinfo to __nf_conntrack_update

2020-05-27 Thread Nathan Chancellor
Clang warns: net/netfilter/nf_conntrack_core.c:2068:21: warning: variable 'ctinfo' is uninitialized when used here [-Wuninitialized] nf_ct_set(skb, ct, ctinfo); ^~ net/netfilter/nf_conntrack_core.c:2024:2: note: variable 'ctinfo' is declared here enum

[PATCH][V2][net-next] mlxsw: spectrum_router: remove redundant initialization of pointer br_dev

2020-05-27 Thread Colin King
From: Colin Ian King The pointer br_dev is being initialized with a value that is never read and is being updated with a new value later on. The initialization is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- V2: remove stray blank line -

[PATCH net-next] rds: transport module should be auto loaded when transport is set

2020-05-27 Thread rao . shoaib
From: Rao Shoaib This enhancement auto loads transport module when the transport is set via SO_RDS_TRANSPORT socket option. Orabug: 31032127 Reviewed-by: Ka-Cheong Poon Reviewed-by: Håkon Bugge Signed-off-by: Rao Shoaib Signed-off-by: Somasundaram Krishnasamy --- include/uapi/linux/rds.h |

Re: [PATCH 00/10] staging: wfx: introduce nl80211 vendor extensions

2020-05-27 Thread Greg Kroah-Hartman
On Tue, May 26, 2020 at 07:18:11PM +0200, Jerome Pouiller wrote: > From: Jérôme Pouiller > > Hello, > > This series introduces some nl80211 vendor extensions to the wfx driver. > > This series may lead to some discussions: I've applied the first 6 patches here, until you get some answers from

RE: [PATCH v3 net-next 1/8] sctp: setsockopt, expand some #defines

2020-05-27 Thread David Laight
From: David Miller > Sent: 26 May 2020 23:37 > > This should be 3/8. > > David just respin this at some point and with this fixed and also the > header posting saying "0/8" properly instead of "0/1", this is really > messy. I have to copy patches onto a windows box. Then open them in wordpad so I

[PATCH bpf-next] libbpf: fix perf_buffer__free() API for sparse allocs

2020-05-27 Thread Eelco Chaudron
In case the cpu_bufs are sparsely allocated they are not all free'ed. These changes will fix this. Signed-off-by: Eelco Chaudron --- tools/lib/bpf/libbpf.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c index 5d60de6fd81

RE: [PATCH net] vsock: fix timeout in vsock_accept()

2020-05-27 Thread Jorgen Hansen
> From: Stefano Garzarella > Sent: Wednesday, May 27, 2020 9:57 AM > > The accept(2) is an "input" socket interface, so we should use > SO_RCVTIMEO instead of SO_SNDTIMEO to set the timeout. > > So this patch replace sock_sndtimeo() with sock_rcvtimeo() to > use the right timeout in the vsock_ac

Re: [PATCH v5 06/11] net: ethernet: mtk-star-emac: new driver

2020-05-27 Thread Bartosz Golaszewski
śr., 27 maj 2020 o 09:31 Nathan Chancellor napisał(a): > > On Fri, May 22, 2020 at 02:06:55PM +0200, Bartosz Golaszewski wrote: > > > > > diff --git a/drivers/net/ethernet/mediatek/mtk_star_emac.c > > b/drivers/net/ethernet/mediatek/mtk_star_emac.c > > new file mode 100644 > > index

Re: [RFC next-next v2 2/5] net: marvell: prestera: Add PCI interface support

2020-05-27 Thread Vadym Kochan
Hi Jiri, On Wed, May 27, 2020 at 07:53:05AM +0200, Jiri Pirko wrote: > Tue, May 26, 2020 at 06:26:44PM CEST, vadym.koc...@plvision.eu wrote: > >On Mon, May 11, 2020 at 01:23:46PM +0200, Jiri Pirko wrote: > >> Fri, May 01, 2020 at 01:20:49AM CEST, vadym.koc...@plvision.eu wrote: > >> >Add PCI inter

Re: [PATCH net-next] bridge: mrp: Rework the MRP netlink interface

2020-05-27 Thread Nikolay Aleksandrov
On 26/05/2020 17:22, Horatiu Vultur wrote: > This patch rework the MRP netlink interface. Before, each attribute > represented a binary structure which made it hard to be extended. > Therefore update the MRP netlink interface such that each existing > attribute to be a nested attribute which contai

Re: [PATCH][V2][net-next] mlxsw: spectrum_router: remove redundant initialization of pointer br_dev

2020-05-27 Thread Ido Schimmel
On Wed, May 27, 2020 at 09:15:55AM +0100, Colin King wrote: > From: Colin Ian King > > The pointer br_dev is being initialized with a value that is never read > and is being updated with a new value later on. The initialization > is redundant and can be removed. > > Addresses-Coverity: ("Unused

[net-next:master 2135/2155] net/tipc/msg.c:215:24: warning: variable 'prev' set but not used

2020-05-27 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: 4e637c70b503b686aae45716a25a94dc3a434f3a commit: 0a3e060f340dbe232ffa290c40f879b7f7db595b [2135/2155] tipc: add test for Nagle algorithm effectiveness config: alpha-allyesconfig (attached as .config) compile

[RFC PATCH] vdpa: vhost_vdpa_poll_stop() can be static

2020-05-27 Thread kbuild test robot
Signed-off-by: kbuild test robot --- vdpa.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c index d3a2acafedecd4..5037ce7f48cd42 100644 --- a/drivers/vhost/vdpa.c +++ b/drivers/vhost/vdpa.c @@ -287,12 +287,12 @@ static lon

[PATCH] net: ethernet: mtk-star-emac: fix error path in RX handling

2020-05-27 Thread Bartosz Golaszewski
From: Bartosz Golaszewski The dma_addr field in desc_data must not be overwritten until after the new skb is mapped. Currently we do replace it with uninitialized value in error path. This change fixes it by moving the assignment before the label to which we jump after mapping or allocation error

[PATCH net-next] net/tls: Add force_resync for driver resync

2020-05-27 Thread Tariq Toukan
This patch adds a field to the tls rx offload context which enables drivers to force a send_resync call. This field can be used by drivers to request a resync at the next possible tls record. It is beneficial for hardware that provides the resync sequence number asynchronously. In such cases, the

[PATCH v2 bpf-next] xdp: introduce convert_to_xdp_buff utility routine

2020-05-27 Thread Lorenzo Bianconi
Introduce convert_to_xdp_buff utility routine to initialize xdp_buff fields from xdp_frames ones. Rely on convert_to_xdp_buff in veth xdp code Suggested-by: Jesper Dangaard Brouer Signed-off-by: Lorenzo Bianconi --- Changes since v1: - rely on frame->data pointer to compute xdp->data_hard_start

[PATCH 9/9] RDMA/core: remove FMR device ops

2020-05-27 Thread Max Gurtovoy
After removing FMR support from all the RDMA ULPs and providers, there is no need to keep FMR operation for IB devices. Signed-off-by: Max Gurtovoy --- Documentation/infiniband/core_locking.rst | 2 -- drivers/infiniband/core/device.c | 4 --- drivers/infiniband/core/verbs.c

[PATCH 1/9] RDMA/mlx5: Remove FMR leftovers

2020-05-27 Thread Max Gurtovoy
From: Gal Pressman Remove a few leftovers from FMR functionality which are no longer used. Signed-off-by: Gal Pressman Signed-off-by: Max Gurtovoy --- drivers/infiniband/hw/mlx5/mlx5_ib.h | 8 1 file changed, 8 deletions(-) diff --git a/drivers/infiniband/hw/mlx5/mlx5_ib.h b/driver

[PATCH 5/9] RDMA/rdmavt: remove FMR memory registration

2020-05-27 Thread Max Gurtovoy
Use FRWR method to register memory by default and remove the ancient and unsafe FMR method. Signed-off-by: Max Gurtovoy --- drivers/infiniband/sw/rdmavt/mr.c | 154 -- drivers/infiniband/sw/rdmavt/mr.h | 15 drivers/infiniband/sw/rdmavt/vt.c | 4 - 3 f

[PATCH 6/9] RDMA/iser: Remove support for FMR memory registration

2020-05-27 Thread Max Gurtovoy
From: Israel Rukshin FMR is not supported on most recent RDMA devices (that use fast memory registration mechanism). Also, FMR was recently removed from NFS/RDMA ULP. Signed-off-by: Israel Rukshin Signed-off-by: Max Gurtovoy Reviewed-by: Sagi Grimberg --- drivers/infiniband/ulp/iser/iscsi_is

[PATCH 3/9] RDMA/rds: remove FMR support for memory registration

2020-05-27 Thread Max Gurtovoy
Use FRWR method for memory registration by default and remove the ancient and unsafe FMR method. Signed-off-by: Max Gurtovoy --- net/rds/Makefile | 2 +- net/rds/ib.c | 14 +-- net/rds/ib.h | 1 - net/rds/ib_cm.c | 4 +- net/rds/ib_fmr.c | 269 ---

[PATCH 4/9] RDMA/mthca: remove FMR support for memory registration

2020-05-27 Thread Max Gurtovoy
Remove the ancient and unsafe FMR method. Signed-off-by: Max Gurtovoy --- drivers/infiniband/hw/mthca/mthca_dev.h | 10 - drivers/infiniband/hw/mthca/mthca_mr.c | 262 +-- drivers/infiniband/hw/mthca/mthca_provider.c | 86 - 3 files changed, 1 inserti

[PATCH 0/9 v2] Remove FMR support from RDMA drivers

2020-05-27 Thread Max Gurtovoy
This series removes the support for FMR mode to register memory. This ancient mode is unsafe (rkeys that are usually exposed for caching purposes and the API is limited to page granularity mappings) and not maintained/tested in the last few years. It also doesn't have any reasonable advantage over

[PATCH 8/9] RDMA/core: remove FMR pool API

2020-05-27 Thread Max Gurtovoy
This ancient and unsafe method for memory registration is no longer used by any RDMA based ULP. Remove the FMR pool API from the core driver. Signed-off-by: Max Gurtovoy --- Documentation/driver-api/infiniband.rst | 3 - drivers/infiniband/core/Makefile| 2 +- drivers/infiniband/core

[PATCH 2/9] RDMA/mlx4: remove FMR support for memory registration

2020-05-27 Thread Max Gurtovoy
HCA's that are driven by mlx4 driver support FRWR method to register memory. Remove the ancient and unsafe FMR method. Signed-off-by: Max Gurtovoy --- drivers/infiniband/hw/mlx4/main.c | 10 -- drivers/infiniband/hw/mlx4/mlx4_ib.h| 16 --- drivers/infiniband/hw/mlx4/mr.c | 9

[PATCH 7/9] RDMA/srp: remove support for FMR memory registration

2020-05-27 Thread Max Gurtovoy
FMR is not supported on most recent RDMA devices (that use fast memory registration mechanism). Also, FMR was recently removed from NFS/RDMA ULP. Signed-off-by: Max Gurtovoy Reviewed-by: Israel Rukshin Reviewed-by: Bart Van Assche --- drivers/infiniband/ulp/srp/ib_srp.c | 222 +++--

Re: [PATCH net] netfilter: conntrack: Pass value of ctinfo to __nf_conntrack_update

2020-05-27 Thread Pablo Neira Ayuso
On Wed, May 27, 2020 at 01:10:39AM -0700, Nathan Chancellor wrote: > Clang warns: > > net/netfilter/nf_conntrack_core.c:2068:21: warning: variable 'ctinfo' is > uninitialized when used here [-Wuninitialized] > nf_ct_set(skb, ct, ctinfo); >^~ > net/netfilter/

Re: [RFC PATCH net-next 0/3] TC: Introduce qevents

2020-05-27 Thread Petr Machata
Cong Wang writes: > On Tue, May 26, 2020 at 10:11 AM Petr Machata wrote: >> >> The Spectrum hardware allows execution of one of several actions as a >> result of queue management events: tail-dropping, early-dropping, marking a >> packet, or passing a configured latency threshold or buffer siz

[PATCH v2] sctp: check assoc before SCTP_ADDR_{MADE_PRIM,ADDED} event

2020-05-27 Thread Jonas Falkevik
Make sure SCTP_ADDR_{MADE_PRIM,ADDED} are sent only for associations that have been established. These events are described in rfc6458#section-6.1 SCTP_PEER_ADDR_CHANGE: This tag indicates that an address that is part of an existing association has experienced a change of state (e.g., a failure or

[PATCH] sctp: fix typo sctp_ulpevent_nofity_peer_addr_change

2020-05-27 Thread Jonas Falkevik
change typo in function name "nofity" to "notify" sctp_ulpevent_nofity_peer_addr_change -> sctp_ulpevent_notify_peer_addr_change Signed-off-by: Jonas Falkevik --- include/net/sctp/ulpevent.h | 2 +- net/sctp/associola.c| 8 net/sctp/ulpevent.c | 2 +- 3 files changed, 6

Re: [PATCH bpf-next 2/5] bpf: Add support to attach bpf program to a devmap entry

2020-05-27 Thread Toke Høiland-Jørgensen
David Ahern writes: > Add BPF_XDP_DEVMAP attach type for use with programs associated with a > DEVMAP entry. > > DEVMAPs can associate a program with a device entry by setting the > value to pair. The program associated with the fd must have > type XDP with expected attach type BPF_XDP_DEVMAP. W

Re: [PATCH bpf-next 4/5] bpftool: Add SEC name for xdp programs attached to device map

2020-05-27 Thread Toke Høiland-Jørgensen
David Ahern writes: > Support SEC("xdp_dm*") as a short cut for loading the program with > type BPF_PROG_TYPE_XDP and expected attach type BPF_XDP_DEVMAP. You're not using this in the selftest; shouldn't you be? Also, the prefix should be libbpf: not bpftool:, no? -Toke

Re: [PATCH net-next] bridge: mrp: Rework the MRP netlink interface

2020-05-27 Thread Horatiu Vultur
The 05/27/2020 11:59, Nikolay Aleksandrov wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On 26/05/2020 17:22, Horatiu Vultur wrote: > > This patch rework the MRP netlink interface. Before, each attribute > > represented a binary structure

Re: [PATCH v3 3/7] kunit: tests for stats_fs API

2020-05-27 Thread Alan Maguire
On Tue, 26 May 2020, Emanuele Giuseppe Esposito wrote: > Add kunit tests to extensively test the stats_fs API functionality. > I've added in the kunit-related folks. > In order to run them, the kernel .config must set CONFIG_KUNIT=y > and a new .kunitconfig file must be created with CONFIG_STAT

Re: [PATCH v2 bpf-next] xdp: introduce convert_to_xdp_buff utility routine

2020-05-27 Thread Jesper Dangaard Brouer
On Wed, 27 May 2020 11:28:03 +0200 Lorenzo Bianconi wrote: > Introduce convert_to_xdp_buff utility routine to initialize xdp_buff > fields from xdp_frames ones. Rely on convert_to_xdp_buff in veth xdp > code > > Suggested-by: Jesper Dangaard Brouer > Signed-off-by: Lorenzo Bianconi > --- > Cha

Re: [PATCHv4 bpf-next 0/2] xdp: add dev map multicast support

2020-05-27 Thread Toke Høiland-Jørgensen
Hangbin Liu writes: > Hi all, > > This patchset is for xdp multicast support, which has been discussed > before[0]. The goal is to be able to implement an OVS-like data plane in > XDP, i.e., a software switch that can forward XDP frames to multiple > ports. > > To achieve this, an application nee

Re: [PATCH bpf-next 1/5] bpf: Handle 8-byte values in DEVMAP and DEVMAP_HASH

2020-05-27 Thread Jesper Dangaard Brouer
On Tue, 26 May 2020 19:09:01 -0600 David Ahern wrote: > Add support to DEVMAP and DEVMAP_HASH to support 8-byte values as a > pair. To do this, a new struct is needed in > bpf_dtab_netdev to hold the values to return on lookup. > > Signed-off-by: David Ahern > --- > kernel/bpf/devmap.c | 56 +

Re: [PATCH ethtool v1] netlink: add master/slave configuration support

2020-05-27 Thread Oleksij Rempel
On Tue, May 26, 2020 at 02:41:39PM +0200, Michal Kubecek wrote: > On Tue, May 26, 2020 at 11:10:25AM +0200, Oleksij Rempel wrote: > > This UAPI is needed for BroadR-Reach 100BASE-T1 devices. Due to lack of > > auto-negotiation support, we needed to be able to configure the > > MASTER-SLAVE role of

Re: [PATCHv4 bpf-next 1/2] xdp: add a new helper for dev map multicast support

2020-05-27 Thread Toke Høiland-Jørgensen
Hangbin Liu writes: > This patch is for xdp multicast support. In this implementation we > add a new helper to accept two maps: forward map and exclude map. > We will redirect the packet to all the interfaces in *forward map*, but > exclude the interfaces that in *exclude map*. > > To achive this

Re: [PATCHv4 bpf-next 0/2] xdp: add dev map multicast support

2020-05-27 Thread Eelco Chaudron
On 27 May 2020, at 12:21, Toke Høiland-Jørgensen wrote: Hangbin Liu writes: Hi all, This patchset is for xdp multicast support, which has been discussed before[0]. The goal is to be able to implement an OVS-like data plane in XDP, i.e., a software switch that can forward XDP frames to m

[PATCH RFC v2 1/9] net: phy: clean up cortina workaround

2020-05-27 Thread Russell King
Move the Cortina PHY workaround out of the "devices in package" loop; it doesn't need to be in there as the control flow will terminate the loop once we enter the workaround irrespective of the workaround's outcome. The workaround is triggered by the ID being mostly 1's, which will in any case term

[PATCH RFC v2 0/9] Clause 45 PHY probing cleanups

2020-05-27 Thread Russell King - ARM Linux admin
Hi, This is version 2 of my proposal to expand our Clause 45 PHY probing. This series does not change the functionality beyond probing further MMDs. The first four patches clean up get_phy_device() and called functions, updating the kernel doc, adding information about the various error return va

[PATCH RFC v2 2/9] net: phy: clean up PHY ID reading

2020-05-27 Thread Russell King
Rearrange the code to read the PHY IDs, so we don't call get_phy_id() only to immediately call get_phy_c45_ids(). Move that logic into get_phy_device(), which results in better readability. Signed-off-by: Russell King --- drivers/net/phy/phy_device.c | 25 + 1 file chang

[PATCH RFC v2 6/9] net: phy: add support for probing MMDs >= 8 for devices-in-package

2020-05-27 Thread Russell King
Add support for probing MMDs above 7 for a valid devices-in-package specifier, but only probe the vendor MMDs for this if they also report that there the device is present in status register 2. This avoids issues where the MMD is implemented, but does not provide IEEE 802.3 compliant registers (su

[PATCH RFC v2 3/9] net: phy: clean up get_phy_c45_ids() failure handling

2020-05-27 Thread Russell King
When we decide that a PHY is not present, we do not need to go through the hoops of setting *phy_id to 0x, and then return zero to make get_phy_device() fail - we can return -ENODEV which will have the same effect. Doing so means we no longer have to pass a pointer to phy_id in, and we can

[PATCH RFC v2 9/9] net: phy: read MMD ID from all present MMDs

2020-05-27 Thread Russell King
Expand the device_ids[] array to allow all MMD IDs to be read rather than just the first 8 MMDs, but only read the ID if the MDIO_STAT2 register reports that a device really is present here for these new devices to maintain compatibility with our current behaviour. 88X3310 PHY vendor MMDs do are m

[PATCH RFC v2 5/9] net: phy: reword get_phy_device() kerneldoc

2020-05-27 Thread Russell King
Signed-off-by: Russell King --- drivers/net/phy/phy_device.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c index 424e608cec21..bc20ee01b31d 100644 --- a/drivers/net/phy/phy_device.c +++ b/drivers/net/

[PATCH RFC v2 7/9] net: phy: set devices_in_package only after validation

2020-05-27 Thread Russell King
Only set the devices_in_package to a non-zero value if we find a valid value for this field, so we avoid leaving it set to e.g. 0x1fff. Signed-off-by: Russell King --- drivers/net/phy/phy_device.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/drivers/ne

[PATCH RFC v2 8/9] net: phy: split devices_in_package

2020-05-27 Thread Russell King
We have two competing requirements for the devices_in_package field. We want to use it as a bit array indicating which MMDs are present, but we also want to know if the Clause 22 registers are present. Since "devices in package" is a term used in the 802.3 specification, keep this as the as-specif

[PATCH RFC v2 4/9] net: phy: clean up get_phy_c22_id() invalid ID handling

2020-05-27 Thread Russell King
Move the ID check from get_phy_device() into get_phy_c22_id(), which simplifies get_phy_device(). The ID reading functions are now responsible for indicating whether they found a PHY or not via their return code - they must return -ENODEV when a PHY is not present. Signed-off-by: Russell King ---

[PATCH net-next v2] bridge: mrp: Rework the MRP netlink interface

2020-05-27 Thread Horatiu Vultur
This patch reworks the MRP netlink interface. Before, each attribute represented a binary structure which made it hard to be extended. Therefore update the MRP netlink interface such that each existing attribute to be a nested attribute which contains the fields of the binary structures. In this wa

Re: [PATCH net-next v2] bridge: mrp: Rework the MRP netlink interface

2020-05-27 Thread Nikolay Aleksandrov
On 27/05/2020 15:34, Horatiu Vultur wrote: > This patch reworks the MRP netlink interface. Before, each attribute > represented a binary structure which made it hard to be extended. > Therefore update the MRP netlink interface such that each existing > attribute to be a nested attribute which conta

Re: [PATCH 16/17] dt-bindings: watchdog: renesas,wdt: Document r8a7742 support

2020-05-27 Thread Lad, Prabhakar
Hi Rob, On Wed, May 27, 2020 at 2:31 AM Rob Herring wrote: > > On Fri, May 15, 2020 at 04:08:56PM +0100, Lad Prabhakar wrote: > > RZ/G1H (R8A7742) watchdog implementation is compatible with R-Car Gen2, > > therefore add relevant documentation. > > > > Signed-off-by: Lad Prabhakar > > Reviewed-by

Re: [PATCH v5 06/11] net: ethernet: mtk-star-emac: new driver

2020-05-27 Thread Arnd Bergmann
On Wed, May 27, 2020 at 10:46 AM Bartosz Golaszewski wrote: > > I don't know if there should be a new label that excludes that > > assignment for those particular gotos or if new_dma_addr should > > be initialized to something at the top. Please take a look at > > addressing this when you get a c

Re: [PATCH RFC net-next 00/13] RX filtering for DSA switches

2020-05-27 Thread Vladimir Oltean
On Tue, 26 May 2020 at 17:02, Ido Schimmel wrote: > > On Mon, May 25, 2020 at 11:23:34PM +0300, Vladimir Oltean wrote: > > Hi Ido, > > > > On Mon, 25 May 2020 at 22:48, Ido Schimmel wrote: > > > > > > On Sun, May 24, 2020 at 07:24:27PM +0300, Vladimir Oltean wrote: > > > > On Sun, 24 May 2020 at

Re: [PATCH v5 06/11] net: ethernet: mtk-star-emac: new driver

2020-05-27 Thread Bartosz Golaszewski
śr., 27 maj 2020 o 13:33 Arnd Bergmann napisał(a): > > On Wed, May 27, 2020 at 10:46 AM Bartosz Golaszewski wrote: > > > > I don't know if there should be a new label that excludes that > > > assignment for those particular gotos or if new_dma_addr should > > > be initialized to something at the

Re: [PATCH v2 net-next 0/2] mptcp: adjust tcp rcvspace on rx

2020-05-27 Thread Florian Westphal
David Miller wrote: > From: Florian Westphal > Date: Mon, 25 May 2020 20:15:06 +0200 > > > These two patches improve mptcp throughput by making sure tcp grows > > the receive buffer when we move skbs from subflow socket to the > > mptcp socket. > > > > The second patch moves mptcp receive buffe

Re: [PATCH v2 net-next 2/2] mptcp: move recbuf adjustment to recvmsg path

2020-05-27 Thread Florian Westphal
Christoph Paasch wrote: > tcp_rcv_space_adjust is called even when the app is not yet reading, > thus wouldn't this mean that we still end up with an ever-growing > window? Window is based on available mptcp sk recvbuf. When data is moved from ssk to the mptcp sk, the skb truesize is charged to

RE: [RFC next-next v2 2/5] net: marvell: prestera: Add PCI interface support

2020-05-27 Thread Mickey Rachamim
Hi Vadym, Jiri, > > Hi Jiri, > > On Wed, May 27, 2020 at 07:53:05AM +0200, Jiri Pirko wrote: > > Tue, May 26, 2020 at 06:26:44PM CEST, vadym.koc...@plvision.eu wrote: > > >On Mon, May 11, 2020 at 01:23:46PM +0200, Jiri Pirko wrote: > > >> Fri, May 01, 2020 at 01:20:49AM CEST, vadym.koc...@plvisi

[PATCH] net: dsa: b53: remove redundant premature assignment to new_pvid

2020-05-27 Thread Colin King
From: Colin Ian King Variable new_pvid is being assigned with a value that is never read, the following if statement updates new_pvid with a new value in both of the if paths. The assignment is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King ---

Re: [PATCH net-next v3 2/4] net: phy: Add a helper to return the index for of the internal delay

2020-05-27 Thread Dan Murphy
Andrew On 5/26/20 7:42 PM, Andrew Lunn wrote: +/** + * phy_get_delay_index - returns the index of the internal delay + * @phydev: phy_device struct + * @delay_values: array of delays the PHY supports + * @size: the size of the delay array + * @int_delay: the internal delay to be looked up + * @d

[PATCH v2][net-next] ice: Replace one-element arrays with flexible-arrays

2020-05-27 Thread Gustavo A. R. Silva
The current codebase makes use of one-element arrays in the following form: struct something { int length; u8 data[1]; }; struct something *instance; instance = kmalloc(sizeof(*instance) + size, GFP_KERNEL); instance->length = size; memcpy(instance->data, source, size); but the preferre

Re: [PATCH net-next v3 4/4] net: dp83869: Add RGMII internal delay configuration

2020-05-27 Thread Dan Murphy
Andrew On 5/26/20 7:52 PM, Andrew Lunn wrote: @@ -218,6 +224,7 @@ static int dp83869_of_init(struct phy_device *phydev) ret = phy_read_mmd(phydev, DP83869_DEVADDR, DP83869_STRAP_STS1); if (ret < 0) return ret; + if (ret & DP

Re: [PATCH v5 06/11] net: ethernet: mtk-star-emac: new driver

2020-05-27 Thread Arnd Bergmann
On Wed, May 27, 2020 at 1:49 PM Bartosz Golaszewski wrote: > > śr., 27 maj 2020 o 13:33 Arnd Bergmann napisał(a): > > > > On Wed, May 27, 2020 at 10:46 AM Bartosz Golaszewski wrote: > > > Thanks for reporting this! I have a fix ready and will send it shortly. > > > > I already have a workaround

Re: [PATCH 00/10] staging: wfx: introduce nl80211 vendor extensions

2020-05-27 Thread Kalle Valo
Jerome Pouiller writes: > This series introduces some nl80211 vendor extensions to the wfx driver. > > This series may lead to some discussions: > > 1. Patch 7 allows to change the dynamic PS timeout. I have found > an API in wext (cfg80211_wext_siwpower()) that do more or less the >

Re: [PATCHv4 bpf-next 0/2] xdp: add dev map multicast support

2020-05-27 Thread Hangbin Liu
On Wed, May 27, 2020 at 12:21:54PM +0200, Toke Høiland-Jørgensen wrote: > > The example in patch 2 is functional, but not a lot of effort > > has been made on performance optimisation. I did a simple test(pkt size 64) > > with pktgen. Here is the test result with BPF_MAP_TYPE_DEVMAP_HASH > > arrays

[patch] flow_dissector: Fix wrong vlan header offset in __skb_flow_dissect

2020-05-27 Thread Fengtiantian
We use the openvswitch 2.7.0 and find the issue when ovs use the skb_get_hash() to get the hash of QinQ skb. Because the __skb_flow_dissect() get the wrong vlan protocol headers. Someone report bonding driver has the same issue use the __skb_flow_dissect() to count hash in bond_xmit_hash: https:/

Re: [PATCH 00/10] staging: wfx: introduce nl80211 vendor extensions

2020-05-27 Thread Jérôme Pouiller
On Wednesday 27 May 2020 14:34:37 CEST Kalle Valo wrote: > Jerome Pouiller writes: > > > This series introduces some nl80211 vendor extensions to the wfx driver. > > > > This series may lead to some discussions: > > > > 1. Patch 7 allows to change the dynamic PS timeout. I have found > > a

[no subject]

2020-05-27 Thread Warren Buffett Foundation
-- Hello Lucky One. My Name is Warren Buffett, An American business magnate, investor, speaker and philanthropist who serves as the chairman and CEO of Berkshire Hathaway,The Buffett Foundation is a charitable organisation formed 1964 in Omaha, Nebraska, by me (Warren Buffett) as a vehicle to man

Re: [PATCH net-next v3 4/4] net: dp83869: Add RGMII internal delay configuration

2020-05-27 Thread Andrew Lunn
> If the dt defines rgmii-rx/tx-id then these values are required not > optional.  That was the discussion on the binding. How many times do i need to say it. They are optional. If not specified, default to 2ns. > > > + ret = of_property_read_u32(of_node, "tx-internal-delay-ps", > > > +

Re: [PATCH v3 0/7] Statsfs: a new ram-based file system for Linux kernel statistics

2020-05-27 Thread Emanuele Giuseppe Esposito
The file system is mounted on /sys/kernel/stats and would be already used by kvm. Statsfs was initially introduced by Paolo Bonzini [1]. What's the direct motivation for this work? Moving KVM stats out of debugfs? There's many reasons: one of these is not using debugfs for statistics, but

Spende

2020-05-27 Thread Mrs.Judith Rice
Attn: Es tut uns leid, dass wir Sie aufgrund eines Mismanagent of Beneficaries-Fonds von unseren ernannten Zonal Managern verspätet kontaktiert haben. Bitte beachten Sie, dass Sie qualifiziert sind, die Zahlung von 900.000,00 USD an der ATM-Karte mit neunhunderttausend Dollar zu erhalten. Als

Re: [PATCH v3 3/7] kunit: tests for stats_fs API

2020-05-27 Thread Emanuele Giuseppe Esposito
In order to run them, the kernel .config must set CONFIG_KUNIT=y and a new .kunitconfig file must be created with CONFIG_STATS_FS=y and CONFIG_STATS_FS_TEST=y It looks like CONFIG_STATS_FS is built-in, but it exports much of the functionality you are testing. However could the tests also be

Re: [RFC v3 1/2] thermal: core: Let thermal zone device's mode be stored in its struct

2020-05-27 Thread Bartlomiej Zolnierkiewicz
Hi Daniel, On 5/23/20 11:24 PM, Daniel Lezcano wrote: > Hi Andrzej, > > On 17/04/2020 18:20, Andrzej Pietrasiewicz wrote: >> Thermal zone devices' mode is stored in individual drivers. This patch >> changes it so that mode is stored in struct thermal_zone_device instead. >> >> As a result all d

Re: [PATCH v3 0/7] Statsfs: a new ram-based file system for Linux kernel statistics

2020-05-27 Thread Andrew Lunn
> I don't really know a lot about the networking subsystem, and as it was > pointed out in another email on patch 7 by Andrew, networking needs to > atomically gather and display statistics in order to make them consistent, > and currently this is not supported by stats_fs but could be added in > f

[PATCH] [net-next] mtk-star-emac: mark PM functions as __maybe_unused

2020-05-27 Thread Arnd Bergmann
Without CONFIG_PM, the compiler warns about two unused functions: drivers/net/ethernet/mediatek/mtk_star_emac.c:1472:12: error: unused function 'mtk_star_suspend' [-Werror,-Wunused-function] drivers/net/ethernet/mediatek/mtk_star_emac.c:1488:12: error: unused function 'mtk_star_resume' [-Werror,

[PATCH] [wireless-next] mt75: fix enum type mismatch

2020-05-27 Thread Arnd Bergmann
The __mt7915_mcu_msg_send() calls a generic function that expects a mt76_txq_id rather than mt7915_txq_id, and it also uses the values according to that type, which are different from the similarly named MT7915_TXQ_ constants: drivers/net/wireless/mediatek/mt76/mt7915/mcu.c:232:9: error: implicit

Re: [PATCH] [net-next] mtk-star-emac: mark PM functions as __maybe_unused

2020-05-27 Thread Bartosz Golaszewski
śr., 27 maj 2020 o 15:35 Arnd Bergmann napisał(a): > > Without CONFIG_PM, the compiler warns about two unused functions: > > drivers/net/ethernet/mediatek/mtk_star_emac.c:1472:12: error: unused function > 'mtk_star_suspend' [-Werror,-Wunused-function] > drivers/net/ethernet/mediatek/mtk_star_emac

[PATCH] [net-next] sfc: avoid an unused-variable warning

2020-05-27 Thread Arnd Bergmann
'nic_data' is no longer used outside of the #ifdef block in efx_ef10_set_mac_address: drivers/net/ethernet/sfc/ef10.c:3231:28: error: unused variable 'nic_data' [-Werror,-Wunused-variable] struct efx_ef10_nic_data *nic_data = efx->nic_data; Move the variable into a local scope. Fixes: d

[PATCH net-next] mlx5: fix xdp data_meta setup in mlx5e_fill_xdp_buff

2020-05-27 Thread Jesper Dangaard Brouer
The helper function xdp_set_data_meta_invalid() must be called after setting xdp->data as it depends on it. The bug was introduced in 39d6443c8daf ("mlx5, xsk: Migrate to new MEM_TYPE_XSK_BUFF_POOL"), and cause the kernel to crash when using BPF helper bpf_xdp_adjust_head() on mlx5 driver. Fixes:

[PATCH] [net-next] e1000e: fix unused-function warning

2020-05-27 Thread Arnd Bergmann
The CONFIG_PM_SLEEP #ifdef checks in this file are inconsistent, leading to a warning about sometimes unused function: drivers/net/ethernet/intel/e1000e/netdev.c:137:13: error: unused function 'e1000e_check_me' [-Werror,-Wunused-function] Rather than adding more #ifdefs, just remove them complet

[PATCH] [net-next] nexthop: fix enum type confusion

2020-05-27 Thread Arnd Bergmann
Clang points out a mismatch between function arguments using a different enum type: net/ipv4/nexthop.c:841:30: error: implicit conversion from enumeration type 'enum nexthop_event_type' to different enumeration type 'enum fib_event_type' [-Werror,-Wenum-conversion] call_nexthop_notifiers

Re: [PATCH] [net-next] nexthop: fix enum type confusion

2020-05-27 Thread David Ahern
On 5/27/20 7:47 AM, Arnd Bergmann wrote: > Clang points out a mismatch between function arguments > using a different enum type: > > net/ipv4/nexthop.c:841:30: error: implicit conversion from enumeration type > 'enum nexthop_event_type' to different enumeration type 'enum fib_event_type' > [-Wer

Re: [PATCH net-next] nexthop: Fix type of event_type in call_nexthop_notifiers

2020-05-27 Thread David Ahern
On 5/27/20 2:00 AM, Nathan Chancellor wrote: > Clang warns: > > net/ipv4/nexthop.c:841:30: warning: implicit conversion from enumeration > type 'enum nexthop_event_type' to different enumeration type 'enum > fib_event_type' [-Wenum-conversion] > call_nexthop_notifiers(net, NEXTHOP_EVENT_DE

[PATCH] bridge: multicast: work around clang bug

2020-05-27 Thread Arnd Bergmann
Clang-10 and clang-11 run into a corner case of the register allocator on 32-bit ARM, leading to excessive stack usage from register spilling: net/bridge/br_multicast.c:2422:6: error: stack frame size of 1472 bytes in function 'br_multicast_get_stats' [-Werror,-Wframe-larger-than=] Work around t

[PATCH mlx5-next v1 01/11] net/mlx5: Export resource dump interface

2020-05-27 Thread Leon Romanovsky
From: Maor Gottlieb Export some of the resource dump API, so it could be used by the mlx5_ib driver as well. Signed-off-by: Maor Gottlieb Signed-off-by: Leon Romanovsky --- .../mellanox/mlx5/core/diag/rsc_dump.c| 3 ++ .../mellanox/mlx5/core/diag/rsc_dump.h| 33 +-

[PATCH rdma-next v1 00/11] RAW format dumps through RDMAtool

2020-05-27 Thread Leon Romanovsky
From: Leon Romanovsky Changelog: v1: * Maor dropped controversial change to dummy interface. v0: https://lore.kernel.org/linux-rdma/20200513095034.208385-1-l...@kernel.org Hi, The following series adds support to get the RDMA resource data in RAW format. The main motivation for doing this is t

[PATCH mlx5-next v1 02/11] net/mlx5: Add support in query QP, CQ and MKEY segments

2020-05-27 Thread Leon Romanovsky
From: Maor Gottlieb Introduce new resource dump segments - PRM_QUERY_QP, PRM_QUERY_CQ and PRM_QUERY_MKEY. These segments contains the resource dump in PRM query format. Signed-off-by: Maor Gottlieb Signed-off-by: Leon Romanovsky --- drivers/net/ethernet/mellanox/mlx5/core/diag/rsc_dump.c | 3

Spende

2020-05-27 Thread Mrs.Judith Rice
Attn: Es tut uns leid, dass wir Sie aufgrund eines Mismanagent of Beneficaries-Fonds von unseren ernannten Zonal Managern verspätet kontaktiert haben. Bitte beachten Sie, dass Sie qualifiziert sind, die Zahlung von 900.000,00 USD an der ATM-Karte mit neunhunderttausend Dollar zu erhalten. Als

  1   2   3   4   5   >