Re: [PATCH] net/mlx5: Add a missing macro undefinition

2020-06-06 Thread Hu Haowen
On 2020/6/7 2:36 PM, Leon Romanovsky wrote: On Sun, Jun 07, 2020 at 01:12:40PM +0800, Hu Haowen wrote: The macro ODP_CAP_SET_MAX is only used in function handle_hca_cap_odp() in file main.c, so it should be undefined when there are no more uses of it. Signed-off-by: Hu Haowen --- drivers/n

Re: [PATCH] net/mlx5: Add a missing macro undefinition

2020-06-06 Thread Leon Romanovsky
On Sun, Jun 07, 2020 at 01:12:40PM +0800, Hu Haowen wrote: > The macro ODP_CAP_SET_MAX is only used in function handle_hca_cap_odp() > in file main.c, so it should be undefined when there are no more uses > of it. > > Signed-off-by: Hu Haowen > --- > drivers/net/ethernet/mellanox/mlx5/core/main.c

Re: [PATCH] net/mlx5: E-Switch, Fix some error pointer dereferences

2020-06-06 Thread Leon Romanovsky
On Fri, Jun 05, 2020 at 01:52:03PM +0300, Dan Carpenter wrote: > On Thu, Jun 04, 2020 at 01:32:55PM +0300, Leon Romanovsky wrote: > > + netdev > > > > This is sort of useless. What's netdev going to do with a patch they > can't apply? I assumed that mellanox was going to take this through > their

Re: [net-next] tipc: update a binding service via broadcast

2020-06-06 Thread kernel test robot
Hi Hoang, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] [also build test WARNING on linus/master next-20200605] [cannot apply to v5.7] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we a

Re: [net-next] tipc: update a binding service via broadcast

2020-06-06 Thread kernel test robot
Hi Hoang, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] [also build test WARNING on linus/master next-20200605] [cannot apply to v5.7] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we a

[PATCH] net/mlx5: Add a missing macro undefinition

2020-06-06 Thread Hu Haowen
The macro ODP_CAP_SET_MAX is only used in function handle_hca_cap_odp() in file main.c, so it should be undefined when there are no more uses of it. Signed-off-by: Hu Haowen --- drivers/net/ethernet/mellanox/mlx5/core/main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ether

[net-next] tipc: update a binding service via broadcast

2020-06-06 Thread Hoang Huu Le
Currently, updating binding table (add service binding to name table/withdraw a service binding) is being sent over replicast. However, if we are scaling up clusters to > 100 nodes/containers this method is less affection because of looping through nodes in a cluster one by one. It is worth to use

Re: [PATCH] sunrpc: need delete xprt->timer in xs_destroy

2020-06-06 Thread Trond Myklebust
On Fri, 2020-06-05 at 10:10 +0800, Zhengbin (OSKernel) wrote: > The complete process is like this: > > xprt_destroy >wait_on_bit_lock(&xprt->state, XPRT_LOCKED, > TASK_UNINTERRUPTIBLE) > -->getlock >del_timer_sync(&xprt->timer) -->del xprt->timer >INIT_WORK(&xprt->task_cleanup, xpr

Re: [PATCH] net: mvneta: only do WoL speed down if the PHY is valid

2020-06-06 Thread Daniel González Cabanelas
Hi Russell, El vie., 5 jun. 2020 a las 11:49, Russell King - ARM Linux admin () escribió: > > On Thu, May 21, 2020 at 05:55:19PM +0200, Daniel González Cabanelas wrote: > > Thanks for the comments. > > > > I'll look for a better approach. > > > Hi Daniel, > > I've just pushed out phylink a patch a

Re: [PATCH net] net: dp83869: Reset return variable if PHY strap is read

2020-06-06 Thread David Miller
From: Dan Murphy Date: Fri, 5 Jun 2020 15:51:03 -0500 > When the PHY's strap register is read to determine if lane swapping is > needed the phy_read_mmd returns the value back into the ret variable. > > If the call to read the strap fails the failed value is returned. If > the call to read the

Re: [PATCH] rhashtable: Drop raw RCU deref in nested_table_free

2020-06-06 Thread David Miller
From: Herbert Xu Date: Wed, 3 Jun 2020 18:12:43 +1000 > This patch replaces some unnecessary uses of rcu_dereference_raw > in the rhashtable code with rcu_dereference_protected. > > The top-level nested table entry is only marked as RCU because it > shares the same type as the tree entries under

Re: [PATCH v2] cxgb4: Fix 'defined but not used' warning for cxgb4_uld_in_use()

2020-06-06 Thread David Miller
From: Tom Seewald Date: Sat, 6 Jun 2020 01:04:21 -0500 >> This doesn't apply to the net GIT tree. > Apologies, this fix is for net-next. Let me know if I should resend. Right now net == net-next, and no new changes are going into net-next.

Re: [PATCH RFC] uaccess: user_access_begin_after_access_ok()

2020-06-06 Thread Michael S. Tsirkin
On Fri, Jun 05, 2020 at 06:03:38PM +0800, Jason Wang wrote: > > On 2020/6/5 上午12:49, Michael S. Tsirkin wrote: > > > > 2. Second argument to translate_desc is a GPA, isn't it? > > > No, it's IOVA, this function will be called only when IOTLB is enabled. > > > > > > Thanks > > Right IOVA. Point st

[PATCH] i40e: silence an UBSAN false positive

2020-06-06 Thread Qian Cai
virtchnl_rss_lut.lut is used for the RSS lookup table, but in i40e_vc_config_rss_lut(), it is indexed by subscript results in a false positive. UBSAN: array-index-out-of-bounds in drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c:2983:15 index 1 is out of range for type 'u8 [1]' CPU: 34 PID:

[PATCH] Fix build failure of OCFS2 when TCP/IP is disabled

2020-06-06 Thread Tom Seewald
After commit 12abc5ee7873 ("tcp: add tcp_sock_set_nodelay") and commit c488aeadcbd0 ("tcp: add tcp_sock_set_user_timeout"), building the kernel with OCFS2_FS=y but without INET=y causes it to fail with: ld: fs/ocfs2/cluster/tcp.o: in function `o2net_accept_many': tcp.c:(.text+0x21b1): undefined re

Re: [PATCH ethtool 01/21] netlink: fix build warnings

2020-06-06 Thread Heiko Thiery
Hi Michal, On 29.05.20 01:21, Michal Kubecek wrote: Depending on compiler version and options, some of these warnings may result in build failure. - gcc 4.8 wants __KERNEL_DIV_ROUND_UP defined before including ethtool.h - avoid pointer arithmetic on void * Signed-off-by: Michal Kubecek Test

WARNING in tipc_msg_append

2020-06-06 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:5e9eeccc tipc: fix NULL pointer dereference in streaming git tree: net console output: https://syzkaller.appspot.com/x/log.txt?x=15ee307a10 kernel config: https://syzkaller.appspot.com/x/.config?x=a16ddbc78955e3a9 dashboard li

Re: [PATCH 2/2] net: dsa: qca8k: introduce SGMII configuration options

2020-06-06 Thread Jonathan McDowell
On Sat, Jun 06, 2020 at 02:43:56PM +0100, Russell King - ARM Linux admin wrote: > On Sat, Jun 06, 2020 at 11:59:09AM +0100, Jonathan McDowell wrote: > > So the device in question is a 7 port stand alone switch chip. There's a > > single SGMII port which is configurable between port 0 + 6 (they can

Re: [bpf-next PATCH 1/3] bpf: refactor sockmap redirect code so its easy to reuse

2020-06-06 Thread Jakub Sitnicki
On Fri, 29 May 2020 23:06:41 + John Fastabend wrote: > We will need this block of code called from tls context shortly > lets refactor the redirect logic so its easy to use. This also > cleans up the switch stmt so we have fewer fallthrough cases. > > No logic changes are intended. > > Fixe

Re: [PATCH v3 net-next 0/6] bnxt_en: Add 'enable_live_dev_reset' and 'allow_live_dev_reset' generic devlink params.

2020-06-06 Thread Vasundhara Volam
On Mon, Jun 1, 2020 at 9:01 PM Vasundhara Volam wrote: > > On Mon, Jun 1, 2020 at 3:34 PM Jiri Pirko wrote: > > > > Mon, Jun 01, 2020 at 10:58:09AM CEST, vasundhara-v.vo...@broadcom.com wrote: > > >On Mon, Jun 1, 2020 at 12:13 PM Jiri Pirko wrote: > > >> > > >> Mon, Jun 01, 2020 at 08:18:19AM CE

Re: [PATCH 2/2] net: dsa: qca8k: introduce SGMII configuration options

2020-06-06 Thread Andrew Lunn
> > > > Also, netdev is closed at the moment, so please post patches as RFC. > > > > > > "closed"? If you mean this won't get into 5.8 then I wasn't expecting it > > > to, I'm aware the merge window for that is already open. > > > > See https://www.kernel.org/doc/Documentation/networking/netdev-F

Re: WARNING in dev_change_net_namespace

2020-06-06 Thread syzbot
syzbot has bisected this bug to: commit 13dc4d836179444f0ca90188cfccd23f9cd9ff05 Author: Will Deacon Date: Tue Apr 21 14:29:18 2020 + arm64: cpufeature: Remove redundant call to id_aa64pfr0_32bit_el0() bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=109aa3b110 start c

Re: ethtool build failure

2020-06-06 Thread Heiko Thiery
Hi Michal, Am Sa., 6. Juni 2020 um 15:47 Uhr schrieb Heiko Thiery : > > Hi Michal, > > Am Sa., 6. Juni 2020 um 15:43 Uhr schrieb Michal Kubecek : > > > > On Sat, Jun 06, 2020 at 03:24:22PM +0200, Heiko Thiery wrote: > > > Hi Michael et all, > > > > > > I'm digging in the reason for a failure when

Re: [PATCH] ethtool: remove extra checks

2020-06-06 Thread Michal Kubecek
On Sat, Jun 06, 2020 at 03:49:05PM +0300, Vasily Averin wrote: > Found by smatch: > net/ethtool/linkmodes.c:356 ethnl_set_linkmodes() warn: > variable dereferenced before check 'info' (see line 332) > net/ethtool/linkinfo.c:143 ethnl_set_linkinfo() warn: > variable dereferenced before check 'info

Re: ethtool build failure

2020-06-06 Thread Heiko Thiery
Hi Michal, Am Sa., 6. Juni 2020 um 15:43 Uhr schrieb Michal Kubecek : > > On Sat, Jun 06, 2020 at 03:24:22PM +0200, Heiko Thiery wrote: > > Hi Michael et all, > > > > I'm digging in the reason for a failure when building ethtool with > > buildroot [1]. > > > > I see the following error: > > --- >

Re: [PATCH 2/2] net: dsa: qca8k: introduce SGMII configuration options

2020-06-06 Thread Russell King - ARM Linux admin
On Sat, Jun 06, 2020 at 11:59:09AM +0100, Jonathan McDowell wrote: > So the device in question is a 7 port stand alone switch chip. There's a > single SGMII port which is configurable between port 0 + 6 (they can > also be configure up as RGMII, while the remaining 5 ports have their > own phys). >

Re: ethtool build failure

2020-06-06 Thread Michal Kubecek
On Sat, Jun 06, 2020 at 03:24:22PM +0200, Heiko Thiery wrote: > Hi Michael et all, > > I'm digging in the reason for a failure when building ethtool with > buildroot [1]. > > I see the following error: > --- > data/buildroot/buildroot-test/instance-0/output/host/bin/i686-linux-gcc > -DHAVE_CONFIG

ethtool build failure

2020-06-06 Thread Heiko Thiery
Hi Michael et all, I'm digging in the reason for a failure when building ethtool with buildroot [1]. I see the following error: --- data/buildroot/buildroot-test/instance-0/output/host/bin/i686-linux-gcc -DHAVE_CONFIG_H -I. -I./uapi -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=

[PATCH] ethtool: remove extra checks

2020-06-06 Thread Vasily Averin
Found by smatch: net/ethtool/linkmodes.c:356 ethnl_set_linkmodes() warn: variable dereferenced before check 'info' (see line 332) net/ethtool/linkinfo.c:143 ethnl_set_linkinfo() warn: variable dereferenced before check 'info' (see line 119 In both cases non-zero 'info' is always provided by call

[ANNOUNCE] nftables 0.9.5 release

2020-06-06 Thread Pablo Neira Ayuso
Hi! The Netfilter project proudly presents: nftables 0.9.5 This release contains fixes and new features available up to the Linux kernel 5.7 release. * Support for set counters: table ip x { set y { typeof ip saddr counter

Re: [PATCH 2/2] net: dsa: qca8k: introduce SGMII configuration options

2020-06-06 Thread Jonathan McDowell
On Sat, Jun 06, 2020 at 09:37:41AM +0100, Russell King - ARM Linux admin wrote: > On Sat, Jun 06, 2020 at 08:49:16AM +0100, Jonathan McDowell wrote: > > On Fri, Jun 05, 2020 at 08:38:43PM +0200, Andrew Lunn wrote: > > > On Fri, Jun 05, 2020 at 07:10:58PM +0100, Jonathan McDowell wrote: > > > > The

Re: WARNING in dev_change_net_namespace

2020-06-06 Thread syzbot
syzbot has found a reproducer for the following crash on: HEAD commit:7ae77150 Merge tag 'powerpc-5.8-1' of git://git.kernel.org.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=1011221210 kernel config: https://syzkaller.appspot.com/x/.config?x=be4578b

Re: [PATCH 2/2] net: dsa: qca8k: introduce SGMII configuration options

2020-06-06 Thread Russell King - ARM Linux admin
On Sat, Jun 06, 2020 at 08:49:16AM +0100, Jonathan McDowell wrote: > On Fri, Jun 05, 2020 at 08:38:43PM +0200, Andrew Lunn wrote: > > On Fri, Jun 05, 2020 at 07:10:58PM +0100, Jonathan McDowell wrote: > > > The QCA8337(N) has an SGMII port which can operate in MAC, PHY or BASE-X > > > mode dependin

Re: [PATCH net v2] esp: select CRYPTO_SEQIV when useful

2020-06-06 Thread Steffen Klassert
On Fri, Jun 05, 2020 at 11:00:23AM -0700, Eric Biggers wrote: > On Fri, Jun 05, 2020 at 10:39:31AM -0700, Eric Biggers wrote: > > From: Eric Biggers > > > > diff --git a/net/ipv4/Kconfig b/net/ipv4/Kconfig > > index 23ba5045e3d3..6520b30883cf 100644 > > --- a/net/ipv4/Kconfig > > +++ b/net/ipv4/K

Re: [PATCH v2] cxgb4: Fix 'defined but not used' warning for cxgb4_uld_in_use()

2020-06-06 Thread Tom Seewald
Looks like this has already been fixed in net, sorry for the noise.

Re: Hang on wireless removal..

2020-06-06 Thread Johannes Berg
Hi, sorry for the top post, on my phone. Yes, your analysis is spot on I think. I've got a fix for this in my jberg/mac80211 tree, there's a deadlock with a work struct and the rtnl. Sorry about that. My testing should've caught it, but that exact scenario didn't happen, and lockdep for disabl

Re: [PATCH 2/2] net: dsa: qca8k: introduce SGMII configuration options

2020-06-06 Thread Jonathan McDowell
On Fri, Jun 05, 2020 at 08:38:43PM +0200, Andrew Lunn wrote: > On Fri, Jun 05, 2020 at 07:10:58PM +0100, Jonathan McDowell wrote: > > The QCA8337(N) has an SGMII port which can operate in MAC, PHY or BASE-X > > mode depending on what it's connected to (e.g. CPU vs external PHY or > > SFP). At prese