Re: [PATCH net-next RFC v4 01/15] devlink: Add reload action option to devlink reload command

2020-09-14 Thread Vasundhara Volam
On Mon, Sep 14, 2020 at 11:39 AM Moshe Shemesh wrote: > > Add devlink reload action to allow the user to request a specific reload > action. The action parameter is optional, if not specified then devlink > driver re-init action is used (backward compatible). > Note that when required to do firmwa

Re: [RFC PATCH 00/22] Enhance VHOST to enable SoC-to-SoC communication

2020-09-14 Thread Kishon Vijay Abraham I
Hi Jason, On 01/09/20 2:20 pm, Jason Wang wrote: > > On 2020/9/1 下午1:24, Kishon Vijay Abraham I wrote: >> Hi, >> >> On 28/08/20 4:04 pm, Cornelia Huck wrote: >>> On Thu, 9 Jul 2020 14:26:53 +0800 >>> Jason Wang wrote: >>> >>> [Let me note right at the beginning that I first noted this while >>>

[net-next v3 00/20] ethernet: convert tasklets to use new tasklet_setup API

2020-09-14 Thread Allen Pais
From: Allen Pais Commit 12cc923f1ccc ("tasklet: Introduce new initialization API")' introduced a new tasklet initialization API. This series converts all the crypto modules to use the new tasklet_setup() API This series is based on v5.9-rc5 v3: fix subject prefix use backpointer instead of

[net-next v3 02/20] net: amd-xgbe: convert tasklets to use new tasklet_setup() API

2020-09-14 Thread Allen Pais
From: Allen Pais In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- drivers/net/eth

[net-next v3 03/20] cnic: convert tasklets to use new tasklet_setup() API

2020-09-14 Thread Allen Pais
From: Allen Pais In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- drivers/net/eth

[net-next v3 01/20] net: alteon: convert tasklets to use new tasklet_setup() API

2020-09-14 Thread Allen Pais
From: Allen Pais In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- drivers/net/eth

[net-next v3 05/20] liquidio: convert tasklets to use new tasklet_setup() API

2020-09-14 Thread Allen Pais
From: Allen Pais In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- drivers/net/eth

[net-next v3 06/20] chelsio: convert tasklets to use new tasklet_setup() API

2020-09-14 Thread Allen Pais
From: Allen Pais In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- drivers/net/eth

[net-next v3 04/20] net: macb: convert tasklets to use new tasklet_setup() API

2020-09-14 Thread Allen Pais
From: Allen Pais In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- drivers/net/eth

[net-next v3 08/20] net: hinic: convert tasklets to use new tasklet_setup() API

2020-09-14 Thread Allen Pais
From: Allen Pais In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- drivers/net/eth

[net-next v3 09/20] net: ehea: convert tasklets to use new tasklet_setup() API

2020-09-14 Thread Allen Pais
From: Allen Pais In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- drivers/net/eth

[net-next v3 07/20] net: sundance: convert tasklets to use new tasklet_setup() API

2020-09-14 Thread Allen Pais
From: Allen Pais In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- drivers/net/eth

[net-next v3 10/20] ibmvnic: convert tasklets to use new tasklet_setup() API

2020-09-14 Thread Allen Pais
From: Allen Pais In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- drivers/net/eth

[net-next v3 11/20] net: jme: convert tasklets to use new tasklet_setup() API

2020-09-14 Thread Allen Pais
From: Allen Pais In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- drivers/net/eth

[net-next v3 19/20] net: silan: convert tasklets to use new tasklet_setup() API

2020-09-14 Thread Allen Pais
From: Allen Pais In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- drivers/net/eth

[net-next v3 17/20] net: nixge: convert tasklets to use new tasklet_setup() API

2020-09-14 Thread Allen Pais
From: Allen Pais In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- drivers/net/eth

[net-next v3 13/20] net: mlx: convert tasklets to use new tasklet_setup() API

2020-09-14 Thread Allen Pais
From: Allen Pais In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- drivers/net/eth

[RESEND net-next v2 00/12]drivers: net: convert tasklets to use new tasklet_setup() API

2020-09-14 Thread Allen Pais
From: Allen Pais ommit 12cc923f1ccc ("tasklet: Introduce new initialization API")' introduced a new tasklet initialization API. This series converts all the net/* drivers to use the new tasklet_setup() API This series is based on v5.9-rc5 Allen Pais (12): net: mvpp2: Prepare to use the new ta

[net-next v3 12/20] net: skge: convert tasklets to use new tasklet_setup() API

2020-09-14 Thread Allen Pais
From: Allen Pais In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- drivers/net/eth

[net-next v3 15/20] net: natsemi: convert tasklets to use new tasklet_setup() API

2020-09-14 Thread Allen Pais
From: Allen Pais In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- drivers/net/eth

[net-next v3 16/20] nfp: convert tasklets to use new tasklet_setup() API

2020-09-14 Thread Allen Pais
From: Allen Pais In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- drivers/net/eth

[net-next v3 20/20] net: smc91x: convert tasklets to use new tasklet_setup() API

2020-09-14 Thread Allen Pais
From: Allen Pais In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- drivers/net/eth

[net-next v3 14/20] net: micrel: convert tasklets to use new tasklet_setup() API

2020-09-14 Thread Allen Pais
From: Allen Pais In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- drivers/net/eth

[net-next v3 18/20] qed: convert tasklets to use new tasklet_setup() API

2020-09-14 Thread Allen Pais
From: Allen Pais In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- drivers/net/eth

[RESEND net-next v2 12/12] net: usbnet: convert tasklets to use new tasklet_setup() API

2020-09-14 Thread Allen Pais
From: Allen Pais In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly and remove the .data field. Signed-off-by: Romain Perier Signed-off-by: Allen

[RESEND net-next v2 11/12] net: rtl8150: convert tasklets to use new tasklet_setup() API

2020-09-14 Thread Allen Pais
From: Allen Pais In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- drivers/net/usb

[RESEND net-next v2 03/12] net: caif: convert tasklets to use new tasklet_setup() API

2020-09-14 Thread Allen Pais
From: Allen Pais In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- drivers/net/cai

[RESEND net-next v2 05/12] net: ppp: convert tasklets to use new tasklet_setup() API

2020-09-14 Thread Allen Pais
From: Allen Pais In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- drivers/net/ppp

[RESEND net-next v2 06/12] net: cdc_ncm: convert tasklets to use new tasklet_setup() API

2020-09-14 Thread Allen Pais
From: Allen Pais In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- drivers/net/usb

[RESEND net-next v2 01/12] net: mvpp2: Prepare to use the new tasklet API

2020-09-14 Thread Allen Pais
From: Allen Pais The future tasklet API will no longer allow to pass an arbitrary "unsigned long" data parameter. The tasklet data structure will need to be embedded into a data structure that will be retrieved from the tasklet handler. Currently, there are no ways to retrieve the "struct mvpp2_p

[RESEND net-next v2 08/12] net: lan78xx: convert tasklets to use new tasklet_setup() API

2020-09-14 Thread Allen Pais
From: Allen Pais In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- drivers/net/usb

[RESEND net-next v2 09/12] net: pegasus: convert tasklets to use new tasklet_setup() API

2020-09-14 Thread Allen Pais
From: Allen Pais In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- drivers/net/usb

[RESEND net-next v2 02/12] net: arcnet: convert tasklets to use new tasklet_setup() API

2020-09-14 Thread Allen Pais
From: Allen Pais In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- drivers/net/arc

[RESEND net-next v2 07/12] net: hso: convert tasklets to use new tasklet_setup() API

2020-09-14 Thread Allen Pais
From: Allen Pais In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- drivers/net/usb

[RESEND net-next v2 04/12] net: ifb: convert tasklets to use new tasklet_setup() API

2020-09-14 Thread Allen Pais
From: Allen Pais In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- drivers/net/ifb

[RESEND net-next v2 10/12] net: r8152: convert tasklets to use new tasklet_setup() API

2020-09-14 Thread Allen Pais
From: Allen Pais In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- drivers/net/usb

Re: [PATCH] Revert "net: linkwatch: add check for netdevice being present to linkwatch_do_dev"

2020-09-14 Thread Geert Uytterhoeven
Hi David, CC bridge On Sun, Sep 13, 2020 at 3:34 AM David Miller wrote: > From: Geert Uytterhoeven > Date: Sat, 12 Sep 2020 14:33:59 +0200 > > > "dev" is not the bridge device, but the physical Ethernet interface, which > > may already be suspended during s2ram. > > Hmmm, ok. > > Looking more d

[PATCH net-next v2] net/packet: Fix a comment about hard_header_len and headroom allocation

2020-09-14 Thread Xie He
This comment is outdated and no longer reflects the actual implementation of af_packet.c. Reasons for the new comment: 1. In af_packet.c, the function packet_snd first reserves a headroom of length (dev->hard_header_len + dev->needed_headroom). Then if the socket is a SOCK_DGRAM socket, it calls

Re: [PATCH net-next] net: bridge: pop vlan from skb if filtering is disabled but it's a pvid

2020-09-14 Thread Nikolay Aleksandrov
On Sat, 2020-09-12 at 12:38 -0700, Florian Fainelli wrote: > > On 9/11/2020 11:56 PM, Nikolay Aleksandrov wrote: > > On Sat, 2020-09-12 at 02:16 +0300, Vladimir Oltean wrote: > > > Currently the bridge untags VLANs from its VLAN group in > > > __allowed_ingress() only when VLAN filtering is enable

RE: [Linux-kernel-mentees] [PATCH] net: fix uninit value error in __sys_sendmmsg

2020-09-14 Thread David Laight
From: Greg KH > Sent: 13 September 2020 07:14 > On Sun, Sep 13, 2020 at 11:26:39AM +0530, Anant Thazhemadam wrote: > > The crash report showed that there was a local variable; > > > > iovstack.i@__sys_sendmmsg created at: > > ___sys_sendmsg net/socket.c:2388 [inline] > > __sys_sendmmsg+0x6db/

[PATCH net-next v2 01/13] mptcp: rethink 'is writable' conditional

2020-09-14 Thread Paolo Abeni
Currently, when checking for the 'msk is writable' condition, we look at the individual subflows write space. That works well while we send data via a single subflow, but will not as soon as we will enable concurrent xmit on multiple subflows. With this change msk becomes writable when the followi

[PATCH net-next v2 08/13] mptcp: add OoO related mibs

2020-09-14 Thread Paolo Abeni
Add a bunch of MPTCP mibs related to MPTCP OoO data processing. Signed-off-by: Paolo Abeni --- net/mptcp/mib.c | 5 + net/mptcp/mib.h | 5 + net/mptcp/protocol.c | 24 +++- net/mptcp/subflow.c | 1 + 4 files changed, 34 insertions(+), 1 deletion(-) diff

[PATCH net-next v2 12/13] mptcp: call tcp_cleanup_rbuf on subflows

2020-09-14 Thread Paolo Abeni
That is needed to let the subflows announce promptly when new space is available in the receive buffer. tcp_cleanup_rbuf() is currently a static function, drop the scope modifier and add a declaration in the TCP header. Reviewed-by: Mat Martineau Signed-off-by: Paolo Abeni --- include/net/tcp.

[PATCH net-next v2 11/13] mptcp: allow picking different xmit subflows

2020-09-14 Thread Paolo Abeni
Update the scheduler to less trivial heuristic: cache the last used subflow, and try to send on it a reasonably long burst of data. When the burst or the subflow send space is exhausted, pick the subflow with the lower ratio between write space and send buffer - that is, the subflow with the great

[PATCH net-next v2 02/13] mptcp: set data_ready status bit in subflow_check_data_avail()

2020-09-14 Thread Paolo Abeni
This simplify mptcp_subflow_data_available() and will made follow-up patches simpler. Additionally remove the unneeded checks on subflow copied_seq: we always whole skbs out of subflows. Signed-off-by: Paolo Abeni --- net/mptcp/subflow.c | 19 --- 1 file changed, 8 insertions(+)

[PATCH net-next v2 00/13] mptcp: introduce support for real multipath xmit

2020-09-14 Thread Paolo Abeni
This series enable MPTCP socket to transmit data on multiple subflows concurrently in a load balancing scenario. First the receive code path is refactored to better deal with out-of-order data (patches 1-7). An RB-tree is introduced to queue MPTCP-level out-of-order data, closely resembling the TC

[PATCH net-next v2 05/13] mptcp: introduce and use mptcp_try_coalesce()

2020-09-14 Thread Paolo Abeni
Factor-out existing code, will be re-used by the next patch. Signed-off-by: Paolo Abeni --- net/mptcp/protocol.c | 31 +++ 1 file changed, 19 insertions(+), 12 deletions(-) diff --git a/net/mptcp/protocol.c b/net/mptcp/protocol.c index 4f12a8ce0ddd..5a2ff333e426 1006

[PATCH net-next v2 07/13] mptcp: cleanup mptcp_subflow_discard_data()

2020-09-14 Thread Paolo Abeni
There is no need to use the tcp_read_sock(), we can simply drop the skb. Additionally try to look at the next buffer for in order data. This both simplifies the code and avoid unneeded indirect calls. Signed-off-by: Paolo Abeni --- net/mptcp/protocol.h | 1 - net/mptcp/subflow.c | 58

[PATCH net-next v2 06/13] mptcp: move ooo skbs into msk out of order queue.

2020-09-14 Thread Paolo Abeni
Add an RB-tree to cope with OoO (at MPTCP level) data. __mptcp_move_skb() insert into the RB tree "future" data, eventually coalescing skb as allowed by the MPTCP DSN. To simplify sequence accounting, move the DSN inside the cb. After successfully enqueuing in sequence data, check if we can use a

[PATCH net-next v2 09/13] mptcp: move address attribute into mptcp_addr_info

2020-09-14 Thread Paolo Abeni
So that can be accessed easily from the subflow creation helper. No functional change intended. Signed-off-by: Paolo Abeni --- net/mptcp/pm_netlink.c | 39 --- net/mptcp/protocol.h | 5 +++-- net/mptcp/subflow.c| 5 ++--- 3 files changed, 25 insertions

[PATCH net-next v2 10/13] mptcp: allow creating non-backup subflows

2020-09-14 Thread Paolo Abeni
Currently the 'backup' attribute of local endpoint is ignored. Let's use it for the MP_JOIN handshake Signed-off-by: Paolo Abeni --- net/mptcp/subflow.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/mptcp/subflow.c b/net/mptcp/subflow.c index ae3eeb9bb191..8be401349d9

[PATCH net-next v2 13/13] mptcp: simult flow self-tests

2020-09-14 Thread Paolo Abeni
Add a bunch of test-cases for multiple subflow xmit: create multiple subflows simulating different links condition via netem and verify that the msk is able to use completely the aggregated bandwidth. Signed-off-by: Paolo Abeni --- tools/testing/selftests/net/mptcp/Makefile| 3 +- .../self

[PATCH net-next v2 04/13] mptcp: basic sndbuf autotuning

2020-09-14 Thread Paolo Abeni
Let the msk sendbuf track the size of the larger subflow's send window, so that we ensure mptcp_sendmsg() does not exceed MPTCP-level send window. The update is performed just before try to send any data. Signed-off-by: Paolo Abeni --- net/mptcp/protocol.c | 17 + 1 file changed

[PATCH net-next v2 03/13] mptcp: trigger msk processing even for OoO data

2020-09-14 Thread Paolo Abeni
This is a prerequisite to allow receiving data from multiple subflows without re-injection. Instead of dropping the OoO - "future" data in subflow_check_data_avail(), call into __mptcp_move_skbs() and let the msk drop that. To avoid code duplication factor out the mptcp_subflow_discard_data() hel

Re: [PATCH v2] net: fix uninit value error in __sys_sendmmsg

2020-09-14 Thread Anant Thazhemadam
On 13/09/20 4:33 pm, Anant Thazhemadam wrote: > The crash report indicated that there was a local variable; > iovstack.i@__sys_sendmmsg created at: > ___sys_sendmsg net/socket.c:2388 [inline] > __sys_sendmmsg+0x6db/0xc90 net/socket.c:2480 > > that was left uninitialized. > > Initializing t

Re: [PATCH bpf-next] bpftool: fix build failure

2020-09-14 Thread Quentin Monnet
On 14/09/2020 07:12, Yonghong Song wrote: > When building bpf selftests like > make -C tools/testing/selftests/bpf -j20 > I hit the following errors: > ... > GEN > /net-next/tools/testing/selftests/bpf/tools/build/bpftool/Documentation/bpftool-gen.8 > :75: (WARNING/2) Block quote ends

Re: [RESEND net-next v2 12/12] net: usbnet: convert tasklets to use new tasklet_setup() API

2020-09-14 Thread Oliver Neukum
Am Montag, den 14.09.2020, 13:01 +0530 schrieb Allen Pais: > From: Allen Pais > > In preparation for unconditionally passing the > struct tasklet_struct pointer to all tasklet > callbacks, switch to using the new tasklet_setup() > and from_tasklet() to pass the tasklet pointer explicitly > and re

[PATCH] arm64: bpf: Fix branch offset in JIT

2020-09-14 Thread Ilias Apalodimas
Running the eBPF test_verifier leads to random errors looking like this: [ 6525.735488] Unexpected kernel BRK exception at EL1 [ 6525.735502] Internal error: ptrace BRK handler: f2000100 [#1] SMP [ 6525.741609] Modules linked in: nls_utf8 cifs libdes libarc4 dns_resolver fscache binfmt_misc nls_a

Re: [PATCH v3 08/11] Input: hyperv-keyboard: Make ringbuffer at least take two pages

2020-09-14 Thread Boqun Feng
On Thu, Sep 10, 2020 at 10:34:52PM +0800, Boqun Feng wrote: > When PAGE_SIZE > HV_HYP_PAGE_SIZE, we need the ringbuffer size to be at > least 2 * PAGE_SIZE: one page for the header and at least one page of > the data part (because of the alignment requirement for double mapping). > > So make sure

[PATCH 2/3] can: xilinx_can: Check return value of set_reset_mode

2020-09-14 Thread Michal Simek
From: Srinivas Neeli Check return value of set_reset_mode() for error. Addresses-Coverity: "check_return" Signed-off-by: Srinivas Neeli Signed-off-by: Michal Simek --- drivers/net/can/xilinx_can.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/can/xilinx

[PATCH 1/3] can: xilinx_can: Limit CANFD brp to 2

2020-09-14 Thread Michal Simek
From: Srinivas Neeli Bit enlarging is observed for CANFD2.0 when brp is 1, So change brp_min value to 2. Signed-off-by: Srinivas Neeli Signed-off-by: Michal Simek --- drivers/net/can/xilinx_can.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/can/xilinx_c

[PATCH 3/3] can: xilinx_can: Fix incorrect variable and initialize with a default value

2020-09-14 Thread Michal Simek
From: Srinivas Neeli Some variables with incorrect type were passed to "of_property_read_u32" API, "of_property_read_u32" API was expecting an "u32 *" but the formal parameter that was passed was of type "int *". Fixed the issue by changing the variable types from "int" to "u32" and initialized w

[PATCH 0/3] can: xilinx_can: Some minor changes

2020-09-14 Thread Michal Simek
Hi, recently some small patches come to our internal tree. We started to use coverity which found 2 issues (last two patches) which is simply to fix. Thanks, Michal Srinivas Neeli (3): can: xilinx_can: Limit CANFD brp to 2 can: xilinx_can: Check return value of set_reset_mode can: xilinx_

WARNING in taprio_change

2020-09-14 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:5760d9ac net: ethernet: ti: cpsw_new: fix suspend/resume git tree: net console output: https://syzkaller.appspot.com/x/log.txt?x=14c4e05390 kernel config: https://syzkaller.appspot.com/x/.config?x=bd46548257448703 dashboard li

Re: [PATCH RFC bpf-next 2/2] bpf: Enable bpf_skc_to_* sock casting helper to networking prog type

2020-09-14 Thread Lorenz Bauer
On Sat, 12 Sep 2020 at 05:59, Martin KaFai Lau wrote: > > There is a constant need to add more fields into the bpf_tcp_sock > for the bpf programs running at tc, sock_ops...etc. > > A current workaround could be to use bpf_probe_read_kernel(). However, > other than making another helper call for

kernel BUG at net/wireless/core.h:LINE!

2020-09-14 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:e4c26faa Merge tag 'usb-5.9-rc5' of git://git.kernel.org/p.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=1130fc4390 kernel config: https://syzkaller.appspot.com/x/.config?x=c61610091f4ca8c4 das

Re: [PATCH RFC bpf-next 1/2] bpf: Move the PTR_TO_BTF_ID check to check_reg_type()

2020-09-14 Thread Lorenz Bauer
On Sat, 12 Sep 2020 at 05:59, Martin KaFai Lau wrote: > > check_reg_type() checks whether a reg can be used as an arg of a > func_proto. For PTR_TO_BTF_ID, the check is actually not > completely done until the reg->btf_id is pointing to a > kernel struct that is acceptable by the func_proto. > >

INFO: trying to register non-static key in cfg80211_release_pmsr

2020-09-14 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:7fe10096 Merge branch 'linus' of git://git.kernel.org/pub/.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=1655e24590 kernel config: https://syzkaller.appspot.com/x/.config?x=a9075b36a6ae26c9 das

Re: [PATCH v3 08/11] Input: hyperv-keyboard: Make ringbuffer at least take two pages

2020-09-14 Thread Wei Liu
On Mon, Sep 14, 2020 at 04:46:00PM +0800, Boqun Feng wrote: > On Thu, Sep 10, 2020 at 10:34:52PM +0800, Boqun Feng wrote: > > When PAGE_SIZE > HV_HYP_PAGE_SIZE, we need the ringbuffer size to be at > > least 2 * PAGE_SIZE: one page for the header and at least one page of > > the data part (because

Re: [PATCH net-next RFC v4 01/15] devlink: Add reload action option to devlink reload command

2020-09-14 Thread Jiri Pirko
Mon, Sep 14, 2020 at 09:08:58AM CEST, vasundhara-v.vo...@broadcom.com wrote: >On Mon, Sep 14, 2020 at 11:39 AM Moshe Shemesh wrote: [...] >> @@ -1126,15 +1126,24 @@ mlxsw_devlink_core_bus_device_reload_down(struct >> devlink *devlink, >> } >> >> static int >> -mlxsw_devlink_core_bus_device_r

general protection fault in tipc_mon_reinit_self

2020-09-14 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:7fe10096 Merge branch 'linus' of git://git.kernel.org/pub/.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=14886e9e90 kernel config: https://syzkaller.appspot.com/x/.config?x=a9075b36a6ae26c9 das

Re: [PATCH net-next v2] net/packet: Fix a comment about hard_header_len and headroom allocation

2020-09-14 Thread Willem de Bruijn
On Mon, Sep 14, 2020 at 9:42 AM Xie He wrote: > > This comment is outdated and no longer reflects the actual implementation > of af_packet.c. > > Reasons for the new comment: > > 1. > > In af_packet.c, the function packet_snd first reserves a headroom of > length (dev->hard_header_len + dev->neede

RE: [PATCH 05/15] habanalabs/gaudi: add NIC Ethernet support

2020-09-14 Thread Omer Shpigelman
On Thu, Sep 10, 2020 at 11:03 PM Jakub Kicinski wrote: > On Thu, 10 Sep 2020 19:11:16 +0300 Oded Gabbay wrote: > > +module_param(nic_rx_poll, int, 0444); > MODULE_PARM_DESC(nic_rx_poll, > > + "Enable NIC Rx polling mode (0 = no, 1 = yes, default no)"); > > If your chip does not support IRQ coal

Re: [PATCH net-next RFC v4 01/15] devlink: Add reload action option to devlink reload command

2020-09-14 Thread Vasundhara Volam
On Mon, Sep 14, 2020 at 3:02 PM Jiri Pirko wrote: > > Mon, Sep 14, 2020 at 09:08:58AM CEST, vasundhara-v.vo...@broadcom.com wrote: > >On Mon, Sep 14, 2020 at 11:39 AM Moshe Shemesh wrote: > > [...] > > > >> @@ -1126,15 +1126,24 @@ mlxsw_devlink_core_bus_device_reload_down(struct > >> devlink *de

Re: [Intel-wired-lan] [PATCH net-next] i40e: allow VMDQs to be used with AF_XDP zero-copy

2020-09-14 Thread Magnus Karlsson
On Fri, Sep 11, 2020 at 8:42 PM Alexander Duyck wrote: > > On Fri, Sep 11, 2020 at 11:05 AM Samudrala, Sridhar > wrote: > > > > > > > > On 9/11/2020 6:10 AM, Maciej Fijalkowski wrote: > > > On Fri, Sep 11, 2020 at 02:29:50PM +0200, Magnus Karlsson wrote: > > >> On Fri, Sep 11, 2020 at 2:11 PM Mac

Re: [PATCH v3 08/11] Input: hyperv-keyboard: Make ringbuffer at least take two pages

2020-09-14 Thread Boqun Feng
On Mon, Sep 14, 2020 at 09:30:16AM +, Wei Liu wrote: > On Mon, Sep 14, 2020 at 04:46:00PM +0800, Boqun Feng wrote: > > On Thu, Sep 10, 2020 at 10:34:52PM +0800, Boqun Feng wrote: > > > When PAGE_SIZE > HV_HYP_PAGE_SIZE, we need the ringbuffer size to be at > > > least 2 * PAGE_SIZE: one page fo

Re: INFO: task hung in ctrl_getfamily

2020-09-14 Thread syzbot
syzbot suspects this issue was fixed by commit: commit 47733f9daf4fe4f7e0eb9e273f21ad3a19130487 Author: Cong Wang Date: Sat Aug 15 23:29:15 2020 + tipc: fix uninit skb->data in tipc_nl_compat_dumpit() bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=13f287b390 start co

Re: [PATCH net-next RFC v4 01/15] devlink: Add reload action option to devlink reload command

2020-09-14 Thread Jiri Pirko
Mon, Sep 14, 2020 at 11:54:55AM CEST, vasundhara-v.vo...@broadcom.com wrote: >On Mon, Sep 14, 2020 at 3:02 PM Jiri Pirko wrote: >> >> Mon, Sep 14, 2020 at 09:08:58AM CEST, vasundhara-v.vo...@broadcom.com wrote: >> >On Mon, Sep 14, 2020 at 11:39 AM Moshe Shemesh wrote: >> >> [...] >> >> >> >> @@ -

Re: [PATCH nf-next v3 3/3] netfilter: Introduce egress hook

2020-09-14 Thread Laura García Liébana
Hi Daniel, On Fri, Sep 11, 2020 at 6:28 PM Daniel Borkmann wrote: > > On 9/11/20 9:42 AM, Laura García Liébana wrote: > > On Tue, Sep 8, 2020 at 2:55 PM Daniel Borkmann wrote: > >> On 9/5/20 7:24 AM, Lukas Wunner wrote: > >>> On Fri, Sep 04, 2020 at 11:14:37PM +0200, Daniel Borkmann wrote: > >>>

Re: [PATCH net-next RFC v4 15/15] devlink: Add Documentation/networking/devlink/devlink-reload.rst

2020-09-14 Thread Jiri Pirko
Mon, Sep 14, 2020 at 08:08:02AM CEST, mo...@mellanox.com wrote: >Add devlink reload rst documentation file. >Update index file to include it. > >Signed-off-by: Moshe Shemesh >--- >v3 -> v4: >- Remove reload action fw_activate_no_reset >- Add reload actions limit levels and document the no_reset li

Re: [PATCH V1 net-next 2/8] net: ena: Add device distinct log prefix to files

2020-09-14 Thread Shay Agroskin
David Miller writes: From: Shay Agroskin Date: Sun, 13 Sep 2020 11:16:34 +0300 ENA logs are adjusted to display the full ENA representation to distinct each ENA device in case of multiple interfaces. Using dev_err/warn/info function family for logging provides uniform printing with clear

Re: [PATCH] arm64: bpf: Fix branch offset in JIT

2020-09-14 Thread Will Deacon
On Mon, Sep 14, 2020 at 11:36:21AM +0300, Ilias Apalodimas wrote: > Running the eBPF test_verifier leads to random errors looking like this: > > [ 6525.735488] Unexpected kernel BRK exception at EL1 > [ 6525.735502] Internal error: ptrace BRK handler: f2000100 [#1] SMP > [ 6525.741609] Modules lin

Re: [PATCH net-next RFC v4 01/15] devlink: Add reload action option to devlink reload command

2020-09-14 Thread Jiri Pirko
Mon, Sep 14, 2020 at 08:07:48AM CEST, mo...@mellanox.com wrote: >Add devlink reload action to allow the user to request a specific reload >action. The action parameter is optional, if not specified then devlink >driver re-init action is used (backward compatible). >Note that when required to do fir

Re: [PATCH] arm64: bpf: Fix branch offset in JIT

2020-09-14 Thread Ilias Apalodimas
On Mon, Sep 14, 2020 at 01:20:43PM +0100, Will Deacon wrote: > On Mon, Sep 14, 2020 at 11:36:21AM +0300, Ilias Apalodimas wrote: > > Running the eBPF test_verifier leads to random errors looking like this: > > > > [ 6525.735488] Unexpected kernel BRK exception at EL1 > > [ 6525.735502] Internal er

Re: [PATCH net-next RFC v4 02/15] devlink: Add reload action limit level

2020-09-14 Thread Jiri Pirko
Mon, Sep 14, 2020 at 08:07:49AM CEST, mo...@mellanox.com wrote: [..] >diff --git a/include/net/devlink.h b/include/net/devlink.h >index b09db891db04..9ee5b8a9 100644 >--- a/include/net/devlink.h >+++ b/include/net/devlink.h >@@ -1012,9 +1012,13 @@ enum devlink_trap_g

[PATCH net-next] net: dnet: remove unused variable 'tx_status 'in dnet_start_xmit()

2020-09-14 Thread Zhang Changzhong
Fixes the following W=1 kernel build warning(s): drivers/net/ethernet/dnet.c:510:6: warning: variable 'tx_status' set but not used [-Wunused-but-set-variable] u32 tx_status, irq_enable; ^ After commit 4796417417a6 ("dnet: Dave DNET ethernet controller driver (updated)"), variable

[PATCH AUTOSEL 4.4 4/8] SUNRPC: stop printk reading past end of string

2020-09-14 Thread Sasha Levin
From: "J. Bruce Fields" [ Upstream commit 8c6b6c793ed32b8f9770ebcdf1ba99af423c303b ] Since p points at raw xdr data, there's no guarantee that it's NULL terminated, so we should give a length. And probably escape any special characters too. Reported-by: Zhi Li Signed-off-by: J. Bruce Fields

[PATCH net-next] net: fec: ptp: remove unused variable 'ns' in fec_time_keep()

2020-09-14 Thread Zhang Changzhong
Fixes the following W=1 kernel build warning(s): drivers/net/ethernet/freescale/fec_ptp.c:523:6: warning: variable 'ns' set but not used [-Wunused-but-set-variable] 523 | u64 ns; | ^~ After commit 6605b730c061 ("FEC: Add time stamping code and a PTP hardware clock"), variable 'ns'

[PATCH AUTOSEL 4.9 06/10] SUNRPC: stop printk reading past end of string

2020-09-14 Thread Sasha Levin
From: "J. Bruce Fields" [ Upstream commit 8c6b6c793ed32b8f9770ebcdf1ba99af423c303b ] Since p points at raw xdr data, there's no guarantee that it's NULL terminated, so we should give a length. And probably escape any special characters too. Reported-by: Zhi Li Signed-off-by: J. Bruce Fields

[PATCH net-next] net: pxa168_eth: remove unused variable 'retval' int pxa168_eth_change_mtu()

2020-09-14 Thread Zhang Changzhong
Fixes the following W=1 kernel build warning(s): drivers/net/ethernet/marvell/pxa168_eth.c:1190:6: warning: variable 'retval' set but not used [-Wunused-but-set-variable] 1190 | int retval; | ^~ Function pxa168_eth_change_mtu() always return zero, so variable 'retval' is redunda

Re: [PATCH] arm64: bpf: Fix branch offset in JIT

2020-09-14 Thread Ilias Apalodimas
Hi Will, On Mon, Sep 14, 2020 at 03:35:04PM +0300, Ilias Apalodimas wrote: > On Mon, Sep 14, 2020 at 01:20:43PM +0100, Will Deacon wrote: > > On Mon, Sep 14, 2020 at 11:36:21AM +0300, Ilias Apalodimas wrote: > > > Running the eBPF test_verifier leads to random errors looking like this: > > > > >

Re: [PATCH net-next RFC v4 03/15] devlink: Add reload action stats

2020-09-14 Thread Jiri Pirko
Mon, Sep 14, 2020 at 08:07:50AM CEST, mo...@mellanox.com wrote: >Add reload action stats to hold the history per reload action type and >limit level. Empty line missing. >For example, the number of times fw_activate has been performed on this >device since the driver module was added or if the f

Re: [PATCH net-next RFC v4 04/15] devlink: Add reload actions stats to dev get

2020-09-14 Thread Jiri Pirko
Mon, Sep 14, 2020 at 08:07:51AM CEST, mo...@mellanox.com wrote: >Expose devlink reload actions stats to the user through devlink dev >get command. > >Examples: >$ devlink dev show >pci/:82:00.0: > reload_action_stats: >driver_reinit 2 >fw_activate 1 >driver_reinit_no_reset 0 >f

[PATCH net-next] hinic: add vxlan segmentation and cs offload support

2020-09-14 Thread Luo bin
Add NETIF_F_GSO_UDP_TUNNEL and NETIF_F_GSO_UDP_TUNNEL_CSUM features to support vxlan segmentation and checksum offload. Ipip and ipv6 tunnel packets are regarded as non-tunnel pkt for hw and as for other type of tunnel pkts, checksum offload is disabled. Signed-off-by: Luo bin --- .../net/ethern

Re: [PATCH net-next RFC v4 10/15] net/mlx5: Add support for devlink reload action fw activate

2020-09-14 Thread Jiri Pirko
Mon, Sep 14, 2020 at 08:07:57AM CEST, mo...@mellanox.com wrote: >Add support for devlink reload action fw_activate. To activate firmware >image the mlx5 driver resets the firmware and reloads it from flash. If >a new image was stored on flash it will be loaded. Once this reload >command is executed

Re: [PATCH net-next RFC v4 10/15] net/mlx5: Add support for devlink reload action fw activate

2020-09-14 Thread Jiri Pirko
Mon, Sep 14, 2020 at 08:07:57AM CEST, mo...@mellanox.com wrote: [..] >+static void mlx5_fw_reset_complete_reload(struct mlx5_core_dev *dev) >+{ >+ struct mlx5_fw_reset *fw_reset = dev->priv.fw_reset; >+ >+ /* if this is the driver that initiated the fw reset, devlink completed >the rel

Re: [PATCH] arm64: bpf: Fix branch offset in JIT

2020-09-14 Thread Will Deacon
Hi Ilias, On Mon, Sep 14, 2020 at 04:23:50PM +0300, Ilias Apalodimas wrote: > On Mon, Sep 14, 2020 at 03:35:04PM +0300, Ilias Apalodimas wrote: > > On Mon, Sep 14, 2020 at 01:20:43PM +0100, Will Deacon wrote: > > > On Mon, Sep 14, 2020 at 11:36:21AM +0300, Ilias Apalodimas wrote: > > > > Running t

Re: [PATCH bpf-next] bpf: don't check against device MTU in __bpf_skb_max_len

2020-09-14 Thread Jesper Dangaard Brouer
Hi Maze, Thanks for getting back to me, I appreciate that a lot. More inline below: On Thu, 10 Sep 2020 13:00:12 -0700 Maciej Żenczykowski wrote: > All recent Android R common kernels are currently carrying the > following divergence from upstream: > > https://android.googlesource.com/kernel

RE: [PATCH 12/15] habanalabs/gaudi: add debugfs entries for the NIC

2020-09-14 Thread Omer Shpigelman
On Thu, Sep 10, 2020 at 11:31 PM Jakub Kicinski wrote: > On Thu, 10 Sep 2020 23:17:59 +0300 Oded Gabbay wrote: > > > Doesn't seem like this one shows any more information than can be > > > queried with ethtool, right? > > correct, it just displays it in a format that is much more readable > > You

Re: [PATCH net-next RFC v4 11/15] devlink: Add enable_remote_dev_reset generic parameter

2020-09-14 Thread Jiri Pirko
Mon, Sep 14, 2020 at 08:07:58AM CEST, mo...@mellanox.com wrote: >The enable_remote_dev_reset devlink param flags that the host admin >allows device resets that can be initiated by other hosts. This >parameter is useful for setups where a device is shared by different >hosts, such as multi-host setu

  1   2   3   4   5   >