RE: [PATCH net 2/2] vhost_net: fix high cpu load when sendmsg fails

2020-12-15 Thread wangyunjian
> -Original Message- > From: Jason Wang [mailto:jasow...@redhat.com] > Sent: Tuesday, December 15, 2020 12:10 PM > To: wangyunjian ; netdev@vger.kernel.org; > m...@redhat.com; willemdebruijn.ker...@gmail.com > Cc: virtualizat...@lists.linux-foundation.org; Lilijun (Jerry) > ; chenchanghu

Re: [RFC] net: stmmac: Problem with adding the native GPIOs support

2020-12-15 Thread Serge Semin
Hello Alexandre, Thanks for the response. My comments are below. On Mon, Dec 14, 2020 at 11:52:14AM +0100, Alexandre Torgue wrote: > Hi Serge, > > Sorry I never used GPIO provided by DWMAC IP. Obviously, I think is to late > for you to use GPIOs provided by your SoC directly. Unfortunately, it

Re: [RFC] net: stmmac: Problem with adding the native GPIOs support

2020-12-15 Thread Serge Semin
Hello Andrew, On Mon, Dec 14, 2020 at 04:31:43PM +0100, Andrew Lunn wrote: > On Mon, Dec 14, 2020 at 12:25:16PM +0300, Serge Semin wrote: > > Hello folks, > > > > I've got a problem, which has been blowing by head up for more than three > > weeks now, and I'm desperately need your help in that ma

[PATCH net-next] ibmvnic: merge do_change_param_reset into do_reset

2020-12-15 Thread Lijun Pan
Commit b27507bb59ed ("net/ibmvnic: unlock rtnl_lock in reset so linkwatch_event can run") introduced do_change_param_reset function to solve the rtnl lock issue. Majority of the code in do_change_param_reset duplicates do_reset. Also, we can handle the rtnl lock issue in do_reset itself. Hence merg

[PATCH] net: phy: fix kernel-doc for .config_intr()

2020-12-15 Thread Ioana Ciornei
From: Ioana Ciornei Fix the kernel-doc for .config_intr() so that we do not trigger a warning like below. include/linux/phy.h:869: warning: Function parameter or member 'config_intr' not described in 'phy_driver' Fixes: 6527b938426f ("net: phy: remove the .did_interrupt() and .ack_interrupt()

Re: [PATCH] net: phy: fix kernel-doc for .config_intr()

2020-12-15 Thread Ioana Ciornei
On Tue, Dec 15, 2020 at 10:37:51AM +0200, Ioana Ciornei wrote: > From: Ioana Ciornei > > Fix the kernel-doc for .config_intr() so that we do not trigger a > warning like below. > > include/linux/phy.h:869: warning: Function parameter or member 'config_intr' > not described in 'phy_driver' > >

Re: [PATCH 04/25] dt-bindings: net: dwmac: Refactor snps,*-config properties

2020-12-15 Thread Serge Semin
Hello Rob, On Mon, Dec 14, 2020 at 08:30:06AM -0600, Rob Herring wrote: > On Mon, Dec 14, 2020 at 12:15:54PM +0300, Serge Semin wrote: > > Currently the "snps,axi-config", "snps,mtl-rx-config" and > > "snps,mtl-tx-config" properties are declared as a single phandle reference > > to a node with cor

Re: [PATCH] net: allwinner: Fix some resources leak in the error handling path of the probe and in the remove function

2020-12-15 Thread Maxime Ripard
Hi, On Mon, Dec 14, 2020 at 09:21:17PM +0100, Christophe JAILLET wrote: > 'irq_of_parse_and_map()' should be balanced by a corresponding > 'irq_dispose_mapping()' call. Otherwise, there is some resources leaks. Do you have a source to back that? It's not clear at all from the documentation for th

[net-next v5 00/15] Add mlx5 subfunction support

2020-12-15 Thread Saeed Mahameed
From: Saeed Mahameed Hi Dave, Jakub, Jason, This series form Parav was the theme of this mlx5 release cycle, we've been waiting anxiously for the auxbus infrastructure to make it into the kernel, and now as the auxbus is in and all the stars are aligned, I can finally submit this V2 of the devli

[net-next v5 03/15] devlink: Introduce PCI SF port flavour and port attribute

2020-12-15 Thread Saeed Mahameed
From: Parav Pandit A PCI sub-function (SF) represents a portion of the device similar to PCI VF. In an eswitch, PCI SF may have port which is normally represented using a representor netdevice. To have better visibility of eswitch port, its association with SF, and its representor netdevice, int

[net-next v5 01/15] net/mlx5: Fix compilation warning for 32-bit platform

2020-12-15 Thread Saeed Mahameed
From: Parav Pandit MLX5_GENERAL_OBJECT_TYPES types bitfield is 64-bit field. Defining an enum for such bit fields on 32-bit platform results in below warning. ./include/vdso/bits.h:7:26: warning: left shift count >= width of type [-Wshift-count-overflow] ^ ./include/li

[net-next v5 07/15] net/mlx5: SF, Add auxiliary device support

2020-12-15 Thread Saeed Mahameed
From: Parav Pandit Introduce API to add and delete an auxiliary device for an SF. Each SF has its own dedicated window in the PCI BAR 2. SF device is similar to PCI PF and VF that supports multiple class of devices such as net, rdma and vdpa. SF device will be added or removed in subsequent pat

[net-next v5 06/15] net/mlx5: Introduce vhca state event notifier

2020-12-15 Thread Saeed Mahameed
From: Parav Pandit vhca state events indicates change in the state of the vhca that may occur due to a SF allocation, deallocation or enabling/disabling the SF HCA. Introduce vhca state event handler which will be used by SF devlink port manager and SF hardware id allocator in subsequent patches

[net-next v5 15/15] net/mlx5: Add devlink subfunction port documentation

2020-12-15 Thread Saeed Mahameed
From: Parav Pandit Add documentation for subfunction management using devlink port. Signed-off-by: Parav Pandit Signed-off-by: Saeed Mahameed --- .../device_drivers/ethernet/mellanox/mlx5.rst | 204 ++ 1 file changed, 204 insertions(+) diff --git a/Documentation/networking/de

[net-next v5 11/15] net/mlx5: SF, Add port add delete functionality

2020-12-15 Thread Saeed Mahameed
From: Parav Pandit To handle SF port management outside of the eswitch as independent software layer, introduce eswitch notifier APIs so that upper layer who wish to support sf port management in switchdev mode can perform its task whenever eswitch mode is set to switchdev or before eswitch is di

[net-next v5 12/15] net/mlx5: SF, Port function state change support

2020-12-15 Thread Saeed Mahameed
From: Parav Pandit Support changing the state of the SF port's function through devlink. When activating the SF port's function, enable the hca in the device followed by adding its auxiliary device. When deactivating the SF port's function, delete its auxiliary device followed by disabling the vH

[net-next v5 14/15] devlink: Extend devlink port documentation for subfunctions

2020-12-15 Thread Saeed Mahameed
From: Parav Pandit Add devlink port documentation for subfunction management. Signed-off-by: Parav Pandit Signed-off-by: Saeed Mahameed --- Documentation/driver-api/auxiliary_bus.rst| 2 + .../networking/devlink/devlink-port.rst | 89 ++- 2 files changed, 87 inserti

[net-next v5 13/15] devlink: Add devlink port documentation

2020-12-15 Thread Saeed Mahameed
From: Parav Pandit Added documentation for devlink port and port function related commands. Signed-off-by: Parav Pandit Reviewed-by: Jiri Pirko Reviewed-by: Jacob Keller Signed-off-by: Saeed Mahameed --- .../networking/devlink/devlink-port.rst | 118 ++ Documentation/n

[net-next v5 10/15] net/mlx5: E-switch, Add eswitch helpers for SF vport

2020-12-15 Thread Saeed Mahameed
From: Parav Pandit Add helpers to enable/disable eswitch port, register its devlink port and load its representor. Signed-off-by: Vu Pham Signed-off-by: Parav Pandit Reviewed-by: Roi Dayan Signed-off-by: Saeed Mahameed --- .../mellanox/mlx5/core/esw/devlink_port.c | 41 +

[net-next v5 09/15] net/mlx5: E-switch, Prepare eswitch to handle SF vport

2020-12-15 Thread Saeed Mahameed
From: Vu Pham Prepare eswitch to handle SF vport during (a) querying eswitch functions (b) egress ACL creation (c) account for SF vports in total vports calculation Assign a dedicated placeholder for SFs vports and their representors. They are placed after VFs vports and before ECPF vports as be

[net-next v5 05/15] devlink: Support get and set state of port function

2020-12-15 Thread Saeed Mahameed
From: Parav Pandit devlink port function can be in active or inactive state. Allow users to get and set port function's state. When the port function it activated, its operational state may change after a while when the device is created and driver binds to it. Similarly on deactivation flow. T

[net-next v5 08/15] net/mlx5: SF, Add auxiliary device driver

2020-12-15 Thread Saeed Mahameed
From: Parav Pandit Add auxiliary device driver for mlx5 subfunction auxiliary device. A mlx5 subfunction is similar to PCI PF and VF. For a subfunction an auxiliary device is created. As a result, when mlx5 SF auxiliary device binds to the driver, its netdev and rdma device are created, they ap

[PATCH net] ethtool: fix error paths in ethnl_set_channels()

2020-12-15 Thread Ivan Vecera
Fix two error paths in ethnl_set_channels() to avoid lock-up caused but unreleased RTNL. Fixes: e19c591eafad ("ethtool: set device channel counts with CHANNELS_SET request") Cc: Michal Kubecek Reported-by: LiLiang Signed-off-by: Ivan Vecera --- net/ethtool/channels.c | 6 -- 1 file change

[net-next v5 04/15] devlink: Support add and delete devlink port

2020-12-15 Thread Saeed Mahameed
From: Parav Pandit Extended devlink interface for the user to add and delete port. Extend devlink to connect user requests to driver to add/delete such port in the device. When driver routines are invoked, devlink instance lock is not held. This enables driver to perform several devlink objects

[net-next v5 02/15] devlink: Prepare code to fill multiple port function attributes

2020-12-15 Thread Saeed Mahameed
From: Parav Pandit Prepare code to fill zero or more port function optional attributes. Subsequent patch makes use of this to fill more port function attributes. Signed-off-by: Parav Pandit Reviewed-by: Jiri Pirko Reviewed-by: Vu Pham Signed-off-by: Saeed Mahameed --- net/core/devlink.c | 6

[PATCH net-next 1/1] net/smc: fix access to parent of an ib device

2020-12-15 Thread Karsten Graul
The parent of an ib device is used to retrieve the PCI device attributes. It turns out that there are possible cases when an ib device has no parent set in the device structure, which may lead to page faults when trying to access this memory. Fix that by checking the parent pointer and consolidate

Re: [PATCH v2 net-next 2/2] nfc: s3fwrn5: Remove unused NCI prop commands

2020-12-15 Thread Krzysztof Kozlowski
On Tue, Dec 15, 2020 at 03:54:01PM +0900, Bongsu Jeon wrote: > From: Bongsu Jeon > > Remove the unused NCI prop commands that s3fwrn5 driver doesn't use. > > Signed-off-by: Bongsu Jeon > --- > drivers/nfc/s3fwrn5/nci.c | 25 - > drivers/nfc/s3fwrn5/nci.h | 22 --

[PATCH net-next 0/1] net/smc: fix access to parent of an ib device

2020-12-15 Thread Karsten Graul
Please apply the following patch for smc to netdev's net-next tree. The patch fixes an access to the parent of an ib device which might be NULL. I am sending this fix to net-next because the fixed code is still in this tree only. Karsten Graul (1): net/smc: fix access to parent of an ib device

Re: [PATCH] net: allwinner: Fix some resources leak in the error handling path of the probe and in the remove function

2020-12-15 Thread Dan Carpenter
On Tue, Dec 15, 2020 at 09:56:55AM +0100, Maxime Ripard wrote: > Hi, > > On Mon, Dec 14, 2020 at 09:21:17PM +0100, Christophe JAILLET wrote: > > 'irq_of_parse_and_map()' should be balanced by a corresponding > > 'irq_dispose_mapping()' call. Otherwise, there is some resources leaks. > > Do you ha

Re: [PATCH v2 net-next 1/2] nfc: s3fwrn5: Remove the delay for NFC sleep

2020-12-15 Thread Krzysztof Kozlowski
On Tue, Dec 15, 2020 at 03:54:00PM +0900, Bongsu Jeon wrote: > From: Bongsu Jeon > > Remove the delay for NFC sleep because the delay is only needed to > guarantee that the NFC is awake. > > Signed-off-by: Bongsu Jeon > --- > drivers/nfc/s3fwrn5/phy_common.c | 3 ++- > 1 file changed, 2 insert

Re: [PATCH net-next] sfc: reduce the number of requested xdp ev queues

2020-12-15 Thread Jesper Dangaard Brouer
On Mon, 14 Dec 2020 17:29:06 -0800 Ivan Babrou wrote: > Without this change the driver tries to allocate too many queues, > breaching the number of available msi-x interrupts on machines > with many logical cpus and default adapter settings: > > Insufficient resources for 12 XDP event queues (24

general protection fault in taprio_dequeue_soft

2020-12-15 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:7f376f19 Merge tag 'mtd/fixes-for-5.10-rc8' of git://git.k.. git tree: net console output: https://syzkaller.appspot.com/x/log.txt?x=1384228750 kernel config: https://syzkaller.appspot.com/x/.config?x=3416bb960d5c705d dashboar

[MPTCP][PATCH net-next] mptcp: clear use_ack and use_map when dropping other suboptions

2020-12-15 Thread Geliang Tang
This patch cleared use_ack and use_map when dropping other suboptions to fix the following syzkaller BUG: [ 15.223006] BUG: unable to handle page fault for address: 00223b10 [ 15.223700] #PF: supervisor read access in kernel mode [ 15.224209] #PF: error_code(0x) - not-present pag

Re: [PATCH net] ethtool: fix error paths in ethnl_set_channels()

2020-12-15 Thread Michal Kubecek
On Tue, Dec 15, 2020 at 10:08:10AM +0100, Ivan Vecera wrote: > Fix two error paths in ethnl_set_channels() to avoid lock-up caused > but unreleased RTNL. > > Fixes: e19c591eafad ("ethtool: set device channel counts with CHANNELS_SET > request") > Cc: Michal Kubecek > Reported-by: LiLiang > Sign

Re: [PATCH net] nfp: do not send control messages during cleanup

2020-12-15 Thread Simon Horman
On Mon, Dec 14, 2020 at 06:26:50PM -0800, Jakub Kicinski wrote: > On Fri, 11 Dec 2020 10:27:38 +0100 Simon Horman wrote: > > On cleanup the txbufs are freed before app cleanup. But app clean-up may > > result in control messages due to use of common control paths. There is no > > need to clean-up t

WARNING: suspicious RCU usage in nf_ct_iterate_cleanup

2020-12-15 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:33dc9614 Merge tag 'ktest-v5.10-rc6' of git://git.kernel.o.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=1200a46b50 kernel config: https://syzkaller.appspot.com/x/.config?x=5ed9af1b47477866 das

[PATCH net-next] devlink: use _BITUL() macro instead of BIT() in the UAPI header

2020-12-15 Thread Tobias Klauser
The BIT() macro is not available for the UAPI headers. Moreover, it can be defined differently in user space headers. Thus, replace its usage with the _BITUL() macro which is already used in other macro definitions in . Fixes: dc64cc7c6310 ("devlink: Add devlink reload limit option") Signed-off-by

Re: [PATCH] net: allwinner: Fix some resources leak in the error handling path of the probe and in the remove function

2020-12-15 Thread Maxime Ripard
On Tue, Dec 15, 2020 at 12:11:53PM +0300, Dan Carpenter wrote: > On Tue, Dec 15, 2020 at 09:56:55AM +0100, Maxime Ripard wrote: > > Hi, > > > > On Mon, Dec 14, 2020 at 09:21:17PM +0100, Christophe JAILLET wrote: > > > 'irq_of_parse_and_map()' should be balanced by a corresponding > > > 'irq_dispos

Re: [PATCH v2 3/3] net: mhi: Add dedicated alloc thread

2020-12-15 Thread Loic Poulain
Hi Jakub, On Mon, 14 Dec 2020 at 20:47, Jakub Kicinski wrote: > > On Mon, 14 Dec 2020 10:19:07 +0100 Loic Poulain wrote: > > On Sat, 12 Dec 2020 at 21:55, Jakub Kicinski wrote: > > > On Thu, 10 Dec 2020 12:15:51 +0100 Loic Poulain wrote: > > > > The buffer allocation for RX path is currently don

Re: [PATCH v4 0/4] Improve s0ix flows for systems i219LM

2020-12-15 Thread Hans de Goede
Hi, On 12/14/20 8:36 PM, Limonciello, Mario wrote: >> Hi All, >> >> Sasha (and the other intel-wired-lan folks), thank you for investigating this >> further and for coming up with a better solution. >> >> Mario, thank you for implementing the new scheme. >> > > Sure. > >> I've tested this patch

Re: [PATCH v2] net/mlx4: Use true,false for bool variable

2020-12-15 Thread Vasyl
Hi, Ouuu it was fixed recently in net-next. Sorry, I missed that. Thanks for submitting policy clarification I am going to adapt to it. Thanks On Tue, Dec 15, 2020 at 7:18 AM Leon Romanovsky wrote: > > On Mon, Dec 14, 2020 at 09:37:34PM -0800, Joe Perches wrote: > > On Tue, 2020-12-15 at 07:18

Re: [PATCH v3 bpf-next 2/2] net: xdp: introduce xdp_prepare_buff utility routine

2020-12-15 Thread Maciej Fijalkowski
On Sat, Dec 12, 2020 at 06:41:49PM +0100, Lorenzo Bianconi wrote: > Introduce xdp_prepare_buff utility routine to initialize per-descriptor > xdp_buff fields (e.g. xdp_buff pointers). Rely on xdp_prepare_buff() in > all XDP capable drivers. > > Signed-off-by: Lorenzo Bianconi > --- > drivers/net

Re: [PATCH v5 4/4] e1000e: Export S0ix flags to ethtool

2020-12-15 Thread Hans de Goede
Hi, On 12/14/20 8:29 PM, Mario Limonciello wrote: > This flag can be used by an end user to disable S0ix flows on a > buggy system or by an OEM for development purposes. > > If you need this flag to be persisted across reboots, it's suggested > to use a udev rule to call adjust it until the kerne

Re: [PATCH v5 0/4] Improve s0ix flows for systems i219LM

2020-12-15 Thread Hans de Goede
Hi, On 12/14/20 8:29 PM, Mario Limonciello wrote: > commit e086ba2fccda ("e1000e: disable s0ix entry and exit flows for ME > systems") > disabled s0ix flows for systems that have various incarnations of the > i219-LM ethernet controller. This was done because of some regressions > caused by an e

Re: [PATCH v5 2/4] e1000e: bump up timeout to wait when ME un-configures ULP mode

2020-12-15 Thread Hans de Goede
Hi, On 12/14/20 8:29 PM, Mario Limonciello wrote: > Per guidance from Intel ethernet architecture team, it may take > up to 1 second for unconfiguring ULP mode. > > However in practice this seems to be taking up to 2 seconds on > some Lenovo machines. Detect scenarios that take more than 1 secon

Re: [PATCH v5 3/4] Revert "e1000e: disable s0ix entry and exit flows for ME systems"

2020-12-15 Thread Hans de Goede
Hi, On 12/14/20 8:29 PM, Mario Limonciello wrote: > commit e086ba2fccda ("e1000e: disable s0ix entry and exit flows for ME > systems") > disabled s0ix flows for systems that have various incarnations of the > i219-LM ethernet controller. This changed caused power consumption > regressions > on

Re: [PATCH 1/3] PCI/ASPM: Use the path max in L1 ASPM latency check

2020-12-15 Thread Ian Kumlien
On Tue, Dec 15, 2020 at 1:40 AM Bjorn Helgaas wrote: > > On Mon, Dec 14, 2020 at 11:56:31PM +0100, Ian Kumlien wrote: > > On Mon, Dec 14, 2020 at 8:19 PM Bjorn Helgaas wrote: > > > > If you're interested, you could probably unload the Realtek drivers, > > > remove the devices, and set the PCI_EXP

Re: Fw: [External] Re: [PATCH v4 0/4] Improve s0ix flows for systems i219LM

2020-12-15 Thread Neftin, Sasha
On 12/14/2020 20:40, Mark Pearson wrote: Thanks Hans On 14/12/2020 13:31, Mark Pearson wrote: *From:* Hans de Goede *Sent:* December 14, 2020 13:24 *To:* Mario Limonciello ; Jeff Kirsher ; Tony Nguyen ; intel-wired-...@

Re: [PATCH v5 bpf-next 13/14] bpf: add new frame_length field to the XDP ctx

2020-12-15 Thread Eelco Chaudron
On 9 Dec 2020, at 13:07, Eelco Chaudron wrote: On 9 Dec 2020, at 12:10, Maciej Fijalkowski wrote: + + ctx_reg = (si->src_reg == si->dst_reg) ? scratch_reg - 1 : si->src_reg; + while (dst_reg == ctx_reg || scratch_reg == ctx_reg) + ctx_reg

Re: [PATCH net-next] net: Limit logical shift left of TCP probe0 timeout

2020-12-15 Thread Cambda Zhu
> On Dec 15, 2020, at 19:06, Eric Dumazet wrote: > > On Tue, Dec 15, 2020 at 3:08 AM Jakub Kicinski wrote: >> >> On Sun, 13 Dec 2020 21:59:45 +0800 Cambda Zhu wrote: On Dec 13, 2020, at 06:32, Jakub Kicinski wrote: On Tue, 8 Dec 2020 17:19:10 +0800 Cambda Zhu wrote: > For each

Re: [PATCH v1 net-next 05/15] nvme-tcp: Add DDP offload control path

2020-12-15 Thread Shai Malin
On 12/14/2020 08:38, Boris Pismenny wrote: > On 10/12/2020 19:15, Shai Malin wrote: > > diff --git a/drivers/nvme/host/tcp.c b/drivers/nvme/host/tcp.c index > > c0c33320fe65..ef96e4a02bbd 100644 > > --- a/drivers/nvme/host/tcp.c > > +++ b/drivers/nvme/host/tcp.c > > @@ -14,6 +14,7 @@ > > #include

[PATCH net 2/2] net: mvpp2: disable force link UP during port init procedure

2020-12-15 Thread stefanc
From: Stefan Chulski Force link UP can be enabled by bootloader during tftpboot and breaks NFS support. Force link UP disabled during port init procedure. Signed-off-by: Stefan Chulski --- drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 14 +- 1 file changed, 13 insertions(+), 1

[PATCH net 1/2] net: mvpp2: Fix GoP port 3 Networking Complex Control configurations

2020-12-15 Thread stefanc
From: Stefan Chulski During GoP port 2 Networking Complex Control mode of operation configurations, also GoP port 3 mode of operation was wrongly set mode. Patch removes these configurations. GENCONF_CTRL0_PORTX naming also fixed. Signed-off-by: Stefan Chulski --- drivers/net/ethernet/marvell/

Re: [PATCH RFC v2 1/5] dt-bindings: net: dwmac-meson: use picoseconds for the RGMII RX delay

2020-12-15 Thread Rob Herring
On Sun, Dec 13, 2020 at 05:59:05PM +0100, Martin Blumenstingl wrote: > Hi Rob, > > On Mon, Dec 7, 2020 at 8:17 PM Rob Herring wrote: > > > > On Sun, Nov 15, 2020 at 07:52:06PM +0100, Martin Blumenstingl wrote: > > > Amlogic Meson G12A, G12B and SM1 SoCs have a more advanced RGMII RX > > > delay r

Re: [PATCH v3 bpf-next 2/2] net: xdp: introduce xdp_prepare_buff utility routine

2020-12-15 Thread Lorenzo Bianconi
[...] > > xdp_act = bpf_prog_run_xdp(xdp_prog, &xdp); > > diff --git a/drivers/net/ethernet/intel/i40e/i40e_txrx.c > > b/drivers/net/ethernet/intel/i40e/i40e_txrx.c > > index 4dbbbd49c389..fcd1ca3343fb 100644 > > --- a/drivers/net/ethernet/intel/i40e/i40e_txrx.c > > +++ b/drivers/net/ethernet/

Re: [RFC] net: stmmac: Problem with adding the native GPIOs support

2020-12-15 Thread Andrew Lunn
> > > Anyway the hardware setup depicted above doesn't seem > > > problematic at the first glance, but in fact it is. See, the DW *MAC > > > driver > > > (STMMAC ethernet driver) is doing the MAC reset each time it performs the > > > device open or resume by means of the call-chain: > > > > > >

RE: [PATCH v1 net-next 07/15] nvme-tcp : Recalculate crc in the end of the capsule

2020-12-15 Thread Shai Malin
> crc offload of the nvme capsule. Check if all the skb bits are on, and if not > recalculate the crc in SW and check it. > > This patch reworks the receive-side crc calculation to always run at the end, > so as to keep a single flow for both offload and non-offload. This change > simplifies the

Re: [PATCH 04/25] dt-bindings: net: dwmac: Refactor snps,*-config properties

2020-12-15 Thread Rob Herring
On Tue, Dec 15, 2020 at 2:54 AM Serge Semin wrote: > > Hello Rob, > > On Mon, Dec 14, 2020 at 08:30:06AM -0600, Rob Herring wrote: > > On Mon, Dec 14, 2020 at 12:15:54PM +0300, Serge Semin wrote: > > > Currently the "snps,axi-config", "snps,mtl-rx-config" and > > > "snps,mtl-tx-config" properties

[PATCH] atm: ambassador: remove h from printk format specifier

2020-12-15 Thread trix
From: Tom Rix See Documentation/core-api/printk-formats.rst. h should no longer be used in the format specifier for printk. Signed-off-by: Tom Rix --- drivers/atm/ambassador.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/atm/ambassador.c b/drivers/atm/ambassa

[PATCH] atm: horizon: remove h from printk format specifier

2020-12-15 Thread trix
From: Tom Rix See Documentation/core-api/printk-formats.rst. h should no longer be used in the format specifier for printk. Signed-off-by: Tom Rix --- drivers/atm/horizon.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/atm/horizon.c b/drivers/atm/horizon.c i

Re: [RFC PATCH net-next 01/16] net: mscc: ocelot: offload bridge port flags to device

2020-12-15 Thread Alexandre Belloni
On 08/12/2020 14:07:47+0200, Vladimir Oltean wrote: > We should not be unconditionally enabling address learning, since doing > that is actively detrimential when a port is standalone and not offloading > a bridge. Namely, if a port in the switch is standalone and others are > offloading the bridge

Re: [PATCH][next] netfilter: nftables: fix incorrect increment of loop counter

2020-12-15 Thread Pablo Neira Ayuso
Hi, On Mon, Dec 14, 2020 at 11:40:15PM +, Colin King wrote: > From: Colin Ian King > > The intention of the err_expr cleanup path is to iterate over the > allocated expr_array objects and free them, starting from i - 1 and > working down to the start of the array. Currently the loop counter

Re: [RFC PATCH net-next 02/16] net: mscc: ocelot: allow offloading of bridge on top of LAG

2020-12-15 Thread Alexandre Belloni
On 08/12/2020 14:07:48+0200, Vladimir Oltean wrote: > Commit 7afb3e575e5a ("net: mscc: ocelot: don't handle netdev events for > other netdevs") was too aggressive, and it made ocelot_netdevice_event > react only to network interface events emitted for the ocelot switch > ports. > > In fact, only t

[PATCH] net/mlx5: fix spelling mistake in Kconfig "accelaration" -> "acceleration"

2020-12-15 Thread Colin King
From: Colin Ian King There are some spelling mistakes in the Kconfig. Fix these. Signed-off-by: Colin Ian King --- drivers/net/ethernet/mellanox/mlx5/core/Kconfig | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/Kconfig b/driver

Re: [PATCH v3 bpf-next 2/2] net: xdp: introduce xdp_prepare_buff utility routine

2020-12-15 Thread Daniel Borkmann
On 12/15/20 2:47 PM, Lorenzo Bianconi wrote: [...] diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c index 329397c60d84..61d3f5f8b7f3 100644 --- a/drivers/net/xen-netfront.c +++ b/drivers/net/xen-netfront.c @@ -866,10 +866,8 @@ static u32 xennet_run_xdp(struct netfront_queue *q

RE: [PATCH v5 4/4] e1000e: Export S0ix flags to ethtool

2020-12-15 Thread Shen, Yijun
> -Original Message- > From: Limonciello, Mario > Sent: Tuesday, December 15, 2020 3:30 AM > To: Jeff Kirsher; Tony Nguyen; intel-wired-...@lists.osuosl.org > Cc: linux-ker...@vger.kernel.org; Netdev; Alexander Duyck; Jakub Kicinski; > Sasha Netfin; Aaron Brown; Stefan Assmann; David Mille

Re: [RFC] net: stmmac: Problem with adding the native GPIOs support

2020-12-15 Thread Serge Semin
On Tue, Dec 15, 2020 at 02:58:37PM +0100, Andrew Lunn wrote: > > > > Anyway the hardware setup depicted above doesn't seem > > > > problematic at the first glance, but in fact it is. See, the DW *MAC > > > > driver > > > > (STMMAC ethernet driver) is doing the MAC reset each time it performs > >

RE: [PATCH v5 3/4] Revert "e1000e: disable s0ix entry and exit flows for ME systems"

2020-12-15 Thread Shen, Yijun
> -Original Message- > From: Limonciello, Mario > Sent: Tuesday, December 15, 2020 3:30 AM > To: Jeff Kirsher; Tony Nguyen; intel-wired-...@lists.osuosl.org > Cc: linux-ker...@vger.kernel.org; Netdev; Alexander Duyck; Jakub Kicinski; > Sasha Netfin; Aaron Brown; Stefan Assmann; David Mille

RE: [PATCH v5 2/4] e1000e: bump up timeout to wait when ME un-configures ULP mode

2020-12-15 Thread Shen, Yijun
> -Original Message- > From: Limonciello, Mario > Sent: Tuesday, December 15, 2020 3:30 AM > To: Jeff Kirsher; Tony Nguyen; intel-wired-...@lists.osuosl.org > Cc: linux-ker...@vger.kernel.org; Netdev; Alexander Duyck; Jakub Kicinski; > Sasha Netfin; Aaron Brown; Stefan Assmann; David Mille

RE: [PATCH v5 1/4] e1000e: Only run S0ix flows if shutdown succeeded

2020-12-15 Thread Shen, Yijun
> -Original Message- > From: Limonciello, Mario > Sent: Tuesday, December 15, 2020 3:30 AM > To: Jeff Kirsher; Tony Nguyen; intel-wired-...@lists.osuosl.org > Cc: linux-ker...@vger.kernel.org; Netdev; Alexander Duyck; Jakub Kicinski; > Sasha Netfin; Aaron Brown; Stefan Assmann; David Mille

Re: [RFC PATCH net-next 03/16] net: mscc: ocelot: rename ocelot_netdevice_port_event to ocelot_netdevice_changeupper

2020-12-15 Thread Alexandre Belloni
Hi, On 08/12/2020 14:07:49+0200, Vladimir Oltean wrote: > -static int ocelot_netdevice_port_event(struct net_device *dev, > -unsigned long event, > -struct netdev_notifier_changeupper_info > *info) > +static int ocelot_netdev

Re: [stabe-rc 5.9 ] sched: core.c:7270 Illegal context switch in RCU-bh read-side critical section!

2020-12-15 Thread Paul E. McKenney
On Tue, Dec 15, 2020 at 07:50:31AM +0530, Naresh Kamboju wrote: > There are two warnings "WARNING: suspicious RCU usage" noticed on arm64 > juno-r2 > device while running selftest bpf test_tc_edt.sh and net: udpgro_bench.sh. > These warnings are occurring intermittently. > > metadata: > git bra

UBSAN: shift-out-of-bounds in xprt_calc_majortimeo

2020-12-15 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:14240d4c Add linux-next specific files for 20201210 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=1321cf1750 kernel config: https://syzkaller.appspot.com/x/.config?x=6dbe20fdaa5aaebe dashboard

Re: [PATCH v3 bpf-next 2/2] net: xdp: introduce xdp_prepare_buff utility routine

2020-12-15 Thread Lorenzo Bianconi
> On 12/15/20 2:47 PM, Lorenzo Bianconi wrote: > [...] > > > > diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c > > > > index 329397c60d84..61d3f5f8b7f3 100644 > > > > --- a/drivers/net/xen-netfront.c > > > > +++ b/drivers/net/xen-netfront.c > > > > @@ -866,10 +866,8 @@ static u

Re: [RFC PATCH 0/7] Share events between metrics

2020-12-15 Thread Paul A. Clarke
On Thu, May 07, 2020 at 10:43:43PM -0700, Ian Rogers wrote: > On Thu, May 7, 2020 at 2:47 PM Andi Kleen wrote: > > > > > > - without this change events within a metric may get scheduled > > > > together, after they may appear as part of a larger group and be > > > > multiplexed at different ti

UBSAN: shift-out-of-bounds in hash_ipmark_create

2020-12-15 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:15ac8fdb Add linux-next specific files for 20201207 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=156c845b50 kernel config: https://syzkaller.appspot.com/x/.config?x=3696b8138207d24d dashboard

Re: [PATCH v3 bpf-next 2/2] net: xdp: introduce xdp_prepare_buff utility routine

2020-12-15 Thread Maciej Fijalkowski
On Tue, Dec 15, 2020 at 04:06:20PM +0100, Lorenzo Bianconi wrote: > > On 12/15/20 2:47 PM, Lorenzo Bianconi wrote: > > [...] > > > > > diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c > > > > > index 329397c60d84..61d3f5f8b7f3 100644 > > > > > --- a/drivers/net/xen-netfront.c >

Re: [RFC PATCH net-next 03/16] net: mscc: ocelot: rename ocelot_netdevice_port_event to ocelot_netdevice_changeupper

2020-12-15 Thread Vladimir Oltean
On Tue, Dec 15, 2020 at 04:01:32PM +0100, Alexandre Belloni wrote: > Hi, > > On 08/12/2020 14:07:49+0200, Vladimir Oltean wrote: > > -static int ocelot_netdevice_port_event(struct net_device *dev, > > - unsigned long event, > > - st

Re: [PATCH net v3] lan743x: fix rx_napi_poll/interrupt ping-pong

2020-12-15 Thread Sven Van Asbroeck
Hi Jakub, On Fri, Dec 11, 2020 at 9:38 AM Sven Van Asbroeck wrote: > > From: Sven Van Asbroeck > > Even if there is more rx data waiting on the chip, the rx napi poll fn > will never run more than once - it will always read a few buffers, then > bail out and re-arm interrupts. Which results in p

Re: [RFC PATCH net-next 04/16] net: mscc: ocelot: use a switch-case statement in ocelot_netdevice_event

2020-12-15 Thread Alexandre Belloni
On 08/12/2020 14:07:50+0200, Vladimir Oltean wrote: > Make ocelot's net device event handler more streamlined by structuring > it in a similar way with others. The inspiration here was > dsa_slave_netdevice_event. > > Signed-off-by: Vladimir Oltean > --- > drivers/net/ethernet/mscc/ocelot_net.c

Re: [RFC PATCH net-next 05/16] net: mscc: ocelot: don't refuse bonding interfaces we can't offload

2020-12-15 Thread Alexandre Belloni
On 08/12/2020 14:07:51+0200, Vladimir Oltean wrote: > Since switchdev/DSA exposes network interfaces that fulfill many of the > same user space expectations that dedicated NICs do, it makes sense to > not deny bonding interfaces with a bonding policy that we cannot offload, > but instead allow the

Re: [RFC PATCH net-next 04/16] net: mscc: ocelot: use a switch-case statement in ocelot_netdevice_event

2020-12-15 Thread Alexandre Belloni
On 15/12/2020 16:52:26+0100, Alexandre Belloni wrote: > On 08/12/2020 14:07:50+0200, Vladimir Oltean wrote: > > Make ocelot's net device event handler more streamlined by structuring > > it in a similar way with others. The inspiration here was > > dsa_slave_netdevice_event. > > > > Signed-off-by:

Re: [RFC PATCH net-next 06/16] net: mscc: ocelot: use ipv6 in the aggregation code

2020-12-15 Thread Alexandre Belloni
On 08/12/2020 14:07:52+0200, Vladimir Oltean wrote: > IPv6 header information is not currently part of the entropy source for > the 4-bit aggregation code used for LAG offload, even though it could be. > The hardware reference manual says about these fields: > > ANA::AGGR_CFG.AC_IP6_TCPUDP_PORT_EN

[PATCH net-next] r8169: facilitate adding new chip versions

2020-12-15 Thread Heiner Kallweit
Add a constant RTL_GIGA_MAC_MAX and use it if all new chip versions handle a feature in a specific way. As result we have to touch less places when adding support for a new chip version. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169.h | 3 ++- drivers/net/ethernet/r

Re: [net-next v4 00/15] Add mlx5 subfunction support

2020-12-15 Thread Alexander Duyck
On Mon, Dec 14, 2020 at 6:44 PM David Ahern wrote: > > On 12/14/20 6:53 PM, Alexander Duyck wrote: > >> example subfunction usage sequence: > >> --- > >> Change device to switchdev mode: > >> $ devlink dev eswitch set pci/:06:00.0 mode switchdev > >> > >> Add a

[PATCH net v4] lan743x: fix rx_napi_poll/interrupt ping-pong

2020-12-15 Thread Sven Van Asbroeck
From: Sven Van Asbroeck Even if there is more rx data waiting on the chip, the rx napi poll fn will never run more than once - it will always read a few buffers, then bail out and re-arm interrupts. Which results in ping-pong between napi and interrupt. This defeats the purpose of napi, and is b

Re: [PATCH][next] netfilter: nftables: fix incorrect increment of loop counter

2020-12-15 Thread Pablo Neira Ayuso
On Tue, Dec 15, 2020 at 03:38:30PM +0100, Pablo Neira Ayuso wrote: > Hi, > > On Mon, Dec 14, 2020 at 11:40:15PM +, Colin King wrote: > > From: Colin Ian King > > > > The intention of the err_expr cleanup path is to iterate over the > > allocated expr_array objects and free them, starting fro

[PATCH] net: remove disc_data_lock in ppp line discipline

2020-12-15 Thread Gao Yan
tty layer provide tty->ldisc_sem lock to protect tty->disc_data; For examlpe, when cpu A is running ppp_synctty_ioctl that hold the tty->ldisc_sem, so if cpu B calls ppp_synctty_close, it will wait until cpu A release tty->ldisc_sem. So I think it is unnecessary to have the disc_data_lock; cpu A

Re: [PATCH v5 3/6] net: dsa: microchip: ksz8795: move register offsets and shifts to separate struct

2020-12-15 Thread Michael Grzeschik
Gentle Ping. Did you find time to look into my other patches of the series. I really would like to send the next version. Thanks! On Mon, Dec 07, 2020 at 10:44:15PM +0100, Michael Grzeschik wrote: On Mon, Dec 07, 2020 at 08:02:57PM +, tristram...@microchip.com wrote: In order to get this d

Re: [PATCH net-next v2 2/4] sch_htb: Hierarchical QoS hardware offload

2020-12-15 Thread Jamal Hadi Salim
On 2020-12-14 3:30 p.m., Maxim Mikityanskiy wrote: On 2020-12-14 21:35, Cong Wang wrote: On Mon, Dec 14, 2020 at 7:13 AM Maxim Mikityanskiy wrote: On 2020-12-11 21:16, Cong Wang wrote: On Fri, Dec 11, 2020 at 7:26 AM Maxim Mikityanskiy wrote: Interesting, please explain how your HTB

Re: [RFC PATCH net-next 07/16] net: mscc: ocelot: set up the bonding mask in a way that avoids a net_device

2020-12-15 Thread Alexandre Belloni
On 08/12/2020 14:07:53+0200, Vladimir Oltean wrote: > Since this code should be called from pure switchdev as well as from > DSA, we must find a way to determine the bonding mask not by looking > directly at the net_device lowers of the bonding interface, since those > could have different private

[net-next PATCH v2 00/14] ACPI support for dpaa2 driver

2020-12-15 Thread Calvin Johnson
This patch set provides ACPI support to DPAA2 network drivers. It also introduces new fwnode based APIs to support phylink and phy layers Following functions are defined: phylink_fwnode_phy_connect() fwnode_mdiobus_register_phy() fwnode_mdiobus_register() fwnode_get_p

[net-next PATCH v2 01/14] Documentation: ACPI: DSD: Document MDIO PHY

2020-12-15 Thread Calvin Johnson
Introduce ACPI mechanism to get PHYs registered on a MDIO bus and provide them to be connected to MAC. Describe properties "phy-handle" and "phy-mode". Signed-off-by: Calvin Johnson --- Changes in v2: - Updated with more description in document Documentation/firmware-guide/acpi/dsd/phy.rst |

[net-next PATCH v2 02/14] net: phy: Introduce phy related fwnode functions

2020-12-15 Thread Calvin Johnson
Define fwnode_phy_find_device() to iterate an mdiobus and find the phy device of the provided phy fwnode. Additionally define device_phy_find_device() to find phy device of provided device. Define fwnode_get_phy_node() to get phy_node using named reference. Signed-off-by: Calvin Johnson --- Cha

[net-next PATCH v2 10/14] device property: Introduce fwnode_get_id()

2020-12-15 Thread Calvin Johnson
Using fwnode_get_id(), get the reg property value for DT node and get the _ADR object value for ACPI node. Signed-off-by: Calvin Johnson --- Changes in v2: None drivers/base/property.c | 26 ++ include/linux/property.h | 1 + 2 files changed, 27 insertions(+) diff --

[net-next PATCH v2 08/14] net: mdiobus: Introduce fwnode_mdiobus_register()

2020-12-15 Thread Calvin Johnson
Introduce fwnode_mdiobus_register() to register PHYs on the mdiobus. If the fwnode is DT node, then call of_mdiobus_register(). If it is an ACPI node, then: - disable auto probing of mdiobus - register mdiobus - save fwnode to mdio structure - loop over child nodes

[net-next PATCH v2 11/14] phylink: introduce phylink_fwnode_phy_connect()

2020-12-15 Thread Calvin Johnson
Define phylink_fwnode_phy_connect() to connect phy specified by a fwnode to a phylink instance. Signed-off-by: Calvin Johnson --- Changes in v2: None drivers/net/phy/phylink.c | 54 +++ include/linux/phylink.h | 3 +++ 2 files changed, 57 insertions(+) d

[net-next PATCH v2 12/14] net: phylink: Refactor phylink_of_phy_connect()

2020-12-15 Thread Calvin Johnson
Refactor phylink_of_phy_connect() to use phylink_fwnode_phy_connect(). Signed-off-by: Calvin Johnson --- Changes in v2: None drivers/net/phy/phylink.c | 39 +-- 1 file changed, 1 insertion(+), 38 deletions(-) diff --git a/drivers/net/phy/phylink.c b/drivers

[net-next PATCH v2 14/14] net: dpaa2-mac: Add ACPI support for DPAA2 MAC driver

2020-12-15 Thread Calvin Johnson
Modify dpaa2_mac_connect() to support ACPI along with DT. Modify dpaa2_mac_get_node() to get the dpmac fwnode from either DT or ACPI. Replace of_get_phy_mode with fwnode_get_phy_mode to get phy-mode for a dpmac_node. Use helper function phylink_fwnode_phy_connect() to find phy_dev and connect to

Re: [RFC PATCH net-next 08/16] net: mscc: ocelot: avoid unneeded "lp" variable in LAG join

2020-12-15 Thread Alexandre Belloni
On 08/12/2020 14:07:54+0200, Vladimir Oltean wrote: > The index of the LAG is equal to the logical port ID that all the > physical port members have, which is further equal to the index of the > first physical port that is a member of the LAG. > > The code gets a bit carried away with logic like t

  1   2   3   >