Re: [PATCH] dt-bindings: Cleanup standard unit properties

2021-01-29 Thread Alexandre Torgue
d schema, it is simpler as a whole to only define scalar constraints. Cc: Jean Delvare Cc: Guenter Roeck Cc: Jonathan Cameron Cc: Lars-Peter Clausen Cc: Alexandre Torgue Cc: Dmitry Torokhov Cc: Ulf Hansson Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Sebastian Reichel Cc: Mark Brown

Re: [RFC] net: stmmac: Problem with adding the native GPIOs support

2020-12-14 Thread Alexandre Torgue
Hi Serge, Sorry I never used GPIO provided by DWMAC IP. Obviously, I think is to late for you to use GPIOs provided by your SoC directly. Unfortunately, it seems to be a "perfect" chicken and eggs problem :(. Do you have possibilty to "play" with gpio setting. I mean change configuration of

Re: [PATCH 6/8] dt-bindings: net: stmmac: Convert the binding to a schemas

2019-05-23 Thread Alexandre Torgue
# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Synopsys DesignWare MAC Device Tree Bindings + +maintainers: + - Alexandre Torgue + - Giuseppe Cavallaro + - Jose Abreu + +properties: + compatible: +oneOf: + - const: snps,dwmac + - const: snps,dwmac-3.50a +

[net, PATCH v2] net: stmmac: handle endianness in dwmac4_get_timestamp

2019-02-15 Thread Alexandre Torgue
GMAC IP is little-endian and used on several kind of CPU (big or little endian). Main callbacks functions of the stmmac drivers take care about it. It was not the case for dwmac4_get_timestamp function. Fixes: ba1ffd74df74 ("stmmac: fix PTP support for GMAC4") Signed-off-by: Alexan

Re: [net-next] net: stmmac: handle endianness in dwmac4_get_timestamp

2019-02-15 Thread Alexandre Torgue
On 2/14/19 7:09 PM, Florian Fainelli wrote: On 2/14/19 9:26 AM, Alexandre Torgue wrote: GMAC IP is little-endian and used on several kind of CPU (big or little endian). Main callbacks functions of the stmmac drivers take care about it. It was not the case for dwmac4_get_timestamp function

[net-next] net: stmmac: handle endianness in dwmac4_get_timestamp

2019-02-14 Thread Alexandre Torgue
GMAC IP is little-endian and used on several kind of CPU (big or little endian). Main callbacks functions of the stmmac drivers take care about it. It was not the case for dwmac4_get_timestamp function. Signed-off-by: Alexandre Torgue diff --git a/drivers/net/ethernet/stmicro/stmmac

[net-next, PATCH v2] net: stmmac: use correct define to get rx timestamp on GMAC4

2019-02-14 Thread Alexandre Torgue
igned-off-by: Alexandre Torgue --- changes since v1: *use le32_to_cpu to handle endianess diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c b/drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c index 20299f6..90045ff 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c

Re: [net-next, PATCH] net: stmmac: use correct define to get rx timestamp on GMAC4

2019-02-14 Thread Alexandre Torgue
On 2/14/19 4:30 PM, Jose Abreu wrote: On 2/14/2019 3:00 PM, Alexandre Torgue wrote: Hi Jose On 2/14/19 3:18 PM, Jose Abreu wrote: Hi Alexandre, On 2/14/2019 2:12 PM, Alexandre Torgue wrote: In dwmac4_wrback_get_rx_timestamp_status we looking for a RX timestamp. For that receive

Re: [net-next, PATCH] net: stmmac: use correct define to get rx timestamp on GMAC4

2019-02-14 Thread Alexandre Torgue
Hi Jose On 2/14/19 3:18 PM, Jose Abreu wrote: Hi Alexandre, On 2/14/2019 2:12 PM, Alexandre Torgue wrote: In dwmac4_wrback_get_rx_timestamp_status we looking for a RX timestamp. For that receive descriptors are handled and so we should use defines related to receive descriptors. It'

[net-next, PATCH] net: stmmac: use correct define to get rx timestamp on GMAC4

2019-02-14 Thread Alexandre Torgue
igned-off-by: Alexandre Torgue diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c b/drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c index 20299f6..9f062b3 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c @@ -

Re: [net-next, PATCH] net: stmmac: fix ptp timestamping on Rx on gmac4

2019-02-06 Thread Alexandre Torgue
Delay_Resp, Pdelay_Req, Pdelay_Resp and Pdelay_Resp_Follow_Up messages. Signed-off-by: Ilias Apalodimas For GMAC4 part: Tested-by: Alexandre TORGUE

Re: [PATCH V4 0/8] net: ethernet: stmmac: add support for stm32mp1

2018-06-26 Thread Alexandre Torgue
Hi Christophe, On 05/23/2018 05:47 PM, Christophe Roullier wrote: Patches to have Ethernet support on stm32mp1 Changelog: Remark from Rob Herring Move Documentation/devicetree/bindings/arm/stm32.txt in Documentation/devicetree/bindings/arm/stm32/stm32.txt and create Documentation/devicetree/bind

Re: [PATCH V4 5/8] ARM: dts: stm32: Add ethernet dwmac on stm32mp1

2018-06-26 Thread Alexandre Torgue
Hi christophe On 05/23/2018 05:47 PM, Christophe Roullier wrote: Add Ethernet support (Synopsys MAC IP 4.20a) on stm32mp1 SOC. Enable feature supported by the stmmac driver, such as TSO. Signed-off-by: Christophe Roullier --- arch/arm/boot/dts/stm32mp157c.dtsi | 30 ++

Re: [PATCH V4 1/8] net: ethernet: stmmac: add adaptation for stm32mp157c.

2018-05-24 Thread Alexandre Torgue
Hi, On 05/23/2018 05:47 PM, Christophe Roullier wrote: Glue codes to support stm32mp157c device and stay compatible with stm32 mcu family Signed-off-by: Christophe Roullier --- Acked-by: Alexandre TORGUE drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c | 270 -- 1

Re: [PATCH V4 0/8] net: ethernet: stmmac: add support for stm32mp1

2018-05-24 Thread Alexandre Torgue
On 05/23/2018 10:08 PM, David Miller wrote: From: Christophe Roullier Date: Wed, 23 May 2018 17:47:51 +0200 Patches to have Ethernet support on stm32mp1 Changelog: Remark from Rob Herring Move Documentation/devicetree/bindings/arm/stm32.txt in Documentation/devicetree/bindings/arm/stm32/stm3

Re: [PATCH net-next] net: stmmac: Add Jose Abreu as co-maintainer

2018-05-14 Thread Alexandre Torgue
t-dev! Signed-off-by: Jose Abreu Cc: David S. Miller Cc: Joao Pinto Cc: Alexandre Torgue Cc: Giuseppe Cavallaro --- MAINTAINERS |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index cecf461..c6989d0 100644 --- a/MAINTAINERS +++ b/MAINTA

Re: [PATCH] net: stmmac: Avoid VLA usage

2018-05-02 Thread Alexandre Torgue
On 05/02/2018 04:07 PM, Jose Abreu wrote: On 02-05-2018 13:36, Kees Cook wrote: On Wed, May 2, 2018 at 1:54 AM, Jose Abreu wrote: Hi Kees, On 01-05-2018 22:01, Kees Cook wrote: In the quest to remove all stack VLAs from the kernel[1], this switches the "status" stack buffer to use the ex

Re: [PATCH 3/8] ARM: dts: stm32: add ethernet pins to stm32mp157c

2018-04-25 Thread Alexandre Torgue
Hi Rob, On 04/25/2018 05:09 PM, Rob Herring wrote: On Tue, Apr 24, 2018 at 10:01 AM, Christophe Roullier wrote: Add ethernet pins on stm32mp157c. Signed-off-by: Christophe Roullier --- arch/arm/boot/dts/stm32mp157-pinctrl.dtsi | 46 +++ 1 file changed, 46 inser

Re: [PATCH] ethernet: dwmac-stm32: Fix copyright

2017-11-29 Thread Alexandre Torgue
On 11/29/2017 03:20 PM, Benjamin Gaignard wrote: Uniformize STMicroelectronics copyrights header Signed-off-by: Benjamin Gaignard CC: Alexandre Torgue --- drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net

Re: [PATCH net-next] bindings: net: stmmac: correctify note about LPI interrupt

2017-11-10 Thread Alexandre Torgue
t occurs when Rx exits the LPI state) - phy-mode: See ethernet.txt file in the same directory. - snps,reset-gpio gpio number for phy reset. - snps,reset-active-low boolean flag to indicate if phy reset is active low. Acked-by: Alexandre TORGUE

Re: [PATCH net] net: stmmac: fix completely hung TX when using TSO

2017-06-06 Thread Alexandre Torgue
: (last_segment) && (buff_size < TSO_MAX_BUFF_SIZE), I don't remember to have seen this kind of issue in the past but for sure I agree with this patch. Acked-by: Alexandre TORGUE ... On 6/6/2017 9:25 AM, Niklas Cassel wrote: stmmac_tso_allocator can fail to set the Last Des

Re: [PATCH net-next] net: stmmac: set total length of the packet to be transmitted in TDES3

2017-04-11 Thread Alexandre Torgue
Hi, On 04/11/2017 07:40 AM, Giuseppe CAVALLARO wrote: Hi Niklas patch looks ok for me, Alex any feedback? It sounds good for me to. peppe On 4/10/2017 8:33 PM, Niklas Cassel wrote: From: Niklas Cassel Field FL/TPL in register TDES3 is not correctly set on GMAC4. TX appears to be functio

Re: [v2,net-next,1/3] net: stmmac: enable multiple buffers

2017-03-27 Thread Alexandre Torgue
Hi Joao On 03/24/2017 06:09 PM, Joao Pinto wrote: Hello David, Às 5:05 PM de 3/24/2017, David Miller escreveu: From: Andrew Lunn Date: Fri, 24 Mar 2017 12:17:36 +0100 Yes it would be fantastic to have a set of boards, but I rarely see this in any maintainer :). Being a Marvell SoC and sw

Re: [PATCH] stmmac: add missing of_node_put

2017-01-17 Thread Alexandre Torgue
ink(np); of_node_put(plat->phy_node); + of_node_put(plat->mdio_node); } #else struct plat_stmmacenet_data * Acked-by: Alexandre TORGUE Thanks Alex

Re: [patch net-next] stmmac: indent an if statement

2017-01-17 Thread Alexandre Torgue
Hi Julia On 01/16/2017 11:10 PM, Julia Lawall wrote: On Tue, 17 Jan 2017, Dan Carpenter wrote: On Mon, Jan 16, 2017 at 10:46:22PM +0100, Julia Lawall wrote: On Mon, 16 Jan 2017, Dan Carpenter wrote: On Mon, Jan 16, 2017 at 12:19:24PM +0300, Dan Carpenter wrote: On Sun, Jan 15, 2017 at

Re: [patch net-next] stmmac: indent an if statement

2017-01-17 Thread Alexandre Torgue
Dear David On 01/16/2017 11:00 PM, David Miller wrote: From: Dan Carpenter Date: Tue, 17 Jan 2017 00:56:15 +0300 (It would be better if one of the stmmac people were responding here insead of a random fix the indenting weenie like myself.) They are all too busy trying to rename the driver,

Re: [PATCH v2 2/2] stmmac: rename it to synopsys

2017-01-12 Thread Alexandre Torgue
Hi Joao On 01/12/2017 10:43 AM, Joao Pinto wrote: Hi Florian, Às 9:14 PM de 1/11/2017, Florian Fainelli escreveu: On 01/10/2017 06:52 AM, Joao Pinto wrote: This patch renames stmicro/stmmac to synopsys/ since it is a standard ethernet software package regarding synopsys ethernet controllers,

Re: [PATCH v2 0/2] remove dwc_eth_qos and rename stmicro/stmmac

2017-01-11 Thread Alexandre Torgue
On 01/11/2017 03:29 PM, Joao Pinto wrote: Alex, Às 2:25 PM de 1/11/2017, Alexandre Torgue escreveu: Jao, On 01/11/2017 12:54 PM, Joao Pinto wrote: Hi Alex, Às 11:39 AM de 1/11/2017, Alexandre Torgue escreveu: Hi Jao, On 01/10/2017 03:52 PM, Joao Pinto wrote: This patch set removes

Re: [PATCH v2 0/2] remove dwc_eth_qos and rename stmicro/stmmac

2017-01-11 Thread Alexandre Torgue
Jao, On 01/11/2017 12:54 PM, Joao Pinto wrote: Hi Alex, Às 11:39 AM de 1/11/2017, Alexandre Torgue escreveu: Hi Jao, On 01/10/2017 03:52 PM, Joao Pinto wrote: This patch set removes the synopsys/dwc_eth_qos since it was merged recently to stmmac (dwmac-dwc-qos-eth glue driver). It also

Re: [PATCH v2 0/2] remove dwc_eth_qos and rename stmicro/stmmac

2017-01-11 Thread Alexandre Torgue
Hi Jao, On 01/10/2017 03:52 PM, Joao Pinto wrote: This patch set removes the synopsys/dwc_eth_qos since it was merged recently to stmmac (dwmac-dwc-qos-eth glue driver). It also renames stmicro/stmmac to synopsys/ since it is a standard ethernet software package regarding synopsys ethernet cont

Re: [PATCH v3 3/3] stmmac: adding new glue driver dwmac-dwc-qos-eth

2017-01-06 Thread Alexandre Torgue
Hi Joao, On 01/05/2017 06:49 PM, Joao Pinto wrote: Hi Alex, Às 5:19 PM de 1/5/2017, Alexandre Torgue escreveu: Hi Joao, On 01/04/2017 05:22 PM, Joao Pinto wrote: This patch adds a new glue driver called dwmac-dwc-qos-eth which was based in the dwc_eth_qos as is. To assure retro

Re: [PATCH v3 3/3] stmmac: adding new glue driver dwmac-dwc-qos-eth

2017-01-05 Thread Alexandre Torgue
Hi Joao, On 01/04/2017 05:22 PM, Joao Pinto wrote: This patch adds a new glue driver called dwmac-dwc-qos-eth which was based in the dwc_eth_qos as is. To assure retro-compatibility a slight tweak was also added to stmmac_platform. Sorry to come late in the review. I have a basic question. Why

Re: stmmac DT property snps,axi_all

2016-12-09 Thread Alexandre Torgue
Hi Niklas On 12/09/2016 10:53 AM, Niklas Cassel wrote: On 12/09/2016 10:20 AM, Niklas Cassel wrote: On 12/08/2016 02:36 PM, Alexandre Torgue wrote: Hi Niklas, On 12/05/2016 05:18 PM, Niklas Cassel wrote: Hello Giuseppe I'm trying to figure out what snps,axi_all is supposed to repr

Re: [PATCH net-next 0/2] Initial driver for Synopsys DWC XLGMAC

2016-12-08 Thread Alexandre Torgue
Hi On 12/07/2016 04:57 AM, Jie Deng wrote: This series provides the support for 25/40/50/100 GbE devices using Synopsys DWC Enterprise Ethernet (XLGMAC). Can you explain which GMAC are you targeted ? A driver which support some Synopsys GMAC IP already exists. It support GMAC 3.5, 3.7, 4.0,

Re: stmmac driver...

2016-12-08 Thread Alexandre Torgue
On 12/08/2016 04:25 PM, David Miller wrote: From: Alexandre Torgue Date: Thu, 8 Dec 2016 14:55:04 +0100 Maybe I forget some series. Do you have others in mind ? Please see the thread titled: "net: ethernet: Initial driver for Synopsys DWC XLGMAC" which seems to be

Re: [PATCH v3 1/6] net: stmmac: return error if no DMA configuration is found

2016-12-08 Thread Alexandre Torgue
Hi David, On 12/08/2016 04:19 PM, David Miller wrote: From: Alexandre Torgue Date: Thu, 8 Dec 2016 11:44:35 +0100 Acked-by: Alexandre Torgue Typo in your email. I would suggest that you put this into an editor macro or similar in order to avoid such typos in the future. That's

Re: stmmac driver...

2016-12-08 Thread Alexandre Torgue
Hi David, On 12/07/2016 07:06 PM, David Miller wrote: Giuseppe and Alexandre, There are a lot of patches and discussions happening around the stammc driver lately and both of you are listed as the maintainers. I really need prompt and conclusive reviews of these patch submissions from you, an

Re: stmmac DT property snps,axi_all

2016-12-08 Thread Alexandre Torgue
Hi Niklas, On 12/05/2016 05:18 PM, Niklas Cassel wrote: Hello Giuseppe I'm trying to figure out what snps,axi_all is supposed to represent. It appears that the value is saved, but never used in the code. Looking at the register specification, I'm guessing that it represents Address-Aligned B

Re: [PATCH v3 1/6] net: stmmac: return error if no DMA configuration is found

2016-12-08 Thread Alexandre Torgue
error if no DMA configuration is found, that way we can assume that the DMA configuration always exists. Signed-off-by: Niklas Cassel Acked-by: Alexandre Torgue --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions

Re: [PATCH v3 6/6] net: smmac: allow configuring lower pbl values

2016-12-08 Thread Alexandre Torgue
Hi Niklas, On 12/07/2016 03:20 PM, Niklas Cassel wrote: From: Niklas Cassel The driver currently always sets the PBLx8/PBLx4 bit, which means that the pbl values configured via the pbl/txpbl/rxpbl DT properties are always multiplied by 8/4 in the hardware. In order to allow the DT to configur

Re: [PATCH v3 5/6] net: stmmac: add support for independent DMA pbl for tx/rx

2016-12-08 Thread Alexandre Torgue
Hi Niklas On 12/07/2016 03:20 PM, Niklas Cassel wrote: From: Niklas Cassel GMAC and newer supports independent programmable burst lengths for DMA tx/rx. Add new optional devicetree properties representing this. To be backwards compatible, snps,pbl will still be valid, but snps,txpbl/snps,rxpb

Re: [PATCH v3 3/6] net: stmmac: stmmac_platform: fix parsing of DT binding

2016-12-08 Thread Alexandre Torgue
Hi On 12/08/2016 10:46 AM, Niklas Cassel wrote: On 12/08/2016 10:02 AM, Alexandre Torgue wrote: Hi Niklas On 12/07/2016 03:20 PM, Niklas Cassel wrote: From: Niklas Cassel commit 64c3b252e9fc ("net: stmmac: fixed the pbl setting with DT") changed the parsing of the DT bindin

Re: [PATCH v3 4/6] net: stmmac: dwmac1000: fix define DMA_BUS_MODE_RPBL_MASK

2016-12-08 Thread Alexandre Torgue
Hi Niklas On 12/07/2016 03:20 PM, Niklas Cassel wrote: From: Niklas Cassel DMA_BUS_MODE_RPBL_MASK is really 6 bits, just like DMA_BUS_MODE_PBL_MASK. Signed-off-by: Niklas Cassel --- drivers/net/ethernet/stmicro/stmmac/dwmac1000.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

Re: [PATCH v3 3/6] net: stmmac: stmmac_platform: fix parsing of DT binding

2016-12-08 Thread Alexandre Torgue
Hi Niklas On 12/07/2016 03:20 PM, Niklas Cassel wrote: From: Niklas Cassel commit 64c3b252e9fc ("net: stmmac: fixed the pbl setting with DT") changed the parsing of the DT binding. Before 64c3b252e9fc, snps,fixed-burst and snps,mixed-burst were parsed regardless if the property snps,pbl exist

Re: [PATCH v3 2/6] net: stmmac: simplify the common DMA init API

2016-12-08 Thread Alexandre Torgue
Hi Niklas, On 12/07/2016 03:20 PM, Niklas Cassel wrote: From: Niklas Cassel Use struct stmmac_dma_cfg *dma_cfg as an argument rather than using all the struct members as individual arguments. Signed-off-by: Niklas Cassel Thanks for this patch. You can add my Acked-by. Regards Alex ---

Re: stmmac ethernet in kernel 4.9-rc6: coalescing related pauses.

2016-12-02 Thread Alexandre Torgue
Hi Pavel and Peppe, On 12/02/2016 02:51 PM, Giuseppe CAVALLARO wrote: On 12/2/2016 1:32 PM, Pavel Machek wrote: Hi! Well, if you have a workload that sends and receive packets, it tends to work ok, as you do tx_clean() in stmmac_poll(). My workload is not like that -- it is "sending packets a

Re: [PATCH] stmmac: reduce code duplication getting basic descriptors

2016-12-02 Thread Alexandre Torgue
Hi Pavel, On 11/28/2016 01:17 PM, Pavel Machek wrote: Remove code duplication getting basic descriptors. I agree with your patch, it will make code easier to understand. After fix kbuild issue you can add my Acked-by; Regards Alex Signed-off-by: Pavel Machek diff --git a/drivers/net/eth

Re: [PATCH] net: stmmac: enable tx queue 0 for gmac4 IPs synthesized with multiple TX queues

2016-12-01 Thread Alexandre Torgue
Hi David and Niklas, On 11/28/2016 05:29 PM, David Miller wrote: From: Niklas Cassel Date: Thu, 24 Nov 2016 15:36:33 +0100 From: Niklas Cassel The dwmac4 IP can synthesized with 1-8 number of tx queues. On an IP synthesized with DWC_EQOS_NUM_TXQ > 1, all txqueues are disabled by default. Fo

Re: [PATCH] net: stmmac: enable tx queue 0 for gmac4 IPs synthesized with multiple TX queues

2016-11-25 Thread Alexandre Torgue
Hi Niklas On 11/25/2016 01:14 PM, Niklas Cassel wrote: On 11/25/2016 01:10 PM, Niklas Cassel wrote: On 11/24/2016 07:11 PM, Alexandre Torgue wrote: Hi Niklas, Hello Alexandre On 11/24/2016 03:36 PM, Niklas Cassel wrote: From: Niklas Cassel The dwmac4 IP can synthesized with 1-8 number

Re: [PATCH] net: stmmac: enable tx queue 0 for gmac4 IPs synthesized with multiple TX queues

2016-11-24 Thread Alexandre Torgue
Hi Niklas, On 11/24/2016 03:36 PM, Niklas Cassel wrote: From: Niklas Cassel The dwmac4 IP can synthesized with 1-8 number of tx queues. On an IP synthesized with DWC_EQOS_NUM_TXQ > 1, all txqueues are disabled by default. For these IPs, the bitfield TXQEN is R/W. Always enable tx queue 0. The

Re: [PATCH 4/4] net: stmmac: stmmac_platform: use correct setup function for gmac4

2016-11-24 Thread Alexandre Torgue
Hi Niklas, On 11/23/2016 03:25 PM, Niklas Cassel wrote: From: Niklas Cassel devicetree binding for stmmac states: - compatible: Should be "snps,dwmac-", "snps,dwmac" For backwards compatibility: "st,spear600-gmac" is also supported. Previously, when specifying "snps,dwmac-4.10a", "snp

Re: [PATCH 1/4] bindings: net: stmmac: correct note about TSO

2016-11-24 Thread Alexandre Torgue
Hi Niklas, On 11/23/2016 03:24 PM, Niklas Cassel wrote: From: Niklas Cassel snps,tso was previously placed under AXI BUS Mode parameters, suggesting that the property should be in the stmmac-axi-config node. TSO (TCP Segmentation Offloading) has nothing to do with AXI BUS Mode parameters, and

Re: [PATCH (net.git) 0/3] stmmac: fix PTP support

2016-10-26 Thread Alexandre Torgue
| 97 +++--- drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c | 9 +- drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.h | 72 11 files changed, 260 insertions(+), 152 deletions(-) For the series: Acked-by: Alexandre Torgue Thanks Alex

[PATCH v2 1/3] ARM: dts: stm32f429: Align Ethernet node with new bindings properties

2016-10-24 Thread Alexandre TORGUE
This patch aligns clocks names and node reference according to new stm32-dwmac glue binding. It also renames Ethernet pinctrl phandle (indeed there is no need to add 0 as Ethernet instance as there is only one IP in SOC). Signed-off-by: Alexandre TORGUE diff --git a/arch/arm/boot/dts/stm32429i

[PATCH v2 3/3] ARM: dts: stm32f429: remove Ethernet wake on Lan support

2016-10-24 Thread Alexandre TORGUE
This patch removes WoL (Wake on Lan) support as it is not yet fully supported and tested. Signed-off-by: Alexandre TORGUE diff --git a/arch/arm/boot/dts/stm32f429.dtsi b/arch/arm/boot/dts/stm32f429.dtsi index 6350117b..ad0bc6a 100644 --- a/arch/arm/boot/dts/stm32f429.dtsi +++ b/arch/arm/boot

[PATCH v2 0/3] STM32F429: Add Ethernet fixes

2016-10-24 Thread Alexandre TORGUE
: -Change DT to be compliant to stm32 ethernet glue binding -Add phy-handle to correctly use mdio subnode -Remove WoL support changes since v1: -squash patch1 and patch2. Regards Alex Alexandre TORGUE (3): ARM: dts: stm32f429: Align Ethernet node with new bindings properties ARM: dts: stm32f429

[PATCH v2 2/3] ARM: dts: stm32f429: Fix Ethernet node on Eval Board

2016-10-24 Thread Alexandre TORGUE
"phy-handle" entry is mandatory when mdio subnode is used in Ethernet node. Signed-off-by: Alexandre TORGUE diff --git a/arch/arm/boot/dts/stm32429i-eval.dts b/arch/arm/boot/dts/stm32429i-eval.dts index fa30bf1..a11b108 100644 --- a/arch/arm/boot/dts/stm32429i-eval.dts +++ b/arch/ar

Re: [PATCH 0/4] STM32F429: Add Ethernet fixes

2016-10-24 Thread Alexandre Torgue
Hi David, On 10/20/2016 08:41 PM, David Miller wrote: From: Alexandre TORGUE Date: Thu, 20 Oct 2016 17:21:22 +0200 This series adds several fixes for Ethernet for stm32f429 MCU. First 2 patches have already been reviewed some months ago when stm32 Ethernet glue has been pushed (I added in

[PATCH 4/4] ARM: dts: stm32f429: remove Ethernet wake on Lan support

2016-10-20 Thread Alexandre TORGUE
This patch removes WoL (Wake on Lan) support as it is not yet fully supported and tested. Signed-off-by: Alexandre TORGUE diff --git a/arch/arm/boot/dts/stm32f429.dtsi b/arch/arm/boot/dts/stm32f429.dtsi index 6350117b..ad0bc6a 100644 --- a/arch/arm/boot/dts/stm32f429.dtsi +++ b/arch/arm/boot

[PATCH 2/4] ARM: dts: stm32f429: Update Ethernet node on Eval board

2016-10-20 Thread Alexandre TORGUE
Update new pinctrl phandle name and use new node name. Signed-off-by: Alexandre TORGUE diff --git a/arch/arm/boot/dts/stm32429i-eval.dts b/arch/arm/boot/dts/stm32429i-eval.dts index 13c7cd2..fa30bf1 100644 --- a/arch/arm/boot/dts/stm32429i-eval.dts +++ b/arch/arm/boot/dts/stm32429i-eval.dts

[PATCH 1/4] ARM: dts: stm32f429: Align Ethernet node with new bindings properties

2016-10-20 Thread Alexandre TORGUE
This patch aligns clocks names and node reference according to new stm32-dwmac glue binding. It also renames Ethernet pinctrl phandle (indeed there is no need to add 0 as Ethernet instance as there is only one IP in SOC). Signed-off-by: Alexandre TORGUE diff --git a/arch/arm/boot/dts/stm32f429

[PATCH 3/4] ARM: dts: stm32f429: Fix Ethernet node on Eval Board

2016-10-20 Thread Alexandre TORGUE
"phy-handle" entry is mandatory when mdio subnode is used in Ethernet node. Signed-off-by: Alexandre TORGUE diff --git a/arch/arm/boot/dts/stm32429i-eval.dts b/arch/arm/boot/dts/stm32429i-eval.dts index fa30bf1..a11b108 100644 --- a/arch/arm/boot/dts/stm32429i-eval.dts +++ b/arch/ar

[PATCH 0/4] STM32F429: Add Ethernet fixes

2016-10-20 Thread Alexandre TORGUE
correctly use mdio subnode -Remove WoL support Regards Alex Alexandre TORGUE (4): ARM: dts: stm32f429: Align Ethernet node with new bindings properties ARM: dts: stm32f429: Update Ethernet node on Eval board ARM: dts: stm32f429: Fix Ethernet node on Eval Board ARM: dts: stm32f429: remove

Re: [PATCH (net.git)] stmmac: display the descriptors if DES0 = 0

2016-10-20 Thread Alexandre Torgue
Hi Peppe, On 10/20/2016 10:01 AM, Giuseppe Cavallaro wrote: It makes sense to display the descriptors even if DES0 is zero. This helps for example in case of it is needed to dump rx write-back descriptors to get timestamp status. Signed-off-by: Giuseppe Cavallaro Cc: Alexandre TORGUE

Re: [PATCH 13/15] stmmac: use IS_ENABLED() instead of checking for built-in or module

2016-09-12 Thread Alexandre Torgue
) #define STMMAC_VLAN_TAG_USED #include #endif Reviewed-by: Alexandre TORGUE Thanks, Alex

Re: stmmac/RTL8211F/Meson GXBB: TX throughput problems

2016-09-12 Thread Alexandre Torgue
Hi Martin, On 09/11/2016 10:39 PM, Martin Blumenstingl wrote: Hello, I have a device with a Meson GXBB SoC with an stmmac IP block. Which Synopsys IP version do you use ? Gbit ethernet on my device is provided by a Realtek RTL8211F RGMII PHY. Similar issues were reported in #linux-amlogic

[RESEND PATCH v6 1/3] net: ethernet: dwmac: add Ethernet glue logic for stm32 chip

2016-08-29 Thread Alexandre TORGUE
From: Alexandre TORGUE stm324xx family chips support Synopsys MAC 3.510 IP. This patch adds settings for logical glue logic: -clocks -mode selection MII or RMII. Reviewed-by: Joachim Eastwood Acked-by: Giuseppe Cavallaro Tested-by: Maxime Coquelin Signed-off-by: Alexandre TORGUE diff --git

[RESEND PATCH v6 3/3] net: ethernet: stmmac: add support of Synopsys 3.50a MAC IP

2016-08-29 Thread Alexandre TORGUE
From: Alexandre TORGUE Adds support of Synopsys 3.50a MAC IP in stmmac driver. Acked-by: Giuseppe Cavallaro Tested-by: Maxime Coquelin Signed-off-by: Alexandre TORGUE diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c

[RESEND PATCH v6 0/3] Add Ethernet support on STM32F429

2016-08-29 Thread Alexandre TORGUE
ectly in dwmac-stm32 glue driver. -Take into account Joachim review. Regards. Alexandre. Alexandre TORGUE (3): net: ethernet: dwmac: add Ethernet glue logic for stm32 chip Documentation: Bindings: Add STM32 DWMAC glue net: ethernet: stmmac: add support of Synopsys 3.50a MAC IP .../dev

[RESEND PATCH v6 2/3] Documentation: Bindings: Add STM32 DWMAC glue

2016-08-29 Thread Alexandre TORGUE
From: Alexandre TORGUE Acked-by: Rob Herring Signed-off-by: Alexandre TORGUE diff --git a/Documentation/devicetree/bindings/net/stm32-dwmac.txt b/Documentation/devicetree/bindings/net/stm32-dwmac.txt new file mode 100644 index 000..c35afb7 --- /dev/null +++ b/Documentation/devicetree

Re: [PATCH v2 14/15] ethernet: stmicro: stmmac: add missing of_node_put after calling of_parse_phandle

2016-08-01 Thread Alexandre Torgue
_node); return ERR_PTR(-ENOMEM); } plat->dma_cfg = dma_cfg; You can add my: Acked-by: Alexandre Torgue Regards Alex

Re: [PATCH 14/15] ethernet: stmicro: stmmac: stmmac_platform: add missing of_node_put after calling of_parse_phandle

2016-07-28 Thread Alexandre Torgue
Hi, On 07/27/2016 04:20 AM, Peter Chen wrote: of_node_put needs to be called when the device node which is got from of_parse_phandle has finished using. Signed-off-by: Peter Chen --- drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 5 - 1 file changed, 4 insertions(+), 1 deletion

Re: [RESEND PATCH v6 0/6] Add Ethernet support on STM32F429

2016-06-30 Thread Alexandre Torgue
GMT+02:00 David Miller : From: Alexandre TORGUE Date: Mon, 9 May 2016 12:31:33 +0200 STM32F429 Chip embeds a Synopsys 3.50a MAC IP. This series: -enhance current stmmac driver to control it (code already available) and adds basic glue for STM32F429 chip. -Enable basic Net config in kernel

[RESEND PATCH v6 4/6] ARM: STM32: Enable Ethernet in stm32_defconfig

2016-05-09 Thread Alexandre TORGUE
Enable basic Ethernet support (IPV4) for stm32 defconfig. Signed-off-by: Alexandre TORGUE diff --git a/arch/arm/configs/stm32_defconfig b/arch/arm/configs/stm32_defconfig index 1e5ec2a..719218b 100644 --- a/arch/arm/configs/stm32_defconfig +++ b/arch/arm/configs/stm32_defconfig @@ -33,11 +33,20

[RESEND PATCH v6 3/6] net: ethernet: stmmac: add support of Synopsys 3.50a MAC IP

2016-05-09 Thread Alexandre TORGUE
Adds support of Synopsys 3.50a MAC IP in stmmac driver. Acked-by: Giuseppe Cavallaro Tested-by: Maxime Coquelin Signed-off-by: Alexandre TORGUE diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c index 409db91..7718247

[RESEND PATCH v6 2/6] Documentation: Bindings: Add STM32 DWMAC glue

2016-05-09 Thread Alexandre TORGUE
Acked-by: Rob Herring Signed-off-by: Alexandre TORGUE diff --git a/Documentation/devicetree/bindings/net/stm32-dwmac.txt b/Documentation/devicetree/bindings/net/stm32-dwmac.txt new file mode 100644 index 000..c35afb7 --- /dev/null +++ b/Documentation/devicetree/bindings/net/stm32-dwmac.txt

[RESEND PATCH v6 1/6] net: ethernet: dwmac: add Ethernet glue logic for stm32 chip

2016-05-09 Thread Alexandre TORGUE
stm324xx family chips support Synopsys MAC 3.510 IP. This patch adds settings for logical glue logic: -clocks -mode selection MII or RMII. Reviewed-by: Joachim Eastwood Acked-by: Giuseppe Cavallaro Tested-by: Maxime Coquelin Signed-off-by: Alexandre TORGUE diff --git a/drivers/net/ethernet

[RESEND PATCH v6 0/6] Add Ethernet support on STM32F429

2016-05-09 Thread Alexandre TORGUE
is no more driven in stmmac_pltfr but directly in dwmac-stm32 glue driver. -Take into account Joachim review. Regards. Alexandre. Alexandre TORGUE (6): net: ethernet: dwmac: add Ethernet glue logic for stm32 chip Documentation: Bindings: Add STM32 DWMAC glue net: ethernet: stmmac: add suppo

[RESEND PATCH v6 5/6] ARM: dts: stm32f429: Align Ethernet node with new bindings properties

2016-05-09 Thread Alexandre TORGUE
This patch aligns clocks names and node reference according to new stm32-dwmac glue binding. It also renames Ethernet pinctrl phandle (indeed there is no need to add 0 as Ethernet instance as there is only one IP in SOC). Signed-off-by: Alexandre TORGUE diff --git a/arch/arm/boot/dts/stm32f429

[RESEND PATCH v6 6/6] ARM: dts: stm32f429: Update Ethernet node on Eval board

2016-05-09 Thread Alexandre TORGUE
Update new pinctrl phandle name and use new node name. Signed-off-by: Alexandre TORGUE diff --git a/arch/arm/boot/dts/stm32429i-eval.dts b/arch/arm/boot/dts/stm32429i-eval.dts index 6bfc595..9a72445 100644 --- a/arch/arm/boot/dts/stm32429i-eval.dts +++ b/arch/arm/boot/dts/stm32429i-eval.dts

[PATCH net-next] net: ethernet: stmmac: update MDIO support for GMAC4

2016-04-28 Thread Alexandre TORGUE
On new GMAC4 IP, MAC_MDIO_address register has been updated, and bitmaps changed. This patch takes into account those changes. Signed-off-by: Alexandre TORGUE diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c index 06704ca

[PATCH v6 2/6] Documentation: Bindings: Add STM32 DWMAC glue

2016-04-25 Thread Alexandre TORGUE
Signed-off-by: Alexandre TORGUE diff --git a/Documentation/devicetree/bindings/net/stm32-dwmac.txt b/Documentation/devicetree/bindings/net/stm32-dwmac.txt new file mode 100644 index 000..c35afb7 --- /dev/null +++ b/Documentation/devicetree/bindings/net/stm32-dwmac.txt @@ -0,0 +1,32

[PATCH v6 0/6] Add Ethernet support on STM32F429

2016-04-25 Thread Alexandre TORGUE
is no more driven in stmmac_pltfr but directly in dwmac-stm32 glue driver. -Take into account Joachim review. Regards. Alexandre. Alexandre TORGUE (6): net: ethernet: dwmac: add Ethernet glue logic for stm32 chip Documentation: Bindings: Add STM32 DWMAC glue net: ethernet: stmmac: add suppo

[PATCH v6 4/6] ARM: STM32: Enable Ethernet in stm32_defconfig

2016-04-25 Thread Alexandre TORGUE
Enable basic Ethernet support (IPV4) for stm32 defconfig. Signed-off-by: Alexandre TORGUE diff --git a/arch/arm/configs/stm32_defconfig b/arch/arm/configs/stm32_defconfig index 1e5ec2a..719218b 100644 --- a/arch/arm/configs/stm32_defconfig +++ b/arch/arm/configs/stm32_defconfig @@ -33,11 +33,20

[PATCH v6 1/6] net: ethernet: dwmac: add Ethernet glue logic for stm32 chip

2016-04-25 Thread Alexandre TORGUE
stm324xx family chips support Synopsys MAC 3.510 IP. This patch adds settings for logical glue logic: -clocks -mode selection MII or RMII. Reviewed-by: Joachim Eastwood Acked-by: Giuseppe Cavallaro Tested-by: Maxime Coquelin Signed-off-by: Alexandre TORGUE diff --git a/drivers/net/ethernet

[PATCH v6 3/6] net: ethernet: stmmac: add support of Synopsys 3.50a MAC IP

2016-04-25 Thread Alexandre TORGUE
Adds support of Synopsys 3.50a MAC IP in stmmac driver. Acked-by: Giuseppe Cavallaro Tested-by: Maxime Coquelin Signed-off-by: Alexandre TORGUE diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c index effaa4f..7ef8b98

[PATCH v6 6/6] ARM: dts: stm32f429: Update Ethernet node on Eval board

2016-04-25 Thread Alexandre TORGUE
Update new pinctrl phandle name and use new node name. Signed-off-by: Alexandre TORGUE diff --git a/arch/arm/boot/dts/stm32429i-eval.dts b/arch/arm/boot/dts/stm32429i-eval.dts index 6bfc595..9a72445 100644 --- a/arch/arm/boot/dts/stm32429i-eval.dts +++ b/arch/arm/boot/dts/stm32429i-eval.dts

[PATCH v6 5/6] ARM: dts: stm32f429: Align Ethernet node with new bindings properties

2016-04-25 Thread Alexandre TORGUE
This patch aligns clocks names and node reference according to new stm32-dwmac glue binding. It also renames Ethernet pinctrl phandle (indeed there is no need to add 0 as Ethernet instance as there is only one IP in SOC). Signed-off-by: Alexandre TORGUE diff --git a/arch/arm/boot/dts/stm32f429

[PATCH net-next] net: ethernet: stmmac: GMAC4.xx: Fix TX descriptor preparation

2016-04-08 Thread Alexandre TORGUE
: Alexandre TORGUE diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c b/drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c index d4952c7..4ec7397 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c @@ -254,14 +254,7

Re: [PATCH v5 2/4] Documentation: Bindings: Add STM32 DWMAC glue

2016-04-04 Thread Alexandre Torgue
Hi Rob, 2016-03-22 17:11 GMT+01:00 Alexandre Torgue : > Hi guys, > > I will fix typo issues (s/vesrion/version and ethernet @). > > Concerning compatible string. For sure "snps,dwmac-3.50a" string is > not used inside glue driver. > I perfere to keep it for informat

[RESEND PATCH net-next 10/13] stmmac: support new GMAC4

2016-04-01 Thread Alexandre TORGUE
This patch adds the whole GMAC4 support inside the stmmac d.d. now able to use the new HW and some new features i.e.: TSO. It is missing the multi-queue and split Header support at this stage. This patch also updates the driver version and the stmmac.txt. Signed-off-by: Alexandre TORGUE Signed

[RESEND PATCH net-next 12/13] stmmac: update version to Jan_2016

2016-04-01 Thread Alexandre TORGUE
This patch just updates the driver to the version fully tested on STi platforms. This version is Jan_2016. Signed-off-by: Alexandre TORGUE diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac.h b/drivers/net/ethernet/stmicro/stmmac/stmmac.h index 317ce35..ff67506 100644 --- a/drivers/net

[RESEND PATCH net-next 08/13] stmmac: enhance mmc counter management

2016-04-01 Thread Alexandre TORGUE
-off-by: Alexandre TORGUE diff --git a/drivers/net/ethernet/stmicro/stmmac/mmc.h b/drivers/net/ethernet/stmicro/stmmac/mmc.h index 192c249..38a1a56 100644 --- a/drivers/net/ethernet/stmicro/stmmac/mmc.h +++ b/drivers/net/ethernet/stmicro/stmmac/mmc.h @@ -35,6 +35,10

[RESEND PATCH net-next 09/13] stmmac: add new DT platform entries for GMAC4

2016-04-01 Thread Alexandre TORGUE
This is to support the snps,dwmac-4.00 and snps,dwmac-4.10a and related features on the platform driver. See binding doc for further details. Signed-off-by: Giuseppe Cavallaro Signed-off-by: Alexandre TORGUE diff --git a/Documentation/devicetree/bindings/net/stmmac.txt b/Documentation

[RESEND PATCH net-next 03/13] stmmac: rework synopsys id read, moved to dwmac setup

2016-04-01 Thread Alexandre TORGUE
synopsys_uid is only used once after setup, to get synopsys_id by using shitf/mask operation. It's no longer used then. So, remove this temporary variable and directly compute synopsys_id from setup routine. Acked-by: Giuseppe Cavallaro Signed-off-by: Fabrice Gasnier Signed-off-by: Alex

[RESEND PATCH net-next 06/13] stmmac: add DMA support for GMAC 4.xx

2016-04-01 Thread Alexandre TORGUE
w transfer: "current descriptor pointer < Descriptor tail pointer" The DMA automatically wraps around the base address when the end of ring is reached. Up to 8 DMA could be use but currently we only use one (channel0) Signed-off-by: Alexandre TORGUE Signed-off-by: Giuseppe Cavallaro d

[RESEND PATCH net-next 13/13] stmmac: update MAINTAINERS

2016-04-01 Thread Alexandre TORGUE
Signed-off-by: Alexandre TORGUE diff --git a/MAINTAINERS b/MAINTAINERS index 32bafda..37fc112 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3348,6 +3348,7 @@ F:Documentation/powerpc/cxlflash.txt STMMAC ETHERNET DRIVER M: Giuseppe Cavallaro +M: Alexandre Torgue L

[RESEND PATCH net-next 02/13] stmmac: rework the routines to show the ring status

2016-04-01 Thread Alexandre TORGUE
To avoid lot of check in stmmac_main for display ring management and support the GMAC4 chip, the display_ring function is moved into dedicated descriptor file. Signed-off-by: Alexandre TORGUE Signed-off-by: Giuseppe Cavallaro diff --git a/drivers/net/ethernet/stmicro/stmmac/common.h b/drivers

[RESEND PATCH net-next 07/13] stmmac: add GMAC4 core support

2016-04-01 Thread Alexandre TORGUE
This is the initial support for GMAC4 that includes the main callbacks to setup the core module: including Csum, basic filtering, mac address and interrupt (MMC, MTL, PMT) No LPI added. Signed-off-by: Alexandre TORGUE Signed-off-by: Giuseppe Cavallaro diff --git a/drivers/net/ethernet/stmicro

[RESEND PATCH net-next 11/13] Documentation: networking: update stmmac

2016-04-01 Thread Alexandre TORGUE
Update stmmac driver documentation according to new GMAC 4.x family. Signed-off-by: Alexandre TORGUE diff --git a/Documentation/networking/stmmac.txt b/Documentation/networking/stmmac.txt index d64a147..671fe3d 100644 --- a/Documentation/networking/stmmac.txt +++ b/Documentation/networking

  1   2   >