From: Willem de Bruijn
Date: Sat, 8 Dec 2018 06:22:46 -0500
> From: Willem de Bruijn
>
> extra_uref is used in __ip(6)_append_data only if uarg is set.
>
> Smatch sees that the variable is passed to sock_zerocopy_put_abort.
> This function accesses it only when uarg is set, but smatch cannot
From: Ilias Apalodimas
Date: Sat, 8 Dec 2018 16:57:28 +0200
> The patchset speeds up the mvneta driver on the default network
> stack. The only change that was needed was to adapt the driver to
> using the page_pool API. The speed improvements we are seeing on
> specific workloads (i.e 256b <
From: Jesper Dangaard Brouer
Date: Sat, 8 Dec 2018 12:36:10 +0100
> The annoying part is actually that depending on the kernel config
> options CONFIG_XFRM, CONFIG_NF_CONNTRACK and CONFIG_BRIDGE_NETFILTER,
> whether there is a cache-line split, where mem_info gets moved into the
> next
From: Jesper Dangaard Brouer
Date: Fri, 07 Dec 2018 00:25:47 +0100
> @@ -744,6 +745,10 @@ struct sk_buff {
> head_frag:1,
> xmit_more:1,
> pfmemalloc:1;
> + /* TODO: Future idea, extend mem_info with
From: Jesper Dangaard Brouer
Date: Fri, 07 Dec 2018 00:25:32 +0100
> From: Ilias Apalodimas
>
> Add helper functions for retreiving dma_addr_t stored in page_private and
> unmapping dma addresses, mapped via the page_pool API.
>
> Signed-off-by: Ilias Apalodimas
> Signed-off-by: Jesper
From: Benjamin Herrenschmidt
Date: Fri, 07 Dec 2018 15:05:04 +1100
> This reverts commit 624ca9c33c8a853a4a589836e310d776620f4ab9.
>
> This commit is completely bogus. The STACR register has two formats, old
> and new, depending on the version of the IP block used. There's a pair of
>
From: Maciej Żenczykowski
Date: Fri, 7 Dec 2018 16:46:36 -0800
>> This doesn't apply to the current net tree.
>>
>> Also "net-udp: " is a weird subsystem prefix, just use "udp: ".
>>
>> Thank you.
>
> Interesting... this patch was on top of net-next/master, and it still
> rebases cleanly on
From: Lucas Bates
Date: Thu, 6 Dec 2018 17:42:23 -0500
> Patch 1 adds a timeout feature for any command tdc launches in a subshell.
> This prevents tdc from hanging indefinitely.
>
> Patches 2-4 introduce a new method for tracking and generating test case
> results, and implements it across
From: Stefano Brivio
Date: Thu, 6 Dec 2018 19:30:35 +0100
> Patch 1/2 fixes a slab out-of-bounds occurring with short SCTP packets over
> IPv4 over L2TP over IPv6 on a configuration with relatively low HEADER_MAX.
>
> Patch 2/2 makes sure we avoid writing before the allocated buffer in
>
From: Eric Dumazet
Date: Thu, 6 Dec 2018 09:58:24 -0800
> tcp_tso_should_defer() can return true in three different cases :
>
> 1) We are cwnd-limited
> 2) We are rwnd-limited
> 3) We are application limited.
>
> Neal pointed out that my recent fix went too far, since
> it assumed that if
From: Maciej Żenczykowski
Date: Wed, 5 Dec 2018 12:59:17 -0800
> From: Maciej Żenczykowski
>
> During udp socket lookup cpu match should be lowest priority,
> hence it should increase score by only 1.
>
> The next priority is delivering v4 to v4 sockets, and v6 to v6 sockets.
> The v6 code
From: yupeng
Date: Wed, 5 Dec 2018 18:56:28 -0800
> after set SO_DONTROUTE to 1, the IP layer should not route packets if
> the dest IP address is not in link scope. But if the socket has cached
> the dst_entry, such packets would be routed until the sk_dst_cache
> expires. So we should clean
From: David Ahern
Date: Fri, 7 Dec 2018 12:24:57 -0800
> From: David Ahern
>
> The existing garbage collection algorithm has a number of problems:
...
> This patch addresses these problems as follows:
>
> 1. Use of a separate list_head to track entries that can be garbage
>collected
From: Marek Vasut
Date: Fri, 7 Dec 2018 23:59:58 +0100
> On 12/07/2018 11:24 PM, Andrew Lunn wrote:
>> On Fri, Dec 07, 2018 at 10:51:36PM +0100, Marek Vasut wrote:
>>> Add code to handle optional reset GPIO in the KSZ switch driver. The switch
>>> has a reset GPIO line which can be controlled by
From: Eric Dumazet
Date: Fri, 7 Dec 2018 15:03:04 -0800
> On 12/07/2018 02:24 PM, David Ahern wrote:
>> On 12/7/18 3:20 PM, Eric Dumazet wrote:
>>
>> /* --- cacheline 3 boundary (192 bytes) --- */
>> struct hh_cachehh; /* 19248 */
>>
>> ...
>>
>> but does
Every patch series should have a header posting with Subject of
the form "[PATCH 0/N] ..." explaining what the series does at
a high level, how it does it, and why it does it that way.
From: Igor Russkikh
Date: Fri, 7 Dec 2018 14:00:09 +
> In this patchset few bugs related to RSS are fixed and RSS table and
> hash key configuration is added.
>
> We also do increase max number of HW rings upto 8.
>
> v2: removed extra arg check
Series applied.
From: Shmulik Ladkani
Date: Fri, 7 Dec 2018 09:50:17 +0200
> In 'seg6_output', stack variable 'struct flowi6 fl6' was missing
> initialization.
>
> Fixes: 6c8702c60b88 ("ipv6: sr: add support for SRH encapsulation and
> injection with lwtunnels")
> Signed-off-by: Shmulik Ladkani
Applied and
Looks like your posting was empty?
From: David Ahern
Date: Thu, 6 Dec 2018 14:38:44 -0800
> The existing garbage collection algorithm has a number of problems:
Thanks for working on this!
I totally agree with what you are doing, especially the separate
gc_list.
But why do you need the on_gc_list boolean state? That's
From: Andrew Lunn
Date: Thu, 6 Dec 2018 21:48:46 +0100
> David has already accepted the patchset, so i will add a followup
> patch.
Yeah sorry for jumping the gun, the changes looked pretty
straightforward to me. :-/
From: Petr Machata
Date: Thu, 6 Dec 2018 17:05:35 +
> Drivers may need to validate configuration of a device that's about to
> be upped. An example is mlxsw, which needs to check the configuration of
> a VXLAN device attached to an offloaded bridge. Should the validation
> fail, there's
From: Ido Schimmel
Date: Thu, 6 Dec 2018 17:44:48 +
> Patches #1 and #2 fix two VxLAN related issues. The first patch removes
> warnings that can currently be triggered from user space. Second patch
> avoids leaking a FID in an error path.
>
> Patch #3 fixes a too strict check that causes
From: Pavel Machek
Date: Thu, 6 Dec 2018 14:03:45 +0100
> @@ -79,7 +82,7 @@ static enum dsa_tag_protocol
> mv88e6060_get_tag_protocol(struct dsa_switch *ds,
> {
>//return DSA_TAG_PROTO_QCA;
>//return DSA_TAG_PROTO_TRAILER;
These C++ style comments are not in any of my tree(s).
Your
Plain "printk" are never appropriate.
Please explicitly use pr_warn() or similar. If there is a device context
available, either a generic device or a netdev, use one of the dev_*()
or netdev_*() variants.
From: Pedro Tammela
Date: Thu, 6 Dec 2018 10:45:28 -0200
> 2 goto labels are indented with a tab. remove the tabs and
> keep the code style consistent.
>
> Signed-off-by: Pedro Tammela
Applied to net-next.
From: Andrew Lunn
Date: Thu, 6 Dec 2018 11:36:03 +0100
> DSA makes use of additional headers to direct a frame in/out of a
> specific port of the switch. When the slave interfaces uses an MTU of
> 1500, the master interface can be asked to handle frames with an MTU
> of 1504, or 1508 bytes.
From: Li RongQing
Date: Thu, 6 Dec 2018 16:08:17 +0800
> tun flow entry 'updated' fields are written when receive
> every packet. Thus if a flow is receiving packets from a
> particular flow entry, it'll cause false-sharing with
> all the other who has looked it up, so move it in its own
>
From: Li RongQing
Date: Thu, 6 Dec 2018 16:28:11 +0800
> caller has guaranted that rxhash is not zero
>
> Signed-off-by: Li RongQing
Applied.
From: Jouke Witteveen
Date: Thu, 6 Dec 2018 09:59:20 +0100
> On Thu, Dec 6, 2018 at 1:34 AM David Miller wrote:
>>
>> From: Jouke Witteveen
>> Date: Wed, 5 Dec 2018 23:38:17 +0100
>>
>> > Can you elaborate a bit? I may not be aware of the policy you have in
From: Jakub Audykowicz
Date: Thu, 6 Dec 2018 08:58:37 +0100
> My previous patch introduced a compilation warning regarding a type
> mismatch (int vs size_t). This is a one-letter fix for good housekeeping.
>
> Signed-off-by: Jakub Audykowicz
Still wrong and I fixed it when I applied your
From: David Ahern
Date: Wed, 5 Dec 2018 20:02:29 -0800
> From: David Ahern
>
> Add extack messages for failures in neigh_add and neigh_delete.
>
> Signed-off-by: David Ahern
Looks good, applied, thanks David.
From: Jiri Wiesner
Date: Wed, 5 Dec 2018 16:55:29 +0100
> The *_frag_reasm() functions are susceptible to miscalculating the byte
> count of packet fragments in case the truesize of a head buffer changes.
> The truesize member may be changed by the call to skb_unclone(), leaving
> the fragment
From: Xin Long
Date: Wed, 5 Dec 2018 14:49:40 +0800
> This patch is to separate the base data memory from struct flex_array and
> save it into a page. With this change, total_nr_elements of a flex_array
> can grow or shrink without having the old element's memory changed when
> the new size of
From: Peter Oskolkov
Date: Tue, 4 Dec 2018 11:55:56 -0800
> When testing high-bandwidth TCP streams with large windows,
> high latency, and low jitter, netem consumes a lot of CPU cycles
> doing rbtree rebalancing.
>
> This patch uses a linear list/queue in addition to the rbtree:
> if an
From: Jakub Audykowicz
Date: Tue, 4 Dec 2018 20:27:41 +0100
> If for some reason an association's fragmentation point is zero,
> sctp_datamsg_from_user will try to endlessly try to divide a message
> into zero-sized chunks. This eventually causes kernel panic due to
> running out of memory.
>
From: David Ahern
Date: Wed, 5 Dec 2018 17:46:37 -0700
> ok. patches 5-7 are not dependent on 1-4. Should I re-send outside of
> this set?
Yes, please respin.
Thanks David.
From: Saeed Mahameed
Date: Wed, 5 Dec 2018 16:12:58 -0800
> The following series is for mlx5e netdevice driver, it adds ethtool
> support for RX hash fields configuration and some misc updates, please
> see tag log below.
>
> Please pull and let me know if there's any problem.
>
> v1->v2:
>
From: David Ahern
Date: Wed, 5 Dec 2018 15:34:09 -0800
> @@ -270,37 +270,25 @@ static inline bool neigh_key_eq128(const struct
> neighbour *n, const void *pkey)
> (n32[2] ^ p32[2]) | (n32[3] ^ p32[3])) == 0;
> }
>
> -static inline struct neighbour *___neigh_lookup_noref(
> -
From: Yuchung Cheng
Date: Wed, 5 Dec 2018 14:38:38 -0800
> TCP loss probe timer may fire when the retranmission queue is empty but
> has a non-zero tp->packets_out counter. tcp_send_loss_probe will call
> tcp_rearm_rto which triggers NULL pointer reference by fetching the
> retranmission queue
From: Jouke Witteveen
Date: Wed, 5 Dec 2018 23:38:17 +0100
> Can you elaborate a bit? I may not be aware of the policy you have in
> mind.
When we have a user facing interface to do something, we don't create
another one unless it is absolutely, positively, unavoidable.
From: Eric Dumazet
Date: Wed, 5 Dec 2018 14:24:31 -0800
> If available rwnd is too small, tcp_tso_should_defer()
> can decide it is worth waiting before splitting a TSO packet.
>
> This really means we are rwnd limited.
>
> Fixes: 5615f88614a4 ("tcp: instrument how long TCP is limited by
From: Alexei Starovoitov
Date: Wed, 5 Dec 2018 13:23:22 -0800
> The following pull-request contains BPF updates for your *net* tree.
>
> The main changes are:
>
> 1) fix bpf uapi pointers for 32-bit architectures, from Daniel.
>
> 2) improve verifer ability to handle progs with a lot of
From: Andrew Lunn
Date: Wed, 5 Dec 2018 21:49:39 +0100
> This patchset fixes issues found in the last patchset which converted
> the phydev advertise etc, from a u32 to a linux bitmap. Most of the
> issues are the result of clearing bits which should not of been
> cleared. To make the API
From: Edward Cree
Date: Tue, 4 Dec 2018 17:37:57 +
> list_del() leaves the skb->next pointer poisoned, which can then lead to
> a crash in e.g. OVS forwarding. For example, setting up an OVS VXLAN
> forwarding bridge on sfc as per:
...
> So, in all listified-receive handling, instead
From: Matteo Croce
Date: Tue, 4 Dec 2018 18:05:42 +0100
> Following commit 59f997b088d2 ("macvlan: return correct error value"),
> there is a duplicate check for mac addresses both in macvlan_sync_address()
> and macvlan_set_mac_address().
> As the former calls the latter, remove the one in
From: Anssi Hannula
Date: Fri, 30 Nov 2018 20:21:34 +0200
> Here are a couple of race condition fixes for the macb driver. The first
> two are issues observed on real HW.
It looks like there is still an active discussion about the memory
barriers in patch #3 being excessive.
Once that is
From: Anssi Hannula
Date: Fri, 30 Nov 2018 20:21:35 +0200
> @@ -682,6 +682,11 @@ static void macb_set_addr(struct macb *bp, struct
> macb_dma_desc *desc, dma_addr_
> if (bp->hw_dma_cap & HW_DMA_CAP_64B) {
> desc_64 = macb_64b_desc(bp, desc);
> desc_64->addrh =
From: Jouke Witteveen
Date: Wed, 5 Dec 2018 14:50:31 +0100
> For example, I maintain a network manager that delegates the actual
> networking work to specialized programs.
Basically "I've implemented things using separate programs"
> Basically, it is an implementation of network manager logic
From: Jiong Wang
Date: Wed, 05 Dec 2018 11:28:32 +
> Indeed. Doubled checked the ISA doc,"Bit 32 of RS is replicated to fill
> RA0:31.".
>
> Will fix both places in v2.
See, sparc64 isn't so weird :-)
generates
> an [E]POLLOUT event for every incoming ACK packet.
>
> This causes a high number of context switches.
>
> This patch implements the strategy David Miller added
> in sock_def_write_space() :
>
> - If TCP socket has a notsent_lowat constraint of X bytes,
>al
From: Baruch Siach
Date: Tue, 4 Dec 2018 16:03:53 +0200
> The .validate phylink callback should empty the supported bitmap when
> the interface mode is invalid.
>
> Cc: Maxime Chevallier
> Cc: Antoine Tenart
> Reported-by: Russell King
> Signed-off-by: Baruch Siach
Applied.
From: Baruch Siach
Date: Tue, 4 Dec 2018 16:03:52 +0200
> The mvpp2_phylink_validate() relies on the interface field of
> phylink_link_state to determine valid link modes. However, when called
> from phylink_sfp_module_insert() this field in not initialized. The
> default switch case then
From: Felix Jia
Date: Mon, 3 Dec 2018 16:39:31 +1300
> +int
> +ip6_get_addrport(struct iphdr *iph, __be32 *saddr4, __be32 *daddr4,
> + __be16 *sport4, __be16 *dport4, __u8 *proto, int *icmperr)
> +{
This looks like something the flow dissector can do alreayd, please look into
From: Or Gerlitz
Date: Sun, 2 Dec 2018 14:55:19 +0200
> This short series from Adi Nissim allows to support key-less tunnels
> by the tc tunnel key actions, which is needed for some GRE use-cases.
>
> changes from V0:
> - addresses build warning spotted by kbuild, make sure to always init
>
From: Jouke Witteveen
Date: Sat, 1 Dec 2018 17:00:21 +0100
> Make it easy for userspace to respond to acquisition/loss of carrier.
> The uevent is picked up by udev and, on systems with systemd, the
> device unit of the interface announces a configuration reload.
>
> Signed-off-by: Jouke
From: Eric Dumazet
Date: Tue, 4 Dec 2018 09:40:35 -0800
> kmsan was able to trigger a kernel-infoleak using a gre device [1]
>
> nlmsg_populate_fdb_fill() has a hard coded assumption
> that dev->addr_len is ETH_ALEN, as normally guaranteed
> for ARPHRD_ETHER devices.
>
> A similar issue was
From: Nikolay Aleksandrov
Date: Wed, 5 Dec 2018 01:45:16 +0200
> On a related note I saw Paul's call_rcu patches hit, so I'll wait for those
> to go in and will rebase on top of them before sending the v3 as the bridge
> change will have a conflict with this set.
They aren't going in via my
From: Alexei Starovoitov
Date: Tue, 4 Dec 2018 12:16:04 -0800
> You already did :)
Amazing, I'll take the rest of the day off, thanks! :)
From: Jiong Wang
Date: Tue, 4 Dec 2018 20:14:11 +
> On 04/12/2018 20:10, David Miller wrote:
>> From: Alexei Starovoitov
>> Date: Tue, 4 Dec 2018 11:29:55 -0800
>>
>>> I guess sparc doesn't really have 32 subregisters. All registers
>>> are conside
From: Alexei Starovoitov
Date: Tue, 4 Dec 2018 11:29:55 -0800
> I guess sparc doesn't really have 32 subregisters. All registers
> are considered 64-bit. It has 32-bit alu ops on 64-bit registers
> instead.
Right.
Anyways, sparc will require two instructions because of this, the
'sra' then a
From: Peter Oskolkov
Date: Tue, 4 Dec 2018 11:10:55 -0800
> Thanks, Stephen!
>
> I don't care much about braces either. David, do you want me to send a
> new patch with braces moved around?
Single statement basic blocks definitely must not have curly braces,
please remove them and repost.
From: Paolo Abeni
Date: Tue, 04 Dec 2018 12:27:51 +0100
> On Mon, 2018-12-03 at 10:04 -0800, Eric Dumazet wrote:
>> On 12/03/2018 03:40 AM, Paolo Abeni wrote:
>> > This header define a bunch of helpers that allow avoiding the
>> > retpoline overhead when calling builtin functions via function
From: Jiong Wang
Date: Tue, 4 Dec 2018 04:56:29 -0500
> This patch implements interpreting BPF_ALU | BPF_ARSH. Do arithmetic right
> shift on low 32-bit sub-register, and zero the high 32 bits.
>
> Reviewed-by: Jakub Kicinski
> Signed-off-by: Jiong Wang
I just want to say that this behavior
From: Ido Schimmel
Date: Tue, 4 Dec 2018 08:15:09 +
> Up until now, when a packet was routed by the ASIC through the same
> router interface (RIF) from which it ingressed from, the ASIC passed the
> sole copy of the packet to the kernel. This allowed the kernel to route
> the packet and also
From: David Ahern
Date: Mon, 3 Dec 2018 17:15:03 -0700
> So, instead of a program tag which the program writer controls, how
> about some config knob that an admin controls that says at attach time
> use standard stats?
How about, instead of replacing it is in addition to, and admin can
From: Tariq Toukan
Date: Sun, 2 Dec 2018 17:40:24 +0200
> This patchset by Erez contains cleanups to the mlx4_core driver.
>
> Patch 1 replaces -EINVAL with -EOPNOTSUPP for unsupported operations.
> Patch 2 fixes some coding style issues.
>
> Series generated against net-next commit:
>
From: Jose Abreu
Date: Sun, 2 Dec 2018 16:33:14 +0100
> Logic of phy_device_create() requests PHY modules according to PHY ID
> but for C45 PHYs we use different field for the IDs.
>
> Let's also request the modules for these IDs.
>
> Changes from v1:
> - Only request C22 modules if C45 are
From: Jerin Jacob
Date: Sun, 2 Dec 2018 18:17:35 +0530
> This patchset is a continuation to earlier submitted four patch
> series to add a new driver for Marvell's OcteonTX2 SOC's
> Resource virtualization unit (RVU) admin function driver.
>
> 1. octeontx2-af: Add RVU Admin Function driver
>
From: Tariq Toukan
Date: Sun, 2 Dec 2018 14:34:35 +0200
> This patchset includes small fixes for the mlx4_en driver.
>
> First patch by Eran fixes the value used to init the netdevice's
> min_mtu field.
> Please queue it to -stable >= v4.10.
>
> Second patch by Saeed adds missing Kconfig
From: Matteo Croce
Date: Sat, 1 Dec 2018 00:26:27 +0100
> A MAC address must be unique among all the macvlan devices with the same
> lower device. The only exception is the passthru [sic] mode,
> which shares the lower device address.
>
> When duplicate addresses are detected, EBUSY is
From: Toke Høiland-Jørgensen
Date: Mon, 03 Dec 2018 22:00:32 +0200
> I wonder if it would be possible to support both the "give me user
> normal stats" case and the "let me do whatever I want" case by a
> combination of userspace tooling and maybe a helper or two?
>
> I.e., create a
From: Willem de Bruijn
Date: Fri, 30 Nov 2018 15:32:38 -0500
> Enable MSG_ZEROCOPY for udp sockets
Series applied, thanks for keeping up with this.
From:
Date: Mon, 3 Dec 2018 08:26:52 +
> Can you please delay a bit the acceptance of this series, I would like
> that we assess these findings with tests on our hardware before applying
> them.
Sure.
From: Xin Long
Date: Sat, 1 Dec 2018 01:36:59 +0800
> In sctp_hash_transport/sctp_epaddr_lookup_transport, it dereferences
> a transport's asoc under rcu_read_lock while asoc is freed not after
> a grace period, which leads to a use-after-free panic.
>
> This patch fixes it by calling
From: Thomas Falcon
Date: Fri, 30 Nov 2018 10:59:08 -0600
> Commit a5681e20b541 ("net/ibmnvic: Fix deadlock problem
> in reset") made the change to hold the RTNL lock during
> driver reset but still calls netdev_notify_peers, which
> results in a deadlock. Instead, use call_netdevice_notifiers,
From: Ido Schimmel
Date: Fri, 30 Nov 2018 19:00:24 +0200
> Yes, agree. Patch is good. I'll tag your v2.
This means, I assume, that a new version of this fix is coming.
Eric, is this correct?
From: Cong Wang
Date: Tue, 27 Nov 2018 22:10:13 -0800
> When an ethernet frame is padded to meet the minimum ethernet frame
> size, the padding octets are not covered by the hardware checksum.
> Fortunately the padding octets are ususally zero's, which don't affect
> checksum. However, we have a
From: Heiner Kallweit
Date: Tue, 27 Nov 2018 22:30:14 +0100
> So far the two functions consider neither member eee_enabled nor
> eee_active. Therefore network drivers have to do this in some kind
> of glue code. I think this can be avoided.
>
> Getting EEE parameters:
> When not advertising any
From: Alexis Bauvin
Date: Mon, 3 Dec 2018 10:54:37 +0100
> We are trying to isolate the VXLAN traffic from different VMs with VRF as
> shown
> in the schemas below:
...a
> We faced some issue in the datapath, here are the details:
>
> * Egress traffic:
> The vxlan packets are sent directly
From: Prashant Bhole
Date: Mon, 3 Dec 2018 18:09:24 +0900
> In tun.c skb->len was accessed while doing stats accounting after a
> call to netif_receive_skb. We can not access skb after this call
> because buffers may be dropped.
>
> The fix for this bug would be to store skb->len in local
From: Ido Schimmel
Date: Mon, 3 Dec 2018 07:58:57 +
> Shalom says:
>
> Currently, drivers do not have the ability to control the firmware
> loading policy and they always use their own fixed policy. This prevents
> drivers from running the device with a different firmware version for
>
From: Heiner Kallweit
Date: Mon, 3 Dec 2018 08:19:33 +0100
> Currently __set_phy_supported allows to add modes w/o checking whether
> the PHY supports them. This is wrong, it should never add modes but
> only remove modes we don't want to support.
>
> The commit marked as fixed didn't do
From: Heiner Kallweit
Date: Mon, 3 Dec 2018 08:04:57 +0100
> Currently __set_phy_supported allows to add modes w/o checking whether
> the PHY supports them. This is wrong, it should never add modes but
> only remove modes we don't want to support.
>
> Signed-off-by: Heiner Kallweit
Applied.
From: David Ahern
Date: Mon, 3 Dec 2018 08:56:28 -0700
> I do not want Linux + XDP to require custom anything to debug basic
> functionality - such as isolating a packet drop to a specific point.
Definitely we need to let people choose to arrange things that way
if they want to do so. It is
From: David Ahern
Date: Mon, 3 Dec 2018 08:45:12 -0700
> On 12/1/18 4:22 AM, Jesper Dangaard Brouer wrote:
>> IMHO XDP_DROP should not be accounted as netdev stats drops, this is a
>> user installed program like tc/iptables, that can also choose to drop
>> packets.
>
> sure and both tc and
Tweaking some things on vger, please just ignore.
From: Jerin Jacob
Date: Sat, 1 Dec 2018 14:43:54 +0530
> @@ -987,6 +997,76 @@ static void nix_reset_tx_linkcfg(struct rvu *rvu, int
> blkaddr,
> NIX_AF_TL3_TL2X_LINKX_CFG(schq, link), 0x00);
> }
>
> +static int
> +rvu_get_tl1_schqs(struct rvu *rvu,
> +
From: Jerin Jacob
Date: Sat, 1 Dec 2018 14:43:51 +0530
> +#define FLOW_KEY_TYPE_PORT BIT(0)
> +#define FLOW_KEY_TYPE_IPV4 BIT(1)
> +#define FLOW_KEY_TYPE_IPV6 BIT(2)
> +#define FLOW_KEY_TYPE_TCPBIT(3)
> +#define FLOW_KEY_TYPE_UDPBIT(4)
> +#define FLOW_KEY_TYPE_SCTP BIT(5)
This
Stephen please actually read the reports your forward here.
This is a report about arch/x86/lib/inat.c which is a set of CPU
instruction attributes and has nothing to do with networkig.
From: Alexei Starovoitov
Date: Fri, 30 Nov 2018 21:55:02 -0800
> The patch 2 didn't apply as-is to bpf-next, since I applied your
> earlier fix "bpf: Fix verifier log string check for bad alignment"
> to bpf tree. So I applied that fix to bpf-next as well and then
> pushed your series on top.
If a testcase has alignment problems but is expected to be ACCEPT,
verify it using F_NEEDS_EFFICIENT_UNALIGNED_ACCESS too.
Maybe in the future if we add some architecture specific code to elide
the unaligned memory access warnings during the test, we can execute
these as well.
Signed-off-by:
Use F_NEEDS_EFFICIENT_UNALIGNED_ACCESS in more tests where the
expected result is REJECT.
Signed-off-by: David S. Miller
---
tools/testing/selftests/bpf/test_verifier.c | 44 +
1 file changed, 44 insertions(+)
diff --git
Make it set the flag argument to bpf_verify_program() which will relax
the alignment restrictions.
Now all such test cases will go properly through the verifier even on
inefficient unaligned access architectures.
On inefficient unaligned access architectures do not try to run such
programs,
On sparc64 a ton of test cases in test_verifier.c fail because
the memory accesses in the test case are unaligned (or cannot
be proven to be aligned by the verifier).
Perhaps we can eventually try to (carefully) modify each test case
which has this problem to not use unaligned accesses but:
1)
Often we want to write tests cases that check things like bad context
offset accesses. And one way to do this is to use an odd offset on,
for example, a 32-bit load.
This unfortunately triggers the alignment checks first on platforms
that do not set CONFIG_EFFICIENT_UNALIGNED_ACCESS. So the
From: Alexei Starovoitov
Date: Fri, 30 Nov 2018 13:58:20 -0800
> On Thu, Nov 29, 2018 at 07:32:41PM -0800, David Miller wrote:
>> diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h
>> index 426b5c8..c9647ea 100644
>> --- a/include/uapi/linux/bpf.h
>> +++
From: Nicolas Dichtel
Date: Thu, 29 Nov 2018 14:45:39 +0100
> It's not supported right now (the goal of the initial patch was to support
> 'ip link del' only).
>
> Before the patch:
> $ ip link add foo type tun
> [ 239.632660] BUG: unable to handle kernel NULL pointer dereference at
>
From: YueHaibing
Date: Thu, 29 Nov 2018 02:36:32 +
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c: In function
> 'rmnet_map_do_flow_control':
> drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c:23:36: warning:
> variable
From: Yuchung Cheng
Date: Wed, 28 Nov 2018 16:06:42 -0800
> This patch set has assorted fixes of minor accounting issues in
> timeout, window probe, and retransmission stats.
Looks good, series applied.
1 - 100 of 25771 matches
Mail list logo
