Re: [PATCH] net: cavium: Add fine-granular dependencies on PCI

2018-07-18 Thread David Miller
From: Alexander Sverdlin Date: Tue, 17 Jul 2018 18:23:58 +0200 > Add dependencies on PCI where necessary. > > Fixes: 7e2bc7fb65 ("net: cavium: Drop dependency of NET_VENDOR_CAVIUM on PCI") > Signed-off-by: Alexander Sverdlin Applied, thank you.

Re: [PATCH net-next 1/1] tc-tests: initial version of fw filter unit tests

2018-07-18 Thread David Miller
From: Keara Leibovitz Date: Tue, 17 Jul 2018 12:12:54 -0400 > Create initial unit tests for the tc fw filter. > > Signed-off-by: Keara Leibovitz Applied, thank you.

Re: [PATCH v3 net-next 6/8] lan743x: Add power management support

2018-07-18 Thread David Miller
From: David Miller Date: Thu, 19 Jul 2018 07:15:52 +0900 (KST) > Please remove these "#endif FOO, #ifdef FOO" sequences, and instead just have > one large continuous "ifdef FOO, endif FOO" section. BTW, there were other patches that had this problem too, so ple

Re: [PATCH v3 net-next 6/8] lan743x: Add power management support

2018-07-18 Thread David Miller
From: Bryan Whitehead Date: Wed, 18 Jul 2018 17:04:36 -0400 > +#ifdef CONFIG_PM > +static void lan743x_ethtool_get_wol(struct net_device *netdev, > + struct ethtool_wolinfo *wol) > +{ > + struct lan743x_adapter *adapter = netdev_priv(netdev); > + > +

Re: [PATCH v2 net-next 0/8] PTP support for mv88e6165 family

2018-07-18 Thread David Miller
From: Andrew Lunn Date: Wed, 18 Jul 2018 22:38:19 +0200 > The mv88e6165 family of switches supports PTP. It is however not fully > compatible with the current PTP support in the mv88e6xxx driver. This > patchset adds a level of abstraction to the PTP code, and then adds > the code needed to

Re: [PATCH net-next 0/3] net: Drop OF dependency for some Broadcom drivers

2018-07-18 Thread David Miller
From: Florian Fainelli Date: Tue, 17 Jul 2018 08:42:03 -0700 > This patch series drops the CONFIG_OF dependency that some Broadcom drivers > had, this is no longer necessary and goes against allowing build testing > on more platforms. > > Let me know if kbuild or your own builds somehow fail.

Re: [PATCH v2 net] net/ipv6: Do not allow device only routes via the multipath API

2018-07-18 Thread David Miller
From: David Ahern Date: Tue, 17 Jul 2018 06:13:43 -0600 > On 7/16/18 3:09 PM, David Miller wrote: >> >> Is this a -stable candidate? >> > > I think so. The API is not doing what the user requested, even though > the route add does not fail. Ok, queued up, thanks.

Re: [PATCH net-next v2] net: Move skb decrypted field, avoid explicity copy

2018-07-18 Thread David Miller
From: Stefano Brivio Date: Tue, 17 Jul 2018 11:52:57 +0200 > Commit 784abe24c903 ("net: Add decrypted field to skb") > introduced a 'decrypted' field that is explicitly copied on skb > copy and clone. > > Move it between headers_start[0] and headers_end[0], so that we > don't need to copy it

Re: [PATCH net-next] xdp: fix uninitialized 'err' variable

2018-07-18 Thread David Miller
From: Jakub Kicinski Date: Mon, 16 Jul 2018 19:08:50 -0700 > Smatch caught an uninitialized variable error which GCC seems > to miss. > > Fixes: a25717d2b604 ("xdp: support simultaneous driver and hw XDP attachment") > Signed-off-by: Jakub Kicinski Applied.

Re: [net-next v2 1/5] net/tls: Do not enable zero-copy prematurely

2018-07-18 Thread David Miller
From: Vakul Garg Date: Mon, 16 Jul 2018 21:27:11 +0530 > Zero-copy mode was left enabled even when zerocopy_from_iter() failed. > Set the zero-copy mode only when zerocopy_from_iter() succeeds. This > leads to removal of argument 'zc' of function decrypt_skb_update(). > Function

Re: [PATCH next v2] bonding: pass link-local packets to bonding master also.

2018-07-18 Thread David Miller
From: Mahesh Bandewar Date: Wed, 18 Jul 2018 12:55:42 -0700 > From: Mahesh Bandewar > > Commit b89f04c61efe ("bonding: deliver link-local packets with > skb->dev set to link that packets arrived on") changed the behavior > of how link-local-multicast packets are processed. The change in > the

Re: [RFC PATCH 3/3] net: macb: add support for padding and fcs computation

2018-07-18 Thread David Miller
From: Claudiu Beznea Date: Wed, 18 Jul 2018 15:58:09 +0300 > > +static int macb_pad_and_fcs(struct sk_buff **skb, struct net_device *ndev) > +{ > + struct sk_buff *nskb; > + int padlen = ETH_ZLEN - (*skb)->len; > + int headroom = skb_headroom(*skb); > + int tailroom =

Re: [PATCH net-next] cxgb4: display number of rx and tx pages free

2018-07-18 Thread David Miller
From: Ganesh Goudar Date: Wed, 18 Jul 2018 17:36:12 +0530 > display free rx and tx page count in the meminfo of > an adapter. > > Signed-off-by: Casey Leedom > Signed-off-by: Ganesh Goudar Applied.

Re: [PATCH net-next 00/16] mlxsw: Introduce initial Spectrum-2 support

2018-07-18 Thread David Miller
From: Ido Schimmel Date: Wed, 18 Jul 2018 11:14:29 +0300 > This patch set adds initial support for the Spectrum-2 ASIC. The first > two patches add Spectrum-2 specific KVD linear (KVDL) manager. Unlike > the Spectrum ASIC, there is no linear memory and instead the type of the > entry (e.g.,

Re: [PATCH v3 net-next 0/3] rds: IPv6 support

2018-07-18 Thread David Miller
From: Sowmini Varadhan Date: Wed, 18 Jul 2018 03:33:40 -0700 > On (07/18/18 15:19), Ka-Cheong Poon wrote: >> >bind() and connect() are using the sa_family/ss_family to have >> >the application signal to the kernel about whether ipv4 or ipv6 is >> >desired. (and bind and connect are doing the

Re: [PATCH] octeon_mgmt: Fix MIX registers configuration on MTU setup

2018-07-17 Thread David Miller
From: Alexander Sverdlin Date: Fri, 13 Jul 2018 17:31:50 +0200 > From: Alexander Sverdlin > > octeon_mgmt driver doesn't drop RX frames that are 1-4 bytes bigger than > MTU set for the corresponding interface. The problem is in the > AGL_GMX_RX0/1_FRM_MAX register setting, which should not

Re: [PATCH net-next] r8169: power down chip in probe

2018-07-17 Thread David Miller
From: Heiner Kallweit Date: Tue, 17 Jul 2018 21:21:37 +0200 > The removed code would be called in two situations: > 1. interface is brought up never or >10s after driver load > 2. after close() > > Case 1 we can handle cleaner by ensuring chip is powered down when > leaving probe(). open()

Re: [PATCH net-next 1/7] net: dsa: bcm_sf2: Allow targeting CPU ports for CFP rules

2018-07-17 Thread David Miller
From: Florian Fainelli Date: Tue, 17 Jul 2018 08:36:39 -0700 > @@ -755,7 +755,8 @@ static int bcm_sf2_cfp_rule_set(struct dsa_switch *ds, > int port, > port_num = fs->ring_cookie / SF2_NUM_EGRESS_QUEUES; > > if (fs->ring_cookie == RX_CLS_FLOW_DISC || > -

Re: [PATCH net-next v3 00/10] r8169: add phylib support

2018-07-17 Thread David Miller
From: Heiner Kallweit Date: Tue, 17 Jul 2018 22:42:40 +0200 > Now that all the basic refactoring has been done we can add phylib > support. This patch series was successfully tested on: > RTL8168h > RTL8168evl > RTL8169sb > > Changes in v2: > - return error in mdio ops if phyaddr > 0 > -

Re: [PATCH net-next 1/8] net: dsa: mv88e6xxx: Abstract PTP operations

2018-07-17 Thread David Miller
From: Andrew Lunn Date: Tue, 17 Jul 2018 23:48:53 +0200 > @@ -319,6 +337,8 @@ int mv88e6xxx_ptp_setup(struct mv88e6xxx_chip *chip) > { > int i; > > + const struct mv88e6xxx_ptp_ops *ptp_ops = chip->info->ops->ptp_ops; > + Please keep the local variables together here. Otherwise,

Re: [PATCH net-next] liquidio: correct error msg text when removing VLAN ID

2018-07-16 Thread David Miller
From: Felix Manlunas Date: Mon, 16 Jul 2018 18:06:07 -0700 > From: Rick Farrington > > Signed-off-by: Rick Farrington > Signed-off-by: Felix Manlunas Applied.

Re: [PATCH][net-next][v2] net: convert gro_count to bitmask

2018-07-16 Thread David Miller
From: Eric Dumazet Date: Mon, 16 Jul 2018 16:40:52 -0700 > I guess we could either use BITS_PER_LONG or : > > diff --git a/net/core/dev.c b/net/core/dev.c > index > c883b17ee0fe2c8a7ca2f2867560ba74004790a7..4f8b92d81d107fc9acd2499297435cbd9e9b5c67 > 100644 > --- a/net/core/dev.c > +++

Re: [PATCH net-next] cxgb4: collect ASIC LA dumps from ULP TX

2018-07-16 Thread David Miller
From: Rahul Lakkireddy Date: Mon, 16 Jul 2018 19:40:54 +0530 > From: Surendra Mobiya > > Signed-off-by: Surendra Mobiya > Signed-off-by: Rahul Lakkireddy > Signed-off-by: Ganesh Goudar Applied, thank you.

Re: [PATCH net 0/2] tg3: Update copyright and fix for tx timeout with 5762

2018-07-16 Thread David Miller
From: Siva Reddy Kallam Date: Mon, 16 Jul 2018 11:13:30 +0530 > From: Siva Reddy Kallam > > First patch: > Update copyright > > Second patch: > Add higher cpu clock for 5762 Series applied, thank you.

Re: [PATCH net] ibmvnic: Fix error recovery on login failure

2018-07-16 Thread David Miller
From: John Allen Date: Mon, 16 Jul 2018 10:29:30 -0500 > Testing has uncovered a failure case that is not handled properly. In the > event that a login fails and we are not able to recover on the spot, we > return 0 from do_reset, preventing any error recovery code from being > triggered.

Re: [PATCH v2 net] net/ipv6: Do not allow device only routes via the multipath API

2018-07-16 Thread David Miller
From: dsah...@kernel.org Date: Sun, 15 Jul 2018 09:35:19 -0700 > From: David Ahern > > Eric reported that reverting the patch that fixed and simplified IPv6 > multipath routes means reverting back to invalid userspace notifications. > eg., > $ ip -6 route add 2001:db8:1::/64 nexthop dev eth0

Re: [PATCH net] net/mlx4_en: Don't reuse RX page when XDP is set

2018-07-16 Thread David Miller
From: Tariq Toukan Date: Sun, 15 Jul 2018 13:54:39 +0300 > From: Saeed Mahameed > > When a new rx packet arrives, the rx path will decide whether to reuse > the remainder of the page or not according to one of the below conditions: > 1. frag_info->frag_stride == PAGE_SIZE / 2 > 2.

Re: [PATCH net-next] mlxsw: spectrum: Expose counters for various packet sizes

2018-07-16 Thread David Miller
From: Ido Schimmel Date: Sun, 15 Jul 2018 10:45:42 +0300 > From: Jiri Pirko > > Expose counters ASIC has in the group of RFC 2819 counters that count > number of packets within specific size range. > > Signed-off-by: Jiri Pirko > Signed-off-by: Ido Schimmel Applied.

Re: [PATCH net-next] liquidio: fix hang when re-binding VF host drv after running DPDK VF driver

2018-07-16 Thread David Miller
From: Felix Manlunas Date: Fri, 13 Jul 2018 12:50:21 -0700 > From: Rick Farrington > > When configuring SLI_PKTn_OUTPUT_CONTROL, VF driver was assuming that IPTR > mode was disabled by reset, which was not true. Since DPDK driver had > set IPTR mode previously, the VF driver (which uses

Re: [PATCH net] hv/netvsc: fix handling of fallback to single queue mode

2018-07-16 Thread David Miller
From: Stephen Hemminger Date: Fri, 13 Jul 2018 10:38:38 -0700 > The netvsc device may need to fallback to running in single queue > mode if host side only wants to support single queue. > > Recent change for handling mtu broke this in setup logic. > > Reported-by: Dan Carpenter > Fixes:

Re: [PATCH net] ibmvnic: Revise RX/TX queue error messages

2018-07-16 Thread David Miller
From: Thomas Falcon Date: Fri, 13 Jul 2018 12:03:32 -0500 > During a device failover, there may be latency between the loss > of the current backing device and a notification from firmware that > a failover has occurred. This latency can result in a large amount of > error printouts as firmware

Re: [PATCH net] ipv6: make DAD fail with enhanced DAD when nonce length differs

2018-07-16 Thread David Miller
From: Sabrina Dubroca Date: Fri, 13 Jul 2018 17:21:42 +0200 > Commit adc176c54722 ("ipv6 addrconf: Implemented enhanced DAD (RFC7527)") > added enhanced DAD with a nonce length of 6 bytes. However, RFC7527 > doesn't specify the length of the nonce, other than being 6 + 8*k bytes, > with integer

Re: [PATCH] net: cavium: Drop dependency of NET_VENDOR_CAVIUM on PCI

2018-07-16 Thread David Miller
From: Alexander Sverdlin Date: Fri, 13 Jul 2018 17:04:28 +0200 > Octeon Ethernet drivers work perfectly without PCI. > > Signed-off-by: Alexander Sverdlin Applied.

Re: [PATCH net-next] cxgb4: do not return DUPLEX_UNKNOWN when link is down

2018-07-16 Thread David Miller
From: Ganesh Goudar Date: Fri, 13 Jul 2018 17:56:55 +0530 > We were returning DUPLEX_UNKNOWN in get_link_ksettings() when > the link was down. Unfortunately, this causes a problem when > "ethtool -s autoneg on" is issued for a link which is down because > the ethtool code first reads the

Re: [PATCH][net-next][v2] net: convert gro_count to bitmask

2018-07-16 Thread David Miller
From: Li RongQing Date: Fri, 13 Jul 2018 14:41:36 +0800 > gro_hash size is 192 bytes, and uses 3 cache lines, if there is few > flows, gro_hash may be not fully used, so it is unnecessary to iterate > all gro_hash in napi_gro_flush(), to occupy unnecessary cacheline. > > convert gro_count to a

Re: [PATCH net-next] net: ip6_gre: get ipv6hdr after skb_cow_head()

2018-07-16 Thread David Miller
From: Prashant Bhole Date: Fri, 13 Jul 2018 14:40:50 +0900 > A KASAN:use-after-free bug was found related to ip6-erspan > while running selftests/net/ip6_gre_headroom.sh > > It happens because of following sequence: > - ipv6hdr pointer is obtained from skb > - skb_cow_head() is called,

Re: [PATCH net] tun: Fix use-after-free on XDP_TX

2018-07-16 Thread David Miller
From: Toshiaki Makita Date: Fri, 13 Jul 2018 13:24:38 +0900 > On XDP_TX we need to free up the frame only when tun_xdp_tx() returns a > negative value. A positive value indicates that the packet is > successfully enqueued to the ptr_ring, so freeing the page causes > use-after-free. > > Fixes:

Re: [PATCH] liquidio: Use %pad printk format for dma_addr_t values

2018-07-16 Thread David Miller
From: Helge Deller Date: Thu, 12 Jul 2018 22:36:29 +0200 > Use the existing %pad printk format to print dma_addr_t values. > This avoids the following warnings when compiling on the parisc platform: > > warning: format '%llx' expects argument of type 'long long unsigned int', but > argument 2

Re: [PATCH net-next] net: phy: realtek: add missing entry for RTL8211C to mdio_device_id table

2018-07-16 Thread David Miller
From: Heiner Kallweit Date: Thu, 12 Jul 2018 21:45:08 +0200 > Add missing entry for RTL8211C to mdio_device_id table. > > Signed-off-by: Heiner Kallweit > Fixes: cf87915cb9f8 ("net: phy: realtek: add support for RTL8211C") Applied.

Re: [PATCH net-next v2 0/2] net: phy: add functionality to speed down PHY when waiting for WoL packet

2018-07-16 Thread David Miller
From: Heiner Kallweit Date: Thu, 12 Jul 2018 21:30:19 +0200 > Some network drivers include functionality to speed down the PHY when > suspending and just waiting for a WoL packet because this saves energy. > > This patch is based on our recent discussion about factoring out this > functionality

Re: [PATCH net-next] selftests: tls: add selftests for TLS sockets

2018-07-16 Thread David Miller
From: Dave Watson Date: Thu, 12 Jul 2018 10:59:20 -0700 > Add selftests for tls socket. Tests various iov and message options, > poll blocking and nonblocking behavior, partial message sends / receives, > and control message data. Tests should pass regardless of if TLS > is enabled in the

Re: [PATCH net] tls: Stricter error checking in zerocopy sendmsg path

2018-07-16 Thread David Miller
From: Dave Watson Date: Thu, 12 Jul 2018 08:03:43 -0700 > In the zerocopy sendmsg() path, there are error checks to revert > the zerocopy if we get any error code. syzkaller has discovered > that tls_push_record can return -ECONNRESET, which is fatal, and > happens after the point at which it

Re: [PATCH net v2] KEYS: DNS: fix parsing multiple options

2018-07-16 Thread David Miller
From: Eric Biggers Date: Wed, 11 Jul 2018 10:46:29 -0700 > From: Eric Biggers > > My recent fix for dns_resolver_preparse() printing very long strings was > incomplete, as shown by syzbot which still managed to hit the > WARN_ONCE() in set_precision() by adding a crafted "dns_resolver" key: >

Re: [PATCHv2 net 0/2] multicast: init as INCLUDE when join SSM INCLUDE group

2018-07-16 Thread David Miller
From: Hangbin Liu Date: Tue, 10 Jul 2018 22:41:25 +0800 > Based on RFC3376 5.1 and RFC3810 6.1, we should init as INCLUDE when join SSM > INCLUDE group. In my first version I only clear the group change record. But > this is not enough as when a new group join, it will init as EXCLUDE and >

Re: [PATCH v5 net-next 00/18] TLS offload rx, netdev & mlx5

2018-07-16 Thread David Miller
From: Boris Pismenny Date: Fri, 13 Jul 2018 14:33:34 +0300 > The following series provides TLS RX inline crypto offload. Series applied, thanks.

Re: pull-request: bpf-next 2018-07-15

2018-07-14 Thread David Miller
From: Daniel Borkmann Date: Sun, 15 Jul 2018 01:19:49 +0200 > The following pull-request contains BPF updates for your *net-next* tree. > > The main changes are: ... > Please consider pulling these changes from: > > git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git Pulled,

Re: [PATCH net-next 0/4] mlxsw: Add VRRP support

2018-07-14 Thread David Miller
From: Ido Schimmel Date: Sat, 14 Jul 2018 11:39:50 +0300 > When a router that is acting as the default gateway of a host stops > functioning, the host will encounter packet loss until the router starts > functioning again. > > To increase the reliability of the default gateway without

Re: [PATCH net] qlogic: check kstrtoul() for errors

2018-07-13 Thread David Miller
From: Dan Carpenter Date: Thu, 12 Jul 2018 15:23:45 +0300 > We accidentally left out the error handling for kstrtoul(). > > Fixes: a520030e326a ("qlcnic: Implement flash sysfs callback for 83xx > adapter") > Signed-off-by: Dan Carpenter Applied.

Re: [PATCH] of: mdio: Support fixed links in of_phy_get_and_connect()

2018-07-13 Thread David Miller
From: Linus Walleij Date: Wed, 11 Jul 2018 19:45:11 +0200 > By a simple extension of of_phy_get_and_connect() drivers > that have a fixed link on e.g. RGMII can support also > fixed links, so in addition to: > > ethernet-port { > phy-mode = "rgmii"; > phy-handle = <>; > }; > > This

Re: [PATCH net-next] net: sched: refactor flower walk to iterate over idr

2018-07-13 Thread David Miller
From: Vlad Buslov Date: Mon, 9 Jul 2018 13:29:11 +0300 > Extend struct tcf_walker with additional 'cookie' field. It is intended to > be used by classifier walk implementations to continue iteration directly > from particular filter, instead of iterating 'skip' number of times. > > Change

Re: [PATCH v3 net-next 3/3] rds: Extend RDS API for IPv6 support

2018-07-13 Thread David Miller
From: Santosh Shilimkar Date: Fri, 13 Jul 2018 15:00:59 -0700 > Ofcourse any application built using upstream header and > using SO_RDS_TRANSPORT will break but since this particular > option was added for special case(application wants to > upfront select transport instead letting bind figure

Re: [PATCH net-next v6 01/11] net: sched: use rcu for action cookie update

2018-07-13 Thread David Miller
From: Cong Wang Date: Fri, 13 Jul 2018 14:51:15 -0700 > Can we at least agree you have no justification for this change in > this changelog? He stated that he wishes to make this subsystem more lockless, and he cannot do that without making the action cookie handling use RCU. I agree with the

Re: [PATCH v4 net-next 19/19] net/mlx5e: Kconfig, mutually exclude compilation of TLS and IPsec accel

2018-07-13 Thread David Miller
From: Boris Pismenny Date: Fri, 13 Jul 2018 16:03:01 -0400 > We currently have no devices that support both TLS and IPsec using the > accel framework I read this the first time, and this is not what I am objecting to. The compile time limitation is the problem, not the run time limitation. >

Re: pull-request: bpf 2018-07-13

2018-07-13 Thread David Miller
From: Daniel Borkmann Date: Fri, 13 Jul 2018 17:40:58 +0200 > The following pull-request contains BPF updates for your *net* tree. > > The main changes are: > > 1) Fix AF_XDP TX error reporting before final kernel release such that it >becomes consistent between copy mode and zero-copy,

Re: [PATCH net] skbuff: Unconditionally copy pfmemalloc in __skb_clone()

2018-07-13 Thread David Miller
From: Stefano Brivio Date: Fri, 13 Jul 2018 13:21:07 +0200 > Commit 8b7008620b84 ("net: Don't copy pfmemalloc flag in > __copy_skb_header()") introduced a different handling for the > pfmemalloc flag in copy and clone paths. > > In __skb_clone(), now, the flag is set only if it was set in the >

Re: [PATCH v3 net-next 3/3] rds: Extend RDS API for IPv6 support

2018-07-13 Thread David Miller
From: Ka-Cheong Poon Date: Fri, 13 Jul 2018 04:02:59 -0700 > @@ -52,7 +52,7 @@ > #define RDS_RECVERR 5 > #define RDS_CONG_MONITOR 6 > #define RDS_GET_MR_FOR_DEST 7 > -#define SO_RDS_TRANSPORT 8 > +#define SO_RDS_TRANSPORT 9 There

Re: [PATCH net-next] net: ipmr: add support for passing full packet on wrong vif

2018-07-13 Thread David Miller
From: Nikolay Aleksandrov Date: Fri, 13 Jul 2018 12:16:43 +0300 > This patch adds support for IGMPMSG_WRVIFWHOLE which is used to pass > full packet and real vif id when the incoming interface is wrong. > While the RP and FHR are setting up state we need to be sending the > registers

Re: [PATCH v4 net-next 19/19] net/mlx5e: Kconfig, mutually exclude compilation of TLS and IPsec accel

2018-07-12 Thread David Miller
From: Boris Pismenny Date: Thu, 12 Jul 2018 22:25:57 +0300 > We currently have no devices that support both TLS and IPsec using the > accel framework, and the current code does not support both IPsec and > TLS. This patch prevents such combinations. > > Signed-off-by: Boris Pismenny > --- >

Re: [PATCH net-next 5/5 v3] net: gemini: Indicate that we can handle jumboframes

2018-07-12 Thread David Miller
From: Linus Walleij Date: Wed, 11 Jul 2018 21:32:45 +0200 > The hardware supposedly handles frames up to 10236 bytes and > implements .ndo_change_mtu() so accept 10236 minus the ethernet > header for a VLAN tagged frame on the netdevices. Use > ETH_MIN_MTU as minimum MTU. > > Signed-off-by:

Re: [PATCH net-next 1/5 v3] net: gemini: Look up L3 maxlen from table

2018-07-12 Thread David Miller
From: Linus Walleij Date: Wed, 11 Jul 2018 21:32:41 +0200 > The code to calculate the hardware register enumerator > for the maximum L3 length isn't entirely simple to read. > Use the existing defines and rewrite the function into a > table look-up. > > Acked-by: Michał Mirosław >

Re: [PATCH net-next 4/5 v3] net: gemini: Move main init to port

2018-07-12 Thread David Miller
From: Linus Walleij Date: Wed, 11 Jul 2018 21:32:44 +0200 > The initialization sequence for the ethernet, setting up > interrupt routing and such things, need to be done after > both the ports are clocked and reset. Before this the > config will not "take". Move the initialization to the > port

Re: [PATCH net-next 2/5 v3] net: gemini: Improve connection prints

2018-07-12 Thread David Miller
From: Linus Walleij Date: Wed, 11 Jul 2018 21:32:42 +0200 > Switch over to using a module parameter and debug prints > that can be controlled by this or ethtool like everyone > else. Depromote all other prints to debug messages. > > The phy_print_status() was already in place, albeit never >

Re: [PATCH net-next 3/5 v3] net: gemini: Allow multiple ports to instantiate

2018-07-12 Thread David Miller
From: Linus Walleij Date: Wed, 11 Jul 2018 21:32:43 +0200 > The code was not tested with two ports actually in use at > the same time. (I blame this on lack of actual hardware using > that feature.) Now after locating a system using both ports, > add necessary fix to make both ports come up. >

Re: [PATCH net-next v3 00/11] devlink: Add support for region access

2018-07-12 Thread David Miller
From: Alex Vesker Date: Thu, 12 Jul 2018 15:13:07 +0300 > This is a proposal which will allow access to driver defined address > regions using devlink. Each device can create its supported address > regions and register them. A device which exposes a region will allow > access to it using

Re: [PATCH net-next] net: gro: properly remove skb from list

2018-07-12 Thread David Miller
From: Prashant Bhole Date: Thu, 12 Jul 2018 16:24:59 +0900 > Following crash occurs in validate_xmit_skb_list() when same skb is > iterated multiple times in the loop and consume_skb() is called. > > The root cause is calling list_del_init(>list) and not clearing > skb->next in d4546c2509b1.

Re: [PATCH net] nsh: set mac len based on inner packet

2018-07-12 Thread David Miller
From: Willem de Bruijn Date: Wed, 11 Jul 2018 12:00:44 -0400 > From: Willem de Bruijn > > When pulling the NSH header in nsh_gso_segment, set the mac length > based on the encapsulated packet type. > > skb_reset_mac_len computes an offset to the network header, which > here still points to

Re: [PATCH net] packet: reset network header if packet shorter than ll reserved space

2018-07-12 Thread David Miller
From: Willem de Bruijn Date: Wed, 11 Jul 2018 12:00:45 -0400 > From: Willem de Bruijn > > If variable length link layer headers result in a packet shorter > than dev->hard_header_len, reset the network header offset. Else > skb->mac_len may exceed skb->len after skb_mac_reset_len. > >

Re: [PATCH net] selftests: in udpgso_bench do not test udp zerocopy

2018-07-12 Thread David Miller
From: Willem de Bruijn Date: Wed, 11 Jul 2018 12:00:46 -0400 > From: Willem de Bruijn > > The udpgso benchmark compares various configurations of UDP and TCP. > Including one that is not upstream, udp zerocopy. This is a leftover > from the earlier RFC patchset. > > The test is part of

Re: [PATCH net-next 00/10] s390/qeth: updates 2018-07-11

2018-07-12 Thread David Miller
From: Julian Wiedmann Date: Wed, 11 Jul 2018 17:42:37 +0200 > please apply this first batch of qeth patches for net-next. It brings the > usual cleanups, and some performance improvements to the transmit paths. Series applied, thank you.

Re: [net-next PATCH] net: ipv4: fix listify ip_rcv_finish in case of forwarding

2018-07-12 Thread David Miller
From: Jesper Dangaard Brouer Date: Wed, 11 Jul 2018 17:01:20 +0200 > In commit 5fa12739a53d ("net: ipv4: listify ip_rcv_finish") calling > dst_input(skb) was split-out. The ip_sublist_rcv_finish() just calls > dst_input(skb) in a loop. > > The problem is that ip_sublist_rcv_finish() forgot to

Re: [PATCH net] net: Don't copy pfmemalloc flag in __copy_skb_header()

2018-07-12 Thread David Miller
From: Stefano Brivio Date: Wed, 11 Jul 2018 14:39:42 +0200 > The pfmemalloc flag indicates that the skb was allocated from > the PFMEMALLOC reserves, and the flag is currently copied on skb > copy and clone. > > However, an skb copied from an skb flagged with pfmemalloc > wasn't necessarily

Re: [PATCH net-next v2 0/2] net/sched: act_skbedit: lockless data path

2018-07-12 Thread David Miller
From: Davide Caratti Date: Wed, 11 Jul 2018 16:04:48 +0200 > the data path of act_skbedit can be faster if we avoid using spinlocks: > - patch 1 converts act_skbedit statistics to use per-cpu counters > - patch 2 lets act_skbedit use RCU to read/update its configuration > > test procedure

Re: [PATCH net 0/2] sfc: filter locking fixes

2018-07-12 Thread David Miller
From: Bert Kenward Date: Wed, 11 Jul 2018 11:39:39 +0100 > Two fixes for sfc ef10 filter table locking. Initially spotted > by lockdep, but one issue has also been seen in normal use. Series applied, thanks.

Re: [PATCH] tcp: allow user to create repair socket without window probes

2018-07-12 Thread David Miller
From: Stefan Baranoff Date: Tue, 10 Jul 2018 17:31:10 -0400 > Under rare conditions where repair code may be used it is possible that > window probes are either unnecessary or undesired. If the user knows that > window probes are not wanted or needed this change allows them to skip > sending

Re: [PATCH] tcp: fix sequence numbers for repaired sockets re-using TIME-WAIT sockets

2018-07-12 Thread David Miller
From: Stefan Baranoff Date: Tue, 10 Jul 2018 17:25:20 -0400 > This patch fixes a bug where the sequence numbers of a socket created using > TCP repair functionality are lower than set after connect is called. > This occurs when the repair socket overlaps with a TIME-WAIT socket and > triggers

Re: [PATCH net-next] tc-testing: add geneve options in tunnel_key unit tests

2018-07-12 Thread David Miller
From: Jakub Kicinski Date: Tue, 10 Jul 2018 18:22:31 -0700 > From: Pieter Jansen van Vuuren > > Extend tc tunnel_key action unit tests with geneve options. Tests > include testing single and multiple geneve options, as well as > testing geneve options that are expected to fail. > >

Re: [net v2] sch_fq_codel: zero q->flows_cnt when fq_codel_init fails

2018-07-12 Thread David Miller
From: Jacob Keller Date: Tue, 10 Jul 2018 14:22:27 -0700 > When fq_codel_init fails, qdisc_create_dflt will cleanup by using > qdisc_destroy. This function calls the ->reset() op prior to calling the > ->destroy() op. > > Unfortunately, during the failure flow for sch_fq_codel, the ->flows >

Re: [net 0/4][pull request] Intel Wired LAN Driver Updates 2018-07-12

2018-07-12 Thread David Miller
From: Jeff Kirsher Date: Thu, 12 Jul 2018 08:27:52 -0700 > This series contains updates to ixgbe and e100/e1000 kernel documentation. > > Alex fixes ixgbe to ensure that we are more explicit about the ordering > of updates to the receive address register (RAR) table. > > Dan Carpenter fixes an

Re: pull-request: ieee802154 for net 2018-07-11

2018-07-12 Thread David Miller
From: Stefan Schmidt Date: Wed, 11 Jul 2018 11:26:53 -0400 > An update from ieee802154 for your *net* tree. > > Build system fix for a missing include from Arnd Bergmann. > Setting the IFLA_LINK for the lowpan parent from Lubomir Rintel. > Fixes for some RX corner cases in adf7242 driver by

[CLOSED] LPC Plumbers Networking Track

2018-07-12 Thread David Miller
The submission window for the networking track of this years's Linux Plumbers Conference is now officially closed. We are simply overwhelmed by the amount of submissions and the overall quality of the content! Please do not submit any new submissions from this point forward, it will not be

Re: [PATCH net-next v2 0/8] be2net: small structures clean-up

2018-07-12 Thread David Miller
From: Ivan Vecera Date: Tue, 10 Jul 2018 22:59:40 +0200 > The series: > - removes unused / unneccessary fields in several be2net structures > - re-order fields in some structures to eliminate holes, cache-lines > crosses > - as result reduces size of main struct be_adapter by 4kB Series

Re: [PATCH net-next] selftests: forwarding: mirror_gre_nh: Unset rp_filter on host VRF

2018-07-12 Thread David Miller
From: Petr Machata Date: Tue, 10 Jul 2018 14:44:26 +0200 > The mirrored packets arrive at $h3 encapsulated in GRE/IPv4, with IP > address from 192.0.2.128/28 network. However the interface is configured > as a member of 192.0.2.160/28 and there's no route directing traffic > from the former

Re: [PATCH net 2/2] sfp: fix module initialisation with netdev already up

2018-07-12 Thread David Miller
From: Russell King Date: Tue, 10 Jul 2018 12:05:36 +0100 > It was been observed that with a particular order of initialisation, > the netdev can be up, but the SFP module still has its TX_DISABLE > signal asserted. This occurs when the network device brought up before > the SFP kernel module

Re: [PATCH net 1/2] sfp: ensure we clean up properly on bus registration failure

2018-07-12 Thread David Miller
From: Russell King Date: Tue, 10 Jul 2018 12:05:31 +0100 > We fail to correctly clean up after a bus registration failure, which > can lead to an incorrect assumption about the registration state of > the upstream or sfp cage. > > Signed-off-by: Russell King Applied.

Re: [PATCH net-next 0/3] mlxsw: ERSPAN: Take LACP state into consideration

2018-07-12 Thread David Miller
From: Ido Schimmel Date: Tue, 10 Jul 2018 10:02:56 +0300 > Petr says: > > When offloading mirror-to-gretap, mlxsw needs to preroute the path that > the encapsulated packet will take. That path may include a LAG device > above a front panel port. So far, mlxsw resolved the path to the first > up

Re: [PATCH net-next] macvlan: Change status when lower device goes down

2018-07-12 Thread David Miller
From: Travis Brown Date: Tue, 10 Jul 2018 00:35:01 + > Today macvlan ignores the notification when a lower device goes > administratively down, preventing the lack of connectivity from > bubbling up. > > Processing NETDEV_DOWN results in a macvlan state of LOWERLAYERDOWN > with NO-CARRIER

Re: [net-next 0/7][pull request] L2 Fwd Offload & 10GbE Intel Driver Updates 2018-07-09

2018-07-12 Thread David Miller
From: Jeff Kirsher Date: Mon, 9 Jul 2018 15:20:35 -0700 > This patch series is meant to allow support for the L2 forward offload, aka > MACVLAN offload without the need for using ndo_select_queue. > > The existing solution currently requires that we use ndo_select_queue in > the transmit path

Re: [PATCH net-next] tcp: expose both send and receive intervals for rate sample

2018-07-12 Thread David Miller
From: Deepti Raghavan Date: Mon, 9 Jul 2018 17:53:39 + > Congestion control algorithms, which access the rate sample > through the tcp_cong_control function, only have access to the maximum > of the send and receive interval, for cases where the acknowledgment > rate may be inaccurate due

Re: [PATCH net-next] net: sched: fix unprotected access to rcu cookie pointer

2018-07-12 Thread David Miller
From: Vlad Buslov Date: Mon, 9 Jul 2018 20:26:47 +0300 > Fix action attribute size calculation function to take rcu read lock and > access act_cookie pointer with rcu dereference. > > Fixes: eec94fdb0480 ("net: sched: use rcu for action cookie update") > Reported-by: Marcelo Ricardo Leitner >

Re: [PATCH net-next 0/2] cxgb4: move stats fetched from firmware to debugfs

2018-07-12 Thread David Miller
From: Rahul Lakkireddy Date: Mon, 9 Jul 2018 21:42:45 +0530 > Some stats are fetched via slow firmware mailbox, which can cause > packet drops under heavy load. So, this series removes these stats > from ethtool -S and expose them via debugfs. > > Patch 1 removes stats fetched via firmware

Re: [PATCH net-next] net: sched: act_ife: fix memory leak in ife init

2018-07-11 Thread David Miller
From: Vlad Buslov Date: Mon, 9 Jul 2018 14:33:26 +0300 > Free params if tcf_idr_check_alloc() returned error. > > Fixes: 0190c1d452a9 ("net: sched: atomically check-allocate action") > Reported-by: Dan Carpenter > Signed-off-by: Vlad Buslov Applied.

Re: [PATCH net-next] cxgb4: specify IQTYPE in fw_iq_cmd

2018-07-11 Thread David Miller
From: Ganesh Goudar Date: Mon, 9 Jul 2018 16:52:03 +0530 > From: Arjun Vynipadath > > congestion argument passed to t4_sge_alloc_rxq() is used > to differentiate between nic/ofld queues. > > Signed-off-by: Arjun Vynipadath > Signed-off-by: Ganesh Goudar Applied.

Re: [PATCH net v2 0/5] net/ipv6: addr_gen_mode fixes

2018-07-11 Thread David Miller
From: Sabrina Dubroca Date: Mon, 9 Jul 2018 12:25:13 +0200 > This series fixes bugs in handling of the addr_gen_mode option, mainly > related to the sysctl. A minor netlink issue was also present in the > initial commit introducing the option on a per-netdevice basis. > > v2: add patch 4,

Re: [PATCH resend] rhashtable: detect when object movement might have invalidated a lookup

2018-07-11 Thread David Miller
From: David Miller Date: Wed, 11 Jul 2018 22:46:58 -0700 (PDT) > From: NeilBrown > Date: Fri, 06 Jul 2018 17:08:35 +1000 > >> >> Some users of rhashtable might need to change the key >> of an object and move it to a different location in the table. >> O

Re: [PATCH net-next] net/sched: flower: Fix null pointer dereference when run tc vlan command

2018-07-11 Thread David Miller
From: Jianbo Liu Date: Mon, 9 Jul 2018 02:26:20 + > Zahari issued tc vlan command without setting vlan_ethtype, which will > crash kernel. To avoid this, we must check tb[TCA_FLOWER_KEY_VLAN_ETH_TYPE] > is not null before use it. > Also we don't need to dump vlan_ethtype or cvlan_ethtype in

Re: 答复: [PATCH] net: convert gro_count to bitmask

2018-07-11 Thread David Miller
From: "Li,Rongqing" Date: Thu, 12 Jul 2018 03:03:51 + > > >> -邮件原件- >> 发件人: David Miller [mailto:da...@davemloft.net] >> 发送时间: 2018年7月12日 10:49 >> 收件人: Li,Rongqing >> 抄送: netdev@vger.kernel.org >> 主题: Re: [PATCH] net: convert gr

Re: [PATCH] net: convert gro_count to bitmask

2018-07-11 Thread David Miller
From: Li RongQing Date: Wed, 11 Jul 2018 17:15:53 +0800 > + clear_bit(index, >gro_bitmask); Please don't use atomics here, at least use __clear_bit(). This is why I did the operations by hand in my version of the patch. Also, if you are going to preempt my patch, at least retain

Re: [PATCH net-next] selftests: forwarding: mirror_lib: Tighten up VLAN capture

2018-07-10 Thread David Miller
From: Petr Machata Date: Sun, 08 Jul 2018 19:58:55 +0200 > The function do_test_span_vlan_dir_ips() is used for testing whether > mirrored packets are VLAN-encapsulated. But since it only considers > VLAN encapsulation, it may end up matching unmirrored ARP traffic as > well. One consequence is

Re: [PATCH net-next 0/2] net/sched: act_skbedit: lockless data path

2018-07-10 Thread David Miller
From: Davide Caratti Date: Fri, 6 Jul 2018 12:40:12 +0200 > the data path of act_skbedit can be faster if we avoid using spinlocks: > - patch 1 converts act_skbedit statistics to use per-cpu counters > - patch 2 lets act_skbedit use RCU to read/update its configuration This doesn't apply

Re: [PATCH net] ipv4: reset fnhe_mtu_locked after cache route flushed

2018-07-10 Thread David Miller
From: Sabrina Dubroca Date: Tue, 10 Jul 2018 16:00:42 +0200 > Would there be a way to detect this when you apply patches? "there's > no tag above the first '^---', but there are some tags below it", > something like that? Ugh, yeah ping's output format keeps biting us like this, sorry.

<    10   11   12   13   14   15   16   17   18   19   >