Re: [trivial PATCH] treewide: Convert switch/case fallthrough; to break;

2020-09-10 Thread Felipe Balbi
hy-fsl-usb.c | 2 +- for the drivers above: Acked-by: Felipe Balbi -- balbi signature.asc Description: PGP signature

[PATCH 1/2] NET: m_can: split into core library and platform adaptation

2019-09-09 Thread Felipe Balbi
A future patch will add PCI-based m_can driver. This patch makes that a lot simpler. Signed-off-by: Felipe Balbi --- drivers/net/can/m_can/Kconfig | 10 + drivers/net/can/m_can/Makefile | 1 + drivers/net/can/m_can/m_can.c | 707 ++--- drivers

[PATCH 2/2] NET: m_can: add PCI glue driver

2019-09-09 Thread Felipe Balbi
Some intel platforms support an MCAN controller attached to the PCI bus. This minimal driver adds support for those. Signed-off-by: Felipe Balbi --- drivers/net/can/m_can/Kconfig | 7 + drivers/net/can/m_can/Makefile| 1 + drivers/net/can/m_can/m_can_pci.c | 222

Re: [PATCH v2 2/2] PTP: add support for one-shot output

2019-09-05 Thread Felipe Balbi
Hi, Richard Cochran writes: > On Fri, Aug 30, 2019 at 11:00:20AM +0300, Felipe Balbi wrote: >> seems like this should be defined together with the other flags? If >> that's the case, it seems like we would EXTTS and PEROUT masks. > > Yes, let's make the m

Re: [PATCH 12/18] fotg210-udc: remove a bogus dma_sync_single_for_device call

2019-02-11 Thread Felipe Balbi
Hi, Christoph Hellwig writes: > On Fri, Feb 01, 2019 at 05:10:26PM +0100, Christoph Hellwig wrote: >> On Fri, Feb 01, 2019 at 03:19:41PM +0200, Felipe Balbi wrote: >> > Christoph Hellwig writes: >> > >> > > dma_map_single already transfers ownership to

Re: [PATCH 12/18] fotg210-udc: remove a bogus dma_sync_single_for_device call

2019-02-01 Thread Felipe Balbi
Christoph Hellwig writes: > dma_map_single already transfers ownership to the device. > > Signed-off-by: Christoph Hellwig Do you want me to take the USB bits or will you take the entire series? In case you're taking the entire series: Acked-by: Felipe Balbi > --- > dr

Re: [PATCH 13/18] fotg210-udc: pass struct device to DMA API functions

2019-02-01 Thread Felipe Balbi
e you're taking the entire series: Acked-by: Felipe Balbi -- balbi signature.asc Description: PGP signature

Re: [PATCH 1/2] Convert target drivers to use sbitmap

2018-05-15 Thread Felipe Balbi
ff-by: Matthew Wilcox > --- [...] > drivers/usb/gadget/function/f_tcm.c | 8 +++--- for drivers/usb/gadget/function/f_tcm.c Acked-by: Felipe Balbi -- balbi signature.asc Description: PGP signature

Re: [-next PATCH 0/4] sysfs and DEVICE_ATTR_

2017-12-20 Thread Felipe Balbi
Hi, Joe Perches writes: > drivers/usb/phy/phy-tahvo.c| 2 +- Acked-by: Felipe Balbi -- balbi

Re: [PATCH v2 07/15] usb: gadget: configfs: make config_item_type const

2017-10-17 Thread Felipe Balbi
Bhumika Goyal writes: > Make config_item_type structures const as they are either passed to a > function having the argument as const or stored in the const "ci_type" > field of a config_item structure. > > Done using Coccinelle. > > Signed-off-by: Bhumika

Re: [PATCH v2 02/15] usb: gadget: make config_item_type structures const

2017-10-17 Thread Felipe Balbi
patches into a series. I'm assuming this depends on patch 1 of the series. In that case: Acked-by: Felipe Balbi -- balbi signature.asc Description: PGP signature

Re: [PATCH v1] ACPI: Switch to use generic UUID API

2017-05-09 Thread Felipe Balbi
o Sakkinen > Cc: Jani Nikula > Cc: Ben Skeggs > Cc: Benjamin Tissoires > Cc: Joerg Roedel > Cc: Adrian Hunter > Cc: Yisen Zhuang > Cc: Bjorn Helgaas > Cc: Zhang Rui > Cc: Felipe Balbi > Cc: Mathias Nyman > Cc: Heikki Krogerus > Cc: Liam Girdwood > Cc

Re: [PATCH v3 17/20] usb: gadget: pch_udc: Replace PCI pool old API

2017-03-06 Thread Felipe Balbi
Fine by me: Acked-by: Felipe Balbi -- balbi signature.asc Description: PGP signature

Re: [PATCH] Revert "usb: dwc3: gadget: use allocated/queued reqs for LST bit"

2016-11-01 Thread Felipe Balbi
Hi, David Miller writes: > From: Ville Syrjälä > Date: Fri, 28 Oct 2016 19:33:32 +0300 > >> On Fri, Oct 28, 2016 at 01:16:13PM +0300, Felipe Balbi wrote: >>> Yeah, I'm guessing we're gonna need some help from networking folks. The >>> only thing

Re: [PATCH] Revert "usb: dwc3: gadget: use allocated/queued reqs for LST bit"

2016-10-28 Thread Felipe Balbi
Hi, Ville Syrjälä writes: > On Thu, Oct 06, 2016 at 12:08:26PM +0300, Ville Syrjälä wrote: >> On Thu, Oct 06, 2016 at 10:36:09AM +0300, Felipe Balbi wrote: >> > >> > Hi, >> > >> > Felipe Balbi writes: >> >> > Okay,

Re: [PATCH 00/26] constify local structures

2016-09-12 Thread Felipe Balbi
Hi, Jarkko Sakkinen writes: > On Mon, Sep 12, 2016 at 10:54:07AM +0200, Julia Lawall wrote: >> >> >> On Sun, 11 Sep 2016, Jarkko Sakkinen wrote: >> >> > On Sun, Sep 11, 2016 at 03:05:42PM +0200, Julia Lawall wrote: >> > > Constify local structures. >> > > >> > > The semantic patch that makes

Re: [PATCH 00/21] Delete CURRENT_TIME and CURRENT_TIME_SEC macros

2016-06-09 Thread Felipe Balbi
Hi, Deepa Dinamani writes: > drivers/usb/gadget/function/f_fs.c | 2 +- > drivers/usb/gadget/legacy/inode.c | 2 +- for drivers/usb/gadget: Acked-by: Felipe Balbi -- balbi signature.asc Description: PGP signature

Re: [PATCH net-next 4/5] treewide: replace dev->trans_start update with helper

2016-05-04 Thread Felipe Balbi
t; Cc: linux-blueto...@vger.kernel.org > Signed-off-by: Florian Westphal > --- for u_ether.c: Acked-by: Felipe Balbi > diff --git a/drivers/usb/gadget/function/u_ether.c > b/drivers/usb/gadget/function/u_ether.c > index 637809e..a3f7e7c 100644 > --- a/drivers/usb/gadget/fun

Re: [PATCH 18/23] spear13xx_pcie_gadget: use per-attribute show and store methods

2015-10-12 Thread Felipe Balbi
Christoph Hellwig writes: > On Fri, Oct 09, 2015 at 04:05:17PM -0500, Felipe Balbi wrote: >> Pratyush Anand writes: >> >> > On Sat, Oct 3, 2015 at 7:02 PM, Christoph Hellwig wrote: >> >> Signed-off-by: Christoph Hellwig >> > >> > Ack

Re: simplify configfs attributes V2

2015-10-09 Thread Felipe Balbi
scription for >various patches For reference, I'm fine if you guys take all patches through FS tree. Another option is waiting for dependencies to be merged in v4.4, and the gadget changes merge in v4.5, whatever works. Acked-by: Felipe Balbi -- balbi signature.asc Description: PGP signature

Re: [PATCH 02/23] usb-gadget: use per-attribute show and store methods

2015-10-09 Thread Felipe Balbi
Hi, Christoph Hellwig writes: > To simplify the configfs interface and remove boilerplate code that also > causes binary bloat. > > Signed-off-by: Christoph Hellwig > Reviewed-by: Andrzej Pietrasiewicz I suppose this depends on other fs/configfs changes ? -- balbi signature.asc Descriptio

Re: [PATCH 18/23] spear13xx_pcie_gadget: use per-attribute show and store methods

2015-10-09 Thread Felipe Balbi
Pratyush Anand writes: > On Sat, Oct 3, 2015 at 7:02 PM, Christoph Hellwig wrote: >> Signed-off-by: Christoph Hellwig > > Acked-by: Pratyush Anand I don't seem to have the actual patch, care to resend? -- balbi signature.asc Description: PGP signature

Re: [PATCH 02/23] usb-gadget: use per-attribute show and store methods

2015-10-01 Thread Felipe Balbi
Hi, On Mon, Sep 28, 2015 at 03:33:28PM +0200, Christoph Hellwig wrote: > The Subject line is part of the commit log. If you have a useful heh > suggestion for improving the logs please feel free to suggest it. how about explaining why you want per-attribute show/store methods ? -- balbi si

Re: [PATCH 02/23] usb-gadget: use per-attribute show and store methods

2015-09-30 Thread Felipe Balbi
On Wed, Sep 30, 2015 at 12:35:38PM -0400, Tejun Heo wrote: > On Wed, Sep 30, 2015 at 11:32:19AM -0500, Felipe Balbi wrote: > > On Wed, Sep 30, 2015 at 12:20:46PM -0400, Tejun Heo wrote: > > > On Wed, Sep 30, 2015 at 11:19:25AM -0500, Felipe Balbi wrote: > > > > On M

Re: [PATCH 02/23] usb-gadget: use per-attribute show and store methods

2015-09-30 Thread Felipe Balbi
On Wed, Sep 30, 2015 at 12:20:46PM -0400, Tejun Heo wrote: > On Wed, Sep 30, 2015 at 11:19:25AM -0500, Felipe Balbi wrote: > > On Mon, Sep 28, 2015 at 03:35:14PM +0200, Christoph Hellwig wrote: > > > On Sun, Sep 27, 2015 at 10:50:53AM -0500, Felipe Balbi wrote: > > > &

Re: [PATCH 02/23] usb-gadget: use per-attribute show and store methods

2015-09-30 Thread Felipe Balbi
On Mon, Sep 28, 2015 at 03:35:14PM +0200, Christoph Hellwig wrote: > On Sun, Sep 27, 2015 at 10:50:53AM -0500, Felipe Balbi wrote: > > this (and the other helper below) could be macros just fine. > > They could, but they shouldn't. Inlines are always preferable over > func

Re: [PATCH 02/23] usb-gadget: use per-attribute show and store methods

2015-09-27 Thread Felipe Balbi
On Fri, Sep 25, 2015 at 06:49:39AM -0700, Christoph Hellwig wrote: > Signed-off-by: Christoph Hellwig > --- > drivers/usb/gadget/configfs.c | 295 > ++-- > include/linux/usb/gadget_configfs.h | 19 +-- > 2 files changed, 118 insertions(+), 196 deletions(-)

Re: [PATCH 02/23] usb-gadget: use per-attribute show and store methods

2015-09-27 Thread Felipe Balbi
On Fri, Sep 25, 2015 at 06:49:39AM -0700, Christoph Hellwig wrote: > Signed-off-by: Christoph Hellwig I need commit logs for everything. Without commit logs, I can't apply your patches. -- balbi signature.asc Description: PGP signature

Re: [net PATCH 1/1] drivers: net: cpsw: fix disabling of tx interrupt in rx isr

2015-07-08 Thread Felipe Balbi
Hi, On Wed, Jul 08, 2015 at 02:21:27PM +0530, Mugunthan V N wrote: > On Wednesday 08 July 2015 01:08 PM, Felipe Balbi wrote: > > Hi, > > > > On Wed, Jul 08, 2015 at 12:17:46PM +0530, Mugunthan V N wrote: > >> With the below commit, common isr is split into tx

Re: [net PATCH 1/1] drivers: net: cpsw: fix disabling of tx interrupt in rx isr

2015-07-08 Thread Felipe Balbi
Hi, On Wed, Jul 08, 2015 at 12:17:46PM +0530, Mugunthan V N wrote: > With the below commit, common isr is split into tx and rx, but in > rx isr tx interrupt is also disabled. So tx packets are not handled > during rx interrupts and rx napi completion. Fixing by disabling on > rx interrupt in rx is

Re: [PATCH v2] Move the definition of pr_err() into kernel.h

2007-09-11 Thread Felipe Balbi
asier to read and keeps on blank-line only to separate other defines/code-portion Same to all the others -- Best Regards, Felipe Balbi [EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html