ree on that one. I have seen too
many instances over the years where people post patches that use
primitives such as RCU and think that they must be safe because
it compiles with no warnings (and probably even runs).
Cheers,
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Pa
seeing this when I was working on it but never
got around to removing this bogosity.
Thanks,
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send t
r (KTSAN).
>
> Signed-off-by: Dmitry Vyukov <dvyu...@google.com>
Acked-by: Herbert Xu <herb...@gondor.apana.org.au>
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey
On Sun, Sep 20, 2015 at 10:55:21PM -0700, David Miller wrote:
> From: Herbert Xu <herb...@gondor.apana.org.au>
> Date: Fri, 18 Sep 2015 19:16:50 +0800
>
> > The commit c0bb07df7d981e4091432754e30c9c720e2c0c78 ("netlink:
> > Reset portid after netlink_in
ensure that a valid
portid is used.
Fixes: 1f770c0a09da ("netlink: Fix autobind race condition that leads to zero
port ID")
Reported-by: Tejun Heo <t...@kernel.org>
Reported-by: Linus Torvalds <torva...@linux-foundation.org>
Signed-off-by: Herbert Xu <herb...@gondor.apana.or
d once in netlink_bind fixes
a race where two threads that bind the socket at the same time
with different port IDs may both succeed.
Fixes: 1f770c0a09da ("netlink: Fix autobind race condition that leads to zero
port ID")
Reported-by: Tejun Heo <t...@kernel.org>
Reported-by: Linu
that the real portid is only set
after the socket has been successfully hashed.
Fixes: c0bb07df7d98 ("netlink: Reset portid after netlink_insert failure")
Reported-by: Tejun Heo <t...@kernel.org>
Reported-by: Linus Torvalds <torva...@linux-foundation.org>
Signed-off
On Fri, Sep 18, 2015 at 02:36:09PM +0800, Herbert Xu wrote:
>
> But yes there are ordering issues here so I've decided to make
> rhashtable use a new field for its hash instead.
>
> Note that I've dropped the acks as this patch is now substantially
> different.
v3 doesn't ap
t; I think Herbert has an additional patch for this issue. But yes, I
> think should be scheduled for stable. Herbert?
Yes this should be safe for stable, even though the real cause of
the problem is probably the one that Tejun spotted.
Cheers,
--
Email: Herbert Xu <herb...@gondor.apana.org
.
Thanks!
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kerne
ernel.org>
Reported-by: Linus Torvalds <torva...@linux-foundation.org>
Signed-off-by: Herbert Xu <herb...@gondor.apana.org.au>
Reviewed-by: Cong Wang <cw...@twopensource.com>
diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c
index dea9253..42013c5 100644
--- a/
On Thu, Sep 17, 2015 at 11:08:45AM +0800, Herbert Xu wrote:
>
> Good catch! I think your explanation makes perfect sense. Linus
> ran into this previously too after suspend-and-resume.
Unfortunately you can't just postpone the setting of portid because
once you pass it onto r
s
Created 1000 ports
Created 2000 ports
Created 3000 ports
Created 4000 ports
Created 5000 ports
Created 6000 ports
Created 7000 ports
Created 8000 ports
Created 9000 ports
Created 1 ports
Ports successfully created, terminating
...
So what am I missing?
Thanks,
--
Email: Herbert
On Mon, Aug 31, 2015 at 03:35:26PM +0800, Herbert Xu wrote:
>
> I see where the bug came from. Indeed IPv6 does do fragmentation
> but only for tunnel mode. While your patch added a check that also
> affected transport mode. So in addition to the GSO fix we should
> also mak
On Tue, Sep 01, 2015 at 04:51:24PM +0200, Thomas Graf wrote:
>
> 1. The current in-kernel self-test
> 2. bind_netlink.c: https://github.com/tgraf/rhashtable
Thanks, I will try to reproduce this.
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.
fails it is never retried. The only thing that is
retried is the expansion of the table. So I have no idea what
you are talking about.
Cheers,
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.or
f rhashtable is doing
something wrong.
Cheers,
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the
> why retry in background at all?
It should be tried in the background first at 70% and only when
that fails would we hit the 100% case and then we will try it
with GFP_ATOMIC. If that fails then the insertion will fail.
Cheers,
--
Email: Herbert Xu <herb...@gondor.apana.org.a
> which try to insert 50k entries at the same time, I don't think it's
> unlikely that three more entries are inserted before the background
> expansion completes.
Yes but in that case the GFP_ATOMIC allocation should work because
the table is so small anyway.
Cheers,
--
Em
Do you have a test program?
Thanks,
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the
dition to the GSO fix we should
also make the MTU check conditional to tunnel mode.
Cheers,
--
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line &q
effort basis so its failure has nothing to do with
the failure of a subsequent insertion.
The insertion must have tried its own last-ditch synchronous
expansion and only fail if that fails.
Cheers,
--
Email: Herbert Xu herb...@gondor.apana.org.au
Home Page: http://gondor.apana.org.au/~herbert/
PGP
why isn't it needed
for IPv4 as well?
Thanks,
--
Email: Herbert Xu herb...@gondor.apana.org.au
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message
!= 0\))
{ ... return ret; }
|
ret = 0
)
... when != ret = e1
when != ret
*if(...)
{
... when != ret = e2
when forall
return ret;
}
// /smpl
Signed-off-by: Julia Lawall julia.law...@lip6.fr
Acked-by: Herbert Xu herb...@gondor.apana.org.au
This problem exists in net/ipv4
not clear to me that this patch is the root cause of your OOM
problem.
Thanks,
--
Email: Herbert Xu herb...@gondor.apana.org.au
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line unsubscribe
On Fri, Aug 21, 2015 at 03:09:42PM +0800, Huang Ying wrote:
Sorry, my fault. There are OOM for parent commit too, just some dmesg
difference, which I miss understood. Please ignore this report. I
will be more careful next time.
Thanks for the confirmation.
--
Email: Herbert Xu herb
. Thomas?
Cheers,
--
Email: Herbert Xu herb...@gondor.apana.org.au
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More
impossible.
But if we had a WARN_ON_ONCE there then we'll know for sure.
Cheers,
--
Email: Herbert Xu herb...@gondor.apana.org.au
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line unsubscribe netdev
that Linus saw.
Cheers,
--
Email: Herbert Xu herb...@gondor.apana.org.au
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
On Fri, Aug 07, 2015 at 12:26:41AM +0200, Daniel Borkmann wrote:
Reference: http://thread.gmane.org/gmane.linux.network/372676
Reported-by: Linus Torvalds torva...@linux-foundation.org
Signed-off-by: Daniel Borkmann dan...@iogearbox.net
Acked-by: Herbert Xu herb...@gondor.apana.org.au
) ...
Please use something other than ENOMEM as it is already heavily
used in this context. Perhaps EOVERFLOW?
We should probably add a WARN_ON_ONCE in rhashtable_insert_rehash
since two concurrent rehashings indicates something is going
seriously wrong.
Thanks,
--
Email: Herbert Xu herb
the old freed skb.
This patch fixes it by making skb_set_peeked return the new skb
(or the old one if unchanged).
Fixes: 738ac1ebb96d (net: Clone skb before setting peeked flag)
Reported-by: Brenden Blanco bbla...@plumgrid.com
Signed-off-by: Herbert Xu herb...@gondor.apana.org.au
diff --git a/net
error. We must not free the skb as it's still on the
recv queue.
Cheers,
--
Email: Herbert Xu herb...@gondor.apana.org.au
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line unsubscribe netdev
David Laight david.lai...@aculab.com wrote:
In that case, what happens to the receive queue when skb_clone()
takes a copy of the skb - freeing the original one?
The new skb is inserted into the recv queue and replacing the
existing skb.
--
Email: Herbert Xu herb...@gondor.apana.org.au
Home
On Tue, Aug 04, 2015 at 08:30:23AM -0700, Brenden Blanco wrote:
This patch holds good in my testing. Thanks!
Thanks for testing. Let's add a tag for patchwork:
Tested-by: Brenden Blanco bbla...@plumgrid.com
--
Email: Herbert Xu herb...@gondor.apana.org.au
Home Page: http
.
Cheers,
--
Email: Herbert Xu herb...@gondor.apana.org.au
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo info
should not lock up (unless of course we're feeding
it something that's completely bogus).
If we can't figure this out then the safest solution would be
to disable tunnel GRO completely because it's broken as it stands.
Cheers,
--
Email: Herbert Xu herb...@gondor.apana.org.au
Home Page: http
) because it generates packets
that cannot be handled even by our own GSO.
Reported-by: Wolfgang Walter li...@stwm.de
Signed-off-by: Herbert Xu herb...@gondor.apana.org.au
diff --git a/net/ipv6/ip6_offload.c b/net/ipv6/ip6_offload.c
index e893cd1..08b6204 100644
--- a/net/ipv6/ip6_offload.c
+++ b/net/ipv6
On Thu, Jul 16, 2015 at 12:58:45PM +0200, Wolfgang Walter wrote:
Am Donnerstag, 16. Juli 2015, 08:23:50 schrieb Herbert Xu:
On Wed, Jul 15, 2015 at 02:25:59PM +0200, Wolfgang Walter wrote:
Yes. Switching TSO off and leaving GRO on works, too.
OK, could you please try this patch
-
header is 41. It may only looks at those?
I think GRO is actually working fine. Can you show me the output
of ethtool -k eth1? If hardware TSO is enabled can you try disabling
it to see if it helps?
Thanks,
--
Email: Herbert Xu herb...@gondor.apana.org.au
Home Page: http://gondor.apana.org.au
that doesn't know what to do with it.
Fixes: 19424e052fb4 (sit: Add gro callbacks to sit_offload)
Reported-by: Wolfgang Walter li...@stwm.de
Signed-off-by: Herbert Xu herb...@gondor.apana.org.au
diff --git a/net/ipv6/ip6_offload.c b/net/ipv6/ip6_offload.c
index e893cd1..1252eac 100644
--- a/net
)-udp_portaddr_hash accesses.
Signed-off-by: Eric Dumazet eduma...@google.com
Good find! This goes all the way back to 1.3 it seems :)
Acked-by: Herbert Xu herb...@gondor.apana.org.au
--
Email: Herbert Xu herb...@gondor.apana.org.au
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http
then be the thing that you
insert into rhashtable. This means that during rehashing they
get moved atomically.
Cheers,
--
Email: Herbert Xu herb...@gondor.apana.org.au
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from
. For example we may move from a /32 granularity to a
/31 granlarity at the requst of the admin. In that case you can't
just mix the chain from the old table with the new.
Cheers,
--
Email: Herbert Xu herb...@gondor.apana.org.au
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http
to move
previously wildcard entries that are no longer wildcards into the
hash table, or move non-wildcard entries out of the table and into
the wildcard list.
And of course we want to do this without imposing locking on the
reader :)
Cheers,
--
Email: Herbert Xu herb...@gondor.apana.org.au
Home Page
= next_pseudo_random32(khash);
+ }
Note that during a rehash you can encounter the same object multiple
times, does this logic still work in that case?
Cheers,
--
Email: Herbert Xu herb...@gondor.apana.org.au
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au
has no effect.
Can you run some tcpdumps and post the results in the two cases?
Thanks,
--
Email: Herbert Xu herb...@gondor.apana.org.au
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line
on top of rhashtable instead of
inside it.
The memory cost is merely 8 bytes per local port, is it really too
much?
Cheers,
--
Email: Herbert Xu herb...@gondor.apana.org.au
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe
On Mon, Jul 13, 2015 at 04:31:00PM +0800, Herbert Xu wrote:
On Mon, Jul 13, 2015 at 10:28:19AM +0200, Eric Dumazet wrote:
Except that udp checksum are checked outside of spinlock protection.
Good point. I wonder when this got broken. I'll do some digging.
OK looks like I can claim
On Mon, Jul 13, 2015 at 08:01:42PM +0800, Herbert Xu wrote:
PS we seem to no longer use the hardware checksum in case of
CHECKSUM_COMPLETE, I wonder why that is?
Nevermind, it's still there. I was just looking in the wrong place.
--
Email: Herbert Xu herb...@gondor.apana.org.au
Home Page
no longer handles shared
skbs. So either we need to fix the recv path to not touch skbs
without cloning them, or we need to get rid of the use of shared
skbs in netlink.
In fact it looks I introduced the bug way back in
commit a59322be07c964e916d15be3df473fb7ba20c41e
Author: Herbert Xu herb
to double-free.
This patch fixes this by cloning the skb and replacing the skb
in the list when setting skb-peeked.
Fixes: a59322be07c9 ([UDP]: Only increment counter on first peek/recv)
Reported-by: Konstantin Khlebnikov khlebni...@yandex-team.ru
Signed-off-by: Herbert Xu herb...@gondor.apana.org.au
, this patch is not needed if we fix the root
cause.
Thanks,
--
Email: Herbert Xu herb...@gondor.apana.org.au
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message
.
Cheers,
--
Email: Herbert Xu herb...@gondor.apana.org.au
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo
On Mon, Jul 13, 2015 at 10:22:34AM +0200, Eric Dumazet wrote:
It should worry, in case multiple threads are using MSG_PEEK on same udp
socket ;)
That should be fine because we already hold a spinlock on the
queue.
Cheers,
--
Email: Herbert Xu herb...@gondor.apana.org.au
Home Page: http
On Mon, Jul 13, 2015 at 10:28:19AM +0200, Eric Dumazet wrote:
Except that udp checksum are checked outside of spinlock protection.
Good point. I wonder when this got broken. I'll do some digging.
Cheers,
--
Email: Herbert Xu herb...@gondor.apana.org.au
Home Page: http://gondor.apana.org.au
a simpler fix would be to move iter-p = NULL before
the if statement.
Thanks,
--
Email: Herbert Xu herb...@gondor.apana.org.au
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line unsubscribe netdev
eddee5ba (rhashtable: Fix walker behaviour during
rehash) although not explicitly tested.
Fixes: eddee5ba (rhashtable: Fix walker behaviour during rehash)
Signed-off-by: Phil Sutter p...@nwl.cc
Acked-by: Herbert Xu herb...@gondor.apana.org.au
--
Email: Herbert Xu herb...@gondor.apana.org.au
Home
your test to see if this patch makes your problem go
away on the pre-4.0 kernels?
Thanks!
--
Email: Herbert Xu herb...@gondor.apana.org.au
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line
like this is it. Thanks for digging into this!
--
Email: Herbert Xu herb...@gondor.apana.org.au
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message
and IPv6 before enabling it.
However, the benefit of GSO should cancel out the cost of copying
so I was hoping to just enable GSO unconditionally at some point.
Thanks,
--
Email: Herbert Xu herb...@gondor.apana.org.au
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au
will
simply expire and stop without sending more queries.
Suggested-by: Herbert Xu herb...@gondor.apana.org.au
Signed-off-by: Nikolay Aleksandrov niko...@cumulusnetworks.com
Acked-by: Herbert Xu herb...@gondor.apana.org.au
Thanks,
--
Email: Herbert Xu herb...@gondor.apana.org.au
Home Page: http
think
adding it to the place where you were going to place the disable_port
call would be the most obvious.
Thanks,
--
Email: Herbert Xu herb...@gondor.apana.org.au
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from
it in all states different from blocking. Note that when a
port goes in BR_STATE_DISABLED it's not enabled because that is handled
in the beginning of the port list loop.
Signed-off-by: Nikolay Aleksandrov niko...@cumulusnetworks.com
Acked-by: Herbert Xu herb...@gondor.apana.org.au
how about removing br_multicast_enable_port from br_make_forward
and just add it here for both kernel and user-space STP?
Thanks,
--
Email: Herbert Xu herb...@gondor.apana.org.au
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Aleksandrov niko...@cumulusnetworks.com
Fixes: 0909e11758bd (bridge: Add multicast_router sysfs entries)
Acked-by: Herbert Xu herb...@gondor.apana.org.au
--
Email: Herbert Xu herb...@gondor.apana.org.au
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert
))
- hlist_del_init_rcu(p-rlist);
+ hlist_del_init_rcu(p-rlist);
This should work but removing it and readding seems strange.
How about moving the hlist_unhashed test that's currently in
br_multicast_mark_router into br_multicast_add_router instead?
Thanks,
--
Email: Herbert
)
Acked-by: Herbert Xu herb...@gondor.apana.org.au
--
Email: Herbert Xu herb...@gondor.apana.org.au
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message
once every single driver has been converted.
Cheers,
--
Email: Herbert Xu herb...@gondor.apana.org.au
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message
On Thu, Jun 04, 2015 at 03:15:19PM -0700, Tadeusz Struk wrote:
Hi Herbert,
On 05/22/2015 01:30 AM, Herbert Xu wrote:
This patch makes use of the new AEAD interface which uses a single
SG list instead of separate lists for the AD and plain text.
The fact the src and assoc point to the same
?
I just looked up the patchwork entry and it actually says not
applicable which is correct:
https://patchwork.ozlabs.org/patch/473041/
Because the patch only applies to stable and is not needed in either
net or net-next.
Cheers,
--
Email: Herbert Xu herb...@gondor.apana.org.au
Home Page: http
warnings. So better make it an
RCU_INIT_POINTER.
Cheers,
--
Email: Herbert Xu herb...@gondor.apana.org.au
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body
just before it (but only to linux-crypto):
https://www.mail-archive.com/linux-crypto@vger.kernel.org/msg14487.html
Thanks,
--
Email: Herbert Xu herb...@gondor.apana.org.au
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from
and
crypto_aead_decrypt that did the same thing as old_crypt.
Cheers,
--
Email: Herbert Xu herb...@gondor.apana.org.au
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line unsubscribe netdev
interface along with the
old interface.
Note that this patch itself won't be good enough because I have since
removed cryptoff. But it illustrates the amount of code you need.
Cheers,
--
Email: Herbert Xu herb...@gondor.apana.org.au
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http
in that
situation the kernel would interpret the ICMP message as a reduction
in outer MTU and thus resulting in a loop where the MTU keeps
getting smaller.
Cheers,
--
Email: Herbert Xu herb...@gondor.apana.org.au
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert
on this!
--
Email: Herbert Xu herb...@gondor.apana.org.au
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo info
in future wish to support different generation
schemes for a single algorithm.
Cheers,
--
Email: Herbert Xu herb...@gondor.apana.org.au
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line unsubscribe netdev
This patch makes use of the new AEAD interface which uses a single
SG list instead of separate lists for the AD and plain text.
Signed-off-by: Herbert Xu herb...@gondor.apana.org.au
---
net/mac802154/llsec.c | 41 ++---
1 file changed, 14 insertions(+), 27
This patch makes use of the new AEAD interface which uses a single
SG list instead of separate lists for the AD and plain text.
Signed-off-by: Herbert Xu herb...@gondor.apana.org.au
---
crypto/tcrypt.c | 15 +++
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/crypto
This patch adds IV generator information to xfrm_state. This
is currently obtained from our own list of algorithm descriptions.
Signed-off-by: Herbert Xu herb...@gondor.apana.org.au
---
include/net/xfrm.h |1 +
net/key/af_key.c |1 +
net/xfrm/xfrm_user.c | 40
This patch makes use of the new AEAD interface which uses a single
SG list instead of separate lists for the AD and plain text.
Signed-off-by: Herbert Xu herb...@gondor.apana.org.au
---
crypto/testmgr.c | 87 ++-
1 file changed, 48
This patch makes use of the new AEAD interface which uses a single
SG list instead of separate lists for the AD and plain text. The
IV generation is also now carried out through normal AEAD methods.
Signed-off-by: Herbert Xu herb...@gondor.apana.org.au
---
net/ipv6/esp6.c | 200
This patch makes use of the new AEAD interface which uses a single
SG list instead of separate lists for the AD and plain text. The
IV generation is also now carried out through normal AEAD methods.
Signed-off-by: Herbert Xu herb...@gondor.apana.org.au
---
net/ipv4/esp4.c | 200
This patch makes use of the new AEAD interface which uses a single
SG list instead of separate lists for the AD and plain text.
Tested-by: Johannes Berg johan...@sipsolutions.net
Signed-off-by: Herbert Xu herb...@gondor.apana.org.au
---
net/mac80211/aes_ccm.c | 30
. Now this may or may not
trigger the original bug that I was trying to fix but it still
feels unsafe.
So please convince me that it is totally safe to take the TSO
code path with TSO disabled, e.g., when PMTU causes tso_segs
to be greater than one.
Thanks,
--
Email: Herbert Xu herb
, for the case where
skb-len mss.
Acked-by: Herbert Xu herb...@gondor.apana.org.au
Cheers,
--
Email: Herbert Xu herb...@gondor.apana.org.au
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line
tcp_tso_should_defer
instead.
Maybe this is OK but it is far from obvious.
Cheers,
--
Email: Herbert Xu herb...@gondor.apana.org.au
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line unsubscribe netdev
On Wed, May 27, 2015 at 09:38:40AM +0800, Herbert Xu wrote:
Not really. They're not identical. For example, before your
patch a packet greater than MSS with TSO disabled would call
tcp_nagle_test, with your patch it will call tcp_tso_should_defer
instead.
Maybe this is OK but it is far
On Mon, May 25, 2015 at 07:53:41PM +0800, Herbert Xu wrote:
On Mon, May 25, 2015 at 01:50:55PM +0200, Stephan Mueller wrote:
When you have my code local, simply execute libkcapi/test/kcapi -y twice or
three times. That triggered the crash.
Aha that's what I was missing. I'll look
On Tue, May 26, 2015 at 08:39:56AM +0200, Stephan Mueller wrote:
May I also ask where I can find the generated IV when using
rfc4106(gcm(aes))?
You need to use the IV generator, seqniv(rfc4106(gcm(aes)))
Cheers,
--
Email: Herbert Xu herb...@gondor.apana.org.au
Home Page: http
to disable the AEAD
user-space interface in 4.1 so that we have time to fix it properly
for 4.2.
Cheers,
--
Email: Herbert Xu herb...@gondor.apana.org.au
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line
. If and when we
do that we can easily set a default IV generator.
This is all in the patch series that you're responding. So please
actually read it rather than making assumptions :)
Cheers,
--
Email: Herbert Xu herb...@gondor.apana.org.au
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http
: Herbert Xu herb...@gondor.apana.org.au
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
On Tue, May 26, 2015 at 03:38:58PM +0800, Herbert Xu wrote:
On Tue, May 26, 2015 at 09:37:09AM +0200, Stephan Mueller wrote:
- the current IKE implementations use rfc4106(gcm(aes)). They would need to
use seqniv(rfc4106(gcm(aes))) depending on the kernel version. So, we have
a
clear
(i.e. no error), but does not produce the correct encryption that is required.
You mean through the user-space AEAD interface? That's not a problem
because I'm going to disable it for 4.1 :)
Cheers,
--
Email: Herbert Xu herb...@gondor.apana.org.au
Home Page: http://gondor.apana.org.au/~herbert
On Tue, May 26, 2015 at 09:57:51AM +0200, Stephan Mueller wrote:
Ok. Would you look into that one or shall I do that?
I'll reenable it immediately after the patch to convert it to
the new interface is merged.
Cheers,
--
Email: Herbert Xu herb...@gondor.apana.org.au
Home Page: http
,
--
Email: Herbert Xu herb...@gondor.apana.org.au
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
On Mon, May 25, 2015 at 01:50:55PM +0200, Stephan Mueller wrote:
When you have my code local, simply execute libkcapi/test/kcapi -y twice or
three times. That triggered the crash.
Aha that's what I was missing. I'll look into the crash.
Thanks,
--
Email: Herbert Xu herb
On Sat, May 23, 2015 at 08:04:19PM +0200, Stephan Mueller wrote:
Am Freitag, 22. Mai 2015, 16:31:04 schrieb Herbert Xu:
Hi Herbert,
This patch makes use of the new AEAD interface which uses a single
SG list instead of separate lists for the AD and plain text.
After applying your
401 - 500 of 2197 matches
Mail list logo
